[tw] Re: [TW5] For those who wants double click to edit

[Eli Du]

Thank you so much for this! Works great and adds a lot of usability to TW5!

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywiki+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywiki@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywiki/d8c8662d-7a94-4111-9053-fb001a3ba0a8%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[tw] Re: [TW5] For those who wants double click to edit

[Tobias Beer]

Hi Danielo,
 

> It just attach a listener to its parent, it does not do anything itself.
>
 
Argh, these moments when I'm not paying close attention.

Taking a second look, I can see how your widget
attaches an event listener to its parent, the tiddler.
A neat little trick, to work the DOM nonetheless. ^_^

Best wishes,

— tb

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywiki+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywiki@googlegroups.com.
Visit this group at http://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywiki/1e65c819-02f8-4956-8e78-6d8311daba65%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[tw] Re: [TW5] For those who wants double click to edit

[Tobias Beer]

Hi Danielo,

My browser seems to automagically correct it,
but isn't it a problem to just put an opening tag
in a ViewTemplate section and then never close it?

title: $:/plugins/danielo515/2click2edit/ui/ViewTemplate 

tags: $:/tags/ViewTemplate

<$click>

Also, why doesn't this need any...

list-before:

...to make it the first viewtemplate-section being rendered?
When I click on the tagpill for *$:/tags/ViewTemplate*, it is listed last.

Best wishes,

— tb

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywiki+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywiki@googlegroups.com.
Visit this group at http://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywiki/4e79bb5d-53f7-4760-bdb0-ecaa93e53852%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[tw] Re: [TW5] For those who wants double click to edit

[Danielo Rodríguez]

Hello Tobias, 

The widget is not actually an Html element, so it does not behave like a 
regular element. It is wikitext, so it is actually parsed by tiddlywiky and 
inserted into the widget tree, that's why it is not an issue to not close it. 
I'm not sure about the specification and how widgets should be created, 
probably Jeremy can throw some light on this. There is no render before field 
because it does not matter where the plugin is as long as it is a direct child 
of the tiddler node. It just attach a listener to its parent, it does not do 
anything itself. 

Regards

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywiki+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywiki@googlegroups.com.
Visit this group at http://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywiki/f419385f-03b4-4da0-bd21-ad4271aa4649%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [tw] Re: [TW5] For those who wants double click to edit

[Danielo Rodríguez]

>
>
>>
> Within wikitext, both HTML elements and widgets are parsed by the same 
> parse rule:
>
>
> https://github.com/Jermolene/TiddlyWiki5/blob/master/core/modules/parsers/wikiparser/rules/html.js
>
> If the end tag is missing it defaults to the end of the tiddler or macro 
> containing the starting tag.
>
> Personally, it feels more correct to use <$click/>, and close the tag 
> explicitly, to avoid readers thinking that the text has been truncated.
>

Hello Jeremy, thank you very much for the explanation! I'll fix it. 

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywiki+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywiki@googlegroups.com.
Visit this group at http://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywiki/d7eb59b4-f76e-4ca2-a62b-1543ec634d36%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [tw] Re: [TW5] For those who wants double click to edit

[Jeremy Ruston]

Hi Danielo

The widget is not actually an Html element, so it does not behave like a
> regular element. It is wikitext, so it is actually parsed by tiddlywiky and
> inserted into the widget tree, that's why it is not an issue to not close
> it. I'm not sure about the specification and how widgets should be created,
> probably Jeremy can throw some light on this. There is no render before
> field because it does not matter where the plugin is as long as it is a
> direct child of the tiddler node. It just attach a listener to its parent,
> it does not do anything itself.
>

Within wikitext, both HTML elements and widgets are parsed by the same
parse rule:

https://github.com/Jermolene/TiddlyWiki5/blob/master/core/modules/parsers/wikiparser/rules/html.js

If the end tag is missing it defaults to the end of the tiddler or macro
containing the starting tag.

Personally, it feels more correct to use <$click/>, and close the tag
explicitly, to avoid readers thinking that the text has been truncated.

Best wishes

Jeremy.



>
> Regards
>
> --
> You received this message because you are subscribed to the Google Groups
> "TiddlyWiki" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to tiddlywiki+unsubscr...@googlegroups.com.
> To post to this group, send email to tiddlywiki@googlegroups.com.
> Visit this group at http://groups.google.com/group/tiddlywiki.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/tiddlywiki/f419385f-03b4-4da0-bd21-ad4271aa4649%40googlegroups.com
> .
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Jeremy Ruston
mailto:jeremy.rus...@gmail.com

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywiki+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywiki@googlegroups.com.
Visit this group at http://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywiki/CAPKKYJbV%2BizBMAbyKjWbGwu1AKwreO%3DwqQHJqi9ePUx1xmXwHg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

[tw] Re: [TW5] For those who wants double click to edit

[Jon]

Many thanks Danielo - very useful indeed.

I also agree with Mat, that it would be better to keep this behaviour as an 
option rather than make it default so that people can choose what works 
best for them.

Jon

On Thursday, 3 September 2015 03:47:16 UTC+1, Sergio Rolim wrote:
>
> Very good
>
> Em quarta-feira, 2 de setembro de 2015 06:29:10 UTC-3, Danielo Rodríguez 
> escreveu:
>>
>> Hello
>>
>> Since a lot of people wants this, and TW is built by the community for 
>> the community and it should provide what community wants, here is a small 
>> plugin that can calm down your hunger for this feature. 
>>
>> www.danielorodriguez.com/TW5-2click2edit
>>
>> It is a very simple plugin focused on adding one functionality. Once 
>> installed, you have to "refresh" your tw to make it take effect..
>> As plugin claims, it is just a workaround. After TW add this 
>> functionality in core, it will become useless.
>>
>> Hope you enjoy it.
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywiki+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywiki@googlegroups.com.
Visit this group at http://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywiki/6ff56f48-7897-47f6-9298-a5d79a344feb%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[tw] Re: [TW5] For those who wants double click to edit

[Danielo Rodríguez]

El miércoles, 2 de septiembre de 2015, 14:20:25 (UTC+2), Odder escribió:
>
>
> Great!!!
>
> Thank you very much Danielo.
>

Enjoy it! 

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywiki+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywiki@googlegroups.com.
Visit this group at http://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywiki/029789ed-583e-45d3-959d-a91d59945706%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[tw] Re: [TW5] For those who wants double click to edit

[Danielo Rodríguez]

El miércoles, 2 de septiembre de 2015, 14:06:57 (UTC+2), Sylvain Naudin 
escribió:
>
> Hi,
>
> Just installed, tested, and.. approved !!
>
> Thanks for this feature :)
>
>
Very welcome! 

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywiki+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywiki@googlegroups.com.
Visit this group at http://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywiki/ffb5bdb6-5e5c-4b6b-be3b-a8cba440a82f%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [tw] Re: [TW5] For those who wants double click to edit

[Danielo Rodríguez]

El miércoles, 2 de septiembre de 2015, 14:22:04 (UTC+2), Jeremy Ruston 
escribió:
>
> Bravo Daniel, great stuff,
>
> Best wishes
>
> Jeremy
>

It was just two hours work, including Github's repo and publication, so 
nothing big :D

Next step is to provide a UI to deactivate the function. It should be as 
easy as a checkbox that removes the view template tag from the appropriate 
tiddler. 

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywiki+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywiki@googlegroups.com.
Visit this group at http://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywiki/ac038f32-39f6-40a8-bace-dd61e8cb8d4d%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[tw] Re: [TW5] For those who wants double click to edit

[Sergio Rolim]

Very good

Em quarta-feira, 2 de setembro de 2015 06:29:10 UTC-3, Danielo Rodríguez 
escreveu:
>
> Hello
>
> Since a lot of people wants this, and TW is built by the community for the 
> community and it should provide what community wants, here is a small 
> plugin that can calm down your hunger for this feature. 
>
> www.danielorodriguez.com/TW5-2click2edit
>
> It is a very simple plugin focused on adding one functionality. Once 
> installed, you have to "refresh" your tw to make it take effect..
> As plugin claims, it is just a workaround. After TW add this functionality 
> in core, it will become useless.
>
> Hope you enjoy it.
>

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywiki+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywiki@googlegroups.com.
Visit this group at http://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywiki/e5dcee85-36fc-4b97-b41b-e31a0e48190f%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[tw] Re: [TW5] For those who wants double click to edit

[HansWobbe]

Danielo:

Thank you, indeed!

~~ Hans

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywiki+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywiki@googlegroups.com.
Visit this group at http://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywiki/14c99d3e-9d27-48fd-af5b-6821245e6f05%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[tw] Re: [TW5] For those who wants double click to edit

[Mat]

Well done Danielo - but I should also add that I think this feature should 
remain a plugin and not be core. The idea to double click on a document to 
have it change into edit mode is...very strange IMO. (I wish the Sticky 
titlebar feature would work tho so that the edit button is always 
immediately accessible.)

<:-)


On Wednesday, September 2, 2015 at 11:29:10 AM UTC+2, Danielo Rodríguez 
wrote:
>
> Hello
>
> Since a lot of people wants this, and TW is built by the community for the 
> community and it should provide what community wants, here is a small 
> plugin that can calm down your hunger for this feature. 
>
> www.danielorodriguez.com/TW5-2click2edit
>
> It is a very simple plugin focused on adding one functionality. Once 
> installed, you have to "refresh" your tw to make it take effect..
> As plugin claims, it is just a workaround. After TW add this functionality 
> in core, it will become useless.
>
> Hope you enjoy it.
>

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywiki+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywiki@googlegroups.com.
Visit this group at http://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywiki/b49de0bc-b7a1-4e08-a6a0-6e38a5016d19%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[tw] Re: [TW5] For those who wants double click to edit

[Sylvain Naudin]

Hi,

Just installed, tested, and.. approved !!

Thanks for this feature :)

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywiki+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywiki@googlegroups.com.
Visit this group at http://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywiki/079b4ec2-5f79-4bc7-bba5-13c2136661a6%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[tw] Re: [TW5] For those who wants double click to edit

[Odder]

Great!!!

Thank you very much Danielo.

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywiki+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywiki@googlegroups.com.
Visit this group at http://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywiki/1ba2a08f-ac8c-40c0-98fe-5b6664a1466b%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[tw] Re: [TW5] For those who wants double click to edit

[Birthe C]

Hi Danielo,

Thank you so much for this.


Birthe


-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywiki+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywiki@googlegroups.com.
Visit this group at http://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywiki/d700d52f-3e82-4f22-9bd7-c36b1a375368%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [tw] Re: [TW5] For those who wants double click to edit

[Jeremy Ruston]

Bravo Daniel, great stuff,

Best wishes

Jeremy

On Wed, Sep 2, 2015 at 1:20 PM, Odder  wrote:

>
> Great!!!
>
> Thank you very much Danielo.
>
> --
> You received this message because you are subscribed to the Google Groups
> "TiddlyWiki" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to tiddlywiki+unsubscr...@googlegroups.com.
> To post to this group, send email to tiddlywiki@googlegroups.com.
> Visit this group at http://groups.google.com/group/tiddlywiki.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/tiddlywiki/1ba2a08f-ac8c-40c0-98fe-5b6664a1466b%40googlegroups.com
> 
> .
>
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Jeremy Ruston
mailto:jeremy.rus...@gmail.com

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywiki+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywiki@googlegroups.com.
Visit this group at http://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywiki/CAPKKYJZ11hKtkkPtgaa_wXOGhDXAc6YbWgkH0k_9wCXxH-A5GA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.