Re: [Tinycc-devel] tcc coding style question

[Vincent Lefevre]

On 2019-01-24 17:50:39 +, avih wrote:
> While `git blame -w` does skip white spaces changes, not all
> tools/editors use it.

In this case, the user could use an alias "blame = blame -w" in his
git configuration.

> In general, I think it's better to not do style-only changes except
> in lines/functions which are touched for "proper" reasons.

Actually this is not only style. There are technical issues with them.
Spaces at the end of a line can be lost, and tabs are automatically
converted to spaces in some contexts. Thus avoiding tabs and trailing
spaces makes patches more robust (e.g. if they appear on the web).
Moreover, tabs make diffs less readable.

-- 
Vincent Lefèvre  - Web: 
100% accessible validated (X)HTML - Blog: 
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

___
Tinycc-devel mailing list
Tinycc-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/tinycc-devel

Re: [Tinycc-devel] tcc coding style question

[avih]

While `git blame -w` does skip white spaces changes, not all tools/editors use 
it. In general, I think it's better to not do style-only changes except in 
lines/functions which are touched for "proper" reasons.
- avih
 

On Thursday, January 24, 2019 7:20 PM, Christian Jullien  
wrote:
 

 I understand it's a go?

-Original Message-
From: Tinycc-devel [mailto:tinycc-devel-bounces+eligis=orange...@nongnu.org]
On Behalf Of Michael Matz
Sent: jeudi 24 janvier 2019 18:10
To: tinycc-devel@nongnu.org
Subject: Re: [Tinycc-devel] tcc coding style question

Hi,

On Thu, 24 Jan 2019, Vincent Lefevre wrote:

> On 2019-01-24 16:10:03 +, Michael Matz wrote:
> > On Thu, 24 Jan 2019, Christian Jullien wrote:
> > 
> > > Question (to maintainers): do you allow me to fix them all?
> > 
> > Please don't.  It makes git blame unnecessarily hard.
> 
> Doesn't the -w option of "git blame" solve this issue.

Oh, it does, I didn't know about that option.

In that case bulk changes are fine with me.


Ciao,
Michael.

___
Tinycc-devel mailing list
Tinycc-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/tinycc-devel


___
Tinycc-devel mailing list
Tinycc-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/tinycc-devel


   ___
Tinycc-devel mailing list
Tinycc-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/tinycc-devel

Re: [Tinycc-devel] tcc coding style question

[Michael Matz]

Hi,

On Thu, 24 Jan 2019, Christian Jullien wrote:

> I understand it's a go?

>From my perspective, yup :)


Ciao,
Michael.

> 
> -Original Message-
> From: Tinycc-devel [mailto:tinycc-devel-bounces+eligis=orange...@nongnu.org]
> On Behalf Of Michael Matz
> Sent: jeudi 24 janvier 2019 18:10
> To: tinycc-devel@nongnu.org
> Subject: Re: [Tinycc-devel] tcc coding style question
> 
> Hi,
> 
> On Thu, 24 Jan 2019, Vincent Lefevre wrote:
> 
> > On 2019-01-24 16:10:03 +, Michael Matz wrote:
> > > On Thu, 24 Jan 2019, Christian Jullien wrote:
> > > 
> > > > Question (to maintainers): do you allow me to fix them all?
> > > 
> > > Please don't.  It makes git blame unnecessarily hard.
> > 
> > Doesn't the -w option of "git blame" solve this issue.
> 
> Oh, it does, I didn't know about that option.
> 
> In that case bulk changes are fine with me.
> 
> 
> Ciao,
> Michael.
> 
> ___
> Tinycc-devel mailing list
> Tinycc-devel@nongnu.org
> https://lists.nongnu.org/mailman/listinfo/tinycc-devel
> 
> 
> ___
> Tinycc-devel mailing list
> Tinycc-devel@nongnu.org
> https://lists.nongnu.org/mailman/listinfo/tinycc-devel
> 

___
Tinycc-devel mailing list
Tinycc-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/tinycc-devel

Re: [Tinycc-devel] tcc coding style question

[Michael Matz]

Hi,

On Thu, 24 Jan 2019, Christian Jullien wrote:

> Hum! Unrelated question, I'm a big fan of Doxyen which I use on all 
> projects I own, I'm asking if we want start to move to Doxygen for 
> public API. I can make project infrastructure (but of course not 
> associated Doxygen tags).

I personally find Doxygen markup to just clutter sources.  I want the 
source code to be self-contained, including useful comments; the idea of 
post-processing to have useful docu goes counter to that.

It might make sense for libraries, where the public entry points should 
have documentation in a form that's separate from sources (but even there 
I've seen more useless Doxygen "docu" than useful ones), so perhaps it's 
sensible to create such docu for the library parts of TCC.

In any case I think adding infrastructure without also making use of it 
shouldn't be done.  So, if we have someone interested in writing docu for 
the library parts: super, let's add the infrastructure and the docu, 
otherwise let's wait until we do have someone ;)


Ciao,
Michael.

> 
> C
> 
> 
> -Original Message-
> From: Tinycc-devel [mailto:tinycc-devel-bounces+eligis=orange...@nongnu.org]
> On Behalf Of Michael Matz
> Sent: jeudi 24 janvier 2019 17:10
> To: tinycc-devel@nongnu.org
> Subject: Re: [Tinycc-devel] tcc coding style question
> 
> Hi,
> 
> On Thu, 24 Jan 2019, Christian Jullien wrote:
> 
> > Question (to maintainers): do you allow me to fix them all?
> 
> Please don't.  It makes git blame unnecessarily hard.  You can fix style 
> issues when you change the code in question for other reasons.
> 
> (I'm probably responsible for some of the tabs, as other projects I'm 
> working on require tabs at line beginnings)
> 
> 
> Ciao,
> Michael.
> 
> ___
> Tinycc-devel mailing list
> Tinycc-devel@nongnu.org
> https://lists.nongnu.org/mailman/listinfo/tinycc-devel
> 
> 
> ___
> Tinycc-devel mailing list
> Tinycc-devel@nongnu.org
> https://lists.nongnu.org/mailman/listinfo/tinycc-devel
> 

___
Tinycc-devel mailing list
Tinycc-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/tinycc-devel

Re: [Tinycc-devel] tcc coding style question

[Christian Jullien]

I understand it's a go?

-Original Message-
From: Tinycc-devel [mailto:tinycc-devel-bounces+eligis=orange...@nongnu.org]
On Behalf Of Michael Matz
Sent: jeudi 24 janvier 2019 18:10
To: tinycc-devel@nongnu.org
Subject: Re: [Tinycc-devel] tcc coding style question

Hi,

On Thu, 24 Jan 2019, Vincent Lefevre wrote:

> On 2019-01-24 16:10:03 +, Michael Matz wrote:
> > On Thu, 24 Jan 2019, Christian Jullien wrote:
> > 
> > > Question (to maintainers): do you allow me to fix them all?
> > 
> > Please don't.  It makes git blame unnecessarily hard.
> 
> Doesn't the -w option of "git blame" solve this issue.

Oh, it does, I didn't know about that option.

In that case bulk changes are fine with me.


Ciao,
Michael.

___
Tinycc-devel mailing list
Tinycc-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/tinycc-devel


___
Tinycc-devel mailing list
Tinycc-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/tinycc-devel

Re: [Tinycc-devel] tcc coding style question

[Christian Jullien]

For sure, that's why I asked maintainers before doing those gratuitous
changes.
I don't want to be the person to be blamed :o))
I'll do nothing then.

Hum! Unrelated question, I'm a big fan of Doxyen which I use on all projects
I own, I'm asking if we want start to move to Doxygen for public API. I can
make project infrastructure (but of course not associated Doxygen tags). 

C


-Original Message-
From: Tinycc-devel [mailto:tinycc-devel-bounces+eligis=orange...@nongnu.org]
On Behalf Of Michael Matz
Sent: jeudi 24 janvier 2019 17:10
To: tinycc-devel@nongnu.org
Subject: Re: [Tinycc-devel] tcc coding style question

Hi,

On Thu, 24 Jan 2019, Christian Jullien wrote:

> Question (to maintainers): do you allow me to fix them all?

Please don't.  It makes git blame unnecessarily hard.  You can fix style 
issues when you change the code in question for other reasons.

(I'm probably responsible for some of the tabs, as other projects I'm 
working on require tabs at line beginnings)


Ciao,
Michael.

___
Tinycc-devel mailing list
Tinycc-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/tinycc-devel


___
Tinycc-devel mailing list
Tinycc-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/tinycc-devel

Re: [Tinycc-devel] tcc coding style question

[Michael Matz]

Hi,

On Thu, 24 Jan 2019, Vincent Lefevre wrote:

> On 2019-01-24 16:10:03 +, Michael Matz wrote:
> > On Thu, 24 Jan 2019, Christian Jullien wrote:
> > 
> > > Question (to maintainers): do you allow me to fix them all?
> > 
> > Please don't.  It makes git blame unnecessarily hard.
> 
> Doesn't the -w option of "git blame" solve this issue.

Oh, it does, I didn't know about that option.

In that case bulk changes are fine with me.


Ciao,
Michael.

___
Tinycc-devel mailing list
Tinycc-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/tinycc-devel

Re: [Tinycc-devel] tcc coding style question

[Vincent Lefevre]

On 2019-01-24 16:10:03 +, Michael Matz wrote:
> On Thu, 24 Jan 2019, Christian Jullien wrote:
> 
> > Question (to maintainers): do you allow me to fix them all?
> 
> Please don't.  It makes git blame unnecessarily hard.

Doesn't the -w option of "git blame" solve this issue.

-- 
Vincent Lefèvre  - Web: 
100% accessible validated (X)HTML - Blog: 
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

___
Tinycc-devel mailing list
Tinycc-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/tinycc-devel

Re: [Tinycc-devel] tcc coding style question

[Michael Matz]

Hi,

On Thu, 24 Jan 2019, Christian Jullien wrote:

> Question (to maintainers): do you allow me to fix them all?

Please don't.  It makes git blame unnecessarily hard.  You can fix style 
issues when you change the code in question for other reasons.

(I'm probably responsible for some of the tabs, as other projects I'm 
working on require tabs at line beginnings)


Ciao,
Michael.

___
Tinycc-devel mailing list
Tinycc-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/tinycc-devel