Re: [Tinycc-devel] TinyCC in macOS
Hi, On Tue, 28 Mar 2017, Andrei E. Warkentin wrote: > Dear tinycc-devel, > > Found your mailing list today looking for macOS support for TCC. I have > some good news, in the form of a patch that enables '-run' mode and a patch > consisting of clang warning fixes. This should allow for further work to be > done, as in adding proper Mach-O support. > > Don't know the procedures you folks have for doing code reviews, but I've > my own branch (https://github.com/andreiw/tinycc) which I just forked from > the mob one. At the very least, it provides a good way of looking at the > changes. > > https://github.com/andreiw/tinycc/commit/e733d489f015c2e9df3a43e975c82276a4823ee5 > (tcc: early OSX native support) Merge this one. > https://github.com/andreiw/tinycc/commit/302fbde543a5347daa6ee93aa98733260b2e3d29 > (tcc: fixup clang warnings) I think introducing LINE_MACRO_OUTPUT_FORMAT_P10 for the hack of accepting -P10 is not worth it. The cast you had to add for the O() macro in i386-asm.c: I noticed this as well somewhen with clang which doesn't notice that the values in question never overflow. If a cast to int works as well please use that. Otherwise merge it as well. Ciao, Michael. ___ Tinycc-devel mailing list Tinycc-devel@nongnu.org https://lists.nongnu.org/mailman/listinfo/tinycc-devel
Re: [Tinycc-devel] TinyCC in macOS
Hi Michael, tinycc-devel, How does the merge process work for tinycc? Anything you want from my end? A On Tue, Mar 28, 2017 at 12:09 PM, Michael Matz wrote: > Hi, > > On Tue, 28 Mar 2017, Andrei E. Warkentin wrote: > > > Dear tinycc-devel, > > > > Found your mailing list today looking for macOS support for TCC. I have > > some good news, in the form of a patch that enables '-run' mode and a > patch > > consisting of clang warning fixes. This should allow for further work to > be > > done, as in adding proper Mach-O support. > > > > Don't know the procedures you folks have for doing code reviews, but I've > > my own branch (https://github.com/andreiw/tinycc) which I just forked > from > > the mob one. At the very least, it provides a good way of looking at the > > changes. > > > > https://github.com/andreiw/tinycc/commit/e733d489f015c2e9df3a43e975c822 > 76a4823ee5 > > (tcc: early OSX native support) > > Merge this one. > > > https://github.com/andreiw/tinycc/commit/302fbde543a5347daa6ee93aa98733 > 260b2e3d29 > > (tcc: fixup clang warnings) > > I think introducing LINE_MACRO_OUTPUT_FORMAT_P10 for the hack of accepting > -P10 is not worth it. The cast you had to add for the O() macro in > i386-asm.c: I noticed this as well somewhen with clang which doesn't > notice that the values in question never overflow. If a cast to int works > as well please use that. Otherwise merge it as well. > > > Ciao, > Michael. > > ___ > Tinycc-devel mailing list > Tinycc-devel@nongnu.org > https://lists.nongnu.org/mailman/listinfo/tinycc-devel > -- A ___ Tinycc-devel mailing list Tinycc-devel@nongnu.org https://lists.nongnu.org/mailman/listinfo/tinycc-devel
Re: [Tinycc-devel] TinyCC in macOS
Hello, On Thu, 13 Apr 2017, Andrei E. Warkentin wrote: How does the merge process work for tinycc? Anything you want from my end? I used imprecise language. When I said "merge" I meant "push to mob". See http://repo.or.cz/tinycc.git, in particular the section "mob" of the repository readme. (Please rebase your work to current mob before pushing; I'm not sure if non-fast-forwards are even accepted, but just in case to not uglify history too much). Ciao, Michael. ___ Tinycc-devel mailing list Tinycc-devel@nongnu.org https://lists.nongnu.org/mailman/listinfo/tinycc-devel
Re: [Tinycc-devel] TinyCC in macOS
Thank you. I followed the directions on the http://repo.or.cz/tinycc.git website. The three patches have been pushed. A On Sat, Apr 15, 2017 at 8:42 PM, Michael Matz wrote: > Hello, > > On Thu, 13 Apr 2017, Andrei E. Warkentin wrote: > > How does the merge process work for tinycc? Anything you want from my end? >> > > I used imprecise language. When I said "merge" I meant "push to mob". See > http://repo.or.cz/tinycc.git, in particular the section "mob" of the > repository readme. (Please rebase your work to current mob before pushing; > I'm not sure if non-fast-forwards are even accepted, but just in case to > not uglify history too much). > > > > Ciao, > Michael. > > ___ > Tinycc-devel mailing list > Tinycc-devel@nongnu.org > https://lists.nongnu.org/mailman/listinfo/tinycc-devel > -- A ___ Tinycc-devel mailing list Tinycc-devel@nongnu.org https://lists.nongnu.org/mailman/listinfo/tinycc-devel
