Re: [tipc-discussion] [PATCH] tipc: remove nonexisting function from link.h

[Jon Maloy]

Since you say "dangling reference" I looked into  link.c to check if there is a 
function that needs to be declared static.
There isn't, so I would just call it "dangling declaration of removed function" 
or similar to avoid confusion.

Acked-by: jon

///jon


> -Original Message-
> From: Erik Hugne [mailto:erik.hu...@gmail.com]
> Sent: Wednesday, 09 March, 2016 16:03
> To: tipc-discussion@lists.sourceforge.net
> Cc: Richard Alpe; Jon Maloy; Parthasarathy Bhuvaragan; Erik Hugne
> Subject: [PATCH] tipc: remove nonexisting function from link.h
> 
> Kill the dangling reference in link.h to tipc_link_build_bc_sync_msg
> 
> Signed-off-by: Erik Hugne 
> ---
>  net/tipc/link.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/net/tipc/link.h b/net/tipc/link.h
> index 6a94175..0e1acc5 100644
> --- a/net/tipc/link.h
> +++ b/net/tipc/link.h
> @@ -135,8 +135,6 @@ void tipc_link_set_mtu(struct tipc_link *l, int mtu);
>  int tipc_link_mtu(struct tipc_link *l);
>  void tipc_link_bc_ack_rcv(struct tipc_link *l, u16 acked,
> struct sk_buff_head *xmitq);
> -void tipc_link_build_bc_sync_msg(struct tipc_link *l,
> -  struct sk_buff_head *xmitq);
>  void tipc_link_bc_init_rcv(struct tipc_link *l, struct tipc_msg *hdr);
>  void tipc_link_bc_sync_rcv(struct tipc_link *l,   struct tipc_msg *hdr,
>  struct sk_buff_head *xmitq);
> --
> 2.5.0


--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785111=/4140
___
tipc-discussion mailing list
tipc-discussion@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tipc-discussion

[tipc-discussion] [PATCH tipc-discussion v2] tipc: make sure IPv6 header fits in skb headroom

[Richard Alpe]

Expand headroom further in order to be able to fit the larger IPv6
header. Prior to this patch this caused a skb under panic for certain
tipc packets when using IPv6 UDP bearer(s).

Signed-off-by: Richard Alpe 
---
 net/tipc/udp_media.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/tipc/udp_media.c b/net/tipc/udp_media.c
index 49b3c2e..6364cff 100644
--- a/net/tipc/udp_media.c
+++ b/net/tipc/udp_media.c
@@ -53,7 +53,7 @@
 /* IANA assigned UDP port */
 #define UDP_PORT_DEFAULT   6118
 
-#define UDP_MIN_HEADROOM28
+#define UDP_MIN_HEADROOM48
 
 /**
  * struct udp_media_addr - IP/UDP addressing information
-- 
2.1.4


--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785111=/4140
___
tipc-discussion mailing list
tipc-discussion@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tipc-discussion