Re: Where IS mod_webapp ??

[Endre Stølsvik]

On Tue, 20 Nov 2001, Chad Johnson wrote:

| The WebApp Module has a little webpage.  Take a look here.
|
| http://nagoya.apache.org/~pier/

Thanks!

But I'd also like a more "stable" release. How do I get that?

- And this is *WAY* underdocumented!!


| - Original Message -
| From: "Endre Stølsvik" <[EMAIL PROTECTED]>
|
| > I've apparently missed out on something, because where is the mod_webapp
| > for the different OS'es and where is the source (because the one in the
| > tomcat 4.0 "binary tree" for linux is apparently using the wrong api, it
| > should be using EAPI..)
| >
| > I've understood that there is something called j-t-c, but where is their
| > webpage??
| >
| > Thanks a lot.. Getting way too late too sit at work over here..


-- 
Mvh,
Endre


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

test

[yuexiang]

-- 
 ^  ^
 (oo)\___
 (__)\   )\/\
 ||w |
 || ||

Welcome http://192.168.213.203



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-site/docs index.html

[bojan]

bojan   01/11/20 22:14:51

  Modified:docs index.html
  Log:
  Change the order of releases
  
  Revision  ChangesPath
  1.18  +38 -38jakarta-tomcat-site/docs/index.html
  
  Index: index.html
  ===
  RCS file: /home/cvs/jakarta-tomcat-site/docs/index.html,v
  retrieving revision 1.17
  retrieving revision 1.18
  diff -u -r1.17 -r1.18
  --- index.html2001/11/20 20:51:57 1.17
  +++ index.html2001/11/21 06:14:51 1.18
  @@ -150,60 +150,66 @@
   
   
   
  -2.2/1.1
  +2.3/1.2
   
   
   
   
  -3.3
  +4.0.1
   
   
   
   
   
   
  -2.3/1.2
  +2.2/1.1
   
   
   
   
  -4.0.1
  +3.3
   
   
   
   
  +Tomcat 4.0 
implements a new servlet container (called
  +Catalina) that is based on completely new architecture.  The 4.0 release
  +implements the Servlet 2.3 and JSP 1.2
  +specifications.  
   There are several versions of 
Tomcat 3.x currently
   available for download:
   
  -Version 3.3 is the current production quality release for the Servlet 2.2
  -and JSP 1.1 specifications.  Tomcat 3.3 is the latest continuation of the
  -Tomcat 3.x architecture and it is more advanced then 3.2.4, which is the 'old'
  -production quality release.
  +Version 3.3 is the current production quality release for
  +the Servlet 2.2 and JSP 1.1 specifications.  Tomcat 3.3 is the latest
  +continuation of the Tomcat 3.x architecture and it is more advanced then 3.2.4,
  +which is the 'old' production quality release.
   Version 3.2.4 is the 'old' production quality release and is now in
   maintenance only mode.
   Version 3.1.1 is a legacy release.
   
   
  -All Tomcat 3.x releases trace their heritage back to the original Servlet and
  -JSP implementations that Sun donated to the Apache Software Foundation.  The
  -3.x versions all implement the Servlet 2.2 and JSP
  -1.1 specifications.
  +All Tomcat 3.x releases trace their heritage back to the
  +original Servlet and JSP implementations that Sun donated to the Apache
  +Software Foundation.  The 3.x versions all implement the Servlet
  +2.2 and JSP 1.1 specifications.
   
  -Tomcat 4.0 
implements a new servlet container (called
  -Catalina) that is based on completely new architecture.  The 4.0 release
  -implements the Servlet 2.3 and JSP 1.2
  -specifications.  
   The releases are described in 
more detail below to help you determine 
   which one is right for you.  More details about each release can be found in 
   the associated release notes.
  -Tomcat 3.1.x.  
The 3.1 release contained several 
  -improvements over Tomcat 3.0, including servlet reloading, WAR file 
  -support and added connectors for the IIS and Netscape web servers.  The 
  -latest maintenance release, 3.1.1, contained fixes for security problems.  
  -There is no active development ongoing for Tomcat 3.1.x.  Users of Tomcat 
  -3.1 should update to 3.1.1 to close the security holes and they are 
  -strongly encouraged to migrate to the current production release, Tomcat 
  -3.3.
  +Tomcat 4.0.x.  
Tomcat 4.0.1 is the current production
  +quality release.  Tomcat 4.0 is the next generation of Tomcat.  The 4.0 servlet
  +container (Catalina) has been developed from the ground up for flexibility and
  +performance.  Version 4.0 implements the final released versions of the Servlet
  +2.3 and JSP 1.2 specifications.  As required by the specifications, Tomcat 4.0
  +also supports web applications built for the Servlet 2.2 and JSP 1.1
  +specifications with no changes.
  +Tomcat 3.3. 
Version 3.3 is the current production quality
  +release. It continues the refactoring that was begun in version 3.2 and
  +carries it to its logical conclusion.  Version 3.3 provides a much more modular
  +design and allows the servlet container to be customized by adding and removing
  +modules that control the processing of servlet requests.  This version also
  +contains many performance improvements. The future 3.3.1 release continues on
  +the same path with more specific performance and security improvements.
   Tomcat 3.2.x.  
Versi

cvs commit: jakarta-tomcat-site/xdocs index.xml

[bojan]

bojan   01/11/20 22:14:26

  Modified:xdocsindex.xml
  Log:
  Change the order of releases
  
  Revision  ChangesPath
  1.17  +40 -40jakarta-tomcat-site/xdocs/index.xml
  
  Index: index.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-site/xdocs/index.xml,v
  retrieving revision 1.16
  retrieving revision 1.17
  diff -u -r1.16 -r1.17
  --- index.xml 2001/11/20 20:51:38 1.16
  +++ index.xml 2001/11/21 06:14:26 1.17
  @@ -39,54 +39,61 @@
   
   
   
  -  2.2/1.1
  -  3.3
  +  2.3/1.2
  +  4.0.1
   
   
   
  -  2.3/1.2
  -  4.0.1
  +  2.2/1.1
  +  3.3
   
   
   
   
  +Tomcat 4.0 implements a new servlet container (called
  +Catalina) that is based on completely new architecture.  The 4.0 release
  +implements the Servlet 2.3 and JSP 1.2
  +specifications.   
  +
   There are several versions of Tomcat 3.x currently
   available for download:
   
   
  -Version 3.3 is the current production quality release for the Servlet 2.2
  -and JSP 1.1 specifications.  Tomcat 3.3 is the latest continuation of the
  -Tomcat 3.x architecture and it is more advanced then 3.2.4, which is the 'old'
  -production quality release.
  +Version 3.3 is the current production quality release for
  +the Servlet 2.2 and JSP 1.1 specifications.  Tomcat 3.3 is the latest
  +continuation of the Tomcat 3.x architecture and it is more advanced then 3.2.4,
  +which is the 'old' production quality release.
   Version 3.2.4 is the 'old' production quality release and is now in
   maintenance only mode.
   Version 3.1.1 is a legacy release.
   
   
   
  -All Tomcat 3.x releases trace their heritage back to the original Servlet and
  -JSP implementations that Sun donated to the Apache Software Foundation.  The
  -3.x versions all implement the Servlet 2.2 and JSP
  -1.1 specifications.
  +All Tomcat 3.x releases trace their heritage back to the
  +original Servlet and JSP implementations that Sun donated to the Apache
  +Software Foundation.  The 3.x versions all implement the Servlet
  +2.2 and JSP 1.1 specifications.
   
   
  -Tomcat 4.0 implements a new servlet container (called
  -Catalina) that is based on completely new architecture.  The 4.0 release
  -implements the Servlet 2.3 and JSP 1.2
  -specifications.   
  -
   The releases are described in more detail below to help you determine 
   which one is right for you.  More details about each release can be found in 
   the associated release notes. 
   
  -Tomcat 3.1.x.  The 3.1 release contained several 
  -improvements over Tomcat 3.0, including servlet reloading, WAR file 
  -support and added connectors for the IIS and Netscape web servers.  The 
  -latest maintenance release, 3.1.1, contained fixes for security problems.  
  -There is no active development ongoing for Tomcat 3.1.x.  Users of Tomcat 
  -3.1 should update to 3.1.1 to close the security holes and they are 
  -strongly encouraged to migrate to the current production release, Tomcat 
  -3.3. 
  +Tomcat 4.0.x.  Tomcat 4.0.1 is the current production
  +quality release.  Tomcat 4.0 is the next generation of Tomcat.  The 4.0 servlet
  +container (Catalina) has been developed from the ground up for flexibility and
  +performance.  Version 4.0 implements the final released versions of the Servlet
  +2.3 and JSP 1.2 specifications.  As required by the specifications, Tomcat 4.0
  +also supports web applications built for the Servlet 2.2 and JSP 1.1
  +specifications with no changes.
  +
  +Tomcat 3.3. Version 3.3 is the current production quality
  +release. It continues the refactoring that was begun in version 3.2 and
  +carries it to its logical conclusion.  Version 3.3 provides a much more modular
  +design and allows the servlet container to be customized by adding and removing
  +modules that control the processing of servlet requests.  This version also
  +contains many performance improvements. The future 3.3.1 release continues on
  +the same path with more specific performance and security improvements. 
   
   Tomcat 3.2.x.  Version 3.2 added few new features 
   since 3.1; the major effort was a refactoring of the internals to improve 
  @@ -97,22 +104,15 @@
   All users of Tomcat versions prior to 3.2.3 should updgrade as soon as 
   possible.  With the exception of fixes for critical security related bugs, 
   development on the Tomcat 3.2.x branch has stopped. 
  -
  -Tomcat 3.3. Version 3.3 is the current production quality
  -release. It continues the refactoring that was begun in version 3.2 and
  -carries it to its logical conclusion.  Version 3.3 provides a much more modular
  -design and allows the servlet container to be customized by adding and removing
  -modules that control the processing of servlet requests.  This version also
  -contains many performance improvements. The future 3.3.1 release continues on
  -the same path with more specific performance and security improvements. 
   
  -Tomcat 4.0.x

Re: [VOTE] Change the order of releases mentioned on the TC web page

[Bojan Smojver]

Bojan Smojver wrote:
> 
> Tomcat web page (http://jakarta.apache.org/tomcat/) currently lists the
> releases in the order from the oldest to the newest in the description
> section.
> 
> I propose those are listed in the more natural order, from the newest to
> the oldest (i.e. TC 4.0.x, TC 3.3, TC 3.2.x, TC 3.1.x)
> 
> Vote to change the order of releases on the Tomcat web page:
> 
> [ ] +1.  I agree with the proposal and I will help support it.
> [ ] +0.  I agree with the proposal but I will not be able support it.
> [ ] -0.  I don't agree with the proposal but I won't stop it.
> [ ] -1.  I disagree with the proposal and will explain my reasons.
> 
> Bojan

Since there were enough +1 (9) votes and no negatives at all, I'm making
the change. It is simple enough to revert it if there is someone out
there that doesn't agree.

Bojan

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat RELEASE-NOTES-3.3.1.txt

[billbarker]

billbarker01/11/20 20:33:55

  Modified:.RELEASE-NOTES-3.3.1.txt
  Log:
  Update for bug 4948 fix.
  
  Revision  ChangesPath
  1.5   +4 -1  jakarta-tomcat/RELEASE-NOTES-3.3.1.txt
  
  Index: RELEASE-NOTES-3.3.1.txt
  ===
  RCS file: /home/cvs/jakarta-tomcat/RELEASE-NOTES-3.3.1.txt,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- RELEASE-NOTES-3.3.1.txt   2001/11/20 06:39:21 1.4
  +++ RELEASE-NOTES-3.3.1.txt   2001/11/21 04:33:54 1.5
  @@ -3,7 +3,7 @@
Release Notes
=
   
  -$Id: RELEASE-NOTES-3.3.1.txt,v 1.4 2001/11/20 06:39:21 billbarker Exp $
  +$Id: RELEASE-NOTES-3.3.1.txt,v 1.5 2001/11/21 04:33:54 billbarker Exp $
   
   
   This document describes the changes that have been made since the
  @@ -67,6 +67,9 @@
   4955  Fixed bug in the parsing of the query string to 
 RequestDispatcher.include/forward wasn't handling the case where only
 the parameter name was specified.
  +
  +4948  Fix DependClassLoader to be a Java2 ClassLoader when running under
  +  a Java2 JVM.  
   
   Configuration:
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 4948] - Class.getPackage() returns null in classes loaded by webapp class loader

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4948

Class.getPackage() returns null in classes loaded by webapp class loader

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2001-11-20 19:19 ---
I've checked your patch into the CVS.
Thank you for your contribution!

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/depend DependClassLoader12.java

[billbarker]

billbarker01/11/20 19:02:27

  Modified:src/share/org/apache/tomcat/util/depend
DependClassLoader12.java
  Log:
  Teaches the DependClassLoader how to define packages for Java2
  
  Fix for bug #4948
  Reported By: Joel Bartley [EMAIL PROTECTED]
  Submitted By: Joel Bartley [EMAIL PROTECTED]
  
  Revision  ChangesPath
  1.5   +52 -1 
jakarta-tomcat/src/share/org/apache/tomcat/util/depend/DependClassLoader12.java
  
  Index: DependClassLoader12.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/util/depend/DependClassLoader12.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- DependClassLoader12.java  2001/09/29 04:37:42 1.4
  +++ DependClassLoader12.java  2001/11/21 03:02:27 1.5
  @@ -60,6 +60,7 @@
   import java.net.*;
   import java.text.*;
   import java.util.*;
  +import java.util.jar.*;
   import java.util.zip.*;
   import java.security.*;
   
  @@ -107,6 +108,56 @@
//  PermissionCollection perms=Policy.getPolicy().getPermissions(cs);
//  ProtectionDomain pd=new ProtectionDomain( cs,perms);
//  System.out.println("XXX " + name + ": " + cs + "\n" + perms );
  - return defineClass(name, data, s, end, (ProtectionDomain)pd);
  +int idx = name.lastIndexOf(".");
  +String pkgname = idx != -1 ? name.substring(0, idx) : null;
  +if ( pkgname != null ) {
  +  Package p = getPackage(pkgname);
  +  if ( p == null ) {
  +if ( "jar".equals(res.getProtocol()) ) {
  +  try {
  +JarURLConnection juconn = 
  +  (JarURLConnection)res.openConnection();
  +Manifest mf = juconn.getManifest();
  + if(mf == null) // Jar may not be Java2
  +throw new IOException("No Manifest");
  +Attributes main = mf.getMainAttributes();
  +Attributes pkg = mf.getAttributes(
  +  pkgname.replace('.', '/').concat("/")
  +);
  +boolean sealed = Boolean.getBoolean(
  +  getAttribute(Attributes.Name.SEALED, main, pkg)
  +);
  +definePackage(
  +  pkgname, 
  +  getAttribute(Attributes.Name.SPECIFICATION_TITLE, main, pkg),
  +  getAttribute(Attributes.Name.SPECIFICATION_VERSION, main, pkg),
  +  getAttribute(Attributes.Name.SPECIFICATION_VENDOR, main, pkg),
  +  getAttribute(Attributes.Name.IMPLEMENTATION_TITLE, main, pkg),
  +  getAttribute(Attributes.Name.IMPLEMENTATION_VERSION, main, pkg),
  +  getAttribute(Attributes.Name.IMPLEMENTATION_VENDOR, main, pkg),
  +  sealed ? res : null
  +);
  +  } catch ( IOException e ) {
  +definePackage(pkgname, null, null, null, null, null, null, null);
  +  }
  +} else {
  +  definePackage(pkgname, null, null, null, null, null, null, null);
  +}
  +  }
  +}
  + return defineClass(name, data, s, end, (ProtectionDomain)pd);
   }
  +
  +private String getAttribute(Attributes.Name key, Attributes main, Attributes 
pkg)
  +{
  +  String value = null;
  +  if ( pkg != null ) {
  +value = (String)pkg.get(key);
  +  }
  +  if ( value == null ) {
  +value = (String)main.get(key);
  +  }
  +  return value;
  + }
  +
   }
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 4940] - Reserved words are accepted as taglib prefixes

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4940

Reserved words are accepted as taglib prefixes

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2001-11-20 18:26 ---
Fixed in nightly build 20011121

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/resources messages.properties messages_es.properties messages_ja.properties

[kinman]

kinman  01/11/20 18:09:55

  Modified:jasper/src/share/org/apache/jasper/compiler Tag:
tomcat_40_branch Parser.java
   jasper/src/share/org/apache/jasper/resources Tag:
tomcat_40_branch messages.properties
messages_es.properties messages_ja.properties
  Log:
  PR: 4940
  
  -- Issue error if reserved taglib prefixes are used in taglib directives.
  
  Revision  ChangesPath
  No   revision
  
  
  No   revision
  
  
  1.13.2.3  +14 -2 
jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/Parser.java
  
  Index: Parser.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/Parser.java,v
  retrieving revision 1.13.2.2
  retrieving revision 1.13.2.3
  diff -u -r1.13.2.2 -r1.13.2.3
  --- Parser.java   2001/10/03 19:26:47 1.13.2.2
  +++ Parser.java   2001/11/21 02:09:55 1.13.2.3
  @@ -187,6 +187,10 @@
new JspUtil.ValidAttribute ("prefix", true)
};
   
  + private static final String[] reservedPrefixes = {
  + "jsp", "jspx", "java", "javax", "servlet", "sun", "sunw"
  + };
  +
public boolean accept(ParseEventListener listener, JspReader reader, 
  Parser parser) throws JasperException
{
  @@ -224,10 +228,18 @@
else if (match.equals("include"))
JspUtil.checkAttributes ("Include directive", attrs, 
 includeDvalidAttrs, start);
  - else if (match.equals("taglib"))
  + else if (match.equals("taglib")) {
JspUtil.checkAttributes ("Taglib directive", attrs, 
 tagDvalidAttrs, start);
  - 
  + String prefix = attrs.getValue("prefix");
  + for (int i = 0; i < reservedPrefixes.length; i++) {
  + if (prefix.equals(reservedPrefixes[i]))
  + throw new ParseException(reader.mark(),
  + Constants.getString("jsp.error.taglib.reserved.prefix",
  + new Object[] { prefix }));
  + }
  + }
  +
// Match close.
reader.skipSpaces();
if (!reader.matches(close))
  
  
  
  No   revision
  
  
  No   revision
  
  
  1.20.2.2  +2 -1  
jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/resources/messages.properties
  
  Index: messages.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/resources/messages.properties,v
  retrieving revision 1.20.2.1
  retrieving revision 1.20.2.2
  diff -u -r1.20.2.1 -r1.20.2.2
  --- messages.properties   2001/10/03 22:00:34 1.20.2.1
  +++ messages.properties   2001/11/21 02:09:55 1.20.2.2
  @@ -1,4 +1,4 @@
  -# $Id: messages.properties,v 1.20.2.1 2001/10/03 22:00:34 kinman Exp $
  +# $Id: messages.properties,v 1.20.2.2 2001/11/21 02:09:55 kinman Exp $
   #
   # Default localized string information
   # Localized this the Default Locale as is en_US
  @@ -236,6 +236,7 @@
   jspx.error.templateDataNotInJspCdata=Validation Error: Element <{0}> cannot 
have template data. Template data must be encapsulated within a  
element. [JSP1.2 PFD section 5.1.9]\nTemplate data in error: {1}
   #Error while processing taglib jar file {0}: {1}
   jsp.error.taglib.jarFileException=
  +jsp.error.taglib.reserved.prefix=The taglib prefix {0} is reserved
   jsp.error.invalid.javaEncoding=Invalid java encodings. Tried {0} and then {1}. Both 
failed.
   jsp.error.needAlternateJavaEncoding=Default java encoding {0} is invalid on your 
java platform. An alternate can be specified via the 'javaEncoding' parameter of 
JspServlet.
   #Error when compiling, used for jsp line number error messages
  
  
  
  1.8.2.1   +2 -1  
jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/resources/messages_es.properties
  
  Index: messages_es.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/resources/messages_es.properties,v
  retrieving revision 1.8
  retrieving revision 1.8.2.1
  diff -u -r1.8 -r1.8.2.1
  --- messages_es.properties2001/09/07 17:57:46 1.8
  +++ messages_es.properties2001/11/21 02:09:55 1.8.2.1
  @@ -1,4 +1,4 @@
  -# $Id: messages_es.properties,v 1.8 2001/09/07 17:57:46 craigmcc Exp $
  +# $Id: messages_es.properties,v 1.8.2.1 2001/11/21 02:09:55 kinman Exp $
   #
   # Default localized string information
   # Localized para Locale es_ES
  @@ -194,6 +194,7 @@
   jsp.error.library.invalid=
   jsp.warning.tlvclass.is.null=No se puedee cargar la clase TagLibraryValidator 
llama

cvs commit: jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/resources messages.properties messages_es.properties messages_ja.properties

[kinman]

kinman  01/11/20 17:57:19

  Modified:jasper/src/share/org/apache/jasper/compiler Parser.java
   jasper/src/share/org/apache/jasper/resources
messages.properties messages_es.properties
messages_ja.properties
  Log:
  PR: 4940
  
  -- Issue error if reserved taglib prefixes are used in taglib directives.
  
  Revision  ChangesPath
  1.17  +13 -1 
jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/Parser.java
  
  Index: Parser.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/Parser.java,v
  retrieving revision 1.16
  retrieving revision 1.17
  diff -u -r1.16 -r1.17
  --- Parser.java   2001/10/19 01:42:36 1.16
  +++ Parser.java   2001/11/21 01:57:19 1.17
  @@ -187,6 +187,10 @@
new JspUtil.ValidAttribute ("prefix", true)
};
   
  + private static final String[] reservedPrefixes = {
  + "jsp", "jspx", "java", "javax", "servlet", "sun", "sunw"
  + };
  +
public boolean accept(ParseEventListener listener, JspReader reader, 
  Parser parser) throws JasperException
{
  @@ -224,9 +228,17 @@
else if (match.equals("include"))
JspUtil.checkAttributes ("Include directive", attrs, 
 includeDvalidAttrs, start);
  - else if (match.equals("taglib"))
  + else if (match.equals("taglib")) {
JspUtil.checkAttributes ("Taglib directive", attrs, 
 tagDvalidAttrs, start);
  + String prefix = attrs.getValue("prefix");
  + for (int i = 0; i < reservedPrefixes.length; i++) {
  + if (prefix.equals(reservedPrefixes[i]))
  + throw new ParseException(reader.mark(),
  + Constants.getString("jsp.error.taglib.reserved.prefix",
  + new Object[] { prefix }));
  + }
  + }

// Match close.
reader.skipSpaces();
  
  
  
  1.22  +2 -1  
jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/resources/messages.properties
  
  Index: messages.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/resources/messages.properties,v
  retrieving revision 1.21
  retrieving revision 1.22
  diff -u -r1.21 -r1.22
  --- messages.properties   2001/10/03 21:48:30 1.21
  +++ messages.properties   2001/11/21 01:57:19 1.22
  @@ -1,4 +1,4 @@
  -# $Id: messages.properties,v 1.21 2001/10/03 21:48:30 kinman Exp $
  +# $Id: messages.properties,v 1.22 2001/11/21 01:57:19 kinman Exp $
   #
   # Default localized string information
   # Localized this the Default Locale as is en_US
  @@ -236,6 +236,7 @@
   jspx.error.templateDataNotInJspCdata=Validation Error: Element <{0}> cannot 
have template data. Template data must be encapsulated within a  
element. [JSP1.2 PFD section 5.1.9]\nTemplate data in error: {1}
   #Error while processing taglib jar file {0}: {1}
   jsp.error.taglib.jarFileException=
  +jsp.error.taglib.reserved.prefix=The taglib prefix {0} is reserved
   jsp.error.invalid.javaEncoding=Invalid java encodings. Tried {0} and then {1}. Both 
failed.
   jsp.error.needAlternateJavaEncoding=Default java encoding {0} is invalid on your 
java platform. An alternate can be specified via the 'javaEncoding' parameter of 
JspServlet.
   #Error when compiling, used for jsp line number error messages
  
  
  
  1.9   +2 -1  
jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/resources/messages_es.properties
  
  Index: messages_es.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/resources/messages_es.properties,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- messages_es.properties2001/09/07 17:57:46 1.8
  +++ messages_es.properties2001/11/21 01:57:19 1.9
  @@ -1,4 +1,4 @@
  -# $Id: messages_es.properties,v 1.8 2001/09/07 17:57:46 craigmcc Exp $
  +# $Id: messages_es.properties,v 1.9 2001/11/21 01:57:19 kinman Exp $
   #
   # Default localized string information
   # Localized para Locale es_ES
  @@ -194,6 +194,7 @@
   jsp.error.library.invalid=
   jsp.warning.tlvclass.is.null=No se puedee cargar la clase TagLibraryValidator 
llamada {0}: {1}
   jsp.error.taglibraryvalidator.invalidpage=
  +jsp.error.taglib.reserved.prefix=
   jsp.parser.sax.propertynotsupported=
   jsp.parser.sax.propertynotrecognized=
   jsp.parser.sax.featurenotsupported=
  
  
  
  1.5   +2 -1  
jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/resources/messages_ja.properties
  

cvs commit: jakarta-tomcat-4.0/webapps/admin index.jsp

[patrickl]

patrickl01/11/20 17:12:08

  Modified:webapps/admin index.jsp
  Log:
  Enhancements to the tree renderer to make it more "pluggable"
  Submitted by: Jazmin Jonson
  
  Revision  ChangesPath
  1.6   +1 -1  jakarta-tomcat-4.0/webapps/admin/index.jsp
  
  Index: index.jsp
  ===
  RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/admin/index.jsp,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- index.jsp 2001/11/17 21:20:54 1.5
  +++ index.jsp 2001/11/21 01:12:08 1.6
  @@ -16,7 +16,7 @@
   
 
 
  -
  +
   
 
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin SetUpTreeAction.java TreeBuilder.java TreeControlTestListener.java

[patrickl]

patrickl01/11/20 17:10:09

  Modified:webapps/admin/WEB-INF struts-config.xml web.xml
  Added:   webapps/admin/WEB-INF/classes/org/apache/webapp/admin
SetUpTreeAction.java TreeBuilder.java
  Removed: webapps/admin/WEB-INF/classes/org/apache/webapp/admin
TreeControlTestListener.java
  Log:
  Enhancements to the tree renderer to make it more "pluggable"
  Submitted by: Jazmin Jonson
  
  Revision  ChangesPath
  1.8   +8 -0  jakarta-tomcat-4.0/webapps/admin/WEB-INF/struts-config.xml
  
  Index: struts-config.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/struts-config.xml,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- struts-config.xml 2001/11/18 17:17:08 1.7
  +++ struts-config.xml 2001/11/21 01:10:09 1.8
  @@ -65,6 +65,14 @@
   
   
  +
  +
  +  
  +
  +
   
   
  
  
  
  1.5   +0 -11 jakarta-tomcat-4.0/webapps/admin/WEB-INF/web.xml
  
  Index: web.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/web.xml,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- web.xml   2001/11/18 21:09:12 1.4
  +++ web.xml   2001/11/21 01:10:09 1.5
  @@ -6,13 +6,6 @@
   
   
   
  -  
  -  
  -
  -  org.apache.webapp.admin.TreeControlTestListener
  -
  -  
  -
 
 
   action
  @@ -48,10 +41,6 @@
   
 validate
 true
  -
  -
  -  treebuilders
  -  org.apache.webapp.admin.TomcatTreeBuilder
   
   2
 
  
  
  
  1.1  
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/SetUpTreeAction.java
  
  Index: SetUpTreeAction.java
  ===
  /*
   * $Header: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/SetUpTreeAction.java,v
 1.1 2001/11/21 01:10:09 patrickl Exp $
   * $Revision: 1.1 $
   * $Date: 2001/11/21 01:10:09 $
   *
   * 
   *
   * The Apache Software License, Version 1.1
   *
   * Copyright (c) 2001 The Apache Software Foundation.  All rights
   * reserved.
   *
   * Redistribution and use in source and binary forms, with or without
   * modification, are permitted provided that the following conditions
   * are met:
   *
   * 1. Redistributions of source code must retain the above copyright
   *notice, this list of conditions and the following disclaimer.
   *
   * 2. Redistributions in binary form must reproduce the above copyright
   *notice, this list of conditions and the following disclaimer in
   *the documentation and/or other materials provided with the
   *distribution.
   *
   * 3. The end-user documentation included with the redistribution, if
   *any, must include the following acknowlegement:
   *   "This product includes software developed by the
   *Apache Software Foundation (http://www.apache.org/)."
   *Alternately, this acknowlegement may appear in the software itself,
   *if and wherever such third-party acknowlegements normally appear.
   *
   * 4. The names "The Jakarta Project", "Tomcat", and "Apache Software
   *Foundation" must not be used to endorse or promote products derived
   *from this software without prior written permission. For written
   *permission, please contact [EMAIL PROTECTED]
   *
   * 5. Products derived from this software may not be called "Apache"
   *nor may "Apache" appear in their names without prior written
   *permission of the Apache Group.
   *
   * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
   * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
   * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
   * DISCLAIMED.  IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
   * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
   * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
   * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
   * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
   * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
   * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
   * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
   * SUCH DAMAGE.
   * 
   *
   * This software consists of voluntary contributions made by many
   * individuals on behalf of the Apache Software Foundation.  For more
   * information on the Apache Software Foundation, please see
   * .
   *
   */
  
  
  package org.apache.webapp.admin;
  

DO NOT REPLY [Bug 4959] - jasper error if the jsp name is only formed by numbers

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4959

jasper error if the jsp name is only formed by numbers

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2001-11-20 17:03 ---
Fixed previously.

*** This bug has been marked as a duplicate of 3892 ***

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 3845] - Body content is supposed to be empty

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=3845

Body content is supposed to be empty

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2001-11-20 16:56 ---
*** Bug 4918 has been marked as a duplicate of this bug. ***

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 4918] - Jasper barfs on empty tags in start tag-end tag form

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4918

Jasper barfs on empty tags in start tag-end tag form

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2001-11-20 16:56 ---
This bug is a duplicate of 3845 and was fixed in both the tomcat_40 branch and
head branch.

*** This bug has been marked as a duplicate of 3845 ***

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 4990] New: - Allow a flag to the standard manager to specify sessions should be serialized or not

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4990

Allow a flag to the standard manager to specify sessions should be serialized or not

   Summary: Allow a flag to the standard manager to specify sessions
should be serialized or not
   Product: Tomcat 4
   Version: 4.0.1 Final
  Platform: Other
OS/Version: Linux
Status: NEW
  Severity: Enhancement
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


It would be nice to have a boolean flag (true/false) for the session manager to 
explicitly request session persistence.  A typical usage we have is storing 
Torque objects in the sessions.  These objects implement java.io.Serializable 
but cause all kinds of problems when read from the SESSIONS.ser file when the 
Torque infrastructure is not initialized.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-connectors/jk/native/common jk_endpoint.h jk_worker.c jk_worker.h jk_service.h

[costin]

costin  01/11/20 16:15:16

  Modified:jk/native/common jk_worker.c jk_worker.h jk_service.h
  Added:   jk/native/common jk_endpoint.h
  Log:
  Moved the worker declaration in jk_worker.h, the endpoint in jk_endpoint.h.
  
  This is supposed to make things easier to find and more consistent. Each
  'type' is defined in jk_type.h.
  
  jk_worker_env is a problem - I think this ( and all other 'global' jk properties )
  belong in jk_env.h.
  
  Another issue is jk_util.c - which contains the logger and some worker-related
  property access methods.
  
  All this is 'cosmetic', the behavior of the code is the same.
  
  Revision  ChangesPath
  1.10  +2 -16 jakarta-tomcat-connectors/jk/native/common/jk_worker.c
  
  Index: jk_worker.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_worker.c,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- jk_worker.c   2001/11/16 22:59:06 1.9
  +++ jk_worker.c   2001/11/21 00:15:15 1.10
  @@ -60,7 +60,7 @@
* Description: Workers controller *
* Author:  Gal Shachor <[EMAIL PROTECTED]>   *
* Author:  Henri Gomez <[EMAIL PROTECTED]>   *
  - * Version: $Revision: 1.9 $   *
  + * Version: $Revision: 1.10 $   *
***/
   
   /* #define _PLACE_WORKER_LIST_HERE */
  @@ -191,7 +191,7 @@
   }
   
   *rc = w;
  -jk_log(l, JK_LOG_DEBUG, "wc_create_worker, done\n"); 
  +   jk_log(l, JK_LOG_DEBUG, "wc_create_worker, done\n"); 
   return JK_TRUE;
   }
   
  @@ -257,17 +257,3 @@
   jk_log(l, JK_LOG_DEBUG, "build_worker_map, done\n"); 
   return JK_TRUE;
   }
  -
  -/* static worker_factory get_factory_for(char *type) */
  -/* { */
  -/* worker_factory_record_t *factory = &worker_factories[0]; */
  -/* while(factory->name) { */
  -/* if(0 == strcmp(factory->name, type)) { */
  -/* return factory->fac; */
  -/* } */
  -
  -/* factory ++; */
  -/* } */
  -
  -/* return NULL; */
  -/* } */
  
  
  
  1.6   +125 -3jakarta-tomcat-connectors/jk/native/common/jk_worker.h
  
  Index: jk_worker.h
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_worker.h,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- jk_worker.h   2001/06/18 14:16:16 1.5
  +++ jk_worker.h   2001/11/21 00:15:15 1.6
  @@ -58,7 +58,7 @@
   /***
* Description: Workers controller header file *
* Author:  Gal Shachor <[EMAIL PROTECTED]>   * 
  - * Version: $Revision: 1.5 $   *
  + * Version: $Revision: 1.6 $   *
***/
   
   #ifndef JK_WORKER_H
  @@ -66,6 +66,7 @@
   
   #include "jk_logger.h"
   #include "jk_service.h"
  +#include "jk_endpoint.h"
   #include "jk_map.h"
   #include "jk_uri_worker_map.h"
   
  @@ -73,8 +74,129 @@
   extern "C" {
   #endif /* __cplusplus */
   
  +struct jk_worker;
  +struct jk_endpoint;
  +struct jk_worker_env;
  +typedef struct jk_worker jk_worker_t;
  +
  +/*
  + * The worker 'class', which represents something to which the web server
  + * can delegate requests. 
  + *
  + * This can mean communicating with a particular servlet engine instance,
  + * using a particular protocol.  A single web server instance may have
  + * multiple workers communicating with a single servlet engine (it could be
  + * using ajp12 for some requests and ajp13/ajp14 for others).  Or, a single web
  + * server instance could have multiple workers communicating with different
  + * servlet engines using the same protocol (it could be load balancing
  + * among many engines, using ajp13/ajp14 for all communication).
  + *
  + * There is also a load balancing worker (jk_lb_worker.c), which itself
  + * manages a group of workers.
  + *
  + * Web servers are configured to forward requests to a given worker.  To
  + * handle those requests, the worker's get_endpoint method is called, and
  + * then the service() method of that endpoint is called.
  + *
  + * As with all the core jk classes, this is essentially an abstract base
  + * class which is implemented/extended by classes which are specific to a
  + * particular protocol (or request-handling system).  By using an abstract
  + * base class in this manner, plugins can be written for different servers

Re: [PATCH] Tomcat 4.0.1- Proposed fix for Bugzilla 4609

[Kin-Man Chung]

The problem is actually deeper than is reported in the bug report.

1. We also need a fix for flush(), since invoking flush after close
   should also throw IOE.
   
2. The fixes should also be applied to BodyContentImpl.java, since it's just
   another JspWriter.
   
However, doing all these fixes leads to another bug in the Jasper runtime.
And this one is nastier.  Suppose we have a  somewhere in
the page.  The 'forward' would cause out.close() to be invoked; and then
releasePageContext (generated for every page in 
JspParseEventListener.generateFooter()) would be invoked, which
would cause out.flush() to be invoked, which in term would cause a
IOException!  This all works now because flush called after close does
not cause IOException (a bug).  If fact, if the user explicit closes
a JspWriter, releasePageContext would surely causes a IOE.

I am currently looking at this bug and have essentially the same fix
(except for the generateFooter part), but don't know yet how to fix
the problem I described above.  If you have any ideas, I'd love hearing
from you!


> Date: Tue, 20 Nov 2001 18:19:16 -0500
> From: Ryan Lubke <[EMAIL PROTECTED]>
> Subject: [PATCH] Tomcat 4.0.1- Proposed fix for Bugzilla 4609
> To: tcdev <[EMAIL PROTECTED]>
> MIME-version: 1.0
> Delivered-to: mailing list [EMAIL PROTECTED]
> Mailing-List: contact [EMAIL PROTECTED]; run by ezmlm
> X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
> List-Post: 
> List-Subscribe: 
> List-Unsubscribe: 
> List-Help: 
> List-Id: "Tomcat Developers List" 
> 
> Hi,
> 
> Thought I'd give a shot at patching a bug (4609) I logged.
> The basics of the bug is that an IOException is not thrown
> if out.close() is called from within a JSP page and 
> subsequent calls to write() or println(), etc. are made.
> 
> The solution I have affects two classes:
> org.apache.jasper.runtime.JspWriterImpl
> org.apache.jasper.compiler.JspParseEventListener
> 
> The modification to JspWriterImpl was simple:
>   -Added a new boolean instance variable called 'closed'
>   -When JspWriter.close() is called, set 'closed' to true.
>   -Modified the JspWriter.ensureOpen() method.  If
>'closed' is true, or response is null, throw the IOException.
> 
> I felt the modification to JspParseEventListener.generateFooter()
> was necessary as the page code generated:
> 
> 
> } catch (Throwable t) {
> if (out != null && out.getBufferSize() != 0)
>   out.clearBuffer();
> if (pageContext != null) pageContext.handlePageException(t);
> }
> 
> 
> So in this case, now that the IOException is thown, we go into the 
> throwable, but the call to out.clearBuffer() generates its own
> IOException.  The problem with this is that the stacktrace becomes
> inaccurate.  Showing the call to clearBuffer() as the top-most call
> on the stack.
> 
> So the change I introduced would generate the following code:
> 
> 
> if (out != null && out.getBufferSize() != 0)
> try {
> out.clearBuffer();
> } catch (java.io.IOException ioe) {
> if (t instanceof java.io.IOException) {
> if (!(t.getMessage().equals(ioe.getMessage( {
> t = ioe;
> }
> }
> }
> 
> 
> So, here if out.clearBuffer() happens to throw an IOException,
> check to see if the throwable that brought us to this point
> in the code is an IOException as well.  If it is, see if 
> the messages are the same, if they aren't, then there
> is a new IO issue and set ioe to the throwable which will
> be handled by pageContext.handlePageException.  Otherwise
> the catch becomes a no-op and pageContext.handlePageException
> will use the original throwable.  Hope that made sense.
> 
> Anyway,  comments are definately welcome.  Still getting familiar
> with the code.
> 
> Thanks,
> -rl
> 
> 
> 


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-connectors/jk/native/common jk_registry.c

[costin]

costin  01/11/20 16:09:56

  Modified:jk/native/common jk_registry.c
  Log:
  Ajp12..
  
  Revision  ChangesPath
  1.7   +10 -1 jakarta-tomcat-connectors/jk/native/common/jk_registry.c
  
  Index: jk_registry.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_registry.c,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- jk_registry.c 2001/11/19 18:14:38 1.6
  +++ jk_registry.c 2001/11/21 00:09:56 1.7
  @@ -62,7 +62,7 @@
   
   /***
* Description: Worker list*
  - * Version: $Revision: 1.6 $   *
  + * Version: $Revision: 1.7 $   *
***/
   
   /** Static declarations for all 'hardcoded' modules. This is a hack, 
  @@ -102,6 +102,12 @@
jk_logger_t *l);
   #endif
   
  +#ifdef AJP12
  +int JK_METHOD ajp12_worker_factory(jk_worker_t **w,
  +   const char *name,
  +   jk_logger_t *l);
  +#endif
  +
   /* Factories for 'new' types. We use the new factory interface,
*  workers will be updated later 
*/
  @@ -123,6 +129,9 @@
   printf("jk_registry_init: Assertion failed, env==NULL\n" );
   return;
 }
  +#ifdef AJP12
  +  env->registerFactory( env, "worker", "ajp12", &ajp12_worker_factory );
  +#endif
 env->registerFactory( env, "worker", "ajp13", &ajp13_worker_factory );
 env->registerFactory( env, "worker", "ajp14", &ajp14_worker_factory );
 env->registerFactory( env, "worker", "lb",&lb_worker_factory );
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-connectors/jk/native/apache-1.3 mod_jk.c

[costin]

costin  01/11/20 16:09:22

  Modified:jk/native/apache-2.0 mod_jk.c
   jk/native/common jk_global.h
   jk/native/apache-1.3 mod_jk.c
  Log:
  Moved the duplicated declaration in jk_global.
  
  Revision  ChangesPath
  1.37  +4 -13 jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c
  
  Index: mod_jk.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c,v
  retrieving revision 1.36
  retrieving revision 1.37
  diff -u -r1.36 -r1.37
  --- mod_jk.c  2001/11/16 22:55:34 1.36
  +++ mod_jk.c  2001/11/21 00:09:21 1.37
  @@ -60,13 +60,12 @@
* Description: Apache 2 plugin for Jakarta/Tomcat *
* Author:  Gal Shachor <[EMAIL PROTECTED]>   *
* Henri Gomez <[EMAIL PROTECTED]>   *
  - * Version: $Revision: 1.36 $   *
  + * Version: $Revision: 1.37 $   *
***/
   
   /*
* mod_jk: keeps all servlet/jakarta related ramblings together.
*/
  -
   #include "apu_compat.h"
   #include "ap_config.h"
   #include "apr_lib.h"
  @@ -89,14 +88,6 @@
   /*
* Jakarta (jk_) include files
*/
  -#ifdef NETWARE
  -#define _SYS_TYPES_H_
  -#define _NETDB_H_INCLUDED
  -#define _IN_
  -#define _INET_
  -#define _SYS_TIMEVAL_H_
  -#define _SYS_SOCKET_H_
  -#endif
   #include "jk_global.h"
   #include "jk_util.h"
   #include "jk_map.h"
  @@ -253,7 +244,7 @@
   
   /* this NOP function was removed in apache 2.0 alpha14 */
   /* ap_send_http_header(r); */
  -p->response_started = JK_TRUE;
  +  p->response_started = JK_TRUE;
   
   return JK_TRUE;
   }
  @@ -1284,7 +1275,7 @@
   #endif
   {   
   int is_recoverable_error = JK_FALSE;
  -rc = end->service(end, &s, xl, &is_recoverable_error);
  +rc = end->service(end, &s, xl, &is_recoverable_error);
   
   if (s.content_read < s.content_length ||
   (s.is_chunked && ! s.no_more_chunks)) {
  @@ -1578,7 +1569,7 @@
   /* bypass the directory_walk and file_walk for non-file requests */
   static int jk_map_to_storage(request_rec *r)
   {
  -if (apr_table_get(r->notes, JK_WORKER_ID)) {
  +if (apr_table_get(r->notes, JK_WORKER_ID) != NULL ) {
   r->filename = (char *)apr_filename_of_pathname(r->uri);
   return OK;
   }
  
  
  
  1.13  +10 -1 jakarta-tomcat-connectors/jk/native/common/jk_global.h
  
  Index: jk_global.h
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_global.h,v
  retrieving revision 1.12
  retrieving revision 1.13
  diff -u -r1.12 -r1.13
  --- jk_global.h   2001/10/31 14:03:22 1.12
  +++ jk_global.h   2001/11/21 00:09:21 1.13
  @@ -59,11 +59,20 @@
* Description: Global definitions and include files that should exist *
*  anywhere   *
* Author:  Gal Shachor <[EMAIL PROTECTED]>   *
  - * Version: $Revision: 1.12 $   *
  + * Version: $Revision: 1.13 $   *
***/
   
   #ifndef JK_GLOBAL_H
   #define JK_GLOBAL_H
  +
  +#ifdef NETWARE
  +#define _SYS_TYPES_H_
  +#define _NETDB_H_INCLUDED
  +#define _IN_
  +#define _INET_
  +#define _SYS_TIMEVAL_H_
  +#define _SYS_SOCKET_H_
  +#endif
   
   #include "jk_version.h"
   
  
  
  
  1.21  +1 -9  jakarta-tomcat-connectors/jk/native/apache-1.3/mod_jk.c
  
  Index: mod_jk.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/apache-1.3/mod_jk.c,v
  retrieving revision 1.20
  retrieving revision 1.21
  diff -u -r1.20 -r1.21
  --- mod_jk.c  2001/10/31 14:03:22 1.20
  +++ mod_jk.c  2001/11/21 00:09:22 1.21
  @@ -61,7 +61,7 @@
* Author:  Gal Shachor <[EMAIL PROTECTED]>   *
*  Dan Milstein <[EMAIL PROTECTED]>*
*  Henri Gomez <[EMAIL PROTECTED]>   *
  - * Version: $Revision: 1.20 $   *
  + * Version: $Revision: 1.21 $   *
***/
   
   /*
  @@ -83,14 +83,6 @@
   /*
* Jakarta (jk_) include files
*/
  -#ifdef NETWARE
  -#define _SYS_TYPES_H_
  -#define _NETDB_H_INCLUDED
  -#define _IN_
  -#define _INET_
  -#define _SYS_T

cvs commit: jakarta-tomcat-connectors/jk/native build.xml

[costin]

costin  01/11/20 16:05:23

  Modified:jk/native build.xml
  Log:
  Minor changes, added a define for XP_UNIX if not on win32 ( otherwise
  netscape will fail ) ( I try to verify my commits are not braking
  the other server adapters ).
  Added a flag to compile the 12 adapter for those who need it.
  
  Revision  ChangesPath
  1.19  +46 -41jakarta-tomcat-connectors/jk/native/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/build.xml,v
  retrieving revision 1.18
  retrieving revision 1.19
  diff -u -r1.18 -r1.19
  --- build.xml 2001/11/20 21:32:59 1.18
  +++ build.xml 2001/11/21 00:05:23 1.19
  @@ -19,6 +19,7 @@
 
 
 
  +  
 
 
 
  @@ -112,8 +113,10 @@
taskDebug="0"
profile="${so.profile}" >
 
  -  
  +  
  +  
 
 
 

  - 
  + 
  +
 
 

  @@ -221,45 +225,45 @@
 
   
 
  -  
  +
   
  -
  - 
  -
  -
  -
  -
  - 
  - 
  - 
  - 
  -
  -
  -
  -
  +  
  +
  +
  +
  +  
  +  
  +
  +
  +
  +
  +  
  +  
  +
  +  
   
  -
  -
  -
  -
  -
  -
  -
  -
  -
  -
  -
  -
  -
  -
  -
  -
  - 
  +  
  +  
  +  
  +  
  +  
  +  
  +  
  +  
  +  
  +  
  +  
  +  
  +  
  +  
  +  
  +  
  +
 
   
 
  @@ -268,7 +272,6 @@
optimize="${so.optimize}"
debug="${so.debug}"
profile="${so.profile}">
  -  
   
 

  @@ -315,6 +318,8 @@
 
 
 
  +  
 
 
 
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-connectors/jk/native/common/ajp12 jk_ajp12_worker.c jk_ajp12_worker.h jk_sockbuf.c jk_sockbuf.h

[costin]

costin  01/11/20 16:02:32

  Added:   jk/native/common/ajp12 jk_ajp12_worker.c jk_ajp12_worker.h
jk_sockbuf.c jk_sockbuf.h
  Log:
  Part 2 of Ajp12 removal ( or sort of :-).
  
  It seems some people still need ajp12 - it's the only way to use
  JServ with Apache2, and people still have 'legacy' servlet2.0
  applications on jserv...
  
  The code will not be compiled by default and probably we can
  actually remove it in the second release of mod_jk, but for now
  it doesn't hurt too much to keep it.
  
  Revision  ChangesPath
  1.1  
jakarta-tomcat-connectors/jk/native/common/ajp12/jk_ajp12_worker.c
  
  Index: jk_ajp12_worker.c
  ===
  /*
   * Copyright (c) 1997-1999 The Java Apache Project.  All rights reserved.
   *
   * Redistribution and use in source and binary forms, with or without
   * modification, are permitted provided that the following conditions
   * are met:
   *
   * 1. Redistributions of source code must retain the above copyright
   *notice, this list of conditions and the following disclaimer.
   *
   * 2. Redistributions in binary form must reproduce the above copyright
   *notice, this list of conditions and the following disclaimer in
   *the documentation and/or other materials provided with the
   *distribution.
   *
   * 3. All advertising materials mentioning features or use of this
   *software must display the following acknowledgment:
   *"This product includes software developed by the Java Apache 
   *Project for use in the Apache JServ servlet engine project
   *."
   *
   * 4. The names "Apache JServ", "Apache JServ Servlet Engine" and 
   *"Java Apache Project" must not be used to endorse or promote products 
   *derived from this software without prior written permission.
   *
   * 5. Products derived from this software may not be called "Apache JServ"
   *nor may "Apache" nor "Apache JServ" appear in their names without 
   *prior written permission of the Java Apache Project.
   *
   * 6. Redistributions of any form whatsoever must retain the following
   *acknowledgment:
   *"This product includes software developed by the Java Apache 
   *Project for use in the Apache JServ servlet engine project
   *."
   *
   * THIS SOFTWARE IS PROVIDED BY THE JAVA APACHE PROJECT "AS IS" AND ANY
   * EXPRESSED OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
   * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
   * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE JAVA APACHE PROJECT OR
   * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
   * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
   * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
   * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
   * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
   * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
   * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
   * OF THE POSSIBILITY OF SUCH DAMAGE.
   *
   * This software consists of voluntary contributions made by many
   * individuals on behalf of the Java Apache Group. For more information
   * on the Java Apache Project and the Apache JServ Servlet Engine project,
   * please see .
   *
   */
  
  /***
   * Description: ajpv1.2 worker, used to call local or remote jserv hosts   *
   * Author:  Gal Shachor <[EMAIL PROTECTED]>   *
   * Based on:jserv_ajpv12.c from Jserv  *
   * Version: $Revision: 1.1 $   *
   ***/
  
  #include "jk_ajp12_worker.h"
  #include "jk_pool.h"
  #include "jk_connect.h"
  #include "jk_util.h"
  #include "jk_sockbuf.h"
  
  #define AJP_DEF_HOST("localhost")
  #define AJP_DEF_PORT(8007)
  #define READ_BUF_SIZE   (8*1024)
  #define DEF_RETRY_ATTEMPTS  (1)
  
  struct ajp12_worker {
  struct sockaddr_in worker_inet_addr;
  unsigned connect_retry_attempts;
  char *name; 
  jk_worker_t worker;
  };
  
  typedef struct ajp12_worker ajp12_worker_t;
  
  struct ajp12_endpoint { 
  ajp12_worker_t *worker;
  
  int sd;
  jk_sockbuf_t sb;
  
  jk_endpoint_t endpoint;
  };
  typedef struct ajp12_endpoint ajp12_endpoint_t;
  
  static int ajpv12_mark(ajp12_endpoint_t *p, 
 unsigned char type);
  
  static int ajpv12_sendstring(ajp12_endpoint_t *p, 
   const char *buffer);
  
  static int ajpv12_sendint(ajp12_endpoint_t *p, 
int d);
  
  stat

cvs commit: jakarta-tomcat-connectors/jk/native/common/ajp12 - New directory

[costin]

costin  01/11/20 15:52:29

  jakarta-tomcat-connectors/jk/native/common/ajp12 - New directory

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 4940] - Reserved words are accepted as taglib prefixes

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4940

Reserved words are accepted as taglib prefixes

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||tomcat-
   ||[EMAIL PROTECTED]
 AssignedTo|tomcat- |[EMAIL PROTECTED]
   |[EMAIL PROTECTED]  |



--- Additional Comments From [EMAIL PROTECTED]  2001-11-20 15:52 ---
Mmm... The spec (Table JSP.2-1) only list the following reserved prefixes:

jsp, jspx, java, javax, servlet, sun, and sunw

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 4939] - JspEngineInfo.getSpecificationVersion() returns 1.1 instead of 1.2

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4939

JspEngineInfo.getSpecificationVersion() returns 1.1 instead of 1.2

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2001-11-20 15:44 ---
Fixed with nightly build 20011121

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/runtime JspFactoryImpl.java

[kinman]

kinman  01/11/20 15:26:25

  Modified:jasper/src/share/org/apache/jasper/runtime Tag:
tomcat_40_branch JspFactoryImpl.java
  Log:
  PR: 4939
  
  JspEngineInfo.getSpecificationVersion() should return "1.2"
  
  Revision  ChangesPath
  No   revision
  
  
  No   revision
  
  
  1.2.2.1   +7 -4  
jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/runtime/JspFactoryImpl.java
  
  Index: JspFactoryImpl.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/runtime/JspFactoryImpl.java,v
  retrieving revision 1.2
  retrieving revision 1.2.2.1
  diff -u -r1.2 -r1.2.2.1
  --- JspFactoryImpl.java   2001/02/04 01:07:00 1.2
  +++ JspFactoryImpl.java   2001/11/20 23:26:25 1.2.2.1
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/runtime/JspFactoryImpl.java,v
 1.2 2001/02/04 01:07:00 glenn Exp $
  - * $Revision: 1.2 $
  - * $Date: 2001/02/04 01:07:00 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/runtime/JspFactoryImpl.java,v
 1.2.2.1 2001/11/20 23:26:25 kinman Exp $
  + * $Revision: 1.2.2.1 $
  + * $Date: 2001/11/20 23:26:25 $
*
* 
* 
  @@ -202,8 +202,11 @@
   }
   
   static class SunJspEngineInfo extends JspEngineInfo {
  +
  + final static String SpecificationVersion = "1.2";
  +
   public String getSpecificationVersion() {
  -return "1.1";
  +return SpecificationVersion;
   }
   }
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/runtime JspFactoryImpl.java

[kinman]

kinman  01/11/20 15:22:40

  Modified:jasper/src/share/org/apache/jasper/runtime
JspFactoryImpl.java
  Log:
  PR: 4939
  
  JspEngineInfo.getSpecificationVersion() should return "1.2"
  
  Revision  ChangesPath
  1.3   +7 -4  
jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/runtime/JspFactoryImpl.java
  
  Index: JspFactoryImpl.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/runtime/JspFactoryImpl.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- JspFactoryImpl.java   2001/02/04 01:07:00 1.2
  +++ JspFactoryImpl.java   2001/11/20 23:22:40 1.3
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/runtime/JspFactoryImpl.java,v
 1.2 2001/02/04 01:07:00 glenn Exp $
  - * $Revision: 1.2 $
  - * $Date: 2001/02/04 01:07:00 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/runtime/JspFactoryImpl.java,v
 1.3 2001/11/20 23:22:40 kinman Exp $
  + * $Revision: 1.3 $
  + * $Date: 2001/11/20 23:22:40 $
*
* 
* 
  @@ -202,8 +202,11 @@
   }
   
   static class SunJspEngineInfo extends JspEngineInfo {
  +
  + final static String SpecificationVersion = "1.2";
  +
   public String getSpecificationVersion() {
  -return "1.1";
  +return SpecificationVersion;
   }
   }
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 4988] - Tomcat hangs after auto-start

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4988

Tomcat hangs after auto-start

[EMAIL PROTECTED] changed:

   What|Removed |Added

 OS/Version|Other   |Windows NT/2K

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

[PATCH] Tomcat 4.0.1- Proposed fix for Bugzilla 4609

[Ryan Lubke]

Hi,

Thought I'd give a shot at patching a bug (4609) I logged.
The basics of the bug is that an IOException is not thrown
if out.close() is called from within a JSP page and 
subsequent calls to write() or println(), etc. are made.

The solution I have affects two classes:
org.apache.jasper.runtime.JspWriterImpl
org.apache.jasper.compiler.JspParseEventListener

The modification to JspWriterImpl was simple:
  -Added a new boolean instance variable called 'closed'
  -When JspWriter.close() is called, set 'closed' to true.
  -Modified the JspWriter.ensureOpen() method.  If
   'closed' is true, or response is null, throw the IOException.

I felt the modification to JspParseEventListener.generateFooter()
was necessary as the page code generated:


} catch (Throwable t) {
if (out != null && out.getBufferSize() != 0)
out.clearBuffer();
if (pageContext != null) pageContext.handlePageException(t);
}


So in this case, now that the IOException is thown, we go into the 
throwable, but the call to out.clearBuffer() generates its own
IOException.  The problem with this is that the stacktrace becomes
inaccurate.  Showing the call to clearBuffer() as the top-most call
on the stack.

So the change I introduced would generate the following code:


if (out != null && out.getBufferSize() != 0)
try {
out.clearBuffer();
} catch (java.io.IOException ioe) {
if (t instanceof java.io.IOException) {
if (!(t.getMessage().equals(ioe.getMessage( {
t = ioe;
}
}
}


So, here if out.clearBuffer() happens to throw an IOException,
check to see if the throwable that brought us to this point
in the code is an IOException as well.  If it is, see if 
the messages are the same, if they aren't, then there
is a new IO issue and set ioe to the throwable which will
be handled by pageContext.handlePageException.  Otherwise
the catch becomes a no-op and pageContext.handlePageException
will use the original throwable.  Hope that made sense.

Anyway,  comments are definately welcome.  Still getting familiar
with the code.

Thanks,
-rl





Index: JspParseEventListener.java
===
RCS file: 
/home/cvspublic/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/JspParseEventListener.java,v
retrieving revision 1.35
diff -u -r1.35 JspParseEventListener.java
--- JspParseEventListener.java  2001/11/02 19:36:09 1.35
+++ JspParseEventListener.java  2001/11/20 22:29:40
@@ -378,7 +378,23 @@
writer.pushIndent();
 writer.println("if (out != null && out.getBufferSize() != 0)");
 writer.pushIndent();
+writer.println( "try {" );
+writer.pushIndent();
writer.println("out.clearBuffer();");
+writer.popIndent();
+writer.println("} catch (java.io.IOException ioe) {");
+writer.pushIndent();
+writer.println("if (t instanceof java.io.IOException) {");
+writer.pushIndent();
+writer.println("if (!(t.getMessage().equals(ioe.getMessage( {");
+writer.pushIndent();
+writer.println("t = ioe;");
+writer.popIndent();
+writer.println("}");
+writer.popIndent();
+writer.println("}");
+writer.popIndent();
+writer.println("}");
writer.popIndent();
writer.println("if (pageContext != null) pageContext.handlePageException(t);");
writer.popIndent();


Index: JspWriterImpl.java
===
RCS file: 
/home/cvspublic/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/runtime/JspWriterImpl.java,v
retrieving revision 1.1
diff -u -r1.1 JspWriterImpl.java
--- JspWriterImpl.java  2000/08/12 00:52:12 1.1
+++ JspWriterImpl.java  2001/11/20 18:10:11
@@ -99,6 +99,7 @@
 protected static int defaultCharBufferSize = Constants.DEFAULT_BUFFER_SIZE;
 
 protected boolean flushed = false;
+protected boolean closed = false;
 
 public JspWriterImpl() {
super( defaultCharBufferSize, true );
@@ -223,6 +224,7 @@
 if (out != null)
 out.close();
 out = null;
+closed = true;
//cb = null;
 }
 }
@@ -236,7 +238,7 @@
 
 /** check to make sure that the stream has not been closed */
 protected void ensureOpen() throws IOException {
-   if (response == null)
+   if ( closed || response == null)
throw new IOException("Stream closed");
 }
 



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 4988] New: - Tomcat hangs after auto-start

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4988

Tomcat hangs after auto-start

   Summary: Tomcat hangs after auto-start
   Product: Tomcat 4
   Version: 4.0.1 Final
  Platform: PC
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Unknown
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I have a JSP page which uses a class which accesses a local database through a 
JDBC connection. When I start Tomcat (standalone) maually this page and all 
other pages work perfectly but when Tomcat has been started as an NT service or 
by the task scheduler this JSP page causes Tomcat to hang. The NT service can't 
even be restarted. The computer has to be rebooted. The logs are not giving any 
clues. I've even tried using a wrapper bat-file with a custom CLASSPATH with 
little success.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

[PATCH] jakarta-tomcat-4.0/webapps/admin

[tangojaz]

Role Based Admin Change


I am thinking that a web server admin tool
my not have just one admin that controls everything
but there maybe be other less powerful admins with
limited control. For example there may be admins
that control properties for a certain subset of
webapps. In this case the less powerful
admins should be only be allowed to see what they
have access to. Thus the user's tree of configurable and readable objects
should be built according to their priviledges or
roles. In this case, the tree controller cannot be built
in the session listener code because the user has
not logged in yet at that point. I have moved the code for
the tree building to a new file SetUpTreeAction.java
which gets called from index.jsp after the user
has logged in.

SetUpTreeAction.java builds the root node and then
gets the init parameters set in web.xml of a classes that 
implement the TreeBuilder interface. That way anyone
can input nodes into the tree in the implementation
of the method buildTree() of the interface. One of the
parameters of the of the buildTree method is the request
so the user can do a getUserPrincipal() to do role checks.

Attached are the cvs diffs of the existing files and
the added files SetUpTreeAction.java and TreeBuilder.java
The new files should be checked into the following directory:

$TOMCAT_HOME/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin 

Also we should probably get rid of TreeControlTestListener.java


Jazmin

-- 




__
Your favorite stores, helpful shopping tools and great gift ideas. Experience the 
convenience of buying online with Shop@Netscape! http://shopnow.netscape.com/

Get your own FREE, personal Netscape Mail account today at http://webmail.netscape.com/



cvsdiff
Description: cvsdiff


TreeBuilder.java
Description: TreeBuilder.java


SetUpTreeAction.java
Description: SetUpTreeAction.java

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-connectors/jk/native build.xml

[hgomez]

hgomez  01/11/20 13:32:59

  Modified:jk/native build.xml
  Log:
  Fix apache includes when they are not under
  apache home, ie follow FHS and live for
  example in /usr/include/apache anf /usr/include/apache2
  Just have to define apache13.include, apache2.include
  to ovveride default setting
  
  Revision  ChangesPath
  1.18  +6 -4  jakarta-tomcat-connectors/jk/native/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/build.xml,v
  retrieving revision 1.17
  retrieving revision 1.18
  diff -u -r1.17 -r1.18
  --- build.xml 2001/11/17 06:00:24 1.17
  +++ build.xml 2001/11/20 21:32:59 1.18
  @@ -22,13 +22,16 @@
 
 
 
  +  
  +  
  +
 
 
 
   
 
   
  -  
  +  
 
   
 
  @@ -126,7 +129,7 @@
 
 

  - 
  + 

 
 
  @@ -154,8 +157,7 @@
 


  - 
  - 
  + 

   
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 4985] New: - Typo in service/native/location.c line 77 ("define" should be "defined")

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4985

Typo in service/native/location.c line 77 ("define" should be "defined")

   Summary: Typo in service/native/location.c line 77 ("define"
should be "defined")
   Product: Tomcat 4
   Version: Nightly Build
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Unknown
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


In service/native/location.c at line 77, the keyword "define" should be changed
to "defined".  Here's what is there now:

#elif define(OS_CYGWIN)
"/cygdrive/c/WINNT/system32/java",
#endif

It should read:

#elif defined(OS_CYGWIN)
"/cygdrive/c/WINNT/system32/java",
#endif
With the typo, the location.c file does not compile under Cygwin.  I'm using
Cygwin 1.3.3 on Windows 2000 Service Pack 2.

$ uname -a
CYGWIN_NT-5.0 DEV 1.3.3(0.46/3/2) 2001-09-12 23:54 i686 unknown

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-site/docs index.html

[bojan]

bojan   01/11/20 12:51:57

  Modified:docs index.html
  Log:
  The 'old' release is now 3.2.4, not 3.2.3
  
  Revision  ChangesPath
  1.17  +3 -3  jakarta-tomcat-site/docs/index.html
  
  Index: index.html
  ===
  RCS file: /home/cvs/jakarta-tomcat-site/docs/index.html,v
  retrieving revision 1.16
  retrieving revision 1.17
  diff -u -r1.16 -r1.17
  --- index.html2001/11/20 17:42:21 1.16
  +++ index.html2001/11/20 20:51:57 1.17
  @@ -177,9 +177,9 @@
   
   Version 3.3 is the current production quality release for the Servlet 2.2
   and JSP 1.1 specifications.  Tomcat 3.3 is the latest continuation of the
  -Tomcat 3.x architecture and it is more advanced then 3.2.3, which is the 'old'
  +Tomcat 3.x architecture and it is more advanced then 3.2.4, which is the 'old'
   production quality release.
  -Version 3.2.3 is the 'old' production quality release and is now in
  +Version 3.2.4 is the 'old' production quality release and is now in
   maintenance only mode.
   Version 3.1.1 is a legacy release.
   
  @@ -203,7 +203,7 @@
   There is no active development ongoing for Tomcat 3.1.x.  Users of Tomcat 
   3.1 should update to 3.1.1 to close the security holes and they are 
   strongly encouraged to migrate to the current production release, Tomcat 
  -3.2.3.
  +3.3.
   Tomcat 3.2.x.  
Version 3.2 added few new features 
   since 3.1; the major effort was a refactoring of the internals to improve 
   performance and stability.  The 3.2.1 release, like 3.1.1, was a security 
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-site/xdocs index.xml

[bojan]

bojan   01/11/20 12:51:38

  Modified:xdocsindex.xml
  Log:
  The 'old' release is now 3.2.4, not 3.2.3
  
  Revision  ChangesPath
  1.16  +3 -4  jakarta-tomcat-site/xdocs/index.xml
  
  Index: index.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-site/xdocs/index.xml,v
  retrieving revision 1.15
  retrieving revision 1.16
  diff -u -r1.15 -r1.16
  --- index.xml 2001/11/20 17:42:21 1.15
  +++ index.xml 2001/11/20 20:51:38 1.16
  @@ -56,9 +56,9 @@
   
   Version 3.3 is the current production quality release for the Servlet 2.2
   and JSP 1.1 specifications.  Tomcat 3.3 is the latest continuation of the
  -Tomcat 3.x architecture and it is more advanced then 3.2.3, which is the 'old'
  +Tomcat 3.x architecture and it is more advanced then 3.2.4, which is the 'old'
   production quality release.
  -Version 3.2.3 is the 'old' production quality release and is now in
  +Version 3.2.4 is the 'old' production quality release and is now in
   maintenance only mode.
   Version 3.1.1 is a legacy release.
   
  @@ -86,7 +86,7 @@
   There is no active development ongoing for Tomcat 3.1.x.  Users of Tomcat 
   3.1 should update to 3.1.1 to close the security holes and they are 
   strongly encouraged to migrate to the current production release, Tomcat 
  -3.2.3. 
  +3.3. 
   
   Tomcat 3.2.x.  Version 3.2 added few new features 
   since 3.1; the major effort was a refactoring of the internals to improve 
  @@ -118,4 +118,3 @@
   
   
   
  -
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

NT Service in 4.01 (tomcat.exe) installation/documentation

[Andrew]

1. Difficult to locate documentation of installation of the NT Service. There 
is no documentation that I could find, in the distribution or CVS repository, 
regarding the installation on Tomcat 4.01 as a Service on NT. I recomend 
placing a quick example in the documentation on how to install Tomcat as an NT 
Service.

2. A program is included with the distribution to install Tomcat as an NT 
Service (tomcat.exe). This was found by browsing the bin directory while 
trying to determine the best way to install tomcat 4 as a service. However 
again, there is no documentation other than a concise commandline reference. 
And no reference I could find in the Tomcat Documentation. I would recommend 
at least mentioning the NT Service installation (tomcat.exe) included in the 
binary download.

3. Further investigation (in particular of the CVS repository) led to the 
discovery of the Installer script for NSIS. In this manner, the inclusion of a 
simple NT Services install in the binary release (EXE) was noted. However due 
to the use of JDK1.4Beta3 on the server, the installer failed with the 
inability to find JDK. (This is due to the registry check for the runtime 
environment) My environment does not include a seperate install of the Java 
Runtime environment as such is not neccessary at this time. Adding the option 
to specify where the Java Dll is located may solve this issue.

4. Because of the time consuming process of typing all the information at the 
command line to do an installation of Tomcat as a NT Service I created a 
script to handle the menial tasks (run from %CATALINA_HOME%\bin). The script 
currently has the option to specify the NT Service name (To suppost multiple 
containers, etc.) and the option to specify the security support. In addition 
the script handles finding the Java Dll automatically (can also be specified). 
However all other catalina start options were removed. They could probably be 
easily added by hand to the script. About half of the code used in the script 
was taken directly from 'catalina.bat'.

The following is the full script (might be linewrapped):


@echo off
rem 
---
rem ntservice.cmd - script to install/remove the Tomcat ntservice
rem
rem Environment Variable Prequisites:
rem
rem   CATALINA_BASE (Optional) Base directory for resolving dynamic portions
rem of a Catalina installation.  If not present, resolves to
rem the same directory that CATALINA_HOME points to.
rem
rem   CATALINA_HOME (Optional) May point at your Catalina "build" directory.
rem If not present, the current working directory is assumed.
rem
rem   CATALINA_OPTS (Optional) Java runtime options used when the "start",
rem "stop", or "run" command is executed.
rem
rem   JAVA_HOME Must point at your Java Development Kit installation.
rem
rem   JAVADLL   (Optional) May point at your Java DLL. This can be used
rem to specify the DLL used to run Tomcat.
rem
rem   JSSE_HOME (Optional) May point at your Java Secure Sockets Extension
rem (JSSE) installation, whose JAR files will be added to the
rem system class path used to start Tomcat.
rem
rem 
---


rem - Save Environment Variables That May Change 
--

set _CATALINA_BASE=%CATALINA_BASE%
set _CATALINA_HOME=%CATALINA_HOME%
set _CLASSPATH=%CLASSPATH%
set _CP=%CP%


rem - Verify and Set Required Environment Variables 
---

if not "%JAVA_HOME%" == "" goto gotJava
echo You must set JAVA_HOME to point at your Java Development Kit installation
goto cleanup
:gotJava

if not "%CATALINA_HOME%" == "" goto gotHome
set CATALINA_HOME=.
if exist "%CATALINA_HOME%\bin\catalina.bat" goto okHome
set CATALINA_HOME=..
:gotHome
if exist "%CATALINA_HOME%\bin\catalina.bat" goto okHome
echo Cannot find catalina.bat in %CATALINA_HOME%\bin
echo Please check your CATALINA_HOME setting
goto cleanup
:okHome

if not "%CATALINA_BASE%" == "" goto gotBase
set CATALINA_BASE=%CATALINA_HOME%
:gotBase


rem - Prepare Appropriate Java Execution Commands 
-

if not "%OS%" == "Windows_NT" goto noNT
if not exist "%JAVADLL%" goto findJVM
set _JAVADLL=%JAVADLL%
goto gotJVM
:findJVM
if not exist "%JAVA_HOME%\jre\bin\server\jvm.dll" goto noJVMyet
set _JAVADLL="%JAVA_HOME%\jre\bin\server\jvm.dll"
goto gotJVM
:noJVMyet
if not exist "%JAVA_HOME%\jre\bin\client\jvm.dll" goto noJVM
set _JAVADLL="%JAVA_HOME%\jre\bin\client\jvm.dll"
goto gotJVM
:noJVM
echo This script could not find the Java DLL please set JAVADLL
echo to point at your Java DLL.
goto cleanup
:nonoNT
echo This script can only be used on NT4 and Win2k.
goto cleanup
:gotJVM

rem - Set Up The Runtime Classpath 


set CP=%CATALINA_HOME%\bin\bootstrap.jar;%JAVA_HO

mod_warp not in distribution:

[Endre Stølsvik]

from:
http://jakarta.apache.org/builds/jakarta-tomcat-4.0/release/v4.0.1/

RELESE NOTES

[ -- cut -- ]

-
Tomcat 4.0 and Apache:
-

The binary distribution for Tomcat 4.0 includes the most recent stable
   ^^  WHERE??
version of the WARP connector, which is the Tomcat component that talks to
mod_webapp inside Apache 1.3.  The current state of this support is
summarized as follows:

[ -- cut -- ]

* Currently, mod_webapp forwards *all* requests under the specified
  context path to Tomcat for processing.  When Tomcat 4.0 final is
 ^^^
  released,ISN'T IT ALREADY?! ;)
 ^
  it will automatically configure itself to serve static resources
  from Apache *unless* the resource is subject to filtering, or subject
  to a security constraint, as defined in web.xml.  No extra configuration
  in httpd.conf will be required.


--

What is the current status of that connector thingy anyway?



-- 
Mvh,
Endre


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 4982] New: - HTC files aren't being attached

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4982

HTC files aren't being attached

   Summary: HTC files aren't being attached
   Product: Tomcat 4
   Version: 4.0 Final
  Platform: All
OS/Version: All
Status: NEW
  Severity: Critical
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


For some very weird reason, HTC files that are attched to CSS files aren't being 
attached to the DHTML 
engine in IE5+.
It used to work in previous versions.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 4980] New: - Startup message indicates incorrect log file

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4980

Startup message indicates incorrect log file

   Summary: Startup message indicates incorrect log file
   Product: Tomcat 3
   Version: 3.2.3 Final
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: Minor
  Priority: Other
 Component: Unknown
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


It appears that regardless of where the tc_log is directed, Tomcat always 
prints the message "Starting tomcat. Check logs/tomcat.log for error messages".

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/ajp Ajp13Packet.java Ajp14.java AjpHandler.java NegociationHandler.java RequestHandler.java Ajp14Packet.java

[costin]

costin  01/11/20 09:49:53

  Modified:jk/java/org/apache/ajp Ajp13Packet.java Ajp14.java
AjpHandler.java NegociationHandler.java
RequestHandler.java
  Removed: jk/java/org/apache/ajp Ajp14Packet.java
  Log:
  Merge Ajp14Packet back into Ajp13Packet ( i.e. no more differences between the
  wire protocol - headers, etc ). Ajp14 workers should work with ajp13 clients.
  
  Revision  ChangesPath
  1.9   +13 -2 
jakarta-tomcat-connectors/jk/java/org/apache/ajp/Ajp13Packet.java
  
  Index: Ajp13Packet.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/ajp/Ajp13Packet.java,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- Ajp13Packet.java  2001/06/24 21:17:49 1.8
  +++ Ajp13Packet.java  2001/11/20 17:49:53 1.9
  @@ -60,10 +60,18 @@
   
   import java.io.IOException;
   import java.io.UnsupportedEncodingException;
  +import java.io.InputStream;
  +import java.io.OutputStream;
  +import java.net.Socket;
  +import java.util.Enumeration;
  +import java.security.*;
   
  -import org.apache.tomcat.util.buf.MessageBytes;
   import org.apache.tomcat.util.http.MimeHeaders;
  +import org.apache.tomcat.util.buf.MessageBytes;
  +import org.apache.tomcat.util.http.HttpMessages;
  +import org.apache.tomcat.util.buf.HexUtils;
   
  +
   /**
* A single packet for communication between the web server and the
* container.  Designed to be reused many times with no creation of
  @@ -71,6 +79,9 @@
* Can be used (somewhat confusingly) for both incoming and outgoing
* packets.  
*
  + * @see Ajp14/Ajp13Packet 
  + *
  + * @author Henri Gomez [[EMAIL PROTECTED]]
* @author Dan Milstein [[EMAIL PROTECTED]]
* @author Keith Wannamaker [[EMAIL PROTECTED]]
* @author Kevin Seguin
  @@ -195,7 +206,7 @@
   }
   return len;
   }
  - 
  +
   /**
* Prepare this packet for accumulating a message from the container to
* the web server.  Set the write position to just after the header
  
  
  
  1.4   +10 -10jakarta-tomcat-connectors/jk/java/org/apache/ajp/Ajp14.java
  
  Index: Ajp14.java
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/ajp/Ajp14.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- Ajp14.java2001/06/27 15:53:06 1.3
  +++ Ajp14.java2001/11/20 17:49:53 1.4
  @@ -79,7 +79,7 @@
* at a time.
*
* This class contains knowledge about how an individual packet is laid out
  - * (via the internal Ajp14Packet class), and also about the
  + * (via the internal Ajp13Packet class), and also about the
* stages of communicaton between the server and the servlet container.  It
* translates from Tomcat's internal servlet support methods
* (e.g. doWrite) to the correct packets to send to the web server.
  @@ -111,11 +111,11 @@
   
   // XXX public fields are temp. solutions until the API stabilizes
   // Buffer used of output body and headers
  -public Ajp14Packet outBuf = new Ajp14Packet( MAX_PACKET_SIZE );
  +public Ajp13Packet outBuf = new Ajp13Packet( MAX_PACKET_SIZE );
   // Buffer used for input body
  -Ajp14Packet inBuf  = new Ajp14Packet( MAX_PACKET_SIZE );
  +Ajp13Packet inBuf  = new Ajp13Packet( MAX_PACKET_SIZE );
   // Buffer used for request head ( and headers )
  -Ajp14Packet hBuf=new Ajp14Packet( MAX_PACKET_SIZE );
  +Ajp13Packet hBuf=new Ajp13Packet( MAX_PACKET_SIZE );
   
   // Holds incoming reads of request body data (*not* header data)
   byte []bodyBuff = new byte[MAX_READ_SIZE];
  @@ -142,9 +142,9 @@
   
   public void initBuf()
   {
  - outBuf = new Ajp14Packet( MAX_PACKET_SIZE );
  - inBuf  = new Ajp14Packet( MAX_PACKET_SIZE );
  - hBuf   = new Ajp14Packet( MAX_PACKET_SIZE );
  + outBuf = new Ajp13Packet( MAX_PACKET_SIZE );
  + inBuf  = new Ajp13Packet( MAX_PACKET_SIZE );
  + hBuf   = new Ajp13Packet( MAX_PACKET_SIZE );
   }
   
   public void recycle() {
  @@ -276,7 +276,7 @@
   
   /**
* Read in a packet from the web server and store it in the passed-in
  - * Ajp14Packet object.
  + * Ajp13Packet object.
*
* @param msg The object into which to store the incoming packet -- any
* current contents will be overwritten.
  @@ -284,7 +284,7 @@
* @return The number of bytes read on a successful read or -1 if there 
* was an error.
**/
  -public int receive(Ajp14Packet msg) throws IOException {
  +public int receive(Ajp13Packet msg) throws IOException {
// XXX If the length in the packet header doesn't agree with the
// actual number of bytes read, it should probably return an error
// v

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/ajp/tomcat4 JkServlet.java

[costin]

costin  01/11/20 09:47:38

  Added:   jk/java/org/apache/ajp/tomcat4 JkServlet.java
  Log:
  Initial attempt to use the Ajp WAR file in 4.0.
  The servlet will configure the ajp connector, using standard web.xml settings.
  
  The main benefit of using WARs is that it'll be much easier and cleaner for users
  to upgrade and install extensions in the server ( and maybe use the 'standard'
  tools for configuration ).
  
  Revision  ChangesPath
  1.1  
jakarta-tomcat-connectors/jk/java/org/apache/ajp/tomcat4/JkServlet.java
  
  Index: JkServlet.java
  ===
  /*
   * 
   *
   * The Apache Software License, Version 1.1
   *
   * Copyright (c) 1999 The Apache Software Foundation.  All rights
   * reserved.
   *
   * Redistribution and use in source and binary forms, with or without
   * modification, are permitted provided that the following conditions
   * are met:
   *
   * 1. Redistributions of source code must retain the above copyright
   *notice, this list of conditions and the following disclaimer.
   *
   * 2. Redistributions in binary form must reproduce the above copyright
   *notice, this list of conditions and the following disclaimer in
   *the documentation and/or other materials provided with the
   *distribution.
   *
   * 3. The end-user documentation included with the redistribution, if
   *any, must include the following acknowlegement:
   *   "This product includes software developed by the
   *Apache Software Foundation (http://www.apache.org/)."
   *Alternately, this acknowlegement may appear in the software itself,
   *if and wherever such third-party acknowlegements normally appear.
   *
   * 4. The names "The Jakarta Project", "Tomcat", and "Apache Software
   *Foundation" must not be used to endorse or promote products derived
   *from this software without prior written permission. For written
   *permission, please contact [EMAIL PROTECTED]
   *
   * 5. Products derived from this software may not be called "Apache"
   *nor may "Apache" appear in their names without prior written
   *permission of the Apache Group.
   *
   * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
   * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
   * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
   * DISCLAIMED.  IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
   * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
   * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
   * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
   * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
   * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
   * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
   * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
   * SUCH DAMAGE.
   * 
   *
   * This software consists of voluntary contributions made by many
   * individuals on behalf of the Apache Software Foundation.  For more
   * information on the Apache Software Foundation, please see
   * .
   *
   * [Additional notices, if required by prior licensing conditions]
   *
   */
  package org.apache.ajp.tomcat4;
  
  
  import java.io.*;
  import java.net.*;
  import javax.servlet.*;
  import javax.servlet.http.*;
  import org.apache.catalina.Container;
  import org.apache.catalina.ContainerServlet;
  import org.apache.catalina.Context;
  import org.apache.catalina.Deployer;
  import org.apache.catalina.Globals;
  import org.apache.catalina.Session;
  import org.apache.catalina.Wrapper;
  import org.apache.catalina.util.StringManager;
  
  
  /**
   * Module loader for JkServlet
   *
   * @author Costin Manolache
   */
  public class JkServlet
  extends HttpServlet implements ContainerServlet
  {
  //  ContainerServlet interface 
  Wrapper wrapper;
  
  public Wrapper getWrapper() {
if( dL > 0 ) d("getWrapper()");
return wrapper;
  }
  
  public void setWrapper(Wrapper wrapper) {
if( dL > 0 ) d("setWrapper() " + wrapper );
this.wrapper=wrapper;
  }
  
  Context ctx;
  
  /**
   * Initialize this servlet.
   */
  public void init() throws ServletException {
super.init();
  if(wrapper == null) {
log("No wrapper available, make sure the app is trusted");
System.out.println("No wrapper available, make sure the app is trusted");
return;
}
  
ctx=(Context) wrapper.getParent();
  
if( dL > 0 ) {
d("Wrapper: " + wrapper.getClass().getName() + " " + wrapper 

cvs commit: jakarta-tomcat-site/xdocs news.xml

[marcsaeg]

marcsaeg01/11/20 09:46:09

  Modified:docs news.html
   xdocsnews.xml
  Log:
  Fixed a stupid typo.
  
  Revision  ChangesPath
  1.14  +1 -1  jakarta-tomcat-site/docs/news.html
  
  Index: news.html
  ===
  RCS file: /home/cvs/jakarta-tomcat-site/docs/news.html,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- news.html 2001/11/20 17:42:21 1.13
  +++ news.html 2001/11/20 17:46:09 1.14
  @@ -108,7 +108,7 @@
 
   
   20 November 2001 - Apache Tomcat 3.2.4 
Released
  -Tomcat 3.2.4 is not available 
for download
  +Tomcat 3.2.4 is now available 
for download
   http://www.apache.org/dist/jakarta/jakarta-tomcat/release/v3.2.4";>here
   Tomcat 3.2.4 fixes bugs found 
since the Tomcat 3.2.3 release in July, 
   2001.  See the RELEASE-NOTES file for details on bug fixes and changes in 
  
  
  
  1.12  +1 -1  jakarta-tomcat-site/xdocs/news.xml
  
  Index: news.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-site/xdocs/news.xml,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -r1.11 -r1.12
  --- news.xml  2001/11/20 17:42:21 1.11
  +++ news.xml  2001/11/20 17:46:09 1.12
  @@ -12,7 +12,7 @@
   
   20 November 2001 - Apache Tomcat 3.2.4 Released
   
  -Tomcat 3.2.4 is not available for download
  +Tomcat 3.2.4 is now available for download
   http://www.apache.org/dist/jakarta/jakarta-tomcat/release/v3.2.4";>here
   
   Tomcat 3.2.4 fixes bugs found since the Tomcat 3.2.3 release in July, 
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-site/xdocs index.xml news.xml

[marcsaeg]

marcsaeg01/11/20 09:42:21

  Modified:docs index.html news.html
   xdocsindex.xml news.xml
  Log:
  Updates for the Tomcat 3.2.4 release.
  
  Revision  ChangesPath
  1.16  +9 -8  jakarta-tomcat-site/docs/index.html
  
  Index: index.html
  ===
  RCS file: /home/cvs/jakarta-tomcat-site/docs/index.html,v
  retrieving revision 1.15
  retrieving revision 1.16
  diff -u -r1.15 -r1.16
  --- index.html2001/11/19 04:44:37 1.15
  +++ index.html2001/11/20 17:42:21 1.16
  @@ -204,14 +204,15 @@
   3.1 should update to 3.1.1 to close the security holes and they are 
   strongly encouraged to migrate to the current production release, Tomcat 
   3.2.3.
  -Tomcat 3.2.x. 
Version 3.2 added few new features since 3.1;
  -the major effort was a refactoring of the internals to improve performance and
  -stability.  The 3.2.1 release, like 3.1.1, was a security patch.  Version 3.2.2
  -fixed a large number of bugs and all known specification compliance issues.
  -Version 3.2.3 is a security update that closes a serious security hole.  All
  -users of Tomcat versions prior to 3.2.3 should updgrade as soon as possible.
  -The 3.2.x branch will continue in maintenance mode, but no new feature releases
  -are planned.
  +Tomcat 3.2.x.  
Version 3.2 added few new features 
  +since 3.1; the major effort was a refactoring of the internals to improve 
  +performance and stability.  The 3.2.1 release, like 3.1.1, was a security 
  +patch.  Version 3.2.2 fixed a large number of bugs and all known 
  +specification compliance issues.  Version 3.2.3 was a security update that 
  +closes a serious security hole.  Version 3.2.4 is a minor bug fix release.  
  +All users of Tomcat versions prior to 3.2.3 should updgrade as soon as 
  +possible.  With the exception of fixes for critical security related bugs, 
  +development on the Tomcat 3.2.x branch has stopped.
   Tomcat 3.3. 
Version 3.3 is the current production quality
   release. It continues the refactoring that was begun in version 3.2 and
   carries it to its logical conclusion.  Version 3.3 provides a much more modular
  
  
  
  1.13  +11 -1 jakarta-tomcat-site/docs/news.html
  
  Index: news.html
  ===
  RCS file: /home/cvs/jakarta-tomcat-site/docs/news.html,v
  retrieving revision 1.12
  retrieving revision 1.13
  diff -u -r1.12 -r1.13
  --- news.html 2001/10/27 01:14:45 1.12
  +++ news.html 2001/11/20 17:42:21 1.13
  @@ -107,7 +107,17 @@
 
 
   
  -26 October 2001 - Apache Tomcat 3.2.4 beta 
1 Released
  +20 November 2001 - Apache Tomcat 3.2.4 
Released
  +Tomcat 3.2.4 is not available 
for download
  +http://www.apache.org/dist/jakarta/jakarta-tomcat/release/v3.2.4";>here
  +Tomcat 3.2.4 fixes bugs found 
since the Tomcat 3.2.3 release in July, 
  +2001.  See the RELEASE-NOTES file for details on bug fixes and changes in 
  +this release.  
  +With the exception of fixes for 
critical security problems, this is the 
  +last Tomcat 3.2.x release.  All future Servlet 2.2/JSP 1.1 Tomcat releases 
  +will be based on Tomcat 3.3.
  +
  +26 October 2001 - Apache Tomcat 
3.2.4 beta 1 Released
   The first beta release of 
Jakarta Tomcat 3.2.4 is now available for download at
   http://www.apache.org/dist/jakarta/jakarta-tomcat/release/v3.2.4-beta-1";>here
   Tomcat 3.2.4 fixes bugs found 
since the Tomcat 3.2.3 release in July, 
  
  
  
  1.15  +9 -8  jakarta-tomcat-site/xdocs/index.xml
  
  Index: index.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-site/xdocs/index.xml,v
  retrieving revision 1.14
  retrieving revision 1.15
  diff -u -r1.14 -r1.15
  --- index.xml 2001/11/19 04:44:07 1.14
  +++ index.xml 2001/11/20 17:42:21 1.15
  @@ -88,14 +88,15 @@
   strongly encouraged to migrate to the current production release, Tomcat 
   3.2.3. 
   
  -Tomcat 3.2.x. Version 3.2 added few new features since 3.1;
  -the major effort was a refactoring of the internals to improve performance and
  -stability.  The 3.2.1 release, like 3.1.1, was a security patch.  Version 3.2.2
  -fixed a large number of bugs and all known specification compliance issues.
  -Version 3.2.3 is a security update that closes a serious security hole.  All
  -users o

cvs commit: jakarta-tomcat-connectors/jk/native/common jk_ajp_common.h jk_ajp_common.c jk_ajp14_worker.c jk_ajp14.h jk_ajp13_worker.c jk_ajp13.c jk_ajp13.h

[costin]

costin  01/11/20 08:58:47

  Modified:jk/native/common jk_ajp_common.h jk_ajp_common.c
jk_ajp14_worker.c jk_ajp14.h jk_ajp13_worker.c
  Removed: jk/native/common jk_ajp13.c jk_ajp13.h
  Log:
  Use the same header for ajp13 and ajp14. Move the remaining 'ajp13 specific' code
  in ajp_common - the 'base' protocol supported by both ajp13 and 14.
  
  The idea is to be able to use a single codebase and worker. User can configure
  the worker to use the new 14 APIs or stay in 'compatibility' mode.
  ( this will happen later - now we still use 2 different workers )
  
  Revision  ChangesPath
  1.12  +69 -3 jakarta-tomcat-connectors/jk/native/common/jk_ajp_common.h
  
  Index: jk_ajp_common.h
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_ajp_common.h,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -r1.11 -r1.12
  --- jk_ajp_common.h   2001/10/09 18:07:37 1.11
  +++ jk_ajp_common.h   2001/11/20 16:58:46 1.12
  @@ -59,7 +59,7 @@
* Description: common stuff for bi-directional protocol ajp13/ajp14.  *
* Author:  Gal Shachor <[EMAIL PROTECTED]>   *
* Author:  Henri Gomez <[EMAIL PROTECTED]>   *
  - * Version: $Revision: 1.11 $   *
  + * Version: $Revision: 1.12 $   *
***/
   
   #ifndef JK_AJP_COMMON_H
  @@ -216,7 +216,70 @@
   #define AJP_HEADER_SZ_LEN (2)
   #define CHUNK_BUFFER_PAD  (12)
   
  +#define AJP13_PROTO  13
  +#define AJP13_WS_HEADER  0x1234
  +#define AJP13_SW_HEADER  0x4142  /* 'AB' */
  +
  +#define AJP13_DEF_HOST   ("localhost")
  +#define AJP13_DEF_PORT   (8009)
  +#define AJP13_READ_BUF_SIZE (8*1024)
  +#define AJP13_DEF_CACHE_SZ  (1)
  +#define JK_INTERNAL_ERROR(-2)
  +#define JK_FATAL_ERROR  (-3)
  +#define JK_CLIENT_ERROR (-4)
  +#define AJP13_MAX_SEND_BODY_SZ  (DEF_BUFFER_SZ - 6)
   
  +/*
  + * Message does not have a response (for example, JK_AJP13_END_RESPONSE)
  + */
  +#define JK_AJP13_ERROR  -1
  +/*
  + * Message does not have a response (for example, JK_AJP13_END_RESPONSE)
  + */
  +#define JK_AJP13_NO_RESPONSE0
  +/*
  + * Message have a response.
  + */
  +#define JK_AJP13_HAS_RESPONSE   1
  +
  +/*
  + * Forward a request from the web server to the servlet container.
  + */
  +#define JK_AJP13_FORWARD_REQUEST(unsigned char)2
  +
  +/*
  + * Write a body chunk from the servlet container to the web server
  + */
  +#define JK_AJP13_SEND_BODY_CHUNK(unsigned char)3
  +
  +/*
  + * Send response headers from the servlet container to the web server.
  + */
  +#define JK_AJP13_SEND_HEADERS   (unsigned char)4
  +
  +/*
  + * Marks the end of response.
  + */
  +#define JK_AJP13_END_RESPONSE   (unsigned char)5
  +
  +/*
  + * Marks the end of response.
  + */
  +#define JK_AJP13_GET_BODY_CHUNK (unsigned char)6
  +
  +/*
  + * Asks the container to shutdown
  + */
  +#define JK_AJP13_SHUTDOWN   (unsigned char)7
  +
  +/*
  + * Functions
  + */
  +int ajp13_marshal_shutdown_into_msgb(jk_msg_buf_t *msg,
  + jk_pool_t *p,
  + jk_logger_t *l);
  +
  +
   struct jk_res_data {
   int status;
   const char *msg;
  @@ -253,9 +316,12 @@
   unsigned ep_cache_sz;
   ajp_endpoint_t **ep_cache;
   
  - int proto; /* PROTOCOL USED AJP13/AJP14 */
  +/* PROTOCOL USED AJP13/AJP14
  +   XXX "version" - the API version to use
  +*/
  +int proto;
   
  - jk_login_service_t *login;
  +jk_login_service_t *login;
   
   jk_worker_t worker; 
   
  
  
  
  1.20  +31 -37jakarta-tomcat-connectors/jk/native/common/jk_ajp_common.c
  
  Index: jk_ajp_common.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_ajp_common.c,v
  retrieving revision 1.19
  retrieving revision 1.20
  diff -u -r1.19 -r1.20
  --- jk_ajp_common.c   2001/11/17 06:08:20 1.19
  +++ jk_ajp_common.c   2001/11/20 16:58:46 1.20
  @@ -59,15 +59,14 @@
* Description: common stuff for bi-directional protocols ajp13/ajp14. *
* Author:  Gal Shachor <[EMAIL PROTECTED]>   *
* Author:  Henri Gomez <[EMAIL PROTECTED]>   *
  - * Version: $Revision: 1.19 $   *
  + * Version: $Revision: 1.20 $   *
***

DO NOT REPLY [Bug 4948] - Class.getPackage() returns null in classes loaded by webapp class loader

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4948

Class.getPackage() returns null in classes loaded by webapp class loader





--- Additional Comments From [EMAIL PROTECTED]  2001-11-20 08:09 ---
Created an attachment (id=807)
Teaches the DependClassLoader how to define packages for Java2

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 4948] - Class.getPackage() returns null in classes loaded by webapp class loader

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4948

Class.getPackage() returns null in classes loaded by webapp class loader





--- Additional Comments From [EMAIL PROTECTED]  2001-11-20 08:09 ---
  Thanks for the clarification of what the class reloading problem was.  You're 
right about the way I was testing it ( touching web.xml ) and I agree that 
that's not good enough.  So, I spent some more time now digging in to 
DependClassLoader.java, trying to understand how it could possibly fail to 
define packages.  It turns out that the problem was much simpler than I had 
imagined it to be.  The root of the problem is that DependClassLoader12 is 
never calling definePackage.  Apparently, this must be a not-very-often used 
feature because everything still runs just fine regardless ( until you 
encounter some code that wants to call Class.getPackage() and it gets null ).  
I've modified my copy of DependClassLoader12.java to call definePackage 
appropriately and will attach a patch containing those changes.  Thanks for 
your attention.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 4978] New: - catalina debug

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4978

catalina debug

   Summary: catalina debug
   Product: Tomcat 4
   Version: 4.0.1 Final
  Platform: All
OS/Version: All
Status: NEW
  Severity: Enhancement
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Add debug command to catalina to use Java remote debugger. For example:

if "%1" == "env" goto doEnv
if "%1" == "run" goto doRun
if "%1" == "start" goto doStart
if "%1" == "stop" goto doStop
if "%1" == "debug" goto doDebug

:doUsage
echo Usage:  catalina ( env ^| run ^| start ^| stop ^| debug )
echo Commands:
echo   env -   Set up environment variables that Catalina would use
echo   run -   Start Catalina in the current window
echo   start - Start Catalina in a separate window
echo   stop -  Stop Catalina
echo   debug -  Debug Catalina with java
goto cleanup

:doEnv
goto finish

:doDebug
echo Starting catalina in debug mode
if "%2" == "-security" goto doRunSecure
%_RUNJAVA% -Xdebug -Djava.compiler=NONE -Xnoagent -
Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=5000 %CATALINA_OPTS% -
Dcatalina.base="%CATALINA_BASE%" -Dcatalina.home="%CATALINA_HOME%" 
org.apache.catalina.startup.Bootstrap %2 %3 %4 %5 %6 %7 %8 %9 start
goto cleanup
:doRunSecure
%_RUNJAVA% -Xdebug -Djava.compiler=NONE -Xnoagent -
Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=5000 %CATALINA_OPTS% -
Djava.security.manager -Djava.security.policy=="%
CATALINA_BASE%/conf/catalina.policy" -Dcatalina.base="%CATALINA_BASE%" -
Dcatalina.home="%CATALINA_HOME%" org.apache.catalina.startup.Bootstrap %3 %4 %5 
%6 %7 %8 %9 start
goto cleanup

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/core Constants.java

[marcsaeg]

marcsaeg01/11/20 06:53:18

  Modified:src/webpages Tag: tomcat_32 index.html
   src/share/org/apache/tomcat/core Tag: tomcat_32
Constants.java
  Log:
  Updated version numbers for Tomcat 3.2.4 release.
  
  Revision  ChangesPath
  No   revision
  
  
  No   revision
  
  
  1.13.2.23 +2 -2  jakarta-tomcat/src/webpages/index.html
  
  Index: index.html
  ===
  RCS file: /home/cvs/jakarta-tomcat/src/webpages/index.html,v
  retrieving revision 1.13.2.22
  retrieving revision 1.13.2.23
  diff -u -r1.13.2.22 -r1.13.2.23
  --- index.html2001/10/26 15:55:11 1.13.2.22
  +++ index.html2001/11/20 14:53:18 1.13.2.23
  @@ -4,13 +4,13 @@
   
   
   
  -Tomcat v3.2.4 beta 1
  +Tomcat v3.2.4
   
   
   Tomcat 
   
   Version
  -3.2.4 beta 1
  +3.2.4
   This is the default Tomcat home page. This page serves as a quick reference
   guide to related resources and is located at:
   
  
  
  
  No   revision
  
  
  No   revision
  
  
  1.22.2.21 +1 -1  
jakarta-tomcat/src/share/org/apache/tomcat/core/Attic/Constants.java
  
  Index: Constants.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/core/Attic/Constants.java,v
  retrieving revision 1.22.2.20
  retrieving revision 1.22.2.21
  diff -u -r1.22.2.20 -r1.22.2.21
  --- Constants.java2001/10/26 15:55:11 1.22.2.20
  +++ Constants.java2001/11/20 14:53:18 1.22.2.21
  @@ -67,7 +67,7 @@
   
   public class Constants {
   public static final String TOMCAT_NAME = "Tomcat Web Server";
  -public static final String TOMCAT_VERSION = "3.2.4 beta 1";
  +public static final String TOMCAT_VERSION = "3.2.4";
   
   public static final String JSP_NAME = "JSP";
   public static final String JSP_VERSION = "1.1";
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 4975] New: - Connection closed before response is sent

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4975

Connection closed before response is sent

   Summary: Connection closed before response is sent
   Product: Tomcat 3
   Version: 3.3 Final
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Unknown
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


If a Servlet's service() method returns very early (just setting
response code, not doing IO on the response), the client of the
Http10Adaptor sometimes sees a closed socket before the response 
is recieved.

Adding a Thread.yield() to the servlet's service() method helps.
The effect is not noticeable when the servlet yields.

This looks like a race condition in conjunction with Thread scheduler
timing.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

[RESULTS] Tomcat 3.2.4 release

[Marc Saegesser]

Here are the results of the vote to release the tomcat_32 branch as Tomcat
3.2.4.  I'll cut the release today.


[8] +1.  I agree with the proposal and I will help support
 the release.
[3] +0.  I agree with the proposal but I will not be able
 to help support the release.
[0] -0.  I don't agree with the proposal but I won't stop
 the release.
[0] -1.  I disagree with the proposal and will explain my
 reasons.


Marc Saegesser 

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: [VOTE] New committer: Michael Smith

[Marc Saegesser]

+1


Marc Saegesser 

> -Original Message-
> From: Remy Maucherat [mailto:[EMAIL PROTECTED]]
> Sent: Monday, November 19, 2001 12:29 PM
> To: Tomcat Developers List
> Subject: [VOTE] New committer: Michael Smith
> 
> 
> Hi,
> 
> I'd like to nominate Michael Smith [msmith at apache.org] as 
> a committer on
> the Tomcat subproject. Michael already has commit access on the Slide
> subproject, and has contributed important bug fixes for 
> Tomcat 4 as well as
> mod_jk.
> 
> He has my +1.
> 
> Remy
> 
> 
> --
> To unsubscribe, e-mail:   
> 
> For additional commands, e-mail: 
> 
> 

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/webapps/admin error.jsp

[patrickl]

patrickl01/11/20 05:57:44

  Modified:webapps/admin error.jsp
  Log:
  Change link to "/" to try login again. Old use of "/logOut.do" forced a user to 
login twice after clicking on this link.
  
  Revision  ChangesPath
  1.5   +1 -1  jakarta-tomcat-4.0/webapps/admin/error.jsp
  
  Index: error.jsp
  ===
  RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/admin/error.jsp,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- error.jsp 2001/11/13 01:00:03 1.4
  +++ error.jsp 2001/11/20 13:57:44 1.5
  @@ -21,7 +21,7 @@
 
 
 
  -  
  +  
   
 
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [PATCH] Watchdog 4.0 - Fix for Bugzilla 3904

[Ryan Lubke]

Apologies,

I attached the wrong patch in the previous email.  The correct
patch for Bugzilla 3904 is now attached.

-rl

On Tue, 2001-11-20 at 09:07, Ryan Lubke wrote:
> GTest currently verifies response headers in a case sensative
> manner.  This patch resolves the issue.
> 
> Fix is based of suggested fix in Bug report.
> 
> Comments welcome.
> 
> -rl
> 
> 
> 
> 
> 
> 
> 

> Index: GTest.java
> ===
> RCS file: 
>/home/cvspublic/jakarta-watchdog-4.0/src/tools/org/apache/tomcat/task/GTest.java,v
> retrieving revision 1.3
> diff -u -r1.3 GTest.java
> --- GTest.java2001/09/28 04:09:56 1.3
> +++ GTest.java2001/11/19 21:36:00
> @@ -15,6 +15,11 @@
>  
>  // derived from Jsp
>  public class GTest extends Task {
> +
> +private static final String ZEROS = "";
> +private static final int SHORTPADSIZE = 4;
> +private static final int BYTEPADSIZE = 2;
> +
>  String prefix="http://localhost:8080/test";;
>  String host="localhost";
>  int port=8080;
> @@ -376,9 +381,9 @@
>   boolean cmp=true;
>   
>   if(exactMatch)
> - cmp=compare(responseBody, expResult.toString() );
> + cmp=compare(responseBody.getBytes(), expResult.toString().getBytes() );
>   else
> - cmp=compareWeek( responseBody, expResult.toString());
> + cmp=compareWeak( responseBody, expResult.toString());
>   
>   if( cmp  != testCondition ) {
>   responseStatus = false;
> @@ -521,30 +526,200 @@
>  }
>  }
>  
> +/*
> + * compare compares the two byte arrays passed
> + * in to verify that the lengths of the arrays are equal, and
> + * that the content of the two arrays, byte for byte are equal.
> + *
> + * @param fromServer a byte[] value
> + * @param fromGoldenFile a byte[] value
> + * @return boolean true if equal, otherwise false
> + */
> +private boolean compare( byte[] fromServer, byte[] fromGoldenFile ) {
> +if ( fromServer == null || fromGoldenFile == null ) {
> +return false;
> +}   
> +
> +/*
> + * Check to see that the respose and golden file lengths
> + * are equal.  If they are not, dump the hex and don't
> + * bother comparing the bytes.  If they are equal,
> + * iterate through the byte arrays and compare each byte.
> + * If the bytes don't match, dump the hex representation
> + * of the server response and the goldenfile and return
> + * false.
> + */
> +
> +if ( fromServer.length != fromGoldenFile.length ) {
> +StringBuffer sb = new StringBuffer( 50 );
> +sb.append( "Response and golden file lengths do not match!\n" );
> +sb.append( "Server response length: " );
> +sb.append( fromServer.length );
> +sb.append( "\nGoldenfile length: " );
> +sb.append( fromGoldenFile.length );
> +System.out.println( sb.toString() );
> +sb = null;
> +// dump the hex representation of the byte arrays
> +dumpHex( fromServer, fromGoldenFile );
> +
> +return false;
> +
> +} else {
> +
> +int i = 0;
> +int j = 0;
> +
> +while ( ( i < fromServer.length ) && ( j < fromGoldenFile.length ) ) {
> +if ( fromServer[ i ] != fromGoldenFile[ j ] ) {
> +System.out.println( "Error at position " + ( i + 1 ) );
>  
> -// Compare the actual result and the expected result.
> -private boolean compare(String str1, String str2) {
> - //System.out.println("In compare");
> - if ( str1==null || str2==null) return false;
> - if ( str1.length() != str2.length() ) {
> - System.out.println("Wrong size " + str1.length() +" " + str2.length() );
> - return false;
> - }
> - 
> -for(int i=0; i -if (str1.charAt( i ) != str2.charAt( i ) ) {
> - System.out.println("Error at " + i  + " " + str1.charAt(1) +
> -str2.charAt(i));
> -return false;
> +// dump the hex representation of the byte arrays
> +dumpHex( fromServer, fromGoldenFile );
> +
> +return false;
> +}
> +
> +i++;
> +j++;
> +}
> +}
> +
> +return true;
> +}
> +
> +/*
> + * dumpHex helper method to dump formatted
> + * hex output of the server response and the goldenfile.
> + *
> + * @param serverResponse a byte[] value
> + * @param goldenFile a byte[] value
> + */
> +private void dumpHex( byte[] serverResponse, byte[] goldenFile ) {
> +StringBuffer outBuf = new StringBuffer( ( serverResponse.length + 
>goldenFile.length ) * 2 );
> +
> +String fromServerString = getHexValue( serverResponse, 0

[PATCH] Watchdog 4.0 - Fix for Bugzilla 3904

[Ryan Lubke]

GTest currently verifies response headers in a case sensative
manner.  This patch resolves the issue.

Fix is based of suggested fix in Bug report.

Comments welcome.

-rl







Index: GTest.java
===
RCS file: 
/home/cvspublic/jakarta-watchdog-4.0/src/tools/org/apache/tomcat/task/GTest.java,v
retrieving revision 1.3
diff -u -r1.3 GTest.java
--- GTest.java  2001/09/28 04:09:56 1.3
+++ GTest.java  2001/11/19 21:36:00
@@ -15,6 +15,11 @@
 
 // derived from Jsp
 public class GTest extends Task {
+
+private static final String ZEROS = "";
+private static final int SHORTPADSIZE = 4;
+private static final int BYTEPADSIZE = 2;
+
 String prefix="http://localhost:8080/test";;
 String host="localhost";
 int port=8080;
@@ -376,9 +381,9 @@
boolean cmp=true;

if(exactMatch)
-   cmp=compare(responseBody, expResult.toString() );
+   cmp=compare(responseBody.getBytes(), expResult.toString().getBytes() );
else
-   cmp=compareWeek( responseBody, expResult.toString());
+   cmp=compareWeak( responseBody, expResult.toString());

if( cmp  != testCondition ) {
responseStatus = false;
@@ -521,30 +526,200 @@
 }
 }
 
+/*
+ * compare compares the two byte arrays passed
+ * in to verify that the lengths of the arrays are equal, and
+ * that the content of the two arrays, byte for byte are equal.
+ *
+ * @param fromServer a byte[] value
+ * @param fromGoldenFile a byte[] value
+ * @return boolean true if equal, otherwise false
+ */
+private boolean compare( byte[] fromServer, byte[] fromGoldenFile ) {
+if ( fromServer == null || fromGoldenFile == null ) {
+return false;
+}   
+
+/*
+ * Check to see that the respose and golden file lengths
+ * are equal.  If they are not, dump the hex and don't
+ * bother comparing the bytes.  If they are equal,
+ * iterate through the byte arrays and compare each byte.
+ * If the bytes don't match, dump the hex representation
+ * of the server response and the goldenfile and return
+ * false.
+ */
+
+if ( fromServer.length != fromGoldenFile.length ) {
+StringBuffer sb = new StringBuffer( 50 );
+sb.append( "Response and golden file lengths do not match!\n" );
+sb.append( "Server response length: " );
+sb.append( fromServer.length );
+sb.append( "\nGoldenfile length: " );
+sb.append( fromGoldenFile.length );
+System.out.println( sb.toString() );
+sb = null;
+// dump the hex representation of the byte arrays
+dumpHex( fromServer, fromGoldenFile );
+
+return false;
+
+} else {
+
+int i = 0;
+int j = 0;
+
+while ( ( i < fromServer.length ) && ( j < fromGoldenFile.length ) ) {
+if ( fromServer[ i ] != fromGoldenFile[ j ] ) {
+System.out.println( "Error at position " + ( i + 1 ) );
 
-// Compare the actual result and the expected result.
-private boolean compare(String str1, String str2) {
-   //System.out.println("In compare");
-   if ( str1==null || str2==null) return false;
-   if ( str1.length() != str2.length() ) {
-   System.out.println("Wrong size " + str1.length() +" " + str2.length() );
-   return false;
-   }
-   
-for(int i=0; idumpHex helper method to dump formatted
+ * hex output of the server response and the goldenfile.
+ *
+ * @param serverResponse a byte[] value
+ * @param goldenFile a byte[] value
+ */
+private void dumpHex( byte[] serverResponse, byte[] goldenFile ) {
+StringBuffer outBuf = new StringBuffer( ( serverResponse.length + 
+goldenFile.length ) * 2 );
+
+String fromServerString = getHexValue( serverResponse, 0, 
+serverResponse.length );
+String fromGoldenFileString = getHexValue( goldenFile, 0, goldenFile.length );
+
+outBuf.append( "Hex dump of server response and goldenfile below.\n\n### 
+RESPONSE FROM SERVER ###\n" );
+outBuf.append( "\n" );
+outBuf.append( fromServerString );
+outBuf.append( "\n\n### GOLDEN FILE ###\n" );
+outBuf.append( "---\n" );
+outBuf.append( fromGoldenFileString );
+outBuf.append( "\n\n### END OF DUMP ###\n" );
+
+System.out.println( outBuf.toString() );
+
+}
+
+/*
+ * getHexValue displays a formatted hex
+ * representation of the passed byte array.  It also
+ * allows for only a specified offset and length of 
+ * a particular array to be returned.
+ *
+ * @param bytes byte[] array to process.
+ * @param pos int specifies offset to begin processing.
+ *

AW: Session variables in TC 4.0.1 realms

[Andreas Graichen]

I managed my problem to get the session whithin a realm by modifying
realm.java, writing a custom realm and a custom FormAuthenticator to have an
authenticate() with an additional HttpServletRequest parameter. However, I
will spend some more time to put this into an Authenticator...

The problem that I realized now is that if you login successfully and go
back using the browsers back button and then login again (with the same user
name and passwort, without destroying the session) you get an 404
j_security_check not avaiable! This is also in the original TC4.0
distribution (examples/jsp/security/protected). Is this a known problem or
what am I doing wrong?

Andreas






-Ursprungliche Nachricht-
Von: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED]]Im Auftrag von Craig R. McClanahan
Gesendet: Mittwoch, 14. November 2001 18:06
An: Tomcat Developers List; Graichen, Andreas
Betreff: Re: Session variables in TC 4.0.1 realms




On Mon, 12 Nov 2001, Andreas Graichen wrote:

> Date: Mon, 12 Nov 2001 12:49:00 +0100
> From: Andreas Graichen <[EMAIL PROTECTED]>
> Reply-To: Tomcat Developers List <[EMAIL PROTECTED]>,
>  [EMAIL PROTECTED]
> To: [EMAIL PROTECTED]
> Subject: Session variables in TC 4.0.1 realms
>
> Hi,
>
> I'm going to develop an authentication realm (based on FORM
authentication)
> for TC 4.0.1 which performs a kind of challenge/response task: Put a
> challange into a session variable on the login page (.jsp). The expected
> password would then be the encrypted challenge. Whithin my realm the
> decryption of the response and the verification against the stored session
> variable has to be performed. The problem is that the HTTP request is not
> accessible whithin TC 4.x realms. This was possible in TC 3.x. Is there
any
> possibility to access a session variable in a TC 4.x custom realm? Thank
> you.
>

It sounds like you really want to create an Authenticator, not a Realm.
You might also want to look at how DigestAuthenticator (which implements
DIGEST login) deals with encrypted passwords coming in.

Authenticators *do* things -- they actively decide whether a user has
already been authenticated, and challenge him/her if not.  And, of course,
they have full access to the request and response (because they are
Valves).  The programming model for Valves is similar to that of Filters
at the application level -- so Authenticators can (and do, if you look at
the existing implementations) intercept the request and create
authentication challenges back again.

Realms are just a place to look up users and check their passwords.  Think
of a Realm as a database, not a participant in request processing.  It's
an interface to *any* underlying storage mechanism -- a black box that
says "yes, this user is valid" or "no, this user is not valid."

In Tomcat 4, these concepts are separate from each other, because you
really want to be able to mix and match *any* Authenticator with *any*
Realm.  In Tomcat 3.2, the concepts are mashed together in one class,
which was totally messed up IMHO.

> Andreas Graichen
>

Craig


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

[PATCH] Watchdog 4.0 - Fix for Bugzilla 3527

[Ryan Lubke]

Classes referenced by TLD are not in the repository.  As stated in the
bug, some containers are very strict about having all classes available
that are referenced in a TLD.

The included patches removed the unused references from the TLDs.

Comments welcome.

-rl




Index: tld_uri.tld
===
RCS file: 
/home/cvspublic/jakarta-watchdog-4.0/src/server/jsp-tests/WEB-INF/tlds/tld_uri.tld,v
retrieving revision 1.2
diff -u -r1.2 tld_uri.tld
--- tld_uri.tld 2000/11/30 23:53:58 1.2
+++ tld_uri.tld 2001/11/20 12:34:42
@@ -16,22 +16,7 @@
   
A simple tab library for testing computation of TLD Resource Path 
   
-
-  tags.TagLibraryValidator.Validator
-
-usa
-Washington
-Capital
-
-
-india
-New Delhi
-Capital
-
-
 
-
-  
   
 tldtag
 tags.tld_resource_path.tld_URI


Index: TestLib.tld
===
RCS file: 
/home/cvspublic/jakarta-watchdog-4.0/src/server/jsp-tests/WEB-INF/tlds/TestLib.tld,v
retrieving revision 1.8
diff -u -r1.8 TestLib.tld
--- TestLib.tld 2000/12/01 00:19:25 1.8
+++ TestLib.tld 2001/11/20 12:34:30
@@ -201,24 +201,6 @@
   
 
 
-propertyEditor
-tags.PropertyEditorTag
-
-A tag that Uses ProprtyEditorSupport class
-
-
-
-  url
-  false
-
-
-
-  locale
-  false
-
-
-
-
 iterator
 tags.SimpleIteratorTag
 
@@ -310,21 +292,5 @@
   true
 
 
-
-
-thirdWinner
-tags.TagSupport.thirdPrizeTag
-
-A tag that sets the third prize winner and also returns it to a   
-nested tag
-
-
-  winner
-  true
-
-
-
-
-
 
 



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 4969] New: - SSO cookie malformed in AuthenticatorBase.generateSessionId()

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4969

SSO cookie malformed in AuthenticatorBase.generateSessionId()

   Summary: SSO cookie malformed in
AuthenticatorBase.generateSessionId()
   Product: Tomcat 4
   Version: 4.0.1 Final
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


It looks to me like line 805 in AuthenticatorBase:
result.append((char) ('0' + (b2 - 10)));
should instead read
result.append((char) ('A' + (b2 - 10)));
to avoid potential session overlaps.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: [VOTE] New committer: Michael Smith

[Larry Isaacs]

+1

Larry

> -Original Message-
> From: Remy Maucherat [mailto:[EMAIL PROTECTED]]
> Sent: Monday, November 19, 2001 1:29 PM
> To: Tomcat Developers List
> Subject: [VOTE] New committer: Michael Smith
> 
> 
> Hi,
> 
> I'd like to nominate Michael Smith [msmith at apache.org] as 
> a committer on
> the Tomcat subproject. Michael already has commit access on the Slide
> subproject, and has contributed important bug fixes for 
> Tomcat 4 as well as
> mod_jk.
> 
> He has my +1.
> 
> Remy
> 
> 
> --
> To unsubscribe, e-mail:   
> 
> For additional commands, e-mail: 
> 
> 

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 4967] New: - ArrayIndexOutOfBoundsException in SimpleMapper1

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4967

ArrayIndexOutOfBoundsException in SimpleMapper1

   Summary: ArrayIndexOutOfBoundsException in SimpleMapper1
   Product: Tomcat 3
   Version: 3.3 Final
  Platform: Sun
OS/Version: Solaris
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Config
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Exception raised during context lookup in SimpleMapper1.
Not easily repeatable - I suspect this is due to multiple threads accessing the 
same SimpleHashtable while not synchronized.

2001-11-19 15:43:04 - SimpleMapper1: Mapping R( /RMS) - 
java.lang.ArrayIndexOutOfBoundsException
at org.apache.tomcat.util.collections.SimpleHashtable.hasMoreElements
(Unknown Source)
at org.apache.tomcat.util.collections.SimpleHashtable.keys(Unknown 
Source)
at org.apache.tomcat.modules.mappers.PrefixMapper.getLongestPrefixMatch
(Unknown Source)
at org.apache.tomcat.modules.mappers.SimpleMapper1.contextMap(Unknown 
Source)
at org.apache.tomcat.core.ContextManager.processRequest(Unknown Source)
at org.apache.tomcat.core.ContextManager.internalService(Unknown Source)
at org.apache.tomcat.core.ContextManager.service(Unknown Source)
at net.cp.bmg.tomcat.ContextServer.service(ContextServer.java:79)
at org.apache.tomcat.modules.server.Http10Interceptor.processConnection
(Unknown Source)
at net.cp.bmg.tomcat.HTTPConnector$TomcatConnector.processConnection
(HTTPConnector.java:85)
at org.apache.tomcat.util.net.TcpWorkerThread.runIt(Unknown Source)
at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run
(Unknown Source)
at java.lang.Thread.run(Thread.java:484)

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 4966] New: - request.getParameter(String) SOMETIMES fail to parse the querystring

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4966

request.getParameter(String) SOMETIMES fail to parse the querystring

   Summary: request.getParameter(String) SOMETIMES fail to parse the
querystring
   Product: Tomcat 4
   Version: 4.0.1 Final
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Setup: 
We have a servlet that is called (GET) by a shell-script every minute, always with the 
same URL. Every 25th reqeust or so, tomcat seems to fail parsing the querystring. The 
server is not under heavy load, the shell-script is the only client.

Code (servlet):
  protected void doGet(HttpServletRequest request, HttpServletResponse response)
  throws ServletException, IOException
  {
// get requests and features
String templateName = request.getParameter(URL_TEMPLATE);
String hintString = request.getParameter(URL_FORMAT);

// check template
if (templateName == null || templateName.equals(""))
{
  // debug för felet på prod6
  SystemLog.debug("Template missing in request 
["+request.getParameter(URL_TEMPLATE)+"] in ["+request.getQueryString()+"]");
  error("Template missing in request",request,response);
  return;
}

Output (SystemLog.debug is a simple System.out.println):
DEBUG msg:Template missing in request [null] in [t=billerud_day&f=pngm]

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 4964] New: - popBody() is called before doEndTag() is called in a BodyTag

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4964

popBody() is called before doEndTag() is called in a BodyTag

   Summary: popBody() is called before doEndTag() is called in a
BodyTag
   Product: Tomcat 4
   Version: 4.0.1 Final
  Platform: All
OS/Version: All
Status: NEW
  Severity: Major
  Priority: Other
 Component: Jasper
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


popBody() is called before doEndTag() is called in a BodyTag.

This seems to contradicts with the JSP 1.2 spec.
Section JSP.10.2 (page 182):
"The content of a BodyContent instance remains available until after the
invocation of its associated doEndBody() method."

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Tomcat 4 / IIS connectivity document

[GOMEZ Henri]

A great documentation live here :

http://www.vacodi.com/howto/tomcat/iisnt/index.html



-
Henri Gomez ___[_]
EMAIL : [EMAIL PROTECTED](. .) 
PGP KEY : 697ECEDD...oOOo..(_)..oOOo...
PGP Fingerprint : 9DF8 1EA8 ED53 2F39 DC9B 904A 364F 80E6 

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: [VOTE] New committer: Michael Smith

[GOMEZ Henri]

>I'd like to nominate Michael Smith [msmith at apache.org] as a 
>committer on
>the Tomcat subproject. Michael already has commit access on the Slide
>subproject, and has contributed important bug fixes for Tomcat 
>4 as well as
>mod_jk.
>

+1, welcome on board and thanks for the patch in JTC :)

--
To unsubscribe, e-mail:   
For additional commands, e-mail: