DO NOT REPLY [Bug 13832] - handshake security error when user accessing http://localhost:8443

2002-10-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13832

handshake security error when user accessing http://localhost:8443





--- Additional Comments From [EMAIL PROTECTED]  2002-10-22 07:43 ---
Ah, you're being rough on poor Amy.  If it's her itch, let her scratch it.

The NPE is simple, and should probably be patched.  I don't know any way to 
convert an SSLSocket to a PlainSocket to give the nice, pretty, error message 
that Apache/httpd does for this case.  However, catching the exception on the 
handshake, closing the socket, and re-throwing looks like a viable alternative 
to me (since, from the report, the socket isn't closed in this case).

Amy: Please give your JVM/JSSE version for SSL-related bugs.  It's too hard to 
track otherwise.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 13827] - mod_jk load balancing does not set proper JSESSIONID with tomcat 4.x

2002-10-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13827

mod_jk load balancing does not set proper JSESSIONID with tomcat 4.x

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2002-10-22 07:58 ---
This looks invalid. You need to set the "jvmRoute" attribute on the Engine element.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Protocol.java

2002-10-22 Thread remm
remm2002/10/22 02:23:32

  Modified:http11/src/java/org/apache/coyote/http11 Http11Protocol.java
  Log:
  - Decrease amount of logging (client disconnects are normal, so they should
have DEBUG level IMO).
  
  Revision  ChangesPath
  1.16  +0 -4  
jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Protocol.java
  
  Index: Http11Protocol.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Protocol.java,v
  retrieving revision 1.15
  retrieving revision 1.16
  diff -u -r1.15 -r1.16
  --- Http11Protocol.java   7 Jun 2002 00:48:21 -   1.15
  +++ Http11Protocol.java   22 Oct 2002 09:23:32 -  1.16
  @@ -394,15 +394,11 @@
   TcpConnection.shutdownInput( socket );
   } catch(java.net.SocketException e) {
   // SocketExceptions are normal
  -proto.log.info(sm.getString
  -   ("http11protocol.proto.socketexception.info"));
   proto.log.debug
   (sm.getString
("http11protocol.proto.socketexception.debug"), e);
   } catch (java.io.IOException e) {
   // IOExceptions are normal 
  -proto.log.info(sm.getString
  -   ("http11protocol.proto.ioexception.info"));
   proto.log.debug
   (sm.getString
("http11protocol.proto.ioexception.debug"), e);
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 13832] - handshake security error when user accessing http://localhost:8443

2002-10-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13832

handshake security error when user accessing http://localhost:8443





--- Additional Comments From [EMAIL PROTECTED]  2002-10-22 09:27 ---
Ah, ok, the NPE is the actual bug then. This is not crystal clear in the report
(and I don't quite see the need of filing one; it looks like an easy fix).

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2002-10-22 Thread remm
remm2002/10/22 02:42:49

  Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
  Log:
  - Fix NPE (bug 13842).
  - Remove useless logging (maybe the hadshake failure should be an INFO).
  - Make sure socket is correctly closed in all cases.
  - Tighten up exception handling.
  
  Revision  ChangesPath
  1.6   +26 -9 
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java
  
  Index: PoolTcpEndpoint.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- PoolTcpEndpoint.java  19 Oct 2002 09:30:37 -  1.5
  +++ PoolTcpEndpoint.java  22 Oct 2002 09:42:48 -  1.6
  @@ -510,9 +510,18 @@

try {
if(endpoint.getServerSocketFactory()!=null) {
  - endpoint.getServerSocketFactory().handshake(s);
  +endpoint.getServerSocketFactory().handshake(s);
}
  - 
  +} catch (Throwable t) {
  +endpoint.log("Handshake failed", t, Log.DEBUG);
  +// Try to close the socket
  +try {
  +s.close();
  +} catch (IOException e) {}
  +continue;
  +}
  +
  +try {
if( usePool ) {
con=(TcpConnection)connectionCache.get();
if( con == null ) 
  @@ -526,11 +535,19 @@
con.setSocket(s);
endpoint.setSocketOptions( s );
endpoint.getConnectionHandler().processConnection(con, perThrData);
  - } catch (IOException e){
  - endpoint.log("Handshake failed",e,Log.ERROR);
  +} catch (Throwable t) {
  +endpoint.log("Unexpected error", t, Log.ERROR);
  +// Try to close the socket
  +try {
  +s.close();
  +} catch (IOException e) {}
   } finally {
  -con.recycle();
  -if( usePool && con != null ) connectionCache.put(con);
  +if (con != null) {
  +con.recycle();
  +if (usePool) {
  +connectionCache.put(con);
  +}
  +}
   }
   break;
}
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 13832] - handshake security error when user accessing http://localhost:8443

2002-10-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13832

handshake security error when user accessing http://localhost:8443





--- Additional Comments From [EMAIL PROTECTED]  2002-10-22 09:44 ---
Since I've been bad, I just committed a fix. I think it fixes the issues raised
by Bill.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: DO NOT REPLY [Bug 13827] - mod_jk load balancing does notset proper JSESSIONID with tomcat 4.x

2002-10-22 Thread Henri Gomez
[EMAIL PROTECTED] wrote:

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.



--- Additional Comments From [EMAIL PROTECTED]  2002-10-22 07:58 ---
This looks invalid. You need to set the "jvmRoute" attribute on the Engine element.


Right, I didn't see the ref on jvmroute in documentation :

http://jakarta.apache.org/tomcat/tomcat-4.1-doc/config/jk.html

http://jakarta.apache.org/tomcat/tomcat-4.1-doc/config/engine.html

I'll add it as comment in server.xml to help users locate it


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-4.0/catalina/src/conf server.xml

2002-10-22 Thread hgomez
hgomez  2002/10/22 02:45:35

  Modified:catalina/src/conf server.xml
  Log:
  Add comment about jvmroute in Engine to use jk/jk2 load-balancing
  
  Revision  ChangesPath
  1.63  +4 -0  jakarta-tomcat-4.0/catalina/src/conf/server.xml
  
  Index: server.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-4.0/catalina/src/conf/server.xml,v
  retrieving revision 1.62
  retrieving revision 1.63
  diff -u -r1.62 -r1.63
  --- server.xml16 Aug 2002 20:19:32 -  1.62
  +++ server.xml22 Oct 2002 09:45:34 -  1.63
  @@ -149,6 +149,10 @@
analyzes the HTTP headers included with the request, and passes them
on to the appropriate Host (virtual host). -->
   
  + 
  + 
   
   
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-catalina/catalina/src/conf server.xml

2002-10-22 Thread hgomez
hgomez  2002/10/22 02:48:15

  Modified:catalina/src/conf server.xml
  Log:
  Add comment about jvmroute in Engine to use jk/jk2 load-balancing
  
  Revision  ChangesPath
  1.9   +4 -0  jakarta-tomcat-catalina/catalina/src/conf/server.xml
  
  Index: server.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/conf/server.xml,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- server.xml11 Oct 2002 08:54:12 -  1.8
  +++ server.xml22 Oct 2002 09:48:15 -  1.9
  @@ -126,6 +126,10 @@
analyzes the HTTP headers included with the request, and passes them
on to the appropriate Host (virtual host). -->
   
  + 
  + 
   
   
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 13843] New: - Jasper locks big files at runtime

2002-10-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13843

Jasper locks big files at runtime

   Summary: Jasper locks big files at runtime
   Product: Tomcat 4
   Version: 4.1.12
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Jasper 2
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Some JSP are locked by Tomcat at runtime. The file is locked after the first
access to the web page with the browser.

After investigation I found that the following code performs the lock on some
files: 

Class org.apache.servlet.JspServlet

private void serviceJspFile(HttpServletRequest request,
HttpServletResponse response, String jspUri,
Throwable exception, boolean precompile)
throws ServletException, IOException {

   JspServletWrapper wrapper =
(JspServletWrapper) rctxt.getWrapper(jspUri);
   if (wrapper == null) {
   // First check if the requested JSP page exists, to avoid
   // creating unnecessary directories and files.

   if (context.getResourceAsStream(jspUri)== null) {
  response.sendError(HttpServletResponse.SC_NOT_FOUND, jspUri);
  return;
   }
   .


context.getResourceAsStream(jspUri) locks some files on Windows. It seems to be
related to file size. I tried on a dumb big page filled with only text (50ko):
it locks, with the same page with less text (5ko) the page is not locked.

As a concequence, the opened inputStream should be closed even if it is not read.
The following code do not lock files anymore:

   java.io.InputStream resourceStream=context.getResourceAsStream(jspUri);
   if (resourceStream == null) {
   response.sendError(HttpServletResponse.SC_NOT_FOUND, jspUri);
   return;
}else{
try{
resourceStream.close();
}catch(IOException e) { /* ignore */ }
}

IMPORTANT: to reproduce problem. Files seems not be locked on a new compiled
page. After modiying a JSP, restart Tomcat, access the web page and check if you
can rename the corresponding JSP file.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_map.c

2002-10-22 Thread mturk
mturk   2002/10/22 03:06:55

  Modified:jk/native2/common jk_map.c
  Log:
  Fix the stupid MSVC CR+LF line endings.
  
  Revision  ChangesPath
  1.23  +39 -39jakarta-tomcat-connectors/jk/native2/common/jk_map.c
  
  Index: jk_map.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_map.c,v
  retrieving revision 1.22
  retrieving revision 1.23
  diff -u -r1.22 -r1.23
  --- jk_map.c  18 Oct 2002 11:45:25 -  1.22
  +++ jk_map.c  22 Oct 2002 10:06:55 -  1.23
  @@ -78,40 +78,40 @@
   int size;
   } jk_map_private_t;
   
  -#if APR_CHARSET_EBCDIC
  -#define CASE_MASK 0xbfbfbfbf
  -#else
  -#define CASE_MASK 0xdfdfdfdf
  -#endif
  -
  -/* Compute the "checksum" for a key, consisting of the first
  - * 4 bytes, normalized for case-insensitivity and packed into
  - * an int...this checksum allows us to do a single integer
  - * comparison as a fast check to determine whether we can
  - * skip a strcasecmp
  - */
  -#define COMPUTE_KEY_CHECKSUM(key, checksum)\
  -{  \
  -const char *k = (key); \
  -apr_uint32_t c = (apr_uint32_t)*k; \
  -(checksum) = c;\
  -(checksum) <<= 8;  \
  -if (c) {   \
  -c = (apr_uint32_t)*++k;\
  -checksum |= c; \
  -}  \
  -(checksum) <<= 8;  \
  -if (c) {   \
  -c = (apr_uint32_t)*++k;\
  -checksum |= c; \
  -}  \
  -(checksum) <<= 8;  \
  -if (c) {   \
  -c = (apr_uint32_t)*++k;\
  -checksum |= c; \
  -}  \
  -checksum &= CASE_MASK; \
  -}
  +#if APR_CHARSET_EBCDIC
  +#define CASE_MASK 0xbfbfbfbf
  +#else
  +#define CASE_MASK 0xdfdfdfdf
  +#endif
  +
  +/* Compute the "checksum" for a key, consisting of the first
  + * 4 bytes, normalized for case-insensitivity and packed into
  + * an int...this checksum allows us to do a single integer
  + * comparison as a fast check to determine whether we can
  + * skip a strcasecmp
  + */
  +#define COMPUTE_KEY_CHECKSUM(key, checksum)\
  +{  \
  +const char *k = (key); \
  +apr_uint32_t c = (apr_uint32_t)*k; \
  +(checksum) = c;\
  +(checksum) <<= 8;  \
  +if (c) {   \
  +c = (apr_uint32_t)*++k;\
  +checksum |= c; \
  +}  \
  +(checksum) <<= 8;  \
  +if (c) {   \
  +c = (apr_uint32_t)*++k;\
  +checksum |= c; \
  +}  \
  +(checksum) <<= 8;  \
  +if (c) {   \
  +c = (apr_uint32_t)*++k;\
  +checksum |= c; \
  +}  \
  +checksum &= CASE_MASK; \
  +}
   
   static void *jk2_map_default_get(jk_env_t *env, jk_map_t *m,
const char *name)
  @@ -124,7 +124,7 @@
   return NULL;
   mPriv=(jk_map_private_t *)m->_private;
   
  -COMPUTE_KEY_CHECKSUM(name, checksum);
  +COMPUTE_KEY_CHECKSUM(name, checksum);
   
   for(i = 0 ; i < mPriv->size ; i++) {
   if (mPriv->keys[i] == checksum && 
  @@ -198,7 +198,7 @@
   
   mPriv=(jk_map_private_t *)m->_private;
   
  -COMPUTE_KEY_CHECKSUM(name, checksum);
  +COMPUTE_KEY_CHECKSUM(name, checksum);
   
   for(i = 0 ; i < mPriv->size ; i++) {
   if (mPriv->keys[i] == checksum && 
  @@ -248,8 +248,8 @@
   
   if(mPriv->size < mPriv->capacity) {
   apr_uint32_t checksum;
  -
  -COMPUTE_KEY_CHECKSUM(name, checksum);
  +
  +COMPUTE_KEY_CHECKSUM(name, checksum);
   mPriv->values[mPriv->size] = value;
   /* XXX this is wrong - either we take ownership and copy both
  name and value,
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_uriMap.c jk_uriEnv.c

2002-10-22 Thread mturk
mturk   2002/10/22 03:11:44

  Modified:jk/native2/common jk_uriMap.c jk_uriEnv.c
  Log:
  Fix the stupid MSVC CR+LF line endings.
  
  Revision  ChangesPath
  1.57  +15 -15jakarta-tomcat-connectors/jk/native2/common/jk_uriMap.c
  
  Index: jk_uriMap.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_uriMap.c,v
  retrieving revision 1.56
  retrieving revision 1.57
  diff -u -r1.56 -r1.57
  --- jk_uriMap.c   21 Oct 2002 18:05:13 -  1.56
  +++ jk_uriMap.c   22 Oct 2002 10:11:43 -  1.57
  @@ -328,21 +328,21 @@
   static jk_uriEnv_t *jk2_uriMap_regexpMap(jk_env_t *env, jk_uriMap_t *uriMap,
jk_map_t *mapTable, const char *uri) 
   {
  -int i;
  -int sz = mapTable->size(env, mapTable);
  -
  -for (i = 0; i < sz; i++) {
  -jk_uriEnv_t *uwr = mapTable->valueAt(env, mapTable, i);
  -
  -if (uwr->regexp) {
  -regex_t *r = (regex_t *)uwr->regexp;
  -regmatch_t regm[10];
  -if (!regexec(r, uri, r->re_nsub + 1, regm, 0)) {
  -return uwr;
  -}
  -}
  -}
  -return NULL;
  +int i;
  +int sz = mapTable->size(env, mapTable);
  +
  +for (i = 0; i < sz; i++) {
  +jk_uriEnv_t *uwr = mapTable->valueAt(env, mapTable, i);
  +
  +if (uwr->regexp) {
  +regex_t *r = (regex_t *)uwr->regexp;
  +regmatch_t regm[10];
  +if (!regexec(r, uri, r->re_nsub + 1, regm, 0)) {
  +return uwr;
  +}
  +}
  +}
  +return NULL;
   
   }
   #else
  
  
  
  1.40  +3 -3  jakarta-tomcat-connectors/jk/native2/common/jk_uriEnv.c
  
  Index: jk_uriEnv.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_uriEnv.c,v
  retrieving revision 1.39
  retrieving revision 1.40
  diff -u -r1.39 -r1.40
  --- jk_uriEnv.c   21 Oct 2002 18:05:13 -  1.39
  +++ jk_uriEnv.c   22 Oct 2002 10:11:44 -  1.40
  @@ -147,11 +147,11 @@
   uri);
   {
   regex_t *preg = (regex_t *)uriEnv->pool->calloc( env, uriEnv->pool, 
sizeof(regex_t));
  -if (regcomp(preg, uriEnv->uri, REG_EXTENDED)) {
  +if (regcomp(preg, uriEnv->uri, REG_EXTENDED)) {
   env->l->jkLog(env, env->l, JK_LOG_DEBUG,
 "uriEnv.parseName() error compiling regexp %s\n",
  -  uri);
  - return JK_ERR;
  +  uri);
  + return JK_ERR;
   }
   uriEnv->regexp = preg;
   }
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet JspServlet.java

2002-10-22 Thread remm
remm2002/10/22 03:13:19

  Modified:jasper2/src/share/org/apache/jasper/servlet JspServlet.java
  Log:
  - Fix bug 13843 (locking of big JSP files).
  - Patch submitted by cmarton at calendra.com.
  
  Revision  ChangesPath
  1.13  +10 -4 
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JspServlet.java
  
  Index: JspServlet.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JspServlet.java,v
  retrieving revision 1.12
  retrieving revision 1.13
  diff -u -r1.12 -r1.13
  --- JspServlet.java   7 May 2002 03:15:53 -   1.12
  +++ JspServlet.java   22 Oct 2002 10:13:19 -  1.13
  @@ -67,6 +67,7 @@
   import javax.servlet.http.HttpServletRequest;
   import javax.servlet.http.HttpServletResponse;
   
  +import java.io.InputStream;
   import java.io.IOException;
   import java.io.FileNotFoundException;
   import java.net.URL;
  @@ -271,9 +272,14 @@
   if (wrapper == null) {
   // First check if the requested JSP page exists, to avoid
   // creating unnecessary directories and files.
  -if (context.getResourceAsStream(jspUri) == null) {
  +InputStream resourceStream = context.getResourceAsStream(jspUri);
  +if (resourceStream == null) {
   response.sendError(HttpServletResponse.SC_NOT_FOUND, jspUri);
   return;
  +} else {
  +try {
  +resourceStream.close();
  +} catch(IOException e) { /* ignore */ }
   }
   boolean isErrorPage = exception != null;
   synchronized(this) {
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet JspServlet.java

2002-10-22 Thread remm
remm2002/10/22 04:17:56

  Modified:jasper2/src/share/org/apache/jasper/servlet Tag:
tomcat_4_branch JspServlet.java
  Log:
  - Port patch.
  - Fix bug 13843 (locking of big JSP files).
  - Patch submitted by cmarton at calendra.com.
  
  Revision  ChangesPath
  No   revision
  
  
  No   revision
  
  
  1.12.2.1  +10 -4 
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JspServlet.java
  
  Index: JspServlet.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JspServlet.java,v
  retrieving revision 1.12
  retrieving revision 1.12.2.1
  diff -u -r1.12 -r1.12.2.1
  --- JspServlet.java   7 May 2002 03:15:53 -   1.12
  +++ JspServlet.java   22 Oct 2002 11:17:56 -  1.12.2.1
  @@ -67,6 +67,7 @@
   import javax.servlet.http.HttpServletRequest;
   import javax.servlet.http.HttpServletResponse;
   
  +import java.io.InputStream;
   import java.io.IOException;
   import java.io.FileNotFoundException;
   import java.net.URL;
  @@ -271,9 +272,14 @@
   if (wrapper == null) {
   // First check if the requested JSP page exists, to avoid
   // creating unnecessary directories and files.
  -if (context.getResourceAsStream(jspUri) == null) {
  +InputStream resourceStream = context.getResourceAsStream(jspUri);
  +if (resourceStream == null) {
   response.sendError(HttpServletResponse.SC_NOT_FOUND, jspUri);
   return;
  +} else {
  +try {
  +resourceStream.close();
  +} catch(IOException e) { /* ignore */ }
   }
   boolean isErrorPage = exception != null;
   synchronized(this) {
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 13843] - Jasper locks big files at runtime

2002-10-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13843

Jasper locks big files at runtime

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2002-10-22 11:19 ---


*** This bug has been marked as a duplicate of 12628 ***

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 12628] - Jasper puts a lock on .jsp pages that it has compiled

2002-10-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12628

Jasper puts a lock on .jsp pages that it has compiled

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2002-10-22 11:19 ---
*** Bug 13843 has been marked as a duplicate of this bug. ***

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




New W3 tag support request.

2002-10-22 Thread V. Cekvenich
One day W3.org will release xforms tag to replace the forms tag.

Here is a plug in for IE:
http://www.FormsPlayer.com
With great links.
Exciting.

Also http://jxforms.cybernd.at/ is also ok.

Yes, not released but... a feature request for next version. It puts a 
lot more procesing on the browser, thus making the server faster / more 
scalable.

.V




--
To unsubscribe, e-mail:   
For additional commands, e-mail: 



cvs commit: jakarta-tomcat-connectors/jk/native2/server/apache2 mod_jk2.dsp

2002-10-22 Thread mturk
mturk   2002/10/22 04:56:42

  Modified:jk/native2/server/apache2 mod_jk2.dsp
  Log:
  Added HAS_PCRE cause Apache2 comes with pcre.
  
  Revision  ChangesPath
  1.6   +6 -6  jakarta-tomcat-connectors/jk/native2/server/apache2/mod_jk2.dsp
  
  Index: mod_jk2.dsp
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/server/apache2/mod_jk2.dsp,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- mod_jk2.dsp   24 Sep 2002 13:22:14 -  1.5
  +++ mod_jk2.dsp   22 Oct 2002 11:56:42 -  1.6
  @@ -43,7 +43,7 @@
   # PROP Ignore_Export_Lib 0
   # PROP Target_Dir ""
   # ADD BASE CPP /nologo /MD /W3 /GX /O2 /D "WIN32" /D "NDEBUG" /D "_WINDOWS" /D 
"_MBCS" /D "_USRDLL" /D "MOD_JK2_EXPORTS" /YX /FD /c
  -# ADD CPP /nologo /MD /W3 /GX /O2 /I "..\..\include" /I "$(JAVA_HOME)\include" /I 
"$(JAVA_HOME)\include\win32" /I "$(APACHE2_HOME)\include" /I 
"$(APACHE2_HOME)\os\win32" /D "WIN32" /D "NDEBUG" /D "_WINDOWS" /D "_MBCS" /D 
"_USRDLL" /D "MOD_JK2_EXPORTS" /D "HAVE_JNI" /D "HAS_APR" /FR /YX /FD /c
  +# ADD CPP /nologo /MD /W3 /GX /O2 /I "..\..\include" /I "$(JAVA_HOME)\include" /I 
"$(JAVA_HOME)\include\win32" /I "$(APACHE2_HOME)\include" /I 
"$(APACHE2_HOME)\os\win32" /D "NDEBUG" /D "WIN32" /D "_WINDOWS" /D "_MBCS" /D 
"_USRDLL" /D "MOD_JK2_EXPORTS" /D "HAVE_JNI" /D "HAS_APR" /D "HAS_PCRE" /FR /YX /FD /c
   # ADD BASE MTL /nologo /D "NDEBUG" /mktyplib203 /win32
   # ADD MTL /nologo /D "NDEBUG" /mktyplib203 /win32
   # ADD BASE RSC /l 0xc0a /d "NDEBUG"
  @@ -53,7 +53,7 @@
   # ADD BSC32 /nologo
   LINK32=link.exe
   # ADD BASE LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib 
advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib 
/nologo /dll /machine:I386
  -# ADD LINK32 libhttpd.lib libapr.lib libaprutil.lib wsock32.lib advapi32.lib 
/nologo /dll /machine:I386 /libpath:"$(APACHE2_HOME)\lib"
  +# ADD LINK32 libhttpd.lib libapr.lib libaprutil.lib pcre.lib pcreposix.lib 
wsock32.lib advapi32.lib /nologo /dll /machine:I386 /libpath:"$(APACHE2_HOME)\lib"
   
   !ELSEIF  "$(CFG)" == "mod_jk2 - Win32 Debug"
   
  @@ -69,7 +69,7 @@
   # PROP Ignore_Export_Lib 0
   # PROP Target_Dir ""
   # ADD BASE CPP /nologo /MTd /W3 /Gm /GX /ZI /Od /D "WIN32" /D "_DEBUG" /D 
"_WINDOWS" /D "_MBCS" /D "_USRDLL" /D "MOD_JK2_EXPORTS" /YX /FD /GZ /c
  -# ADD CPP /nologo /MDd /W3 /Gm /GX /ZI /Od /I "..\..\include" /I 
"$(JAVA_HOME)\include" /I "$(JAVA_HOME)\include\win32" /I "$(APACHE2_HOME)\include" /I 
"$(APACHE2_HOME)\os\win32" /D "WIN32" /D "_DEBUG" /D "_WINDOWS" /D "_MBCS" /D 
"_USRDLL" /D "MOD_JK2_EXPORTS" /D "HAVE_JNI" /D "HAS_APR" /FR /YX /FD /GZ /c
  +# ADD CPP /nologo /MDd /W3 /Gm /GX /ZI /Od /I "..\..\include" /I 
"$(JAVA_HOME)\include" /I "$(JAVA_HOME)\include\win32" /I "$(APACHE2_HOME)\include" /I 
"$(APACHE2_HOME)\os\win32" /D "_DEBUG" /D "WIN32" /D "_WINDOWS" /D "_MBCS" /D 
"_USRDLL" /D "MOD_JK2_EXPORTS" /D "HAVE_JNI" /D "HAS_APR" /D "HAS_PCRE" /FR /YX /FD 
/GZ /c
   # SUBTRACT CPP /X
   # ADD BASE MTL /nologo /D "_DEBUG" /mktyplib203 /win32
   # ADD MTL /nologo /D "_DEBUG" /mktyplib203 /win32
  @@ -80,7 +80,7 @@
   # ADD BSC32 /nologo
   LINK32=link.exe
   # ADD BASE LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib 
advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib 
/nologo /dll /debug /machine:I386 /pdbtype:sept
  -# ADD LINK32 libhttpd.lib libapr.lib libaprutil.lib wsock32.lib advapi32.lib 
/nologo /dll /debug /machine:I386 /pdbtype:sept /libpath:"$(APACHE2_HOME)\lib"
  +# ADD LINK32 libhttpd.lib libapr.lib libaprutil.lib pcre.lib pcreposix.lib 
wsock32.lib advapi32.lib /nologo /dll /debug /machine:I386 /pdbtype:sept 
/libpath:"$(APACHE2_HOME)\lib"
   
   !ENDIF 
   
  @@ -370,7 +370,7 @@
   !IF  "$(CFG)" == "mod_jk2 - Win32 Release"
   
   # Begin Custom Build - Creating resources from $(InputPath)
  -InputDir=\tomcat\jakarta-tomcat-connectors\jk\native2\common
  +InputDir=\WORK\apache\jakarta-tomcat-connectors\jk\native2\common
   InputPath=..\..\common\jk_logger_win32_message.mc
   
   "..\..\common\jk_logger_win32_message.rc" : $(SOURCE) "$(INTDIR)" "$(OUTDIR)"
  @@ -381,7 +381,7 @@
   !ELSEIF  "$(CFG)" == "mod_jk2 - Win32 Debug"
   
   # Begin Custom Build - Creating resources from $(InputPath)
  -InputDir=\tomcat\jakarta-tomcat-connectors\jk\native2\common
  +InputDir=\WORK\apache\jakarta-tomcat-connectors\jk\native2\common
   InputPath=..\..\common\jk_logger_win32_message.mc
   
   "..\..\common\jk_logger_win32_message.rc" : $(SOURCE) "$(INTDIR)" "$(OUTDIR)"
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-connectors/jk/native2/server/isapi isapi.dsp

2002-10-22 Thread mturk
mturk   2002/10/22 04:57:33

  Modified:jk/native2/server/isapi isapi.dsp
  Log:
  Added HAS_PCRE cause Apache2 (required for build)
  comes with pcre.
  
  Revision  ChangesPath
  1.21  +12 -12jakarta-tomcat-connectors/jk/native2/server/isapi/isapi.dsp
  
  Index: isapi.dsp
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/server/isapi/isapi.dsp,v
  retrieving revision 1.20
  retrieving revision 1.21
  diff -u -r1.20 -r1.21
  --- isapi.dsp 27 Sep 2002 17:59:53 -  1.20
  +++ isapi.dsp 22 Oct 2002 11:57:33 -  1.21
  @@ -45,7 +45,7 @@
   # PROP Ignore_Export_Lib 0
   # PROP Target_Dir ""
   # ADD BASE CPP /nologo /MD /W3 /GX /O2 /D "WIN32" /D "NDEBUG" /D "_WINDOWS" /D 
"_MBCS" /D "_USRDLL" /D "ISAPI_EXPORTS" /YX /FD /c
  -# ADD CPP /nologo /MD /W3 /GX /O2 /I "..\..\include" /I "$(JAVA_HOME)\include" /I 
"$(JAVA_HOME)\include\win32" /I "$(APACHE2_HOME)\include" /I 
"$(APACHE2_HOME)\os\win32" /D "WIN32" /D "NDEBUG" /D "_WINDOWS" /D "_MBCS" /D 
"_USRDLL" /D "ISAPI_EXPORTS" /D "HAVE_JNI" /D "HAS_APR" /FR /YX /FD /c
  +# ADD CPP /nologo /MD /W3 /GX /O2 /I "..\..\include" /I "$(JAVA_HOME)\include" /I 
"$(JAVA_HOME)\include\win32" /I "$(APACHE2_HOME)\include" /I 
"$(APACHE2_HOME)\os\win32" /D "NDEBUG" /D "WIN32" /D "_WINDOWS" /D "_MBCS" /D 
"_USRDLL" /D "ISAPI_EXPORTS" /D "HAVE_JNI" /D "HAS_APR" /D "HAS_PCRE" /FR /YX /FD /c
   # ADD BASE MTL /nologo /D "NDEBUG" /mktyplib203 /win32
   # ADD MTL /nologo /D "NDEBUG" /mktyplib203 /win32
   # ADD BASE RSC /l 0xc0a /d "NDEBUG"
  @@ -55,7 +55,7 @@
   # ADD BSC32 /nologo
   LINK32=link.exe
   # ADD BASE LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib 
advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib 
/nologo /dll /machine:I386
  -# ADD LINK32 libapr.lib libaprutil.lib wsock32.lib advapi32.lib /nologo /dll 
/machine:I386 /out:"Release/isapi_redirector2.dll" /libpath:"$(APACHE2_HOME)\lib"
  +# ADD LINK32 libapr.lib libaprutil.lib wsock32.lib advapi32.lib pcre.lib 
pcreposix.lib /nologo /dll /machine:I386 /out:"Release/isapi_redirector2.dll" 
/libpath:"$(APACHE2_HOME)\lib"
   
   !ELSEIF  "$(CFG)" == "isapi - Win32 Debug"
   
  @@ -71,7 +71,7 @@
   # PROP Ignore_Export_Lib 0
   # PROP Target_Dir ""
   # ADD BASE CPP /nologo /MTd /W3 /Gm /GX /ZI /Od /D "WIN32" /D "_DEBUG" /D 
"_WINDOWS" /D "_MBCS" /D "_USRDLL" /D "ISAPI_EXPORTS" /YX /FD /GZ /c
  -# ADD CPP /nologo /MTd /W3 /Gm /GX /ZI /Od /I "..\..\include" /I 
"$(JAVA_HOME)\include" /I "$(JAVA_HOME)\include\win32" /I "$(APACHE2_HOME)\include" /I 
"$(APACHE2_HOME)\os\win32" /D "WIN32" /D "_DEBUG" /D "_WINDOWS" /D "_MBCS" /D 
"_USRDLL" /D "ISAPI_EXPORTS" /D "HAVE_JNI" /D "HAS_APR" /FR /YX /FD /GZ /c
  +# ADD CPP /nologo /MTd /W3 /Gm /GX /ZI /Od /I "..\..\include" /I 
"$(JAVA_HOME)\include" /I "$(JAVA_HOME)\include\win32" /I "$(APACHE2_HOME)\include" /I 
"$(APACHE2_HOME)\os\win32" /D "_DEBUG" /D "WIN32" /D "_WINDOWS" /D "_MBCS" /D 
"_USRDLL" /D "ISAPI_EXPORTS" /D "HAVE_JNI" /D "HAS_APR" /D "HAS_PCRE" /FR /YX /FD /GZ 
/c
   # ADD BASE MTL /nologo /D "_DEBUG" /mktyplib203 /win32
   # ADD MTL /nologo /D "_DEBUG" /mktyplib203 /win32
   # ADD BASE RSC /l 0xc0a /d "_DEBUG"
  @@ -81,15 +81,15 @@
   # ADD BSC32 /nologo
   LINK32=link.exe
   # ADD BASE LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib 
advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib 
/nologo /dll /debug /machine:I386 /pdbtype:sept
  -# ADD LINK32 libapr.lib libaprutil.lib wsock32.lib advapi32.lib /nologo /dll /debug 
/machine:I386 /out:"Debug/isapi_redirector2.dll" /pdbtype:sept 
/libpath:"$(APACHE2_HOME)\lib"
  +# ADD LINK32 libapr.lib libaprutil.lib wsock32.lib advapi32.lib pcre.lib 
pcreposix.lib /nologo /dll /debug /machine:I386 /out:"Debug/isapi_redirector2.dll" 
/pdbtype:sept /libpath:"$(APACHE2_HOME)\lib"
   # SUBTRACT LINK32 /nodefaultlib
   
   !ELSEIF  "$(CFG)" == "isapi - Win32 Debug Static"
   
   # PROP BASE Use_MFC 0
   # PROP BASE Use_Debug_Libraries 1
  -# PROP BASE Output_Dir "isapi___Win32_Debug_Static"
  -# PROP BASE Intermediate_Dir "isapi___Win32_Debug_Static"
  +# PROP BASE Output_Dir "DebugS"
  +# PROP BASE Intermediate_Dir "DebugS"
   # PROP BASE Ignore_Export_Lib 0
   # PROP BASE Target_Dir ""
   # PROP Use_MFC 0
  @@ -99,7 +99,7 @@
   # PROP Ignore_Export_Lib 0
   # PROP Target_Dir ""
   # ADD BASE CPP /nologo /MTd /W3 /Gm /GX /ZI /Od /I "..\..\include" /I 
"$(JAVA_HOME)\include" /I "$(JAVA_HOME)\include\win32" /I "$(APACHE2_HOME)\include" /I 
"$(APACHE2_HOME)\os\win32" /D "WIN32" /D "_DEBUG" /D "_WINDOWS" /D "_MBCS" /D 
"_USRDLL" /D "ISAPI_EXPORTS" /D "HAVE_JNI" /D "HAS_APR" /FR /YX /FD /GZ /c
  -# ADD CPP /nologo /MDd /W3 /Gm /GX /ZI /Od /I "..\..\include" /I 
"$(JAVA_HOME)\include" /I "$(JAVA_HOME)\include\win32" /I "$(APACHE2_HOME)\include" /I 
"$(APACHE2_HOME)\os\win32" /D "WIN32" /D "_DEBUG" /D "_WINDOWS" /D "_MBCS" /D 
"_USRDL

DO NOT REPLY [Bug 13846] New: - If-Modified-Since results in incorrect headers

2002-10-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13846

If-Modified-Since results in incorrect headers

   Summary: If-Modified-Since results in incorrect headers
   Product: Tomcat 4
   Version: 4.1.12
  Platform: All
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Connector:Coyote JK 2
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I reported this a while ago regarding Tomcat 3.3
(http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13662). It seems however that
a (symptomatically) similar problem exists in Tomcat 4.1.12. 

According to W3C spec of 304 response header 
(http://www.w3.org/Protocols/HTTP/HTRESP.html):
"Response headers are as if the client had sent a HEAD request, but limited to 
only those headers which make sense in this context. This means only headers 
that are relevant to cache managers and which may have changed independently 
of the document's Last-Modified date. Examples include Date , Server and 
Expires . "


My setup is:
Tomcat 4.1.12 with a Coyote HTTP/1.1 Connector on port 18000
Apache 1.3.26 using mod_jk on port 80 forwards all traffic using mod_jk to a
Coyote JK 2 connector (on port 8009).

Consider the following going through apache -> jk -> tomcat:
$ curl -I http://rhubarb/images/bit.gif 
HTTP/1.1 200 
Date: Tue, 22 Oct 2002 11:52:32 GMT
Server: Apache/1.3.26 (Unix) mod_jk/1.1.0 DAV/1.0.3 mod_ssl/2.8.10 OpenSSL/0.9.6g
ETag: W/"48-1032511407000"
Last-Modified: Fri, 20 Sep 2002 08:43:27 GMT
Content-Length: 48
Content-Type: image/gif

$ curl -I http://rhubarb/images/bit.gif -H 'If-Modified-Since: Fri, 20 Sep 2002
08:43:27 GMT'
HTTP/1.1 304 
Date: Tue, 22 Oct 2002 11:55:28 GMT
Server: Apache/1.3.26 (Unix) mod_jk/1.1.0 DAV/1.0.3 mod_ssl/2.8.10 OpenSSL/0.9.6g
Content-Length: 0
Content-Type: text/plain


The second 'curl' command shows the problem. We have two headers (Content-Length
and Content-Type) that shows strange things. Clearly this breaks the spec, and
does cause problems in example mod_proxy (see above mentioned bug report).

However, if I go directly towards port 18000 of my Tomcat, I get the correct result:

$ curl -I http://rhubarb:18000/images/bit.gif 
HTTP/1.1 200 OK
ETag: W/"48-1032511407000"
Last-Modified: Fri, 20 Sep 2002 08:43:27 GMT
Content-Type: image/gif
Content-Length: 48
Date: Tue, 22 Oct 2002 11:59:03 GMT
Server: Apache Coyote/1.0

$ curl -I http://rhubarb:18000/images/bit.gif -H 'If-Modified-Since: Fri, 20 Sep
2002 08:43:27 GMT'
HTTP/1.1 304 Not Modified
Content-Length: 0
Date: Tue, 22 Oct 2002 11:59:17 GMT
Server: Apache Coyote/1.0

Second 'curl' have no strange headers. This is why I suspect Coyote JK 2 to be
the problem. I'm speculating this is due to a DEFAULT_CONTENT_TYPE set in the
Coyote JK connector (org.apache.coyote.Constants). But I haven't looked closely
enough to verify this, and also I'm not sure what the remedy should be.

The DEFAULT_CONTENT_TYPE I assume is there for a reason even though I don't
understand why a Connector would interfere with any headers (wouldn't it be
cleaner if the Connector only passed on whatever Tomcat tells it, and don't try
to add it's own bits on top?).

I am happy to sort this one out myself, but I would appreciate getting pointed
in the right direction. Should I make a special case in the Connector for 304
errors (and then clear these headers), or should the Connector not have default
types?

Martin Algesten

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11Http11Protocol.java

2002-10-22 Thread Glenn Nielsen
There are times when client disconnects (aborted requests) may be an indicator
of problems within Tomcat.  An increased number of aborted requests can be an
indicator that Tomcat performance has degraded to the point where request
latency has increased to the point where remote users are giving up on viewing
the page.  Or there may just be one JSP page or servlet which takes a long
time to finish generating a response.

I think this exception should be at the WARN or INFO level, and the message
should mention that the most likely cause is that the request was aborted
by the remote client.  No need to log the exception stack trace, just log
a message.

Regards,

Glenn


[EMAIL PROTECTED] wrote:

remm2002/10/22 02:23:32

  Modified:http11/src/java/org/apache/coyote/http11 Http11Protocol.java
  Log:
  - Decrease amount of logging (client disconnects are normal, so they should
have DEBUG level IMO).
  
  Revision  ChangesPath
  1.16  +0 -4  jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Protocol.java
  
  Index: Http11Protocol.java
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Protocol.java,v
  retrieving revision 1.15
  retrieving revision 1.16
  diff -u -r1.15 -r1.16
  --- Http11Protocol.java	7 Jun 2002 00:48:21 -	1.15
  +++ Http11Protocol.java	22 Oct 2002 09:23:32 -	1.16
  @@ -394,15 +394,11 @@
   TcpConnection.shutdownInput( socket );
   } catch(java.net.SocketException e) {
   // SocketExceptions are normal
  -proto.log.info(sm.getString
  -   ("http11protocol.proto.socketexception.info"));
   proto.log.debug
   (sm.getString
("http11protocol.proto.socketexception.debug"), e);
   } catch (java.io.IOException e) {
   // IOExceptions are normal 
  -proto.log.info(sm.getString
  -   ("http11protocol.proto.ioexception.info"));
   proto.log.debug
   (sm.getString
("http11protocol.proto.ioexception.debug"), e);
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-connectors/jk/native2 CHANGES.txt

2002-10-22 Thread mturk
mturk   2002/10/22 05:44:57

  Modified:jk/native2 CHANGES.txt
  Log:
  Update recent changes
  
  Revision  ChangesPath
  1.3   +6 -1  jakarta-tomcat-connectors/jk/native2/CHANGES.txt
  
  Index: CHANGES.txt
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/CHANGES.txt,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- CHANGES.txt   15 Oct 2002 13:00:49 -  1.2
  +++ CHANGES.txt   22 Oct 2002 12:44:57 -  1.3
  @@ -2,6 +2,11 @@
   Last modified at [$Date$]
   
   Changes with JK2 2.0.2:
  +* Add the regular expressions to uriMap. The regex uris are differentiated
  +  to normal one by starting with dollar ($) sign.
  +  [Mladen Turk]
  +* Add the max_connections to the wajp13 worker.
  +  [Mladen Turk]
   * Add the hostMap cache
 [Mladen Turk] 
   * Allow the lb:name scheme inside the [channel.xxx]
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-connectors/jk/xdocs/jk2 configwebcom.xml

2002-10-22 Thread mturk
mturk   2002/10/22 05:45:40

  Modified:jk/xdocs/jk2 configwebcom.xml
  Log:
  Describe the max_connections for ajp13 worker.
  
  Revision  ChangesPath
  1.4   +9 -0  jakarta-tomcat-connectors/jk/xdocs/jk2/configwebcom.xml
  
  Index: configwebcom.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/xdocs/jk2/configwebcom.xml,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- configwebcom.xml  15 Oct 2002 14:00:11 -  1.3
  +++ configwebcom.xml  22 Oct 2002 12:45:40 -  1.4
  @@ -423,6 +423,15 @@
   
   
   
  +
  +max_connections
  +0 (unlimited)
  +Maximum number of currently used endpoints.
  +If the specified number is reached then the load 
balancer has the chance
  +to try another worker. This is very useful in 
situations when having multiple
  +servers and you wish to finer grade the lb_factor.
  +
  +
   
   
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Where have the 4.1x nightly builds

2002-10-22 Thread John Trollinger
I can not seem to find the nighly builds for 4.1.x have they moved and
the links are just broken.

Thanks,

John


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 13846] - If-Modified-Since results in incorrect headers

2002-10-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13846

If-Modified-Since results in incorrect headers





--- Additional Comments From [EMAIL PROTECTED]  2002-10-22 13:37 ---
Just realised that my second example (going straight to tomcats HTTP/1.1
connector) doesn't seem right either. The header "Content-Lenght: 0" doesn't
seem right according to spec. So rather being a problem isolated to Coyote JK 2,
it might also affect some core components.

M

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 13827] - mod_jk load balancing does not set proper JSESSIONID with tomcat 4.x

2002-10-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13827

mod_jk load balancing does not set proper JSESSIONID with tomcat 4.x





--- Additional Comments From [EMAIL PROTECTED]  2002-10-22 13:45 ---
Remy,
Thanks, that fixed it.  I guess I was too close to the problem to see the
solution.  I even went so far as dissecting mod_jk sources, and I can't program
(yes it was an effort in futility).
Jason

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




allowChunking

2002-10-22 Thread Bryan Dougherty
Why isn't the allowChunking attribute supported in the Coyote HTTP 
connector?  

Bryan


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 



DO NOT REPLY [Bug 3888] - WebappClassLoader: Lifecycle error : CL stopped

2002-10-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=3888

WebappClassLoader: Lifecycle error : CL stopped





--- Additional Comments From [EMAIL PROTECTED]  2002-10-22 15:03 ---
Created an attachment (id=3567)
See the README file.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 3888] - WebappClassLoader: Lifecycle error : CL stopped

2002-10-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=3888

WebappClassLoader: Lifecycle error : CL stopped





--- Additional Comments From [EMAIL PROTECTED]  2002-10-22 15:10 ---
I added a new tarball lock.tar.gz as an attachement. It contains a README file 
explaining its usage. 

My preliminary conclusion is that there is indeed an undesired interaction 
between log4j and Tomcat when the DOMConfigurator is used but not otherwise. 

The problem has been reduced to log4j/DOMConfigurator.

I don't think the indetified bug is directly linked to the bug reported by Jon. 
Jon are you using the DOMConfigurator?

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: MBeanException w/AJP13Connector and (hopefully)itssolution

2002-10-22 Thread Jeff Tulley
Yeah there are a miriad of solutions to this problem.

First off, the immediate solutions is to add the patch I posted to the list - that is, 
to add in the MBean tags to the mbean descriptor XML file, describing the AJP 13 
connector.  That gets rid of the exception right away.  This, of course, keeps you 
using the deprecated AJP 13 Connector.  We had resisted moving since we did not 
realize that the new Coyote connector does work with the old mod_jk Apache mod.  I've 
attached that patch.

Now, the options if you move to the Coyote JkHandler:
1) Easiest, immediate fix to the problem:
   Add"IntrospectionUtils.setProperty(protocolHandler, 
"channelSocket.port", "" + port);"  to the file 
coyote/src/java/org/apache/coyote/tomcat4/CoyoteConnector.java", in the 
jakarta-tomcat-connectors project.  Add this in the initialize method, right after the 
line that sets the port.
What this does is take whatever port you have set in your server.xml and also sets 
that port for the "channelSocket".  If you also have a value in jk2.properties, this 
value will over-ride that one.
I've attached a patch that has the "unified diff" of this fix.

2) What really needs to happen is some way of associating the connector instances in 
server.xml with the connector properties in jk2.properties that allows you to have 
multiple instances of Tomcat.  This would take a bit more work, though a lot of the 
support is already there in jk2.properties.  (IE, instead of "channelSocket.port=8009" 
in jk2.properties, you can have "channelSocketPort.instance1.port=8009".  The only 
thing left to do is associate the connector in server.xml with "instance1", maybe with 
a new attribute in the Connector XML tag).   This would be a bit more involved, and I 
do not have a patch for this problem (yet?).
With this solution, all of the configuration information that is common between the 
java Connector and the C-based Apache Mods can come from one file instead of two as in 
the past.  I think this is the design the committers want ultimately.


Jeff Tulley  ([EMAIL PROTECTED])
(801)861-5322
Novell, Inc., the leading provider of Net business solutions
http://www.novell.com

>>> Richard Doorduin <[EMAIL PROTECTED]> 10/22/02 4:57:20 AM >>>
Dear Jeff,

It seems that we are sharing the same problem that is if you still haven't
found the solution for it.
That is why I am emailing you.

Because it would make it less difficult if you found the solution for it.

I hope you can reply to me!

Greetings,


Richard Doorduin




mbeans-descriptors.patch
Description: Binary data


CoyoteConnector.patch
Description: Binary data
--
To unsubscribe, e-mail:   
For additional commands, e-mail: 


DO NOT REPLY [Bug 13692] - request.getCharacterEncoding() is NULL

2002-10-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13692

request.getCharacterEncoding() is NULL

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Priority|Other   |Medium

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




[4.1.13] Tagging ...

2002-10-22 Thread Remy Maucherat
I plan to tag 4.1.13 tomorrow. As usual, the quality of the build will 
be evaluated over a period of time before it is officially released.

Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 



DO NOT REPLY [Bug 13040] - can't retrieve external context who's uri is a sub-dir of current context

2002-10-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13040

can't retrieve external context who's uri is a sub-dir of current context





--- Additional Comments From [EMAIL PROTECTED]  2002-10-22 16:57 ---
The problem is much more trivial. We will always have a contextPath with a
length > 0 since we always append "/" if there isn't one already.

$ diff -u ApplicationContext.java-2002-10-21 ApplicationContext.java
--- ApplicationContext.java-2002-10-21  Mon Sep 23 11:23:16 2002
+++ ApplicationContext.java Tue Oct 22 17:55:08 2002
@@ -442,7 +442,7 @@
 String contextPath = context.getPath();
 if (!contextPath.endsWith("/"))
 contextPath = contextPath + "/";
-if ((contextPath.length() > 0) && (uri.startsWith(contextPath))) {
+if ((contextPath.length() > 1) && (uri.startsWith(contextPath))) {
 return (this);
 }
 
Martin Algesten

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 3888] - WebappClassLoader: Lifecycle error : CL stopped

2002-10-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=3888

WebappClassLoader: Lifecycle error : CL stopped





--- Additional Comments From [EMAIL PROTECTED]  2002-10-22 17:39 ---
I don't believe so. All of my log4j configuration is done with properties 
files.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 3888] - WebappClassLoader: Lifecycle error : CL stopped

2002-10-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=3888

WebappClassLoader: Lifecycle error : CL stopped





--- Additional Comments From [EMAIL PROTECTED]  2002-10-22 17:41 ---
Created an attachment (id=3569)
A new version of log4j that solves the log4j.jar locking problem.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 13519] - tomcat4.1.12 failed to deploy context not under webapp directory with 'allowLinking' enabled

2002-10-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13519

tomcat4.1.12 failed to deploy context not under webapp directory with 'allowLinking' 
enabled





--- Additional Comments From [EMAIL PROTECTED]  2002-10-22 19:29 ---
I've tracked down this problem to be from o.a.c.core.CatainerBase.java.

When there is a 'Resources' definition inside 'Context', the 'parent'
container of this container is not properly setup, which affects loading
of jars later in ContextConfig.java. In 'setResources(), 'env' only
has 'CONTEXT', no 'HOST' information.

Can someone help me to further solve this problem, and how to cascade
the 'allowLinking' property from top container down to resources?

Thanks.

 

Previously posted messages are attached below.


>>

I am having the same issue.
It looks as though the "allowLinking" option breaks things.

When I  use the below server.xml  section



The apache_log.-MM-DD.txt shows no errors
ditto on the  catalina_log.-MM-DD.txt

But when I add the allowLinking option...




I see the below error
2002-10-10 16:11:34 ContextConfig[/foo] Exception processing JAR at resource
path /WEB-INF/lib/mm.mysql-2.0.14-bin.jar

I using tomcat4-4.1.12-full.1jpp installed via rpm
thanks

paul

--- "Liu, Xiaoyan" <[EMAIL PROTECTED]> wrote:
> Hi, all,
> 
> I'm upgrading from 4.1.9 to 4.1.12 and noticed that a previously working
> application
> is not successfully loaded. It fails at the part of scanning tld files.
> 
> The context is defined in server.xml as below. THis context does not live
> under
> CATALINA_HOME/webapp, and it has resources(jsp pages) symlinked under it.
> 
>  docBase="/home/xliu/JSPApplication/pages" 
>  crossContext="false"
>  debug="3" 
>  reloadable="true" > 
>  allowLinking="true" docBase="/home/xliu/JSPApplication/pages" />
> 
> 
> 
> The log is attached.  Is this a bug or rather some changes involving
> security?
> 
> thanks for your help.
> 
> 
> xliu
> capitalthinking.com
> 


=
Paul N Miller
[EMAIL PROTECTED]

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 13861] New: - Authentication / SSL conflict (web.xml security-constraint auth-constraint user-data-constraint)

2002-10-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13861

Authentication / SSL conflict (web.xml security-constraint auth-constraint 
user-data-constraint)

   Summary: Authentication / SSL conflict (web.xml security-
constraint auth-constraint user-data-constraint)
   Product: Tomcat 4
   Version: 4.1.12
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Blocker
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Into the original /examples/WEB-INF/web.xml file, I added the following
security constraint just before the Example Security Constraint.


  
 Protected by tomcat role and SSL
 /jsp/snp/*
  
  
 tomcat
  
  
 CONFIDENTIAL
  


No other changes to this web.xml file were made.

Now, my browser hangs when I try to access 
http://localhost:8080/examples/jsp/snp/snoop.jsp.
It appears that Catalina cannot redirect to login.jsp and
change to port 8443 at the same time.

If I remove the  tag, SSL works fine.

If I remove the  tag, authentication works fine.

How can I get them to BOTH work at the same time?

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler DefaultErrorHandler.java

2002-10-22 Thread luehe
luehe   2002/10/22 14:59:58

  Modified:jasper2/src/share/org/apache/jasper/compiler
DefaultErrorHandler.java
  Log:
  expose exception in error message
  
  Revision  ChangesPath
  1.4   +5 -5  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/DefaultErrorHandler.java
  
  Index: DefaultErrorHandler.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/DefaultErrorHandler.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- DefaultErrorHandler.java  7 Oct 2002 19:37:21 -   1.3
  +++ DefaultErrorHandler.java  22 Oct 2002 21:59:57 -  1.4
  @@ -96,7 +96,7 @@
  + " " + errMsg);
} else {
throw new JasperException(fname + "(" + line + "," + column + ")"
  -   + " " + ex.getMessage());
  +   + " " + ex);
}
   }
   
  @@ -110,7 +110,7 @@
if (errMsg != null) {
throw new JasperException(errMsg);
} else {
  - throw new JasperException(ex.getMessage());
  + throw new JasperException(ex);
}
   }
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




4.0.7 release?

2002-10-22 Thread Jon Scott Stevens
Can I get a 4.0.7 release? It has an important configuration bug fix that I
need for Scarab.

-jon

-- 
StudioZ.tv /\ Bar/Nightclub/Entertainment
314 11th Street @ Folsom /\ San Francisco
http://studioz.tv/


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




2 small problems with examples

2002-10-22 Thread Costin Manolache
I'm building 5.0 - and at least on my machine the servlet examples
are not running:

1. the links in jsr154/examples/index.html are ../servlet, and no 
servlet is defined in web.xml

2. even if it would be, the link will point to the ROOT context.

Someone with karma to the servlet cvs - please take a look.

It was proposed some time ago to move the examples back to 
tomcat. What happened with the proposal ?


-- 
Costin



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-connectors/jk/support jk_pcre.m4

2002-10-22 Thread mturk
mturk   2002/10/22 12:40:28

  Added:   jk/support jk_pcre.m4
  Log:
  Add conditional pcre compile
  
  Revision  ChangesPath
  1.1  jakarta-tomcat-connectors/jk/support/jk_pcre.m4
  
  Index: jk_pcre.m4
  ===
  dnl  =
  dnl
  dnl  The Apache Software License,  Version 1.1
  dnl
  dnl   Copyright (c) 1999-2001 The Apache Software Foundation.
  dnlAll rights reserved.
  dnl
  dnl  =
  dnl
  dnl  Redistribution and use in source and binary forms,  with or without modi-
  dnl  fication, are permitted provided that the following conditions are met:
  dnl
  dnl  1. Redistributions of source code  must retain the above copyright notice
  dnl notice, this list of conditions and the following disclaimer.
  dnl
  dnl  2. Redistributions  in binary  form  must  reproduce the  above copyright
  dnl notice,  this list of conditions  and the following  disclaimer in the
  dnl documentation and/or other materials provided with the distribution.
  dnl
  dnl  3. The end-user documentation  included with the redistribution,  if any,
  dnl must include the following acknowlegement:
  dnl
  dnl"This product includes  software developed  by the Apache  Software
  dnl Foundation ."
  dnl
  dnl Alternately, this acknowlegement may appear in the software itself, if
  dnl and wherever such third-party acknowlegements normally appear.
  dnl
  dnl  4. The names "The Jakarta Project",  "Apache WebApp Module",  and "Apache
  dnl Software Foundation"  must not be used to endorse or promote  products
  dnl derived  from this  software  without  prior  written  permission. For
  dnl written permission, please contact <[EMAIL PROTECTED]>.
  dnl
  dnl  5. Products derived from this software may not be called "Apache" nor may
  dnl "Apache" appear in their names without prior written permission of the
  dnl Apache Software Foundation.
  dnl
  dnl  THIS SOFTWARE IS PROVIDED "AS IS" AND ANY EXPRESSED OR IMPLIED WARRANTIES
  dnl  INCLUDING, BUT NOT LIMITED TO,  THE IMPLIED WARRANTIES OF MERCHANTABILITY
  dnl  AND FITNESS FOR  A PARTICULAR PURPOSE  ARE DISCLAIMED.  IN NO EVENT SHALL
  dnl  THE APACHE  SOFTWARE  FOUNDATION OR  ITS CONTRIBUTORS  BE LIABLE  FOR ANY
  dnl  DIRECT,  INDIRECT,   INCIDENTAL,  SPECIAL,  EXEMPLARY,  OR  CONSEQUENTIAL
  dnl  DAMAGES (INCLUDING,  BUT NOT LIMITED TO,  PROCUREMENT OF SUBSTITUTE GOODS
  dnl  OR SERVICES;  LOSS OF USE,  DATA,  OR PROFITS;  OR BUSINESS INTERRUPTION)
  dnl  HOWEVER CAUSED AND  ON ANY  THEORY  OF  LIABILITY,  WHETHER IN  CONTRACT,
  dnl  STRICT LIABILITY, OR TORT  (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
  dnl  ANY  WAY  OUT OF  THE  USE OF  THIS  SOFTWARE,  EVEN  IF  ADVISED  OF THE
  dnl  POSSIBILITY OF SUCH DAMAGE.
  dnl
  dnl  =
  dnl
  dnl  This software  consists of voluntary  contributions made  by many indivi-
  dnl  duals on behalf of the  Apache Software Foundation.  For more information
  dnl  on the Apache Software Foundation, please see .
  dnl
  dnl  =
  
  
  
  
  AC_DEFUN(
[JK_PCRE],
[
  AC_ARG_WITH(pcre,
[  --with-pcre  Build pcre support],
[
case "${withval}" in
  y | yes | true) use_pcre=true ;;
  n | no | false) use_pcre=false ;;
*) use_pcre=true ;;
  esac
  
if ${TEST} ${use_pcre} ; then
  HAVE_PCRE="-DHAVE_PCRE"
  PCRE_LIBS="-lpcre -lpcreposix"
fi
])
])
  
  dnl vi:set sts=2 sw=2 autoindent:
  
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-connectors/jk/native2 configure.in

2002-10-22 Thread mturk
mturk   2002/10/22 12:40:45

  Modified:jk/native2 configure.in
  Log:
  Add conditional pcre compile
  
  Revision  ChangesPath
  1.9   +7 -4  jakarta-tomcat-connectors/jk/native2/configure.in
  
  Index: configure.in
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/configure.in,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- configure.in  5 Jun 2002 13:42:31 -   1.8
  +++ configure.in  22 Oct 2002 19:40:45 -  1.9
  @@ -67,6 +67,7 @@
   sinclude(../support/jk_apr.m4)
   sinclude(../support/jk_tchome.m4)
   sinclude(../support/jk_java.m4)
  +sinclude(../support/jk_pcre.m4)
   
   dnl
   dnl Process this file with autoconf to produce a configure script
  @@ -79,7 +80,7 @@
   
   dnl package and version. (synchronization with common/jk_version.h ?)
   PACKAGE=mod_jk2
  -VERSION=2.0.0
  +VERSION=2.0.2
   
   AM_INIT_AUTOMAKE(${PACKAGE}, ${VERSION})
   
  @@ -186,12 +187,14 @@
   JK_JDK()
   JK_JDK_OS()
   JK_JNI()
  +JK_PCRE()
   
   AC_SUBST(JAVA_HOME)
   AC_SUBST(JAVA_PLATFORM)
   AC_SUBST(OS)
   AC_SUBST(HAVE_JNI)
  -
  +AC_SUBST(HAS_PCRE)
  +AC_SUBST(PCRE_LIBS)
   
   dnl Check that at least one WEBSERVER has been given
   if ${TEST} -z "$WEBSERVERS" ; then
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-connectors/jk/native2/server/apache2 Makefile.in Makefile.apxs.in

2002-10-22 Thread mturk
mturk   2002/10/22 12:41:03

  Modified:jk/native2/server/apache2 Makefile.in Makefile.apxs.in
  Log:
  Add conditional pcre compile
  
  Revision  ChangesPath
  1.11  +2 -2  jakarta-tomcat-connectors/jk/native2/server/apache2/Makefile.in
  
  Index: Makefile.in
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/server/apache2/Makefile.in,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- Makefile.in   16 Jun 2002 20:55:21 -  1.10
  +++ Makefile.in   22 Oct 2002 19:41:03 -  1.11
  @@ -33,8 +33,8 @@
 ${APR_INCL} \
 ${JAVA_INCL}
   
  -JK_CFLAGS=-DCHUNK_SIZE=4096 -DUSE_APACHE_MD5 -DHAS_APR @HAVE_JNI@
  -JK_LDFLAGS=-L${APACHE2_LIBDIR} -lcrypt -lapr
  +JK_CFLAGS=-DCHUNK_SIZE=4096 -DUSE_APACHE_MD5 -DHAS_APR @HAVE_JNI@ @HAS_PCRE@
  +JK_LDFLAGS=-L${APACHE2_LIBDIR} -lcrypt -lapr-0 @PCRE_LIBS@
   
   ## Based on rules.mk ##
   ALL_CFLAGS   = $(EXTRA_CFLAGS) $(NOTEST_CFLAGS) $(CFLAGS)
  
  
  
  1.6   +1 -1  
jakarta-tomcat-connectors/jk/native2/server/apache2/Makefile.apxs.in
  
  Index: Makefile.apxs.in
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/native2/server/apache2/Makefile.apxs.in,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- Makefile.apxs.in  4 Jun 2002 10:33:45 -   1.5
  +++ Makefile.apxs.in  22 Oct 2002 19:41:03 -  1.6
  @@ -11,7 +11,7 @@
   
   JK=${JK_DIR}/common/
   JKINC=${JK_DIR}/include/
  -JK_INCL=-DUSE_APACHE_MD5 -I ${JK} -I ${JKINC} -DHAS_APR @HAVE_JNI@
  +JK_INCL=-DUSE_APACHE_MD5 -I ${JK} -I ${JKINC} -DHAS_APR @HAVE_JNI@ @HAS_PCRE@
   JAVA_INCL=-I ${JAVA_HOME}/include -I ${JAVA_HOME}/include/${OS}
   JAVA_LIB=-L ${JAVA_HOME}/jre/lib/${ARCH} -L ${JAVA_HOME}/lib/${ARCH}/native_threads
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper EmbededServletOptions.java

2002-10-22 Thread luehe
luehe   2002/10/22 15:23:15

  Modified:jasper2/src/share/org/apache/jasper
EmbededServletOptions.java
  Log:
  Reduced visibility of instance fields from public to private, since each has its own 
(public) getter method
  
  Revision  ChangesPath
  1.11  +18 -18
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/EmbededServletOptions.java
  
  Index: EmbededServletOptions.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/EmbededServletOptions.java,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- EmbededServletOptions.java20 Aug 2002 03:52:18 -  1.10
  +++ EmbededServletOptions.java22 Oct 2002 22:23:14 -  1.11
  @@ -87,12 +87,12 @@
   /**
* Is Jasper being used in development mode?
*/
  -public boolean development = true;
  +private boolean development = true;
   
   /**
* Do you want to keep the generated Java files around?
*/
  -public boolean keepGenerated = true;
  +private boolean keepGenerated = true;
   
   /**
* Do you want support for "large" files? What this essentially
  @@ -100,64 +100,64 @@
* file is stored separately as opposed to those constant string
* data being used literally in the generated servlet. 
*/
  -public boolean largeFile = false;
  +private boolean largeFile = false;
   
   /**
* Determines whether tag handler pooling is enabled.
*/
  -public boolean poolingEnabled = true;
  +private boolean poolingEnabled = true;
   
   /**
* Do you want support for "mapped" files? This will generate
* servlet that has a print statement per line of the JSP file.
* This seems like a really nice feature to have for debugging.
*/
  -public boolean mappedFile = false;
  +private boolean mappedFile = false;
   
   /**
* Do you want stack traces and such displayed in the client's
* browser? If this is false, such messages go to the standard
* error or a log file if the standard error is redirected. 
*/
  -public boolean sendErrorToClient = false;
  +private boolean sendErrorToClient = false;
   
   /**
* Do we want to include debugging information in the class file?
*/
  -public boolean classDebugInfo = true;
  +private boolean classDebugInfo = true;
   
   /**
* Background compile thread check interval in seconds.
*/
  -public int checkInterval = 300;
  +private int checkInterval = 300;
   
   /**
* JSP reloading check ?
*/
  -public boolean reloading = true;
  +private boolean reloading = true;
   
   /**
* I want to see my generated servlets. Which directory are they
* in?
*/
  -public File scratchDir;
  +private File scratchDir;
   
   /**
* Need to have this as is for versions 4 and 5 of IE. Can be set from
* the initParams so if it changes in the future all that is needed is
* to have a jsp initParam of type ieClassId=""
*/
  -public String ieClassId = "clsid:8AD9C840-044E-11D1-B3E9-00805F499D93";
  +private String ieClassId = "clsid:8AD9C840-044E-11D1-B3E9-00805F499D93";
   
   /**
* What classpath should I use while compiling generated servlets?
*/
  -public String classpath = null;
  +private String classpath = null;
   
   /**
* Compiler to use.
*/
  -public String compiler = null;
  +private String compiler = null;
   
   /**
* Cache for the TLD locations
  @@ -167,7 +167,7 @@
   /**
* Jsp config information
*/
  -JspConfig jspConfig = null;
  +private JspConfig jspConfig = null;
   
   /**
* Java platform encoding to generate the JSP
  @@ -278,7 +278,7 @@
   }
   
   public void setTldLocationsCache( TldLocationsCache tldC ) {
  -tldLocationsCache=tldC;
  +tldLocationsCache = tldC;
   }
   
   public String getJavaEncoding() {
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-catalina/webapps/docs/funcspecs mbean-names.xml project.xml

2002-10-22 Thread amyroh
amyroh  2002/10/22 13:09:49

  Modified:webapps/docs/funcspecs project.xml
  Added:   webapps/docs/funcspecs mbean-names.xml
  Log:
  Add missing mbean names documentation from tomcat 4.
  
  Revision  ChangesPath
  1.2   +1 -0  jakarta-tomcat-catalina/webapps/docs/funcspecs/project.xml
  
  Index: project.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/funcspecs/project.xml,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- project.xml   18 Jul 2002 16:48:35 -  1.1
  +++ project.xml   22 Oct 2002 20:09:48 -  1.2
  @@ -17,6 +17,7 @@
   
   
   
  +   
   
   
   
  
  
  
  1.1  jakarta-tomcat-catalina/webapps/docs/funcspecs/mbean-names.xml
  
  Index: mbean-names.xml
  ===
  
  
  ]>
  
  
&project;
  

  Craig McClanahan
  Amy Roh
  Tomcat MBean Names
  $Id: mbean-names.xml,v 1.1 2002/10/22 20:09:48 amyroh Exp $

  
  
  
  
  
  
  We will be using JMX MBeans as the technology for
  implementing manageability of Tomcat.
  
  One of the key concepts of JMX (and JSR-77) is that each management
  bean has a unique name in the MBeanServer's registry, and that
  management applications can utilize these names to retrieve the MBean
  of interest to them for a particular management operation.
  This document proposes a naming convention for MBeans that allows easy
  calculation of the name for a particular MBean.  For background
  information on JMX MBean names, see the Java Management Extensions
  Instrumentation and Agent Specification, version 1.0, section 6.
  In particular, we will be discussing the String Representation of
  ObjectName instances.
  
  
  
  
  
  Tomcat's servlet container implementation, called Catalina, can be
  represented as a hierarchy of objects that contain references to each other.
  The object hierarchy can be represented as a tree, or (isomorphically) based
  on the nesting of configuration elements in the conf/server.xml
  file that is traditionally used to configure Tomcat stand-alone.
  
  The valid component nestings for Catalina are depicted in the following
  table, with columns that contain the following values:
  
  Pattern - Nesting pattern of XML elements (in the
  conf/server.xml file) used to configure this component.
  Cardinality - Minimum and maximum number of occurrences of
  this element at this nesting position, which also corresponds to the
  minimum and maximum number of Catalina components.
  Identifier - Name of the JavaBeans property of this component
  that represents the unique identifier (within the nested hierarchy),
  if any.
  MBean ObjectName - The portion of the MBean object name that
  appears after the domain name.  For now, it should be
  assumed that all of these MBeans appear in the default JMX domain.
  
  
  In the MBean ObjectName descriptions, several types of symbolic
  expressions are utilized to define variable text that is replaced by
  corresponding values:
  
  ${GROUP} - One of the standard MBean names of the specified
  "group" category.  For example, the expression ${LOGGER}
  represents the values FileLogger,
  SystemErrLogger, and SystemOutLogger that
  identify the various MBeans for possible Logger components.
  ${name} - Replaced by the value of property name
  from the current component.
  ${parent.name} - Replaced by the value of property
  name from a parent of the current component, with the
  parent's type identified by parent.
  ${###} - An arbitrary numeric identifier that preserves
  order but has no other particular meaning.  In general, the server will
  assign numeric values to existing instances with large gaps into which
  new items can be configured if desired.
  
  
  
  

  Pattern
  Cardinality
  Identifier
  MBean ObjectName

  

  Server
  1..1
  (none)
  type=${SERVER}

  

  Server / Listener
  0..n
  (none)
  type=${LISTENER}, sequence=${###}

  

  Server / Service
  1..n
  name
  type=${SERVICE}, name=${name}

  

  Server / Service / Connector
  1..n
  address, port
  type=${CONNECTOR}, service=${service}, port=${port},
  address=${address}

  

  Server / Service / Connector / Factory
  0..1
  (none)
  (Only defined explicitly for an SSL connector, but can be treated
  as part of the connector component)

  

  Server / Service / Connector / Listener
  0..n
  (none)
  type=${LISTENER}, sequence=${###}, service=${service},
  port=${connector.port}, address=${connector.address}

  

  Serv

[3.3] Is methodo.a.c.http11.Http11Processor.addFilter used

2002-10-22 Thread Jean-Francois Arcand
Hi,

is method o.a.c.http11.Http11Processor.addFilter used by Tomcat 3.x? The 
method is not used in 4.1.X and 5, and I would like to remove it. The 
method gives direct access to Class.forName, and this is a "lightweight" 
security issue.

Thanks,

-- Jeanfrancois


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 



cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup Bootstrap.java

2002-10-22 Thread costin
costin  2002/10/22 13:25:29

  Modified:catalina/src/share/org/apache/catalina/startup
Bootstrap.java
  Log:
  A bit of refactoring I had on my machine.
  
  I'm still confused on which file is actually used, and not sure
  if this is actually needed.
  
  Revision  ChangesPath
  1.4   +51 -36
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/Bootstrap.java
  
  Index: Bootstrap.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/Bootstrap.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- Bootstrap.java18 Oct 2002 21:30:43 -  1.3
  +++ Bootstrap.java22 Oct 2002 20:25:29 -  1.4
  @@ -90,42 +90,29 @@
   
   public final class Bootstrap {
   
  -
  -// --- Static Variables
  -
  -
   /**
* Debugging detail level for processing the startup.
*/
  -private static int debug = 0;
  +protected int debug = 0;
  +protected String args[];
   
  +// Construct the class loaders we will need
  +protected ClassLoader commonLoader = null;
  +protected ClassLoader catalinaLoader = null;
  +protected ClassLoader sharedLoader = null;
  +
  +
  +public void setDebug( int debug ) {
  +this.debug=debug;
  +}
   
  +public void setArgs(String args[] ) {
  +this.args=args;
  +}
   // --- Main Program
   
  -
  -/**
  - * The main program for the bootstrap.
  - *
  - * @param args Command line arguments to be processed
  - */
  -public static void main(String args[]) {
  -
  -// Set the debug flag appropriately
  -for (int i = 0; i < args.length; i++)  {
  -if ("-debug".equals(args[i]))
  -debug = 1;
  -}
  -
  -// Configure catalina.base from catalina.home if not yet set
  -if (System.getProperty("catalina.base") == null)
  -System.setProperty("catalina.base", getCatalinaHome());
  -
  -// Construct the class loaders we will need
  -ClassLoader commonLoader = null;
  -ClassLoader catalinaLoader = null;
  -ClassLoader sharedLoader = null;
  +public void initClassLoaders() {
   try {
  -
   File unpacked[] = new File[1];
   File packed[] = new File[1];
   File packed2[] = new File[2];
  @@ -161,6 +148,23 @@
   System.exit(1);
   
   }
  +}
  +
  +// --- Main Program
  +
  +public void execute() {
  +// Set the debug flag appropriately
  +for (int i = 0; i < args.length; i++)  {
  +if ("-debug".equals(args[i]))
  +setDebug( 1 );
  +}
  +
  +// Configure catalina.base from catalina.home if not yet set
  +if (System.getProperty("catalina.base") == null)
  +System.setProperty("catalina.base", getCatalinaHome());
  +
  +this.initClassLoaders();
  +
   Thread.currentThread().setContextClassLoader(catalinaLoader);
   

  @@ -205,14 +209,25 @@
   e.printStackTrace(System.out);
   System.exit(2);
   }
  +}
  +
  +/**
  + * The main program for the bootstrap.
  + *
  + * @param args Command line arguments to be processed
  + */
  +public static void main(String args[]) {
  +Bootstrap bootstrap=new Bootstrap();
   
  +bootstrap.setArgs( args );
  +bootstrap.execute();
   }
   
   
   /**
* Get the value of the catalina.home environment variable.
*/
  -private static String getCatalinaHome() {
  +protected String getCatalinaHome() {
   return System.getProperty("catalina.home",
 System.getProperty("user.dir"));
   }
  @@ -221,7 +236,7 @@
   /**
* Get the value of the catalina.base environment variable.
*/
  -private static String getCatalinaBase() {
  +protected String getCatalinaBase() {
   return System.getProperty("catalina.base", getCatalinaHome());
   }
   
  @@ -231,7 +246,7 @@
*
* @param message The message to be logged
*/
  -private static void log(String message) {
  +protected void log(String message) {
   
   System.out.print("Bootstrap: ");
   System.out.println(message);
  @@ -245,7 +260,7 @@
* @param message The message to be logged
* @param exception The exception to be logged
*/
  -private static void log(String message, Throwable exception) {
  +protected void log(String message, Throwable exception) {
   
   log(message);
   

Re: The JNDIRealm

2002-10-22 Thread Fredrik Westermarck
?? ??? wrote:

Hi!

On this subject already wrote Fredrik Westermarck.

I concerning JNDIRealm. Unfortunately I am not yet commiter, therefore 
of powerful contribution bring I can not.
Usage SSL in JNDIRealm is a urgent subject - we use it for 
authentification of the users registered in Novell NDS - and the base 
mechanism does not suffice. It is necessary to work with LDAP not only 
as with the database (realm) but also as with the mechanism of 
identification of the users. For this purpose JNDIRealm tries to 
incorporate to the server through the mechanism of a login name - 
password indicated by the user. It is desirable that JNDIRealm was 
connected even with a minimum level of privacy.

I offer to expand JNDIRealm so, that it could solve all these tasks.

Tomcat 4.1.x support binding as the user _or_ searching for a user and 
comparing passwords.

However it doesn't support connecting to a SSL-enabled directory server 
- the patch I posted will let you do that. But we need someone that is 
willing to commit the patch... or atleast reviewing it and commeting it 
and how it could be improved.


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 



Re: [3.3] Is methodo.a.c.http11.Http11Processor.addFilter used

2002-10-22 Thread Bill Barker
It's not called by 3.3.  Like everybody else, 3.3 doesn't know anything
about o.a.c.http.**.

- Original Message -
From: "Jean-Francois Arcand" <[EMAIL PROTECTED]>
To: "Tomcat Developers List" <[EMAIL PROTECTED]>
Sent: Tuesday, October 22, 2002 2:46 PM
Subject: [3.3] Is methodo.a.c.http11.Http11Processor.addFilter used


> Hi,
>
> is method o.a.c.http11.Http11Processor.addFilter used by Tomcat 3.x? The
> method is not used in 4.1.X and 5, and I would like to remove it. The
> method gives direct access to Class.forName, and this is a "lightweight"
> security issue.
>
> Thanks,
>
> -- Jeanfrancois
>
>
> --
> To unsubscribe, e-mail:

> For additional commands, e-mail:

>


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 13869] New: - mod_jk2 becomes confused when client breaks the connection

2002-10-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13869

mod_jk2 becomes confused when client breaks the connection

   Summary: mod_jk2 becomes confused when client breaks the
connection
   Product: Tomcat 4
   Version: 4.1.12
  Platform: All
OS/Version: All
Status: NEW
  Severity: Blocker
  Priority: Other
 Component: Connector:Coyote JK 2
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


When the connection between mod_jk2 and a client browser gets interrupted, e.g.
because the client closed the connection, the communication link between mod_jk2
and tomcat gets into an illegal state. mod_jk2 will send the remaining part of
tomcats response to some other client, e.g., clients will receive (parts of)
responses to requests they have not sent. Users may consequently slip into
sessions of other user. Note that besides of the fact the users' requests are
not served the right way this is a major security issue. Once this happend the
server becomes largely unusable until it is shutdown and restarted.

Reproducing the problem is somewhat tricky. You have to cut the connection at
the right time. The script below tries to read parts of varying size before it
closes the connection to increase the likelyhood that it eventually hits the
right time. On the systems I have tried the error will occure almost instantly,
but that might not be the case on your system. Here is the script:


#!/usr/bin/perl -w

use Socket;

##
# adjust this to your tomcat / apache installation
$host = "localhost";
$port = 9600;
$doc = "/erfx/const.jsp";
##

$count = 0;
$read_lines = 1;

sub request {
my ($doc) = @_;
start:
$count++;
my $iaddr = inet_aton($host)
or die "unknown host\n";
my $paddr = sockaddr_in($port, $iaddr);
my $proto = getprotobyname('tcp');

socket(SOCK, PF_INET, SOCK_STREAM, $proto)
or die "socket failed\n";
connect(SOCK, $paddr)
or die "connect failed\n";
select SOCK;
$| = 1;
select STDOUT;

print SOCK <) {
if ($count % 2 == 0 && $read_lines == $.) {
$read_lines = 1 + ($read_lines + 1) % 20;
close(SOCK);
goto start;
}
$result .= $_;
}

close(SOCK);

return $result;
}


$result = request $doc;

$result =~ /value:\s*(\d+)(.|[\n\r])*href=\"([^\"]+)\"/m
or die "$result\nBad response\n";
$value = $1;
$url = $3;

print "$value $url\n";

$|=1;
for ($i = 0; ; $i++) {
$result = request $url;
$result =~ /value:\s*(\d+)(.|[\n\r])*href=\"([^\"]+)\"/m
or die "$result\nBad response\n";
$my_value = $1;
$my_url = $3;
$my_url eq $url or die "Got wrong URL: $my_url $url\n";
$my_value eq $value or die "Got wrong value: $my_value $value\n";
print "$i ok\r";
}



and the test JSP the script requests:



Test Page

HI THERE!

value: 
again
<% for (int y = 0; y < 50; y++) { %>

<% for (int i = 0; i < 1000; i++) { %> test <% } %>

<% } %>




Put that somewhere into your installation and adjust the marked lines in the
script to point to the right location.

The script might detect the error different ways. Usually it will fail with "Bad
response" because it receives the remaining part of a terminated response
missing the lines at the beginning the script looks for. May may also try
running multiple instances of the script. You may then get parts of responses to
requests of another instance.

The following patch provides a simple fix for the problem:


-- jk/native2/common/jk_worker_ajp13.c_old 2002-10-23 06:42:33.0 +0200
+++ jk/native2/common/jk_worker_ajp13.c 2002-10-23 06:29:48.0 +0200
@@ -394,6 +394,7 @@
  * upload data and we must consider that operation is no more recoverable
  */
 if (err!=JK_OK && ! e->recoverable ) {
+   e->worker->in_error_state=JK_TRUE;
 s->is_recoverable_error = JK_FALSE;
 env->l->jkLog(env, env->l, JK_LOG_ERROR,
   "ajp13.service() ajpGetReply unrecoverable error %d\n",


This way mod_jk2 will close the connection to tomcat and reconnect, thereby
dumping the part of tomcats response which can 

DO NOT REPLY [Bug 13869] - mod_jk2 becomes confused when client breaks the connection

2002-10-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13869

mod_jk2 becomes confused when client breaks the connection





--- Additional Comments From [EMAIL PROTECTED]  2002-10-23 06:02 ---
We allready had a following in the sources:

   if (err!=JK_OK && ! e->recoverable ) {
s->is_recoverable_error = JK_FALSE;
env->l->jkLog(env, env->l, JK_LOG_ERROR,
  "ajp13.service() ajpGetReply unrecoverable error %
d\n",
  err);
/* The connection is compromised, need to close it ! */
e->worker->in_error_state = 1;
return JK_ERR;
}


So there is allready setting of worker in_error_state.
If your sources are the same, an if it works with you patch, then the problem 
might be in race condition, caused by the logging.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 13869] - mod_jk2 becomes confused when client breaks the connection

2002-10-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13869

mod_jk2 becomes confused when client breaks the connection

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2002-10-23 06:15 ---
Looking at the current CVS repository, apparently it was fixed in Version 1.39
of the file. I was referring to the 4.1.12 distribution, which still contained
the bug.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 13040] - can't retrieve external context who's uri is a sub-dir of current context

2002-10-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13040

can't retrieve external context who's uri is a sub-dir of current context

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
  everconfirmed|0   |1



--- Additional Comments From [EMAIL PROTECTED]  2002-10-23 06:53 ---
In the general case, "/store/common" is supposed to return context "/store" if
it exists.
The current algorithm has a big problem with the root context, as pointed out by
Martin. However, it actually has the same problem for all contexts, so I think
there's a spec problem here.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: