Re: [PATCH] JDBCStore-howto.html Updated

2003-08-26 Thread Glenn Nielsen
Thanks for the patch Tom.

I don't see where we include this document in our release docs
anymore.  The JDBCStore is documented in /webapps/tomcat-docs/config/manager.xml .
And those docs are up to date.
Perhaps this file should be removed from CVS.

Regards,

Glenn

Tom Anderson wrote:
I noticed that the JDBCStore-howto.html no longer reflects reality so I 
updated it.   Here's my patch.

~Tom



Index: JDBCStore-howto.html
===
RCS file: /home/cvspublic/jakarta-tomcat-4.0/catalina/docs/JDBCStore-howto.html,v
retrieving revision 1.1
diff -u -r1.1 JDBCStore-howto.html
--- JDBCStore-howto.html27 Apr 2001 22:11:03 -  1.1
+++ JDBCStore-howto.html25 Aug 2003 21:46:33 -
@@ -44,6 +44,7 @@
 create table tomcat$sessions
 (
 id varchar(100) not null primary key,
+app varchar(100) not null,
 valid char(1) not null,
 maxinactive int not null,
 lastaccess bigint,
@@ -75,6 +76,7 @@
 mysql create table tomcat$sessions
 - (
 - id varchar(100) not null primary key,
+- app varchar(100) not null,
 - valid char(1) not null,
 - maxinactive int not null,
 - lastaccess bigint,
@@ -109,6 +111,7 @@
 connectionURL=jdbc:mysql://localhost/tomcat?user=testamp;amp;password=testbr
 sessionTable=tomcat$sessionsbr
 sessionIdCol=idbr
+sessionAppCol=appbr
 sessionDataCol=databr
 sessionValidCol=validbr
 sessionMaxInactiveCol=maxinactivebr
@@ -155,6 +158,11 @@
 tr
 td height=32sessionIdCol/td
 td The column in the session table that contains the session ID
+/td
+/tr
+tr
+td height=32sessionAppCol/td
+td The column in the session table that identifies the webapp (built 
from Engine, Host and Context).
 /td
 /tr
 tr


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


DO NOT REPLY [Bug 22236] - JNDI Realm authentication to Novell eDirectory via LDAP

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22236.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22236

JNDI Realm authentication to Novell eDirectory via LDAP





--- Additional Comments From [EMAIL PROTECTED]  2003-08-25 23:29 ---
Can I get a stacktrace? I thought I squished any NPE. But I *might* see one more
spot which might through a NPE. Please make sure the stacktrace is also against
4.1.27 and/or 5.0.9

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 8091] - JDBCRealm makes Tomcat unusable if the database is unavailable when Tomcat starts

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8091.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8091

JDBCRealm makes Tomcat unusable if the database is unavailable when Tomcat starts

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |



--- Additional Comments From [EMAIL PROTECTED]  2003-08-26 00:08 ---
Reopened since my reasoning didn't make sense and the patch seems easy enough

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 17908] - JDBCRealm getPassword() unimplemented

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17908.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17908

JDBCRealm getPassword() unimplemented

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2003-08-25 23:37 ---


*** This bug has been marked as a duplicate of 19767 ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler PageDataImpl.java TagLibraryInfoImpl.java

2003-08-26 Thread luehe
luehe   2003/08/25 17:08:33

  Modified:jasper2/src/share/org/apache/jasper/compiler
PageDataImpl.java TagLibraryInfoImpl.java
  Log:
  - Prepend urn:jsptld to uri values that represent relative paths
when adding xmlns:prefix attribute on the root of the JSP document's
XML view (see JSP.10.1.5)
  
  - Make the value passed as the uri argument to
TagLibraryValidator.validate() match the above
  
  Revision  ChangesPath
  1.35  +6 -3  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/PageDataImpl.java
  
  Index: PageDataImpl.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/PageDataImpl.java,v
  retrieving revision 1.34
  retrieving revision 1.35
  diff -u -r1.34 -r1.35
  --- PageDataImpl.java 12 Aug 2003 18:12:54 -  1.34
  +++ PageDataImpl.java 26 Aug 2003 00:08:32 -  1.35
  @@ -227,6 +227,9 @@
if (rootAttrs.getIndex(qName) == -1) {
String location = attrs.getValue(uri);
if (location != null) {
  +if (location.startsWith(/)) {
  +location = URN_JSPTLD + location;
  +}
rootAttrs.addAttribute(, , qName, CDATA,
   location);
} else {
  
  
  
  1.46  +11 -7 
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/TagLibraryInfoImpl.java
  
  Index: TagLibraryInfoImpl.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/TagLibraryInfoImpl.java,v
  retrieving revision 1.45
  retrieving revision 1.46
  diff -u -r1.45 -r1.46
  --- TagLibraryInfoImpl.java   25 Aug 2003 19:46:50 -  1.45
  +++ TagLibraryInfoImpl.java   26 Aug 2003 00:08:32 -  1.46
  @@ -82,7 +82,7 @@
* @author Kin-man Chung
* @author Jan Luehe
*/
  -class TagLibraryInfoImpl extends TagLibraryInfo {
  +class TagLibraryInfoImpl extends TagLibraryInfo implements TagConstants {
   
   // Logger
   private static Log log = LogFactory.getLog(TagLibraryInfoImpl.class);
  @@ -726,9 +726,13 @@
   public ValidationMessage[] validate(PageData thePage) {
TagLibraryValidator tlv = getTagLibraryValidator();
if (tlv == null) return null;
  - return tlv.validate(getPrefixString(),
  -(getReliableURN() != null) ? getReliableURN() : 
getURI(),
  -thePage);
  +
  +String uri = getURI();
  +if (uri.startsWith(/)) {
  +uri = URN_JSPTLD + uri;
  +}
  +
  + return tlv.validate(getPrefixString(), uri, thePage);
   }
   
   protected TagLibraryValidator tagLibraryValidator; 
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 19767] - Digest authentication doesn't work with JDBCRealm

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19767.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19767

Digest authentication doesn't work with JDBCRealm

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]
   ||o.in



--- Additional Comments From [EMAIL PROTECTED]  2003-08-25 23:37 ---
*** Bug 17908 has been marked as a duplicate of this bug. ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 20860] - JDBCRealm looses database connection

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20860.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20860

JDBCRealm looses database connection

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2003-08-25 23:52 ---


*** This bug has been marked as a duplicate of 11929 ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 11929] - JDBC Realm rejects user at first login

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11929.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11929

JDBC Realm rejects user at first login

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2003-08-26 01:08 ---
*** Bug 22126 has been marked as a duplicate of this bug. ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22126] - MySQL Connector J - JDBC Realm needs two attempts to open new connection

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22126.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22126

MySQL Connector J - JDBC Realm needs two attempts to open new connection

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2003-08-26 01:08 ---


*** This bug has been marked as a duplicate of 11929 ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/webapps/admin/connector connector.jsp

2003-08-26 Thread amyroh
amyroh  2003/08/25 15:16:39

  Modified:webapps/admin/WEB-INF/classes/org/apache/webapp/admin
ApplicationResources_en.properties
ApplicationResources_es.properties
   webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector
AddConnectorAction.java ConnectorForm.java
EditConnectorAction.java SaveConnectorAction.java
   webapps/admin/connector connector.jsp
  Log:
  Update admin with the latest connector changes.
  
  Revision  ChangesPath
  1.16  +12 -0 
jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationResources_en.properties
  
  Index: ApplicationResources_en.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationResources_en.properties,v
  retrieving revision 1.15
  retrieving revision 1.16
  diff -u -r1.15 -r1.16
  --- ApplicationResources_en.properties24 Aug 2003 22:52:45 -  1.15
  +++ ApplicationResources_en.properties25 Aug 2003 22:16:38 -  1.16
  @@ -114,20 +114,32 @@
   connector.type=Type
   connector.scheme=Scheme
   connector.accept.count=Accept Count
  +connector.compression=Compression
  +connector.connection.linger=Connection Linger
   connector.connection.timeout=Connection Timeout
  +connector.connection.uploadTimeout=Connection Upload Timeout
   connector.default.buffer=Default Buffer Size
  +connector.connection.disableUploadTimeout=Disable Upload Timeout
   connector.enable.dns=Enable DNS Lookups
   connector.address.ip=IP Address
   connector.redirect.portnumber=Redirect Port Number
   connector.min=Minimum
   connector.milliseconds=milliseconds
   connector.max=Maximum
  +connector.maxkeepalive=Max KeepAlive Requests
   connector.proxy.name=Proxy Name
   connector.proxy.portnumber=Proxy Port Number
  +connector.algorithm=Algorithm
  +connector.ciphers=Ciphers
   connector.client.auth=Client Authentication
   connector.keystore.filename=Keystore Filename
   connector.keystore.password=Keystore Password
  +connector.keystore.type=Keystore Type
  +connector.sslProtocol=SSL Protocol
   connector.keyPass.warning=liPlease use keytool to generate certificate./li
  +connector.secure=Secure
  +connector.tcpNoDelay=TCP No Delay 
  +connector.xpoweredby=X Powered By 
   host.properties=Host Properties
   host.name=Name
   host.base=Application Base
  
  
  
  1.15  +12 -0 
jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationResources_es.properties
  
  Index: ApplicationResources_es.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationResources_es.properties,v
  retrieving revision 1.14
  retrieving revision 1.15
  diff -u -r1.14 -r1.15
  --- ApplicationResources_es.properties24 Aug 2003 22:52:45 -  1.14
  +++ ApplicationResources_es.properties25 Aug 2003 22:16:38 -  1.15
  @@ -114,20 +114,32 @@
   connector.type=Tipo
   connector.scheme=Esquema
   connector.accept.count=Accept Count
  +connector.compression=Compresión
  +connector.connection.linger=La Conexión Se rezaga
   connector.connection.timeout=Tiempo De Espera De La Conexi\u00f3n
  +connector.connection.uploadTimeout=Descanso Del Upload De la Conexión
   connector.default.buffer=Tama\u00f1o por defecto del Buffer
  +connector.connection.disableUploadTimeout=Inhabilite El Descanso Del Upload
   connector.enable.dns=Permitir Busquedas en el DNS
   connector.address.ip=Direcci\u00f3n IP
   connector.redirect.portnumber=N\u00fmero del puerto de redireccionamiento
   connector.min=M\u00ednimo
   connector.milliseconds=milisegundos
   connector.max=M\u00e1ximo
  +connector.maxkeepalive=Peticiones Máximas De KeepAlive
   connector.proxy.name=Nombre del Proxy
   connector.proxy.portnumber=N\u00fmero de Puerto del Proxy
  +connector.algorithm=Algoritmo
  +connector.ciphers=Cifras
   connector.client.auth=Client Authentication
   connector.keystore.filename=Keystore Filename
   connector.keystore.password=Keystore Password
  +connector.keystore.type=Keystore Type
  +connector.sslProtocol=SSL Protocol
   connector.keyPass.warning=liUtilice por favor el keytool para generar el 
certificado/li
  +connector.secure=seguro
  +connector.tcpNoDelay=TCP No Delay 
  +connector.xpoweredby=X Powered By 
   host.properties=Propiedades del ordenador principal
   host.name=Nombre
   host.base=Base De la Aplicacion
  
  
  
  1.4   +16 -4 
jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector/AddConnectorAction.java
  
  Index: AddConnectorAction.java
  ===
  RCS file: 

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm JDBCRealm.java

2003-08-26 Thread funkman
funkman 2003/08/25 18:10:20

  Modified:catalina/src/share/org/apache/catalina/realm JDBCRealm.java
  Log:
  Big JDBCRealm cleanup
  7116 - JDBC realm doesn't handle NULL passwords
  10623 - JDBCRealm lacks one DB commit, preventing sucessfull authentication under 
certain circunstances
  11929 - In case db connection is bad (stale due to firewall ...) - retry 
authenticating (2 tries total)
  And many dups
  8091 - Allow tomcat to startup even if the database isn't available
  (and some other dup bz items)
  
  Make authenticate synchronized since there are race conditions between the 
connection being
  opened, used and exceptions occuring.
  
  Revision  ChangesPath
  1.2   +107 -81   
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/JDBCRealm.java
  
  Index: JDBCRealm.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/JDBCRealm.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- JDBCRealm.java18 Jul 2002 16:47:55 -  1.1
  +++ JDBCRealm.java26 Aug 2003 01:10:20 -  1.2
  @@ -65,7 +65,6 @@
   
   
   import java.io.File;
  -import java.security.MessageDigest;
   import java.security.Principal;
   import java.sql.Connection;
   import java.sql.Driver;
  @@ -74,17 +73,8 @@
   import java.sql.SQLException;
   import java.util.ArrayList;
   import java.util.Properties;
  -import org.apache.catalina.Container;
  -import org.apache.catalina.Lifecycle;
  -import org.apache.catalina.LifecycleEvent;
   import org.apache.catalina.LifecycleException;
  -import org.apache.catalina.LifecycleListener;
  -import org.apache.catalina.Logger;
  -import org.apache.catalina.Realm;
  -import org.apache.catalina.util.HexUtils;
  -import org.apache.catalina.util.LifecycleSupport;
   import org.apache.catalina.util.StringManager;
  -import org.apache.catalina.util.Base64;
   
   
   /**
  @@ -95,7 +85,7 @@
   *
   * pstrongTODO/strong - Support connection pooling (including message
   * format objects) so that codeauthenticate()/code does not have to be
  -* synchronized./p
  +* synchronized and would fix the ugly connection logic. /p
   *
   * @author Craig R. McClanahan
   * @author Carson McDonald
  @@ -377,43 +367,53 @@
* event is also logged, and the connection will be closed so that
* a subsequent request will automatically re-open it.
*
  + *
* @param username Username of the Principal to look up
* @param credentials Password or other credentials to use in
*  authenticating this username
*/
  -public Principal authenticate(String username, String credentials) {
  -
  -Connection dbConnection = null;
  +public synchronized Principal authenticate(String username, String credentials) 
{
   
  -try {
  +// Number of tries is the numebr of attempts to connect to the database
  +// during this login attempt (if we need to open the database)
  +// This needs rewritten wuth better pooling support, the existing code
  +// needs signature changes since the Prepared statements needs cached
  +// with the connections.
  +// The code below will try twice if there is a SQLException so the
  +// connection may try to be opened again. On normal conditions (including
  +// invalid login - the above is only used once.
  +int numberOfTries = 2;
  +while (numberOfTries0) {
  +try {
   
  -// Ensure that we have an open database connection
  -dbConnection = open();
  +// Ensure that we have an open database connection
  +open();
   
  -// Acquire a Principal object for this user
  -Principal principal = authenticate(dbConnection,
  -   username, credentials);
  +// Acquire a Principal object for this user
  +Principal principal = authenticate(dbConnection,
  +   username, credentials);
   
  -// Release the database connection we just used
  -release(dbConnection);
   
  -// Return the Principal (if any)
  -return (principal);
  +// Return the Principal (if any)
  +return (principal);
   
  -} catch (SQLException e) {
  +} catch (SQLException e) {
   
  -// Log the problem for posterity
  -log(sm.getString(jdbcRealm.exception), e);
  +// Log the problem for posterity
  +log(sm.getString(jdbcRealm.exception), e);
   
  -// Close the connection so that it gets reopened next time
  -if (dbConnection != null)
  -close(dbConnection);
  +// Close the 

DO NOT REPLY [Bug 21190] - JDBCRealm is trying to use closed connections without checking

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21190.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21190

JDBCRealm is trying to use closed connections without checking

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2003-08-26 01:07 ---


*** This bug has been marked as a duplicate of 11929 ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 10361] - JDBCRealm requires restart if JDBC connection fails.

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10361.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10361

JDBCRealm requires restart if JDBC connection fails.

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-08-26 01:14 ---
Fixed for tomcat5 - please confirm with HEAD of tomcat 5 (or when 5.0.10 is
available). Upon confirmation - will backport to tomcat 4.1 Will not port to
tomcat 4.0.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 10623] - JDBCRealm lacks one DB commit, preventing sucessfull authentication under certain circunstances

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10623.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10623

JDBCRealm lacks one DB commit, preventing sucessfull authentication under certain 
circunstances

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-08-26 01:14 ---
Fixed for tomcat5 - please confirm with HEAD of tomcat 5 (or when 5.0.10 is
available). Upon confirmation - will backport to tomcat 4.1 Will not port to
tomcat 4.0.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 11929] - JDBC Realm rejects user at first login

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11929.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11929

JDBC Realm rejects user at first login

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-08-26 01:15 ---
Fixed for tomcat5 - please confirm with HEAD of tomcat 5 (or when 5.0.10 is
available). Upon confirmation - will backport to tomcat 4.1 Will not port to
tomcat 4.0.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 8091] - JDBCRealm makes Tomcat unusable if the database is unavailable when Tomcat starts

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8091.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8091

JDBCRealm makes Tomcat unusable if the database is unavailable when Tomcat starts

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-08-26 01:16 ---
Fixed for tomcat5 - please confirm with HEAD of tomcat 5 (or when 5.0.10 is
available). Upon confirmation - will backport to tomcat 4.1 Will not port to
tomcat 4.0.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22715] New: - tomcat-user.xml re-writing with xml entities

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22715.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22715

tomcat-user.xml re-writing with xml entities

   Summary: tomcat-user.xml re-writing with xml entities
   Product: Tomcat 4
   Version: 4.1.27
  Platform: PC
OS/Version: All
Status: NEW
  Severity: Minor
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I'm using the UserDatabase (org.apache.catalina.UserDatabase /
org.apache.catalina.users.MemoryUserDatabaseFactory) as configured by default 
with Tomcat 4.1.27.

Our System admin made a basic XML error, and in tomcat-users.xml put and entry 
in like...

user username=tomcat password=tomcat roles=tomcat /

Obviously the '' makes this invalid XML, and tomcat doesn't start...

We changed the  to amp; the XML was then valid, the user account worked, 
life was good

A few days later, after he restarted the server, it was broke again...

Seems that when Tomcat re-wrote out the tomcat-users.xml file, instead of 
escaping the  and writing it back out as amp; it just put it out a , so we 
were back to square one!

Question:
1) Is this a bug? 
2) Can I stop the 're-writing' part of this as a work around?
3) Are XML entities not allowed in tomcat-users.xml?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources messages.properties

2003-08-26 Thread luehe
luehe   2003/08/25 15:25:55

  Modified:jasper2/src/share/org/apache/jasper/compiler
JspDocumentParser.java
   jasper2/src/share/org/apache/jasper/resources
messages.properties
  Log:
  Ensure that jsp:root is root element in JSP document
  
  Revision  ChangesPath
  1.67  +9 -4  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/JspDocumentParser.java
  
  Index: JspDocumentParser.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/JspDocumentParser.java,v
  retrieving revision 1.66
  retrieving revision 1.67
  diff -u -r1.66 -r1.67
  --- JspDocumentParser.java21 Aug 2003 23:10:49 -  1.66
  +++ JspDocumentParser.java25 Aug 2003 22:25:54 -  1.67
  @@ -605,7 +605,12 @@
Node node = null;
   
if (localName.equals(ROOT_ACTION)) {
  - node = new Node.JspRoot(qName, nonTaglibAttrs, nonTaglibXmlnsAttrs,
  +if (!(current instanceof Node.Root)) {
  +throw new SAXParseException(
  +Localizer.getMessage(jsp.error.nested_jsproot),
  +locator);
  +}
  +node = new Node.JspRoot(qName, nonTaglibAttrs, nonTaglibXmlnsAttrs,
taglibAttrs, start, current);
if (isTop) {
pageInfo.setHasJspRoot(true);
  
  
  
  1.132 +2 -1  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources/messages.properties
  
  Index: messages.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources/messages.properties,v
  retrieving revision 1.131
  retrieving revision 1.132
  diff -u -r1.131 -r1.132
  --- messages.properties   15 Aug 2003 00:06:09 -  1.131
  +++ messages.properties   25 Aug 2003 22:25:55 -  1.132
  @@ -399,3 +399,4 @@
   jsp.error.text.has_subelement=lt;jsp:textgt; must not have any subelements
   jsp.error.data.file.read=Error reading file \{0}\
   jsp.error.prefix.refined=Attempt to redefine the prefix {0} to {1}, when it was 
already defined as {2} in the current scope.
  +jsp.error.nested_jsproot=Nested lt;jsp:rootgt;
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22716] New: - NotSerializableException not caught by PersistentManager

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22716.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22716

NotSerializableException not caught by PersistentManager

   Summary: NotSerializableException not caught by PersistentManager
   Product: Tomcat 4
   Version: 4.1.24
  Platform: All
OS/Version: All
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


When we change classes in our webapps that uses persistent sessions, the older 
sessions throw 
NotSerializableExceptions (because the class changed).   This causes a couple of 
problems.  First, 
the thread that checks for timeouts (PersistentManagerBase.run()) exits.   Second, if 
we try to get a 
session that contains objects of the old (unserializable) class then it returns a 
valid session with 
nothing in it (shouldn't it be invalidated?).

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 7116] - JDBC realm doesn't handle NULLpasswords

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7116.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7116

JDBC realm doesn't handle NULLpasswords

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-08-26 01:16 ---
Fixed for tomcat5 - please confirm with HEAD of tomcat 5 (or when 5.0.10 is
available). Upon confirmation - will backport to tomcat 4.1 Will not port to
tomcat 4.0.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 8091] - JDBCRealm makes Tomcat unusable if the database is unavailable when Tomcat starts

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8091.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8091

JDBCRealm makes Tomcat unusable if the database is unavailable when Tomcat starts

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||WONTFIX



--- Additional Comments From [EMAIL PROTECTED]  2003-08-25 23:51 ---
For the interest of security - I am marking as WONTFIX since the unavailability
of the Realm could expose a security issue and the safe thing is to not start.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] 5.0.9 stability rating

2003-08-26 Thread Bill Barker

Jean-Francois Arcand [EMAIL PROTECTED] wrote in message
news:[EMAIL PROTECTED]


 Bill Barker wrote:

 - Original Message -
 From: Jean-Francois Arcand [EMAIL PROTECTED]
 To: Tomcat Developers List [EMAIL PROTECTED]
 Sent: Monday, August 25, 2003 6:20 AM
 Subject: Re: [VOTE] 5.0.9 stability rating
 
 
 
 
 Bill Barker wrote:
 
 
 
 - Original Message -
 From: Remy Maucherat [EMAIL PROTECTED]
 To: Tomcat Developers List [EMAIL PROTECTED]
 Sent: Monday, August 25, 2003 12:32 AM
 Subject: Re: [VOTE] 5.0.9 stability rating
 
 
 
 
 
 
 Bill Barker wrote:
 
 
 
 
 Tim Funk wrote:
 
 
 
 
 
 Installed 5.0.9 from exe (win2k)
 1) startup.bat worked fine, but the icon which calls tomcatw.exe
 //GT//Tomcat5 fails will some Current Thread not owner error
 2) Race conditions and connection handling in JDBCRealm - plus a
 
 
 whole
 
 
 host of other JDBCRealm bugs in Bugzilla applicable to 4 and 5. I
 
 
 hope
 
 
 early next week to have a patch which will close many of the
 
 
 JDBCRealm
 
 
 bugs.
 3) Need to reinvestigate the JNDIRealm bug reopened.
 
 For the first error - I am sure I just need to look through
bugzilla,
 
 
 
 
 or
 
 
 
 
 the archives and just need to add something to the README.  (User
 
 
 
 
 error)
 
 
 
 
 This works for me, Bill, and presumably others. There are reports on
 tomcatw in BZ, so it must be at least an uncommon error (given the
 
 
 code
 
 
 have stayed stable for a few releases). Even if the bug is mildly
 common, the old shell scripts are still there. I can put a note
 
 
 stating
 
 
 that they can be used in case the new .exe wrapper somehow fails.
 
 I'm staying by my beta rating. Again, we cannot continue releasing
 alphas just because there could be some non obvious bugs in the
build.
 In the current system, the period before the vote is meant to check
if
 there are no showstoppers. If the build is mostly clean, it must be
a
 beta, otherwise, it merely delays wider testing and finding bugs,
 
 
 which
 
 
 is *bad*.
 
 
 
 
 Ok.  I'm willing to vote for a (weak) Beta in exchange for a
 
 
 
 
 release-note
 
 
 
 
 that Tomcat doesn't implement the current-draft's Authentication
 requirements.
 
 
 
 
 What is your plan, BTW ? Wait a bit more for the deadline to see what
 the final specification will say ? (IMO, the old auth matching rules
 were not very good)
 
 
 
 
 I was hoping for a pfd4, but it doesn't look like it's coming out
anytime
 soon :-(.  It's a pretty big change to conform to pfd3 (which is a
 completely nonsensical requirement :), so I was playing the
wait-and-see
 game.  Of course, I'm more than happy to do the grunt work to bring
 
 
 Tomcat
 
 
 into compliance with pfd3.  However, if the spec changes to something
 sensible, then that means two big (e.g. changing interfaces in o.a.c)
API
 changes.
 
 
 
 The spec should'nt change now. I don't really understand why you think
 we aren't complinat right nowI tough your last change was to bring
 back compatibility with PFD 3.  Do you have an example I can use to
 demonstrate the problem?
 
 Thanks,
 
 
 
 The following doesn't work correctly according to pfd3:
 
 security-constraint
   web-resource-collection
  url-pattern/*/url-pattern
   /web-resource-collection
   auth-constraint
  role-name*/role-name
   /auth-constraint
  /security-constraint
 security-constraint
   web-resource-collection
  url-pattern/product1/*/url-pattern
   /web-resource-collection
   auth-constraint
  role-nameproduct1/role-name
   /auth-constraint
  /security-constraint
 security-constraint
   web-resource-collection
  url-pattern/product2/*/url-pattern
   /web-resource-collection
   auth-constraint
  role-nameproduct2/role-name
   /auth-constraint
  /security-constraint
 
 With Tomcat, you need role 'product1' to access /myapp/product1, role
 'product2' to access /myapp/product2, and must be authenticated to access
 anything else.
 
 The correct behavior is that any authenticated user can access anything.
 
 My understanding of the spec is that is the proper behaviour (just
 discussed the issue with the spec lead). Having role-name equals to *
 doesn't means you have access to /product1/* etc.  The spec will be
 clarified (but the required behaviour will stay the same)

+1 for clarification (although somewhat meaningless, since I'm not a
servlet-api committer :).  It currently reads too much like it was modeled
after 'grant'.

I guess that gets rid of my excuses to not re-visit the code and see if I
can't get rid of some of the garbage.


 -- Jeanfrancois


 
 
 
 
 -- Jeanfrancois
 
 
 
 
 
 
 
 
 Remy
 
 
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 
 
 
 
 
 


 
 This message is intended only for the use of the person(s) listed above
 
 
 as the intended recipient(s), and may 

DO NOT REPLY [Bug 11929] - JDBC Realm rejects user at first login

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11929.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11929

JDBC Realm rejects user at first login

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2003-08-26 01:07 ---
*** Bug 21190 has been marked as a duplicate of this bug. ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm RealmBase.java

2003-08-26 Thread billbarker
billbarker2003/08/25 21:04:56

  Modified:catalina/src/share/org/apache/catalina/realm RealmBase.java
  Log:
  Simplifying the code by hiding the arrayCopy.  No real functional changes.
  
  Revision  ChangesPath
  1.15  +5 -5  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/RealmBase.java
  
  Index: RealmBase.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/RealmBase.java,v
  retrieving revision 1.14
  retrieving revision 1.15
  diff -u -r1.14 -r1.15
  --- RealmBase.java25 Jul 2003 05:06:49 -  1.14
  +++ RealmBase.java26 Aug 2003 04:04:56 -  1.15
  @@ -487,7 +487,7 @@
   if(results == null)
   return null;
   SecurityConstraint [] array = new SecurityConstraint [results.size()];
  -System.arraycopy(results.toArray(), 0, array, 0, array.length);
  +results.toArray(array);
   return array;
   
   }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[PATCH] jakarta-servletapi-5 API Changes

2003-08-26 Thread Mark Roth
jsr152/src/share/javax/servlet/jsp/tagext/TagInfo.java
- Fixed incorrect clarification of getVariableInfo().  The original
  semantics requiring special treatment of the id attribute
  were supposed to have been removed in JSP 1.2.  We brought them
  back to life in JSP 2.0, but the right thing to do was to remove
  them altogether, as no containers implemented them anyway.
jsr152/src/share/javax/servlet/jsp/tagext/TagLibraryValidator.java
- Clarified that the URI passed to validate() is the same as
  the URI in the XML View, not the uri passed to the taglib
  directive (which doesn't always exist or produce consistent
  results)
---
Mark Roth, Java Software
JSP 2.0 Co-Specification Lead
Sun Microsystems, Inc.
Index: jsr152/src/share/javax/servlet/jsp/tagext/TagInfo.java
===
RCS file: 
/home/cvspublic/jakarta-servletapi-5/jsr152/src/share/javax/servlet/jsp/tagext/TagInfo.java,v
retrieving revision 1.7
diff -u -r1.7 TagInfo.java
--- jsr152/src/share/javax/servlet/jsp/tagext/TagInfo.java  8 Aug 2003 22:27:40 
-   1.7
+++ jsr152/src/share/javax/servlet/jsp/tagext/TagInfo.java  25 Aug 2003 20:15:19 
-
@@ -268,25 +268,13 @@
  * @param data TagData describing this action.
  * @return if a TagExtraInfo object is associated with this TagInfo, the
  * result of getTagExtraInfo().getVariableInfo( data ), otherwise
- * null if the tag has no id attribute or new VariableInfo[] {
- * new VariableInfo( data.getId(), java.lang.Object, true,
- * VariableInfo.NESTED ) } if an id attribute is present.
+ * null.
  */
public VariableInfo[] getVariableInfo(TagData data) {
VariableInfo[] result = null;
TagExtraInfo tei = getTagExtraInfo();
if (tei != null) {
   result = tei.getVariableInfo( data );
-   }
-   else {
-  String idValue = data.getId();
-  if( idValue != null ) {
-  result = 
-  new VariableInfo[] {
-  new VariableInfo( idValue, java.lang.Object,
-  true, VariableInfo.NESTED )
-  };
-  }
}
return result;
}
Index: jsr152/src/share/javax/servlet/jsp/tagext/TagLibraryValidator.java
===
RCS file: 
/home/cvspublic/jakarta-servletapi-5/jsr152/src/share/javax/servlet/jsp/tagext/TagLibraryValidator.java,v
retrieving revision 1.6
diff -u -r1.6 TagLibraryValidator.java
--- jsr152/src/share/javax/servlet/jsp/tagext/TagLibraryValidator.java  14 Apr 2003 
17:36:39 -  1.6
+++ jsr152/src/share/javax/servlet/jsp/tagext/TagLibraryValidator.java  25 Aug 2003 
20:15:19 -
@@ -76,7 +76,7 @@
  *
  * once initialized, the validate(String, String, PageData) method will
  * be invoked, where the first two arguments are the prefix
- * and uri arguments used in the taglib directive.  The prefix is intended
+ * and uri for this tag library in the XML View.  The prefix is intended
  * to make it easier to produce an error message.  However, it is not
  * always accurate.  In the case where a single URI is mapped to more 
  * than one prefix in the XML view, the prefix of the first URI is provided.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.c

2003-08-26 Thread billbarker
billbarker2003/08/25 21:20:04

  Modified:jk/native/common jk_uri_worker_map.c
  Log:
  Changing the contract for map_uri_to_worker, as discussed on tomcat-dev.
  
  The 'uri' parameter is now considered to be modifiable by this routine.  This fixes 
a multi-threading problem when using Apache2 on high-end machines.
  
  Reported by: Marc Saegesser
  
  Revision  ChangesPath
  1.18  +3 -9  jakarta-tomcat-connectors/jk/native/common/jk_uri_worker_map.c
  
  Index: jk_uri_worker_map.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_uri_worker_map.c,v
  retrieving revision 1.17
  retrieving revision 1.18
  diff -u -r1.17 -r1.18
  --- jk_uri_worker_map.c   6 Aug 2003 12:19:55 -   1.17
  +++ jk_uri_worker_map.c   26 Aug 2003 04:20:04 -  1.18
  @@ -490,14 +490,12 @@
   unsigned i;
   unsigned best_match = -1;
   unsigned longest_match = 0;
  -char *clean_uri = jk_pool_strdup(uw_map-tp,uri);
  -char *url_rewrite = strstr(clean_uri, JK_PATH_SESSION_IDENTIFIER);
  +char *url_rewrite = strstr(uri, JK_PATH_SESSION_IDENTIFIER);
   
   if(url_rewrite) {
   *url_rewrite = '\0';
   }
  -jk_no2slash(clean_uri);
  -uri = clean_uri;
  +jk_no2slash(uri);
   
   jk_log(l, JK_LOG_DEBUG, Attempting to map URI '%s'\n, uri);
   for(i = 0 ; i  uw_map-size ; i++) {
  @@ -518,7 +516,6 @@
   Found an exact match %s - %s\n,
   uwr-worker_name,
   uwr-context );
  -jk_reset_pool(uw_map-tp);
   return uwr-worker_name;
   }
   } else if(MATCH_TYPE_CONTEXT == uwr-match_type) {
  @@ -594,7 +591,6 @@
   }
   
   if(-1 != best_match) {
  -jk_reset_pool(uw_map-tp);
   return uw_map-maps[best_match]-worker_name;
   } else {
   /*
  @@ -611,10 +607,8 @@
   jk_log(l, JK_LOG_EMERG, 
  In jk_uri_worker_map_t::map_uri_to_worker, found a security 
fraud in '%s'\n,
  uri);
  -jk_reset_pool(uw_map-tp);
   return uw_map-maps[fraud]-worker_name;
   }
  -jk_reset_pool(uw_map-tp);
  }
   } else {
   jk_log(l, JK_LOG_ERROR, 
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jk/native/apache-2.0 mod_jk.c

2003-08-26 Thread billbarker
billbarker2003/08/25 21:28:12

  Modified:jk/native/apache-2.0 mod_jk.c
  Log:
  Changes for Apache2 to support the new contract.
  
  Revision  ChangesPath
  1.82  +11 -5 jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c
  
  Index: mod_jk.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c,v
  retrieving revision 1.81
  retrieving revision 1.82
  diff -u -r1.81 -r1.82
  --- mod_jk.c  15 Jul 2003 12:16:05 -  1.81
  +++ mod_jk.c  26 Aug 2003 04:28:12 -  1.82
  @@ -1696,7 +1696,8 @@
Manual configuration for %s %s %d\n,
r-uri, worker_env.first_worker, worker_env.num_of_workers); 
 } else {
  -  worker_name = map_uri_to_worker(xconf-uw_map, r-uri, xconf-log);
  +  char *uri = apr_pstrdup(r-pool, r-uri);
  +  worker_name = map_uri_to_worker(xconf-uw_map, uri, xconf-log);
 if( worker_name == NULL ) 
 worker_name=  worker_env.first_worker;
 jk_log(xconf-log, JK_LOG_DEBUG, 
  @@ -1719,7 +1720,8 @@
   
   if(conf  ! worker_name ) {
   /* Direct mapping ( via setHandler ). Try overrides */
  -worker_name = map_uri_to_worker(conf-uw_map, r-uri, conf-log);
  +char *uri = apr_strdup(r-pool, r-uri);
  +worker_name = map_uri_to_worker(conf-uw_map, uri, conf-log);
   if( ! worker_name ) {
   /* Since we are here, an explicit (native) mapping has been used */
   /* Use default worker */
  @@ -2256,6 +2258,7 @@
   
   if(conf) {
   char *worker;
  +char *uri;
   if( (r-handler != NULL )  
   (! strcmp( r-handler, JK_HANDLER ) )) {
   /* Somebody already set the handler, probably manual config
  @@ -2265,7 +2268,8 @@
  Manually mapped, no need to call uri_to_worker\n);
   return DECLINED;
   }
  -worker = map_uri_to_worker(conf-uw_map, r-uri, conf-log);
  +uri = apr_pstrdup(r-pool, r-uri);
  +worker = map_uri_to_worker(conf-uw_map, uri, conf-log);
   
   if(worker) {
   r-handler=apr_pstrdup(r-pool,JK_HANDLER);
  @@ -2370,6 +2374,7 @@
   
   if(conf) {
   char *worker;
  +char *uri;
   if( (r-handler != NULL ) 
   (! strcmp( r-handler, JK_HANDLER ) )) {
   /* Somebody already set the handler, probably manual config
  @@ -2379,7 +2384,8 @@
  Manually mapped, no need to call uri_to_worker\n);
   return DECLINED;
   }
  -worker = map_uri_to_worker(conf-uw_map, r-uri, conf-log);
  +uri = apr_strdup(r-pool, r-uri);
  +worker = map_uri_to_worker(conf-uw_map, uri, conf-log);
   
   if(worker) {
   r-handler=apr_pstrdup(r-pool,JK_HANDLER);
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jk/native/apache-1.3 mod_jk.c

2003-08-26 Thread billbarker
billbarker2003/08/25 21:32:59

  Modified:jk/native/apache-1.3 mod_jk.c
  Log:
  Apache 1.3 support for new contract.
  
  Revision  ChangesPath
  1.42  +4 -3  jakarta-tomcat-connectors/jk/native/apache-1.3/mod_jk.c
  
  Index: mod_jk.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/apache-1.3/mod_jk.c,v
  retrieving revision 1.41
  retrieving revision 1.42
  diff -u -r1.41 -r1.42
  --- mod_jk.c  7 Aug 2003 22:12:35 -   1.41
  +++ mod_jk.c  26 Aug 2003 04:32:59 -  1.42
  @@ -1819,7 +1819,8 @@
   
   if(conf) {
   jk_logger_t *l = conf-log ? conf-log : main_log;
  -char *worker = map_uri_to_worker(conf-uw_map, r-uri, l);
  +char *uri = ap_pstrdup(r-pool, r-uri);
  +char *worker = map_uri_to_worker(conf-uw_map, uri, l);
   
   /* Don't know the worker, ForwardDirectories is set, there is a
* previous request for which the handler is JK_HANDLER (as set by
  @@ -1841,7 +1842,7 @@
   r-handler = ap_pstrdup(r-pool, JK_HANDLER);
   ap_table_setn(r-notes, JK_WORKER_ID, worker);
   } else if(conf-alias_dir != NULL) {
  -char *clean_uri = ap_pstrdup(r-pool, r-uri);
  +char *clean_uri = uri;
   ap_no2slash(clean_uri);
   /* Automatically map uri to a context static file */
   jk_log(l, JK_LOG_DEBUG,
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jk/native/iis jk_isapi_plugin.c

2003-08-26 Thread billbarker
billbarker2003/08/25 21:41:54

  Modified:jk/native/iis jk_isapi_plugin.c
  Log:
  Updating IIS for the changed contract.
  
  This one scares me, but I don't know (or want to know :) the ISAPI enough to know if 
it is safe to use stack-frame buffers.
  
  Nacho, Mladin: If you could review this, I'd be very grateful.  Unlike Apache, I 
can't actually build this one.
  
  Revision  ChangesPath
  1.19  +5 -4  jakarta-tomcat-connectors/jk/native/iis/jk_isapi_plugin.c
  
  Index: jk_isapi_plugin.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/iis/jk_isapi_plugin.c,v
  retrieving revision 1.18
  retrieving revision 1.19
  diff -u -r1.18 -r1.19
  --- jk_isapi_plugin.c 25 Sep 2002 00:49:40 -  1.18
  +++ jk_isapi_plugin.c 26 Aug 2003 04:41:54 -  1.19
  @@ -759,13 +759,14 @@
   jk_log(logger, JK_LOG_DEBUG, 
  In HttpFilterProc Virtual Host redirection of %s\n, 
  snuri);
  -worker = map_uri_to_worker(uw_map, snuri, logger);
  -}
  +} else {
  +   strncpy(snuri, uri, sizeof(snuri));
  + }
   if (!worker) {
   jk_log(logger, JK_LOG_DEBUG, 
  In HttpFilterProc test Default redirection of %s\n, 
  uri);
  -worker = map_uri_to_worker(uw_map, uri, logger);
  +worker = map_uri_to_worker(uw_map, snuri, logger);
   }
   
   if (worker) {
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jk/native/domino jk_dsapi_plugin.c

2003-08-26 Thread billbarker
billbarker2003/08/25 21:54:32

  Modified:jk/native/domino jk_dsapi_plugin.c
  Log:
  Update Domino for new contract.
  
  I've got no clue on how to implement this efficiently.  Hopefully there are still 
Domino people lurking on the list that will give a better patch.
  
  Revision  ChangesPath
  1.11  +7 -6  jakarta-tomcat-connectors/jk/native/domino/jk_dsapi_plugin.c
  
  Index: jk_dsapi_plugin.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/domino/jk_dsapi_plugin.c,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- jk_dsapi_plugin.c 28 Jun 2001 18:45:40 -  1.10
  +++ jk_dsapi_plugin.c 26 Aug 2003 04:54:32 -  1.11
  @@ -980,7 +980,7 @@
if (fr.URL  strlen(fr.URL))
{
char *uri = fr.URL;
  - char *workerName, *qp;
  + char *workerName, *qp, *turi;
   
if (!initDone)
{
  @@ -1038,11 +1038,12 @@
   
if (!ok) return kFilterError;
initDone = JK_TRUE;
  - }
  +}
   
  - if (qp = strchr(uri, '?'), qp != NULL) *qp = '\0';
  - workerName = map_uri_to_worker(uw_map, uri, logger);
  - if (qp) *qp = '?';
  +turi = strdup(uri);
  +if (qp = strchr(turi, '?'), tqp != NULL) *qp = '\0';
  +workerName = map_uri_to_worker(uw_map, turi, logger);
  +free(turi);
   
DEBUG((Worker for this URL is %s\n, workerName));
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 11929] - JDBC Realm rejects user at first login

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11929.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11929

JDBC Realm rejects user at first login

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2003-08-25 23:52 ---
*** Bug 20860 has been marked as a duplicate of this bug. ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [PATCH] JDBCStore-howto.html Updated

2003-08-26 Thread Tom Anderson
The JDBCStore-howto.html document is in catalina/docs.But I see 
that manager.xml is NOT up-to-date (does not document the app column 
in JDBCStore).   Also, many of the attributes that are listed as 
required actually have default values.   And, shouldn't the example of 
the created table contain the default column names?

Here is a patch to manager.xml with my corrections.   Take it for what 
it's worth.   ;-)

~Tom

On Monday, August 25, 2003, at 05:13 PM, Glenn Nielsen wrote:

Thanks for the patch Tom.

I don't see where we include this document in our release docs
anymore.  The JDBCStore is documented in 
/webapps/tomcat-docs/config/manager.xml .
And those docs are up to date.

Perhaps this file should be removed from CVS.

Regards,

Glenn

Tom Anderson wrote:
I noticed that the JDBCStore-howto.html no longer reflects reality so 
I updated it.   Here's my patch.
~Tom




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 4975] - Connection closed before response is sent

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4975.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4975

Connection closed before response is sent

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2003-08-26 06:06 ---
*** Bug 22588 has been marked as a duplicate of this bug. ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22588] - large file uploads fail with server not found error

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22588.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22588

large file uploads fail with server not found error

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2003-08-26 06:06 ---


*** This bug has been marked as a duplicate of 4975 ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22722] New: - Null Pointer in o.a.c.t.CoyoteAdapter without StackTrace

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22722.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22722

Null Pointer in o.a.c.t.CoyoteAdapter without StackTrace

   Summary: Null Pointer in o.a.c.t.CoyoteAdapter without StackTrace
   Product: Tomcat 5
   Version: 5.0.9
  Platform: Other
OS/Version: Linux
Status: UNCONFIRMED
  Severity: Critical
  Priority: Other
 Component: Connector:Coyote HTTP/1.1
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


SEVERE: An exception or error occurred in the container during the request
processing
java.lang.NullPointerException
Aug 26, 2003 7:17:57 AM org.apache.coyote.tomcat5.CoyoteAdapter service
SEVERE: An exception or error occurred in the container during the request
processing
java.lang.NullPointerException
Aug 26, 2003 7:18:00 AM org.apache.coyote.tomcat5.CoyoteAdapter service
SEVERE: An exception or error occurred in the container during the request
processing
java.lang.NullPointerException
Aug 26, 2003 7:18:09 AM org.apache.coyote.tomcat5.CoyoteAdapter service
SEVERE: An exception or error occurred in the container during the request
processing
java.lang.NullPointerException
Aug 26, 2003 7:18:24 AM org.apache.coyote.tomcat5.CoyoteAdapter service
SEVERE: An exception or error occurred in the container during the request
processing
java.lang.NullPointerException

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22722] - Null Pointer in o.a.c.t.CoyoteAdapter without StackTrace

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22722.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22722

Null Pointer in o.a.c.t.CoyoteAdapter without StackTrace

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2003-08-26 07:01 ---
Please submit a test case, or explain how to reproduce this.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22691] - TldConfig.getGlobalJarPath() throws an IOException which is not really catched

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22691.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22691

TldConfig.getGlobalJarPath() throws an IOException which is not really catched

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-08-26 07:20 ---
This will be finxed in 5.0.10.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup TldConfig.java

2003-08-26 Thread remm
remm2003/08/26 00:17:44

  Modified:catalina/src/share/org/apache/catalina/startup
TldConfig.java
  Log:
  - Wrap getCanonicalFile in a try/catch (bug 22691). If the classpath or a CL has 
dubious
entries, they will simply be ignored.
  
  Revision  ChangesPath
  1.18  +9 -5  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/TldConfig.java
  
  Index: TldConfig.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/TldConfig.java,v
  retrieving revision 1.17
  retrieving revision 1.18
  diff -u -r1.17 -r1.18
  --- TldConfig.java22 Aug 2003 23:18:24 -  1.17
  +++ TldConfig.java26 Aug 2003 07:17:43 -  1.18
  @@ -229,9 +229,9 @@
   
   File tldCache=null;
   
  -if( context instanceof StandardContext ) {
  -File workDir=(File)
  -
((StandardContext)context).getServletContext().getAttribute(Globals.WORK_DIR_ATTR);
  +if (context instanceof StandardContext) {
  +File workDir= (File)
  +
((StandardContext)context).getServletContext().getAttribute(Globals.WORK_DIR_ATTR);
   tldCache=new File( workDir, tldCache.ser);
   }
   
  @@ -753,7 +753,7 @@
* @return Map of paths to all JAR files accessible to all parent class
* loaders of the web application class loader
*/
  -private Map getGlobalJarPaths() throws IOException {
  +private Map getGlobalJarPaths() {
   
   HashMap globalJarPaths = null;
   
  @@ -767,7 +767,11 @@
   // over file or the custom jndi handler, but a lot less
   // buggy overall
   File file = new File(urls[i].getFile());
  -file = file.getCanonicalFile();
  +try {
  +file = file.getCanonicalFile();
  +} catch (IOException e) {
  +// Ignore
  +}
   if (file.exists()) {
   String path = file.getAbsolutePath();
   if (path.endsWith(.jar)) {
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ant ValidatorTask.java

2003-08-26 Thread remm
remm2003/08/26 01:31:00

  Modified:catalina/src/share/org/apache/catalina/ant
ValidatorTask.java
  Log:
  - I was suddenly getting some java.lang.ExceptionInInitializerError when running
   the task after JSPC (running it without JSPC worked ok), related with 
commons-logging
   (as usual). I'm not sure how real this bug is (diffing revealed the code didn't 
change at
   al), but setting the context classloader makes c-l happy.
  
  Revision  ChangesPath
  1.2   +11 -4 
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ant/ValidatorTask.java
  
  Index: ValidatorTask.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ant/ValidatorTask.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- ValidatorTask.java14 May 2003 17:45:36 -  1.1
  +++ ValidatorTask.java26 Aug 2003 08:31:00 -  1.2
  @@ -132,6 +132,11 @@
   throw new BuildException(Cannot find web.xml);
   }
   
  +// Commons-logging likes having the context classloader set
  +ClassLoader oldCL = Thread.currentThread().getContextClassLoader();
  +Thread.currentThread().setContextClassLoader
  +(ValidatorTask.class.getClassLoader());
  +
   Digester digester = ContextConfig.createWebXmlDigester(true, true);
   try {
   file = file.getCanonicalFile();
  @@ -142,6 +147,8 @@
   digester.parse(is);
   } catch (Throwable t) {
   throw new BuildException(Validation failure, t);
  +} finally {
  +Thread.currentThread().setContextClassLoader(oldCL);
   }
   
   }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup ContextConfig.java TldConfig.java

2003-08-26 Thread remm
remm2003/08/26 01:39:59

  Modified:catalina/src/share/org/apache/catalina/startup
ContextConfig.java TldConfig.java
  Log:
  - Reenable validation (there are still problems validating TLDs, even with
Xerces 2.1).
  
  Revision  ChangesPath
  1.31  +2 -3  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/ContextConfig.java
  
  Index: ContextConfig.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/ContextConfig.java,v
  retrieving revision 1.30
  retrieving revision 1.31
  diff -u -r1.30 -r1.31
  --- ContextConfig.java20 Aug 2003 08:35:43 -  1.30
  +++ ContextConfig.java26 Aug 2003 08:39:59 -  1.31
  @@ -493,8 +493,7 @@
   SchemaResolver webEntityResolver = new SchemaResolver(url.toString(),
 webDigester);
   
  -// FIXME: if (validation) {
  -if (false) {
  +if (validation) {
   webDigester.setSchema(url.toString());
   }
   
  
  
  
  1.19  +1 -2  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/TldConfig.java
  
  Index: TldConfig.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/TldConfig.java,v
  retrieving revision 1.18
  retrieving revision 1.19
  diff -u -r1.18 -r1.19
  --- TldConfig.java26 Aug 2003 07:17:43 -  1.18
  +++ TldConfig.java26 Aug 2003 08:39:59 -  1.19
  @@ -388,8 +388,7 @@
   SchemaResolver tldEntityResolver = new SchemaResolver(url.toString(), 
 tldDigester);
   
  -// FIXME: if (xmlValidation) {
  -if (false) {
  +if (xmlValidation) {
   tldDigester.setSchema(url.toString());
   }
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-5/resources/deployer build.xml

2003-08-26 Thread remm
remm2003/08/26 01:40:35

  Modified:resources/deployer build.xml
  Log:
  - Validate before running JAVAC.
  
  Revision  ChangesPath
  1.3   +2 -2  jakarta-tomcat-5/resources/deployer/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-5/resources/deployer/build.xml,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- build.xml 17 Aug 2003 08:31:08 -  1.2
  +++ build.xml 26 Aug 2003 08:40:35 -  1.3
  @@ -72,6 +72,8 @@
addWebXmlMappings=true
outputDir=${webapp.path}/WEB-INF/classes / 
   
  +validator path=${webapp.path} /
  +
   mkdir dir=${webapp.path}/WEB-INF/classes/
   mkdir dir=${webapp.path}/WEB-INF/lib/
   
  @@ -91,8 +93,6 @@
 include name=** /
 exclude name=tags/** /
   /javac
  -
  -validator path=${webapp.path} /
   
   jar destfile=${webapp.path}.war
basedir=${webapp.path} /
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-5 build.properties.default build.xml

2003-08-26 Thread remm
remm2003/08/26 01:42:39

  Modified:.build.properties.default build.xml
  Log:
  - Use Xerces 2.1, which has less issues with schema validation.
  - The deployer doesn't need the Ant binary (as Ant is required to run the
build.xml anyway). This will make the binary much smaller.
  
  Revision  ChangesPath
  1.103 +4 -3  jakarta-tomcat-5/build.properties.default
  
  Index: build.properties.default
  ===
  RCS file: /home/cvs/jakarta-tomcat-5/build.properties.default,v
  retrieving revision 1.102
  retrieving revision 1.103
  diff -u -r1.102 -r1.103
  --- build.properties.default  19 Aug 2003 16:22:22 -  1.102
  +++ build.properties.default  26 Aug 2003 08:42:38 -  1.103
  @@ -126,11 +126,12 @@
   
   
   # - Xerces XML Parser, version 2.5.0 -
  -xerces.home=${base.path}/xerces-2_5_0
  +xerces.home=${base.path}/xerces-2_1_0
   xerces.lib=${xerces.home}
   xercesImpl.jar=${xerces.lib}/xercesImpl.jar
   xmlParserAPIs.jar=${xerces.lib}/xmlParserAPIs.jar
  -xerces.loc=http://xml.apache.org/dist/xerces-j/Xerces-J-bin.2.5.0.tar.gz
  +xerces.loc=http://xml.apache.org/dist/xerces-j/old_xerces2/Xerces-J-bin.2.1.0.tar.gz
  +
   
   # --
   #  CORE OPTIONAL LIBRARIES
  
  
  
  1.152 +0 -2  jakarta-tomcat-5/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-5/build.xml,v
  retrieving revision 1.151
  retrieving revision 1.152
  diff -u -r1.151 -r1.152
  --- build.xml 25 Aug 2003 18:43:04 -  1.151
  +++ build.xml 26 Aug 2003 08:42:38 -  1.152
  @@ -705,8 +705,6 @@
   
 target name=deployer description=Create the Tomcat deployer binary  
   
  -copy todir=${tomcat.deployer}/lib file=${tomcat.build}/common/lib/ant.jar/
  -
   !-- JSP and Servlet runtime --
   copy todir=${tomcat.deployer}/lib
 fileset dir=${tomcat.build}/common/lib
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm RealmBase.java

2003-08-26 Thread remm
remm2003/08/26 01:46:48

  Modified:catalina/src/share/org/apache/catalina/realm RealmBase.java
  Log:
  - Bug 22698: Restore RealmBase.main(). There doesn't seem to be any side
effect, so there's no reason to remove it at this time.
  
  Revision  ChangesPath
  1.16  +23 -22
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/RealmBase.java
  
  Index: RealmBase.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/RealmBase.java,v
  retrieving revision 1.15
  retrieving revision 1.16
  diff -u -r1.15 -r1.16
  --- RealmBase.java26 Aug 2003 04:04:56 -  1.15
  +++ RealmBase.java26 Aug 2003 08:46:48 -  1.16
  @@ -987,24 +987,25 @@
   }
   
   
  -///**
  -// * Digest password using the algorithm especificied and
  -// * convert the result to a corresponding hex string.
  -// * If exception, the plain credentials string is returned
  -// */
  -//public static void main(String args[]) {
  -//
  -//if(args.length  2  args[0].equalsIgnoreCase(-a)) {
  -//for(int i=2; i  args.length ; i++){
  -//System.out.print(args[i]+:);
  -//System.out.println(Digest(args[i], args[1]));
  -//}
  -//} else {
  -//System.out.println
  -//(Usage: RealmBase -a algorithm credentials);
  -//}
  -//
  -//}
  +/**
  + * Digest password using the algorithm especificied and
  + * convert the result to a corresponding hex string.
  + * If exception, the plain credentials string is returned
  + */
  +public static void main(String args[]) {
  +
  +if(args.length  2  args[0].equalsIgnoreCase(-a)) {
  +for(int i=2; i  args.length ; i++){
  +System.out.print(args[i]+:);
  +System.out.println(Digest(args[i], args[1]));
  +}
  +} else {
  +System.out.println
  +(Usage: RealmBase -a algorithm credentials);
  +}
  +
  +}
  +
   
   //  JMX and Registration  
   protected String type;
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22588] - large file uploads fail with server not found error

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22588.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22588

large file uploads fail with server not found error

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|DUPLICATE   |



--- Additional Comments From [EMAIL PROTECTED]  2003-08-26 08:37 ---
Sorry, no dice. I tried the 04-aug nightly build (3.3.2-dev) with no joy.

Without the following code, IE6 says page not found.

final ServletInputStream servIn = request.getInputStream();
final byte [] temp = new byte[4*1024];
while (true) {
final int size = servIn.read(temp);
if (size=0) break;
}

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-site/xdocs index.xml

2003-08-26 Thread remm
remm2003/08/26 02:08:17

  Modified:docs index.html
   docs/faq bugs.html classnotfound.html memory.html misc.html
performance.html security.html version.html
   docs/faq/printer bugs.html classnotfound.html
   xdocsindex.xml
  Log:
  - TC site update.
  
  Revision  ChangesPath
  1.47  +1 -1  jakarta-tomcat-site/docs/index.html
  
  
http://cvs.apache.org/viewcvs/jakarta-tomcat-site/docs/index.html.diff?r1=1.46r2=1.47
  
  
  1.6   +86 -86jakarta-tomcat-site/docs/faq/bugs.html
  
  
http://cvs.apache.org/viewcvs/jakarta-tomcat-site/docs/faq/bugs.html.diff?r1=1.5r2=1.6
  
  
  1.6   +127 -127  jakarta-tomcat-site/docs/faq/classnotfound.html
  
  
http://cvs.apache.org/viewcvs/jakarta-tomcat-site/docs/faq/classnotfound.html.diff?r1=1.5r2=1.6
  
  
  1.6   +144 -144  jakarta-tomcat-site/docs/faq/memory.html
  
  
http://cvs.apache.org/viewcvs/jakarta-tomcat-site/docs/faq/memory.html.diff?r1=1.5r2=1.6
  
  
  1.7   +542 -542  jakarta-tomcat-site/docs/faq/misc.html
  
  
http://cvs.apache.org/viewcvs/jakarta-tomcat-site/docs/faq/misc.html.diff?r1=1.6r2=1.7
  
  
  1.6   +50 -50jakarta-tomcat-site/docs/faq/performance.html
  
  
http://cvs.apache.org/viewcvs/jakarta-tomcat-site/docs/faq/performance.html.diff?r1=1.5r2=1.6
  
  
  1.6   +90 -90jakarta-tomcat-site/docs/faq/security.html
  
  
http://cvs.apache.org/viewcvs/jakarta-tomcat-site/docs/faq/security.html.diff?r1=1.5r2=1.6
  
  
  1.7   +76 -76jakarta-tomcat-site/docs/faq/version.html
  
  
http://cvs.apache.org/viewcvs/jakarta-tomcat-site/docs/faq/version.html.diff?r1=1.6r2=1.7
  
  
  1.4   +85 -85jakarta-tomcat-site/docs/faq/printer/bugs.html
  
  
http://cvs.apache.org/viewcvs/jakarta-tomcat-site/docs/faq/printer/bugs.html.diff?r1=1.3r2=1.4
  
  
  1.4   +126 -126  jakarta-tomcat-site/docs/faq/printer/classnotfound.html
  
  
http://cvs.apache.org/viewcvs/jakarta-tomcat-site/docs/faq/printer/classnotfound.html.diff?r1=1.3r2=1.4
  
  
  1.39  +1 -1  jakarta-tomcat-site/xdocs/index.xml
  
  
http://cvs.apache.org/viewcvs/jakarta-tomcat-site/xdocs/index.xml.diff?r1=1.38r2=1.39
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22698] - org.apache.catalina.realm.RealmBase missing main()

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22698.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22698

org.apache.catalina.realm.RealmBase missing main()

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-08-26 08:49 ---
The fix will be in 5.0.10.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



FTP

2003-08-26 Thread Carl Boshoff
Hey guys!
 
Can I set up tomcat to be an ftp server?


cvs commit: jakarta-tomcat-connectors/jk/native/common jk_connect.c

2003-08-26 Thread hgomez
hgomez  2003/08/26 03:07:37

  Modified:jk/native2/common jk_channel_socket.c
   jk/native/common jk_connect.c
  Log:
  Make use of in_addr_t instead of u_long for all platforms but OS400.
  Should make jk build on OpenBSD/64
  
  Revision  ChangesPath
  1.55  +6 -1  jakarta-tomcat-connectors/jk/native2/common/jk_channel_socket.c
  
  Index: jk_channel_socket.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_channel_socket.c,v
  retrieving revision 1.54
  retrieving revision 1.55
  diff -u -r1.54 -r1.55
  --- jk_channel_socket.c   31 Jul 2003 14:49:32 -  1.54
  +++ jk_channel_socket.c   26 Aug 2003 10:07:36 -  1.55
  @@ -246,8 +246,13 @@
   int x;
   
   /* TODO: Should be updated for IPV6 support. */
  -/* for now use the correct type, in_addr_t */
  +/* for now use the correct type, in_addr_t (or u_long for OS400) */
  +
  +#ifdef AS400
  +u_long laddr;
  +#else
   in_addr_t laddr;
  +#endif
   
   rc-sin_port   = htons((short)port);
   rc-sin_family = AF_INET;
  
  
  
  1.11  +7 -1  jakarta-tomcat-connectors/jk/native/common/jk_connect.c
  
  Index: jk_connect.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_connect.c,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- jk_connect.c  25 Jul 2003 14:58:22 -  1.10
  +++ jk_connect.c  26 Aug 2003 10:07:37 -  1.11
  @@ -110,7 +110,13 @@
   int x;
   
   /* TODO: Should be updated for IPV6 support. */
  +/* for now use the correct type, in_addr_t (or u_long for OS400) */
  +
  +#ifdef AS400
   u_long laddr;
  +#else
  + in_addr_t laddr;
  +#endif
   
   rc-sin_port   = htons((short)port);
   rc-sin_family = AF_INET;
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Release mod_jk 1.2.5

2003-08-26 Thread Henri Gomez
Kurt Miller a écrit :
From: Henri Gomez [EMAIL PROTECTED]

The future will be mod_jk2, and I think we should focus on it after the
1.2.5 release.


Ok. I jumped in on this thread because I thought that a new problem was
introduced, but that is how it was in prior releases. I can report 1.2.5
works fine on OpenBSD-current/i386. I will keep working on
OpenBSD/sparc64

and post patches here when it is working. If there's a 1.2.6 release
maybe

they can be incorporated then.
Surely, jk 1.2.6 could be the release with OpenBSD/sparc64 support, we
should fix this hack around the in_addr_t and of course add the Ipv6
support since an IP adress won't fix into a 32 bits integer for too long.
Work on patch and we'll see how to make them useable for other OS,
I think the rigth way is via in_addr_t


I done more testing this morning and have determined that the u_long is the
only bug preventing mod_jk from working on OpenBSD/sparc64. The other issues
on OpenBSD/sparc64 that I was referring to seem to be related to my install
of tomcat 4.0.6. I setup a new tomcat 4.1.27 install on a different box and
mod_jk on OpenBSD/sparc64 works fine with it (with the datatype change).
Is it too late to incorporate a change for the 1.2.5 release? You and David
Rees have pointed out the in_addr_t is the correct type to use for
inet_addr. Would it not make sense to change it to that and have a define
for the iSeries? I would supply a patch, but I don't have an iSeries
available.
If it works on all platform (except iSeries), it should be changed to
in_addr_t. I'll take a look to see where the type is defined to add the
missing include. Stay tuned


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


FTP

2003-08-26 Thread Richard Backhouse

Return Receipt
   
Your  FTP  
document   
:  
   
was   Richard Backhouse/Durham/IBM 
received   
by:
   
at:   08/26/2003 05:50:34 EDT  
   





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationFilterFactory.java

2003-08-26 Thread remm
remm2003/08/26 07:07:13

  Modified:catalina/src/share/org/apache/catalina/core
ApplicationFilterFactory.java
  Log:
  - Fix small filter extension mapping bug: if the extension of the request starts
with the tested path, it would have been matched (bug 22546).
  
  Revision  ChangesPath
  1.10  +6 -4  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationFilterFactory.java
  
  Index: ApplicationFilterFactory.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationFilterFactory.java,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- ApplicationFilterFactory.java 25 May 2003 14:27:01 -  1.9
  +++ ApplicationFilterFactory.java 26 Aug 2003 14:07:13 -  1.10
  @@ -289,7 +289,9 @@
   int slash = requestPath.lastIndexOf('/');
   int period = requestPath.lastIndexOf('.');
   if ((slash = 0)  (period  slash) 
  - (period != requestPath.length() - 1)) {
  + (period != requestPath.length() - 1)
  + ((requestPath.length() - period) 
  +== (testPath.length() - 1))) {
   return (testPath.regionMatches(2, requestPath, period + 1,
  testPath.length() - 2));
   }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java

2003-08-26 Thread remm
remm2003/08/26 07:11:04

  Modified:catalina/src/share/org/apache/catalina/session
StandardManager.java
  Log:
  - Don't restore invalid sessions. There's no apparent side effect to that. This
fixes bug 22695 (the sessions were really invalid after all if the exception
occurred).
  
  Revision  ChangesPath
  1.12  +8 -6  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/StandardManager.java
  
  Index: StandardManager.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/StandardManager.java,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -r1.11 -r1.12
  --- StandardManager.java  19 Aug 2003 00:49:58 -  1.11
  +++ StandardManager.java  26 Aug 2003 14:11:04 -  1.12
  @@ -449,8 +449,10 @@
   StandardSession session = getNewSession();
   session.readObjectData(ois);
   session.setManager(this);
  -sessions.put(session.getId(), session);
  -session.activate();
  +if (session.isValid()) {
  +sessions.put(session.getId(), session);
  +session.activate();
  +}
   }
   } catch (ClassNotFoundException e) {
 log.error(sm.getString(standardManager.loading.cnfe, e), e);
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java StandardSession.java

2003-08-26 Thread remm
remm2003/08/26 07:18:54

  Modified:catalina/src/share/org/apache/catalina/session
StandardManager.java StandardSession.java
  Log:
  - Revert my previous fix. I think it could cause sessions to not be invalidated
properly.
  - Instead, don't check for validity when activating and passivating.
  
  Revision  ChangesPath
  1.13  +6 -8  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/StandardManager.java
  
  Index: StandardManager.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/StandardManager.java,v
  retrieving revision 1.12
  retrieving revision 1.13
  diff -u -r1.12 -r1.13
  --- StandardManager.java  26 Aug 2003 14:11:04 -  1.12
  +++ StandardManager.java  26 Aug 2003 14:18:54 -  1.13
  @@ -449,10 +449,8 @@
   StandardSession session = getNewSession();
   session.readObjectData(ois);
   session.setManager(this);
  -if (session.isValid()) {
  -sessions.put(session.getId(), session);
  -session.activate();
  -}
  +sessions.put(session.getId(), session);
  +session.activate();
   }
   } catch (ClassNotFoundException e) {
 log.error(sm.getString(standardManager.loading.cnfe, e), e);
  
  
  
  1.21  +18 -6 
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/StandardSession.java
  
  Index: StandardSession.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/StandardSession.java,v
  retrieving revision 1.20
  retrieving revision 1.21
  diff -u -r1.20 -r1.21
  --- StandardSession.java  19 Aug 2003 00:49:58 -  1.20
  +++ StandardSession.java  26 Aug 2003 14:18:54 -  1.21
  @@ -731,7 +731,7 @@
   HttpSessionEvent event = null;
   String keys[] = keys();
   for (int i = 0; i  keys.length; i++) {
  -Object attribute = getAttribute(keys[i]);
  +Object attribute = getAttributeInternal(keys[i]);
   if (attribute instanceof HttpSessionActivationListener) {
   if (event == null)
   event = new HttpSessionEvent(this);
  @@ -753,7 +753,7 @@
   HttpSessionEvent event = null;
   String keys[] = keys();
   for (int i = 0; i  keys.length; i++) {
  -Object attribute = getAttribute(keys[i]);
  +Object attribute = getAttributeInternal(keys[i]);
   if (attribute instanceof HttpSessionActivationListener) {
   if (event == null)
   event = new HttpSessionEvent(this);
  @@ -1571,6 +1571,18 @@
   String results[] = new String[0];
   synchronized (attributes) {
   return ((String[]) attributes.keySet().toArray(results));
  +}
  +
  +}
  +
  +
  +/**
  + * Return the value of an attribute without a check for validity.
  + */
  +private Object getAttributeInternal(String name) {
  +
  +synchronized (attributes) {
  +return (attributes.get(name));
   }
   
   }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22695] - TC 5.0.9 Exception During Startup

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22695.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22695

TC 5.0.9 Exception During Startup





--- Additional Comments From [EMAIL PROTECTED]  2003-08-26 14:29 ---
Thanks!

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



FTP

2003-08-26 Thread Kirk Mitchener

Return Receipt
   
Your  FTP  
document   
:  
   
was   Kirk Mitchener/NA/IDC
received   
by:
   
at:   08/26/2003 09:00:03 AM   
   





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Release mod_jk 1.2.5

2003-08-26 Thread Henri Gomez
Joseph Shraibman a écrit :
Glenn Nielsen wrote:

No problems have been reported since the last test source distribution
of mod_jk 1.2.5 was made available for testing July 26.
ballot
Please vote on a release of mod_jk 1.2.5:
[ ] +1 release, and I will help build binaries for _ os/web 
server
[ ] +0 ok to release
[ ] -0 release, but I still have a problem with _
[ ] -1 don't release, there is a problem with _
/ballot

The votes will be counted Monday August 4 and the source dist
release made if the vote passes.


So whatever happened?  Why wasn't 1.2.5 released?
Glenn could you tag jk (with my latest jk_connect.c patch) for jk 1.2.5
and make the release ?
It will make jk compatible with OpenBSD/64

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: [VOTE] Release mod_jk 1.2.5

2003-08-26 Thread Glenn Nielsen
Henri Gomez wrote:
Joseph Shraibman a écrit :

Glenn Nielsen wrote:

No problems have been reported since the last test source distribution
of mod_jk 1.2.5 was made available for testing July 26.
ballot
Please vote on a release of mod_jk 1.2.5:
[ ] +1 release, and I will help build binaries for _ os/web 
server
[ ] +0 ok to release
[ ] -0 release, but I still have a problem with _
[ ] -1 don't release, there is a problem with _
/ballot

The votes will be counted Monday August 4 and the source dist
release made if the vote passes.


So whatever happened?  Why wasn't 1.2.5 released?


Glenn could you tag jk (with my latest jk_connect.c patch) for jk 1.2.5
and make the release ?
It will make jk compatible with OpenBSD/64

Yeah, I was waiting on that.  Plus there is that recent thread safe
issue which was raised with the uri mapping.
Glenn

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: [VOTE] 5.0.9 stability rating

2003-08-26 Thread Remy Maucherat
Amy Roh wrote:

Remy Maucherat wrote:

Amy Roh wrote:

I'll update the mbean-descriptor.xml and admin page for Connector soon.


Thanks. Sorry for the trouble.


No Problem.  I just committed the updates.  Let me know if there is 
additional updates or if I missed/overlooked anything.
The changes are a bit more complex than what you did. The new syntax is:

HTTP/1.1:

Connector port=8080
   maxThreads=150 minSpareThreads=25 maxSpareThreads=75
   enableLookups=false redirectPort=8443 acceptCount=100
   debug=0 connectionTimeout=2
   disableUploadTimeout=true /
(the thread pool configuration changed, basically)
AJP/1.3:

Connector port=8009
   enableLookups=false redirectPort=8443 debug=0
   protocol=AJP/1.3 /
(ie, no thread pool configuration here)
Please don't add get/set on the CoyoteConnector class itself (we're 
trying to avoid that, as it's protocol dependent; you can look at Bill's 
patch - which I reverted for performance reasons, but which did the 
right thing on principle). IMO, you should add those to the 
ConnectorMBean, and use get/setProperty. What do you think ?

Remy



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


DO NOT REPLY [Bug 12215] - Correction for List$jsp.java causes Nasty Jasper error

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12215.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12215

Correction for List$jsp.java causes Nasty Jasper error

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WORKSFORME



--- Additional Comments From [EMAIL PROTECTED]  2003-08-26 17:55 ---
I have checked this with the HEAD of tomcat 4.1 and the HEAD of tomcat 5. The 
admin application compiles successfully in both cases without the proposed 
patch.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Release mod_jk 1.2.5

2003-08-26 Thread Kurt Miller
From: Glenn Nielsen [EMAIL PROTECTED]
 Henri Gomez wrote:
  Joseph Shraibman a écrit :
 
  Glenn Nielsen wrote:
 
  No problems have been reported since the last test source distribution
  of mod_jk 1.2.5 was made available for testing July 26.
 
  ballot
  Please vote on a release of mod_jk 1.2.5:
 
  [ ] +1 release, and I will help build binaries for _ os/web
  server
  [ ] +0 ok to release
  [ ] -0 release, but I still have a problem with _
  [ ] -1 don't release, there is a problem with _
  /ballot
 
  The votes will be counted Monday August 4 and the source dist
  release made if the vote passes.
 
 
 
  So whatever happened?  Why wasn't 1.2.5 released?
 
 
  Glenn could you tag jk (with my latest jk_connect.c patch) for jk 1.2.5
  and make the release ?
 
  It will make jk compatible with OpenBSD/64
 

 Yeah, I was waiting on that.  Plus there is that recent thread safe
 issue which was raised with the uri mapping.


Thank you Glenn and Henri.

-Kurt


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22695] - TC 5.0.9 Exception During Startup

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22695.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22695

TC 5.0.9 Exception During Startup

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Normal  |Minor
 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-08-26 14:20 ---
The fix will be in 5.0.10. The error is completely harmless.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session ReplicatedSession.java

2003-08-26 Thread fhanik
fhanik  2003/08/26 13:45:04

  Modified:modules/cluster/src/share/org/apache/catalina/cluster/session
ReplicatedSession.java
  Log:
  set dirty flag gets set on setMaxInactiveInterval
  
  Revision  ChangesPath
  1.6   +8 -3  
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/ReplicatedSession.java
  
  Index: ReplicatedSession.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/ReplicatedSession.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- ReplicatedSession.java16 Apr 2003 18:49:22 -  1.5
  +++ ReplicatedSession.java26 Aug 2003 20:45:04 -  1.6
  @@ -147,6 +147,11 @@
   super.setAttribute(name,value);
   }
   
  +public void setMaxInactiveInterval(int interval) {
  +setIsDirty(true);
  +super.setMaxInactiveInterval(interval);
  +}
  +
   
   /**
* Sets the manager for this session
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22388] - TC 5.0.7 Startup Exception

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22388.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22388

TC 5.0.7 Startup Exception

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |



--- Additional Comments From [EMAIL PROTECTED]  2003-08-26 22:01 ---
This is still present in 5.0.9. I realize that you say it will be fixed in the 
final .. but will the fix be in a release before TC5 ships so we can verify 
that the issue has gone away?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-servletapi-5/jsr154/src/share/dtd web-app_2_4.xsd

2003-08-26 Thread jfarcand
jfarcand2003/08/26 14:38:09

  Modified:jsr154/src/share/dtd web-app_2_4.xsd
  Log:
  Apply patch submitted by Yutaka Yoshida.
  
  Revision  ChangesPath
  1.12  +11 -11jakarta-servletapi-5/jsr154/src/share/dtd/web-app_2_4.xsd
  
  Index: web-app_2_4.xsd
  ===
  RCS file: /home/cvs/jakarta-servletapi-5/jsr154/src/share/dtd/web-app_2_4.xsd,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -r1.11 -r1.12
  --- web-app_2_4.xsd   16 May 2003 23:20:18 -  1.11
  +++ web-app_2_4.xsd   26 Aug 2003 21:38:09 -  1.12
  @@ -126,7 +126,7 @@
 /xsd:documentation
   /xsd:annotation
   
  -xsd:unique name=servlet-name-uniqueness
  +xsd:unique name=web-app-servlet-name-uniqueness
 xsd:annotation
xsd:documentation
   
  @@ -139,7 +139,7 @@
 xsd:fieldxpath=j2ee:servlet-name/
   /xsd:unique
   
  -xsd:unique name=filter-name-uniqueness
  +xsd:unique name=web-app-filter-name-uniqueness
 xsd:annotation
xsd:documentation
   
  @@ -152,7 +152,7 @@
 xsd:fieldxpath=j2ee:filter-name/
   /xsd:unique
   
  -xsd:unique name=ejb-local-ref-name-uniqueness
  +xsd:unique name=web-app-ejb-local-ref-name-uniqueness
 xsd:annotation
xsd:documentation
   
  @@ -170,7 +170,7 @@
 xsd:fieldxpath=j2ee:ejb-ref-name/
   /xsd:unique
   
  -xsd:unique name=ejb-ref-name-uniqueness
  +xsd:unique name=web-app-ejb-ref-name-uniqueness
 xsd:annotation
xsd:documentation
   
  @@ -188,7 +188,7 @@
 xsd:fieldxpath=j2ee:ejb-ref-name/
   /xsd:unique
   
  -xsd:unique name=resource-env-ref-uniqueness
  +xsd:unique name=web-app-resource-env-ref-uniqueness
 xsd:annotation
xsd:documentation
   
  @@ -204,7 +204,7 @@
 xsd:fieldxpath=j2ee:resource-env-ref-name/
   /xsd:unique
   
  -xsd:unique name=message-destination-ref-uniqueness
  +xsd:unique name=web-app-message-destination-ref-uniqueness
 xsd:annotation
xsd:documentation
   
  @@ -220,7 +220,7 @@
 xsd:fieldxpath=j2ee:message-destination-ref-name/
   /xsd:unique
   
  -xsd:unique name=res-ref-name-uniqueness
  +xsd:unique name=web-app-res-ref-name-uniqueness
 xsd:annotation
xsd:documentation
   
  @@ -235,7 +235,7 @@
 xsd:fieldxpath=j2ee:res-ref-name/
   /xsd:unique
   
  -xsd:unique name=env-entry-name-uniqueness
  +xsd:unique name=web-app-env-entry-name-uniqueness
 xsd:annotation
xsd:documentation
   
  @@ -251,7 +251,7 @@
 xsd:fieldxpath=j2ee:env-entry-name/
   /xsd:unique
   
  -xsd:key name=role-name-key
  +xsd:key name=web-app-role-name-key
 xsd:annotation
xsd:documentation
   
  @@ -264,8 +264,8 @@
 xsd:fieldxpath=j2ee:role-name/
   /xsd:key
   
  -xsd:keyref name=role-name-references
  - refer=j2ee:role-name-key
  +xsd:keyref name=web-app-role-name-references
  + refer=j2ee:web-app-role-name-key
 xsd:annotation
xsd:documentation
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22388] - TC 5.0.7 Startup Exception

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22388.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22388

TC 5.0.7 Startup Exception

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2003-08-26 22:16 ---
Please do not reopen the report. This is not a Tomcat issue anyway.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22701] - commons-logging and SSL in tomcat with struts

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22701.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22701

commons-logging and SSL in tomcat with struts

[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|struts- |tomcat-
   |[EMAIL PROTECTED]  |[EMAIL PROTECTED]
 Status|REOPENED|NEW



--- Additional Comments From [EMAIL PROTECTED]  2003-08-26 18:19 ---
Reassigned to [EMAIL PROTECTED]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 14019] - Problem with endorsed in Catalina.bat

2003-08-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14019.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14019

Problem with endorsed in Catalina.bat

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2003-08-26 21:59 ---
This works for me. If you are still having difficulties, may I suggest the 
following:
1. Use the file as is. It is written so you can install Tomcat pretty much 
where you like and it will still work.
2. If you do need to explicitly set paths, use the environment variables. They 
are there so you do not have to edit the batch file.
3. Post any follow up questions to the user list. Bugzilla should only be used 
to track bugs. I refer you to http://jakarta.apache.org/tomcat/bugreport.html 
for further guidance.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[ANN] Apache Tomcat 5.0.9 Beta released

2003-08-26 Thread Remy Maucherat
The Tomcat Team announces the immediate availability of the first Apache 
Tomcat 5.0 Beta release: Apache Tomcat 5.0.9.

Tomcat 5.0 contains many enhancements over Tomcat 4.1, including:
* Support for the Servlet 2.4 and JSP 2.0 PFD 3 specifications
* Performance optimizations and reduced garbage collection
* Refactored application deployer, with an optional standalone deployer 
allowing validation and compilation of a web application before putting 
it in production
* Complete server monitoring using JMX and the manager web application
* Scalability and reliability enhancements
* Improved Taglibs handling, including advanced pooling and tag plugins
* Improved platform integration, with native Windows and Unix wrappers
* Embedding of Tomcat using JMX
* Expanded documentation

Apache Tomcat 5.0.9 is a beta release, and contains the following known 
issues:
* The security contraint matching implementation may not be compliant 
with the Servlet 2.4 PFD 3 specification, due to confusion over the 
specification meaning.
* The administration web application cannot currently be used to view or 
edit hosts and connectors.
* Deployment descriptors using schemas (based on the new specifications) 
cannot currently be validated.
* An exception can occur on Tomcat startup when attempting to load 
serialized sessions. This exception should be ignored.

Downloads:
Binaries: http://jakarta.apache.org/site/binindex.cgi
Sources: http://jakarta.apache.org/site/sourceindex.cgi
Remy



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]