DO NOT REPLY [Bug 21390] - Incorrect code generated by the jsp compiler

2003-08-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21390.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21390

Incorrect code generated by the jsp compiler





--- Additional Comments From [EMAIL PROTECTED]  2003-08-28 23:14 ---
Both JSP 1.2 and JSP 2.0 do not address this issue adequately.  I have talked
with JSP 2.0 spec lead, and we are also leaning towards declaring all scripting
variables.  Any attempt to fix multiple definition errors (like what Japser is
doing now) will fail, in cases such as this.  So I am in favor of removing this
functionality from Japser.  This amounts to removing ScriptingVariabler.java and
some codes from Generator.java.  I also like the fact that Jasper also will be
simpler as a result.  :-)

The only problem is we may break applications that depend on it.  The workaround
for simple case like

test:test1/
test:test1/

is to include a %= { % and %= } % around the tag invokation.  But
there is no wrokaround for nested tags

test:test1
test:test1/
/test:test1

because Java language does not allow the a variable be declared in a block when
a variable of the same name has already been declared in an outer block.  Is it
OK for us to say tough, the tag handlers cannot be nested when there are
scripting variables?  I don't know.

Maybe the only solution is for the taglib designer to include an attribute for
specifying the name of the scripting variable.  So in the the nested case, one
can say

test:test1 var=var1
test:test1 var=var2/
/test:test1

to manually avoid Javac errors.

JSP 2.0 is discouraging the use of scripting variable and is encouraginging the
use of EL, partly because of issues like this.

BTW, when you write

% /* % test:test/ % */ %

you are assuming that a comment is not generated for test:test/.  This may not
be true in general.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 21390] - Incorrect code generated by the jsp compiler

2003-08-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21390.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21390

Incorrect code generated by the jsp compiler





--- Additional Comments From [EMAIL PROTECTED]  2003-08-29 01:58 ---
Hi,

I tried it by putting %= { % and %= } % around the tag invocations but 
that didn't work either with tomcat 4.1 and above.
It works fine on tomcat 4.0.6 if you enclose it within the parantheses.

I am not concerned about nesting since these tags are not meant to be nested 
inside another instance of the same tag.


Thanks,


Roshan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 21390] - Incorrect code generated by the jsp compiler

2003-08-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21390.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21390

Incorrect code generated by the jsp compiler





--- Additional Comments From [EMAIL PROTECTED]  2003-08-29 02:20 ---
Maybe I didn't express clearly.  I was saying that if we fix Jasper so that your
page would work, then consecutive tags or nested tags would generate javac
errors (currently they don't).  The first case can use %= { % and % } % as a
workaround, but the second has no workaround.  Your tags may not be nested, but
there are others that can.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Protocol.java LocalStrings.properties

2003-08-29 Thread amyroh
amyroh  2003/08/28 19:34:47

  Modified:http11/src/java/org/apache/coyote/http11 Http11Protocol.java
LocalStrings.properties
  Log:
  Implement getAttribute(key).
  
  Revision  ChangesPath
  1.34  +3 -1  
jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Protocol.java
  
  Index: Http11Protocol.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Protocol.java,v
  retrieving revision 1.33
  retrieving revision 1.34
  diff -u -r1.33 -r1.34
  --- Http11Protocol.java   11 Aug 2003 21:44:49 -  1.33
  +++ Http11Protocol.java   29 Aug 2003 02:34:47 -  1.34
  @@ -115,7 +115,9 @@
   }
   
   public Object getAttribute( String key ) {
  -return null;
  +if( log.isTraceEnabled())
  +log.trace(sm.getString(http11protocol.getattribute, key));
  +return attributes.get(key);
   }
   
   /**
  
  
  
  1.6   +2 -1  
jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/LocalStrings.properties
  
  Index: LocalStrings.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/LocalStrings.properties,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- LocalStrings.properties   5 Nov 2002 09:37:34 -   1.5
  +++ LocalStrings.properties   29 Aug 2003 02:34:47 -  1.6
  @@ -16,6 +16,7 @@
   http11protocol.proto.ioexception.info=IOException reading request, ignored
   http11protocol.proto.socketexception.debug=SocketException reading request
   http11protocol.proto.socketexception.info=SocketException reading request, ignored
  +http11protocol.getattribute=Attribute {0}
   http11protocol.setattribute=Attribute {0}: {1}
   http11protocol.socketfactory.initerror=Error initializing socket factory
   http11protocol.start=Starting Coyote HTTP/1.1 on port {0}
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 mbeans-descriptors.xml

2003-08-29 Thread amyroh
amyroh  2003/08/28 19:35:57

  Modified:catalina/src/share/org/apache/catalina/mbeans
ConnectorMBean.java
   catalina/src/share/org/apache/coyote/tomcat5
mbeans-descriptors.xml
  Log:
  Add ConnectorMBean implementation and force CoyoteConnector to use the 
ConnectorMBean for its configuration.
  
  Revision  ChangesPath
  1.2   +128 -176  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbeans/ConnectorMBean.java
  
  Index: ConnectorMBean.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbeans/ConnectorMBean.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- ConnectorMBean.java   18 Jul 2002 16:47:58 -  1.1
  +++ ConnectorMBean.java   29 Aug 2003 02:35:57 -  1.2
  @@ -1,4 +1,4 @@
  -/*
  +/*l
* $Header$
* $Revision$
* $Date$
  @@ -64,16 +64,24 @@
   package org.apache.catalina.mbeans;
   
   import java.lang.reflect.Method;
  +import javax.management.Attribute;
  +import javax.management.AttributeNotFoundException;
  +import javax.management.InstanceNotFoundException;
   import javax.management.MBeanException;
  +import javax.management.ReflectionException;
   import javax.management.RuntimeOperationsException;
  +import javax.management.modelmbean.InvalidTargetObjectTypeException;
   import org.apache.catalina.Connector;
   import org.apache.catalina.Service;
   import org.apache.commons.modeler.BaseModelMBean;
  +import org.apache.coyote.ProtocolHandler;
  +import org.apache.coyote.tomcat5.CoyoteConnector;
  +import org.apache.tomcat.util.IntrospectionUtils;
   
   
   /**
* pA strongModelMBean/strong implementation for the
  - * codeorg.apache.coyote.tomcat4.CoyoteConnector/code component./p
  + * codeorg.apache.coyote.tomcat5.CoyoteConnector/code component./p
*
* @author Amy Roh
* @version $Revision$ $Date$
  @@ -105,191 +113,135 @@
   // - Attributes
   
   
  -
  -// - Operations
  -
  -
   /**
  - * Return Client authentication info
  + * Obtain and return the value of a specific attribute of this MBean.
*
  - * @exception Exception if an MBean cannot be created or registered
  - */
  -public boolean getClientAuth()
  -throws Exception {
  -
  -Object clientAuthObj = null;
  -Class coyoteConnectorCls = 
Class.forName(org.apache.coyote.tomcat4.CoyoteConnector);
  -if (coyoteConnectorCls.isInstance(this.resource)) {
  -// get factory
  -Method meth1 = coyoteConnectorCls.getMethod(getFactory, null);
  -Object factory = meth1.invoke(this.resource, null);
  -Class coyoteServerSocketFactoryCls = 
Class.forName(org.apache.coyote.tomcat4.CoyoteServerSocketFactory);
  -if (coyoteServerSocketFactoryCls.isInstance(factory)) {
  -// get clientAuth
  -Method meth2 = 
coyoteServerSocketFactoryCls.getMethod(getClientAuth, null);
  -clientAuthObj = meth2.invoke(factory, null);
  -}
  -   
  -}
  -if (clientAuthObj instanceof Boolean) {
  -return ((Boolean)clientAuthObj).booleanValue();
  -} else return false;
  -
  -}
  -
  -
  -/**
  - * Set Client authentication info
  + * @param name Name of the requested attribute
*
  - * @exception Exception if an MBean cannot be created or registered
  + * @exception AttributeNotFoundException if this attribute is not
  + *  supported by this MBean
  + * @exception MBeanException if the initializer of an object
  + *  throws an exception
  + * @exception ReflectionException if a Java reflection exception
  + *  occurs when invoking the getter
*/
  -public void setClientAuth(boolean clientAuth)
  -throws Exception {
  -
  -Class coyoteConnectorCls = 
Class.forName(org.apache.coyote.tomcat4.CoyoteConnector);
  -if (coyoteConnectorCls.isInstance(this.resource)) {
  -// get factory
  -Method meth1 = coyoteConnectorCls.getMethod(getFactory, null);
  -Object factory = meth1.invoke(this.resource, null);
  -Class coyoteServerSocketFactoryCls = 
Class.forName(org.apache.coyote.tomcat4.CoyoteServerSocketFactory);
  -if (coyoteServerSocketFactoryCls.isInstance(factory)) {
  -// set clientAuth
  -Class partypes2 [] = new Class[1];
  -partypes2[0] = Boolean.TYPE;
  -Method meth2 = 
coyoteServerSocketFactoryCls.getMethod(setClientAuth, partypes2);
  -Object arglist2[] = new 

cvs commit: jakarta-tomcat-catalina/webapps/admin/connector connector.jsp

2003-08-29 Thread amyroh
amyroh  2003/08/28 19:40:52

  Modified:webapps/admin/WEB-INF/classes/org/apache/webapp/admin
ApplicationResources_en.properties
   webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector
AddConnectorAction.java ConnectorForm.java
EditConnectorAction.java SaveConnectorAction.java
   webapps/admin/connector connector.jsp
  Log:
  Update Admin with new connector properties including thread pool configuration.
  
  Revision  ChangesPath
  1.17  +3 -0  
jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationResources_en.properties
  
  Index: ApplicationResources_en.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationResources_en.properties,v
  retrieving revision 1.16
  retrieving revision 1.17
  diff -u -r1.16 -r1.17
  --- ApplicationResources_en.properties25 Aug 2003 22:16:38 -  1.16
  +++ ApplicationResources_en.properties29 Aug 2003 02:40:51 -  1.17
  @@ -127,6 +127,9 @@
   connector.milliseconds=milliseconds
   connector.max=Maximum
   connector.maxkeepalive=Max KeepAlive Requests
  +connector.maxspare=Max Spare Threads
  +connector.maxthreads=Max Threads
  +connector.minspare=Min Spare Threads
   connector.proxy.name=Proxy Name
   connector.proxy.portnumber=Proxy Port Number
   connector.algorithm=Algorithm
  
  
  
  1.5   +7 -4  
jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector/AddConnectorAction.java
  
  Index: AddConnectorAction.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector/AddConnectorAction.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- AddConnectorAction.java   25 Aug 2003 22:16:38 -  1.4
  +++ AddConnectorAction.java   29 Aug 2003 02:40:51 -  1.5
  @@ -158,6 +158,9 @@
   connectorFm.setMinProcessorsText(5);
   connectorFm.setMaxProcessorsText(20);
   connectorFm.setMaxKeepAliveText(100);
  +connectorFm.setMaxSpare(50);
  +connectorFm.setMaxThreads(200);
  +connectorFm.setMinSpare(4);
   connectorFm.setSecure(false);
   connectorFm.setTcpNoDelay(true);
   connectorFm.setXpoweredBy(false);
  
  
  
  1.5   +92 -19
jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector/ConnectorForm.java
  
  Index: ConnectorForm.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector/ConnectorForm.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- ConnectorForm.java25 Aug 2003 22:16:38 -  1.4
  +++ ConnectorForm.java29 Aug 2003 02:40:51 -  1.5
  @@ -188,6 +188,21 @@
   private String maxKeepAliveText = null;
   
   /**
  + * The text for the maxSpare.
  + */
  +private String maxSpare = null;
  +
  +/**
  + * The text for the maxThreads.
  + */
  +private String maxThreads = null;
  +
  +/**
  + * The text for the minSpare.
  + */
  +private String minSpare = null;
  +
  +/**
* The text for the port.
*/
   private String portText = null;
  @@ -824,7 +839,6 @@
   
   }
   
  -
   /**
* Set the maxKeepAliveText.
*/
  @@ -836,6 +850,63 @@
   }
   
   /**
  + * Return the maxSpare.
  + */
  +public String getMaxSpare() {
  +
  +return this.maxSpare;
  +
  +}
  +
  +/**
  + * Set the maxSpare.
  + */
  +
  +public void setMaxSpare(String maxSpare) {
  +
  +this.maxSpare = maxSpare;
  +
  +} 
  +
  +/**
  + * Return the maxThreads.
  + */
  +public String getMaxThreads() {
  +
  +return this.maxThreads;
  +
  +}
  +
  +/**
  + * Set the maxThreads.
  + */
  +
  +public void setMaxThreads(String maxThreads) {
  +
  +this.maxThreads = maxThreads;
  +
  +} 
  +
  +/**
  + * Return the minSpare.
  + */
  +public String getMinSpare() {
  +
  +return this.minSpare;
  +
  +}
  +
  +/**
  + * Set the minSpare.
  + */
  +
  +public void setMinSpare(String minSpare) {
  +
  +this.minSpare = minSpare;
  +
  +}  
  +
  +/**
* Return the port text.
*/
   public String getPortText() {
  @@ -986,6 +1057,9 @@
  

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteConnector.java

2003-08-29 Thread amyroh
amyroh  2003/08/28 19:44:16

  Modified:catalina/src/share/org/apache/coyote/tomcat5
CoyoteConnector.java
  Log:
  Remove get/set I added previously.  JMX management is done in ConnectorMBean now.  I 
think we can remove other get/setters too.
  
  Revision  ChangesPath
  1.26  +1 -47 
jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteConnector.java
  
  Index: CoyoteConnector.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteConnector.java,v
  retrieving revision 1.25
  retrieving revision 1.26
  diff -u -r1.25 -r1.26
  --- CoyoteConnector.java  25 Aug 2003 22:08:24 -  1.25
  +++ CoyoteConnector.java  29 Aug 2003 02:44:16 -  1.26
  @@ -1459,26 +1459,6 @@
   
   //  Management methods 
   
  -
  -public String getAlgorithm() {
  -String ret = (String) getProperty(algorithm);
  -if (ret == null) {
  -ServerSocketFactory factory = this.getFactory();
  -if (factory instanceof CoyoteServerSocketFactory) {
  -ret = ((CoyoteServerSocketFactory)factory).getAlgorithm();
  -}
  -}
  -
  -return ret;
  -}
  -
  -public void setAlgorithm(String algorithm) {
  -setProperty(algorithm, algorithm);
  -ServerSocketFactory factory = this.getFactory();
  -if (factory instanceof CoyoteServerSocketFactory) {
  -((CoyoteServerSocketFactory)factory).setAlgorithm(algorithm);
  -}
  -}
   
   public boolean getClientAuth() {
   boolean ret = false;
  @@ -1548,32 +1528,6 @@
   ServerSocketFactory factory = getFactory();
   if( factory instanceof CoyoteServerSocketFactory ) {
   ((CoyoteServerSocketFactory)factory).setKeystorePass(keystorePass);
  -}
  -}
  -
  -/**
  - * Return keystoreType
  - */
  -public String getKeystoreType() {
  -String ret = (String) getProperty(keytype);
  -if (ret == null) {
  -ServerSocketFactory factory = getFactory();
  -if (factory instanceof CoyoteServerSocketFactory ) {
  -return ((CoyoteServerSocketFactory)factory).getKeystoreType();
  -}
  -}
  -
  -return ret;
  -}
  -
  -/**
  - * Set keystoreType
  - */
  -public void setKeystoreType(String keystoreType) {
  -setProperty(keytype, keystoreType);
  -ServerSocketFactory factory = getFactory();
  -if( factory instanceof CoyoteServerSocketFactory ) {
  -((CoyoteServerSocketFactory)factory).setKeystoreType(keystoreType);
   }
   }
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22802] - mappedfile option not working

2003-08-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22802.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22802

mappedfile option not working





--- Additional Comments From [EMAIL PROTECTED]  2003-08-29 02:56 ---
This is very likely the same issue fixed in Tomcat 5 as Bugzilla Bug 22266.  
I've never looked at the Tomcat 4.1 code, so I don't know how hard it would be 
to port the fix to Tomcat 4.1, but the implementation in Tomcat 5 may be 
changing (to incorporate Kin-Man's suggestion of doing the consolidation in a 
separate pass), so I don't know that it makes a whole lot of sense to port the 
current code.  Of course other committers may see it differently.

On the other hand if you're anxious for a fix to this (I see you marked the 
Severity as Critical), and are able to work on it yourself, you might be 
able to save yourself some time by porting from Tomcat 5 instead of starting 
from scratch.  Look for isTemplateText() in Parser.java.

My only other suggestion would be to upgrade to Tomcat 5, but it's only beta, 
and supports different servlet and JSP specs than Tomcat 4.1, so it may not be 
appropriate for your environment.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: jakarta-tomcat-catalina/webapps/admin/connector connector.jsp

2003-08-29 Thread Bill Barker

- Original Message - 
From: [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Sent: Thursday, August 28, 2003 7:40 PM
Subject: cvs commit: jakarta-tomcat-catalina/webapps/admin/connector
connector.jsp


 amyroh  2003/08/28 19:40:52

   Modified:webapps/admin/WEB-INF/classes/org/apache/webapp/admin
 ApplicationResources_en.properties

webapps/admin/WEB-INF/classes/org/apache/webapp/admin/connector
 AddConnectorAction.java ConnectorForm.java
 EditConnectorAction.java SaveConnectorAction.java
webapps/admin/connector connector.jsp
   Log:
   Update Admin with new connector properties including thread pool
configuration.


Definately an improvement.  The AJP connector still lies, but that is
because I need to make some changes to the Protocol to get it to return the
correct values (Costin didn't design this with the admin in mind ;-).

All of my Connectors (http, https, ajp) show blanks for the Processors
section (even for those that I've explicitly configured in 'server.xml').
I've been out of touch with admin for a while, but is it looking for the
wrong attributes (I haven't had a chance to look myself yet).

This message is intended only for the use of the person(s) listed above as the 
intended recipient(s), and may contain information that is PRIVILEGED and 
CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or 
distribute this message or any attachment. If you received this communication in 
error, please notify us immediately by e-mail and then delete all copies of this 
message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the 
Internet is not secure. Do not send confidential or sensitive information, such as 
social security numbers, account numbers, personal identification numbers and 
passwords, to us via ordinary (unencrypted) e-mail.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5mbeans-descriptors.xml

2003-08-29 Thread Remy Maucherat
[EMAIL PROTECTED] wrote:
amyroh  2003/08/28 19:35:57

  Modified:catalina/src/share/org/apache/catalina/mbeans
ConnectorMBean.java
   catalina/src/share/org/apache/coyote/tomcat5
mbeans-descriptors.xml
  Log:
  Add ConnectorMBean implementation and force CoyoteConnector to use the 
ConnectorMBean for its configuration.

   attribute   name=maxProcessors
 description=The maximum number of processors allowed
  + type=int/
  +
  +attribute   name=minProcessors
  +  description=The minimum number of processors to start at
  +   initialization time
  + type=int/
There's no minProcessors anymore, only minSpareThreads. Similarly, 
maxProcessors should return maxThreads. You should add a note in the 
description that both are deprecated.

BTW, I think StandardServer should be adapted to create the new conector 
format, rather than use the old attribute names (and likely the socket 
factory also).

  +attribute   name=maxSpareThreads
  +  description=The maximum number of unused request processing threads
  + type=int/
  +
  +attribute   name=maxThreads
  +  description=The maximum number of request processing threads to be created
  + type=int/
  +
  +attribute   name=minSpareThreads
  +  description=The number of request processing threads that will be created
type=int/
   
   attribute   name=minProcessors
Remy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


DO NOT REPLY [Bug 22754] - Tomcat connectors page is missing

2003-08-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22754.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22754

Tomcat connectors page is missing

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2003-08-29 07:13 ---
This is not missing. New howtos are needed, since the configuration of JK 2 is
not identical to JK (a lot is similar though).

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22810] New: - can't use ant to deploy war to tomcat server on windows 2000, server pack 4

2003-08-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22810.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22810

can't use ant to deploy war to tomcat server on windows 2000, server pack 4

   Summary: can't use ant to deploy war to tomcat server on windows
2000, server pack 4
   Product: Tomcat 4
   Version: 4.1.27
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Webapps:Manager
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Now I can't deploy war to tomcat server(the server isn't a same computer as
development PC), But I can deploy war to tomcat server before I upgrade windows
2000.

before upgrade my OS version is windows 2000 ,Service Pack 3. after upgrade my
OS version is windows 2000 ,Service Pack 4. The error is:
E:\cvs\hbstockant deploy
Buildfile: build.xml

compile:

compile:

war:

deploy:

BUILD FAILED
file:E:/cvs/hbstock/build.xml:147: java.net.UnknownHostException: E

I don't know why?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jk/native/apache-2.0 bldjk.qclsrc

2003-08-29 Thread hgomez
hgomez  2003/08/29 06:05:36

  Modified:jk/native/apache-2.0 bldjk.qclsrc
  Log:
  Update the build file to have iSeries recognise Unix98 calls
  
  Revision  ChangesPath
  1.9   +39 -20jakarta-tomcat-connectors/jk/native/apache-2.0/bldjk.qclsrc
  
  Index: bldjk.qclsrc
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/apache-2.0/bldjk.qclsrc,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- bldjk.qclsrc  25 Jul 2003 14:29:00 -  1.8
  +++ bldjk.qclsrc  29 Aug 2003 13:05:36 -  1.9
  @@ -1,7 +1,8 @@
   PGM
   CRTCMOD MODULE(MOD_JK/MOD_JK) +
SRCSTMF('/home/apache/jk/native/apache-2.0/mod_jk.c') +
  - DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' 'USE_APACHE_MD5' '_REENTRANT') +
  + DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=520' + 
  +'USE_APACHE_MD5' '_REENTRANT') +
TEXT('mod_jk.c') +
OPTIMIZE(40) +
SYSIFCOPT(*IFSIO) +
  @@ -13,7 +14,8 @@
   
   CRTCMOD MODULE(MOD_JK/JK_AJP_COM) +
   SRCSTMF('/home/apache/jk/native/common/jk_ajp_common.c') +
  -DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' 'USE_APACHE_MD5' '_REENTRANT') +
  +DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=520' +  
  +   'USE_APACHE_MD5' '_REENTRANT') +
   TEXT('jk_ajp_common.c') +
   OPTIMIZE(40) +
   SYSIFCOPT(*IFSIO) +
  @@ -26,7 +28,8 @@
   
   CRTCMOD MODULE(MOD_JK/JK_AJP12_W) +
   SRCSTMF('/home/apache/jk/native/common/jk_ajp12_worker.c') +
  -DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' 'USE_APACHE_MD5' '_REENTRANT') +
  +DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=520' +  
  +   'USE_APACHE_MD5' '_REENTRANT') +
   TEXT('jk_ajp12_worker.c') +
   OPTIMIZE(40) +
   SYSIFCOPT(*IFSIO) +
  @@ -39,7 +42,8 @@
   
   CRTCMOD MODULE(MOD_JK/JK_AJP13) +
   SRCSTMF('/home/apache/jk/native/common/jk_ajp13.c') +
  -DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' 'USE_APACHE_MD5' '_REENTRANT') +
  +DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=520' +   
  +   'USE_APACHE_MD5' '_REENTRANT') +
   TEXT('jk_ajp13.c') +
   OPTIMIZE(40) +
   SYSIFCOPT(*IFSIO) +
  @@ -52,7 +56,8 @@
   
   CRTCMOD MODULE(MOD_JK/JK_AJP13_W) +
   SRCSTMF('/home/apache/jk/native/common/jk_ajp13_worker.c') +
  -DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' 'USE_APACHE_MD5' '_REENTRANT') +
  +DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=520' +  
  +   'USE_APACHE_MD5' '_REENTRANT') +
   TEXT('jk_ajp13_worker.c') +
   OPTIMIZE(40) +
   SYSIFCOPT(*IFSIO) +
  @@ -65,7 +70,8 @@
   
   CRTCMOD MODULE(MOD_JK/JK_AJP14) +
   SRCSTMF('/home/apache/jk/native/common/jk_ajp14.c') +
  -DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' 'USE_APACHE_MD5' '_REENTRANT') +
  +DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=520' +  
  +   'USE_APACHE_MD5' '_REENTRANT') +
   TEXT('jk_ajp14.c') +
   OPTIMIZE(40) +
   SYSIFCOPT(*IFSIO) +
  @@ -78,7 +84,8 @@
   
   CRTCMOD MODULE(MOD_JK/JK_AJP14_W) +
   SRCSTMF('/home/apache/jk/native/common/jk_ajp14_worker.c') +
  -DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' 'USE_APACHE_MD5' '_REENTRANT') +
  +DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=520' +  
  +   'USE_APACHE_MD5' '_REENTRANT') +
   TEXT('jk_ajp14_worker.c') +
   OPTIMIZE(40) +
   SYSIFCOPT(*IFSIO) +
  @@ -91,7 +98,8 @@
   
   CRTCMOD MODULE(MOD_JK/JK_CONNECT) +
   SRCSTMF('/home/apache/jk/native/common/jk_connect.c') +
  -DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' 'USE_APACHE_MD5' '_REENTRANT') +
  +DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=520' +  
  +   'USE_APACHE_MD5' '_REENTRANT') +
   TEXT('jk_connect.c') +
   OPTIMIZE(40) +
   SYSIFCOPT(*IFSIO) +
  @@ -104,7 +112,8 @@
   
   CRTCMOD MODULE(MOD_JK/JK_CONTEXT) +
   SRCSTMF('/home/apache/jk/native/common/jk_context.c') +
  -DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' 'USE_APACHE_MD5' '_REENTRANT') +
  +DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=520' +  
  +   'USE_APACHE_MD5' '_REENTRANT') +
   TEXT('jk_context.c') +
   OPTIMIZE(40) +
   SYSIFCOPT(*IFSIO) +
  @@ -117,7 +126,8 @@
   
   CRTCMOD MODULE(MOD_JK/JK_JNI_WOR) +
   SRCSTMF('/home/apache/jk/native/common/jk_jni_worker.c') +
  -DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' 'OS400_JVM_12' 'USE_APACHE_MD5' +
  +DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' 'OS400_JVM_12' + 
  +   '_XOPEN_SOURCE=520' +  'USE_APACHE_MD5' +
   '_REENTRANT') +
   TEXT('jk_jni_worker.c') +
   OPTIMIZE(40) +
  @@ -131,7 +141,8 @@
   
   CRTCMOD MODULE(MOD_JK/JK_LB_WORK) +
   SRCSTMF('/home/apache/jk/native/common/jk_lb_worker.c') +
  -DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' 'USE_APACHE_MD5' '_REENTRANT') +
  +DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=520' +  
  +   'USE_APACHE_MD5' '_REENTRANT') +
   TEXT('jk_lb_worker.c') +
  

cvs commit: jakarta-tomcat-connectors/jk/native/common jk_connect.c

2003-08-29 Thread hgomez
hgomez  2003/08/29 06:07:52

  Modified:jk/native/common jk_connect.c
  Log:
  No more special iSeries defines now that we define _XOPEN_SOURCE=520
  in build script...
  
  ie: 
  
  CRTCMOD MODULE(MOD_JK/JK_CONNECT) +
  SRCSTMF('/home/apache/jk/native/common/jk_connect.c') +
  DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=520' +  
 'USE_APACHE_MD5' '_REENTRANT') +
  TEXT('jk_connect.c') +
  OPTIMIZE(40) +
  SYSIFCOPT(*IFSIO) +
  LANGLVL(*ANSI) +
  TGTCCSID(*JOB) +
  OPTION(*LOGMSG) +
  TERASPACE(*YES *TSIFC) +
  STGMDL(*INHERIT) +
  INCDIR('/home/apache/jk/native/common' '/QIBM/ProdData/HTTPA/Include')
  
  Revision  ChangesPath
  1.12  +2 -7  jakarta-tomcat-connectors/jk/native/common/jk_connect.c
  
  Index: jk_connect.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_connect.c,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -r1.11 -r1.12
  --- jk_connect.c  26 Aug 2003 10:07:37 -  1.11
  +++ jk_connect.c  29 Aug 2003 13:07:52 -  1.12
  @@ -110,13 +110,8 @@
   int x;
   
   /* TODO: Should be updated for IPV6 support. */
  -/* for now use the correct type, in_addr_t (or u_long for OS400) */
  -
  -#ifdef AS400
  -u_long laddr;
  -#else
  +/* for now use the correct type, in_addr_t */
in_addr_t laddr;
  -#endif
   
   rc-sin_port   = htons((short)port);
   rc-sin_family = AF_INET;
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_channel_socket.c

2003-08-29 Thread hgomez
hgomez  2003/08/29 06:08:57

  Modified:jk/native2/common jk_channel_socket.c
  Log:
  No more special iSeries defines now that we define _XOPEN_SOURCE=520
  in build script...
  
  ie: 
  
  CRTCMOD MODULE(MOD_JK/JK_CONNECT) +
  SRCSTMF('/home/apache/jk/native/common/jk_connect.c') +
  DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=520' +  
 'USE_APACHE_MD5' '_REENTRANT') +
  TEXT('jk_connect.c') +
  OPTIMIZE(40) +
  SYSIFCOPT(*IFSIO) +
  LANGLVL(*ANSI) +
  TGTCCSID(*JOB) +
  OPTION(*LOGMSG) +
  TERASPACE(*YES *TSIFC) +
  STGMDL(*INHERIT) +
  INCDIR('/home/apache/jk/native/common' '/QIBM/ProdData/HTTPA/Include')
  
  Revision  ChangesPath
  1.56  +1 -6  jakarta-tomcat-connectors/jk/native2/common/jk_channel_socket.c
  
  Index: jk_channel_socket.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_channel_socket.c,v
  retrieving revision 1.55
  retrieving revision 1.56
  diff -u -r1.55 -r1.56
  --- jk_channel_socket.c   26 Aug 2003 10:07:36 -  1.55
  +++ jk_channel_socket.c   29 Aug 2003 13:08:57 -  1.56
  @@ -246,13 +246,8 @@
   int x;
   
   /* TODO: Should be updated for IPV6 support. */
  -/* for now use the correct type, in_addr_t (or u_long for OS400) */
  -
  -#ifdef AS400
  -u_long laddr;
  -#else
  +/* for now use the correct type, in_addr_t   */
   in_addr_t laddr;
  -#endif
   
   rc-sin_port   = htons((short)port);
   rc-sin_family = AF_INET;
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: jk 1.2.5 and ipv6

2003-08-29 Thread Henri Gomez
Glenn Nielsen a écrit :

Henri,

Can this wait until after the mod_jk 1.2.5 release?

BTW, int inet_pton(int af, const char *cp, void *addr);
is available in both Solaris 7 and 8.
And on FreeBSD 4.8 it is defined as:
int inet_pton __P((int, const char *, void *));
Regards,

Glenn
Ok, we could wait delay this for jk 1.2.6 ?

BTW, I finished with iSeries and Unix98 compat problems,
so you could tag it when you want.
I'm now fixing some cast and it will be ready for release.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Error in jk 1.2.5

2003-08-29 Thread Henri Gomez
if mod_jk.c, apr_strdup() is used.

But it should be :

apr_pstrdup ?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.h jk_uri_worker_map.c

2003-08-29 Thread hgomez
hgomez  2003/08/29 07:09:27

  Modified:jk/native/common jk_uri_worker_map.h jk_uri_worker_map.c
  Log:
  iSeries C compiler didn't like cast between const and non const.
  
  BTW, with the new function jk_no2slash, the uri is not more 
  constant
  
  Revision  ChangesPath
  1.7   +2 -2  jakarta-tomcat-connectors/jk/native/common/jk_uri_worker_map.h
  
  Index: jk_uri_worker_map.h
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_uri_worker_map.h,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- jk_uri_worker_map.h   27 Jun 2003 02:54:17 -  1.6
  +++ jk_uri_worker_map.h   29 Aug 2003 14:09:27 -  1.7
  @@ -98,7 +98,7 @@
   void jk_no2slash(char *name);
   
   char *map_uri_to_worker(jk_uri_worker_map_t *uw_map,
  -const char *uri,
  +char *uri,
   jk_logger_t *l);
   
   #ifdef __cplusplus
  
  
  
  1.19  +2 -2  jakarta-tomcat-connectors/jk/native/common/jk_uri_worker_map.c
  
  Index: jk_uri_worker_map.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_uri_worker_map.c,v
  retrieving revision 1.18
  retrieving revision 1.19
  diff -u -r1.18 -r1.19
  --- jk_uri_worker_map.c   26 Aug 2003 04:20:04 -  1.18
  +++ jk_uri_worker_map.c   29 Aug 2003 14:09:27 -  1.19
  @@ -480,7 +480,7 @@
   
   
   char *map_uri_to_worker(jk_uri_worker_map_t *uw_map,
  -const char *uri,
  +char *uri,
   jk_logger_t *l)
   {
   jk_log(l, JK_LOG_DEBUG, 
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jk/native/apache-2.0 mod_jk.c

2003-08-29 Thread hgomez
hgomez  2003/08/29 07:10:31

  Modified:jk/native/apache-2.0 mod_jk.c
  Log:
  Fix typo, apr_pstrdup should be used
  
  Revision  ChangesPath
  1.84  +3 -3  jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c
  
  Index: mod_jk.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c,v
  retrieving revision 1.83
  retrieving revision 1.84
  diff -u -r1.83 -r1.84
  --- mod_jk.c  28 Aug 2003 09:48:22 -  1.83
  +++ mod_jk.c  29 Aug 2003 14:10:31 -  1.84
  @@ -1720,7 +1720,7 @@
   
   if(conf  ! worker_name ) {
   /* Direct mapping ( via setHandler ). Try overrides */
  -char *uri = apr_strdup(r-pool, r-uri);
  +char *uri = apr_pstrdup(r-pool, r-uri);
   worker_name = map_uri_to_worker(conf-uw_map, uri, conf-log);
   if( ! worker_name ) {
   /* Since we are here, an explicit (native) mapping has been used */
  @@ -2384,7 +2384,7 @@
  Manually mapped, no need to call uri_to_worker\n);
   return DECLINED;
   }
  -uri = apr_strdup(r-pool, r-uri);
  +uri = apr_pstrdup(r-pool, r-uri);
   worker = map_uri_to_worker(conf-uw_map, uri, conf-log);
   
   if(worker) {
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 20561] - Limitation of availiable high ports for JK2

2003-08-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20561.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20561

Limitation of availiable high ports for JK2

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-08-29 15:57 ---
Cleaning house...

I have been using the patch I provided for a couple of monthes now.  It works 
fine.  I will close this bug.  Thanks everyone!

-e

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [5.0] JMX 1.2

2003-08-29 Thread Amy Roh
Hi Remy,

JSR 160 will go final in October (assuming the final ballot passes, as 
seems very likely).  At that stage the RI will be released under 
essentially the same licensing terms as the JMX RI.  So yes, Tomcat will 
be able to use it.

Amy

Remy Maucherat wrote:
As discussed before, I'm going to package the JMX RI 1.2.1 with TC 5.0.x 
from now on (after testing, of course).
I'll leave MX4J part of the build process.

Q to the Sun folks: can I legally ship the JMX remote 1.0 RI binary with 
Tomcat ?

Remy


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


help for jakarta tomcat on sparc 64 bit

2003-08-29 Thread Brijesh
Sir/madam,
I am working on java platform on Solaris 9 on the SPARC 64 bit system
I need to download Jakarta tomcat for the same
could you please suggest me a site location from where I can download the application
I would be grateful for your help
thank you
Regards
Brijesh Shetty
Divinet Access Technologies Ltd
***
DISCLAIMER
The information in this email is confidential and may be legally privileged. It is 
intended solely for the addressee. Access to this email by anyone else is 
unauthorized. If you are not the intended recipient, any disclosure, copying, 
distribution or any action taken or omitted to be taken in reliance on it, is 
prohibited and may be unlawful. When addressed to our clients any opinions or advice 
contained in this email are subject to the terms and conditions expressed in the 
governing DATL client engagement letter.
***


cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteRequest.java

2003-08-29 Thread jfarcand
jfarcand2003/08/29 10:18:14

  Modified:catalina/src/share/org/apache/catalina Globals.java
   catalina/src/share/org/apache/catalina/security
SecurityUtil.java
   catalina/src/share/org/apache/coyote/tomcat5
CoyoteRequest.java
  Log:
  Do not create a new Subject everytime a Servlet/Filter is invoked. Associate the 
same Subject to the AccessControlContext.
  
  Revision  ChangesPath
  1.6   +11 -4 
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/Globals.java
  
  Index: Globals.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/Globals.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- Globals.java  3 Mar 2003 15:46:45 -   1.5
  +++ Globals.java  29 Aug 2003 17:18:14 -  1.6
  @@ -332,6 +332,13 @@
   
   
   /**
  + * The subject under which the AccessControlContext is running.
  + */
  +public static final String SUBJECT_ATTR =
  +javax.security.auth.subject;
  +
  +
  +/**
* The servlet context attribute under which we record the set of
* welcome files (as an object of type String[]) for this application.
*/
  
  
  
  1.5   +78 -39
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/security/SecurityUtil.java
  
  Index: SecurityUtil.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/security/SecurityUtil.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- SecurityUtil.java 4 Jun 2003 21:15:39 -   1.4
  +++ SecurityUtil.java 29 Aug 2003 17:18:14 -  1.5
  @@ -64,6 +64,7 @@
   import java.lang.reflect.InvocationTargetException;
   import java.util.HashMap;
   import java.security.AccessController;
  +import java.security.AccessControlContext;
   import java.security.Principal;
   import java.security.PrivilegedActionException;
   import java.security.PrivilegedExceptionAction;
  @@ -72,17 +73,17 @@
   import javax.servlet.Filter;
   import javax.servlet.Servlet;
   import javax.servlet.ServletException;
  +import javax.servlet.http.HttpServletRequest;
   import javax.servlet.UnavailableException;
   
  -import org.apache.tomcat.util.buf.MessageBytes;
  -
  +import org.apache.catalina.Globals;
   import org.apache.catalina.util.StringManager;
  -
   /**
* This utility class associates a codeSubject/code to the current 
  - * codeAccessControlContext/code. When a codeSecurityManager/code is used, 
  - * the container will always associate the called thread with an 
AccessControlContext
  - * containing only the principal of the requested Servlet/Filter.
  + * codeAccessControlContext/code. When a codeSecurityManager/code is
  + * used, * the container will always associate the called thread with an 
  + * AccessControlContext * containing only the principal of the requested
  + * Servlet/Filter.
*
* This class uses reflection to invoke the invoke methods.
*
  @@ -123,7 +124,8 @@
* will be granted to a codenull/code subject. 
*
* @param methodName the method to apply the security restriction
  - * @param targetObject the codeServlet/code on which the method will be 
called.
  + * @param targetObject the codeServlet/code on which the method will
  + * be called.
*/
   public static void doAsPrivilege(final String methodName, 
final Servlet targetObject) throws 
java.lang.Exception{
  @@ -136,15 +138,24 @@
* will be granted to a codenull/code subject. 
*
* @param methodName the method to apply the security restriction
  - * @param targetObject the codeServlet/code on which the method will be 
called.
  - * @param targetType codeClass/code array used to instanciate a 
codeMethod/code object.
  - * @param targetObject codeObject/code array contains the runtime 
parameters instance.
  + * @param targetObject the codeServlet/code on which the method will
  + * be called.
  + * @param targetType codeClass/code array used to instanciate a i
  + * codeMethod/code object.
  + * @param targetObject codeObject/code array contains the runtime 
  + * parameters instance.
*/
   public static void doAsPrivilege(final String methodName, 
final Servlet targetObject, 
final Class[] targetType,
  - final Object[] targetArguments) throws 
java.lang.Exception{
  - doAsPrivilege(methodName, targetObject, targetType, targetArguments, 
null);
  + final Object[] 

Re: [5.0] JMX 1.2

2003-08-29 Thread Remy Maucherat
Amy Roh wrote:
Hi Remy,

JSR 160 will go final in October (assuming the final ballot passes, as 
seems very likely).  At that stage the RI will be released under 
essentially the same licensing terms as the JMX RI.  So yes, Tomcat will 
be able to use it.
Ok, so I won't bundle the binary until then.

I need to write code to replace the MX4J connector setup which is in 
ServerLifecycleListener and MBeanUtils. I'll implement that as a 
separate lifecycle listener.

Remy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


cvs commit: jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin ApplicationResources_es.properties

2003-08-29 Thread amyroh
amyroh  2003/08/29 12:09:36

  Modified:webapps/admin/WEB-INF/classes/org/apache/webapp/admin
ApplicationResources_es.properties
  Log:
  Forgot these properties in Spanish properties file.
  
  Revision  ChangesPath
  1.16  +3 -0  
jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationResources_es.properties
  
  Index: ApplicationResources_es.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationResources_es.properties,v
  retrieving revision 1.15
  retrieving revision 1.16
  diff -u -r1.15 -r1.16
  --- ApplicationResources_es.properties25 Aug 2003 22:16:38 -  1.15
  +++ ApplicationResources_es.properties29 Aug 2003 19:09:36 -  1.16
  @@ -127,6 +127,9 @@
   connector.milliseconds=milisegundos
   connector.max=M\u00e1ximo
   connector.maxkeepalive=Peticiones Máximas De KeepAlive
  +connector.maxspare=Max Spare Threads
  +connector.maxthreads=Max Threads
  +connector.minspare=Min Spare Threads
   connector.proxy.name=Nombre del Proxy
   connector.proxy.portnumber=N\u00fmero de Puerto del Proxy
   connector.algorithm=Algoritmo
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler JspDocumentParser.java ParserController.java

2003-08-29 Thread luehe
luehe   2003/08/29 12:31:22

  Modified:jasper2/src/share/org/apache/jasper/compiler
JspDocumentParser.java ParserController.java
  Log:
  Added support for JSP.6.2.4:
  
A JSP document with a DOCTYPE declaration must be validated by the
container in the translation phase. Validation errors must be handled
the same way as any other translation phase errors, as described in
Section JSP.1.4.1.
  
JSP 2.0 requires only DTD validation for JSP documents; containers
should not perform validation based on other types of schemas, such as
XML schema.
  
  This fixes Bugtraq 4914702.
  
  Revision  ChangesPath
  1.68  +113 -39   
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/JspDocumentParser.java
  
  Index: JspDocumentParser.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/JspDocumentParser.java,v
  retrieving revision 1.67
  retrieving revision 1.68
  diff -u -r1.67 -r1.68
  --- JspDocumentParser.java25 Aug 2003 22:25:54 -  1.67
  +++ JspDocumentParser.java29 Aug 2003 19:31:22 -  1.68
  @@ -62,6 +62,7 @@
   
   import java.io.*;
   import java.util.*;
  +import java.util.jar.JarFile;
   import javax.servlet.jsp.tagext.*;
   import javax.xml.parsers.SAXParserFactory;
   import javax.xml.parsers.ParserConfigurationException;
  @@ -87,24 +88,25 @@
   private static final String LEXICAL_HANDLER_PROPERTY
= http://xml.org/sax/properties/lexical-handler;;
   
  +private static final EnableDTDValidationException 
ENABLE_DTD_VALIDATION_EXCEPTION
  += new EnableDTDValidationException(jsp.error.enable_dtd_validation,
  +   null);
  +
   private ParserController parserController;
   private JspCompilationContext ctxt;
   private PageInfo pageInfo;
  -
  -// XML document source
  -private InputSource inputSource;
  -
   private String path;
   
   // Node representing the XML element currently being parsed
   private Node current;
   
  -// Document locator
   private Locator locator;
   
   // Flag indicating whether we are inside DTD declarations
   private boolean inDTD;
   
  +private boolean isValidating;
  +
   private ErrorDispatcher err;
   private boolean isTagFile;
   private boolean directivesOnly;
  @@ -115,18 +117,17 @@
*/
   public JspDocumentParser(ParserController pc,
 String path,
  -  InputStream inStream,
  +  JarFile jarFile,
 boolean isTagFile,
 boolean directivesOnly) {
  - this.parserController = pc;
  - this.ctxt = pc.getJspCompilationContext();
  - this.pageInfo = pc.getCompiler().getPageInfo();
  - this.err = pc.getCompiler().getErrorDispatcher();
  - this.path = path;
  - this.inputSource = new InputSource(inStream);
  - this.isTagFile = isTagFile;
  - this.directivesOnly = directivesOnly;
  - this.isTop = true;
  +this.parserController = pc;
  +this.ctxt = pc.getJspCompilationContext();
  +this.pageInfo = pc.getCompiler().getPageInfo();
  +this.err = pc.getCompiler().getErrorDispatcher();
  +this.path = path;
  +this.isTagFile = isTagFile;
  +this.directivesOnly = directivesOnly;
  +this.isTop = true;
   }
   
   /*
  @@ -136,7 +137,7 @@
*/
   public static Node.Nodes parse(ParserController pc,
   String path,
  -InputStream inStream,
  +JarFile jarFile,
   Node parent,
   boolean isTagFile,
   boolean directivesOnly,
  @@ -145,8 +146,9 @@
   boolean isEncodingSpecifiedInProlog)
throws JasperException {
   
  - JspDocumentParser jspDocParser = new JspDocumentParser(pc, path,
  -inStream,
  + JspDocumentParser jspDocParser = new JspDocumentParser(pc,
  +   path,
  +jarFile,
   isTagFile,
   directivesOnly);
Node.Nodes pageNodes = null;
  @@ -166,21 +168,25 @@
jspDocParser.isTop = false;
}
   
  - // Use the default (non-validating) parser
  - SAXParserFactory factory = SAXParserFactory.newInstance();
  - factory.setNamespaceAware(true);
  - // Preserve xmlns attributes
  - 

Re: cvs commit:jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5mbeans-descriptors.xml

2003-08-29 Thread Amy Roh
There's no minProcessors anymore, only minSpareThreads. Similarly, 
maxProcessors should return maxThreads. You should add a note in the 
description that both are deprecated.
I don't use minProcessors or maxProcessors.  I just left them in the 
descriptor instead of removing them.  I can either add a note or remove 
them.

BTW, I think StandardServer should be adapted to create the new conector 
format, rather than use the old attribute names (and likely the socket 
factory also).
Can you elaborate?

Thanks,
Amy


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5mbeans-descriptors.xml

2003-08-29 Thread Remy Maucherat
Amy Roh wrote:

There's no minProcessors anymore, only minSpareThreads. Similarly, 
maxProcessors should return maxThreads. You should add a note in the 
description that both are deprecated.
I don't use minProcessors or maxProcessors.  I just left them in the 
descriptor instead of removing them.  I can either add a note or remove 
them.
Forget it then :)
Adding a deprecated note wouldn't be completely useless, I guess.
BTW, I think StandardServer should be adapted to create the new 
conector format, rather than use the old attribute names (and likely 
the socket factory also).
Can you elaborate?
Well, when you press commit, it saves back the server.xml file, right ?
I believe the Connector element it saves doesn't use the modern syntax 
(see the current server.xml). That should be esp true for SSL and JK.

Also, I have one big gripe with the save server.xml feature: it creates 
an unreadable server.xml, since it mindlessly saves every field on every 
element. Kinda crappy, and I'm pretty sure many people don't use the 
admin webapp because it trashes their server.xml (ok, maybe it's becuase 
of the bugs also ;-) ) ...
I think I have a way to fix this:
- when saving an element, figure out what's the associated className
- instantiate an instance of that class (it there's no default 
constructor, skip this algorithm)
- for every field, also retrieve the value from the blank object
- if the two values match, it means the field has its default value, so 
don't save it to server.xml; otherwise, save it as usual

Remy



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


DO NOT REPLY [Bug 22806] - Link to Tomcat Administration

2003-08-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22806.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22806

Link to Tomcat Administration





--- Additional Comments From [EMAIL PROTECTED]  2003-08-29 19:32 ---
I am on AIX 5.1, i have try to use a good package of tomcat from a linux 
platform (tar and bzip2)
On the linux platform, Tomcat Administration is OK
But i have still the problem on AIX
I still need help 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22823] New: - Tomcat 4.1.27 is missing from download directory? I only see 4.1.24 4.1.26-alpha

2003-08-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22823.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22823

Tomcat 4.1.27 is missing from download directory? I only see 4.1.24   4.1.26-alpha 

   Summary: Tomcat 4.1.27 is missing from download directory? I only
see 4.1.24   4.1.26-alpha
   Product: Tomcat 4
   Version: 4.1.27
  Platform: All
   URL: http://jakarta.apache.org/builds/jakarta-tomcat-4.0/
OS/Version: All
Status: NEW
  Severity: Major
  Priority: Other
 Component: Unknown
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


The website mentions that Tomcat 4.1.27 has been out for a few weeks, but it is
not available for download on your website.

The README on the website
(http://jakarta.apache.org/tomcat/tomcat-4.1-doc/README.txt , also included with
Tomcat 4.1.24) says this:

--

Release Builds of Tomcat 4.1 are created and released periodically, and
announced to the interested mailing lists.  Each release build resides in its
own directories.  For example, the Tomcat 4.1.18 release is available at:

Binary:  http://jakarta.apache.org/builds/jakarta-tomcat-4.0/release/v4.1.18/bin/
Source:  http://jakarta.apache.org/builds/jakarta-tomcat-4.0/release/v4.1.18/src/

However, there is no 4.1.27 available anywhere under any subdirectories here:

http://jakarta.apache.org/builds/jakarta-tomcat-4.0/

I do see some other builds:

Index of /builds/jakarta-tomcat-4.0/release

 NameLast modified  Size  Description Parent
Directory -   
 v4.0.6/ 15-Jul-2003 11:54-   
 v4.1.24/01-Apr-2003 05:12-   
 v4.1.26-alpha/  15-Jul-2003 04:05-   


Either the directory is wrong, or the README is out of date.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 16189] - Tomcat Hangs in SSL Mode (Both 4.1.18 and 4.1.18LE for JDK 1.4)

2003-08-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16189.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16189

Tomcat Hangs in SSL Mode (Both 4.1.18 and 4.1.18LE for JDK 1.4)

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Major   |Critical
 Status|RESOLVED|REOPENED
 OS/Version|Windows NT/2K   |Linux
   Priority|Other   |Medium
 Resolution|FIXED   |
Version|4.1.18  |4.1.27



--- Additional Comments From [EMAIL PROTECTED]  2003-08-29 21:02 ---
I am getting a similar/the same problem using Tomcat 4.1.27, so 4.1.19 didn't
fix this problem so far as I can tell.

After use of the application for a little while I end up with these messages in
the logs and the container needs to be restarted for SSL to work again.  HTTP
still works fine though.

I am using log4j and struts 1.1 in my application.

Aug 29, 2003 12:04:01 PM
org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler processConnection
SEVERE: Error reading request, ignored
org.apache.commons.logging.LogConfigurationException:
org.apache.commons.logging.LogConfigurationException:
org.apache.commons.logging.LogConfigurationException: Class
org.apache.commons.logging.impl.Log4JLogger does not implement Log
at
org.apache.commons.logging.impl.LogFactoryImpl.newInstance(LogFactoryImpl.java:532)
at
org.apache.commons.logging.impl.LogFactoryImpl.getInstance(LogFactoryImpl.java:272)
at
org.apache.commons.logging.impl.LogFactoryImpl.getInstance(LogFactoryImpl.java:246)
at org.apache.commons.logging.LogFactory.getLog(LogFactory.java:395)
at org.apache.tomcat.util.net.jsse.JSSESupport.init(JSSESupport.java:87)
at
org.apache.tomcat.util.net.jsse.JSSE14Support.init(JSSE14Support.java:99)
at
org.apache.tomcat.util.net.jsse.JSSE14Factory.getSSLSupport(JSSE14Factory.java:84)
at
org.apache.tomcat.util.net.jsse.JSSEImplementation.getSSLSupport(JSSEImplementation.java:118)
at
org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.processConnection(Http11Protocol.java:385)
at
org.apache.tomcat.util.net.TcpWorkerThread.runIt(PoolTcpEndpoint.java:565)
at
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:619)
at java.lang.Thread.run(Thread.java:536)
Caused by: org.apache.commons.logging.LogConfigurationException:
org.apache.commons.logging.LogConfigurationException: Class
org.apache.commons.logging.impl.Log4JLogger does not implement Log
at
org.apache.commons.logging.impl.LogFactoryImpl.getLogConstructor(LogFactoryImpl.java:416)
at
org.apache.commons.logging.impl.LogFactoryImpl.newInstance(LogFactoryImpl.java:525)
... 11 more
Caused by: org.apache.commons.logging.LogConfigurationException: Class
org.apache.commons.logging.impl.Log4JLogger does not implement Log
at
org.apache.commons.logging.impl.LogFactoryImpl.getLogConstructor(LogFactoryImpl.java:412)
... 12 more

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Asking the user for a password on startup

2003-08-29 Thread joe user
Hello Tomcat developers,

I have a class which needs to get a password typed in
on the console from a user for startup.  This password
is used to access an encryption key so I don't want it
to be stored in web.xml, etc.  I could create a web
application that accepts that password over the net,
but what I really want to do is to just allow the
administrator to type the password in when he runs
startup.sh.

One solution that I have is to have a class with a
static block that gets the password from the console. 
That works fine (the password is requested when the
class is loaded) but it breaks the regular Tomcat
startup scripts.  I modified the script so that it
does not background the java process, and then I hit
Ctl-Z and then background it, but what I'm wondering
is, is there a better way to do this?

Thanks!


__
Do you Yahoo!?
Yahoo! SiteBuilder - Free, easy-to-use web site design software
http://sitebuilder.yahoo.com

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22328] - javax.management.ReflectionException: Cannot find method getClassName with this signature

2003-08-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22328.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22328

javax.management.ReflectionException: Cannot find method getClassName with this 
signature

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 OS/Version|Windows NT/2K   |Linux
   Priority|Other   |High
 Resolution|FIXED   |



--- Additional Comments From [EMAIL PROTECTED]  2003-08-29 18:37 ---
Der Fehler passiert, wenn man die Valve
org.apache.catalina.valves.AccessLogValve öffnet. Leider, kenne ich noch keine
Abhilfe, außer der, die Valve zu machen.
Ausgerechnet aber gerade diese Valve ist äußerst wichtig!

java.lang.NoSuchMethodException:
org.apache.catalina.valves.AccessLogValve.getClassName()
at java.lang.Class.getMethod0(Class.java:1756)
at java.lang.Class.getMethod(Class.java:963)
at org.apache.commons.modeler.BaseModelMBean.invoke(BaseModelMBean.java:372)
at
org.apache.commons.modeler.BaseModelMBean.getAttribute(BaseModelMBean.java:238)
at
mx4j.server.interceptor.InvokerMBeanServerInterceptor.getAttribute(InvokerMBeanServerInterceptor.java:242)
.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardServer.java

2003-08-29 Thread remm
remm2003/08/29 14:21:29

  Modified:catalina/src/share/org/apache/catalina/core
StandardServer.java
  Log:
  - Implement my simple trick: don't save the value of properties which have their
default values. A number of fields are saved while they really shouldn't, but
it's significantly better.
  - Revert if it causes problems.
  
  Revision  ChangesPath
  1.19  +13 -4 
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardServer.java
  
  Index: StandardServer.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardServer.java,v
  retrieving revision 1.18
  retrieving revision 1.19
  diff -u -r1.18 -r1.19
  --- StandardServer.java   19 Jul 2003 14:30:07 -  1.18
  +++ StandardServer.java   29 Aug 2003 21:21:29 -  1.19
  @@ -1064,6 +1064,8 @@
   
   // Render the relevant properties of this bean
   String className = bean.getClass().getName();
  +// Create blank instance
  +Object bean2 = bean.getClass().newInstance();
   for (int i = 0; i  descriptors.length; i++) {
   if (descriptors[i] instanceof IndexedPropertyDescriptor) {
   continue; // Indexed properties are not persisted
  @@ -1076,11 +1078,18 @@
   Object value =
   PropertyUtils.getSimpleProperty(bean,
   descriptors[i].getName());
  +Object value2 =
  +PropertyUtils.getSimpleProperty(bean2,
  +descriptors[i].getName());
   if (value == null) {
   continue; // Null values are not persisted
   }
   if (isException(className, descriptors[i].getName())) {
   continue; // Skip the specified exceptions
  +}
  +if (value.equals(value2)) {
  +// The property has its default value
  +continue;
   }
   if (!(value instanceof String)) {
   value = value.toString();
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteConnector.java

2003-08-29 Thread remm
remm2003/08/29 14:34:46

  Modified:catalina/src/share/org/apache/coyote/tomcat5
CoyoteConnector.java
  Log:
  - Since port is mandatory, there should be no default value. (this is a quick fix
obviously)
  
  Revision  ChangesPath
  1.27  +2 -2  
jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteConnector.java
  
  Index: CoyoteConnector.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteConnector.java,v
  retrieving revision 1.26
  retrieving revision 1.27
  diff -u -r1.26 -r1.27
  --- CoyoteConnector.java  29 Aug 2003 02:44:16 -  1.26
  +++ CoyoteConnector.java  29 Aug 2003 21:34:46 -  1.27
  @@ -239,7 +239,7 @@
   /**
* The port number on which we listen for requests.
*/
  -private int port = 8080;
  +private int port = 0;
   
   
   /**
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: [j-t-c] Thread problem in jk_uri_worker_map.c

2003-08-29 Thread Marc Saegesser
The file common/jk_connect.c no longer compiles on Win32 because the
in_addr_t type is not defined on that platform.  The attached patch fixes
the build problem, but there is probably a better way.

-- Marc
 

 -Original Message-
 From: Glenn Nielsen [mailto:[EMAIL PROTECTED]
 Sent: Wednesday, August 27, 2003 8:55 AM
 To: Tomcat Developers List
 Subject: Re: [j-t-c] Thread problem in jk_uri_worker_map.c
 
 Henri Gomez wrote:
  Marc Saegesser a écrit :
 
  That makes sense.  The manipulations that map_uri_to_worker() does
 always
  make the string shorter so there is no need to worry about the
 modifiable
  string passed in being too short and needing reallocated.
 
  Trying to fix this in the jk/common code is, I think, a waste of
 effort.
 
  -- Marc
 
 
  A good reason to have delayed jk 1.2.5 ;)
 
 
 Ok, I have seen Henri's commit for the in_addr build fix.
 And I have seen Bill's patches for the uri mapping thread safe
 bug.
 
 If I don't hear about any more open items/bugs  for mod_jk 1.2.5 in the
 next
 few days I will generate another test release distribution over the
 weekend.
 
 Regards,
 
 Glenn
 
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22058] - incorrect JSP compilation

2003-08-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22058.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22058

incorrect JSP compilation





--- Additional Comments From [EMAIL PROTECTED]  2003-08-29 22:01 ---
Hmm... The attached war file does not seem to contain the JSP page you quoted.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22426] - cannot resolve getContextPath on ServletRequest

2003-08-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22426.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22426

cannot resolve getContextPath on ServletRequest

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2003-08-29 22:28 ---
The spec (see JSP.8.8) only required that request be a subclass of
javax.servlet.ServletResponse, but not necessarily
javax.servlet.http.HttpServletRequest.  Use your workaround when it works.  :-)

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: [j-t-c] Thread problem in jk_uri_worker_map.c

2003-08-29 Thread Marc Saegesser
G, the attachment got stripped from my last message.  Here's the diff
inline:

Index: jk_connect.c
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_connect.c,v
retrieving revision 1.12
diff -u -r1.12 jk_connect.c
--- jk_connect.c29 Aug 2003 13:07:52 -  1.12
+++ jk_connect.c29 Aug 2003 21:37:12 -
@@ -101,6 +101,9 @@
 #include apr_general.h
 #endif
 
+#if defined(WIN32)
+typedef u_long in_addr_t;
+#endif
 /** resolve the host IP */
  
 int jk_resolve(char *host,


-- Marc
 

 -Original Message-
 From: Marc Saegesser [mailto:[EMAIL PROTECTED]
 Sent: Friday, August 29, 2003 4:41 PM
 To: Tomcat Developers List
 Subject: RE: [j-t-c] Thread problem in jk_uri_worker_map.c
 
 The file common/jk_connect.c no longer compiles on Win32 because the
 in_addr_t type is not defined on that platform.  The attached patch fixes
 the build problem, but there is probably a better way.
 
 -- Marc
 
 
  -Original Message-
  From: Glenn Nielsen [mailto:[EMAIL PROTECTED]
  Sent: Wednesday, August 27, 2003 8:55 AM
  To: Tomcat Developers List
  Subject: Re: [j-t-c] Thread problem in jk_uri_worker_map.c
 
  Henri Gomez wrote:
   Marc Saegesser a écrit :
  
   That makes sense.  The manipulations that map_uri_to_worker() does
  always
   make the string shorter so there is no need to worry about the
  modifiable
   string passed in being too short and needing reallocated.
  
   Trying to fix this in the jk/common code is, I think, a waste of
  effort.
  
   -- Marc
  
  
   A good reason to have delayed jk 1.2.5 ;)
  
 
  Ok, I have seen Henri's commit for the in_addr build fix.
  And I have seen Bill's patches for the uri mapping thread safe
  bug.
 
  If I don't hear about any more open items/bugs  for mod_jk 1.2.5 in the
  next
  few days I will generate another test release distribution over the
  weekend.
 
  Regards,
 
  Glenn
 
 
  -
  To unsubscribe, e-mail: [EMAIL PROTECTED]
  For additional commands, e-mail: [EMAIL PROTECTED]
 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22426] - cannot resolve getContextPath on ServletRequest

2003-08-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22426.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22426

cannot resolve getContextPath on ServletRequest





--- Additional Comments From [EMAIL PROTECTED]  2003-08-29 22:48 ---
Arghh.  I meant javax.servlet.ServletRequest, not javax.servlet.ServletResponse!

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]