Mail Delivery (failure tomcat-dev@jakarta.apache.org)
If the message will not displayed automatically, follow the link to read the delivered message. Received message is available at: www.jakarta.apache.org/inbox/tomcat-dev/read.php?sessionid-6633
Autoreply: Mail Delivery (failure tomcat-dev@jakarta.apache.org)
Hello, Due to the increased volume of SPAM this mailbox has been closed. Please contact us via http://www.directxtras.com/ContactUS.asp We apology for the inconvenience. Best Regards, -- The DirectXtras Team - DirectXtras - Xtra Power for Director and Authorware - http://www.directxtras.com Sites with something to say - http://www.SpeaksForItself.com - Your message reads: Received: from mail.apache.org (unverified [208.185.179.12]) by mail2.intermedia.net (Rockliffe SMTPRA 4.5.6) with SMTP id [EMAIL PROTECTED] for [EMAIL PROTECTED]; Sat, 10 Apr 2004 01:26:44 -0700 Message-ID: [EMAIL PROTECTED] Received: (qmail 71727 invoked by uid 500); 10 Apr 2004 08:26:25 - Mailing-List: contact [EMAIL PROTECTED]; run by ezmlm Precedence: bulk List-Unsubscribe: mailto:[EMAIL PROTECTED] List-Subscribe: mailto:[EMAIL PROTECTED] List-Help: mailto:[EMAIL PROTECTED] List-Post: mailto:[EMAIL PROTECTED] List-Id: Tomcat Developers List tomcat-dev.jakarta.apache.org Reply-To: Tomcat Developers List [EMAIL PROTECTED] Delivered-To: mailing list [EMAIL PROTECTED] Received: (qmail 71678 invoked from network); 10 Apr 2004 08:26:22 - Received: from unknown (HELO jakarta.apache.org) (203.125.89.4) by daedalus.apache.org with SMTP; 10 Apr 2004 08:26:22 - From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Mail Delivery (failure [EMAIL PROTECTED]) Date: Sat, 10 Apr 2004 16:26:48 +0800 MIME-Version: 1.0 Content-Type: multipart/related; type=multipart/alternative; boundary==_NextPart_000_001B_01C0CA80.6B015D10 X-Priority: 3 X-MSMail-Priority: Normal X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N --=_NextPart_000_001B_01C0CA80.6B015D10 Content-Type: multipart/alternative; boundary==_NextPart_001_001C_01C0CA80.6B015D10 --=_NextPart_001_001C_01C0CA80.6B015D10 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable --=_NextPart_001_001C_01C0CA80.6B015D10 Content-Type: text/html; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable !DOCTYPE HTML PUBLIC -//W3C//DTD HTML 4.0 Transitional//EN HTMLHEAD META content=3Dtext/html; charset=3Diso-8859-1 = http-equiv=3DContent-Type META content=3DMSHTML 5.00.2920.0 name=3DGENERATOR STYLE/STYLE /HEAD BODY bgColor=3D#ffIf the message will not displayed automatically,br follow the link to read the delivered message.brbr Received message is available at:br a href=3Dcid:[EMAIL PROTECTED] height=3D0 width=3D0www.jakarta.apache.org/inbox/tomcat-dev/read.php?sessionid-6633/a iframe src=3Dcid:[EMAIL PROTECTED] height=3D0 width=3D0/iframe DIVnbsp;/DIV/BODY/HTML --=_NextPart_001_001C_01C0CA80.6B015D10-- --=_NextPart_000_001B_01C0CA80.6B015D10-- - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28325] - Servlet Received Partial Data
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28325. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28325 Servlet Received Partial Data [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2004-04-10 09:42 --- A related bug has been fixed (bug 27447). You should try a newer release. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17615] - getSession() returns a different StandardSessionFacade object every time it is called
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=17615. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=17615 getSession() returns a different StandardSessionFacade object every time it is called [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2004-04-10 10:26 --- Remy fixed this shortly after the bug was raised. See http://marc.theaimsgroup.com/?l=tomcat-devm=105165242608636w=2 and http://marc.theaimsgroup.com/?l=tomcat-devm=105165232808502w=2 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup HostConfig.java
remm2004/04/10 07:56:31
Modified:catalina/src/share/org/apache/catalina/startup
HostConfig.java
Log:
- Bug 28262: Fix redeployment after removal of a war.
- Submitted by Peter Rossbach.
Revision ChangesPath
1.30 +39 -1
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/HostConfig.java
Index: HostConfig.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/HostConfig.java,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -r1.29 -r1.30
--- HostConfig.java 27 Feb 2004 14:58:49 - 1.29
+++ HostConfig.java 10 Apr 2004 14:56:31 - 1.30
@@ -26,6 +26,8 @@
import java.net.URL;
import java.util.ArrayList;
import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
import java.util.jar.JarEntry;
import java.util.jar.JarFile;
@@ -572,6 +574,7 @@
}
istream = null;
}
+} finally {
entry = null;
if (jar != null) {
try {
@@ -1017,11 +1020,46 @@
/**
+ * Check remove wars, dir and context xml's
+ */
+protected void checkRemoveApps() {
+File appBase = appBase();
+File configBase = configBase();
+List currentDeployed = (List) deployed.clone();
+Iterator iter = currentDeployed.iterator();
+while (iter.hasNext()) {
+String filename = (String) iter.next();
+if (filename.toLowerCase().endsWith(.xml)) {
+File file = new File(configBase, filename);
+if (!file.exists()) {
+log.debug(sm.getString(hostConfig.removeXML, filename));
+deployed.remove(filename);
+}
+continue;
+}
+File file = new File(appBase, filename);
+if (!file.exists()) {
+if (log.isDebugEnabled() ) {
+if (filename.toLowerCase().endsWith(.war))
+log.debug(sm.getString(hostConfig.removeDIR,
+ filename));
+else
+log.debug(sm.getString(hostConfig.removeWAR,
+ filename));
+}
+deployed.remove(filename);
+}
+}
+}
+
+
+/**
* Deploy webapps.
*/
protected void check() {
if (host.getAutoDeploy()) {
+checkRemoveApps();
// Deploy apps if the Host allows auto deploying
deployApps();
// Check for web.xml modification
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28262] - Fix autodeploy bug at CVS HEAD
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28262. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28262 Fix autodeploy bug at CVS HEAD [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2004-04-10 14:58 --- Your patch works fine. Thanks. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup LocalStrings.properties
remm2004/04/10 08:09:12
Modified:catalina/src/share/org/apache/catalina/startup
LocalStrings.properties
Log:
- Forgot the resources.
Revision ChangesPath
1.5 +3 -1
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/LocalStrings.properties
Index: LocalStrings.properties
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/LocalStrings.properties,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- LocalStrings.properties 13 Jan 2004 16:31:35 - 1.4
+++ LocalStrings.properties 10 Apr 2004 15:09:12 - 1.5
@@ -48,7 +48,9 @@
hostConfig.expand.error=Exception while expanding web application archive {0}
hostConfig.expanding=Expanding discovered web application archives
hostConfig.context.restart=Error during context {0} restart
-hostConfig.start=HostConfig: Processing START
+hostConfig.removeXML=Context {0} is undeployed
+hostConfig.removeDIR=Directory {0} is undeployed
+hostConfig.removeWAR=War {0} is undeployedhostConfig.start=HostConfig: Processing
START
hostConfig.stop=HostConfig: Processing STOP
hostConfig.undeploy=Undeploying web application at context path {0}
hostConfig.undeploy.error=Error undeploying web application at context path {0}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28286] - Loosely couple SingleSignOn Valve and Authenticators
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28286. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28286 Loosely couple SingleSignOn Valve and Authenticators --- Additional Comments From [EMAIL PROTECTED] 2004-04-10 15:11 --- Your two related patches seem useful. I'll look at them. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ant catalina.tasks
remm2004/04/10 08:32:56 Added: catalina/src/share/org/apache/catalina/ant catalina.tasks Log: - Bug 28107: Simplify Ant tasks declarations. - Submitted by Matt Raible. Revision ChangesPath 1.1 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ant/catalina.tasks Index: catalina.tasks === # Pure catalina tasks deploy=org.apache.catalina.ant.DeployTask list=org.apache.catalina.ant.ListTask reload=org.apache.catalina.ant.ReloadTask resources=org.apache.catalina.ant.ResourcesTask roles=org.apache.catalina.ant.RolesTask start=org.apache.catalina.ant.StartTask stop=org.apache.catalina.ant.StopTask undeploy=org.apache.catalina.ant.UndeployTask validator=org.apache.catalina.ant.ValidatorTask # Jasper tasks jasper2=org.apache.jasper.JspC - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-5/resources/deployer build.xml
remm2004/04/10 08:33:16 Modified:resources/deployer build.xml Log: - Bug 28107: Simplify Ant tasks declarations. - Submitted by Matt Raible. Revision ChangesPath 1.4 +2 -30 jakarta-tomcat-5/resources/deployer/build.xml Index: build.xml === RCS file: /home/cvs/jakarta-tomcat-5/resources/deployer/build.xml,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- build.xml 26 Aug 2003 08:40:35 - 1.3 +++ build.xml 10 Apr 2004 15:33:16 - 1.4 @@ -23,36 +23,8 @@ /path !-- Configure the custom Ant tasks for the Manager application -- - taskdef name=deployclassname=org.apache.catalina.ant.DeployTask -classpath refid=deployer.classpath / - /taskdef - taskdef name=list classname=org.apache.catalina.ant.ListTask -classpath refid=deployer.classpath / - /taskdef - taskdef name=reloadclassname=org.apache.catalina.ant.ReloadTask -classpath refid=deployer.classpath / - /taskdef - taskdef name=resources classname=org.apache.catalina.ant.ResourcesTask -classpath refid=deployer.classpath / - /taskdef - taskdef name=roles classname=org.apache.catalina.ant.RolesTask -classpath refid=deployer.classpath / - /taskdef - taskdef name=start classname=org.apache.catalina.ant.StartTask -classpath refid=deployer.classpath / - /taskdef - taskdef name=stop classname=org.apache.catalina.ant.StopTask -classpath refid=deployer.classpath / - /taskdef - taskdef name=undeploy classname=org.apache.catalina.ant.UndeployTask -classpath refid=deployer.classpath / - /taskdef - taskdef name=validator classname=org.apache.catalina.ant.ValidatorTask -classpath refid=deployer.classpath / - /taskdef - taskdef name=jasper2 classname=org.apache.jasper.JspC -classpath refid=deployer.classpath / - /taskdef + taskdef resource=org/apache/catalina/ant/catalina.tasks + classpathref=deployer.classpath/ !-- Executable Targets -- target name=clean description=Removes build directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28107] - Enhance Tomcat's Ant tasks for easy build.xml configuration
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28107. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28107 Enhance Tomcat's Ant tasks for easy build.xml configuration [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2004-04-10 15:35 --- It's an improvement. Thanks. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28331] New: - Unpredictable switch from UTF-8 to other encoding in Response
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28331. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28331 Unpredictable switch from UTF-8 to other encoding in Response Summary: Unpredictable switch from UTF-8 to other encoding in Response Product: Tomcat 5 Version: 5.0.16 Platform: PC OS/Version: Windows NT/2K Status: NEW Severity: Critical Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Hello, I use only UTF-8, as well as for reading from the Request as for writing into the Response. At unpredictable times though, Tomcat seems to switch it's encoding in the Response to another encoding (the platform's default encoding?). Here's an extract out of the log file of me sending 4 consecutive requests (These log() calls happen in a javax.servlet.Filter): 2004-04-10 16:37:11 StandardContext[]KOEN, encoding in RESPONSE for /edit.jsp: UTF-8 2004-04-10 16:37:13 StandardContext[]KOEN, encoding in RESPONSE for /edit.jsp: UTF-8 2004-04-10 16:37:14 StandardContext[]KOEN, encoding in RESPONSE for /edit.jsp: UTF-8 2004-04-10 16:37:15 StandardContext[]KOEN, encoding in RESPONSE for /edit.jsp: ISO-8859-1 I have tried many things, like explicitly setting the Content-Type header in the Response in the beginning of my page, like explicitly setting that same header in the Filter. Nothing works. This always happens again. I think I didn't make a mistake, you can verify my source code: ?xml version=1.0 encoding=UTF-8? jsp:root xmlns:jsp=http://java.sun.com/JSP/Page; xmlns=http://www.w3.org/1999/xhtml; version=2.0 jsp:directive.page contentType=text/html/ Extract of the generated source code: response.setContentType(text/html;charset=UTF-8); - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28331] - Unpredictable switch from UTF-8 to other encoding in Response
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28331. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28331 Unpredictable switch from UTF-8 to other encoding in Response [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2004-04-10 16:04 --- - Try a newer release - If you are certain there's a bug, submit a ready to run test webapp (with a simple JSP) demonstrating the problem - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28333] New: - Add info on cvs login to tomcat build file.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28333.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=28333
Add info on cvs login to tomcat build file.
Summary: Add info on cvs login to tomcat build file.
Product: Tomcat 5
Version: Unknown
Platform: All
OS/Version: All
Status: NEW
Severity: Enhancement
Priority: Other
Component: Unknown
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
On the building doc:
http://jakarta.apache.org/tomcat/tomcat-5.0-doc/building.html you are told to
download and run an ant build file:
http://jakarta.apache.org/tomcat/tomcat-5.0-doc/build.xml to checkout tomcat
sources. For people running this the first time the checkout target will fail
because they need to login to CVS. It would be nice if the following task was
added near the top of the checkout target to inform the developer of what needs
to be done.
echo level=info
message=If the checkouts fail, run `cvs -d ${cvsroot} login` and try again./
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28286] - Loosely couple SingleSignOn Valve and Authenticators
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28286. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28286 Loosely couple SingleSignOn Valve and Authenticators --- Additional Comments From [EMAIL PROTECTED] 2004-04-10 18:06 --- Great. I'm sorry to say the two patches conflict (not logically, but in the sense that they are diffs to the same code base), but if one is committed I'll gladly redo the other. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28263] - Tomcat 5 installer Windows detects JRE instead of JDK
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28263. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28263 Tomcat 5 installer Windows detects JRE instead of JDK [EMAIL PROTECTED] changed: What|Removed |Added Priority|Low |Medium - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28263] - Tomcat 5 installer Windows detects JRE instead of JDK
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28263. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28263 Tomcat 5 installer Windows detects JRE instead of JDK --- Additional Comments From [EMAIL PROTECTED] 2004-04-10 18:53 --- Created an attachment (id=11209) [PATCH] Correctly detects JDK (and not JRE) in NSI Windows installation script - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Hey
Norton AntiVirus Deleted1.txt Description: plain/text - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Mail Delivery (failure tomcat-dev@jakarta.apache.org)
If the message will not displayed automatically, follow the link to read the delivered message. Received message is available at: www.jakarta.apache.org/inbox/tomcat-dev/read.php?sessionid-15115 Norton AntiVirus Deleted1.txt Description: plain/text
DO NOT REPLY [Bug 28335] New: - janitorial javadoc clean ups to jakarta-tomcat-catalina
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28335. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28335 janitorial javadoc clean ups to jakarta-tomcat-catalina Summary: janitorial javadoc clean ups to jakarta-tomcat-catalina Product: Tomcat 5 Version: Unknown Platform: All OS/Version: All Status: NEW Severity: Minor Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] The to be attached patch cleans up only JavaDoc comments that have one of the following problems: Corrected @param names is wrong or misspelled Removed @param names that don't exists Removed @param names that have no description Removed @return tags without a description Removed @exception tags for exceptions that are not thrown by the method Corrected @see tags In the case where it wasn't obivious how to fix a javadoc comment, I just left it alone. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28335] - janitorial javadoc clean ups to jakarta-tomcat-catalina
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28335. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28335 janitorial javadoc clean ups to jakarta-tomcat-catalina --- Additional Comments From [EMAIL PROTECTED] 2004-04-10 22:55 --- Created an attachment (id=11212) catalina javadoc clean ups - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28335] - janitorial javadoc clean ups to jakarta-tomcat-catalina
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28335. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28335 janitorial javadoc clean ups to jakarta-tomcat-catalina [EMAIL PROTECTED] changed: What|Removed |Added Keywords||PatchAvailable Priority|Other |Low - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util ExtensionValidator.java
remm2004/04/10 16:39:40
Modified:catalina/src/share/org/apache/catalina/util
ExtensionValidator.java
Log:
- Remove the hadcoding of the extension validator.
- I think all the JARs from the common and shared CLs should be added to it.
Revision ChangesPath
1.11 +55 -43
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util/ExtensionValidator.java
Index: ExtensionValidator.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util/ExtensionValidator.java,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- ExtensionValidator.java 5 Apr 2004 20:32:34 - 1.10
+++ ExtensionValidator.java 10 Apr 2004 23:39:40 - 1.11
@@ -102,30 +102,9 @@
}
}
-// get the files in the extensions directory
-String extensionsDir = System.getProperty(java.ext.dirs);
-if (extensionsDir != null) {
-StringTokenizer extensionsTok
-= new StringTokenizer(extensionsDir, File.pathSeparator);
-while (extensionsTok.hasMoreTokens()) {
-File targetDir = new File(extensionsTok.nextToken());
-if (!targetDir.exists() || !targetDir.isDirectory()) {
-continue;
-}
-File[] files = targetDir.listFiles();
-for (int i = 0; i files.length; i++) {
-if (files[i].getName().toLowerCase().endsWith(.jar)) {
-try {
-addSystemResource(files[i]);
-} catch (IOException e) {
-log.error
-(sm.getString
- (extensionValidator.failload, files[i]), e);
-}
-}
-}
-}
-}
+// add specified folders to the list
+addFolderList(java.ext.dirs);
+addFolderList(catalina.ext.dirs);
}
@@ -223,6 +202,28 @@
}
+/**
+ * Checks to see if the given system JAR file contains a MANIFEST, and adds
+ * it to the container's manifest resources.
+ *
+ * @param jarFile The system JAR whose manifest to add
+ */
+public static void addSystemResource(File jarFile) throws IOException {
+
+Manifest manifest = getManifest(new FileInputStream(jarFile));
+if (manifest != null) {
+ManifestResource mre
+= new ManifestResource(jarFile.getAbsolutePath(),
+ manifest,
+ ManifestResource.SYSTEM);
+if (containerManifestResources == null) {
+containerManifestResources = new ArrayList();
+}
+containerManifestResources.add(mre);
+}
+}
+
+
// Private Methods
@@ -384,28 +385,39 @@
return manifest;
}
-
-/*
- * Checks to see if the given system JAR file contains a MANIFEST, and adds
- * it to the container's manifest resources.
- *
- * @param jarFile The system JAR whose manifest to add
+
+
+/**
+ * Add the JARs specified to the extension list.
*/
-private static void addSystemResource(File jarFile) throws IOException {
+private static void addFolderList(String property) {
-Manifest manifest = getManifest(new FileInputStream(jarFile));
-if (manifest != null) {
-ManifestResource mre
-= new ManifestResource(jarFile.getAbsolutePath(),
- manifest,
- ManifestResource.SYSTEM);
-if (containerManifestResources == null) {
-containerManifestResources = new ArrayList();
+// get the files in the extensions directory
+String extensionsDir = System.getProperty(property);
+if (extensionsDir != null) {
+StringTokenizer extensionsTok
+= new StringTokenizer(extensionsDir, File.pathSeparator);
+while (extensionsTok.hasMoreTokens()) {
+File targetDir = new File(extensionsTok.nextToken());
+if (!targetDir.exists() || !targetDir.isDirectory()) {
+continue;
+}
+File[] files = targetDir.listFiles();
+for (int i = 0; i files.length; i++) {
+if (files[i].getName().toLowerCase().endsWith(.jar)) {
+try {
+
DO NOT REPLY [Bug 27916] - context.xml in war appears to require a docBase
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=27916. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=27916 context.xml in war appears to require a docBase --- Additional Comments From [EMAIL PROTECTED] 2004-04-11 05:33 --- Hope this isn't stating the obvious, but you if your .war file is named myapp.war, you can set the docBase to myapp.war, do a manager deploy, and it will work fine. It does seem a bit redundant, though, since Tomcat could provide that info itself. I guess I haven't run into an issue with the way things currenly work so this arguable redundancy isn't overly important to me. Jake - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
