Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/authenti cator SingleSignOn.java

[Brian Stansberry]

At 11:02 PM 9/20/2004 +, Jan.Luehe wrote
I've restored the previous version. Maybe
SessionEvent.getData() could have differentiated between session
expiration and session invalidation, so we would not have to determine
the cause of the SESSION_DESTROYED_EVENT by comparing
getLastAccessedTime() and getMaxInactiveInterval()?
It would be great if SessionEvent.getData() could do that.  I looked into it 
a bit and I think the problem would be Session.expire() doesn't take a 
parameter that would allow calling code to indicate whether the expire call 
is due to timeout or an HttpSession.invalidate() call by the application.  I 
expect it would be easy enough to find a way around this for 
StandardSession, but it would break for anyone who for some reason 
implemented Session themselves :(

Thanks much!
Brian
_
STOP MORE SPAM with the new MSN 8 and get 2 months FREE* 
http://join.msn.com/?page=features/junkmail

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] 4.1.31 stability

[Keith Wannamaker]

Hi Kurt, good catch.  I'll fix it and build RC2.
Keith
Kurt Miller wrote:
From: "Keith Wannamaker" <[EMAIL PROTECTED]>
I have uploaded a Tomcat 4.1.31 release canidate to 
http://apache.org/~keith/rc1/


In the binary releases, the servletapi documentation was installed
into /webapps/tomcat-docs/servletapi/api/ instead of
/webapps/tomcat-docs/servletapi/. This breaks the 'Servlet/JSP
Javadocs' link in tomcat-docs.
-Kurt

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/webapps/docs/config host.xml

[luehe]

luehe   2004/09/20 19:08:55

  Modified:webapps/docs/config host.xml
  Log:
  Restored bullet about logout (but not session expiration!) invalidating all sessions 
associated with SingleSignOn entry.
  
  Revision  ChangesPath
  1.11  +6 -0  jakarta-tomcat-catalina/webapps/docs/config/host.xml
  
  Index: host.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/config/host.xml,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- host.xml  20 Sep 2004 18:25:43 -  1.10
  +++ host.xml  21 Sep 2004 02:08:55 -  1.11
  @@ -458,6 +458,12 @@
   utilized for access control decisions across all
   of the associated web applications, without challenging the user
   to authenticate themselves to each application individually.
  +As soon as the user logs out of one web application (for example,
  +by invalidating the corresponding session if form
  +based login is used), the user's sessions in all
  +web applications will be invalidated.  Any subsequent attempt to
  +access a protected resource in any application will require the
  +user to authenticate himself or herself again.
   The Single Sign On feature utilizes HTTP cookies to transmit a token
   that associates each request with the saved user identity, so it can
   only be utilized in client environments that support cookies.
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/authenti cator SingleSignOn.java

[Jan Luehe]

Brian Stansberry wrote:
Hi Jan,

At 11:02 PM 9/20/2004 +, you wrote:
luehe   2004/09/16 11:18:41
 Modified:catalina/src/share/org/apache/catalina/authenticator
   SingleSignOn.java
 Log:
 - Removed deregister(String ssoid), because it is no longer needed
   (used to be called when session was logged out, which is no longer
   supported)
I'm not sure what you meant here by "no longer supported."  Do you 
mean the cross-webapp signout feature that deregister(String ssoid) 
provided, or has there been some more fundamental change in TC's 
handling of HttpSession.invalidate()?

I was referring to the removal of 
javax.servlet.http.HttpSession.logout(),
which had been added temporarily to Servlet 2.4 and was later removed
before the spec went final. See this log entry in the history of
javax.servlet.http.HttpSession:

  revision 1.3
  date: 2003/04/07 21:27:36;  author: jfarcand;  state: Exp;  lines: +0
  -15
  As required by the upcoming Servlet spec 2.4 PFD 3, remove the
  logout() method.
This method was the only method that generated a SessionEvent of
type SESSION_DESTROYED_EVENT with event data equal to "logout", which
used to invalidate all remaining sessions (if any) associated with
the SingleSignOn entry.

The code in sessionEvent() that checked the session's last accessed time 
was intended as a workaround to try to discriminate timeouts from 
intentional logouts after the logout() method was removed from the 
spec.  It was applied as a fix to bug 9077, which complained about the 
SSO valve not invalidating related sessions.  The CVS logs for 
SingleSignOn.java revs 1.7 and 1.11 touch on this and there was also 
some discussion on the dev list last Nov 24.  I'm curious as to why this 
is no longer supported.
OK, my bad. I've restored the previous version. Maybe 
SessionEvent.getData() could have differentiated between session
expiration and session invalidation, so we would not have to determine
the cause of the SESSION_DESTROYED_EVENT by comparing
getLastAccessedTime() and getMaxInactiveInterval()?

In any case, as a result of this, I am going to restore this bullet in 
the Single Sign-On documentation, after removing the part marked by
[REMOVE ...]:

  "As soon as the user logs out of one web application (for example, by
  invalidating [REMOVE: or timing out] the corresponding session if form
  based login is used), the user's sessions in all web applications will
  be invalidated. Any subsequent attempt to access a protected resource
  in any application will require the user to authenticate himself or
  herself again."
Thanks!
Jan


Could a config parameter be added to the valve 
to allow this behavior?

_
STOP MORE SPAM with the new MSN 8 and get 2 months FREE* 
http://join.msn.com/?page=features/junkmail

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] 4.1.31 stability

[Kurt Miller]

From: "Keith Wannamaker" <[EMAIL PROTECTED]>
> I have uploaded a Tomcat 4.1.31 release canidate to 
> http://apache.org/~keith/rc1/
> 

In the binary releases, the servletapi documentation was installed
into /webapps/tomcat-docs/servletapi/api/ instead of
/webapps/tomcat-docs/servletapi/. This breaks the 'Servlet/JSP
Javadocs' link in tomcat-docs.

-Kurt



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/authenticator SingleSignOn.java

[luehe]

luehe   2004/09/20 18:45:12

  Modified:catalina/src/share/org/apache/catalina/authenticator
SingleSignOn.java
  Log:
  Undid previous commit. Code's check of session's last accessed time was intended as 
a workaround to try to discriminate timeouts from intentional logouts after the 
logout() method was removed from the spec.
  
  Revision  ChangesPath
  1.19  +91 -2 
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/authenticator/SingleSignOn.java
  
  Index: SingleSignOn.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/authenticator/SingleSignOn.java,v
  retrieving revision 1.18
  retrieving revision 1.19
  diff -u -r1.18 -r1.19
  --- SingleSignOn.java 16 Sep 2004 18:18:41 -  1.18
  +++ SingleSignOn.java 21 Sep 2004 01:45:12 -  1.19
  @@ -287,10 +287,24 @@
   synchronized (reverse) {
   ssoId = (String) reverse.get(session);
   }
  -if (ssoId == null) {
  +if (ssoId == null)
   return;
  +
  +// Was the session destroyed as the result of a timeout?
  +// If so, we'll just remove the expired session from the
  +// SSO.  If the session was logged out, we'll log out
  +// of all session associated with the SSO.
  +if ((session.getMaxInactiveInterval() > 0)
  +&& (System.currentTimeMillis() - session.getLastAccessedTime() >=
  +session.getMaxInactiveInterval() * 1000)) {
  +removeSession(ssoId, session);
  +} else {
  +// The session was logged out.
  +// Deregister this single session id, invalidating 
  +// associated sessions
  +deregister(ssoId);
   }
  -deregister(ssoId, session);
  +
   }
   
   
  @@ -454,6 +468,46 @@
   
   
   /**
  + * Deregister the specified single sign on identifier, and invalidate
  + * any associated sessions.
  + *
  + * @param ssoId Single sign on identifier to deregister
  + */
  +protected void deregister(String ssoId) {
  +
  +if (container.getLogger().isDebugEnabled())
  +container.getLogger().debug("Deregistering sso id '" + ssoId + "'");
  +
  +// Look up and remove the corresponding SingleSignOnEntry
  +SingleSignOnEntry sso = null;
  +synchronized (cache) {
  +sso = (SingleSignOnEntry) cache.remove(ssoId);
  +}
  +
  +if (sso == null)
  +return;
  +
  +// Expire any associated sessions
  +Session sessions[] = sso.findSessions();
  +for (int i = 0; i < sessions.length; i++) {
  +if (container.getLogger().isTraceEnabled())
  +container.getLogger().trace(" Invalidating session " + sessions[i]);
  +// Remove from reverse cache first to avoid recursion
  +synchronized (reverse) {
  +reverse.remove(sessions[i]);
  +}
  +// Invalidate this session
  +sessions[i].expire();
  +}
  +
  +// NOTE:  Clients may still possess the old single sign on cookie,
  +// but it will be removed on the next request since it is no longer
  +// in the cache
  +
  +}
  +
  +
  +/**
* Attempts reauthentication to the given Realm using
* the credentials associated with the single sign-on session
* identified by argument ssoId.
  @@ -582,4 +636,39 @@
   }
   
   }
  +
  +
  +/**
  + * Remove a single Session from a SingleSignOn.  Called when
  + * a session is timed out and no longer active.
  + *
  + * @param ssoId Single sign on identifier from which to remove the session.
  + * @param session the session to be removed.
  + */
  +protected void removeSession(String ssoId, Session session) {
  +
  +if (container.getLogger().isDebugEnabled())
  +container.getLogger().debug("Removing session " + session.toString() + 
" from sso id " + 
  +ssoId );
  +
  +// Get a reference to the SingleSignOn
  +SingleSignOnEntry entry = lookup(ssoId);
  +if (entry == null)
  +return;
  +
  +// Remove the inactive session from SingleSignOnEntry
  +entry.removeSession(session);
  +
  +// Remove the inactive session from the 'reverse' Map.
  +synchronized(reverse) {
  +reverse.remove(session);
  +}
  +
  +// If there are not sessions left in the SingleSignOnEntry,
  +// deregister the entry.
  +if (entry.findSessions().length == 0) {
  +deregister(ssoId);
  +}
  +}
  +
   }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional comm

Document

[mmanders]

--  Virus Warning Message (on uusnwa0p)

Found virus WORM_NETSKY.Z in file Details.txt  
   
.exe (in Details.zip)
The file is deleted.

-
Important details!


--  Virus Warning Message (on uusnwa0p)

Details.zip is removed from here because it contains a virus.

-
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31304] - NoClassDefFoundError: org/apache/commons/collections/CursorableLinkedList

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31304

NoClassDefFoundError: org/apache/commons/collections/CursorableLinkedList





--- Additional Comments From [EMAIL PROTECTED]  2004-09-21 00:01 ---
Yoav,

All that was added was the mysql-connector JAR to common/lib and a session
counting listener to common/classes. Both WEB-INF/lib and WEB-INF/classes are empty.

--- # jar tf common/lib/commons-collections-3.1.jar ---

org/apache/commons/collections/CursorableLinkedList$Listable.class
org/apache/commons/collections/CursorableLinkedList$ListIter.class
org/apache/commons/collections/CursorableLinkedList$Cursor.class
org/apache/commons/collections/CursorableLinkedList.class

So yes it exists in mine as well. To be expected really since I haven't modified
anything.

--- context config ---

  
  

  url
  jdbc:mysql://dev:3306/test?autoReconnect=true


  validationQuery
  select id, foo, bar from testdata


  maxIdle
  5


  maxActive
  100


  driverClassName
  com.mysql.jdbc.Driver


  maxWait
  1


  removeAbandoned
  true


  factory
  org.apache.commons.dbcp.BasicDataSourceFactory


  username
  test


  logAbandoned
  true


  removeAbandonedTimeout
  60


  password
  test

  

--- WEB-INF/web.xml ---


  
DB Connection Pool
  
  
jdbc/test
  
  
javax.sql.DataSource
  
  
Container
  


--- test JSP ---

<%@ page import="java.sql.*,
 javax.naming.Context,
 javax.naming.InitialContext,
 javax.sql.DataSource"%>
<%
  Context initContext = new InitialContext();
  Context envContext  = (Context)initContext.lookup("java:/comp/env");
  DataSource ds = (DataSource)envContext.lookup("jdbc/test");
  Statement stmt = null;
  ResultSet rs = null;
  Connection conn = null;
  if (ds != null) {
  try {
conn = ds.getConnection();
stmt = conn.createStatement();
rs = stmt.executeQuery("select id, foo, bar from testdata");
while (rs.next()) {
   %>id: <%= rs.getInt("id") %>, foo: <%= rs.getString("foo") %>, bar: <%=
rs.getInt("bar") %><%
}
rs.close();
rs = null;
stmt.close();
stmt = null;
conn.close();
conn = null;
  } catch (SQLException e) { ; } finally {
if (rs != null) {
  try { rs.close(); } catch (SQLException e) { ; }
  rs = null;
}
if (stmt != null) {
  try { stmt.close(); } catch (SQLException e) { ; }
  stmt = null;
}
if (conn != null) {
  try { conn.close(); } catch (SQLException e) { ; }
  conn = null;
}
  }
  } else {
  %> DataSource is null <%
  }
%>

I also have a page that performs the same function but by going directly using
the same settings i.e. Class.forName ... etc ...

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 4690] - sessions not scoped according to spec section 7.3

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=4690

sessions not scoped according to spec section 7.3





--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 23:37 ---
I would also object.  The Portlet Specification depends upon cross context
functionality working properly and there have been several complaints on the
Pluto user and dev lists about this.  I'm pretty sure that the underlying
problem is in tomcat and not in pluto.  

As I stated before, the fix seems to be implemented halfway.  The session which
is passed to the target context is now unique, however, it is not permenantly
associated with the context and thus can't be retrieved during future requests.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/authenti cator SingleSignOn.java

[Brian Stansberry]

Hi Jan,

At 11:02 PM 9/20/2004 +, you wrote:
luehe   2004/09/16 11:18:41
 Modified:catalina/src/share/org/apache/catalina/authenticator
   SingleSignOn.java
 Log:
 - Removed deregister(String ssoid), because it is no longer needed
   (used to be called when session was logged out, which is no longer
   supported)
I'm not sure what you meant here by "no longer supported."  Do you mean 
the cross-webapp signout feature that deregister(String ssoid) provided, 
or has there been some more fundamental change in TC's handling of 
HttpSession.invalidate()?
I was referring to the removal of javax.servlet.http.HttpSession.logout(),
which had been added temporarily to Servlet 2.4 and was later removed
before the spec went final. See this log entry in the history of
javax.servlet.http.HttpSession:
  revision 1.3
  date: 2003/04/07 21:27:36;  author: jfarcand;  state: Exp;  lines: +0
  -15
  As required by the upcoming Servlet spec 2.4 PFD 3, remove the
  logout() method.
This method was the only method that generated a SessionEvent of
type SESSION_DESTROYED_EVENT with event data equal to "logout", which
used to invalidate all remaining sessions (if any) associated with
the SingleSignOn entry.
The code in sessionEvent() that checked the session's last accessed time was 
intended as a workaround to try to discriminate timeouts from intentional 
logouts after the logout() method was removed from the spec.  It was applied 
as a fix to bug 9077, which complained about the SSO valve not invalidating 
related sessions.  The CVS logs for SingleSignOn.java revs 1.7 and 1.11 
touch on this and there was also some discussion on the dev list last Nov 
24.  I'm curious as to why this is no longer supported.  Could a config 
parameter be added to the valve to allow this behavior?

_
STOP MORE SPAM with the new MSN 8 and get 2 months FREE* 
http://join.msn.com/?page=features/junkmail

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 4690] - sessions not scoped according to spec section 7.3

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=4690

sessions not scoped according to spec section 7.3





--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 22:45 ---
I was the original poster and I obviously haven't been waiting 3 years hoping it
will be fixed and I am less dependent on the cross-context behavior now than I
was then.  I simply filed the issue as a failure in the reference implementation
to meet the specification.  

But there are others who are still suffering from this problem and many dupes
were filed as well.  Remy indicates that it should have been fixed, but it
appears there is still a bug.  The problem in Tomcat 4.x was deep in the
architecture, but  it sounds like a solution is closer at hand now, it would
seem a shame to declare it a WONTFIX, if the current bug turns out to be simple.

Resetting this to Tomcat 4 and declaring it WONTFIX while also entering a more
specific defect report in Tomcat 5 might be a reasonable route though.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[GUMP@brutus]: jakarta-tomcat-4.0/jakarta-tomcat-4.0 failed

[Stefan Bodewig]

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact folk at [EMAIL PROTECTED]

Project jakarta-tomcat-4.0 has an issue affecting its community integration.
This issue affects 1 projects.
Project State : 'Failed'
The following are affected:
- jakarta-tomcat-4.0 :  Servlet 2.3 and JSP 1.2 Reference Implementation


Full details are available at:


http://brutus.apache.org/gump/public/jakarta-tomcat-4.0/jakarta-tomcat-4.0/index.html

That said, some snippets follow:


The following annotations were provided:
 -DEBUG- Jar [naming-resources.jar] identifier set to jar basename: [naming-resources]
 -DEBUG- Jar [servlets-default.jar] identifier set to jar basename: [servlets-default]
 -DEBUG- Jar [naming-common.jar] identifier set to jar basename: [naming-common]
 -DEBUG- Jar [catalina.jar] identifier set to jar basename: [catalina]
 -DEBUG- Jar [bootstrap.jar] identifier set to jar basename: [bootstrap]
 -DEBUG- Jar [servlets-common.jar] identifier set to jar basename: [servlets-common]
 -DEBUG- Jar [servlets-invoker.jar] identifier set to jar basename: [servlets-invoker]
 -DEBUG- Dependency on javamail exists, no need to add for property mail.jar.
 -DEBUG- Dependency on jaf exists, no need to add for property activation.jar.
 -DEBUG- Dependency on jmx exists, no need to add for property jmx.jar.
 -DEBUG- Dependency on jakarta-servletapi-4 exists, no need to add for property 
servlet.jar.
 -DEBUG- Dependency on xml-xerces exists, no need to add for property xerces.jar.
 -DEBUG- Dependency on jakarta-tomcat-util exists, no need to add for property 
tomcat-util.jar.
 -DEBUG- Dependency on commons-logging exists, no need to add for property 
commons-logging-api.jar.
 -DEBUG- Dependency on ant exists, no need to add for property ant.home.
 -DEBUG- Dependency on jakarta-servletapi-4 exists, no need to add for property 
servlet.home.
 -DEBUG- Dependency on jsse exists, no need to add for property jsse.home.
 -DEBUG- Dependency on jmx exists, no need to add for property jmx.home.
 -DEBUG- Dependency on jmx exists, no need to add for property jmxtools.jar.
 -DEBUG- Dependency on jndi exists, no need to add for property jndi.home.
 -DEBUG- Dependency on jakarta-regexp exists, no need to add for property regexp.home.
 -DEBUG- Dependency on jakarta-regexp exists, no need to add for property regexp.jar.
 -DEBUG- Dependency on javamail exists, no need to add for property mail.home.
 -DEBUG- Dependency on jakarta-tomcat-coyote exists, no need to add for property 
tomcat-coyote.home.
 -DEBUG- Dependency on jaf exists, no need to add for property activation.home.
 -WARNING- Bad *Optional* Dependency. Project: avalon unknown to *this* workspace
 -INFO- Optional dependency avalon-phoenix prerequisite failed with reason build failed
 -INFO- Failed with reason build failed
 -DEBUG- Extracted fallback artifacts from Gump Repository


The following work was performed:
http://brutus.apache.org/gump/public/jakarta-tomcat-4.0/jakarta-tomcat-4.0/gump_work/build_jakarta-tomcat-4.0_jakarta-tomcat-4.0.html
Work Name: build_jakarta-tomcat-4.0_jakarta-tomcat-4.0 (Type: Build)
State: Failed
Elapsed: 8 secs
Command Line: java -Djava.awt.headless=true 
-Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/java/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-xerces2/java/build/xml-apis.jar:/usr/local/gump/public/workspace/xml-xalan/java/build/xalan-unbundled.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar
 org.apache.tools.ant.Main -Dgump.merge=/usr/local/gump/public/gump/work/merge.xml 
-Dbuild.sysclasspath=only -Djmx.jar=/usr/local/gump/packages/jmx-1_2-ri/lib/jmxri.jar 
-Djmx.home=/usr/local/gump/packages/jmx-1_2-ri 
-Djdbc20ext.jar=/usr/local/gump/packages/jdbc2_0/jdbc2_0-stdext.jar 
-Dregexp.jar=/usr/local/gump/public/workspace/jakarta-regexp/build/jakarta-regexp-20092004.jar
 -Dmail.home=/usr/local/gump/packages/javamail-1.3 
-Dant.home=/usr/local/gump/public/workspace/ant/dist 
-Dservlet.jar=/usr/local/gump/public/workspace/jakarta-servletapi-4/lib/servlet.jar 
-Dsite2.home=/usr/local/gump/public/workspace/jakarta-site2 
-Dxerces.jar=/usr/local/gump/public/workspace/xml-xerces2/java/build/xercesImpl.jar 
-Dcommons-collections.jar=/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-20092004.jar
 -Dldap.jar=/usr/local/gump/packages/ldap-1_2_4/lib/ldap.jar 
-Djsse.home=/usr/local/gump/packages/jsse1.0.3 
-Djaas.jar=/usr/local/gump/packages/jaas1_0/lib/jaas.jar 
-Dmail.jar=/usr/local/gump/packages/javamail-1.3/mail.jar 
-Dcommons-digester.jar=/usr/local/gump/public/workspace/jakarta-commons/digester/dist/commons-digester.jar
 -Djndi.jar=/usr/local/gump/packages/jndi1_2_1/lib/jndi.jar 
-Djmxtools.jar=/usr/local/gump/packages/jmx-1_2-ri/lib/jmxtools.jar 
-Dactivation.home=/usr/local/gump/packages/jaf-1.0.1 
-Dregexp.home=/usr/l

[GUMP@brutus]: jakarta-tomcat-jasper_tc5/jakarta-tomcat-jasper_tc5 success

[bobh]

To whom it may satisfy...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact folk at [EMAIL PROTECTED]

Project jakarta-tomcat-jasper_tc5 *no longer* has an issue.
Project State : 'Success', Reason ''

Full details are available at:


http://brutus.apache.org/gump/public/jakarta-tomcat-jasper_tc5/jakarta-tomcat-jasper_tc5/index.html

That said, some snippets follow:


The following annotations were provided:
 -DEBUG- Jar [jasper-runtime.jar] identifier set to jar basename: [jasper-runtime]
 -DEBUG- Jar [jasper-compiler.jar] identifier set to jar basename: [jasper-compiler]
 -INFO- No license on redistributable project with outputs.


The following work was performed:
http://brutus.apache.org/gump/public/jakarta-tomcat-jasper_tc5/jakarta-tomcat-jasper_tc5/gump_work/build_jakarta-tomcat-jasper_tc5_jakarta-tomcat-jasper_tc5.html
Work Name: build_jakarta-tomcat-jasper_tc5_jakarta-tomcat-jasper_tc5 (Type: Build)
State: Success
Elapsed: 5 secs
Command Line: java -Djava.awt.headless=true 
-Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/java/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-xerces2/java/build/xml-apis.jar
 org.apache.tools.ant.Main -Dgump.merge=/usr/local/gump/public/gump/work/merge.xml 
-Dbuild.sysclasspath=only 
-Djsp-api.jar=/usr/local/gump/public/workspace/jakarta-servletapi-5/jsr152/dist/lib/jsp-api.jar
 
-Dcommons-el.jar=/usr/local/gump/public/workspace/jakarta-commons/el/dist/commons-el.jar
 
-Djasper-compiler-jdt.jar=/usr/local/gump/packages/eclipse-3.0.1/plugins/org.eclipse.jdt.core_3.0.1/jdtcore.jar
 -Dant.jar=/usr/local/gump/public/workspace/ant/dist/lib/ant.jar 
-Dservlet-api.jar=/usr/local/gump/public/workspace/jakarta-servletapi-5/jsr154/dist/lib/servlet-api.jar
 -Dcompile.source=1.4 dist 
[Working Directory: /usr/local/gump/public/workspace/jakarta-tomcat-jasper_tc5/jasper2]
CLASSPATH : 
/usr/local/j2sdk1.4.2_04/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-api.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-stylebook.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/el/dist/commons-el.jar:/usr/local/gump/public/workspace/jakarta-servletapi-5/jsr154/dist/lib/servlet-api.jar:/usr/local/gump/public/workspace/jakarta-servletapi-5/jsr152/dist/lib/jsp-api.jar:/usr/local/gump/packages/eclipse-3.0.1/plugins/org.eclipse.jdt.core_3.0.1/jdtcore.jar-
Buildfile: build.xml

build-prepare:
[mkdir] Created dir: 
/usr/local/gump/public/workspace/jakarta-tomcat-jasper_tc5/jasper2/build
[mkdir] Created dir: 
/usr/local/gump/public/workspace/jakarta-tomcat-jasper_tc5/jasper2/build/bin
[mkdir] Created dir: 
/usr/local/gump/public/workspace/jakarta-tomcat-jasper_tc5/jasper2/build/common/classes
[mkdir] Created dir: 
/usr/local/gump/public/workspace/jakarta-tomcat-jasper_tc5/jasper2/build/common/lib
[mkdir] Created dir: 
/usr/local/gump/public/workspace/jakarta-tomcat-jasper_tc5/jasper2/build/shared/classes
[mkdir] Created dir: 
/usr/local/gump/public/workspace/jakarta-tomcat-jasper_tc5/jasper2/build/shared/lib

copy-launcher.jars:

build-static:
 [copy] Copying 4 files to 
/usr/local/gump/public/workspace/jakarta-tomcat-jasper_tc5/jasper2/build/bin

build-only:
[javac] Compiling 82 source files to 
/usr/local/gump/public/workspace/jakarta-tomcat-jasper_tc5/jasper2/build/shared/classes
[javac] Note: 
/usr/local/gump/public/workspace/jakarta-tomcat-jasper_tc5/jasper2/src/share/org/apache/jasper/servlet/JspServletWrapper.java
 uses or overrides a deprecated API.
[javac] Note: Recompile with -deprecation for details.
 [copy] Copying 4 files to 
/usr/local/gump/public/workspace/jakarta-tomcat-jasper_tc5/jasper2/build/shared/classes
  [jar] Building jar: 
/usr/local/gump/public/workspace/jakarta-tomcat-jasper_tc5/jasper2/build/shared/lib/jasper-compiler.jar
  [jar] Building jar: 
/usr/local/gump/public/workspace/jakarta-tomcat-jasper_tc5/jasper2/build/shared/lib/jasper-runtime.jar

build-main:
 [copy] Copying 1 file to 
/usr/local/gump/public/workspace/jakarta-tomcat-jasper_tc5/jasper2/build/shared/lib

dist:
[mkdir] Created dir: 
/usr/local/gump/public/workspace/jakarta-tomcat-jasper_tc5/jasper2/dist/bin
 [copy] Copying 4 files to 
/usr/local/gump/public/workspace/jakarta-tomcat-jasper_tc5/jasper2/dist/bin
[mkdir] Created dir: 
/

DO NOT REPLY [Bug 31232] - response.encodeURL() not encoding URL when mix of cookies and URL rewriting

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31232

response.encodeURL() not encoding URL when mix of cookies and URL rewriting





--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 21:26 ---
forgot to mention that for the workaround of forcing users to use URL rewriting 
for the members section that this goes back to the usual debate of URL 
rewriting vs. cookies where if the user navigates away from the site and comes 
back then the URL rewritten session is gone.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31316] - Tomcat 5 rejects

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31316

Tomcat 5 rejects 

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WORKSFORME



--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 21:22 ---
I think you got the valid and invliad cases reversed.

You'll get this error iff there are white spaces between  and
.  The reason why this is an error is explained in
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25448

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Bugzilla 30936: secure attribute is persisted twice

[Peter Rossbach]

Hey,
we have many duplicate attributes at connector and protocolhandler classes-
I have spent a lot of time to fix that at my new server.xml/context.xml 
storage
module.
  Current design based on factory model with external description file 
to handle those issues.
  Very strange, but my only chance to implement the handler, without 
break the current codebase.

We must refactor the Connector/Protocoll class to make a clear cut,
between old and correct attributes. We drop maxProcessors and 
minProcessors attributes as example.

My current questions are:
Why we handle all connectors attributes as real class attributes
and dymamic properties?
Can we drop the attribute translation between Connector and 
ProtocolHandler?

Regards
Peter
PS: I am waiting to get cvs write access
Shapira, Yoav schrieb:
Hi,
 

I'm going to wait for Peter for save-to-XML rewriting, before bothering
with fixing the various issues.
(right now, saving data sources needs to be redone as well)
   

I contemplated that, but it seems that here the core problem is not the
persisting itself: it's the duplication of attributes.  Even if the XML
persistence issue is fixed soon (I have faith ;)), it'll be hackish to
have it check the buffer to see if an attribute has been persisted, and
only persist it if not.  It's an OK fix, but doesn't address the core
issue in this particular case, does it? ;)
Yoav

This e-mail, including any attachments, is a confidential business communication, and 
may contain information that is confidential, proprietary and/or privileged.  This 
e-mail is intended only for the individual(s) to whom it is addressed, and may not be 
saved, copied, printed, disclosed or used by anyone else.  If you are not the(an) 
intended recipient, please immediately delete this e-mail from your computer system 
and notify the sender.  Thank you.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31232] - response.encodeURL() not encoding URL when mix of cookies and URL rewriting

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31232

response.encodeURL() not encoding URL when mix of cookies and URL rewriting





--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 21:02 ---
Our use case is that our system is half web-based and half applet based. The 
applets communicate with our servlets, setup sessions, redirect users to 
various web pages. All this has to be done through URL rewriting because the 
cookie caches aren't shared between broswer and the applet. This is in the /sub 
context.

Now we have a members section that is cookie based on the root context. We 
tried linking some features of the members section into the applet so it's 
accessible in the applet. But whenever the user goes to the member section all 
access to the /sub is "screwed up" like how I mentioned before: the URL 
rewriting in the sub context doesn't take because of the cookie at the root 
context.

Lets see workaround for us...
1) rewrite our site to use URL rewriting instead of cookies.
2) move members ares to a separate /sub2 context. Can't do that because they 
still access pages from /


But use case aside, it just seems like a bug: I specify that the /sub context 
is not to use cookies (force URL rewriting) and it's not using the session ID 
given on the URL because the root context uses cookies. I would it expect it 
use URL rewriting instead of not being able to use anything.

I don't know if there is a spec covering URL-rewriting so I can't refer to 
anything other than it being vendor specific.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31316] - Tomcat 5 rejects

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31316

Tomcat 5 rejects 





--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 20:35 ---
It fails in the same way even if the  appears on a separate line.

But even if this workaround had worked, the change in behavior is still
surprising and would still be problematic for people porting apps.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31292] - provide better error message for "Unable to find setter method for attribute: name"

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31292

provide better error message for "Unable to find setter method for attribute: name"

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
Version|5.0.0   |5.0.24



--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 20:09 ---
no, I am using 5.0.24 or even 5.0.27 and you are right the error message is the
one you cite, just in the pre 1.2.dtd of struts, a form object had an attribute
named "name".

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 29727] - JNDI env-entry not reload when context reloaded

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=29727

JNDI env-entry not reload when context reloaded





--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 19:51 ---
I have posted the war file. I ran the test against 5.0.28 - no change, problem 
still exists. Thanks for looking into this.

To test:

install war in server

browse to //listenv.jsp

-  the current value of the env-entry should be displayed

change the web.xml env-entry using some text editor.

reload the context, or allow tomcat to auto reload on change.

browse to //listenv.jsp (refresh needs to be performed)

-  the OLD value is still displayed

change the env-entry using the tomcat 'admin' web interface. post changes.

browse to //listenv.jsp (refresh needs to be performed)

-  the NEW value is still displayed

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 29727] - JNDI env-entry not reload when context reloaded

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=29727

JNDI env-entry not reload when context reloaded





--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 19:46 ---
Created an attachment (id=12809)
war file to demonstrate env-entry problem

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31308] - Tomcat ignores precompiled JSP if JSP file is a welcome-file

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31308

Tomcat ignores precompiled JSP if JSP file is a welcome-file

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 19:40 ---
Crystal clear ( /jspctest.jsp ). You should have
posted on tomcat-user about this "bug" first.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31308] - Tomcat ignores precompiled JSP if JSP file is a welcome-file

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31308

Tomcat ignores precompiled JSP if JSP file is a welcome-file

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |



--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 19:27 ---
Please find three file attached:  
build.xml 
web.xml 
jspctest.jsp 
 
Here's how to reproduce the bug; 
1) Create a directory called jspctest. This directory 
   must NOT be under the $CATALINA_HOME directory. 
 
2) Copy the three attached files to jspctest. 
 
3) Edit build.xml and set the properties to suit your environment. 
 
4) type "ant deploy" to deploy the app. 
 
5) Open a console window cd to 
$CATALINA_HOME/work/Catalina/localhost/jspctest. 
 
6) Open a web browser and go to http://localhost:8080/jspctest/jspctest.jsp 
 
7) In the console window created in step 5, type "find .". The only files 
   which should appear are: 
. 
./tldCache.ser 
 
 
8) Repeat step 6, but change the URL to  
   ttp://localhost:8080/jspctest/ 
 
9) Repeat step 7. You should now see the additional files 
   ./org/apache/jsp/jspctest_jsp.java 
   ./org/apache/jsp/jspctest_jsp.class 
   which should not be created. 
 
 
I hope this all makes the issue clear.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31308] - Tomcat ignores precompiled JSP if JSP file is a welcome-file

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31308

Tomcat ignores precompiled JSP if JSP file is a welcome-file





--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 19:11 ---
Created an attachment (id=12807)
jspctest.jsp example JSP

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31308] - Tomcat ignores precompiled JSP if JSP file is a welcome-file

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31308

Tomcat ignores precompiled JSP if JSP file is a welcome-file





--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 19:10 ---
Created an attachment (id=12806)
web.xml file

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31308] - Tomcat ignores precompiled JSP if JSP file is a welcome-file

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31308

Tomcat ignores precompiled JSP if JSP file is a welcome-file





--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 19:10 ---
Created an attachment (id=12805)
build.xml file

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: Bugzilla 30936: secure attribute is persisted twice

[Shapira, Yoav]

Hi,

>I'm going to wait for Peter for save-to-XML rewriting, before bothering
>with fixing the various issues.
>(right now, saving data sources needs to be redone as well)

I contemplated that, but it seems that here the core problem is not the
persisting itself: it's the duplication of attributes.  Even if the XML
persistence issue is fixed soon (I have faith ;)), it'll be hackish to
have it check the buffer to see if an attribute has been persisted, and
only persist it if not.  It's an OK fix, but doesn't address the core
issue in this particular case, does it? ;)

Yoav



This e-mail, including any attachments, is a confidential business communication, and 
may contain information that is confidential, proprietary and/or privileged.  This 
e-mail is intended only for the individual(s) to whom it is addressed, and may not be 
saved, copied, printed, disclosed or used by anyone else.  If you are not the(an) 
intended recipient, please immediately delete this e-mail from your computer system 
and notify the sender.  Thank you.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Bugzilla 30936: secure attribute is persisted twice

[Remy Maucherat]

Shapira, Yoav wrote:
Hi,
I'm looking at http://issues.apache.org/bugzilla/show_bug.cgi?id=30936.
The "secure" attribute is persisted twice, causing a Digester error,
because it's an attribute of both the Connector itself and its
ProtocolHandler.
The simplest fix seems to be to remove one these attributes.  It seems
fairly easy to remove the one from connector.  We'd retain the getSecure
and setSecure methods and make them pass through to the ProtocolHandler.
The getSecure/setSecure methods from the Http11Protocol would need to be
added to the ProtocolHandler interface I would think.  Does this fix
seem OK?
I'm going to wait for Peter for save-to-XML rewriting, before bothering 
with fixing the various issues.
(right now, saving data sources needs to be redone as well)

Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31316] - Tomcat 5 rejects

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31316

Tomcat 5 rejects 





--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 18:58 ---
I believe this has been raised at least once in the past, and the response was 
that you have to have a new line between the start and end jsp:include tags, 
i.e.
 is a no-no, but


is OK.  Try the latter and let us know.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 4690] - sessions not scoped according to spec section 7.3

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=4690

sessions not scoped according to spec section 7.3





--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 18:56 ---
There have been two Servlet Spec versions and many more Tomcat versions since 
this bug was originally filed.  Does this still matter to anyone, or at least 
to the original poster?

Is the latest Servlet Spec (v2.4) clear on this issue?  How is it handled in 
the latest stable Tomcat (5.0.28 at the time of this writing)?  Who would 
object if this issue is closed as WONTFIX, since that's been the effective 
status for a year now?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 25055] - bypass of apache authentication

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=25055

bypass of apache authentication





--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 18:56 ---
Since the problem seems to lay inside Apache hooks, I spent some time to explore
hooks configuration in Apache 2 mod_jk2/mod_jk modules. 

This is the piece of code involved

static void jk2_register_hooks(apr_pool_t * p)
{
ap_hook_handler(jk2_handler, NULL, NULL, APR_HOOK_MIDDLE);
ap_hook_post_config(jk2_post_config, NULL, NULL, APR_HOOK_MIDDLE);

/* Force the mpm to run before us and set the scoreboard image */
ap_hook_child_init(jk2_child_init, NULL, NULL, APR_HOOK_LAST);

ap_hook_translate_name(jk2_translate, NULL, NULL, APR_HOOK_MIDDLE);
ap_hook_map_to_storage(jk2_map_to_storage, NULL, NULL, APR_HOOK_MIDDLE);
}

I see nothing about authentication in this. Furthermore,  I don't see where
htaccess handling takes place inside Apache 2 request processing. If anyone has
any idea on how to configure modjk for Apache2, please let us know.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31316] New: - Tomcat 5 rejects

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31316

Tomcat 5 rejects 

   Summary: Tomcat 5 rejects 
   Product: Tomcat 5
   Version: 5.0.28
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Servlet & JSP API
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


In porting an app from Tomcat 4.1.30 to Tomcat 5.0.28 we discovered
that the following JSP text no longer works:



It throws a JasperException:

org.apache.jasper.JasperException: /index.jsp(374,0) Expecting
"jsp:param" standard action with "name" and "value" attributes

unless the text is changed to



The change in behavior seems to violate the old (1.2) and new (2.0) JSP
specs, which both say:

A jsp:include action may have jsp:param subelements that can
provide values for some parameters in the request to be used for
the inclusion.

i.e. it *may* have  subelements (it doesn't insist on
them).

Even the syntax description (on page 1-110 of the 2.0 spec) explicitly
permits omitting  when opening and closing jsp:include tags
are used instead of :


{  }*


In any case the change in behavior is problematic for people porting
applications.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Bugzilla 30936: secure attribute is persisted twice

[Shapira, Yoav]

Hi,
I'm looking at http://issues.apache.org/bugzilla/show_bug.cgi?id=30936.
The "secure" attribute is persisted twice, causing a Digester error,
because it's an attribute of both the Connector itself and its
ProtocolHandler.

The simplest fix seems to be to remove one these attributes.  It seems
fairly easy to remove the one from connector.  We'd retain the getSecure
and setSecure methods and make them pass through to the ProtocolHandler.
The getSecure/setSecure methods from the Http11Protocol would need to be
added to the ProtocolHandler interface I would think.  Does this fix
seem OK?

Yoav Shapira
Millennium Research Informatics





This e-mail, including any attachments, is a confidential business communication, and 
may contain information that is confidential, proprietary and/or privileged.  This 
e-mail is intended only for the individual(s) to whom it is addressed, and may not be 
saved, copied, printed, disclosed or used by anyone else.  If you are not the(an) 
intended recipient, please immediately delete this e-mail from your computer system 
and notify the sender.  Thank you.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31292] - provide better error message for "Unable to find setter method for attribute: name"

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31292

provide better error message for "Unable to find setter method for attribute: name"

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Normal  |Enhancement
   Priority|Other   |Low



--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 18:36 ---
What version are you using?  Not 5.0.0 I imagine.  Anyways, it looks like a 
better message should already be coming at you: the error code 
of "jsp.error.unable.to_find_method" is correctly passed to ErrorDispatcher, 
which would look it up using the Localizer, and in LocalStrings.properties, the 
message is
jsp.error.unable.to_find_method=Unable to find setter method for attribute: {0}

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31277] - Applciation deployed twice after restart if path doesn't match war filename

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31277

Applciation deployed twice after restart if path doesn't match war filename

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 18:31 ---
OK, doc clarified (for 5.0.29 and 5.5.3).

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/webapps/docs/config host.xml

[yoavs]

yoavs   2004/09/20 11:29:06

  Modified:webapps/docs Tag: TOMCAT_5_0 changelog.xml
   webapps/docs/config Tag: TOMCAT_5_0 host.xml
  Log:
  Bugzilla 31277: clarified Automatic Application Deployment doc a bit.
  
  Revision  ChangesPath
  No   revision
  No   revision
  1.70.2.38 +3 -0  jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.70.2.37
  retrieving revision 1.70.2.38
  diff -u -r1.70.2.37 -r1.70.2.38
  --- changelog.xml 20 Sep 2004 18:07:21 -  1.70.2.37
  +++ changelog.xml 20 Sep 2004 18:29:05 -  1.70.2.38
  @@ -76,6 +76,9 @@
 
   30869: Make sure JAAS realm name is legal. (yoavs)
 
  +   
  +31277: Clarified automatic application deployment section of 
Host configuration page. (yoavs) 
  +   
   
 
 
  
  
  
  No   revision
  No   revision
  1.6.2.1   +9 -1  jakarta-tomcat-catalina/webapps/docs/config/host.xml
  
  Index: host.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/config/host.xml,v
  retrieving revision 1.6
  retrieving revision 1.6.2.1
  diff -u -r1.6 -r1.6.2.1
  --- host.xml  23 Dec 2003 16:50:17 -  1.6
  +++ host.xml  20 Sep 2004 18:29:05 -  1.6.2.1
  @@ -8,6 +8,8 @@
   
 
   Craig R. McClanahan
  +Remy Maucherat 
  +Yoav Shapira 
   The Host Container
 
   
  @@ -275,7 +277,8 @@
   be the absolute pathname to a web application directory, or the
   absolute pathname of a web application archive (WAR) file (which
   will not be expanded).
  -Any web application archive file that does not have a corresponding
  +Any web application archive file within the application base (appBase) 
  +directory that does not have a corresponding
   directory of the same name (without the ".war" extension) will be
   automatically expanded, unless the unpackWARs property
   is set to false.  If you redeploy an updated WAR file,
  @@ -320,6 +323,11 @@
   appBase directory. If this is not the case difficulties
   may be experienced deploying the web application or the application may
   be deployed twice.
  +
  +Finally, note that if you are defining contexts explicitly, you should 
  +probably turn off automatic application deployment.  Otherwise, your context 
  +will be deployed twice each, and that may cause problems for your app. 
  + 
   
 
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler SmapUtil.java

[amyroh]

amyroh  2004/09/20 11:27:09

  Modified:jasper2/src/share/org/apache/jasper/compiler SmapUtil.java
  Log:
  Do not use log(String) helper method since unnecessary Sting parameters
  will be created without the log.isDebugEnabled() condition.
  
  Thanks Remy and Paul for catching this.
  
  Revision  ChangesPath
  1.26  +28 -19
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/SmapUtil.java
  
  Index: SmapUtil.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/SmapUtil.java,v
  retrieving revision 1.25
  retrieving revision 1.26
  diff -u -r1.25 -r1.26
  --- SmapUtil.java 20 Sep 2004 17:51:28 -  1.25
  +++ SmapUtil.java 20 Sep 2004 18:27:09 -  1.26
  @@ -284,7 +284,8 @@
   copy(4 + 2 + 2); // magic min/maj version
   int constantPoolCountPos = genPos;
   int constantPoolCount = readU2();
  -log("constant pool count: " + constantPoolCount);
  +if (log.isDebugEnabled())
  +log.debug("constant pool count: " + constantPoolCount);
   writeU2(constantPoolCount);
   
   // copy old constant pool return index of SDE symbol, if found
  @@ -298,27 +299,32 @@
   ++constantPoolCount;
   randomAccessWriteU2(constantPoolCountPos, constantPoolCount);
   
  -log("SourceDebugExtension not found, installed at: " + sdeIndex);
  +if (log.isDebugEnabled())
  +log.debug("SourceDebugExtension not found, installed at: " + 
sdeIndex);
   } else {
  -log("SourceDebugExtension found at: " + sdeIndex);
  +if (log.isDebugEnabled())
  +log.debug("SourceDebugExtension found at: " + sdeIndex);
   }
   copy(2 + 2 + 2); // access, this, super
   int interfaceCount = readU2();
   writeU2(interfaceCount);
  -log("interfaceCount: " + interfaceCount);
  +if (log.isDebugEnabled())
  +log.debug("interfaceCount: " + interfaceCount);
   copy(interfaceCount * 2);
   copyMembers(); // fields
   copyMembers(); // methods
   int attrCountPos = genPos;
   int attrCount = readU2();
   writeU2(attrCount);
  -log("class attrCount: " + attrCount);
  +if (log.isDebugEnabled())
  +log.debug("class attrCount: " + attrCount);
   // copy the class attributes, return true if SDE attr found (not copied)
   if (!copyAttrs(attrCount)) {
   // we will be adding SDE and it isn't already counted
   ++attrCount;
   randomAccessWriteU2(attrCountPos, attrCount);
  -log("class attrCount incremented");
  +if (log.isDebugEnabled())
  +log.debug("class attrCount incremented");
   }
   writeAttrForSDE(sdeIndex);
   }
  @@ -326,12 +332,14 @@
   void copyMembers() {
   int count = readU2();
   writeU2(count);
  -log("members count: " + count);
  +if (log.isDebugEnabled())
  +log.debug("members count: " + count);
   for (int i = 0; i < count; ++i) {
   copy(6); // access, name, descriptor
   int attrCount = readU2();
   writeU2(attrCount);
  -log("member attr count: " + attrCount);
  +if (log.isDebugEnabled())
  +log.debug("member attr count: " + attrCount);
   copyAttrs(attrCount);
   }
   }
  @@ -343,13 +351,15 @@
   // don't write old SDE
   if (nameIndex == sdeIndex) {
   sdeFound = true;
  -log("SDE attr found");
  +if (log.isDebugEnabled())
  +log.debug("SDE attr found");
   } else {
   writeU2(nameIndex); // name
   int len = readU4();
   writeU4(len);
   copy(len);
  -log("attr len: " + len);
  +if (log.isDebugEnabled())
  +log.debug("attr len: " + len);
   }
   }
   return sdeFound;
  @@ -428,7 +438,8 @@
   switch (tag) {
   case 7 : // Class
   case 8 : // String
  -log(i + " copying 2 bytes");
  +if (log.isDebugEnabled())
  +log.debug(i + " copying 2 bytes");
   copy(2);
   break;

cvs commit: jakarta-tomcat-catalina/webapps/docs/config host.xml

[yoavs]

yoavs   2004/09/20 11:25:43

  Modified:webapps/docs changelog.xml
   webapps/docs/config host.xml
  Log:
  Bugzilla 31277: clarified Automatic Application Deployment doc a bit.
  
  Revision  ChangesPath
  1.112 +3 -0  jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.111
  retrieving revision 1.112
  diff -u -r1.111 -r1.112
  --- changelog.xml 20 Sep 2004 17:58:26 -  1.111
  +++ changelog.xml 20 Sep 2004 18:25:42 -  1.112
  @@ -45,6 +45,9 @@
 md5Helper, md5Encoder, and normalize are used by WebdavServlet,
 not DefaultServelt so move them into WebdavServlet.
 
  +  
  +31277: Clarified automatic application deployment section of 
Host configuration page. (yoavs)
  +  
   
 
   
  
  
  
  1.10  +9 -1  jakarta-tomcat-catalina/webapps/docs/config/host.xml
  
  Index: host.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/config/host.xml,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- host.xml  20 Sep 2004 18:14:43 -  1.9
  +++ host.xml  20 Sep 2004 18:25:43 -  1.10
  @@ -8,6 +8,8 @@
   
 
   Craig R. McClanahan
  +Remy Maucherat
  +Yoav Shapira
   The Host Container
 
   
  @@ -271,7 +273,8 @@
   be the absolute pathname to a web application directory, or the
   absolute pathname of a web application archive (WAR) file (which
   will not be expanded).
  -Any web application archive file that does not have a corresponding
  +Any web application archive file within the application base (appBase)
  +directory that does not have a corresponding
   directory of the same name (without the ".war" extension) will be
   automatically expanded, unless the unpackWARs property
   is set to false.  If you redeploy an updated WAR file,
  @@ -316,6 +319,11 @@
   appBase directory. If this is not the case difficulties
   may be experienced deploying the web application or the application may
   be deployed twice.
  +
  +Finally, note that if you are defining contexts explicitly, you should
  +probably turn off automatic application deployment.  Otherwise, your context
  +will be deployed twice each, and that may cause problems for your app.
  +
   
 
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler SmapUtil.java

[Amy Roh]

Amy Roh wrote:
[EMAIL PROTECTED] wrote:
amyroh  2004/09/20 10:51:28
 Modified:jasper2/src/share/org/apache/jasper/compiler 
SmapUtil.java
 Log:
 Remove verbose.
 -if (verbose) {
 -if (log.isDebugEnabled())
 -log.debug("constant pool count: " + 
constantPoolCount);
 -}
 +log("constant pool count: " + constantPoolCount);

You need to keep if (log.isDebugEnabled()), otherwise, zillions of 
Strings will be created for no reason (as the parameter of your method 
will have to be created).

I have added the following log helper method so I don't have to do if 
(log.isDebugEnabled()) everytime I use log.debug()

 +
 +private static void log(String msg) {
 +if (log.isDebugEnabled())
 +log.debug(msg);
 +}
 +
  }
Amy
>>>  +log("constant pool count: " + constantPoolCount);
But even to call your log() method, a String will need to be created that 
combines the "constant pool count:" with a 
String.valueOf(constantPoolCount).  Even if it's just going to be thrown 
away.
-Paul
Ah, I see what you mean.  I'll commit the fix. 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/webapps/docs/config host.xml

[luehe]

luehe   2004/09/20 11:14:43

  Modified:webapps/docs/config host.xml
  Log:
  Removed invalid paragraph
  
  Revision  ChangesPath
  1.9   +0 -6  jakarta-tomcat-catalina/webapps/docs/config/host.xml
  
  Index: host.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/config/host.xml,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- host.xml  1 Sep 2004 22:04:29 -   1.8
  +++ host.xml  20 Sep 2004 18:14:43 -  1.9
  @@ -450,12 +450,6 @@
   utilized for access control decisions across all
   of the associated web applications, without challenging the user
   to authenticate themselves to each application individually.
  -As soon as the user logs out of one web application (for example,
  -by invalidating or timing out the corresponding session if form
  -based login is used), the user's sessions in all
  -web applications will be invalidated.  Any subsequent attempt to
  -access a protected resource in any application will require the
  -user to authenticate himself or herself again.
   The Single Sign On feature utilizes HTTP cookies to transmit a token
   that associates each request with the saved user identity, so it can
   only be utilized in client environments that support cookies.
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler SmapUtil.java

[Paul Speed]

Amy Roh wrote:
[EMAIL PROTECTED] wrote:
amyroh  2004/09/20 10:51:28
 Modified:jasper2/src/share/org/apache/jasper/compiler SmapUtil.java
 Log:
 Remove verbose.
 -if (verbose) {
 -if (log.isDebugEnabled())
 -log.debug("constant pool count: " + 
constantPoolCount);
 -}
 +log("constant pool count: " + constantPoolCount);

You need to keep if (log.isDebugEnabled()), otherwise, zillions of 
Strings will be created for no reason (as the parameter of your method 
will have to be created).

I have added the following log helper method so I don't have to do if 
(log.isDebugEnabled()) everytime I use log.debug()

 +
 +private static void log(String msg) {
 +if (log.isDebugEnabled())
 +log.debug(msg);
 +}
 +
  }
Amy
>>>  +log("constant pool count: " + constantPoolCount);
But even to call your log() method, a String will need to be created 
that combines the "constant pool count:" with a 
String.valueOf(constantPoolCount).  Even if it's just going to be thrown 
away.
-Paul

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31232] - response.encodeURL() not encoding URL when mix of cookies and URL rewriting

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31232

response.encodeURL() not encoding URL when mix of cookies and URL rewriting





--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 18:11 ---
This seems contrived... What's the use-case for it?  I'm just curious, not 
closing this issue at this point.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31171] - ClassCastException in org.apache.jasper.runtime.PageContextImpl.getException

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31171

ClassCastException in org.apache.jasper.runtime.PageContextImpl.getException

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 18:09 ---
Fixed for 5.0.29 and 5.5.3.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime PageContextImpl.java

[yoavs]

yoavs   2004/09/20 11:07:22

  Modified:webapps/docs Tag: TOMCAT_5_0 changelog.xml
   jasper2/src/share/org/apache/jasper/runtime Tag: TOMCAT_5_0
PageContextImpl.java
  Log:
  Bugzilla 31171: wrap to avoid ClassCastException if necessary.
  
  Revision  ChangesPath
  No   revision
  No   revision
  1.70.2.37 +3 -0  jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.70.2.36
  retrieving revision 1.70.2.37
  diff -u -r1.70.2.36 -r1.70.2.37
  --- changelog.xml 20 Sep 2004 16:39:28 -  1.70.2.36
  +++ changelog.xml 20 Sep 2004 18:07:21 -  1.70.2.37
  @@ -99,6 +99,9 @@
 
   30984: Added compilerTargetVM option to Jasper. (yoavs)
 
  +   
  +31171: Wrap to avoid ClassCastException in PageContextImpl. 
(yoavs) 
  +   
   
 
 
  
  
  
  No   revision
  No   revision
  1.60.2.1  +21 -1 
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime/PageContextImpl.java
  
  Index: PageContextImpl.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime/PageContextImpl.java,v
  retrieving revision 1.60
  retrieving revision 1.60.2.1
  diff -u -r1.60 -r1.60.2.1
  --- PageContextImpl.java  13 Apr 2004 22:55:50 -  1.60
  +++ PageContextImpl.java  20 Sep 2004 18:07:22 -  1.60.2.1
  @@ -557,7 +557,27 @@
   }
   public ServletRequest getRequest() { return request; }
   public ServletResponse getResponse() { return response; }
  -public Exception getException() { return 
(Exception)request.getAttribute(EXCEPTION); }
  +
  +/** 
  + * Returns the exception associated with this page 
  + * context, if any. 
  + *  
  + * Added wrapping for Throwables to avoid ClassCaseException: 
  + * see Bugzilla 31171 for details. 
  + * 
  + * @return The Exception associated with this page context, if any. 
  + */ 
  +public Exception getException() { 
  +Throwable exc = (Throwable) request.getAttribute(EXCEPTION); 
  +
  +// Only wrap if needed 
  +if((exc != null) && (! (exc instanceof Exception))) { 
  +exc = new JspException(exc); 
  +} 
  +
  +return (Exception) exc; 
  +} 
  +
   public Object getPage() { return servlet; }
   
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler SmapUtil.java

[Amy Roh]

[EMAIL PROTECTED] wrote:
amyroh  2004/09/20 10:51:28
 Modified:jasper2/src/share/org/apache/jasper/compiler SmapUtil.java
 Log:
 Remove verbose.
 -if (verbose) {
 -if (log.isDebugEnabled())
 -log.debug("constant pool count: " + 
constantPoolCount);
 -}
 +log("constant pool count: " + constantPoolCount);

You need to keep if (log.isDebugEnabled()), otherwise, zillions of Strings 
will be created for no reason (as the parameter of your method will have 
to be created).
I have added the following log helper method so I don't have to do if 
(log.isDebugEnabled()) everytime I use log.debug()

 +
 +private static void log(String msg) {
 +if (log.isDebugEnabled())
 +log.debug(msg);
 +}
 +
  }
Amy
Rémy 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/authenti cator SingleSignOn.java

[Jan Luehe]

Brian,
Brian Stansberry wrote:
Jan,
At 06:18 PM 9/16/2004 +, you wrote:
luehe   2004/09/16 11:18:41
 Modified:catalina/src/share/org/apache/catalina/authenticator
   SingleSignOn.java
 Log:
 - Removed deregister(String ssoid), because it is no longer needed
   (used to be called when session was logged out, which is no longer
   supported)
I'm not sure what you meant here by "no longer supported."  Do you mean 
the cross-webapp signout feature that deregister(String ssoid) provided, 
or has there been some more fundamental change in TC's handling of 
HttpSession.invalidate()?
I was referring to the removal of javax.servlet.http.HttpSession.logout(),
which had been added temporarily to Servlet 2.4 and was later removed
before the spec went final. See this log entry in the history of
javax.servlet.http.HttpSession:
  revision 1.3
  date: 2003/04/07 21:27:36;  author: jfarcand;  state: Exp;  lines: +0
  -15
  As required by the upcoming Servlet spec 2.4 PFD 3, remove the
  logout() method.
This method was the only method that generated a SessionEvent of
type SESSION_DESTROYED_EVENT with event data equal to "logout", which
used to invalidate all remaining sessions (if any) associated with
the SingleSignOn entry.
In either case, the SingleSignOn docs at 
http://jakarta.apache.org/tomcat/tomcat-5.5-doc/config/host.html#Single%20Sign%20On 
need to be updated, as they state:

"As soon as the user logs out of one web application (for example, by 
invalidating or timing out the corresponding session if form based login 
is used), the user's sessions in all web applications will be 
invalidated. Any subsequent attempt to access a protected resource in 
any application will require the user to authenticate himself or herself 
again."

(Actually, that paragraph was incorrect even before this patch, since 
the time out of a session would not cause other sessions to be 
invalidated.)

Agreed. I'm going to remove this paragraph.
Jan

Best,
Brian Stansberry
 - Replaced call to removeSession(String, Session) with
   deregister(String, Session), which is identical, and removed
   removeSession(String, Session) because it is no longer needed
 Revision  ChangesPath
 1.18  +3 -92 
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/authenticator/SingleSignOn.java 

 Index: SingleSignOn.java
 ===
 RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/authenticator/SingleSignOn.java,v 

 retrieving revision 1.17
 retrieving revision 1.18
 diff -u -r1.17 -r1.18
 --- SingleSignOn.java 29 Aug 2004 16:46:09 -  1.17
 +++ SingleSignOn.java 16 Sep 2004 18:18:41 -  1.18
 @@ -287,24 +287,10 @@
  synchronized (reverse) {
  ssoId = (String) reverse.get(session);
  }
 -if (ssoId == null)
 +if (ssoId == null) {
  return;
 -
 -// Was the session destroyed as the result of a timeout?
 -// If so, we'll just remove the expired session from the
 -// SSO.  If the session was logged out, we'll log out
 -// of all session associated with the SSO.
 -if ((session.getMaxInactiveInterval() > 0)
 -&& (System.currentTimeMillis() - 
session.getLastAccessedTime() >=
 -session.getMaxInactiveInterval() * 1000)) {
 -removeSession(ssoId, session);
 -} else {
 -// The session was logged out.
 -// Deregister this single session id, invalidating
 -// associated sessions
 -deregister(ssoId);
  }
 -
 +deregister(ssoId, session);
  }

 @@ -468,46 +454,6 @@
  /**
 - * Deregister the specified single sign on identifier, and 
invalidate
 - * any associated sessions.
 - *
 - * @param ssoId Single sign on identifier to deregister
 - */
 -protected void deregister(String ssoId) {
 -
 -if (container.getLogger().isDebugEnabled())
 -container.getLogger().debug("Deregistering sso id '" + 
ssoId + "'");
 -
 -// Look up and remove the corresponding SingleSignOnEntry
 -SingleSignOnEntry sso = null;
 -synchronized (cache) {
 -sso = (SingleSignOnEntry) cache.remove(ssoId);
 -}
 -
 -if (sso == null)
 -return;
 -
 -// Expire any associated sessions
 -Session sessions[] = sso.findSessions();
 -for (int i = 0; i < sessions.length; i++) {
 -if (container.getLogger().isTraceEnabled())
 -container.getLogger().trace(" Invalidating session " 
+ sessions[i]);
 -// Remove from reverse cache first to avoid recursion
 -synchronized (reverse) {
 -reverse.remove(sessions[i]);
 -}
 -// Invalidate this session
 -sessions[i].expire();
 -}
 -
 -// NOTE:  Clients may still possess 

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime PageContextImpl.java

[yoavs]

yoavs   2004/09/20 10:58:26

  Modified:webapps/docs changelog.xml
   jasper2/src/share/org/apache/jasper/runtime
PageContextImpl.java
  Log:
  Bugzilla 31171: wrap to avoid ClassCastException if necessary.
  
  Revision  ChangesPath
  1.111 +5 -0  jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.110
  retrieving revision 1.111
  diff -u -r1.110 -r1.111
  --- changelog.xml 20 Sep 2004 17:00:03 -  1.110
  +++ changelog.xml 20 Sep 2004 17:58:26 -  1.111
  @@ -57,6 +57,11 @@
 
   
 
  +
  +  
  +31171: Wrap to avoid ClassCastException in PageContextImpl. 
(yoavs)
  +  
  +
 
   
 
  
  
  
  1.61  +21 -1 
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime/PageContextImpl.java
  
  Index: PageContextImpl.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime/PageContextImpl.java,v
  retrieving revision 1.60
  retrieving revision 1.61
  diff -u -r1.60 -r1.61
  --- PageContextImpl.java  13 Apr 2004 22:55:50 -  1.60
  +++ PageContextImpl.java  20 Sep 2004 17:58:26 -  1.61
  @@ -557,7 +557,27 @@
   }
   public ServletRequest getRequest() { return request; }
   public ServletResponse getResponse() { return response; }
  -public Exception getException() { return 
(Exception)request.getAttribute(EXCEPTION); }
  +
  +/**
  + * Returns the exception associated with this page
  + * context, if any.
  + * 
  + * Added wrapping for Throwables to avoid ClassCaseException:
  + * see Bugzilla 31171 for details.
  + *
  + * @return The Exception associated with this page context, if any.
  + */
  +public Exception getException() {
  +Throwable exc = (Throwable) request.getAttribute(EXCEPTION);
  +
  +// Only wrap if needed
  +if((exc != null) && (! (exc instanceof Exception))) {
  +exc = new JspException(exc);
  +}
  +
  +return (Exception) exc;
  +}
  +
   public Object getPage() { return servlet; }
   
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler SmapUtil.java

[Remy Maucherat]

[EMAIL PROTECTED] wrote:
amyroh  2004/09/20 10:51:28
 Modified:jasper2/src/share/org/apache/jasper/compiler SmapUtil.java
 Log:
 Remove verbose.
 
 -if (verbose) {
 -if (log.isDebugEnabled())
 -log.debug("constant pool count: " + constantPoolCount);
 -}
 +log("constant pool count: " + constantPoolCount);
 

You need to keep if (log.isDebugEnabled()), otherwise, zillions of 
Strings will be created for no reason (as the parameter of your method 
will have to be created).

Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/buf C2BConverter.java

[amyroh]

amyroh  2004/09/20 10:52:09

  Modified:jk/java/org/apache/jk/config WebXml2Jk.java
   jk/test/org/apache/ajp/test TestAjp13.java
   util/java/org/apache/tomcat/util/buf C2BConverter.java
  Log:
  A couple more logging changes.
  
  Revision  ChangesPath
  1.7   +2 -1  
jakarta-tomcat-connectors/jk/java/org/apache/jk/config/WebXml2Jk.java
  
  Index: WebXml2Jk.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/jk/config/WebXml2Jk.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- WebXml2Jk.java24 Feb 2004 08:48:43 -  1.6
  +++ WebXml2Jk.java20 Sep 2004 17:52:09 -  1.7
  @@ -417,7 +417,8 @@
  String systemId)
   throws SAXException, IOException
   {
  -System.out.println("ResolveEntity: " + publicId + " " + systemId);
  +if (log.isDebugEnabled())
  +log.debug("ResolveEntity: " + publicId + " " + systemId);
   return new InputSource(new StringReader(""));
   }
   }
  
  
  
  1.4   +5 -1  
jakarta-tomcat-connectors/jk/test/org/apache/ajp/test/TestAjp13.java
  
  Index: TestAjp13.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/test/org/apache/ajp/test/TestAjp13.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- TestAjp13.java24 Feb 2004 08:48:44 -  1.3
  +++ TestAjp13.java20 Sep 2004 17:52:09 -  1.4
  @@ -34,6 +34,9 @@
   
   public class TestAjp13 extends TestCase {
   
  +private static org.apache.commons.logging.Log log=
  +org.apache.commons.logging.LogFactory.getLog( TestAjp13.class );
  +
   Ajp13Server server = null;
   
   public TestAjp13(String name) {
  @@ -167,7 +170,8 @@
   }
   
   protected static void println(String msg) {
  -System.out.println("[TestAjp13] " + msg);
  +if (log.isDebugEnabled())
  +log.debug("[TestAjp13] " + msg);
   }
   
   public static void main(String[] args) throws Exception {
  
  
  
  1.5   +6 -1  
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/buf/C2BConverter.java
  
  Index: C2BConverter.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/buf/C2BConverter.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- C2BConverter.java 24 Feb 2004 08:50:06 -  1.4
  +++ C2BConverter.java 20 Sep 2004 17:52:09 -  1.5
  @@ -29,6 +29,10 @@
* 
*/
   public final class C2BConverter {
  +
  +private static org.apache.commons.logging.Log log=
  +org.apache.commons.logging.LogFactory.getLog(C2BConverter.class );
  +
   private IntermediateOutputStream ios;
   private WriteConvertor conv;
   private ByteChunk bb;
  @@ -108,7 +112,8 @@
   charC.getOffset(), charC.getLength());
   //System.out.println("XXX Converting " + mb.getCharChunk() );
   } else {
  -System.out.println("XXX unknowon type " + type );
  +if (log.isDebugEnabled())
  +log.debug("XXX unknowon type " + type );
   }
   flushBuffer();
   //System.out.println("C2B: XXX " + bb.getBuffer() + bb.getLength()); 
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler SmapUtil.java

[amyroh]

amyroh  2004/09/20 10:51:28

  Modified:jasper2/src/share/org/apache/jasper/compiler SmapUtil.java
  Log:
  Remove verbose.
  
  Revision  ChangesPath
  1.25  +20 -62
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/SmapUtil.java
  
  Index: SmapUtil.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/SmapUtil.java,v
  retrieving revision 1.24
  retrieving revision 1.25
  diff -u -r1.24 -r1.25
  --- SmapUtil.java 17 Sep 2004 21:02:34 -  1.24
  +++ SmapUtil.java 20 Sep 2004 17:51:28 -  1.25
  @@ -45,8 +45,6 @@
   
   private static org.apache.commons.logging.Log log=
   org.apache.commons.logging.LogFactory.getLog( SmapUtil.class );
  -
  -private static final boolean verbose = false;
   
   //*
   // Constants
  @@ -286,10 +284,7 @@
   copy(4 + 2 + 2); // magic min/maj version
   int constantPoolCountPos = genPos;
   int constantPoolCount = readU2();
  -if (verbose) {
  -if (log.isDebugEnabled())
  -log.debug("constant pool count: " + constantPoolCount);
  -}
  +log("constant pool count: " + constantPoolCount);
   writeU2(constantPoolCount);
   
   // copy old constant pool return index of SDE symbol, if found
  @@ -303,45 +298,27 @@
   ++constantPoolCount;
   randomAccessWriteU2(constantPoolCountPos, constantPoolCount);
   
  -if (verbose) {
  -if (log.isDebugEnabled())
  -log.debug(
  -"SourceDebugExtension not found, installed at: "
  -+ sdeIndex);
  -}
  +log("SourceDebugExtension not found, installed at: " + sdeIndex);
   } else {
  -if (verbose) {
  -if (log.isDebugEnabled())
  -log.debug(
  -"SourceDebugExtension found at: " + sdeIndex);
  -}
  +log("SourceDebugExtension found at: " + sdeIndex);
   }
   copy(2 + 2 + 2); // access, this, super
   int interfaceCount = readU2();
   writeU2(interfaceCount);
  -if (verbose) {
  -if (log.isDebugEnabled())
  -log.debug("interfaceCount: " + interfaceCount);
  -}
  +log("interfaceCount: " + interfaceCount);
   copy(interfaceCount * 2);
   copyMembers(); // fields
   copyMembers(); // methods
   int attrCountPos = genPos;
   int attrCount = readU2();
   writeU2(attrCount);
  -if (verbose) {
  -if (log.isDebugEnabled())
  -log.debug("class attrCount: " + attrCount);
  -}
  +log("class attrCount: " + attrCount);
   // copy the class attributes, return true if SDE attr found (not copied)
   if (!copyAttrs(attrCount)) {
   // we will be adding SDE and it isn't already counted
   ++attrCount;
   randomAccessWriteU2(attrCountPos, attrCount);
  -if (verbose) {
  -if (log.isDebugEnabled())
  -log.debug("class attrCount incremented");
  -}
  +log("class attrCount incremented");
   }
   writeAttrForSDE(sdeIndex);
   }
  @@ -349,18 +326,12 @@
   void copyMembers() {
   int count = readU2();
   writeU2(count);
  -if (verbose) {
  -if (log.isDebugEnabled())
  -log.debug("members count: " + count);
  -}
  +log("members count: " + count);
   for (int i = 0; i < count; ++i) {
   copy(6); // access, name, descriptor
   int attrCount = readU2();
   writeU2(attrCount);
  -if (verbose) {
  -if (log.isDebugEnabled())
  -log.debug("member attr count: " + attrCount);
  -}
  +log("member attr count: " + attrCount);
   copyAttrs(attrCount);
   }
   }
  @@ -372,19 +343,13 @@
   // don't write old SDE
   if (nameIndex == sdeIndex) {
   sdeFound = true;
  -if (verbose) {
  -if (log.isDebugEnabled())
  -log.debug("SDE attr found");
  -}
  +log("SDE attr found");
   } else {
  

DO NOT REPLY [Bug 31308] - Tomcat ignores precompiled JSP if JSP file is a welcome-file

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31308

Tomcat ignores precompiled JSP if JSP file is a welcome-file

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 17:42 ---
I still do not see anything which is any different from the root web
application, which you don't seem to have looked into at all.
Please attach a small test WAR with your precompiled application, exhibiting the
"issue". I recommend you look into the issue more instead of reopening the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31308] - Tomcat ignores precompiled JSP if JSP file is a welcome-file

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31308

Tomcat ignores precompiled JSP if JSP file is a welcome-file

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |



--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 17:37 ---
More info. 
 
Here's my jspc target definition: 
 
   
  

  
  

  
  

  
  

  

  
 
  
 
 
 
 
   
 
My deploy task: 
   
 
   
 
   
 
   
 
 
   
 
 
The xml created by jasper is inserted in the 
appropriawork/Catalina/localhostte place in 
web.xml ( before the welcome-file-list ). 
 
When I access the JSP directly via the browser,  
Tomcat does not create .java or .class files in the  
$CATALINA_HOME/work/Catalina/localhost/app_path directory; 
if I don't type the JSP file name, the files are created, 
which (I think) shouldn't happen.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

[funkman]

funkman 2004/09/20 10:00:04

  Modified:webapps/docs changelog.xml
  Log:
  document md5 move from defaultservelt to webdav servlet
  add  around the fixes in Catalina
  
  Revision  ChangesPath
  1.110 +6 -0  jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.109
  retrieving revision 1.110
  diff -u -r1.109 -r1.110
  --- changelog.xml 20 Sep 2004 16:31:17 -  1.109
  +++ changelog.xml 20 Sep 2004 17:00:03 -  1.110
  @@ -31,6 +31,7 @@
 
   
 
  +
 
   Remove Digester code for Xerces workaround. (jfarcand)
 
  @@ -40,6 +41,11 @@
 
   30869: Make sure JAAS realm name is legal. (yoavs)
 
  +  
  +  md5Helper, md5Encoder, and normalize are used by WebdavServlet,
  +  not DefaultServelt so move them into WebdavServlet.
  +  
  +
 
   
 
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31304] - NoClassDefFoundError: org/apache/commons/collections/CursorableLinkedList

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31304

NoClassDefFoundError: org/apache/commons/collections/CursorableLinkedList





--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 16:48 ---
Looking at the Jakarta Commons-Collections 3.1 JavaDoc makes it clear that 
org.apache.commons.collections.CursorableLinkedList exists (although it's 
deprecated).

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31304] - NoClassDefFoundError: org/apache/commons/collections/CursorableLinkedList

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31304

NoClassDefFoundError: org/apache/commons/collections/CursorableLinkedList





--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 16:46 ---
First, using DBCP works for me out of the box with Tomcat 5.0.28.  So you must 
have changed something in order to get this error.

Did you modify the commons-pool, commons-collections, or commons-dbcp versions 
that shipped with Tomcat?  Did you place additional versions of any of these 
jars in $CATALINA_HOME/common/lib or in your webapp's WEB-INF/lib directory?

This is the kind of issue that's best discussed on tomcat-user first, rather 
than opening a Tomcat bug report right away, as it's much more likely to be a 
configuration error on your part than an actual Tomcat bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31090] - The session "disappears" when the context name contains the space character

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31090

The session "disappears" when the context name contains the space character





--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 16:43 ---
Where are you defining this context name?  In the web.xml (display-name 
attribute)?  In the context.xml file for the context?  Or explicitly by making 
it a directory in the webapps directory?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31058] - currentQueryString not escaped in status XML

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31058

currentQueryString not escaped in status XML

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 16:41 ---
OK, fixed for both 5.0.29 and 5.5.3.  Used 
org.apache.catalina.util.RequestUtil#filter, which does XML-escaping properly I 
think.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/webapps/manager/WEB-INF/classes/org/apache/catalina/manager StatusTransformer.java

[yoavs]

yoavs   2004/09/20 09:39:28

  Modified:webapps/docs Tag: TOMCAT_5_0 changelog.xml
   webapps/manager/WEB-INF/classes/org/apache/catalina/manager
Tag: TOMCAT_5_0 StatusTransformer.java
  Log:
  Bugzilla 31058: xml-escape query string in manager's StatusTransformer.
  
  Revision  ChangesPath
  No   revision
  No   revision
  1.70.2.36 +3 -0  jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.70.2.35
  retrieving revision 1.70.2.36
  diff -u -r1.70.2.35 -r1.70.2.36
  --- changelog.xml 20 Sep 2004 16:11:47 -  1.70.2.35
  +++ changelog.xml 20 Sep 2004 16:39:28 -  1.70.2.36
  @@ -89,6 +89,9 @@
 
   29485: Added JavaScript confirmation prompts to HTML Manager 
actions. (yoavs)
 
  +  
  +31058: Ensure StatusTransformer escapes query string for XML. 
(yoavs)
  +  
   
 
 
  
  
  
  No   revision
  No   revision
  1.18.2.1  +4 -3  
jakarta-tomcat-catalina/webapps/manager/WEB-INF/classes/org/apache/catalina/manager/StatusTransformer.java
  
  Index: StatusTransformer.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/webapps/manager/WEB-INF/classes/org/apache/catalina/manager/StatusTransformer.java,v
  retrieving revision 1.18
  retrieving revision 1.18.2.1
  diff -u -r1.18 -r1.18.2.1
  --- StatusTransformer.java26 May 2004 16:41:54 -  1.18
  +++ StatusTransformer.java20 Sep 2004 16:39:28 -  1.18.2.1
  @@ -25,6 +25,7 @@
   import java.util.Vector;
   
   import javax.servlet.http.HttpServletResponse;
  +import org.apache.catalina.util.RequestUtil;
   import org.apache.tomcat.util.compat.JdkCompat;
   
   import javax.management.MBeanServer;
  @@ -404,7 +405,7 @@
   (pName, "currentQueryString");
   if ((queryString != null) && (!queryString.equals(""))) {
   writer.write("?");
  -writer.print(queryString);
  +writer.print(RequestUtil.filter(queryString));
   }
   writer.write(" ");
   writer.write(filter(mBeanServer.getAttribute
  @@ -459,7 +460,7 @@
   (pName, "currentQueryString");
   if ((queryString != null) && (!queryString.equals(""))) {
   writer.write(" currentQueryString=\"" 
  - + queryString + "\"");
  + + RequestUtil.filter(queryString) + "\"");
   } else {
   writer.write(" currentQueryString=\"?\"");
   }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/webapps/manager/WEB-INF/classes/org/apache/catalina/manager StatusTransformer.java

[yoavs]

yoavs   2004/09/20 09:31:17

  Modified:webapps/docs changelog.xml
   webapps/manager/WEB-INF/classes/org/apache/catalina/manager
StatusTransformer.java
  Log:
  Bugzilla 31058: XML-escape query string for Manager's StatusTransformer.
  
  Revision  ChangesPath
  1.109 +3 -0  jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.108
  retrieving revision 1.109
  diff -u -r1.108 -r1.109
  --- changelog.xml 20 Sep 2004 15:57:55 -  1.108
  +++ changelog.xml 20 Sep 2004 16:31:17 -  1.109
  @@ -61,6 +61,9 @@
 
   29485: I broke the HTML manager when adding JavaScript 
confirmation, fixed now ;) (yoavs)
 
  +  
  +31058: Ensure StatusTransformer escapes query string for XML. 
(yoavs)
  +  
   
 
   
  
  
  
  1.22  +4 -3  
jakarta-tomcat-catalina/webapps/manager/WEB-INF/classes/org/apache/catalina/manager/StatusTransformer.java
  
  Index: StatusTransformer.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/webapps/manager/WEB-INF/classes/org/apache/catalina/manager/StatusTransformer.java,v
  retrieving revision 1.21
  retrieving revision 1.22
  diff -u -r1.21 -r1.22
  --- StatusTransformer.java7 Sep 2004 20:57:35 -   1.21
  +++ StatusTransformer.java20 Sep 2004 16:31:17 -  1.22
  @@ -25,6 +25,7 @@
   import java.util.Vector;
   
   import javax.servlet.http.HttpServletResponse;
  +import org.apache.catalina.util.RequestUtil;
   import org.apache.tomcat.util.compat.JdkCompat;
   
   import javax.management.MBeanServer;
  @@ -404,7 +405,7 @@
   (pName, "currentQueryString");
   if ((queryString != null) && (!queryString.equals(""))) {
   writer.write("?");
  -writer.print(queryString);
  +writer.print(RequestUtil.filter(queryString));
   }
   writer.write(" ");
   writer.write(filter(mBeanServer.getAttribute
  @@ -459,7 +460,7 @@
   (pName, "currentQueryString");
   if ((queryString != null) && (!queryString.equals(""))) {
   writer.write(" currentQueryString=\"" 
  - + queryString + "\"");
  + + RequestUtil.filter(queryString) + "\"");
   } else {
   writer.write(" currentQueryString=\"?\"");
   }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 30832] - Loading resources from a .jar-file requires file-write permission if SecurityManager is installed

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=30832

Loading resources from a .jar-file requires file-write permission if SecurityManager 
is installed

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 16:19 ---
Tomcat requires that the user running the server has write permissions into the 
working directory.  This is true for running with and without a 
SecurityManager.  Other things will fail as well if you don't have this write 
permission.

That's why I'm marking this issue as invalid.

The suggestion to do the critical part as a PrivilegedAction is interesting and 
potentially good for other reasons, not just the reason mentioned in this 
Bugzilla issue.  If you submit a .diff patch with that code, I'll be glad to 
look at it and apply it.  Thanks ;)

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 30869] - JAAS module name is not allowed in jaas.conf file

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=30869

JAAS module name is not allowed in jaas.conf file

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 16:15 ---
OK, done for both 5.0.29 and 5.5.3.  My initial implementation is simply to 
remove leading slash if one is present.  I made the relevant method protected 
so extenders of JAASRealm can easily modify this behavior.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

[yoavs]

yoavs   2004/09/20 09:11:51

  Modified:catalina/src/share/org/apache/catalina/realm Tag: TOMCAT_5_0
JAASRealm.java
   webapps/docs Tag: TOMCAT_5_0 changelog.xml
  Log:
  Bugzilla 30869 initial implementation.
  
  Revision  ChangesPath
  No   revision
  No   revision
  1.6.2.2   +32 -3 
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/JAASRealm.java
  
  Index: JAASRealm.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/JAASRealm.java,v
  retrieving revision 1.6.2.1
  retrieving revision 1.6.2.2
  diff -u -r1.6.2.1 -r1.6.2.2
  --- JAASRealm.java21 Aug 2004 15:49:53 -  1.6.2.1
  +++ JAASRealm.java20 Sep 2004 16:11:47 -  1.6.2.2
  @@ -189,10 +189,14 @@
   
   public void setContainer(Container container) {
   super.setContainer(container);
  -String name=container.getName();
  +
   if( appName==null  ) {
  +String name=container.getName();
  +name = makeLegalForJAAS(name);
  +
   appName=name;
  -log.info("Setting JAAS app name " + appName);
  +
  +log.info("Set JAAS app name " + appName);
   }
   }
   
  @@ -451,6 +455,31 @@
   return (null);
   }
   }
  + /**
  +  * Ensure the given name is legal for JAAS configuration.
  +  * Added for Bugzilla 30869, made protected for easy customization
  +  * in case my implementation is insufficient, which I think is
  +  * very likely.
  +  *
  +  * @param src The name to validate
  +  * @return A string that's a valid JAAS realm name
  +  */
  + protected String makeLegalForJAAS(final String src) {
  + String result = src;
  + 
  + // Default name is "other" per JAAS spec
  + if(result == null) {
  + result = "other";
  + }
  +
  + // Strip leading slash if present, as Sun JAAS impl
  + // barfs on it (see Bugzilla 30869 bug report).
  + if(result.startsWith("/")) {
  + result = result.substring(1);
  + }
  +
  + return result;
  + }
   
   
   // -- Lifecycle Methods
  
  
  
  No   revision
  No   revision
  1.70.2.35 +3 -1  jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.70.2.34
  retrieving revision 1.70.2.35
  diff -u -r1.70.2.34 -r1.70.2.35
  --- changelog.xml 17 Sep 2004 19:52:04 -  1.70.2.34
  +++ changelog.xml 20 Sep 2004 16:11:47 -  1.70.2.35
  @@ -34,7 +34,6 @@
   Use CatalinaDigester on shutdown so you can use a sytem property to
   configure the port. (funkman)
 
  -  
 
   28914: threadPriority attribute ignored. (yoavs)
 
  @@ -73,6 +72,9 @@
 
 
   Set the FORM notes even when caching so that clustering with SSO works 
properly. (remm)
  +  
  +  
  +30869: Make sure JAAS realm name is legal. (yoavs)
 
   
 
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

[yoavs]

yoavs   2004/09/20 08:57:55

  Modified:catalina/src/share/org/apache/catalina/realm JAASRealm.java
   webapps/docs changelog.xml
  Log:
  Bugzilla 30869 initial implementation.
  
  Revision  ChangesPath
  1.8   +33 -3 
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/JAASRealm.java
  
  Index: JAASRealm.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/JAASRealm.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- JAASRealm.java28 Jul 2004 21:31:16 -  1.7
  +++ JAASRealm.java20 Sep 2004 15:57:55 -  1.8
  @@ -189,10 +189,14 @@
   
   public void setContainer(Container container) {
   super.setContainer(container);
  -String name=container.getName();
  +
   if( appName==null  ) {
  +String name=container.getName();
  +name = makeLegalForJAAS(name);
  +
   appName=name;
  -log.info("Setting JAAS app name " + appName);
  +
  +log.info("Set JAAS app name " + appName);
   }
   }
   
  @@ -451,6 +455,32 @@
   return (null);
   }
   }
  +
  + /**
  +  * Ensure the given name is legal for JAAS configuration.
  +  * Added for Bugzilla 30869, made protected for easy customization
  +  * in case my implementation is insufficient, which I think is
  +  * very likely.
  +  *
  +  * @param src The name to validate
  +  * @return A string that's a valid JAAS realm name
  +  */
  + protected String makeLegalForJAAS(final String src) {
  + String result = src;
  + 
  + // Default name is "other" per JAAS spec
  + if(result == null) {
  + result = "other";
  + }
  +
  + // Strip leading slash if present, as Sun JAAS impl
  + // barfs on it (see Bugzilla 30869 bug report).
  + if(result.startsWith("/")) {
  + result = result.substring(1);
  + }
  +
  + return result;
  + }
   
   
   // -- Lifecycle Methods
  
  
  
  1.108 +3 -0  jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.107
  retrieving revision 1.108
  diff -u -r1.107 -r1.108
  --- changelog.xml 17 Sep 2004 19:50:19 -  1.107
  +++ changelog.xml 20 Sep 2004 15:57:55 -  1.108
  @@ -37,6 +37,9 @@
 
   Give proper permission to the balancer app when running under the security 
manager. (jfarcand)
 
  +  
  +30869: Make sure JAAS realm name is legal. (yoavs)
  +  
 
   
 
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

accusé réception

[Service]

Merci pour votre message.

Notre équipe va tout mettre en oeuvre pour vous répondre dans les meilleurs délais.

Très cordialement,

Le Service Clientèle du Club des Créateurs de Beauté.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 29727] - JNDI env-entry not reload when context reloaded

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=29727

JNDI env-entry not reload when context reloaded





--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 15:41 ---
The code as posted can't be compiled: what's the "jndi" variable?

If you post a complete test case, i.e. a WAR file that I can drop into my 
Tomcat installation to reproduce your problem, I'll be glad to look at it.

In addition, can you please test 5.0.28, the latest stable Tomcat 5.0 release 
at the time of this writing?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Roland Heiberger/MIS is out of the office.

[Roland . Heiberger]

I will be out of the office starting  09/14/2004 and will not return until
09/24/2004.




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31309] - Deploy fails when deploying from path with international characters

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31309

Deploy fails when deploying from path with international characters





--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 14:01 ---
Created an attachment (id=12802)
localhost_log.txt

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31309] New: - Deploy fails when deploying from path with international characters

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31309

Deploy fails when deploying from path with international characters

   Summary: Deploy fails when deploying from path with international
characters
   Product: Tomcat 5
   Version: 5.0.28
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Webapps:Manager
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


When trying to deploy web application from path with international characters (ä
- German umlaut a in my case) using the following Tomcat Manager command:

http://localhost:8084/manager/deploy?config=file:/test/p%C3%A4/WebApplication1/build/web/META-INF/context.xml&war=file:/test/p%C3%A4/WebApplication1/build/web/

I get the following error:

FAIL - Encountered exception java.io.IOException: java.io.FileNotFoundException:
/test/pä/WebApplication1/build/web/META-INF/context.xml (No such file or directory)

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31308] - Tomcat ignores precompiled JSP if JSP file is a welcome-file

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31308

Tomcat ignores precompiled JSP if JSP file is a welcome-file

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 13:38 ---
I really doubt this, since this is the root webapp which is set as default after
installing Tomcat uses a index.jsp precompiled JSP.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31308] New: - Tomcat ignores precompiled JSP if JSP file is a welcome-file

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31308

Tomcat ignores precompiled JSP if JSP file is a welcome-file

   Summary: Tomcat ignores precompiled JSP if JSP file is a welcome-
file
   Product: Tomcat 5
   Version: 5.0.27
  Platform: Other
OS/Version: Linux
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Unknown
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I used jasper to precompile JSPs. When the JSP is a in a welcome-file-list, 
Tomcat ignores the existing precompiled class file and compiles the JSP 
again.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 23357] - TRAX and Xalan get confused when writing to a JspWriter

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=23357

TRAX and Xalan get confused when writing to a JspWriter





--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 12:37 ---
The TraX API seems to have overlooked the need for a published protocol for a 
StreamSource to advertise what characters it can deliver and what need to be 
escaped out or transcoded. It might be reasonable for jasper to go out of its 
way to work around this. Alternatively, if you happen to know where to shoot 
complaints related to Trax as provided in the JDK, I'll submit a report over 
there.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 29494] - No way to set PATH when running as a service on Windows

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=29494

No way to set PATH when running as a service on Windows





--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 12:34 ---
If you would give me a starting pointer to the part of the Tomcat source tree 
which contains the config GUI, I would try to set up a patch for your 
consideration in the 5.0.x branch.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31305] - Tomcat sends after a while the compiles JSP-pages not correct to the client

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31305

Tomcat sends after a while the compiles JSP-pages not correct to the client

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 09:44 ---
I do not see anything I can look into with your bug report. While you can REOPEN
the bug anytime, it will not be looked into until you give out something
reproduceable, or look into the issue yourself and find the place where the
"issue" would occur in Tomcat.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31277] - Applciation deployed twice after restart if path doesn't match war filename

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31277

Applciation deployed twice after restart if path doesn't match war filename

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
  Component|Webapps:Manager |Webapps:Documentation
 Resolution|INVALID |



--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 09:38 ---
I did have the flag autoDeploy set to false but your comment pointed me in the 
right direction. The flag that needs turning off is in fact deployOnStartup. So 
the host element needs to be:


I think there is still an issue around the documentation. The help on Automatic 
Application Deployment is misleading (http://jakarta.apache.org/tomcat/tomcat-
5.0-doc/config/host.html#Automatic%20Application%20Deployment).

1. I think the first action happens even when deployOnStartup is false - I 
didn't try this attribute because I thought it would stop things deploying on 
startup but it doesn't. Actually it solves the problem I was having by only 
deploying things from context files in 
$CATALINA_HOME/conf/[engine_name]/[host_name], but doesn't deploy things from 
appBase.
2. Should the second action read "Any web application archive file within 
the application base directory that does not have a corresponding 
directory of the same name..."
3. The paragraph starting "In addition to the automatic deployment" doesn't 
mention the attribute "autoDeploy" but I think this is what it is referring to.
4. The last paragraph starting "When using automatic deployment," doesn't 
reflect the fact that if you upload a war file, the docBase attribute is 
ignored and the file goes in the appBase directory. Hence you get double 
deployment on restart unless you disable deployOnStartup

I accept that this was in fact a configuration issue but hopefully the 
documentation can be made clearer.

Thanks

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31305] - Tomcat sends after a while the compiles JSP-pages not correct to the client

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31305

Tomcat sends after a while the compiles JSP-pages not correct to the client

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |



--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 09:37 ---
It is difficult to give more informations, but i will try it.
On some days the users works 1 or 2 hours and then the error appears and on 
other days the will work 4 up to 6 hours an then the error appears.
Our customer will use the webapplication in a external call center and he told 
us that the user will work with the webapplication in a normal way.

I have attached the three configuration files server.xml, web.xml and ams.xml.
Also there will be two attachements, which will be take on the client (MSIE 
6.0) by [View | Source Code]. One is taken at the time the system works 
correct and the second is taken when the error appears. Make a diff and you 
will see the duplicate part, which causes the JavaScript-error.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Monitoring different Contexts with JMX MBean

[Stefan Fleiter]

This is a message I already posted to tomcat-user, but did not get any 
answer to.

I would be really thankful for any hint or direction where to get the 
needed information.

Hi,
I try to do my first steps with the java server platform and have chosen 
Tomcat for this.

I wrote a class which is able to Monitor the database pools of a Context
when beeing called out of it.
I only had to use JNDI to iterate over "comp/env/jdbc" and cast the 
DataSource instances to a BasicDataSource.

Now I want to implement an MBean which is able to monitor the pools of 
all Contexts of Tomcat.

I even don't know whether this is possible, but hope to get some help.
Now my concrete questions:
 - Can I somehow change the Context my code is executed in?
 - If not: How do I get instances of all JNDI DataSource for all
   Contexts ?
 - Where do I have to put my MBean .class-files?
   In the webapps dir or somewhere else?
 - How can I make Tomcat register my MBeans at startup?
Thanks a lot in advance,
Stefan
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31305] - Tomcat sends after a while the compiles JSP-pages not correct to the client

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31305

Tomcat sends after a while the compiles JSP-pages not correct to the client

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 09:26 ---
You need to explain clearly how to reproduce this.
Quotes like this don't make the cut:
- "Parts of the page are duplicate in the source when i take a look to 
it on the client browser"
- "After a few hours"
Instead, you need to be precise, concise, and accurate.

As nobody ever reported this issue, and I never experienced it either, I doubt
this report is valid.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31305] - Tomcat sends after a while the compiles JSP-pages not correct to the client

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31305

Tomcat sends after a while the compiles JSP-pages not correct to the client





--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 09:21 ---
Created an attachment (id=12791)
source code take on client browser, when error appeared

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31305] - Tomcat sends after a while the compiles JSP-pages not correct to the client

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31305

Tomcat sends after a while the compiles JSP-pages not correct to the client





--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 09:21 ---
Created an attachment (id=12790)
source code take on client browser, when all is ok

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31305] - Tomcat sends after a while the compiles JSP-pages not correct to the client

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31305

Tomcat sends after a while the compiles JSP-pages not correct to the client





--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 09:19 ---
Created an attachment (id=12789)
configuration file from tomcat/conf/catalina/localhost

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31305] - Tomcat sends after a while the compiles JSP-pages not correct to the client [T20040920007Y]

[support]

Dear [EMAIL PROTECTED],

Thanks for writing to Webshots!

We received your message on 9/20/2004.
Your tracking number for this message is : T20040920007Y

** IMPORTANT: PLEASE DO NOT REPLY TO THIS EMAIL! **

This is an automatic response to let you know that your Webshots Support
email will be personally answered within 10 business days.

Our customer support staff is available to respond to messages
during regular business hours, excluding holidays.

Thanks again for your questions and comments,

The Webshots Support Team.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31305] - Tomcat sends after a while the compiles JSP-pages not correct to the client

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31305

Tomcat sends after a while the compiles JSP-pages not correct to the client





--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 09:18 ---
Created an attachment (id=12788)
configuration file from tomcat/conf

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31305] - Tomcat sends after a while the compiles JSP-pages not correct to the client

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31305

Tomcat sends after a while the compiles JSP-pages not correct to the client





--- Additional Comments From [EMAIL PROTECTED]  2004-09-20 09:18 ---
Created an attachment (id=12787)
configuration file from tomcat/conf

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31305] New: - Tomcat sends after a while the compiles JSP-pages not correct to the client

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31305

Tomcat sends after a while the compiles JSP-pages not correct to the client

   Summary: Tomcat sends after a while the compiles JSP-pages not
correct to the client
   Product: Tomcat 5
   Version: 5.0.27
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Critical
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


When starting tomcat with our webapplication ams all works correct. After a 
few hours the compiled JSP-pages, which will be send to the client, are not 
correct. Parts of the page are duplicate in the source when i take a look to 
it on the client browser. This duplicate code causes JavaScript-errors, so it 
is not possible to work with the webapplication. If you stop tomcat and start 
it again, all will work correct, for some hours and then the problem will 
appear again.
Only a few persons (1- 8) will use the webapplication.

The same webapplication worked on tomcat 3.2.3 with no problems.


Some infos for the system:
- win 2000 (5.00.2195), CPU 1500 MHz
- 512 MB RAM
- Tomcat 5.0.27
- no webserver (like apache)
- JVM 1.4.2 (build 1.4.2-b28)


contents of server.xml:



  
  
  



  
factory
org.apache.catalina.users.MemoryUserDatabaseFactory
  
  
pathname
conf/tomcat-users.xml
  

  
  



  

  
  
  

  




contents of web.xml:


http://java.sun.com/dtd/web-app_2_3.dtd";>


  
  
  
  
  
  
  
  
  


  


  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  


default

  org.apache.catalina.servlets.DefaultServlet


debug
3


listings
true

-2147483646



  
  
  
  
  
  
  
  
  
  
  
  


invoker

  org.apache.catalina.servlets.InvokerServlet


debug
3





  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  


jsp
org.apache.jasper.servlet.JspServlet

development
true


fork
true


xpoweredBy
false

-2147483646



  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  




  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  




  


  
  
  
  



default
/





invoker
/servlet/*




jsp
*.jsp



jsp
*.jspx










  
  
  


50



  
  
  
  
  
  


abs
audio/x-mpeg


ai
application/postscript


aif
audio/x-aiff


aifc
audio/x-aiff


aiff
audio/x-aiff


aim
application/x-aim


art
image/x-jg


asf
video/x-ms-asf


asx
video/x-ms-asf


au
audio/basic


avi
video/x-msvideo


avx
video/x-rad-screenplay


bcpio
application/x-bcpio


bin
application/octet-stream


bmp
image/bmp


body
text/html


cdf
application/x-cdf


cer
application/x-x509-ca-cert


class
application/java


cpio
application/x-cpio


csh
application/x-csh


css
text/css


dib
image/bmp


doc
application/msword


dtd
text/plain


dv
video/x-dv


dvi
application/x-dvi


eps
application/postscript


etx
text/x-setext


exe
application/octet-str