DO NOT REPLY [Bug 31474] - URL query string attribute duplication when using forward method

2004-09-29 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31474

URL query string attribute duplication when using forward method

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-09-30 06:05 ---
Fix now in the CVS.

Thanks for the report!

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat/src/facade22/org/apache/tomcat/facade RequestDispatcherImpl.java

2004-09-29 Thread billbarker 
billbarker2004/09/29 23:02:39

  Modified:src/facade22/org/apache/tomcat/facade
RequestDispatcherImpl.java
  Log:
  Set the correct query-string on forwards.
  
  The parameters are the sum of the forward URI and the request URI, but the 
query-string is the one from the forward URI according to the spec.
  
  This still needs some work to handle the post-request clean-up.
  
  Fix for Bug #31474
  Reported By: Marc Daniels  [EMAIL PROTECTED]
  
  Revision  ChangesPath
  1.29  +7 -5  
jakarta-tomcat/src/facade22/org/apache/tomcat/facade/RequestDispatcherImpl.java
  
  Index: RequestDispatcherImpl.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat/src/facade22/org/apache/tomcat/facade/RequestDispatcherImpl.java,v
  retrieving revision 1.28
  retrieving revision 1.29
  diff -u -r1.28 -r1.29
  --- RequestDispatcherImpl.java23 Feb 2004 06:06:13 -  1.28
  +++ RequestDispatcherImpl.java30 Sep 2004 06:02:39 -  1.29
  @@ -193,7 +193,7 @@
//realRequest.query().recycle();
realRequest.servletPath().recycle();
realRequest.pathInfo().recycle();
  -realRequest.setChild(null);
  + realRequest.setChild(null);
   
// merge query string as specified in specs - before, it may affect
// the way the request is handled by special interceptors
  @@ -201,11 +201,11 @@
// Process existing parameters, if not already done so
// ( otherwise we'll process some twice )
realRequest.parameters().handleQueryParameters();
  - // Set the query string - the sum of the new one and old one.
  + // Set the query string - the new one.
String oldQS=realRequest.queryString().toString();
  - String newQS=(oldQS==null ) ? queryString : queryString + "&" +
  - oldQS;
  - realRequest.queryString().setString(newQS);
  + // String newQS=(oldQS==null ) ? queryString : queryString + "&" +
  + //  oldQS;
  + realRequest.queryString().setString(queryString);
   
// Process the additional parsm. We don't know if the old
// params were processed ( so we need to make sure they are,
  @@ -215,6 +215,8 @@
   
child.processParameters( queryString );
//realRequest.parameters().processParameters( queryString ); 
  + } else {
  + realRequest.queryString().recycle();
}

// run the new request through the context manager
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Important

2004-09-29 Thread craig . mcclanahan 
--  Virus Warning Message (on uusnwa0p)

Found virus WORM_NETSKY.Z in file Data.txt 
   
 .exe (in Data.zip)
The file is deleted.

-
Important data!


--  Virus Warning Message (on uusnwa0p)

Data.zip is removed from here because it contains a virus.

-
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Yahoo! À´ÐÅ×Ô¶¯»Ø¸´

2004-09-29 Thread fyjokers 
×ð¾´µÄÓû§£º
 ·ïÒÇÆ˿˵Ä×÷Õߣ¬Ê®·Ö¸ÐлÄú¶Ô±¾Èí¼þµÄÖ§³ÖºÍºñ°®£¡
Òò±¾È˵Ť×÷Ô­Òò£¬×î½ü¿ÉÄÜÎÞ·¨¼°Ê±»Ø¸´À´ÐÅ£¬ÇëÔ­ÁÂ! 
ÔÙ´ÎÊ®·Ö¸Ðл£¡

±¾ÐÅÊÇ×Ô¶¯·¢ËÍ£¬Èô¸øÄú´øÀ´²»±ã£¬Çë¼ûÁ£¡
[EMAIL PROTECTED]
http://flyangel.5inet.cn




Original Message:


X-YahooFilteredBulk: 61.129.192.191
X-Originating-IP: [61.129.192.191]
Return-Path: <[EMAIL PROTECTED]>
Received: from 61.129.192.191  (EHLO yahoo.com.cn) (61.129.192.191)
  by mta105.mail.cnb.yahoo.com with SMTP; Thu, 30 Sep 2004 07:51:46 +0800
From: [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Subject: Mail Delivery (failure [EMAIL PROTECTED])
Date: Thu, 30 Sep 2004 08:03:31 +0800
MIME-Version: 1.0
Content-Type: multipart/related;
type="multipart/alternative";
boundary="=_NextPart_000_001B_01C0CA80.6B015D10"
X-Priority: 3
X-MSMail-Priority: Normal

This is a multi-part message in MIME format.

--=_NextPart_000_001B_01C0CA80.6B015D10
Content-Type: multipart/alternative;
boundary="=_NextPart_001_001C_01C0CA80.6B015D10"

--=_NextPart_001_001C_01C0CA80.6B015D10
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

--=_N
_
DO YOU YAHOO!?
Get your free @yahoo.com address at http://mail.yahoo.com


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31475] New: - resouce-ref does not refer to the server data resource

2004-09-29 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31475

resouce-ref does not refer to the server data resource

   Summary: resouce-ref does not refer to the server data resource
   Product: Tomcat 5
   Version: 5.0.28
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I have in my web.xml:

  Connection Pool
  jdbc/sybase
  javax.sql.DataSource
  Application


In server.xml I have correct definition by the Data source. When running
applicaion I get:

org.apache.commons.dbcp.SQLNestedException: Cannot create JDBC driver of class
'' for connect URL 'null'

In Tomcat administration I see definition of the jdbc/sybase data source with no
properties. I have expected to refer to the global data source defined in the
server.xml.

Workaround is: (use Tomcat administration)
1) Remove data source from the context
2) Make resource link to the global Data source

I expect that the link should be made automaticaly.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: More needed connector refactoring

2004-09-29 Thread Costin Manolache 
Bill Barker wrote:
- Original Message -
From: "Costin Manolache" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Wednesday, September 29, 2004 9:01 AM
Subject: Re: More needed connector refactoring

Remy Maucherat wrote:
Hi,
- I'll add a thread pool similar to the one in Tomcat 4.0, as an
optional policy to the current one; the idea is that it's very dumb, and
could be more stable in some environments (that RH 9 thing ...), but is
not as efficient as the current one; I'll do some benchmarks to see if
for a single CPU computer there's any difference between the two, and I
propose that whichever is the fastest for that use case becomes the
default one (with a preference for the TC 4.0 one in case of a tie, as
it's simpler)
I'm a bit confused - what happened with the thread pool and how did we
end up with 2 ? I missed this change.

- I think conf/jk2.properties should go, since we can have arbitrary
properties on the Connector element, and additionally, it has an
extremely confusing name; any comments on that ?
+1 :-)

It will make the Connector element in server.xml really hideous, and
restrict component names to be valid XML attribute names (e.g.
channelSocket.localhost:8009 is a no-no :).  Other than that, I don't see a
problem.
Maybe a better solution would be to introduce a new tag ( "mbean" or 
"module" or similar ), so we can express the fact that jk is composed 
from multiple components.

The intention of jk2.properties was to have a way to configure generic 
components ( mbean-like ), with a simple way to parse/save the changes 
from both java and C.

Since "C" is no longer an issue - there is no problem with using an xml 
file, like server.xml. And a good "save changes" implementation 
shouldn't be specific to jk.

Costin
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: More needed connector refactoring

2004-09-29 Thread Bill Barker 

- Original Message -
From: "Remy Maucherat" <[EMAIL PROTECTED]>
To: "Tomcat Developers List" <[EMAIL PROTECTED]>
Sent: Wednesday, September 29, 2004 12:29 PM
Subject: Re: More needed connector refactoring


>Bill Barker wrote:
>
>>>Remy Maucherat wrote:
>>>
>>>
Hi,

- I'll add a thread pool similar to the one in Tomcat 4.0, as an
optional policy to the current one; the idea is that it's very dumb, and
could be more stable in some environments (that RH 9 thing ...), but is
not as efficient as the current one; I'll do some benchmarks to see if
for a single CPU computer there's any difference between the two, and I
propose that whichever is the fastest for that use case becomes the
default one (with a preference for the TC 4.0 one in case of a tie, as
it's simpler)


>>>I'm a bit confused - what happened with the thread pool and how did we
>>>end up with 2 ? I missed this change.
>>>
>>>
>There was no change yet. I was proposing (re)introducing a more
>conventional policy as an option (where I would just copy code from TC
>4.1). At least, I'll do it to see without committing anything to see how
>it compares.
>
- I think conf/jk2.properties should go, since we can have arbitrary
properties on the Connector element, and additionally, it has an
extremely confusing name; any comments on that ?


>>>+1 :-)
>>>
>>>
>>It will make the Connector element in server.xml really hideous, and
>>restrict component names to be valid XML attribute names (e.g.
>>channelSocket.localhost:8009 is a no-no :).  Other than that, I don't see
a
>>problem.
>>
>I'm ok to keep the file if it's the only way, but it needs at least to
>be renamed. Doesn't having a file restrict the AJP connector to
>one-per-server ? (or did I miss something ?)
>

Of course it is possible to get rid of the jk2.properties file.  You just
get Connector elements like:
  

The AJP connector is designed to be one-per-server (because of the native
APR stuff).  Of course, with mod_jk2 deprecated in TC 5.5, the need for the
one-per-server design is weaker.  Personally, I prefer to configure multiple
JkChannels on one Connector, but it seems that tastes vary here ;-).

>From the user list, it seems that people are working around this now by
setting the jkHome attribute on the connectors,  Making the config file
configurable (assuming that it stays at all :) is on the BZ wish-list (e.g.
#29780).


>Rémy


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



This message is intended only for the use of the person(s) listed above as the 
intended recipient(s), and may contain information that is PRIVILEGED and 
CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or 
distribute this message or any attachment. If you received this communication in 
error, please notify us immediately by e-mail and then delete all copies of this 
message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the 
Internet is not secure. Do not send confidential or sensitive information, such as 
social security numbers, account numbers, personal identification numbers and 
passwords, to us via ordinary (unencrypted) e-mail.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/webapps/manager/WEB-INF/classes/org/apache/catalina/manager StatusTransformer.java

2004-09-29 Thread luehe 
luehe   2004/09/29 14:11:56

  Modified:webapps/manager/WEB-INF/classes/org/apache/catalina/manager
StatusTransformer.java
  Log:
  Expose context start time in status page
  
  Revision  ChangesPath
  1.23  +6 -1  
jakarta-tomcat-catalina/webapps/manager/WEB-INF/classes/org/apache/catalina/manager/StatusTransformer.java
  
  Index: StatusTransformer.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/webapps/manager/WEB-INF/classes/org/apache/catalina/manager/StatusTransformer.java,v
  retrieving revision 1.22
  retrieving revision 1.23
  diff -u -r1.22 -r1.23
  --- StatusTransformer.java20 Sep 2004 16:31:17 -  1.22
  +++ StatusTransformer.java29 Sep 2004 21:11:56 -  1.23
  @@ -19,6 +19,7 @@
   
   import java.io.PrintWriter;
   import java.text.MessageFormat;
  +import java.util.Date;
   import java.util.Enumeration;
   import java.util.Iterator;
   import java.util.Set;
  @@ -607,6 +608,10 @@
   writer.print("");
   
   writer.print("");
  +Object startTime = mBeanServer.getAttribute(objectName,
  +"startTime");
  +writer.print(" Start time: " +
  + new Date(((Long) startTime).longValue()));
   writer.print(" Startup time: ");
   writer.print(formatTime(mBeanServer.getAttribute
   (objectName, "startupTime"), false));
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core mbeans-descriptors.xml

2004-09-29 Thread luehe 
luehe   2004/09/29 14:09:41

  Modified:catalina/src/share/org/apache/catalina/core
mbeans-descriptors.xml
  Log:
  Clarified distinction between 'startupTime' and 'startTime'
  
  Revision  ChangesPath
  1.35  +2 -2  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/mbeans-descriptors.xml
  
  Index: mbeans-descriptors.xml
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/mbeans-descriptors.xml,v
  retrieving revision 1.34
  retrieving revision 1.35
  diff -u -r1.34 -r1.35
  --- mbeans-descriptors.xml22 Sep 2004 02:10:37 -  1.34
  +++ mbeans-descriptors.xml29 Sep 2004 21:09:40 -  1.35
  @@ -168,11 +168,11 @@
  writeable="false"/>

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java

2004-09-29 Thread luehe 
luehe   2004/09/29 14:07:07

  Modified:catalina/src/share/org/apache/catalina/core
StandardContext.java
  Log:
  Fixed getStartTime() to return time when context was started (instead of time it 
took to start context)
  
  Revision  ChangesPath
  1.148 +13 -2 
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java
  
  Index: StandardContext.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
  retrieving revision 1.147
  retrieving revision 1.148
  diff -u -r1.147 -r1.148
  --- StandardContext.java  23 Sep 2004 06:58:51 -  1.147
  +++ StandardContext.java  29 Sep 2004 21:07:05 -  1.148
  @@ -1079,6 +1079,11 @@
   this.defaultWebXml = defaultWebXml;
   }
   
  +/**
  + * Gets the time (in milliseconds) it took to start this context.
  + *
  + * @return Time (in milliseconds) it took to start this context.
  + */
   public long getStartupTime() {
   return startupTime;
   }
  @@ -5408,8 +5413,14 @@
   return this.javaVMs = javaVMs;
   }
   
  +/**
  + * Gets the time this context was started.
  + *
  + * @return Time (in milliseconds since January 1, 1970, 00:00:00) when this
  + * context was started 
  + */
   public long getStartTime() {
  -return startupTime;
  +return startTime;
   }
   
   public boolean isEventProvider() {
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31474] New: - URL query string attribute duplication when using forward method

2004-09-29 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31474

URL query string attribute duplication when using forward method

   Summary: URL query string attribute duplication when using
forward method
   Product: Tomcat 3
   Version: 3.3.2 Final
  Platform: All
OS/Version: All
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Servlet
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


RequestDispatcher's forward method corrupts URL's query string, duplicating each
attribute key=value pair.  i.e. http://host/page.jsp?foo=bar might forward to
some other page, wherein the getQueryString method returns foo=bar&foo=bar.


  start contents of mdtest.jsp   **
<%

// Forward to another page
out.println("your query string:"+request.getQueryString()+"");
RequestDispatcher disp = request.getRequestDispatcher("mdtest2.jsp?" +
request.getQueryString() );
disp.forward(request, response);

%>

  end contents of mdtest.jsp   
  start contents of mdtest2.jsp  **

your query string:
  <%=request.getQueryString()%>
  click here



  end contents of mdtest2.jsp  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31473] New: - Windows installer for tomcat 5.5 mess up with tomcat 5.0 service

2004-09-29 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31473

Windows installer for tomcat 5.5 mess up with tomcat 5.0 service

   Summary: Windows installer for tomcat 5.5 mess up with tomcat 5.0
service
   Product: Tomcat 5
   Version: 5.5.2
  Platform: PC
OS/Version: Windows XP
Status: UNCONFIRMED
  Severity: Minor
  Priority: Other
 Component: Unknown
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Both windows installers for tomcat 5.0 and tomcat 5.5 creates a service named
"Tomcat5". Thus it's not possible to have both versions installed properly.
There are two options:
-install only one version at a time (tomcat 5.0 or tomcat 5.5)
-manually tweak the registry to create a separate windows service for tomcat 5.5.

I would recommand to permit to chose the service name during tomcat installation.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: More needed connector refactoring

2004-09-29 Thread Remy Maucherat 
Bill Barker wrote:
Remy Maucherat wrote:
   

Hi,
- I'll add a thread pool similar to the one in Tomcat 4.0, as an
optional policy to the current one; the idea is that it's very dumb, and
could be more stable in some environments (that RH 9 thing ...), but is
not as efficient as the current one; I'll do some benchmarks to see if
for a single CPU computer there's any difference between the two, and I
propose that whichever is the fastest for that use case becomes the
default one (with a preference for the TC 4.0 one in case of a tie, as
it's simpler)
 

I'm a bit confused - what happened with the thread pool and how did we
end up with 2 ? I missed this change.
   

There was no change yet. I was proposing (re)introducing a more 
conventional policy as an option (where I would just copy code from TC 
4.1). At least, I'll do it to see without committing anything to see how 
it compares.

- I think conf/jk2.properties should go, since we can have arbitrary
properties on the Connector element, and additionally, it has an
extremely confusing name; any comments on that ?
 

+1 :-)
   

It will make the Connector element in server.xml really hideous, and
restrict component names to be valid XML attribute names (e.g.
channelSocket.localhost:8009 is a no-no :).  Other than that, I don't see a
problem.
I'm ok to keep the file if it's the only way, but it needs at least to 
be renamed. Doesn't having a file restrict the AJP connector to 
one-per-server ? (or did I miss something ?)

Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: More needed connector refactoring

2004-09-29 Thread Bill Barker 

- Original Message -
From: "Costin Manolache" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Wednesday, September 29, 2004 9:01 AM
Subject: Re: More needed connector refactoring


> Remy Maucherat wrote:
> > Hi,
> >
> > - I'll add a thread pool similar to the one in Tomcat 4.0, as an
> > optional policy to the current one; the idea is that it's very dumb, and
> > could be more stable in some environments (that RH 9 thing ...), but is
> > not as efficient as the current one; I'll do some benchmarks to see if
> > for a single CPU computer there's any difference between the two, and I
> > propose that whichever is the fastest for that use case becomes the
> > default one (with a preference for the TC 4.0 one in case of a tie, as
> > it's simpler)
>
> I'm a bit confused - what happened with the thread pool and how did we
> end up with 2 ? I missed this change.
>
>
> > - I think conf/jk2.properties should go, since we can have arbitrary
> > properties on the Connector element, and additionally, it has an
> > extremely confusing name; any comments on that ?
>
> +1 :-)

It will make the Connector element in server.xml really hideous, and
restrict component names to be valid XML attribute names (e.g.
channelSocket.localhost:8009 is a no-no :).  Other than that, I don't see a
problem.

>
> Costin
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>


This message is intended only for the use of the person(s) listed above as the 
intended recipient(s), and may contain information that is PRIVILEGED and 
CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or 
distribute this message or any attachment. If you received this communication in 
error, please notify us immediately by e-mail and then delete all copies of this 
message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the 
Internet is not secure. Do not send confidential or sensitive information, such as 
social security numbers, account numbers, personal identification numbers and 
passwords, to us via ordinary (unencrypted) e-mail.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

2004-09-29 Thread fhanik 
fhanik  2004/09/29 12:06:53

  Modified:webapps/docs changelog.xml
  Log:
  Added notes about the recent changes to the cluster impl
  
  Revision  ChangesPath
  1.121 +11 -0 jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.120
  retrieving revision 1.121
  diff -u -r1.120 -r1.121
  --- changelog.xml 28 Sep 2004 13:32:28 -  1.120
  +++ changelog.xml 29 Sep 2004 19:06:53 -  1.121
  @@ -95,6 +95,17 @@
 
   
 
  +
  +  
  +Added flag to the cluster (notifyListenersOnReplication) to enable/disable 
the 
  +notifications of attribute/context listeners upon replication of a session 
delta
  +Works only with the DeltaManager (fhanik)
  +  
  +  
  +Added flag to the cluster (Cluster/Sender/ackTimeout) to set the timeout in 
milliseconds
  +for a synchronous request to go through, defaults to 15000ms (fhanik)
  +  
  +  
 
   
 
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/modules/cluster to-do.txt

2004-09-29 Thread fhanik 
fhanik  2004/09/29 11:59:33

  Modified:modules/cluster to-do.txt
  Log:
  Marked the item fixed
  
  Revision  ChangesPath
  1.3   +2 -1  jakarta-tomcat-catalina/modules/cluster/to-do.txt
  
  Index: to-do.txt
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/modules/cluster/to-do.txt,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- to-do.txt 24 Sep 2004 20:45:47 -  1.2
  +++ to-do.txt 29 Sep 2004 18:59:32 -  1.3
  @@ -7,5 +7,6 @@
   6. Implement context attribute replication (?)
   7. JMX friendly
   8. Documentation
  -9. Add a flag for replicated  attribute events, to enable or disable them
  +9. Add a flag for replicated  attribute events, to enable or disable them -
  +COMPLETED
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp ReplicationTransmitter.java

2004-09-29 Thread fhanik 
fhanik  2004/09/29 11:56:18

  Modified:modules/cluster/src/share/org/apache/catalina/cluster/tcp
ReplicationTransmitter.java
  Log:
  Fixed, setting the flag in the correct place
  
  Revision  ChangesPath
  1.17  +2 -2  
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationTransmitter.java
  
  Index: ReplicationTransmitter.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationTransmitter.java,v
  retrieving revision 1.16
  retrieving revision 1.17
  diff -u -r1.16 -r1.17
  --- ReplicationTransmitter.java   29 Sep 2004 18:23:55 -  1.16
  +++ ReplicationTransmitter.java   29 Sep 2004 18:56:18 -  1.17
  @@ -116,6 +116,8 @@
   {
   if (!sender.isConnected())
   sender.connect();
  +//set the timeout, will be ignored by async senders
  +sender.setAckTimeout(getAckTimeout());
   sender.sendMessage(sessionId,data);
   sender.setSuspect(false);
   addStats(data.length);
  @@ -146,8 +148,6 @@
   {
   
   IDataSender sender = senders[i];
  -//set the timeout, will be ignored by async senders
  -sender.setAckTimeout(getAckTimeout());
   try
   {
   sendMessageData(sessionId,data,sender);
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Ideas on collecting/tracing a JSP App for 404 Resources

2004-09-29 Thread Gary Helmling 
Just look at the logs:

grep " 404 " $CATALINA_HOME/logs/localhost_access_log.*


On Wed, 2004-09-29 at 04:01 -0300, Aldrin Leal wrote:
> Hello,
> 
> Looks like a simple question, but i'd like to gather some opinions:
> 
> I'd like to get all my 404 errors, their urls and referrals for a
> given Java Webapp. The idea is to perform some cleanup on a JSP
> application i just took maintenance over, as a lazy measure (so lazy
> i'm calling your help, heh).
> 
>  Any ideas?
> 
> Thanks in advance!
>  
> -- Aldrin Leal, [EMAIL PROTECTED]
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp AsyncSocketSender.java IDataSender.java ReplicationTransmitter.java

2004-09-29 Thread fhanik 
fhanik  2004/09/29 11:23:55

  Modified:catalina/src/conf server.xml
   modules/cluster/src/share/org/apache/catalina/cluster/tcp
AsyncSocketSender.java IDataSender.java
ReplicationTransmitter.java
  Log:
  Added the ability to configure the ackTimeout on synchronous replication. For users 
with a large amount of sessions or very large sessions this can be very helpful
  
  Revision  ChangesPath
  1.38  +2 -1  jakarta-tomcat-catalina/catalina/src/conf/server.xml
  
  Index: server.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/conf/server.xml,v
  retrieving revision 1.37
  retrieving revision 1.38
  diff -u -r1.37 -r1.38
  --- server.xml29 Sep 2004 16:45:27 -  1.37
  +++ server.xml29 Sep 2004 18:23:55 -  1.38
  @@ -313,7 +313,8 @@
   
   
  +replicationMode="pooled"
  +ackTimeout="15000"/>
   
   
  
  
  
  1.8   +7 -0  
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/AsyncSocketSender.java
  
  Index: AsyncSocketSender.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/AsyncSocketSender.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- AsyncSocketSender.java1 Jul 2004 09:44:27 -   1.7
  +++ AsyncSocketSender.java29 Sep 2004 18:23:55 -  1.8
  @@ -34,6 +34,7 @@
   private boolean suspect;
   
   private QueueThread queueThread = null;
  +private long ackTimeout;
   
   public AsyncSocketSender(InetAddress host, int port)  {
   this.address = host;
  @@ -122,6 +123,12 @@
   
   public void setSuspect(boolean suspect) {
   this.suspect = suspect;
  +}
  +public long getAckTimeout() {
  +return ackTimeout;
  +}
  +public void setAckTimeout(long ackTimeout) {
  +this.ackTimeout = ackTimeout;
   }
   
   private class QueueThread extends Thread {
  
  
  
  1.5   +2 -1  
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/IDataSender.java
  
  Index: IDataSender.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/IDataSender.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- IDataSender.java  27 Feb 2004 14:58:56 -  1.4
  +++ IDataSender.java  29 Sep 2004 18:23:55 -  1.5
  @@ -35,4 +35,5 @@
   public boolean isConnected();
   public void setSuspect(boolean suspect);
   public boolean getSuspect();
  -}
  \ No newline at end of file
  +public void setAckTimeout(long timeout);
  +}
  
  
  
  1.16  +10 -0 
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationTransmitter.java
  
  Index: ReplicationTransmitter.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationTransmitter.java,v
  retrieving revision 1.15
  retrieving revision 1.16
  diff -u -r1.15 -r1.16
  --- ReplicationTransmitter.java   27 Feb 2004 14:58:56 -  1.15
  +++ ReplicationTransmitter.java   29 Sep 2004 18:23:55 -  1.16
  @@ -34,6 +34,8 @@
   private static long nrOfRequests = 0;
   private static long totalBytes = 0;
   private String replicationMode;
  +private long ackTimeout = 15000; //15 seconds by default
  +
   private static synchronized void addStats(int length) {
   nrOfRequests++;
   totalBytes+=length;
  @@ -144,6 +146,8 @@
   {
   
   IDataSender sender = senders[i];
  +//set the timeout, will be ignored by async senders
  +sender.setAckTimeout(getAckTimeout());
   try
   {
   sendMessageData(sessionId,data,sender);
  @@ -162,6 +166,12 @@
   public boolean getIsSenderSynchronized() {
   return IDataSenderFactory.SYNC_MODE.equals(replicationMode) ||
   IDataSenderFactory.POOLED_SYNC_MODE.equals(replicationMode);
  +}
  +public long getAckTimeout() {
  +return ackTimeout;
  +}
  +public void setAckTimeout(long ackTimeout) {
  +this.ackTimeout = ackTimeout;
   }
   
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

2004-09-29 Thread markt 
markt   2004/09/29 11:02:22

  Modified:webapps/docs Tag: TOMCAT_5_0 changelog.xml
  Log:
  Update change log with CGI servlet fix.
  
  Revision  ChangesPath
  No   revision
  No   revision
  1.70.2.45 +3 -0  jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.70.2.44
  retrieving revision 1.70.2.45
  diff -u -r1.70.2.44 -r1.70.2.45
  --- changelog.xml 28 Sep 2004 13:23:11 -  1.70.2.44
  +++ changelog.xml 29 Sep 2004 18:02:21 -  1.70.2.45
  @@ -110,6 +110,9 @@
 
   31058: Ensure StatusTransformer escapes query string for XML. 
(yoavs)
 
  +  
  +CGI Servlet: Revert the fix for 27090 as it introduced a JDK 1.4 
dependency. (markt)
  +  
   
 
 
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/catalina/src/conf server.xml

2004-09-29 Thread fhanik 
fhanik  2004/09/29 09:45:27

  Modified:catalina/src/conf server.xml
  Log:
  Added flag to enable/disable attribute/context events during session delta 
replication
  
  Revision  ChangesPath
  1.37  +2 -1  jakarta-tomcat-catalina/catalina/src/conf/server.xml
  
  Index: server.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/conf/server.xml,v
  retrieving revision 1.36
  retrieving revision 1.37
  diff -u -r1.36 -r1.37
  --- server.xml31 Jul 2004 17:13:53 -  1.36
  +++ server.xml29 Sep 2004 16:45:27 -  1.37
  @@ -294,7 +294,8 @@
   
  + useDirtyFlag="true"
  + notifyListenersOnReplication="true">

cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp SimpleTcpCluster.java

2004-09-29 Thread fhanik 
fhanik  2004/09/29 09:43:45

  Modified:modules/cluster/src/share/org/apache/catalina/cluster
ClusterManager.java
   modules/cluster/src/share/org/apache/catalina/cluster/session
DeltaManager.java DeltaRequest.java
DeltaSession.java SimpleTcpReplicationManager.java
   modules/cluster/src/share/org/apache/catalina/cluster/tcp
SimpleTcpCluster.java
  Log:
  Added flag to enabled/disable attribute/context events during session delta 
replication
  
  Revision  ChangesPath
  1.7   +4 -0  
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/ClusterManager.java
  
  Index: ClusterManager.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/ClusterManager.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- ClusterManager.java   22 Jul 2004 15:41:15 -  1.6
  +++ ClusterManager.java   29 Sep 2004 16:43:44 -  1.7
  @@ -71,5 +71,9 @@
  public void setUseDirtyFlag(boolean useDirtyFlag);
  
  public void setCluster(CatalinaCluster cluster);
  +   
  +   public boolean getNotifyListenersOnReplication();
  +   
  +   public void setNotifyListenersOnReplication(boolean 
notifyListenersOnReplication);
   
   }
  
  
  
  1.31  +12 -2 
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java
  
  Index: DeltaManager.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java,v
  retrieving revision 1.30
  retrieving revision 1.31
  diff -u -r1.30 -r1.31
  --- DeltaManager.java 5 Sep 2004 22:03:42 -   1.30
  +++ DeltaManager.java 29 Sep 2004 16:43:44 -  1.31
  @@ -128,6 +128,8 @@
   private boolean useDirtyFlag;
   private boolean expireSessionsOnShutdown;
   private boolean printToScreen;
  +
  +private boolean notifyListenersOnReplication = false;
   // - Constructor
   public DeltaManager() {
   super();
  @@ -895,7 +897,7 @@
  DeltaSession session = 
(DeltaSession)findSession(msg.getSessionID());
  if (session != null) {
  DeltaRequest dreq = loadDeltaRequest(session, delta);
  -   dreq.execute(session);
  +   dreq.execute(session,notifyListenersOnReplication);
  session.setPrimarySession(false);
  }
  
  @@ -984,6 +986,14 @@
   }
   public void setName(String name) {
   this.name = name;
  +}
  +
  +public boolean getNotifyListenersOnReplication() {
  +return notifyListenersOnReplication;
  +}
  +
  +public void setNotifyListenersOnReplication(boolean 
notifyListenersOnReplication) {
  +this.notifyListenersOnReplication = notifyListenersOnReplication;
   }
   
   
  
  
  
  1.9   +9 -5  
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaRequest.java
  
  Index: DeltaRequest.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaRequest.java,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- DeltaRequest.java 1 Jul 2004 09:44:26 -   1.8
  +++ DeltaRequest.java 29 Sep 2004 16:43:44 -  1.9
  @@ -55,7 +55,7 @@
   public DeltaRequest() {
   
   }
  -
  +
   public DeltaRequest(String sessionId, boolean recordAllActions) {
   this.recordAllActions=recordAllActions;
   setSessionId(sessionId);
  @@ -108,8 +108,12 @@
   //add the action
   actions.addLast(info);
   }
  -
  +
   public void execute(DeltaSession session) {
  +execute(session,true);
  +}
  +
  +public void execute(DeltaSession session, boolean notifyListeners) {
   if ( !this.sessionId.equals( session.getId() ) )
   throw new java.lang.IllegalArgumentException("Session id mismatch, not 
executing the delta request");
   session.access();
  @@ -118,9 +122,9 @@
   switch ( info.getType() ) {
   case TYPE_ATTRIBUTE: {
   if ( info.getAction() == ACTION_SET ) {
  -session.setAttribute(info.getName(), info.getValue(),false);
  +session.setAttribute(info.getName(), 
info.getValue(),notifyListeners,false);

Re: More needed connector refactoring

2004-09-29 Thread Costin Manolache 
Remy Maucherat wrote:
Hi,
- I'll add a thread pool similar to the one in Tomcat 4.0, as an 
optional policy to the current one; the idea is that it's very dumb, and 
could be more stable in some environments (that RH 9 thing ...), but is 
not as efficient as the current one; I'll do some benchmarks to see if 
for a single CPU computer there's any difference between the two, and I 
propose that whichever is the fastest for that use case becomes the 
default one (with a preference for the TC 4.0 one in case of a tie, as 
it's simpler)
I'm a bit confused - what happened with the thread pool and how did we 
end up with 2 ? I missed this change.


- I think conf/jk2.properties should go, since we can have arbitrary 
properties on the Connector element, and additionally, it has an 
extremely confusing name; any comments on that ?
+1 :-)
Costin
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31465] New: - JSP encoding is wrong

2004-09-29 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31465

JSP encoding is wrong

   Summary: JSP encoding is wrong
   Product: Tomcat 5
   Version: 5.5.2
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Jasper
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I have the following text in a JSP with no encoding declared:

Copyright © 2003 by 

The copyright symbol does not come out correctly. I checked the file and the 
stored character code is 0xA9 which is correct for ISO-8859-1. I checked the 
JSP 2.0 spec and the default encoding is still supposed to be ISO-8859-1. Yet 
the result is

Copyright © 2003 by

This can be easily reproduced by creating an empty web application and putting 
just Copyright © 2003 by into a jsp file.

Looking at the generated Java file I see

  out.write("Copyright © 2003 by\r\n");

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 30354] - Wrong task in example ant build.xml

2004-09-29 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=30354

Wrong task in example ant build.xml

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2004-09-29 13:57 ---
*** Bug 31456 has been marked as a duplicate of this bug. ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31456] - Error in Users Guide / Manager/Custom Ant Task example

2004-09-29 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31456

Error in Users Guide / Manager/Custom Ant Task example

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2004-09-29 13:57 ---


*** This bug has been marked as a duplicate of 30354 ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31456] - Error in Users Guide / Manager/Custom Ant Task example

2004-09-29 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31456

Error in Users Guide / Manager/Custom Ant Task example





--- Additional Comments From [EMAIL PROTECTED]  2004-09-29 13:56 ---
Created an attachment (id=12892)
Duplicate

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Yahoo! Auto Response

2004-09-29 Thread ressl 
The following errors occurred when trying to deliver the attached mail:

mressl: User unknown
--- The original message sent:
Received: from mail.yahoo.com (mail.yahoo.com [149.221.144.178]) by mailer.test.com 
(mail500) with ESMTP id i7UHa055008514  for <[EMAIL PROTECTED]>; Mon, 30 Aug 2004 
13:36:00 -0400 (EDT)
Message-ID: <[EMAIL PROTECTED]>
Date: Mon, 30 Aug 2004 19:35:45 +0200
MIME-Version: 1.0
To: [EMAIL PROTECTED]





Original Message:


X-YahooFilteredBulk: 202.164.43.25
X-Originating-IP: [202.164.43.25]
Return-Path: <[EMAIL PROTECTED]>
Received: from 202.164.43.25  (EHLO geocities.com) (202.164.43.25)
  by mta363.mail.scd.yahoo.com with SMTP; Wed, 29 Sep 2004 06:24:49 -0700
From: [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Subject: Mail Delivery (failure [EMAIL PROTECTED])
Date: Wed, 29 Sep 2004 18:50:55 +0530
MIME-Version: 1.0
Content-Type: multipart/related;
type="multipart/alternative";
boundary="=_NextPart_000_001B_01C0CA80.6B015D10"
X-Priority: 3
X-MSMail-Priority: Normal

This is a multi-part message in MIME format.

--=_NextPart_000_001B_01C0CA80.6B015D10
Content-Type: multipart/alternative;
boundary="=_NextPart_001_001C_01C0CA80.6B015D10"

--=_NextPart_001_001C_01C0CA80.6B015D10
Content-Type: text/plain;
charset="iso-8859-1"
Content-Tra
_
DO YOU YAHOO!?
Get your free @yahoo.com address at http://mail.yahoo.com


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

More needed connector refactoring

2004-09-29 Thread Remy Maucherat 
Hi,
- I'll add a thread pool similar to the one in Tomcat 4.0, as an 
optional policy to the current one; the idea is that it's very dumb, and 
could be more stable in some environments (that RH 9 thing ...), but is 
not as efficient as the current one; I'll do some benchmarks to see if 
for a single CPU computer there's any difference between the two, and I 
propose that whichever is the fastest for that use case becomes the 
default one (with a preference for the TC 4.0 one in case of a tie, as 
it's simpler)
- I think conf/jk2.properties should go, since we can have arbitrary 
properties on the Connector element, and additionally, it has an 
extremely confusing name; any comments on that ?

Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22388] - TC 5.0.7 Startup Exception

2004-09-29 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=22388

TC 5.0.7 Startup Exception

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2004-09-29 10:49 ---
*** Bug 31462 has been marked as a duplicate of this bug. ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31462] - ConcurrentModificationException in coyote initialization

2004-09-29 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31462

ConcurrentModificationException in coyote initialization

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2004-09-29 10:49 ---


*** This bug has been marked as a duplicate of 22388 ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31462] New: - ConcurrentModificationException in coyote initialization

2004-09-29 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31462

ConcurrentModificationException in coyote initialization

   Summary: ConcurrentModificationException in coyote initialization
   Product: Tomcat 5
   Version: 5.0.28
  Platform: Sun
OS/Version: Solaris
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Connector:Coyote
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
CC: [EMAIL PROTECTED]


I'm sorry I could not reproduce it again. But the scenario follows.

I had Tomcat running with my 5 webapps plus the default ones (except the default
ROOT). I stopped it, removed all the application sub-dirs from /webapps to force
the reload.

I restarted Tomcat and - eager to see my new pages - I pointed my browser to a
webapp URL. I usually do this and things go ok, it takes a while and then shows
me the right page. But not this time. I received a "resource not available"
message. When I went to check in the log, I saw the weird stack trace below.

When I stopped Tomcat and restarted it, things went OK and I could use my webapps.

I wrote about my new deployment because the time spent and concurrent threads
trying to deploy/start/duno may have something to do with the exception. The
stack trace follows.

Sep 29, 2004 11:33:03 AM org.apache.coyote.http11.Http11Protocol start
INFO: Starting Coyote HTTP/1.1 on http-8080
Sep 29, 2004 11:33:04 AM org.apache.coyote.http11.Http11Protocol start
INFO: Starting Coyote HTTP/1.1 on http-443
Sep 29, 2004 11:33:04 AM org.apache.coyote.tomcat5.MapperListener init
WARNING: Error registering contexts
java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextEntry(HashMap.java:782)
at java.util.HashMap$EntryIterator.next(HashMap.java:824)
at java.util.HashMap.putAllForCreate(HashMap.java:424)
at java.util.HashMap.clone(HashMap.java:656)
at mx4j.server.DefaultMBeanRepository.clone(DefaultMBeanRepository.java:56)
at
mx4j.server.MBeanServerImpl.findMBeansByPattern(MBeanServerImpl.java:1603)
at mx4j.server.MBeanServerImpl.queryObjectNames(MBeanServerImpl.java:1568)
at mx4j.server.MBeanServerImpl.queryMBeans(MBeanServerImpl.java:1512)
at org.apache.coyote.tomcat5.MapperListener.init(MapperListener.java:136)
at
org.apache.coyote.tomcat5.CoyoteConnector.start(CoyoteConnector.java:1537)
at org.apache.catalina.core.StandardService.start(StandardService.java:489)
at org.apache.catalina.core.StandardServer.start(StandardServer.java:2313)
at org.apache.catalina.startup.Catalina.start(Catalina.java:556)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:324)
at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:287)
at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:425)
Sep 29, 2004 11:33:04 AM org.apache.jk.common.ChannelSocket init
INFO: JK2: ajp13 listening on /0.0.0.0:8009
Sep 29, 2004 11:33:04 AM org.apache.jk.server.JkMain start

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup ConnectorCreateRule.java Embedded.java Catalina.java

2004-09-29 Thread remm 
remm2004/09/29 02:55:39

  Modified:catalina/src/share/org/apache/catalina/mbeans
ConnectorMBean.java MBeanFactory.java
   catalina/src/share/org/apache/catalina/connector
Connector.java mbeans-descriptors.xml
   catalina/src/share/org/apache/catalina/startup Embedded.java
Catalina.java
  Added:   catalina/src/share/org/apache/catalina/startup
ConnectorCreateRule.java
  Log:
  - Refactor connector a little.
  - Remove many fields from Connector.
  - Tie the creation of the Connector to the creation of the protocol handler.
  
  Revision  ChangesPath
  1.9   +37 -118   
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbeans/ConnectorMBean.java
  
  Index: ConnectorMBean.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbeans/ConnectorMBean.java,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- ConnectorMBean.java   2 Aug 2004 06:13:32 -   1.8
  +++ ConnectorMBean.java   29 Sep 2004 09:55:37 -  1.9
  @@ -75,48 +75,30 @@
* @exception ReflectionException if a Java reflection exception
*  occurs when invoking the getter
*/
  -public Object getAttribute(String name)
  -throws AttributeNotFoundException, MBeanException,
  -ReflectionException {
  - 
  - Object attribute = null;
  +public Object getAttribute(String name) throws AttributeNotFoundException,
  +MBeanException, ReflectionException {
  +
  +Object attribute = null;
   // Validate the input parameters
   if (name == null)
  -throw new RuntimeOperationsException
  -(new IllegalArgumentException("Attribute name is null"),
  - "Attribute name is null");
  -  
  -Connector connector = null;
  - try {
  - connector = (Connector) getManagedResource();
  - } catch (InstanceNotFoundException e) {
  - throw new MBeanException(e);
  - } catch (InvalidTargetObjectTypeException e) {
  -throw new MBeanException(e);
  -}
  - 
  - if (isProtocolProperty(name)) {
  -
  -name = translateAttributeName(name);
  -
  -ProtocolHandler protocolHandler = connector.getProtocolHandler();
  - /* check the Protocol first, since JkCoyote has an independent
  - * configure method.
  - */
  -try {
  -if( protocolHandler != null ) {
  -attribute = IntrospectionUtils.getAttribute(protocolHandler, 
name);
  -} else {
  -attribute = connector.getProperty(name);
  -}
  -} catch (Exception e) {
  -throw new MBeanException(e);
  +throw new RuntimeOperationsException(new IllegalArgumentException(
  +"Attribute name is null"), "Attribute name is null");
  +
  +Object result = null;
  +try {
  +Connector connector = (Connector) getManagedResource();
  +result = IntrospectionUtils.getProperty(connector, name);
  +// FIXME: I don't understand why this is needed
  +if (result == null) {
  +result = 
IntrospectionUtils.getProperty(connector.getProtocolHandler(), name);
   }
  - } else {
  - attribute = super.getAttribute(name);
  - }
  - 
  -return attribute;
  +} catch (InstanceNotFoundException e) {
  +throw new MBeanException(e);
  +} catch (InvalidTargetObjectTypeException e) {
  +throw new MBeanException(e);
  +}
  +
  +return result;
   
   }
   
  @@ -135,92 +117,29 @@
*  occurs when invoking the getter
*/
public void setAttribute(Attribute attribute)
  -throws AttributeNotFoundException, MBeanException,
  -ReflectionException {
  +throws AttributeNotFoundException, MBeanException,
  +ReflectionException {
   
   // Validate the input parameters
   if (attribute == null)
  -throw new RuntimeOperationsException
  -(new IllegalArgumentException("Attribute is null"),
  - "Attribute is null");
  +throw new RuntimeOperationsException(new IllegalArgumentException(
  +"Attribute is null"), "Attribute is null");
   String name = attribute.getName();
   Object value = attribute.getValue();
   if (name == null)
  -throw new RuntimeOperationsException
  -(new IllegalArgumentException("Attribute name is null"),
  - "Attrib

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Constants.java Http11Processor.java Http11Protocol.java

2004-09-29 Thread remm 
remm2004/09/29 02:54:28

  Modified:http11/src/java/org/apache/coyote/http11 Constants.java
Http11Processor.java Http11Protocol.java
  Log:
  - Add a utility method to convert strings to byte arrays.
  - Add a few additional byte arrays.
  
  Revision  ChangesPath
  1.23  +27 -74
jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Constants.java
  
  Index: Constants.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Constants.java,v
  retrieving revision 1.22
  retrieving revision 1.23
  diff -u -r1.22 -r1.23
  --- Constants.java24 Feb 2004 08:50:56 -  1.22
  +++ Constants.java29 Sep 2004 09:54:28 -  1.23
  @@ -39,12 +39,13 @@
   public static final int DEFAULT_SERVER_SOCKET_TIMEOUT = 0;
   public static final boolean DEFAULT_TCP_NO_DELAY = true;
   
  +
   /**
* Server string.
*/
  -public static final String SERVER = "Apache-Coyote/1.1";
  -
  +public static final byte[] SERVER_BYTES = convertToBytes("Apache-Coyote/1.1");
   
  +
   /**
* CR.
*/
  @@ -116,47 +117,17 @@
*/
   public static final String CRLF = "\r\n";
   
  -
  -/**
  - * CRLF bytes.
  - */
  -public static final byte[] CRLF_BYTES = {(byte) '\r', (byte) '\n'};
  -
  -
  -/**
  - * Colon bytes.
  - */
  -public static final byte[] COLON_BYTES = {(byte) ':', (byte) ' '};
  -
  -
  -/**
  - * Close bytes.
  - */
  -public static final byte[] CLOSE_BYTES = {
  -(byte) 'c',
  -(byte) 'l',
  -(byte) 'o',
  -(byte) 's',
  -(byte) 'e'
  -};
  -
  -
  -/**
  - * Keep-alive bytes.
  - */
  -public static final byte[] KEEPALIVE_BYTES = {
  -(byte) 'k',
  -(byte) 'e',
  -(byte) 'e',
  -(byte) 'p',
  -(byte) '-',
  -(byte) 'a',
  -(byte) 'l',
  -(byte) 'i',
  -(byte) 'v',
  -(byte) 'e'
  -};
  -
  +
  +/* Various constant "strings" */
  +public static final byte[] CRLF_BYTES = convertToBytes(CRLF);
  +public static final byte[] COLON_BYTES = convertToBytes(": ");
  +public static final byte[] CONNECTION_BYTES = convertToBytes("Connection");
  +public static final byte[] CLOSE_BYTES = convertToBytes("close");
  +public static final byte[] KEEPALIVE_BYTES = convertToBytes("keep-alive");
  +public static final byte[] CHUNKED_BYTES = convertToBytes("chunked");
  +public static final byte[] ACK_BYTES = convertToBytes("HTTP/1.1 100 Continue" + 
CRLF + CRLF);
  +public static final byte[] TRANSFERENCODING_BYTES = 
convertToBytes("Transfer-Encoding");
  +
   
   /**
* Identity filters (input and output).
  @@ -219,35 +190,17 @@
   
   
   /**
  - * Ack string when pipelining HTTP requests.
  - */
  -public static final byte[] ACK_BYTES = {
  -(byte) 'H',
  -(byte) 'T',
  -(byte) 'T',
  -(byte) 'P',
  -(byte) '/',
  -(byte) '1',
  -(byte) '.',
  -(byte) '1',
  -(byte) ' ',
  -(byte) '1',
  -(byte) '0',
  -(byte) '0',
  -(byte) ' ',
  -(byte) 'C',
  -(byte) 'o',
  -(byte) 'n',
  -(byte) 't',
  -(byte) 'i',
  -(byte) 'n',
  -(byte) 'u',
  -(byte) 'e',
  -(byte) '\r',
  -(byte) '\n',
  -(byte) '\r',
  -(byte) '\n'
  -};
  -
  -
  + * Utility method.
  + * 
  + * @param value to convert to byte array
  + * @return the byte array value
  + */
  +public static final byte[] convertToBytes(String value) {
  +byte[] result = new byte[value.length()];
  +for (int i = 0; i < value.length(); i++) {
  +result[i] = (byte) value.charAt(i);
  +}
  +return result;
  +}
  +
   }
  
  
  
  1.111 +15 -6 
jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Processor.java
  
  Index: Http11Processor.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Processor.java,v
  retrieving revision 1.110
  retrieving revision 1.111
  diff -u -r1.110 -r1.111
  --- Http11Processor.java  15 Sep 2004 00:16:05 -  1.110
  +++ Http11Processor.java  29 Sep 2004 09:54:28 -  1.111
  @@ -300,7 +300,7 @@
   /**
* Allow a customized the server header for the tin-foil hat folks.
*/
  -protected String server = Constants.SERVER;
  +protected String server = null;
   
   
   // - Properties
  @@ -708,7 +708,7 @@
*/
   public v

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/digester Digester.java BeanPropertySetterRule.java ExtendedBaseRules.java

2004-09-29 Thread remm 
remm2004/09/29 02:52:11

  Modified:util/java/org/apache/tomcat/util/digester Digester.java
  Removed: util/java/org/apache/tomcat/util/digester
BeanPropertySetterRule.java ExtendedBaseRules.java
  Log:
  - Remove useless stuff in digester.
  
  Revision  ChangesPath
  1.6   +1 -30 
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/digester/Digester.java
  
  Index: Digester.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/digester/Digester.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- Digester.java 24 Sep 2004 07:27:04 -  1.5
  +++ Digester.java 29 Sep 2004 09:52:11 -  1.6
  @@ -1694,35 +1694,6 @@
   
   
   /**
  - * Add a "bean property setter" rule for the specified parameters.
  - *
  - * @param pattern Element matching pattern
  - * @see BeanPropertySetterRule
  - */
  -public void addBeanPropertySetter(String pattern) {
  -
  -addRule(pattern,
  -new BeanPropertySetterRule());
  -
  -}
  -
  -
  -/**
  - * Add a "bean property setter" rule for the specified parameters.
  - *
  - * @param pattern Element matching pattern
  - * @param propertyName Name of property to set
  - * @see BeanPropertySetterRule
  - */
  -public void addBeanPropertySetter(String pattern,
  -  String propertyName) {
  -
  -addRule(pattern,
  -new BeanPropertySetterRule(propertyName));
  -
  -}
  -
  -/**
* Add an "call method" rule for a method which accepts no arguments.
*
* @param pattern Element matching pattern
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Ideas on collecting/tracing a JSP App for 404 Resources

2004-09-29 Thread Aldrin Leal 
Hello,

Looks like a simple question, but i'd like to gather some opinions:

I'd like to get all my 404 errors, their urls and referrals for a
given Java Webapp. The idea is to perform some cleanup on a JSP
application i just took maintenance over, as a lazy measure (so lazy
i'm calling your help, heh).

 Any ideas?

Thanks in advance!
 
-- Aldrin Leal, [EMAIL PROTECTED]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]