DO NOT REPLY [Bug 33368] - swallowOutput causes memory leak

2005-02-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33368.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33368





--- Additional Comments From [EMAIL PROTECTED]  2005-02-05 10:51 ---
Thanks, but as I have stated, I am not interested in this way to fix it ;)

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33357] - DataSourceRealm leaks connections

2005-02-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33357.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33357


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-02-05 11:36 ---
I have applied your patch.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jni/java/org/apache/tomcat/jni Socket.java

2005-02-05 Thread mturk
mturk   2005/02/05 04:31:05

  Modified:jni/java/org/apache/tomcat/jni Socket.java
  Log:
  Fix native call naming for recvFrom
  
  Revision  ChangesPath
  1.3   +3 -3  
jakarta-tomcat-connectors/jni/java/org/apache/tomcat/jni/Socket.java
  
  Index: Socket.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jni/java/org/apache/tomcat/jni/Socket.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- Socket.java   14 Jan 2005 14:42:37 -  1.2
  +++ Socket.java   5 Feb 2005 12:31:05 -   1.3
  @@ -245,8 +245,8 @@
* @param nbytes The number of bytes to read (-1) for full array.
* @return the number of bytes received.
*/
  -public static native int recv(long from, long sock, int flags,
  -  byte[] buf, int nbytes)
  +public static native int recvFrom(long from, long sock, int flags,
  +  byte[] buf, int nbytes)
   throws Error;
   
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jni/java/org/apache/tomcat/jni Pool.java

2005-02-05 Thread mturk
mturk   2005/02/05 04:31:35

  Modified:jni/java/org/apache/tomcat/jni Pool.java
  Log:
  Fix native call declaration for ByteBuffers
  
  Revision  ChangesPath
  1.4   +3 -3  
jakarta-tomcat-connectors/jni/java/org/apache/tomcat/jni/Pool.java
  
  Index: Pool.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jni/java/org/apache/tomcat/jni/Pool.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- Pool.java 3 Feb 2005 07:48:32 -   1.3
  +++ Pool.java 5 Feb 2005 12:31:35 -   1.4
  @@ -119,7 +119,7 @@
* @param size The amount of memory to allocate
* @return The ByteBuffer with allocated memory
*/
  -public static ByteBuffer alloc(long p, int size);
  +public static native ByteBuffer alloc(long p, int size);
   
   /**
* Allocate a block of memory from a pool and set all of the memory to 0
  @@ -127,6 +127,6 @@
* @param size The amount of memory to allocate
* @return The ByteBuffer with allocated memory
*/
  -public static ByteBuffer calloc(long p, int size);
  +public static native ByteBuffer calloc(long p, int size);
   
   }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jni/java/org/apache/tomcat/jni Poll.java

2005-02-05 Thread mturk
mturk   2005/02/05 04:32:20

  Modified:jni/java/org/apache/tomcat/jni Poll.java
  Log:
  Add native methods for accessing apr_pollset_fd struct data.
  
  Revision  ChangesPath
  1.3   +18 -1 
jakarta-tomcat-connectors/jni/java/org/apache/tomcat/jni/Poll.java
  
  Index: Poll.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jni/java/org/apache/tomcat/jni/Poll.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- Poll.java 14 Jan 2005 14:42:37 -  1.2
  +++ Poll.java 5 Feb 2005 12:32:20 -   1.3
  @@ -102,5 +102,22 @@
 long [] descriptors)
   throws Error;
   
  +/**
  + * Return socket from poll descriptor
  + * @param polldesc The pollset decriptor to use
  + */
  +public static native long socket(long polldesc);
  +
  +/**
  + * Return client data from poll descriptor
  + * @param polldesc The pollset decriptor to use
  + */
  +public static native long data(long polldesc);
  +
  +/**
  + * Return rtnevents from poll descriptor
  + * @param polldesc The pollset decriptor to use
  + */
  +public static native int events(long polldesc);
   
   }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jni/native/src poll.c

2005-02-05 Thread mturk
mturk   2005/02/05 04:32:36

  Modified:jni/native/src poll.c
  Log:
  Add native methods for accessing apr_pollset_fd struct data.
  
  Revision  ChangesPath
  1.2   +21 -0 jakarta-tomcat-connectors/jni/native/src/poll.c
  
  Index: poll.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jni/native/src/poll.c,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- poll.c14 Jan 2005 13:47:58 -  1.1
  +++ poll.c5 Feb 2005 12:32:36 -   1.2
  @@ -103,3 +103,24 @@
   
   return (jint)num;
   }
  +
  +TCN_IMPLEMENT_CALL(jlong, Poll, socket)(TCN_STDARGS, jlong pollfd)
  +{
  +apr_pollfd_t *fd = J2P(pollfd,  apr_pollfd_t *);
  +UNREFERENCED_STDARGS;;
  +return P2J(fd-desc.s);
  +}
  +
  +TCN_IMPLEMENT_CALL(jlong, Poll, data)(TCN_STDARGS, jlong pollfd)
  +{
  +apr_pollfd_t *fd = J2P(pollfd,  apr_pollfd_t *);
  +UNREFERENCED_STDARGS;;
  +return P2J(fd-client_data);
  +}
  +
  +TCN_IMPLEMENT_CALL(jint, Poll, events)(TCN_STDARGS, jlong pollfd)
  +{
  +apr_pollfd_t *fd = J2P(pollfd,  apr_pollfd_t *);
  +UNREFERENCED_STDARGS;;
  +return (jint)fd-rtnevents;
  +}
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jni/native/src network.c

2005-02-05 Thread mturk
mturk   2005/02/05 04:33:09

  Modified:jni/native/src network.c
  Log:
  Fix accept call returning newly accepted socket.
  
  Revision  ChangesPath
  1.2   +1 -1  jakarta-tomcat-connectors/jni/native/src/network.c
  
  Index: network.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jni/native/src/network.c,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- network.c 14 Jan 2005 13:47:58 -  1.1
  +++ network.c 5 Feb 2005 12:33:09 -   1.2
  @@ -159,7 +159,7 @@
   TCN_THROW_IF_ERR(apr_socket_accept(n, s, p), s);
   
   cleanup:
  -return P2J(s);
  +return P2J(n);
   }
   
   TCN_IMPLEMENT_CALL(jint, Socket, connect)(TCN_STDARGS, jlong sock,
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jni build.xml

2005-02-05 Thread mturk
mturk   2005/02/05 04:33:25

  Modified:jni  build.xml
  Log:
  Add examples to build
  
  Revision  ChangesPath
  1.2   +40 -1 jakarta-tomcat-connectors/jni/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jni/build.xml,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- build.xml 15 Jan 2005 11:27:31 -  1.1
  +++ build.xml 5 Feb 2005 12:33:25 -   1.2
  @@ -39,7 +39,7 @@
   
   !-- Build classpath --
   path id=classpath
  -pathelement location=${build.dest}/
  +pathelement location=${build.dest}/java/
   /path
   
   !-- Test classpath --
  @@ -148,6 +148,45 @@
   /copy
   /target
   
  +!-- === 
--
  +!-- Compiles the examples directory 
--
  +!-- === 
--
  +target name=examples depends=compile
  +mkdir dir=${build.dest}/
  +mkdir dir=${build.dest}/examples/
  +mkdir dir=${build.src}/
  +mkdir dir=${build.src}/examples/
  +tstamp
  +format property=TODAY pattern=MMM d  locale=en/
  +format property=TSTAMP pattern=hh:mm:ss/
  +/tstamp
  +!-- Copy static resource files --
  +filter token=VERSION value=${version}/
  +filter token=VERSION_NUMBER value=${version.number}/
  +filter token=VERSION_BUILT value=${TODAY} ${TSTAMP}/
  +copy todir=${build.src}/examples filtering=yes
  +fileset dir=${src.dir}/examples
  +include name=**/*.java/
  +include name=**/*.xml/
  +include name=**/*.properties/
  +/fileset
  +/copy
  +
  +javac srcdir=${build.src}/examples
  +destdir=${build.dest}/examples
  +debug=${debug}
  +deprecation=${deprecation}
  +optimize=${optimize}
  +classpath refid=examples.classpath/
  +/javac
  +copy todir=${build.dest}/examples filtering=yes
  +fileset dir=${build.src}/examples
  +include name=**/*.xml/
  +include name=**/*.properties/
  +/fileset
  +/copy
  +/target
  +
   !-- == 
--
   !-- Make Tomcat Native jar 
--
   !-- == 
--
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jni/examples - New directory

2005-02-05 Thread mturk
mturk   2005/02/05 04:33:33

  jakarta-tomcat-connectors/jni/examples - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jni/examples/org - New directory

2005-02-05 Thread mturk
mturk   2005/02/05 04:33:41

  jakarta-tomcat-connectors/jni/examples/org - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jni/examples/org/apache - New directory

2005-02-05 Thread mturk
mturk   2005/02/05 04:33:46

  jakarta-tomcat-connectors/jni/examples/org/apache - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jni/examples/org/apache/tomcat - New directory

2005-02-05 Thread mturk
mturk   2005/02/05 04:33:51

  jakarta-tomcat-connectors/jni/examples/org/apache/tomcat - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jni/examples/org/apache/tomcat/jni - New directory

2005-02-05 Thread mturk
mturk   2005/02/05 04:33:56

  jakarta-tomcat-connectors/jni/examples/org/apache/tomcat/jni - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jni/examples/org/apache/tomcat/jni Echo.java Echo.properties

2005-02-05 Thread mturk
mturk   2005/02/05 04:34:47

  Added:   jni/examples/org/apache/tomcat/jni Echo.java Echo.properties
  Log:
  Add simpe Echo server with pollset for nonblocking
  call after the first message is read.
  
  Revision  ChangesPath
  1.1  
jakarta-tomcat-connectors/jni/examples/org/apache/tomcat/jni/Echo.java
  
  Index: Echo.java
  ===
  /*
   *  Copyright 1999-2004 The Apache Software Foundation
   *
   *  Licensed under the Apache License, Version 2.0 (the License);
   *  you may not use this file except in compliance with the License.
   *  You may obtain a copy of the License at
   *
   *  http://www.apache.org/licenses/LICENSE-2.0
   *
   *  Unless required by applicable law or agreed to in writing, software
   *  distributed under the License is distributed on an AS IS BASIS,
   *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   *  See the License for the specific language governing permissions and
   *  limitations under the License.
   */
  
  package org.apache.tomcat.jni;
  
  import java.util.Properties;
  
  import java.io.*;
  import java.net.*;
  import java.lang.*;
  
  /** Echo server example
   *
   * @author Mladen Turk
   * @version $Revision: 1.1 $, $Date: 2005/02/05 12:34:47 $
   */
  
  public class Echo {
  
  public static String echoEcho = null;
  public static String echoAddr = null;
  public static int echoPort= 0;
  public static int echoNmax= 0;
  public static int echoNrun= 0;
  public static long echoPool   = 0;
  
  private static Poller echoPoller = null;
  private static Acceptor echoAcceptor = null;
  
  private static Object threadLock = new Object();
  
  static {
  
  try {
  InputStream is = Echo.class.getResourceAsStream
  (/org/apache/tomcat/jni/Echo.properties);
  Properties props = new Properties();
  props.load(is);
  is.close();
  echoAddr = props.getProperty(echo.ip, 127.0.0.1);
  echoPort = Integer.decode(props.getProperty(echo.port, 23));
  echoNmax = Integer.decode(props.getProperty(echo.max, 1));
  }
  catch (Throwable t) {
  ; // Nothing
  }
  }
  
  /* Acceptor thread. Listens for new connections */
  private class Acceptor extends Thread {
  private long serverSock = 0;
  private long inetAddress = 0;
  private long pool = 0;
  public Acceptor() {
  try {
  
  pool = Pool.create(Echo.echoPool);
  System.out.println(Accepting:  +  Echo.echoAddr + : +
 Echo.echoPort);
  inetAddress = Address.info(Echo.echoAddr, Socket.APR_INET,
 Echo.echoPort, 0,
 pool);
  serverSock = Socket.create(Socket.APR_INET, 
Socket.SOCK_STREAM,
 Socket.APR_PROTO_TCP, pool);
  Socket.bind(serverSock, inetAddress);
  Socket.listen(serverSock, 5);
  }
  catch( Exception ex ) {
  ex.printStackTrace();
  }
  }
  
  public void run() {
  int i = 0;
  try {
  while (true) {
  long clientSock = Socket.accept(serverSock, pool);
  System.out.println(Accepted id:  +  i);
  Worker worker = new Worker(clientSock, i++,
 this.getClass().getName());
  Echo.incThreads();
  worker.start();
  }
  }
  catch( Exception ex ) {
  ex.printStackTrace();
  }
  }
  }
  
  /* Poller thread. Listens for new recycled connections */
  private class Poller extends Thread {
  private long serverPollset = 0;
  private long pool = 0;
  private int nsocks = 0;
  public Poller() {
  try {
  
  pool = Pool.create(Echo.echoPool);
  serverPollset = Poll.create(16, pool, 0);
  }
  catch( Exception ex ) {
  ex.printStackTrace();
  }
  }
  
  public void add(long socket, int workerId) {
  int rv = Poll.add(serverPollset, socket, workerId,
Poll.APR_POLLIN, 0);
  if (rv == Status.APR_SUCCESS) {
  System.out.println(Added worker  + workerId +  to 
pollset);
  nsocks++;
  }
  }
  
  public void remove(long socket, int workerId) {
  int rv = Poll.remove(serverPollset, socket);
  if 

cvs commit: jakarta-tomcat-connectors/jk/native/apache-2.0 mod_jk.c

2005-02-05 Thread mturk
mturk   2005/02/05 04:41:17

  Modified:jk/native/apache-2.0 mod_jk.c
  Log:
  Re-open a global log mutex lock in a child process.
  From APR documentation:
  This function must be called to maintain portability, even
  if the underlying lock mechanism does not require it.
  
  Revision  ChangesPath
  1.116 +8 -1  jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c
  
  Index: mod_jk.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c,v
  retrieving revision 1.115
  retrieving revision 1.116
  diff -u -r1.115 -r1.116
  --- mod_jk.c  12 Jan 2005 17:23:11 -  1.115
  +++ mod_jk.c  5 Feb 2005 12:41:17 -   1.116
  @@ -2189,9 +2189,16 @@
   {
   jk_server_conf_t *conf;
   int mpm_threads = 1;
  +apr_status_t rv;
   
   conf = ap_get_module_config(s-module_config, jk_module);
   
  +rv = apr_global_mutex_child_init(jk_log_lock, NULL, pconf);
  +if (rv != APR_SUCCESS) {
  +ap_log_error(APLOG_MARK, APLOG_CRIT, rv, s,
  + mod_jk: could not init JK log lock in child);
  +}
  +
   JK_TRACE_ENTER(conf-log);
   
   /* Set default connection cache size for worker mpm */
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Tomcat Native example

2005-02-05 Thread Mladen Turk
To whom it may concern:
I've committed the example for Tomcat Native that acts
as simple Echo server.
Well, it does not echo anything, but that's not the point.
Here is how it works.
It creates two threads 'Acceptor' and 'Poller'.
The Acceptor is standard blocking acceptor that waits for
any new connection.
When the connection arrives it launches a new 'Worker' thread
that reads the input in standard blocking mode.
When the Workers finds the LF char, it treats this
as end-of-transaction (like HTTP request with keep-alive).
It does not close the client connection, but rather
passes the socket to the 'Poller'.
The Poller then waits for the first byte received on that
socket, thus offering the non-blocking keep-alive.
When the event occurs the Poller launches the Worker with
already connected socket (like next keep-alive request).
That's about it.
Although being only the proof of concept it shows that
both BIO and NIO models can be combined together, thus offering
much greater scalability, without NIO's event latency.
Regards,
Mladen.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


DO NOT REPLY [Bug 33368] - swallowOutput causes memory leak

2005-02-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33368.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33368





--- Additional Comments From [EMAIL PROTECTED]  2005-02-05 15:20 ---
Remy: I did understand, that you prefer some refactoring there. But you weren't
precise about only introducing a ThreadLocal (easy) or also making analysis on
probable recursion. I changed the logs HashTable inside SystemLogHandler to a
ThreadLocal and I'm running a series of tests to see, if the memory leak is
gone. I wil post the small patch (for both SystemLogHandlers) as soon, as the
tests succeed.

I would not very much like to go deeper into the question, if a stack
(supporting recursion) is really necessary. In the jasper case it is not (and so
not in the code), but the case of the filters and valves using
/org/apache/tomcat/util/log/SystemLogHandler.java might be different (and even
different in the various TC versions).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33368] - swallowOutput causes memory leak

2005-02-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33368.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33368


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Attachment #14184|0   |1
is obsolete||




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33368] - swallowOutput causes memory leak

2005-02-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33368.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33368


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Attachment #14185|0   |1
is obsolete||




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33368] - swallowOutput causes memory leak

2005-02-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33368.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33368


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Attachment #14186|0   |1
is obsolete||




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33368] - swallowOutput causes memory leak

2005-02-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33368.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33368


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Attachment #14187|0   |1
is obsolete||




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33368] - swallowOutput causes memory leak

2005-02-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33368.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33368





--- Additional Comments From [EMAIL PROTECTED]  2005-02-05 17:54 ---
Created an attachment (id=14189)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=14189action=view)
ThreadLocal Patch for Jaspers SystemLogHandler


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33368] - swallowOutput causes memory leak

2005-02-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33368.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33368





--- Additional Comments From [EMAIL PROTECTED]  2005-02-05 17:55 ---
Created an attachment (id=14190)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=14190action=view)
ThreadLocal Patch for connectors SystemLogHandler


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33368] - swallowOutput causes memory leak

2005-02-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33368.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33368





--- Additional Comments From [EMAIL PROTECTED]  2005-02-05 18:02 ---
Created an attachment (id=14191)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=14191action=view)
Complete Code and classes for the two patches

Test by extracting classes to server/classes.

I could not reproduce the thread memory leak with this version.

New version of the Jasper SystemLogHandler is compatible with Revision 1.4 (5.0
and 5.5 branches), but it seems, that it could also be used instead of 1.1.2.2
(Tomcat 4 branch).

For the connectors SystemLogHandler the patch can be applied to 1.5 (5.5
branch) and 1.4.2.1 (5.0 branch), since they are the same.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 26135] - Tomcat 5.0.16 leaks memory when a webapp is reloaded or stopped/started

2005-02-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=26135.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=26135





--- Additional Comments From [EMAIL PROTECTED]  2005-02-05 19:05 ---
This is the same solution as was found previously in the following two bugs...
http://issues.apache.org/bugzilla/show_bug.cgi?id=26372
http://issues.apache.org/bugzilla/show_bug.cgi?id=27371

The solution was originally (as far as I know) found here...
http://marc.theaimsgroup.com/?t=10957839304r=1w=2


It would have been nice to have recognized this information back in September
'04 when Yoav posted references to the solution rather than having to re-figure
it out independently in January '05 and finaly take action.  In any case, I'm
glad it is finally fixed!


Jake

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: SVN migration?

2005-02-05 Thread Henri Yandell
On Fri, 04 Feb 2005 19:16:03 -0800, Costin Manolache
[EMAIL PROTECTED] wrote:

 I like SVN a lot - and for a new project probably I would choose it if
 there is a choice - sf.net or other places are cvs only.  But I don't
 think all the pain for switching tomcat is justified, and switching few
 repositories but not others is even worse.

+1. Definite disservice to the subcommunity if you are straddling two
source control systems.

 Unless we're going to do major reorganization of the code ( move
 directories around ) or we start some complex branches, or we have any
 other need where SVN is much better than CVS - I would say it's better
 for everyone to stick with the stable environment.

I'll start to maintain a list of Want to stay in CVS for the near
future, and I'll add Tomcat/ServletAPI/Watchdog to that, as I think
those are the groups that this list represents :)

Reasons:

1) Eclipse support (nobody has mentioned a different IDE yet)
2) A lot to do when there's no driving need to migrate.

Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jk/native/netscape nsapi.dsp

2005-02-05 Thread mturk
mturk   2005/02/05 11:40:19

  Modified:jk/native/apache-1.3 Makefile.vc mod_jk.dsp
   jk/native/apache-2.0 Makefile.vc NWGNUmakefile mod_jk.dsp
   jk/native/common list.mk.in
   jk/native/iis isapi.dsp
   jk/native/netscape nsapi.dsp
  Added:   jk/native/common jk_shm.c jk_shm.h
  Log:
  Add shared memory support.
  
  Revision  ChangesPath
  1.3   +8 -0  
jakarta-tomcat-connectors/jk/native/apache-1.3/Makefile.vc
  
  Index: Makefile.vc
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/native/apache-1.3/Makefile.vc,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- Makefile.vc   27 Dec 2004 08:46:57 -  1.2
  +++ Makefile.vc   5 Feb 2005 19:40:19 -   1.3
  @@ -51,6 +51,7 @@
[EMAIL PROTECTED] $(INTDIR)\jk_md5.obj
[EMAIL PROTECTED] $(INTDIR)\jk_msg_buff.obj
[EMAIL PROTECTED] $(INTDIR)\jk_pool.obj
  + [EMAIL PROTECTED] $(INTDIR)\jk_shm.obj
[EMAIL PROTECTED] $(INTDIR)\jk_sockbuf.obj
[EMAIL PROTECTED] $(INTDIR)\jk_uri_worker_map.obj
[EMAIL PROTECTED] $(INTDIR)\jk_util.obj
  @@ -87,6 +88,7 @@
$(INTDIR)\jk_md5.obj \
$(INTDIR)\jk_msg_buff.obj \
$(INTDIR)\jk_pool.obj \
  + $(INTDIR)\jk_shm.obj \
$(INTDIR)\jk_sockbuf.obj \
$(INTDIR)\jk_uri_worker_map.obj \
$(INTDIR)\jk_util.obj \
  @@ -226,6 +228,12 @@
$(CPP) $(CPP_PROJ) $(SOURCE)
   
   
  +SOURCE=..\common\jk_shm.c
  +
  +$(INTDIR)\jk_shm.obj : $(SOURCE) $(INTDIR)
  + $(CPP) $(CPP_PROJ) $(SOURCE)
  +
  +
   SOURCE=..\common\jk_sockbuf.c
   
   $(INTDIR)\jk_sockbuf.obj : $(SOURCE) $(INTDIR)
  
  
  
  1.8   +46 -40jakarta-tomcat-connectors/jk/native/apache-1.3/mod_jk.dsp
  
  Index: mod_jk.dsp
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/native/apache-1.3/mod_jk.dsp,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- mod_jk.dsp23 Dec 2004 14:20:44 -  1.7
  +++ mod_jk.dsp5 Feb 2005 19:40:19 -   1.8
  @@ -42,8 +42,8 @@
   # PROP Intermediate_Dir Release
   # PROP Ignore_Export_Lib 0
   # PROP Target_Dir 
  -# ADD BASE CPP /nologo /MD /W3 /O2 /Zi /D WIN32 /D NDEBUG /D _WINDOWS 
/D _MBCS /D _USRDLL /D MOD_JK_EXPORTS /FD /c
  -# ADD CPP /nologo /MD /W3 /O2 /Zi /I ..\common /I 
$(APACHE1_HOME)\include /I $(APACHE1_HOME)\src\include /I 
$(APACHE1_HOME)\src\os\win32 /I $(JAVA_HOME)\include /I 
$(JAVA_HOME)\include\win32 /D WIN32 /D NDEBUG /D _WINDOWS /D _MBCS /D 
_USRDLL /D MOD_JK_EXPORTS /FdRelease\mod_jk_src /FD /c
  +# ADD BASE CPP /nologo /MD /W3 /Zi /O2 /D WIN32 /D NDEBUG /D _WINDOWS 
/D _MBCS /D _USRDLL /D MOD_JK_EXPORTS /FD /c
  +# ADD CPP /nologo /MD /W3 /Zi /O2 /I ..\common /I 
$(APACHE1_HOME)\include /I $(APACHE1_HOME)\src\include /I 
$(APACHE1_HOME)\src\os\win32 /I $(JAVA_HOME)\include /I 
$(JAVA_HOME)\include\win32 /D WIN32 /D NDEBUG /D _WINDOWS /D _MBCS /D 
_USRDLL /D MOD_JK_EXPORTS /FdRelease\mod_jk_src /FD /c
   # ADD BASE MTL /nologo /D NDEBUG /mktyplib203 /win32
   # ADD MTL /nologo /D NDEBUG /mktyplib203 /win32
   # ADD BASE RSC /l 0x409 /d NDEBUG
  @@ -53,7 +53,7 @@
   # ADD BSC32 /nologo
   LINK32=link.exe
   # ADD BASE LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib 
comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib 
odbc32.lib odbccp32.lib /nologo /dll /machine:I386
  -# ADD LINK32 ApacheCore.lib wsock32.lib kernel32.lib user32.lib gdi32.lib 
winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib 
uuid.lib odbc32.lib odbccp32.lib /nologo /base:0x6A6B /subsystem:windows 
/dll /incremental:no /debug /machine:I386 /out:Release/mod_jk.so /opt:ref 
/libpath:$(APACHE1_HOME)\libexec /libpath:$(APACHE1_HOME)\src\CoreR 
/libpath:$(APACHE1_HOME)\src\Release
  +# ADD LINK32 ApacheCore.lib wsock32.lib kernel32.lib user32.lib gdi32.lib 
winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib 
uuid.lib odbc32.lib odbccp32.lib /nologo /base:0x6A6B /subsystem:windows 
/dll /debug /machine:I386 /out:Release/mod_jk.so 
/libpath:$(APACHE1_HOME)\libexec /libpath:$(APACHE1_HOME)\src\CoreR 
/libpath:$(APACHE1_HOME)\src\Release /opt:ref
   
   !ELSEIF  $(CFG) == mod_jk - Win32 Debug
   
  @@ -104,10 +104,26 @@
   # End Source File
   # Begin Source File
   
  +SOURCE=..\common\jk_ajp14.c
  +# End Source File
  +# Begin Source File
  +
  +SOURCE=..\common\jk_ajp14_worker.c
  +# End Source File
  +# Begin Source File
  +
  +SOURCE=..\common\jk_ajp_common.c
  +# End Source File
  +# Begin Source File
  +
   SOURCE=..\common\jk_connect.c
   # End Source File
   # Begin Source File
   
  +SOURCE=..\common\jk_context.c
  +# End Source File
  +# Begin Source File
  +
   SOURCE=..\common\jk_jni_worker.c
   # End Source File
   # Begin Source File
  @@ 

DO NOT REPLY [Bug 33143] - [PATCH] Java 1.4 loggers per context

2005-02-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33143.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33143


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2005-02-05 22:44 ---
I would suggest switching to Log4j 1.3 or the UGLI API (
http://logging.apache.org/log4j/docs/ugli.html ), of which there are
implementations for Log4j, JDK1.4 logging, simple system.out logging, and NOP. 
You decide which implementation by providing it in the classpath and never
change the API you reference.  Kind of like commons-logging, but without the
brittleness of the discovery system.  Anyway, if you use Log4j as the
implementation (directly or via UGLI-Log4j), you can use a repository selector (
http://www.qos.ch/logging/sc.jsp ) which will effectively separate container
logging from application logging using a single instance of Log4j (in
common/lib).  Actually, you can share logging by giving two apps the same logger
repository name to use.  Read the Javadoc for more info...

http://cvs.apache.org/viewcvs.cgi/logging-log4j/src/java/org/apache/log4j/selector/ContextJNDISelector.java?rev=1.18view=markup


Jake

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[GUMP@brutus]: Project jakarta-tomcat-jk-native (in module jakarta-tomcat-connectors) failed

2005-02-05 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project jakarta-tomcat-jk-native has an issue affecting its community 
integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- jakarta-tomcat-jk-native :  Connectors to various web servers


Full details are available at:

http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -INFO- Failed with reason build failed



The following work was performed:
http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/gump_work/build_jakarta-tomcat-connectors_jakarta-tomcat-jk-native.html
Work Name: build_jakarta-tomcat-connectors_jakarta-tomcat-jk-native (Type: 
Build)
Work ended in a state of : Failed
Elapsed: 
Command Line: make 
[Working Directory: 
/usr/local/gump/public/workspace/jakarta-tomcat-connectors/jk/native]
-
Making all in common
make[1]: Entering directory 
`/home/gump/workspaces2/public/workspace/jakarta-tomcat-connectors/jk/native/common'
/bin/sh 
/usr/local/gump/public/workspace/apache-httpd/dest-05022005/build/libtool 
--silent --mode=compile gcc 
-I/usr/local/gump/public/workspace/apache-httpd/dest-05022005/include -g -O2 -g 
-O2 -pthread -DHAVE_APR 
-I/usr/local/gump/public/workspace/apr/dest-05022005/include/apr-1 -g -O2 
-DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -I 
/opt/jdk1.4/include -I /opt/jdk1.4/include/ -c jk_ajp12_worker.c 
/usr/local/gump/public/workspace/apache-httpd/dest-05022005/build/libtool: 
/usr/local/gump/public/workspace/apache-httpd/dest-05022005/build/libtool: No 
such file or directory
make[1]: *** [jk_ajp12_worker.lo] Error 127
make[1]: Leaving directory 
`/home/gump/workspaces2/public/workspace/jakarta-tomcat-connectors/jk/native/common'
make: *** [all-recursive] Error 1
-

To subscribe to this information via syndicated feeds:
- RSS: 
http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/rss.xml
- Atom: 
http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/atom.xml

== Gump Tracking Only ===
Produced by Gump version 2.2.
Gump Run 51001805022005, brutus:brutus-public:51001805022005
Gump E-mail Identifier (unique within run) #2.

--
Apache Gump
http://gump.apache.org/ [Instance: brutus]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]