Re: tag plugin
wing lee wrote:
I've tried the generateBody method, but it just generate such code
write.out(body content), don't return the value of the body content.
That's odd: it's supposed to continue evaluation and code generation for
the body, not consider nested stuff as static text. There's a good
example with the if tag plugin (although, as I said, I didn't test it
at all, so maybe it's broken).
public final class If implements TagPlugin {
public void doTag(TagPluginContext ctxt) {
String condV = ctxt.getTemporaryVariableName();
ctxt.generateJavaSource(boolean + condV + =);
ctxt.generateAttribute(test);
ctxt.generateJavaSource(;);
if (ctxt.isAttributeSpecified(var)) {
String scope = PageContext.PAGE_SCOPE;
if (ctxt.isAttributeSpecified(scope)) {
String scopeStr = ctxt.getConstantAttribute(scope);
if (request.equals(scopeStr)) {
scope = PageContext.REQUEST_SCOPE;
} else if (session.equals(scopeStr)) {
scope = PageContext.SESSION_SCOPE;
} else if (application.equals(scopeStr)) {
scope = PageContext.APPLICATION_SCOPE;
}
}
ctxt.generateJavaSource(_jspx_page_context.setAttribute();
ctxt.generateAttribute(var);
ctxt.generateJavaSource(, new Boolean( + condV + ), + scope +
););
}
ctxt.generateJavaSource(if ( + condV + ){);
ctxt.generateBody();
ctxt.generateJavaSource(});
}
}
Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm UserDatabaseRealm.java
Hey Bill,
many thanks to clean this up
Peter
[EMAIL PROTECTED] schrieb:
billbarker2005/08/17 21:41:02
Modified:catalina/src/share/org/apache/catalina/realm
UserDatabaseRealm.java
Log:
Clean up previous patch so it works with Custom UserDatabases, not just the
Memory one.
Revision ChangesPath
1.14 +22 -18
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/UserDatabaseRealm.java
Index: UserDatabaseRealm.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/UserDatabaseRealm.java,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -r1.13 -r1.14
--- UserDatabaseRealm.java 17 Aug 2005 10:40:33 - 1.13
+++ UserDatabaseRealm.java 18 Aug 2005 04:41:02 - 1.14
@@ -142,6 +142,12 @@
* @param role Security role to be checked
*/
public boolean hasRole(Principal principal, String role) {
+if( principal instanceof GenericPrincipal) {
+GenericPrincipal gp = (GenericPrincipal)principal;
+if(gp.getUserPrincipal() instanceof User) {
+principal = gp.getUserPrincipal();
+}
+}
if(! (principal instanceof User) ) {
//Play nice with SSO and mixed Realms
return super.hasRole(principal, role);
@@ -203,29 +209,27 @@
*/
protected Principal getPrincipal(String username) {
-Principal principal = database.findUser(username);
-if(principal instanceof GenericPrincipal)
-return principal ;
-
+User user = database.findUser(username);
+if(user == null) {
+return null;
+}
+
List roles = new ArrayList();
-if(principal instanceof MemoryUser) {
-MemoryUser user = (MemoryUser)principal;
-Iterator uroles = user.getRoles();
+Iterator uroles = user.getRoles();
+while(uroles.hasNext()) {
+Role role = (Role)uroles.next();
+roles.add(role.getName());
+}
+Iterator groups = user.getGroups();
+while(groups.hasNext()) {
+Group group = (Group)groups.next();
+uroles = user.getRoles();
while(uroles.hasNext()) {
Role role = (Role)uroles.next();
roles.add(role.getName());
}
-Iterator groups = user.getGroups();
-while(groups.hasNext()) {
-Group group = (Group)groups.next();
-uroles = user.getRoles();
-while(uroles.hasNext()) {
-Role role = (Role)uroles.next();
-roles.add(role.getName());
-}
-}
}
-return new GenericPrincipal(this, username, getPassword(username),
roles, principal);
+return new GenericPrincipal(this, username, user.getPassword(),
roles, user);
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/tagplugin TagPluginContext.java
remm2005/08/18 01:24:15 Modified:jasper2/src/share/org/apache/jasper/compiler/tagplugin TagPluginContext.java Log: - Javadoc fixes. Revision ChangesPath 1.15 +1 -1 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/tagplugin/TagPluginContext.java Index: TagPluginContext.java === RCS file: /home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/tagplugin/TagPluginContext.java,v retrieving revision 1.14 retrieving revision 1.15 diff -u -r1.14 -r1.15 --- TagPluginContext.java 17 Mar 2004 19:23:04 - 1.14 +++ TagPluginContext.java 18 Aug 2005 08:24:14 - 1.15 @@ -84,7 +84,7 @@ */ void generateAttribute(String attribute); -/* +/** * Generate codes for the body of the custom tag */ void generateBody(); - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36113] - Session persistence for objects with primitive types
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36113. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36113 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WORKSFORME --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 15:11 --- This works very well for me. Please provide a ready to test WAR file. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36245] New: - Cannot make Socket Connection after extended usage
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36245. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36245 Summary: Cannot make Socket Connection after extended usage Product: Tomcat 5 Version: 5.5.9 Platform: PC OS/Version: Windows XP Status: NEW Severity: critical Priority: P2 Component: Connector:HTTP AssignedTo: tomcat-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] CC: [EMAIL PROTECTED] I use tomcat 5.5.9 with J2SE 5.0 Update 4. My web application involves opening a tcp socket connection with an external server and closing it at logout. I find that when using tomcat as a service using tomcat5.exe, after 2000 uses (login followed by logout which is open the socket connection followed by close the socket connection), I cannot make a socket connection anymore with the external server. But if I start tomcat using startup.bat, there seems to be no problem even after 5000 uses. Why am I observing such a behavior? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36113] - Session persistence for objects with primitive types
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36113. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36113 [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME | --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 15:21 --- I already tried that code, patching a copy of tomcat myself and this works. So this can be treated as solved. Just one remark: The same bug is in the cluster package, class ReplicationStream. Whenever a primitive type is in the session (such as a castor object), an exception is generated. Maybe you should fix this inside that class also. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml
remm2005/08/18 06:25:18
Modified:catalina/src/share/org/apache/catalina/connector
ClientAbortException.java
catalina/src/share/org/apache/catalina/core
StandardHostValve.java
webapps/docs changelog.xml
Log:
- 35984: Use getCause.
Revision ChangesPath
1.3 +6 -6
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/ClientAbortException.java
Index: ClientAbortException.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/ClientAbortException.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- ClientAbortException.java 27 Feb 2004 14:58:41 - 1.2
+++ ClientAbortException.java 18 Aug 2005 13:25:18 - 1.3
@@ -112,15 +112,15 @@
/**
- * Returns the throwable that caused this exception, if any.
+ * Returns the cause that caused this exception, if any.
*/
-public Throwable getThrowable() {
-
+public Throwable getCause() {
+
return (throwable);
-
+
}
-
+
/**
* Return a formatted string that describes this exception.
*/
1.25 +7 -5
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardHostValve.java
Index: StandardHostValve.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardHostValve.java,v
retrieving revision 1.24
retrieving revision 1.25
diff -u -r1.24 -r1.25
--- StandardHostValve.java27 Sep 2004 16:04:05 - 1.24
+++ StandardHostValve.java18 Aug 2005 13:25:18 - 1.25
@@ -174,10 +174,12 @@
// If this is an aborted request from a client just log it and return
if (realError instanceof ClientAbortException ) {
-log.debug
-(sm.getString(standardHost.clientAbort,
- ((ClientAbortException)
realError).getThrowable()
- .getMessage()));
+if (log.isDebugEnabled()) {
+log.debug
+(sm.getString(standardHost.clientAbort,
+((ClientAbortException) realError).getCause()
+.getMessage()));
+}
return;
}
1.359 +6 -0 jakarta-tomcat-catalina/webapps/docs/changelog.xml
Index: changelog.xml
===
RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
retrieving revision 1.358
retrieving revision 1.359
diff -u -r1.358 -r1.359
--- changelog.xml 17 Aug 2005 15:07:19 - 1.358
+++ changelog.xml 18 Aug 2005 13:25:18 - 1.359
@@ -86,6 +86,12 @@
bug35978/bug: Bad handling of single range requests greater than
2GB in the DefaultServlet
(remm)
/fix
+ fix
+bug35984/bug: Client abort exceptions will now use getCause
(remm)
+ /fix
+ fix
+Fix handling of non-file based includes with SSI, submitted by David
Becker (markt)
+ /fix
/changelog
/subsection
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36113] - Session persistence for objects with primitive types
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36113. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36113 [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||WORKSFORME --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 15:27 --- I asked for a test case, not further comments, so please don't reopen the report without a test WAR. This works for me without any changes. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36247] New: - Jasper jsp:include page=foo.xml/ throws IllegalStateException
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36247. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36247 Summary: Jasper jsp:include page=foo.xml/ throws IllegalStateException Product: Tomcat 5 Version: 5.5.9 Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: Jasper AssignedTo: tomcat-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] %@ page language=java contentType=text/xml% jsp:include page=sample.xml/ the above jsp causes an IllegalStateException the following is just fine: (the files are identical) %@ page language=java contentType=text/xml% jsp:include page=sample.html/ My guess is that someone is messing about with the outputStream in order to get the XML encoding sorted... still surely the contentType drives this not the file extension? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36102] - jk 1.2.14 - Worker actions do not persist
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36102. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36102 --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 16:24 --- Created an attachment (id=16097) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=16097action=view) Ilustration of the jkstatus page -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36102] - jk 1.2.14 - Worker actions do not persist
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36102. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36102 --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 16:25 --- Thanks Mark! One other thing to look for. I noticed that even in IIS5 isolation mode, changes to the load balancing worker aren't exactly smooth. For example: I open the home page of the app running under Tomcat. Click refresh several times quickly and it switches tomcat instances (workers). If we were on tomcat 5, and clustering, it wouldn't be any big deal. But with tomcat 4, the user will loose there session vars. I tried checking the sticky = True, and updating the worker. When I refreshed the page, it 404'd. I closed the browser and the worker displays contained jibberish, but the sticky was reset to False. Screen shot of the jibberish will be attached to the issue. Only a bounce of the WWW Pub service got the jkstatus page to display correctly again. Not sure what this has to do with anything, but thought you might like to have any additional symptoms I ran across. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Temp RM
Hi, Yoav has granted me temp RM powers while he's away on vacation. I plan to use them and release a new 5.5.11 test build early next week (let's say monday) for further testing of the new features introduced in 5.5.10, which unfortunately had serious bugs which should have been addressed. I don't think this new test build will be the subject of a stability vote given that too many key people may be out of reach until september. Any problems with this plan ? Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Subversion migration update
Mark Thomas wrote: Mark Thomas wrote: snip The performance comparison between CVS and SVN is in the early stages and I will post some results once I have a more complete set. Tests performed on WinXP SP2, with Tortoise CVS 1.8.18 and Tortoise SVN 1.2.1 using the Watchdog repository. For tests using a single file I used build.xml. The results are (averages in seconds): Operation CVS SVN checkout 38 51 history 45 blame 47 diff42 revert 71 Also, SVN does not support revision graphs. Some tools can derive the graph but for the ASF repository this will take hours, possibly days. See http://subversion.tigris.org/ for a list of other SVN benefits. I am +1 for moving the remaining Tomcat CVS modules to SVN. I'm +10^-60 or something. Assuming everyone else is happy to move the remaining tomcat modules to SVN I would suggest the following stages (Watchdog was stage 1). I'll give people at least a week to comment on this proposal and assuming no -1's start the phase 2 towards the end of next week. 2. j-t-service, j-t-site 3. j-servletapi, j-servletapi-4, j-servletapi-5 4. j-tomcat, j-tomcat-4.0 5. j-t-catalina, j-t-5, j-t-jasper, j-t-connectors Do we need an OK from the spec team before we do stage 3? I don't think so, we're not changing the code. Any other comments/concerns? Right after that, we'll need new repositories to implement the new Servlet 2.5 / JSP 2.1. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36250] New: - Tomcat should not return FAIL on ThreadDeath during redeploy
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36250. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36250 Summary: Tomcat should not return FAIL on ThreadDeath during redeploy Product: Tomcat 5 Version: 5.5.7 Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Unknown AssignedTo: tomcat-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] Hi, This issue is related to http://issues.apache.org/bugzilla/show_bug.cgi?id=26372 and http://www.netbeans.org/issues/show_bug.cgi?id=62529 I personally consider this issue to be a bug but if you believe it to be a RFE please feel free to modify the severity accordingly. In a nutshell, we're expecting Tomcat to return something other than FAIL on a redeploy if a ThreadDeath occurs along the way. Since ThreadDeath does not actually indicate a failure in this case, it would make sense for Tomcat to return something other than FAIL. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36218] - principal replication problem in cluster
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36218. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36218 --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 18:09 --- I tested it with the MemoryRealm settings using tomcat-users.xml for data of users, and the fix works. This with FORM authentication. however, we would like to use our custom JAAS login module. For this we programmed a module, and added 2 Principals to the config for user and role. These classes extend java.security.Principal. And this does not work yet. I think it has to do with the method createPrincipal(String username, Subject subject) in org.apache.catalina.realm.JAASRealm. All the other real implementations deal with GenericPrincipal, while here java.security.Principal is used. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36252] New: - ServletException should override getCause()
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36252. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36252 Summary: ServletException should override getCause() Product: Tomcat 5 Version: 5.5.9 Platform: PC OS/Version: Windows XP Status: NEW Severity: enhancement Priority: P3 Component: Unknown AssignedTo: tomcat-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] ServletException needs to implement getCause() to return getRootCause() in order for exception-chaining to work. Right now if the ServletException gets wrapped with another exception and you invoke printStackTrace() on that the stack-trace will end at ServletException and it will not display its root cause. I'm going to report this issue as well with the Servlet specification team, but it would be nice if this was fixed sooner in Tomcat. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36231] - getCause() null for ServletException
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36231. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36231 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 19:12 --- *** Bug 36252 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36252] - ServletException should override getCause()
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36252. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36252 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 19:12 --- *** This bug has been marked as a duplicate of 36231 *** -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36250] - Tomcat should not return FAIL on ThreadDeath during redeploy
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36250. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36250 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 19:21 --- *** This bug has been marked as a duplicate of 26372 *** -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26372] - java.lang.ThreadDeath when trying to reload an application
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=26372. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=26372 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 19:21 --- *** Bug 36250 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36231] - getCause() null for ServletException
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36231.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=36231
--- Additional Comments From [EMAIL PROTECTED] 2005-08-18 19:29 ---
Guys, you don't need initCause() to fix this problem, nor do you need to change
the interface or specification. All you need to do is implement a method
public Throwable getCause()
{
return getRootCause();
}
there you go. This code will run on J2EE 1.3 just fine and this is something
that the Tomcat team can do independantly of the specification. I also don't
understand what portability has anything to do with this (maybe you meant
backwards compatibility?). The way I see it, if someone is coding a webapp on
pre-1.3, he can't possibly invoke getCause() because it does not exist. If he
codes his webapp post-1.3, he expects getCause()'s contract to be met and we are
in fact trying to fix ServletException so it meets its contract. There is no
loss of portability or backwards compatibility here. Can I reopen this issue?
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36250] - Tomcat should not return FAIL on ThreadDeath during redeploy
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36250. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36250 --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 19:33 --- Remy... Closing this as DUPLICATE makes no logical sense. I am not complaining that ThreadDeath is occuring (as the original issue does). If you had actually read my full report you would know this. I *understand* why ThreadDeath is occuring. I understand this is normal. I am simply saying that Tomcat should not return FAIL under this condition because as you yourself said in the other discussion thread this is not a failure condition but rather quite normal. So please explain: why is it alright for Tomcat to return FAIL if ThreadDeath is not a failure condition? And also, I have tried all your workarounds mentioned in the other bug report and none of them work so there really is no way to workaround this issue. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36231] - getCause() null for ServletException
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36231. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36231 --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 19:36 --- (In reply to comment #8) in fact trying to fix ServletException so it meets its contract. There is no loss of portability or backwards compatibility here. Can I reopen this issue? No. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36231] - getCause() null for ServletException
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36231. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36231 --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 19:42 --- Remy, what is your reasoning for not applying this patch? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Subversion migration update
Remy Maucherat wrote: Mark Thomas wrote: I am +1 for moving the remaining Tomcat CVS modules to SVN. I'm +10^-60 or something. He he he. Right after that, we'll need new repositories to implement the new Servlet 2.5 / JSP 2.1. Not having been around when we have done this before, do we just branch the previous version? If so, the simplest thing to do would be to create 5.5.x branches for each component and develop 6.0 (assuming we call it that) in trunk. I can do this as soon as we are ready. Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36254] New: - Creating symlink causes NullPointerException
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36254. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36254 Summary: Creating symlink causes NullPointerException Product: Tomcat 5 Version: 5.5.9 Platform: Sun OS/Version: SunOS Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: tomcat-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] This happens in 5.5.9 and 5.5.8 on solaris and fedora linux but works fine in 5.0.28. Creating symlink under app's root directory causes an exception when trying to view directory. For instance I can do: cd webapps/jsp-examples/colors mkdir temp ln -s temp temp1 and when I http://localhost:8080/jsp-examples/colors it produces this: 2005-08-18 14:15:01,430 [http-8080-Processor25] ERROR org.apache.catalina.core.ContainerBase.[Catalina].[local host].[/apres].[default] - Servlet.service() for servlet default threw exception java.lang.NullPointerException at org.apache.catalina.servlets.DefaultServlet.renderHtml(DefaultServlet.java:1345) at org.apache.catalina.servlets.DefaultServlet.render(DefaultServlet.java:1102) at org.apache.catalina.servlets.DefaultServlet.serveResource(DefaultServlet.java:807) at org.apache.catalina.servlets.DefaultServlet.doGet(DefaultServlet.java:335) at javax.servlet.http.HttpServlet.service(HttpServlet.java:689) at javax.servlet.http.HttpServlet.service(HttpServlet.java:802) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:856) at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.processConnection(Http11Protocol.ja va:744) at org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527) at org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80) at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684) at java.lang.Thread.run(Thread.java:595) -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36231] - getCause() null for ServletException
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36231. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36231 --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 20:41 --- I understand the portability issue to be as follows: - This bug is fixed in Tomcat - I write code that depends on the fix - I port my app to another servlet container where the bug is not fixed - My app is slightly broken You could make this argument for any bug that exists in more than one servlet container. More people have encountered this bug and wasted time tracking it down than will ever have the hypothetical portability issue. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36231] - getCause() null for ServletException
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36231. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36231 --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 20:46 --- Right! I totally agree. Besides which, I have already reported this issue to Sun so they will be fixing it (eventually). I don't see any benefit in making everyone wait a couple of years for this... -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36231] - getCause() null for ServletException
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36231. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36231 --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 21:11 --- This is not a bug - there is no violation of the Servlet spec here. It is an enhancement request. To reiterate a point the seems to have been missed, only the servlet spec team can change the interface or implementation of ServletException. We could, as suggested, change the Tomcat code to call initCause(). There are 72 or so calls that would need to be added. However, this would break application portability. The whole point of having a specification is portability. If we break it for this, why not for something else? If we do it for this, why shouldn't another vendor do it for something else. Such a change would be the beginning of a very nasty slippery slope. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36231] - getCause() null for ServletException
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36231. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36231 --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 21:16 --- Just for the record, I *did* file an enhancement request (see #36252) and it was closed as a duplicate of this issue... So I guess there is nothing for us to do but sit on our hands for the next couple of years... -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36231] - getCause() null for ServletException
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36231. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36231 --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 21:45 --- Joshua Bloch recommended making the same change to ServletException as Gili just did, back in 2000, in anticipation of j2se1.4. Too bad it was ignored, probably because Joshua Bloch doesn't know anything about Java. http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4395719 Fixing this bug will not violate the spec. Calling getCause() is undefined behavior. It would be more useful if it did the right thing instead of the wrong thing. Furthermore, just because it doesn't violate the servlet spec doesn't mean its not a bug. That is a ridiculous position to take. According to the java spec, if I am using 1.4 or later, getCause() does the following: - Returns the cause of this throwable or null if the cause is nonexistent or unknown. - By returning null, ServletException is implying that the cause is nonexistent or unknown, which is not true. ServletException doesn't adhere to the java spec, and that is definitely a bug. Here is another snippet from the javadoc for Throwable.getCause(): - While it is typically unnecessary to override this method, a subclass can override it to return a cause set by some other means. This is appropriate for a legacy chained throwable that predates the addition of chained exceptions to Throwable. - -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36250] - Tomcat should not return FAIL on ThreadDeath during redeploy
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36250. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36250 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Subversion migration update
On 8/18/05, Mark Thomas [EMAIL PROTECTED] wrote: Remy Maucherat wrote: Mark Thomas wrote: I am +1 for moving the remaining Tomcat CVS modules to SVN. I'm +10^-60 or something. He he he. Well, the +10 is promising :) Right after that, we'll need new repositories to implement the new Servlet 2.5 / JSP 2.1. Not having been around when we have done this before, do we just branch the previous version? If so, the simplest thing to do would be to create 5.5.x branches for each component and develop 6.0 (assuming we call it that) in trunk. I can do this as soon as we are ready. svn mkdir https://svn.apache.org/repos/asf/tomcat/servletapi/2.5/ (or whatever). No longer need to have Infra for this kind of thing. It's either handled by the Tomcat community at large, or for some bits (user authentication) by Remy as chair. Hen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
