Re: [5.0] [PROPOSAL] Make output buffer size limit configurable
Let's be nice to each other, Remy. I want to help. My question was very specific. Why, when I check out TOMCAT_4_1_24, does it not match what's in your jakarta-tomcat-4.1.24-LE-jdk14.zip source bundle? The bugzilla #'s aren't closed, but I want to be sure these fixes are already in, and provide a more useful diff. Remy Maucherat <[EMAIL PROTECTED]> wrote on 07/15/2003 09:54:08 AM: > David Wood wrote: > > > Speaking of jasper, I'm very sorry to interrupt again, and I know it's bad > > etiquette to repeat myself, but I have two patches to outstanding bugs in > > Jasper and I'm just asking for a little help navigating your CVS > > repository so I can make it easy for you to get them in. > > > > Details here: > > > > http://www.mail-archive.com/[EMAIL PROTECTED]/msg44405.html > > I recommend you experiment more with CVS, which is a basic requirement > for dealing with OSS projects. > > - source bundles are available > - you should contribute patches for TC 5 if you can; you can send > patches for TC 4.1, but they are less likely to be integrated > > Remy > > > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] >
Re: [5.0] [PROPOSAL] Make output buffer size limit configurable
Speaking of jasper, I'm very sorry to interrupt again, and I know it's bad etiquette to repeat myself, but I have two patches to outstanding bugs in Jasper and I'm just asking for a little help navigating your CVS repository so I can make it easy for you to get them in. Details here: http://www.mail-archive.com/[EMAIL PROTECTED]/msg44405.html Regards, -David Remy Maucherat <[EMAIL PROTECTED]> wrote on 07/15/2003 03:39:20 AM: > Jan Luehe wrote: > > I noticed that if I send a request specifying HTTP/1.0 as the protocol > > version, and the response exceeds the output buffer, TC returns an > > HTTP/1.1 response with neither a "Content-Length" nor a > > "Transfer-Encoding: chunked" header. > > > > I would have expected it to include a "Content-Length" header. Would you > > agree? > > Of course not, this is completely valid. > > The server must: > - return the highest protocol version it supports > - close the connection to indicate the end of the response if the > content-length is not set > > I'm wondering why you're desperately trying to find things to fix in > Coyote HTTP/1.1, which AFAIK is quite good in terms of HTTP compliance. > There are still things that can be improved in there, such as the > compression support (but I plan to help, since I'm done with my 5.0.x > feature list), but these are not critical features. > If I could choose, I'd prefer you help fix issues on Jasper, since you > know it well and there are still bugs to fix ;-) > > Remy > > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] >
Trying to make a patch, confused by Tomcat's CVS setup
Hi, I have two patches for outstanding bugs of 4.1.24. I'm trying to pull down sources via CVS, both to make sure these patches are still needed, and to build the patch files themselves. I followed the instructions here: http://jakarta.apache.org/site/cvsindex.html I pulled out files tagged TOMCAT_4_1_24. But, when I happened to compare what I pulled down to what is in the 4.1.24 source archive distributed from the Tomcat site, I found radical differences. What am I doing wrong? IOW, what repository are the source release archives built from, and how can I get at it? P.S. On the file that I checked, the majority of the text was different, but the most interesting difference to me was at the top; I include it here in case it may this more clear. The first block is from the CVS checkout I did (labeled TOMCAT_4_1_24), the second is from the archive jakarta-tomcat-4.1.24-LE-jdk14.zip: 2,4c2,4 < * $Header: /home/cvspublic/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/JspC.java,v 1.15 2002/05/16 00:41:26 kinman Exp $ < * $Revision: 1.15 $ < * $Date: 2002/05/16 00:41:26 $ --- > * $Header: /home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java,v 1.12.2.6 2003/03/17 20:53:39 costin Exp $ > * $Revision: 1.12.2.6 $ > * $Date: 2003/03/17 20:53:39 $
