Can someone commit this minor fix?

2001-11-01 Thread Michael Jennings

The following fix enables form-based authentication to work with
Apache + Tomcat.
Can someone add this to tomcat 3.2?

Thanks!
-Mike Jennings


Index: jakarta-tomcat/src/share/org/apache/tomcat/task/ApacheConfig.java
===
RCS file: 
/home/cvspublic/jakarta-tomcat/src/share/org/apache/tomcat/task/Attic/ApacheConfig.java,v
retrieving revision 1.12.2.2
diff -r1.12.2.2 ApacheConfig.java
202a203
 mod_jk.println(JkMount /*j_security_check ajp12);
289a291
   mod_jk.println(JkMount  + path +*j_security_check ajp12);




RE: Can someone commit this minor fix?

2001-11-01 Thread Marc Saegesser

I'll get into Tomcat 3.2.4 before the final release.


Marc Saegesser 

 -Original Message-
 From: Michael Jennings [mailto:[EMAIL PROTECTED]]
 Sent: Thursday, November 01, 2001 10:51 AM
 To: [EMAIL PROTECTED]
 Subject: Can someone commit this minor fix?
 
 
 The following fix enables form-based authentication to work with
 Apache + Tomcat.
 Can someone add this to tomcat 3.2?
 
 Thanks!
 -Mike Jennings
 
 
 Index: 
 jakarta-tomcat/src/share/org/apache/tomcat/task/ApacheConfig.java
 ===
 RCS file: 
 /home/cvspublic/jakarta-tomcat/src/share/org/apache/tomcat/tas
 k/Attic/ApacheConfig.java,v
 retrieving revision 1.12.2.2
 diff -r1.12.2.2 ApacheConfig.java
 202a203
  mod_jk.println(JkMount /*j_security_check ajp12);
 289a291
mod_jk.println(JkMount  + path +*j_security_check ajp12);
 
 

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: Can someone commit this minor fix?

2001-11-01 Thread Michael Jennings

Thanks!
-Mike

- Original Message -
From: Marc Saegesser [EMAIL PROTECTED]
To: Tomcat Developers List [EMAIL PROTECTED]
Sent: Thursday, November 01, 2001 10:54 AM
Subject: RE: Can someone commit this minor fix?


 I'll get into Tomcat 3.2.4 before the final release.


 Marc Saegesser

  -Original Message-
  From: Michael Jennings [mailto:[EMAIL PROTECTED]]
  Sent: Thursday, November 01, 2001 10:51 AM
  To: [EMAIL PROTECTED]
  Subject: Can someone commit this minor fix?
 
 
  The following fix enables form-based authentication to work with
  Apache + Tomcat.
  Can someone add this to tomcat 3.2?
 
  Thanks!
  -Mike Jennings
 
 
  Index:
  jakarta-tomcat/src/share/org/apache/tomcat/task/ApacheConfig.java
  ===
  RCS file:
  /home/cvspublic/jakarta-tomcat/src/share/org/apache/tomcat/tas
  k/Attic/ApacheConfig.java,v
  retrieving revision 1.12.2.2
  diff -r1.12.2.2 ApacheConfig.java
  202a203
   mod_jk.println(JkMount /*j_security_check ajp12);
  289a291
 mod_jk.println(JkMount  + path +*j_security_check ajp12);
 
 

 --
 To unsubscribe, e-mail:
mailto:[EMAIL PROTECTED]
 For additional commands, e-mail:
mailto:[EMAIL PROTECTED]




--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




RE: Can someone commit this minor fix?

2001-11-01 Thread Larry Isaacs

Please see my prior post as to why this may not do what
you expect, i.e.

JkMount /*j_security_check ajp12

will map *all* requests to Tomcat. :)

Larry

 -Original Message-
 From: Michael Jennings [mailto:[EMAIL PROTECTED]]
 Sent: Thursday, November 01, 2001 3:05 PM
 To: Tomcat Developers List
 Subject: Re: Can someone commit this minor fix?
 
 
 Thanks!
 -Mike
 
 - Original Message -
 From: Marc Saegesser [EMAIL PROTECTED]
 To: Tomcat Developers List [EMAIL PROTECTED]
 Sent: Thursday, November 01, 2001 10:54 AM
 Subject: RE: Can someone commit this minor fix?
 
 
  I'll get into Tomcat 3.2.4 before the final release.
 
 
  Marc Saegesser
 
   -Original Message-
   From: Michael Jennings [mailto:[EMAIL PROTECTED]]
   Sent: Thursday, November 01, 2001 10:51 AM
   To: [EMAIL PROTECTED]
   Subject: Can someone commit this minor fix?
  
  
   The following fix enables form-based authentication to work with
   Apache + Tomcat.
   Can someone add this to tomcat 3.2?
  
   Thanks!
   -Mike Jennings
  
  
   Index:
   jakarta-tomcat/src/share/org/apache/tomcat/task/ApacheConfig.java
   
 ===
   RCS file:
   /home/cvspublic/jakarta-tomcat/src/share/org/apache/tomcat/tas
   k/Attic/ApacheConfig.java,v
   retrieving revision 1.12.2.2
   diff -r1.12.2.2 ApacheConfig.java
   202a203
mod_jk.println(JkMount /*j_security_check ajp12);
   289a291
  mod_jk.println(JkMount  + path 
 +*j_security_check ajp12);
  
  
 
  --
  To unsubscribe, e-mail:
 mailto:[EMAIL PROTECTED]
  For additional commands, e-mail:
 mailto:[EMAIL PROTECTED]
 
 
 
 
 --
 To unsubscribe, e-mail:   
 mailto:[EMAIL PROTECTED]
 For additional commands, e-mail: 
 mailto:[EMAIL PROTECTED]
 

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




RE: Can someone commit this minor fix?

2001-11-01 Thread Marc Saegesser

Mike,
[I tried sending this privately, but it bounced.]

I just got caught up on the rest of the messages in tomcat-dev and it looks
like this patch doesn't do what you expect.  Mod_jk doesen't handle
wildcards per se.  It only knows two kinds of mappings

JkMount /path/*

and

JkMount *.ext

The way code is written, doing JkMount /path/*j_security_check will actually
map all requests to /path/* to Tomcat.  Now, that isn't necessarily a bad
thing, and unless your application has lots of static data that would be
better served through Apache, I think its safer to route all requests to
resources inside the web application through Tomcat.  All of my applications
now just do a JkMount /app/* AJP13.


Marc Saegesser 

 -Original Message-
 From: Michael Jennings [mailto:[EMAIL PROTECTED]]
 Sent: Thursday, November 01, 2001 2:08 PM
 To: [EMAIL PROTECTED]
 Subject: Re: Can someone commit this minor fix?
 
 
 Hi Marc,
 The diff to use is
 
 Index: 
 jakarta-tomcat/src/share/org/apache/tomcat/task/ApacheConfig.java
 ===
 RCS file:
 /home/cvspublic/jakarta-tomcat/src/share/org/apache/tomcat/tas
 k/Attic/Apache
 Config.java,v
 retrieving revision 1.12.2.2
 diff -r1.12.2.2 ApacheConfig.java
 202a203
  mod_jk.println(JkMount /*j_security_check ajp12);
 289a291
mod_jk.println(JkMount  + path +/*j_security_check ajp12);
 
 
 The other one you have is missing the / before *j_security_check
 
 Thanks again!
 -Mike
 
 - Original Message -
 From: Marc Saegesser [EMAIL PROTECTED]
 To: Tomcat Developers List [EMAIL PROTECTED]
 Sent: Thursday, November 01, 2001 10:54 AM
 Subject: RE: Can someone commit this minor fix?
 
 
  I'll get into Tomcat 3.2.4 before the final release.
 
 
  Marc Saegesser
 
   -Original Message-
   From: Michael Jennings [mailto:[EMAIL PROTECTED]]
   Sent: Thursday, November 01, 2001 10:51 AM
   To: [EMAIL PROTECTED]
   Subject: Can someone commit this minor fix?
  
  
   The following fix enables form-based authentication to work with
   Apache + Tomcat.
   Can someone add this to tomcat 3.2?
  
   Thanks!
   -Mike Jennings
  
  
   Index:
   jakarta-tomcat/src/share/org/apache/tomcat/task/ApacheConfig.java
   
 ===
   RCS file:
   /home/cvspublic/jakarta-tomcat/src/share/org/apache/tomcat/tas
   k/Attic/ApacheConfig.java,v
   retrieving revision 1.12.2.2
   diff -r1.12.2.2 ApacheConfig.java
   202a203
mod_jk.println(JkMount /*j_security_check ajp12);
   289a291
  mod_jk.println(JkMount  + path 
 +*j_security_check ajp12);
  
  
 
  --
  To unsubscribe, e-mail:
 mailto:[EMAIL PROTECTED]
  For additional commands, e-mail:
 mailto:[EMAIL PROTECTED]
 
 
 

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]