DO NOT REPLY [Bug 26662] - ClassCastException in GzipOutputFilter

2004-03-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=26662.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=26662

ClassCastException in GzipOutputFilter





--- Additional Comments From [EMAIL PROTECTED]  2004-03-17 19:23 ---

I found what was causing the class cast exception.  The maxKeepAliveRequests is 
set to 100.  If more than 100 requests are sent to that connection then the 
Http11Processor.process() sets keepAlive to false (which is the correct 
behavior) but when Http11Processor.processResponse() is called the following 
code 

1485if (contentLength != -1) {
1486response.getMimeHeaders().setValue(Content-Length)
1487.setInt(contentLength);
1488outputBuffer.addActiveFilter
1489(outputFilters[Constants.IDENTITY_FILTER]);
1490contentDelimitation = true;
1491} else {
1492if (entityBody  http11  keepAlive) {
1493outputBuffer.addActiveFilter
1494(outputFilters[Constants.CHUNKED_FILTER]);
1495contentDelimitation = true;
1496response.addHeader(Transfer-Encoding, chunked);
1497}
1498}

does not add a filter there for causing the compression filter to be the only 
one added.  

I am attaching a patch that checks to see if there are any filters added before 
the compression filter is and if not added the identityFilter.

All line numbers and the patch are for 5.0.18

John

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 26662] - ClassCastException in GzipOutputFilter

2004-03-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=26662.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=26662

ClassCastException in GzipOutputFilter





--- Additional Comments From [EMAIL PROTECTED]  2004-03-17 19:24 ---
Created an attachment (id=10835)
Patch for the HttpProcessor, fixes classCastException

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 26662] - ClassCastException in GzipOutputFilter

2004-03-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=26662.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=26662

ClassCastException in GzipOutputFilter





--- Additional Comments From [EMAIL PROTECTED]  2004-03-17 20:00 ---
Created an attachment (id=10836)
fixed the patch.. had a extra char in it. sorry remy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 26662] - ClassCastException in GzipOutputFilter

2004-03-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=26662.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=26662

ClassCastException in GzipOutputFilter





--- Additional Comments From [EMAIL PROTECTED]  2004-03-17 23:16 ---
The current code reads:

if (contentLength != -1) {
response.getMimeHeaders().setValue(Content-Length)
.setInt(contentLength);
outputBuffer.addActiveFilter
(outputFilters[Constants.IDENTITY_FILTER]);
contentDelimitation = true;
} else {
if (entityBody  http11  keepAlive) {
outputBuffer.addActiveFilter
(outputFilters[Constants.CHUNKED_FILTER]);
contentDelimitation = true;
response.addHeader(Transfer-Encoding, chunked);
} else {
outputBuffer.addActiveFilter
(outputFilters[Constants.IDENTITY_FILTER]);
}
}

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 26662] - ClassCastException in GzipOutputFilter

2004-02-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26662.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26662

ClassCastException in GzipOutputFilter

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2004-02-24 23:16 ---
*** Bug 27197 has been marked as a duplicate of this bug. ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 26662] - ClassCastException in GzipOutputFilter

2004-02-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26662.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26662

ClassCastException in GzipOutputFilter





--- Additional Comments From [EMAIL PROTECTED]  2004-02-05 13:47 ---
Remy,

The fix did not work.. I still get the classcastexception.  The stacktrace is 
the same..

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 26662] - ClassCastException in GzipOutputFilter

2004-02-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26662.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26662

ClassCastException in GzipOutputFilter





--- Additional Comments From [EMAIL PROTECTED]  2004-02-05 17:10 ---
Sure. Please provide a test case (test telnet request + servlet or JSP if needed).

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 26662] - ClassCastException in GzipOutputFilter

2004-02-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26662.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26662

ClassCastException in GzipOutputFilter

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2004-02-04 15:59 ---
Long time since I last heard about your reports. Now you'll see that this must
be wrapped with another filter for content delimitation (either identity or
chunked), which can be safely cast. If this doesn't happen, then you have a bug,
but quite frankly I really doubt it.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 26662] - ClassCastException in GzipOutputFilter

2004-02-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26662.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26662

ClassCastException in GzipOutputFilter





--- Additional Comments From [EMAIL PROTECTED]  2004-02-04 16:09 ---
Remy,

I did not think you read my bug reports, I though you would have filtered them 
by now.. :-)

I understand what you are saying, but I keep getting the following stacktrace...

ava.lang.ClassCastException
at org.apache.coyote.http11.filters.GzipOutputFilter.end
(GzipOutputFilter.java:165)
at org.apache.coyote.http11.InternalOutputBuffer.endRequest
(InternalOutputBuffer.java:439)
at org.apache.coyote.http11.Http11Processor.action
(Http11Processor.java:968)
at org.apache.coyote.Response.action(Response.java:226)
at org.apache.coyote.Response.finish(Response.java:348)
at org.apache.coyote.tomcat5.OutputBuffer.close(OutputBuffer.java:328)
at org.apache.coyote.tomcat5.CoyoteResponse.finishResponse
(CoyoteResponse.java:497)
at org.apache.coyote.tomcat5.CoyoteAdapter.service
(CoyoteAdapter.java:209)
at org.apache.coyote.http11.Http11Processor.process
(Http11Processor.java:828)
at 
org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.processConnectio
n(Http11Protocol.java:700)
at org.apache.tomcat.util.net.TcpWorkerThread.runIt
(PoolTcpEndpoint.java:584)
at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run
(ThreadPool.java:683)
at java.lang.Thread.run(Thread.java:536)

This would indicate to me that it is a bug..

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 26662] - ClassCastException in GzipOutputFilter

2004-02-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26662.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26662

ClassCastException in GzipOutputFilter

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |



--- Additional Comments From [EMAIL PROTECTED]  2004-02-04 16:23 ---
So basically, you are complining about stacktraces in your logs, right ?
I get ClassCastException's when navigating our site would be translated by a
normal guy as: I see the stacktrace in my browser.
Maybe it could happen when finishing an error request.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 26662] - ClassCastException in GzipOutputFilter

2004-02-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26662.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26662

ClassCastException in GzipOutputFilter

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-02-04 16:39 ---
I added a filter for the only branch of the if which wasn't adding a filter. I
don't quite understand when this branch code was being run; possibly in the case
of an error. So this is fixed.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 26662] - ClassCastException in GzipOutputFilter

2004-02-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26662.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26662

ClassCastException in GzipOutputFilter





--- Additional Comments From [EMAIL PROTECTED]  2004-02-04 17:34 ---
I know it seems silly (believe me I know!!) but I just do as management tells 
me to and they wanted me to see if I could get it fixed..

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 26662] - ClassCastException in GzipOutputFilter

2004-02-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26662.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26662

ClassCastException in GzipOutputFilter





--- Additional Comments From [EMAIL PROTECTED]  2004-02-04 19:44 ---
Okidoki. Feel free to test the patch.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]