DO NOT REPLY [Bug 28158] - Context reloadable=true not working if autodeploy=false

2004-04-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28158.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28158

Context reloadable=true not working if autodeploy=false





--- Additional Comments From [EMAIL PROTECTED]  2004-04-05 11:58 ---
 don't use server.xml, use a context file with a name matching the context name
Ok Remy. I've really tried everything now. Even with the Context-definition in a
seperate .xml file realoding doesn't work if autodeploy is true.

I tried every possible combination of autodeploy, deployonstartup and
context-paths. I can list the different attemps on détail if you want me to. 

The result in the end is always the same: if you don't turn on autodeploy
auto-reloading will not work! I don't say that there is a direct link between
those two. But I suspect that there is a different loader attached (or no loader
at all) to the context if its deployed directly (by specifying context in the
server.xml or in a specific context-xml) than if its deployed by the auto-deployer. 

So one of those if's here would not be true because of this.

if (getLoader() != null) { // -- no loader attached?
if (reloadable  (getLoader().modified())) { // .modified() never
returns true for attached loader

If you still think I'm wasting your time with this I'll have a closer look at
the code myself, but obviously it would be much easier for you to find the problem.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28158] - Context reloadable=true not working if autodeploy=false

2004-04-02 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28158.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28158

Context reloadable=true not working if autodeploy=false

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2004-04-02 13:28 ---
This is normal behavior. Webapps will be deployed if they are in appBase. Use
context files rather than context declarations in server.xml.
reloadable is also independant of the auto deployer, but wil only reload if
classes are modified.
Post on tomcat-user for this kind of issues, and don't reopen this report.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28158] - Context reloadable=true not working if autodeploy=false

2004-04-02 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28158.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28158

Context reloadable=true not working if autodeploy=false





--- Additional Comments From [EMAIL PROTECTED]  2004-04-02 13:35 ---
 reloadable is also independant of the auto deployer, but wil only reload if
classes are modified.

If you say that reloadable is independant of the autodeploayer, then reloadable 
with autodeploy=false should work and this bug would be valid.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28158] - Context reloadable=true not working if autodeploy=false

2004-04-02 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28158.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28158

Context reloadable=true not working if autodeploy=false





--- Additional Comments From [EMAIL PROTECTED]  2004-04-02 13:41 ---
If you look at the code, you'll see that class reloading is indeed independant
of auto deploy. This should be obvious enough (see below for the code in the
context). See, I'm sort of tired wasting my time testing non issues, so if you
could be convincing it would help me think this is going to be quality time.

/**
 * Execute a periodic task, such as reloading, etc. This method will be
 * invoked inside the classloading context of this container. Unexpected
 * throwables will be caught and logged.
 */
public void backgroundProcess() {

if (!started)
return;

count = (count + 1) % managerChecksFrequency;

if ((getManager() != null)  (count == 0)) {
try {
getManager().backgroundProcess();
} catch ( Exception x ) {
log.warn(Unable to perform background process on manager,x);
}
}

if (getLoader() != null) {
if (reloadable  (getLoader().modified())) {
try {
Thread.currentThread().setContextClassLoader
(StandardContext.class.getClassLoader());
reload();
} finally {
if (getLoader() != null) {
Thread.currentThread().setContextClassLoader
(getLoader().getClassLoader());
}
}
}
if (getLoader() instanceof WebappLoader) {
((WebappLoader) getLoader()).closeJARs(false);
}
}

}

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28158] - Context reloadable=true not working if autodeploy=false

2004-04-02 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28158.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28158

Context reloadable=true not working if autodeploy=false





--- Additional Comments From [EMAIL PROTECTED]  2004-04-02 13:55 ---
I don't intend to waste your time. Reporting a bug costs my time too, so I only
do it if I think I found a bug, not to missuse bugzilla as a forum.

I don't know if the code you provided is correct or not, as I don't have insight
in the tomcat source. I just managed to reproduce the following behaviour in
Tomcat 5 (and 4), which is faulty IMO:

Auto-reload works fine as long as I have autodeploy=true for the host my
context resits in. As soon is I trun autodeploy off, reloading of the context
doesn't work anymore. So the relaoding-feature of a webapp seems to be somehow
dependant of the autodeploy feature on the host.

I posted the second part with the multiple deployment only to show why I think
fixing this is important.

I'm glad to post a server.xml to show what I think is a bug. Maybe you could
confirm it then.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28158] - Context reloadable=true not working if autodeploy=false

2004-04-02 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28158.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28158

Context reloadable=true not working if autodeploy=false





--- Additional Comments From [EMAIL PROTECTED]  2004-04-02 14:21 ---
Ok, so:
- I tested and it works
- (as I said but you don't want to listen) don't use server.xml, use a context
file with a name matching the context name

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28158] - Context reloadable=true not working if autodeploy=false

2004-04-02 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28158.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28158

Context reloadable=true not working if autodeploy=false





--- Additional Comments From [EMAIL PROTECTED]  2004-04-02 14:29 ---
 - I tested and it works
How can you know if it works if you don't have my server.xml? 

 - (as I said but you don't want to listen) don't use server.xml, use a context
file with a name matching the context name
I did listen. Its just not a solution. Its as valid to put the whole 
configuration in the server.xml as it is to put it into individual files.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28158] - Context reloadable=true not working if autodeploy=false

2004-04-02 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28158.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28158

Context reloadable=true not working if autodeploy=false





--- Additional Comments From [EMAIL PROTECTED]  2004-04-02 14:34 ---
Created an attachment (id=11103)
server.xml used (see comment in file)

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28158] - Context reloadable=true not working if autodeploy=false

2004-04-02 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28158.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28158

Context reloadable=true not working if autodeploy=false





--- Additional Comments From [EMAIL PROTECTED]  2004-04-02 15:48 ---
Please try to read my comments. Thanks.
don't use server.xml, use a context file with a name matching the context name

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]