DO NOT REPLY [Bug 8024] - Can't include entities in web.xml

2002-04-30 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8024.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8024

Can't include entities in web.xml





--- Additional Comments From [EMAIL PROTECTED]  2002-04-30 21:00 ---
(Is there an easy way to tell exactly what changes went into a fix for a bug? I
don't see any way to do that, unless the fix comment informally states what was
changed.)

As I've built tomcat-4.0 from the latest CVS, I would expect I'm getting the
required fix for this.  Unfortunately, it appears to have had no effect.

When I precompile my JSP pages, it still complains about the file reference.

If I use this:

!ENTITY webinc PUBLIC webinc file:./webinc.xml

I get:

XML parsing error on file /WEB-INF/web.xml: java.io.FileNotFoundException:
.\webinc.xml (The system cannot find the file specified)

I I use this:

XML parsing error on file /WEB-INF/web.xml: (line 6, col -1): Relative URI
webinc.xml; can not be resolved without a base URI.

I've also tried ./webinc.xml and file:webinc.xml, but both give the previous
error.

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 8024] - Can't include entities in web.xml

2002-04-24 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8024.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8024

Can't include entities in web.xml





--- Additional Comments From [EMAIL PROTECTED]  2002-04-24 12:18 ---
You are right, however I was talking about enhancing the Digester.parse(File) 
method. I have now submitted this as a separate Bug 8461 reported against the 
Commons/Digester/Nightly Build, together with a patch.

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 8024] - Can't include entities in web.xml

2002-04-23 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8024.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8024

Can't include entities in web.xml





--- Additional Comments From [EMAIL PROTECTED]  2002-04-23 07:26 ---
Having thought more about this, there's a better patch: rewriting the 
Digester.parse(File) method to use an input source with systemId set. That way, 
you wouldn't have to hunt down all usages of it in the Tomcat code, not to 
speak about the fact that other projects using the Digester would also benefit 
instantly from the patch.

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 8024] - Can't include entities in web.xml

2002-04-23 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8024.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8024

Can't include entities in web.xml





--- Additional Comments From [EMAIL PROTECTED]  2002-04-23 15:27 ---
Digester.parse() is an overloaded method -- you've got the choice to call it
with a File, an InputSource, an InputStream, a Reader, or a String (containing a
URL).  In the InputStream or Reader cases, there is no way for Digester to
derive what the appropriate System ID should have been, so constructing an
InputSource around it will not help.

So, I modified Tomcat (which was using the InputStream argument) to calculate
the appropriate InputSource first, because it knows where the server.xml or
web.xml file is coming from so that it can calculate  a useful URL. 
Interestingly, it even works when web.xml is inside an unpacked WAR file,
because the rules for resolving a relative URL against an absolute one still
work fine.

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 8024] - Can't include entities in web.xml

2002-04-22 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8024.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8024

Can't include entities in web.xml

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2002-04-22 19:05 ---
The proposed patch only covers the parsing of the conf/server.xml file, so I
extended this for the places in o.a.c.startup.ContextConfig that web.xml files
are parsed as well.  This still doesn't cover TLDs (which are parsed in
ContextConfig to register listeners, and parsed in Jasper as part of
compilation), but I suspect the need for external entities in TLDs is a lot less
common.

Fixed in nightly build 20020423.  Thanks for the patch!

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 8024] - Can't include entities in web.xml

2002-04-16 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8024.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8024

Can't include entities in web.xml





--- Additional Comments From [EMAIL PROTECTED]  2002-04-16 14:35 ---
Created an attachment (id=1599)
The patch that fixes the bug

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 8024] - Can't include entities in web.xml

2002-04-16 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8024.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8024

Can't include entities in web.xml





--- Additional Comments From [EMAIL PROTECTED]  2002-04-16 14:37 ---
Created an attachment (id=1600)
A *more correct* fix to the bug... ignore the previous, this is the right one.

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]