DO NOT REPLY [Bug 8200] - include (PageContext) does not throw IOException if resource not available

2003-12-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8200.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8200

include (PageContext) does not throw IOException if resource not available

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX



--- Additional Comments From [EMAIL PROTECTED]  2003-12-19 13:12 ---
I would prefer to fix this to conform with the spec but in light of Bill's 
comments, I am going to resolve this as WONTFIX.  My reasons are as follows 
(most important first):

- I can't see a clean solution for all possible cases. The points where the 
exception needs to be thrown may be reached from a number of include methods 
and there is no easy way to determine if it was PageContext.include
- It has been like this for a while and has not caused a large number of 
problems.
- The 2.0 spec changes.

If anyone can see a clean solution, then I would be happy for it to be applied.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 8200] - include (PageContext) does not throw IOException if resource not available

2003-12-18 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8200.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8200

include (PageContext) does not throw IOException if resource not available





--- Additional Comments From [EMAIL PROTECTED]  2003-12-18 22:59 ---
I have a proposed patch for this. I am not 100% sure about this patch so I 
would be grateful if one of the committers with more knowledge of jasper than 
I reviewed the patch before it gets committed.

I will attach the patch shortly.

Thanks.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 8200] - include (PageContext) does not throw IOException if resource not available

2003-12-18 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8200.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8200

include (PageContext) does not throw IOException if resource not available





--- Additional Comments From [EMAIL PROTECTED]  2003-12-18 22:59 ---
Created an attachment (id=9636)
Proposed patch for TC4 to fix this bug

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 8200] - include (PageContext) does not throw IOException if resource not available

2003-12-18 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8200.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8200

include (PageContext) does not throw IOException if resource not available





--- Additional Comments From [EMAIL PROTECTED]  2003-12-19 01:04 ---
The patch looks OK.

However, be aware that this part of spec has been updated in JSP 2.0, so that
the  behavior of PageContext.include now follows that of
javax.servlet.RequestDispatcher.include.  So if this is fixed in TC4, it would
behave differently from TC5.

I wouldn't mind if this bug is resolved to WONTFIX, just to keep the same
behavior in both versions of TC.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 8200] - include (PageContext) does not throw IOException if resource not available

2003-12-18 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8200.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8200

include (PageContext) does not throw IOException if resource not available





--- Additional Comments From [EMAIL PROTECTED]  2003-12-19 01:36 ---
It doesn't look like the patch will work for the case of a mapped Servlet 
(e.g. a pre-compiled JSP).  There is no reason to expect that there will be a 
physical resource on the other end of the request.

I like the WONTFIX personally, since it is cleanest.  Otherwise, maybe having 
DefaultServlet throw a FileNotFound exception if it is being included.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]