DO NOT REPLY [Bug 36169] - [PATCH] Enable chunked encoding for IIS JK connector

2005-08-15 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36169.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36169





--- Additional Comments From [EMAIL PROTECTED]  2005-08-15 17:58 ---
(In reply to comment #2)
 Have you verified this works?

I've verified it on IIS 5.0 on Win2K and IIS 5.1 on WinXPPro, at least during
our modest testing.  I tried only to make changes to the IIS-specific code, but
obviously made one change to jk_ajp_common.c.  It's probably possible to
rollback the change to jk_ajp_common.c and add code to the IIS-specific pieces
so that the if-statement in jk_ajp_common.c is still tripped accordingly.

In the case of IIS, most of the work of dealing with HTTP is left up to the
ISAPI filters; IIS does very little for you.

Anyway, my familiarity with the connector code involves the few hours I spent
getting chunked encoding to work properly with IIS.  I've tried to be a good
citizen and report the problem with a potential patch.  If there is a better way
to handle this, I certainly have no ego associated with my patch.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36169] - [PATCH] Enable chunked encoding for IIS JK connector

2005-08-14 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36169.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36169


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]
   ||com




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36169] - [PATCH] Enable chunked encoding for IIS JK connector

2005-08-14 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36169.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36169





--- Additional Comments From [EMAIL PROTECTED]  2005-08-14 23:41 ---
Have you verified this works?
Looking at the Apache 2.0 code, it seems to delegate both the chunked encoding
detection and the chunked encoded read to Apache via ap_* calls (and IIS isn't
gonna be that accomodating).
I can't see anywhere in the common read code that parses the chunk block length.

This will have some overlap with #15357 , which implements chunked encoding on
the outbound response.

I'd also suggest the check for Transfer-Encoding: chunked be moved up a bit to
where the Tomcat worker/query headers are checked for.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36169] New: - [PATCH] Enable chunked encoding for IIS JK connector

2005-08-12 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36169.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36169

   Summary: [PATCH] Enable chunked encoding for IIS JK connector
   Product: Tomcat 5
   Version: 5.0.28
  Platform: Other
OS/Version: Windows 2000
Status: NEW
  Keywords: PatchAvailable
  Severity: major
  Priority: P1
 Component: Native:JK
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


While looking through the JK connector code for the IIS integration, I found
that Chunked support is never turned on.  The JK codebase has support for
chunked encoding, but the IIS-specific packaging doesn't have any code to enable
this.

Attached is a patch to enable this.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36169] - [PATCH] Enable chunked encoding for IIS JK connector

2005-08-12 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36169.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36169





--- Additional Comments From [EMAIL PROTECTED]  2005-08-12 20:05 ---
Created an attachment (id=16023)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=16023action=view)
Patch enabling chunked transfer encoding for IIS


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: IIS JK Connector.

2002-10-22 Thread Henri Gomez
Mladen Turk wrote:



-Original Message-
From: Henri Gomez

The place is on apache.org, coding standards.

http://www.apache.org/dev/styleguide.html



So why don't we follow that ;).


Well it's a pretty long story ;-)




--
To unsubscribe, e-mail:   mailto:tomcat-dev-unsubscribe;jakarta.apache.org
For additional commands, e-mail: mailto:tomcat-dev-help;jakarta.apache.org




IIS JK Connector.

2002-10-21 Thread Steven Velez
I have run in to a problem using the JK (version 1) connector for IIS in
conjunction with an ISAPI filter put out in closed source.  Basically, this
other filter randomly deletes request headers for some reason and that
interrupts the communication between the filter and the extension that
implement the JK connector.
 
I was planning on working around this problem by passing request information
from the filter to the extension using shared memory (using a lookup table
and passing the index in the query string).  However, I was wondering if the
patch would be more likely to be accepted if the new mechanism was enabled
via a configuration option (or compile setting) or if I could just go ahead
make that the communication mechanism.
 
Also, is there a place I can go to read the coding standards for Jakarta,
C-language projects?
 
 
Thanks
 
Steven B. Velez
Software Engineer
alventive
[EMAIL PROTECTED]
 



Re: IIS JK Connector.

2002-10-21 Thread Henri Gomez
Steven Velez wrote:

I have run in to a problem using the JK (version 1) connector for IIS in
conjunction with an ISAPI filter put out in closed source.  Basically, this
other filter randomly deletes request headers for some reason and that
interrupts the communication between the filter and the extension that
implement the JK connector.
 
I was planning on working around this problem by passing request information
from the filter to the extension using shared memory (using a lookup table
and passing the index in the query string).  However, I was wondering if the
patch would be more likely to be accepted if the new mechanism was enabled
via a configuration option (or compile setting) or if I could just go ahead
make that the communication mechanism.
 
Also, is there a place I can go to read the coding standards for Jakarta,
C-language projects?

The place is on apache.org, coding standards.

http://www.apache.org/dev/styleguide.html




--
To unsubscribe, e-mail:   mailto:tomcat-dev-unsubscribe;jakarta.apache.org
For additional commands, e-mail: mailto:tomcat-dev-help;jakarta.apache.org




RE: IIS JK Connector.

2002-10-21 Thread Mladen Turk


 -Original Message-
 From: Henri Gomez
 
 The place is on apache.org, coding standards.
 
 http://www.apache.org/dev/styleguide.html

So why don't we follow that ;).

MT.



--
To unsubscribe, e-mail:   mailto:tomcat-dev-unsubscribe;jakarta.apache.org
For additional commands, e-mail: mailto:tomcat-dev-help;jakarta.apache.org