Re: [PATCH] RE: mod_webapp and other connectors status...
Martin van den Bemt wrote: I tried the latest mod_webapp (build from jakarta-tomcat-connectors, head branch) and starting up apache before tomcat still gives the error Web-aplication not yet deployed (in wa_request.c). I thought : what the hack, let's fix this ;) Great the patch looks very easy... Checking the result of calling wa_startup() more than once will take a while. I am worried by the following (in warp_handle): +++ /* Check application */ if (((int)(appl-conf))==-1) return(wa_rerror(WA_MARK,r,404,Application not deployed)); +++ I have already checked that it has no impact on TC (On Already deployed applications). Attached the diff to the current cvs version of wa_request Please look at it carefully, because I don't have a clue what I really did, so it could mean a lot of memory leaks or bad programming (let's say it's bin a while I did c and this is the first time I looked at the source,so..) Hope it is usefull (for me it is for now btw..) Mvgr, Martin PS My first patch, and not even a java one ;) -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of jean-frederic clere Sent: Tuesday, January 08, 2002 15:11 To: Tomcat Developers List Subject: Re: mod_webapp and other connectors status... Martin van den Bemt wrote: Hi everyone, I probably missed a couple of threads on mod_webapp, so forgive me ;) In the release notes of v4.0.2-b1 it states : * If you restart Tomcat, you must also restart Apache to avoid receiving Error 400 - Bad Request errors. This will be handled transparently in the final release. Is this dependend on the return of Pier, or is someone else working on this already ? I think it is fixed. And if second applies : Is the mod_webapp code integrated into the tomcat 4 cvs already or do I have to get the latest from cvs ? In jakarta-tomcat-connectors. Also I saw a lot of commits come by for ajp (i think the new ajp14??). Can I be of any testing assistance in that area ? I am using tomcat 4 (also have the cvs version of tomcat 3.3 running) and both apache 1.3 and apache 2 running on redhat 7.1 linux boxes. I also depend heavily on virtual hosting, so that is the main reason I want to test this.. (restarting tomcat, without restarting apache and everything keeps on running ;). If there are any specific points you want to be tested, just mail me and I let you know (have an almost clean server on the internet right, which for now hasn't any production stuff on there... Mvgr, Martin van den Bemt -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] Name: wa_request.patch wa_request.patchType: unspecified type (application/octet-stream) Encoding: quoted-printable -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [PATCH] RE: mod_webapp and other connectors status...
Martin van den Bemt wrote: I tried the latest mod_webapp (build from jakarta-tomcat-connectors, head branch) and starting up apache before tomcat still gives the error Web-aplication not yet deployed (in wa_request.c). I thought : what the hack, let's fix this ;) Attached the diff to the current cvs version of wa_request Please look at it carefully, because I don't have a clue what I really did, so it could mean a lot of memory leaks or bad programming (let's say it's bin a while I did c and this is the first time I looked at the source,so..) Hope it is usefull (for me it is for now btw..) I have committed it - Many thanks - Mvgr, Martin PS My first patch, and not even a java one ;) -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of jean-frederic clere Sent: Tuesday, January 08, 2002 15:11 To: Tomcat Developers List Subject: Re: mod_webapp and other connectors status... Martin van den Bemt wrote: Hi everyone, I probably missed a couple of threads on mod_webapp, so forgive me ;) In the release notes of v4.0.2-b1 it states : * If you restart Tomcat, you must also restart Apache to avoid receiving Error 400 - Bad Request errors. This will be handled transparently in the final release. Is this dependend on the return of Pier, or is someone else working on this already ? I think it is fixed. And if second applies : Is the mod_webapp code integrated into the tomcat 4 cvs already or do I have to get the latest from cvs ? In jakarta-tomcat-connectors. Also I saw a lot of commits come by for ajp (i think the new ajp14??). Can I be of any testing assistance in that area ? I am using tomcat 4 (also have the cvs version of tomcat 3.3 running) and both apache 1.3 and apache 2 running on redhat 7.1 linux boxes. I also depend heavily on virtual hosting, so that is the main reason I want to test this.. (restarting tomcat, without restarting apache and everything keeps on running ;). If there are any specific points you want to be tested, just mail me and I let you know (have an almost clean server on the internet right, which for now hasn't any production stuff on there... Mvgr, Martin van den Bemt -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] Name: wa_request.patch wa_request.patchType: unspecified type (application/octet-stream) Encoding: quoted-printable -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: [PATCH] RE: mod_webapp and other connectors status...
I found an issue I think.. When you stop an webapplication, the application comes available again through webapp (I tried to stop tomcat-docs and it was still reachable by mod_webapp.so), so I think it needs some tweaking.. Mvgr, martin -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of jean-frederic clere Sent: Wednesday, January 09, 2002 11:25 To: Tomcat Developers List Subject: Re: [PATCH] RE: mod_webapp and other connectors status... Martin van den Bemt wrote: I tried the latest mod_webapp (build from jakarta-tomcat-connectors, head branch) and starting up apache before tomcat still gives the error Web-aplication not yet deployed (in wa_request.c). I thought : what the hack, let's fix this ;) Great the patch looks very easy... Checking the result of calling wa_startup() more than once will take a while. I am worried by the following (in warp_handle): +++ /* Check application */ if (((int)(appl-conf))==-1) return(wa_rerror(WA_MARK,r,404,Application not deployed)); +++ I have already checked that it has no impact on TC (On Already deployed applications). Attached the diff to the current cvs version of wa_request Please look at it carefully, because I don't have a clue what I really did, so it could mean a lot of memory leaks or bad programming (let's say it's bin a while I did c and this is the first time I looked at the source,so..) Hope it is usefull (for me it is for now btw..) Mvgr, Martin PS My first patch, and not even a java one ;) -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of jean-frederic clere Sent: Tuesday, January 08, 2002 15:11 To: Tomcat Developers List Subject: Re: mod_webapp and other connectors status... Martin van den Bemt wrote: Hi everyone, I probably missed a couple of threads on mod_webapp, so forgive me ;) In the release notes of v4.0.2-b1 it states : * If you restart Tomcat, you must also restart Apache to avoid receiving Error 400 - Bad Request errors. This will be handled transparently in the final release. Is this dependend on the return of Pier, or is someone else working on this already ? I think it is fixed. And if second applies : Is the mod_webapp code integrated into the tomcat 4 cvs already or do I have to get the latest from cvs ? In jakarta-tomcat-connectors. Also I saw a lot of commits come by for ajp (i think the new ajp14??). Can I be of any testing assistance in that area ? I am using tomcat 4 (also have the cvs version of tomcat 3.3 running) and both apache 1.3 and apache 2 running on redhat 7.1 linux boxes. I also depend heavily on virtual hosting, so that is the main reason I want to test this.. (restarting tomcat, without restarting apache and everything keeps on running ;). If there are any specific points you want to be tested, just mail me and I let you know (have an almost clean server on the internet right, which for now hasn't any production stuff on there... Mvgr, Martin van den Bemt -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] Name: wa_request.patch wa_request.patchType: unspecified type (application/octet-stream) Encoding: quoted-printable -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]