RE: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads ThreadPool.java ThreadPoolMX.java
Hi Costin, jtc/util still contains org.apache.tomcat.util.mx.DynamicMBeanProxy which imports javax.management.*. Is the intent to update or remove this class so the dependency on JMX can be removed? Thanks. Cheers, Larry -Original Message- From: Costin Manolache [mailto:[EMAIL PROTECTED]] Sent: Monday, January 27, 2003 10:39 AM To: [EMAIL PROTECTED] Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/thr eads ThreadPool.java ThreadPoolMX.java FYI: I did the same in the main branch. All of DynamicMBean features are now porte to modeler. There is no need for JMX dependency in jtc/util ( the branch is still needed in coyote, jk, http11 ) Costin [EMAIL PROTECTED] wrote: billbarker2003/01/24 20:49:24 Modified:util/java/org/apache/tomcat/util/threads Tag: coyote_10 ThreadPool.java Removed: util/java/org/apache/tomcat/util/threads Tag: coyote_10 ThreadPoolMX.java Log: Removing JMX dependencies from this branch (as voted on in tomcat-dev). Revision ChangesPath No revision No revision 1.9.2.1 +0 -9 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/thr eads/ThreadPool.java Index: ThreadPool.java === RCS file: /home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomca t/util/threads/ThreadPool.java,v retrieving revision 1.9 retrieving revision 1.9.2.1 diff -u -r1.9 -r1.9.2.1 --- ThreadPool.java 14 Jan 2003 18:47:39 - 1.9 +++ ThreadPool.java 25 Jan 2003 04:49:24 - 1.9.2.1 @@ -159,15 +159,6 @@ * call register() in order to set a name. */ public static ThreadPool createThreadPool(boolean jmx) { -if( jmx ) { -try { -Class.forName( org.apache.commons.modeler.Registry); -Class tpc=Class.forName( org.apache.tomcat.util.threads.ThreadPoolMX); -ThreadPool res=(ThreadPool)tpc.newInstance(); -return res; -} catch( Exception ex ) { -} -} return new ThreadPool(); } -- To unsubscribe, e-mail: mailto:tomcat-dev- [EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads ThreadPool.java ThreadPoolMX.java
Larry Isaacs wrote: Hi Costin, jtc/util still contains org.apache.tomcat.util.mx.DynamicMBeanProxy which imports javax.management.*. Is the intent to update or remove this class so the dependency on JMX can be removed? Thanks. To deprecate - for sure, there is no point in maintaining it when the same functionality is in modeler. I made quite a few improvements to the equivalent code in modeler ( support for more types, automatic detection of .xml descriptors, etc ). About remove - I don't know if it was included in any official release, and if removing it won't break code. I know of a use in 3.3, is anyone else using it ? We definitely need a way to document what APIs are FROZEN ( like mozilla ). Costin Cheers, Larry -Original Message- From: Costin Manolache [mailto:[EMAIL PROTECTED]] Sent: Monday, January 27, 2003 10:39 AM To: [EMAIL PROTECTED] Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/thr eads ThreadPool.java ThreadPoolMX.java FYI: I did the same in the main branch. All of DynamicMBean features are now porte to modeler. There is no need for JMX dependency in jtc/util ( the branch is still needed in coyote, jk, http11 ) Costin [EMAIL PROTECTED] wrote: billbarker2003/01/24 20:49:24 Modified:util/java/org/apache/tomcat/util/threads Tag: coyote_10 ThreadPool.java Removed: util/java/org/apache/tomcat/util/threads Tag: coyote_10 ThreadPoolMX.java Log: Removing JMX dependencies from this branch (as voted on in tomcat-dev). Revision ChangesPath No revision No revision 1.9.2.1 +0 -9 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/thr eads/ThreadPool.java Index: ThreadPool.java === RCS file: /home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomca t/util/threads/ThreadPool.java,v retrieving revision 1.9 retrieving revision 1.9.2.1 diff -u -r1.9 -r1.9.2.1 --- ThreadPool.java 14 Jan 2003 18:47:39 - 1.9 +++ ThreadPool.java 25 Jan 2003 04:49:24 - 1.9.2.1 @@ -159,15 +159,6 @@ * call register() in order to set a name. */ public static ThreadPool createThreadPool(boolean jmx) { -if( jmx ) { -try { -Class.forName( org.apache.commons.modeler.Registry); -Class tpc=Class.forName( org.apache.tomcat.util.threads.ThreadPoolMX); -ThreadPool res=(ThreadPool)tpc.newInstance(); -return res; -} catch( Exception ex ) { -} -} return new ThreadPool(); } -- To unsubscribe, e-mail: mailto:tomcat-dev- [EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads ThreadPool.java ThreadPoolMX.java
I'll assume DynamicMBeanProxy will stay for now and make sure the jtc/util projects in Gump still show a dependency on JMX. Larry -Original Message- From: Costin Manolache [mailto:[EMAIL PROTECTED]] Sent: Monday, January 27, 2003 3:55 PM To: [EMAIL PROTECTED] Subject: RE: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/thr eads ThreadPool.java ThreadPoolMX.java Larry Isaacs wrote: Hi Costin, jtc/util still contains org.apache.tomcat.util.mx.DynamicMBeanProxy which imports javax.management.*. Is the intent to update or remove this class so the dependency on JMX can be removed? Thanks. To deprecate - for sure, there is no point in maintaining it when the same functionality is in modeler. I made quite a few improvements to the equivalent code in modeler ( support for more types, automatic detection of .xml descriptors, etc ). About remove - I don't know if it was included in any official release, and if removing it won't break code. I know of a use in 3.3, is anyone else using it ? We definitely need a way to document what APIs are FROZEN ( like mozilla ). Costin Cheers, Larry -Original Message- From: Costin Manolache [mailto:[EMAIL PROTECTED]] Sent: Monday, January 27, 2003 10:39 AM To: [EMAIL PROTECTED] Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/thr eads ThreadPool.java ThreadPoolMX.java FYI: I did the same in the main branch. All of DynamicMBean features are now porte to modeler. There is no need for JMX dependency in jtc/util ( the branch is still needed in coyote, jk, http11 ) Costin [EMAIL PROTECTED] wrote: billbarker2003/01/24 20:49:24 Modified:util/java/org/apache/tomcat/util/threads Tag: coyote_10 ThreadPool.java Removed: util/java/org/apache/tomcat/util/threads Tag: coyote_10 ThreadPoolMX.java Log: Removing JMX dependencies from this branch (as voted on in tomcat-dev). Revision ChangesPath No revision No revision 1.9.2.1 +0 -9 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/thr eads/ThreadPool.java Index: ThreadPool.java === RCS file: /home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomca t/util/threads/ThreadPool.java,v retrieving revision 1.9 retrieving revision 1.9.2.1 diff -u -r1.9 -r1.9.2.1 --- ThreadPool.java 14 Jan 2003 18:47:39 - 1.9 +++ ThreadPool.java 25 Jan 2003 04:49:24 - 1.9.2.1 @@ -159,15 +159,6 @@ * call register() in order to set a name. */ public static ThreadPool createThreadPool(boolean jmx) { -if( jmx ) { -try { -Class.forName( org.apache.commons.modeler.Registry); -Class tpc=Class.forName( org.apache.tomcat.util.threads.ThreadPoolMX); -ThreadPool res=(ThreadPool)tpc.newInstance(); -return res; -} catch( Exception ex ) { -} -} return new ThreadPool(); } -- To unsubscribe, e-mail: mailto:tomcat-dev- [EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:tomcat-dev- [EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads ThreadPool.java ThreadPoolMX.java
I'll take Sam's suggestions (probably tomorrow, since it is a bit late for me to get it right now :). It's a bit of a gray area. Tomcat 3.3 should gump-build fine as is. As long as you are using the HEAD commons-modeler, then you have no problems building the HEAD j-t-c. The branch is for the 'standard-build' of TC 3.3 (which, until Larry's patch) had no dependencies on any version of commons-modeler. - Original Message - From: Ignacio J. Ortega [EMAIL PROTECTED] To: 'Tomcat Developers List' [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Sent: Saturday, January 25, 2003 8:35 AM Subject: RE: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads ThreadPool.java ThreadPoolMX.java Bill, we will need another gump descriptor to build coyote_10 tag jtc sources obviously, to allow tc33 to be gumped correctly? Anyone with more knowledge of gump can help ? billbarker2003/01/24 20:49:24 Modified:util/java/org/apache/tomcat/util/threads Tag: coyote_10 ThreadPool.java Removed: util/java/org/apache/tomcat/util/threads Tag: coyote_10 ThreadPoolMX.java (Care with double posting please) Saludos, Ignacio J. Ortega -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads ThreadPool.java ThreadPoolMX.java
Bill, we will need another gump descriptor to build coyote_10 tag jtc sources obviously, to allow tc33 to be gumped correctly? Anyone with more knowledge of gump can help ? billbarker2003/01/24 20:49:24 Modified:util/java/org/apache/tomcat/util/threads Tag: coyote_10 ThreadPool.java Removed: util/java/org/apache/tomcat/util/threads Tag: coyote_10 ThreadPoolMX.java (Care with double posting please) Saludos, Ignacio J. Ortega -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads ThreadPool.java ThreadPoolMX.java
billbarker2003/01/24 20:49:24 Modified:util/java/org/apache/tomcat/util/threads Tag: coyote_10 ThreadPool.java Removed: util/java/org/apache/tomcat/util/threads Tag: coyote_10 ThreadPoolMX.java Log: Removing JMX dependencies from this branch (as voted on in tomcat-dev). Revision ChangesPath No revision No revision 1.9.2.1 +0 -9 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/ThreadPool.java Index: ThreadPool.java === RCS file: /home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/ThreadPool.java,v retrieving revision 1.9 retrieving revision 1.9.2.1 diff -u -r1.9 -r1.9.2.1 --- ThreadPool.java 14 Jan 2003 18:47:39 - 1.9 +++ ThreadPool.java 25 Jan 2003 04:49:24 - 1.9.2.1 @@ -159,15 +159,6 @@ * call register() in order to set a name. */ public static ThreadPool createThreadPool(boolean jmx) { -if( jmx ) { -try { -Class.forName( org.apache.commons.modeler.Registry); -Class tpc=Class.forName( org.apache.tomcat.util.threads.ThreadPoolMX); -ThreadPool res=(ThreadPool)tpc.newInstance(); -return res; -} catch( Exception ex ) { -} -} return new ThreadPool(); } -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads ThreadPool.java ThreadPoolMX.java
costin 2003/01/20 16:17:11 Modified:util/java/org/apache/tomcat/util/threads ThreadPool.java ThreadPoolMX.java Log: Remove the dependency on JMX. ThreadPoolMX will be wrapped in a model mbean - but it doesn't need to depend on JMX. Revision ChangesPath 1.10 +0 -5 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/ThreadPool.java Index: ThreadPool.java === RCS file: /home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/ThreadPool.java,v retrieving revision 1.9 retrieving revision 1.10 diff -u -r1.9 -r1.10 --- ThreadPool.java 14 Jan 2003 18:47:39 - 1.9 +++ ThreadPool.java 21 Jan 2003 00:17:11 - 1.10 @@ -171,11 +171,6 @@ return new ThreadPool(); } -public void register( String domain, String name ) { -// nothing in the base class - it'll register in jmx mode -// We could use the name to create a ThreadGroup and name threads -} - public synchronized void start() { stopThePool=false; currentThreadCount = 0; 1.4 +0 -13 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/ThreadPoolMX.java Index: ThreadPoolMX.java === RCS file: /home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/ThreadPoolMX.java,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- ThreadPoolMX.java 14 Jan 2003 18:47:39 - 1.3 +++ ThreadPoolMX.java 21 Jan 2003 00:17:11 - 1.4 @@ -63,7 +63,6 @@ import java.util.*; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; -import org.apache.commons.modeler.Registry; /** * Manageable thread pool @@ -72,24 +71,12 @@ */ public class ThreadPoolMX extends ThreadPool { static Log log = LogFactory.getLog(ThreadPoolMX.class); -Registry reg; protected String domain; protected String name; public ThreadPoolMX() { super(); -} - -public void register(String domain, String name) { -this.name=name; -this.domain=domain; -reg=Registry.getRegistry(); -try { -reg.registerComponent(this, domain, ThreadPool, name); -} catch( Exception ex ) { -log.error( Error registering thread pool, ex ); -} } public synchronized void start() { -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads ThreadPool.java ThreadPoolMX.java
costin 2003/01/14 10:47:39 Modified:util/java/org/apache/tomcat/util/threads ThreadPool.java ThreadPoolMX.java Log: Pass the domain. ThreadPools should be registered in the same domain with all catalina mbeans. Revision ChangesPath 1.9 +1 -1 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/ThreadPool.java Index: ThreadPool.java === RCS file: /home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/ThreadPool.java,v retrieving revision 1.8 retrieving revision 1.9 diff -u -r1.8 -r1.9 --- ThreadPool.java 12 Jan 2003 19:07:07 - 1.8 +++ ThreadPool.java 14 Jan 2003 18:47:39 - 1.9 @@ -171,7 +171,7 @@ return new ThreadPool(); } -public void register( String name ) { +public void register( String domain, String name ) { // nothing in the base class - it'll register in jmx mode // We could use the name to create a ThreadGroup and name threads } 1.3 +2 -1 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/ThreadPoolMX.java Index: ThreadPoolMX.java === RCS file: /home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/ThreadPoolMX.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- ThreadPoolMX.java 12 Jan 2003 19:07:07 - 1.2 +++ ThreadPoolMX.java 14 Jan 2003 18:47:39 - 1.3 @@ -81,8 +81,9 @@ super(); } -public void register(String name) { +public void register(String domain, String name) { this.name=name; +this.domain=domain; reg=Registry.getRegistry(); try { reg.registerComponent(this, domain, ThreadPool, name); -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads ThreadPool.java ThreadPoolMX.java
costin 2003/01/12 11:07:07 Modified:util/java/org/apache/tomcat/util/threads ThreadPool.java ThreadPoolMX.java Log: Few more changes ( on the new jmx code ). Old code will continue to use the normal pool, new code can get a JMX pool if JMX is available. We could move some of the methods I added to ThreadPoolMX. One big issue: support for chainging pool params at runtime ! Revision ChangesPath 1.8 +27 -10 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/ThreadPool.java Index: ThreadPool.java === RCS file: /home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/ThreadPool.java,v retrieving revision 1.7 retrieving revision 1.8 diff -u -r1.7 -r1.8 --- ThreadPool.java 11 Jan 2003 06:55:24 - 1.7 +++ ThreadPool.java 12 Jan 2003 19:07:07 - 1.8 @@ -123,8 +123,6 @@ /* Flag to control if the main thread is 'daemon' */ protected boolean isDaemon=true; - -static int debug=0; /** The threads that are part of the pool. * Key is Thread, value is the ControlRunnable @@ -133,6 +131,10 @@ protected Vector listeners=new Vector(); +/** Name of the threadpool + */ +protected String name=null; + /** * Helper object for logging **/ @@ -148,17 +150,32 @@ } -public static ThreadPool createThreadPool() { -try { -Class.forName( org.apache.commons.modeler.Registry); -Class tpc=Class.forName( org.apache.tomcat.util.threads.ThreadPoolMX); -ThreadPool res=(ThreadPool)tpc.newInstance(); -return res; -} catch( Exception ex ) { +/** Create a ThreadPool instance. + * + * @param jmx True if you want a pool with JMX support. A regular pool + * will be returned if JMX or the modeler are not available. + * + * @return ThreadPool instance. If JMX support is requested, you need to + * call register() in order to set a name. + */ +public static ThreadPool createThreadPool(boolean jmx) { +if( jmx ) { +try { +Class.forName( org.apache.commons.modeler.Registry); +Class tpc=Class.forName( org.apache.tomcat.util.threads.ThreadPoolMX); +ThreadPool res=(ThreadPool)tpc.newInstance(); +return res; +} catch( Exception ex ) { +} } return new ThreadPool(); } +public void register( String name ) { +// nothing in the base class - it'll register in jmx mode +// We could use the name to create a ThreadGroup and name threads +} + public synchronized void start() { stopThePool=false; currentThreadCount = 0; @@ -213,7 +230,7 @@ } public static int getDebug() { -return debug; +return 0; } /** The default is true - the created threads will be 1.2 +2 -14 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/ThreadPoolMX.java Index: ThreadPoolMX.java === RCS file: /home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/ThreadPoolMX.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- ThreadPoolMX.java 11 Jan 2003 06:52:27 - 1.1 +++ ThreadPoolMX.java 12 Jan 2003 19:07:07 - 1.2 @@ -81,23 +81,11 @@ super(); } -public void setDomain(String domain) { -this.domain=domain; -} -public String getDomain() { -return domain; -} - -public String getName() { -return name; -} - -public void setName(String name) { +public void register(String name) { this.name=name; reg=Registry.getRegistry(); try { -reg.registerComponent(this, domain, ThreadPool, -name= + name); +reg.registerComponent(this, domain, ThreadPool, name); } catch( Exception ex ) { log.error( Error registering thread pool, ex ); } -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]