RE: cvs commit:jakarta-tomcat/src/share/org/apache/tomcat/util/buf DateTool.java
It has all to do with standards. Tabs have been used for indentation for at least the last 15 years ( that's when I started playing with computers- and the tab was there ). But the point is that we're using SPACES... Since _EVER_... Discussion closed. I really doubt you guys have been using spaces everywhere since JServ. Look at Craig's source for JServ 2 (err, I mean, Catalina) : there are tabs everywhere ;) Frankly, I don't think we should make a big deal of the whole issue. Space Wars - Vi Strike Back ?)
Re: cvs commit:jakarta-tomcat/src/share/org/apache/tomcat/util/buf DateTool.java
on 5/26/01 10:18 AM, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
+// Called from MessageBytes.setTime
+/**
+ */
+public static String format1123( Date d ) {
+return rfc1123Format.format( d );
+}
+
+
+// Called from ServerCookie
+/**
+ */
+public static void formatOldCookie( Date d, StringBuffer sb,
+ FieldPosition fp )
+{
+oldCookieFormat.format( d, sb, fp );
+}
+
+// Called from ServerCookie
+public static String formatOldCookie( Date d )
+{
+return oldCookieFormat.format( d );
}
I thought we weren't using tab's in the files anymore...
-jon
Re: cvs commit:jakarta-tomcat/src/share/org/apache/tomcat/util/buf DateTool.java
on 5/27/01 5:04 PM, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: http://jakarta.apache.org/site/source.html Costin Costin, you are being stupid (again). However, some projects may decide to override these defaults and use their own defined conventions. -jon
Re: cvs commit:jakarta-tomcat/src/share/org/apache/tomcat/util/buf DateTool.java
on 5/27/01 5:25 PM, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Jon, try to write more code and less mail. Once again, you completely miss the point Costin. Your code isn't any good if people can't read the diff's that go into CVS because they don't format correctly in email clients because of the tab's. -jon
Re: cvs commit:jakarta-tomcat/src/share/org/apache/tomcat/util/buf DateTool.java
on 5/27/01 5:54 PM, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: It's a matter of principle here - the fact that some mail clients or editors chose to ignore standards and common practices doesn't mean the standard itself is bad and shouldn't be used. Costin Making developers jump through hoops (such as using a particular mail client) in order to participate in Tomcat development is not good for the project. Also, this has nothing to do with standards. People should be able to choose whatever font they want to read their email. -jon
Re: cvs commit:jakarta-tomcat/src/share/org/apache/tomcat/util/buf DateTool.java
on 5/27/01 6:45 PM, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: It has all to do with standards. Tabs have been used for indentation for at least the last 15 years ( that's when I started playing with computers- and the tab was there ). Great! I have you beat. I started creating software when I was 9 and now I'm 28. So there. A program to display a simple fixed-font text with tabs is quite trivial - and it's not jumping through hoops. A program that can deal with using spaces instead of tabs in the source files is quite trivial. -jon
Re: cvs commit:jakarta-tomcat/src/share/org/apache/tomcat/util/buf DateTool.java
[EMAIL PROTECTED] at [EMAIL PROTECTED] wrote: It has all to do with standards. Tabs have been used for indentation for at least the last 15 years ( that's when I started playing with computers- and the tab was there ). But the point is that we're using SPACES... Since _EVER_... Discussion closed. I really doubt you guys have been using spaces everywhere since JServ. Look at Craig's source for JServ 2 (err, I mean, Catalina) : there are tabs everywhere ;) Frankly, I don't think we should make a big deal of the whole issue. Remy
