DO NOT REPLY [Bug 15105] - pushBody()/popBody() error on tomcat 4.1.X

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15105>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15105

pushBody()/popBody() error on tomcat 4.1.X

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-01-15 00:20 ---
Ismael,

you've got a valid point there. :)
I just committed a fix for Tomcat 4.1.x.
As I said, this is already fixed in Tomcat 5.

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

DO NOT REPLY [Bug 15105] - pushBody()/popBody() error on tomcat 4.1.X

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15105>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15105

pushBody()/popBody() error on tomcat 4.1.X

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |
Summary|pushBody()/popBody() error  |pushBody()/popBody() error
   |on tomcat 4.1.12|on tomcat 4.1.X



--- Additional Comments From [EMAIL PROTECTED]  2003-01-14 09:29 ---
The problem is that you only control on tomcat 4.1.x when pushBody and popBody
are used on a jsp. But what happens if you use them directly as I do on my code.
You have to take into account that it is a method available to use directly on a
custom tag, then any clean operation should be done on the pushBody popBody methods.

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

DO NOT REPLY [Bug 15105] - pushBody()/popBody() error on tomcat 4.1.12

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15105>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15105

pushBody()/popBody() error on tomcat 4.1.12

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2003-01-14 00:32 ---
Notice that the behaviour your are experiencing indeed used to be a
bug, but it's been fixed.

In Tomcat 4.1.x, any BodyContent that is being reused is cleared in
the generated servlet code right after the call to pushBody(), like
this:

 javax.servlet.jsp.tagext.BodyContent _bc = pageContext.pushBody();
 _bc.clear();
 out = _bc;
 _jspx_th_xxx.setBodyContent(_bc);
 _jspx_th_xxx.doInitBody();

In Tomcat 5, the contents of a reused BodyContent are cleared inside
of org.apache.jasper.runtime.BodyContentImpl.setWriter(), so the
BodyContent returned by pushBody() has already been cleared.

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

DO NOT REPLY [Bug 15105] - pushBody()/popBody() error on tomcat 4.1.12

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15105>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15105

pushBody()/popBody() error on tomcat 4.1.12

[EMAIL PROTECTED] changed:

   What|Removed |Added

Version|4.1.12  |4.1.18



--- Additional Comments From [EMAIL PROTECTED]  2003-01-13 16:51 ---
I have reviewed 4.1.18 to see if this error has been fixed, but there is no
change. Is there any update about this bug ?

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

DO NOT REPLY [Bug 15105] - pushBody()/popBody() error on tomcat 4.1.12

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15105>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15105

pushBody()/popBody() error on tomcat 4.1.12





--- Additional Comments From [EMAIL PROTECTED]  2002-12-19 10:06 ---
For now, what I do to bypass this bug is to use the method
.clearBody() before I do a popBody().

But it should not be done this WAY, should it be ?

Sorry( I wrote why instead of way)

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

DO NOT REPLY [Bug 15105] - pushBody()/popBody() error on tomcat 4.1.12

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15105>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15105

pushBody()/popBody() error on tomcat 4.1.12





--- Additional Comments From [EMAIL PROTECTED]  2002-12-19 10:05 ---
For now, what I do to bypass this bug is to use the method
.clearBody() before I do a popBody().

But it should not be done this why, should it be ?

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

DO NOT REPLY [Bug 15105] - pushBody()/popBody() error on tomcat 4.1.12

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15105>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15105

pushBody()/popBody() error on tomcat 4.1.12

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |



--- Additional Comments From [EMAIL PROTECTED]  2002-12-09 17:42 ---
Lets verify all together the code :D

On the file PageContentImpl.java we have the two methods

public BodyContent pushBody() { 
depth++; 
if (depth >= outs.length) { 
BodyContent[] newOuts = new BodyContentImpl[depth + 1]; 
for (int i = 0; i < outs.length; i++) { 
newOuts[i] = outs[i]; 
} 
newOuts[depth] = new BodyContentImpl(out); 
outs = newOuts; 
} 
out = outs[depth]; 
return outs[depth]; 
} 
 
public JspWriter popBody() { 
depth--; 
if (depth >= 0) { 
out = outs[depth]; 
} else { 
out = baseOut; 
} 
return out; 
} 

As we can see on the code if we make two calls to pushBody(), then the array
outs will have two body outs A and B. If we make a popBody, then depth will be
decremented, but the B object is not removed from the outs array, then if I make
another pushBody() (this should create a new out object C, this is not done),
the outs array will have again two objects, but the second object will not be a
new one, it will be the previous B object. Then what will be in the second
element will be the new content plus previous content from B object,that is, the
new content will be appended.

Is not this the way it should work ? That is, create a new object when we make a
pushBody() OR clear the old object when we make a popBody().

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

DO NOT REPLY [Bug 15105] - pushBody()/popBody() error on tomcat 4.1.12

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15105>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15105

pushBody()/popBody() error on tomcat 4.1.12

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WORKSFORME



--- Additional Comments From [EMAIL PROTECTED]  2002-12-05 23:44 ---
pushBody and popBody are usually invoked by the generated codes, and they have
worked as expected.  Looking at the source in runtime/PageContextImpl.java also
does not support your claim that popBody writes to the previous body.  You'll
need to supply an actualy test case.

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

DO NOT REPLY [Bug 15105] New: - pushBody()/popBody() error on tomcat 4.1.12

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15105>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15105

pushBody()/popBody() error on tomcat 4.1.12

   Summary: pushBody()/popBody() error on tomcat 4.1.12
   Product: Tomcat 4
   Version: 4.1.12
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Critical
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


How it should work:

I am using bodytag that calls a pushBody(), then the current body writer
sould be kept and it should be createa a new one, later when I call the
popBody() the system should get the previous body (that is, the body
that has been kept on the call to pushBody())

What it does now:

All works as expected, but  after I call popBody() the new body writer
that has been created on the call to pushBody() writes its contents to
the previous body writer (that is, the body that has been kept on the
call to pushBody()). I think that the content should not been copied on
the other body writer.

It fails on Tomcat 4.1.12 and it works fine on Tomcat 4.0.X.

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

pushBody()/popBody() error on tomcat 4.1.12

[Ismael Blesa Part]

How it should work:

I am using bodytag that calls a pushBody(), then the current body writer
sould be kept and it should be createa a new one, later when I call the
popBody() the system should get the previous body (that is, the body
that has been kept on the call to pushBody())

What it does now:

All works as expected, but  after I call popBody() the new body writer
that has been created on the call to pushBody() writes its contents to
the previous body writer (that is, the body that has been kept on the
call to pushBody()). I think that the content should not been copied on
the other body writer.

It fails on Tomcat 4.1.12 and it works fine on Tomcat 4.0.X.


Cheers



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

pushBody()/popBody() error

[Ismael Blesa Part]

How it should work:

I am using bodytag that calls a pushBody(), then the current body writer 
sould be kept and it should be createa a new one, later when I call the 
popBody() the system should get the previous body (that is, the body 
that has been kept on the call to pushBody())

What it does now:

All works as expected, but  after I call popBody() the new body writer 
that has been created on the call to pushBody() writes its contents to 
the previous body writer (that is, the body that has been kept on the 
call to pushBody()). I think that the content should not been copied on 
the other body writer.

It fails on Tomcat 4.1.12 and it works fine on Tomcat 4.0.X.


Cheers


--
To unsubscribe, e-mail:   
For additional commands, e-mail: