date:20170313

Re: [tor-bugs] #20680 [Applications/Tor Browser]: Rebase Tor Browser patches to 52 ESR

2017-03-13 Thread Tor Bug Tracker & Wiki

#20680: Rebase Tor Browser patches to 52 ESR
-+-
 Reporter:  arthuredelstein  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, tbb-7.0-must,  |  Actual Points:
  TorBrowserTeam201703   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by arthuredelstein):

 A further small correction:
 https://github.com/arthuredelstein/tor-browser/commits/20680+8

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13018 [Applications/Tor Browser]: Math routines are OS fingerprintable

2017-03-13 Thread Tor Bug Tracker & Wiki

#13018: Math routines are OS fingerprintable
-+-
 Reporter:  mikeperry|  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-fingerprinting-os-version,   |  Actual Points:
  ff31-esr   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by yawning):

 A few notes:

  * A quick check with the browser console gives me the impression that
 simple JS math expressions are evaluated with 64 bit intermediaries (as
 opposed to 80 bit).  I am uncertain about the JS JIT behavior.  `(1.0 +
 Number.EPSILON * 0.5) + Number.EPSILON * 0.5`)

  * Assuming calls are made to libm (or equivalent) blindly, the results on
 each system are library version and implementation dependent.  A
 particularly egregious example would be the output of `double sin(double
 x);` being flat out wrong for glibc < 2.19 for certain values.  MS's VC++
 runtime is less wrong for a different set of certain values, but is still
 wrong.  This probably applies to most transcendental functions.

  * Even if we fix the JS that calls into libm, higher level apis that just
 happen to do math are not guaranteed to give the correct results,
 depending on how the native code it's called into is written or built.  If
 we can assume that x87 is never used at all, then we'd still need to check
 for things like ` rsqrtss`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21723 [Applications/Tor Browser]: Fix inconsistent generation of MOZ_MACBUNDLE_ID

2017-03-13 Thread Tor Bug Tracker & Wiki

#21723: Fix inconsistent generation of MOZ_MACBUNDLE_ID
--+--
 Reporter:  teor  |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201703R |  Actual Points:
Parent ID:  #17670| Points:
 Reviewer:|Sponsor:
--+--

Comment (by teor):

 Replying to [comment:2 mcs]:
 > Thanks for working on this. I have not tested this, but a quick glance
 at the uses of MOZ_MACBUNDLE_NAME within the browser code tells me we may
 not want to force it to lowercase because doing so will change our .app
 bundle from TorBrowser.app to torbrowser.app which is is less OSX-like and
 may also require changes to our packaging scripts, etc.

 You're right, I didn't notice that this was a different variable.
 I reverted this change.

 > MOZ_MACBUNDLE_ID should definitely be fixed though,

 I have revised this patch in my branch fix-macos-bundle-id-v2.
 It now removes all invalid characters, not just spaces.

 I tested it using:
 `echo "Tor Browser" | tr 'A-Z' 'a-z' | tr -dc 'a-z-'`
 on macOS and Ubuntu.

 The `[]` are unnecessary on modern tr, and lead to unexpected results when
 used with `tr -d`.

 `a-z` might not work when configure is run in a non-English locale, we can
 replace them with octal if this is a concern. (I expect this is not a
 practical issue, because otherwise the existing `tr [A-Z] [a-z]` would
 have failed.)

 > and I like org.torproject.torbrowser better than org.mozilla.torbrowser
 (but that will require a larger patch or scarier build config changes).

 This can be implemented by passing the following argument to Firefox's
 configure:
 `--with-distribution-id=org.torproject`

 Please see my branch `distribution-torproject` on
 https://github.com/teor2345/tor-browser-build.git for this change.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17670 [Applications/Tor Browser]: Mac OSX mistakes Tor as Firefox default browser

2017-03-13 Thread Tor Bug Tracker & Wiki

#17670: Mac OSX mistakes Tor as Firefox default browser
--+--
 Reporter:  patrickbateman|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Immediate |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Critical  | Resolution:
 Keywords:  tbb-usability |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by teor):

 Replying to [comment:7 mcs]:
 > Replying to [comment:6 teor]:
 > > I don't know how to fix the Meek Tor Browser CFBundleSignature or
 CFBundleIdentifier. Is the Meek Tor Browser generated by the build
 scripts?
 >
 > The Meek Tor Browser is just another instance of Tor Browser in which
 the firefox binary is started with a --invisible flag and a different
 browser profile. Things used to be different though; a symlink'd copy was
 used in the past. It would be good to know if there is still a way for a
 "crippled" Tor Browser to be opened via Adium or another application.

 I opened #21732 to track this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21732 [Applications/Tor Browser]: Stop the Meek Tor Browser opening links or documents on macOS

2017-03-13 Thread Tor Bug Tracker & Wiki

#21732: Stop the Meek Tor Browser opening links or documents on macOS
--+--
 Reporter:  teor  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:  #17670
   Points:|   Reviewer:
  Sponsor:|
--+--
 Sometimes, the meek Tor Browser instance opens links or documents on
 macOS, when those links or documents should be opened in the regular Tor
 Browser.

 This has happened in the past on macOS, but we don't know whether it is
 still reproducible.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21724 [Applications/Tor Browser]: Distinguish between Tor Browser and Firefox when macOS opens documents

2017-03-13 Thread Tor Bug Tracker & Wiki

Comment (by teor):

Replying to [comment:3 mcs]:
> While I do not object to this change, we should test and see if this
change is needed. I have the impression (but no hard data) that the
creator code is not used by OSX and that only the bundle ID is important.

Apple has deprecated the creator code, but still uses it in their
implementation for backwards-compatibility reasons.

They are not mentioned at all in:

https://developer.apple.com/library/content/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html

But here's how I can reproduce the Tor Browser / Firefox confusion on
macOS 10.12.3:
1. Install Firefox and Tor Browser
2. `touch empty.html`
3. In Finder, Get Info on empty.html
4. Set "Open With" to Tor Browser
5. Make sure both Firefox and Tor Browser are not running
6. Open empty.html with the Finder
(Either Firefox or Tor Browser will open depending on their order in the
LaunchServices database, which depends on installation and maybe previous
view/open order, and then if Tor Browser opens, Tor Launcher fails to
handle the open request, so the default browser will open instead, see
#20105)
7. Make sure Firefox is running and Tor Browser is not running
8. Open empty.html with the Finder
(Firefox opens, even though we said to Open in Tor Browser)
9. Make sure Tor Browser is running and Firefox is not running
10. Open empty.html with the Finder
(Tor Browser opens)
11. Make sure Tor Browser and Firefox are both running
12. Open empty.html with the Finder
(Either Firefox or Tor Browser will open depending on their order in the
LaunchServices database, which depends on installation and maybe previous
view/open/launch order)

What I expect to happen is that Tor Browser opens every time, and Firefox
or the default browser do not open.

> And I do not think Apple maintains a registry any more.

Yes, this is true. But we should try not to conflict with Mozilla's
potential future uses, if any.

--
Ticket URL:
Tor Bug Tracker & Wiki
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

1 2 >

1 - 100 of 105 matches

Mail list logo