Re: [tor-bugs] #21651 [Core Tor/Tor]: prop140/compression: Refactor directory cache spooling code

[Tor Bug Tracker & Wiki]

#21651: prop140/compression: Refactor directory cache spooling code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  1
  group-17   |
Parent ID:   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 Minor questions on GL. Could use one additional set of eyes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21643 [Core Tor/Tor]: Prop140: Extract, test, revise, and clean the diff code

[Tor Bug Tracker & Wiki]

#21643: Prop140: Extract, test, revise, and clean the diff code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  2
  group-17   |
Parent ID:  #13339   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 Code review is progressing on Gitlab - still a few minor things to fix
 there. Marking this `needs_revision` for now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21645 [Core Tor/Tor]: prop140 / compression: Unified directory cache backend

[Tor Bug Tracker & Wiki]

#21645: prop140 / compression: Unified directory cache backend
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  .5
  group-17   |
Parent ID:   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 Minor question on GL - other than that it looks good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21561 [Core Tor/Tor]: CRYPTO_THREADID_set_callback

[Tor Bug Tracker & Wiki]

#21561: CRYPTO_THREADID_set_callback
--+
 Reporter:  pds   |  Owner:
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.0.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  openssl   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by pds):

 No improvement with l-7.0a2_en-US.

 Since updating to Windows 10 Insider Preview build 15058, All appears to
 be working correctly now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21753 [Applications/Tor Browser]: Get rid of old GCC toolchain in pluggable transports macOS descriptor

[Tor Bug Tracker & Wiki]

#21753: Get rid of old GCC toolchain in pluggable transports macOS descriptor
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam21703, |  Actual Points:
  GeorgKoppen201703, tbb-gitian  |
Parent ID:  #21328   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  TorBrowserTeam21703, GeorgKoppen201703 => TorBrowserTeam21703,
 GeorgKoppen201703, tbb-gitian


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21754 [Applications/Tor Browser]: Swtich to OS X 10.7 SDK everywhere in our OS X descriptors

[Tor Bug Tracker & Wiki]

#21754: Swtich to OS X 10.7 SDK everywhere in our OS X descriptors
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  TorBrowserTeam201703,
 Severity:  Normal   |  GeorgKoppen201703, tbb-gitian
Actual Points:   |  Parent ID:  #21328
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 We should get rid of our 10.6 SDK as Tor Browser based on ESR 52 will have
 10.9 as the minimum requirement. Building with the 10.7 SDK is sufficient
 in that case.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21753 [Applications/Tor Browser]: Get rid of old GCC toolchain in pluggable transports macOS descriptor

[Tor Bug Tracker & Wiki]

#21753: Get rid of old GCC toolchain in pluggable transports macOS descriptor
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  TorBrowserTeam21703,
 Severity:  Normal   |  GeorgKoppen201703
Actual Points:   |  Parent ID:  #21328
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 The pluggable transports descriptor is the last place using the old GCC
 based toolchain for OS X cross-compilation (now that we have a patch for
 #10369). Time to get rid of it as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19783 [Applications/Tor Browser]: Typo in build helpers: `MAXOSX_DEPLOYEMENT_TARGET`

[Tor Bug Tracker & Wiki]

#19783: Typo in build helpers: `MAXOSX_DEPLOYEMENT_TARGET`
-+-
 Reporter:  dcf  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Minor| Resolution:
 Keywords:  tbb-gitian, TorBrowserTeam201703,|  Actual Points:
  ff52-esr   |
Parent ID:  #21328   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * parent:   => #21328


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #10369 [Applications/Tor Browser]: Building the Utils component in OS X TBBs is broken with the new cross-compiler

[Tor Bug Tracker & Wiki]

#10369: Building the Utils component in OS X TBBs is broken with the new cross-
compiler
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  gitian, tbb-3.0, tbb-gitian, |  Actual Points:
  GeorgKoppen201703, TorBrowserTeam201703R   |
Parent ID:  #21328   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  gitian, tbb-3.0, tbb-gitian, GeorgKoppen201506 => gitian,
 tbb-3.0, tbb-gitian, GeorgKoppen201703, TorBrowserTeam201703R
 * parent:   => #21328


Comment:

 Finally, this is ready for review. See bug_10369_v2
 (https://gitweb.torproject.org/user/gk/tor-browser-
 bundle.git/commit/?h=bug_10369_v2=e0b570f34528453ff9d7c25c7200c86d5261c710)
 in my public tor-browser-bundle repo.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20522 [Core Tor/Tor]: Enable DISABLE_DISABLING_ED25519

[Tor Bug Tracker & Wiki]

#20522: Enable DISABLE_DISABLING_ED25519
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-ed25519-proto, triage-   |  Actual Points:
  out-030-201612 |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
 |  SponsorZ
-+-
Changes (by nickm):

 * milestone:  Tor: 0.3.1.x-final => Tor: 0.3.2.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19984 [Core Tor/Tor]: Use a better set of comparison/evaluation functions for deciding which connections to kill when OOS

[Tor Bug Tracker & Wiki]

#19984: Use a better set of comparison/evaluation functions for deciding which
connections to kill when OOS
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  accepted
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  dos, sockets, triage-out-030-201612  |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 So, what's the best strategy here?  We'd like to emphasize connections
 that are getting lots of usage, but only real usage.  The existing code
 kills whatever OR connections have the fewest circuits, and leaves
 everything else alone.  But if DirPort is open, or if we're an exit, that
 can be really bad.

 My first thought was to treat directory server connections and exit as if
 they had one circuit, and then to rank them by number of circuits along
 with the OR connections.  But maybe that's vulnerable too?  An attacker
 could just start a bunch of clients, open two circuits from each, and get
 an exit to kill off all its exit connections.  Probably not so good.

 Should we look at last-written time, or queue age, or something else?
 There may be cleverness needed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20453 [Metrics/Torflow]: Update bwauth setup.sh to use tor 0.2.8.9

[Tor Bug Tracker & Wiki]

#20453: Update bwauth setup.sh to use tor 0.2.8.9
-+--
 Reporter:  teor |  Owner:  aagbsn
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Torflow  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  easy |  Actual Points:
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+--

Comment (by tom):

 I had been using 0.2.8.9 myself for... some time. I've switched to the
 release-0.2.8 branch to test this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20796 [Metrics/Torflow]: TorFlow's ScanHandler can divide by zero when there are no unmeasured nodes

[Tor Bug Tracker & Wiki]

#20796: TorFlow's ScanHandler can divide by zero when there are no unmeasured 
nodes
-+--
 Reporter:  teor |  Owner:  aagbsn
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Torflow  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by tom):

 This is in testing. (I'm surprised we don't have a pytorctl component.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21710 [Applications/Tor Browser]: Upgrade Go to 1.8

[Tor Bug Tracker & Wiki]

#21710: Upgrade Go to 1.8
--+--
 Reporter:  dcf   |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-gitian|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by dcf):

 Replying to [ticket:21710 dcf]:
 > Note:
 > > Go 1.8 now only supports OS X 10.8 or later. This is likely the last
 Go release to support 10.8. Compiling Go or running binaries on older OS X
 versions is untested.

 Ticket about dropping support for OS X 10.6, 10.7, 10.8 in Tor Browser:
 #18530.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20467 [Metrics/Torflow]: bwauth aggregator divides by zero if a node class is missing

[Tor Bug Tracker & Wiki]

#20467: bwauth aggregator divides by zero if a node class is missing
-+
 Reporter:  teor |  Owner:  aagbsn
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Metrics/Torflow  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by tom):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Merged

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21752 [Metrics/Atlas]: put "Current Status" under an Android Browser on top

[Tor Bug Tracker & Wiki]

#21752: put "Current Status" under an Android Browser on top
---+
 Reporter:  toralf |  Owner:  irl
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.3.0.x-final
Component:  Metrics/Atlas  |Version:
 Severity:  Minor  |   Keywords:
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor: |
---+
 Currently it is after "Configuration" and "Properties" but IMO it makes
 more sense to have this info as a heading.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20270 [Core Tor/Tor]: "Descriptor is missing an ntor curve25519 onion key" message too noisy?

[Tor Bug Tracker & Wiki]

#20270: "Descriptor is missing an ntor curve25519 onion key" message too noisy?
-+-
 Reporter:  arma |  Owner:  nickm
 Type:  defect   | Status:  accepted
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  easy, triage-out-030-201612  |  Actual Points:
Parent ID:   | Points:  .2
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 So, right now authdir_wants_to_reject_router is deciding on what severity
 to use like this:
 {{{
   int severity = (complain && ri->contact_info) ? LOG_NOTICE : LOG_INFO;
 }}}

 In theory, these are all ones that we could contact to tell them to
 upgrade.

 Should I wontfix this, or think about other behavior improvements?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21673 [Core Tor/Tor]: prop140: Handle signatures correctly

[Tor Bug Tracker & Wiki]

#21673: prop140: Handle signatures correctly
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  prop140   |  Actual Points:
Parent ID:  #13339| Points:
 Reviewer:|Sponsor:  Sponsor4
--+

Comment (by nickm):

 According to the spec:
 {{{
  The signatures at the end of a consensus document are sorted in
  ascending order by identity digest.
 }}}

 We should note that in a more clever place, and we should make sure the
 code really does it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21644 [Core Tor/Tor]: Prop140: Fuzz the diff and patch code

[Tor Bug Tracker & Wiki]

#21644: Prop140: Fuzz the diff and patch code
+--
 Reporter:  nickm   |  Owner:  nickm
 Type:  task| Status:  closed
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.1.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  implemented
 Keywords:  TorCoreTeam201703, prop140  |  Actual Points:
Parent ID:  #13339  | Points:  1
 Reviewer:  |Sponsor:  Sponsor4
+--
Changes (by nickm):

 * status:  accepted => closed
 * resolution:   => implemented


Comment:

 This is included in my branch for #21643

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #21602, #21554, #19068

[Tor Bug Tracker & Wiki]

Batch modification to #21602, #21554, #19068 by dgoulet:
component to Core Tor/Tor

--
Tickets URL: 

Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21540 [Core Tor/Tor]: Warning "Failure from drain_fd"

[Tor Bug Tracker & Wiki]

#21540: Warning "Failure from drain_fd"
-+-
 Reporter:  PjotrV   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.9
 Severity:  Minor| Resolution:
 Keywords:  supressed 029-backport 030-backport  |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review
 * milestone:  Tor: 0.3.1.x-final => Tor: 0.3.0.x-final


Comment:

 fixup added, squashed as `bug21540_029_v2`.  Merged to master; marking for
 possible backport to 0.3.0 and then maybe to 0.2.9

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21540 [Core Tor/Tor]: Warning "Failure from drain_fd"

[Tor Bug Tracker & Wiki]

#21540: Warning "Failure from drain_fd"
-+-
 Reporter:  PjotrV   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.9
 Severity:  Minor| Resolution:
 Keywords:  supressed 029-backport 030-backport  |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by dgoulet):

 * reviewer:   => dgoulet


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21540 [Core Tor/Tor]: Warning "Failure from drain_fd"

[Tor Bug Tracker & Wiki]

#21540: Warning "Failure from drain_fd"
-+-
 Reporter:  PjotrV   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.9
 Severity:  Minor| Resolution:
 Keywords:  supressed 029-backport 030-backport  |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+-
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 This pattern is used except in `recv_ni()` which removes the unneeded
 `else`:

 {{{
 +if (errno == EINTR)
 +  goto again;
 +else
 +  return -errno;
 +  }
 }}}

 I would suggest going for the same pattern, one or the other.

 The rest lgtm.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21540 [Core Tor/Tor]: Warning "Failure from drain_fd"

[Tor Bug Tracker & Wiki]

#21540: Warning "Failure from drain_fd"
-+-
 Reporter:  PjotrV   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.9
 Severity:  Minor| Resolution:
 Keywords:  supressed 029-backport 030-backport  |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  supressed => supressed 029-backport 030-backport
 * status:  accepted => needs_review


Comment:

 Fix in branch "bug21540_029".  Possible backport.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21751 [Metrics/metrics-lib]: Use multiple threads to parse descriptors

[Tor Bug Tracker & Wiki]

#21751: Use multiple threads to parse descriptors
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/metrics-lib  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+--
 The following idea came up when I looked a bit into #17831 to speed up
 metrics-lib.

 When we read and parse descriptors from disk, we're using a single thread
 to read and parse descriptors.  It's a daemon thread and not the
 application's main thread, so if the application's thread is busy
 processing parsed descriptors we're at least using two threads.  But we
 could parallelize even more by using separate threads for reading and
 parsing and even using multiple threads for reading and/or for parsing.
 I'll leave the I/O part to #17831 and focus on the multi-threaded parsing
 part here.

 I wrote a little patch that measures time spent on reading tarball
 contents in `DescriptorReaderImpl#readTarballs()` and then extended that
 by moving descriptor parsing code to a separate class that implements
 `Runnable` and that gets executed by an `ExecutorService`.  I initialized
 that executor with `Executors.newFixedThreadPool(n)` for `n = [2, 4, 8,
 16, 32, 64]`.  I also tried `n = 1`, but ran out of memory due to a major
 issue in my simple patch: it reads ''all'' tarball contents to memory when
 creating `Task` instances even if they cannot be executed anytime soon.
 What we should do is block the reader thread when it realizes that the
 executor is already full.  I'm attaching my patch, but only to avoid
 starting from zero the next time.  It needs more work.

 || '''separate parser threads''' || '''read `.tar` file (s)''' || '''parse
 `.tar` file (s)''' || '''read `.tar.xz` file (s)''' || '''parse `.tar.xz`
 file (s)''' ||
 || none (current code) || 35 || 159 || 9 || 162 ||
 || 2 || 36 || 42 || 8 || 126 ||
 || 4 || 41 || 13 || 7 || 96 ||
 || 8 || 42 || 11 || 6 || 35 ||
 || 16 || 41 || 11 || 10 || 28 ||
 || 32 || 45 || 13 || 7 || 34 ||
 || 64 || 41 || 13 || 6 || 38 ||

 These results show that 4 threads speed up the parse time for `.tar` files
 by a '''factor 12''' after which there's no visible improvement, and 8
 threads speed up the parse time for `.tar.xz` files by a '''factor 4.6'''.
 Just from these numbers I'd suggest using 8 threads by default and making
 this number configurable for the application.  But: needs more work.

 My recommendation would be to look more into making parsing multi-threaded
 and save #17831 for later.  It seems like parsing is the lower-hanging
 fruit.

 Note that reading the same tarball in extracted form using the current
 code took 271 seconds.  In that case the lower-hanging fruit might be I/O
 improvements, not multi-threaded parsing.  But my hope is that not many
 applications extract tarballs containing over 800,000 files and read them
 using `DescriptorReader`, especially not if they could as well read the
 tarball directly.

 Suggestions welcome!  Otherwise I might pick this up again and move it
 forward whenever there's time.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21723 [Applications/Tor Browser]: Fix inconsistent generation of MOZ_MACBUNDLE_ID

[Tor Bug Tracker & Wiki]

#21723: Fix inconsistent generation of MOZ_MACBUNDLE_ID
--+--
 Reporter:  teor  |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201703R |  Actual Points:
Parent ID:  #17670| Points:
 Reviewer:|Sponsor:
--+--

Comment (by mcs):

 Replying to [comment:6 teor]:
 > The build change `--with-distribution-id=org.torproject` changes the
 distribution ID on all platforms. I'm not sure how the distribution ID is
 used on Linux or Windows, but we should be consistent.

 I agree that we should be consistent (unless we find a good reason not to
 be). Here are the references to MOZ_DISTRIBUTION_ID (which is what --with-
 distribution-id sets):
 https://dxr.mozilla.org/mozilla-esr52/search?q=MOZ_DISTRIBUTION_ID

 Files such as browser/branding/aurora/locales/moz.build use
 MOZ_DISTRIBUTION_ID to define MOZ_DISTRIBUTION_ID_UNQUOTED, but I do not
 see where that is used.

 In old-configure.in, MOZ_DISTRIBUTION_ID is used to define
 MOZ_MACBUNDLE_ID, as teor pointed out.

 The code in toolkit/xre/nsAppRunner.cpp makes the MOZ_DISTRIBUTION_ID
 value available via nsIXULRuntime.distributionID. Chasing that via:
 https://dxr.mozilla.org/mozilla-esr52/search?q=distributionID
 shows that it is used in telemetry and in the search engine code. We don't
 care about telemetry, but the search engine code will insert the
 distribution ID into search parameters via `{moz:distributionID}`. But the
 only place I see that technique used is in browser/locales/searchplugins
 /yahoo-jp-auctions.xml, which I assume we will not ship with Tor Browser.

 So... I think it is okay to change the distribution ID on all platforms.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21749 [Applications/Tor Browser]: bitcoin.de

[Tor Bug Tracker & Wiki]

#21749: bitcoin.de
--+--
 Reporter:  globos|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-usability-website |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * keywords:   => tbb-usability-website


Comment:

 We are getting things like
 {{{
 GET XHR https://www.bitcoin.de/en/home/reload-trades [HTTP/1.1 403
 Forbidden 298ms]
 }}}
 Not sure why it is forbidden with Tor, though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18530 [Applications/Tor Browser]: Consider dropping support for Mac OS 10.6, 10.7, and 10.8

[Tor Bug Tracker & Wiki]

#18530: Consider dropping support for Mac OS 10.6, 10.7, and 10.8
-+-
 Reporter:  mcs  |  Owner:  boklm
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, tbb-7.0-must,  |  Actual Points:
  TorBrowserTeam201703   |
Parent ID:  #21147   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by gk):

 If we want to be fancy we can provide a learn more link on the about
 dialog and the text that no further update is possible. Not sure exactly
 what we need to do to activate that, I just stumbled over
 https://bugzilla.mozilla.org/show_bug.cgi?id=1291488.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21748 [Obfuscation/Snowflake]: Snowflake breaks nightly builds as of March 15

[Tor Bug Tracker & Wiki]

#21748: Snowflake breaks nightly builds as of March 15
---+--
 Reporter:  gk |  Owner:  arlolra
 Type:  defect | Status:  assigned
 Priority:  High   |  Milestone:
Component:  Obfuscation/Snowflake  |Version:
 Severity:  Major  | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by arlolra):

 Yup, this is is because we merged a patch to upgrade webrtc to branch-
 heads/58 (from 52) in,
 https://github.com/keroserene/go-webrtc/pull/61

 I'm working on a tor-browser-bundle patch, thanks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21645 [Core Tor/Tor]: prop140 / compression: Unified directory cache backend

[Tor Bug Tracker & Wiki]

#21645: prop140 / compression: Unified directory cache backend
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  .5
  group-17   |
Parent ID:   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-

Comment (by nickm):

 https://gitlab.com/nickm_tor/tor/merge_requests/13

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21651 [Core Tor/Tor]: prop140/compression: Refactor directory cache spooling code

[Tor Bug Tracker & Wiki]

#21651: prop140/compression: Refactor directory cache spooling code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  1
  group-17   |
Parent ID:   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-

Comment (by nickm):

 https://gitlab.com/nickm_tor/tor/merge_requests/14

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21643 [Core Tor/Tor]: Prop140: Extract, test, revise, and clean the diff code

[Tor Bug Tracker & Wiki]

#21643: Prop140: Extract, test, revise, and clean the diff code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  2
  group-17   |
Parent ID:  #13339   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-

Comment (by nickm):

 https://gitlab.com/nickm_tor/tor/merge_requests/12

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19048 [Applications/Tor Browser]: Review Firefox Developer Docs and Undocumented bugs since FF45esr

[Tor Bug Tracker & Wiki]

#19048: Review Firefox Developer Docs and Undocumented bugs since FF45esr
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, tbb-7.0-must,  |  Actual Points:
  TorBrowserTeam201703, GeorgKoppen201703|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by mcs):

 Here are the items that Kathy and I found for Firefox 52:

 a) As I mentioned in comment:4, captive portal detection is enabled in
 FF52. It won't be useful over Tor, so we should disable it via `network
 .captive-portal-service.enabled = false`. I thought we already had a
 ticket for this, but I cannot find it.
  https://bugzilla.mozilla.org/show_bug.cgi?id=1313706

 b) MediaError has gained a message property that may include system
 diagnostic
 information. We should make sure it does not provide fingerprintable
 information
 about the user's computer.
  https://developer.mozilla.org/en-US/docs/Web/API/MediaError
  https://bugzilla.mozilla.org/show_bug.cgi?id=1322606

 c) Kathy and I don't fully understand what was done in the following bug
 and
 how it affects our use of the --disable-eme configure flag:
   https://bugzilla.mozilla.org/show_bug.cgi?id=1300654
 Maybe the difference is that now the framework that supports EME is always
 built and --disable-eme only skips building the bundled providers?

 d) The CustomElementRegistry.get() method of the Web Components API has
 been implemented. It looks like all of the custom element features are
 disabled via `dom.webcomponents.customelements.enabled = false`, but
 eventually we should make sure that these APIs do not introduce any
 linkability problems
  https://bugzilla.mozilla.org/show_bug.cgi?id=1275838

 e) A note related to e10s: use of accessibility tools is no longer a
 reason to disable e10s (it was for Firefox 48-51, as I noted in
 comment:11):
  https://bugzilla.mozilla.org/show_bug.cgi?id=1312100
  https://bugzilla.mozilla.org/show_bug.cgi?id=1310788
  https://bugzilla.mozilla.org/show_bug.cgi?id=1322606

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21642 [Core Tor/Tor]: Prop275: Eliminate "published" times from microdescriptor consensus

[Tor Bug Tracker & Wiki]

#21642: Prop275: Eliminate "published" times from microdescriptor consensus
+--
 Reporter:  nickm   |  Owner:  nickm
 Type:  enhancement | Status:
|  needs_review
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.1.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  TorCoreTeam201703, review-group-17  |  Actual Points:  .5
Parent ID:  | Points:  2
 Reviewer:  |Sponsor:  Sponsor4
+--
Changes (by dgoulet):

 * status:  needs_information => needs_review


Comment:

 Aaah! ok that makes more sense. Thanks. Back in need review

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21642 [Core Tor/Tor]: Prop275: Eliminate "published" times from microdescriptor consensus

[Tor Bug Tracker & Wiki]

#21642: Prop275: Eliminate "published" times from microdescriptor consensus
+--
 Reporter:  nickm   |  Owner:  nickm
 Type:  enhancement | Status:
|  needs_information
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.1.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  TorCoreTeam201703, review-group-17  |  Actual Points:  .5
Parent ID:  | Points:  2
 Reviewer:  |Sponsor:  Sponsor4
+--

Comment (by nickm):

 The plan would be to change all the 'published' dates to something like
 2030-01-01.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21642 [Core Tor/Tor]: Prop275: Eliminate "published" times from microdescriptor consensus

[Tor Bug Tracker & Wiki]

#21642: Prop275: Eliminate "published" times from microdescriptor consensus
+--
 Reporter:  nickm   |  Owner:  nickm
 Type:  enhancement | Status:
|  needs_information
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.1.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  TorCoreTeam201703, review-group-17  |  Actual Points:  .5
Parent ID:  | Points:  2
 Reviewer:  |Sponsor:  Sponsor4
+--
Changes (by dgoulet):

 * status:  needs_review => needs_information


Comment:

 In `prop275_minimal_029`, the changes file is confusing to me:

 {{{
 +  [...] This change will
 +  eventually allow us to stop listing meaningful "published" dates
 }}}

 Kind of weird that we want to stop doing something "meaningful" :)...
 maybe it was suppose to be "meaningless" or "useless" or "wrong" or ... ?
 If not, what does that mean exactly?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #21643, #21645, #21651

[Tor Bug Tracker & Wiki]

Batch modification to #21643, #21645, #21651 by dgoulet:
reviewer to ahf

--
Tickets URL: 

Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20059 [Core Tor/Tor]: Bug: Duplicate call to circuit_mark_for_close

[Tor Bug Tracker & Wiki]

#20059: Bug: Duplicate call to circuit_mark_for_close
+--
 Reporter:  cypherpunks |  Owner:  nickm
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor:
|  0.2.9.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  030-backport, 029-backport  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  dgoulet |Sponsor:
+--
Changes (by nickm):

 * keywords:  030-backport, 029-backport, review-group-17 => 030-backport,
 029-backport
 * status:  merge_ready => needs_review
 * milestone:  Tor: 0.3.1.x-final => Tor: 0.2.9.x-final


Comment:

 Whoops.  It didn't actually compile.  Fixed in a fixup commit, squashed in
 `bug20059_024_v2`.

 Taken in 030 and forward, marking for possible 029 backport

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21703 [Core Tor/Tor]: Warn on getinfo network-status

[Tor Bug Tracker & Wiki]

#21703: Warn on getinfo network-status
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  review-group-17  |  Actual Points:  0
Parent ID:   | Points:  0
 Reviewer:  dgoulet  |Sponsor:
-+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21703 [Core Tor/Tor]: Warn on getinfo network-status

[Tor Bug Tracker & Wiki]

#21703: Warn on getinfo network-status
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-17  |  Actual Points:  0
Parent ID:   | Points:  0
 Reviewer:  dgoulet  |Sponsor:
-+
Changes (by dgoulet):

 * status:  needs_review => merge_ready
 * reviewer:   => dgoulet


Comment:

 lgtm;

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21496 [Core Tor/Tor]: Check string passed to extrainfo_parse_entry_from_string

[Tor Bug Tracker & Wiki]

#21496: Check string passed to extrainfo_parse_entry_from_string
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  clang, scan-build, memory-safety,|  Actual Points:  0
  review-group-17|
Parent ID:   | Points:  .1
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21496 [Core Tor/Tor]: Check string passed to extrainfo_parse_entry_from_string

[Tor Bug Tracker & Wiki]

#21496: Check string passed to extrainfo_parse_entry_from_string
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  clang, scan-build, memory-safety,|  Actual Points:  0
  review-group-17|
Parent ID:   | Points:  .1
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by dgoulet):

 * status:  needs_review => merge_ready
 * reviewer:   => dgoulet


Comment:

 lgtm.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21496 [Core Tor/Tor]: Check string passed to extrainfo_parse_entry_from_string

[Tor Bug Tracker & Wiki]

#21496: Check string passed to extrainfo_parse_entry_from_string
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  clang, scan-build, memory-safety,|  Actual Points:  0
  review-group-17|
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 Whoops.  The branch is `feature21496`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20059 [Core Tor/Tor]: Bug: Duplicate call to circuit_mark_for_close

[Tor Bug Tracker & Wiki]

#20059: Bug: Duplicate call to circuit_mark_for_close
-+-
 Reporter:  cypherpunks  |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  030-backport, 029-backport, review-  |  Actual Points:
  group-17   |
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by dgoulet):

 * status:  needs_review => merge_ready
 * reviewer:   => dgoulet


Comment:

 lgtm and ack for the backport.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  assigned
 Priority:  Very High|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  6
 Reviewer:   |Sponsor:  SponsorR-must
-+
Changes (by dgoulet):

 * status:  needs_review => assigned
 * keywords:  tor-hs, prop224, review-group-17 => tor-hs, prop224


Comment:

 I've moved asn's ntor branch review in #21750 so removing this ticket from
 the review group and back to the assigned state.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21750 [Core Tor/Tor]: prop224: ntor handshake implementation

[Tor Bug Tracker & Wiki]

#21750: prop224: ntor handshake implementation
--+
 Reporter:  dgoulet   |  Owner:  asn
 Type:  task  | Status:
  |  needs_review
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs, prop224, review-group-17  |  Actual Points:
Parent ID:  #20657| Points:  6
 Reviewer:  nickm |Sponsor:  SponsorR-
  |  must
--+
Changes (by dgoulet):

 * keywords:  tor-hs, prop224 => tor-hs, prop224, review-group-17
 * status:  new => needs_review
 * reviewer:   => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21750 [Core Tor/Tor]: prop224: ntor handshake implementation

[Tor Bug Tracker & Wiki]

#21750: prop224: ntor handshake implementation
---+
 Reporter:  dgoulet|  Owner:  asn
 Type:  task   | Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal |   Keywords:  tor-hs, prop224
Actual Points: |  Parent ID:  #20657
   Points:  6  |   Reviewer:
  Sponsor:  SponsorR-must  |
---+
 Ticket created after
 https://trac.torproject.org/projects/tor/ticket/20657#comment:12

 Initial reviews are here: https://gitlab.com/asn/tor/merge_requests/13

 OK after a review from David and some comments from Nick I present the
 `prop224-ntor-v2` branch which comes with all the code review fixes, and
 with a full on integration test suite similar to the
 `./src/test/test_ntor.sh` tests for simple ntor.

 It also implements the key expansion functionality as requested by David.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21133 [Core Tor/Tor]: Add ed25519 relay key expire date

[Tor Bug Tracker & Wiki]

#21133: Add ed25519 relay key expire date
--+
 Reporter:  tom   |  Owner:  tom
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  torspec, dirauth  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by dgoulet):

 * keywords:   => torspec, dirauth


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19001 [Obfuscation/Snowflake]: Tor Browser with Snowflake

[Tor Bug Tracker & Wiki]

#19001: Tor Browser with Snowflake
---+-
 Reporter:  dcf|  Owner:
 Type:  project| Status:  new
 Priority:  Medium |  Milestone:
Component:  Obfuscation/Snowflake  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by adrelanos):

 * cc: adrelanos (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21293 [Core Tor/Tor]: circuit_receive_relay_cell(): Bug: relay crypt failed. Dropping connection.

[Tor Bug Tracker & Wiki]

#21293: circuit_receive_relay_cell(): Bug: relay crypt failed. Dropping 
connection.
--+
 Reporter:  s7r   |  Owner:  dgoulet
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.0.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  tor-client|  Actual Points:
Parent ID:| Points:  .5
 Reviewer:|Sponsor:
--+
Changes (by dgoulet):

 * owner:   => dgoulet
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16706 [Core Tor/Tor]: Too many connection_edge_process_relay_cell warnings

[Tor Bug Tracker & Wiki]

#16706: Too many connection_edge_process_relay_cell warnings
-+-
 Reporter:  s7r  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.6.10
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, nickm-deferred-20161017, |  Actual Points:
  triage-out-030-201612  |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
 |  SponsorR-can
-+-
Changes (by dgoulet):

 * keywords:  tor-hs, 026-backport, nickm-deferred-20161017, triage-
 out-030-201612 => tor-hs, nickm-deferred-20161017, triage-
 out-030-201612


Comment:

 No chance we backport that to 026.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16706 [Core Tor/Tor]: Too many connection_edge_process_relay_cell warnings

[Tor Bug Tracker & Wiki]

#16706: Too many connection_edge_process_relay_cell warnings
-+-
 Reporter:  s7r  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.6.10
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, 026-backport, nickm- |  Actual Points:
  deferred-20161017, triage-out-030-201612   |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
 |  SponsorR-can
-+-
Changes (by dgoulet):

 * owner:   => dgoulet
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #20657, #20059, #21496, #21642, ...

[Tor Bug Tracker & Wiki]

Batch modification to #20657, #20059, #21496, #21642, #21643, #21645, #21651, 
#21703, #17903 by nickm:
keywords to review-group-17

--
Tickets URL: 

Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17903 [Core Tor/Tor]: router_pick_trusteddirserver_impl should distinguish between fallbacks and authorities

[Tor Bug Tracker & Wiki]

#17903: router_pick_trusteddirserver_impl should distinguish between fallbacks 
and
authorities
---+---
 Reporter:  teor   |  Owner:  attila
 Type:  enhancement| Status:  needs_review
 Priority:  Very Low   |  Milestone:  Tor:
   |  0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Minor  | Resolution:
 Keywords:  tor-03-unspecified-201612  |  Actual Points:
Parent ID: | Points:
 Reviewer:  nickm  |Sponsor:
---+---
Changes (by nickm):

 * reviewer:   => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #20524, #21600, #21621

[Tor Bug Tracker & Wiki]

Batch modification to #20524, #21600, #21621 by dgoulet:
sponsor to SponsorR-can

--
Tickets URL: 

Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #16861, #17592, #17604, #13802, ...

[Tor Bug Tracker & Wiki]

Batch modification to #16861, #17592, #17604, #13802, #21039, #21415, #13790 by 
nickm:
keywords to review-group-16

--
Tickets URL: 

Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21673 [Core Tor/Tor]: prop140: Handle signatures correctly

[Tor Bug Tracker & Wiki]

#21673: prop140: Handle signatures correctly
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  prop140   |  Actual Points:
Parent ID:  #13339| Points:
 Reviewer:|Sponsor:  Sponsor4
--+
Changes (by dgoulet):

 * sponsor:   => Sponsor4


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19048 [Applications/Tor Browser]: Review Firefox Developer Docs and Undocumented bugs since FF45esr

[Tor Bug Tracker & Wiki]

#19048: Review Firefox Developer Docs and Undocumented bugs since FF45esr
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, tbb-7.0-must,  |  Actual Points:
  TorBrowserTeam201703, GeorgKoppen201703|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by mcs):

 Replying to [comment:24 gk]:
 > > b) When reviewing bugs, Kathy and I noticed that there seem to be a
 lot of crasher bugs associated with DOM Animation, e.g., UAF bugs. I think
 this is disabled by default via:
 > >  dom.animations-api.core.enabled = false
 > > or maybe we also need to add the following if we want to turn it off
 completely?
 > >  dom.animations-api.element-animate.enabled
 > > This might be something for the security slider eventually.
 >
 > Have you checked whether those crasher bugs made it ever into releases?
 The current metric for the slider was looking at sec-high and sec-critical
 bugs that got fixed on the release channel. Just looking at mozilla50
 might spoil our metrics.

 You make a good point. It is difficult to tell if a bug made it into an
 actual release (at least I am not sure how to tell). If it did, it should
 be included in the Mozilla Security Advisory list, and I did find a couple
 of items there:
  https://www.mozilla.org/en-
 US/security/advisories/mfsa2016-85/#CVE-2016-5277
  https://www.mozilla.org/en-
 US/security/advisories/mfsa2017-01/#CVE-2017-5379
 But there is always a collection of memory safety bugs for which little
 detail is available, and I cannot see all of the bugs. I did find one bug
 that way:
  https://bugzilla.mozilla.org/show_bug.cgi?id=1289701

 > > c) As part of our release procedures, do we double-check the HPKP
 expiration? We do not want to have a repeat of the problem where the pins
 expired. Mozilla seems to have bugs for each release, e.g.,
 > >  https://bugzilla.mozilla.org/show_bug.cgi?id=1307530
 >
 > Hey, that got mentioned in the mozilla49 notes already (see my reply in
 the previous comment). :)

 Oops. I think I am repeating myself. I think I am repeating myself.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21715 [Core Tor/Tor]: Possible error in the Tor manual (section "NumEntryGuards NUM")

[Tor Bug Tracker & Wiki]

#21715: Possible error in the Tor manual (section "NumEntryGuards NUM")
---+
 Reporter:  moe-szyslak-0  |  Owner:
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  easy doc   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by dgoulet):

 * status:  assigned => new


Comment:

 No owner so putting that back in `new`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21749 [Applications/Tor Browser]: bitcoin.de

[Tor Bug Tracker & Wiki]

#21749: bitcoin.de
--+--
 Reporter:  globos|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by nickm):

 * owner:   => tbb-team
 * component:  - Select a component => Applications/Tor Browser


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21744 [Core Tor/Tor]: Build out glossary in torspec

[Tor Bug Tracker & Wiki]

#21744: Build out glossary in torspec
--+--
 Reporter:  chelseakomlo  |  Owner:  chelseakomlo
 Type:  project   | Status:  new
 Priority:  Low   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:  torspec   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by nickm):

 * component:  Core Tor => Core Tor/Tor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20021 [Core Tor/Tor]: Require ntor-onion-key in microdescriptors, descriptors

[Tor Bug Tracker & Wiki]

#20021: Require ntor-onion-key in microdescriptors, descriptors
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  needs_revision
 Priority:  Medium |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorCoreTeam201703  |  Actual Points:
Parent ID: | Points:  1.1
 Reviewer: |Sponsor:  Sponsor4
---+
Changes (by nickm):

 * points:  .1 => 1.1
 * milestone:  Tor: 0.3.1.x-final => Tor: 0.3.2.x-final


Comment:

 I've fixed some of the test failures in ticket20021.  But a real fix for
 the tests will be tricky:
   1) I'd need to update the unit tests that use failing_routerdescs.inc so
 that they check the log messages and enforce the correct failure reasons.
   2) I'd need to update the examples in failing_routerdescs.inc to include
 ntor keys.

 Both of those are bigger than I'd expected, though the first would be
 quite worthwhile.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21693 [Core Tor/Tor]: prop224: HS descriptors do wasteful double-base64 encoding (was: prop224 HS descriptors do wasteful double-base64 encoding)

[Tor Bug Tracker & Wiki]

#21693: prop224: HS descriptors do wasteful double-base64 encoding
-+
 Reporter:  asn  |  Owner:  asn
 Type:  task | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:   | Points:  4
 Reviewer:   |Sponsor:  SponsorR-can
-+
Changes (by dgoulet):

 * keywords:  tor-hs prop224 => tor-hs, prop224
 * owner:   => asn
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16456 [Applications/Tor Browser]: screen size fingerprint with findbar panel/bookmarks toolbar

[Tor Bug Tracker & Wiki]

#16456: screen size fingerprint with findbar panel/bookmarks toolbar
---+--
 Reporter:  tmpAnon|  Owner:  tbb-team
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-fingerprinting-resolution  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by mcs):

 Related to this ticket: as of Firefox 52 ESR, the toolbar will be opened
 automatically when a bookmark is added to the "Bookmarks Toolbar" folder.
 See: https://bugzilla.mozilla.org/show_bug.cgi?id=1219788

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21596 [Core Tor/Tor]: When hidden services stop creating new intro points, they also stop checking existing ones

[Tor Bug Tracker & Wiki]

#21596: When hidden services stop creating new intro points, they also stop
checking existing ones
--+
 Reporter:  teor  |  Owner:
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.7.2-alpha
 Severity:  Normal| Resolution:
 Keywords:  tor-hs, 030-backport  |  Actual Points:  0.2
Parent ID:| Points:  0.2
 Reviewer:|Sponsor:
--+
Changes (by dgoulet):

 * parent:  #21446 =>


Comment:

 This is merged upstream so removing parent so we can close it at some
 point.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21749 [- Select a component]: bitcoin.de

[Tor Bug Tracker & Wiki]

#21749: bitcoin.de
--+-
 Reporter:  globos|  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  - Select a component  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+-
 The Tor browser won't display the last bid/ask items on the landing
 homepage https://www.bitcoin.de/
 Temporarily allowing all scripts didn't help.
 Plain Firefox 52.0 displays the page just fine.

 Note: Bitcoin.de might not be using CloudFlare anymore, because I no
 longer see captchas when I get there through Tor (which I used to).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13802 [Core Tor/Tor]: Add general trace-event logging instrumentation to Tor

[Tor Bug Tracker & Wiki]

#13802: Add general trace-event logging instrumentation to Tor
-+-
 Reporter:  dgoulet  |  Owner:  pastly
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-03-unspecified-201612, review-   |  Actual Points:
  group-15, review-group-16  |
Parent ID:  #13792   | Points:  3
 Reviewer:  dgoulet  |Sponsor:
 |  SponsorR-can
-+-
Changes (by dgoulet):

 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21744 [Core Tor]: Build out glossary in torspec

[Tor Bug Tracker & Wiki]

#21744: Build out glossary in torspec
--+--
 Reporter:  chelseakomlo  |  Owner:  chelseakomlo
 Type:  project   | Status:  new
 Priority:  Low   |  Milestone:  Tor: unspecified
Component:  Core Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:  torspec   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by dgoulet):

 * version:  Tor: unspecified =>
 * milestone:   => Tor: unspecified


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19669 [Core Tor/Tor]: `log_prefix_` maybe getting weird output from strftime

[Tor Bug Tracker & Wiki]

#19669: `log_prefix_` maybe getting weird output from strftime
-+-
 Reporter:  dcf  |  Owner:
 Type:  defect   | Status:  new
 Priority:  Low  |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  easy, triage-out-030-201612  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_information => new
 * milestone:  Tor: 0.3.1.x-final => Tor: unspecified


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20059 [Core Tor/Tor]: Bug: Duplicate call to circuit_mark_for_close

[Tor Bug Tracker & Wiki]

#20059: Bug: Duplicate call to circuit_mark_for_close
---+---
 Reporter:  cypherpunks|  Owner:  nickm
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  030-backport 029-backport  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by nickm):

 * keywords:   => 030-backport 029-backport
 * status:  accepted => needs_review


Comment:

 Likely fix in  `bug20059_024`.

 I say we only take this in 029 and forward, since it's just a warning.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20059 [Core Tor/Tor]: Bug: Duplicate call to circuit_mark_for_close

[Tor Bug Tracker & Wiki]

#20059: Bug: Duplicate call to circuit_mark_for_close
--+
 Reporter:  cypherpunks   |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * owner:   => nickm
 * status:  needs_information => accepted


Comment:

 Okay; the first close is here in command.c:
 {{{
 /* the destroy came from behind */
 circuit_set_p_circid_chan(TO_OR_CIRCUIT(circ), 0, NULL);
 circuit_mark_for_close(circ, reason|END_CIRC_REASON_FLAG_REMOTE);
 }}}
 And the second is here in onion.c:
 {{{
 log_info(LD_CIRC,
  "Circuit create request is too old; canceling due to
 overload.");
 circuit_mark_for_close(TO_CIRCUIT(circ),
 END_CIRC_REASON_RESOURCELIMIT);
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19760 [Core Tor/Tor]: Update longclaw's hard-coded IPv6 address

[Tor Bug Tracker & Wiki]

#19760: Update longclaw's hard-coded IPv6 address
-+-
 Reporter:  teor |  Owner:  micah
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  dir-auth, ipv6, 029-proposed,|  Actual Points:
  tor-03-unspecified-201612  |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
 |  SponsorZ
-+-

Comment (by nickm):

 micah, please reassign this to somebody else once there's an IPv6 address
 we should be using. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19760 [Core Tor/Tor]: Update longclaw's hard-coded IPv6 address

[Tor Bug Tracker & Wiki]

#19760: Update longclaw's hard-coded IPv6 address
-+-
 Reporter:  teor |  Owner:  micah
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  dir-auth, ipv6, 029-proposed,|  Actual Points:
  tor-03-unspecified-201612  |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
 |  SponsorZ
-+-
Changes (by nickm):

 * owner:   => micah
 * status:  needs_information => assigned
 * milestone:  Tor: 0.3.1.x-final => Tor: 0.3.2.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20267 [Core Tor/Tor]: Use -DOPENSSL_SYS_WIN32 on Windows

[Tor Bug Tracker & Wiki]

#20267: Use -DOPENSSL_SYS_WIN32 on Windows
-+-
 Reporter:  teor |  Owner:
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regression, windows, nickm-  |  worksforme
  deferred-20161017, triage-out-030-201612   |  Actual Points:
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_information => closed
 * resolution:   => worksforme


Comment:

 Please reopen if this is a problem with current tor and current openssl?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19824 [Core Tor/Tor]: /var/run/tor/control socket not created because of /var/run/tor permission issue

[Tor Bug Tracker & Wiki]

#19824: /var/run/tor/control socket not created because of /var/run/tor 
permission
issue
--+
 Reporter:  adrelanos |  Owner:
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.8.6
 Severity:  Normal| Resolution:  user disappeared
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  needs_information => closed
 * resolution:   => user disappeared


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17286 [Core Tor/Tor]: Implement a circuit-extension algorithm that can resist quantum computers

[Tor Bug Tracker & Wiki]

#17286: Implement a circuit-extension algorithm that can resist quantum 
computers
-+-
 Reporter:  nickm|  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  term-project-ideas,  |  Actual Points:
  tor-03-unspecified-201612  |
Parent ID:   | Points:  large
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * severity:   => Normal
 * milestone:  Tor: unspecified => Tor: 0.3.2.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21693 [Core Tor/Tor]: prop224 HS descriptors do wasteful double-base64 encoding

[Tor Bug Tracker & Wiki]

#21693: prop224 HS descriptors do wasteful double-base64 encoding
+
 Reporter:  asn |  Owner:
 Type:  task| Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs prop224  |  Actual Points:
Parent ID:  | Points:  4
 Reviewer:  |Sponsor:  SponsorR-can
+

Comment (by asn):

 A further point of complication here is that we apply NUL padding (up to
 nearest multiple of 10k bytes) on the superencrypted section to hide
 metadata about client auth details and intro points. So it's more like:

 `middle_layer = b64(encrypt(client_auth_data + b64(encrypt(inner_layer)) +
 nul_padding))`
 `outer_layer = header + middle_layer.`

 So unfortunately it's not as simple as replacing
 `b64(encrypt(inner_layer))` with `encrypt(inner_layer)` since then the
 binary ciphertext gets mangled with the NUL padding... :(

 I guess this means we need some sort of frame on the binary data that
 specifies the length of `encrypt(inner_layer)`, so that the decoding side
 can separate the ciphertext from the padding.

 In my experience, these sort of frames need careful consideration due to
 all sorts of weird padding-oracle type of stuff... Will think some more,
 but this might be a reasonable topic for amsterdam as well...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21719 [HTTPS Everywhere/EFF-HTTPS Everywhere]: Can't copy (Ctrl+C) and make search (Ctrl+F) by formulae on feynmanlectures.caltech.edu. FF 18.0.2 works fine

[Tor Bug Tracker & Wiki]

#21719: Can't copy (Ctrl+C) and make search (Ctrl+F) by formulae on
feynmanlectures.caltech.edu. FF 18.0.2 works fine
-+-
 Reporter:  Ilya_SpongeBob   |  Owner:  legind
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  HTTPS Everywhere/EFF-HTTPS   |Version:
  Everywhere |
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability|  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 F*cking HTTPSE again! Is it really needed for ESR52? (also look at the
 console there)
 Also it triggers #18080
 {{{
 11:09:16.674 Cross-Origin Request Blocked: The Same Origin Policy
 disallows reading the remote resource at
 http://cdn.mathjax.org/mathjax/2.7-latest/fonts/HTML-CSS/TeX/otf
 /MathJax_Main-Regular.otf?V=2.7.0. (Reason: CORS header 'Access-Control-
 Allow-Origin' missing).1 
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21719 [HTTPS Everywhere/EFF-HTTPS Everywhere]: Can't copy (Ctrl+C) and make search (Ctrl+F) by formulae on feynmanlectures.caltech.edu. FF 18.0.2 works fine

[Tor Bug Tracker & Wiki]

#21719: Can't copy (Ctrl+C) and make search (Ctrl+F) by formulae on
feynmanlectures.caltech.edu. FF 18.0.2 works fine
-+-
 Reporter:  Ilya_SpongeBob   |  Owner:  legind
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  HTTPS Everywhere/EFF-HTTPS   |Version:
  Everywhere |
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability|  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by Ilya_SpongeBob):

 Replying to [comment:14 gk]:

 > Don't use Tor Browser 4 anymore ...

 I would willingly, if next versions did not consume more resources and
 have not higher size on HDD.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21719 [HTTPS Everywhere/EFF-HTTPS Everywhere]: Can't copy (Ctrl+C) and make search (Ctrl+F) by formulae on feynmanlectures.caltech.edu. FF 18.0.2 works fine

[Tor Bug Tracker & Wiki]

#21719: Can't copy (Ctrl+C) and make search (Ctrl+F) by formulae on
feynmanlectures.caltech.edu. FF 18.0.2 works fine
-+-
 Reporter:  Ilya_SpongeBob   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  HTTPS Everywhere/EFF-HTTPS   |Version:
  Everywhere |
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability|  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * component:  Applications/Tor Browser => HTTPS Everywhere/EFF-HTTPS
 Everywhere


Comment:

 Replying to [comment:13 Ilya_SpongeBob]:
 > My computer works faster with Tor Browser 4, so I would like to use ver.
 4. Should I create a new ticket for font minimization on ver.4?

 Don't use Tor Browser 4 anymore (I know it might be easier to say than to
 do) because you are vulnerable to several critical bugs for which there
 are very likely exploits on the Interenet. Moreover, you are probably
 easily recognizable as there won't be many Tor Browser 4 users any longer
 around.

 That said: opening a ticket won't help, alas, as we don't support Tor
 Browser 4 anymore. Nevertheless, thanks for the bug report!

 Moving this to the HTTPS Everywhere component as this is easily
 reproducible in a vanilla Firefox ESR 45.8.0 with just HTTPS Everywhere as
 extension installed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21719 [HTTPS Everywhere/EFF-HTTPS Everywhere]: Can't copy (Ctrl+C) and make search (Ctrl+F) by formulae on feynmanlectures.caltech.edu. FF 18.0.2 works fine

[Tor Bug Tracker & Wiki]

#21719: Can't copy (Ctrl+C) and make search (Ctrl+F) by formulae on
feynmanlectures.caltech.edu. FF 18.0.2 works fine
-+-
 Reporter:  Ilya_SpongeBob   |  Owner:  legind
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  HTTPS Everywhere/EFF-HTTPS   |Version:
  Everywhere |
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability|  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * owner:  tbb-team => legind
 * status:  needs_information => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21719 [Applications/Tor Browser]: Can't copy (Ctrl+C) and make search (Ctrl+F) by formulae on feynmanlectures.caltech.edu. FF 18.0.2 works fine

[Tor Bug Tracker & Wiki]

#21719: Can't copy (Ctrl+C) and make search (Ctrl+F) by formulae on
feynmanlectures.caltech.edu. FF 18.0.2 works fine
--+---
 Reporter:  Ilya_SpongeBob|  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-usability |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by Ilya_SpongeBob):

 My computer works faster with Tor Browser 4, so I would like to use ver.
 4. Should I create a new ticket for font minimization on ver.4?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19833 [Applications]: torsocks-2.2.0-rc1 segfaults emacs(notmuch) and git

[Tor Bug Tracker & Wiki]

#19833: torsocks-2.2.0-rc1 segfaults emacs(notmuch) and git
--+
 Reporter:  ng0   |  Owner:
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  torsocks  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by ng0):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 fixed in latest release of torsocks

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21719 [Applications/Tor Browser]: Can't copy (Ctrl+C) and make search (Ctrl+F) by formulae on feynmanlectures.caltech.edu. FF 18.0.2 works fine

[Tor Bug Tracker & Wiki]

#21719: Can't copy (Ctrl+C) and make search (Ctrl+F) by formulae on
feynmanlectures.caltech.edu. FF 18.0.2 works fine
--+---
 Reporter:  Ilya_SpongeBob|  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-usability |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by gk):

 Replying to [comment:11 Ilya_SpongeBob]:
 >
 >
 > Yes, on FF ESR 45.1.0 fonts are normal. But on TorBrowser 5+ fonts are
 also normal.

 Okay. I was assuming that you only tested Tor Browser in comment:7 and was
 wondering whether just HTTPS-Everywhere installed in the unmodified 45.1.0
 ESR gives the same copy/search issues. I guess that's the case then?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20680 [Applications/Tor Browser]: Rebase Tor Browser patches to 52 ESR

[Tor Bug Tracker & Wiki]

#20680: Rebase Tor Browser patches to 52 ESR
-+-
 Reporter:  arthuredelstein  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, tbb-7.0-must,  |  Actual Points:
  TorBrowserTeam201703   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by cypherpunks):

 O [removed in esr17] Bug #6210: set plugin.expose_full_path to false
 O [removed in esr38] Bug #9012: Do not display the missing plugin
 information bar
 D [broken] Bug #9867: Flash is not click-to-play
 O* [removed in esr31] Bug #10703: Fallback charset enables fingerprinting
 of bundle localization
 O [FF has] Bug #11253: Turn on TLS 1.1 and 1.2 in TorBrowser
 O [removed in esr31] Bug #12212: Disable deprecated Audio Data API
 O [removed in esr38] Bug #15029: Tor Browser 4.5a4 prompts to install
 Flash
 O [FF has] Bug #17369: The RC4 cipher flags in TBB must be set to "false"
 by default

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21719 [Applications/Tor Browser]: Can't copy (Ctrl+C) and make search (Ctrl+F) by formulae on feynmanlectures.caltech.edu. FF 18.0.2 works fine

[Tor Bug Tracker & Wiki]

#21719: Can't copy (Ctrl+C) and make search (Ctrl+F) by formulae on
feynmanlectures.caltech.edu. FF 18.0.2 works fine
--+---
 Reporter:  Ilya_SpongeBob|  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-usability |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by Ilya_SpongeBob):

 Replying to [comment:10 gk]:
 > Replying to [comment:9 Ilya_SpongeBob]:
 > > I don't know what is vanilla Firefox. I use FF 18.0.2 Portable
 (Portableapps) and it doesn't contain HTTPS Everywhere. Fonts are normal.
 > >
 > > Anyway I can't use FF of ver. higher 18 because my computer has not
 enough resources.
 >
 > I meant the normal, unmodified Firefox 45.1.0 from above you tested
 with.

 Yes on FF 45.1.0 fonts are normal too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21738 [Internal Services/Tor Sysadmin Team]: Please add alison to the tormedia group

[Tor Bug Tracker & Wiki]

#21738: Please add alison to the tormedia group
-+
 Reporter:  arma |  Owner:  tpa
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by weasel):

 * status:  new => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21734 [Internal Services/Tor Sysadmin Team]: add hiro to torblog

[Tor Bug Tracker & Wiki]

#21734: add hiro to torblog
-+
 Reporter:  hiro |  Owner:  tpa
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by weasel):

 * status:  new => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21734 [Internal Services/Tor Sysadmin Team]: add hiro to torblog (was: Access to motor.tpo)

[Tor Bug Tracker & Wiki]

#21734: add hiro to torblog
-+-
 Reporter:  hiro |  Owner:  tpa
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21719 [Applications/Tor Browser]: Can't copy (Ctrl+C) and make search (Ctrl+F) by formulae on feynmanlectures.caltech.edu. FF 18.0.2 works fine

[Tor Bug Tracker & Wiki]

#21719: Can't copy (Ctrl+C) and make search (Ctrl+F) by formulae on
feynmanlectures.caltech.edu. FF 18.0.2 works fine
--+---
 Reporter:  Ilya_SpongeBob|  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-usability |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by gk):

 Replying to [comment:9 Ilya_SpongeBob]:
 > I don't know what is vanilla Firefox. I use FF 18.0.2 Portable
 (Portableapps) and it doesn't contain HTTPS Everywhere. Fonts are normal.
 >
 > Anyway I can't use FF of ver. higher 18 because my computer has not
 enough resources.

 I meant the normal, unmodified Firefox 45.1.0 from above you tested with.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21748 [Obfuscation/Snowflake]: Snowflake breaks nightly builds as of March 15

[Tor Bug Tracker & Wiki]

#21748: Snowflake breaks nightly builds as of March 15
---+--
 Reporter:  gk |  Owner:  arlolra
 Type:  defect | Status:  assigned
 Priority:  High   |  Milestone:
Component:  Obfuscation/Snowflake  |Version:
 Severity:  Major  | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by gk):

 * owner:   => arlolra
 * status:  new => assigned


Comment:

 Assigning to arlo. Let me know if that should be someone else in the
 future.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21748 [Obfuscation/Snowflake]: Snowflake breaks nightly builds as of March 15

[Tor Bug Tracker & Wiki]

#21748: Snowflake breaks nightly builds as of March 15
---+-
 Reporter:  gk |  Owner:
 Type:  defect | Status:  new
 Priority:  High   |  Milestone:
Component:  Obfuscation/Snowflake  |Version:
 Severity:  Major  |   Keywords:
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor: |
---+-
 Our nightly builds are broken now due to Snowflake compilation being
 unhappy:
 {{{
 + go install github.com/keroserene/go-webrtc
 # github.com/keroserene/go-webrtc
 :0:0: warning: "_GLIBCXX_USE_CXX11_ABI" redefined
 :0:0: note: this is the location of the previous definition
 # github.com/keroserene/go-webrtc
 :0:0: warning: "_GLIBCXX_USE_CXX11_ABI" redefined
 :0:0: note: this is the location of the previous definition
 # github.com/keroserene/go-webrtc
 :0:0: warning: "_GLIBCXX_USE_CXX11_ABI" redefined
 :0:0: note: this is the location of the previous definition
 ../../go/src/github.com/keroserene/go-webrtc/peerconnection.cc:13:51:
 fatal error: webrtc/pc/test/fakeaudiocapturemodule.h: No such file or
 directory
 compilation terminated.
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21719 [Applications/Tor Browser]: Can't copy (Ctrl+C) and make search (Ctrl+F) by formulae on feynmanlectures.caltech.edu. FF 18.0.2 works fine

[Tor Bug Tracker & Wiki]

#21719: Can't copy (Ctrl+C) and make search (Ctrl+F) by formulae on
feynmanlectures.caltech.edu. FF 18.0.2 works fine
--+---
 Reporter:  Ilya_SpongeBob|  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-usability |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by Ilya_SpongeBob):

 I don't know what is vanilla Firefox. I use FF 18.0.2 Portable
 (Portableapps) and it doesn't contain HTTPS Everywhere. Anyway I can't use
 FF of ver. higher 18 because my computer has not enough resources.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21719 [Applications/Tor Browser]: Can't copy (Ctrl+C) and make search (Ctrl+F) by formulae on feynmanlectures.caltech.edu. FF 18.0.2 works fine

[Tor Bug Tracker & Wiki]

#21719: Can't copy (Ctrl+C) and make search (Ctrl+F) by formulae on
feynmanlectures.caltech.edu. FF 18.0.2 works fine
--+---
 Reporter:  Ilya_SpongeBob|  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-usability |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by gk):

 Replying to [comment:7 Ilya_SpongeBob]:
 > By disabling addons one by one I found HTTPS Everywhere 5.2.12 is the
 cause. But font minimization is still unexplained.

 Interesting. And this happens as well (the font minimization, too?) on a
 vanilla Firefox just with HTTPS-Everywhere as additional extension?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21719 [Applications/Tor Browser]: Can't copy (Ctrl+C) and make search (Ctrl+F) by formulae on feynmanlectures.caltech.edu. FF 18.0.2 works fine

[Tor Bug Tracker & Wiki]

#21719: Can't copy (Ctrl+C) and make search (Ctrl+F) by formulae on
feynmanlectures.caltech.edu. FF 18.0.2 works fine
--+---
 Reporter:  Ilya_SpongeBob|  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-usability |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by Ilya_SpongeBob):

 By disabling addons one by one I found HTTPS Everywhere 5.2.12 is the
 cause.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21719 [Applications/Tor Browser]: Can't copy (Ctrl+C) and make search (Ctrl+F) by formulae on feynmanlectures.caltech.edu. FF 18.0.2 works fine

[Tor Bug Tracker & Wiki]

#21719: Can't copy (Ctrl+C) and make search (Ctrl+F) by formulae on
feynmanlectures.caltech.edu. FF 18.0.2 works fine
--+---
 Reporter:  Ilya_SpongeBob|  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-usability |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by Ilya_SpongeBob):

 Replying to [comment:5 gk]:

 > Can you reproduce that? And taking that into account your normal Firefox
 still allows you to copy formulae after that change on the side?


 Yes, when scripts are disabled by NoScript Addon I can copy the text but
 formulae are shown as Latex - code and are absolutelly unreadable. I have
 checked the bug in next browsers:

 * FF ESR 45.1.0 with default settings (scripts on) - can copy and search
 by formulae;
 * FF ESR 31.6.0 with default settings (scripts on) - can copy and search;
 * FF 18.0.2 with NoScript Addon allowing scripts - can copy and search;
 * TorBrowser 4.0.8 with NoScript Addon allowing scripts - can copy and
 search, but font changed (maybe by script) to very small and hard to read;
 * TorBrowser 5.0.7 with NoScript Addon allowing scripts - can't copy or
 search;
 * TorBrowser 5.5.5 with NoScript Addon allowing scripts - can't copy or
 search;
 * TorBrowser 6.0.8 with NoScript Addon allowing scripts - can't copy or
 search;

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #6474 [Applications/Tor Browser]: Don't prompt for Offline Storage unless disk activity is enabled

[Tor Bug Tracker & Wiki]

#6474: Don't prompt for Offline Storage unless disk activity is enabled
-+-
 Reporter:  mikeperry|  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability, tbb-   |  Actual Points:
  pref, tbb-firefox-patch|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 #13503 is a duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13503 [Applications/Tor Browser]: Tor Browser does nothing when clicking "Allow" for offline storage use

[Tor Bug Tracker & Wiki]

#13503: Tor Browser does nothing when clicking "Allow" for offline storage use
--+---
 Reporter:  isis  |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  duplicate
 Keywords:  tbb-pref, tbb-usability   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by cypherpunks):

 * status:  new => closed
 * resolution:   => duplicate
 * severity:   => Normal


Comment:

 Closed as a duplicate of #6474.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21719 [Applications/Tor Browser]: Can't copy (Ctrl+C) and make search (Ctrl+F) by formulae on feynmanlectures.caltech.edu. FF 18.0.2 works fine

[Tor Bug Tracker & Wiki]

#21719: Can't copy (Ctrl+C) and make search (Ctrl+F) by formulae on
feynmanlectures.caltech.edu. FF 18.0.2 works fine
--+---
 Reporter:  Ilya_SpongeBob|  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-usability |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by gk):

 Replying to [comment:4 Ilya_SpongeBob]:
 > Replying to [comment:2 gk]:
 > > Hm, and this works in a vanilla Firefox 45 ESR?
 > This works in Mozilla Firefox ESR, Portable Edition 17.0.3 and Mozilla
 Firefox ESR, Portable Edition 45.1.0
 >
 >
 
https://sourceforge.net/projects/portableapps/files/Mozilla%20Firefox%2C%20Portable%20Ed./Mozilla%20Firefox%20ESR%2C%20Portable%20Edition%2017.0.3/
 >
 >
 
https://sourceforge.net/projects/portableapps/files/Mozilla%20Firefox%2C%20Portable%20Ed./Mozilla%20Firefox%20ESR%2C%20Portable%20Edition%2045.1.0/

 This seems to work for me immediately after loading the page: I can copy
 and paste formulae and search for them in the text. But later on something
 changes the content (probably some script) leading to the results you
 describe. Can you reproduce that? And taking that into account your normal
 Firefox still allows you to copy formulae after that change on the side?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21747 [Applications/Tor Browser]: Requesting a new circuit for a site is not working in ESR 52 based Tor Browser

[Tor Bug Tracker & Wiki]

#21747: Requesting a new circuit for a site is not working in ESR 52 based Tor
Browser
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  tbb-torbutton,
 Severity:  Normal   |  ff52-esr, tbb-7.0-must,
 |  TorBrowserTeam201703
Actual Points:   |  Parent ID:  #21201
   Points:   |   Reviewer:
  Sponsor:  Sponsor4 |
-+-
 Trying to request a new circuit does nothing but instead gives
 {{{
 TypeError: thirdPartyUtil.getFirstPartyHostForIsolation is not a function
 torbutton.js:1016:26
 }}}
 in the browser console.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs