Re: [tor-bugs] #25400 [Core Tor/Tor]: CIRC_BW event miscounts, should count all circ data

[Tor Bug Tracker & Wiki]

#25400: CIRC_BW event miscounts, should count all circ data
--+
 Reporter:  mikeperry |  Owner:  mikeperry
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-stats |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by mikeperry):

 Another additional wrinkle to discuss: I chose to use CELL_PAYLOAD_SIZE as
 the number of bytes to count per cell. That value is the total bytes in a
 cell, less cell header size. I also briefly debated subtracting the common
 relay header size, but since the true relay header size varies by relay
 cell type, I decided not to subtract the common relay header from the
 totals. The Tor controller can decide to subtract the common relay header
 out itself (as it represents a constant rate of overhead). The vanguards
 controller will do this subtraction.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25400 [Core Tor/Tor]: CIRC_BW event miscounts, should count all circ data

[Tor Bug Tracker & Wiki]

#25400: CIRC_BW event miscounts, should count all circ data
--+
 Reporter:  mikeperry |  Owner:  mikeperry
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-stats |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by mikeperry):

 * cc: atagar (added)


Comment:

 To Teor's question, Karsten implemented the event, possibly for metrics
 usage. I don't know if metrics relies upon the existing behavior in a
 critical way. atagar may also have more information on CIRC_BW usage by
 Nyx and other stem apps.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25401 [Core Tor/Tor]: Transparent proxy stopped working after Linux kernel update to version 4.4.118 that fixes Spectre variant 1

[Tor Bug Tracker & Wiki]

#25401: Transparent proxy stopped working after Linux kernel update to version
4.4.118 that fixes Spectre variant 1
--+-
 Reporter:  FlinchX   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Immediate |  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.3.2.9
 Severity:  Blocker   |   Keywords:  transparent proxy TransPort
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+-
 This happens on a fully updated Slackware64-14.2 system with tor 0.3.2.9
 after an update to kernel 4.4.118 that fixes Spectre variant 1. Same
 version of tor worked fine with a few previous 4.4.x kernel versions
 (4.4.115, 4.4.111, 4.4.88). Tor process freezes in uninterruptible state
 as soon as a program anonymized using this guideline
 
https://trac.torproject.org/projects/tor/wiki/doc/TransparentProxy#Transparentlyanonymizingtrafficforaspecificuser
 tries to get online. Symptoms are similar to the ones described in this
 ticket https://trac.torproject.org/projects/tor/ticket/25380

 More technical details from two different sources that were able to
 reproduce the issue independently can be found in this forum thread
 https://www.linuxquestions.org/questions/slackware-14/address-already-in-
 use-errors-when-trying-to-restart-tor-4175624554/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25400 [Core Tor/Tor]: CIRC_BW event miscounts, should count all circ data

[Tor Bug Tracker & Wiki]

#25400: CIRC_BW event miscounts, should count all circ data
--+
 Reporter:  mikeperry |  Owner:  mikeperry
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-stats |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by mikeperry):

 * status:  assigned => needs_review


Comment:

 Patch in mikeperry/bug25400. Spec patch in my torspec remote, also branch
 bug25400.

 Right now this branch only counts relay cells, which is similar to the
 behavior before. I decided against counting CREATED cells, and VAR cells,
 because those are a bit weird since there is not a circuit ID on the
 outgoing cell, only upon the response. Let me know what you think.

 For what it's worth, counting all cells (including
 padding/dropped/rejected/partially full ones) in circuit bandwidth totals
 allows a Tor controller to check for side channel attacks by doing
 accounting on STREAM_BW totals on a circuit and comparing that to the
 CIRC_BW totals. Large differences indicate side channel abuse (depending
 on the application protocol).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25400 [Core Tor/Tor]: CIRC_BW event miscounts, should count all circ data

[Tor Bug Tracker & Wiki]

#25400: CIRC_BW event miscounts, should count all circ data
--+
 Reporter:  mikeperry |  Owner:  mikeperry
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-stats |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * keywords:   => tor-stats
 * milestone:   => Tor: 0.3.4.x-final


Comment:

 How is this event used?
 I'd like to know how important it is, so I can prioritise this ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25399 [Core Tor/Tor]: mmap length doesn't need to be page-aligned

[Tor Bug Tracker & Wiki]

#25399: mmap length doesn't need to be page-aligned
--+
 Reporter:  Hello71   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * points:   => 0.5
 * milestone:   => Tor: 0.3.4.x-final


Comment:

 Can you explain how this bug affects Tor?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25398 [Core Tor/Tor]: tests fail if COMPAT_HAS_MMAN_AND_PAGESIZE is not set

[Tor Bug Tracker & Wiki]

#25398: tests fail if COMPAT_HAS_MMAN_AND_PAGESIZE is not set
-+
 Reporter:  Hello71  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Low  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  easy intro tor-test  |  Actual Points:
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+
Changes (by teor):

 * keywords:   => easy intro tor-test
 * points:   => 0.1
 * milestone:   => Tor: 0.3.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25400 [Core Tor/Tor]: CIRC_BW event miscounts, should count all circ data

[Tor Bug Tracker & Wiki]

#25400: CIRC_BW event miscounts, should count all circ data
--+---
 Reporter:  mikeperry |  Owner:  mikeperry
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+---
 The CIRC_BW event as implemented seems to be totaling only explicit
 application data on the circuit. To have an accurate representation of
 circuit usage, it should total all bytes sent on the circuit, including
 padding, dropped cells, and partially full cells.

 Furthermore, it currently counts bytes differently depending on if you
 have the STREAM event enabled (see control_event_stream_bandwidth()). This
 is definitely a bug.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25399 [Core Tor/Tor]: mmap length doesn't need to be page-aligned

[Tor Bug Tracker & Wiki]

#25399: mmap length doesn't need to be page-aligned
--+
 Reporter:  Hello71   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Minor |   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 POSIX says that mmap length doesn't need to be page-aligned. addr and off
 may have page alignment requirements, but length must be handled
 automatically. getpagesize is deprecated too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25398 [Core Tor/Tor]: tests fail if COMPAT_HAS_MMAN_AND_PAGESIZE is not set

[Tor Bug Tracker & Wiki]

#25398: tests fail if COMPAT_HAS_MMAN_AND_PAGESIZE is not set
--+
 Reporter:  Hello71   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Minor |   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 `tor_mmap_file` doesn't check for empty files if
 `COMPAT_HAS_MMAN_AND_PAGESIZE` is not set, causes `test_util_mmap` to fail

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24965 [Applications/Tor Browser]: Automatically remove metadata from images (EXIF) before upload

[Tor Bug Tracker & Wiki]

#24965: Automatically remove metadata from images (EXIF) before upload
---+--
 Reporter:  arthuredelstein|  Owner:  tbb-team
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-fingerprinting, gsoc-proposed  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by arthuredelstein):

 Replying to [comment:4 cypherpunks]:
 > By default, seems really great to protect users (would such a benefit
 apply to GlobaLeaks as well?). What if I want to have EXIF data uploaded?
 There should be some pref for that I can flip in such cases.

 Yes, I can imagine a checkbox in the upload dialog or a pref might be a
 possibility. I think it's important that metadata is stripped by default,
 though.

 > PS: What about PDFs as well?

 Yes! There's a list on https://mat.boum.org that could serve as
 inspiration:

 Portable Network Graphics (.png)
 JPEG (.jpg, .jpeg, …)
 TIFF (.tif, tiff, …)
 Open Documents (.odt, .odx, .ods, …)
 Office OpenXml (.docx, .pptx, .xlsx, …)
 Portable Document Fileformat (.pdf)
 Tape ARchives (.tar, .tar.bz2, …)
 MPEG AUdio (.mp3, .mp2, .mp1, …)
 Ogg Vorbis (.ogg, …)
 Free Lossless Audio Codec (.flac)
 Torrent (.torrent)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23169 [Metrics/Website]: Explain why metrics are important and what we do to make sure they're safe

[Tor Bug Tracker & Wiki]

#23169: Explain why metrics are important and what we do to make sure they're 
safe
-+
 Reporter:  arma |  Owner:  irl
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:  iwakeh, karsten  |Sponsor:
-+
Changes (by karsten):

 * cc: metrics-team (added)


Comment:

 (Gotta copy metrics-team, or metrics-bugs@ won't receive messages when the
 ticket gets updated.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23169 [Metrics/Website]: Explain why metrics are important and what we do to make sure they're safe

[Tor Bug Tracker & Wiki]

#23169: Explain why metrics are important and what we do to make sure they're 
safe
-+
 Reporter:  arma |  Owner:  irl
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:  iwakeh, karsten  |Sponsor:
-+
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 I reviewed the branch and built it locally. Some thoughts:
  - The text really reads well! In the first pass I didn't spot anything
 incorrect or misleading. Great stuff!
  - When looking at the locally built website, I noticed that the home page
 now starts with a lot of text. This might be a bit intimidating for new
 users and slightly annoying for returning users. Don't get me wrong, the
 text is useful, it's the presentation that we might still be able to
 improve. Maybe split up paragraphs and use paragraph titles?
  - Related to the point above, the two columns on the start page should
 have the same length.
  - You're saying "Tor Metrics Portal" in at least one place, but I think
 we stopped calling it a portal a while ago. We're referring to the website
 as "Tor Metrics" or "Tor Metrics website".
  - The descriptions under Philosophy look a bit like they could benefit
 from some more whitespace. I guess we did not style them when we redid the
 website last year, because we didn't use description lists before. Maybe
 we should just add a little bit of space before the `` part? We could
 ask antonela.
  - The dependencies diagram on the About page is really neat! Are there
 instructions anywhere how I would build that?
  - That diagram should also include Consensus Health, which fetches data
 from the directory authorities without help of metrics-lib, and which we
 could say is made for users, not primarily researchers or developers.

 All in all, I really like what you wrote there! Let's see if we can tweak
 it some more, and let's also hear what iwakeh has to add. Maybe we can
 even deploy this in the next days.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25378 [Core Tor/Tor]: Log domain list is out of sync in tor.1.txt

[Tor Bug Tracker & Wiki]

#25378: Log domain list is out of sync in tor.1.txt
---+
 Reporter:  ahf|  Owner:  ahf
 Type:  defect | Status:  merge_ready
 Priority:  Low|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  doc, 033-backport  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by nickm):

 +1. Let's take this once 0.3.3.3-alpha has been tagged.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25112 [Applications/Tor Browser]: Tor Browser 7.5 is not working on Windows Vista 64bit

[Tor Bug Tracker & Wiki]

#25112: Tor Browser 7.5 is not working on Windows Vista 64bit
-+-
 Reporter:  gk   |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  ff60-esr-will-have,  |  Actual Points:
  TorBrowserTeam201803R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by pospeselr):

 * keywords:  ff60-esr-will-have, TorBrowserTeam201802R => ff60-esr-will-
 have, TorBrowserTeam201803R
 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25147 [Applications/Tor Browser]: Backport of fix shipped in Firefox 58.0.1?

[Tor Bug Tracker & Wiki]

#25147: Backport of fix shipped in Firefox 58.0.1?
--+--
 Reporter:  gk|  Owner:  pospeselr
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201803R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by pospeselr):

 * keywords:  TorBrowserTeam201802R => TorBrowserTeam201803R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25147 [Applications/Tor Browser]: Backport of fix shipped in Firefox 58.0.1?

[Tor Bug Tracker & Wiki]

#25147: Backport of fix shipped in Firefox 58.0.1?
--+--
 Reporter:  gk|  Owner:  pospeselr
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201802R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by pospeselr):

 * keywords:  TorBrowserTeam201802 => TorBrowserTeam201802R
 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25147 [Applications/Tor Browser]: Backport of fix shipped in Firefox 58.0.1?

[Tor Bug Tracker & Wiki]

#25147: Backport of fix shipped in Firefox 58.0.1?
--+---
 Reporter:  gk|  Owner:  pospeselr
 Type:  task  | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201802  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by pospeselr):

 * Attachment "0001-Bug-25147-Backport-of-fix-shipped-in-
 Firefox-58.0.1.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25396 [Metrics/Consensus Health]: Consensus health reports wrong latest valid-after time

[Tor Bug Tracker & Wiki]

#25396: Consensus health reports wrong latest valid-after time
--+-
 Reporter:  asn   |  Owner:  tom
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Metrics/Consensus Health  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-

Comment (by tom):

 It's possible this is caused by host issues.  The host that it runs on is
 currently down, which is why it says 2018-03-01 17:00:00 as of this
 comment.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24765 [Core Tor/Tor]: What version of Rust does Tor require for 0.3.2?

[Tor Bug Tracker & Wiki]

#24765: What version of Rust does Tor require for 0.3.2?
---+
 Reporter:  teor   |  Owner:  (none)
 Type:  task   | Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-rust, doc  |  Actual Points:  0.1
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:
---+

Comment (by isis):

 Closed #25379 as a duplicate of this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25379 [Core Tor/Tor]: Determine the lowest rustc version we will compile with

[Tor Bug Tracker & Wiki]

#25379: Determine the lowest rustc version we will compile with
-+
 Reporter:  isis |  Owner:  (none)
 Type:  task | Status:  closed
 Priority:  Low  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  duplicate
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:  #24765   | Points:  2
 Reviewer:   |Sponsor:  SponsorM-can
-+
Changes (by isis):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Replying to [comment:1 teor]:
 > This might be a duplicate of #24765

 Definitely a duplicate, thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25342 [Internal Services/Tor Sysadmin Team]: Please sync recent Apache web server logs from torproject.org hosts to colchicifolium

[Tor Bug Tracker & Wiki]

#25342: Please sync recent Apache web server logs from torproject.org hosts to
colchicifolium
-+-
 Reporter:  karsten  |  Owner:  tpa
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by karsten):

 When you have a moment, can you please start looking into this or tell me
 what's needed to get this going? Ideally, I'd want to start deploying
 things before Rome. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24217 [Metrics/Statistics]: Specify data format and aggregation process of new IPv6 relay statistics

[Tor Bug Tracker & Wiki]

#24217: Specify data format and aggregation process of new IPv6 relay statistics
+--
 Reporter:  karsten |  Owner:  karsten
 Type:  enhancement | Status:  needs_review
 Priority:  High|  Milestone:
Component:  Metrics/Statistics  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  iwakeh  |Sponsor:
+--

Comment (by karsten):

 Quick update: we moved to storm, and I added more content. Then I realized
 that the shortcuts should better be written in code and wrote the
 "download data as CSV" feature that is now deployed on all graph pages on
 Tor Metrics. Next step will be to add more content for the complete
 journeys. There's not much to see yet for that part.

 I wonder if we should generalize the scope of this ticket. We're writing
 documentation for all data available on Tor Metrics, not just IPv6 relay
 statistics. But we can change the summary when we move forward here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24229 [Metrics/Website]: Provide BGP Data Collection on Tor Metrics

[Tor Bug Tracker & Wiki]

#24229: Provide BGP Data Collection on Tor Metrics
-+---
 Reporter:  iwakeh   |  Owner:  iwakeh
 Type:  enhancement  | Status:  needs_information
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---

Comment (by karsten):

 Sounds good to me!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24707 [Metrics]: Define R coding guidelines for Metrics' products

[Tor Bug Tracker & Wiki]

#24707: Define R coding guidelines for Metrics' products
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by karsten):

 I just finished reading the tidyverse style guide, and I like it. I'd say
 unless you find anything speaking against it or for another guide/tool,
 let's use it.

 (Note that we wouldn't use the full tidyverse package just yet. It's not
 fully packaged in Debian. So far we use ggplot2, tidyr, and dplyr. In the
 future, I'd like to switch to readr.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25397 [Metrics/Website]: Cut off lower number of expected clients at 0

[Tor Bug Tracker & Wiki]

#25397: Cut off lower number of expected clients at 0
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+--
 We should avoid negative numbers in clients.csv and in per-graph CSV files
 based on it.

 Take this graph as example:

 https://metrics.torproject.org/userstats-relay-
 country.html?start=2013-08-15=2013-08-31=dk=on

 The corresponding CSV file is:

 {{{
 date,users,downturns,upturns,lower,upper
 2013-08-15,2419,FALSE,FALSE,1509,3400
 2013-08-16,2417,FALSE,FALSE,1530,3526
 2013-08-17,2583,FALSE,FALSE,1888,3593
 2013-08-18,2625,FALSE,FALSE,2099,3451
 2013-08-19,2631,FALSE,FALSE,1950,3865
 2013-08-20,2998,FALSE,FALSE,-307,8058
 2013-08-21,3429,FALSE,FALSE,-2158,12097
 2013-08-22,4161,FALSE,FALSE,-5815,19493
 2013-08-23,4910,FALSE,FALSE,-11092,29505
 2013-08-24,5387,FALSE,FALSE,-14669,35722
 2013-08-25,5899,FALSE,FALSE,-16103,38944
 2013-08-26,6115,FALSE,FALSE,-18394,42370
 2013-08-27,6486,FALSE,FALSE,-8958,29056
 2013-08-28,7213,FALSE,FALSE,-4772,23752
 2013-08-29,7950,FALSE,FALSE,-,19506
 2013-08-30,8844,FALSE,FALSE,1660,17111
 2013-08-31,9966,FALSE,FALSE,2088,19165
 }}}

 We can just cut the lower number at 0. Like in the graph.

 We could do it in write_userstats_relay_country() or in the clients
 module. The first is at lot easier to fix.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25396 [Metrics/Consensus Health]: Consensus health reports wrong latest valid-after time

[Tor Bug Tracker & Wiki]

#25396: Consensus health reports wrong latest valid-after time
--+-
 Reporter:  asn   |  Owner:  tom
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Metrics/Consensus Health  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+-
 Over the past days a few people have reported that consensus health
 reports the wrong latest valid-after time.

 As an example, it currently says:
 {{{
 Consensus was published 2018-03-01 17:00:00. Note that it takes up to 15
 minutes to learn about new consensus and votes and process them.
 }}}

 but there is a valid 19:00 consensus:

 {{{
 $ curl -kis http://199.58.81.140/tor/status-vote/current/consensus-
 microdesc | grep valid-after
 valid-after 2018-03-01 19:00:00
 $ date --utc
 Thu  1 Mar 19:33:43 UTC 2018
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25388 [Core Tor/Tor]: document how to allow partially failing builds in Travis CI

[Tor Bug Tracker & Wiki]

#25388: document how to allow partially failing builds in Travis CI
--+
 Reporter:  catalyst  |  Owner:  catalyst
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-ci|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by catalyst):

 Pushed a minor typo fix in a comment.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24707 [Metrics]: Define R coding guidelines for Metrics' products

[Tor Bug Tracker & Wiki]

#24707: Define R coding guidelines for Metrics' products
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by iwakeh):

 Regarding licensing: tidyverse is GPL3; I couldn't find anything on the
 styleguide itself.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24698 [Applications/Tor Browser]: Torbrowser keeps hanging and freezing, plus it takes a very long time to load after hibernation

[Tor Bug Tracker & Wiki]

#24698: Torbrowser keeps hanging and freezing, plus it takes a very long time to
load after hibernation
--+---
 Reporter:  justmeee  |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Immediate |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Critical  | Resolution:
 Keywords:  tbb-performance   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by justmeee):

 I looked at the Event Viewer and it seems like the same message.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24707 [Metrics]: Define R coding guidelines for Metrics' products

[Tor Bug Tracker & Wiki]

#24707: Define R coding guidelines for Metrics' products
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by iwakeh):

 Replying to [comment:5 karsten]:

 Thanks for looking!

 > Replying to [comment:4 iwakeh]:
 > > Stumbled upon some R style guides:
 > >
 > > * [http://style.tidyverse.org/ tidyverse] has also packages supporting
 the styles.
 >
 > On first sight this looks best. I installed the `lintr` package and it
 showed me useful output.

 Yes, I think so too.  Will try the `lintr` package.

 >
 > > * [https://google.github.io/styleguide/Rguide.xml Google's R Style] on
 which many others build
 >
 > Might make sense to look into this more, because we're also using
 Google's Java style. But we need a tool.

 I think it is very terse almost seeming unfinished.

 >
 > > * [https://github.com/rdatsci/PackagesInfo/wiki/R-Style-Guide Style
 Guide by rdatsci] building on Google's and two others linked from the doc.
 >
 > The part where I stopped reading was "Assignment operator: Use = instead
 of <- for assignments." Sorry, you're out.

 True, the R-majority uses `<-`, but at least the
 [https://csgillespie.wordpress.com/2010/11/16/assignment-operators-
 in-r-vs/ link quoted there] is helpful.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25395 [Webpages/Website]: Upload banners to media.torproject.org

[Tor Bug Tracker & Wiki]

#25395: Upload banners to media.torproject.org
--+
 Reporter:  steph |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #25282| Points:
 Reviewer:|Sponsor:
--+

Comment (by steph):

 Banners are too large to upload. Emailing dl links to hiro.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25339 [Applications/Tor Browser]: Install python 3.6 for building HTTPS-Everywhere

[Tor Bug Tracker & Wiki]

#25339: Install python 3.6 for building HTTPS-Everywhere
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803R,  |  Actual Points:
  boklm201802|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  needs_revision => needs_review
 * keywords:  tbb-rbm, TorBrowserTeam201803, boklm201802 => tbb-rbm,
 TorBrowserTeam201803R, boklm201802


Comment:

 Replying to [comment:4 gk]:
 >
 > Yes, that's true. However we would need to look for yet another solution
 to this bug in about three months as Ubuntu Artful is EOL in July 2018,
 not ideal. If you feel strongly here I am fine building Python 3.6 from
 source for 64bit Linux in the same container used for HTTPS-Everywhere. I
 feel the risk of breaking the reproducibility of HTTPS-Everywhere with
 `buster` is not very high given that it is "just" an extension. Either way
 I want to test the new process in an alpha anyway first (shipping the
 stable one time with a not up-to-date HTTPS-Everywhere seems to me
 acceptable given that we need to test a new build method in our
 environment first).

 I don't feel strongly about this, so I am fine using `buster`. We can
 still look for another solution later if it actually becomes a problem.

 > Looking at the patch we don't need the 32bit `buster` in the debootstrap
 config. Could you remove that part? Oh, and we might want to clean that
 config up anyway (in a different bug/commit) as there are still Ubuntu
 Precise things among others in it.

 I removed the 32bit `buster` in branch `bug_25339_v3`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_25339_v3=7f6cb4caa95b7818e4482f41fd333f5a2a8d60f1

 And I opened #25394 for more clean up.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25395 [Webpages/Website]: Upload banners to media.torproject.org

[Tor Bug Tracker & Wiki]

#25395: Upload banners to media.torproject.org
--+
 Reporter:  steph |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:  #25282
   Points:|   Reviewer:
  Sponsor:|
--+
 Create new subfolder "Banners" under "Outreach Materials"
 -upload 2 banners

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24707 [Metrics]: Define R coding guidelines for Metrics' products

[Tor Bug Tracker & Wiki]

#24707: Define R coding guidelines for Metrics' products
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by karsten):

 Replying to [comment:4 iwakeh]:
 > Stumbled upon some R style guides:
 >
 > * [http://style.tidyverse.org/ tidyverse] has also packages supporting
 the styles.

 On first sight this looks best. I installed the `lintr` package and it
 showed me useful output.

 > * [https://google.github.io/styleguide/Rguide.xml Google's R Style] on
 which many others build

 Might make sense to look into this more, because we're also using Google's
 Java style. But we need a tool.

 > * [https://github.com/rdatsci/PackagesInfo/wiki/R-Style-Guide Style
 Guide by rdatsci] building on Google's and two others linked from the doc.

 The part where I stopped reading was "Assignment operator: Use = instead
 of <- for assignments." Sorry, you're out.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22689 [Core Tor/Tor]: hs: Stop rend and intro points being used as single hop proxies

[Tor Bug Tracker & Wiki]

#22689: hs: Stop rend and intro points being used as single hop proxies
--+
 Reporter:  teor  |  Owner:  dgoulet
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  relay-safety  |  Actual Points:
Parent ID:  #17945| Points:  0.5
 Reviewer:  teor  |Sponsor:
--+
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 I feel like we are spending too much time on this ticket, while it's not a
 priority and we are not sure what's the best way to do it. I'm marking it
 as needs_revision because of the recent discussion about DoS options.

 Perhaps we can revisit this in Rome and figure the best approach for
 handling and supporting 1-hop everything. I'm fine with delaying this to
 034 too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24229 [Metrics/Website]: Provide BGP Data Collection on Tor Metrics

[Tor Bug Tracker & Wiki]

#24229: Provide BGP Data Collection on Tor Metrics
-+---
 Reporter:  iwakeh   |  Owner:  iwakeh
 Type:  enhancement  | Status:  needs_information
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---

Comment (by iwakeh):

 Yes, I think `contrib` for all third-party contributions is the right
 choice!  Let's choose `bgp`, because it is short.

 Thus, we would have:

 Suggested file structure for external data provided by CollecTor:
 `https://collector.torproject.org/contrib/`

 The next level will consist of the third party main name, i.e., the path
 for BGP Data:
 `https://collector.torproject.org/contrib/bgp`

 Agreed, below the third party main level we can use whatever is provided
 by the contributing third-party, that is within reasonable naming
 conventions (sort of *nix server style).

 The official documentation will be a jsp file based on the provided
 documentation. The path for the documentation integrated to metrics.tp.o
 could be `https://metrics.torproject.org/contrib/bgp.html`, which will be
 linked from [https://metrics.torproject.org/sources.html#other Other
 sources].

 Next steps:
 * the jsp and referring links need to be created and
 * files need to be copied to the new structure below
 `https://collector.torproject.org/contrib/`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25393 [Metrics/Relay Search]: Integration of RelaySearch

[Tor Bug Tracker & Wiki]

#25393: Integration of RelaySearch
--+--
 Reporter:  iwakeh|  Owner:  metrics-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Metrics/Relay Search  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by iwakeh):

 Update from today's team meeting:
 RelaySearch should become a part of metrics-web and not be a stand-alone
 service anymore.

 Next steps:
 First work on the basics of #25392 submodule move, new ant tasks etc.
 Then find out which libraries etc. can be safely reused and adapt project
 structure.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22423 [Metrics/Website]: Refactor R code to use modern R packages and methods

[Tor Bug Tracker & Wiki]

#22423: Refactor R code to use modern R packages and methods
-+--
 Reporter:  johnbwilliams|  Owner:  metrics-team
 Type:  enhancement  | Status:  assigned
 Priority:  High |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * owner:  iwakeh => metrics-team
 * status:  merge_ready => assigned


Comment:

 Thanks for looking!

 Some functions still use the old code style, so I'd say let's leave this
 ticket open for now. I'll un-assign it, though, because I'm done for the
 moment. Feel free to grab it back.

 And yes, let's tackle the indentation stuff in #24707.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23136 [Applications/Tor Launcher]: moat integration (fetch bridges for the user)

[Tor Bug Tracker & Wiki]

#23136: moat integration (fetch bridges for the user)
+--
 Reporter:  mcs |  Owner:  brade
 Type:  defect  | Status:  needs_review
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Launcher   |Version:
 Severity:  Normal  | Resolution:
 Keywords:  TorBrowserTeam201803R, ux-team  |  Actual Points:
Parent ID:  #24689  | Points:
 Reviewer:  |Sponsor:  Sponsor4
+--

Comment (by mcs):

 I should have mentioned that we have not yet addressed items 1) and 2)
 from comment:49. The root cause of both problems is the same: we cannot do
 Moat things while tor has a meek client running. As I mentioned in
 comment:55, there is no simple solution for that issue.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23136 [Applications/Tor Launcher]: moat integration (fetch bridges for the user)

[Tor Bug Tracker & Wiki]

#23136: moat integration (fetch bridges for the user)
+--
 Reporter:  mcs |  Owner:  brade
 Type:  defect  | Status:  needs_review
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Launcher   |Version:
 Severity:  Normal  | Resolution:
 Keywords:  TorBrowserTeam201803R, ux-team  |  Actual Points:
Parent ID:  #24689  | Points:
 Reviewer:  |Sponsor:  Sponsor4
+--
Changes (by mcs):

 * status:  needs_revision => needs_review
 * keywords:  TorBrowserTeam201803, ux-team => TorBrowserTeam201803R, ux-
   team


Comment:

 A new patch that addresses the items found during review is here:
 https://gitweb.torproject.org/user/brade/tor-
 launcher.git/commit/?h=bug23136-05

 To see our recent changes, you can look at the "squash!" commits on
 brade's bug23136-04 branch:
 https://gitweb.torproject.org/user/brade/tor-
 launcher.git/log/?h=bug23136-04

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23136 [Applications/Tor Launcher]: moat integration (fetch bridges for the user)

[Tor Bug Tracker & Wiki]

#23136: moat integration (fetch bridges for the user)
---+---
 Reporter:  mcs|  Owner:  brade
 Type:  defect | Status:
   |  needs_revision
 Priority:  Very High  |  Milestone:
Component:  Applications/Tor Launcher  |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorBrowserTeam201803, ux-team  |  Actual Points:
Parent ID:  #24689 | Points:
 Reviewer: |Sponsor:  Sponsor4
---+---

Comment (by mcs):

 Replying to [comment:71 gk]:
 > Okay, three final items:
 >
 > 16) "in CMETHOD responses" -> "in CMETHOD response"

 Good catch.

 > 17)
 >
 > Do you mind flipping
 > {{{
 > version: this.kMoatVersion,
 > type: this.kMoatCheckRequestType,
 > }}}
 > to
 > {{{
 > type: this.kMoatCheckRequestType,
 > version: this.kMoatVersion,
 > }}}
 > in `finishFetch()` so that it conforms to the order outlined in the
 spec?

 Sure, we will make that change.

 > 18)
 >
 > Two points regarding your PT spec compliance:
 >
 > a) Setting `TOR_PT_STATE_LOCATION` is required according to the PT spec
 but is missing in `envAddidions`. Is that intentional? It seems it
 benefits from `meek` not caring about that and I wonder what to do. At
 least we should add a comment explaining why we deviate from the spec.

 Not setting that is an oversight on our part. The meek client doesn't use
 it, but it might in the future or maybe obfs4proxy in meek_lite mode needs
 it. We will add it.

 > b)
 > {{{
 >   if (proxyType == "socks4a")
 > this.mMeekClientProxyType = "socks4";
 >   else if (proxyType == "socks5")
 > this.mMeekClientProxyType = "socks";
 >   else
 > this.mMeekClientProxyType = proxyType;
 >
 > }}}
 > is overly lenient IMO. The spec states that the client talks some sort
 of SOCKS. Thus, we should make sure we get either SOCKS4 or SOCKS5 back
 and error out in case anything else shows up. So, probably something like
 this (taking the SOCKS 5 prioritization in the PT spec into account):
 > ...

 We will make the change you suggested. A new patch is coming soon!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25229 [Applications/Tor Browser]: Resist Spectre by using retpoline and a new instruction provided by Intel with microcode update

[Tor Bug Tracker & Wiki]

#25229: Resist Spectre by using retpoline and a new instruction provided by 
Intel
with microcode update
--+-
 Reporter:  cypherpunks   |  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  invalid
 Keywords:  tbb-security  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-
Changes (by cypherpunks):

 * status:  reopened => closed
 * resolution:   => invalid


Comment:

 > tjr: Landed a 2ms bump in nightly and beta; uplifting to ESR 52.7

 ... so just wait for the (already mitigated) mitigation to pass a
 handshake to the next TB release.

 Replying to [comment:4 cypherpunks]:
 > "Go piss up a rope, little cypherpunk." (c)
 Stop using
 [https://trac.torproject.org/projects/tor/ticket/22511#comment:12 nickm's
 licensed phrases] without prior permission. ;)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23169 [Metrics/Website]: Explain why metrics are important and what we do to make sure they're safe

[Tor Bug Tracker & Wiki]

#23169: Explain why metrics are important and what we do to make sure they're 
safe
-+--
 Reporter:  arma |  Owner:  irl
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:  iwakeh, karsten  |Sponsor:
-+--
Changes (by iwakeh):

 * reviewer:   => iwakeh, karsten


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23749 [Obfuscation/Snowflake]: Snowflake-client potentially suffers from memory leaks

[Tor Bug Tracker & Wiki]

#23749: Snowflake-client potentially suffers from memory leaks
---+---
 Reporter:  cypherpunks|  Owner:  (none)
 Type:  defect | Status:  closed
 Priority:  High   |  Milestone:
Component:  Obfuscation/Snowflake  |Version:
 Severity:  Major  | Resolution:  duplicate
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by arlolra):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Being fixed in #21312

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25272 [Obfuscation/Snowflake]: Research

[Tor Bug Tracker & Wiki]

#25272: Research
---+-
 Reporter:  justicefortheopressed  |  Owner:  (none)
 Type:  project| Status:  closed
 Priority:  Medium |  Milestone:
Component:  Obfuscation/Snowflake  |Version:
 Severity:  Normal | Resolution:  invalid
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by arlolra):

 * status:  new => closed
 * resolution:   => invalid


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22423 [Metrics/Website]: Refactor R code to use modern R packages and methods

[Tor Bug Tracker & Wiki]

#22423: Refactor R code to use modern R packages and methods
-+-
 Reporter:  johnbwilliams|  Owner:  iwakeh
 Type:  enhancement  | Status:  merge_ready
 Priority:  High |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by iwakeh):

 * status:  assigned => merge_ready


Comment:

 Well, it is merged already.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22423 [Metrics/Website]: Refactor R code to use modern R packages and methods

[Tor Bug Tracker & Wiki]

#22423: Refactor R code to use modern R packages and methods
-+--
 Reporter:  johnbwilliams|  Owner:  iwakeh
 Type:  enhancement  | Status:  assigned
 Priority:  High |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by iwakeh):

 Assuming the committed code already got tested regarding functionality and
 calculates the correct results I checked for readability and the like.
 The modernization makes all much more readable.  What hinders here and
 there is the line breaks and indentation, but that will be work after the
 style guide is settled (cf. #24707).

 Also the additional two commits look fine.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23169 [Metrics/Website]: Explain why metrics are important and what we do to make sure they're safe

[Tor Bug Tracker & Wiki]

#23169: Explain why metrics are important and what we do to make sure they're 
safe
-+--
 Reporter:  arma |  Owner:  irl
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+--
Changes (by irl):

 * status:  accepted => needs_review


Comment:

 Please review my branch [[https://gitweb.torproject.org/user/irl/metrics-
 web.git/log/?h=task/23169|task/21369]].

 I have added text to the home page and the about page to talk more about
 what Tor Metrics does and how it's safe. I've added vauge text about why
 metrics are important, but like the
 [[https://www.torproject.org/about/torusers.html.en|Who uses Tor?]] page I
 feel like this would be better coming from actual users of Tor metrics.
 This probably comes back to the "Add more testimonials" task from the
 roadmap.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25394 [Applications/Tor Browser]: Clean up projects/debootstrap-image/config

[Tor Bug Tracker & Wiki]

#25394: Clean up projects/debootstrap-image/config
-+-
 Reporter:  boklm|  Owner:  tbb-team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  TorBrowserTeam201803,
 Severity:  Normal   |  boklm201803
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 We should clean up `projects/debootstrap-image/config` to remove the
 distributions we don't use anymore, such as Ubuntu Precise.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25394 [Applications/Tor Browser]: Clean up projects/debootstrap-image/config

[Tor Bug Tracker & Wiki]

#25394: Clean up projects/debootstrap-image/config
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201803, boklm201803,   |  Actual Points:
  tbb-rbm|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * keywords:  TorBrowserTeam201803, boklm201803 => TorBrowserTeam201803,
 boklm201803, tbb-rbm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24707 [Metrics]: Define R coding guidelines for Metrics' products

[Tor Bug Tracker & Wiki]

#24707: Define R coding guidelines for Metrics' products
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by iwakeh):

 Stumbled upon some R style guides:

 * [http://style.tidyverse.org/ tidyverse] has also packages supporting the
 styles.
 * [https://google.github.io/styleguide/Rguide.xml Google's R Style] on
 which many others build
 * [https://github.com/rdatsci/PackagesInfo/wiki/R-Style-Guide Style Guide
 by rdatsci] building on Google's and two others linked from the doc.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25126 [Applications/Tor Browser]: about:tor should work on small screens (mobile)

[Tor Bug Tracker & Wiki]

#25126: about:tor should work on small screens (mobile)
-+-
 Reporter:  igt0 |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,TorBrowserTeam201802R  |  Actual Points:
Parent ID:  #24855   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-torbutton,TorBrowserTeam201802 => tbb-
 torbutton,TorBrowserTeam201802R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25013 [Applications/Tor Browser]: Move TorButton code to the tor browser repository

[Tor Bug Tracker & Wiki]

#25013: Move TorButton code to the tor browser repository
--+--
 Reporter:  igt0  |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201802R |  Actual Points:
Parent ID:  #24855| Points:
 Reviewer:  gk, sysrqb, mcs,  |Sponsor:
--+--
Changes (by gk):

 * keywords:  TorBrowserTeam201802 => TorBrowserTeam201802R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201802,|  Actual Points:
  TorBrowserTeam201803   |
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm, boklm201802, TorBrowserTeam201802R => tbb-rbm,
 boklm201802, TorBrowserTeam201803


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25287 [Metrics/Website]: update URL for TorDNSEL

[Tor Bug Tracker & Wiki]

#25287: update URL for TorDNSEL
-+--
 Reporter:  cypherpunks  |  Owner:  metrics-team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Updated the first part, attempted to do the right thing for the second
 part. Closing. Please re-open or open a new ticket for more changes/fixes.
 Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25339 [Applications/Tor Browser]: Install python 3.6 for building HTTPS-Everywhere

[Tor Bug Tracker & Wiki]

#25339: Install python 3.6 for building HTTPS-Everywhere
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803,   |  Actual Points:
  boklm201802|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm, TorBrowserTeam201802R, boklm201802 => tbb-rbm,
 TorBrowserTeam201803, boklm201802
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:3 boklm]:
 > There is a patch for review in branch `bug_25339_v2`, using `buster` to
 build https-everywhere:
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_25339_v2=734a41c0f986989163ff7536ff84a2a03e00d5cc
 >
 > However `buster` is not a stable release yet, so I am wondering how
 likely it is that an update, for instance on the `zip` package, would
 break the reproducibility of the build. Ubuntu Artful is a stable release,
 so it might be less likely to have big updates.

 Yes, that's true. However we would need to look for yet another solution
 to this bug in about three months as Ubuntu Artful is EOL in July 2018,
 not ideal. If you feel strongly here I am fine building Python 3.6 from
 source for 64bit Linux in the same container used for HTTPS-Everywhere. I
 feel the risk of breaking the reproducibility of HTTPS-Everywhere with
 `buster` is not very high given that it is "just" an extension. Either way
 I want to test the new process in an alpha anyway first (shipping the
 stable one time with a not up-to-date HTTPS-Everywhere seems to me
 acceptable given that we need to test a new build method in our
 environment first).

 Looking at the patch we don't need the 32bit `buster` in the debootstrap
 config. Could you remove that part? Oh, and we might want to clean that
 config up anyway (in a different bug/commit) as there are still Ubuntu
 Precise things among others in it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25392 [Metrics/Website]: Adapt Relay Search integration to Metrics' project standards

[Tor Bug Tracker & Wiki]

#25392: Adapt Relay Search integration to Metrics' project standards
-+--
 Reporter:  iwakeh   |  Owner:  iwakeh
 Type:  defect   | Status:  accepted
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by iwakeh):

 See also #25393.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25392 [Metrics/Website]: Adapt Relay Search integration to Metrics' project standards

[Tor Bug Tracker & Wiki]

#25392: Adapt Relay Search integration to Metrics' project standards
-+--
 Reporter:  iwakeh   |  Owner:  iwakeh
 Type:  defect   | Status:  accepted
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by iwakeh):

 * owner:  metrics-team => iwakeh
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25393 [Metrics/Relay Search]: Integration of RelaySearch

[Tor Bug Tracker & Wiki]

#25393: Integration of RelaySearch
--+--
 Reporter:  iwakeh|  Owner:  metrics-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Metrics/Relay Search  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by iwakeh):

 * component:  Metrics/Website => Metrics/Relay Search


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25393 [Metrics/Website]: Integration of RelaySearch

[Tor Bug Tracker & Wiki]

#25393: Integration of RelaySearch
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+--
 RelaySearch (former Atlas) recently was integrated into Metrics code bases
 more tightly.  It is working fine, but should be adapted more to
 facilitate better maintenance in future.

 One question that needs to be decided:

 Should RelaySearch be developed as a part of metrics.tp.o that can also be
 served stand-alone, which is the current situation or just as a part of
 metrics.tp.o?
 The latter would reduce the amount of files and maintenance for
 RelaySearch once the integration is completed, as it currently duplicates
 many parts of metrics-web (fonts, css partially, etc), which will cost
 more maintenance in future.

 This ticket should serve for the discussion of the above question and for
 deriving the next necessary steps.
 (There is also a related ticket for metrics-web, see #25392)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25392 [Metrics/Website]: Adapt Relay Search integration to Metrics' project standards

[Tor Bug Tracker & Wiki]

#25392: Adapt Relay Search integration to Metrics' project standards
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+--
 RelaySearch integration needs some tuning and streamlining:
 First steps

 1. Move from `src/main/resources/web/rs` into `src/submods/relaysearch`
 2. Only include fonts once into the war file (currently these are
 duplicated)
 3. Avoid including readme files and scripts that are not needed for the
 running web application into the war file.
 4. Separate preparation steps inside RelaySearch from building the war.
 5. Create an Ant task that prepares RelaySearch for war file inclusion and
 adds the needed files to the war file.

 More tasks should be added as comments.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23830 [Metrics/Website]: Update README to get a development environment for metrics-web going

[Tor Bug Tracker & Wiki]

#23830: Update README to get a development environment for metrics-web going
-+--
 Reporter:  irl  |  Owner:  metrics-team
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:  implemented
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by iwakeh):

 * status:  new => closed
 * resolution:   => implemented


Comment:

 I think this is obsolete now as Relay Search is integrated into
 metrics.torproject.org and can be closed now.

 Please reopen, if there are any unresolved issues left.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23136 [Applications/Tor Launcher]: moat integration (fetch bridges for the user)

[Tor Bug Tracker & Wiki]

#23136: moat integration (fetch bridges for the user)
---+---
 Reporter:  mcs|  Owner:  brade
 Type:  defect | Status:
   |  needs_revision
 Priority:  Very High  |  Milestone:
Component:  Applications/Tor Launcher  |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorBrowserTeam201803, ux-team  |  Actual Points:
Parent ID:  #24689 | Points:
 Reviewer: |Sponsor:  Sponsor4
---+---
Changes (by gk):

 * keywords:  TorBrowserTeam201802R, ux-team => TorBrowserTeam201803, ux-
   team
 * status:  needs_review => needs_revision


Comment:

 Okay, three final items:

 16) "in CMETHOD responses" -> "in CMETHOD response"

 17)

 Do you mind flipping
 {{{
 version: this.kMoatVersion,
 type: this.kMoatCheckRequestType,
 }}}
 to
 {{{
 type: this.kMoatCheckRequestType,
 version: this.kMoatVersion,
 }}}
 in `finishFetch()` so that it conforms to the order outlined in the spec?

 18)

 Two points regarding your PT spec compliance:

 a) Setting `TOR_PT_STATE_LOCATION` is required according to the PT spec
 but is missing in `envAddidions`. Is that intentional? It seems it
 benefits from `meek` not caring about that and I wonder what to do. At
 least we should add a comment explaining why we deviate from the spec.

 b)
 {{{
   if (proxyType == "socks4a")
 this.mMeekClientProxyType = "socks4";
   else if (proxyType == "socks5")
 this.mMeekClientProxyType = "socks";
   else
 this.mMeekClientProxyType = proxyType;

 }}}
 is overly lenient IMO. The spec states that the client talks some sort of
 SOCKS. Thus, we should make sure we get either SOCKS4 or SOCKS5 back and
 error out in case anything else shows up. So, probably something like this
 (taking the SOCKS 5 prioritization in the PT spec into account):
 {{{
 if (proxyType == "socks5") {
   this.mMeekClientProxyType = "socks";
 } else if ((proxyType == "socks4a") || (proxyType == "socks4")) {
   this.mMeekClientProxyType = "socks4";
 } else {
   errMsg = "Unexpected proxy type " + proxyType + " in CMETHOD response."
   break;
 }
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22423 [Metrics/Website]: Refactor R code to use modern R packages and methods

[Tor Bug Tracker & Wiki]

#22423: Refactor R code to use modern R packages and methods
-+--
 Reporter:  johnbwilliams|  Owner:  iwakeh
 Type:  enhancement  | Status:  assigned
 Priority:  High |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by karsten):

 FWIW, I just pushed two more commits to master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25383 [Metrics/Website]: Deprecate stats.html and stats/*.csv files

[Tor Bug Tracker & Wiki]

#25383: Deprecate stats.html and stats/*.csv files
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by karsten):

 Replying to [comment:3 irl]:
 > #25240 is the relevant ticket, with the idea being to add some tweets to
 metrics-bot about the number of users. It sounds to me that the new graph
 based ones are better for this use case than the raw files under stats/.
 >
 > A few questions though:
 >
 > * Would we update stats.html to describe the format of the new CSV files
 along with the API for retrieving them programmatically?

 Ideally, the new CSV files won't need as much description as the old ones.
 Column names are chosen in reference to graphs, units are the same as in
 the graph, parameters are the same as for the graph, and so on. The
 current plan is to include a short comment header in the CSV files, see
 #25387. Ideally, we wouldn't have to write and maintain another HTML page
 for that. It's yet one more thing we need to write whenever we want to
 provide a new graph, and we'd want to make it easier to add new graphs,
 not harder.

 > * Do we describe how we get from CollecTor to the new graph based CSV
 files (which would include the steps necessary for getting to the
 stats/*.csv files)?

 Yes, this is still relevant. And this deserves a HTML page somewhere.
 Could be stats.html or a new page.

 > I'm not opposed to removing them from the website for the reason that I
 feel they are intermediate artefacts of the analysis/visualisation
 process, as long as we are not creating them with secret data that would
 not be accessible to others (afaik it's all in CollecTor) and as long as
 we describe our process.
 >
 > For most use cases I think the graph based CSV files are going to be
 easier for new researchers to get started with anyway.

 Sounds good!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25383 [Metrics/Website]: Deprecate stats.html and stats/*.csv files

[Tor Bug Tracker & Wiki]

#25383: Deprecate stats.html and stats/*.csv files
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by karsten):

 Replying to [comment:2 joss]:
 > I might be almost unique in this, but I do actively use the existing
 full user metric .csv files for the infolabe-anomalies mailing list
 (). This is
 carrying out anomaly detection on a nightly basis looking at user numbers.
 >
 > I'm not entirely sure to what extent this data would still be available
 under the proposed change. I'm fine to update my code a bit to change
 URLs, etc, but if the data disappeared entirely it would harm some of my
 research quite considerably.
 >
 > In a more general sense, I'd strongly advocate for an 'open data'
 principle. You never know what research the next person coming along might
 do, and what it might contribute. At the moment it's a simple curl/wget to
 get that data -- if I had to wrangle a web interface as a precondition to
 carrying out analysis on Tor metrics then it would (possibly) be extremely
 awkward.
 >
 > Again, though, maybe I'm misunderstanding the proposed changes.

 Your use case is special, yet we should make sure it's supported.

 FWIW, you wouldn't have to fight with web interfaces to get the data, as
 the new CSV files are also available via curl/wget, just with optional
 parameters.

 But it might be that none of the new CSV files has all the data you want.
 We should fix that and ensure that your use case continues to work even
 after taking down the old CSV files.

 Needs more thinking. Thanks for bringing this up!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25389 [Applications/Tor Browser]: backport Subprocess.jsm runaway CPU fix (Mozilla 1370027)

[Tor Bug Tracker & Wiki]

#25389: backport Subprocess.jsm runaway CPU fix (Mozilla 1370027)
--+--
 Reporter:  mcs   |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  TorBrowserTeam201802R |  Actual Points:
Parent ID:  #24689| Points:
 Reviewer:|Sponsor:  Sponsor4
--+--
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Nice find! Looks good and fixes the issue on my end as well. Pushed to
 `tor-browser-52.6.0esr-8.0-2` (commit
 f7e0d580f4159357cfa3dc69cb9ed4d9027e9b9f).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs