Re: [tor-bugs] #24629 [Core Tor/Tor]: Activate osx builds on travis, at low priority

2018-07-26 Thread Tor Bug Tracker & Wiki
#24629: Activate osx builds on travis, at low priority
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  not-just-linux, tor-ci, teor-was-|  Actual Points:
  assigned, 034-triage-20180328, |
  034-removed-20180328, 034-backport,|
  035-removed-20180711, fast-fix |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  needs_revision => needs_review


Comment:

 i386 macOS builds were really complex, so I didn't set them up. I'm happy
 to proceed with rust building on x86_64 for now.

 Please see my branch travis-osx-v8 on https://github.com/teor2345/tor.git

 Travis CI is at:
 https://travis-ci.org/teor2345/tor/builds/408372308

 Replying to [comment:19 teor]:
 > I rewrote and simplified the build matrix.
 >
 > We have the following builds on all platforms (Linux, macOS) and
 compilers (gcc, clang):
 > * no Rust (with hardening, which is the default)
 > * Rust online (without hardening due to #25386/#26398)
 >
 > We have the following builds on Linux gcc:
 > * coverage
 > * no hardening
 > * distcheck
 > * disable module dirauth
 > * Rust offline (without hardening due to #25386/#26398)
 > * distcheck with Rust online (without hardening due to #25386/#26398)
 > * disable module dirauth with Rust online (without hardening due to
 #25386/#26398)
 >
 > That gives us 15 builds rather than the previous 13, so CI should
 complete in a similar time. (I'm seeing 5 builders allocated at a time
 when building this branch.)

 The previous commit on master ran for 29 minutes:
 https://travis-ci.org/torproject/tor/builds/408312564

 These new builds ran for 24 minutes.
 So I think we're fine.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25669 [Core Tor/Tor]: Privcount: blinding and encryption should be finished up

2018-07-26 Thread Tor Bug Tracker & Wiki
#25669: Privcount: blinding and encryption should be finished up
-+-
 Reporter:  nickm|  Owner:  teor
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #22898   | Points:
 Reviewer:   |Sponsor:
 |  SponsorV-can
-+-
Changes (by teor):

 * owner:  (none) => teor
 * status:  needs_revision => assigned


Comment:

 This is mine now, for revision

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25669 [Core Tor/Tor]: Privcount: blinding and encryption should be finished up

2018-07-26 Thread Tor Bug Tracker & Wiki
#25669: Privcount: blinding and encryption should be finished up
-+-
 Reporter:  nickm|  Owner:  teor
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #22898   | Points:
 Reviewer:   |Sponsor:
 |  SponsorV-can
-+-
Changes (by teor):

 * status:  assigned => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26939 [Core Tor/Tor]: Privcount blinding and encryption: type fixes

2018-07-26 Thread Tor Bug Tracker & Wiki
#26939: Privcount blinding and encryption: type fixes
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  privcount, 035-roadmap-master, 035
 Severity:  Normal   |  -triaged-in-20180711, rust
Actual Points:   |  Parent ID:  #25669
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Type fixes from
 https://trac.torproject.org/projects/tor/ticket/25669#comment:15

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26940 [Core Tor/Tor]: Privcount blinding and encryption: doc fixes

2018-07-26 Thread Tor Bug Tracker & Wiki
#26940: Privcount blinding and encryption: doc fixes
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  privcount, 035-roadmap-master, 035
 Severity:  Normal   |  -triaged-in-20180711, rust
Actual Points:   |  Parent ID:  #25669
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Doc fixes from
 https://trac.torproject.org/projects/tor/ticket/25669#comment:15

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26941 [Core Tor/Tor]: Privcount blinding and encryption: review dependencies

2018-07-26 Thread Tor Bug Tracker & Wiki
#26941: Privcount blinding and encryption: review dependencies
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  privcount, 035-roadmap-master, 035
 Severity:  Normal   |  -triaged-in-20180711, rust
Actual Points:   |  Parent ID:  #25669
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 External dependency review from
 https://trac.torproject.org/projects/tor/ticket/25669#comment:15

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26942 [Core Tor/Tor]: Privcount blinding and encryption: Rust code conventions

2018-07-26 Thread Tor Bug Tracker & Wiki
#26942: Privcount blinding and encryption: Rust code conventions
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  privcount, 035-roadmap-master, 035
 Severity:  Normal   |  -triaged-in-20180711, rust
Actual Points:   |  Parent ID:  #25669
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Rust code convention fixes from
 https://trac.torproject.org/projects/tor/ticket/25669#comment:15

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26943 [Core Tor/Tor]: Privcount blinding and encryption: Safety fixes

2018-07-26 Thread Tor Bug Tracker & Wiki
#26943: Privcount blinding and encryption: Safety fixes
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  privcount, 035-roadmap-master, 035
 Severity:  Normal   |  -triaged-in-20180711, rust
Actual Points:   |  Parent ID:  #25669
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Safety fixes from
 https://trac.torproject.org/projects/tor/ticket/25669#comment:15

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26944 [Core Tor/Tor]: Privcount blinding and encryption: Add tests

2018-07-26 Thread Tor Bug Tracker & Wiki
#26944: Privcount blinding and encryption: Add tests
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  privcount, 035-roadmap-master, 035
 Severity:  Normal   |  -triaged-in-20180711, rust
Actual Points:   |  Parent ID:  #25669
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Add tests as recommended in
 https://trac.torproject.org/projects/tor/ticket/25669#comment:15

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26945 [Core Tor/Tor]: Privcount blinding and encryption: Conditionally disable i128

2018-07-26 Thread Tor Bug Tracker & Wiki
#26945: Privcount blinding and encryption: Conditionally disable i128
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  privcount, 035-roadmap-master, 035
 Severity:  Normal   |  -triaged-in-20180711, rust
Actual Points:   |  Parent ID:  #25669
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 See https://trac.torproject.org/projects/tor/ticket/25669#comment:12

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26946 [Core Tor/Tor]: Privcount blinding and encryption: warning fixes

2018-07-26 Thread Tor Bug Tracker & Wiki
#26946: Privcount blinding and encryption: warning fixes
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  privcount, 035-roadmap-master, 035
 Severity:  Normal   |  -triaged-in-20180711, rust
Actual Points:   |  Parent ID:  #25669
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 privcount_shamir builds and tests ok, but has a few warnings.

 Split off #25669.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26946 [Core Tor/Tor]: Privcount blinding and encryption: warning fixes

2018-07-26 Thread Tor Bug Tracker & Wiki
#26946: Privcount blinding and encryption: warning fixes
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  assigned => needs_review


Comment:

 Please see my branch bug26946 at
 https://github.com/teor2345/privcount_shamir.git

 It includes changes from rustfmt, #26942, and #26946.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26942 [Core Tor/Tor]: Privcount blinding and encryption: Rust code conventions

2018-07-26 Thread Tor Bug Tracker & Wiki
#26942: Privcount blinding and encryption: Rust code conventions
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Please see my branch bug26946 at
 https://github.com/teor2345/privcount_shamir.git

 It includes changes from rustfmt, #26942, and #26946.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26942 [Core Tor/Tor]: Privcount blinding and encryption: Rust code conventions

2018-07-26 Thread Tor Bug Tracker & Wiki
#26942: Privcount blinding and encryption: Rust code conventions
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26641 [Applications/Tor Browser]: problema con l'apertura di siti onion

2018-07-26 Thread Tor Bug Tracker & Wiki
#26641: problema con l'apertura di siti onion
--+--
 Reporter:  rossicè46 |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by rossicè46):

 grazie mille per la disponibilità, e la pazienza ma in realtà nella
 cartella Application Support non c'è la cartella TorBrowser-Data ma solo
 l'applicazione TorBrowser,
 per quanto riguarda i siti della lista che mi hai fornito non mi
 funzionano neanche uno.
 grazie ancora

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26401 [Applications/Tor Browser]: Rebase Orfox patches onto Tor Browser 8.0 for TBA

2018-07-26 Thread Tor Bug Tracker & Wiki
#26401: Rebase Orfox patches onto Tor Browser 8.0 for TBA
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  task  | Status:
  |  needs_review
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201807  |  Actual Points:
Parent ID:  #26531| Points:
 Reviewer:|Sponsor:
--+

Comment (by gk):

 Replying to [comment:34 sysrqb]:
 > Replying to [comment:32 sysrqb]:
 > > I'm worried about only using a pref for deciding if the app should
 update itself or something else installs updates (such as an app store).
 Although it seems Google are not currently enforcing this, Google Play's
 policy says apps should not be able to update themselves - so having a
 toggle-able pref seems risky.
 > I take this back, I think we can accomplish this without much risk
 (Google Play's only says we can't update the app, but it doesn't say the
 app must not be capable of updating itself). #26528 may give us what we
 need for this.

 That's what I had in mind, yes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24629 [Core Tor/Tor]: Activate osx builds on travis, at low priority

2018-07-26 Thread Tor Bug Tracker & Wiki
#24629: Activate osx builds on travis, at low priority
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  not-just-linux, tor-ci, teor-was-|  Actual Points:
  assigned, 034-triage-20180328, |
  034-removed-20180328, 034-backport,|
  035-removed-20180711, fast-fix |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-

Comment (by Hello71):

 Replying to [comment:19 teor]:
 > Please see my branch travis-osx-v7 on
 https://github.com/teor2345/tor.git
 >
 > I rewrote and simplified the build matrix.
 >
 > We have the following builds on all platforms (Linux, macOS) and
 compilers (gcc, clang):
 > * no Rust (with hardening, which is the default)
 > * Rust online (without hardening due to #25386/#26398)
 >
 > We have the following builds on Linux gcc:
 > * coverage
 > * no hardening
 > * distcheck
 > * disable module dirauth
 > * Rust offline (without hardening due to #25386/#26398)
 > * distcheck with Rust online (without hardening due to #25386/#26398)
 > * disable module dirauth with Rust online (without hardening due to
 #25386/#26398)
 >
 > That gives us 15 builds rather than the previous 13, so CI should
 complete in a similar time.

 overall, I like this. I'm not super convinced that we need all these
 miscellaneous builds, e.g. no hardening when we already have Rust without
 hardening, but I guess they could help diagnose some CI failures, and I
 think we're far from exceeding the total maximum jobs.

 > (I'm seeing 5 builders allocated at a time when building this branch.)

 unfortunately, I can't find where I found this information, but I believe
 the maximum at the time that I wrote "4/6" and "2/6" was the lower of: 5
 Linux jobs, 2 Mac jobs, 6 total jobs (at any given time). therefore,
 adding Mac jobs and decreasing Linux jobs is expected to lower the total
 time.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23713 [Metrics/Onionoo]: Expand parameters and fields around AS number and names

2018-07-26 Thread Tor Bug Tracker & Wiki
#23713: Expand parameters and fields around AS number and names
-+--
 Reporter:  cypherpunks  |  Owner:  karsten
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  irl  |Sponsor:
-+--
Changes (by irl):

 * reviewer:   => irl


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23549 [Metrics/Website]: Move ExoneraTorServlet to metrics-web

2018-07-26 Thread Tor Bug Tracker & Wiki
#23549: Move ExoneraTorServlet to metrics-web
-+--
 Reporter:  karsten  |  Owner:  karsten
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * status:  assigned => needs_review


Comment:

 Replying to [comment:14 karsten]:
 > Alright, looking more into the thin jar option. Thanks for commenting!

 Please review the metrics-base patch that I'm going to attach to this
 ticket in a second. It's going to create `*-thin.jar` files with the same
 contents as the `*.jar` file except for the dependencies that are not
 included here. I didn't manage to teach Ant not to produce such a thin jar
 file for metrics-lib, which by default already produces just a thin file,
 but I figured it might not even hurt to have both thin and fat jar files
 for metrics-lib. We'll just have to say so in the next metrics-lib change
 log.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23549 [Metrics/Website]: Move ExoneraTorServlet to metrics-web

2018-07-26 Thread Tor Bug Tracker & Wiki
#23549: Move ExoneraTorServlet to metrics-web
-+--
 Reporter:  karsten  |  Owner:  karsten
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * Attachment "0001-Add-new-thin.jar-file-without-dependencies.patch"
 added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25448 [Metrics/Onionoo]: allow for URLs that specify list of fingerprints

2018-07-26 Thread Tor Bug Tracker & Wiki
#25448: allow for URLs that specify list of fingerprints
-+
 Reporter:  cypherpunks  |  Owner:  karsten
 Type:  enhancement  | Status:  closed
 Priority:  Low  |  Milestone:  Onionoo 1.16.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Minor| Resolution:  implemented
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  irl  |Sponsor:
-+
Changes (by karsten):

 * status:  merge_ready => closed
 * resolution:   => implemented
 * milestone:   => Onionoo 1.16.0


Comment:

 Cool! Merged to master. Adding to the Onionoo 1.16.0 milestone as a
 reminder to document the change in metrics-web when putting out the next
 release. Closing. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23549 [Metrics/Website]: Move ExoneraTorServlet to metrics-web

2018-07-26 Thread Tor Bug Tracker & Wiki
#23549: Move ExoneraTorServlet to metrics-web
-+
 Reporter:  karsten  |  Owner:  karsten
 Type:  enhancement  | Status:  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by irl):

 * status:  needs_review => needs_revision


Comment:

 This patch looks good to me.

 Perhaps now there is a plan it is better to start again with a new ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26947 [Core Tor/Tor]: Add function for reporting the tor version in tor_api.h

2018-07-26 Thread Tor Bug Tracker & Wiki
#26947: Add function for reporting the tor version in tor_api.h
--+
 Reporter:  hellais   |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:  #25510
   Points:|   Reviewer:
  Sponsor:|
--+
 As a user of libtor_api it would be useful for me to be able to obtain the
 version of tor without having to call it's main function.

 The function could look something like:

 {{{
 const char * tor_version()
 {
 return tor_version_string;
 }
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25510 [Core Tor/Tor]: Collect feedback on mobile embedding API; resolve issues.

2018-07-26 Thread Tor Bug Tracker & Wiki
#25510: Collect feedback on mobile embedding API; resolve issues.
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  project  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  roadmap, 035-roadmap-master, |  Actual Points:
  034-triage-20180328, 034-included-20180328,|
  035-triaged-in-20180711|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8-must
-+-

Comment (by hellais):

 I started the new tor_api.h and have been chatting with ahf on IRC about
 this.

 Here is how far I got with testing it.

 == Setup

 First, to setup an environment for testing I needed to build it as a
 shared library.

 This was done by building tor with `make V=1 CFLAGS=-fPIC`.

 I then deleted `src/app/tor`, re-ran `make V=1 CFLAGS=-fPIC` and reran
 that line adding `-shared` to it. That lead me to having a `dylib` (or
 `.so` on linux) in `src/app/tor`.

 This artifact can now be used for testing libtor.

 == Testing

 I wrote a testing harness that uses python and `cffi`, to implement some
 basic smoke tests for libtor. This can be found here:
 https://gist.github.com/hellais/b56043d57eb5be885958e80b3665bfe2 (to run
 it do `pip install cffi` and change the `LIB_PATH` to the correct path).

 In particular by adding the command line flag `--version` and starting
 tor, I am unable to re-start it due to the exception listed in the above
 gist.

 == Feedback

 WRT API design I have the following thoughts on possible areas for
 improvement. I have for the time being only created tickets for the things
 I think should be part of an MVP, while the others can possibly be
 deferred to a future version and if you think they are good ideas I will
 proceed with creating tickets for them.
 I may also be missing some best practice here.

 * Add function for reporting the tor version -
 https://trac.torproject.org/projects/tor/ticket/26947

 * Ability to know when the control port is ready

 Currently it's not possible for a user of the API to know when the control
 port is ready if not by looking at the standard output and/or polling the
 port/socket where the control port is supposed to be at. It would be great
 if there were some function (or some documented approach) to doing this.

 * Ability to get the output of tor_run_main() without having to mock
 standard out

 There is a wealth of information inside of the log output of tor, which
 would be nice if it were exposed in a more API friendly way (maybe some
 sort of callback function?) so that a user of the library doesn't have to
 mock stdout/stderr.

 * Ability to terminate tor cleanly without using the control port

 I am aware of the fact that there is a control port command to stop tor,
 but it would be great if there were also an API call to be used to tell
 tor to shutdown cleanly (similarly to calling kill -SIGTERM tor).

 * Add API calls for making it easier to setup the configuration for tor

 This is more of usability issue, but it would be great if the tor_api.h
 has some function for setting configuration options for Tor, without
 having to rely on passing them as command line arguments.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26947 [Core Tor/Tor]: Add function for reporting the tor version in tor_api.h

2018-07-26 Thread Tor Bug Tracker & Wiki
#26947: Add function for reporting the tor version in tor_api.h
--+
 Reporter:  hellais   |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #25510| Points:
 Reviewer:|Sponsor:
--+
Description changed by hellais:

Old description:

> As a user of libtor_api it would be useful for me to be able to obtain
> the version of tor without having to call it's main function.
>
> The function could look something like:
>
> {{{
> const char * tor_version()
> {
> return tor_version_string;
> }
> }}}

New description:

 As a user of libtor_api it would be useful for me to be able to obtain the
 version of tor without having to call it's main function.

 The function could look something like:

 {{{
 const char * tor_version()
 {
 return tor_version_string;
 }
 }}}

 This would be very useful for a user of the library that wishes to check
 if they have linked to the right tor version (or implement some sanity
 checks) without having to start tor and then speak to it on the control
 port (therefore paying some significant overhead).

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26948 [Core Tor/Tor]: tor_run_main crashes when called a second time with --version

2018-07-26 Thread Tor Bug Tracker & Wiki
#26948: tor_run_main crashes when called a second time with --version
--+
 Reporter:  hellais   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:  #25510
   Points:|   Reviewer:
  Sponsor:|
--+
 I wrote a testing harness that uses python and cffi, to implement some
 basic smoke tests for libtor. This can be found here:
 ​https://gist.github.com/hellais/b56043d57eb5be885958e80b3665bfe2 (to run
 it do pip install cffi and change the LIB_PATH to the correct path).

 In particular by adding the command line flag --version and starting tor,
 I am unable to re-start it due to the exception listed in the above gist.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26807 [Obfuscation/Censorship analysis]: Venezuela blocks access to the Tor network

2018-07-26 Thread Tor Bug Tracker & Wiki
#26807: Venezuela blocks access to the Tor network
-+-
 Reporter:  ptdetector   |  Owner:  dcf
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/Censorship analysis  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by ptdetector):

 //A group of blind men heard that a strange animal, called an elephant,
 had been brought to the town, but none of them were aware of its shape and
 form. Out of curiosity, they said: "We must inspect and know it by touch,
 of which we are capable". So, they sought it out, and when they found it
 they groped about it. In the case of the first person, whose hand landed
 on the trunk, said "This being is like a thick snake". For another one
 whose hand reached its ear, it seemed like a kind of fan. As for another
 person, whose hand was upon its leg, said, the elephant is a pillar like a
 tree-trunk. The blind man who placed his hand upon its side said,
 "elephant is a wall". Another who felt its tail, described it as a rope.
 The last felt its tusk, stating the elephant is that which is hard, smooth
 and like a spear.//

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26892 [Core Tor/Tor]: log_addr_has_changed() does not heed SafeLogging

2018-07-26 Thread Tor Bug Tracker & Wiki
#26892: log_addr_has_changed() does not heed SafeLogging
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-log   |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+
Changes (by rl1987):

 * status:  needs_revision => needs_review


Comment:

 https://github.com/torproject/tor/pull/249

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26401 [Applications/Tor Browser]: Rebase Orfox patches onto Tor Browser 8.0 for TBA

2018-07-26 Thread Tor Bug Tracker & Wiki
#26401: Rebase Orfox patches onto Tor Browser 8.0 for TBA
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  task  | Status:
  |  needs_revision
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201807  |  Actual Points:
Parent ID:  #26531| Points:
 Reviewer:|Sponsor:
--+
Changes (by gk):

 * status:  needs_review => needs_revision


Comment:

 Okay, we are getting close, just the following comments/remarks are left:

 commit 0b932f895e3b2866161048a6007e61e257dc395b -- not okay

 There is no need for a `--enable-install-strip` as we already strip
 everything with `--enable-strip`.

 commit 408e63083f15d59c98fee619a277dfe123429d8c -- not okay

 we should follow the Android version as used in the resist fingerprinting
 mode, see:

 https://dxr.mozilla.org/mozilla-
 
esr60/source/browser/components/resistfingerprinting/test/browser/browser_navigator.js

 I.e. "Android 4.1.0" > "Android 6.0" which is way more popuplar than 4.1.0
 as well.

 commit 7bc689d797439d6394853e421f71eda5d7d1631a -- not okay

 +import android.content.IntentFilter; <- seems to be something not used
 (probably part of the NetCipher upgrade on the previous branch?)

 `checkStartOrbot()` came before `processTabQueue()` before (and the if-
 clause around `!mHasResumed` got deleted). Doesn't the order matter here?
 (I don't know just for double-checking)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21900 [Core Tor/Tor]: evdns fails when resolv.conf is missing, but succeeds when resolv.conf is empty

2018-07-26 Thread Tor Bug Tracker & Wiki
#21900: evdns fails when resolv.conf is missing, but succeeds when resolv.conf 
is
empty
-+-
 Reporter:  teor |  Owner:  rl1987
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  technical-debt, dns, crash, tor- |  Actual Points:
  relay, macos, 032-unreached|
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+-
Changes (by rl1987):

 * owner:  (none) => rl1987
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23846 [Core Tor/Tor]: Use libtool for building shared library

2018-07-26 Thread Tor Bug Tracker & Wiki
#23846: Use libtool for building shared library
-+-
 Reporter:  hellais  |  Owner:  sbs
 Type:  enhancement  | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-mobile, s8-api,  |  Actual Points:
  034-triage-20180328, 034-included-20180402,|
  034-roadmap-subtask, 035-roadmap-subtask, 035  |
  -triaged-in-20180711   |
Parent ID:  #25510   | Points:
 Reviewer:  ahf  |Sponsor:
 |  Sponsor8
-+-

Comment (by hellais):

 For the purpose of testing I didn't end up using this branch as it's quite
 tricky to have it work with the latest master.

 It would be great if these patches could be forward ported to the latest
 master so we can easily build a shared library with libtool.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26949 [Applications/Tor Browser]: STIX moved away from SourceForge to Github breaking download during Tor Browser build

2018-07-26 Thread Tor Bug Tracker & Wiki
#26949: STIX moved away from SourceForge to Github breaking download during Tor
Browser build
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  tbb-rbm,
 Severity:  Normal   |  TorBrowserTeam201807
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 It seems we need to update the location of `STIX` in order to unbreak
 building Tor Browser with `tor-browser-build`, see:
 https://lists.torproject.org/pipermail/tor-dev/2018-July/013357.html.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26949 [Applications/Tor Browser]: STIX moved away from SourceForge to Github breaking download during Tor Browser build

2018-07-26 Thread Tor Bug Tracker & Wiki
#26949: STIX moved away from SourceForge to Github breaking download during Tor
Browser build
---+--
 Reporter:  gk |  Owner:  tbb-team
 Type:  defect | Status:  new
 Priority:  High   |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201807  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by sukhbir):

 * cc: sukhbir (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26401 [Applications/Tor Browser]: Rebase Orfox patches onto Tor Browser 8.0 for TBA

2018-07-26 Thread Tor Bug Tracker & Wiki
#26401: Rebase Orfox patches onto Tor Browser 8.0 for TBA
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  task  | Status:
  |  needs_revision
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201807  |  Actual Points:
Parent ID:  #26531| Points:
 Reviewer:|Sponsor:
--+

Comment (by sysrqb):

 Replying to [comment:36 gk]:
 > Okay, we are getting close, just the following comments/remarks are
 left:
 >
 > commit 0b932f895e3b2866161048a6007e61e257dc395b -- not okay
 >
 > There is no need for a `--enable-install-strip` as we already strip
 everything with `--enable-strip`.
 >

 Okay.

 > commit 408e63083f15d59c98fee619a277dfe123429d8c -- not okay
 >
 > we should follow the Android version as used in the resist
 fingerprinting mode, see:
 >
 > https://dxr.mozilla.org/mozilla-
 
esr60/source/browser/components/resistfingerprinting/test/browser/browser_navigator.js
 >
 > I.e. "Android 4.1.0" > "Android 6.0" which is way more popuplar than
 4.1.0 as well.

 Hrm. Yes, I see. I did consider using a higher Android version, but I
 thought it would be better if we used the lowest supported version number
 instead of the most popular. In any case, I don't feel strongly about
 this. I'll change the hard-coded UAS so it matches the RFP string.

 Also, https://dxr.mozilla.org/mozilla-
 esr60/source/toolkit/components/resistfingerprinting/nsRFPService.h#35

 >
 > commit 7bc689d797439d6394853e421f71eda5d7d1631a -- not okay
 >
 > +import android.content.IntentFilter; <- seems to be something not used
 > (probably part of the NetCipher upgrade on the previous branch?)
 >

 Ugh. That was added in the wrong commit. The `import` should be in
 694067738b04b6a670d072c64a7afa4be63581b1 ("Orfox: add
 BroadcastReceiver..."). I'll move it.

 > `checkStartOrbot()` came before `processTabQueue()` before (and the if-
 clause around `!mHasResumed` got deleted). Doesn't the order matter here?
 (I don't know just for double-checking)

 Yeah, this was something I looked at while I was rebasing the commit.
 Calling `checkStartOrbot()` was moved as a fix for a crash
 (https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-
 browser-52.8.1esr-8.0-1&id=dc6f0c7a561321460ca0f5987f30017ee1066e38).

 I think the `!mHasResumed` clause was deleted in Orfox as a way of
 preventing the app from bringing itself to the foreground the next time it
 was paused (put into the background). After it was deleted, `mHasResumed`
 would never be set to true in `onResume()`, so when `onPause()` is called
 the `mHasResumed` conditional isn't executed and `Prompt:ShowTop` is never
 registered. I don't know why this was missed during the rebase - I
 might've been confused while resolving a merge conflict. I'll include this
 deletion.
 https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-
 browser-52.8.1esr-8.0-1&id=7040f97c97b238b2adef4cae96471907d38caf1d

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26949 [Applications/Tor Browser]: STIX moved away from SourceForge to Github breaking download during Tor Browser build

2018-07-26 Thread Tor Bug Tracker & Wiki
#26949: STIX moved away from SourceForge to Github breaking download during Tor
Browser build
---+--
 Reporter:  gk |  Owner:  tbb-team
 Type:  defect | Status:  needs_review
 Priority:  High   |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201807  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by sukhbir):

 * status:  new => needs_review


Comment:

 https://github.com/azadi/tor-browser-build-1/tree/bug-26949

 (I compared the sha1 of the STIXMath-Regular.otf to make sure it's the
 same.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25696 [Applications/Tor Browser]: Design of alpha onboarding for Tor Browser for Android

2018-07-26 Thread Tor Bug Tracker & Wiki
#25696: Design of alpha onboarding for Tor Browser for Android
--+--
 Reporter:  isabela   |  Owner:  antonela
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ux-team, tbb-mobile   |  Actual Points:
Parent ID:  #26531| Points:
 Reviewer:|Sponsor:  Sponsor8
--+--
Changes (by antonela):

 * Attachment "onion_circles_pattern.html" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25696 [Applications/Tor Browser]: Design of alpha onboarding for Tor Browser for Android

2018-07-26 Thread Tor Bug Tracker & Wiki
#25696: Design of alpha onboarding for Tor Browser for Android
--+--
 Reporter:  isabela   |  Owner:  antonela
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ux-team, tbb-mobile   |  Actual Points:
Parent ID:  #26531| Points:
 Reviewer:|Sponsor:  Sponsor8
--+--
Changes (by antonela):

 * Attachment "onion_circles_pattern.py" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25696 [Applications/Tor Browser]: Design of alpha onboarding for Tor Browser for Android

2018-07-26 Thread Tor Bug Tracker & Wiki
#25696: Design of alpha onboarding for Tor Browser for Android
--+--
 Reporter:  isabela   |  Owner:  antonela
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ux-team, tbb-mobile   |  Actual Points:
Parent ID:  #26531| Points:
 Reviewer:|Sponsor:  Sponsor8
--+--

Comment (by antonela):

 Cool! I made a .css version and pospeselr made a python version that
 generates .svg.
 Attaching both here.

 
https://trac.torproject.org/projects/tor/attachment/ticket/25696/onion_circles_pattern.html
 
https://trac.torproject.org/projects/tor/attachment/ticket/25696/onion_circles_pattern.py

 .png and .svg version were ready to be exported at
 ​https://marvelapp.com/5981a4b/screen/44384308/handoff

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25695 [Applications/Tor Browser]: Activity 5.1: Redesign Tor Browser homepage ("about:tor") - create an user onboard

2018-07-26 Thread Tor Bug Tracker & Wiki
#25695: Activity 5.1: Redesign Tor Browser homepage ("about:tor") - create an 
user
onboard
---+---
 Reporter:  isabela|  Owner:  antonela
 Type:  defect | Status:  assigned
 Priority:  Very High  |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ux-team, TorBrowserTeam201807  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:  Sponsor17
---+---

Comment (by antonela):

 Just in case do you prefer it, .css and .py for the circles' background
 pattern.

 
https://trac.torproject.org/projects/tor/attachment/ticket/25696/onion_circles_pattern.html
 
https://trac.torproject.org/projects/tor/attachment/ticket/25696/onion_circles_pattern.py

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26816 [Core Tor/Tor]: Link NSS into Tor, while still using OpenSSL

2018-07-26 Thread Tor Bug Tracker & Wiki
#26816: Link NSS into Tor, while still using OpenSSL
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  035-roadmap-subticket, 035-triaged-  |  Actual Points:
  in-20180711|
Parent ID:  #26631   | Points:
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 Change state to match related ticket #26815.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26817 [Core Tor/Tor]: Use NSS for DH

2018-07-26 Thread Tor Bug Tracker & Wiki
#26817: Use NSS for DH
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  035-roadmap-subticket, 035-triaged-  |  Actual Points:
  in-20180711|
Parent ID:  #26631   | Points:
 Reviewer:  catalyst |Sponsor:
 |  Sponsor8-can
-+-
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 Thanks!  Still looking over the patches.  This branch, being based on the
 same branch as #26815 and #26816, has the same (hopefully minor) issues.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26401 [Applications/Tor Browser]: Rebase Orfox patches onto Tor Browser 8.0 for TBA

2018-07-26 Thread Tor Bug Tracker & Wiki
#26401: Rebase Orfox patches onto Tor Browser 8.0 for TBA
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  task  | Status:
  |  needs_review
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201807  |  Actual Points:
Parent ID:  #26531| Points:
 Reviewer:|Sponsor:
--+
Changes (by sysrqb):

 * status:  needs_revision => needs_review


Comment:

 Okay, I have another branch for review - tor-
 browser-60.1.0esr-8.0-1+26401_3

 igt0, can you review this new branch, too? (assuming gk doesn't find
 anything else that needs changing).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26785 [Core Tor/Tor]: older gccs don't accept -Wunused-const-variable

2018-07-26 Thread Tor Bug Tracker & Wiki
#26785: older gccs don't accept -Wunused-const-variable
-+-
 Reporter:  catalyst |  Owner:
 |  catalyst
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.11
 Severity:  Normal   | Resolution:
 Keywords:  compression, portability,|  Actual Points:
  regression?, zstd, fast-fix|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by catalyst):

 * status:  assigned => needs_review


Comment:

 Patches in https://github.com/torproject/tor/pull/250

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26950 [Metrics/Website]: Remove "Fraction of relays reporting onion-service statistics" graph

2018-07-26 Thread Tor Bug Tracker & Wiki
#26950: Remove "Fraction of relays reporting onion-service statistics" graph
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+--
 When we added graphs on onion services back in
 [https://gitweb.torproject.org/metrics-
 web.git/commit/?id=4ea56ba80d54d8a34a994181ecb715c544654162 March 2015],
 we also included the [https://metrics.torproject.org/hidserv-frac-
 reporting.html "Fraction of relays reporting onion-service statistics"
 graph].

 Back then, this graph was somewhat useful for pro users, to see how onion-
 service statistics deployment proceeded over time and to assess how much
 we could trust the overall numbers. However, since fractions went up to
 50% in 2016 or even 75% in 2017, this graph has become less relevant.

 Also, when we added this graph in 2015 we still had an "advanced/pro"
 category of graphs that were not displayed by default. We don't have that
 distinction anymore and simply throw everything we have at our users.

 I suggest we remove this graph now from Tor Metrics. It costs maintenance
 effort, and it distracts our users from the more important graphs.

 We could (should?) even keep providing the data by including a `frac`
 column in the CSV files linked from the other two onion-service graphs.
 That's how we do this with the user number graphs. If somebody wants to
 graph fractions of reported statistics, they can easily do that themselves
 using their favorite graphing tool.

 Thoughts? Are there any good reasons to keep this graph?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26935 [Internal Services/Tor Sysadmin Team]: Please change forwarding address for email alias

2018-07-26 Thread Tor Bug Tracker & Wiki
#26935: Please change forwarding address for email alias
-+
 Reporter:  ewyatt   |  Owner:  tpa
 Type:  task | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by weasel):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 done in the config mgmt.  will be a few hours before it goes live
 automagically.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26932 [Core Tor/Tor]: Soft assert in HS3 with vanguards ([warn] Invalid signature for service descriptor signing key: expired)

2018-07-26 Thread Tor Bug Tracker & Wiki
#26932: Soft assert in HS3 with vanguards ([warn] Invalid signature for service
descriptor signing key: expired)
-+-
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs possible-regression bug easy  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mikeperry):

 * milestone:  Tor: 0.3.5.x-final => Tor: 0.3.4.x-final


Comment:

 I also got this on my service side on 0.3.4.4-rc. I can try a patch.
 Should move_hs_state() just call set_rotation_time(dest_service,
 time(NULL))? Or is there more to it?

 Also we want this to be for at least 0.3.4.x. Maybe also 0.3.3.x?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26401 [Applications/Tor Browser]: Rebase Orfox patches onto Tor Browser 8.0 for TBA

2018-07-26 Thread Tor Bug Tracker & Wiki
#26401: Rebase Orfox patches onto Tor Browser 8.0 for TBA
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  task  | Status:
  |  needs_review
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201807  |  Actual Points:
Parent ID:  #26531| Points:
 Reviewer:|Sponsor:
--+

Comment (by gk):

 LGTM. Let's get this merged tomorrow (plus the other stuff that is ready
 on top of it).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26951 [Applications/Tor Browser]: Linux tbb execdesktop argument passing is broken

2018-07-26 Thread Tor Bug Tracker & Wiki
#26951: Linux tbb execdesktop argument passing is broken
--+--
 Reporter:  benburrill|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 Arguments with spaces get flattened due to the eval, so running

 {{{
 ./start-tor-browser.desktop --search "hello world"
 }}}

 is effectively converted to

 {{{
 ./start-tor-browser.desktop --search hello world
 }}}

 opening up two windows, one search for "hello" and one trying to connect
 to http://world

 I have a patch, which I will try to attach.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26951 [Applications/Tor Browser]: Linux tbb execdesktop argument passing is broken

2018-07-26 Thread Tor Bug Tracker & Wiki
#26951: Linux tbb execdesktop argument passing is broken
--+--
 Reporter:  benburrill|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by benburrill):

 * Attachment "0001-Fix-execdesktop-argument-passing.patch" added.

 Fixes the bug

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26951 [Applications/Tor Browser]: Linux tbb execdesktop argument passing is broken

2018-07-26 Thread Tor Bug Tracker & Wiki
#26951: Linux tbb execdesktop argument passing is broken
--+--
 Reporter:  benburrill|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by benburrill):

 Just to clarify, the patch is a git format-patch patch for the builders
 /tor-browser-bundle repo.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26951 [Applications/Tor Browser]: Linux tbb execdesktop argument passing is broken

2018-07-26 Thread Tor Bug Tracker & Wiki
#26951: Linux tbb execdesktop argument passing is broken
+--
 Reporter:  benburrill  |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  Low |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201807R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * keywords:   => tbb-rbm, TorBrowserTeam201807R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26949 [Applications/Tor Browser]: STIX moved away from SourceForge to Github breaking download during Tor Browser build

2018-07-26 Thread Tor Bug Tracker & Wiki
#26949: STIX moved away from SourceForge to Github breaking download during Tor
Browser build
+--
 Reporter:  gk  |  Owner:  tbb-team
 Type:  defect  | Status:  closed
 Priority:  High|  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201807R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * keywords:  tbb-rbm, TorBrowserTeam201807 => tbb-rbm,
   TorBrowserTeam201807R
 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good. Merged to `master` (commit
 cab964b173814a77f25bfd7ffa8d9adeff4d53fe).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26892 [Core Tor/Tor]: log_addr_has_changed() does not heed SafeLogging

2018-07-26 Thread Tor Bug Tracker & Wiki
#26892: log_addr_has_changed() does not heed SafeLogging
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-log   |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+
Changes (by teor):

 * status:  needs_review => merge_ready


Comment:

 Looks fine to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #12018 [Community/Translations]: Add HTTPS Everywhere for Chrome to Transifex

2018-07-26 Thread Tor Bug Tracker & Wiki
#12018: Add HTTPS Everywhere for Chrome to Transifex
+--
 Reporter:  pde |  Owner:  emmapeel
 Type:  task| Status:  assigned
 Priority:  High|  Milestone:
Component:  Community/Translations  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  #5257   | Points:
 Reviewer:  |Sponsor:
+--

Comment (by legind):

 I fixed this a while ago, we should close the ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26952 [Core Tor/Tor]: Try enabling ccache on Travis

2018-07-26 Thread Tor Bug Tracker & Wiki
#26952: Try enabling ccache on Travis
--+
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  fast-fix
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 Based on my branch in #24629.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26401 [Applications/Tor Browser]: Rebase Orfox patches onto Tor Browser 8.0 for TBA

2018-07-26 Thread Tor Bug Tracker & Wiki
#26401: Rebase Orfox patches onto Tor Browser 8.0 for TBA
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  task  | Status:
  |  needs_review
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201807  |  Actual Points:
Parent ID:  #26531| Points:
 Reviewer:|Sponsor:
--+

Comment (by igt0):

 I think we dont need this commit:
 https://gitweb.torproject.org/user/sysrqb/tor-browser.git/commit/?h=tor-
 browser-60.1.0esr-8.0-1%2b26401_3&id=109f0a19ed90738210577cdca051564c0f57a1c6

 We are going to implement the onboarding in the
 https://trac.torproject.org/projects/tor/ticket/25696

 Besides that, nice work!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26953 [Core Tor/Tor]: Privcount blinding and encryption: add travis CI

2018-07-26 Thread Tor Bug Tracker & Wiki
#26953: Privcount blinding and encryption: add travis CI
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  privcount, 035-roadmap-master, 035
 Severity:  Normal   |  -triaged-in-20180711, rust
Actual Points:   |  Parent ID:  #25669
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Because I don't want to spend all my time running multiple builds.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26932 [Core Tor/Tor]: Soft assert in HS3 with vanguards ([warn] Invalid signature for service descriptor signing key: expired)

2018-07-26 Thread Tor Bug Tracker & Wiki
#26932: Soft assert in HS3 with vanguards ([warn] Invalid signature for service
descriptor signing key: expired)
-+-
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs possible-regression bug easy  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by asn):

 IMO, the patch is to add `dst->next_rotation_time =
 src->next_rotation_time;` to `move_hs_state()`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26932 [Core Tor/Tor]: Soft assert in HS3 with vanguards ([warn] Invalid signature for service descriptor signing key: expired)

2018-07-26 Thread Tor Bug Tracker & Wiki
#26932: Soft assert in HS3 with vanguards ([warn] Invalid signature for service
descriptor signing key: expired)
-+-
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs possible-regression bug easy  |  Actual Points:
  034-backport 033-backport-maybe 032-backport-  |
  maybe  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:  tor-hs possible-regression bug easy =>
 tor-hs possible-regression bug easy 034-backport 033-backport-maybe
 032-backport-maybe
 * milestone:  Tor: 0.3.4.x-final => Tor: 0.3.5.x-final


Comment:

 If it's a simple patch, let's consider backporting it to 0.3.2 and later.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24629 [Core Tor/Tor]: Activate osx builds on travis, at low priority

2018-07-26 Thread Tor Bug Tracker & Wiki
#24629: Activate osx builds on travis, at low priority
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  not-just-linux, tor-ci, teor-was-|  Actual Points:
  assigned, 034-triage-20180328, |
  034-removed-20180328, 034-backport,|
  035-removed-20180711, fast-fix |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 I fixed a comment typo and some redundant env initialisations.

 I also added a commit that sorts the config into chronological order, and
 groups related items together.

 Then I added extra logging:
 * rustup version for rust builds
 * config.log for failures

 And caching (see #26952):
 * ccache
 * cargo cache for rust builds
 Cached builds are about 30% faster.

 Please see travis-osx-v9.
 There were some fixups to earlier commits, so I force-pushed it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26952 [Core Tor/Tor]: Try enabling ccache on Travis

2018-07-26 Thread Tor Bug Tracker & Wiki
#26952: Try enabling ccache on Travis
--+
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  fast-fix  |  Actual Points:
Parent ID:  #24629| Points:
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  assigned => needs_review
 * parent:   => #24629


Comment:

 Tracking this in #24629.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26954 [Core Tor/Tor]: Appveyor: Add Rust builds on Windows

2018-07-26 Thread Tor Bug Tracker & Wiki
#26954: Appveyor: Add Rust builds on Windows
--+-
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  tor-windows, tor-ci
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+-
 The Tor Browser team cross-compiles Tor with Rust for Windows.
 It would be great if we had our own CI for Rust Windows builds.

 There's a good thread with some scripts here:
 https://users.rust-lang.org/t/rust-appveyor-windows-ci-scripts/4437

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26953 [Core Tor/Tor]: Privcount blinding and encryption: add travis CI

2018-07-26 Thread Tor Bug Tracker & Wiki
#26953: Privcount blinding and encryption: add travis CI
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  assigned => needs_review


Comment:

 Please see my branch ci-osx on
 https://github.com/teor2345/privcount_shamir.git

 I'm going to merge it to my master once CI passes, so I can use it as the
 base for my other branches. (Otherwise, they won't have any CI.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26955 [Core Tor/Tor]: Privcount blinding and encryption: rustfmt

2018-07-26 Thread Tor Bug Tracker & Wiki
#26955: Privcount blinding and encryption: rustfmt
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  privcount, 035-roadmap-master, 035
 Severity:  Normal   |  -triaged-in-20180711, rust
Actual Points:   |  Parent ID:  #25669
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 I'm going to rustfmt the entire codebase, so I don't have spurious changes
 when I edit particular files.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26955 [Core Tor/Tor]: Privcount blinding and encryption: rustfmt

2018-07-26 Thread Tor Bug Tracker & Wiki
#26955: Privcount blinding and encryption: rustfmt
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  assigned => needs_review


Comment:

 Please see my branch rustfmt on
 ​https://github.com/teor2345/privcount_shamir.git

 I'm going to merge it to my master once CI passes, so I can use it as the
 base for my other branches. (Otherwise, I'll end up with spurious
 whitespace changes in my other branches.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26953 [Core Tor/Tor]: Privcount blinding and encryption: add travis CI

2018-07-26 Thread Tor Bug Tracker & Wiki
#26953: Privcount blinding and encryption: add travis CI
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 https://github.com/nmathewson/privcount_shamir/pull/2

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26955 [Core Tor/Tor]: Privcount blinding and encryption: rustfmt

2018-07-26 Thread Tor Bug Tracker & Wiki
#26955: Privcount blinding and encryption: rustfmt
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 https://github.com/teor2345/privcount_shamir/pull/1

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26942 [Core Tor/Tor]: Privcount blinding and encryption: Rust code conventions

2018-07-26 Thread Tor Bug Tracker & Wiki
#26942: Privcount blinding and encryption: Rust code conventions
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Please see my branch bug26942 at
 ​https://github.com/teor2345/privcount_shamir.git

 Or https://github.com/teor2345/privcount_shamir/pull/2

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26946 [Core Tor/Tor]: Privcount blinding and encryption: warning fixes

2018-07-26 Thread Tor Bug Tracker & Wiki
#26946: Privcount blinding and encryption: warning fixes
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Ok, now it just includes the changes for this ticket.

 See https://github.com/teor2345/privcount_shamir/pull/3

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23713 [Metrics/Onionoo]: Expand parameters and fields around AS number and names

2018-07-26 Thread Tor Bug Tracker & Wiki
#23713: Expand parameters and fields around AS number and names
-+-
 Reporter:  cypherpunks  |  Owner:  karsten
 Type:  enhancement  | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  irl  |Sponsor:
-+-
Changes (by irl):

 * status:  needs_review => merge_ready


Comment:

 This looks good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #12018 [Community/Translations]: Add HTTPS Everywhere for Chrome to Transifex

2018-07-26 Thread Tor Bug Tracker & Wiki
#12018: Add HTTPS Everywhere for Chrome to Transifex
+--
 Reporter:  pde |  Owner:  emmapeel
 Type:  task| Status:  closed
 Priority:  High|  Milestone:
Component:  Community/Translations  |Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  |  Actual Points:
Parent ID:  #5257   | Points:
 Reviewer:  |Sponsor:
+--
Changes (by emmapeel):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 Thanks, closing then.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs