Re: [tor-bugs] #25885 [Core Tor/Tor]: count_acceptable_nodes() would be more accurate using node_has_preferred_descriptor()

2018-08-07 Thread Tor Bug Tracker & Wiki
#25885: count_acceptable_nodes() would be more accurate using
node_has_preferred_descriptor()
--+--
 Reporter:  nickm |  Owner:  neel
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by neel):

 * cc: neel@… (added)
 * status:  new => assigned
 * owner:  (none) => neel


Comment:

 I am interested in fixing this.

 I have a question: what is a "careful count"?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27075 [Core Tor/Tor]: Typo in control_event_hs_descriptor_content() comment

2018-08-07 Thread Tor Bug Tracker & Wiki
#27075: Typo in control_event_hs_descriptor_content() comment
--+--
 Reporter:  neel  |  Owner:  neel
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by neel):

 Also, sorry if I didn't put it in the original message but this comment is
 in the file `src/feature/control/control.c`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27075 [Core Tor/Tor]: Typo in control_event_hs_descriptor_content() comment

2018-08-07 Thread Tor Bug Tracker & Wiki
#27075: Typo in control_event_hs_descriptor_content() comment
--+--
 Reporter:  neel  |  Owner:  neel
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by neel):

 My PR is here: https://github.com/torproject/tor/pull/266

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27075 [Core Tor/Tor]: Typo in control_event_hs_descriptor_content() comment

2018-08-07 Thread Tor Bug Tracker & Wiki
#27075: Typo in control_event_hs_descriptor_content() comment
--+--
 Reporter:  neel  |  Owner:  neel
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 In this code:

 {{{
 /** Send HS_DESC_CONTENT event after completion of a successful fetch from
 hs
  * directory. If hsdir_id_digest is NULL, it is replaced by
 "UNKNOWN".
  * If content is NULL, it is replaced by an empty string. The
  * onion_address or desc_id set to NULL will no trigger the
  * control event. */
 }}}

 The `no trigger` should be `not trigger`.

 I will post a PR shortly.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16824 [Core Tor/Tor]: Emit a warning message about side channel leaks when using relays as clients

2018-08-07 Thread Tor Bug Tracker & Wiki
#16824: Emit a warning message about side channel leaks when using relays as
clients
-+-
 Reporter:  starlight|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.6.10
 Severity:  Normal   | Resolution:
 Keywords:  mike-can, tor-client, tor-relay, |  Actual Points:
  tor-log, sidechannel, easy, 035-triaged-   |
  in-20180711|
Parent ID:   | Points:  1
 Reviewer:  mikeperry|Sponsor:
-+-

Comment (by mikeperry):

 Wait don't we already do this?
 https://trac.torproject.org/projects/tor/ticket/12908

 Why is that warn not being emitted?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

2018-08-07 Thread Tor Bug Tracker & Wiki
#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
--+
 Reporter:  chelseakomlo  |  Owner:  teor
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by cypherpunks3):

 Sorry, fixed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23588 [Core Tor/Tor]: Write fascist_firewall_choose_address_ls() and use it in hs_get_extend_info_from_lspecs()

2018-08-07 Thread Tor Bug Tracker & Wiki
#23588: Write fascist_firewall_choose_address_ls() and use it in
hs_get_extend_info_from_lspecs()
-+-
 Reporter:  teor |  Owner:  neel
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs, single-onion,   |  Actual Points:
  ipv6, 034-triage-20180328, |
  034-removed-20180328   |
Parent ID:  #23493   | Points:  1
 Reviewer:  teor |Sponsor:
-+-

Comment (by neel):

 I have updated my code and used the same branch b23588a.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27068 [Core Tor/Chutney]: TOR_DIR shouldn't override CHUTNEY_TOR and CHUTNEY_TOR_GENCERT

2018-08-07 Thread Tor Bug Tracker & Wiki
#27068: TOR_DIR shouldn't override CHUTNEY_TOR and CHUTNEY_TOR_GENCERT
--+
 Reporter:  catalyst  |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Chutney  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #27067| Points:
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  new => needs_review


Comment:

 I fixed this issue by making test-network.sh use CHUTNEY_TOR and
 CHUTNEY_TOR_GENCERT as binary paths if TOR_DIR is not a Tor build
 directory, rather than just searching PATH for the standard binary names.

 This change allows CHUTNEY_TOR to be set as a workaround to #27067, even
 without the changes in #27067.

 I also made the following changes:
   * If CHUTNEY_TOR or CHUTNEY_TOR_GENCERT aren't binary paths, use them as
 binary names to search PATH
   * Tell the user how chutney is trying to find tor binaries
   * Document chutney's binary search order better

 I didn't swap the TOR_DIR and CHUTNEY_TOR search order, because (as far as
 I understand) chutney is mainly used in Tor build directories. And a major
 change like that could break compatibility with existing setups.

 Please see the earlier commits in my branch bug27067 on
 https://github.com/teor2345/chutney.git

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27067 [Core Tor/Chutney]: test-network can't find tor binaries on tor master

2018-08-07 Thread Tor Bug Tracker & Wiki
#27067: test-network can't find tor binaries on tor master
--+
 Reporter:  catalyst  |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Chutney  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  new => needs_review


Comment:

 I fixed this issue by making test-network.sh look for src/app or src/or.

 Please see my branch bug27067 on https://github.com/teor2345/chutney.git

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

2018-08-07 Thread Tor Bug Tracker & Wiki
#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
--+
 Reporter:  chelseakomlo  |  Owner:  teor
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by teor):

 Hi, it looks like you missed the following review comments:
 https://github.com/torproject/tor/pull/265#discussion_r208422091
 https://github.com/torproject/tor/pull/265#discussion_r208423211

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

2018-08-07 Thread Tor Bug Tracker & Wiki
#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
--+
 Reporter:  chelseakomlo  |  Owner:  teor
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by cypherpunks3):

 Rebased and reran with max_width=100. Also, `echo` prints a newline at the
 end, while `printf` doesn't.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27074 [Metrics/Website]: Metrics does not render graphs

2018-08-07 Thread Tor Bug Tracker & Wiki
#27074: Metrics does not render graphs
--+---
 Reporter:  cKKuzt3QCP7R4CuQ3ujP  |  Owner:  metrics-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Metrics/Website   |Version:
 Severity:  Normal|   Keywords:  metrics graph
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+---
 The metrics page for any relay I've looked at shows "No Data Available"
 for both graphs for the last couple of weeks. Same behaviour for and time
 range on the graphs. It displayed correctly before. I've tried on
 chromium, firefox, and android firefox.

 In the debug console, I see the follow javascript errors that look
 relevant:
 graph.js?v29:41 Uncaught TypeError: history[period].first.split is not a
 function
 at graph.js?v29:41
 at Function._.each._.forEach (underscore-min.js?v29:153)
 at parseWeightHistory (graph.js?v29:40)
 at n.parse_weights_data (graph.js?v29:159)
 at success (main.js?v29:199)
 at Object.success (graph.js?v29:148)
 at i (jquery-3.2.1.min.js?v29:2)
 at Object.fireWith [as resolveWith] (jquery-3.2.1.min.js?v29:2)
 at A (jquery-3.2.1.min.js?v29:4)
 at XMLHttpRequest. (jquery-3.2.1.min.js?v29:4)

 graph.js?v29:12 Uncaught TypeError: history[period].first.split is not a
 function
 at graph.js?v29:12
 at Function._.each._.forEach (underscore-min.js?v29:153)
 at parseHistory (graph.js?v29:11)
 at n.parse_bw_data (graph.js?v29:128)
 at success (main.js?v29:183)
 at Object.success (graph.js?v29:118)
 at i (jquery-3.2.1.min.js?v29:2)
 at Object.fireWith [as resolveWith] (jquery-3.2.1.min.js?v29:2)
 at A (jquery-3.2.1.min.js?v29:4)
 at XMLHttpRequest. (jquery-3.2.1.min.js?v29:4)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27073 [Core Tor/Tor]: conditionvar_timeout intermittently fails on maint-0.3.3

2018-08-07 Thread Tor Bug Tracker & Wiki
#27073: conditionvar_timeout intermittently fails on maint-0.3.3
--+---
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: 0.3.3.8
 Severity:  Normal|   Keywords:  regression?, tor-test
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+---
 util/thread/conditionvar_timeout failed in the last maint-0.3.3 build:
 https://travis-ci.org/torproject/tor/builds/411701508

 With the following message:
 {{{
 util/thread/conditionvar_timeout: [forking]
   FAIL src/test/test_threads.c:285: assert(ti->n_timeouts OP_EQ 2): 1 vs
 2Aug 03 13:03:59.190 [err] Error 16 destroying a mutex.
 Aug 03 13:03:59.190 [err] tor_assertion_failed_(): Bug:
 src/common/compat_pthreads.c:172: tor_mutex_uninit: Assertion 0 failed;
 aborting. (on Tor 0.3.3.8-dev 2a6c1585b0f13e03)
 Aug 03 13:03:59.191 [err] Bug: Assertion 0 failed in tor_mutex_uninit at
 src/common/compat_pthreads.c:172. Stack trace: (on Tor 0.3.3.8-dev
 2a6c1585b0f13e03)
 Aug 03 13:03:59.191 [err] Bug: ./src/test/test(log_backtrace+0x46)
 [0x55cd7c253ec6] (on Tor 0.3.3.8-dev 2a6c1585b0f13e03)
 Aug 03 13:03:59.191 [err] Bug:
 ./src/test/test(tor_assertion_failed_+0xe4) [0x55cd7c294434] (on Tor
 0.3.3.8-dev 2a6c1585b0f13e03)
 Aug 03 13:03:59.191 [err] Bug: ./src/test/test(tor_mutex_uninit+0xa6)
 [0x55cd7c29d736] (on Tor 0.3.3.8-dev 2a6c1585b0f13e03)
 Aug 03 13:03:59.191 [err] Bug: ./src/test/test(tor_mutex_free_+0x25)
 [0x55cd7c262dc5] (on Tor 0.3.3.8-dev 2a6c1585b0f13e03)
 Aug 03 13:03:59.191 [err] Bug: ./src/test/test(+0x54508a)
 [0x55cd7bed908a] (on Tor 0.3.3.8-dev 2a6c1585b0f13e03)
 Aug 03 13:03:59.191 [err] Bug: ./src/test/test(+0x5c840d)
 [0x55cd7bf5c40d] (on Tor 0.3.3.8-dev 2a6c1585b0f13e03)
 Aug 03 13:03:59.191 [err] Bug: ./src/test/test(testcase_run_one+0x310)
 [0x55cd7bf5c7d0] (on Tor 0.3.3.8-dev 2a6c1585b0f13e03)
 Aug 03 13:03:59.191 [err] Bug: ./src/test/test(tinytest_main+0x1eb)
 [0x55cd7bf5d58b] (on Tor 0.3.3.8-dev 2a6c1585b0f13e03)
 Aug 03 13:03:59.191 [err] Bug: ./src/test/test(main+0x4e9)
 [0x55cd7bbb61b9] (on Tor 0.3.3.8-dev 2a6c1585b0f13e03)
 Aug 03 13:03:59.191 [err] Bug: /lib/x86_64-linux-
 gnu/libc.so.6(__libc_start_main+0xf5) [0x2b2813951f45] (on Tor 0.3.3.8-dev
 2a6c1585b0f13e03)
 Aug 03 13:03:59.191 [err] Bug: ./src/test/test(+0x224fdb)
 [0x55cd7bbb8fdb] (on Tor 0.3.3.8-dev 2a6c1585b0f13e03)
 [Lost connection!]
   [conditionvar_timeout FAILED]
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23588 [Core Tor/Tor]: Write fascist_firewall_choose_address_ls() and use it in hs_get_extend_info_from_lspecs()

2018-08-07 Thread Tor Bug Tracker & Wiki
#23588: Write fascist_firewall_choose_address_ls() and use it in
hs_get_extend_info_from_lspecs()
-+-
 Reporter:  teor |  Owner:  neel
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs, single-onion,   |  Actual Points:
  ipv6, 034-triage-20180328, |
  034-removed-20180328   |
Parent ID:  #23493   | Points:  1
 Reviewer:  teor |Sponsor:
-+-

Comment (by teor):

 Thanks!

 When I was reviewing your comments, I noticed that you deleted some code
 that we need to keep. Please fix with extra commits on that branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

2018-08-07 Thread Tor Bug Tracker & Wiki
#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
--+
 Reporter:  chelseakomlo  |  Owner:  teor
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by teor):

 Hi, the CI passed after merging the fix from master:
 https://travis-ci.org/teor2345/tor/builds/413363895

 I opened a GitHub pull request with my review on this branch:
 https://github.com/torproject/tor/pull/265#pullrequestreview-144228176

 Please see my comments on that pull request.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27071 [Core Tor/Tor]: Stop using max_width=80 for rustfmt

2018-08-07 Thread Tor Bug Tracker & Wiki
#27071: Stop using max_width=80 for rustfmt
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:  #26972| Points:
 Reviewer:|Sponsor:
--+

Comment (by teor):

 Ok, I'll ask for that fix in my #26972 review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26858 [Applications/Tor Browser]: TBA: Investigating patching AccountManager

2018-08-07 Thread Tor Bug Tracker & Wiki
#26858: TBA: Investigating patching AccountManager
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile|  Actual Points:
Parent ID:  #26531| Points:
 Reviewer:|Sponsor:
--+--

Comment (by sysrqb):

 But, I wonder if we should accomplish this differently. If we put FxA and
 Sync behind compile-time build flags and add Stub classes, this may make
 it easier to maintain (and easier to reason about).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27060 [Core Tor/Tor]: Improve coverage in a few high-coverage modules (was: Improve coverag in a few high-coverage modules)

2018-08-07 Thread Tor Bug Tracker & Wiki
#27060: Improve coverage in a few high-coverage modules
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by teor):

 Fix typo

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27060 [Core Tor/Tor]: Improve coverag in a few high-coverage modules

2018-08-07 Thread Tor Bug Tracker & Wiki
#27060: Improve coverag in a few high-coverage modules
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 Should be better now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27071 [Core Tor/Tor]: Stop using max_width=80 for rustfmt

2018-08-07 Thread Tor Bug Tracker & Wiki
#27071: Stop using max_width=80 for rustfmt
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:  #26972| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 I favor copying the rust defaults here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26858 [Applications/Tor Browser]: TBA: Investigating patching AccountManager

2018-08-07 Thread Tor Bug Tracker & Wiki
#26858: TBA: Investigating patching AccountManager
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile|  Actual Points:
Parent ID:  #26531| Points:
 Reviewer:|Sponsor:
--+--

Comment (by sysrqb):

 Replying to [comment:2 sysrqb]:
 > Replying to [ticket:26858 sysrqb]:
 > 3) `Tabs.java`
 >
 >   This still exists, and an instance of AccountManager is still
 retrieved here. We should clean this. I believe the goal here is
 preventing the caching of current tabs on disk (`queuePersistAllTabs()`).

 #27065

 >
 > 4)
 
`mobile/android/base/java/org/mozilla/gecko/overlays/service/sharemethods/SendTab.java`
 >
 >   We should clean this. It is initialized in
 `OverlayActionService.java`, it's a background service for handling
 sharing the current tab with another device (when FxA/sync are enabled).
 >

 #27069

 > 6)
 
`mobile/android/services/src/main/java/org/mozilla/gecko/fxa/activities/FxAccountStatusActivity.java`
 >
 >   Needs cleaning.
 >

 #27070

 > > https://github.com/guardianproject/tor-
 browser/commit/b044089a93bd36ddb454ac11eecc72a2c295229c
 > But, we should delete in
 `mobile/android/app/src/main/res/xml/preferences_general_tablet.xml`, too.
 >
 #27072

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

2018-08-07 Thread Tor Bug Tracker & Wiki
#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
--+
 Reporter:  chelseakomlo  |  Owner:  teor
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by teor):

 Replying to [comment:3 teor]:
 > Replying to [comment:2 cypherpunks3]:
 > > But there's a bug upstream in rustfmt, which happens when it's
 configured with max_width=80 (like it is in `src/rust/.rustfmt.toml`).
 >
 > I'm not sure about the impact of the bug.
 > Does it produce ugly formatting, or is the syntax incorrect?
 >
 > Do you think we should give up on max_width=80?
 > We can reconsider wrapping to 80 characters when stable supports
 wrapping comments.
 >
 > If we want to match Tor's C files, we should be wrapping to 79
 characters:
 >
 https://gitweb.torproject.org/tor.git/tree/doc/HACKING/CodingStandards.md#n177

 I opened #27071 to deal with the max_width issue.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27072 [Applications/Tor Browser]: TBA: Delete SyncPreference from tablet layout

2018-08-07 Thread Tor Bug Tracker & Wiki
#27072: TBA: Delete SyncPreference from tablet layout
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-mobile
Actual Points:|  Parent ID:  #26858
   Points:|   Reviewer:
  Sponsor:|
--+
 We already deleted it in preferences_general.xml, but we should delete it
 in `mobile/android/app/src/main/res/xml/preferences_general_tablet.xml`,
 too.

 {{{
 
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27071 [Core Tor/Tor]: Stop using max_width=80 for rustfmt

2018-08-07 Thread Tor Bug Tracker & Wiki
#27071: Stop using max_width=80 for rustfmt
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  rust
Actual Points:|  Parent ID:  #26972
   Points:|   Reviewer:
  Sponsor:|
--+
 We have two options:
 * use max_width=79 to match our C coding standards
 * use the default max_width=100 to match the Rust defaults and avoid
 wrapping bugs in rustfmt

 For details, see:
 https://trac.torproject.org/projects/tor/ticket/26972#comment:2
 https://trac.torproject.org/projects/tor/ticket/26972#comment:3

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27070 [Applications/Tor Browser]: TBA: FxAccountStatusActivity shouldn't modify Android Accounts

2018-08-07 Thread Tor Bug Tracker & Wiki
#27070: TBA: FxAccountStatusActivity shouldn't modify Android Accounts
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-mobile
Actual Points:|  Parent ID:  #26858
   Points:|   Reviewer:
  Sponsor:|
--+
 Prevent FxAccountStatusActivity [https://github.com/guardianproject/tor-
 browser/commit/45ba8e208975daebda7520ea0f111f475adba967#diff-
 3304c3a9a2b4fa252a46fcb817bb15f3 deleting] Android Accounts

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27069 [Applications/Tor Browser]: TBA: Make SendTab Safe

2018-08-07 Thread Tor Bug Tracker & Wiki
#27069: TBA: Make SendTab Safe
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-mobile
Actual Points:|  Parent ID:  #26858
   Points:|   Reviewer:
  Sponsor:|
--+
 I see two options.

 1. Delete/Comment-out the offending code like
 [https://github.com/guardianproject/tor-
 browser/commit/45ba8e208975daebda7520ea0f111f475adba967#diff-
 3e37c64588dc24943c970806d5c670cd Orfox]
 1. Delete all instances of `SendTab`

 I believe the goal here is preventing Orfox/TBA from interacting with the
 Android Accounts subsystem. This is reasonable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22132 [Core Tor/Chutney]: Chutney should avoid waiting for set times: wait for conditions instead

2018-08-07 Thread Tor Bug Tracker & Wiki
#22132: Chutney should avoid waiting for set times: wait for conditions instead
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Core Tor/Chutney  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  2
 Reviewer:|Sponsor:
--+
Changes (by catalyst):

 * cc: catalyst (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

2018-08-07 Thread Tor Bug Tracker & Wiki
#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
--+
 Reporter:  chelseakomlo  |  Owner:  teor
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by teor):

 Replying to [comment:7 cypherpunks3]:
 > Replying to [comment:5 teor]:
 > > The travis build failed, due to old autoconf macros:
 > > https://travis-ci.org/teor2345/tor/builds/412925525
 > > Please fix
 >
 > Huh? According to the log, the source of the warning is a use of AC_WARN
 in configure.ac, and none of these patches added that, or even touched
 that file.

 Sorry, I didn't realise that CI was failing due to a bug in master.

 > It looks like a pre-existing condition. It seems to have already gotten
 fixed in
 
[https://gitweb.torproject.org/tor.git/commit/?id=f90c0533777f2220cd6fb5ed07a5b63cd9c3e881
 f90c0533777f2220cd6fb5ed07a5b63cd9c3e881]. (Although not sure what #23878
 has to do with it.)

 I've pushed your rebased branch to my github, and I'll see if CI works
 this time.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27067 [Core Tor/Chutney]: test-network can't find tor binaries on tor master

2018-08-07 Thread Tor Bug Tracker & Wiki
#27067: test-network can't find tor binaries on tor master
--+
 Reporter:  catalyst  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Chutney  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by catalyst):

 Workaround: create a src/or directory in the build tree and symlink the
 tor binary to it, so chutney can find tor where it's accustomed to.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27068 [Core Tor/Chutney]: TOR_DIR shouldn't override CHUTNEY_TOR and CHUTNEY_TOR_GENCERT

2018-08-07 Thread Tor Bug Tracker & Wiki
#27068: TOR_DIR shouldn't override CHUTNEY_TOR and CHUTNEY_TOR_GENCERT
--+
 Reporter:  catalyst  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Chutney  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:  #27067
   Points:|   Reviewer:
  Sponsor:|
--+
 Right now, chutney's warnings when it can't find tor or tor-gencert
 suggest to set `CHUTNEY_TOR` and `CHUTNEY_TOR_GENCERT`.  However, attempts
 to set these get overwritten by tools/test-network.sh with either a
 computed result based on `TOR_DIR` if that is set, or with plain program
 names to be searched in the path.  This makes it harder to work around
 #27067.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27067 [Core Tor/Chutney]: test-network can't find tor binaries on tor master

2018-08-07 Thread Tor Bug Tracker & Wiki
#27067: test-network can't find tor binaries on tor master
--+
 Reporter:  catalyst  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Chutney  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 `make test-network` doesn't work on master even when given explicit paths
 for `CHUTNEY_TOR` and `CHUTNEY_TOR_GENCERT`.  This seems to be due to the
 0.3.5 source tree reorganization.

 chutney should learn about the new source tree layout (and also probably
 keep looking for the old layout for backward compatibility).

 There is a child ticket for dealing with `TOR_DIR` overriding
 `CHUTNEY_TOR` and `CHUTNEY_TOR_GENCERT`.

 Example failure when setting only `CHUTNEY_PATH`:
 {{{
 $ CHUTNEY_PATH=../../chutney make test-network
 ../src/test/test-network.sh --hs-multi-client 1
 test-network.sh: using CHUTNEY_DNS_CONF '/dev/null'
 test-network.sh: no $TOR_DIR, chutney will use $PATH for tor binaries
 Using Python 2.7.12
 Sending SIGINT to nodes
 Waiting for nodes to finish.
 bootstrap-network.sh: bootstrapping network: bridges+hs
 Using Python 2.7.12
 NOTE: creating '/home/tlyu/src/tor/build-
 norust/../../chutney/net/nodes.1533677645', linking to '/home/tlyu/src/tor
 /build-norust/../../chutney/net/nodes'
 Creating identity key
 /home/tlyu/src/chutney/net/nodes/000a/keys/authority_identity_key for
 test000a with tor-gencert --create-identity-key --passphrase-fd 0 -i
 /home/tlyu/src/chutney/net/nodes/000a/keys/authority_identity_key -s
 /home/tlyu/src/chutney/net/nodes/000a/keys/authority_signing_key -c
 /home/tlyu/src/chutney/net/nodes/000a/keys/authority_certificate -m 12 -a
 127.0.0.1:7000
 Cannot find the tor-gencert binary tor-gencert for the command line 'tor-
 gencert --create-identity-key --passphrase-fd 0 -i
 /home/tlyu/src/chutney/net/nodes/000a/keys/authority_identity_key -s
 /home/tlyu/src/chutney/net/nodes/000a/keys/authority_signing_key -c
 /home/tlyu/src/chutney/net/nodes/000a/keys/authority_certificate -m 12 -a
 127.0.0.1:7000'. Use the CHUTNEY_TOR_GENCERT environment variable to set
 the path, or put the binary into $PATH:
 
'/home/tlyu/.cargo/bin:/home/tlyu/bin:/home/tlyu/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin'.
 If your $PATH contains ~, use $HOME instead.
 sed: can't read /home/tlyu/src/tor/build-
 norust/../../chutney/net/nodes/*a/torrc: No such file or directory
 Using Python 2.7.12
 Starting nodes
 Cannot find tor binary 'tor'. Use CHUTNEY_TOR environment variable to set
 the path, or put the binary into $PATH.
 Using Python 2.7.12
 0/12 nodes are running
 Makefile:15762: recipe for target 'test-network' failed
 make: *** [test-network] Error 3
 }}}

 Example failure when setting `CHUTNEY_TOR`, `CHUTNEY_TOR_GENCERT`, and
 `CHUTNEY_PATH`:
 {{{
 $ CHUTNEY_TOR=`pwd`/src/app/tor CHUTNEY_TOR_GENCERT=`pwd`/src/tools/tor-
 gencert CHUTNEY_PATH=../../chutney make test-network
 ../src/test/test-network.sh --hs-multi-client 1
 test-network.sh: using CHUTNEY_DNS_CONF '/dev/null'
 test-network.sh: no $TOR_DIR, chutney will use $PATH for tor binaries
 Using Python 2.7.12
 Sending SIGINT to nodes
 Waiting for nodes to finish.
 bootstrap-network.sh: bootstrapping network: bridges+hs
 Using Python 2.7.12
 NOTE: creating '/home/tlyu/src/tor/build-
 norust/../../chutney/net/nodes.1533677759', linking to '/home/tlyu/src/tor
 /build-norust/../../chutney/net/nodes'
 Creating identity key
 /home/tlyu/src/chutney/net/nodes/000a/keys/authority_identity_key for
 test000a with tor-gencert --create-identity-key --passphrase-fd 0 -i
 /home/tlyu/src/chutney/net/nodes/000a/keys/authority_identity_key -s
 /home/tlyu/src/chutney/net/nodes/000a/keys/authority_signing_key -c
 /home/tlyu/src/chutney/net/nodes/000a/keys/authority_certificate -m 12 -a
 127.0.0.1:7000
 Cannot find the tor-gencert binary tor-gencert for the command line 'tor-
 gencert --create-identity-key --passphrase-fd 0 -i
 /home/tlyu/src/chutney/net/nodes/000a/keys/authority_identity_key -s
 /home/tlyu/src/chutney/net/nodes/000a/keys/authority_signing_key -c
 /home/tlyu/src/chutney/net/nodes/000a/keys/authority_certificate -m 12 -a
 127.0.0.1:7000'. Use the CHUTNEY_TOR_GENCERT environment variable to set
 the path, or put the binary into $PATH:
 
'/home/tlyu/.cargo/bin:/home/tlyu/bin:/home/tlyu/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin'.
 If your $PATH contains ~, use $HOME instead.
 sed: can't read /home/tlyu/src/tor/build-
 norust/../../chutney/net/nodes/*a/torrc: No such file or directory
 Using Python 2.7.12
 Starting nodes

[tor-bugs] #27066 [Core Tor/Tor]: circuit_build_times_update_alpha(): Bug: Could not determine largest build time

2018-08-07 Thread Tor Bug Tracker & Wiki
#27066: circuit_build_times_update_alpha(): Bug: Could not determine largest 
build
time
--+--
 Reporter:  cstest|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.3.3.9
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 This bug occurs only when v3 hidden services are activated (4 hours after
 activation v3 services). This was my second test of v3 services and this
 issue repeated again. Server was running aprox.150 v3 domains.

 After below warnings, all hidden services stoped working.

 Could be related to #25733.


 {{{
 Aug 07 04:45:49.000 [warn] circuit_build_times_update_alpha(): Bug: Could
 not determine largest build time (0). Xm is 7525ms and we've abandoned 996
 out of 1000 circuits. (on Tor 0.3.3.9 )
 Aug 07 04:45:49.000 [warn] circuit_build_times_update_alpha(): Bug: Could
 not determine largest build time (0). Xm is 7525ms and we've abandoned 997
 out of 1000 circuits. (on Tor 0.3.3.9 )
 Aug 07 04:45:49.000 [warn] circuit_build_times_update_alpha(): Bug: Could
 not determine largest build time (0). Xm is 7525ms and we've abandoned 998
 out of 1000 circuits. (on Tor 0.3.3.9 )
 Aug 07 04:45:49.000 [warn] circuit_build_times_update_alpha(): Bug: Could
 not determine largest build time (0). Xm is 7525ms and we've abandoned 999
 out of 1000 circuits. (on Tor 0.3.3.9 )
 Aug 07 04:45:49.000 [warn] No valid circuit build time data out of 1000
 times, 3 modes, have_timeout=1, 7521.00ms
 Aug 07 04:45:49.000 [warn] No valid circuit build time data out of 1000
 times, 3 modes, have_timeout=1, 7521.00ms
 Aug 07 04:45:49.000 [warn] No valid circuit build time data out of 1000
 times, 3 modes, have_timeout=1, 7521.00ms
 Aug 07 04:45:49.000 [warn] No valid circuit build time data out of 1000
 times, 3 modes, have_timeout=1, 7521.00ms
 Aug 07 04:45:49.000 [warn] No valid circuit build time data out of 1000
 times, 3 modes, have_timeout=1, 7521.00ms
 Aug 07 04:45:49.000 [warn] No valid circuit build time data out of 1000
 times, 3 modes, have_timeout=1, 7521.00ms
 Aug 07 04:45:49.000 [warn] No valid circuit build time data out of 1000
 times, 3 modes, have_timeout=1, 7521.00ms
 Aug 07 04:45:49.000 [warn] No valid circuit build time data out of 1000
 times, 3 modes, have_timeout=1, 7521.00ms
 Aug 07 04:45:49.000 [warn] No valid circuit build time data out of 1000
 times, 3 modes, have_timeout=1, 7521.00ms
 Aug 07 04:45:49.000 [warn] No valid circuit build time data out of 1000
 times, 3 modes, have_timeout=1, 7521.00ms
 Aug 07 04:45:49.000 [warn] No valid circuit build time data out of 1000
 times, 3 modes, have_timeout=1, 7521.00ms
 ...
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27060 [Core Tor/Tor]: Improve coverag in a few high-coverage modules

2018-08-07 Thread Tor Bug Tracker & Wiki
#27060: Improve coverag in a few high-coverage modules
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 CI says it has memory leaks; will revise.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27056 [Core Tor/Tor]: sigusr2 only increases log verbosity to info, not debug

2018-08-07 Thread Tor Bug Tracker & Wiki
#27056: sigusr2 only increases log verbosity to info, not debug
-+-
 Reporter:  drjohnson1984|  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.7
 Severity:  Normal   | Resolution:  not a
 Keywords:  logging sigusr2 034-backport |  bug
  033-backport regression|  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_information => closed
 * resolution:   => not a bug


Comment:

 Okay; thanks for checking!  (And thanks for reporting in the first place
 when you thought you had a bug.  I'd rather have false positives than
 unreported bugs.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27065 [Applications/Tor Browser]: TBA: Delete AccountManager usage from Tabs

2018-08-07 Thread Tor Bug Tracker & Wiki
#27065: TBA: Delete AccountManager usage from Tabs
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-mobile
Actual Points:|  Parent ID:  #26858
   Points:|   Reviewer:
  Sponsor:|
--+
 When the app is started/restarted, it creates an
 `OnAccountsUpdatedListener` using the Android `AccountManager` in
 `Tabs.attachToContext()`. When a new account is added, the Listener calls
 `queuePersistAllTabs()` where the current tabs are cached in the local
 database on disk. We should avoid all of this. We already deleted most of
 the FxA and Sync related code, we can probably delete this, too.

 {{{
 mAccountManager = AccountManager.get(appContext);

 mAccountListener = new OnAccountsUpdateListener() {
 @Override
 public void onAccountsUpdated(Account[] accounts) {
 queuePersistAllTabs();
 }
 };

 // The listener will run on the background thread (see 2nd
 argument).
 mAccountManager.addOnAccountsUpdatedListener(mAccountListener,
 ThreadUtils.getBackgroundHandler(), false);
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26858 [Applications/Tor Browser]: TBA: Investigating patching AccountManager

2018-08-07 Thread Tor Bug Tracker & Wiki
#26858: TBA: Investigating patching AccountManager
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile|  Actual Points:
Parent ID:  #26531| Points:
 Reviewer:|Sponsor:
--+--

Comment (by sysrqb):

 Replying to [ticket:26858 sysrqb]:
 > Orfox previously patched some of the AccountManager and Sync code. Are
 these still needed?
 >
 > https://github.com/guardianproject/tor-
 browser/commit/45ba8e208975daebda7520ea0f111f475adba967

 1)  `mobile/android/base/java/org/mozilla/gecko/AccountsHelper.java`

   `AccountsHelper` is never used because we deleted the only instance in
 `BrowserApp` in `Bug 25741 - TBA: Neuter Firefox Accounts`.

 2) `ContactService.java`

   This was deleted in:
 {{{
 commit 9a8b60ffcae1d642096c9aaedfdd3cf37f87fe7f
 Author: Makoto Kato 
 Date:   Mon Aug 8 15:40:19 2016 +0900

 Bug 1284283 - Remove MozContact API Android backend. r=sebastian

 MozReview-Commit-ID: GLhrA1cc1Rq

 --HG--
 extra : rebase_source : 73efab6d9468388a6ba0be489250d8dd3d185cd6
 }}}

 3) `Tabs.java`

   This still exists, and an instance of AccountManager is still retrieved
 here. We should clean this. I believe the goal here is preventing the
 caching of current tabs on disk (`queuePersistAllTabs()`).

 4)
 
`mobile/android/base/java/org/mozilla/gecko/overlays/service/sharemethods/SendTab.java`

   We should clean this. It is initialized in `OverlayActionService.java`,
 it's a background service for handling sharing the current tab with
 another device (when FxA/sync are enabled).

 5)
 
`mobile/android/services/src/main/java/org/mozilla/gecko/fxa/FirefoxAccounts.java`

   Already cleaned in FxA neutering

 6)
 
`mobile/android/services/src/main/java/org/mozilla/gecko/fxa/activities/FxAccountStatusActivity.java`

   Needs cleaning.

 7)
 
`mobile/android/services/src/main/java/org/mozilla/gecko/sync/setup/SyncAccounts.java`

   Deleted in:
 {{{
 commit 4978a3514277d4cc310ee6e15072d15abd1dfe2a
 Author: Nick Alexander 
 Date:   Mon Jan 18 17:02:56 2016 -0800

 Bug 1220906 - Part 6: Remove Old Sync configuration code. r=rnewman

 --HG--
 extra : commitid : 1NbJi3JriIB
 extra : rebase_source : 895092b10bf20b0425e266a1d340e22b81f8daee
 }}}

 8)
 
`mobile/android/services/src/main/java/org/mozilla/gecko/sync/setup/activities/SetupSyncActivity.java`

   Deleted in:
 {{{
 commit 35d2682654031d011b46bb07344490686f748117
 Author: Nick Alexander 
 Date:   Tue Jan 19 11:31:31 2016 -0800

 Bug 1220906 - Part 5: Remove Old Sync setup and JPAKE code. r=rnewman

 --HG--
 extra : commitid : DrheDFD75zQ
 extra : rebase_source : 4249543a2df591bf042b93094a2f112fd8460805
 }}}


 > https://github.com/guardianproject/tor-
 browser/commit/b044089a93bd36ddb454ac11eecc72a2c295229c

 Already deleted in:
 {{{
 commit 99f346a73bde893c862bbb6504ff52f63b5b60e0
 Author: Amogh Pradeep 
 Date:   Fri Jul 17 13:27:07 2015 -0400

 Bug 25741 - TBA: Remove sync option from preferences

 We don't want this while the Sync subsystem is a proxy-bypass risk. We
 can drop this when the feature is patched.

 Signed-off-by: Amogh Pradeep 
 }}}

 But, we should delete in
 `mobile/android/app/src/main/res/xml/preferences_general_tablet.xml`, too.

 > https://github.com/guardianproject/tor-
 browser/commit/842618571bbe865657836447cbd50fffc027b582
 >

 This isn't needed because the firstrun page was changed so it used the
 `RestrictedWelcomePanel`, and TBA's onboarding/welcome will be custom-
 built.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25696 [Applications/Tor Browser]: Design of alpha onboarding for Tor Browser for Android

2018-08-07 Thread Tor Bug Tracker & Wiki
#25696: Design of alpha onboarding for Tor Browser for Android
-+-
 Reporter:  isabela  |  Owner:
 |  antonela
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team, tbb-mobile, |  Actual Points:
  TorBrowserTeam201808   |
Parent ID:  #26531   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-

Comment (by sysrqb):

 Replying to [comment:22 emmapeel]:
 > I have added it to transifex at https://www.transifex.com/otf/torproject
 /tba-android_stringsdtd/
 >
 > and it checks the file at
 >
 > https://gitweb.torproject.org/tor-
 browser.git/plain/mobile/android/base/locales/en-US/android_strings.dtd

 Hrm. Does this duplicate work from Mozilla? That file is currently
 localized by Mozilla, too. As an example, es-ES: https://hg.mozilla.org
 /l10n-central/es-ES/file/tip/mobile/android/base/android_strings.dtd

 I agree Tor Browser-specific strings must be localized, but will
 translators localize all strings in that file? Even if we only add a few
 new strings?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27056 [Core Tor/Tor]: sigusr2 only increases log verbosity to info, not debug

2018-08-07 Thread Tor Bug Tracker & Wiki
#27056: sigusr2 only increases log verbosity to info, not debug
-+-
 Reporter:  drjohnson1984|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_information
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.7
 Severity:  Normal   | Resolution:
 Keywords:  logging sigusr2 034-backport |  Actual Points:
  033-backport regression|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by drjohnson1984):

 Sorry to waste your time.  It was an rsyslogd issue.  this works fine.
 close it

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26965 [Internal Services/Tor Sysadmin Team]: Please create build in Jenkins for support.torproject.org and support-staging.torproject.org

2018-08-07 Thread Tor Bug Tracker & Wiki
#26965: Please create build in Jenkins for support.torproject.org and support-
staging.torproject.org
-+-
 Reporter:  hiro |  Owner:  tpa
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by hiro):

 * Attachment "0001-Update-portal-build-dependencies.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27056 [Core Tor/Tor]: sigusr2 only increases log verbosity to info, not debug

2018-08-07 Thread Tor Bug Tracker & Wiki
#27056: sigusr2 only increases log verbosity to info, not debug
-+-
 Reporter:  drjohnson1984|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_information
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.7
 Severity:  Normal   | Resolution:
 Keywords:  logging sigusr2 034-backport |  Actual Points:
  033-backport regression|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by drjohnson1984):

 There isn't much to tell.  I'm running a 0.3.3.7 tor relay.  I also have
 the tor source.  When it receives sigusr2, right after it changes the log-
 level settings in the signal handler, it calls log_debug saying it had
 switched to debug-level.  I never see this message.

 Let me go back and check a couple of things.  Make sure the rsyslogd isn't
 somehow routing debug-level messages to someplace other than
 /var/log/messages.  I will also start tor with debug-level logging to
 verify it is logging correctly.  I will update once I have done these

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25440 [Core Tor/Tor]: Broken openat syscall in Sandbox mode

2018-08-07 Thread Tor Bug Tracker & Wiki
#25440: Broken openat syscall in Sandbox mode
-+-
 Reporter:  ageisp0lis   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  sandbox, 033-must, regression,   |  Actual Points:
  033-triage-20180326, 033-included-20180326,|
  033-backport, AffectsTails,|
  034-deferred-20180602, 035-removed-20180711|
  029-backport 032-backport  |
Parent ID:   | Points:
 Reviewer:  nickm|Sponsor:
-+-

Comment (by Jigsaw52):

 It's a good ideia. I've tested it just to be sure it works and it does.
 I've updated my branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20643 [Internal Services/Service - deb.tpo]: make and maintain a registry of what debs are on deb.tp.o and why

2018-08-07 Thread Tor Bug Tracker & Wiki
#20643: make and maintain a registry of what debs are on deb.tp.o and why
-+-
 Reporter:  arma |  Owner:  irl
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - deb.tpo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  arma |Sponsor:
-+-

Comment (by atagar):

 Any reason we can't drop tor-arm?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23390 [Applications/Tor Browser]: TBB 7.5a4 STATUS_FATAL_APP_EXIT crash in msvcr100.dll

2018-08-07 Thread Tor Bug Tracker & Wiki
#23390: TBB 7.5a4 STATUS_FATAL_APP_EXIT crash in msvcr100.dll
--+--
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-crash |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by ct):

 FWIW, some sites still crash a content process in a clean TBB 7.5.6 on an
 up-to-date Win7 32-bit:
 {{{
 Faulting application name: firefox.exe, version: 52.9.0.6607, time stamp:
 0x
 Faulting module name: msvcr100.dll, version: 10.0.40219.325, time stamp:
 0x4df2be1e
 Exception code: 0x4015
 Fault offset: 0x0008d6fd
 }}}
 Related:
 https://forums.malwarebytes.com/topic/151017-appcrash-with-msvcr100dll/
 https://social.msdn.microsoft.com/Forums/vstudio/en-US/722402c4-7fc3-4b75
 -acca-bb443cf513db/program-crash-because-of-exception-0x4015-in-
 msvcr100dll
 https://social.msdn.microsoft.com/Forums/windows/en-US/87cfaa3f-765d-41bc-
 ac2f-0c869c63ddbb/appcrash-msvcr100dll-4015-on-newlyinstalled-
 application

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26965 [Internal Services/Tor Sysadmin Team]: Please create build in Jenkins for support.torproject.org and support-staging.torproject.org

2018-08-07 Thread Tor Bug Tracker & Wiki
#26965: Please create build in Jenkins for support.torproject.org and support-
staging.torproject.org
-+-
 Reporter:  hiro |  Owner:  tpa
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by hiro):

 * Attachment "0001-Force-plugins-reinstall-for-lektor.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23390 [Applications/Tor Browser]: TBB 7.5a4 STATUS_FATAL_APP_EXIT crash in msvcr100.dll

2018-08-07 Thread Tor Bug Tracker & Wiki
#23390: TBB 7.5a4 STATUS_FATAL_APP_EXIT crash in msvcr100.dll
--+--
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-crash |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by ct):

 https://stackoverflow.com/questions/9136958/how-to-fix-faulting-module-
 msvcr100-dll

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26965 [Internal Services/Tor Sysadmin Team]: Please create build in Jenkins for support.torproject.org and support-staging.torproject.org

2018-08-07 Thread Tor Bug Tracker & Wiki
#26965: Please create build in Jenkins for support.torproject.org and support-
staging.torproject.org
-+-
 Reporter:  hiro |  Owner:  tpa
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by hiro):

 * Attachment "0001-Add-depending-packages-to-lektor-build-job.patch"
 added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26965 [Internal Services/Tor Sysadmin Team]: Please create build in Jenkins for support.torproject.org and support-staging.torproject.org

2018-08-07 Thread Tor Bug Tracker & Wiki
#26965: Please create build in Jenkins for support.torproject.org and support-
staging.torproject.org
-+-
 Reporter:  hiro |  Owner:  tpa
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by hiro):

 * Attachment "0001-Add-build-job-for-support-portal.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20643 [Internal Services/Service - deb.tpo]: make and maintain a registry of what debs are on deb.tp.o and why

2018-08-07 Thread Tor Bug Tracker & Wiki
#20643: make and maintain a registry of what debs are on deb.tp.o and why
-+-
 Reporter:  arma |  Owner:  irl
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - deb.tpo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  arma |Sponsor:
-+-
Changes (by irl):

 * status:  accepted => needs_review
 * reviewer:   => arma


Comment:

 I have compiled information
 [[org/operations/Infrastructure/deb.torproject.org|here]].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #26667, #26863, #27042

2018-08-07 Thread Tor Bug Tracker & Wiki
Batch modification to #26667, #26863, #27042 by irl:
parent to 27064

--
Tickets URL: 

Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27064 [Metrics/Website]: Batch merge for Relay Search patches

2018-08-07 Thread Tor Bug Tracker & Wiki
#27064: Batch merge for Relay Search patches
-+--
 Reporter:  irl  |  Owner:  metrics-team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+--
 Please merge the 5 commits in my [[https://gitweb.torproject.org/user/irl
 /metrics-web.git/log/?h=relaysearch-dev|relaysearch-dev]] branch. The last
 commit is fb630f0.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26667 [Metrics/Relay Search]: Add "Experimental" and "Obsolete" additional flags

2018-08-07 Thread Tor Bug Tracker & Wiki
#26667: Add "Experimental" and "Obsolete" additional flags
--+--
 Reporter:  irl   |  Owner:  metrics-team
 Type:  enhancement   | Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Metrics/Relay Search  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by irl):

 * status:  new => merge_ready


Comment:

 https://gitweb.torproject.org/user/irl/metrics-
 web.git/commit/?h=task/26667=fb630f0b81b2e1341f38af1bb5b324f1d73a6da0

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27033 [UX/Research]: Usability Research: Tor Launcher

2018-08-07 Thread Tor Bug Tracker & Wiki
#27033: Usability Research: Tor Launcher
+--
 Reporter:  nyinz   |  Owner:  nyinz
 Type:  project | Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  UX/Research |Version:
 Severity:  Normal  | Resolution:
 Keywords:  user-demographics, ux-team  |  Actual Points:
Parent ID:  #27010  | Points:
 Reviewer:  antonela|Sponsor:
+--
Changes (by antonela):

 * component:  - Select a component => UX/Research


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27032 [UX/Research]: Usability Research: Tor Users Demographics - Applications

2018-08-07 Thread Tor Bug Tracker & Wiki
#27032: Usability Research: Tor Users Demographics - Applications
+--
 Reporter:  nyinz   |  Owner:  nyinz
 Type:  project | Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  UX/Research |Version:
 Severity:  Normal  | Resolution:
 Keywords:  user-demographics, ux-team  |  Actual Points:
Parent ID:  #27010  | Points:
 Reviewer:  antonela|Sponsor:
+--
Changes (by antonela):

 * component:  - Select a component => UX/Research


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27010 [UX/Research]: UX Research

2018-08-07 Thread Tor Bug Tracker & Wiki
#27010: UX Research
-+--
 Reporter:  antonela |  Owner:  nyinz
 Type:  project  | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  UX/Research  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:  Sponsor9
-+--
Changes (by antonela):

 * component:  ux/research => UX/Research


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27010 [ux/research]: UX Research

2018-08-07 Thread Tor Bug Tracker & Wiki
#27010: UX Research
-+--
 Reporter:  antonela |  Owner:  nyinz
 Type:  project  | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  ux/research  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:  Sponsor9
-+--
Changes (by antonela):

 * component:  Community/Outreach => ux/research


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27063 [Internal Services/Tor Sysadmin Team]: Drop helix from the gitolite maintainer role

2018-08-07 Thread Tor Bug Tracker & Wiki
#27063: Drop helix from the gitolite maintainer role
-+-
 Reporter:  arma |  Owner:  tpa
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by irl):

 * owner:  tor-gitadm => tpa
 * component:  Internal Services/Service - git => Internal Services/Tor
 Sysadmin Team


Comment:

 Dropped from the gitolite config.

 Please remove erinn from the gitolite and gitweb groups.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27063 [Internal Services/Service - git]: Drop helix from the gitolite maintainer role

2018-08-07 Thread Tor Bug Tracker & Wiki
#27063: Drop helix from the gitolite maintainer role
-+
 Reporter:  arma |  Owner:  tor-gitadm
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+
 The infrastructure wiki page says that the git-rw admins are erinn, nickm,
 sebastian, weasel:
 https://trac.torproject.org/projects/tor/wiki/org/operations/Infrastructure

 I hear irl has become a new git-rw admin (yay), and also weasel has moved
 himself to a backup (emergency rescue) role.

 We should disable erinn's gitolite admin bits for now, on the "information
 hygiene" principle, since she hasn't been doing that role for a good while
 now and we have enough people who are. She can always resume doing it if
 she becomes more active again.

 And when we've done these things we should update the git-rw box in the
 infrastructure wiki page.

 Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26669 [Webpages/Styleguide]: Add a new icon for "Obsolete"

2018-08-07 Thread Tor Bug Tracker & Wiki
#26669: Add a new icon for "Obsolete"
-+--
 Reporter:  irl  |  Owner:  hiro
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Webpages/Styleguide  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #26667   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by irl):

 * status:  merge_ready => needs_review
 * reviewer:  antonela =>


Comment:

 This is now merged in the tor-icons repository.

 I have also made a patch for styleguide which can be found in my
 
[[https://gitweb.torproject.org/user/irl/styleguide.git/commit/?h=task/26669=4ecc7affd72e3b0dd71037499dbba6d2482b4715|task/26669]]
 branch. It also includes the icon from #26668.

 hiro (or antonela) - Can you please review and merge this in the
 styleguide repository?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26668 [Webpages/Styleguide]: Add a new icon for "Experimental"

2018-08-07 Thread Tor Bug Tracker & Wiki
#26668: Add a new icon for "Experimental"
-+
 Reporter:  irl  |  Owner:  hiro
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Webpages/Styleguide  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:  #26667   | Points:
 Reviewer:  antonela |Sponsor:
-+
Changes (by irl):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Will finish this in #26669.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27048 [Metrics/Consensus Health]: Bandwidth scanner graphs are empty

2018-08-07 Thread Tor Bug Tracker & Wiki
#27048: Bandwidth scanner graphs are empty
--+
 Reporter:  teor  |  Owner:  tom
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Metrics/Consensus Health  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by tom):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 Fixed!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26392 [Internal Services/Service - git]: Please move the `tor-browser/sandboxed-tor-browser` repo to the attic.

2018-08-07 Thread Tor Bug Tracker & Wiki
#26392: Please move the `tor-browser/sandboxed-tor-browser` repo to the attic.
-+
 Reporter:  yawning  |  Owner:  tor-gitadm
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by irl):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 done.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26364 [Internal Services/Service - git]: Please remove these unused repositorities to the attic

2018-08-07 Thread Tor Bug Tracker & Wiki
#26364: Please remove these unused repositorities to the attic
-+
 Reporter:  karsten  |  Owner:  tor-gitadm
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by irl):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 This was already done by hiro on 2018-07-04.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27062 [Internal Services/Service - git]: Please create new repository user/irl/styleguide.git

2018-08-07 Thread Tor Bug Tracker & Wiki
#27062: Please create new repository user/irl/styleguide.git
-+
 Reporter:  irl  |  Owner:  irl
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by irl):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 done

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25485 [Applications/Tor Browser]: Browser/TorBrowser/Tor/libstdc++.so.6: version `CXXABI_1.3.11' not found (required by /usr/lib/x86_64-linux-gnu/libmirclient.so.9)

2018-08-07 Thread Tor Bug Tracker & Wiki
#25485: Browser/TorBrowser/Tor/libstdc++.so.6: version `CXXABI_1.3.11' not found
(required by /usr/lib/x86_64-linux-gnu/libmirclient.so.9)
+--
 Reporter:  cypherpunks |  Owner:  tbb-team
 Type:  defect  | Status:  needs_review
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201808  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by sukhbir):

 * status:  needs_revision => needs_review


Comment:

 Branch with the review changes (comments in `abicheck.cc` and updated
 directory name):

 https://github.com/azadi/tor-browser-build-1/tree/bug-25485-rev2

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26965 [Internal Services/Tor Sysadmin Team]: Please create build in Jenkins for support.torproject.org and support-staging.torproject.org

2018-08-07 Thread Tor Bug Tracker & Wiki
#26965: Please create build in Jenkins for support.torproject.org and support-
staging.torproject.org
-+-
 Reporter:  hiro |  Owner:  tpa
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by hiro):

 * Attachment "0001-Create-build-jobs-for-support-and-support-staging-
 we.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27062 [Internal Services/Service - git]: Please create new repository user/irl/styleguide.git

2018-08-07 Thread Tor Bug Tracker & Wiki
#27062: Please create new repository user/irl/styleguide.git
-+--
 Reporter:  irl  |  Owner:  irl
 Type:  task | Status:  accepted
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by irl):

 * owner:  tor-gitadm => irl
 * status:  new => accepted


Comment:

 Time for me to learn how to do this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27062 [Internal Services/Service - git]: Please create new repository user/irl/styleguide.git

2018-08-07 Thread Tor Bug Tracker & Wiki
#27062: Please create new repository user/irl/styleguide.git
-+
 Reporter:  irl  |  Owner:  tor-gitadm
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+
 RW for me, R for everyone else

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26988 [Webpages/Website]: Please add job to website - Bookkeeper/Payroll Specialist

2018-08-07 Thread Tor Bug Tracker & Wiki
#26988: Please add job to website - Bookkeeper/Payroll Specialist
--+
 Reporter:  ewyatt|  Owner:  (none)
 Type:  task  | Status:  closed
 Priority:  Very High |  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by rl1987):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 
https://github.com/torproject/webwml/commit/9e01724acb41b2102f12bc85e74c76a3908e8ab0
 https://www.torproject.org/about/jobs-payrollspecialist.html.en

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26989 [Webpages/Website]: Please add job to website - Grant Writer

2018-08-07 Thread Tor Bug Tracker & Wiki
#26989: Please add job to website - Grant Writer
--+
 Reporter:  ewyatt|  Owner:  (none)
 Type:  task  | Status:  closed
 Priority:  Very High |  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by rl1987):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 
https://github.com/torproject/webwml/commit/9e01724acb41b2102f12bc85e74c76a3908e8ab0
 https://www.torproject.org/about/jobs-grantwriter.html.en

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26990 [Webpages/Website]: Please add job to website - Grants Manager

2018-08-07 Thread Tor Bug Tracker & Wiki
#26990: Please add job to website - Grants Manager
--+
 Reporter:  ewyatt|  Owner:  (none)
 Type:  task  | Status:  closed
 Priority:  Very High |  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by rl1987):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 
https://github.com/torproject/webwml/commit/9e01724acb41b2102f12bc85e74c76a3908e8ab0
 https://www.torproject.org/about/jobs-grantsmanager.html.en

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26669 [Webpages/Styleguide]: Add a new icon for "Obsolete"

2018-08-07 Thread Tor Bug Tracker & Wiki
#26669: Add a new icon for "Obsolete"
-+-
 Reporter:  irl  |  Owner:  hiro
 Type:  enhancement  | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Webpages/Styleguide  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #26667   | Points:
 Reviewer:  antonela |Sponsor:
-+-
Changes (by irl):

 * status:  needs_review => merge_ready


Comment:

 Awesome!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25485 [Applications/Tor Browser]: Browser/TorBrowser/Tor/libstdc++.so.6: version `CXXABI_1.3.11' not found (required by /usr/lib/x86_64-linux-gnu/libmirclient.so.9)

2018-08-07 Thread Tor Bug Tracker & Wiki
#25485: Browser/TorBrowser/Tor/libstdc++.so.6: version `CXXABI_1.3.11' not found
(required by /usr/lib/x86_64-linux-gnu/libmirclient.so.9)
+--
 Reporter:  cypherpunks |  Owner:  tbb-team
 Type:  defect  | Status:
|  needs_revision
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201808  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by boklm):

 * status:  needs_review => needs_revision


Comment:

 I think we could add a comment in `projects/firefox/abicheck.cc`
 mentioning this ticket, and explaining that we found that this program is
 requiring `GLIBCXX_3.4.22`, which make it useful to check that the
 required version of libstdc++ is available.

 Otherwise the changes look good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26669 [Webpages/Styleguide]: Add a new icon for "Obsolete"

2018-08-07 Thread Tor Bug Tracker & Wiki
#26669: Add a new icon for "Obsolete"
-+--
 Reporter:  irl  |  Owner:  hiro
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Webpages/Styleguide  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #26667   | Points:
 Reviewer:  antonela |Sponsor:
-+--

Comment (by antonela):

 Perfect! I see the 'bug' as the best way to represent the idea you want to
 render.
 Thanks for making them irl!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25485 [Applications/Tor Browser]: Browser/TorBrowser/Tor/libstdc++.so.6: version `CXXABI_1.3.11' not found (required by /usr/lib/x86_64-linux-gnu/libmirclient.so.9)

2018-08-07 Thread Tor Bug Tracker & Wiki
#25485: Browser/TorBrowser/Tor/libstdc++.so.6: version `CXXABI_1.3.11' not found
(required by /usr/lib/x86_64-linux-gnu/libmirclient.so.9)
+--
 Reporter:  cypherpunks |  Owner:  tbb-team
 Type:  defect  | Status:  needs_review
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201808  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by sukhbir):

 Replying to [comment:30 boklm]:
 > Replying to [comment:28 sukhbir]:
 >
 > > I decided to move the bundled libstdc++.so.6 to an additional `Lib`
 directory to make it easier to deal with `LD_LIBRARY_PATH`. Let me know if
 you prefer another way. Tested on Ubuntu 16.04.
 >
 > Yes, moving it to a sub-directory sounds good. I'm thinking that maybe
 that sub-directory should be named something like `libstdc++` to make it
 more clear what it is.

 OK I updated that to `libstdc++`. I will submit the new branch after the
 complete review in case there are other changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26669 [Webpages/Styleguide]: Add a new icon for "Obsolete"

2018-08-07 Thread Tor Bug Tracker & Wiki
#26669: Add a new icon for "Obsolete"
-+--
 Reporter:  irl  |  Owner:  hiro
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Webpages/Styleguide  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #26667   | Points:
 Reviewer:  antonela |Sponsor:
-+--

Comment (by irl):

 I guess the implications of having old relay software is that you may have
 bugs that prevent the relay from being as good as it can be. They're not
 necessarily security bugs, but maybe just missing features that are
 holding back deployment of a new thing in the Tor network (like IPv6
 support of v3 onion service features).

 I've changed it to a bug, which I think does better capture it. A penny
 farthing was a nice idea but I don't think it's universal enough and it
 doesn't render very well at 16x16 pixels as it's a lot of thin lines.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25485 [Applications/Tor Browser]: Browser/TorBrowser/Tor/libstdc++.so.6: version `CXXABI_1.3.11' not found (required by /usr/lib/x86_64-linux-gnu/libmirclient.so.9)

2018-08-07 Thread Tor Bug Tracker & Wiki
#25485: Browser/TorBrowser/Tor/libstdc++.so.6: version `CXXABI_1.3.11' not found
(required by /usr/lib/x86_64-linux-gnu/libmirclient.so.9)
+--
 Reporter:  cypherpunks |  Owner:  tbb-team
 Type:  defect  | Status:  needs_review
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201808  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by boklm):

 Replying to [comment:28 sukhbir]:

 > I decided to move the bundled libstdc++.so.6 to an additional `Lib`
 directory to make it easier to deal with `LD_LIBRARY_PATH`. Let me know if
 you prefer another way. Tested on Ubuntu 16.04.

 Yes, moving it to a sub-directory sounds good. I'm thinking that maybe
 that sub-directory should be named something like `libstdc++` to make it
 more clear what it is.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27061 [Applications/Tor Browser]: Enable verification of langpacks checksums

2018-08-07 Thread Tor Bug Tracker & Wiki
#27061: Enable verification of langpacks checksums
-+-
 Reporter:  boklm|  Owner:  tbb-team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  tbb-rbm,
 Severity:  Normal   |  TorBrowserTeam201808
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 When switching to esr60 we temporarily disabled the checking of langpacks
 checksums in `projects/firefox-langpacks/build` because they were missing
 in the SHA512SUMS files.

 It looks like the bug causing this issue will be fixed soon:
 https://bugzilla.mozilla.org/show_bug.cgi?id=1463749

 We should enable this check again in the next release where this bug has
 been fixed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26668 [Webpages/Styleguide]: Add a new icon for "Experimental"

2018-08-07 Thread Tor Bug Tracker & Wiki
#26668: Add a new icon for "Experimental"
-+-
 Reporter:  irl  |  Owner:  hiro
 Type:  enhancement  | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Webpages/Styleguide  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #26667   | Points:
 Reviewer:  antonela |Sponsor:
-+-
Changes (by irl):

 * status:  needs_review => merge_ready


Comment:

 I hadn't seen that one! Updated.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25485 [Applications/Tor Browser]: Browser/TorBrowser/Tor/libstdc++.so.6: version `CXXABI_1.3.11' not found (required by /usr/lib/x86_64-linux-gnu/libmirclient.so.9)

2018-08-07 Thread Tor Bug Tracker & Wiki
#25485: Browser/TorBrowser/Tor/libstdc++.so.6: version `CXXABI_1.3.11' not found
(required by /usr/lib/x86_64-linux-gnu/libmirclient.so.9)
+--
 Reporter:  cypherpunks |  Owner:  tbb-team
 Type:  defect  | Status:  needs_review
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201808  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by sukhbir):

 Additionally, I decided to put this `projects/firefox` and not `projects
 /tor-browser` as gcc/g++ was already in scope for `/firefox` and I didn't
 want to bring it in for `/tor-browser'.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25485 [Applications/Tor Browser]: Browser/TorBrowser/Tor/libstdc++.so.6: version `CXXABI_1.3.11' not found (required by /usr/lib/x86_64-linux-gnu/libmirclient.so.9)

2018-08-07 Thread Tor Bug Tracker & Wiki
#25485: Browser/TorBrowser/Tor/libstdc++.so.6: version `CXXABI_1.3.11' not found
(required by /usr/lib/x86_64-linux-gnu/libmirclient.so.9)
+--
 Reporter:  cypherpunks |  Owner:  tbb-team
 Type:  defect  | Status:  needs_review
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201808  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by sukhbir):

 * status:  needs_revision => needs_review


Comment:

 For review:

 https://github.com/azadi/tor-browser-build-1/tree/bug-25485-rev1

 I decided to move the bundled libstdc++.so.6 to an additional `Lib`
 directory to make it easier to deal with `LD_LIBRARY_PATH`. Let me know if
 you prefer another way. Tested on Ubuntu 16.04.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26965 [Internal Services/Tor Sysadmin Team]: Please create build in Jenkins for support.torproject.org and support-staging.torproject.org

2018-08-07 Thread Tor Bug Tracker & Wiki
#26965: Please create build in Jenkins for support.torproject.org and support-
staging.torproject.org
-+-
 Reporter:  hiro |  Owner:  tpa
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by weasel):

 Added the patch, slightly modified to git.  Also added a job.  Doesn't
 build quite yet.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26863 [Metrics/Relay Search]: display onionoo and RS version on RS pages

2018-08-07 Thread Tor Bug Tracker & Wiki
#26863: display onionoo and RS version on RS pages
--+--
 Reporter:  nusenu|  Owner:  metrics-team
 Type:  enhancement   | Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Metrics/Relay Search  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by irl):

 * status:  new => merge_ready


Comment:

 https://gitweb.torproject.org/user/irl/metrics-
 web.git/commit/?h=task/26863=0c09769ceeb20c6eda336c34626fadbfefe218c3

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25702 [Applications/Tor Browser]: Activity 1.1 Update Tor Browser icon to follow design guidelines.

2018-08-07 Thread Tor Bug Tracker & Wiki
#25702: Activity 1.1 Update Tor Browser icon to follow design guidelines.
--+---
 Reporter:  isabela   |  Owner:  antonela
 Type:  defect| Status:  assigned
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ux-team, tbb-mobile   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:  Sponsor17
--+---

Comment (by antonela):

 **Step 0**

 The first thing I did was to explore and list

 a. current Browsers Icons
 b. current "Tor Browsers" Icons

 
https://trac.torproject.org/projects/tor/attachment/ticket/25702/25702%20-%20TorBrowser%20Icon%20
 -%20Explore-min.png

 The number of unofficial aka no related to Tor Project, Inc. apps is huge,
 and I wanted to explore what people "improved" making their version. The
 first question that came to my mind is: Why we have a globe and not an
 onion there? Then: Does Tor Browser want to present itself in a way that
 people can relate it with a Privacy/Security tool? Should Tor Project, Inc
 visual style, and colors be related with Tor Browser Icon?

 I'd like to collect our community feelings and/or ideas about what Tor
 Browser means for you.

 So, I made a little survey that will be collecting feelings for two weeks:

 https://survey.torproject.org/index.php/844392

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25702 [Applications/Tor Browser]: Activity 1.1 Update Tor Browser icon to follow design guidelines.

2018-08-07 Thread Tor Bug Tracker & Wiki
#25702: Activity 1.1 Update Tor Browser icon to follow design guidelines.
--+---
 Reporter:  isabela   |  Owner:  antonela
 Type:  defect| Status:  assigned
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ux-team, tbb-mobile   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:  Sponsor17
--+---

Comment (by antonela):

 Hi all! We get back to work on this task. We'll be documenting all the
 process here.

 The steps we'll follow are outlined here:

 0. Research concepts/ideas based on people perception of the product.
 Explore paths to follow.
 1. Research with TPI internal what we want to communicate. Explore
 concepts that can coexist.
 2. Develop three or four concepts from the paths that emerged from
 explorations. Colors, applications, variables, etc.
 3. The community will speak loud. Open blog/comments discussion.
 4. Assets creation - Update all sources with new icons.

 

 If you are a visual designer or/and someone who like to play with colors,
 shapes, and meanings, this line is to encourage you to add your ideas
 here! I can't promise that we are going to pick your option, but it will
 help us to think divergently about our next Tor Browser icon.

 If you don't have graphic design skills, but you have opinions, please
 share them in a way that they can start a conversation. Yes! Here is the
 place to do it now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26965 [Internal Services/Tor Sysadmin Team]: Please create build in Jenkins for support.torproject.org and support-staging.torproject.org

2018-08-07 Thread Tor Bug Tracker & Wiki
#26965: Please create build in Jenkins for support.torproject.org and support-
staging.torproject.org
-+-
 Reporter:  hiro |  Owner:  tpa
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by hiro):

 Updated patch according to feedback.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26965 [Internal Services/Tor Sysadmin Team]: Please create build in Jenkins for support.torproject.org and support-staging.torproject.org

2018-08-07 Thread Tor Bug Tracker & Wiki
#26965: Please create build in Jenkins for support.torproject.org and support-
staging.torproject.org
-+-
 Reporter:  hiro |  Owner:  tpa
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by hiro):

 * Attachment "0001-Create-build-jobs-for-support-and-support-staging-
 we.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26983 [Metrics/Relay Search]: Add support for 6 months graphs in the plotting functions

2018-08-07 Thread Tor Bug Tracker & Wiki
#26983: Add support for 6 months graphs in the plotting functions
--+
 Reporter:  irl   |  Owner:  irl
 Type:  enhancement   | Status:  merge_ready
 Priority:  Medium|  Milestone:  Onionoo 1.17.0
Component:  Metrics/Relay Search  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #25175| Points:
 Reviewer:|Sponsor:
--+
Changes (by irl):

 * status:  accepted => merge_ready
 * milestone:   => Onionoo 1.17.0


Comment:

 Having looked closer at this, this is already supported as long as the 3
 months graphs are removed. The only thing that will need updating is the
 text in the template, the actual graphs would appear under the 3 months
 tab but include 6 months of data.

 [[https://gitweb.torproject.org/user/irl/metrics-
 web.git/commit/?h=task/26983|This commit]] should be merged along with the
 spec update in metrics-web when we deploy Onionoo protocol version 7.0.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27042 [Metrics/Relay Search]: Relay Search should not claim recommended_version is false when onionoo makes no statement about it

2018-08-07 Thread Tor Bug Tracker & Wiki
#27042: Relay Search should not claim recommended_version is false when onionoo
makes no statement about it
--+--
 Reporter:  BHydden   |  Owner:  irl
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Metrics/Relay Search  |Version:  Tor: 0.3.3.9
 Severity:  Normal| Resolution:
 Keywords:  bridge flag   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by irl):

 * status:  accepted => merge_ready


Comment:

 https://gitweb.torproject.org/user/irl/metrics-
 web.git/commit/?h=task/27042=a5991457e9302d5e8283b04998c9810b2ad862ba

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27039 [Metrics/Onionoo]: Timestamps in graph history documents are incorrectly formatted

2018-08-07 Thread Tor Bug Tracker & Wiki
#27039: Timestamps in graph history documents are incorrectly formatted
-+--
 Reporter:  starlight|  Owner:  irl
 Type:  defect   | Status:  accepted
 Priority:  High |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by karsten):

 I'll start with the small tool and will let you know here how that works.
 Feel free to start with the actual patch in the meantime, but if you're
 busy with other tickets, I'll do that after finishing the tool.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26864 [Metrics/Relay Search]: did #18342 break RS' display of the host_name field?

2018-08-07 Thread Tor Bug Tracker & Wiki
#26864: did #18342 break RS' display of the host_name field?
--+--
 Reporter:  nusenu|  Owner:  metrics-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Metrics/Relay Search  |Version:
 Severity:  Normal| Resolution:  not a bug
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by irl):

 * status:  new => closed
 * resolution:   => not a bug


Comment:

 Relay Search is correctly displaying what Onionoo has, there are still
 some issues in Onionoo though in #27050.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27039 [Metrics/Onionoo]: Timestamps in graph history documents are incorrectly formatted

2018-08-07 Thread Tor Bug Tracker & Wiki
#27039: Timestamps in graph history documents are incorrectly formatted
-+--
 Reporter:  starlight|  Owner:  irl
 Type:  defect   | Status:  accepted
 Priority:  High |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by irl):

 karsten - I've been looking at other Relay Search tickets and was going to
 loop back round to this one. The option with the small tool looks like the
 best path to take, do you want to take this instead as you'll probably be
 able to do it quicker than me?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27039 [Metrics/Onionoo]: Timestamps in graph history documents are incorrectly formatted

2018-08-07 Thread Tor Bug Tracker & Wiki
#27039: Timestamps in graph history documents are incorrectly formatted
-+--
 Reporter:  starlight|  Owner:  irl
 Type:  defect   | Status:  accepted
 Priority:  High |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by karsten):

 Yes, I think that's the issue. Looks like we did not include the
 `GraphHistory` class when we added Jackson-related annotations in 52494a7.

 The fix is probably as simple as copying those annotations from `Document`
 to `GraphHistory`.

 But how do we fix existing files in `out/` directories?
  - We could wait until new files are being written and accept that old
 files might be broken. Not very nice.
  - We could change the servlet to read all history files and rewrite them
 before including them in a response. Not very efficient.
  - We could write a small tool to run on an existing `out/` directory that
 reads in history files and overwrites them, if they are broken. Might be
 okay.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27003 [Core Tor/Tor]: Regression: 'SETCONF ORPort' can kill tor process

2018-08-07 Thread Tor Bug Tracker & Wiki
#27003: Regression: 'SETCONF ORPort' can kill tor process
---+---
 Reporter:  atagar |  Owner:  nickm
 Type:  defect | Status:  closed
 Priority:  High   |  Milestone:  Tor:
   |  0.3.5.x-final
Component:  Core Tor/Tor   |Version:  Tor:
   |  unspecified
 Severity:  Normal | Resolution:  fixed
 Keywords:  regression, 035-must 034-backport  |  Actual Points:
Parent ID: | Points:
 Reviewer:  asn|Sponsor:
---+---
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 okay, merged to 0.3.4 and forward.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27039 [Metrics/Onionoo]: Timestamps in graph history documents are incorrectly formatted (was: Relay Search graphs missing)

2018-08-07 Thread Tor Bug Tracker & Wiki
#27039: Timestamps in graph history documents are incorrectly formatted
-+--
 Reporter:  starlight|  Owner:  irl
 Type:  defect   | Status:  accepted
 Priority:  High |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by irl):

 * priority:  Medium => High
 * component:  Metrics/Relay Search => Metrics/Onionoo


Old description:

> maintenance or a problem?  No graphs at time of ticket.

New description:

 Timestamps in graph history documents are being served as ints (maybe unix
 timestamps) instead of -MM-DD hh:mm:ss format.

 This has the result of breaking Relay Search's graphs and also of breaking
 the t-shirt script.

--

Comment:

 I think it's possible that the getter is being used instead of the
 variable, which parses the String to return a long.

 
https://gitweb.torproject.org/onionoo.git/tree/src/main/java/org/torproject/onionoo/docs/GraphHistory.java#n16

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27039 [Metrics/Relay Search]: Relay Search graphs missing

2018-08-07 Thread Tor Bug Tracker & Wiki
#27039: Relay Search graphs missing
--+--
 Reporter:  starlight |  Owner:  irl
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:
Component:  Metrics/Relay Search  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by irl):

 This is definitely the same problem. The Relay Search error is that it
 can't perform a string split on an int.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27060 [Core Tor/Tor]: Improve coverag in a few high-coverage modules

2018-08-07 Thread Tor Bug Tracker & Wiki
#27060: Improve coverag in a few high-coverage modules
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * milestone:   => Tor: 0.3.5.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27060 [Core Tor/Tor]: Improve coverag in a few high-coverage modules

2018-08-07 Thread Tor Bug Tracker & Wiki
#27060: Improve coverag in a few high-coverage modules
--+--
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by nickm):

 * status:  assigned => needs_review


Comment:

 See branch "coverage_6aug"; PR at
 https://github.com/torproject/tor/pull/264

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27060 [Core Tor/Tor]: Improve coverag in a few high-coverage modules

2018-08-07 Thread Tor Bug Tracker & Wiki
#27060: Improve coverag in a few high-coverage modules
--+--
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 I wrote some tests last night while I was burned out on other things.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27059 [- Select a component]: Use sane about:config values

2018-08-07 Thread Tor Bug Tracker & Wiki
#27059: Use sane about:config values
--+
 Reporter:  floweb|  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  High  |  Milestone:
Component:  - Select a component  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 While reading through various about:config security hardening guides, I
 found several bad default values for the Tor Browser:

 1. dom.event.clipboardevents.enabled = false
 - Disable that websites can get notifications if you copy, paste, or
 cut something from a web page, and it lets them know which part of the
 page had been selected.

 2. network.http.referer.trimmingPolicy = 2
 - Send only the scheme, host, and port in the Referer header
 - 0 = Send the full URL in the Referer header
 - 1 = Send the URL without its query string in the Referer header
 - 2 = Send only the scheme, host, and port in the Referer header

 3. network.http.referer.XOriginPolicy = 2
 - Only send Referer header when the full hostnames match. (Note: if
 you notice significant breakage, you might try 1 combined with an
 XOriginTrimmingPolicy tweak below.) Source
 - 0 = Send Referer in all cases
 - 1 = Send Referer to same eTLD sites
 - 2 = Send Referer only when the full hostnames match

 4. network.http.referer.XOriginTrimmingPolicy = 2
 - When sending Referer across origins, only send scheme, host, and
 port in the Referer header of cross-origin requests. Source
 - 0 = Send full url in Referer
 - 1 = Send url without query string in Referer
 - 2 = Only send scheme, host, and port in Referer

 5. webgl.disabled = true
 - WebGL is a potential security risk. Source

 6. network.IDN_show_punycode = true
  - Not rendering IDNs as their punycode equivalent leaves you open to
 phishing attacks that can be very difficult to notice. Source

 7. dom.event.contextmenu.enabled = false
 - Don't allow websites to prevent use of right-click, or otherwise
 messing with the context menu.

 8. network.http.speculative-parallel-limit = 0
 - Disable prefetch link on hover.

 9. extensions.pocket.enabled = false
 - Disable Firefox pocket

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #9809 [Applications/Tor Browser]: Re-disable Ctypes in TBB 7.0

2018-08-07 Thread Tor Bug Tracker & Wiki
#9809: Re-disable Ctypes in TBB 7.0
+--
 Reporter:  mikeperry   |  Owner:  tbb-team
 Type:  enhancement | Status:  new
 Priority:  High|  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-3.0, tbb-firefox-patch  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by ct):

 Didn't Mozilla fix it in esr60?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

  1   2   >