[tor-bugs] #27196 [Applications/Tor bundles/installation]: TB 8a10 and panopticlick: your browser has a unique fingerprint

[Tor Bug Tracker & Wiki]

#27196: TB 8a10 and panopticlick: your browser has a unique fingerprint
-+-
 Reporter:  traumschule  |  Owner:  erinn
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  bundles/installation   |   Keywords:  ff60-esr, tbb-usability
 Severity:  Normal   |  tbb-security, tbb-performance
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 The bundle works fine, thanks for your great work!

 I am surprised by the new yellow blinking triangle over the onion settings
 button. What does it mean? (The tooltip only says "Tor Enabled")

 = Update NoScript to 10.1.8.16
 In NoScript preferences the list of per-site definitions was empty, I
 added a site and clicked on reset: a lot of whitelisted domains appeared
 (#26517).

 = Trackers
 As discussed before (#12958),
 
[https://trac.torproject.org/projects/tor/wiki/org/teams/CommunityTeam/Support_discuss
 #CanIinstallanewadd-onorextensioninTorBrowserlikeAdBlockPlusoruBlockOrigin
 blocking content allows fingerprinting], instead
 [[comment:4:ticket:12958|you suggest]] "an identical blocklist for every
 user. For example, AdBlock Plus with a fixed set of filters." Do you have
 plans to do this? (I am aware of your answers for
 [[comment:1:ticket:15279|uMatrix]] and [[comment:54:ticket:17569|ublock
 origin]] and spare you to repost everything :)
 (mentioning [https://riseup.net/en/security/network-security/better-web-
 browsing Riseup's recommendations] + requestblock for a balanced
 perspective, because I do not follow the conclusion that external requests
 should be accepted just not to be finger-printable. For me personally it's
 worse, when trackers know that I visited a site.)

 #14924 sounds reasonable.

 = EFF/Panopticlick
 wants me to install privacybadger (not voting for it here, because of
 #12958)
 Is your browser blocking tracking ads?  ⚠ partial protection
 Is your browser blocking invisible trackers?⚠ partial protection
 Does your blocker stop trackers that are included in the so-called
 “acceptable ads” whitelist?  ✗ no
 Does your browser unblock 3rd parties that promise to honor Do Not Track?
 ✗ no
 Does your browser protect from fingerprinting?  ✗
 your browser has a unique fingerprint
 https://share.riseup.net/#3RwdPLNSuFFZcK9MA_6l8g

 I consider the defaults dangerous ([[comment:3:ticket:25451|window
 size]]). Why not setting the security slider to "Safest" per default?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27192 [Core Tor/Tor]: Perform --verify-config before reloading tor

[Tor Bug Tracker & Wiki]

#27192: Perform --verify-config before reloading tor
--+--
 Reporter:  traumschule   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by teor):

 I think this might be a duplicate of #21818. What do you think?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27190 [Core Tor/Tor]: disparate duplicate subproto handling in protover

[Tor Bug Tracker & Wiki]

#27190: disparate duplicate subproto handling in protover
--+
 Reporter:  cyberpunks|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust, 033-backport, 034-backport  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * keywords:  rust => rust, 033-backport, 034-backport


Comment:

 No, duplicate subprotocol entries are allowed by the spec:
 https://gitweb.torproject.org/torspec.git/tree/dir-spec.txt#n780

 The rust code is wrong, and should be fixed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27190 [Core Tor/Tor]: disparate duplicate subproto handling in protover

[Tor Bug Tracker & Wiki]

#27190: disparate duplicate subproto handling in protover
--+
 Reporter:  cyberpunks|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor:
  |  unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust, 033-backport, 034-backport  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * milestone:   => Tor: unspecified


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27194 [Core Tor/Tor]: handling extra commas in protover

[Tor Bug Tracker & Wiki]

#27194: handling extra commas in protover
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, security-low, 029-backport,|  Actual Points:
  032-backport, 033-backport, 034-backport   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  new => needs_information
 * keywords:  rust, security-low =>
 rust, security-low, 029-backport, 032-backport, 033-backport,
 034-backport


Comment:

 Is your protocommas1 branch ready for review?

 If so, we should run make test-network-all using ​chutney to make sure
 that standard tor clients aren't inserting extra spaces.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27191 [Core Tor/Tor]: handling double spaces in protover

[Tor Bug Tracker & Wiki]

#27191: handling double spaces in protover
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, 029-backport, 032-backport,|  Actual Points:
  033-backport, 034-backport |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:  rust => rust, 029-backport, 032-backport, 033-backport,
 034-backport
 * milestone:   => Tor: 0.3.5.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27191 [Core Tor/Tor]: handling double spaces in protover

[Tor Bug Tracker & Wiki]

#27191: handling double spaces in protover
--+
 Reporter:  cyberpunks|  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.2.9.4-alpha
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  new => needs_review


Comment:

 Replying to [comment:1 cyberpunks]:
 > The protospaces2 branch at ​​https://gitgud.io/onionk/tor.git changes
 the C implementation to reject them. Nothing actually produces extra
 spaces like this, right?

 Extra spaces are not allowed by the protover spec. Each separator is
 exactly one space:
 https://gitweb.torproject.org/torspec.git/tree/dir-spec.txt#n780

 But we should run `make test-network-all` using
 [https://gitweb.torproject.org/chutney.git chutney] to make sure that
 standard tor clients aren't inserting extra spaces.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27194 [Core Tor/Tor]: handling extra commas in protover

[Tor Bug Tracker & Wiki]

#27194: handling extra commas in protover
+
 Reporter:  cyberpunks  |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.2.9.4-alpha
 Severity:  Normal  | Resolution:
 Keywords:  rust, security-low  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+
Changes (by teor):

 * milestone:  Tor: 0.3.6.x-final => Tor: 0.3.5.x-final


Comment:

 Replying to [comment:1 teor]:
 > I'm not sure if we should fix the rust version to match the C version,
 or fix the C version.
 >
 > If we do fix the C version, we may need to define a new consensus
 method. So I'm scheduling this for merge in 0.3.6, because new consensus
 methods are complicated.

 Oh, hang on, we can just reject descriptors with extra commas in the C
 code. We're allowed to reject descriptors as malformed without a new
 consensus method.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27194 [Core Tor/Tor]: handling extra commas in protover

[Tor Bug Tracker & Wiki]

#27194: handling extra commas in protover
+
 Reporter:  cyberpunks  |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.6.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.2.9.4-alpha
 Severity:  Normal  | Resolution:
 Keywords:  rust, security-low  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+
Changes (by teor):

 * keywords:  rust => rust, security-low
 * milestone:   => Tor: 0.3.6.x-final


Comment:

 I'm not sure if we should fix the rust version to match the C version, or
 fix the C version.

 If we do fix the C version, we may need to define a new consensus method.
 So I'm scheduling this for merge in 0.3.6, because new consensus methods
 are complicated.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27135 [Core Tor/sbws]: Write descriptor bandwidths average in raw results

[Tor Bug Tracker & Wiki]

#27135: Write descriptor bandwidths average in raw results
---+-
 Reporter:  juga   |  Owner:  juga
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #27108 | Points:
 Reviewer: |Sponsor:
---+-

Comment (by teor):

 Replying to [comment:10 juga]:
 >
 > > take the decaying average of the measurements, and scale by the
 decaying average of the descriptor bandwidths
 >
 > could you point out what do you mean by decaying average?, this [0]?

 Yes, I mean an exponentially decaying average. But that article was
 written by mathematicians, not programmers.

 Here's a simple exponential decay algorithm that can be used for both
 descriptor bandwidths and measured bandwidths:

 1. Set the decay constant (R) to a number in (0, 1).

 We get a descriptor every 12-18 hours, and there is a daily cycle in
 Tor bandwidths. So we want to average over a few days, to smooth out
 spikes. A good value for R is 0.98 every hour, because the decaying
 average for 15 hour bandwidths is 26% B1 + 19% B2 + 14% B3 + 11% B4 + 30%
 B5-10. (B11 is less than 1%.)

 2. For each relay, set the decaying average (D) to 1

 3. At the start of each hour:

   a. multiply the decaying average by the decay constant: D *= R

   b. add the most recent bandwidth (B) to the decaying average: D += B

 4. When voting:

   a. Scale decaying averages before including them in votes (V): `V = D *
 (1 - R)`

  If a relay has a constant bandwidth (B), then the decaying average
 will eventually be (strictly, will converge to) `B * 1/(1 - R)`. We
 probably want decaying average bandwidths to be comparable to bandwidths,
 so we should scale them.

   b. Scale each relay's weight so the total is approximately torflow's
 total weight.

 We want the consensus weights to be comparable with Torflow's
 consensus weights.

   c. If the relay's weight is 0, vote 1.

 We want all relays to have a small weight, to avoid zero-division
 bugs.

 > btw, it seems that the answer to my question in [1] is that 1/45 ~= 1/e

 Can you explain what you mean by `e`?

 The base of the natural logarithm is `e ~= 2.72`, so `1/e ~= 0.37`.

 > > how we handle new relays (treat their old bandwidths as 1 is a nice
 simple way of rewarding stability)
 >
 > you mean for their descriptor bw?, for what we write to the bw file?

 Yes, for the initial decaying average for new relays, and the final vote
 bandwidth for all relays. See steps 2. and 4.c. above, where I use 1
 instead of 0.

 > [0] https://en.wikipedia.org/wiki/Exponential_decay#Mean_lifetime
 > [1] https://github.com/pastly/simple-bw-
 scanner/issues/182#issuecomment-409341398

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27195 [Core Tor/Tor]: Rust: add tests for protover edge cases

[Tor Bug Tracker & Wiki]

#27195: Rust: add tests for protover edge cases
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  033-backport, 034-backport, rust,|  Actual Points:
  tor-test   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25918 [Core Tor/Tor]: Standardize the 'onion service' name

[Tor Bug Tracker & Wiki]

#25918: Standardize the 'onion service' name
--+
 Reporter:  atagar|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Major | Resolution:
 Keywords:  tor-hs|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by traumschule):

 * parent:  #25955 =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27164 [Core Tor/Tor]: rust protover accepts "Link=1-5-foo"

[Tor Bug Tracker & Wiki]

#27164: rust protover accepts "Link=1-5-foo"
--+
 Reporter:  cyberpunks|  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.3.9
 Severity:  Normal| Resolution:  fixed
 Keywords:  rust, 033-backport, 034-backport  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by teor):

 I'm at a more capable device now, so I opened #27195.

 Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27195 [Core Tor/Tor]: Rust: add tests for protover edge cases

[Tor Bug Tracker & Wiki]

#27195: Rust: add tests for protover edge cases
-+-
 Reporter:  teor |  Owner:  (none)
 Type:   | Status:  new
  enhancement|
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  033-backport, 034-backport, rust,
 Severity:  Normal   |  tor-test
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 There are more tests for #27164 and #27177 in branch prototest1 on
 ​https://gitgud.io/onionk/tor.git

 Since we backported the fixes, I suggest we backport the tests.

 Original comment:
 https://trac.torproject.org/projects/tor/ticket/27164#comment:7

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25918 [Core Tor/Tor]: Standardize the 'onion service' name

[Tor Bug Tracker & Wiki]

#25918: Standardize the 'onion service' name
--+
 Reporter:  atagar|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Major | Resolution:
 Keywords:  tor-hs|  Actual Points:
Parent ID:  #25955| Points:
 Reviewer:|Sponsor:
--+
Changes (by traumschule):

 * parent:   => #25955


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26168 [Core Tor/Tor]: Rename HSDir consensus flag to OnionDir

[Tor Bug Tracker & Wiki]

#26168: Rename HSDir consensus flag to OnionDir
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, hsdir, needs-proposal, 035   |  Actual Points:
  -roadmap-proposed, 035-removed-20180711,   |
  036-proposed   |
Parent ID:  #25955   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by traumschule):

 * parent:   => #25955


Comment:

 exciting!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25955 [Core Tor/Tor]: onion v2 deprecation plan

[Tor Bug Tracker & Wiki]

#25955: onion v2 deprecation plan
---+
 Reporter:  cypherpunks|  Owner:  (none)
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, prop224-extra  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by teor):

 > What about the option to configure hsv3 this way:

 Tor versions 0.3.2 and later support next-generation onion services using
 legacy HS torrc option names. So any documentation must use the legacy
 names, until all Tor versions support the new Onion option names.

 See #17343 for a torrc ticket to make Onion an alias for HS in torrc
 options.
 See #26168 for another ticket to make OnionDir a synonym for HSDir in
 relay flags.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26168 [Core Tor/Tor]: Rename HSDir consensus flag to OnionDir

[Tor Bug Tracker & Wiki]

#26168: Rename HSDir consensus flag to OnionDir
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, hsdir, needs-proposal, 035   |  Actual Points:
  -roadmap-proposed, 035-removed-20180711,   |
  036-proposed   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:
 tor-hs, hsdir, needs-proposal, 035-roadmap-proposed,
 035-removed-20180711
 =>
 tor-hs, hsdir, needs-proposal, 035-roadmap-proposed,
 035-removed-20180711, 036-proposed


Comment:

 I'm in favour of accepting the OnionDir flag in 0.3.6, updating torspec,
 and calling this ticket done.

 All of the other "hsdir" strings aren't likely to be seen by most users or
 relay operators.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27164 [Core Tor/Tor]: rust protover accepts "Link=1-5-foo"

[Tor Bug Tracker & Wiki]

#27164: rust protover accepts "Link=1-5-foo"
--+
 Reporter:  cyberpunks|  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.3.9
 Severity:  Normal| Resolution:  fixed
 Keywords:  rust, 033-backport, 034-backport  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by teor):

 Replying to [comment:7 cyberpunks]:
 > Oh, I added more tests for this and #27177 in the branch prototest1.

 Would you mind opening another ticket?

 Integers are cheap, but reading long comment threads takes time.
 (And mistakes cost time, too.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25955 [Core Tor/Tor]: onion v2 deprecation plan

[Tor Bug Tracker & Wiki]

#25955: onion v2 deprecation plan
---+
 Reporter:  cypherpunks|  Owner:  (none)
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, prop224-extra  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by traumschule):

 prop224/hsv3 has been tested for 5 months now, that does not make it
 stable and there still are reliability issues, but I wonder if this is a
 good time to create an 'alpha' subpage for the
 [https://torproject.org/docs/tor-onion-service.html onion service guide]
 to  "officially" explain how to configure [[doc/NextGenOnions]].

 This wiki page is locked, maybe it's a good time as well to unlock it to
 let admins share their experiences and to collect knowledge from tickets
 gathered in the last months. For example I wanted to add that {{{chmod 700
 -R /var/lib/tor}}} is a good idea. (There's quite a collection of sites
 showing many 'users'/admins ran into #19824, including myself several
 times :)

 I realized it is hard to write about how to configure onion services
 without mentioning hidden services, at least in torrc itself. What about
 the option to configure hsv3 this way:
 {{{
 OnionDir /var/lib/tor/onion_service
 OnionPort 80 127.0.0.1:80
 }}}
 This would make it easier to set them up, because it implies
 {{{HiddenServiceVersion 3}}} and actually deprecate the term
 HiddenService.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25696 [Applications/Tor Browser]: Design of alpha onboarding for Tor Browser for Android

[Tor Bug Tracker & Wiki]

#25696: Design of alpha onboarding for Tor Browser for Android
-+-
 Reporter:  isabela  |  Owner:
 |  antonela
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team, tbb-mobile, |  Actual Points:
  TorBrowserTeam201808R  |
Parent ID:  #26531   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-

Comment (by sysrqb):

 Replying to [comment:34 igt0]:
 > - Update text description line-height
 > - Change Background image color
 > - Make images bigger
 >
 >
 https://trac.torproject.org/projects/tor/attachment/ticket/25696/0001-Bug-25696
 -Implement-alpha-onboarding-for-Tor-Browser.3.patch

 This looks good! Some nits.

 1. Do we need the private constructor in `FirstrunTorPanelConfig`?
 1. "Experience Tips" is awkward wording, but we should be consistent with
 desktop, so we can use that for now.
 1. I see desktop has additional functionality on each panel ("Review
 Settings", "See FAQs", "Visit an Onion"). Do we want that?
 1. In
 `mobile/android/app/src/main/res/layout/firstrun_animation_container.xml`,
 should `home_tab_menu_strap_tor` be `home_tab_menu_strip_tor`?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27194 [Core Tor/Tor]: handling extra commas in protover

[Tor Bug Tracker & Wiki]

#27194: handling extra commas in protover
--+
 Reporter:  cyberpunks|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.2.9.4-alpha
 Severity:  Normal|   Keywords:  rust
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 Like how it handles spaces, `protover.c` rejects leading commas
 (`Link=,1-5` or `Link=,`) while it accepts and ignores extra commas
 elsewhere (`Link=1-5,` and `Link=1,,,2-5` are valid).

 The Rust version accepts and ignores all extra commas, including leading
 commas.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27193 [Applications/Tor Browser]: remove Tor Browser version 7.5.5 from RecommendedTBBVersions

[Tor Bug Tracker & Wiki]

#27193: remove Tor Browser version 7.5.5 from RecommendedTBBVersions
--+--
 Reporter:  adrelanos |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by boklm):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 > Yet on August 18, 2018 7.5.5 was still included in
 RecommendedTBBVersions. Why? Forgotten or is there a policy to it?

 Sorry, it should have been removed a few hours after `7.5.6` was released,
 but it was forgotten. I have removed it now.

 > Could you please kindly explain the policy on when old versions are
 removed from RecommendedTBBVersions?

 When a new version fixing some security issues is released, we remove the
 old one from `RecommendedTBBVersions`, after 12-24h to give time for
 people to update before showing a warning. When the new version is not a
 security update, we keep both versions in `RecommendedTBBVersions`.

 > I am asking, so ​tb-updater parsing code can be updated accordingly. (At
 the moment it's "suggest the lowest version number among them otherwise it
 might be an alpha/beta version".)

 A more reliable way to find what is the current version is to look at
 `appVersion` in this URL (if you can parse xml):
 https://aus1.torproject.org/torbrowser/update_3/release/Linux_x86_64-gcc3/x
 /en-US

 Or `version` in this one:
 https://aus1.torproject.org/torbrowser/update_3/release/downloads.json

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27193 [Applications/Tor Browser]: remove Tor Browser version 7.5.5 from RecommendedTBBVersions

[Tor Bug Tracker & Wiki]

#27193: remove Tor Browser version 7.5.5 from RecommendedTBBVersions
--+--
 Reporter:  adrelanos |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 External applications such as [https://github.com/Whonix/tb-updater tb-
 updater] and torbrowser-downloader parse, depend on
 [https://www.torproject.org/projects/torbrowser/RecommendedTBBVersions
 RecommendedTBBVersions] being up to date.

 {{{7.5.6}}} was [https://blog.torproject.org/tor-browser-756-released-
 released] June 26, 2018.

 Yet on August 18, 2018 {{{7.5.5}}} was still included in
 RecommendedTBBVersions. Why? Forgotten or is there a policy to it?

 Could you please kindly explain the policy on when old versions are
 removed from RecommendedTBBVersions?

 I am asking, so ​tb-updater parsing code can be updated accordingly. (At
 the moment it's "suggest the lowest version number among them otherwise it
 might be an alpha/beta version".)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27192 [Core Tor/Tor]: Perform --verify-config before reloading tor

[Tor Bug Tracker & Wiki]

#27192: Perform --verify-config before reloading tor
--+--
 Reporter:  traumschule   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 When tor is SIGHUPed and the log file can't be written or ownership or
 permissions of hidden service dir is wrong, tor dies.

 Instead call {{{tor --verify-config}}} before actually reloading tor to
 avoid this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27191 [Core Tor/Tor]: handling double spaces in protover

[Tor Bug Tracker & Wiki]

#27191: handling double spaces in protover
--+
 Reporter:  cyberpunks|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.2.9.4-alpha
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by cyberpunks):

 The protospaces2 branch at ​​https://gitgud.io/onionk/tor.git changes the
 C implementation to reject them. Nothing actually produces extra spaces
 like this, right?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26884 [Applications/Tor Browser]: Update preferences.xul to make it work on mobile

[Tor Bug Tracker & Wiki]

#26884: Update preferences.xul to make it work on mobile
-+-
 Reporter:  igt0 |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,   |  Actual Points:
  TorBrowserTeam201808R  |
Parent ID:  #26531   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by igt0):

 * status:  needs_revision => needs_review


Comment:

 Updated code:


 **Bug 26884 - Part 1: Move show_torbrowser_manual and
 get_general_useragent_locale to utils**
 
https://github.com/igortoliveira/torbutton/commit/d69a48bbaa5fbed41e11448ed5800f9f75cfd124

 **Bug 26884 - Part 2: Create mobile security slider**
 
https://github.com/igortoliveira/torbutton/commit/67b54c3d6a767dfa0146967a8e3675d8dee1e8ff

 **Bug 26884 - Part 3: Remove optionsURL from install.rdf**
 
https://github.com/igortoliveira/torbutton/commit/742843fe8fd181cf7c8632779069517814d6110b

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26884 [Applications/Tor Browser]: Update preferences.xul to make it work on mobile

[Tor Bug Tracker & Wiki]

#26884: Update preferences.xul to make it work on mobile
-+-
 Reporter:  igt0 |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,   |  Actual Points:
  TorBrowserTeam201808R  |
Parent ID:  #26531   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by igt0):

 > > **Bug 26884 - Part 3: Remove optionsURL from install.rdf**
 > >
 
https://github.com/igortoliveira/torbutton/commit/973b138dd24cd193b990c43c8c9eaa221a8d55b4
 >
 > Seems okay.
 >
 > Do we need to add fennec as a new target application in install.rdf?
 > {{{
 > +
 > +
 > +
 > +{aa3c5121-dab2-40e2-81ca-7ea25febc110}
 > +60.0
 > +1.0
 > +
 > +
 > }}}

 I am not sure, because legacy extensions are not supported by default in
 Fennec and I believe the targetApplication is a way to protect the user of
 installing it in unsupported versions. So even if the user tries to
 install just the torbutton, Fennec will not allow it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27135 [Core Tor/sbws]: Write descriptor bandwidths average in raw results

[Tor Bug Tracker & Wiki]

#27135: Write descriptor bandwidths average in raw results
---+-
 Reporter:  juga   |  Owner:  juga
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #27108 | Points:
 Reviewer: |Sponsor:
---+-

Comment (by juga):

 > take the decaying average of the measurements, and scale by the decaying
 average of the descriptor bandwidths

 could you point out what do you mean by decaying average?, this [0]?

 btw, it seems that the answer to my question in [1] is that 1/45 ~= 1/e

 > how we handle new relays (treat their old bandwidths as 1 is a nice
 simple way of rewarding stability)

 you mean for their descriptor bw?, for what we write to the bw file?

 [0] https://en.wikipedia.org/wiki/Exponential_decay#Mean_lifetime
 [1] https://github.com/pastly/simple-bw-
 scanner/issues/182#issuecomment-409341398

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27164 [Core Tor/Tor]: rust protover accepts "Link=1-5-foo"

[Tor Bug Tracker & Wiki]

#27164: rust protover accepts "Link=1-5-foo"
--+
 Reporter:  cyberpunks|  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.3.9
 Severity:  Normal| Resolution:  fixed
 Keywords:  rust, 033-backport, 034-backport  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by cyberpunks):

 Oh, I added more tests for this and #27177 in the branch prototest1.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23846 [Core Tor/Tor]: Option to build Tor with -fPIC (Use libtool for building shared library?)

[Tor Bug Tracker & Wiki]

#23846: Option to build Tor with -fPIC (Use libtool for building shared 
library?)
-+-
 Reporter:  hellais  |  Owner:  nickm
 Type:  enhancement  | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-mobile, s8-api,  |  Actual Points:
  034-triage-20180328, 034-included-20180402,|
  034-roadmap-subtask, 035-roadmap-subtask, 035  |
  -triaged-in-20180711   |
Parent ID:  #25510   | Points:
 Reviewer:  ahf  |Sponsor:
 |  Sponsor8
-+-

Comment (by sbs):

 Thanks nickm and Hello71 for your replies :-). Given that nickm has
 indicated an alternative approach that is good enough for our goals, I
 believe this can probably be closed. We will be using `make show-libs`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27191 [Core Tor/Tor]: handling double spaces in protover

[Tor Bug Tracker & Wiki]

#27191: handling double spaces in protover
--+
 Reporter:  cyberpunks|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.2.9.4-alpha
 Severity:  Normal|   Keywords:  rust
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 `protover.c` accepts trailing spaces and extra spaces between subprotocol
 entries like `"Link=1-4  LinkAuth=1 "`, but rejects leading spaces like `"
 Link=1-4"`. It has since its
 
[https://gitweb.torproject.org/tor.git/commit/?id=b2b2e1c7f24d9b65059e3d089768d6c49ba4f58f
 introduction.]

 The Rust implementation rejects all extra spaces in any position. It's at
 least consistent.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27188 [Core Tor/Tor]: hsv3 unavailable after reconnecting: No more HSDir available to query.

[Tor Bug Tracker & Wiki]

#27188: hsv3 unavailable after reconnecting: No more HSDir available to query.
--+
 Reporter:  traumschule   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:  tor-hs hsdir  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by traumschule):

 Looking at
 [https://gitweb.torproject.org/tor.git/tree/src/core/or/connection_edge.c#n1614
 connection_edge.c] and
 [https://gitweb.torproject.org/tor.git/tree/src/feature/hs/hs_client.c#n409
 hs_client.c: fetch_v3_desc] the request is turned down
 {{{
   case HS_CLIENT_FETCH_NO_HSDIRS:
   case HS_CLIENT_FETCH_NOT_ALLOWED:
 /* Can't proceed further and better close the SOCKS request. */
 }}}
 because
 [https://gitweb.torproject.org/tor.git/tree/src/feature/hs/hs_client.c#n1276
 hs_client_refetch_hsdesc] fails. The
 [https://gitweb.torproject.org/tor.git/tree/src/feature/hs/hs_client.c#n69
 connection is closed (fetch_status_should_close_socks)] and the
 [https://gitweb.torproject.org/tor.git/tree/src/feature/hs/hs_client.c#n1291
 request purged (hs_client_refetch_hsdesc)]. (skipping speculations)

 Found an interesting bit in the log:
 {{{
 Aug 17 02:26:19 host Tor[950]: Tor has successfully opened a circuit.
 Looks like client functionality is working.
 Aug 17 02:26:19 host Tor[950]: Bootstrapped 100%: Done
 Aug 17 03:03:24 host Tor[950]: Your Guard  is failing more
 circuits than usual. Most likely this means the Tor network is overloaded.
 Success counts are 143/243. Use counts a re 45/51. 240 circuits completed,
 6 were unusable, 91 collapsed, and 84 timed out. For reference, your
 timeout cu toff is 60 seconds.
 Aug 17 08:26:17 host Tor[950]: Heartbeat: Tor's uptime is 6:00 hours, with
 10 circuits open. I've sent 6.93 MB and received 15.22 MB.
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27189 [Core Tor/Tor]: cleanup rust code

[Tor Bug Tracker & Wiki]

#27189: cleanup rust code
--+
 Reporter:  cyberpunks|  Owner:  (none)
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  new => needs_review
 * milestone:   => Tor: 0.3.5.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27190 [Core Tor/Tor]: disparate duplicate subproto handling in protover

[Tor Bug Tracker & Wiki]

#27190: disparate duplicate subproto handling in protover
--+
 Reporter:  cyberpunks|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by cyberpunks):

 The C code already has to check for duplicates to prevent double-voting.
 Could both C and Rust be changed to consider it an error to have duplicate
 subprotocol entries?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27190 [Core Tor/Tor]: disparate duplicate subproto handling in protover

[Tor Bug Tracker & Wiki]

#27190: disparate duplicate subproto handling in protover
--+
 Reporter:  cyberpunks|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  rust
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 `protover.c` treats `Link=1 Link=1` and `Link=1` identically, allowing
 duplicate entries without complaint, though it does explicitly check for
 duplicates to avoid double-counting it as two votes for the same version.

 `protover.c` also treats `Link=1 Link=2` and `Link=1-2` the same, while
 the rust implementation of protover treats `Link=1 Link=2` as if it were
 `Link=2`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27189 [Core Tor/Tor]: cleanup rust code

[Tor Bug Tracker & Wiki]

#27189: cleanup rust code
--+
 Reporter:  cyberpunks|  Owner:  (none)
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by cyberpunks):

 Branch rust-cleanup1 at https://gitgud.io/onionk/tor.git

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27189 [Core Tor/Tor]: cleanup rust code

[Tor Bug Tracker & Wiki]

#27189: cleanup rust code
--+
 Reporter:  cyberpunks|  Owner:  (none)
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  rust
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 There are low-hanging fruit for silencing clippy lints, removing
 unnecessary allocations, and writing a more efficient version of
 `.retain()`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27188 [Core Tor/Tor]: hsv3 unavailable after reconnecting: No more HSDir available to query.

[Tor Bug Tracker & Wiki]

#27188: hsv3 unavailable after reconnecting: No more HSDir available to query.
--+
 Reporter:  traumschule   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal|   Keywords:  tor-hs hsdir
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 (Tor 0.3.5.0 needs a trac version)

 Just noticed that my v3 $onion got unavailable while the webserver is
 still functional.
 {{{
 $ torify w3m $onion
 w3m: Can't load $onion
 Aug 17 16:14:09 host Tor[950]: Closed 1 streams for service
 [scrubbed].onion for reason resolve failed. Fetch status: No more HSDir
 available to query.

 $ tor --version
 Tor version 0.3.5.0-alpha-dev

 $ curl -s localhost|grep title
Tor Project | Privacy Online

 $ torsocks curl torproject.org
 
 
 302 Found

 tor$ git blame src/feature/hs/hs_client.c
 c232b6b59c src/or/hs_client.c (David Goulet
 2017-09-26 10:45:24 -0400   57) return "No more HSDir available to
 query";
 }}}
 i can repeat above multiple times but it does not refetch directories.
 keeping the instance running to see if it comes online again after three
 hours (#26769).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26168 [Core Tor/Tor]: Rename HSDir consensus flag to OnionDir

[Tor Bug Tracker & Wiki]

#26168: Rename HSDir consensus flag to OnionDir
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, hsdir, needs-proposal, 035   |  Actual Points:
  -roadmap-proposed, 035-removed-20180711|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by traumschule):

 * keywords:  needs-proposal, 035-roadmap-proposed, 035-removed-20180711 =>
 tor-hs, hsdir, needs-proposal, 035-roadmap-proposed,
 035-removed-20180711


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25696 [Applications/Tor Browser]: Design of alpha onboarding for Tor Browser for Android

[Tor Bug Tracker & Wiki]

#25696: Design of alpha onboarding for Tor Browser for Android
-+-
 Reporter:  isabela  |  Owner:
 |  antonela
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team, tbb-mobile, |  Actual Points:
  TorBrowserTeam201808R  |
Parent ID:  #26531   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-

Comment (by igt0):

 - Update text description line-height
 - Change Background image color
 - Make images bigger

 https://trac.torproject.org/projects/tor/attachment/ticket/25696/0001-Bug-25696
 -Implement-alpha-onboarding-for-Tor-Browser.3.patch

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25696 [Applications/Tor Browser]: Design of alpha onboarding for Tor Browser for Android

[Tor Bug Tracker & Wiki]

#25696: Design of alpha onboarding for Tor Browser for Android
-+-
 Reporter:  isabela  |  Owner:
 |  antonela
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team, tbb-mobile, |  Actual Points:
  TorBrowserTeam201808R  |
Parent ID:  #26531   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by igt0):

 * Attachment "0001-Bug-25696-Implement-alpha-onboarding-for-Tor-
 Browser.3.patch" added.

 patch-r2

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22170 [Applications/Tor Browser]: Check uses of ch.boye.httpclientandroidlib.impl.client.* for proxy safety on Android

[Tor Bug Tracker & Wiki]

#22170: Check uses of ch.boye.httpclientandroidlib.impl.client.* for proxy 
safety
on Android
-+-
 Reporter:  gk   |  Owner:  sysrqb
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff52-esr, tbb-mobile,|  Actual Points:
  TorBrowserTeam201808R  |
Parent ID:  #21863   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks for the detailed analysis, nice job! I think we are good here,
 closing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22170 [Applications/Tor Browser]: Check uses of ch.boye.httpclientandroidlib.impl.client.* for proxy safety on Android

[Tor Bug Tracker & Wiki]

#22170: Check uses of ch.boye.httpclientandroidlib.impl.client.* for proxy 
safety
on Android
-+-
 Reporter:  gk   |  Owner:  sysrqb
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, tbb-mobile,|  Actual Points:
  TorBrowserTeam201808R  |
Parent ID:  #21863   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:22 sysrqb]:
 > Replying to [comment:20 sysrqb]:
 > > All files where Fennec uses `conn`
 > >
 > > {{{
 > > $ git grep -n ch.boye.httpclientandroidlib.conn mobile/android/[bs]*
 > >
 mobile/android/base/java/org/mozilla/gecko/util/URIUtils.java:14:import
 ch.boye.httpclientandroidlib.conn.util.InetAddressUtils;
 > > }}}
 >
 > Only used for parsing a string. This class is only a utility, it doesn't
 create any connections.
 >
 > > {{{
 > >
 
mobile/android/services/src/main/java/org/mozilla/gecko/sync/net/BaseResource.java:44:import
 ch.boye.httpclientandroidlib.conn.ClientConnectionManager;
 > >
 
mobile/android/services/src/main/java/org/mozilla/gecko/sync/net/BaseResource.java:45:import
 ch.boye.httpclientandroidlib.conn.params.ConnRoutePNames;
 > >
 
mobile/android/services/src/main/java/org/mozilla/gecko/sync/net/BaseResource.java:46:import
 ch.boye.httpclientandroidlib.conn.scheme.PlainSocketFactory;
 > >
 
mobile/android/services/src/main/java/org/mozilla/gecko/sync/net/BaseResource.java:47:import
 ch.boye.httpclientandroidlib.conn.scheme.Scheme;
 > >
 
mobile/android/services/src/main/java/org/mozilla/gecko/sync/net/BaseResource.java:48:import
 ch.boye.httpclientandroidlib.conn.scheme.SchemeRegistry;
 > >
 
mobile/android/services/src/main/java/org/mozilla/gecko/sync/net/BaseResource.java:49:import
 ch.boye.httpclientandroidlib.conn.ssl.SSLSocketFactory;
 > > }}}
 >
 > This is proxy-safe but only because we hard-code the default HTTP proxy.
 `scheme.PlainSocketFactory` and `ssl.SSLSocketFactory` are used for
 establishing a connection to the proxy, instead of the destination.
 `params.ConnRoutePNames` is used for specifying the default proxy.
 `scheme.Scheme`, `scheme.SchemeRegistry`, and `ClientConnectionManager`
 are used during instantiation of the connection manager
 (`ThreadSafeClientConnManager`).
 >
 > > {{{
 > >
 
mobile/android/services/src/main/java/org/mozilla/gecko/sync/net/TLSSocketFactory.java:16:import
 ch.boye.httpclientandroidlib.conn.ssl.SSLSocketFactory;
 > > }}}
 >
 > Dead class.

 Looks good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27187 [Metrics/Onionoo]: Possible for inconsistency between summary and details with AS number

[Tor Bug Tracker & Wiki]

#27187: Possible for inconsistency between summary and details with AS number
-+--
 Reporter:  irl  |  Owner:  metrics-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+--
 {{{
 {"version":"6.2",
 "next_major_version_scheduled":"2018-09-03",
 "build_revision":"79de0d2",
 "relays_published":"2018-08-17 12:00:00",
 "relays":[
 {"fingerprint":"008E7B70C3B4A7520B5BEAB8067ABCDC8E63F1FD"},
 {"fingerprint":"070A0DC5AE71D60A9567FF908A4EBFB52C670E39"},
 {"fingerprint":"0AE3AC492B709AA851488D01B1AD1EDFC040947F"},
 {"fingerprint":"0CA2FF775712F67AFFAB64CF16EA96E3D13016B4"},
 {"fingerprint":"0DE225407D80F8C1121AED264A97EBF56F31F299"},
 {"fingerprint":"11757C1EAD3BAD46D2EA2E950D5E9A34035D9B17"},
 {"fingerprint":"126B2DD209618B666FF3184EC9D50363B3FB46B7"},
 {"fingerprint":"136F9299A5009A4E0E96494E723BDB556FB0A26B"},
 {"fingerprint":"19D235674BCA4EAF55BBFFAAE5441C1E392E4C72"},
 {"fingerprint":"1CD464437CF6F0AA8B41660D74DCAB8DD7C14373"},
 {"fingerprint":"1D3174338A1131A53E098443E76E1103CDED00DC"},
 {"fingerprint":"2093B5DC4B595BFD307A26F494A4C31F455DCCCA"},
 {"fingerprint":"22E975935BA77EA59A28EA1AA8387F906034FCBE"},
 {"fingerprint":"2C8BD998EDE0C8D7CCAA1A724BF566524395"},
 {"fingerprint":"2CDCFED0142B28B002E89D305CBA2E26063FADE2"},
 {"fingerprint":"2D74D7EFACC75DCDB3BEE9221B0BEB226754F96E"},
 {"fingerprint":"3098231A16A3661AF98A80D62D161AE7B039358E"},
 {"fingerprint":"3444F4ACA2A1AB4A5E9DC64295A6D414A03D3503"},
 {"fingerprint":"363E2F30AC9823E6094786CE0ABB64B14D2BE233"},
 {"fingerprint":"387A7D62EEC5C14FF45ED8AD9B2235BFE9FE9463"},
 {"fingerprint":"38A42B8D7C0E6346F4A4821617740AEE86EA885B"},
 {"fingerprint":"3B52392E2256C35CDCF7801FF898FC88CE6D431A"},
 {"fingerprint":"3D765C586CCA8B437B7697EA2CE6A51312530AB1"},
 {"fingerprint":"3E50CBCA98A20F637BC4551FD4F132D062DB9A51"},
 {"fingerprint":"41A3C16269C7B63DB6EB741DBDDB4E1F586B1592"},
 {"fingerprint":"4C3165B64B8237E5273D388429480080022C6481"},
 {"fingerprint":"557B274903A48A611B43B66C5761E4F0AFB248A8"},
 {"fingerprint":"55D7C9776246C3C5E683A777D97D3ECDD0C5AF37"},
 {"fingerprint":"572D22C1AF720F274D274A189EDB75C3F9BDC777"},
 {"fingerprint":"5CEF9FD40E64948093EBC041E33ED3ED12F70DFE"},
 {"fingerprint":"5CF8AFA5E4B0BB88942A44A3F3AAE08C3BDFD60B"},
 {"fingerprint":"5FAA9FC7000138C480F042DE4C602C56C5AA3C42"},
 {"fingerprint":"60D2F22EE6FB75739C1F1EF80A2D99D943F12D9E"},
 {"fingerprint":"65F260EAC76E4F72ED2F8C34CE47A8E1E0621B90"},
 
{"fingerprint":"723E9B29DF0357E19B2D1C86B86A0165335BFAA9","as_number":"AS39309"},
 {"fingerprint":"728B01C767259E92262329DC148750C08A3A5259"},
 {"fingerprint":"73D6694F1E71EBD138A15091EA6CBB6F94271405"},
 {"fingerprint":"75FCFA1225B5B4B35E25DA53C8BA7545463B679E"},
 {"fingerprint":"77C99455CF6F68A7FF72F78048D1C39A4719EC59"},
 {"fingerprint":"79D41A16341822F03D11361B0A31DC9309CEB748"},
 {"fingerprint":"7A622004AE337495692986D973A62EAAF2524455"},
 {"fingerprint":"7C494B5BBC1558303DB1CFB840D980A0B4BCC324"},
 {"fingerprint":"7DBB97846CC559FDB82FDD53360127A17742C9D8"},
 {"fingerprint":"7E7006F96EF48C688EEE1B1095BEC66B4EF28029"},
 {"fingerprint":"837D5EA513DF7FDDA36BE569C646151CDA4B9935"},
 {"fingerprint":"83F03DA35C8E65474B2B9B5EF81896E12AD6282A"},
 {"fingerprint":"851491607C61F6C878FF4C92253274095FD20FBB"},
 {"fingerprint":"87EDD379CB568F65704665A291A6186006AFAF57"},
 {"fingerprint":"8CC6AAB9CBAB31EE4D9E80071F1330100A962EEF"},
 {"fingerprint":"8FA258D0E5F525F6E28E13A0BC2351F766D1DAF7"},
 {"fingerprint":"8FC24B546A3603D86901E1892270DAE9718A09A3"},
 {"fingerprint":"90352FBFD5D0BD4D6FDC867309F393A8AF99FF8A"},
 {"fingerprint":"92CFD9565B24646CAC2D172D3DB503D69E777B8A"},
 {"fingerprint":"94342E68666C1307ECC4CB083070F4DEC87408E0"},
 {"fingerprint":"95D68B64F42F27AED4CA15D0E9A1D0DA86E60339"},
 {"fingerprint":"960F231C1C2CABF752E747A57D6CDEFD13F35570"},
 {"fingerprint":"9A90F846871641CB97C70B948963FCA3F7486E5A"},
 {"fingerprint":"9B7D6254CE9C2D6EDC9A4510699ADADDF6F4D5F9"},
 {"fingerprint":"9BF565F0600126D3E2179CC933AA15E7702B4CE9"},
 {"fingerprint":"A2534EF23390CAE079B1586F0FDF9CE11F556062"},
 {"fingerprint":"A29B3032E92CB2D79903198DB36E78F848636CF4"},
 {"fingerprint":"A2DB293FFC5A76A718863BF1AEDBC8DFB1CB1097"},
 {"fingerprint":"A4C98CEA3F34E05299417E9F885A642C88EF6029"},
 {"fingerprint":"AD2060260080FE092DE928384E2514A1C596772F"},
 {"fingerprint":"AF2249FD0897A9FB961883C567309DE41472D5C6"},
 {"fingerprint":"B116D652E092760C1F1C44F4A9CA5D628D17CDE9"},
 {"fingerprint":"B44FBE5366AD98B46D829754FA4AC599BAE41A6A"},
 {"fingerprint":"B584C23DD8B22121FD1B20F926A528F4586F47E7"},
 {"fingerprint":"B7E04B6EC8F69EA05FD8CAD9B70AA76327004B13"},
 

Re: [tor-bugs] #27177 [Core Tor/Tor]: rust protover accepts tabs and newlines in protocol versions

[Tor Bug Tracker & Wiki]

#27177: rust protover accepts tabs and newlines in protocol versions
+--
 Reporter:  cyberpunks  |  Owner:  (none)
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.5.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.3.9
 Severity:  Normal  | Resolution:  fixed
 Keywords:  rust,033-backport,034-backport  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by nickm):

 * status:  needs_revision => closed
 * resolution:   => fixed


Comment:

 Looks good; merged to 0.3.3 and forward!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27177 [Core Tor/Tor]: rust protover accepts tabs and newlines in protocol versions

[Tor Bug Tracker & Wiki]

#27177: rust protover accepts tabs and newlines in protocol versions
+--
 Reporter:  cyberpunks  |  Owner:  (none)
 Type:  defect  | Status:
|  needs_revision
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.5.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.3.9
 Severity:  Normal  | Resolution:
 Keywords:  rust,033-backport,034-backport  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by cyberpunks):

 Replying to [comment:2 teor]:
 > * the branch needs to be rebased onto maint-0.3.3

 Done.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22170 [Applications/Tor Browser]: Check uses of ch.boye.httpclientandroidlib.impl.client.* for proxy safety on Android

[Tor Bug Tracker & Wiki]

#22170: Check uses of ch.boye.httpclientandroidlib.impl.client.* for proxy 
safety
on Android
-+-
 Reporter:  gk   |  Owner:  sysrqb
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, tbb-mobile,|  Actual Points:
  TorBrowserTeam201808R  |
Parent ID:  #21863   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:21 sysrqb]:
 > Replying to [comment:20 sysrqb]:
 > > All files where Fennec uses `impl.client`
 > >
 > > {{{
 > > $ git grep -n ch.boye.httpclientandroidlib.impl.client
 mobile/android/[bs]*
 > >
 
mobile/android/base/java/org/mozilla/gecko/telemetry/TelemetryUploadService.java:15:import
 ch.boye.httpclientandroidlib.impl.client.DefaultHttpClient;
 > > }}}
 >
 > We should never get here because its telemetry, but it's worth checking.
 The DefaultHttpClient is passed in, but not created. The `DATE` headers is
 set. A `BaseResource` is created and `BaseResource.postBlocking()` is
 called. The proxy will be set within `BaseResource.execute()`.

 You mean `BaseResource.prepareClient()`?

 [snip]

 > {{{
 > /**
 >  * Interact with the autopush endpoint HTTP API.
 >  * 
 >  * The API is a Mozilla-proprietary interface, and not even specified to
 Mozilla's usual ad-hoc standards.
 >  * This client is written against a work-in-progress, un-deployed
 upstream commit.
 >  */
 > }}}
 >
 > That's reassuring.

 Indeed.

 > All connections are created via `BaseResource`. DefaultHttpClient is
 passed into an `addHeader()` where an `ACCEPT_LANGAUGE` and `ACCEPT`
 header is added.
 >
 > > {{{
 > >
 
mobile/android/services/src/main/java/org/mozilla/gecko/sync/net/AbstractBearerTokenAuthHeaderProvider.java:9:import
 ch.boye.httpclientandroidlib.impl.client.DefaultHttpClient;
 > > }}}
 >
 > `DefaultHttpClient` isn't used. No network calls in this class.
 >
 > > {{{
 > >
 
mobile/android/services/src/main/java/org/mozilla/gecko/sync/net/AuthHeaderProvider.java:11:import
 ch.boye.httpclientandroidlib.impl.client.DefaultHttpClient;
 > > }}}
 >
 > This is an `interface`, no logic here.
 >
 > > {{{
 > >
 
mobile/android/services/src/main/java/org/mozilla/gecko/sync/net/BaseResource.java:51:import
 ch.boye.httpclientandroidlib.impl.client.BasicAuthCache;
 > >
 
mobile/android/services/src/main/java/org/mozilla/gecko/sync/net/BaseResource.java:52:import
 ch.boye.httpclientandroidlib.impl.client.DefaultHttpClient;
 > > }}}
 >
 > This class is probably proxy-safe. I'll need to look at this again (and
 a second pair of eyes would be welcome).

 Looks good to me.

 [snip]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27164 [Core Tor/Tor]: rust protover accepts "Link=1-5-foo"

[Tor Bug Tracker & Wiki]

#27164: rust protover accepts "Link=1-5-foo"
--+
 Reporter:  cyberpunks|  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.3.9
 Severity:  Normal| Resolution:  fixed
 Keywords:  rust, 033-backport, 034-backport  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+
Changes (by nickm):

 * status:  needs_revision => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:5 cyberpunks]:
 > Replying to [comment:3 teor]:
 > > * code changes need a changes file that passes `make check-changes`
 > >   * (doc and comment changes don't get a changes file)
 > Slight tangent, is that always true? Since
 [https://gitweb.torproject.org/tor.git/tree/changes/doc26638?id=c8aecd14
 doc26638] exists.

 For comments, generally not, unless it's something massive and important.

 For documentation, it's optional for small fixes and suggested for big
 ones.

 > Branch is rebased.

 Thanks! Looks better now; merged to 0.3.3 and forward.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27164 [Core Tor/Tor]: rust protover accepts "Link=1-5-foo"

[Tor Bug Tracker & Wiki]

#27164: rust protover accepts "Link=1-5-foo"
--+
 Reporter:  cyberpunks|  Owner:  (none)
 Type:  defect| Status:
  |  needs_revision
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.3.9
 Severity:  Normal| Resolution:
 Keywords:  rust, 033-backport, 034-backport  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by cyberpunks):

 Replying to [comment:3 teor]:
 > * code changes need a changes file that passes `make check-changes`
 >   * (doc and comment changes don't get a changes file)
 Slight tangent, is that always true? Since
 [https://gitweb.torproject.org/tor.git/tree/changes/doc26638?id=c8aecd14
 doc26638] exists.

 Branch is rebased.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27166 [Webpages/Styleguide]: Consider removing the Tor onion logo "leaves" in small icons

[Tor Bug Tracker & Wiki]

#27166: Consider removing the Tor onion logo "leaves" in small icons
-+--
 Reporter:  loxia_01 |  Owner:  hiro
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Webpages/Styleguide  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by antonela):

 * keywords:   => ux-team


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27164 [Core Tor/Tor]: rust protover accepts "Link=1-5-foo"

[Tor Bug Tracker & Wiki]

#27164: rust protover accepts "Link=1-5-foo"
--+
 Reporter:  cyberpunks|  Owner:  (none)
 Type:  defect| Status:
  |  needs_revision
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.3.9
 Severity:  Normal| Resolution:
 Keywords:  rust, 033-backport, 034-backport  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by teor):

 CI passed at https://travis-ci.org/teor2345/tor/builds/417209334

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27063 [Internal Services/Tor Sysadmin Team]: Drop helix from the gitolite maintainer role

[Tor Bug Tracker & Wiki]

#27063: Drop helix from the gitolite maintainer role
-+
 Reporter:  arma |  Owner:  tpa
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by teor):

 Replying to [comment:2 weasel]:
 > removed erinn from gid gitolite and gitweb.
 >
 > Somebody please update the wiki.

 Done!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26550 [Internal Services/Tor Sysadmin Team]: Migrate newsletter.tpo to static www rotation

[Tor Bug Tracker & Wiki]

#26550: Migrate newsletter.tpo to static www rotation
-+
 Reporter:  hiro |  Owner:  tpa
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by weasel):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 I think this is mostly done now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27063 [Internal Services/Tor Sysadmin Team]: Drop helix from the gitolite maintainer role

[Tor Bug Tracker & Wiki]

#27063: Drop helix from the gitolite maintainer role
-+
 Reporter:  arma |  Owner:  tpa
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by weasel):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 removed erinn from gid gitolite and gitweb.

 Somebody please update the wiki.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27079 [Internal Services/Tor Sysadmin Team]: Please remove irl from the LDAP group atlas (1535)

[Tor Bug Tracker & Wiki]

#27079: Please remove irl from the LDAP group atlas (1535)
-+
 Reporter:  irl  |  Owner:  tpa
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by weasel):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 removed irl from gid atlas by request

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27186 [Core Tor/Tor]: Inform users about configuration file and directory includes

[Tor Bug Tracker & Wiki]

#27186: Inform users about configuration file and directory includes
--+
 Reporter:  UntoSten  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Low   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  new => needs_review
 * milestone:   => Tor: 0.3.5.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27145 [Internal Services/Tor Sysadmin Team]: help.tpo accounts is not clear enough

[Tor Bug Tracker & Wiki]

#27145: help.tpo accounts is not clear enough
-+-
 Reporter:  juga |  Owner:  tpa
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 |  worksforme
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by weasel):

 * status:  new => closed
 * resolution:   => worksforme


Comment:

 It seems irl answered all your questions.

 If you have proposed changes to the text of the wiki, by all means propose
 :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27176 [Core Tor/Tor]: fix inaccurate rust docs

[Tor Bug Tracker & Wiki]

#27176: fix inaccurate rust docs
--+
 Reporter:  cyberpunks|  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  rust,doc  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15518 [Core Tor/Tor]: Tor considers routers in the same IPv6 /16 to be "in the same subnet"

[Tor Bug Tracker & Wiki]

#15518: Tor considers routers in the same IPv6 /16 to be "in the same subnet"
-+-
 Reporter:  isis |  Owner:  neel
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ipv6, path, path-bias, tor-client|  Actual Points:
  easy   |
Parent ID:  #24393   | Points:  1
 Reviewer:  teor |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 lgtm; merging

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15518 [Core Tor/Tor]: Tor considers routers in the same IPv6 /16 to be "in the same subnet"

[Tor Bug Tracker & Wiki]

#15518: Tor considers routers in the same IPv6 /16 to be "in the same subnet"
-+-
 Reporter:  isis |  Owner:  neel
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, path, path-bias, tor-client|  Actual Points:
  easy   |
Parent ID:  #24393   | Points:  1
 Reviewer:  teor |Sponsor:
-+-

Comment (by teor):

 The CI succeeded at https://travis-ci.org/teor2345/tor/branches

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26490 [Applications/Tor Browser]: When first launching 8.0a9 the screen.height starts at 612px

[Tor Bug Tracker & Wiki]

#26490: When first launching 8.0a9 the screen.height starts at 612px
+--
 Reporter:  cypherpunks |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201808  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * status:  needs_information => new


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26490 [Applications/Tor Browser]: When first launching 8.0a9 the screen.height starts at 612px

[Tor Bug Tracker & Wiki]

#26490: When first launching 8.0a9 the screen.height starts at 612px
+--
 Reporter:  cypherpunks |  Owner:  tbb-team
 Type:  defect  | Status:
|  needs_information
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201808  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by ProTipGuyFWIWWeLoveARMA):

 Replying to [comment:7 gk]:
 > Okay, back to this ticket:
 Your humble original reporter here:

 > I need some info to look closer at the window sizing problem: how did
 you determine that the height started with 612px? Did you look up a
 website after start, which showed that in turn? If so, which one?
 Opening new tab, going to https://fpcentral.tbb.torproject.org/fp and
 doing the do doing.

 PS: I can't change the ticket to `new` due to the new ultra-restrictive
 trac permission changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27159 [Metrics/Onionoo]: Release Onionoo 6.2-1.17.1

[Tor Bug Tracker & Wiki]

#27159: Release Onionoo 6.2-1.17.1
-+
 Reporter:  karsten  |  Owner:  karsten
 Type:  task | Status:  merge_ready
 Priority:  Medium   |  Milestone:  Onionoo 1.17.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by karsten):

 Release: https://dist.torproject.org/onionoo/6.2-1.17.1/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22170 [Applications/Tor Browser]: Check uses of ch.boye.httpclientandroidlib.impl.client.* for proxy safety on Android

[Tor Bug Tracker & Wiki]

#22170: Check uses of ch.boye.httpclientandroidlib.impl.client.* for proxy 
safety
on Android
-+-
 Reporter:  gk   |  Owner:  sysrqb
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, tbb-mobile,|  Actual Points:
  TorBrowserTeam201808R  |
Parent ID:  #21863   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 (2) seems like a good idea to me, I guess we can do this in a separate
 ticket, though?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27157 [Webpages/Website]: Update Tor FAQ - Tor has directory guards

[Tor Bug Tracker & Wiki]

#27157: Update Tor FAQ - Tor has directory guards
--+-
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy doc, FAQ |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-
Changes (by traumschule):

 * reviewer:  hiro =>


Comment:

 Thanks for the very helpful feedback, abandoning my WIP approach for this
 one.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23663 [Applications/Tor Browser]: ESR52 codebase is incompatible with anything below Universal C Runtime (CRT) in Windows

[Tor Bug Tracker & Wiki]

#23663: ESR52 codebase is incompatible with anything below Universal C Runtime
(CRT) in Windows
--+--
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Major | Resolution:  invalid
 Keywords:  tbb-security  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by crs):

 Oh, that's why 8.0a9 crashes on shutdown!
 https://hg.mozilla.org/mozilla-central/rev/73f1010eea4c

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27186 [Core Tor/Tor]: Inform users about configuration file and directory includes

[Tor Bug Tracker & Wiki]

#27186: Inform users about configuration file and directory includes
--+
 Reporter:  UntoSten  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Low   |  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Minor |   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 This patch makes it clearer to users what settings Tor daemon is actually
 using. I think it is pretty important.

 https://github.com/UntoSten/tor/tree/inform-about-conf-includes

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27159 [Metrics/Onionoo]: Release Onionoo 6.2-1.17.1

[Tor Bug Tracker & Wiki]

#27159: Release Onionoo 6.2-1.17.1
-+
 Reporter:  karsten  |  Owner:  karsten
 Type:  task | Status:  merge_ready
 Priority:  Medium   |  Milestone:  Onionoo 1.17.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by irl):

 * status:  needs_review => merge_ready


Comment:

 All looks good to me. Ready to deploy at 12:30 UTC.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25696 [Applications/Tor Browser]: Design of alpha onboarding for Tor Browser for Android

[Tor Bug Tracker & Wiki]

#25696: Design of alpha onboarding for Tor Browser for Android
-+-
 Reporter:  isabela  |  Owner:
 |  antonela
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team, tbb-mobile, |  Actual Points:
  TorBrowserTeam201808R  |
Parent ID:  #26531   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by antonela):

 * Attachment "alpha-mockups.zip" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27157 [Webpages/Website]: Update Tor FAQ - Tor has directory guards

[Tor Bug Tracker & Wiki]

#27157: Update Tor FAQ - Tor has directory guards
--+-
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy doc, FAQ |  Actual Points:
Parent ID:| Points:
 Reviewer:  hiro  |Sponsor:
--+-

Comment (by irl):

 traumschule: I can't speak for hiro but I know that I prefer to review
 small changes. If you pile up a whole load of commits in one PR then I
 would probably ignore it until it's too old to consider rebasing it and
 then it would never be merged. Small PRs are easy to review and improve
 your chances that it is merged.

 There are also quite a few people (I count 13 people) that can review and
 merge website changes, not just hiro. By setting the reviewer you will
 cause others that might have looked at your changes to ignore them until
 hiro is able to look at them. The reviewer field should really only be set
 by the person that is taking the review, or if you've already discussed
 with them the specific ticket.

 If all the changes you're making are in the same file (like the FAQ) then
 you could put all these together in the same PR especially if they are
 each only small changes in that file. As soon as you start touching
 unrelated things this should always be in a separate branch. Even so, I
 could see that your first change could already be merged while you're
 still working on other changes. There is no reason to artificially cause
 delays here.

 FWIW,
 
[[https://github.com/torproject/webwml/pull/13/commits/e2e7bc662a5c6e584a3b379964156aac8f4fad25|commit
 e2e7bc6]] looks good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25696 [Applications/Tor Browser]: Design of alpha onboarding for Tor Browser for Android

[Tor Bug Tracker & Wiki]

#25696: Design of alpha onboarding for Tor Browser for Android
-+-
 Reporter:  isabela  |  Owner:
 |  antonela
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team, tbb-mobile, |  Actual Points:
  TorBrowserTeam201808R  |
Parent ID:  #26531   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by igt0):

 * status:  needs_revision => needs_review


Comment:

 I updated the code, assets, links and copy.

 - Updated the last screen "Next" copy to "Start Browsing"
 - Update all the image assets to use the Tor ones
 - Fixed copy problems
 - Updated the code removing dead code
 - Updated the tab title, background and strip colors to follow the design

 https://trac.torproject.org/projects/tor/attachment/ticket/25696/0001-Bug-25696
 -Implement-alpha-onboarding-for-Tor-Browser.2.patch

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25696 [Applications/Tor Browser]: Design of alpha onboarding for Tor Browser for Android

[Tor Bug Tracker & Wiki]

#25696: Design of alpha onboarding for Tor Browser for Android
-+-
 Reporter:  isabela  |  Owner:
 |  antonela
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team, tbb-mobile, |  Actual Points:
  TorBrowserTeam201808R  |
Parent ID:  #26531   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by igt0):

 * Attachment "0001-Bug-25696-Implement-alpha-onboarding-for-Tor-
 Browser.2.patch" added.

 patch-r1

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27177 [Core Tor/Tor]: rust protover accepts tabs and newlines in protocol versions

[Tor Bug Tracker & Wiki]

#27177: rust protover accepts tabs and newlines in protocol versions
+--
 Reporter:  cyberpunks  |  Owner:  (none)
 Type:  defect  | Status:
|  needs_revision
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.5.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.3.9
 Severity:  Normal  | Resolution:
 Keywords:  rust,033-backport,034-backport  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by teor):

 This branch passed CI.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27185 [Core Tor/Tor]: test/test.c and lround() prototype

[Tor Bug Tracker & Wiki]

#27185: test/test.c and lround() prototype
-+-
 Reporter:  gvanem   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.4.6-rc
 Severity:  Minor| Resolution:
 Keywords:  clang-cl warning regression? |  Actual Points:
  windows|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:  clang-cl warning => clang-cl warning regression? windows
 * component:  Core Tor => Core Tor/Tor
 * milestone:   => Tor: 0.3.5.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27185 [Core Tor]: test/test.c and lround() prototype

[Tor Bug Tracker & Wiki]

#27185: test/test.c and lround() prototype
--+---
 Reporter:  gvanem|  Owner:  (none)
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Core Tor  |Version:  Tor: 0.3.4.6-rc
 Severity:  Minor | Resolution:
 Keywords:  clang-cl warning  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by teor):

 * status:  new => needs_information


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27185 [Core Tor]: test/test.c and lround() prototype

[Tor Bug Tracker & Wiki]

#27185: test/test.c and lround() prototype
--+-
 Reporter:  gvanem|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor  |Version:  Tor: 0.3.4.6-rc
 Severity:  Minor | Resolution:
 Keywords:  clang-cl warning  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-

Comment (by teor):

 Thanks for reporting this issue.

 Replying to [ticket:27185 gvanem]:
 > First off, I have to express my frustration with this Trac-system.
 Clumsy as hell; the Markdown support is a joke. I'd wish you'd moved to
 Github or Gitlab.

 Trac uses [https://trac.torproject.org/projects/tor/wiki/WikiFormatting
 WikiFormatting], not Markdown.

 We tried to move to our own Gitlab instance, but it didn't work out.

 We accept pull requests at https://github.com/torproject/tor , but please
 also open a minimal trac ticket with a title and link to the pull request.

 > Okay. To the issue. Compiling test/test.c using MSVC-2017 or clang-cl,
 spits out this warning:
 > {{{
 > test.c(42,10):  warning: 'lround' redeclared without 'dllimport'
 attribute: previous 'dllimport' ignored [-Winconsistent-dllimport]
 > long int lround(double x);
 > }}}
 >
 > From MSVC:
 > {{{
 > test.c(42): warning C4273: 'lround': inconsistent dll linkage
 >
 f:\ProgramFiler-x86\WindowsKits\Include\10.0.16299.0\ucrt\corecrt_math.h(520):
 > note: see previous definition of 'lround'
 > }}}

 Our CI uses gcc, otherwise we might have picked up this issue earlier.
 Do you think it would be easy to extend our Appveyor CI config to use
 clang-cl?
 https://github.com/torproject/tor/blob/master/.appveyor.yml

 > For Windows, it's already prototypes as (after C-preprocessing):
 > {{{
 > __declspec (dllimport)
 >   long long __cdecl llround (double _X);
 > }}}
 >
 > Why not use `tor_lround()` instead?
 > Same goes for `fabs()` I guess, but this function is **not** marked with
 `dllimport`!? Seems to be an intrinsic for clang-cl + MSVC.

 Does the warning go away if we use tor_lround() instead?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27177 [Core Tor/Tor]: rust protover accepts tabs and newlines in protocol versions

[Tor Bug Tracker & Wiki]

#27177: rust protover accepts tabs and newlines in protocol versions
+--
 Reporter:  cyberpunks  |  Owner:  (none)
 Type:  defect  | Status:
|  needs_revision
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.5.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.3.9
 Severity:  Normal  | Resolution:
 Keywords:  rust,033-backport,034-backport  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by teor):

 * status:  new => needs_revision
 * milestone:   => Tor: 0.3.5.x-final


Comment:

 Thanks for this patch, it looks good to me.

 Here's what needs to change before it merges:
 * code changes need a changes file that passes `make check-changes`
   * (doc and comment changes don't get a changes file)
 * the branch needs to be rebased onto maint-0.3.3

 Let us know if you don't want to make these changes, and someone else will
 do them eventually.

 And also:
 * we need to wait for the CI to pass:
   * I have pushed your branches to my github, which is set up to run
 travis
   * https://travis-ci.org/teor2345/tor/builds/417209205
   * if you want to run travis automatically, you can configure it on
 gitgud, or submit a pull request to https://github.com/torproject/tor

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27164 [Core Tor/Tor]: rust protover accepts "Link=1-5-foo"

[Tor Bug Tracker & Wiki]

#27164: rust protover accepts "Link=1-5-foo"
--+
 Reporter:  cyberpunks|  Owner:  (none)
 Type:  defect| Status:
  |  needs_revision
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.3.9
 Severity:  Normal| Resolution:
 Keywords:  rust, 033-backport, 034-backport  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+
Changes (by teor):

 * status:  needs_review => needs_revision
 * reviewer:   => teor


Comment:

 Thanks for this patch, it looks good to me.

 Here's what needs to change before it merges:
 * code changes need a changes file that passes `make check-changes`
   * (doc and comment changes don't get a changes file)
 * the branch needs to be rebased onto maint-0.3.3

 Let us know if you don't want to make these changes, and someone else will
 do them eventually.

 And also:
 * we need to wait for the CI to pass:
   * I have pushed your branches to my github, which is set up to run
 travis
   * https://travis-ci.org/teor2345/tor/builds/417209334
   * if you want to run travis automatically, you can configure it on
 gitgud, or submit a pull request to https://github.com/torproject/tor

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27185 [Core Tor]: test/test.c and lround() prototype

[Tor Bug Tracker & Wiki]

#27185: test/test.c and lround() prototype
--+-
 Reporter:  gvanem|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor  |Version:  Tor: 0.3.4.6-rc
 Severity:  Minor | Resolution:
 Keywords:  clang-cl warning  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-

Comment (by gvanem):

 The C-preprocessed prototype should be:
 {{{
 _declspec (dllimport)
   long __cdecl lround (double _X);
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27185 [Core Tor]: test/test.c and lround() prototype

[Tor Bug Tracker & Wiki]

#27185: test/test.c and lround() prototype
--+--
 Reporter:  gvanem|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor  |Version:  Tor: 0.3.4.6-rc
 Severity:  Minor |   Keywords:  clang-cl warning
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 First off, I have to express my frustration with this Trac-system. Clumsy
 as hell; the Markdown support is a joke. I'd wish you'd moved to Github or
 Gitlab.

 Okay. To the issue. Compiling test/test.c using MSVC-2017 or clang-cl,
 spits out this warning:
 {{{
 test.c(42,10):  warning: 'lround' redeclared without 'dllimport'
 attribute: previous 'dllimport' ignored [-Winconsistent-dllimport]
 long int lround(double x);
 }}}

 From MSVC:
 {{{
 test.c(42): warning C4273: 'lround': inconsistent dll linkage
 f:\ProgramFiler-x86\WindowsKits\Include\10.0.16299.0\ucrt\corecrt_math.h(520):
 note: see previous definition of 'lround'
 }}}

 For Windows, it's already prototypes as (after C-preprocessing):
 {{{
 __declspec (dllimport)
   long long __cdecl llround (double _X);
 }}}

 Why not use `tor_lround()` instead?
 Same goes for `fabs()` I guess, but this function is **not** marked with
 `dllimport`!? Seems to be an intrinsic for clang-cl + MSVC.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27184 [Applications/Tor Browser]: Adapt text in notification bar about security slider to new onion icon

[Tor Bug Tracker & Wiki]

#27184: Adapt text in notification bar about security slider to new onion icon
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201808R, |  Actual Points:
  tbb-torbutton, GeorgKoppen201808   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  ff60-esr, TorBrowserTeam201808, tbb-torbutton,
 GeorgKoppen201808 => ff60-esr, TorBrowserTeam201808R, tbb-torbutton,
 GeorgKoppen201808
 * status:  new => needs_review


Comment:

 `bug_27184_v2`
 
(https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_27184_v2=c3c975026035c36a4a14d570b8f8928b156b58e4)
 has the proposed change up for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27176 [Core Tor/Tor]: fix inaccurate rust docs

[Tor Bug Tracker & Wiki]

#27176: fix inaccurate rust docs
--+
 Reporter:  cyberpunks|  Owner:  (none)
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust,doc  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+
Changes (by teor):

 * status:  needs_revision => merge_ready


Comment:

 Thanks for explaining, sorry I missed that.
 I'm still getting used to all the different git interfaces.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27184 [Applications/Tor Browser]: Adapt text in notification bar about security slider to new onion icon (was: Adapt test in notification bar about security slider to new onion icon)

[Tor Bug Tracker & Wiki]

#27184: Adapt text in notification bar about security slider to new onion icon
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201808,  |  Actual Points:
  tbb-torbutton, GeorgKoppen201808   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27184 [Applications/Tor Browser]: Adapt test in notification bar about security slider to new onion icon

[Tor Bug Tracker & Wiki]

#27184: Adapt test in notification bar about security slider to new onion icon
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  ff60-esr,
 Severity:  Normal   |  TorBrowserTeam201808, tbb-
 |  torbutton, GeorgKoppen201808
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 We say "The green onion menu now" etc. but there is no green icon anymore.
 I think we could just omit the color and are good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26490 [Applications/Tor Browser]: When first launching 8.0a9 the screen.height starts at 612px

[Tor Bug Tracker & Wiki]

#26490: When first launching 8.0a9 the screen.height starts at 612px
+--
 Reporter:  cypherpunks |  Owner:  tbb-team
 Type:  defect  | Status:
|  needs_information
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201808  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * status:  new => needs_information


Comment:

 Okay, back to this ticket: I need some info to look closer at the window
 sizing problem: how did you determine that the height started with 612px?
 Did you look up a website after start, which showed that in turn? If so,
 which one?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27159 [Metrics/Onionoo]: Release Onionoo 6.2-1.17.1

[Tor Bug Tracker & Wiki]

#27159: Release Onionoo 6.2-1.17.1
-+
 Reporter:  karsten  |  Owner:  karsten
 Type:  task | Status:  needs_review
 Priority:  Medium   |  Milestone:  Onionoo 1.17.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by karsten):

 * status:  accepted => needs_review


Comment:

 Branch:
 
https://gitweb.torproject.org/user/karsten/onionoo.git/commit/?h=task-27159=79de0d2857c5b1fef811054513cec93113867f7d

 Tarball:
 ​https://people.torproject.org/~karsten/volatile/onionoo-6.2-1.17.1-pre0.tar.gz

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27159 [Metrics/Onionoo]: Release Onionoo 6.2-1.17.1 (was: Release Onionoo 6.2-1.17.0)

[Tor Bug Tracker & Wiki]

#27159: Release Onionoo 6.2-1.17.1
-+
 Reporter:  karsten  |  Owner:  karsten
 Type:  task | Status:  accepted
 Priority:  Medium   |  Milestone:  Onionoo 1.17.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by karsten):

 * status:  merge_ready => accepted


Comment:

 We did not deploy this release, because it doesn't contain a fix for
 #27163. Let's put out a patch release 6.2-1.17.1 and deploy that. Updated
 summary. Preparing release and pre-release tarball now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27180 [Metrics/Onionoo]: Remove DetailsDocumentFields interface

[Tor Bug Tracker & Wiki]

#27180: Remove DetailsDocumentFields interface
-+
 Reporter:  irl  |  Owner:  irl
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by karsten):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Merged. Closing. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27157 [Webpages/Website]: Update Tor FAQ - Tor has directory guards

[Tor Bug Tracker & Wiki]

#27157: Update Tor FAQ - Tor has directory guards
--+-
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy doc, FAQ |  Actual Points:
Parent ID:| Points:
 Reviewer:  hiro  |Sponsor:
--+-
Changes (by traumschule):

 * reviewer:   => hiro


Comment:

 I need to explain myself better. I titled the current pull request as work
 in progress with the intention to collect more commits, each fixing
 another issue referenced with '(fixes #bugnumber)'.
 Instead I could open a new PR for each ticket, but then it's more work to
 review them in git I guess. Will wait to see what hiro thinks when she is
 back.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26901 [Metrics/Onionoo]: Mention that a DNSSEC-validating resolver is used for reverse DNS lookups

[Tor Bug Tracker & Wiki]

#26901: Mention that a DNSSEC-validating resolver is used for reverse DNS 
lookups
-+
 Reporter:  nusenu   |  Owner:  irl
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by karsten):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Done. Closing. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26901 [Metrics/Onionoo]: Mention that a DNSSEC-validating resolver is used for reverse DNS lookups

[Tor Bug Tracker & Wiki]

#26901: Mention that a DNSSEC-validating resolver is used for reverse DNS 
lookups
-+--
 Reporter:  nusenu   |  Owner:  irl
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by karsten):

 Merging and deploying...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27180 [Metrics/Onionoo]: Remove DetailsDocumentFields interface

[Tor Bug Tracker & Wiki]

#27180: Remove DetailsDocumentFields interface
-+--
 Reporter:  irl  |  Owner:  irl
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by irl):

 Yes. There are no user facing or operational changes so I don't think this
 needs a changelog entry.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27180 [Metrics/Onionoo]: Remove DetailsDocumentFields interface

[Tor Bug Tracker & Wiki]

#27180: Remove DetailsDocumentFields interface
-+--
 Reporter:  irl  |  Owner:  irl
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by karsten):

 I think it's okay to just remove it.

 In fact, regarding `OrderParameters`, I think that these shouldn't use
 `DetailsDocumentFields` anyway, because parameter values and document
 fields are not necessarily the same thing. They happen to be the same in
 this case, and in most cases that makes sense, but there might be cases
 where they are not.

 Should I merge this change then?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27163 [Metrics]: Regular expression for valid AS numbers doesn't allow for AS 0

[Tor Bug Tracker & Wiki]

#27163: Regular expression for valid AS numbers doesn't allow for AS 0
-+
 Reporter:  nusenu   |  Owner:  irl
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  karsten  |Sponsor:
-+
Changes (by karsten):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good! Merged. Closing. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27163 [Metrics]: Regular expression for valid AS numbers doesn't allow for AS 0

[Tor Bug Tracker & Wiki]

#27163: Regular expression for valid AS numbers doesn't allow for AS 0
-+--
 Reporter:  nusenu   |  Owner:  irl
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  karsten  |Sponsor:
-+--
Changes (by karsten):

 * reviewer:   => karsten


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26901 [Metrics/Onionoo]: Mention that a DNSSEC-validating resolver is used for reverse DNS lookups

[Tor Bug Tracker & Wiki]

#26901: Mention that a DNSSEC-validating resolver is used for reverse DNS 
lookups
-+--
 Reporter:  nusenu   |  Owner:  irl
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by irl):

 Added a fixup commit with a change message.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26901 [Metrics/Onionoo]: Mention that a DNSSEC-validating resolver is used for reverse DNS lookups

[Tor Bug Tracker & Wiki]

#26901: Mention that a DNSSEC-validating resolver is used for reverse DNS 
lookups
-+--
 Reporter:  nusenu   |  Owner:  irl
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by karsten):

 Patch looks good. Further clarifications in the change log or change
 message might be useful, too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27178 [Applications/Tor Browser]: Generating of incremental MAR files fails due to new compression format

[Tor Bug Tracker & Wiki]

#27178: Generating of incremental MAR files fails due to new compression format
+--
 Reporter:  gk  |  Owner:  tbb-team
 Type:  defect  | Status:  closed
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201808R  |  Actual Points:
Parent ID:  #26050  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by boklm):

 I filled #27182 and #27183 for the 8.0.1 and 8.0.2 updates.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27183 [Applications/Tor Browser]: Update mar_compression for 8.0.2 release

[Tor Bug Tracker & Wiki]

#27183: Update mar_compression for 8.0.2 release
-+-
 Reporter:  boklm|  Owner:  tbb-team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  ff60-esr,
 Severity:  Normal   |  TorBrowserTeam201809
Actual Points:   |  Parent ID:  #26050
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Following #27178 and #27182, we need to update mar_compression to use xz
 for all versions.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs