Re: [tor-bugs] #27759 [Core Tor/Tor]: 3 Bugs in Tor relay logs

2018-09-18 Thread Tor Bug Tracker & Wiki
#27759: 3 Bugs in Tor relay logs
--+--
 Reporter:  fcornu|  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: 0.3.4.8
 Severity:  Normal| Resolution:  duplicate
 Keywords:|  Actual Points:
Parent ID:  #26434| Points:
 Reviewer:|Sponsor:
--+--
Changes (by teor):

 * status:  new => closed
 * resolution:   => duplicate
 * parent:   => #26434
 * milestone:   => Tor: unspecified


Old description:

> Greetings, all :)
>
> Got these in my relay's log this morning
>
> `Sep 18 06:00:58.000 [warn] connection_dir_finished_flushing(): Bug:
> Emptied a dirserv buffer, but it's still spooling! (on Tor 0.3.4.8 )Sep
> 18 06:00:58.000 [warn] connection_mark_for_close_internal_(): Bug:
> Duplicate call to connection_mark_for_close at ../src/or/directory.c:5201
> (first at ../src/or/main.c:1210) (on Tor 0.3.4.8 )Sep 18 06:00:58.000
> [warn] tor_bug_occurred_(): Bug: ../src/or/connection.c:841:
> connection_mark_for_close_internal_: This line should not have been
> reached. (Future instances of this warning will be silenced.) (on Tor
> 0.3.4.8 )Sep 18 06:00:58.000 [warn] Bug: Line unexpectedly reached at
> connection_mark_for_close_internal_ at ../src/or/connection.c:841. Stack
> trace: (on Tor 0.3.4.8 )Sep 18 06:00:58.000 [warn] Bug:
> /usr/bin/tor(log_backtrace+0x44) [0x5605ad9f8354] (on Tor 0.3.4.8 )Sep 18
> 06:00:58.000 [warn] Bug: /usr/bin/tor(tor_bug_occurred_+0xb9)
> [0x5605ada132f9] (on Tor 0.3.4.8 )Sep 18 06:00:58.000 [warn] Bug:
> /usr/bin/tor(connection_dir_finished_flushing+0xab) [0x5605ad9acd3b] (on
> Tor 0.3.4.8 )Sep 18 06:00:58.000 [warn] Bug:
> /usr/bin/tor(connection_handle_read+0xb7a) [0x5605ad98586a] (on Tor
> 0.3.4.8 )Sep 18 06:00:58.000 [warn] Bug: /usr/bin/tor(+0x53afe)
> [0x5605ad8c3afe] (on Tor 0.3.4.8 )Sep 18 06:00:58.000 [warn] Bug:
> /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5(event_base_loop+0x6a0)
> [0x7f5fe7ebb5a0] (on Tor 0.3.4.8 )Sep 18 06:00:58.000 [warn] Bug:
> /usr/bin/tor(do_main_loop+0x265) [0x5605ad8c5e95] (on Tor 0.3.4.8 )Sep 18
> 06:00:58.000 [warn] Bug: /usr/bin/tor(tor_run_main+0x1175)
> [0x5605ad8c8685] (on Tor 0.3.4.8 )Sep 18 06:00:58.000 [warn] Bug:
> /usr/bin/tor(tor_main+0x3a) [0x5605ad8c04ba] (on Tor 0.3.4.8 )Sep 18
> 06:00:58.000 [warn] Bug: /usr/bin/tor(main+0x19) [0x5605ad8c0229] (on
> Tor 0.3.4.8 )Sep 18 06:00:58.000 [warn] Bug: /lib/x86_64-linux-
> gnu/libc.so.6(__libc_start_main+0xf1) [0x7f5fe67172e1] (on Tor 0.3.4.8
> )Sep 18 06:00:58.000 [warn] Bug: /usr/bin/tor(_start+0x2a)
> [0x5605ad8c027a] (on Tor 0.3.4.8 )`
>
> As they appeared quite on the same time, I thought I'd report them in a
> single ticket, they may be related.
>
> Relay is 'wardsback'

New description:

 Greetings, all :)

 Got these in my relay's log this morning

 {{{
 Sep 18 06:00:58.000 [warn] connection_dir_finished_flushing(): Bug:
 Emptied a dirserv buffer, but it's still spooling! (on Tor 0.3.4.8 )
 Sep 18 06:00:58.000 [warn] connection_mark_for_close_internal_(): Bug:
 Duplicate call to connection_mark_for_close at ../src/or/directory.c:5201
 (first at ../src/or/main.c:1210) (on Tor 0.3.4.8 )
 Sep 18 06:00:58.000 [warn] tor_bug_occurred_(): Bug:
 ../src/or/connection.c:841: connection_mark_for_close_internal_: This line
 should not have been reached. (Future instances of this warning will be
 silenced.) (on Tor 0.3.4.8 )
 Sep 18 06:00:58.000 [warn] Bug: Line unexpectedly reached at
 connection_mark_for_close_internal_ at ../src/or/connection.c:841. Stack
 trace: (on Tor 0.3.4.8 )
 Sep 18 06:00:58.000 [warn] Bug: /usr/bin/tor(log_backtrace+0x44)
 [0x5605ad9f8354] (on Tor 0.3.4.8 )
 Sep 18 06:00:58.000 [warn] Bug: /usr/bin/tor(tor_bug_occurred_+0xb9)
 [0x5605ada132f9] (on Tor 0.3.4.8 )
 Sep 18 06:00:58.000 [warn] Bug:
 /usr/bin/tor(connection_dir_finished_flushing+0xab) [0x5605ad9acd3b] (on
 Tor 0.3.4.8 )
 Sep 18 06:00:58.000 [warn] Bug:
 /usr/bin/tor(connection_handle_read+0xb7a) [0x5605ad98586a] (on Tor
 0.3.4.8 )
 Sep 18 06:00:58.000 [warn] Bug: /usr/bin/tor(+0x53afe)
 [0x5605ad8c3afe] (on Tor 0.3.4.8 )
 Sep 18 06:00:58.000 [warn] Bug: /usr/lib/x86_64-linux-
 gnu/libevent-2.0.so.5(event_base_loop+0x6a0) [0x7f5fe7ebb5a0] (on Tor
 0.3.4.8 )
 Sep 18 06:00:58.000 [warn] Bug: /usr/bin/tor(do_main_loop+0x265)
 [0x5605ad8c5e95] (on Tor 0.3.4.8 )
 Sep 18 06:00:58.000 [warn] Bug: /usr/bin/tor(tor_run_main+0x1175)
 [0x5605ad8c8685] (on Tor 0.3.4.8 )
 Sep 18 06:00:58.000 [warn] Bug: /usr/bin/tor(tor_main+0x3a)
 [0x5605ad8c04ba] (on Tor 0.3.4.8 )
 Sep 18 06:00:58.000 [warn] Bug: /usr/bin/tor(main+0x19)
 [0x5605ad8c0229] (on Tor 0.3.4.8 )
 Sep 18 06:00:58.000 [warn] Bug: /lib/x86_64-linux-
 gnu/libc.so.6(__libc_start_main+0xf1) [0

Re: [tor-bugs] #26624 [Applications/Tor Browser]: NoScript blocks on Standard-Safer security setting in 8.0a9 contrary to behavior in 8.0a8

2018-09-18 Thread Tor Bug Tracker & Wiki
#26624: NoScript blocks  on Standard-Safer security setting in 8.0a9
contrary to behavior in 8.0a8
-+-
 Reporter:  cypherpunks  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-security-slider, noscript,   |  Actual Points:
  tbb-8.0-issues, tbb-regression,|
  tbb-8.0.1-can, GeorgKoppen201809,  |
  TorBrowserTeam201809R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Thanks. Cherry-picked to `master` (commit
 b9626557ddf9a3faf5fb88f99f479145d7789a7f).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27396 [Applications/Tor Launcher]: Don't track progress.dtd in the import translations script anymore

2018-09-18 Thread Tor Bug Tracker & Wiki
#27396: Don't track progress.dtd in the import translations script anymore
---+
 Reporter:  gk |  Owner:  brade
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Launcher  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  TorBrowserTeam201809R  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by gk):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Cherry-picked to `master` (commit
 2b89cfe9069de9851d4b71ccc9abbb4ecf888063), thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27264 [Applications/Tor Browser]: Bookmark items are not visible on the bookmarks toolbar

2018-09-18 Thread Tor Bug Tracker & Wiki
#27264: Bookmark items are not visible on the bookmarks toolbar
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-8.0-issues, tbb-regression,  |  Actual Points:
  tbb-8.0.1-can, GeorgKoppen201809,  |
  TorBrowserTeam201809R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Thanks! Merged to `tor-browser-60.2.0esr-8.5-1` (commit
 1d974fa2b70dfe07bea896c99c88d7f62f3268a5) and cherry-picked to `tor-
 browser-60.2.0esr-8.0-1` (commit
 3444c43fc135f68a2da2ebcded8c0adb89254f3f).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27760 [Applications/Tor Browser]: Use message.__meta to talk to NoScript

2018-09-18 Thread Tor Bug Tracker & Wiki
#27760: Use message.__meta to talk to NoScript
--+
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
  |  TorBrowserTeam201809R
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 For talking to NoScript we are using right now `message._messageName`
 which is deprecated. We should start using the newer `message.__meta`.

 rustybird wrote a patch for that over in #27427 and Arthur rebased and
 reviewed it:

 https://github.com/arthuredelstein/torbutton/commits/27427_alpha

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27760 [Applications/Tor Browser]: Use message.__meta to talk to NoScript

2018-09-18 Thread Tor Bug Tracker & Wiki
#27760: Use message.__meta to talk to NoScript
--+-
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201809R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-
Changes (by gk):

 * status:  new => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27427 [Applications/Tor Browser]: [PATCH] Fix NoScript IPC for about:blank by whitelisting messages

2018-09-18 Thread Tor Bug Tracker & Wiki
#27427: [PATCH] Fix NoScript IPC for about:blank by whitelisting messages
-+-
 Reporter:  rustybird|  Owner:
 |  arthuredelstein
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  TorBrowserTeam201809R,   |  Actual Points:
  tbb-8.0.1-can  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:10 arthuredelstein]:
 > After testing in Tor Browser, Rusty Bird's patch looks good to me. I
 changed it to use the better JS equality operator, but otherwise it's the
 same:
 >
 > Here it is rebased to origin/master:
 >
 > https://github.com/arthuredelstein/torbutton/commit/27427

 Thanks. Cherry-picked to `master` (commit
 8ff3b44e478ebddf5a067d796f57a353beae2af0). This will make it into 8.0.1.

 I opened #27760 for using `message.__meta` in the communication with
 NoScript.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27543 [Applications/Tor Browser]: QR code on http://web.whatsapp.com is only shortly visible in Tor Browser 8

2018-09-18 Thread Tor Bug Tracker & Wiki
#27543: QR code on http://web.whatsapp.com is only shortly visible in Tor 
Browser 8
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-8.0-issues, tbb-regression,  |  Actual Points:
  tbb-8.0.1-can, GeorgKoppen201809,  |
  TorBrowserTeam201809R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks! Cherry-picked to `tor-browser-60.2.0esr-8.5-1` (commit
 3b34acd2d3b755cef2fbd83ddf37545b6988eb0f) and `tor-
 browser-60.2.0esr-8.0-1` (commit
 367ce17b735fdfa1244aa78569e16ac6c90dd746).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27761 [Core Tor/Tor]: check-changes: check that bugfix versions have 3 numbers in them

2018-09-18 Thread Tor Bug Tracker & Wiki
#27761: check-changes: check that bugfix versions have 3 numbers in them
--+
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  fast-fix
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 I tried to modify lintChanges.py to check for bugfixes against future
 versions. But then I realised that we backport bugfixes.

 So I salvaged the version parsing code into a new check.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27761 [Core Tor/Tor]: check-changes: check that bugfix versions have 3 numbers in them

2018-09-18 Thread Tor Bug Tracker & Wiki
#27761: check-changes: check that bugfix versions have 3 numbers in them
--+
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  assigned => needs_review


Comment:

 See my branch ticket27761 at https://github.com/teor2345/tor.git

 I don't mind if this goes in 0.3.5 or 0.3.6.
 Tentatively assigning 0.3.5 because it's part of "make check".

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27489 [Community/Relays]: add openfiles-max and kern.maxfiles settings for OpenBSD

2018-09-18 Thread Tor Bug Tracker & Wiki
#27489: add  openfiles-max and kern.maxfiles settings for OpenBSD
--+--
 Reporter:  nusenu|  Owner:  egypcio
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Community/Relays  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by egypcio):

 got it! nice catch though;
 thanks for the heads up on this one here. appreciated!

 sorry it took me long to write anything back.

 PS: please check if rev10* also works for you, I really would like to roll
 that one back.

 [*]
 https://trac.torproject.org/projects/tor/wiki/TorRelayGuide/OpenBSD?version=10

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27762 [Applications/Tor Browser]: Implement better fix for Torbutton signing workaround

2018-09-18 Thread Tor Bug Tracker & Wiki
#27762: Implement better fix for Torbutton signing workaround
--+
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-mobile
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 In #27271 we implemented a workaround for mobile related to the Torbutton
 signing exemption. We should think about a cleaner fix as mentioned in
 comment:7:ticket:27271.

 There I noted
 {{{
 FWIW: ​https://bugzilla.mozilla.org/show_bug.cgi?id=1464766 landed in
 esr60 and might be a thing to consider here.
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27271 [Applications/Tor Browser]: Don't allow the user to install extensions from web

2018-09-18 Thread Tor Bug Tracker & Wiki
#27271: Don't allow the user to install extensions from web
---+--
 Reporter:  igt0   |  Owner:  tbb-team
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  TorBrowserTeam201808R, tbb-mobile  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by gk):

 Replying to [comment:7 gk]:
 > igt0, sysrqb: could anyone of you open a follow-up ticket with a plan
 for fixing the underlying issue better. FWIW:
 https://bugzilla.mozilla.org/show_bug.cgi?id=1464766 landed in esr60 and
 might be a thing to consider here.

 I opened #27762 for that.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27763 [Applications/Tor Browser]: Restrict Torbutton signing exemption to mobile

2018-09-18 Thread Tor Bug Tracker & Wiki
#27763: Restrict Torbutton signing exemption to mobile
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 In #27220 we made sure our Torbutton can be installed into Tor Browser for
 Android. The patch for that is not needed for desktop. We should clean it
 up accordingly.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27748 [Internal Services/Tor Sysadmin Team]: Updated PGP expiration for nickm

2018-09-18 Thread Tor Bug Tracker & Wiki
#27748: Updated PGP expiration for nickm
-+
 Reporter:  nickm|  Owner:  tpa
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by weasel):

 * status:  new => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27726 [Internal Services/Tor Sysadmin Team]: Please, update my OpenPGP key in LDAP

2018-09-18 Thread Tor Bug Tracker & Wiki
#27726: Please, update my OpenPGP key in LDAP
-+
 Reporter:  juga |  Owner:  tpa
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by weasel):

 * status:  new => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27763 [Applications/Tor Browser]: Restrict Torbutton signing exemption to mobile

2018-09-18 Thread Tor Bug Tracker & Wiki
#27763: Restrict Torbutton signing exemption to mobile
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  TorBrowserTeam201809R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * keywords:   => TorBrowserTeam201809R
 * status:  new => closed
 * resolution:   => fixed
 * cc: mcs, brade (added)


Comment:

 Fixed with commit d53c662d2fbb8053908ba776a2dbddd4f9817d4f on `tor-
 browser-60.2.0esr-8.5-1` and with commit
 ba30179040d81bdd4e326c710d7893eeb8c2a8c6 on `tor-browser-60.2.0esr-8.0-1`.
 mcs: Thanks for the review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27761 [Core Tor/Tor]: check-changes: check that bugfix versions have 3 numbers in them

2018-09-18 Thread Tor Bug Tracker & Wiki
#27761: check-changes: check that bugfix versions have 3 numbers in them
--+
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by cypherpunks3):

 Replying to [ticket:27761 teor]:
 > I tried to modify lintChanges.py to check for bugfixes against future
 versions. But then I realised that we backport bugfixes.
 >
 > So I salvaged the version parsing code into a new check.

 But don't you only backport bugfixes to versions that already have the
 bug?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27755 [Webpages/Website]: Please remove/deactivate Grant Writer job posting (website)

2018-09-18 Thread Tor Bug Tracker & Wiki
#27755: Please remove/deactivate Grant Writer job posting (website)
--+
 Reporter:  ewyatt|  Owner:  (none)
 Type:  task  | Status:  closed
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by traumschule):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 merged

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27619 [Webpages/Website]: Add press clips to website

2018-09-18 Thread Tor Bug Tracker & Wiki
#27619: Add press clips to website
--+
 Reporter:  steph |  Owner:  hiro
 Type:  enhancement   | Status:  closed
 Priority:  High  |  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by traumschule):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 merged

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26381 [Applications/Tor Browser]: about:tor page does not load on first start on Windows and browser is stuck in endless reload cycle

2018-09-18 Thread Tor Bug Tracker & Wiki
#26381: about:tor page does not load on first start on Windows and browser is 
stuck
in endless reload cycle
-+-
 Reporter:  gk   |  Owner:
 |  pospeselr
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-torbutton, ff60-esr, |  Actual Points:
  TorBrowserTeam201809R, tbb-backport|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * keywords:  tbb-torbutton, ff60-esr, TorBrowserTeam201809R => tbb-
 torbutton, ff60-esr, TorBrowserTeam201809R, tbb-backport
 * resolution:   => fixed


Comment:

 Bob seems to be happy with it, so let's take it for the alpha (there are
 some "." missing at the end of several sentences in the code but I take
 this nevertheless to finish the 8.5a2 release prep). commit
 62001bb019dbf0956454f8fc550ccc1e81ee8d3c has the fix on `tor-
 browser-60.2.0esr-8.5-1`. Nice work, Richard!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27546 [Applications/Tor Browser]: Vertical scrollbar is broken on Linux in Tor Browser 8 with Gtk3

2018-09-18 Thread Tor Bug Tracker & Wiki
#27546: Vertical scrollbar is broken on Linux in Tor Browser 8 with Gtk3
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression,  |  Actual Points:
  TorBrowserTeam201809R, GeorgKoppen201809   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_revision => needs_review
 * cc: boklm (added)


Comment:

 `bug_27546_v2` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_27546_v2&id=7bdbf3967110c9ba553dbacda4a1cc72cad1bbc4)
 has the review note addressed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27760 [Applications/Tor Browser]: Use message.__meta to talk to NoScript

2018-09-18 Thread Tor Bug Tracker & Wiki
#27760: Use message.__meta to talk to NoScript
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  TorBrowserTeam201809R, tbb-backport  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  TorBrowserTeam201809R => TorBrowserTeam201809R, tbb-backport
 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged to `master` (commit ec1c0f448893775b660313042709a9b057b3ab75). I
 reverted the `message._messageName`-patch in commit
 59f3b78349d8de267cf69fb8873971ff0d9ecf7b as that one is obsolete with the
 patches in this bug.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27623 [Applications/Tor Browser]: wrong default pref values in Tor Browser 8.0

2018-09-18 Thread Tor Bug Tracker & Wiki
#27623: wrong default pref values in Tor Browser 8.0
-+-
 Reporter:  mcs  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, tbb-8.0-issues,|  Actual Points:
  tbb-8.0.1-can, TorBrowserTeam201809|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  ff60-esr, tbb-8.0-issues, tbb-8.0.1-can, TorBrowserTeam201809R
 => ff60-esr, tbb-8.0-issues, tbb-8.0.1-can, TorBrowserTeam201809
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:6 mcs]:
 > Here is a patch to use for 8.5a2:
 > https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug27623-01&id=e8d4909fcd059614106222a858d8839b58fee00f

 That looks good to me. However, we do not sync the mozconfig files in
 `tor-browser` with those we actually use for building the browser part in
 `tor-browser-build` yet (see: #23656). Thus, could you add the relevant
 `tor-browser-build` changes as well?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21263 [Applications/Tor Browser]: Torbutton's readme still talks about toggling

2018-09-18 Thread Tor Bug Tracker & Wiki
#21263: Torbutton's readme still talks about toggling
--+
 Reporter:  arma  |  Owner:  traumschule
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-torbutton |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-torbutton, TorBrowserTeam201809R => tbb-torbutton


Comment:

 Thanks for the patch. Some nits:

 a/firefox/Firefox/
 {{{
 +Following our design philosophy we restrict plugins a lot, but this may
 not be
 +sufficient. Therefor we recommend not to install any Add-ons to Tor
 Browser.
 }}}
 That seems to be mixing plugins with add-ons which is confusing. I think
 you could just leave those two sentences out.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21263 [Applications/Tor Browser]: Torbutton's readme still talks about toggling

2018-09-18 Thread Tor Bug Tracker & Wiki
#21263: Torbutton's readme still talks about toggling
--+--
 Reporter:  arma  |  Owner:  traumschule
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-torbutton |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by traumschule):

 * status:  needs_revision => needs_review


Comment:

 
https://github.com/traumschule/torbutton/commit/0f49f64ef6776736f61e08b28394bd0fa1c05193

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27552 [Applications/Tor Browser]: Latest tor browser launcher broken on linux (CentOS 6.8)

2018-09-18 Thread Tor Bug Tracker & Wiki
#27552: Latest tor browser launcher broken on linux (CentOS 6.8)
-+-
 Reporter:  LinuxProbes  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-8.0-issues, tbb-regression,  |  Actual Points:
  TorBrowserTeam201809R, tbb-backport|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-8.0-issues, tbb-regression, TorBrowserTeam201809R =>
 tbb-8.0-issues, tbb-regression, TorBrowserTeam201809R, tbb-backport
 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Okay, let's take it for the alpha. Looks good to me. Cherry-picked to
 `master` (commit a0420227e3f10f159a40b08a70cbb8c66f64c342)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24351 [Applications/Tor Browser]: Block Global Active Adversary Cloudflare

2018-09-18 Thread Tor Bug Tracker & Wiki
#24351: Block Global Active Adversary Cloudflare
-+-
 Reporter:  nullius  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  reopened
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  security, privacy, anonymity, mitm,  |  Actual Points:
  cloudflare |
Parent ID:  #18361   | Points:  1000
 Reviewer:   |Sponsor:
-+-

Comment (by vRobM):

 CF is not an Attack. It's a contractual service.
 
[https://github.com/privacytoolsIO/privacytools.io/pull/512#issuecomment-422238838
 Stop the FUD].

 Rob
 About me 

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27546 [Applications/Tor Browser]: Vertical scrollbar is broken on Linux in Tor Browser 8 with Gtk3

2018-09-18 Thread Tor Bug Tracker & Wiki
#27546: Vertical scrollbar is broken on Linux in Tor Browser 8 with Gtk3
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-8.0-issues, tbb-regression,  |  Actual Points:
  TorBrowserTeam201809R, GeorgKoppen201809   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:6 gk]:
 > `bug_27546_v2` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_27546_v2&id=7bdbf3967110c9ba553dbacda4a1cc72cad1bbc4)
 has the review note addressed.

 This looks good to me. I cherry-picked this patch as commit
 `768e2c34a7516ab6e4ce2389d76c45603c3aa2fe` on master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27738 [Core Tor/Tor]: Travis: use the homebrew addon to reliably install dependencies

2018-09-18 Thread Tor Bug Tracker & Wiki
#27738: Travis: use the homebrew addon to reliably install dependencies
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-backport, 032-backport,  |  Actual Points:
  033-backport, 034-backport |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  assigned => needs_review
 * type:  defect => enhancement


Comment:

 See my branches bug27738-029 and bug27738-032 on
 https://github.com/teor2345/tor.git

 bug27738-032 merges cleanly forward into 0.3.3, 0.3.4, and master.

 The CI is here:
 * 029: https://travis-ci.org/teor2345/tor/builds/429961332
 * 032: https://travis-ci.org/teor2345/tor/builds/429964572
 * 033, 034, master: https://travis-ci.org/teor2345/tor/branches

 I also pushed the following branches, so I can compare build speeds and
 package versions without `brew update`:
 * before-bug27738-029
 * before-bug27738-032

 macOS builds now finish in about half the time (8 min vs 15 min, and 7-10
 min vs 13-17 min).

 Here are the package version downgrades:
 * openssl 1.0.2o_2 rather than 1.0.2p
 * zstd 1.3.4 rather than 1.3.5
 * ccache 3.4.2 rather than 3.4.3
 * asciidoc and xmlto always get installed, rather than only being
 installed when $ASCIIDOC_OPTIONS is set

 This change should also reduce the number of network accesses in our
 builds, making them more reliable.

 I also made a travis docs pull request to document the Homebrew addon:
 https://github.com/travis-ci/docs-travis-ci-com/pull/2023

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27760 [Applications/Tor Browser]: Use message.__meta to talk to NoScript

2018-09-18 Thread Tor Bug Tracker & Wiki
#27760: Use message.__meta to talk to NoScript
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  TorBrowserTeam201809R, tbb-backport  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by rustybird):

 * Attachment "Receive-startup-message-using-
 NoScript-10.1.9.2-protocol.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27764 [Core Tor/Tor]: crypto_rsa.c: CID 1439488: Resource leaks

2018-09-18 Thread Tor Bug Tracker & Wiki
#27764: crypto_rsa.c: CID 1439488:  Resource leaks
--+-
 Reporter:  asn   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  tor-crypto coverity
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+-
 Coverity report from 18th Sept:
 {{{
 /src/lib/crypt_ops/crypto_rsa.c: 558 in
 crypto_pk_read_private_key_from_filename()
 552 {
 553   struct stat st;
 554   char *buf = read_file_to_str(keyfile, 0, &st);
 555   if (!buf)
 556 return -1;
 557   if (st.st_size > MAX_PRIVKEY_FILE_LEN)
 >>> CID 1439488:  Resource leaks  (RESOURCE_LEAK)
 >>> Variable "buf" going out of scope leaks the storage it points to.
 558 return -1;
 559
 560   int rv = crypto_pk_read_private_key_from_string(env, buf,
 561
 (ssize_t)st.st_size);
 562   memwipe(buf, 0, (size_t)st.st_size);
 563   tor_free(buf);
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27760 [Applications/Tor Browser]: Use message.__meta to talk to NoScript

2018-09-18 Thread Tor Bug Tracker & Wiki
#27760: Use message.__meta to talk to NoScript
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  TorBrowserTeam201809R, tbb-backport  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Arthur turns out your branch contained a wrong patch. I fixed that by
 reverting the bad commit (which was
 efdc83fec6244d5f2e4b8880fef010a6e362d9dc) and cherry-picking rustybird's
 original patch (this is now commit
 6016a170f0266cf926b7ff305796ba83cc353536).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27764 [Core Tor/Tor]: crypto_rsa.c: CID 1439488: Resource leaks

2018-09-18 Thread Tor Bug Tracker & Wiki
#27764: crypto_rsa.c: CID 1439488:  Resource leaks
-+
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto coverity  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by asn):

 Fix is as simple as doing `tor_free(buf)` before the `return -1`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27764 [Core Tor/Tor]: crypto_rsa.c: CID 1439488: Resource leaks

2018-09-18 Thread Tor Bug Tracker & Wiki
#27764: crypto_rsa.c: CID 1439488:  Resource leaks
-+
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto coverity  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by asn):

 * status:  new => needs_review


Comment:

 Fix in branch `bug27764`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27760 [Applications/Tor Browser]: Use message.__meta to talk to NoScript

2018-09-18 Thread Tor Bug Tracker & Wiki
#27760: Use message.__meta to talk to NoScript
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  TorBrowserTeam201809R, tbb-backport  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by rustybird):

 Replying to [comment:3 gk]:
 > Arthur turns out your branch contained a wrong patch. I fixed that by
 reverting the bad commit (which was
 efdc83fec6244d5f2e4b8880fef010a6e362d9dc) and cherry-picking rustybird's
 original patch (this is now commit
 6016a170f0266cf926b7ff305796ba83cc353536).

 Oh, that was fast. Please ignore
 [https://trac.torproject.org/projects/tor/attachment/ticket/27760/Receive-
 startup-message-using-NoScript-10.1.9.2-protocol.patch Receive-startup-
 message-using-NoScript-10.1.9.2-protocol.patch] which I uploaded before
 your comment.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21263 [Applications/Tor Browser]: Torbutton's readme still talks about toggling

2018-09-18 Thread Tor Bug Tracker & Wiki
#21263: Torbutton's readme still talks about toggling
--+
 Reporter:  arma  |  Owner:  traumschule
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-torbutton |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by gk):

 * status:  needs_review => needs_revision


Comment:

 Looks good. One final request: can you squash the commits and rebase
 against master + add a bug number to the final commit: "Bug 21263: ..."

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27761 [Core Tor/Tor]: check-changes: check that bugfixes aren't on future versions (was: check-changes: check that bugfix versions have 3 numbers in them)

2018-09-18 Thread Tor Bug Tracker & Wiki
#27761: check-changes: check that bugfixes aren't on future versions
--+
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by teor):

 Replying to [comment:2 cypherpunks3]:
 > Replying to [ticket:27761 teor]:
 > > I tried to modify lintChanges.py to check for bugfixes against future
 versions. But then I realised that we backport bugfixes.
 > >
 > > So I salvaged the version parsing code into a new check.
 >
 > But don't you only backport bugfixes to versions that already have the
 bug?

 You're right, yes, we do. (But I bet we've got that wrong in the past, and
 backported bugfixes that say they're for a later version.)

 All the current changes files pass this new check, so let's see how we go.

 See my branch ticket27761, or https://github.com/torproject/tor/pull/353 .

 I also tested that "bugfix on 0.3.5.1-alpha" works, but 0.3.5.2-alpha and
 0.4.5.1-alpha fail the check.

 I backported the change to 0.2.9 and 0.3.2, to check that their changes
 files pass this new check:
 * https://travis-ci.org/teor2345/tor/branches

 (But I don't think we need to backport this change.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21263 [Applications/Tor Browser]: Torbutton's readme still talks about toggling

2018-09-18 Thread Tor Bug Tracker & Wiki
#21263: Torbutton's readme still talks about toggling
--+--
 Reporter:  arma  |  Owner:  traumschule
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-torbutton |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by traumschule):

 * status:  needs_revision => needs_review


Comment:

 {{{
 commit 02f3a9334acb1b1b72ee27c3e81013f8706f20d1 (HEAD -> master,
 origin/master, origin/HEAD, README)
 Author: traumschule 
 Date:   Sat Sep 15 15:43:15 2018 +0200

 Bug 21263: Remove outdated information from the README

 commit 6016a170f0266cf926b7ff305796ba83cc353536 (upstream/master)
 Author: Rusty Bird 
 Date:   Fri Sep 14 13:05:08 2018 +

 Bug 27760: Fix NoScript IPC for about:blank by whitelisting messages
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27765 [Core Tor/Tor]: Appveyor: only install packages for the current target

2018-09-18 Thread Tor Bug Tracker & Wiki
#27765: Appveyor: only install packages for the current target
--+
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  tor-ci
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 Currently, we install packages for 64 and 32 bit targets on both builds.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21263 [Applications/Tor Browser]: Torbutton's readme still talks about toggling

2018-09-18 Thread Tor Bug Tracker & Wiki
#21263: Torbutton's readme still talks about toggling
--+-
 Reporter:  arma  |  Owner:  traumschule
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  tbb-torbutton |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks! Merged to `master` (commit
 02f3a9334acb1b1b72ee27c3e81013f8706f20d1).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27175 [Applications/Tor Browser]: NoScript plugin does not save per-site permissions/settings when tor browser closes

2018-09-18 Thread Tor Bug Tracker & Wiki
#27175: NoScript plugin does not save per-site permissions/settings when tor
browser closes
-+-
 Reporter:  tor-user-1234|  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  noscript, tbb-regression,|  Actual Points:
  tbb-8.0-issues, TorBrowserTeam201809R, tbb-|
  backport   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  noscript, tbb-regression, tbb-8.0-issues,
 TorBrowserTeam201809R =>
 noscript, tbb-regression, tbb-8.0-issues, TorBrowserTeam201809R, tbb-
 backport
 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Okay, this works for me and the code looks good to me as well. I had to
 resolve some conflicts due to #27760 landing earlier but that should be
 fine.

 Commit 461b828c70bb85501db99fdf077af71b69ef7e0a on `master` has the fix.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27607 [Applications/Tor Browser]: Enabling SVG sets security slider back to "Safer" (was: Enabling SVG set security slider back to "Safer")

2018-09-18 Thread Tor Bug Tracker & Wiki
#27607: Enabling SVG sets security slider back to "Safer"
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-security-slider, |  Actual Points:
  tbb-8.0-issues, tbb-regression, tbb-8.0.1-can  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Description changed by gk:

Old description:

> Set the slider to "Safest" and then enabled SVG in `about:config`.
> Despite the wish to just enable SVG this sets the slider back to "Safer".
> Found by ln5

New description:

 Set the slider to "Safest" and then enable SVG in `about:config`. Despite
 the wish to just enable SVG this sets the slider back to "Safer". Found by
 ln5.

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27766 [- Select a component]: The bookmarks toolbar items are not displayed by default

2018-09-18 Thread Tor Bug Tracker & Wiki
#27766: The bookmarks toolbar items are not displayed by default
--+--
 Reporter:  goupille  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Component:  - Select a component
  Version:|   Severity:  Normal
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
 The bookmarks toolbar items are not displayed by default, even if the
 bookmarks toolbar is.

 to reproduce :

 - install a pristine Tor Browser (I tried on Debian)
 - opt-in to display the "Bookmarks Toolbar" (Library → Bookmarks →
 Bookmarking Tools → View Bookmarks Toolbar)
 - add a bookmark in that toolbar

 result: the bookmarks toolbar is empty

 to solve the issue, one need to right-click on the toolbar, click
 "Customize", and drag'n'drop "Bookmarks Toolbar Items" to the toolbar.

 note that it also affects all Tails users
 (https://labs.riseup.net/code/issues/15935).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27767 [Applications/Tor Browser]: The bookmarks toolbar items are not displayed by default

2018-09-18 Thread Tor Bug Tracker & Wiki
#27767: The bookmarks toolbar items are not displayed by default
--+--
 Reporter:  goupille  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Component:  Applications/Tor Browser
  Version:|   Severity:  Normal
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
 The bookmarks toolbar items are not displayed by default, even if the
 bookmarks toolbar is.

 to reproduce :

 - install a pristine Tor Browser (I tried on Debian)
 - opt-in to display the "Bookmarks Toolbar" (Library → Bookmarks →
 Bookmarking Tools → View Bookmarks Toolbar)
 - add a bookmark in that toolbar

 result: the bookmarks toolbar is empty

 to solve the issue, one need to right-click on the toolbar, click
 "Customize", and drag'n'drop "Bookmarks Toolbar Items" to the toolbar.

 note that it also affects all Tails users
 (https://labs.riseup.net/code/issues/15935).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27758 [Internal Services/Service - trac]: Tor Website->Volunteer->Tor->Bug Tracker: REPORT_VIEW privileges are required to perform this operation on report:12. You don't have the requi

2018-09-18 Thread Tor Bug Tracker & Wiki
#27758: Tor Website->Volunteer->Tor->Bug Tracker: REPORT_VIEW privileges are
required to perform this operation on report:12. You don't have the
required permissions.
--+-
 Reporter:  neel  |  Owner:  qbi
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Internal Services/Service - trac  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-

Comment (by cypherpunks3):

 Replying to [comment:2 traumschule]:
 > a crawl bot caused a lot of load today so this feature was disabled,
 hopefully just temporarily, sorry :/

 So the high load was the cause of recent 503 errors, and the reason
 [https://trac.torproject.org/projects/tor/timeline TIMELINE_VIEW] and
 [https://trac.torproject.org/projects/tor/roadmap ROADMAP_VIEW]
 permissions were removed yesterday, too?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27768 [Applications/Tor Browser]: Issues & Enhancements

2018-09-18 Thread Tor Bug Tracker & Wiki
#27768: Issues & Enhancements
-+-
 Reporter:  therapid |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Component:  Applications/Tor
 |  Browser
  Version:  Tor: unspecified |   Severity:  Normal
 Keywords:  menu html customize  |  Actual Points:
  bookmark   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
 1.As you see the highlighted part in the "help" menu is useless so please
 remove it

 2.The "menu" button on the right doesn't open

 3.As in the picture the "customize" tab is barely opens after few retries
 ,even though it's blank & i'm unable to make any customize

 4.Whenever i try to import my "html bookmarks" file the browser bookmarks
 remains ((empty)) ,also the "bookmark this page" function is broken

 5.Please kindly retrieve back the "Test Tor Network Settings" feature to
 the "about:tor" homepage

 6.Please kindly retrieve the "tor button" back it's former version

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27768 [Applications/Tor Browser]: Issues & Enhancements

2018-09-18 Thread Tor Bug Tracker & Wiki
#27768: Issues & Enhancements
--+
 Reporter:  therapid  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:  Tor:
  |  unspecified
 Severity:  Normal| Resolution:
 Keywords:  menu html customize bookmark  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by therapid):

 * Attachment "-.jpg" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27764 [Core Tor/Tor]: crypto_rsa.c: CID 1439488: Resource leaks

2018-09-18 Thread Tor Bug Tracker & Wiki
#27764: crypto_rsa.c: CID 1439488:  Resource leaks
-+
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-crypto coverity  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 merged and added a changes file!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27734 [Core Tor/Tor]: tor on OpenSSL claims not to support LinkAuth=1

2018-09-18 Thread Tor Bug Tracker & Wiki
#27734: tor on OpenSSL claims not to support LinkAuth=1
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:  #27288| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 This was indeed fixed by the commit above.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27333 [Core Tor/Tor]: outdated docs for onion_extend_cpath()

2018-09-18 Thread Tor Bug Tracker & Wiki
#27333: outdated docs for onion_extend_cpath()
--+
 Reporter:  cyberpunks|  Owner:  traumschule
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.1.2.4-alpha
 Severity:  Normal| Resolution:  fixed
 Keywords:  doc   |  Actual Points:
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27073 [Core Tor/Tor]: conditionvar_timeout intermittently fails on maint-0.3.3

2018-09-18 Thread Tor Bug Tracker & Wiki
#27073: conditionvar_timeout intermittently fails on maint-0.3.3
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.8
 Severity:  Normal   | Resolution:
 Keywords:  tor-test, 029-backport 032-backport  |  Actual Points:
  033-backport 034-backport  |
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by nickm):

 * milestone:  Tor: 0.3.5.x-final => Tor: 0.3.4.x-final


Comment:

 merging to master; marking for possible backport.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27742 [UX/Research]: Usability Research: Onions Mombasa, Kenya

2018-09-18 Thread Tor Bug Tracker & Wiki
#27742: Usability Research: Onions Mombasa, Kenya
-+--
 Reporter:  nyinz|  Owner:  nyinz
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  UX/Research  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team  |  Actual Points:
Parent ID:  #27010   | Points:
 Reviewer:  antonela |Sponsor:
-+--
Changes (by antonela):

 * owner:  antonela => nyinz
 * reviewer:   => antonela
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27743 [UX/Research]: Usability Research: Circuit Display-Mombasa, Kenya

2018-09-18 Thread Tor Bug Tracker & Wiki
#27743: Usability Research: Circuit Display-Mombasa, Kenya
-+--
 Reporter:  nyinz|  Owner:  nyinz
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  UX/Research  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team  |  Actual Points:
Parent ID:  #27010   | Points:
 Reviewer:  antonela |Sponsor:
-+--
Changes (by antonela):

 * owner:  antonela => nyinz
 * reviewer:   => antonela
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27744 [UX/Research]: Usability Research: Circuit Display: Nairobi (group 1)

2018-09-18 Thread Tor Bug Tracker & Wiki
#27744: Usability Research: Circuit Display: Nairobi (group 1)
-+--
 Reporter:  nyinz|  Owner:  nyinz
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  UX/Research  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team  |  Actual Points:
Parent ID:  #27010   | Points:
 Reviewer:  antonela |Sponsor:
-+--
Changes (by antonela):

 * owner:  antonela => nyinz
 * reviewer:   => antonela
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27745 [UX/Research]: Usability Research: Circuit Display: Nairobi (group 2)

2018-09-18 Thread Tor Bug Tracker & Wiki
#27745: Usability Research: Circuit Display: Nairobi (group 2)
-+--
 Reporter:  nyinz|  Owner:  nyinz
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  UX/Research  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team  |  Actual Points:
Parent ID:  #27010   | Points:
 Reviewer:  antonela |Sponsor:
-+--
Changes (by antonela):

 * owner:  antonela => nyinz
 * reviewer:   => antonela
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27747 [UX/Research]: Usability Research: Onions- Nairobi (group 1)

2018-09-18 Thread Tor Bug Tracker & Wiki
#27747: Usability Research: Onions- Nairobi (group 1)
-+--
 Reporter:  nyinz|  Owner:  nyinz
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  UX/Research  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team  |  Actual Points:
Parent ID:  #27010   | Points:
 Reviewer:  antonela |Sponsor:
-+--
Changes (by antonela):

 * owner:  antonela => nyinz
 * reviewer:   => antonela
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27149 [UX/Research]: TB8 Alpha Users Feedback

2018-09-18 Thread Tor Bug Tracker & Wiki
#27149: TB8 Alpha Users Feedback
-+--
 Reporter:  nyinz|  Owner:  nyinz
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  UX/Research  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team  |  Actual Points:
Parent ID:  #27010   | Points:
 Reviewer:  antonela |Sponsor:
-+--
Changes (by antonela):

 * owner:  antonela => nyinz
 * reviewer:   => antonela
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27747 [UX/Research]: Usability Research: Onions - Nairobi (group 1) (was: Usability Research: Onions- Nairobi (group 1))

2018-09-18 Thread Tor Bug Tracker & Wiki
#27747: Usability Research: Onions - Nairobi (group 1)
-+--
 Reporter:  nyinz|  Owner:  nyinz
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  UX/Research  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team  |  Actual Points:
Parent ID:  #27010   | Points:
 Reviewer:  antonela |Sponsor:
-+--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27743 [UX/Research]: Usability Research: Circuit Display - Mombasa, Kenya (was: Usability Research: Circuit Display-Mombasa, Kenya)

2018-09-18 Thread Tor Bug Tracker & Wiki
#27743: Usability Research: Circuit Display - Mombasa, Kenya
-+--
 Reporter:  nyinz|  Owner:  nyinz
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  UX/Research  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team  |  Actual Points:
Parent ID:  #27010   | Points:
 Reviewer:  antonela |Sponsor:
-+--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27206 [Core Tor/Tor]: rust protover_all_supported() takes forever on some inputs

2018-09-18 Thread Tor Bug Tracker & Wiki
#27206: rust protover_all_supported() takes forever on some inputs
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  rust, protover, 033-backport,|  Actual Points:
  034-backport   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 merged to 0.3.3 and forward

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26368 [Core Tor/Tor]: Consider circuit isolation when closing redundant intro points

2018-09-18 Thread Tor Bug Tracker & Wiki
#26368: Consider circuit isolation when closing redundant intro points
-+-
 Reporter:  sysrqb   |  Owner:  neel
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tor-client, 035-roadmap- |  Actual Points:
  proposed, tbb-needs|
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => needs_revision


Comment:

 Hi! Thanks for this patch!

 I have a request and a question and a concern:

 The request: Could somebody replace the "bugfix on 0.3.5.1-alpha" in the
 changelog with the actual version that first contained this bug?  (If a
 bug first appears in A, and we fix it in B, the changelog should say
 "bugfix on A".)

 The question: Does this apply to v3 onion services too?  Should it?

 The concern: I don't know if checking the "mixed" flags for equality is
 what we actually want here. (The flag "ISO_XYZ" is set in
 `isolation_flags_mixed` when the circuit have been used to connect streams
 with two different values for the "XYZ" parameter.  Why are we looking at
 that?)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23512 [Core Tor/Tor]: Bandwidth stats info leak upon close of circuits with queued cells

2018-09-18 Thread Tor Bug Tracker & Wiki
#23512: Bandwidth stats info leak upon close of circuits with queued cells
-+-
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-bug-bounty, congestion-attack,   |  Actual Points:
  research, watermark, tor-stats, guard- |
  discovery-stats, 034-triage-20180328,  |
  034-removed-20180328   |
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
 |  SponsorQ
-+-
Changes (by nickm):

 * milestone:  Tor: 0.3.5.x-final => Tor: 0.3.4.x-final


Comment:

 Merged to master; marking for backport (assuming nothing breaks).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27769 [Applications/Tor Browser]: How to update Tor core only on TBB 7.5.6?

2018-09-18 Thread Tor Bug Tracker & Wiki
#27769: How to update Tor core only on TBB 7.5.6?
---+--
 Reporter:  Luddite|  Owner:  tbb-team
 Type:  task   | Status:  new
 Priority:  Medium |  Component:  Applications/Tor Browser
  Version:  Tor: unspecified   |   Severity:  Normal
 Keywords:  XP, compatability  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
 I'm unable to run TBB 8.0 on my old system because it's based on Quantum.
 Is there a way to at least update only Tor in TBB 7.5.6? Simply
 overwriting the files from an unzipped TBB 8.0 didn't work.

 Like 10% of internet users I'm still using XP. I'd rather risk a slim
 chance of pwnge by a windows vulnerability than a certain chance of pwnge
 by Microsoft and PRISM on a modern OS. Upgrading my machine isn't an
 option either because 8th gen intel drivers are only supported on Windows
 10.

 I respect Tor's decision to move to Quantum but since XP is the only
 option for privacy conscious users who can't migrate to Linux please
 provide us with a way to keep Tor core updated.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27767 [Applications/Tor Browser]: The bookmarks toolbar items are not displayed by default

2018-09-18 Thread Tor Bug Tracker & Wiki
#27767: The bookmarks toolbar items are not displayed by default
--+--
 Reporter:  goupille  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  AffectsTails  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by intrigeri):

 * cc: intrigeri (added)
 * keywords:   => AffectsTails


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27766 [- Select a component]: The bookmarks toolbar items are not displayed by default

2018-09-18 Thread Tor Bug Tracker & Wiki
#27766: The bookmarks toolbar items are not displayed by default
--+---
 Reporter:  goupille  |  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  - Select a component  |Version:
 Severity:  Normal| Resolution:  duplicate
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by intrigeri):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 duplicates https://trac.torproject.org/projects/tor/ticket/27767

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27767 [Applications/Tor Browser]: The bookmarks toolbar items are not displayed by default

2018-09-18 Thread Tor Bug Tracker & Wiki
#27767: The bookmarks toolbar items are not displayed by default
--+--
 Reporter:  goupille  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  AffectsTails  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by mcs):

 This is a duplicate of #27264.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27264 [Applications/Tor Browser]: Bookmark items are not visible on the bookmarks toolbar

2018-09-18 Thread Tor Bug Tracker & Wiki
#27264: Bookmark items are not visible on the bookmarks toolbar
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-8.0-issues, tbb-regression,  |  Actual Points:
  tbb-8.0.1-can, GeorgKoppen201809,  |
  TorBrowserTeam201809R, AffectsTails|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * cc: goupille, intrigeri (added)
 * keywords:
 tbb-8.0-issues, tbb-regression, tbb-8.0.1-can, GeorgKoppen201809,
 TorBrowserTeam201809R
 =>
 tbb-8.0-issues, tbb-regression, tbb-8.0.1-can, GeorgKoppen201809,
 TorBrowserTeam201809R, AffectsTails


Comment:

 #27767 is a duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27767 [Applications/Tor Browser]: The bookmarks toolbar items are not displayed by default

2018-09-18 Thread Tor Bug Tracker & Wiki
#27767: The bookmarks toolbar items are not displayed by default
--+---
 Reporter:  goupille  |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  duplicate
 Keywords:  AffectsTails  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by mcs):

 * status:  new => closed
 * resolution:   => duplicate


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #4700 [Core Tor/Tor]: Tor should provide a mechanism for hidden services to differentiate authorized clients and circuits

2018-09-18 Thread Tor Bug Tracker & Wiki
#4700: Tor should provide a mechanism for hidden services to differentiate
authorized clients and circuits
-+-
 Reporter:  katmagic |  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-control, needs-proposal, tor-|  Actual Points:
  hs, needs-design, 035-roadmap-master   |
Parent ID:   | Points:  10
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => needs_revision


Comment:

 Hi!  This patch looks good.

 Three things I think we should do here:
   * I think that the configuration option should accept "none" in addition
 to "haproxy".
   * We should link to the spec for this protocol, in the code and in the
 manual, and explain which version we support.
   * Are we exposing the 'global_identifier' field for an important reason,
 or is it just important that we expose _some_ unique value?  If it's the
 latter case, instead of putting the 'global_identifier' into the IPv6
 address and source port directly, I think we should hash them first,
 possibly with siphash.  It's not that these values are very sensitive, but
 I don't want anybody depending on the actual global_identifier layouts
 from Tor unless we're exposing them intentionally.  (But if we are
 exposing them intentionally, we should document that.)

 One thing for the future, or maybe I don't understand this:
   * Is there some intended way for programs to tell whether a user's
 circuit is authenticated, and if so to which user?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27393 [Community/Translations]: doubled/similar strings in support page

2018-09-18 Thread Tor Bug Tracker & Wiki
#27393: doubled/similar strings in support page
+--
 Reporter:  traumschule |  Owner:  emmapeel
 Type:  defect  | Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  Community/Translations  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by ggus):

 * owner:  ggus => emmapeel


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27750 [Core Tor/Tor]: conn_close_if_marked: Non-fatal assertion !(connection_is_writing(conn))

2018-09-18 Thread Tor Bug Tracker & Wiki
#27750: conn_close_if_marked: Non-fatal assertion !(connection_is_writing(conn))
+
 Reporter:  dgoulet |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.4.8
 Severity:  Normal  | Resolution:
 Keywords:  regression, assert  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+

Comment (by udo):

 The same box experienced an out of memory (4GB!) event (or two) and tor
 got killed, and restarted.
 Nothing much else is running there which is quiet stable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27770 [Webpages/Support]: Support portal -- question permalink view breaks sidebar

2018-09-18 Thread Tor Bug Tracker & Wiki
#27770: Support portal -- question permalink view breaks sidebar
+--
 Reporter:  alison  |  Owner:  hiro
 Type:  defect  | Status:  assigned
 Priority:  Medium  |  Component:  Webpages/Support
  Version:  |   Severity:  Normal
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
 When on support.torproject.org, when you click a question permalink (eg
 https://support.torproject.org/faq/faq-1/), clicking back to the sidebar
 menu topics retrieves "about:blank" instead of bringing you to that topic.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16576 [Webpages/Website]: Add a 'community projects' list (separate page?) to the website

2018-09-18 Thread Tor Bug Tracker & Wiki
#16576: Add a 'community projects' list (separate page?) to the website
+--
 Reporter:  arma|  Owner:  traumschule
 Type:  task| Status:  needs_review
 Priority:  Medium  |  Milestone:  WebsiteV3
Component:  Webpages/Website|Version:
 Severity:  Normal  | Resolution:
 Keywords:  defer-new-website, ux-team  |  Actual Points:
Parent ID:  #24133  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by alison):

 +1!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #4700 [Core Tor/Tor]: Tor should provide a mechanism for hidden services to differentiate authorized clients and circuits

2018-09-18 Thread Tor Bug Tracker & Wiki
#4700: Tor should provide a mechanism for hidden services to differentiate
authorized clients and circuits
-+-
 Reporter:  katmagic |  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-control, needs-proposal, tor-|  Actual Points:
  hs, needs-design, 035-roadmap-master   |
Parent ID:   | Points:  10
 Reviewer:  dgoulet  |Sponsor:
-+-

Comment (by nickm):

 After talking with ahf, I think we shouldn't hash the global_identifier,
 but we should document that we use it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27623 [Applications/Tor Browser]: wrong default pref values in Tor Browser 8.0

2018-09-18 Thread Tor Bug Tracker & Wiki
#27623: wrong default pref values in Tor Browser 8.0
-+-
 Reporter:  mcs  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, tbb-8.0-issues,|  Actual Points:
  tbb-8.0.1-can, TorBrowserTeam201809R   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * status:  needs_revision => needs_review
 * keywords:  ff60-esr, tbb-8.0-issues, tbb-8.0.1-can, TorBrowserTeam201809
 => ff60-esr, tbb-8.0-issues, tbb-8.0.1-can, TorBrowserTeam201809R


Comment:

 Replying to [comment:8 gk]:
 > That looks good to me. However, we do not sync the mozconfig files in
 `tor-browser` with those we actually use for building the browser part in
 `tor-browser-build` yet (see: #23656). Thus, could you add the relevant
 `tor-browser-build` changes as well?

 Sorry about that; for some reason I thought we had fixed that problem. We
 should ;)
 Here is a `tor-browser-build` patch:
 https://gitweb.torproject.org/user/brade/tor-browser-
 build.git/commit/?h=bug27623-01&id=f49b8306354f68dcaf8efeec8a4bd8b5a8908e6b

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27480 [Webpages/Website]: Add win64 to the stable downloads page

2018-09-18 Thread Tor Bug Tracker & Wiki
#27480: Add win64 to the stable downloads page
--+
 Reporter:  boklm |  Owner:  boklm
 Type:  task  | Status:  closed
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  TorBrowserTeam201809  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by boklm):

 It looks like commit `492a32ee822bcc3e1e65198faa8ac4b7c15085bc` removed
 the win64 version from the download page, probably by mistake. I re-added
 it again with commit `66ca644744a0a9cff7d2d38006e6fbe298e7012d`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27686 [Core Tor/Tor]: OOM code should count space used in a circuit's half-closed list

2018-09-18 Thread Tor Bug Tracker & Wiki
#27686: OOM code should count space used in a circuit's half-closed list
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  034-backport?  |  Actual Points:
Parent ID: | Points:
 Reviewer:  ahf|Sponsor:
---+
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 PR 335 looks fine.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16576 [Webpages/Website]: Add a 'community projects' list (separate page?) to the website

2018-09-18 Thread Tor Bug Tracker & Wiki
#16576: Add a 'community projects' list (separate page?) to the website
+-
 Reporter:  arma|  Owner:  traumschule
 Type:  task| Status:  closed
 Priority:  Medium  |  Milestone:  WebsiteV3
Component:  Webpages/Website|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  defer-new-website, ux-team  |  Actual Points:
Parent ID:  #24133  | Points:
 Reviewer:  |Sponsor:
+-
Changes (by traumschule):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27480 [Webpages/Website]: Add win64 to the stable downloads page

2018-09-18 Thread Tor Bug Tracker & Wiki
#27480: Add win64 to the stable downloads page
--+
 Reporter:  boklm |  Owner:  boklm
 Type:  task  | Status:  closed
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  TorBrowserTeam201809  |  Actual Points:
Parent ID:  #14686| Points:
 Reviewer:|Sponsor:
--+
Changes (by traumschule):

 * parent:   => #14686


Comment:

 didn't know about this ticket. need to check updates to that page when
 rebasing
 https://github.com/torproject/webwml/pull/12

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27769 [Applications/Tor Browser]: How to update Tor core only on TBB 7.5.6?

2018-09-18 Thread Tor Bug Tracker & Wiki
#27769: How to update Tor core only on TBB 7.5.6?
--+--
 Reporter:  Luddite   |  Owner:  tbb-team
 Type:  task  | Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:  wontfix
 Keywords:  XP, compatability |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by boklm):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 Privacy conscious users should not continue to use Tor Browser 7.5.6. It
 has known vulnerabilities (in the browser part, so updating Tor wouldn't
 fix that), and most users have updated (or are going to update) to Tor
 Browser 8.0, so remaining 7.5.6 users are going to stand out from the
 other Tor Browser users.

 If you cannot change the operating system on your machine, an option might
 be to boot a Tails USB key when you need to use Tor Browser:
 https://tails.boum.org/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27750 [Core Tor/Tor]: conn_close_if_marked: Non-fatal assertion !(connection_is_writing(conn))

2018-09-18 Thread Tor Bug Tracker & Wiki
#27750: conn_close_if_marked: Non-fatal assertion !(connection_is_writing(conn))
+
 Reporter:  dgoulet |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.4.8
 Severity:  Normal  | Resolution:
 Keywords:  regression, assert  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+

Comment (by udo):

 {{{
 MaxMemInQueues 1024 MB
 }}}

 So OoM is unexpected.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27698 [Webpages/Website]: Add new Tor Browser subkey to verifying signatures website

2018-09-18 Thread Tor Bug Tracker & Wiki
#27698: Add new Tor Browser subkey to verifying signatures website
--+
 Reporter:  gk|  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:  #22637| Points:
 Reviewer:|Sponsor:
--+
Changes (by traumschule):

 * status:  needs_review => closed
 * resolution:   => fixed
 * parent:  #27699 => #22637


Comment:

 merged

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27702 [Webpages/Website]: Link keys.txt and its signature at the signing keys page

2018-09-18 Thread Tor Bug Tracker & Wiki
#27702: Link keys.txt and its signature at the signing keys page
--+
 Reporter:  traumschule   |  Owner:  (none)
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:  #22637| Points:
 Reviewer:|Sponsor:
--+
Changes (by traumschule):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 merged

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27191 [Core Tor/Tor]: handling double spaces in protover

2018-09-18 Thread Tor Bug Tracker & Wiki
#27191: handling double spaces in protover
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, 029-backport, 032-backport,|  Actual Points:
  033-backport, 034-backport |
Parent ID:   | Points:
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Sorry for the delay -- I do think we should use the metaformat from the
 rest of the spec, and change the spec to WS here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26398 [Core Tor/Tor]: feature gate testing C code from Rust for now

2018-09-18 Thread Tor Bug Tracker & Wiki
#26398: feature gate testing C code from Rust for now
--+
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:
  |  needs_information
 Priority:  Very High |  Milestone:  Tor:
  |  unspecified
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.3.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  rust, tor-test, fast-fix, tor-ci  |  Actual Points:
Parent ID:  #25386| Points:  1
 Reviewer:  nickm |Sponsor:
  |  Sponsor8-can
--+
Changes (by nickm):

 * milestone:  Tor: 0.3.5.x-final => Tor: unspecified


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27728 [Core Tor/Tor]: test: Build an HSv3 descriptor with authorized client is apparently broken

2018-09-18 Thread Tor Bug Tracker & Wiki
#27728: test: Build an HSv3 descriptor with authorized client is apparently 
broken
--+
 Reporter:  Hello71   |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  new => accepted
 * owner:  (none) => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27728 [Core Tor/Tor]: Signature mismatch for crypto_strongest_rand() in ed-donna code breaks -flto compilation (was: test: Build an HSv3 descriptor with authorized client is apparently

2018-09-18 Thread Tor Bug Tracker & Wiki
#27728: Signature mismatch for crypto_strongest_rand() in ed-donna code breaks
-flto compilation
--+
 Reporter:  Hello71   |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27474 [Community/Tor Browser Manual]: update tb-manual build script

2018-09-18 Thread Tor Bug Tracker & Wiki
#27474: update tb-manual build script
--+---
 Reporter:  traumschule   |  Owner:  phoul
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Community/Tor Browser Manual  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by traumschule):

 sorry, last track of this. is there anything i can help? should the
 current system be updated or do we just transition to lektor?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24351 [Applications/Tor Browser]: Block Global Active Adversary Cloudflare

2018-09-18 Thread Tor Bug Tracker & Wiki
#24351: Block Global Active Adversary Cloudflare
-+-
 Reporter:  nullius  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  reopened
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  security, privacy, anonymity, mitm,  |  Actual Points:
  cloudflare |
Parent ID:  #18361   | Points:  1000
 Reviewer:   |Sponsor:
-+-

Comment (by cfwatch):

 cc

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25687 [Core Tor/Tor]: over-report of observed / self-measure bandwidth on fast hardware -- important to torflow / peerflow

2018-09-18 Thread Tor Bug Tracker & Wiki
#25687: over-report of observed / self-measure bandwidth  on fast hardware --
important to torflow / peerflow
--+--
 Reporter:  starlight |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: 0.2.6.10
 Severity:  Normal| Resolution:
 Keywords:  tor-bwauth|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by juga):

 * keywords:   => tor-bwauth
 * cc: juga (added)


Comment:

 This ticket is consistent with what we've observed in ``torflow``: when it
 scale the raw measurements, it uses mostly the observed bandwidth. The
 distribution of the observed bandwidth is almost exponential while the one
 of raw measurements are almost linear, what makes the final bandwidth to
 be read by the dirauths to have an almost exponential distribution too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27471 [Core Tor/Tor]: HS intermittently fails: Non-fatal assertion failed in send_introduce1

2018-09-18 Thread Tor Bug Tracker & Wiki
#27471: HS intermittently fails: Non-fatal assertion failed in send_introduce1
-+
 Reporter:  tgragnato|  Owner:  dgoulet
 Type:  defect   | Status:  accepted
 Priority:  Very High|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor: 0.3.4.7-rc
 Severity:  Minor| Resolution:
 Keywords:  tor-hs, regression?  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by dgoulet):

 * status:  new => accepted
 * cc: asn (added)
 * owner:  (none) => dgoulet


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27471 [Core Tor/Tor]: HS intermittently fails: Non-fatal assertion failed in send_introduce1

2018-09-18 Thread Tor Bug Tracker & Wiki
#27471: HS intermittently fails: Non-fatal assertion failed in send_introduce1
-+
 Reporter:  tgragnato|  Owner:  dgoulet
 Type:  defect   | Status:  accepted
 Priority:  Very High|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor: 0.3.4.7-rc
 Severity:  Minor| Resolution:
 Keywords:  tor-hs, regression?  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by dgoulet):

 I'm still unsure why this happened but it is clear that the RP/IP circuit
 were established. Once the RP ACKed the request, the authentication key in
 the IP `hs_ident` wasn't the one in the descriptor.

 So between the initial requests for that .onion and the ACK from the RP,
 the descriptor simply changed and the tor client fetched/stored it.

 That makes me think that when we store a *new* HS descriptor for A.onion
 that is we already had one in our cache and we are getting a new one, we
 should probably close every circuits related to the old one? Probably
 something like going over the IP in the old one, if they are different
 from the new one, close any related circuits.

 That way, we don't end up with leftover circuit for the *same* A.onion but
 with outdated data.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27471 [Core Tor/Tor]: HS intermittently fails: Non-fatal assertion failed in send_introduce1

2018-09-18 Thread Tor Bug Tracker & Wiki
#27471: HS intermittently fails: Non-fatal assertion failed in send_introduce1
-+
 Reporter:  tgragnato|  Owner:  dgoulet
 Type:  defect   | Status:  accepted
 Priority:  Very High|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor: 0.3.4.7-rc
 Severity:  Minor| Resolution:
 Keywords:  tor-hs, regression?  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by asn):

 Replying to [comment:4 dgoulet]:
 > I'm still unsure why this happened but it is clear that the RP/IP
 circuit were established. Once the RP ACKed the request, the
 authentication key in the IP `hs_ident` wasn't the one in the descriptor.
 >
 > So between the initial requests for that .onion and the ACK from the RP,
 the descriptor simply changed and the tor client fetched/stored it.
 >


 Hm, plausible.

 > That makes me think that when we store a *new* HS descriptor for A.onion
 that is we already had one in our cache and we are getting a new one, we
 should probably close every circuits related to the old one? Probably
 something like going over the IP in the old one, if they are different
 from the new one, close any related circuits.
 >
 > That way, we don't end up with leftover circuit for the *same* A.onion
 but with outdated data.

 Hm, how does v2 handle this situation?

 Also, the above fix seems plausible, but it engineering to be fixed.
 Another approach would be to gracefully handle this error, and let the Tor
 client handle it on its own by trying the next intro point (from the new
 desc this time)?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25687 [Core Tor/Tor]: over-report of observed / self-measure bandwidth on fast hardware -- important to torflow / peerflow

2018-09-18 Thread Tor Bug Tracker & Wiki
#25687: over-report of observed / self-measure bandwidth  on fast hardware --
important to torflow / peerflow
--+--
 Reporter:  starlight |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: 0.2.6.10
 Severity:  Normal| Resolution:
 Keywords:  tor-bwauth|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by starlight):

 The concern of this ticket is with regard to the observed value published
 by the daemon rather than the Torflow calculated vote resulting from it.
 I suspect that changes to measurement logic in the daemon have likely
 reduced or eliminated the error last definitively observed in 2.6.10.  I
 may yet write a monitor to evaluate the quality of daemon measurements.

 Torflow adjusts self-report with the ratio of the measured bandwidth for a
 relay to the average of all measured bandwidths in a manner short on
 nuance.  Wrote about possible ways to address that here:

 https://github.com/torproject/sbws/issues/182#issuecomment-410745893

 Have considered opening a Trac ticket encompassing the ideas, but am
 waiting for an opportune moment at a point where serious comparison work
 is evident.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27771 [Community]: Update PreventingDnsLeaksInTor wiki page

2018-09-18 Thread Tor Bug Tracker & Wiki
#27771: Update PreventingDnsLeaksInTor wiki page
-+--
 Reporter:  traumschule  |  Owner:  alison
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Community|Version:
 Severity:  Normal   |   Keywords:  dns leak tor
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+--
 [[doc/PreventingDnsLeaksInTor]] is from 2005. This pad is to draft a new
 version:
 https://pad.riseup.net/p/PreventingDnsLeaksInTor

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25687 [Core Tor/Tor]: over-report of observed / self-measure bandwidth on fast hardware -- important to torflow / peerflow

2018-09-18 Thread Tor Bug Tracker & Wiki
#25687: over-report of observed / self-measure bandwidth  on fast hardware --
important to torflow / peerflow
--+--
 Reporter:  starlight |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: 0.2.6.10
 Severity:  Normal| Resolution:
 Keywords:  tor-bwauth|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by juga):

 Replying to [comment:10 starlight]:
 > The concern of this ticket is with regard to the observed value
 published by the daemon rather than the Torflow calculated vote resulting
 from it.

 if by daemon you mean little-t-tor, i know

 >I suspect that changes to measurement logic in the daemon have likely
 reduced or eliminated the error last definitively observed in 2.6.10.  I
 may yet write a monitor to evaluate the quality of daemon measurements.

 if you do, would be awesome you point us to the code and results

 > Torflow adjusts self-report with the ratio

 exactly, and that ratio is a small number (0.8-8 in the samples i took),
 therefore observed / self-measured bandwidth affects a lot on what Torflow
 finally reports.

 > of the measured bandwidth for a relay to the average of all measured
 bandwidths in a manner short on nuance.  Wrote about possible ways to
 address that here:
 >
 > https://github.com/torproject/sbws/issues/182#issuecomment-410745893

 sorry, i found that comment hard to read

 FWIW, we're continuing that ticket in multiple others. Follow the links of
 https://trac.torproject.org/projects/tor/ticket/27107

 > Have considered opening a Trac ticket encompassing the ideas, but am
 waiting for an opportune moment at a point where serious comparison work
 is evident.

 on what you would like to have a serious comparison?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27623 [Applications/Tor Browser]: wrong default pref values in Tor Browser 8.0

2018-09-18 Thread Tor Bug Tracker & Wiki
#27623: wrong default pref values in Tor Browser 8.0
-+-
 Reporter:  mcs  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff60-esr, tbb-8.0-issues,|  Actual Points:
  tbb-8.0.1-can, TorBrowserTeam201809R, tbb- |
  backport   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  ff60-esr, tbb-8.0-issues, tbb-8.0.1-can, TorBrowserTeam201809R
 =>
 ff60-esr, tbb-8.0-issues, tbb-8.0.1-can, TorBrowserTeam201809R, tbb-
 backport
 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:9 mcs]:
 > Replying to [comment:8 gk]:
 > > That looks good to me. However, we do not sync the mozconfig files in
 `tor-browser` with those we actually use for building the browser part in
 `tor-browser-build` yet (see: #23656). Thus, could you add the relevant
 `tor-browser-build` changes as well?
 >
 > Sorry about that; for some reason I thought we had fixed that problem.
 We should ;)

 Indeed! Patches welcome. ;)

 > Here is a `tor-browser-build` patch:
 > https://gitweb.torproject.org/user/brade/tor-browser-
 build.git/commit/?h=bug27623-01&id=f49b8306354f68dcaf8efeec8a4bd8b5a8908e6b

 Looks good to me. I merged that one to `tor-browser-build`'s `master`
 (commit f49b8306354f68dcaf8efeec8a4bd8b5a8908e6b).

 And cherry-picked the `tor-browser` patch to `tor-browser-60.2.0esr-8.5-1`
 (commit cfcf68c7ef27d33f072a405ef7e99815f5e34c1d).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27546 [Applications/Tor Browser]: Vertical scrollbar is broken on Linux in Tor Browser 8 with Gtk3

2018-09-18 Thread Tor Bug Tracker & Wiki
#27546: Vertical scrollbar is broken on Linux in Tor Browser 8 with Gtk3
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-8.0-issues, tbb-regression,  |  Actual Points:
  TorBrowserTeam201809R, GeorgKoppen201809,  |
  tbb-backport   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:
 tbb-8.0-issues, tbb-regression, TorBrowserTeam201809R,
 GeorgKoppen201809
 =>
 tbb-8.0-issues, tbb-regression, TorBrowserTeam201809R,
 GeorgKoppen201809, tbb-backport


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27728 [Core Tor/Tor]: Signature mismatch for crypto_strongest_rand() in ed-donna code breaks -flto compilation

2018-09-18 Thread Tor Bug Tracker & Wiki
#27728: Signature mismatch for crypto_strongest_rand() in ed-donna code breaks
-flto compilation
--+
 Reporter:  Hello71   |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  accepted => needs_review


Comment:

 Okay -- I've had to install GCC 8.2 locally, and after a bit I've
 successfully reproduced this.  So I don't forget, the configuration line I
 used was:
 {{{
 ./configure CC=/opt/gcc-8.2/bin/gcc CFLAGS='-O3 -flto' LDFLAGS='-flto' \
 AR=/opt/gcc-8.2/bin/gcc-ar \
 RANLIB=/opt/gcc-8.2/bin/gcc-ranlib \
 NM=/opt/gcc-8.2/gcc-nm
 }}}

 I've added a simple fix as branch `bug27728`, with PR at
 https://github.com/torproject/tor/pull/354 .

 I'm seeing a few other GCC 8.2 warnings on the source code -- I'll try to
 check whether they're LTO only.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

  1   2   >