Re: [tor-bugs] #28390 [Obfuscation/Snowflake]: Snowflake stuck at "Loading relay information..."

2018-11-21 Thread Tor Bug Tracker & Wiki
#28390: Snowflake stuck at "Loading relay information..."
---+
 Reporter:  cypherpunks3   |  Owner:  (none)
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Obfuscation/Snowflake  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by cypherpunks3):

 I love you so much snowflake folks <3

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28462 [Metrics/Website]: tor 0.3.6 + 0.4.0 missing in "relays by version" graph

2018-11-21 Thread Tor Bug Tracker & Wiki
#28462: tor 0.3.6 + 0.4.0 missing in "relays by version" graph
-+---
 Reporter:  nusenu   |  Owner:  metrics-team
 Type:  defect   | Status:  needs_information
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---
Changes (by karsten):

 * status:  new => needs_information


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24250 [Core Tor/Tor]: In a private network some relays advertise zero bandwidth-observed

2018-11-21 Thread Tor Bug Tracker & Wiki
#24250: In a private network some relays advertise zero bandwidth-observed
-+-
 Reporter:  Sebastian|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-backport, 033-backport,  |  Actual Points:
  034-triage-20180328, 034-removed-20180328, |
  031-unreached-backport, 032-unreached- |
  backport   |
Parent ID:  #22453   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by juga):

 I guess not.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28563 [Core Tor/sbws]: Work out how sbws can report excluded relays in the bandwidth file

2018-11-21 Thread Tor Bug Tracker & Wiki
#28563: Work out how sbws can report excluded relays in the bandwidth file
---+-
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-bwauth |  Actual Points:
Parent ID:  #28547 | Points:
 Reviewer: |Sponsor:
---+-

Comment (by juga):

 I see some inconvenients to do this:
 - once we figure out why are being relays excluded, we might not want to
 keep the same format.
 - we need to wait until longclaw update to the code that publish the files
 - it'd add like around 1000 extra relays with some extra data, though this
 might not be a problem.
 - the delay that implies creating the spec before

 I was thinking either on something temporal:
 1. produce a different file, with the relays excluded and useful data*
 2. implement other script to dump the data to a DB. It sounds kind of
 crazy, but it might not be much work and from that it's easier to make
 queries
 While currently it's only me accessing to the original data, i can publish
 the results of that.

 *Currently relays excluded, can be because:
 - circuits timeout, this is already in the raw results file
 - when scaling, doesn't find 2 measurements that are at least 1 day away
 and 5 days recent
 - something else we don't know yet

 What about if i try one of the two other approaches before?. Otherwise i'm
 fine with this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28570 [Core Tor/Tor]: Various comment fixes

2018-11-21 Thread Tor Bug Tracker & Wiki
#28570: Various comment fixes
--+
 Reporter:  teor  |  Owner:  teor
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-comment   |  Actual Points:  0.1
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28570 [Core Tor/Tor]: Various comment fixes

2018-11-21 Thread Tor Bug Tracker & Wiki
#28570: Various comment fixes
--+
 Reporter:  teor  |  Owner:  teor
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  tor-comment
Actual Points:  0.1   |  Parent ID:
   Points:  0.1   |   Reviewer:
  Sponsor:|
--+
 Please review and merge:
 https://github.com/torproject/tor/pull/535

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28569 [Core Tor/Tor]: Mark outdated dirservers in reasonably live consensuses

2018-11-21 Thread Tor Bug Tracker & Wiki
#28569: Mark outdated dirservers in reasonably live consensuses
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.5-alpha
 Severity:  Normal   | Resolution:
 Keywords:  033-backport-maybe, 034-backport-|  Actual Points:  0.2
  maybe, 035-backport|
Parent ID:  #23605   | Points:  0.2
 Reviewer:   |Sponsor:
 |  Sponsor8-can
-+-

Comment (by teor):

 This change is required for the unit tests in #24661 to pass, so I'll
 include the commit in that branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28569 [Core Tor/Tor]: Mark outdated dirservers in reasonably live consensuses

2018-11-21 Thread Tor Bug Tracker & Wiki
#28569: Mark outdated dirservers in reasonably live consensuses
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.5-alpha
 Severity:  Normal   | Resolution:
 Keywords:  033-backport-maybe, 034-backport-|  Actual Points:  0.2
  maybe, 035-backport|
Parent ID:  #24661   | Points:  0.2
 Reviewer:   |Sponsor:
 |  Sponsor8-can
-+-
Changes (by teor):

 * parent:  #23605 => #24661


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28554 [Core Tor/Tor]: Fix memory leaks and missing unmocks in test_entry_guard_outdated_dirserver_exclusion

2018-11-21 Thread Tor Bug Tracker & Wiki
#28554: Fix memory leaks and missing unmocks in
test_entry_guard_outdated_dirserver_exclusion
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  bootstrap, clock-skew,   |  Actual Points:  0.1
  s8-bootstrap, 033-backport-maybe, 034  |
  -backport-maybe, 035-backport  |
Parent ID:  #24661   | Points:  0.1
 Reviewer:   |Sponsor:
 |  Sponsor8-can
-+-

Comment (by teor):

 This branch is based on maint-0.3.3.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28554 [Core Tor/Tor]: Fix memory leaks and missing unmocks in test_entry_guard_outdated_dirserver_exclusion

2018-11-21 Thread Tor Bug Tracker & Wiki
#28554: Fix memory leaks and missing unmocks in
test_entry_guard_outdated_dirserver_exclusion
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  bootstrap, clock-skew,   |  Actual Points:  0.1
  s8-bootstrap, 033-backport-maybe, 034  |
  -backport-maybe, 035-backport  |
Parent ID:  #24661   | Points:  0.1
 Reviewer:   |Sponsor:
 |  Sponsor8-can
-+-
Changes (by teor):

 * status:  assigned => needs_review
 * points:   => 0.1
 * sponsor:   => Sponsor8-can
 * actualpoints:   => 0.1


Comment:

 This ticket is sponsor8-can, because it fixes some unit tests we need for
 #24661.

 See my pull request:
 https://github.com/torproject/tor/pull/534

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28390 [Obfuscation/Snowflake]: Snowflake stuck at "Loading relay information..."

2018-11-21 Thread Tor Bug Tracker & Wiki
#28390: Snowflake stuck at "Loading relay information..."
---+
 Reporter:  cypherpunks3   |  Owner:  (none)
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Obfuscation/Snowflake  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by dcf):

 Oh, and an additional problem I didn't notice and fix until 2018-11-22
 04:00:00. Because of #18356 and https://bugs.debian.org/865495, I have to
 remember to do these steps whenever systemd is upgraded (which I did while
 making space on the filesystem):
 {{{
 setcap 'cap_net_bind_service=+ep' /usr/local/bin/snowflake-server
 Set NoNewPrivileges=no in /lib/systemd/system/tor@*.service
 systemctl daemon-reload
 }}}
 Without these changes, the websocket PT plugin fails with `error opening
 HTTP-01 ACME listener: listen tcp 0.0.0.0:80: bind: permission denied`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28569 [Core Tor/Tor]: Mark outdated dirservers in reasonably live consensuses

2018-11-21 Thread Tor Bug Tracker & Wiki
#28569: Mark outdated dirservers in reasonably live consensuses
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.4.0.x-final
Component:  Core |Version:  Tor: 0.3.2.5-alpha
  Tor/Tor|   Keywords:  033-backport-maybe, 034-backport-
 Severity:  Normal   |  maybe, 035-backport
Actual Points:  0.2  |  Parent ID:  #23605
   Points:  0.2  |   Reviewer:
  Sponsor:   |
  Sponsor8-can   |
-+-
 If we have a reasonably live consensus, then most of our dirservers should
 still be caching all the microdescriptors in it.

 Reasonably live consensuses are up to a day old. But microdescriptors
 expire 7 days after the last consensus that referenced them.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28562 [Core Tor/Tor]: test: test_rebind.py doesn't use a temporary a DataDirectory

2018-11-21 Thread Tor Bug Tracker & Wiki
#28562: test: test_rebind.py doesn't use a temporary a DataDirectory
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-test  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  new => needs_review


Comment:

 Thanks, someone should review this patch in the next week or so.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28568 [Core Tor/Tor]: Stop running stem's unit tests in Tor's stem test

2018-11-21 Thread Tor Bug Tracker & Wiki
#28568: Stop running stem's unit tests in Tor's stem test
--+
 Reporter:  teor  |  Owner:  teor
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.5.1-alpha
 Severity:  Normal|   Keywords:  035-backport, fast-fix
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 As noted by atagar in:
 https://trac.torproject.org/projects/tor/ticket/28552#comment:4

 We can use --integ rather than --all.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28552 [Core Tor/Stem]: Should stem integ tests fail on controller errors?

2018-11-21 Thread Tor Bug Tracker & Wiki
#28552: Should stem integ tests fail on controller errors?
---+---
 Reporter:  teor   |  Owner:  atagar
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:  not a bug
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by teor):

 * status:  new => closed
 * resolution:   => not a bug


Comment:

 Thanks, I opened #28568 to follow this up.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28205 [Obfuscation/Snowflake]: linking against other libwebrtc binaries errors out on missing symbols

2018-11-21 Thread Tor Bug Tracker & Wiki
#28205: linking against other libwebrtc binaries errors out on missing symbols
---+--
 Reporter:  eighthave  |  Owner:  eighthave
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Obfuscation/Snowflake  |Version:
 Severity:  Major  | Resolution:
 Keywords:  android|  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by dcf):

 Replying to [comment:48 arlolra]:
 > Replying to [comment:46 eighthave]:
 > > Ok, I figured out the `go get` issue, it seems sometimes that `go get`
 decides that it needs to have `.git` at the end of the path, and other
 times not.  So I used symlinks to provide both options.  Then I only built
 `.../client/lib`, not the whole client.
 >
 > These are the same issues as before with unsupported export types.  What
 needs to be done is a `client/mobile/` that imports from `client/lib/` but
 only exposes a few methods that your app would need.

 Right--you want to build `client`, not `client/lib`. The point of making a
 separate `client/lib` package was not to expose an external interface;
 rather it was to ''hide'' some of client's internal interfaces,
 specifically the ones that gomobile doesn't like.

 Replying to [comment:49 eighthave]:
 > It is not possible to build the shared library, because of `package
 main`:
 > {{{
 > $ gomobile bind -v -x -target=android/arm
 github.com/keroserene/snowflake/client
 > gomobile: binding 'main' package () is not supported
 > }}}

 Please do what you were already planning to do and do for other
 transports; i.e., rename the `main` package to something else. We can also
 talk about adding a new, gomobile-specific package to the source tree to
 make it easier for you, but first I'd like to ensure that it works using
 the procedure you have used for other transports.

 > Looks like building the Android app is working, except for:
 > {{{
 > gomobile: github.com/keroserene/snowflake/client does not import
 "golang.org/x/mobile/app"
 > }}}
 > I'll try implementing golang.org/x/mobile/app tomorrow, unless someone
 else wants to try it.

 Yes, please try it; and if it works that's something we can consider
 adopting into the source tree.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28142 [Core Tor/Tor]: Merge original WTF-PAD branch

2018-11-21 Thread Tor Bug Tracker & Wiki
#28142: Merge original WTF-PAD branch
-+-
 Reporter:  asn  |  Owner:
 |  mikeperry
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:
  padding|
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-

Comment (by riastradh):

 FYI: a part of this work, namely the uniform ^^[0,1^^] sampler used
 throughout, is echoed in #23061.  Just letting you know in case you want
 to avoid the duplication sooner rather than later.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24805 [Core Tor/Fallback Scripts]: Update fallback whitelist in late 2018

2018-11-21 Thread Tor Bug Tracker & Wiki
#24805: Update fallback whitelist in late 2018
-+-
 Reporter:  teor |  Owner:  phoul
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Fallback Scripts|Version:
 Severity:  Normal   | Resolution:
 Keywords:  fallback, 034-triage-20180328,   |  Actual Points:
  034-removed-20180328, 035-removed-20180711,|
  035-roadmap|
Parent ID:  #24786   | Points:  0.5
 Reviewer:   |Sponsor:
-+-

Comment (by phoul):

 Added 1 relay at
 https://github.com/Phoul/tor/commit/6d2c2be291e682bff985a357f3703adf1cd03774

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28390 [Obfuscation/Snowflake]: Snowflake stuck at "Loading relay information..."

2018-11-21 Thread Tor Bug Tracker & Wiki
#28390: Snowflake stuck at "Loading relay information..."
---+
 Reporter:  cypherpunks3   |  Owner:  (none)
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Obfuscation/Snowflake  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by dcf):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 The problem was a full disk, just like in #26661. The bridge and the
 fallback proxies are currently hosted on the same machine, so when the
 proxies filled up the disk with logs, it stopped the bridge running as
 well. The end of one of the log files was (timestamps are UTC)
 {{{
 2018/11/16 15:10:27 broker returns: 504
 2018/11/16 15:10:38 broker returns: 504
 2018/11/16 15:10:48 broker returns: 504
 2018/11/16 15:10:58 broker returns: 504
 2018/11/16 15:11:08 broker returns: 504
 2018/11/16 15:11:18 broker returns: 504
 2018/11/16 15:11:28 broker returns: 504
 2018/11/16 15:11
 }}}

 I compressed the logs to make some space (they compress to around 1% of
 their original size, as they mostly contain those `broker returns: 504`
 lines). Then I did what I should have done after #26661, which is activate
 log rotation to prevent this from happening again. We're using runit to
 manage the proxies, which comes with a program
 [http://smarden.org/runit/svlogd.8.html svlogd] to manage log files. I
 added a `log/run` script to each service directory containing:
 {{{
 #!/bin/sh
 exec chpst -u snowflake-proxy svlogd snowflake-proxy-xxx.log.d
 }}}
 In each service `run` script, I removed the `-log` option from the
 snowflake-proxy command, so that it will log to stderr. Then, in each
 snowflake-proxy-xxx.log.d directory, I made a file `config` that contains:
 {{{
 # http://smarden.org/runit/svlogd.8.html
 # size of log file before rotation (10 MB)
 s1000
 # don't delete old logs
 n0
 # unless the filesystem is full
 N1
 # compress old logs
 !xz
 }}}
 What this means is, when a log file reaches 10 MB, it will be compressed
 and archived. Keep archived log files, but delete the oldest ones if the
 disk is full.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28519 [Core Tor/sbws]: Prioritize relays with no measured bandwidth in the consensus

2018-11-21 Thread Tor Bug Tracker & Wiki
#28519: Prioritize relays with no measured bandwidth in the consensus
---+--
 Reporter:  juga   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws 1.1
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by teor):

 * parent:  #25925 =>


Comment:

 Replying to [comment:3 arma]:
 > It seems like the simple rule of "prioritize relays if we don't have
 enough recent measurements of them" should produce the behavior we want,
 right?

 I think you're right: if we re-measure relays with few measurements, we'll
 eventually have enough measurements for those relays.

 In some cases, we'll measure a relay, then exclude its measurement. But in
 order to find these cases, we need to do the analysis in #28547.

 Once we know *why* relays aren't making it into the bandwidth file, we'll
 know if we need to fix the priority queue (or the exclusion code).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28519 [Core Tor/sbws]: Prioritize relays with no measured bandwidth in the consensus

2018-11-21 Thread Tor Bug Tracker & Wiki
#28519: Prioritize relays with no measured bandwidth in the consensus
---+--
 Reporter:  juga   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws 1.1
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #25925 | Points:
 Reviewer: |Sponsor:
---+--
Changes (by teor):

 * parent:  #22453 => #25925


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28547 [Core Tor/sbws]: Monitor relays that are not measured by each sbws instance

2018-11-21 Thread Tor Bug Tracker & Wiki
#28547: Monitor relays that are not measured by each sbws instance
---+-
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-bwauth |  Actual Points:
Parent ID:  #25925 | Points:
 Reviewer: |Sponsor:
---+-
Changes (by teor):

 * parent:  #22453 => #25925


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16559 [Core Tor/sbws]: bwauth code needs to be smarter about failed circuits

2018-11-21 Thread Tor Bug Tracker & Wiki
#16559: bwauth code needs to be smarter about failed circuits
--+--
 Reporter:  TvdW  |  Owner:  juga
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  sbws 1.1
Component:  Core Tor/sbws |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bwauth, sbws  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by teor):

 * parent:  #25925 =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22453 [Core Tor/Tor]: Relays should regularly do a larger bandwidth self-test

2018-11-21 Thread Tor Bug Tracker & Wiki
#22453: Relays should regularly do a larger bandwidth self-test
-+-
 Reporter:  arma |  Owner:  juga
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-triage-20180328, |  Actual Points:
  034-removed-20180328, tor-bwauth,  |
  035-backport, 034-backport-maybe, 033  |
  -backport-maybe, 029-backport-maybe-not|
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * parent:  #25925 =>
 * milestone:  Tor: 0.4.0.x-final => Tor: unspecified


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28142 [Core Tor/Tor]: Merge original WTF-PAD branch

2018-11-21 Thread Tor Bug Tracker & Wiki
#28142: Merge original WTF-PAD branch
-+-
 Reporter:  asn  |  Owner:
 |  mikeperry
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:
  padding|
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-

Comment (by riastradh):

 I attached a patch to address all the -Wfloat-equal and -Wfloat-conversion
 warnings.

 I didn't address -Wbad-function-casts; if you really want to appease the
 warning at the expense of code clarity, you can just take each case of

 {{{
 integer-type y = (integer-type)floor(f(x));
 }}}

 by the clumsier

 {{{
 double yd = floor(f(x));
 integer-type y = (integer-type)yd;
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26905 [Core Tor/Tor]: Work out if we need to round observed relay bandwidths to protect individual client usage

2018-11-21 Thread Tor Bug Tracker & Wiki
#26905: Work out if we need to round observed relay bandwidths to protect
individual client usage
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:  Tor:
  |  unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * parent:  #25925 =>


Comment:

 This isn't really a bandwidth authority task

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7177 [Core Tor/sbws]: Understand how accurate the bandwidth authority estimates are

2018-11-21 Thread Tor Bug Tracker & Wiki
#7177: Understand how accurate the bandwidth authority estimates are
---+
 Reporter:  karsten|  Owner:  (none)
 Type:  project| Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #25925 | Points:
 Reviewer: |Sponsor:
---+
Changes (by teor):

 * component:  Core Tor/Torflow => Core Tor/sbws


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19009 [Core Tor/Tor]: bandwidth testing circuits should be allowed to use our guards

2018-11-21 Thread Tor Bug Tracker & Wiki
#19009: bandwidth testing circuits should be allowed to use our guards
-+-
 Reporter:  arma |  Owner:  juga
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-bandwidth torflow measurement|  Actual Points:
  metrics, tor-bwauth|
Parent ID:  #22453   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * parent:  #25925 => #22453


Comment:

 We might remove the bandwidth self-test entirely.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16559 [Core Tor/sbws]: bwauth code needs to be smarter about failed circuits

2018-11-21 Thread Tor Bug Tracker & Wiki
#16559: bwauth code needs to be smarter about failed circuits
--+--
 Reporter:  TvdW  |  Owner:  juga
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  sbws 1.1
Component:  Core Tor/sbws |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bwauth, sbws  |  Actual Points:
Parent ID:  #25925| Points:
 Reviewer:|Sponsor:
--+--
Changes (by teor):

 * component:  Core Tor/Torflow => Core Tor/sbws
 * milestone:   => sbws 1.1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7281 [Core Tor/Torflow]: Bandwidth auths should publish average and weighted onionskin failure rates

2018-11-21 Thread Tor Bug Tracker & Wiki
#7281: Bandwidth auths should publish average and weighted onionskin failure 
rates
--+
 Reporter:  mikeperry |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Low   |  Milestone:
Component:  Core Tor/Torflow  |Version:
 Severity:  Normal| Resolution:
 Keywords:  privcount |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * keywords:   => privcount
 * parent:  #25925 =>


Comment:

 This is a relay statistics task, not a bandwidth authority task

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16386 [Core Tor/Chutney]: Chutney generates network with no bandwidth weights

2018-11-21 Thread Tor Bug Tracker & Wiki
#16386: Chutney generates network with no bandwidth weights
--+---
 Reporter:  asn   |  Owner:  (none)
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Core Tor/Chutney  |Version:
 Severity:  Normal| Resolution:
 Keywords:  SponsorS  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by teor):

 * parent:  #25925 =>


Comment:

 This is not really a bandwidth authority task

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28224 [Core Tor/DirAuth]: Monitor dirauth running sbws in production

2018-11-21 Thread Tor Bug Tracker & Wiki
#28224: Monitor dirauth running sbws in production
--+--
 Reporter:  juga  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  sbws 1.1
Component:  Core Tor/DirAuth  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #27107| Points:
 Reviewer:|Sponsor:
--+--

Comment (by teor):

 Replying to [comment:11 starlight]:
 > shouldn't it correctly decide when to start publishing automatically?

 The latest version of sbws only publishes a bandwidth file with relays
 when it has measured 60% of the network.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28142 [Core Tor/Tor]: Merge original WTF-PAD branch

2018-11-21 Thread Tor Bug Tracker & Wiki
#28142: Merge original WTF-PAD branch
-+-
 Reporter:  asn  |  Owner:
 |  mikeperry
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:
  padding|
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-
Changes (by riastradh):

 * Attachment "float-warn.patch" added.

 patch to commit a9f511ddd5bf5e57c159a21b3bbe0203412bc04a on asn-d6
 /adaptive_padding-prob-distr-tests to work around -Wfloat-equal, -Wfloat-
 conversion

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28471 [Core Tor/sbws]: Refactor sbws exit checking so it is consistent

2018-11-21 Thread Tor Bug Tracker & Wiki
#28471: Refactor sbws exit checking so it is consistent
---+-
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:  sbws: 1.0.0
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #28458 | Points:
 Reviewer: |Sponsor:
---+-
Changes (by teor):

 * milestone:   => sbws 1.0 (MVP must)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28463 [Core Tor/sbws]: Measure exits as non-exits with 50% probability

2018-11-21 Thread Tor Bug Tracker & Wiki
#28463: Measure exits as non-exits with 50% probability
---+-
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor/sbws  |Version:  sbws: 1.0.0
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #28458 | Points:
 Reviewer: |Sponsor:
---+-

Comment (by teor):

 Do we want to do this fix in sbws 1.0?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28461 [Core Tor/sbws]: Encourage sbws operators to install a local caching resolver

2018-11-21 Thread Tor Bug Tracker & Wiki
#28461: Encourage sbws operators to install a local caching resolver
---+-
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:  sbws: 1.0.0
 Severity:  Normal | Resolution:  wontfix
 Keywords:  doc|  Actual Points:
Parent ID:  #28458 | Points:
 Reviewer: |Sponsor:
---+-
Changes (by teor):

 * status:  new => closed
 * resolution:   => wontfix
 * milestone:   => sbws 1.0 (MVP must)


Comment:

 I don't think we will do this ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28458 [Core Tor/sbws]: Stop resolving domains locally and check same flags for the 2nd hop

2018-11-21 Thread Tor Bug Tracker & Wiki
#28458: Stop resolving domains locally and check same flags for the 2nd hop
---+-
 Reporter:  juga   |  Owner:  juga
 Type:  defect | Status:  needs_revision
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:  sbws: 1.0.0
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer:  teor   |Sponsor:
---+-
Changes (by teor):

 * milestone:   => sbws 1.0 (MVP must)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28099 [Core Tor/sbws]: Make a policy for adding new sbws relay keys

2018-11-21 Thread Tor Bug Tracker & Wiki
#28099: Make a policy for adding new sbws relay keys
---+-
 Reporter:  teor   |  Owner:  (none)
 Type:  task   | Status:  closed
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP nice)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by teor):

 * milestone:   => sbws 1.0 (MVP nice)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28537 [Core Tor/sbws]: Stop having to edit changelog on every bug/feature

2018-11-21 Thread Tor Bug Tracker & Wiki
#28537: Stop having to edit changelog on every bug/feature
---+-
 Reporter:  juga   |  Owner:  juga
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by teor):

 * milestone:   => sbws 1.0 (MVP must)


Comment:

 I think you'll want this in the next release.

 Also, if you're trying to reconstruct changelogs from tickets and commit
 messages, you'll need good commit messages that reference the ticket
 number.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28562 [Core Tor/Tor]: test: test_rebind.py doesn't use a temporary a DataDirectory

2018-11-21 Thread Tor Bug Tracker & Wiki
#28562: test: test_rebind.py doesn't use a temporary a DataDirectory
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-test  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by riastradh):

 * Attachment "test_rebind.patch" added.

 patch

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28562 [Core Tor/Tor]: test: test_rebind.py doesn't use a temporary a DataDirectory

2018-11-21 Thread Tor Bug Tracker & Wiki
#28562: test: test_rebind.py doesn't use a temporary a DataDirectory
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-test  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by riastradh):

 This is the only test that failed when I ran `make check` with a
 nonwritable $HOME.  With the attached patch, the tests pass.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28099 [Core Tor/sbws]: Make a policy for adding new sbws relay keys

2018-11-21 Thread Tor Bug Tracker & Wiki
#28099: Make a policy for adding new sbws relay keys
---+
 Reporter:  teor   |  Owner:  (none)
 Type:  task   | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by teor):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 I don't think there's anything left to do in this ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27689 [Core Tor/sbws]: Round bandwidth in bandwidth files based on proposal 276

2018-11-21 Thread Tor Bug Tracker & Wiki
#27689: Round bandwidth in bandwidth files based on proposal 276
---+--
 Reporter:  juga   |  Owner:  (none)
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:  sbws 1.1
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop276|  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by teor):

 * milestone:   => sbws 1.1


Comment:

 Finishing off this ticket can wait

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28452 [Core Tor/sbws]: 3. implement rounding gap smoothing as in proposal 276

2018-11-21 Thread Tor Bug Tracker & Wiki
#28452: 3. implement rounding gap smoothing as in proposal 276
---+
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:  needs_revision
 Priority:  Medium |  Milestone:  sbws 1.1
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop276|  Actual Points:
Parent ID:  #27689 | Points:
 Reviewer: |Sponsor:
---+
Changes (by teor):

 * milestone:  sbws 1.0 (MVP nice) => sbws 1.1


Comment:

 This ticket can wait.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28045 [Core Tor/sbws]: Start supporting python 3.7

2018-11-21 Thread Tor Bug Tracker & Wiki
#28045: Start supporting python 3.7
---+--
 Reporter:  juga   |  Owner:  juga
 Type:  defect | Status:  accepted
 Priority:  Medium |  Milestone:  sbws 1.1
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by teor):

 * milestone:   => sbws 1.1


Comment:

 We've deferred this ticket, it can go in sbws 1.1.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27996 [Core Tor/sbws]: Apparent race condition when recalculating relay priority

2018-11-21 Thread Tor Bug Tracker & Wiki
#27996: Apparent race condition when recalculating relay priority
---+-
 Reporter:  pastly |  Owner:  (none)
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by teor):

 * status:  new => closed
 * resolution:   => fixed
 * milestone:   => sbws 1.0 (MVP must)


Comment:

 We think this was fixed in another ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28106 [Core Tor/sbws]: Change integration tests from bash to shell

2018-11-21 Thread Tor Bug Tracker & Wiki
#28106: Change integration tests from bash to shell
---+--
 Reporter:  juga   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws 1.1
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by teor):

 * milestone:   => sbws 1.1


Comment:

 This refactor can probably wait for sbws 1.1.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28087 [Core Tor/sbws]: Investigate circuit timeout times and if sbws is properly cleaning up circuits when it gives up on them

2018-11-21 Thread Tor Bug Tracker & Wiki
#28087: Investigate circuit timeout times and if sbws is properly cleaning up
circuits when it gives up on them
---+--
 Reporter:  pastly |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws 1.1
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by teor):

 * milestone:   => sbws 1.1


Comment:

 Tor will clean up circuits after 10 minutes, so this can probably wait
 until sbws 1.1.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #27343, #27361, #27362, #28282

2018-11-21 Thread Tor Bug Tracker & Wiki
Batch modification to #27343, #27361, #27362, #28282 by teor:
milestone to sbws 1.1

Comment:
These changes can probably wait until sbws 1.1

--
Tickets URL: 

Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28566 [Core Tor/sbws]: Report relays that sbws sees in the consensus, but never chooses to test

2018-11-21 Thread Tor Bug Tracker & Wiki
#28566: Report relays that sbws sees in the consensus, but never chooses to test
---+-
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-bwauth |  Actual Points:
Parent ID:  #28547 | Points:
 Reviewer: |Sponsor:
---+-
Description changed by teor:

Old description:

> We should count:
> * the number of consensuses that sbws has seen a relay in
> * the number of times sbws chooses to test a relay
> * the number of times sbws chooses to exclude a relay (for example,
> because it's an authority)

New description:

 We should count:
 * the number of consensuses that sbws has seen a relay in the consensus
 * the number of times sbws chooses to test a relay
 * the number of times sbws chooses to exclude a relay (for example,
 because it's an authority)

 If there are a large number of exclusions, we should split the exclusions
 into subcategories.

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28552 [Core Tor/Stem]: Should stem integ tests fail on controller errors?

2018-11-21 Thread Tor Bug Tracker & Wiki
#28552: Should stem integ tests fail on controller errors?
---+
 Reporter:  teor   |  Owner:  atagar
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by atagar):

 The test I pointed to is exercising Stems code path for 'tor sends us
 invalid content'. Unit tests don't even have a tor instance running, so
 100% of things it cites concerns just stem - not tor.

 Actually, for tor's purposes it might be worthwhile to swap your '--all'
 argument to '--integ'.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28567 [Core Tor/sbws]: Report relays that sbws wants to test, but the test doesn't work

2018-11-21 Thread Tor Bug Tracker & Wiki
#28567: Report relays that sbws wants to test, but the test doesn't work
---+-
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal |   Keywords:  tor-bwauth
Actual Points: |  Parent ID:  #28547
   Points: |   Reviewer:
  Sponsor: |
---+-
 We should count:
 * the number of times sbws tries to test a relay
 * the number of times the test works and fails

 If there is a high number of failures, we should also count:
 * the number of times that pair selection works and fails
 * the number of times that connecting works and fails
   * if there are a lot of these, count the hop that fails
 * the number of times that data transfer works and fails

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28566 [Core Tor/sbws]: Report relays that sbws sees in the consensus, but never chooses to test

2018-11-21 Thread Tor Bug Tracker & Wiki
#28566: Report relays that sbws sees in the consensus, but never chooses to test
---+-
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-bwauth |  Actual Points:
Parent ID:  #28547 | Points:
 Reviewer: |Sponsor:
---+-
Description changed by teor:

Old description:



New description:

 We should count:
 * the number of consensuses that sbws has seen a relay in
 * the number of times sbws chooses to test a relay
 * the number of times sbws chooses to exclude a relay (for example,
 because it's an authority)

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28566 [Core Tor/sbws]: Report relays that sbws sees in the consensus, but never chooses to test

2018-11-21 Thread Tor Bug Tracker & Wiki
#28566: Report relays that sbws sees in the consensus, but never chooses to test
---+-
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal |   Keywords:  tor-bwauth
Actual Points: |  Parent ID:  #28547
   Points: |   Reviewer:
  Sponsor: |
---+-


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28565 [Core Tor/sbws]: Report excluded results in a relay's bandwidth line

2018-11-21 Thread Tor Bug Tracker & Wiki
#28565: Report excluded results in a relay's bandwidth line
---+-
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal |   Keywords:  tor-bwauth
Actual Points: |  Parent ID:  #28547
   Points: |   Reviewer:
  Sponsor: |
---+-
 When sbws excludes some results for a relay, we should:
 * count how many results were excluded and how many were used
 * report the excluded and used result counts in the relay's bandwidth line

 If the number of excluded results is high, we should split it into
 subcategories.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28564 [Core Tor/sbws]: When a relay is excluded, add an exclusion reason to the relay's bandwidth file line

2018-11-21 Thread Tor Bug Tracker & Wiki
#28564: When a relay is excluded, add an exclusion reason to the relay's 
bandwidth
file line
---+-
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal |   Keywords:  tor-bwauth
Actual Points: |  Parent ID:  #28547
   Points: |   Reviewer:
  Sponsor: |
---+-


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28563 [Core Tor/sbws]: Work out how sbws can report excluded relays in the bandwidth file

2018-11-21 Thread Tor Bug Tracker & Wiki
#28563: Work out how sbws can report excluded relays in the bandwidth file
---+-
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal |   Keywords:  tor-bwauth
Actual Points: |  Parent ID:  #28547
   Points: |   Reviewer:
  Sponsor: |
---+-
 If we report excluded relays in the bandwidth file, then they will be
 publicly archived and available for anyone to analyse.

 We just need to work out a syntax that makes tor ignore excluded relays.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27340 [Core Tor/sbws]: Work out how to scale sbws to match torflow, when the distributions match

2018-11-21 Thread Tor Bug Tracker & Wiki
#27340: Work out how to scale sbws to match torflow, when the distributions 
match
---+-
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID:  #27339 | Points:
 Reviewer: |Sponsor:
---+-
Changes (by teor):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 I think this ticket is done.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28545 [Core Tor/sbws]: Use an 11 second download in sbws

2018-11-21 Thread Tor Bug Tracker & Wiki
#28545: Use an 11 second download in sbws
---+-
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws 1.1
Component:  Core Tor/sbws  |Version:  sbws: 1.0.0
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #22453 | Points:
 Reviewer: |Sponsor:
---+-
Changes (by teor):

 * milestone:  sbws 1.0 (MVP must) => sbws 1.1


Comment:

 I don't think we need this ticket in sbws 1.0.

 After we deploy sbws, we'll know how important it is.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28447 [Core Tor/sbws]: improve new SBWS rounding to exhibit uniform percent deltas

2018-11-21 Thread Tor Bug Tracker & Wiki
#28447: improve new SBWS rounding to exhibit uniform percent deltas
---+-
 Reporter:  starlight  |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws 1.1
Component:  Core Tor/sbws  |Version:  sbws: 1.0.0
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by teor):

 * milestone:   => sbws 1.1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28355 [Core Tor/sbws]: Disable measurement timing rules on sbws by default

2018-11-21 Thread Tor Bug Tracker & Wiki
#28355: Disable measurement timing rules on sbws by default
---+-
 Reporter:  juga   |  Owner:  juga
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws 1.1
Component:  Core Tor/sbws  |Version:  sbws: 1.0.0
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by teor):

 * milestone:  sbws 1.0 (MVP must) => sbws 1.1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27365 [Core Tor/sbws]: Implement sbws features in the tor authority code

2018-11-21 Thread Tor Bug Tracker & Wiki
#27365: Implement sbws features in the tor authority code
---+--
 Reporter:  teor   |  Owner:  (none)
 Type:  task   | Status:  new
 Priority:  Medium |  Milestone:  sbws 1.1
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by teor):

 On the other hand, maybe adding more code to Tor isn't a good idea?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28158 [Core Tor/sbws]: Consider writing bw lines even if the min percentage has not been reached

2018-11-21 Thread Tor Bug Tracker & Wiki
#28158: Consider writing bw lines even if the min percentage has not been 
reached
---+--
 Reporter:  juga   |  Owner:  (none)
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:  sbws 1.1
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by teor):

 * type:  defect => enhancement
 * milestone:   => sbws 1.1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28562 [Core Tor/Tor]: test: test_rebind.py doesn't use a temporary a DataDirectory

2018-11-21 Thread Tor Bug Tracker & Wiki
#28562: test: test_rebind.py doesn't use a temporary a DataDirectory
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-test  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by teor):

 Let's make sure that all our tests are using a temporary data directory

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27167 [Core Tor/Tor]: track "first" OR_CONN

2018-11-21 Thread Tor Bug Tracker & Wiki
#27167: track "first" OR_CONN
-+-
 Reporter:  catalyst |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  usability, ux, ux-team, bootstrap,   |  Actual Points:
  035-roadmap-subtask, 035-triaged-in-20180711,  |
  s8-bootstrap, 035-deferred-20180930,   |
  s8-errors  |
Parent ID:  #27103   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-

Comment (by catalyst):

 WIP branch at https://github.com/tlyu/tor/tree/orconn-tracker which also
 contains a patch for #27402.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28551 [Core Tor/Tor]: Tor's Travis should print the python version after installation

2018-11-21 Thread Tor Bug Tracker & Wiki
#28551: Tor's Travis should print the python version after installation
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:  tor-ci, travis, fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by teor):

 Ok, but tor uses python for other tests, not just stem's tests.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28552 [Core Tor/Stem]: Should stem integ tests fail on controller errors?

2018-11-21 Thread Tor Bug Tracker & Wiki
#28552: Should stem integ tests fail on controller errors?
---+
 Reporter:  teor   |  Owner:  atagar
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by teor):

 I am still confused by these issues, which look like bugs:

 Replying to [ticket:28552 teor]:
 > Is tor really outputting `BW &15* 25`, because the relevant code is `650
 BW %lu %lu\r\n`?
 > Why are the times in 1970?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28398 [Core Tor/Stem]: Please provide a method on descriptors for calculating digests

2018-11-21 Thread Tor Bug Tracker & Wiki
#28398: Please provide a method on descriptors for calculating digests
---+
 Reporter:  irl|  Owner:  atagar
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by atagar):

 Thanks irl! Fixed:
 https://gitweb.torproject.org/stem.git/commit/?id=32a3d26

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22453 [Core Tor/Tor]: Relays should regularly do a larger bandwidth self-test

2018-11-21 Thread Tor Bug Tracker & Wiki
#22453: Relays should regularly do a larger bandwidth self-test
-+-
 Reporter:  arma |  Owner:  juga
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-triage-20180328, |  Actual Points:
  034-removed-20180328, tor-bwauth,  |
  035-backport, 034-backport-maybe, 033  |
  -backport-maybe, 029-backport-maybe-not|
Parent ID:  #25925   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:40 arma]:
 > Replying to [comment:33 teor]:
 > > More realistically, the top 10% of relays are at 125 megabits per
 second:
 > > https://metrics.torproject.org/advbwdist-
 relay.html?start=2018-08-21=2018-11-19=500
 > >
 > > Therefore, it would take log,,2,,(125 / 20)*5 = 13 days for sbws to
 get an accurate bandwidth for most (90%) of relays, if there was no client
 traffic.
 > >
 > > Do you think that's ok?
 >
 > This is a fun analysis!

 I think it's slightly wrong, because sbws' target download time is 5-10
 seconds, not 11 seconds. (We'd need 11 seconds to make sure we covered
 tor's 10 seconds, when the seconds don't line up.)

 But still, we could live with 1x - 2x growth.
 The important thing is that relays won't go backwards (like they sometimes
 do with Torflow).

 > First, I'll start with a "yes we could live with that."
 >
 > But second, if we have six sbws's going, and there's a lot of variance
 with each test (sometimes it's faster than expected, sometimes slower), I
 think the time until one of the tests happens to hit some great
 throughput, on a relay that's way faster than its self-advertised number,
 would end up quite a bit less than this analysis predicts. That is, I
 think it would be quite common to more-than-double, not just double, at
 each iteration.

 It is possible that we would get more than 2x.

 > And third, what's the "every five days" parameter?

 Results are valid for 5 days, and we take the median.

 > Should we teach sbws that when its recent measurements have showed the
 relay to be way faster than its consensus weight, that means we "don't
 have enough good recent measurements" and we need to get more (and better)
 measurements? It seems like there's a lot of space for sbws to be smarter
 about doing tests for relays that appear to be on an upward trajectory.
 (But this said, I would still want to try to keep the priority function as
 simple as possible, to avoid making it hard to analyze what's going wrong:
 #28519)

 I think we could open a ticket to try to make fast relays grow faster. But
 there's a tradeoff: fast growth means less network stability and more
 chance of a sybil.

 Let's do this kind of optimisation in sbws 1.1.

 > Ultimately, in a design where we base our changes proportional to the
 self-advertised bandwidth, we are limited by the feedback cycle between
 "we induce load on relay" and "relay publishes descriptor with higher
 number". We intentionally slowed down that feedback cycle in the #23856
 fix, so I don't see a way around accepting that -- even best case -- it
 will take some days to get to the proper number.

 And that's ok. Again, there's a growth/stability/security tradeoff.

 We won't know if the growth is acceptable until we deploy. So let's stay
 with what we've got for now?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24250 [Core Tor/Tor]: In a private network some relays advertise zero bandwidth-observed

2018-11-21 Thread Tor Bug Tracker & Wiki
#24250: In a private network some relays advertise zero bandwidth-observed
-+-
 Reporter:  Sebastian|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-backport, 033-backport,  |  Actual Points:
  034-triage-20180328, 034-removed-20180328, |
  031-unreached-backport, 032-unreached- |
  backport   |
Parent ID:  #22453   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:20 juga]:
 > I am.
 > However, just changing this function
 https://gitweb.torproject.org/tor.git/tree/src/or/rephist.c?h=maint-0.2.9#n1431
 to log when it would be 0 and return 1, it's an easy change. Maybe i
 create a child ticket for that?.

 Do we need to make this change to Tor before we deploy sbws?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28398 [Core Tor/Stem]: Please provide a method on descriptors for calculating digests

2018-11-21 Thread Tor Bug Tracker & Wiki
#28398: Please provide a method on descriptors for calculating digests
---+
 Reporter:  irl|  Owner:  atagar
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by irl):

 It seems that this has surfaced a bug in parsing microdescriptors.
 Sometimes there is a newline on the end of the _raw_content and sometimes
 it disappears. I've checked all the authorities and they are all putting
 newlines on the end (0x0a). This is messing up the digest when the final
 newline is missing. It is odd that it sometimes works, and sometimes
 doesn't, and seems to mostly not work when there is a family line.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28093 [Applications/Tor Browser]: 2018 Tor Browser Android donation banner

2018-11-21 Thread Tor Bug Tracker & Wiki
#28093: 2018 Tor Browser Android donation banner
-+-
 Reporter:  arthuredelstein  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-fundraising, ux-team, tbb-   |  Actual Points:
  mobile, TorBrowserTeam201811R, TBA-a2  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks better now here. Applied to `master`
 (a41034ced7a6c0fe590320d9da61d15df1fef42f).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27111 [Applications/Tor Browser]: TBA: Implement about:tor

2018-11-21 Thread Tor Bug Tracker & Wiki
#27111: TBA: Implement about:tor
-+-
 Reporter:  igt0 |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-mobile, TBA-a2,  |  Actual Points:
  TorBrowserTeam201811R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 The patches look good to me. I applied the Torbutton one as commit
 61deb44d0c07eb1ec1d71eac2f0a7aeca87ea054 to the `master` branch and commit
 c0c87e1a9a6573ac480e4b46d232a4b451f6475c is now on `tor-
 browser-60.3.0esr-8.5-1`. I pushed a submodule update commit as well
 (commit 9a300eedd12c23e1ce48484816df00f4c1a77033).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25702 [Applications/Tor Browser]: Activity 1.1 Update Tor Browser icon to follow design guidelines.

2018-11-21 Thread Tor Bug Tracker & Wiki
#25702: Activity 1.1 Update Tor Browser icon to follow design guidelines.
-+-
 Reporter:  isabela  |  Owner:
 |  antonela
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team, tbb-mobile, |  Actual Points:
  TorBrowserTeam201811R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor17
-+-

Comment (by pospeselr):

 Updated my 25702_v2 branch with change to css to make 'Tor Browser'
 purple: https://gitweb.torproject.org/user/richard/tor-
 
browser.git/diff/?h=bug_25702_v2=2c31553b9f7092de58afa86ebe6db11a82daef6d=0b188f1fd0349fc76f8cc5663279a67b283d3b68

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28390 [Obfuscation/Snowflake]: Snowflake stuck at "Loading relay information..."

2018-11-21 Thread Tor Bug Tracker & Wiki
#28390: Snowflake stuck at "Loading relay information..."
---+--
 Reporter:  cypherpunks3   |  Owner:  (none)
 Type:  defect | Status:  reopened
 Priority:  Medium |  Milestone:
Component:  Obfuscation/Snowflake  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by arlolra):

 Also, the bridge is down

 
https://metrics.torproject.org/rs.html#details/5481936581E23D2D178105D44DB6915AB06BFB7F

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28390 [Obfuscation/Snowflake]: Snowflake stuck at "Loading relay information..."

2018-11-21 Thread Tor Bug Tracker & Wiki
#28390: Snowflake stuck at "Loading relay information..."
---+--
 Reporter:  cypherpunks3   |  Owner:  (none)
 Type:  defect | Status:  reopened
 Priority:  Medium |  Milestone:
Component:  Obfuscation/Snowflake  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by arlolra):

 Replying to [comment:2 cypherpunks3]:
 > Again seems to not work. Maybe not enough proxies I guess?

 Yes, sorry.  We've been running some proxies to ensure there's always some
 capacity while the transport is in development but those have been having
 some issues.

 We really need to get on #20813

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20813 [Obfuscation/Snowflake]: Start producing snowflakes

2018-11-21 Thread Tor Bug Tracker & Wiki
#20813: Start producing snowflakes
---+
 Reporter:  arlolra|  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  High   |  Milestone:
Component:  Obfuscation/Snowflake  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by arlolra):

 Replying to [comment:8 arlolra]:
 > > Is there a url I should leave my browser on, for the browser to become
 a snowflake?
 >
 > http://keroserene.net/snowflake/embed.html
 > or, http://keroserene.net/snowflake/snowflake.html (for debugging)
 >
 > But you need to opt-in first at,
 > http://keroserene.net/snowflake/options.html

 These are at https://snowflake.torproject.org/ now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27315 [Core Tor/Tor]: Sandbox regression in 0.3.4.7-rc

2018-11-21 Thread Tor Bug Tracker & Wiki
#27315: Sandbox regression in 0.3.4.7-rc
---+---
 Reporter:  toralf |  Owner:  (none)
 Type:  defect | Status:  needs_information
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.4.x-final
Component:  Core Tor/Tor   |Version:  Tor: 0.3.4.7-rc
 Severity:  Normal | Resolution:
 Keywords:  regression?, 034-backport  |  Actual Points:
Parent ID: | Points:
 Reviewer:  ahf|Sponsor:
---+---

Comment (by Jigsaw52):

 Replying to [comment:12 ahf]:
 >
 > Do we think we are able to eliminate the additional rule so it's either
 one of the rules? How do we know which users are impacted by this?

 Ideally each rule should only be applied to the systems that need it. The
 tricky part is figuring out why some systems need each rule. I have tried
 to identify some difference between toralf system (which is affected) and
 mine (which isn't) but failed to to so. I could try further but I need the
 collaboration of someone affected.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28398 [Core Tor/Stem]: Please provide a method on descriptors for calculating digests

2018-11-21 Thread Tor Bug Tracker & Wiki
#28398: Please provide a method on descriptors for calculating digests
---+
 Reporter:  irl|  Owner:  atagar
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by atagar):

 Hi irl, just a quick update that microdescriptors
 [https://gitweb.torproject.org/stem.git/commit/?id=5495c57 now have a
 digest() method]. In implementing this I found and fixed a few past
 mistakes of mine...

 * Tor has now implemented microdescriptor downloading via DirPorts. As
 such, undeprecated our stem.descriptor.remote method for this and improved
 it a bit ([https://gitweb.torproject.org/stem.git/commit/?id=c606f44
 commit]).
 * Our newly added from_str() method didn't work for router status entries
 ([https://gitweb.torproject.org/stem.git/commit/?id=310b5ca commit]).
 * Router status entries referenced a hex rather than base64 digest for
 microdescriptors
 ([https://gitweb.torproject.org/stem.git/commit/?id=e30b130 commit]).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28562 [Core Tor/Tor]: test: test_rebind.py doesn't use a temporary a DataDirectory

2018-11-21 Thread Tor Bug Tracker & Wiki
#28562: test: test_rebind.py doesn't use a temporary a DataDirectory
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  tor-test
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 Riastradh on IRC reported this with `test_rebind.sh`:

 {{{
 Tor logged: "Nov 21 20:08:11.296 [warn] Error creating directory
 /home/riastradh/.tor:
 }}}

 That test is not using a temporary dir (example: mktemp -d) so tor is
 using the default one which is `~/.tor`.

 Really not good, out tests should not poke $HOME whatsoever unless we
 change it. Solution would be to create a temp dir, spawn Tor pointing it
 to that path and then remove it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24264 [Core Tor/Tor]: Enable IPv6 reachability testing for the Bridge Authority

2018-11-21 Thread Tor Bug Tracker & Wiki
#24264: Enable IPv6 reachability testing for the Bridge Authority
---+---
 Reporter:  isis   |  Owner:  (none)
 Type:  task   | Status:  assigned
 Priority:  High   |  Milestone:  Tor:
   |  0.4.0.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  dirauth, bridgeauth, ipv6  |  Actual Points:
Parent ID: | Points:  .2
 Reviewer: |Sponsor:  SponsorM
---+---
Changes (by gaba):

 * owner:  isis => (none)
 * status:  reopened => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25651 [Core Tor/Tor]: Handle incoming extend2/extended2 fragmented requests/replies. (prop249)

2018-11-21 Thread Tor Bug Tracker & Wiki
#25651: Handle incoming extend2/extended2 fragmented requests/replies. (prop249)
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-cell, tor-circuit, trunnel, 034  |  Actual Points:
  -roadmap-subtask, 034-triage-20180328, |
  034-included-20180328, 035-roadmap-subtask,|
  035-triaged-in-20180711|
Parent ID:  #24986   | Points:  3
 Reviewer:   |Sponsor:
 |  SponsorM-can
-+-
Changes (by gaba):

 * status:  accepted => assigned
 * owner:  isis => (none)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22776 [Obfuscation/BridgeDB]: Implement the remaining cryptographic protocols for Hyphae

2018-11-21 Thread Tor Bug Tracker & Wiki
#22776: Implement the remaining cryptographic protocols for Hyphae
-+---
 Reporter:  isis |  Owner:  (none)
 Type:  enhancement  | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/BridgeDB |Version:
 Severity:  Normal   | Resolution:
 Keywords:  bridgedb-distributors, rust  |  Actual Points:
Parent ID:  #22775   | Points:  3
 Reviewer:   |Sponsor:  SponsorM-must
-+---
Changes (by gaba):

 * owner:  gaba => (none)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22776 [Obfuscation/BridgeDB]: Implement the remaining cryptographic protocols for Hyphae

2018-11-21 Thread Tor Bug Tracker & Wiki
#22776: Implement the remaining cryptographic protocols for Hyphae
-+---
 Reporter:  isis |  Owner:  gaba
 Type:  enhancement  | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/BridgeDB |Version:
 Severity:  Normal   | Resolution:
 Keywords:  bridgedb-distributors, rust  |  Actual Points:
Parent ID:  #22775   | Points:  3
 Reviewer:   |Sponsor:  SponsorM-must
-+---
Changes (by gaba):

 * owner:  isis => gaba
 * status:  accepted => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22948 [Core Tor/Tor]: Padding, Keepalive and Drop cells should have random payloads

2018-11-21 Thread Tor Bug Tracker & Wiki
#22948: Padding, Keepalive and Drop cells should have random payloads
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-spec, 034-triage-20180328,   |  Actual Points:
  034-removed-20180328   |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by gaba):

 * owner:  isis => (none)
 * status:  accepted => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28224 [Core Tor/DirAuth]: Monitor dirauth running sbws in production

2018-11-21 Thread Tor Bug Tracker & Wiki
#28224: Monitor dirauth running sbws in production
--+--
 Reporter:  juga  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  sbws 1.1
Component:  Core Tor/DirAuth  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #27107| Points:
 Reviewer:|Sponsor:
--+--

Comment (by juga):

 i don't think that dirauth tor code checks how many relays are in the
 bandwidth file

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25702 [Applications/Tor Browser]: Activity 1.1 Update Tor Browser icon to follow design guidelines.

2018-11-21 Thread Tor Bug Tracker & Wiki
#25702: Activity 1.1 Update Tor Browser icon to follow design guidelines.
-+-
 Reporter:  isabela  |  Owner:
 |  antonela
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team, tbb-mobile, |  Actual Points:
  TorBrowserTeam201811R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor17
-+-

Comment (by pospeselr):

 Replying to [comment:16 antonela]:
 > Richard looks awesome! What we are going to do with:
 >
 > - 1. the orange Tor Browser in `about:tor`? I think you already have a
 patch from #28111.
 > - 2. the 'Tor Browser' name on the `about` windows. Could we simply have
 text? The typography is already loaded so we don't need an image there.
 >
 > I think we are groot here ^^ Thanks!

 The color change should be easy enough, and I've created a ticket (#28561)
 to track that dialog's migration from torbutton to tor-browser (I'll
 update the text at the same time).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28561 [Applications/Tor Browser]: Migrate custom 'About Tor Browser' dialog from torbutton to tor-browser branding

2018-11-21 Thread Tor Bug Tracker & Wiki
#28561: Migrate custom 'About Tor Browser' dialog from torbutton to tor-browser
branding
--+---
 Reporter:  pospeselr |  Owner:  pospeselr
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:  #25702
   Points:|   Reviewer:
  Sponsor:|
--+---
 As part of branding update change in #25702, the Tor Browser icon
 referenced in the About Tor Browser XUL dialog was changed to one packaged
 in tor-browser (since torbutton does not know whether it's stable, alpha
 or nightly).

 The entire dialog should be moved to tor-browser rather than having cross-
 referenced content.  As part of this, also change the 'Tor Browser' text
 from an image to just text.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28540 [Applications/Tor Browser]: 12/11 release Banner text

2018-11-21 Thread Tor Bug Tracker & Wiki
#28540: 12/11 release Banner text
-+-
 Reporter:  sstevenson   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-fundraising, ux-team,|  Actual Points:
  TorBrowserTeam201811R  |
Parent ID:  #23925   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * keywords:  tbb-fundraising, ux-team, TorBrowserTeam201811 => tbb-
 fundraising, ux-team, TorBrowserTeam201811R
 * status:  new => needs_review


Comment:

 Here's the patch to actually use the new strings. It also effectively
 restarts the banner countdown. I have tested this on desktop but not
 mobile.

 https://github.com/arthuredelstein/torbutton/commit/28540+1

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28051 [Applications/Tor Browser]: Build Orbot into TBA

2018-11-21 Thread Tor Bug Tracker & Wiki
#28051: Build Orbot into TBA
-+-
 Reporter:  sysrqb   |  Owner:  sysrqb
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tba-a2,  |  Actual Points:
  TorBrowserTeam201811   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by igt0):

 About the commit {{{e9967a17a4d8eadcd35f45a81023620a93c72633}}} what
 happens if the the user closes the app using the swipe gesture? Does TBA
 stop the background services? Or should we move this logic to the
 onDestroy method?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28358 [Core Tor/Tor]: Nyx forces Tor error: sandbox_getaddrinfo(): Bug: (Sandbox) failed to get address

2018-11-21 Thread Tor Bug Tracker & Wiki
#28358: Nyx forces Tor error: sandbox_getaddrinfo(): Bug: (Sandbox) failed to 
get
address
--+--
 Reporter:  wagon |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: 0.3.4.9
 Severity:  Normal| Resolution:
 Keywords:  sandbox   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by wagon):

 > Would you like to contribute this patch? :) (file to modify:
 `doc/tor.1.txt`)
 For `doc/tor.1.txt` from tor-0.3.5.5-alpha:
 {{{
 $ diff tor.1.txt-original tor.1.txt-updated
 601c601
 < can not be changed while tor is running.
 ---
 > can not be changed while tor is running. +
 603c603
 < When the Sandbox is 1, the following options can not be changed when
 tor
 ---
 > When the **Sandbox** is 1, the following options can not be changed
 when tor
 605,613c605,614
 < Address
 < ConnLimit
 < CookieAuthFile
 < DirPortFrontPage
 < ExtORPortCookieAuthFile
 < Logs
 < ServerDNSResolvConfFile
 < Tor must remain in client or server mode (some changes to ClientOnly
 and
 < ORPort are not allowed).
 ---
 > **Address**,
 > **ConnLimit**,
 > **CookieAuthFile**,
 > **DirPortFrontPage**,
 > **ExtORPortCookieAuthFile**,
 > **Logs**,
 > **ServerDNSResolvConfFile**.
 > Tor must remain in client or server mode (some changes to
 **ClientOnly** and
 > **ORPort** are not allowed). Currently, if **Sandbox** is 1,
 **ControlPort**
 > command "GETINFO address" will not work.
 }}}
 I also fixed formatting problems in this option. The result was checked
 using the commands:
 {{{
 $ a2x -f manpage /path/to/tor.1.txt
 $ man /path/to/tor.1
 }}}
 It would be good solution for now, but in future we have to make it
 working with `Sandbox` option. As I understand you, it doesn't contradict
 to the idea of sandbox design.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28552 [Core Tor/Stem]: Should stem integ tests fail on controller errors?

2018-11-21 Thread Tor Bug Tracker & Wiki
#28552: Should stem integ tests fail on controller errors?
---+
 Reporter:  teor   |  Owner:  atagar
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by atagar):

 Hi teor, this is probably from...

 
https://gitweb.torproject.org/stem.git/tree/test/unit/control/controller.py#n685

 You're seeing these because you're running run_tests.py with "--log
 notice". From stem's standpoint all looks well to me. The '--log' argument
 is intended for troubleshooting. Logged messages don't necessarily
 indicate problems.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28551 [Core Tor/Tor]: Tor's Travis should print the python version after installation

2018-11-21 Thread Tor Bug Tracker & Wiki
#28551: Tor's Travis should print the python version after installation
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:  tor-ci, travis, fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by atagar):

 > If we don't print the actual python version that's running,

 Hi teor. Actually, Stem's tests should be doing this. Test runs are
 prefaced with versioning information...

 {{{
 % python3 run_tests.py --all
 ==
  INITIALISING
 ==

   stem version...  1.7.0-dev
   tor version...   0.4.0.0-alpha-dev
   python version...3.5.2
   operating system version...  Linux (Ubuntu
 16.04)
   cryptography version...  missing
   pynacl version...missing
   mock version...  1.0
   pyflakes version...  missing
   pycodestyle version...   missing
   checking for orphaned .pyc files...  done (0.0s)
   checking for unused tests... done (0.0s)
   importing test modules...done (0.1s)
   running pyflakes...  unavailable
   running pycodestyle...   unavailable

 ==
   UNIT TESTS
 ==

   util.enum... success (0.00s)
   util.connection...   success (0.06s)
   util.conf... success (0.02s)
 ...
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28550 [Core Tor/Stem]: stem integ tests fail on python 2 with str/bytes error

2018-11-21 Thread Tor Bug Tracker & Wiki
#28550: stem integ tests fail on python 2 with str/bytes error
---+
 Reporter:  teor   |  Owner:  atagar
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by atagar):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Oops! Sorry about that teor, fixed:
 https://gitweb.torproject.org/stem.git/commit/?id=2ea9347

 On a side note I suspect you might have the wrong python version. With
 python2 the tests should have been passing, the mistake was with python3.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28551 [Core Tor/Tor]: Tor's Travis should print the python version after installation

2018-11-21 Thread Tor Bug Tracker & Wiki
#28551: Tor's Travis should print the python version after installation
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:  tor-ci, travis, fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by atagar):

 * parent:  #28550 =>


Comment:

 Dropping the parent because that's preventing me from resolving the other
 ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28051 [Applications/Tor Browser]: Build Orbot into TBA

2018-11-21 Thread Tor Bug Tracker & Wiki
#28051: Build Orbot into TBA
-+-
 Reporter:  sysrqb   |  Owner:  sysrqb
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tba-a2,  |  Actual Points:
  TorBrowserTeam201811   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sysrqb):

 Replying to [comment:17 gk]:
 > Okay, starting to review I guess `28051_2`?
 >
 > 1) Can you squash those fixups you made (that is commits
 43936a111d23a89d509e9de75ecf2f28c17dc3c0 and
 c7fa82b84eceacf49d7d9436bfeb530630c9fd03) and base the branch on the
 latest `tor-browser-60.3.0esr-8.5-1`?
 >
 > 2) commit ca62a15e7e8f6781c61e82c4ec64bc4fcfbfe97c
 >
 > {{{
 > +//implementation 'com.github.apl-devs:appintro:v4.2.2'
 > +//implementation 'com.github.javiersantos:AppUpdater:2.6.4'
 > }}}
 > Let's omit those if we don't need them. The Orbot integration is already
 complex enough :)
 >
 > 3) commit 5a755dad3b549f5e01b87016f6f4bfbfbd3654cc
 >
 > I doubt we'll ever get back to a model where Tor Browser for Android
 ships without Orbot or something similarly integrated and needs to ask the
 user about installing Orbot first. Thus, can we clean up the
 > `checkStartOrbot()` related logic while we are at it instead of working
 around with `checkStartOrbot2()`?

 Thanks for starting the review. I pushed `28051_3` with the changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28205 [Obfuscation/Snowflake]: linking against other libwebrtc binaries errors out on missing symbols

2018-11-21 Thread Tor Bug Tracker & Wiki
#28205: linking against other libwebrtc binaries errors out on missing symbols
---+--
 Reporter:  eighthave  |  Owner:  eighthave
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Obfuscation/Snowflake  |Version:
 Severity:  Major  | Resolution:
 Keywords:  android|  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by eighthave):

 It is not possible to build the shared library, because of `package main`:

 {{{
 $ gomobile bind -v -x -target=android/arm
 github.com/keroserene/snowflake/client
 gomobile: binding 'main' package () is not supported
 }}}

 Looks like building the Android app is working, except for:
 {{{
 gomobile: github.com/keroserene/snowflake/client does not import
 "golang.org/x/mobile/app"
 }}}
 https://gitlab.com/eighthave/snowflake/-/jobs/123682282

 I'll try implementing `golang.org/x/mobile/app` tomorrow, unless someone
 else wants to try it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27668 [Community]: Wikipedia wants more attention

2018-11-21 Thread Tor Bug Tracker & Wiki
#27668: Wikipedia wants more attention
-+
 Reporter:  traumschule  |  Owner:  (none)
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Community|Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by alison):

 * status:  assigned => new


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27771 [Community]: Update PreventingDnsLeaksInTor wiki page

2018-11-21 Thread Tor Bug Tracker & Wiki
#27771: Update PreventingDnsLeaksInTor wiki page
--+
 Reporter:  traumschule   |  Owner:  (none)
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Community |Version:
 Severity:  Normal| Resolution:
 Keywords:  dns leak tor  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by alison):

 * status:  assigned => new


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22965 [Community]: Please adopt torbrowser-launcher on deb.torproject.org

2018-11-21 Thread Tor Bug Tracker & Wiki
#22965: Please adopt torbrowser-launcher on deb.torproject.org
-+
 Reporter:  d3vid|  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Community|Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by alison):

 * status:  assigned => new


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

  1   2   >