Re: [tor-bugs] #23880 [Applications/Orbot]: Build tor with --enable-rust in Orbot and OnionBrowser

2018-12-12 Thread Tor Bug Tracker & Wiki
#23880: Build tor with --enable-rust in Orbot and OnionBrowser
+---
 Reporter:  isis|  Owner:  n8fr8
 Type:  task| Status:  new
 Priority:  High|  Milestone:
Component:  Applications/Orbot  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  rust, rust-pilot|  Actual Points:
Parent ID:  | Points:  3
 Reviewer:  |Sponsor:
+---
Changes (by gk):

 * owner:  tbb-team => n8fr8
 * component:  Applications/Tor Browser => Applications/Orbot


Comment:

 Still Orbot.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #1966 [Applications/Orbot]: Need to handle non-ISO-639-1 language codes

2018-12-12 Thread Tor Bug Tracker & Wiki
#1966: Need to handle non-ISO-639-1 language codes
+--
 Reporter:  nickm   |  Owner:  tbb-team
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Applications/Orbot  |Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * status:  assigned => closed
 * component:  Applications/Tor Browser => Applications/Orbot
 * resolution:   => fixed


Comment:

 Replying to [comment:2 n8fr8]:
 > Based on this post, it is possible:
 http://ykyuen.wordpress.com/2009/12/16/android-localization/
 >
 > You specify the region component like so:
 >
 > values-zh-rCN
 > values-zh-rTW
 > values-en-rGB
 >
 > and so on.

 Seems to have been implemented. Hard to say, though, when this got fixed.
 Orfoxisdead: This is yet another ticket that is no Tor Browser one. Please
 don't just simply change the ticket component. Thanks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28191 [Applications/Orbot]: orfox isnt working

2018-12-12 Thread Tor Bug Tracker & Wiki
#28191: orfox isnt working
+--
 Reporter:  turnipdick  |  Owner:  tbb-team
 Type:  defect  | Status:  closed
 Priority:  High|  Milestone:
Component:  Applications/Orbot  |Version:
 Severity:  Normal  | Resolution:  wontfix
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * status:  assigned => closed
 * resolution:   => wontfix
 * component:  Applications/Tor Browser => Applications/Orbot


Comment:

 We won't fix anything for Orfox anymore. Thus, if this is an Orfox issue,
 then this is a WONTFIX. (However, it could be an Orbot issue, too. In that
 case please reopen this ticket providing steps to reproduce this bug with
 an application *not* being Orfox).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28828 [Webpages/Website]: Change website to better handle multi-locale Android .apk

2018-12-12 Thread Tor Bug Tracker & Wiki
#28828: Change website to better handle multi-locale Android .apk
--+--
 Reporter:  gk|  Owner:  hiro
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 Starting with #26483 fixed our .apk file contains all the locales we
 support. There is no per-locale .apk (anymore) and it is not planned to
 support that. But e.g. our alpha download page
 (https://www.torproject.org/projects/torbrowser.html.en#downloads-alpha)
 contains a table with all the available bundles *per locale*.

 We worked around that by pointing to the multi-locale .apk for every
 locale we support but we might want to have something better than this
 stopgap.

 We should revisit the other pages we have that offer the .apk for download
 to make sure we redesign the whole Android download part if needed and not
 just a single page.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28829 [Webpages/Website]: Add reproducible builds verification notes for Android to our verifying signature page

2018-12-12 Thread Tor Bug Tracker & Wiki
#28829: Add reproducible builds verification notes for Android to our verifying
signature page
--+-
 Reporter:  gk|  Owner:  hiro
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal|   Keywords:  TBA-8.5
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+-
 On https://www.torproject.org/docs/verifying-
 signatures.html.en#BuildVerification we outline how to make a link between
 the bundles we actually ship (including update files) to the artifacts one
 gets by following our reproducible builds path.

 So far, this contains instructions for Linux and Windows bundles. macOS is
 tricky and dealt with in #18925.

 This ticket is to add respective instructions for our .apk file(s) we
 ship.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28829 [Webpages/Website]: Add reproducible builds verification notes for Android to our verifying signature page

2018-12-12 Thread Tor Bug Tracker & Wiki
#28829: Add reproducible builds verification notes for Android to our verifying
signature page
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TBA-8.5   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * status:  new => assigned
 * owner:  hiro => tbb-team


Comment:

 Setting owner tentatively to us, but if anyone else wants to pick this up
 meanwhile, feel free.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28830 [Applications/Tor Browser]: Clean up tor-browser-build build scripts/config files

2018-12-12 Thread Tor Bug Tracker & Wiki
#28830: Clean up tor-browser-build build scripts/config files
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-rbm
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 We should go over the projects we have in `tor-browser-build` and clean up
 build scripts and config files if needed.

 Areas we could/should cover:

 1) We sometimes have several platform related blocks in one build script
 which could be confusing. Can we merge those (or some of them) while still
 keeping the overall flow of the script logic?

 2) Duplicating platform-specific and !platform-specific commands, e.g. `cd
 $distdir` in
 {{{
 [% IF c("var/osx") %]
   LIBEVENT_FILE=`basename $libeventdir/lib/libevent-*.dylib`
   cd $distdir
   cp bin/tor $TORBINDIR/
   cd $TORBINDIR/
   x86_64-apple-darwin11-install_name_tool -change
 $libeventdir/lib/$LIBEVENT_FILE @executable_path/$LIBEVENT_FILE tor
 [% END %]

 cd $distdir
 }}}

 3)...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

2018-12-12 Thread Tor Bug Tracker & Wiki
#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by juga):

 Replying to [comment:42 teor]:
 > It looks like you're setting the compression state, then adding the data
 uncompressed.
 >
 > You didn't open a pull request, so I commented on the commit:
 >
 
https://github.com/torproject/tor/commit/b03091842bc4590e11e3ac026daae8ed6d8f7554#r31629291
 >
 
https://github.com/torproject/tor/commit/b03091842bc4590e11e3ac026daae8ed6d8f7554#r31629096

 I didn't create a PR, cause i knew that code fails, but wanted to ask
 about it.
 i've left new comments after setting the compression state.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28764 [Applications/Tor Browser]: OpenSSL Build for Android

2018-12-12 Thread Tor Bug Tracker & Wiki
#28764: OpenSSL Build for Android
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201812   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam201812R => tbb-mobile, tbb-
 rbm, TorBrowserTeam201812


Comment:

 Three things we should think about here:

 1) The OpenSSL output is not build reproducibly. The .a creation is not
 deterministic as it seems to contain timestamps, see:
 {{{
 0007ce70:      6001  0b00  ..`.
  0007ce80:      0100    
  0007ce90:  7373 6c5f 7574 7374 2e6f 2f20 2020  ..ssl_utst.o/
 -0007cea0: 2020 3135 3434 3532 3132 3032 2020 31301544521202  10
 +0007cea0: 2020 3135 3434 3532 3035 3032 2020 31301544520502  10
  0007ceb0: 3030 2020 3130 3030 2020 3130 3036 3434  00  1000  100644
  0007cec0: 2020 3736 3420 2020 2020 2020 600a 7f45764   `..E
  0007ced0: 4c46 0101 0100     0100  LF..
 }}}
 I wonder why that is necessary here. Maybe the cross-toolchain for Android
 does not have something like `-Wl,--no-insert-timestamp`?

 2) Do we really need all the exported env variables in the build script?
 The build seemed to work for me e.g. without declaring `RANLIB`?

 3) The comment in the config file should we wrapped so that we have it on
 two lines instead of one.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28666 [Applications/Tor Browser]: Spellcheck wont work on TorBrowser Version 8.0.3 - Linux (64-Bit) for spanish laguange

2018-12-12 Thread Tor Bug Tracker & Wiki
#28666: Spellcheck wont work on TorBrowser Version 8.0.3 - Linux (64-Bit) for
spanish laguange
--+---
 Reporter:  CaptainCookie |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  spell check   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by gk):

 * Attachment "28666_en-US.png" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28666 [Applications/Tor Browser]: Spellcheck wont work on TorBrowser Version 8.0.3 - Linux (64-Bit) for spanish laguange

2018-12-12 Thread Tor Bug Tracker & Wiki
#28666: Spellcheck wont work on TorBrowser Version 8.0.3 - Linux (64-Bit) for
spanish laguange
--+---
 Reporter:  CaptainCookie |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  spell check   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by gk):

 Replying to [comment:2 CaptainCookie]:
 > > > Where do you click here exactly? Is that in some browser menu? I
 think I am not sure how to reproduce this problem.
 >
 > First install the spanish dictionary. Then go to a web site with a text
 box to type a message (I note this on twitter). Inside that text box make
 a right clic then a menu appears. In that menu in the "languages" submenu
 the spanish dictionary option should appears, but it don't and only shows
 the english option.
 > [[Image(https://ibb.co/Z1xvCFd)]]

 This works for me, somewhat surprisingly:
 [[Image(https://trac.torproject.org/projects/tor/attachment/ticket/28666
 /28666_en-US.png)]]

 > Next pic is to show that spanish dictionary is installed
 > [[Image(https://ibb.co/54JZVVL)]]

 That's weird. How did you get your dictionary into the Extensions section?
 You should have it in an own Dictionaries section (as I have when testing
 that).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28353 [Metrics/Website]: Use Guard & Exit, Guard only, Exit only, and Middle only on all bandwidth by flag graphs

2018-12-12 Thread Tor Bug Tracker & Wiki
#28353: Use Guard & Exit, Guard only, Exit only, and Middle only on all 
bandwidth
by flag graphs
-+--
 Reporter:  teor |  Owner:  metrics-team
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #28328   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by karsten):

 Please also review the newly added
 [https://gitweb.torproject.org/user/karsten/metrics-
 web.git/commit/?h=task-28353&id=1f70089268dd0d1279345004ed1e2c265f69d981
 commit 1f70089 in my task-28353 branch] which removes the two obsolete
 graphs and updates documentation.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28353 [Metrics/Website]: Use Guard & Exit, Guard only, Exit only, and Middle only on all bandwidth by flag graphs

2018-12-12 Thread Tor Bug Tracker & Wiki
#28353: Use Guard & Exit, Guard only, Exit only, and Middle only on all 
bandwidth
by flag graphs
-+--
 Reporter:  teor |  Owner:  metrics-team
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #28328   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * status:  merge_ready => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28720 [Applications/Tor Browser]: NoScript is blocking some videos outright starting with 10.1.9.2rc2 on security level "safer"

2018-12-12 Thread Tor Bug Tracker & Wiki
#28720: NoScript is blocking some videos outright starting with 10.1.9.2rc2 on
security level "safer"
-+-
 Reporter:  gk   |  Owner:  ma1
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  noscript, TorBrowserTeam201812R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:7 ma1]:
 > The replaced video element not automatically reloading the media should
 also be fixed in
 [https://github.com/hackademix/noscript/releases/tag/10.2.1rc2 10.2.1rc2],
 thanks.

 Looks good to me, thanks. I'll close the ticket once a new NoScript
 version containing this fix is out and I bumped the version we ship.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28825 [Core Tor/Tor]: update to 8.04 causes immediate crash on MacOS 10.14.1

2018-12-12 Thread Tor Bug Tracker & Wiki
#28825: update to 8.04 causes immediate crash on MacOS 10.14.1
--+
 Reporter:  gander2001|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Very High |  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Blocker   | Resolution:
 Keywords:  tbb-crash |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by pili):

 I just upgraded my MacOS 10.14 to 10.14.1 and I can run Tor Browser 8.0.4
 without any crashes.

 Previously (on MacOS 10.14) I had upgraded my Tor Browser to 8.0.4 and
 that was also working fine without crashing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28791 [Applications/Tor Browser]: Tor Browser 8 cannot download images protected by basic auth

2018-12-12 Thread Tor Bug Tracker & Wiki
#28791: Tor Browser 8 cannot download images protected by basic auth
--+---
 Reporter:  pf.team   |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-linkability   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by gk):

 * keywords:  TorBrowser files download auth => tbb-linkability
 * status:  new => needs_information


Comment:

 Which Tor Browser version are you using? If it's not the latest alpha,
 please try that one
 (https://www.torproject.org/projects/torbrowser.html.en#downloads-alpha).
 We recently landed a fix for #22343 which might make things work for you.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28790 [Applications/Tor Browser]: Webpage size shouldn’t depend on browser chrome

2018-12-12 Thread Tor Bug Tracker & Wiki
#28790: Webpage size shouldn’t depend on browser chrome
--+---
 Reporter:  dante01123|  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  duplicate
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by gk):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Replying to [comment:1 Thorin]:
 > changing theme density, sidebar, menubar, findbar (and even padding of
 icons on the toolbar) = any change to chrome after opening will not
 automatically resize the browser to control the inner window dimensions.
 >
 > Tor Uplift will instead control the viewport:
 https://bugzilla.mozilla.org/show_bug.cgi?id=1407366 and this should be in
 the next ESR (fingers crossed)

 Yes, which is essentially some variation of #14429. Closing this ticket as
 a duplicate of the former.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #14429 [Applications/Tor Browser]: Automated rounding of content window dimensions

2018-12-12 Thread Tor Bug Tracker & Wiki
#14429: Automated rounding of content window dimensions
-+-
 Reporter:  arthuredelstein  |  Owner:
 |  arthuredelstein
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-fingerprinting-resolution, tbb-  |  Actual Points:
  torbutton  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * cc: dante01123 (added)


Comment:

 Closed #28790 as duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28751 [Applications/Tor Browser]: TB 8.5a5 Sig 11 core dump on shutdown when compiled with Selfrando (was: TB 8.5a5 Sig 11 core dump on shutdown)

2018-12-12 Thread Tor Bug Tracker & Wiki
#28751: TB 8.5a5 Sig 11 core dump on shutdown when compiled with Selfrando
--+---
 Reporter:  jb.1234abcd   |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-crash |  Actual Points:
Parent ID:  #23073| Points:
 Reviewer:|Sponsor:
--+---
Changes (by gk):

 * cc: ahomescu (added)
 * parent:   => #23073


Comment:

 Okay, the only difference is the bundle doing the coredump is compiled
 with selfrando. ahomescu: Does that ring a bell/any ideas?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28800 [Applications/Tor Browser]: Implement New Identity functionality for Tor Browser on Android

2018-12-12 Thread Tor Bug Tracker & Wiki
#28800: Implement New Identity functionality for Tor Browser on Android
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-newnym, ux-team, |  Actual Points:
  TorBrowserTeam201812, TBA-a3   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-newnym, ux-team, TorBrowserTeam201812 => tbb-
 mobile, tbb-newnym, ux-team, TorBrowserTeam201812, TBA-a3


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27515 [Applications/Tor Browser]: video placeholder didn't work in Tor browser 8.0 on highest security level

2018-12-12 Thread Tor Bug Tracker & Wiki
#27515: video placeholder didn't work in Tor browser 8.0 on highest security 
level
-+-
 Reporter:  1362572  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression,  |  Actual Points:
  tbb-security-slider, noscript  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 I think it's actually a separate issue. This ticket got logged on 9/6.
 Back then #28720 was no issue. It showed up with 10.1.9.2 which got
 released on 9/9.

 But steps to reproduce are still needed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28831 [Internal Services/Tor Sysadmin Team]: Fix wrong email for sisbell behind the job-browser@ alias

2018-12-12 Thread Tor Bug Tracker & Wiki
#28831: Fix wrong email for sisbell behind the job-browser@ alias
-+-
 Reporter:  gk   |  Owner:  tpa
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 It seems we had a typo in sisbell's email address for the job-browser@
 alias. In #28770 there was the request to add `sisbe...@torproject.org`
 but it should have been `sisb...@torproject.org`.

 Could we get that corrected?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28831 [Internal Services/Tor Sysadmin Team]: Fix wrong email for sisbell behind the job-browser@ alias

2018-12-12 Thread Tor Bug Tracker & Wiki
#28831: Fix wrong email for sisbell behind the job-browser@ alias
-+
 Reporter:  gk   |  Owner:  tpa
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by ln5):

 * status:  new => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #12885 [Applications/Tor Browser]: Windows Jump Lists fail for Tor Browser

2018-12-12 Thread Tor Bug Tracker & Wiki
#12885: Windows Jump Lists fail for Tor Browser
-+-
 Reporter:  mcs  |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability,   |  Actual Points:
  TorBrowserTeam201812R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => needs_information


Comment:

 Replying to [comment:8 pospeselr]:
 > Replying to [comment:7 mcs]:
 > > Your patch looks OK, but how does the `browser.taskbar.lists.enabled`
 pref relate to the ones you are setting to `false`? It looks like it might
 be a "master switch" that could be used to turn everything off, but I
 would need to look more closely at the code to be sure.
 >
 > Based on some experimentation, the `browser.taskbar.lists.enabled` pref
 does not appear to act as a master switch in this way. After reading the
 code it looks like it may clear the 'recents' list when toggled from true
 to false, but that's about it.

 So, in fact, this does look like a (potential) `master` switch, the
 problem is that old entries are not deleted. It seems a bit weird to me
 that we need to have the whole thing enabled (with the timer to update the
 jumplist still firing all the time) to be sure old entries are deleted
 *and* no new ones are created.

 What about patching the code instead to make sure once during start-up, in
 case `browser.taskbar.lists.enabled` is set to `false`, we remove old
 items, too. The entry point seems to be

 https://dxr.mozilla.org/mozilla-
 esr60/source/browser/components/nsBrowserGlue.js#1173 calling
 `temp.WinTaskbarJumpList.startup();`. That in turn makes us read our prefs
 (`this._refreshPrefs();`) and start the timer for the jump list update
 (`this._updateTimer();`). Maybe we should just call the timer update in
 case the jumplist feature is enabled and if not we delete recent entries
 and that's it? (there would then be no need to disable the three prefs,
 rather we would have turned `browser.taskbar.lists.enabled` into the
 global switch which its name suggests.

 Does that sound reasonable? Or did I miss something while looking at the
 code?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28666 [Applications/Tor Browser]: Spellcheck wont work on TorBrowser Version 8.0.3 - Linux (64-Bit) for spanish laguange

2018-12-12 Thread Tor Bug Tracker & Wiki
#28666: Spellcheck wont work on TorBrowser Version 8.0.3 - Linux (64-Bit) for
spanish laguange
--+---
 Reporter:  CaptainCookie |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  spell check   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by spanish):

 Dictionaries are now WebExtensions, but Mozilla forgot about compatibility
 settings (as in lpks). See https://addons.mozilla.org/en-US/firefox/addon
 /spanish-spain-dictionary/versions/
 Also would you be so kind to bundle appropriate dictionary with every
 locale?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28832 [Webpages/Website]: Change website to better reflect recommended versions

2018-12-12 Thread Tor Bug Tracker & Wiki
#28832: Change website to better reflect recommended versions
-+--
 Reporter:  spanish  |  Owner:  hiro
 Type:  defect   | Status:  new
 Priority:  Medium   |  Component:  Webpages/Website
  Version:   |   Severity:  Normal
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
 E.g. our alpha download page
 (​https://www.torproject.org/projects/torbrowser.html.en#downloads-alpha)
 contains a table with weird `32/64-bit (sig) • 64-bit (sig)` choices. It
 would be better to group choices like in https://www.mozilla.org/en-
 US/firefox/all/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28666 [Applications/Tor Browser]: Spellcheck wont work on TorBrowser Version 8.0.3 - Linux (64-Bit) for spanish laguange

2018-12-12 Thread Tor Bug Tracker & Wiki
#28666: Spellcheck wont work on TorBrowser Version 8.0.3 - Linux (64-Bit) for
spanish laguange
--+---
 Reporter:  CaptainCookie |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  spell check   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by gk):

 Replying to [comment:5 spanish]:
 > Dictionaries are now WebExtensions, but Mozilla forgot about
 compatibility settings (as in lpks). See https://addons.mozilla.org/en-
 US/firefox/addon/spanish-spain-dictionary/versions/

 Are you saying installing from that link causes the problem? I tried
 https://addons.mozilla.org/en-US/firefox/language-tools/ as the reporter
 indicated.

 > Also would you be so kind to bundle appropriate dictionary with every
 locale?

 I am not sure. What is Mozilla doing?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28741 [Core Tor/sbws]: sbws should send scanner metadata as part of every HTTP request

2018-12-12 Thread Tor Bug Tracker & Wiki
#28741: sbws should send scanner metadata as part of every HTTP request
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws: 1.0.x-final
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---

Comment (by juga):

 Replying to [comment:2 teor]:

 > sbws doesn't guarantee any anonymity, and discovering rogue scanners is
 more important than the risk of malicious servers using the IP address.

 Thinking more this, i'm not totally convinced. If we find rogue scanners,
 are we going to try to contact them?.
 I'm also not sure if that might be a problem on the server side due data
 privacy laws.
 What about creating a random unique identifier the first time that it's
 saved locally so the scanner can always send the same?.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28666 [Applications/Tor Browser]: Spellcheck wont work on TorBrowser Version 8.0.3 - Linux (64-Bit) for spanish laguange

2018-12-12 Thread Tor Bug Tracker & Wiki
#28666: Spellcheck wont work on TorBrowser Version 8.0.3 - Linux (64-Bit) for
spanish laguange
--+---
 Reporter:  CaptainCookie |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  spell check   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by spanish):

 Replying to [comment:6 gk]:
 > Replying to [comment:5 spanish]:
 > > Dictionaries are now WebExtensions, but Mozilla forgot about
 compatibility settings (as in lpks). See https://addons.mozilla.org/en-
 US/firefox/addon/spanish-spain-dictionary/versions/
 >
 > Are you saying installing from that link causes the problem? I tried
 https://addons.mozilla.org/en-US/firefox/language-tools/ as the reporter
 indicated.
 `Version 2.3.1webext Released Nov. 28, 2018` is the first webext version,
 not tested with esr.
 > > Also would you be so kind to bundle appropriate dictionary with every
 locale?
 >
 > I am not sure. What is Mozilla doing?
 lpk+dic is better than lpk. Why do you care?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28755 [Core Tor/Tor]: Implement a K/V parser library

2018-12-12 Thread Tor Bug Tracker & Wiki
#28755: Implement a K/V parser library
--+
 Reporter:  dgoulet   |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .3
Parent ID:  #25502| Points:
 Reviewer:  ahf, dgoulet  |Sponsor:
--+
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 Okay, I think the branch is better now.  The leftovers are gone, it passes
 the tests you gave, and still passes the fuzzer.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27299 [Core Tor/Tor]: hsv3: Clarify timing sources around hsv3 code

2018-12-12 Thread Tor Bug Tracker & Wiki
#27299: hsv3: Clarify timing sources around hsv3 code
-+-
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs hsv3 refactoring easy |  Actual Points:
  technical-debt |
Parent ID:  #23764   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by ffmancera):

 Replying to [comment:3 asn]:
 > > I saw that we are using `approx_time()` which is an alias of
 `time(NULL)`, but at the same time and in the same file, we are using
 both. As `approx_time.h` has different utilities for timing, we should use
 it instead of `time(NULL)`. What do you think?
 > >
 >
 > Yes, I think we should be using `approx_time()` instead of `time(NULL)`
 everywhere. I don't see a reason not to.
 >
 > One of the problems with HS timing is that lots of the time sources come
 from the main event loop where `time(NULL)` is used.

 Then we should refactor all time resources, using only approx_time() over
 all the code right? I have a patch for this specific task. I will do a
 pull request if you are fine with that?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28624 [Core Tor/Tor]: Should we remember dormant state on restart?

2018-12-12 Thread Tor Bug Tracker & Wiki
#28624: Should we remember dormant state on restart?
--+
 Reporter:  arma  |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  1
Parent ID:| Points:  2
 Reviewer:  dgoulet   |Sponsor:  Sponsor8-can
--+
Changes (by nickm):

 * sponsor:   => Sponsor8-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26770 [Core Tor/Tor]: Implement proposal 293: "Other ways for relays to know when to publish"

2018-12-12 Thread Tor Bug Tracker & Wiki
#26770: Implement proposal 293: "Other ways for relays to know when to publish"
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop293, prop275, 040-roadmap-   |  implemented
  proposed, StaleDesc|  Actual Points:  .1
Parent ID:  #21642   | Points:
 Reviewer:  teor |Sponsor:
 |  Sponsor8-can
-+-
Changes (by nickm):

 * sponsor:   => Sponsor8-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27929 [Core Tor/Tor]: Consider no longer calling routerlist_remove_old_routers() from check_descriptor_callback()

2018-12-12 Thread Tor Bug Tracker & Wiki
#27929: Consider no longer calling routerlist_remove_old_routers() from
check_descriptor_callback()
+
 Reporter:  rl1987  |  Owner:  (none)
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  implemented
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  nickm   |Sponsor:  Sponsor8-can
+
Changes (by nickm):

 * sponsor:   => Sponsor8-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28524 [Core Tor/Tor]: update control_free_all() for #27169

2018-12-12 Thread Tor Bug Tracker & Wiki
#28524: update control_free_all() for #27169
--+
 Reporter:  catalyst  |  Owner:  catalyst
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.5.1-alpha
 Severity:  Normal| Resolution:  fixed
 Keywords:  regression|  Actual Points:  0.1
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:  Sponsor8-can
--+
Changes (by nickm):

 * sponsor:   => Sponsor8-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28481 [Core Tor/Tor]: Tor's startup time is getting slower on Android

2018-12-12 Thread Tor Bug Tracker & Wiki
#28481: Tor's startup time is getting slower on Android
-+-
 Reporter:  akwizgran|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.4.9
 Severity:  Normal   | Resolution:
 Keywords:  android startup performance  |  Actual Points:
  controller |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by akwizgran):

 Results on Linux x86_64 are similar, although the device is much faster so
 all the times are scaled down:

 ||= Tor version =||= Min =||= Max =||
 ||0.2.9.16||0.29||0.51||
 ||0.2.9.17||0.30||0.44||
 ||0.3.0.1-alpha||0.64||0.88||
 ||0.3.1.1-alpha||0.73||0.95||
 ||0.3.2.1-alpha||0.88||1.05||
 ||0.3.3.1-alpha||0.85||1.37||
 ||0.3.4.1-alpha||0.77||9.46 (outlier)||
 ||0.3.4.8||0.88||1.18||
 ||0.3.4.9||0.99||1.50||
 ||0.3.5.5-alpha||0.54||0.75||

 There doesn't seem to be a corresponding change in CPU time (user or
 system). Any thoughts on what might be causing this, and whether we can
 expect it to get better or worse in future versions?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28755 [Core Tor/Tor]: Implement a K/V parser library

2018-12-12 Thread Tor Bug Tracker & Wiki
#28755: Implement a K/V parser library
--+
 Reporter:  dgoulet   |  Owner:  nickm
 Type:  enhancement   | Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .3
Parent ID:  #25502| Points:
 Reviewer:  ahf, dgoulet  |Sponsor:
--+
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:8 nickm]:
 > Okay, I think the branch is better now.  The leftovers are gone, it
 passes the tests you gave, and still passes the fuzzer.

 lgtm;

 But before merging, can you do a fixup that adds the test cases I added on
 the ticket that caught `AB=`?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23764 [Core Tor/Tor]: hs-v3: No live consensus on client with a bridge

2018-12-12 Thread Tor Bug Tracker & Wiki
#23764: hs-v3: No live consensus on client with a bridge
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224, technical-debt, |  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by dgoulet):

 Replying to [comment:14 teor]:
 > > The second big part would be in `hs_get_responsible_hsdirs()` which
 also requires a live consensus but also used by the service ... so some
 split to be done.
 >
 > No, services should also work with a reasonably live consensus.
 Otherwise, people running services on small devices with skewed clocks
 will be sad.

 To do such a feature, I would open two tickets for client and service
 side. They behave in very different ways and on the service side, the big
 piece of work would be unit testing by upgrading our *critical*
 reachability test case.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27299 [Core Tor/Tor]: hsv3: Clarify timing sources around hsv3 code

2018-12-12 Thread Tor Bug Tracker & Wiki
#27299: hsv3: Clarify timing sources around hsv3 code
-+-
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs hsv3 refactoring easy |  Actual Points:
  technical-debt |
Parent ID:  #23764   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by asn):

 Replying to [comment:5 ffmancera]:
 > Replying to [comment:3 asn]:
 > > > I saw that we are using `approx_time()` which is an alias of
 `time(NULL)`, but at the same time and in the same file, we are using
 both. As `approx_time.h` has different utilities for timing, we should use
 it instead of `time(NULL)`. What do you think?
 > > >
 > >
 > > Yes, I think we should be using `approx_time()` instead of
 `time(NULL)` everywhere. I don't see a reason not to.
 > >
 > > One of the problems with HS timing is that lots of the time sources
 come from the main event loop where `time(NULL)` is used.
 >
 > Then we should refactor all time resources, using only approx_time()
 over all the code right? I have a patch for this specific task. I will do
 a pull request if you are fine with that :-)

 You mean ALL over the codebase? Not sure how to evaluate the correctness
 of such a refactoring. Do you think there is a clear way to show that it
 does not break anything or change any behavior?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28808 [Core Tor/Tor]: Fuzzer to check for round-trip encoding/decoding on various types.

2018-12-12 Thread Tor Bug Tracker & Wiki
#28808: Fuzzer to check for round-trip encoding/decoding on various types.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  implemented
 Keywords:|  Actual Points:
Parent ID:  #28755| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  assigned => closed
 * resolution:   => implemented


Comment:

 Done as part of parent

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28755 [Core Tor/Tor]: Implement a K/V parser library

2018-12-12 Thread Tor Bug Tracker & Wiki
#28755: Implement a K/V parser library
--+
 Reporter:  dgoulet   |  Owner:  nickm
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  implemented
 Keywords:|  Actual Points:  .3
Parent ID:  #25502| Points:
 Reviewer:  ahf, dgoulet  |Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Added those in a0a3694fd16660911756eb1d38c9c0efc4a35334.

 Squashed and merged to master!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28661 [Core Tor/sbws]: Change http links to https in the documentation

2018-12-12 Thread Tor Bug Tracker & Wiki
#28661: Change http links to https in the documentation
---+---
 Reporter:  juga   |  Owner:  juga
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:  sbws: 1.0.x-final
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer:  nickm  |Sponsor:
---+---
Changes (by nickm):

 * status:  needs_review => merge_ready
 * reviewer:  mikeperry => nickm


Comment:

 These links all work for me.  Ready to merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28662 [Core Tor/sbws]: Change old broken links in the documentation

2018-12-12 Thread Tor Bug Tracker & Wiki
#28662: Change old broken links in the documentation
---+---
 Reporter:  juga   |  Owner:  juga
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:  sbws: 1.0.x-final
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer:  nickm  |Sponsor:
---+---
Changes (by nickm):

 * status:  needs_review => merge_ready
 * reviewer:  mikeperry => nickm


Comment:

 This all LGTM.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28525 [Core Tor/Tor]: Make tor_addr_is_internal_() aware of RFC 6598 (Carrier Grade NAT/Large Scale NAT) IPv4 Ranges

2018-12-12 Thread Tor Bug Tracker & Wiki
#28525: Make tor_addr_is_internal_() aware of RFC 6598 (Carrier Grade NAT/Large
Scale NAT) IPv4 Ranges
--+
 Reporter:  neel  |  Owner:  neel
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ipv6  |  Actual Points:
Parent ID:| Points:
 Reviewer:  nickm |Sponsor:
--+
Changes (by nickm):

 * status:  needs_review => needs_revision
 * reviewer:  mikeperry => nickm


Comment:

 This patch does what it is supposed to do.  It would be good to have a
 test.

 One problem here is that I'm not sure that this changed behavior is
 correct.  If you have an address inside a carrier NAT, you have the worst
 of both worlds: it is an address that the public internet cannot reach,
 but it is an address that other random people on your internet provider
 can still connect to.  In other words, these addresses are not useful
 enough to call them public, but not safe enough to call them private. So
 we need to treat these addresses as internal for the purpose of "can this
 address go onto the public tor network", but we need to treat them as non-
 internal for the purpose of "is it safe to have a socksport/extorport/etc
 here."

 The main purpose of the rest of my review here is to see what else we
 would need to change to make sure this change is safe.  I'm going to do
 this by looking at all the users of tor_addr_is_internal in the codebase.

* In warn_nonlocal_client_ports(), we will stop warning about binding a
 socksport to one of these addresses.  Is this a problem?  I need more
 guidance from others.
* In warn_nonlocal_ext_orports(), we will stop warning about binding an
 extorport to one of these addresses.  (same note as above)
* In connection_is_rate_limited(), we no longer count connections to or
 from one of these addresses as having any rate limits.
* In channeltls.c [which calls tor_addr_is_internal via
 is_local_addr()], we count any OR connections to these addresses as
 "local", which seems unwise.

 But all the other cases that I could find seemed like an improvement.

 Maybe what we need here is to replace the `for_listening` argument with a
 more general set of bitflags?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28823 [Applications/Tor Browser]: Every web page crashes on Windows 7 with Tor Browser 8

2018-12-12 Thread Tor Bug Tracker & Wiki
#28823: Every web page crashes on Windows 7 with Tor Browser 8
--+---
 Reporter:  testcy|  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-crash |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by testcy):

 I uninstalled Comodo Internet Security 11 and restarted my computer, but
 the results are exactly the same as above (if
 browser.tabs.remote.autostart is set to true then tabs crash and if
 browser.tabs.remote.autostart is set to false then Tor crashes).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28828 [Webpages/Website]: Change website to better handle multi-locale Android .apk

2018-12-12 Thread Tor Bug Tracker & Wiki
#28828: Change website to better handle multi-locale Android .apk
--+--
 Reporter:  gk|  Owner:  hiro
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by hiro):

 Hi GeKo,
 The download page is being redesigned. Have a look at this ticket:
 https://trac.torproject.org/projects/tor/ticket/24131#comment:4

 This is happening right now and it won't take too long before it will be
 online. You can already check out the staging for the new tp.o
 https://lektor-staging.torproject.org/tpo/staging
 The downloads pages aren't there just now but they will be in the next few
 days (or hours).
 Please have a look at the mocks and see if is this something that we can
 work with.

 Talk soon,
 -hiro

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28666 [Applications/Tor Browser]: Spellcheck wont work on TorBrowser Version 8.0.3 - Linux (64-Bit) for spanish laguange

2018-12-12 Thread Tor Bug Tracker & Wiki
#28666: Spellcheck wont work on TorBrowser Version 8.0.3 - Linux (64-Bit) for
spanish laguange
--+---
 Reporter:  CaptainCookie |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  spell check   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by CaptainCookie):

 Replying to [comment:4 gk]:

 > Replying to [comment:2 CaptainCookie]:
 >
 >
 > > > > Where do you click here exactly? Is that in some browser menu? I
 think I am not sure how to reproduce this problem.
 > > > >
 > > > >
 > >
 > > First install the spanish dictionary. Then go to a web site with a
 text box to type a message (I note this on twitter). Inside that text box
 make a right clic then a menu appears. In that menu in the "languages"
 submenu the spanish dictionary option should appears, but it don't and
 only shows the english option.
 > > [[Image(https://ibb.co/Z1xvCFd)]]
 > >
 > >
 >
 > This works for me, somewhat surprisingly:
 > [[Image(28666_en-US.png)]]
 >
 >
 >
 > > Next pic is to show that spanish dictionary is installed
 > > [[Image(https://ibb.co/54JZVVL)]]
 > >
 > >
 >
 > That's weird. How did you get your dictionary into the Extensions
 section? You should have it in an own Dictionaries section (as I have when
 testing that).

 For the last update (tor-browser-linux64-8.0.4 _en-US) dictionaries are
 working again. Don't forget that I started this ticket with 8.0.3 version.

 For Spanish version update you need to install dictionary manually to work
 since it does not come preinstalled.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28807 [Core Tor/DirAuth]: Ask authority operators to set `MaxAdvertisedBandwidth 0` in their torrcs

2018-12-12 Thread Tor Bug Tracker & Wiki
#28807: Ask authority operators to set `MaxAdvertisedBandwidth 0` in their 
torrcs
-+
 Reporter:  wagon|  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Core Tor/DirAuth |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, tor-dirauth, tor-bwauth  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by wagon):

 Replying to [comment:3 wagon]:
 > What forbids DA to become guard?
 I've recalled it. To earn Guard flag a node must have sufficiently high
 bandwidth. So, it seems low bandwidth value forbids authorities to become
 guards.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28779 [Core Tor/Tor]: Remove double function declarations in circuitpadding.c/test_circuitpadding.c

2018-12-12 Thread Tor Bug Tracker & Wiki
#28779: Remove double function declarations in
circuitpadding.c/test_circuitpadding.c
-+-
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:
  padding, technical-debt, refactor, easy|
Parent ID:  #28637   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by asn):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 LGTM! Closing this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28825 [Core Tor/Tor]: update to 8.04 causes immediate crash on MacOS 10.14.1

2018-12-12 Thread Tor Bug Tracker & Wiki
#28825: update to 8.04 causes immediate crash on MacOS 10.14.1
--+--
 Reporter:  gander2001|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Very High |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Blocker   | Resolution:
 Keywords:  tbb-crash |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by dgoulet):

 * milestone:   => Tor: unspecified


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28633 [Core Tor/Tor]: Pad on specific circuit purposes + ltups

2018-12-12 Thread Tor Bug Tracker & Wiki
#28633: Pad on specific circuit purposes + ltups
-+-
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:
  padding|
Parent ID:  #28632   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Code LGTM but the bitmask logic is non-trivial. Let's close this ticket
 after we get some unittests as well.

 I'm also wondering if we should test that `CIRCUIT_PURPOSE_MAX_` is less
 than 32 (which is the max state we can encode in the 32-bit bitfield).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28329 [Applications/Tor Browser]: Design TBA+Orbot configuration UI/UX

2018-12-12 Thread Tor Bug Tracker & Wiki
#28329: Design TBA+Orbot configuration UI/UX
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, ux-team, TBA-a3, |  Actual Points:
  TorBrowserTeam201812   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by antonela):

 * Attachment "userflow-2.png" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28329 [Applications/Tor Browser]: Design TBA+Orbot configuration UI/UX

2018-12-12 Thread Tor Bug Tracker & Wiki
#28329: Design TBA+Orbot configuration UI/UX
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, ux-team, TBA-a3, |  Actual Points:
  TorBrowserTeam201812   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by antonela):

 * Attachment "mockups-2.png" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28329 [Applications/Tor Browser]: Design TBA+Orbot configuration UI/UX

2018-12-12 Thread Tor Bug Tracker & Wiki
#28329: Design TBA+Orbot configuration UI/UX
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, ux-team, TBA-a3, |  Actual Points:
  TorBrowserTeam201812   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by antonela):

 * Attachment "mockups-2.png" removed.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28329 [Applications/Tor Browser]: Design TBA+Orbot configuration UI/UX

2018-12-12 Thread Tor Bug Tracker & Wiki
#28329: Design TBA+Orbot configuration UI/UX
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, ux-team, TBA-a3, |  Actual Points:
  TorBrowserTeam201812   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by antonela):

 * Attachment "mockups-2.png" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28358 [Core Tor/Tor]: Nyx forces Tor error: sandbox_getaddrinfo(): Bug: (Sandbox) failed to get address

2018-12-12 Thread Tor Bug Tracker & Wiki
#28358: Nyx forces Tor error: sandbox_getaddrinfo(): Bug: (Sandbox) failed to 
get
address
--+
 Reporter:  wagon |  Owner:  (none)
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.4.9
 Severity:  Normal| Resolution:
 Keywords:  sandbox   |  Actual Points:
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 Took the patch in and put it in `ticket28358_040_01`.

 (Did some modification to make it work on 0.4.0. It think it is nicely
 separated now, that Sandbox section was getting a bit cramped up.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28624 [Core Tor/Tor]: Should we remember dormant state on restart?

2018-12-12 Thread Tor Bug Tracker & Wiki
#28624: Should we remember dormant state on restart?
--+
 Reporter:  arma  |  Owner:  nickm
 Type:  enhancement   | Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-dormant   |  Actual Points:  1
Parent ID:| Points:  2
 Reviewer:  dgoulet   |Sponsor:  Sponsor8-can
--+
Changes (by dgoulet):

 * status:  needs_review => merge_ready
 * keywords:   => tor-dormant


Comment:

 lgtm!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28329 [Applications/Tor Browser]: Design TBA+Orbot configuration UI/UX

2018-12-12 Thread Tor Bug Tracker & Wiki
#28329: Design TBA+Orbot configuration UI/UX
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, ux-team, TBA-a3, |  Actual Points:
  TorBrowserTeam201812   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-

Comment (by antonela):

 Hello team, matt and I discussed yesterday what could be our users' best
 scenario when starting TBA.

 We think we can aim to bootstrap tor during the initial screen and then
 open about:tor.

 As you know, I'm working with a designer to have our
 [https://share.riseup.net/#gIizTI1iZRQu3Go2PHaSWA new icon animated], and
 we can use it as a loader while tor is bootstrapping. A progress bar is a
 good option too, but the right speed on the icon animation will make our
 users feel that it is loading faster.

 I updated the user flow, and I approached some mockups for this flow.

 What do you think?


 [[Image(https://trac.torproject.org/projects/tor/raw-
 attachment/ticket/28329/userflow-2.png, 700px)]]

 [[Image(https://trac.torproject.org/projects/tor/raw-
 attachment/ticket/28329/mockups-2.png, 700px)]]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28666 [Applications/Tor Browser]: Spellcheck wont work on TorBrowser Version 8.0.3 - Linux (64-Bit) for spanish laguange

2018-12-12 Thread Tor Bug Tracker & Wiki
#28666: Spellcheck wont work on TorBrowser Version 8.0.3 - Linux (64-Bit) for
spanish laguange
--+--
 Reporter:  CaptainCookie |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  TorBrowserTeam201812  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * keywords:  spell check => TorBrowserTeam201812
 * status:  needs_information => closed
 * resolution:   => fixed


Comment:

 Okay, so this actually seems to be a bug that got fixed in Firefox
 60.4.0esr. Maybe by https://bugzilla.mozilla.org/show_bug.cgi?id=1410214
 and related bugs, closing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28633 [Core Tor/Tor]: Pad on specific circuit purposes + ltups

2018-12-12 Thread Tor Bug Tracker & Wiki
#28633: Pad on specific circuit purposes + ltups
-+-
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:
  padding|
Parent ID:  #28632   | Points:
 Reviewer:  asn  |Sponsor:
-+-

Comment (by nickm):

 Replying to [comment:3 asn]:
 > Code LGTM but the bitmask logic is non-trivial. Let's close this ticket
 after we get some unittests as well.
 >
 > I'm also wondering if we should test that `CIRCUIT_PURPOSE_MAX_` is less
 than 32 (which is the max state we can encode in the 32-bit bitfield).

 FWIW, we now have a "CTASSERT" macro for compile-time assertions.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28358 [Core Tor/Tor]: Nyx forces Tor error: sandbox_getaddrinfo(): Bug: (Sandbox) failed to get address

2018-12-12 Thread Tor Bug Tracker & Wiki
#28358: Nyx forces Tor error: sandbox_getaddrinfo(): Bug: (Sandbox) failed to 
get
address
--+
 Reporter:  wagon |  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.4.9
 Severity:  Normal| Resolution:  fixed
 Keywords:  sandbox   |  Actual Points:
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Seems fine, merged to master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26630 [Core Tor/Tor]: Profile-driven work to reduce memory usage, focusing on clients and mobile.

2018-12-12 Thread Tor Bug Tracker & Wiki
#26630: Profile-driven work to reduce memory usage, focusing on clients and 
mobile.
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  035-roadmap-master, 035-triaged- |  Actual Points:
  in-20180711|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8-must
-+-
Changes (by arma):

 * sponsor:  Sponsor19-must => Sponsor8-must


Comment:

 I'm moving this ticket back to sponsor8, for the same reason as I moved
 #21814.

 This change doesn't mean anything about whether we should do it, just
 about whether it is critical-path to getting the anticensorship team back
 up and going.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28481 [Core Tor/Tor]: Tor's startup time is getting slower on Android

2018-12-12 Thread Tor Bug Tracker & Wiki
#28481: Tor's startup time is getting slower on Android
-+-
 Reporter:  akwizgran|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.4.9
 Severity:  Normal   | Resolution:
 Keywords:  android startup performance  |  Actual Points:
  controller |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * Attachment "tor-init-callgraphs-20181212.tar.bz2" added.


--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28481>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28481 [Core Tor/Tor]: Tor's startup time is getting slower on Android

2018-12-12 Thread Tor Bug Tracker & Wiki
#28481: Tor's startup time is getting slower on Android
-+-
 Reporter:  akwizgran|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.4.9
 Severity:  Normal   | Resolution:
 Keywords:  android startup performance  |  Actual Points:
  controller |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 Hm, interesting.  That result suggests that the problem is indeed CPU-
 based, if it scales that cleanly with with a faster CPU.  TBH that wasn't
 what I had expected; I had expected something far more complicated.

 In this case, a CPU profile would probably be useful.

 I've done a quick-and-dirty startup profile to try to track this down,
 using a hack branch called "exit_immediate" in my public repository.  It
 seems that the biggest offender in 0.3.5 is stuff under
 "router_reload_consensus_networkstatus".  It looks like we're spending our
 time re-parsing and re-validating stuff from storage.

 Can you confirm that your results are significantly slow if Tor starts
 with cached-* files?

 We already made some improvements here in 0.4.0, with #27225.  I think we
 can do better, though.

 I've made some callgraphs with perf, and I'm attaching them here. To make
 them I used my "exit_immediate" branch with:
 {{{
 perf record -g --call-graph dwarf ./src/app/tor -ExitImmediatly 1
 perf report -g --stdio > filename.callgraph
 }}}

 If my hunch is right, then we want to be looking for savings opportunities
 in the "with-cache" case for 0.4.0.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28481 [Core Tor/Tor]: Tor's startup time is getting slower on Android

2018-12-12 Thread Tor Bug Tracker & Wiki
#28481: Tor's startup time is getting slower on Android
-+-
 Reporter:  akwizgran|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.4.9
 Severity:  Normal   | Resolution:
 Keywords:  android startup performance  |  Actual Points:
  controller |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 To follow up: what would be most useful for me at this points is cpu
 profiling of tor on Android for this use case, if you can get that: I want
 to confirm that the hotspots on Android are the same as on my desktop.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28826 [Core Tor/Tor]: Explain appveyor image names

2018-12-12 Thread Tor Bug Tracker & Wiki
#28826: Explain appveyor image names
---+
 Reporter:  teor   |  Owner:  teor
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor   |Version:  Tor: 0.3.5.4-alpha
 Severity:  Normal | Resolution:
 Keywords:  comment, fast-fix  |  Actual Points:  0.1
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:
---+
Changes (by dgoulet):

 * status:  needs_review => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28833 [Applications]: The English installer does its work in Thai

2018-12-12 Thread Tor Bug Tracker & Wiki
#28833: The English installer does its work in Thai
+--
 Reporter:  howiem  |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Low |  Component:  Applications
  Version:  |   Severity:  Minor
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
 I live in Thailand. I just downloaded the 32/64bit English installerfrom
 here: https://www.torproject.org/projects/torbrowser.html.en#downloads

 I used this download link:
 https://www.torproject.org/dist/torbrowser/8.0.4/torbrowser-install-8.0
 .4_en-US.exe

 When I ran the installer the first screen is all in Thai and there is no
 place to change the language (I do read Thai) - see the attached image.

 I suppose this happens because my regional and language settings are  set
 to Thai, but although I am dual language capable, I prefer English.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28833 [Applications]: The English installer does its work in Thai

2018-12-12 Thread Tor Bug Tracker & Wiki
#28833: The English installer does its work in Thai
--+
 Reporter:  howiem|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:
Component:  Applications  |Version:
 Severity:  Minor | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by howiem):

 * Attachment "installer language bug.jpg" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28168 [Obfuscation/meek]: Use ESNI via Firefox HTTPS helper

2018-12-12 Thread Tor Bug Tracker & Wiki
#28168: Use ESNI via Firefox HTTPS helper
--+-
 Reporter:  dcf   |  Owner:  dcf
 Type:  project   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Obfuscation/meek  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-
Changes (by darkspirit):

 * cc: jan@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28834 [Core Tor]: I cannot enter in tor

2018-12-12 Thread Tor Bug Tracker & Wiki
#28834: I cannot enter in tor
--+--
 Reporter:  juliomolito   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Immediate |  Component:  Core Tor
  Version:  Tor: unspecified  |   Severity:  Blocker
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
 every time I try to enter in tor browser it says that tor is already
 running, but not responding, I don't know what to do. Plus I download the
 last version and my laptop is a windows 10.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28833 [Applications/Tor Browser]: The English installer does its work in Thai

2018-12-12 Thread Tor Bug Tracker & Wiki
#28833: The English installer does its work in Thai
--+--
 Reporter:  howiem|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Minor | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by sysrqb):

 * owner:  (none) => tbb-team
 * priority:  Low => Medium
 * component:  Applications => Applications/Tor Browser


Comment:

 Is Thai configured as your default language in windows?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #2878 [Core Tor/Tor]: Don't bootstrap from an old consensus if we're about to replace it

2018-12-12 Thread Tor Bug Tracker & Wiki
#2878: Don't bootstrap from an old consensus if we're about to replace it
-+-
 Reporter:  Sebastian|  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Major| Resolution:
 Keywords:  performance, bootstrap, tor-client,  |  Actual Points:
  s8-performance, s8-errors, 040-roadmap-|
  proposed   |
Parent ID:  #23605   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8-can
-+-

Comment (by arma):

 I think you're right that the microdesc part of this ticket is less
 relevant, in that we won't waste as much bandwidth now as we did in
 earlier designs.

 But here is one concrete issue that I expect still happens (and that is
 the issue in this ticket as originally described): you start your Tor, it
 makes circuits, it declares 100% success, and then it declares un-success
 (because it got the new consensus and that new consensus made us realize
 we don't have a threshold of the right microdescs yet), and it starts
 bootstrapping again. If it finishes bootstrapping right after that, all is
 fine, but what if it fails bootstrapping the second time, like because
 your directory guards don't have the new microdescs you just learned you
 want, or something else has gone wrong? Tor Browser will be happily
 showing you a browser window as if everything is working, when it isn't.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28654 [Core Tor/Tor]: Allow relays to serve future consensuses

2018-12-12 Thread Tor Bug Tracker & Wiki
#28654: Allow relays to serve future consensuses
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  bootstrap, clock-skew, tor-guard,|  Actual Points:
  usability, ux, s8-errors, 035-roadmap- |
  subtask, 035-triaged-in-20180711,  |
  s8-bootstrap   |
Parent ID:  #28591   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8-can
-+-
Changes (by catalyst):

 * sponsor:   => Sponsor8-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21805 [Applications/Tor Browser]: webgl is not blocked with a click-to-play button (was: webgl is blocked without a click-to-play button)

2018-12-12 Thread Tor Bug Tracker & Wiki
#21805: webgl is not blocked with a click-to-play button
-+-
 Reporter:  arthuredelstein  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, TorBrowserTeam201812  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by spanish):

 So, if you untick `webgl` as you do for `media`, then you can see click-
 to-play placeholder in http://webglsamples.org/aquarium/aquarium.html

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28833 [Applications/Tor Browser]: The English installer does its work in Thai

2018-12-12 Thread Tor Bug Tracker & Wiki
#28833: The English installer does its work in Thai
--+---
 Reporter:  howiem|  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Minor | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by gk):

 * status:  new => needs_information


Comment:

 Replying to [ticket:28833 howiem]:
 > I live in Thailand. I just downloaded the 32/64bit English installerfrom
 here: https://www.torproject.org/projects/torbrowser.html.en#downloads
 >
 > I used this download link:
 https://www.torproject.org/dist/torbrowser/8.0.4/torbrowser-install-8.0
 .4_en-US.exe
 >
 > When I ran the installer the first screen is all in Thai and there is no
 place to change the language (I do read Thai) - see the attached image.

 Actually, that's the second screen, the first let's you choose which
 language you want for the installer. It defaults to the locale of your
 system but offers you a drop-down box to select a different one instead.
 Does that not work for you?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28823 [Applications/Tor Browser]: Every web page crashes on Windows 7 with Tor Browser 8

2018-12-12 Thread Tor Bug Tracker & Wiki
#28823: Every web page crashes on Windows 7 with Tor Browser 8
--+---
 Reporter:  testcy|  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-crash |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by gk):

 Okay, let's figure out whether it could be one of our patches causing the
 problem here. Can you take the bundle from
 https://trac.torproject.org/projects/tor/ticket/27503#comment:17 and run
 it on your system? There are instruction on how to do so in that comment
 (the bundle gives you actually a Firefox without all of our Tor Browser
 patches to make sure the "baseline" is working on your system).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs