Re: [tor-bugs] #28940 [Obfuscation/Pluggable transport]: Add support for LOG to goptlib

[Tor Bug Tracker & Wiki]

#28940: Add support for LOG to goptlib
-+-
 Reporter:  dcf  |  Owner:  dcf
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/Pluggable transport  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  goptlib  |  Actual Points:
Parent ID:  #28180   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by dcf):

 Please also add examples of using the new feature to dummy-client and
 dummy-server, and to the long block comment at the top of pt.go. (Just one
 or two examples is fine, doesn't have to be comprehensive.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28940 [Obfuscation/Pluggable transport]: Add support for LOG to goptlib

[Tor Bug Tracker & Wiki]

#28940: Add support for LOG to goptlib
-+-
 Reporter:  dcf  |  Owner:  dcf
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/Pluggable transport  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  goptlib  |  Actual Points:
Parent ID:  #28180   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by dcf):

 * status:  assigned => needs_revision


Comment:

 Thanks for making this branch, ahf.

 First off: I'm really confused about the format of the LOG message. The
 discussion at #21879 and #28181 doesn't seem to have been updated after
 decisions got made on IRC. In addition to LOG, there's also STATUS? It
 would be nice if the format were in a spec, or at least in textual form in
 a ticket somewhere. Especially with regard to what byte values are allowed
 and which must be escaped, and how.

 Here's some quick review.
  *
 https://github.com/ahf/goptlib/commit/2d4cadf91f7da4fb43d8c1e85bb3c851fb660b0c
 (removing advice on how to spy on the stdout output stream) is
 inappropriate. The LOG feature does not replace this feature. While
 debugging, you might want to see for example CMETHOD line that won't just
 be logged verbatim by tor or whatever the controlling program is. And we
 won't be able to rely on the LOG feature for a long time yet.
  * I do not want goptlib to expose a `log.Logger` interface. That is a
 high-level application matter, not something for a low-level library like
 goptlib. If an application needs a `log.Logger`-compatible interface, it
 can write its own wrapper. I feel that there should be exactly one new
 exported function:\\
 {{{
 func Log(severity int, message string)
 }}}
plus appropriate constants for severities. This is a tiny new feature;
 it doesn't need a new source file.
  * Don't use names like `kvline_escape_value`. Use camel-case names as
 https://golang.org/doc/effective_go.html#mixed-caps
  * I don't want a full-fledged key–value encoding library if we don't need
 it. I would rather have `Log` defined as something like\\
 {{{
 line("LOG", "SEVERITY=" + encodeValue(severity), "MESSAGE=" +
 encodeValue(message))
 }}}
In the `encodeValue` helper function, don't do a check like
 `kvline_value_needs_escape`. Just escape everything always.
  * No need to
 [https://github.com/ahf/goptlib/commit/c70bebb95b2a9585a31013bbee74fecc593802ea
 #diff-8ab1b4d8f6dfb248d21e27a7fcfee762R29 call bytes.Buffer.Grow]. It will
 grow automatically as you write to it.
  * In the test code, please also test:
* Values containing `'\0'` (should panic?)
* Values containing bytes >= `'\x80'` (e.g. UTF-8) (should panic?)
* Values containing `'='`
* Empty string
  Unfortunately, per https://spec.torproject.org/pt-spec Section 3.3, we
 are limited to US-ASCII minus `'\x00'` and `'\n'` in ''all'' PT output
 lines, so we need to test what happens when that is violated, even if the
 KV quoted string output allows other values.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28940 [Obfuscation/Pluggable transport]: Add support for LOG to goptlib

[Tor Bug Tracker & Wiki]

#28940: Add support for LOG to goptlib
-+--
 Reporter:  dcf  |  Owner:  dcf
 Type:  enhancement  | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/Pluggable transport  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  goptlib  |  Actual Points:
Parent ID:  #28180   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by dcf):

 * owner:  asn => dcf
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28940 [Obfuscation/Pluggable transport]: Add support for LOG to goptlib

[Tor Bug Tracker & Wiki]

#28940: Add support for LOG to goptlib
-+-
 Reporter:  dcf  |  Owner:  asn
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/Pluggable transport  |Version:
 Severity:  Normal   |   Keywords:  goptlib
Actual Points:   |  Parent ID:  #28180
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 see:
  * #28179 (code changes)
  * #28181 (pt-spec changes) ''[doesn't seem to be committed yet?]''

 ahf made a branch here:
 https://github.com/ahf/goptlib/commits/features/logging

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28936 [Obfuscation/Pluggable transport]: Use Travis CI for goptlib.git repositories on Github

[Tor Bug Tracker & Wiki]

#28936: Use Travis CI for goptlib.git repositories on Github
-+-
 Reporter:  ahf  |  Owner:  dcf
 Type:  enhancement  | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Obfuscation/Pluggable transport  |Version:  Tor:
 |  unspecified
 Severity:  Minor| Resolution:
 Keywords:  tor-pt goptlib   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  dcf  |Sponsor:  Sponsor19
-+-
Changes (by dcf):

 * owner:  asn => dcf
 * keywords:  tor-pt => tor-pt goptlib
 * status:  needs_review => assigned


Comment:

 Thanks for doing this. I am skeptical of this, partly because of an
 aversion to dotfile cruft but also because I don't want to add new
 dependency on GitHub (which, let's not forget, is ''f*‍*‍*ing
 Microsoft'').

 In any case, I don't think that reporting to #tor-ci is appropriate for
 other people's forks that don't necessarily have to do with Tor.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26888 [Core Tor/Torsocks]: torsocks: --quiet option

[Tor Bug Tracker & Wiki]

#26888: torsocks: --quiet option
-+---
 Reporter:  ilf  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_information
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Torsocks|Version:
 Severity:  Normal   | Resolution:
 Keywords:  torsocks, quiet, option  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---
Changes (by onirony):

 * status:  new => needs_information


Comment:

 What version of Torsocks are you using? The current source code at
 https://gitweb.torproject.org/torsocks.git/tree/ supports the -q/--quiet
 option. The man page that came with torsocks when I install it via brew
 also says the following:


 {{{
-q, --quiet
   Suppress every log messages [sic] (even errors).
 }}}

 For some reason, when I just enter the torsocks command on the terminal
 this option isn't presented with all the others, even though it exists and
 is documented in the man page (not sure if there's a reason, to me it
 seems like it should appear with all the rest of the options).

 Anyway, using -q sets a variable within torsocks called
 {{{TORSOCKS_LOG_LEVEL}}} to 1. Torsocks checks this variable before
 outputting errors. The lower the level, the more conservative Torsocks is
 about logging. 1 (quiet mode) is the lowest level. The highest level is 5,
 which is set via the -d/--debug option.

 What system are you on and how did you install torsocks? If you installed
 it using a package manager it's possible they provide a version that
 predates the -q option. If that's the case, torsocks is pretty easy to
 build yourself by cloning the git repo
 (https://gitweb.torproject.org/torsocks.git/tree/) and following the
 instructions here:
 https://gitweb.torproject.org/torsocks.git/tree/README.md

 If it is the case that your package manager gave you a torsocks that lacks
 -q I'll bug the repository maintainers to use a newer version so that
 others don't have to go through this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28939 [Core Tor]: Fix buffer overflow in src/test/test_voting_flags.c

[Tor Bug Tracker & Wiki]

#28939: Fix buffer overflow in src/test/test_voting_flags.c
--+--
 Reporter:  kjak  |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Core Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by kjak):

 * status:  new => needs_review


Comment:

 PR: https://github.com/torproject/tor/pull/620

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28939 [Core Tor]: Fix buffer overflow in src/test/test_voting_flags.c

[Tor Bug Tracker & Wiki]

#28939: Fix buffer overflow in src/test/test_voting_flags.c
+--
 Reporter:  kjak|  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Component:  Core Tor
  Version:  |   Severity:  Normal
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
 In `setup_cfg()` in src/test/test_voting_flags.c a memset is used to write
 `DIGEST256_LEN` (32) bytes into `signed_descriptor_digest` of length
 `DIGEST_LEN` (20).

 I see 12 bytes of the previously-filled `identity_digest` being
 overwritten.

 PR to follow.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28938 [Core Tor]: Fix incorrect OpenBSD macro tests (fix testsuite failure)

[Tor Bug Tracker & Wiki]

#28938: Fix incorrect OpenBSD macro tests (fix testsuite failure)
--+--
 Reporter:  kjak  |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Core Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by kjak):

 * status:  new => needs_review


Comment:

 PR: https://github.com/torproject/tor/pull/619

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28938 [Core Tor]: Fix incorrect OpenBSD macro tests (fix testsuite failure)

[Tor Bug Tracker & Wiki]

#28938: Fix incorrect OpenBSD macro tests (fix testsuite failure)
+--
 Reporter:  kjak|  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Component:  Core Tor
  Version:  |   Severity:  Normal
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
 The testsuite has been failing on OpenBSD, but an upcoming PR will fix
 this.

 It was previously decided (ticket #20980) that the `OpenBSD` macro would
 be used to test for OpenBSD (rather than `__OpenBSD__`, etc.) because the
 former seems to be defined on OpenBSD forks when the latter may or may not
 be.

 However, `sys/param.h` needs to be included for this macro to be defined.
 There were many files where `OpenBSD` was tested for, but when
 `sys/param.h` was not included.

 An upcoming PR will contain a fix to include `sys/param.h` in the files
 where the `OpenBSD` macro is used (when it is not included already).  It
 will also change a couple of instances of the `__OpenBSD__` macro to
 `OpenBSD`.

 See commit 27df23abb675ffeb198bf0c1cc85c4baed77a988 where the usage of
 `__OpenBSD__` and `OPENBSD` macros were replaced with `OpenBSD`.

 See also tickets #6982 and #20980 where the various macros were discussed.
 The latter ticket is where it was decided to use the `OpenBSD` macro.


 I tested on this box:

 {{{
 $ uname -mrs
 OpenBSD 6.4 amd64
 }}}


 Before:

 {{{
 =
tor 0.4.0.0-alpha-dev: ./test-suite.log
 =

 # TOTAL: 20
 # PASS:  15
 # SKIP:  4
 # XFAIL: 0
 # FAIL:  1
 # XPASS: 0
 # ERROR: 0

 

 options/validate__transproxy: [forking]
   FAIL src/test/test_options.c:1164: assert(tdata)
   [validate__transproxy FAILED]

 
 }}}

 ...and after:

 {{{
 =
tor 0.4.0.0-alpha-dev: ./test-suite.log
 =

 # TOTAL: 20
 # PASS:  16
 # SKIP:  4
 # XFAIL: 0
 # FAIL:  0
 # XPASS: 0
 # ERROR: 0
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28920 [Core Tor/Tor]: rep_hist_log_link_protocol_counts() only knows about 4 link protocols, but Tor has 5

[Tor Bug Tracker & Wiki]

#28920: rep_hist_log_link_protocol_counts() only knows about 4 link protocols, 
but
Tor has 5
+
 Reporter:  teor|  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor|Version:  Tor: 0.3.1.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  easy, fast-fix  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+

Comment (by rl1987):

 https://github.com/torproject/tor/pull/618/files

 Note that calling `log_notice()` in each loop iteration would break some
 testcases in test_status.c.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28920 [Core Tor/Tor]: rep_hist_log_link_protocol_counts() only knows about 4 link protocols, but Tor has 5

[Tor Bug Tracker & Wiki]

#28920: rep_hist_log_link_protocol_counts() only knows about 4 link protocols, 
but
Tor has 5
+
 Reporter:  teor|  Owner:  (none)
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor|Version:  Tor: 0.3.1.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  easy, fast-fix  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+
Changes (by rl1987):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28805 [Core Tor/Tor]: ControlPort has undocumented behavior

[Tor Bug Tracker & Wiki]

#28805: ControlPort has undocumented behavior
+--
 Reporter:  wagon   |  Owner:  (none)
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor|Version:  Tor: 0.3.4.9
 Severity:  Normal  | Resolution:
 Keywords:  tor-control, easy, tor-doc  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by rl1987):

 * status:  new => needs_review


Comment:

 https://github.com/torproject/tor/pull/617

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28895 [Core Tor/Tor]: "Your guard" log messages are causing confusion

[Tor Bug Tracker & Wiki]

#28895: "Your guard" log messages are causing confusion
--+--
 Reporter:  asn   |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-guard, tor-log, easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by rl1987):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28895 [Core Tor/Tor]: "Your guard" log messages are causing confusion

[Tor Bug Tracker & Wiki]

#28895: "Your guard" log messages are causing confusion
--+--
 Reporter:  asn   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-guard, tor-log, easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by rl1987):

 https://github.com/torproject/tor/pull/616/files

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28937 [Applications/Tor Browser]: Tor Browser 8.0.4 only warns the user if it's MAXIMIZED, WHILE it's running.

[Tor Bug Tracker & Wiki]

#28937: Tor Browser 8.0.4 only warns the user if it's MAXIMIZED, WHILE it's
running.
-+-
 Reporter:  ArenaL5  |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Component:  Applications/Tor
 |  Browser
  Version:   |   Severity:  Normal
 Keywords:  Tor Browser, screen  |  Actual Points:
  size   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
 ''Please rewrite the title and metadata, it's not very clear as it's
 written right now.''

 ''Priority medium because the users affected by this are precisely the
 ones using non-standard configurations.''

 If the user maximizes Tor Browser while it's running, Tor Browser will
 display a warning recommending them to honor the default window size.

 Some window managers override this default size (like
 [https://github.com/awesomeWM/awesome/issues/2504 Awesome], although
 they're looking at it) and Tor Browser can't detect this.

 It also doesn't warn the user if they resize the window manually. While
 this looks like a lesser risk, it's possible the user resizes it to
 approximately fill the screen, or uses a system outside of the window
 manager (and, through it, fools Tor Browser).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28859 [Metrics/ExoneraTor]: Use Java 8 date-time functionality in ExoneraTor

[Tor Bug Tracker & Wiki]

#28859: Use Java 8 date-time functionality in ExoneraTor
+-
 Reporter:  karsten |  Owner:  karsten
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:
Component:  Metrics/ExoneraTor  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  #23752  | Points:
 Reviewer:  irl |Sponsor:
+-
Changes (by irl):

 * status:  needs_review => merge_ready


Comment:

 Ok. I think this is somewhat like UTF-8 encoding/decoding in that we
 should be explicit whenever times come into and leave the application that
 they are converted to "local" time where this is the local time for the
 application, and for our use this will always be UTC. Let's just watch out
 for this.

 The patch looks good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28841 [Core Tor/Tor]: Write tool for onion service health assesment

[Tor Bug Tracker & Wiki]

#28841: Write tool for onion service health assesment
--+
 Reporter:  asn   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor:
  |  unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs reachability research  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by rl1987):

 * cc: rl1987 (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28806 [Core Tor/Tor]: checkIncludes.py does not like code in src/ext/timeouts

[Tor Bug Tracker & Wiki]

#28806: checkIncludes.py does not like code in src/ext/timeouts
--+--
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by rl1987):

 * priority:  Medium => Low


Comment:

 These are just warnings, but it seems mentioned lines of
 src/ext/timeouts/.may_include do not match any of the following regular
 expressions:
 {{{
  54 ALLOWED_PATTERNS = [
  55 re.compile(r'^.*\*\.(h|inc)$'),
  56 re.compile(r'^.*/.*\.h$'),
  57 re.compile(r'^ext/.*\.c$'),
  58 re.compile(r'^orconfig.h$'),
  59 re.compile(r'^micro-revision.i$'),
  60 ]
 }}}

 What should we do? Add one or more entries to this list? I would like to
 hear from Nick or someone else who worked on checkIncludes script.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28801 [Metrics/Statistics]: Rewrite advbwdist's aggregate.R in Java

[Tor Bug Tracker & Wiki]

#28801: Rewrite advbwdist's aggregate.R in Java
+-
 Reporter:  karsten |  Owner:  karsten
 Type:  enhancement | Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Metrics/Statistics  |Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  irl |Sponsor:
+-
Changes (by karsten):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Thanks for looking! Merged and deployed. Closing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs