Re: [tor-bugs] #29051 [Applications/Tor Browser]: backport 1446472 - privacy.resistFingerprinting is true blocks QR code (canvas) on web.whatsapp.com without any notice

2019-01-11 Thread Tor Bug Tracker & Wiki
#29051: backport 1446472 - privacy.resistFingerprinting is true blocks QR code
(canvas) on web.whatsapp.com without any notice
--+
 Reporter:  pospeselr |  Owner:  pospeselr
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  worksforme
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by gk):

 Replying to [comment:2 tom]:
 > This ticket is probably still valid, I hope that this improvement is
 enough for Tor to consider flipping it back to 'true'. (Which I think is a
 better overall experience, even if it does make WhatsApp more confusing?)

 Not sure in which sense it is still valid but the flip back should be
 handled by #29028.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28874 [Applications/Tor Browser]: https://browserleaks.com/webgl crashes tab on 64bit Tor Browser for Windows

2019-01-11 Thread Tor Bug Tracker & Wiki
#28874: https://browserleaks.com/webgl crashes tab on 64bit Tor Browser for 
Windows
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-crash, tbb-rbm,  |  Actual Points:
  TorBrowserTeam201901R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-crash, TorBrowserTeam201901 => tbb-crash, tbb-rbm,
 TorBrowserTeam201901R
 * status:  needs_information => needs_review


Comment:

 Replying to [comment:15 jacek]:
 > D3DCOMPILER_DLL define is fixed in upstream mingw-w64 now. I recall that
 some declarations also vary between d3dcompiler versions, so if similar
 problems persist, it might be good place to look.

 Thanks! It seems we are fine for now by just bumping the mingw-w64 commit
 we use (see the test results in comment:32:ticket:28823 compared to
 comment:28:ticket:28823). `bug_28874`
 (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_28874&id=5e875c30e825bd726558a3b9fea63b59d2a80d15)
 has the respective patch for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28823 [Applications/Tor Browser]: Every web page crashes on Windows 7 with Tor Browser 8

2019-01-11 Thread Tor Bug Tracker & Wiki
#28823: Every web page crashes on Windows 7 with Tor Browser 8
--+---
 Reporter:  testcy|  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-crash |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by gk):

 Replying to [comment:32 testcy]:
 > First time I run the above build it crashed before starting. I then
 cleaned the TEMP folder, tried again and it did not crash, but it was
 taking for ever to connect. I canceled and tried a few times until it
 connected. While browsing one of the pages that tab was crashing with
 previous build, this time it did not crash, but a NoScript XSS Warning
 appeared asking how to proceed. I also continue seeing various warnings in
 the log as for example WARNING: NS_ENSURE_SUCCESS.

 That's fine. So, even though the build is terribly slow it is working for
 you without any crashes? What about the following non-debug build then:

 https://people.torproject.org/~gk/testbuilds/torbrowser-install-win64-tbb-
 nightly_28823_4en-US.exe
 https://people.torproject.org/~gk/testbuilds/torbrowser-install-win64-tbb-
 nightly_28823_4en-US.exe.asc

 (the XSS warning popup is annoying and confusing but nothing to worry
 about in this bug context.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28716 [Applications/Tor Browser]: Create a mingw-w64-clang project

2019-01-11 Thread Tor Bug Tracker & Wiki
#28716: Create a mingw-w64-clang project
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901,   |  Actual Points:
  GeorgKoppen201901  |
Parent ID:  #28238   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:14 tom]:
 > Replying to [comment:13 gk]:
 > > I've updated `bug_28716_v2` to add the changes coming with bug 1506450
 and rebased `bug_28238_v2` on top of it (after adding the mozconfig
 changes due to the fix for 1506450). 64bit is still compiling fine, I am
 looking into the header path issue for 32bit.
 > >
 > > FWIW: I have not patched our Firefox related build instructions so
 that they bundle the urct dlls instead of msvcr100 yet. That will happen
 in #28238.
 >
 > I built
 
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c7ca3a0df8ec659bbe75322bea4ab296a91a1c50
 with the toolchain from this comment.
 >
 > It builds on top of d90df493b2ecb5267009789a47559ebe534d9d87 from above
 and includes these two patches:
 > https://hg.mozilla.org/try/rev/9857214ebf6b (use your toolchain)
 > https://hg.mozilla.org/try/rev/00a398b1fa4d4c79cf5651635bed03049378b0b2
 (disable check_nsmodules because your toolchain doesn't contain a llvm-
 readelf -> x86_64-blah-readelf symlink which is needed for this)
 >
 > I tested the x64 opt build; and it runs and loaded a few websites.

 That's on Windows 10, right? I tested the artifact
 
(https://queue.taskcluster.net/v1/task/X5K6N8O8SMqb9RarbIrp2w/runs/0/artifacts/public/build/target.zip)
 on Windows 7 and it seems to crash early on. I have not looked closer why
 but I noticed that firefox.exe etc. is still linked against msvcrt.dll
 which is not working for Windows 7. So, we need to teach the toolchain
 again how to link against a non-default runtime lib (ucrt this time) which
 has always been a fun exercise...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28142 [Core Tor/Tor]: Merge original WTF-PAD branch

2019-01-11 Thread Tor Bug Tracker & Wiki
#28142: Merge original WTF-PAD branch
-+-
 Reporter:  asn  |  Owner:
 |  mikeperry
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:
  padding|
Parent ID:  #28631   | Points:
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-

Comment (by asn):

 I pushed a few more commits to `adaptive_padding-final` that Riastradh
 authored to improve the prob distr codebase (it now does type checking on
 the distr macros) and fix a bug and some compilation issues.

 I'm still unsure how to handle the monotime issue because I'm not sure
 what's acceptable in terms of timing accuracy and overhead. Mike has some
 questions on IRC for you Nick.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28989 [Core Tor/Tor]: test_hs_service: CID 1442277: Resource leaks (RESOURCE_LEAK)

2019-01-11 Thread Tor Bug Tracker & Wiki
#28989: test_hs_service: CID 1442277:  Resource leaks  (RESOURCE_LEAK)
-+
 Reporter:  asn  |  Owner:  rl1987
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs coverity  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 LGTM

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28870 [Core Tor/sbws]: Stop asserting when there's not a descriptor for a relay being measured

2019-01-11 Thread Tor Bug Tracker & Wiki
#28870: Stop asserting when there's not a descriptor for a relay being measured
---+---
 Reporter:  juga   |  Owner:  (none)
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:  sbws: 1.0.x-final
Component:  Core Tor/sbws  |Version:  sbws: 1.0.2
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #28663 | Points:
 Reviewer:  asn|Sponsor:
---+---
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 `ac9406a` LGTM.

 `02bb2f5` also LGTM, but as a nitpick IMO it's a bit sneaky to call this a
 'rename' since a rename implies that there is no behavior change, whereas
 that commit actually fixes a bug IIUC. I guess this bug went undetected
 due to the lack of strong typing in Python and no unittests walking over
 it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28669 [Core Tor/Tor]: Bug: ../src/feature/hs/hs_client.c:280: retry_all_socks_conn_waiting_for_desc

2019-01-11 Thread Tor Bug Tracker & Wiki
#28669: Bug: ../src/feature/hs/hs_client.c:280:
retry_all_socks_conn_waiting_for_desc
--+
 Reporter:  traumschule   |  Owner:  (none)
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs|  Actual Points:
Parent ID:| Points:
 Reviewer:  asn   |Sponsor:
--+
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 Let's call this merge_ready since it fixes the issue and the patch looks
 legit.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29004 [Core Tor/Tor]: PrivCount proof of concept: implement check counters

2019-01-11 Thread Tor Bug Tracker & Wiki
#29004: PrivCount proof of concept: implement check counters
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 040-unreached-20190109,   |  Actual Points:  0.4
  041-proposed-on-roadmap|
Parent ID:  #27908   | Points:  1
 Reviewer:  asn  |Sponsor:
-+-
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 Patch looks really nice and tidy!

 Not sure how the TODOs are meant to be addressed, but what I'm seeing
 looks good!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29003 [Applications/Tor Browser]: Create Go PT Bundle Project

2019-01-11 Thread Tor Bug Tracker & Wiki
#29003: Create Go PT Bundle Project
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, TBA-a3, tor-|  Actual Points:
  pt, TorBrowserTeam201901   |
Parent ID:  #28803   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * priority:  Medium => High


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28780 [Core Tor/Tor]: circpadding: Add machine flag for not closing circuit if machine is active

2019-01-11 Thread Tor Bug Tracker & Wiki
#28780: circpadding: Add machine flag for not closing circuit if machine is 
active
-+-
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:
  padding|
Parent ID:  #28632   | Points:
 Reviewer:  mikeperry|Sponsor:
-+-
Changes (by asn):

 * status:  needs_revision => merge_ready


Comment:

 I pushed Mike's latest branch here so that CI runs:
 https://github.com/torproject/tor/pull/644

 I'm OK with the purpose-based approach, but now I see that we are using
 both my "special flag" and also the "special purpose" so we moved from one
 special thing to two. In this case, can you please motivate the new
 purpose further in the docs of `CIRCUIT_PURPOSE_C_CIRCUIT_PADDING`. IIUC,
 the new purpose is so that Tor does not attach
 new streams to the circuit, or are there more reasons?

 If that's the only reason, perhaps it would be wise to ask feedback from
 Nick to see if a new purpose is the best way to achieve that goal.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28780 [Core Tor/Tor]: circpadding: Add machine flag for not closing circuit if machine is active

2019-01-11 Thread Tor Bug Tracker & Wiki
#28780: circpadding: Add machine flag for not closing circuit if machine is 
active
-+-
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:
  padding|
Parent ID:  #28632   | Points:
 Reviewer:  mikeperry|Sponsor:
-+-
Changes (by asn):

 * status:  merge_ready => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26242 [Applications/Tor Browser]: Implement update strategy for TBA

2019-01-11 Thread Tor Bug Tracker & Wiki
#26242: Implement update strategy for TBA
-+-
 Reporter:  igt0 |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201901   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-

Comment (by gk):

 Some good material (with further links) in case we want to set up and own
 F-Droid repo: https://github.com/TeamNewPipe/NewPipe/issues/1981.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29044 [Applications/Tor Browser]: elements' rendering is slightly delayed (was: NoScript does not seem to disable JavaScript on loading properly)

2019-01-11 Thread Tor Bug Tracker & Wiki
#29044:  elements' rendering is slightly delayed
+--
 Reporter:  gk  |  Owner:  tbb-team
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:  wontfix
 Keywords:  TorBrowserTeam201901, noscript  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by ma1):

 * status:  new => closed
 * priority:  Very High => Medium
 * resolution:   => wontfix


Comment:

 That's expected, even if slightly annoying, and as noted '''no JavaScript
 runs''' anyway.

 NoScript 5.x, by using the available XPCOM APIs, could override the
 browser's maximum priority stylesheet which enforces a
 {{{
 noscript {
   display: none !important;
 }
 }}}
 rule, hiding and disabling all the  elements pre-emptively in
 every docshell where JavaScript is enabled.
 WebExtensions lack this overriding power, so now we must work-around with
 a hack: in order to render NOSCRIPT elements on pages where NoScript 10.x
 disables scripting (by using CSP, which doesn't trigger the brower's
 "JavaScript disabled" HTML parsing code path),
 
[https://github.com/hackademix/noscript/blob/c0956b20b90e5b57ead30c783c5b102408a1190a/src/content/onScriptDisabled.js#L4
 we need to replace them] with  elements unaffected by the browser's
 enforced styling '''after they're inserted in the DOM''', therefore the
 delay.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #10760 [Applications/Tor Browser]: Integrate TorButton to TorBrowser core to prevent users from disabling them (was: Integrate TorButton and TorLauncher to TorBrowser core to prevent us

2019-01-11 Thread Tor Bug Tracker & Wiki
#10760: Integrate TorButton to TorBrowser core to prevent users from disabling 
them
--+--
 Reporter:  Rezonansowy   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201901  |  Actual Points:
Parent ID:  #24855| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * cc: igt0 (added)
 * keywords:  needs-triage => TorBrowserTeam201901


Comment:

 That's the ticket for Torbutton now. The one for Tor Launcher is #28044.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26148 [Applications/Tor Browser]: Update binutils to a version more recent than 2.26.1

2019-01-11 Thread Tor Bug Tracker & Wiki
#26148: Update binutils to a version more recent than 2.26.1
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901,   |  Actual Points:
  boklm201811|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 I have been building using `-Wl,-t` two times on one machine, and one time
 on an other one. The builds from the same machine were identical, but
 different on the second machine.

 Comparing the logs from the non maching builds, the main difference was
 the order of `.o` files included inside `libstdc++.a`. It seems that with
 previous versions of binutils, the order of objects inside a `.a` file did
 not affect the output, but it is not the case anymore with more recent
 versions of binutils.

 The reason why `libstdc++.a` is including objects in random order is that
 gcc is using an old version of libtool:
 https://gcc.gnu.org/ml/gcc-patches/2018-06/msg01115.html

 With the libtool patch sorting the output of `find`, I am now able to get
 matching builds on different machines.

 I am now testing a patch to update binutils to 2.31.1.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25702 [Applications/Tor Browser]: Activity 1.1 Update Tor Browser icon to follow design guidelines.

2019-01-11 Thread Tor Bug Tracker & Wiki
#25702: Activity 1.1 Update Tor Browser icon to follow design guidelines.
-+-
 Reporter:  isabela  |  Owner:
 |  antonela
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team, tbb-mobile, |  Actual Points:
  TorBrowserTeam201901R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor17
-+-

Comment (by gk):

 Could you rebase your patches against latest `tor-browser-60.4.0esr-8.5-1`
 and squash them where you see fit?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29035 [Applications/Tor Browser]: Post-YE campaign clean up

2019-01-11 Thread Tor Bug Tracker & Wiki
#29035: Post-YE campaign clean up
--+--
 Reporter:  pili  |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Minor | Resolution:
 Keywords:  TorBrowserTeam201901  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by antonela):

 Replying to [comment:4 gk]:
 > That's for the old newsletter sign-up work. Did you mean to add a new
 pull request? Or did you mean we should essentially use the code there and
 just replace icons? Or...?

 Yes, is the same. We can use that code and if we want the icon, just add
 the icon.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29050 [Core Tor/Torsocks]: Connecting to tor over a socks 5 connection no longer works in 3.5.7

2019-01-11 Thread Tor Bug Tracker & Wiki
#29050: Connecting to tor over a socks 5 connection no longer works in 3.5.7
---+---
 Reporter:  arj|  Owner:  dgoulet
 Type:  defect | Status:  needs_information
 Priority:  Medium |  Milestone:
Component:  Core Tor/Torsocks  |Version:  Tor: 0.3.5.7
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---

Comment (by arj):

 Oh, thanks for your reply. It appears that the debian repo
 https://www.torproject.org/docs/debian.html.en does not include torsocks
 but only tor. And the new 0.3.5.7 is not compatible with torsocks 2.2. I
 can see that debian unstable includes a new version of torsocks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29054 [Core Tor/Tor]: prop224: Implement offline keys for v3 onion services

2019-01-11 Thread Tor Bug Tracker & Wiki
#29054: prop224: Implement offline keys for v3 onion services
--+--
 Reporter:  s7r   |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: 0.3.5.7
 Severity:  Normal|   Keywords:  prop224, tor-hs
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 Prop224 is designed to support offline master keys for v3 onion services,
 a great functionality that has many advantages and becomes more and more
 discussed in threat models. Logging this ticket now to keep track of it,
 even if it's not urgent at the moment.

 This is what seams to be needed at first look (might end up as child
 tickets to this one):

 1. Implement temporary keys + certificates signed by master onion service
 key with limited validity for v3 onion services.

 2. Implement a small utility tool in Tor so that users can create such
 onion service keys offline, similar to `tor --keygen` for relays, with a
 secondary argument of `--keylifetime` which defaults to 30 days but can be
 changed to any value user prefers.

 3. Implement torrc option `HiddenServiceOfflineKey 0|1` (that defaults to
 0) so Tor will know it must not try to generate the onion service master
 key if missing from disk, or even look for it.

 ''Most of the logic and behavior from ed25519 offline master key for
 relays should be applied at these first 3 points as well.''

 4. Implement mnemonic seed backup for onion service master key, so the
 same private key can be restored using a string of words that produce the
 same parameters for the curve. This is simple and widely
 tested/implemented for secp256k1, and implementing for our needs and
 threat model is simple and totally worth it from user experience
 perspective.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28684 [Core Tor/sbws]: Make sbws easy to understand and maintain

2019-01-11 Thread Tor Bug Tracker & Wiki
#28684: Make sbws easy to understand and maintain
---+---
 Reporter:  juga   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws: unspecified
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---

Comment (by irl):

 The output of the parser for stem should be a Python object. Take a look
 at the ServerDescriptor class for an example:

 
https://stem.torproject.org/api/descriptor/server_descriptor.html#stem.descriptor.server_descriptor.RelayDescriptor

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26148 [Applications/Tor Browser]: Update binutils to a version more recent than 2.26.1

2019-01-11 Thread Tor Bug Tracker & Wiki
#26148: Update binutils to a version more recent than 2.26.1
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901,   |  Actual Points:
  boklm201811|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by ld):

 Replying to [comment:8 boklm]:
 > with previous versions of binutils, the order of objects inside a `.a`
 file did not affect the output, but it is not the case anymore with more
 recent versions of binutils.
 Bug or feature for you?
 > I am now testing a patch to update binutils to 2.31.1.
 Please test with the master branch instead, because of
 https://sourceware.org/ml/binutils/2019-01/msg00013.html and to avoid
 issues like https://sourceware.org/bugzilla/show_bug.cgi?id=23600.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29055 [Core Tor/Tor]: Add synonym OnionService* to HiddenService* torrc options

2019-01-11 Thread Tor Bug Tracker & Wiki
#29055: Add synonym OnionService* to HiddenService* torrc options
--+--
 Reporter:  s7r   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: 0.3.5.7
 Severity:  Normal|   Keywords:  tor-hs, doc, manpage
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 We started referring as OnionService instead of HiddenService, would it
 make sense to make `OnionService*` torrc parameter synonym to
 `HiddenService*` for all torrc options, so that one can use:

 {{{
 OnionServiceDir /var/lib/tor/my-web-page
 OnionServicePort 80 127.0.0.1:80
 OnionServiceVersion 3
 }}}

 `HiddenService*` parameters will of course still work, and continue to do
 so, in order not to break any existing torrc config files. Then we can
 simply update the manual, if we want to ditch the '''HiddenService'''
 code-name.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29029 [Core Tor/Tor]: Make "tried to establish rendezvous on non-OR circuit" into a protocol warning

2019-01-11 Thread Tor Bug Tracker & Wiki
#29029: Make "tried to establish rendezvous on non-OR circuit" into a protocol
warning
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.5.7-rc
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, fast-fix, 041-proposed-  |  Actual Points:  0.2
  fast-fix, 040-proposed-fast-fix,   |
  040-backport, 035-backport, 034-backport,  |
  033-backport, 029-backport |
Parent ID:  #15618   | Points:  0.1
 Reviewer:   |Sponsor:
-+-

Comment (by s7r):

 +1.

 Agreed, too often reported and annoying for users that run relays but
 don't exactly understand the warning and ask themselves if there's
 something they should do about it. We'll keep track of it in the parent
 ticket and hopefully get to the bottom of it at some time.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28684 [Core Tor/sbws]: Make sbws easy to understand and maintain

2019-01-11 Thread Tor Bug Tracker & Wiki
#28684: Make sbws easy to understand and maintain
---+---
 Reporter:  juga   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws: unspecified
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---

Comment (by juga):

 Replying to [comment:16 irl]:
 > The output of the parser for stem should be a Python object. Take a look
 at the ServerDescriptor class for an example:
 >
 >
 
https://stem.torproject.org/api/descriptor/server_descriptor.html#stem.descriptor.server_descriptor.RelayDescriptor

 Oh, then it's even easier, since it's already an object
 (https://github.com/torproject/sbws/blob/master/sbws/lib/v3bwfile.py#L511).
 The things to do then:
 1. Maybe solve first #28282 to eliminate the aggregation logic from the
 classes
 2. To do not depend on a stem version that is not released, duplicate the
 code both in sbws and stem, until there's a new stem release

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28684 [Core Tor/sbws]: Make sbws easy to understand and maintain

2019-01-11 Thread Tor Bug Tracker & Wiki
#28684: Make sbws easy to understand and maintain
---+---
 Reporter:  juga   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws: unspecified
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---

Comment (by irl):

 It would be a good idea to speak to atagar about what he would want to see
 for the parser/formatter. Ideally it would work in the same way as the
 existing ones which might need some functions renamed or with different
 arguments. Those bugs should be new tickets too, in the stem component.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29056 [Core Tor/Stem]: Implement bandwidth file parser and formater

2019-01-11 Thread Tor Bug Tracker & Wiki
#29056: Implement bandwidth file parser and formater
---+
 Reporter:  juga   |  Owner:  juga
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal |   Keywords:  tor-bwauth
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor: |
---+
 After #21377 is implemented, the bandwidth authorities will start
 publishing the bandwidth files that they have used in their votes and
 these will be stored by CollectTor.
 This is currently implemented in `sbws`, but it's possible that we still
 need to change the format of the bandwidth file.
 As discussed in #28684, it would be a problem to parse files already
 archived if the format of the bandwidth file changes, so it would be
 better if this implemented in stem.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #1749 [Core Tor/Tor]: Split relay and link crypto across multiple CPU cores

2019-01-11 Thread Tor Bug Tracker & Wiki
#1749: Split relay and link crypto across multiple CPU cores
-+-
 Reporter:  nickm|  Owner:
 |  chelseakomlo
 Type:  project  | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, term-project-ideas,   |  Actual Points:
  threads, performance, 035-roadmap-master, 035  |
  -triaged-in-20180711   |
Parent ID:   | Points:  10
 Reviewer:   |Sponsor:
-+-

Comment (by Hello71):

 I've been saying this whole time that my (admittedly very informal)
 benchmarks show that the time spent in relay crypto is not significant, as
 long as AES is hardware accelerated (e.g. AES-NI). I assume that this task
 will require a significant amount of effort to bang out the final design
 and implement it. Therefore, if someone wants to do this, it is my opinion
 that they should first make better benchmarks, or find better benchmarks
 (I heard dgoulet was doing something...) showing that with modern openssl
 and hardware accelerated AES, parallelization is required.

 Additionally: as I understand, the current design is highly single-
 threaded. In particular, the scheduler is a key component of modern Tor,
 and if I follow correctly, is sort of a bottleneck to full parallelism.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28684 [Core Tor/sbws]: Make sbws easy to understand and maintain

2019-01-11 Thread Tor Bug Tracker & Wiki
#28684: Make sbws easy to understand and maintain
---+---
 Reporter:  juga   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws: unspecified
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---

Comment (by juga):

 i've created #29056 for this, we can now discuss this there.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29056 [Core Tor/Stem]: Implement bandwidth file parser and formater

2019-01-11 Thread Tor Bug Tracker & Wiki
#29056: Implement bandwidth file parser and formater
---+--
 Reporter:  juga   |  Owner:  juga
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-bwauth |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by juga):

 As irl comments on
 https://trac.torproject.org/projects/tor/ticket/28684#comment:18, i'll try
 to make the new classes compatible with
 
​https://stem.torproject.org/api/descriptor/server_descriptor.html#stem.descriptor.server_descriptor.RelayDescriptor.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29057 [Core Tor/sbws]: Adapt bandwidth file classes to be compatible with stem (descriptors, etc) documents

2019-01-11 Thread Tor Bug Tracker & Wiki
#29057: Adapt bandwidth file classes to be compatible with stem (descriptors, 
etc)
documents
---+---
 Reporter:  juga   |  Owner:  juga
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:  sbws: 1.1.x-final
Component:  Core Tor/sbws  |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:  #28684
   Points: |   Reviewer:
  Sponsor: |
---+---
 so that the code can be moved to stem, as commented in #29056

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #28774, #29046, #29047

2019-01-11 Thread Tor Bug Tracker & Wiki
Batch modification to #28774, #29046, #29047 by juga:


Action: reassign

Comment:
Because tickets in milestone 1.0 should be reviewed first, leave tickets in 
milestone 1.1 assigned until 1.0 is released.

--
Tickets URL: 

Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28142 [Core Tor/Tor]: Merge original WTF-PAD branch

2019-01-11 Thread Tor Bug Tracker & Wiki
#28142: Merge original WTF-PAD branch
-+-
 Reporter:  asn  |  Owner:
 |  mikeperry
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:
  padding|
Parent ID:  #28631   | Points:
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-

Comment (by nickm):

 > Mike has some questions on IRC for you Nick.

 I've added a FAQ to compat_time.h, answering those questions as best I can
 with the info I have.

 I think it's okay to leave the time stuff unchanged _for now_, iff it
 won't be called by default.  Otherwise, I think we should define an
 abstract type to represent "whatever time we're using" so we can switch it
 easily if we have to.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29035 [Applications/Tor Browser]: Post-YE campaign clean up

2019-01-11 Thread Tor Bug Tracker & Wiki
#29035: Post-YE campaign clean up
--+--
 Reporter:  pili  |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Minor | Resolution:
 Keywords:  TorBrowserTeam201901  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by sstevenson):

 I prefer the icon because it makes it stand out more.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28870 [Core Tor/sbws]: Stop asserting when there's not a descriptor for a relay being measured

2019-01-11 Thread Tor Bug Tracker & Wiki
#28870: Stop asserting when there's not a descriptor for a relay being measured
---+---
 Reporter:  juga   |  Owner:  (none)
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:  sbws: 1.0.x-final
Component:  Core Tor/sbws  |Version:  sbws: 1.0.2
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID:  #28663 | Points:
 Reviewer:  asn|Sponsor:
---+---
Changes (by juga):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Thanks!. Reworded 02bb2f5 message and merged.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28994 [Core Tor/Tor]: Close stdout pipe on error in process_unix_exec (was double closing stdin pipe)

2019-01-11 Thread Tor Bug Tracker & Wiki
#28994: Close stdout pipe on error in process_unix_exec (was double closing 
stdin
pipe)
--+
 Reporter:  kjak  |  Owner:  (none)
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  ahf   |Sponsor:
--+
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 Good catch! That's some bad copy and paste there.

 I think this patch looks good. I don't think we need a changes file when
 this code isn't released yet, but please correct me if I am wrong.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28590 [Core Tor/sbws]: Replace sbws tests/integration/net.tar with an unpacked version

2019-01-11 Thread Tor Bug Tracker & Wiki
#28590: Replace sbws tests/integration/net.tar with an unpacked version
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  sbws:
  |  1.0.x-final
Component:  Core Tor/sbws |Version:
 Severity:  Normal| Resolution:
 Keywords:  sbws-1.0-nice-moved-20181128  |  Actual Points:
Parent ID:| Points:
 Reviewer:  ahf   |Sponsor:
--+
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 This looks fine as far as I can tell.

 - It looks like the files that have been extracted are the same as in the
 tarball.
 - I did NOT go over the individual files to see if some of the code or
 config files could get some clean-up.

 Right now the Travis CI fails with what looks like an unrelated GPG
 failure. Please bump the Travis CI to make it pass before landing, but
 other than that it looks good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

2019-01-11 Thread Tor Bug Tracker & Wiki
#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 040-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 Two minor comments added, but other than that I think it looks good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25140 [Core Tor/Tor]: Parse only .torrc files in torrc.d directory

2019-01-11 Thread Tor Bug Tracker & Wiki
#25140: Parse only .torrc files in torrc.d directory
-+-
 Reporter:  iry  |  Owner:
 |  Jigsaw52
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.1-alpha
 Severity:  Major| Resolution:
 Keywords:  034-triage-20180328, |  Actual Points:
  035-removed-20180711   |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 Looks good. Only a small correction needed. Please change the changes
 file's tag (between ( and )) to be 'configuration'. Once that is done I
 think we'll move this to merge_ready and then Nick can have a look at it
 too before it goes in.

 Thanks for doing this work!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28705 [Applications/Tor Browser]: Tor Browser on Android is crashing on newer Android devices (>= Android N) by file download

2019-01-11 Thread Tor Bug Tracker & Wiki
#28705: Tor Browser on Android is crashing on newer Android devices (>= Android 
N)
by file download
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-crash, TBA-a3,   |  Actual Points:
  TorBrowserTeam201901   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-crash, TBA-a3, TorBrowserTeam201901R => tbb-
 mobile, tbb-crash, TBA-a3, TorBrowserTeam201901
 * status:  needs_review => needs_revision


Comment:

 Sorry that this took so long. This looks mostly good and fixes the problem
 for me. I am not overly thrilled to take the mozilla-central patch for
 1500906, though, as it first makes it necessary to add yet another patch
 to the patch set (the one for 1485151) and, second, breaks with the usage
 of the `StrictMode` pattern available in the other patches which
 complicates the whole patch set. Please use
 https://hg.mozilla.org/releases/mozilla-release/rev/b71bed0c6a40 instead,
 which is closer to ESR 60 anyway.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29058 [Applications/Tor Browser]: On about:tor manual and getinvolved links are blocked by onion-pattern-container

2019-01-11 Thread Tor Bug Tracker & Wiki
#29058: On about:tor manual and getinvolved links are blocked by onion-pattern-
container
--+--
 Reporter:  traumschule   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 1. The links below the search bar are visible but not clickable (in 8.5a6
 and maybe stable as well) because the circles seem to overlay it.
 2. When i inspect the element, the {{{onion-pattern-container}}} moves up
 and the links are clickable.
 3. Close the inspector and the links are blocked again.
 4. Deleting the node and closing the inspector, the links are free to
 click.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28964 [Applications/Tor Browser]: Please show tor version in About dialog

2019-01-11 Thread Tor Bug Tracker & Wiki
#28964: Please show tor version in About dialog
--+--
 Reporter:  traumschule   |  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by traumschule):

 What about a {{{More»}}} link or an info symbol (like for the circuit
 view) next/below the version that opens the about dialog?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28180 [Core Tor/Tor]: Signal mechanism from PT processes to Tor

2019-01-11 Thread Tor Bug Tracker & Wiki
#28180: Signal mechanism from PT processes to Tor
-+-
 Reporter:  ahf  |  Owner:  dgoulet
 Type:  enhancement  | Status:  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tor-pt, 040-roadmap-subtask  |  Actual Points:
Parent ID:  #25502   | Points:
 Reviewer:   |Sponsor:  Sponsor19
-+-
Changes (by ahf):

 * sponsor:  Sponsor8 => Sponsor19


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28181 [Core Tor/Tor]: spec: Add to pt-spec.txt control messages going back to main process (tor)

2019-01-11 Thread Tor Bug Tracker & Wiki
#28181: spec: Add to pt-spec.txt control messages going back to main process 
(tor)
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-spec, tor-pt, 040-roadmap-   |  Actual Points:
  subtask|
Parent ID:  #28180   | Points:
 Reviewer:  ahf  |Sponsor:
 |  Sponsor19
-+-
Changes (by ahf):

 * sponsor:  Sponsor8 => Sponsor19


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28182 [Core Tor/Tor]: spec: Add to control-spec.txt some pluggable transport events

2019-01-11 Thread Tor Bug Tracker & Wiki
#28182: spec: Add to control-spec.txt some pluggable transport events
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-spec, tor-pt, 040-roadmap-   |  Actual Points:
  subtask|
Parent ID:  #28180   | Points:
 Reviewer:  ahf  |Sponsor:
 |  Sponsor19
-+-
Changes (by ahf):

 * sponsor:  Sponsor8 => Sponsor19


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28044 [Applications/Tor Launcher]: Integrate Tor Launcher into tor-browser

2019-01-11 Thread Tor Bug Tracker & Wiki
#28044: Integrate Tor Launcher into tor-browser
-+-
 Reporter:  gk   |  Owner:  brade
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Launcher|Version:
 Severity:  Normal   | Resolution:
 Keywords:  AffectsTails, ux-team,   |  Actual Points:
  TorBrowserTeam201901   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * cc: mcs (removed)
 * cc: tbb-team (added)


Comment:

 Kathy and I did some research and experimentation over the past couple of
 days, and we believe the best approach is to:
 1. Integrate Tor Launcher directly into Tor Browser, following up on the
 work that Matt did here: https://github.com/sysrqb/tor-
 launcher/commits/bug25260_mozbuild
 2. Keep tor-launcher.git as a separate repository so that other projects
 such as TorBirdy can continue to package the code as an XPCOM extension.
 3. Fix other incompatibilities with the Firefox ESR68 codebase as we find
 them. For example, support for XUL overlays has been removed by Mozilla,
 so we will instead need to preprocess some of the Tor Launcher source
 files in order to include some shared XUL.

 For 1. above we will need decide on the best way to pull the Tor Launcher
 code into Tor Browser.  We could use a git submodule and integrate tightly
 with the browser build process, or we could "post process" browser/omni.ja
 to add the necessary Tor Launcher pieces.

 A related goal will be to keep the Tor Launcher files together as much as
 possible within the browser package; this will make it easier for
 developers to drop in updated Tor Launcher files for testing (but it will
 never again be as easy as just copying over an .xpi file). Within
 browser/omni.ja, we will probably need to place files under these
 subdirectories:
 * defaults/preferences/
 * chrome/torlauncher/
 * components/torlauncher/
 and we will need to ensure that the following manifest files are updated
 to register the Tor Launcher pieces:
 * chrome/chrome.manifest
 * components/components.manifest

 We will also need to decide whether it is worthwhile to rename the
 preferences, e.g., `extensions.torlauncher.loglevel` could be renamed to
 `torlauncher.loglevel`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25140 [Core Tor/Tor]: Parse only .torrc files in torrc.d directory

2019-01-11 Thread Tor Bug Tracker & Wiki
#25140: Parse only .torrc files in torrc.d directory
-+-
 Reporter:  iry  |  Owner:
 |  Jigsaw52
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.1-alpha
 Severity:  Major| Resolution:
 Keywords:  034-triage-20180328, |  Actual Points:
  035-removed-20180711   |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by Jigsaw52):

 * status:  needs_revision => needs_review


Comment:

 I've fixed the changes file tag.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29058 [Applications/Tor Browser]: On about:tor manual and getinvolved links are blocked by onion-pattern-container

2019-01-11 Thread Tor Bug Tracker & Wiki
#29058: On about:tor manual and getinvolved links are blocked by onion-pattern-
container
--+---
 Reporter:  traumschule   |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  duplicate
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by gk):

 * cc: igt0 (added)
 * status:  new => closed
 * resolution:   => duplicate


Comment:

 My gut tells me that's a duplicate of #28836. If it is wrong, please
 reopen.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29059 [Core Tor/Tor]: shellcheck: fuzz_static_testcases.sh issue

2019-01-11 Thread Tor Bug Tracker & Wiki
#29059: shellcheck: fuzz_static_testcases.sh issue
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  technical-debt
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 {{{

 In fuzz_static_testcases.sh line 17:
 f=`basename $fuzzer`
   ^-- SC2006: Use $(..) instead of legacy `..`.
 ^-- SC2086: Double quote to prevent globbing and word
 splitting.
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28836 [Applications/Tor Browser]: Links on about:tor are not clickable anymore on Windows starting with 8.5a5

2019-01-11 Thread Tor Bug Tracker & Wiki
#28836: Links on about:tor are not clickable anymore on Windows starting with 
8.5a5
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-regression,  |  Actual Points:
  TorBrowserTeam201901   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * cc: traumschule (added)


Comment:

 Closed #29058 as a duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29060 [Core Tor/Tor]: shellcheck: test-network.sh issues

2019-01-11 Thread Tor Bug Tracker & Wiki
#29060: shellcheck: test-network.sh issues
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  technical-debt
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 {{{

 In test-network.sh line 8:
 if [ -d "$CHUTNEY_PATH" -a -x "$TEST_NETWORK" ]; then
 ^-- SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is
 not well defined.


 In test-network.sh line 19:
 myname=$(basename $0)
   ^-- SC2086: Double quote to prevent globbing and word
 splitting.


 In test-network.sh line 23:
 ORIGINAL_ARGS="$@"
   ^-- SC2124: Assigning an array to a string! Assign as array,
 or use * instead of @ to concatenate.


 In test-network.sh line 55:
 if [ -d "$BUILDDIR/src/core/or" -a -d "$BUILDDIR/src/tools" ]; then
 ^-- SC2166: Prefer [ p ] && [ q ] as [
 p -a q ] is not well defined.


 In test-network.sh line 60:
 elif [ -d "$PWD/src/core/or" -a -d "$PWD/src/tools" ]; then
  ^-- SC2166: Prefer [ p ] && [ q ] as [ p
 -a q ] is not well defined.


 In test-network.sh line 76:
 if [ ! -d "$CHUTNEY_PATH" -o ! -x "$CHUTNEY_PATH/chutney" ]; then
   ^-- SC2166: Prefer [ p ] || [ q ] as [ p -o q ]
 is not well defined.


 In test-network.sh line 80:
 elif [ -d "$TOR_DIR" -a -d "$TOR_DIR/../chutney" -a \
  ^-- SC2166: Prefer [ p ] && [ q ] as [ p -a q ]
 is not well defined.
  ^-- SC2166: Prefer [
 p ] && [ q ] as [ p -a q ] is not well defined.


 In test-network.sh line 97:
 if [ -d "$CHUTNEY_PATH" -a -x "$TEST_NETWORK" ]; then
 ^-- SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is
 not well defined.


 In test-network.sh line 102:
 exec "$TEST_NETWORK" $ORIGINAL_ARGS
  ^-- SC2086: Double quote to prevent globbing and
 word splitting.

 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29061 [Core Tor/Tor]: shellcheck: test_bt.sh issue

2019-01-11 Thread Tor Bug Tracker & Wiki
#29061: shellcheck: test_bt.sh issue
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  technical-debt
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 {{{
 In test_bt.sh line 6:
 ulimit -c 0
^-- SC2039: In POSIX sh, ulimit -c is undefined.

 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29062 [Core Tor/Tor]: shellcheck: test_keygen.sh issues

2019-01-11 Thread Tor Bug Tracker & Wiki
#29062: shellcheck: test_keygen.sh issues
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  technical-debt
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 {{{

 In test_keygen.sh line 9:
 if [ $# -eq 0 ] || [ ! -f ${1} ] || [ ! -x ${1} ]; then
   ^-- SC2086: Double quote to prevent globbing and
 word splitting.
^-- SC2086: Double quote to
 prevent globbing and word splitting.


 In test_keygen.sh line 16:
 UNAME_OS=`uname -s | cut -d_ -f1`
  ^-- SC2006: Use $(..) instead of legacy `..`.


 In test_keygen.sh line 67:
 check_no_file() { [ -e "$1" ] && die "$1 was not supposed to exist" ||
 true; }
   ^-- SC2015: Note that A && B || C is not if-
 then-else. C may run when A is true.


 In test_keygen.sh line 68:
 check_files_eq() { cmp "$1" "$2" || die "$1 and $2 did not match: `dump
 $1` vs `dump $2`"; }
   ^--
 SC2006: Use $(..) instead of legacy `..`.
 ^-- SC2086: Double quote to prevent globbing and word splitting.
 ^-- SC2006: Use $(..) instead of legacy `..`.
 ^-- SC2086: Double quote to prevent globbing and word splitting.


 In test_keygen.sh line 71:
 DATA_DIR=`mktemp -d -t tor_keygen_tests.XX`
  ^-- SC2006: Use $(..) instead of legacy `..`.


 In test_keygen.sh line 80:
 trap "rm -rf '$DATA_DIR'" 0
   ^-- SC2064: Use single quotes, otherwise this expands now
 rather than when signalled.


 In test_keygen.sh line 83:
 DATA_DIR=`cd "${DATA_DIR}" && pwd`
  ^-- SC2006: Use $(..) instead of legacy `..`.


 In test_keygen.sh line 146:
 ${TOR} --DataDirectory "${ME}" --list-fingerprint > "${ME}/stdout" && die
 "Somehow succeeded when missing secret key, certs: `cat ${ME}/stdout`" ||
 true
^--
 SC2015: Note that A && B || C is not if-then-else. C may run when A is
 true.
 ^-- SC2006: Use $(..) instead of legacy `..`.
 ^-- SC2086: Double quote to prevent globbing and word splitting.


 In test_keygen.sh line 283:
 ${TOR} --DataDirectory "${ME}" --list-fingerprint > "${ME}/stdout" && die
 "Tor started with encrypted secret key and no certs" || true
^--
 SC2015: Note that A && B || C is not if-then-else. C may run when A is
 true.


 In test_keygen.sh line 372:
 ${TOR} --DataDirectory "${ME}" --list-fingerprint >"${ME}/stdout" && die
 "Successfully started with mismatched keys!?" || true
   ^--
 SC2015: Note that A && B || C is not if-then-else. C may run when A is
 true.


 In test_keygen.sh line 388:
 ${TOR} --DataDirectory "${ME}" --passphrase-fd 1 > "${ME}/stdout" && die
 "Successfully started with passphrase-fd but no keygen?" || true
   ^--
 SC2015: Note that A && B || C is not if-then-else. C may run when A is
 true.


 In test_keygen.sh line 404:
 ${TOR} --DataDirectory "${ME}" --no-passphrase > "${ME}/stdout" && die
 "Successfully started with no-passphrase but no keygen?" || true
 ^--
 SC2015: Note that A && B || C is not if-then-else. C may run when A is
 true.


 In test_keygen.sh line 420:
 ${TOR} --DataDirectory "${ME}" --newpass > "${ME}/stdout" && die
 "Successfully started with newpass but no keygen?" || true
   ^-- SC2015: Note
 that A && B || C is not if-then-else. C may run when A is true.


 In test_keygen.sh line 458:
 ${TOR} --DataDirectory "${ME}" --keygen --passphrase-fd ewigeblumenkraft >
 "${ME}/stdout" && die "Successfully started with bogus passphrase-fd?" ||
 true
 ^-- SC2015: Note that A && B || C is not if-then-else. C may run when A is
 true.


 In test_keygen.sh line 475:
 ${TOR} --DataDirectory "${ME}" --keygen --passphrase-fd 1 --no-passphrase
 > "${ME}/stdout" && die "Successfully started with bogus passphrase-fd
 combination?" || true
 ^-- SC2015: Note that A && B || C is not if-then-else. C may run when A is
 true.

 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29063 [Core Tor/Tor]: shellcheck: test_rebind.sh issues

2019-01-11 Thread Tor Bug Tracker & Wiki
#29063: shellcheck: test_rebind.sh issues
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  technical-debt
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 {{{

 In test_rebind.sh line 18:
 clean () { test -n "$tmpdir" && test -d "$tmpdir" && rm -rf "$tmpdir" ||
 :; }
   ^-- SC2015: Note that A
 && B || C is not if-then-else. C may run when A is true.


 In test_rebind.sh line 21:
 tmpdir="`mktemp -d -t tor_rebind_test.XX`"
 ^-- SC2006: Use $(..) instead of legacy `..`.

 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29064 [Core Tor/Tor]: shellcheck: test_rust.sh issues

2019-01-11 Thread Tor Bug Tracker & Wiki
#29064: shellcheck: test_rust.sh issues
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  technical-debt
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 {{{

 In test_rust.sh line 19:
 "${CARGO:-cargo}" test ${CARGO_ONLINE-"--frozen"} \
^-- SC2086: Double quote to prevent
 globbing and word splitting.


 In test_rust.sh line 21:
 --target $rustc_host \
  ^-- SC2086: Double quote to prevent globbing and word
 splitting.


 In test_rust.sh line 22:
 ${EXTRA_CARGO_OPTIONS} \
 ^-- SC2086: Double quote to prevent globbing and word
 splitting.

 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29065 [Core Tor/Tor]: shellcheck: test_switch_id.sh issues

2019-01-11 Thread Tor Bug Tracker & Wiki
#29065: shellcheck: test_switch_id.sh issues
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  technical-debt
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 {{{

 In test_switch_id.sh line 3:
 if test "`id -u`" != '0'; then
  ^-- SC2006: Use $(..) instead of legacy `..`.


 In test_switch_id.sh line 8:
 if test "`id -u nobody`" = ""; then
  ^-- SC2006: Use $(..) instead of legacy `..`.

 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29066 [Core Tor/Tor]: shellcheck: test_workqueue_cancel.sh issue

2019-01-11 Thread Tor Bug Tracker & Wiki
#29066: shellcheck: test_workqueue_cancel.sh issue
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  technical-debt
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 {{{

 In test_workqueue_cancel.sh line 3:
 ${builddir:-.}/src/test/test_workqueue -C 1
 ^-- SC2086: Double quote to prevent globbing and word splitting.

 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

2019-01-11 Thread Tor Bug Tracker & Wiki
#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201901,  |  Actual Points:
  TorBrowserTeam201901   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:4 gk]:
 > Testing `bug_28238` shows that we have some reproducibility issues with
 mingw-w64/clang. It seems we have to deal at least with timestamp issues
 in the COFF header. Comparing e.g. `firefox.exe` from two different runs
 shows:
 > {{{
 > --- /dev/fd/632019-01-10 09:38:08.159230047 +0100
 > +++ /dev/fd/622019-01-10 09:38:08.159230047 +0100
 > @@ -6,7 +6,7 @@
 >  0050: 6973 2070 726f 6772 616d 2063 616e 6e6f  is program canno
 >  0060: 7420 6265 2072 756e 2069 6e20 444f 5320  t be run in DOS
 >  0070: 6d6f 6465 2e24  5045  4c01 0600  mode.$..PE..L...
 > -0080: 3b1c 365c 003c  a201  e000 2201  ;.6\.<".
 > +0080: 45ff 365c 003c  a201  e000 2201  E.6\.<".
 >  0090: 0b01 0e00 001e  001a     
 >  00a0: c013  0010     4000  ..@.
 >  00b0: 0010  0002  0600     
 > }}}

 FWIW: That's still an unsolved issue after bumping the LLVM revision to
 r348363.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29067 [Core Tor/Tor]: shellcheck: test_workqueue_efd.sh issue

2019-01-11 Thread Tor Bug Tracker & Wiki
#29067: shellcheck: test_workqueue_efd.sh issue
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  technical-debt
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 {{{
 In test_workqueue_efd.sh line 3:
 ${builddir:-.}/src/test/test_workqueue \
 ^-- SC2086: Double quote to prevent globbing and word splitting.
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29068 [Core Tor/Tor]: shellcheck: zero_length_keys.sh issues

2019-01-11 Thread Tor Bug Tracker & Wiki
#29068: shellcheck: zero_length_keys.sh issues
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  technical-debt
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 {{{

 In zero_length_keys.sh line 22:
 if [ $# -eq 0 ] || [ ! -f ${1} ] || [ ! -x ${1} ]; then
   ^-- SC2086: Double quote to prevent globbing and
 word splitting.
^-- SC2086: Double quote to
 prevent globbing and word splitting.


 In zero_length_keys.sh line 34:
 DATA_DIR=`mktemp -d -t tor_zero_length_keys.XX`
  ^-- SC2006: Use $(..) instead of legacy `..`.


 In zero_length_keys.sh line 43:
 trap "rm -rf '$DATA_DIR'" 0
   ^-- SC2064: Use single quotes, otherwise this expands now
 rather than when signalled.
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29067 [Core Tor/Tor]: shellcheck: test_workqueue_*.sh issue (was: shellcheck: test_workqueue_efd.sh issue)

2019-01-11 Thread Tor Bug Tracker & Wiki
#29067: shellcheck: test_workqueue_*.sh issue
+
 Reporter:  rl1987  |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+
Description changed by rl1987:

Old description:

> {{{
> In test_workqueue_efd.sh line 3:
> ${builddir:-.}/src/test/test_workqueue \
> ^-- SC2086: Double quote to prevent globbing and word splitting.
> }}}

New description:

 {{{
 In test_workqueue_efd.sh line 3:
 ${builddir:-.}/src/test/test_workqueue \
 ^-- SC2086: Double quote to prevent globbing and word splitting.
 }}}

 Also applies to test_workqueue_efd2.sh, test_workqueue_pipe.sh,
 test_workqueue_pipe2.sh and test_workqueue_socketpair.sh.

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29069 [Core Tor/Tor]: shellcheck: autogen.sh issues

2019-01-11 Thread Tor Bug Tracker & Wiki
#29069: shellcheck: autogen.sh issues
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  technical-debt
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 {{{

 In autogen.sh line 3:
 if [ -x "`which autoreconf 2>/dev/null`" ] ; then
  ^-- SC2006: Use $(..) instead of legacy `..`.
   ^-- SC2230: which is non-standard. Use builtin 'command -v'
 instead.


 In autogen.sh line 6:
   for i in $@; do
^-- SC2068: Double quote array expansions to avoid re-splitting
 elements.


 In autogen.sh line 14:
   exec autoreconf $opt
   ^-- SC2086: Double quote to prevent globbing and word
 splitting.

 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29070 [Core Tor/Tor]: shellcheck: torify issue

2019-01-11 Thread Tor Bug Tracker & Wiki
#29070: shellcheck: torify issue
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 {{{

 In torify line 56:
 echo "$0: Failed to exec torsocks $@" >&2
   ^-- SC2145: Argument mixes string
 and array. Use * or separate argument.
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29071 [Core Tor/Tor]: shellcheck: nagios-check-tor-authority-cert issues

2019-01-11 Thread Tor Bug Tracker & Wiki
#29071: shellcheck: nagios-check-tor-authority-cert issues
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  technical-debt
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 {{{

 In nagios-check-tor-authority-cert line 52:
 TMPFILE="`tempfile`"
  ^-- SC2006: Use $(..) instead of legacy `..`.
   ^-- SC2186: tempfile is deprecated. Use mktemp instead.


 In nagios-check-tor-authority-cert line 57:
 if [ "$?" = 0 ]; then
  ^-- SC2181: Check exit code directly with e.g. 'if mycmd;',
 not indirectly with $?.


 In nagios-check-tor-authority-cert line 77:
 elif [ "$(( $now + 7*24*60*60 ))" -ge "$expiryunix" ]; then
 ^-- SC2004: $/${} is unnecessary on arithmetic variables.


 In nagios-check-tor-authority-cert line 80:
 elif [ "$(( $now + 30*24*60*60 ))" -ge "$expiryunix" ]; then
 ^-- SC2004: $/${} is unnecessary on arithmetic variables.
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29072 [Core Tor/Tor]: shellcheck: check-tor issues

2019-01-11 Thread Tor Bug Tracker & Wiki
#29072: shellcheck: check-tor issues
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  technical-debt
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 {{{

 In check-tor line 36:
 echo ">>" wget --proxy=off -O - http://$ipop/tor/
^-- SC2086: Double quote to
 prevent globbing and word splitting.


 In check-tor line 37:
 timeout 5 wget --proxy=off -O - http://$ipop/tor/ | head -n3
^-- SC2086: Double quote to
 prevent globbing and word splitting.


 In check-tor line 41:
 echo -n "$router "; echo "$lines" | grep 'fingerprint' | sed -e 's/^opt
 //' -e 's/^fingerprint //';
  ^-- SC2039: In POSIX sh, echo flags are undefined.
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29074 [Applications/Tor Browser]: Consider using the Windows 10 UA instead of the Windows 7 UA in the TB UA

2019-01-11 Thread Tor Bug Tracker & Wiki
#29074: Consider using the Windows 10 UA instead of the Windows 7 UA in the TB 
UA
--+--
 Reporter:  cypherpunks3  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Component:  Applications/Tor Browser
  Version:|   Severity:  Normal
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
 [https://data.firefox.com/dashboard/hardware Data from Mozilla] shows that
 Windows 10 dethroned Windows 7, it may be wise (or not) to thus consider
 switching the TB UA to the Windows 10 one.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29073 [Core Tor/Tor]: shellcheck: linux-tor-prio.sh issues

2019-01-11 Thread Tor Bug Tracker & Wiki
#29073: shellcheck: linux-tor-prio.sh issues
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 {{{

 In linux-tor-prio.sh line 98:
 MTU=1500
 ^-- SC2034: MTU appears unused. Verify use (or export if used externally).


 In linux-tor-prio.sh line 108:
 BDP=$(expr $RTT_LATENCY \* $RATE_UP / $AVG_PKT)
   ^-- SC2003: expr is antiquated. Consider rewriting this using
 $((..)), ${} or [[ ]].


 In linux-tor-prio.sh line 113:
 BDP=$(expr $BDP / 4)
   ^-- SC2003: expr is antiquated. Consider rewriting this using
 $((..)), ${} or [[ ]].
^-- SC2086: Double quote to prevent globbing and word
 splitting.


 In linux-tor-prio.sh line 151:
 ip link set dev $DEV qlen $BDP
   ^-- SC2086: Double quote to prevent globbing and
 word splitting.


 In linux-tor-prio.sh line 161:
 tc class add dev $DEV parent 1:1 classid 1:20 htb rate $(expr $RATE_UP -
 $RATE_UP_TOR)kbit ceil ${RATE_UP}kbit prio 0
^-- SC2046: Quote
 this to prevent word splitting.
  ^-- SC2003: expr
 is antiquated. Consider rewriting this using $((..)), ${} or [[ ]].


 In linux-tor-prio.sh line 162:
 tc class add dev $DEV parent 1:1 classid 1:21 htb rate $[$RATE_UP_TOR]kbit
 ceil ${RATE_UP_TOR_CEIL}kbit prio 10
^-- SC2007: Use
 $((..)) instead of deprecated $[..]


 In linux-tor-prio.sh line 165:
 tc qdisc add dev $DEV parent 1:20 handle 20: pfifo limit $BDP
  ^-- SC2086:
 Double quote to prevent globbing and word splitting.


 In linux-tor-prio.sh line 166:
 tc qdisc add dev $DEV parent 1:21 handle 21: pfifo limit $BDP
  ^-- SC2086:
 Double quote to prevent globbing and word splitting.


 In linux-tor-prio.sh line 179:
 if [ ""$TOR_IP == "" ]
^-- SC2086: Double quote to prevent globbing and word splitting.


 In linux-tor-prio.sh line 182:
 iptables -t mangle -A TORSHAPER-OUT -m owner --uid-owner $TOR_UID
 -j MARK --set-mark 21
  ^--
 SC2086: Double quote to prevent globbing and word splitting.


 In linux-tor-prio.sh line 185:
 iptables -t mangle -A TORSHAPER-OUT -s $TOR_IP -j MARK --set-mark
 21
^-- SC2086: Double quote to
 prevent globbing and word splitting.

 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29021 [Applications/Tor Browser]: Provide a means to inform NoScript about being run in a Tor Browser context

2019-01-11 Thread Tor Bug Tracker & Wiki
#29021: Provide a means to inform NoScript about being run in a Tor Browser 
context
--+---
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  noscript  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by watt):

 * status:  new => needs_information
 * type:  enhancement => task


Comment:

 What? In what way is that an enhancement? What prevents NoScript from
 adding a new checkbox "special requirements" in its options?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29074 [Applications/Tor Browser]: Consider using the Windows 10 UA instead of the Windows 7 UA in the TB UA

2019-01-11 Thread Tor Bug Tracker & Wiki
#29074: Consider using the Windows 10 UA instead of the Windows 7 UA in the TB 
UA
--+--
 Reporter:  cypherpunks3  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks3):

 (By the way seeing TB use the UA of the most privacy invading version of
 Windows to date to help spoof things up would be funnily enough pretty
 ironic for the M$ fanbois)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28716 [Applications/Tor Browser]: Create a mingw-w64-clang project

2019-01-11 Thread Tor Bug Tracker & Wiki
#28716: Create a mingw-w64-clang project
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901,   |  Actual Points:
  GeorgKoppen201901  |
Parent ID:  #28238   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by watt):

 Replying to [comment:16 gk]:
 > So, we need to teach the toolchain again how to link against a non-
 default runtime lib (ucrt this time) which has always been a fun
 exercise...
 It is a default c runtime lib in msvc...

 (tom: dxr seems to go nuts https://dxr.mozilla.org/mozilla-central/source
 /old-configure#3526)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29055 [Core Tor/Tor]: Add synonym OnionService* to HiddenService* torrc options

2019-01-11 Thread Tor Bug Tracker & Wiki
#29055: Add synonym OnionService* to HiddenService* torrc options
--+--
 Reporter:  s7r   |  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Low   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: 0.3.5.7
 Severity:  Normal| Resolution:  duplicate
 Keywords:  tor-hs, doc, manpage  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by dgoulet):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 #17343

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26148 [Applications/Tor Browser]: Update binutils to a version more recent than 2.26.1

2019-01-11 Thread Tor Bug Tracker & Wiki
#26148: Update binutils to a version more recent than 2.26.1
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901,   |  Actual Points:
  boklm201811|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:9 ld]:
 > Replying to [comment:8 boklm]:
 > > with previous versions of binutils, the order of objects inside a `.a`
 file did not affect the output, but it is not the case anymore with more
 recent versions of binutils.
 > Bug or feature for you?
 > > I am now testing a patch to update binutils to 2.31.1.
 > Please test with the master branch instead, because of
 https://sourceware.org/ml/binutils/2019-01/msg00013.html and to avoid
 issues like https://sourceware.org/bugzilla/show_bug.cgi?id=23600.

 No, 2.31.1 is fine for now I think (if nothing explodes). We'll want to
 switch to a newer binutils before 2.32 gets released if possible.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27795 [Core Tor/Tor]: Possible fd leak on 0.3.5.1-alpha

2019-01-11 Thread Tor Bug Tracker & Wiki
#27795: Possible fd leak on 0.3.5.1-alpha
---+
 Reporter:  dgoulet|  Owner:  nickm
 Type:  defect | Status:  closed
 Priority:  High   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Critical   | Resolution:  fixed
 Keywords:  regression, tor-relay  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by toralf):

 So my relay did not run again into this situation - I'll consider this bug
 as resolved.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27315 [Core Tor/Tor]: Sandbox regression in 0.3.4.7-rc

2019-01-11 Thread Tor Bug Tracker & Wiki
#27315: Sandbox regression in 0.3.4.7-rc
---+---
 Reporter:  toralf |  Owner:  (none)
 Type:  defect | Status:  needs_information
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.4.x-final
Component:  Core Tor/Tor   |Version:  Tor: 0.3.4.7-rc
 Severity:  Normal | Resolution:
 Keywords:  regression?, 034-backport  |  Actual Points:
Parent ID: | Points:
 Reviewer:  ahf|Sponsor:
---+---

Comment (by toralf):

 This is at my hardened Gentoo relay:
 {{{
 mr-fox ~ # gcc test.c -o test -l seccomp
 test.c: In function ‘main’:
 test.c:92:14: warning: format ‘%llu’ expects argument of type ‘long long
 unsigned int’, but argument 2 has type ‘int’ [-Wformat=]
printf("%llu %llu\n", AT_FDCWD, (unsigned int)AT_FDCWD);
~~~^
%u
 test.c:92:19: warning: format ‘%llu’ expects argument of type ‘long long
 unsigned int’, but argument 3 has type ‘unsigned int’ [-Wformat=]
printf("%llu %llu\n", AT_FDCWD, (unsigned int)AT_FDCWD);
 ~~~^
 %u
 mr-fox ~ # ./test
 Testing rule before fix.
 #
 # pseudo filter code start
 #
 # filter for arch x86_64 (3221225534)
 if ($arch == 3221225534)
   # filter for syscall "fstat64" (-10010) [priority: 65535]
   if ($syscall == -10010)
 action ALLOW;
   # filter for syscall "exit_group" (231) [priority: 65535]
   if ($syscall == 231)
 action ALLOW;
   # filter for syscall "rt_sigreturn" (15) [priority: 65535]
   if ($syscall == 15)
 action ALLOW;
   # filter for syscall "fstat" (5) [priority: 65535]
   if ($syscall == 5)
 action ALLOW;
   # filter for syscall "write" (1) [priority: 65535]
   if ($syscall == 1)
 action ALLOW;
   # filter for syscall "read" (0) [priority: 65535]
   if ($syscall == 0)
 action ALLOW;
   # filter for syscall "openat" (257) [priority: 65531]
   if ($syscall == 257)
 if ($a0.hi32 == 4294967295)
   if ($a0.lo32 == 4294967196)
 if ($a1.hi32 == 22044)
   if ($a1.lo32 == 1279610616)
 action ALLOW;
   # default action
   action KILL;
 # invalid architecture action
 action KILL;
 #
 # pseudo filter code end
 #
 GNU libc version: 2.27
 GNU libc release: stable
 libseccomp 2.3.3
 18446744073709551516 4294967196
 4294967196 4294967196
 Before openat
 Bad system call
 mr-fox ~ # ./test foo
 Testing rule before fix.
 #
 # pseudo filter code start
 #
 # filter for arch x86_64 (3221225534)
 if ($arch == 3221225534)
   # filter for syscall "fstat64" (-10010) [priority: 65535]
   if ($syscall == -10010)
 action ALLOW;
   # filter for syscall "exit_group" (231) [priority: 65535]
   if ($syscall == 231)
 action ALLOW;
   # filter for syscall "rt_sigreturn" (15) [priority: 65535]
   if ($syscall == 15)
 action ALLOW;
   # filter for syscall "fstat" (5) [priority: 65535]
   if ($syscall == 5)
 action ALLOW;
   # filter for syscall "write" (1) [priority: 65535]
   if ($syscall == 1)
 action ALLOW;
   # filter for syscall "read" (0) [priority: 65535]
   if ($syscall == 0)
 action ALLOW;
   # filter for syscall "openat" (257) [priority: 65531]
   if ($syscall == 257)
 if ($a0.hi32 == 4294967295)
   if ($a0.lo32 == 4294967196)
 if ($a1.hi32 == 22046)
   if ($a1.lo32 == 1081806584)
 action ALLOW;
   # default action
   action KILL;
 # invalid architecture action
 action KILL;
 #
 # pseudo filter code end
 #
 GNU libc version: 2.27
 GNU libc release: stable
 libseccomp 2.3.3
 18446744073709551516 4294967196
 4294967196 4294967196
 Before openat
 Bad system call
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28549 [Webpages/Support]: Add missing FAQ questions to support.tpo

2019-01-11 Thread Tor Bug Tracker & Wiki
#28549: Add missing FAQ questions to support.tpo
--+--
 Reporter:  traumschule   |  Owner:  emmapeel
 Type:  task  | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Webpages/Support  |Version:
 Severity:  Normal| Resolution:
 Keywords:  faq   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by traumschule):

 This has some q&a and should probably be archived after reviewing:
 https://gitweb.torproject.org/support-portal.git

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #8127 [Metrics/Website]: Bring back the relays-by-country graph

2019-01-11 Thread Tor Bug Tracker & Wiki
#8127: Bring back the relays-by-country graph
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  assigned
 Priority:  Low  |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by anadahz):

 * cc: anadahz (added)


Comment:

 What kind of resources are required?

 Can a dedicated server allocated only to do this task help to bring back
 the relays-by-country graphs?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29056 [Core Tor/Stem]: Implement bandwidth file parser and formater

2019-01-11 Thread Tor Bug Tracker & Wiki
#29056: Implement bandwidth file parser and formater
---+--
 Reporter:  juga   |  Owner:  juga
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-bwauth |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by atagar):

 Thanks juga! Sounds good. Once the bwauth file format and a method of
 getting them have been added to the tor spec I'd be happy to help write a
 parser (or merge it if ya have a patch).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29075 [Webpages/Support]: Sort support glossary by target language

2019-01-11 Thread Tor Bug Tracker & Wiki
#29075: Sort support glossary by target language
--+--
 Reporter:  traumschule   |  Owner:  hiro
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Webpages/Support  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 We want to have glossary sorted by the translated term in the selected
 language.

 Currently when people translate terms, they are not going to be ordered on
 the target language, so they are not going to respect the alphabetic
 order.

 We can order by other attributes than {{{_id}}}, on the people page we
 order by nickname for example.

 1. Automatically reformat [https://gitweb.torproject.org/tor-glossary.git
 glossary csv] to markdown (hints:
 [https://stackoverflow.com/questions/45514792/loop-csv-content-
 in-a-jinja2-template load csv],
 [https://github.com/mohitt01/CsvToMarkdownTable csv to markdown table])

 2. Create a folder for each term

 3. emmapeel did the 'word' model that can be used as template for the
 glossary model. {{{contents.lr}}} should define what is sent to transifex.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28498 [Core Tor/Nyx]: Unable to refresh connection circuit

2019-01-11 Thread Tor Bug Tracker & Wiki
#28498: Unable to refresh connection circuit
--+--
 Reporter:  cyberpunks|  Owner:  atagar
 Type:  defect| Status:  closed
 Priority:  High  |  Milestone:
Component:  Core Tor/Nyx  |Version:
 Severity:  Normal| Resolution:  user disappeared
 Keywords:  Connection|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by atagar):

 * status:  needs_information => closed
 * resolution:   => user disappeared


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28823 [Applications/Tor Browser]: Every web page crashes on Windows 7 with Tor Browser 8

2019-01-11 Thread Tor Bug Tracker & Wiki
#28823: Every web page crashes on Windows 7 with Tor Browser 8
--+---
 Reporter:  testcy|  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-crash |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by testcy):

 Seems to be working (at least now) with no crashes, but don't forget that
 Comodo is not running.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #4281 [Core Tor/Nyx]: Usage popup not unique clients

2019-01-11 Thread Tor Bug Tracker & Wiki
#4281: Usage popup not unique clients
--+
 Reporter:  atagar|  Owner:  atagar
 Type:  defect| Status:  closed
 Priority:  Low   |  Milestone:
Component:  Core Tor/Nyx  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  connections   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by atagar):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Yikes, this is an old one. The client and exit port usage dialogs changed
 quite a bit since this was filed but in reviewing the code we still had an
 issue with counting on a per-connection rather than a per-client or per-
 destination basis. Fixed.

 https://gitweb.torproject.org/nyx.git/commit/?id=7a4d21b

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16431 [Core Tor/Nyx]: Arm Graph in Putty is Black

2019-01-11 Thread Tor Bug Tracker & Wiki
#16431: Arm Graph in Putty is Black
--+--
 Reporter:  Sk!d  |  Owner:  atagar
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Core Tor/Nyx  |Version:
 Severity:  Normal| Resolution:  user disappeared
 Keywords:  curses|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by atagar):

 * status:  new => closed
 * resolution:   => user disappeared


Comment:

 Hi all, is this relevant any longer? I haven't heard anything more about
 this in years. I'm unsure if that's because this is no longer an issue in
 Putty or that folks no longer use it.

 At this point I need a couple things for this ticket to be actionable...

 1. Confirmation from a putty user that this is still a problem.
 2. A tip on how to detect if folks are using putty.

 For #2 the first step that would help is someone's output from the 'env'
 command. The answer might be 'we cannot detect it' since this is an ssh
 client rather than a shell, but perhaps there's something in there we can
 use.

 If anyone putty users run into this and would care to help feel free to
 reopen!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24288 [Core Tor/Nyx]: install process does not include man page

2019-01-11 Thread Tor Bug Tracker & Wiki
#24288: install process does not include man page
---+--
 Reporter:  stefani|  Owner:  atagar
 Type:  defect | Status:  closed
 Priority:  Low|  Milestone:
Component:  Core Tor/Nyx   |Version:
 Severity:  Normal | Resolution:  user disappeared
 Keywords:  manual, configuration  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by atagar):

 * status:  new => closed
 * resolution:   => user disappeared


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18991 [Core Tor/Nyx]: Use HIBERNATION_STATUS in header panel

2019-01-11 Thread Tor Bug Tracker & Wiki
#18991: Use HIBERNATION_STATUS in header panel
--+---
 Reporter:  atagar|  Owner:  atagar
 Type:  enhancement   | Status:  closed
 Priority:  Very Low  |  Milestone:
Component:  Core Tor/Nyx  |Version:
 Severity:  Minor | Resolution:  not a bug
 Keywords:  header|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by atagar):

 * status:  new => closed
 * resolution:   => not a bug


Comment:

 On reflection there's actually nothing to be done with this. The graph
 panel polls accounting data to display hibernation status, but it presents
 accounting stats as well (which HIVERNATION_STATUS understandably does not
 provide).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26099 [Core Tor/Nyx]: Missing dependency 'python3-distutils' for 'nyx' package from deb.torproject.org for bionic

2019-01-11 Thread Tor Bug Tracker & Wiki
#26099: Missing dependency 'python3-distutils' for 'nyx' package from
deb.torproject.org for bionic
---+---
 Reporter:  cypherpunks|  Owner:  atagar
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Core Tor/Nyx   |Version:  Tor: 0.3.2.10
 Severity:  Normal | Resolution:  fixed
 Keywords:  packaging, dependency  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by atagar):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Thanks cypherpunks, sorry about the long delay! Finally fixed...

 https://gitweb.torproject.org/nyx.git/commit/?id=a04c975

 Nyx no longer uses distutils at all. Hopefully I'll get a new 2.1.0
 release out this weekend.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28823 [Applications/Tor Browser]: Every web page crashes on Windows 7 with Tor Browser 8

2019-01-11 Thread Tor Bug Tracker & Wiki
#28823: Every web page crashes on Windows 7 with Tor Browser 8
--+---
 Reporter:  testcy|  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-crash |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by gk):

 Replying to [comment:34 testcy]:
 > It took several times to connect, but it seems to be working with no
 crashes (at least for now). Don't forget that Comodo is not running.

 Yes, but in comment:4 you said Tor Browser was crashing even _without_
 Commodo running, so I am confused. Thus, to be sure: are the current Tor
 Browser versions (8.0.4 and 8.5a6) crashing right now while the test
 builds are not crashing or not?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29050 [Core Tor/Torsocks]: Connecting to tor over a socks 5 connection no longer works in 3.5.7

2019-01-11 Thread Tor Bug Tracker & Wiki
#29050: Connecting to tor over a socks 5 connection no longer works in 3.5.7
---+---
 Reporter:  arj|  Owner:  dgoulet
 Type:  defect | Status:  needs_information
 Priority:  Medium |  Milestone:
Component:  Core Tor/Torsocks  |Version:  Tor: 0.3.5.7
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---

Comment (by arj):

 Upgrading to torsocks 2.3 does not seem to resolve the problem with socks
 5. I was testing with 2.1 before. I just retested torsocks 2.3 with v4 in
 the node socks library at that still works.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28823 [Applications/Tor Browser]: Every web page crashes on Windows 7 with Tor Browser 8

2019-01-11 Thread Tor Bug Tracker & Wiki
#28823: Every web page crashes on Windows 7 with Tor Browser 8
--+---
 Reporter:  testcy|  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-crash |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by testcy):

 I tried every version again and 8.0.4 and 8.5a6 both crash, but also the
 latest test build. Previously when I tested the test build it was not
 crashing, but now it is crashing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27146 [Core Tor/Tor]: Mismatched digest in 0.3.3.9 and master mixed chutney network

2019-01-11 Thread Tor Bug Tracker & Wiki
#27146: Mismatched digest in 0.3.3.9 and master mixed chutney network
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  assigned
 Priority:  Very High|  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regression, tor-dirauth, macOS, 035  |  Actual Points:
  -roadmap-proposed, 035-can |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gaba):

 * sponsor:  Sponsor8-can =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28558 [Core Tor/Tor]: Crash in memoize_protover_summary() when cache is full

2019-01-11 Thread Tor Bug Tracker & Wiki
#28558: Crash in memoize_protover_summary() when cache is full
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  closed
 Priority:  Very High |  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:  .1
Parent ID:| Points:
 Reviewer:|Sponsor:  Sponsor8
--+
Changes (by gaba):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 This should be close, right?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #10059 [Core Tor/Tor]: capture tor log messages before control connection is opened

2019-01-11 Thread Tor Bug Tracker & Wiki
#10059: capture tor log messages before control connection is opened
-+-
 Reporter:  mcs  |  Owner:  nickm
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, extdev-interview, |  Actual Points:
  tbb-needs, 034-triage-20180328,|
  035-removed-20180711   |
Parent ID:  #9675| Points:  3
 Reviewer:   |Sponsor:
-+-
Changes (by gaba):

 * sponsor:  Sponsor8 =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23289 [Core Tor/Tor]: Improving HS reachability for Orbot/Android users

2019-01-11 Thread Tor Bug Tracker & Wiki
#23289: Improving HS reachability for Orbot/Android users
-+-
 Reporter:  n8fr8|  Owner:  n8fr8
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  orbot, mobile, android,  |  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gaba):

 * sponsor:  Sponsor8-can =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23508 [Core Tor/Tor]: large clock skews cause numerous bootstrap UX issues

2019-01-11 Thread Tor Bug Tracker & Wiki
#23508: large clock skews cause numerous bootstrap UX issues
-+-
 Reporter:  catalyst |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Major| Resolution:
 Keywords:  bootstrap, clock-skew, usability,|  Actual Points:
  ux, 032-unreached, s8-errors   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gaba):

 * sponsor:  Sponsor8-can =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23573 [Core Tor/Tor]: Do we want to close all connections when tor closes?

2019-01-11 Thread Tor Bug Tracker & Wiki
#23573: Do we want to close all connections when tor closes?
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  shutdown, privcount, correctness,|  Actual Points:
  chutney-wants, review-group-24,|
  034-triage-20180328, 034-included20180401, |
  035-roadmap-subtask, 035-triaged-in-20180711   |
Parent ID:  #25510   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor19
-+-
Changes (by gaba):

 * sponsor:  Sponsor8 => Sponsor19


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23882 [Core Tor/Tor]: Investigate implementing a Rust allocator wrapping tor_malloc

2019-01-11 Thread Tor Bug Tracker & Wiki
#23882: Investigate implementing a Rust allocator wrapping tor_malloc
-+-
 Reporter:  isis |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, rust-pilot,|  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+-
Changes (by gaba):

 * sponsor:  Sponsor8-can =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24063 [Core Tor/Tor]: Look into battery usage for Tor on Android devices

2019-01-11 Thread Tor Bug Tracker & Wiki
#24063: Look into battery usage for Tor on Android devices
-+-
 Reporter:  ahf  |  Owner:  ahf
 Type:  task | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  s8-battery, s8-201710,   |  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
Parent ID:  #24061   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gaba):

 * sponsor:  Sponsor8 =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28849 [Core Tor/Tor]: Handle dormant mode in process library and for PT's

2019-01-11 Thread Tor Bug Tracker & Wiki
#28849: Handle dormant mode in process library and for PT's
--+
 Reporter:  ahf   |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  High  |  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #28179| Points:
 Reviewer:|Sponsor:  Sponsor19
--+
Changes (by gaba):

 * sponsor:  Sponsor8 => Sponsor19


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24062 [Core Tor/Tor]: CPU profiling of Tor on Android device

2019-01-11 Thread Tor Bug Tracker & Wiki
#24062: CPU profiling of Tor on Android device
-+-
 Reporter:  ahf  |  Owner:  ahf
 Type:  task | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  s8-perf, s8-201710,  |  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
Parent ID:  #24061   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gaba):

 * sponsor:  Sponsor8 =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24061 [Core Tor/Tor]: Collect Baseline Measurements for Different Android Performance Metrics

2019-01-11 Thread Tor Bug Tracker & Wiki
#24061: Collect Baseline Measurements for Different Android Performance Metrics
-+-
 Reporter:  ahf  |  Owner:  ahf
 Type:  project  | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  s8-perf, s8-201710,  |  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gaba):

 * sponsor:  Sponsor8 =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #2681 [Core Tor/Tor]: brainstorm ways to let Tor clients use yesterday's consensus more safely

2019-01-11 Thread Tor Bug Tracker & Wiki
#2681: brainstorm ways to let Tor clients use yesterday's consensus more safely
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop212, tor-client, small-feature,  |  Actual Points:
  tor-dos-dirauth, low-bandwidth, sponsor4,  |
  sponsor8-maybe, 034-triage-20180328,   |
  034-removed-20180328 035-removed   |
  sponsor8-removed   |
Parent ID:  #2664| Points:  5
 Reviewer:   |Sponsor:
-+-
Changes (by gaba):

 * keywords:
 prop212, tor-client, small-feature, tor-dos-dirauth, low-bandwidth,
 sponsor4, sponsor8-maybe, 034-triage-20180328, 034-removed-20180328
 035-removed
 =>
 prop212, tor-client, small-feature, tor-dos-dirauth, low-bandwidth,
 sponsor4, sponsor8-maybe, 034-triage-20180328, 034-removed-20180328
 035-removed sponsor8-removed
 * sponsor:  Sponsor8-can =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

  1   2   >