Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

2019-01-29 Thread Tor Bug Tracker & Wiki
#29120: Default value of media.cache_size (0) causes some media to load 
extremely
slowly or become unplayable
-+-
 Reporter:  QZw2aBQoPyuEVXYVlBps |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-|  Actual Points:
  website, TorBrowserTeam201901R |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28803 [Applications/Tor Browser]: Integrate building pluggable transports for Android into tor-browser-build

2019-01-29 Thread Tor Bug Tracker & Wiki
#28803: Integrate building pluggable transports for Android into 
tor-browser-build
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, TBA-a3, |  Actual Points:
  TorBrowserTeam201901, tor-pt   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by gk):

 * keywords:  tbb-rbm, tbb-mobile, TBA-a3, TorBrowserTeam201901R, tor-pt =>
 tbb-rbm, tbb-mobile, TBA-a3, TorBrowserTeam201901, tor-pt


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29172 [Obfuscation/Snowflake]: Redeploy Snowflake services with go1.11.5 (was: Redeploy Snowflake services with go1.11.15)

2019-01-29 Thread Tor Bug Tracker & Wiki
#29172: Redeploy Snowflake services with go1.11.5
---+-
 Reporter:  dcf|  Owner:  dcf
 Type:  task   | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Obfuscation/Snowflake  |Version:
 Severity:  Normal | Resolution:  implemented
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by dcf):

 * status:  assigned => closed
 * resolution:   => implemented


Comment:

 This is done.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

2019-01-29 Thread Tor Bug Tracker & Wiki
#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201901   |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 I have everything integrated. There are four parts of the project
 currently.

 1) https://github.com/sisbell/Tor_Onion_Proxy_Library
 This is a fork of TOPL with the changes we need for integration with
 OrbotService. I've submitted a pull request. Yaron has some requested
 changes, but they are relatively minor so I'll get this resubmitted this
 week.

 2) https://github.com/sisbell/Tor_Onion_Proxy_Library_Android
 This contains the TOPL android code. Once the changes are merged from (1)
 we can do away with this repo. This project is dependent on (1) and pulls
 it down as part of the build through jitpack

 3) https://github.com/sisbell/tor-android-service
 This contains the merged TOPL and OrbotService code. This project is
 dependent on (2) and pulls it down as part of the build.

 4) https://github.com/sisbell/orbot
 This is a fork of Orbot. I removed the orbotservice code and added the
 dependency on (3). There are no code changes so tor-android-service is
 100% compatible with the current Orbot UI/app implementation.

 {{{
 implementation 'com.github.sisbell:tor-android-
 service:d4deab617b450401b9d5a3aa811ee6cdacaee303'
 }}}
 This repo is just for testing. We will use whatever is going to be
 included in the browser.

 For testing, you can just checkout (4) and import into Android Studio. All
 dependencies are already handled.

 I still need to

  1. Fix changes suggested in the pull request
  1. Add back in code for cookies and hidden services databases.
  1. Do more integration testing to make sure I didn't miss anything
  1. Start tor-browser-build

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29171 [Obfuscation/meek]: Redeploy meek-server instances with go1.11.5

2019-01-29 Thread Tor Bug Tracker & Wiki
#29171: Redeploy meek-server instances with go1.11.5
--+-
 Reporter:  dcf   |  Owner:  dcf
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Obfuscation/meek  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-

Comment (by dcf):

 Done for starman, maenad, GAEuploader.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29146 [Community/Tor Browser Manual]: Add instructions to the Pluggable Transports page on tb-manual

2019-01-29 Thread Tor Bug Tracker & Wiki
#29146: Add instructions to the Pluggable Transports page on tb-manual
--+-
 Reporter:  wayward   |  Owner:  wayward
 Type:  task  | Status:  closed
 Priority:  Medium|  Milestone:
Component:  Community/Tor Browser Manual  |Version:
 Severity:  Normal| Resolution:  implemented
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-
Changes (by wayward):

 * status:  needs_review => closed
 * resolution:   => implemented


Comment:

 Pull request merged to https://tb-manual.torproject.org/transports/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29201 [Core Tor/Tor]: Tor bootstrap hangs when offline

2019-01-29 Thread Tor Bug Tracker & Wiki
#29201: Tor bootstrap hangs when offline
--+
 Reporter:  atagar|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 Hi Nick. When launching a tor process stem uses bootstrap messages to
 determine when the instance we launch is available. Recently-ish tor
 changed such that when offline tor bootstrapping does not progress past
 0%, printing hundreds of...

 {{{
 Jan 29 11:36:27.000 [warn] Problem bootstrapping. Stuck at 0% (starting):
 Starting. (Network is unreachable; NOROUTE; count 11; recommendation warn;
 host 322C6E3A973BC10FC36DE3037AD27BC89F14723B at 212.83.154.33:8443)
 Jan 29 11:36:28.000 [warn] Problem bootstrapping. Stuck at 0% (starting):
 Starting. (Network is unreachable; NOROUTE; count 12; recommendation warn;
 host F741E5124CB12700DA946B78C9B2DD175D6CD2A1 at 163.172.154.162:9001)
 Jan 29 11:36:28.000 [warn] Problem bootstrapping. Stuck at 0% (starting):
 Starting. (Network is unreachable; NOROUTE; count 14; recommendation warn;
 host D71B1CA1C9DC7E8CA64158E106AD770A21160FEE at 185.34.33.2:31415)
 Jan 29 11:36:29.000 [warn] Problem bootstrapping. Stuck at 0% (starting):
 Starting. (Network is unreachable; NOROUTE; count 13; recommendation warn;
 host F2DFE5FA1E4CF54F8E761A6D304B9B4EC69BDAE8 at 129.13.131.140:443)
 Jan 29 11:36:30.000 [warn] Problem bootstrapping. Stuck at 0% (starting):
 Starting. (Network is unreachable; NOROUTE; count 14; recommendation warn;
 host 47C42E2094EE482E7C9B586B10BABFB67557030B at 185.220.101.34:20034)
 Jan 29 11:36:30.000 [warn] Problem bootstrapping. Stuck at 0% (starting):
 Starting. (Network is unreachable; NOROUTE; count 14; recommendation warn;
 host B06F093A3D4DFAD3E923F4F28A74901BD4F74EB1 at 178.17.174.14:9001)
 Jan 29 11:36:31.000 [warn] Problem bootstrapping. Stuck at 0% (starting):
 Starting. (Network is unreachable; NOROUTE; count 15; recommendation warn;
 host CF6D0AAFB385BE71B8E111FC5CFF4B47923733BC at 154.35.175.225:443)
 }}}

 There's a few issues with this...

 1. Poor experience from a user perspective. Deluging the user with
 hundreds of warnings is pretty unhelpful.

 2. Stem's ability to launch tor processes no longer works when offline.

 3. Stem's integ tests no longer pass when offline. I can sidestep this but
 first I'd like to confirm if this is the desired behavior from tor or not.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28614 [Core Tor/Tor]: Can't parse networkstatus consensus time

2019-01-29 Thread Tor Bug Tracker & Wiki
#28614: Can't parse networkstatus consensus time
-+-
 Reporter:  Vort |  Owner:  nickm
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  040-rc-must, regression, |  Actual Points:
  postfreeze-ok, tbb-needs   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * owner:  (none) => nickm
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24351 [Applications/Tor Browser]: Block Global Active Adversary Cloudflare

2019-01-29 Thread Tor Bug Tracker & Wiki
#24351: Block Global Active Adversary Cloudflare
-+-
 Reporter:  nullius  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  reopened
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  security, privacy, anonymity, mitm,  |  Actual Points:
  cloudflare |
Parent ID:  #18361   | Points:  1000
 Reviewer:   |Sponsor:
-+-

Comment (by oppa):

 vRobM, I'm not sure if you're being deliberately misleading, but CF is the
 dictionary definition of a man in the middle. Even if it's not an "attack"
 it's something that people should protect themselves from, especially
 those who can't afford to risk CF subpoenaing their info to governmental
 bodies.

 And of course, it's a contractual service, but it's one most people aren't
 aware of and is violating their privacy. You say "It's a contractual
 service." almost as if that means it can't be an attack on people's
 privacy

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27194 [Core Tor/Tor]: handling extra commas in protover

2019-01-29 Thread Tor Bug Tracker & Wiki
#27194: handling extra commas in protover
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, security-low, 029-backport,|  Actual Points:
  033-backport, 034-backport, 032-unreached- |
  backport, 035-deferred-20190115, 041-proposed  |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by cypherpunks3):

 Replying to [comment:15 ahf]:
 > Maybe we need to merge #27197 and this at the same time?

 Given that this is true, why is this 'needs_revision'?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29193 [Applications/Tor Browser]: obfs4 needs golang.org/x/net/http2

2019-01-29 Thread Tor Bug Tracker & Wiki
#29193: obfs4 needs golang.org/x/net/http2
+--
 Reporter:  boklm   |  Owner:  tbb-team
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  TorBrowserTeam201901R, tbb-rbm  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good to me. Merged to `master` (commit
 23f8101525288ccdd6ccef2035a698c4e9f1b232).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28044 [Applications/Tor Launcher]: Integrate Tor Launcher into tor-browser

2019-01-29 Thread Tor Bug Tracker & Wiki
#28044: Integrate Tor Launcher into tor-browser
-+-
 Reporter:  gk   |  Owner:  brade
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Launcher|Version:
 Severity:  Normal   | Resolution:
 Keywords:  AffectsTails, ux-team,   |  Actual Points:
  TorBrowserTeam201901   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 I posted a draft proposal here:
 https://lists.torproject.org/pipermail/tbb-dev/2019-January/000951.html

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28610 [Core Tor/Tor]: will WTF-PAD impair bandwidth scanning?

2019-01-29 Thread Tor Bug Tracker & Wiki
#28610: will WTF-PAD impair bandwidth scanning?
--+
 Reporter:  starlight |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #28693| Points:
 Reviewer:|Sponsor:  Sponsor2
--+
Changes (by teor):

 * parent:   => #28693


Comment:

 wtf-pad won't impair bandwidth scanning if we turn it off on the bandwidth
 scanner tor instance

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29193 [Applications/Tor Browser]: obfs4 needs golang.org/x/net/http2

2019-01-29 Thread Tor Bug Tracker & Wiki
#29193: obfs4 needs golang.org/x/net/http2
+--
 Reporter:  boklm   |  Owner:  tbb-team
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  TorBrowserTeam201901R, tbb-rbm  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by boklm):

 * keywords:  TorBrowserTeam201901 => TorBrowserTeam201901R, tbb-rbm
 * status:  needs_revision => needs_review


Comment:

 I added a comment in branch `bug_29193_v3`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_29193_v3=23f8101525288ccdd6ccef2035a698c4e9f1b232

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29200 [UX]: Make more accessible Core Tor documentation

2019-01-29 Thread Tor Bug Tracker & Wiki
#29200: Make more accessible Core Tor documentation
+--
 Reporter:  juga|  Owner:  antonela
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  UX  |Version:
 Severity:  Normal  |   Keywords:
Actual Points:  |  Parent ID:
   Points:  |   Reviewer:
  Sponsor:  |
+--
 There's Core Tor documentation distributed in three (at least) sources.
 Even if it's documentation intended for developers, it'd be great that it
 would be more accessible by providing the HTML version online and using
 some torproject.org subdomain or path or links.
 The sources are:
 - The HTML that can be generated from little-t tor code (with doxygen):
 https://people.torproject.org/~nickm/tor-auto/doxygen/
 - Nickm's torgut repository:
 https://gitweb.torproject.org/user/nickm/torguts.git/tree/. Files are in
 markdown, the can be converted to HTML.
 - The documentation included in little-t tor code:
 https://gitweb.torproject.org/tor.git/tree/doc/HACKING (also markdown).

 I can provide scripts to generate/convert the documentation automatically.
 We would need to decide where to put it, maybe get subdomain and get
 access to the server where it would live.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29193 [Applications/Tor Browser]: obfs4 needs golang.org/x/net/http2

2019-01-29 Thread Tor Bug Tracker & Wiki
#29193: obfs4 needs golang.org/x/net/http2
--+
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201901  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  TorBrowserTeam201901R => TorBrowserTeam201901


Comment:

 Could you add a comment and point e.g. to this bug? Otherwise we might
 easily forget why we pinned that specific comment for the nightlies.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29199 [Core Tor/sbws]: log-level cli argument seems to be ignored when using config argument

2019-01-29 Thread Tor Bug Tracker & Wiki
#29199: log-level cli argument seems to be ignored when using config argument
---+---
 Reporter:  juga   |  Owner:  juga
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:  sbws: 1.0.x-final
Component:  Core Tor/sbws  |Version:  sbws: 1.0.2
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor: |
---+---


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29198 [- Select a component]: mhhgg

2019-01-29 Thread Tor Bug Tracker & Wiki
#29198: mhhgg
--+--
 Reporter:  jaja  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Component:  - Select a component
  Version:|   Severity:  Normal
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29197 [Applications/Tor Launcher]: remove use of overlays from Tor Launcher

2019-01-29 Thread Tor Bug Tracker & Wiki
#29197: remove use of overlays from Tor Launcher
---+---
 Reporter:  mcs|  Owner:  brade
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Launcher  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ff68-esr   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by mcs):

 * keywords:   => ff68-esr


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29197 [Applications/Tor Launcher]: remove use of overlays from Tor Launcher

2019-01-29 Thread Tor Bug Tracker & Wiki
#29197: remove use of overlays from Tor Launcher
---+---
 Reporter:  mcs|  Owner:  brade
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Launcher  |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor: |
---+---
 XUL overlay support was removed from Firefox beginning with Firefox 63.
 See https://bugzilla.mozilla.org/show_bug.cgi?id=1449791

 Tor Launcher uses an overlay to allow configuration UI elements to be
 shared between the setup wizard and the Tor Network Settings dialog. We
 will need to replace this with a preprocessor #include strategy or just
 maintain two copies of the XUL.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28716 [Applications/Tor Browser]: Create a mingw-w64-clang project

2019-01-29 Thread Tor Bug Tracker & Wiki
#28716: Create a mingw-w64-clang project
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901R,  |  Actual Points:
  GeorgKoppen201901  |
Parent ID:  #28238   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm, TorBrowserTeam201901, GeorgKoppen201901 => tbb-rbm,
 TorBrowserTeam201901R, GeorgKoppen201901
 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:26 gk]:
 > `ln -s llvm-readobj [% c("arch") %]-w64-mingw32-readobj` is needed too
 (now)

 This is fixed in commit 893aff78867ce85a89d23cb4b9418bb03837bbca on
 `bug_28716_v2` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/log/?h=bug_28716_v2) and I bumped the `mingw-w64` commit, too,
 on that branch (commit 9821668c3fb06c3abe502695635d3dc2f6b8a071) to match
 Mozilla.

 It turns out that the symlink to `llvm-nm` is not needed. I am not sure
 why there is in the Mozilla build script. I omitted it while adjusting the
 build script for `readobj`.

 A squashed version is available as well: `bug_28716_v6_squashed`
 (https://gitweb.torproject.org/user/gk/tor-browser-
 
build.git/commit/?h=bug_28716_v6_squashed=cfbca8437407f3716d910fec71213a5013c54c3a).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28614 [Core Tor/Tor]: Can't parse networkstatus consensus time

2019-01-29 Thread Tor Bug Tracker & Wiki
#28614: Can't parse networkstatus consensus time
-+-
 Reporter:  Vort |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  040-rc-must, regression, |  Actual Points:
  postfreeze-ok, tbb-needs   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 So we need to do two things here:

  * always write a consensus in binary mode

  * on windows, when we encounter a consensus with CRLF in it, strip the
 CRs.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25574 [Core Tor/Tor]: Eliminate "silent-drop" side channels in Tor protocol

2019-01-29 Thread Tor Bug Tracker & Wiki
#25574: Eliminate "silent-drop" side channels in Tor protocol
---+--
 Reporter:  mikeperry  |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  guard-discovery-stats  |  Actual Points:
Parent ID: | Points:  10-30
 Reviewer: |Sponsor:  SponsorV-can
---+--
Changes (by mikeperry):

 * points:  30 => 10-30


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25753 [Core Tor/Tor]: Check/enforce path restrictions for each path position

2019-01-29 Thread Tor Bug Tracker & Wiki
#25753: Check/enforce path restrictions for each path position
-+-
 Reporter:  mikeperry|  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, tor-guard,  |  Actual Points:
  guard-discovery, 034-deferred-20180602,|
  035-removed-20180711   |
Parent ID:  #25546   | Points:  20
 Reviewer:   |Sponsor:
 |  SponsorV-can
-+-
Changes (by mikeperry):

 * points:   => 20


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25574 [Core Tor/Tor]: Eliminate "silent-drop" side channels in Tor protocol

2019-01-29 Thread Tor Bug Tracker & Wiki
#25574: Eliminate "silent-drop" side channels in Tor protocol
---+--
 Reporter:  mikeperry  |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  guard-discovery-stats  |  Actual Points:
Parent ID: | Points:  30
 Reviewer: |Sponsor:  SponsorV-can
---+--
Changes (by mikeperry):

 * points:   => 30


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22728 [Core Tor/Tor]: Long-lived onion service circuits can enable guard discovery

2019-01-29 Thread Tor Bug Tracker & Wiki
#22728: Long-lived onion service circuits can enable guard discovery
---+---
 Reporter:  mikeperry  |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  Tor:
   |  unspecified
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  guard-discovery-stats, tor-hs  |  Actual Points:
Parent ID: | Points:  45
 Reviewer: |Sponsor:
---+---
Changes (by mikeperry):

 * points:   => 45


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25623 [Applications/Tor Browser]: Disable network during build

2019-01-29 Thread Tor Bug Tracker & Wiki
#25623: Disable network during build
---+--
 Reporter:  boklm  |  Owner:  tbb-team
 Type:  task   | Status:  new
 Priority:  High   |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by boklm):

 > < dcf1> Because the goxnet project uses a commit from 2015, which is too
 old to have the x/net/http2 package that obfs4proxy uses.

 Actually we were using a commit from 2015 in the alpha builds, but master
 in the nightly builds, which is why it was working. With #29178 we
 switched back to the commit from 2015 in the nightly builds, which caused
 the build to fail.

 So it seems there is no dynamic downloading of dependencies. However it
 would still be good to prevent network access during the build to make
 sure it's the case.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29193 [Applications/Tor Browser]: obfs4 needs golang.org/x/net/http2

2019-01-29 Thread Tor Bug Tracker & Wiki
#29193: obfs4 needs golang.org/x/net/http2
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201901R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by boklm):

 * status:  new => needs_review
 * keywords:  TorBrowserTeam201901 => TorBrowserTeam201901R


Comment:

 So this build issue is caused by #29178. We were using the master commit
 of `golang.org/x/net`, but switched back to an older commit which doesn't
 provide `golang.org/x/net/http2`. Updating the goxnet commit to the one
 listed in `go.mod` is fixing the issue:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_29193_v2=1a03b88099512b3ccafc6c9b98641ffdb4a80d5d

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #9001 [Core Tor/Tor]: Slow Guard Discovery of Hidden Services and Clients

2019-01-29 Thread Tor Bug Tracker & Wiki
#9001: Slow Guard Discovery of Hidden Services and Clients
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, path-bias, guard-discovery,  |  Actual Points:
  needs-proposal, mike-can, prop247, tor-guard,  |
  032-unreached  |
Parent ID:  #5456| Points:  30-45
 Reviewer:   |Sponsor:
 |  SponsorV
-+-
Changes (by mikeperry):

 * points:  large => 30-45


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29196 [Core Tor/Tor]: circ: Remove p_mux and n_mux from circuit_t and or_circuit_t

2019-01-29 Thread Tor Bug Tracker & Wiki
#29196: circ: Remove p_mux and n_mux from circuit_t and or_circuit_t
---+
 Reporter:  dgoulet|  Owner:  dgoulet
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-cmux, tor-circuit  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by dgoulet):

 * status:  assigned => needs_review


Comment:

 Branch: `ticket29196_041_01`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29196 [Core Tor/Tor]: circ: Remove p_mux and n_mux from circuit_t and or_circuit_t

2019-01-29 Thread Tor Bug Tracker & Wiki
#29196: circ: Remove p_mux and n_mux from circuit_t and or_circuit_t
--+---
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  tor-cmux, tor-circuit
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+---
 They are simply not used apart from assigning a pointer and asserting on
 the pointer depending on direction.

 Complexity that is not needed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29185 [Applications/Tor Browser]: 8.5a7-build3 Windows .exe files are not reproducibly built

2019-01-29 Thread Tor Bug Tracker & Wiki
#29185: 8.5a7-build3 Windows .exe files are not reproducibly built
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201901,|  Actual Points:
  GeorgKoppen201901  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks2):

 {{{
 static LPBYTE generate_icon_group(IconGroup icon, IconPairs order, bool
 first)
 {
   LPBYTE group = new BYTE[
 sizeof(IconGroupHeader) // header
 + order.size() * SIZEOF_RSRC_ICON_GROUP_ENTRY // entries
   ];

   IconGroupHeader* header = (IconGroupHeader*) group;

   header->wReserved = 0;
   header->wIsIcon   = FIX_ENDIAN_INT16(1);
   header->wCount= FIX_ENDIAN_INT16((WORD)icon.size());

   order = sort_pairs(order, first);

   for (IconGroup::size_type i = 0; i < icon.size(); i++)
   {
 RsrcIconGroupEntry* entry = (RsrcIconGroupEntry*)
   [sizeof(IconGroupHeader) + SIZEOF_RSRC_ICON_GROUP_ENTRY * i];
 unsigned index = first ? order[i].index1 : order[i].index2;

 memcpy(>header, [index].meta, sizeof(IconGroupEntry));
 entry->wRsrcId = FIX_ENDIAN_INT16(order[i].size_index + 1);
   }

   return group;
 }
 }}}
 {{{
 #define SIZEOF_RSRC_ICON_GROUP_ENTRY 14
 }}}
 {{{
 typedef struct
 {
   BYTE bWidth;
   BYTE bHeight;
   BYTE bPaletteEntries;
   BYTE bReserved;
   WORD wPlanes;
   WORD wBitsPerPixel;
   DWORD dwRawSize;
 } IconGroupEntry;
 }}}
 Why?

 order.size() == icon.size()? How?

 ZeroMemory for group need.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29185 [Applications/Tor Browser]: 8.5a7-build3 Windows .exe files are not reproducibly built

2019-01-29 Thread Tor Bug Tracker & Wiki
#29185: 8.5a7-build3 Windows .exe files are not reproducibly built
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201901,|  Actual Points:
  GeorgKoppen201901  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks2):

 > Yeah, and just using `torbrowser.ico` instead of the `torbrowser-
 alpha.ico` "fixes" the issue.

 `RT_GROUP_ICON` differs.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28015 [Applications/Tor Browser]: Brainstorm improved ux for orgs that want to give bridges to their people

2019-01-29 Thread Tor Bug Tracker & Wiki
#28015: Brainstorm improved ux for orgs that want to give bridges to their 
people
---+---
 Reporter:  arma   |  Owner:  tbb-team
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ux-team, education, documentation  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:  Sponsor19
---+---

Comment (by eighthave):

 It should be pretty straightforward to use "bridge://" URLs on desktop
 platforms.  I only vaguely know Windows, but I've done this kind of thing
 on GNOME things and on Mac OS X over the years.  Both have a system-wide
 place to register apps that handle certain URL schemes.  So Tor Browser
 would just need to register itself to handle "bridge://" then receive it
 somewhere, and parse it. It should probably also bring up the bridge
 config UI after receiving such a link.

 The trickier case to handle in Tor Browser is perhaps the case where there
 is a bridge URL with an "https://; scheme.  Of course, all platforms will
 direct that to the browser, but only Android can provide strict matching
 of something like
 "https://bridge.torproject.org/config#984ujqw9d82m398end; (perhaps iOS
 also, but I don't know the details there).  Then the question is: if Tor
 Browser receives such a URL, is it appropriate for it to intercept that
 URL and show the bridge config UI instead of the web page?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28226 [Core Tor/Tor]: Backend for an async publish-subcribe messaging system for cross-module communications

2019-01-29 Thread Tor Bug Tracker & Wiki
#28226: Backend for an async publish-subcribe messaging system for cross-module
communications
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-pubsub, sponsor31-maybe  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  catalyst |Sponsor:  Sponsor31-can
-+-

Comment (by nickm):

 Note from Catalyst: In "Add MESG as a new log domain.", N_LOGGING_DOMAINS
 needs to be incremented.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28716 [Applications/Tor Browser]: Create a mingw-w64-clang project

2019-01-29 Thread Tor Bug Tracker & Wiki
#28716: Create a mingw-w64-clang project
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901,   |  Actual Points:
  GeorgKoppen201901  |
Parent ID:  #28238   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by tom):

 Replying to [comment:28 gk]:
 > Replying to [comment:27 gk]:
 > > Hm, so for 32bit it seems we are running out of memory during linking
 xul.dll which did not happen before. I verify that with a second machine.
 >
 > It seems bug 1475562 is the reason for that. I wonder how the 32bit
 build does not fail on Mozilla's side, but it's at least not a toolchain
 issue.

 IIRC we build on c4.4xlarge and c5.4xlarge which have 30 and 32 GB of
 RAM

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29194 [Applications/rbm]: Set DEBIAN_FRONTEND=noninteractive when installing packages

2019-01-29 Thread Tor Bug Tracker & Wiki
#29194: Set DEBIAN_FRONTEND=noninteractive when installing packages
---+---
 Reporter:  boklm  |  Owner:  boklm
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Applications/rbm   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorBrowserTeam201901, tbb-rbm  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by boklm):

 * cc: tbb-team (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29194 [Applications/rbm]: Set DEBIAN_FRONTEND=noninteractive when installing packages (was: Build of buster container for https-everywhere is getting stuck)

2019-01-29 Thread Tor Bug Tracker & Wiki
#29194: Set DEBIAN_FRONTEND=noninteractive when installing packages
---+---
 Reporter:  boklm  |  Owner:  boklm
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Applications/rbm   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorBrowserTeam201901, tbb-rbm  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by boklm):

 * owner:  tbb-team => boklm
 * component:  Applications/Tor Browser => Applications/rbm


Comment:

 It seems using the `-y` argument with `apt-get install` is enough to
 remove all configuration prompts, but not all of them. We should add the
 `DEBIAN_FRONTEND=noninteractive` environment variable, and maybe the `-q`
 argument.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28716 [Applications/Tor Browser]: Create a mingw-w64-clang project

2019-01-29 Thread Tor Bug Tracker & Wiki
#28716: Create a mingw-w64-clang project
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901,   |  Actual Points:
  GeorgKoppen201901  |
Parent ID:  #28238   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:27 gk]:
 > Hm, so for 32bit it seems we are running out of memory during linking
 xul.dll which did not happen before. I verify that with a second machine.

 It seems bug 1475562 is the reason for that. I wonder how the 32bit build
 does not fail on Mozilla's side, but it's at least not a toolchain issue.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28614 [Core Tor/Tor]: Can't parse networkstatus consensus time

2019-01-29 Thread Tor Bug Tracker & Wiki
#28614: Can't parse networkstatus consensus time
-+-
 Reporter:  Vort |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  040-rc-must, regression, |  Actual Points:
  postfreeze-ok, tbb-needs   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arma):

 Or maybe I am looking at this bug the wrong way around: how did it come to
 have \r's in it on disk? I assume it's because we wrote it with Windows-
 style O_TEXT which added the \r's. So if we want it to not have \r's in it
 when we read it, we need to write it in O_BINARY mode too? And then there
 will still be the edge case where we try to load a legacy file which has
 \r's in it, and we should teach ourselves to handle that case better (e.g.
 discard it and fetch another right then)?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29185 [Applications/Tor Browser]: 8.5a7-build3 Windows .exe files are not reproducibly built

2019-01-29 Thread Tor Bug Tracker & Wiki
#29185: 8.5a7-build3 Windows .exe files are not reproducibly built
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201901,|  Actual Points:
  GeorgKoppen201901  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:10 cypherpunks2]:
 > torbrowser.ico 23.4 KB
 > torbrowser-alpha.ico 117 KB

 Yeah, and just using `torbrowser.ico` instead of the `torbrowser-
 alpha.ico` "fixes" the issue.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29185 [Applications/Tor Browser]: 8.5a7-build3 Windows .exe files are not reproducibly built

2019-01-29 Thread Tor Bug Tracker & Wiki
#29185: 8.5a7-build3 Windows .exe files are not reproducibly built
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201901,|  Actual Points:
  GeorgKoppen201901  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks2):

 > `Reserved` undefined?

 Nope.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29195 [Internal Services/Service - lists]: Create anti-censorship team mailing list

2019-01-29 Thread Tor Bug Tracker & Wiki
#29195: Create anti-censorship team mailing list
---+-
 Reporter:  ahf|  Owner:  qbi
 Type:  task   | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Internal Services/Service - lists  |Version:
 Severity:  Normal | Resolution:  invalid
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by ahf):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 Hold on with this, it sounds like we don't have consensus on doing this
 yet.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29195 [Internal Services/Service - lists]: Create anti-censorship team mailing list

2019-01-29 Thread Tor Bug Tracker & Wiki
#29195: Create anti-censorship team mailing list
---+-
 Reporter:  ahf|  Owner:  qbi
 Type:  task   | Status:  new
 Priority:  Medium |  Milestone:
Component:  Internal Services/Service - lists  |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor: |
---+-
 IMPORTANT: This list needs to be private (like the network-team@ list.)
 and
 invite only.

 This list will be used for internal team emails (sick leave, vacation,
 internal
 coordination, etc.) for the anti-censorship team.

 Initial members should be:

 - p...@torproject.org
 - coh...@torproject.org
 - g...@torproject.org
 - a...@torproject.org
 - a...@torproject.org

 Name: `anti-censorship-t...@lists.torproject.org`
 Maintainer (for now): `g...@torproject.org`, `a...@torproject.org`
 Description: `Team mailing list for the anti-censorship team.`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29194 [Applications/Tor Browser]: Build of buster container for https-everywhere is getting stuck

2019-01-29 Thread Tor Bug Tracker & Wiki
#29194: Build of buster container for https-everywhere is getting stuck
---+--
 Reporter:  boklm  |  Owner:  tbb-team
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorBrowserTeam201901, tbb-rbm  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by boklm):

 As buster is still changing a lot, causing some breakages, maybe we could
 think about building our own python 3.6 on a stable Debian release instead
 of using buster.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29194 [Applications/Tor Browser]: Build of buster container for https-everywhere is getting stuck

2019-01-29 Thread Tor Bug Tracker & Wiki
#29194: Build of buster container for https-everywhere is getting stuck
-+-
 Reporter:  boklm|  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  TorBrowserTeam201901,
 Severity:  Normal   |  tbb-rbm
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 The build of the buster container image used for building https-everywhere
 is getting stuck because a configuration windows for setting up the
 `tango-common` package is waiting for input.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29185 [Applications/Tor Browser]: 8.5a7-build3 Windows .exe files are not reproducibly built

2019-01-29 Thread Tor Bug Tracker & Wiki
#29185: 8.5a7-build3 Windows .exe files are not reproducibly built
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201901,|  Actual Points:
  GeorgKoppen201901  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks2):

 {{{
 IMAGE_RESOURCE_DATA_ENTRY rDataE = {0,};
 rDataE.CodePage = ConvertEndianness(cRDataE->GetCodePage());
 rDataE.Size = ConvertEndianness(cRDataE->GetSize());

 CopyMemory(seeker, , sizeof(IMAGE_RESOURCE_DATA_ENTRY));
 }}}
 {{{
 typedef struct _IMAGE_RESOURCE_DATA_ENTRY {
   DWORD OffsetToData;
   DWORD Size;
   DWORD CodePage;
   DWORD Reserved;
 } IMAGE_RESOURCE_DATA_ENTRY,*PIMAGE_RESOURCE_DATA_ENTRY;
 }}}
 `Reserved` undefined?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28869 [Core Tor/sbws]: KeyboardInterrupt will cause a callback error and does not close the thread pool cleanly

2019-01-29 Thread Tor Bug Tracker & Wiki
#28869: KeyboardInterrupt will cause a callback error and does not close the 
thread
pool cleanly
---+---
 Reporter:  juga   |  Owner:  (none)
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:  sbws: 1.0.x-final
Component:  Core Tor/sbws  |Version:  sbws: 1.0.2
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #28663 | Points:
 Reviewer:  asn|Sponsor:
---+---
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 LGTM!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29193 [Applications/Tor Browser]: obfs4 needs golang.org/x/net/http2

2019-01-29 Thread Tor Bug Tracker & Wiki
#29193: obfs4 needs golang.org/x/net/http2
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201901  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by yawning):

 The correct way to fix all of these issues permanently is #28325.

 The `go.mod` and `go.sum` files in the repository specify all dependencies
 used (at the repository level), the exact versions, and a cryptographic
 digest of said dependency check-out.

 https://github.com/golang/go/wiki/Modules#should-i-commit-my-gosum-file-
 as-well-as-my-gomod-file
 https://tip.golang.org/cmd/go/#hdr-Module_downloading_and_verification

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25623 [Applications/Tor Browser]: Disable network during build

2019-01-29 Thread Tor Bug Tracker & Wiki
#25623: Disable network during build
---+--
 Reporter:  boklm  |  Owner:  tbb-team
 Type:  task   | Status:  new
 Priority:  High   |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by gk):

 Replying to [comment:1 boklm]:
 > Yesterday dcf said on IRC:
 > {{{
 > < dcf1> boklm: I wonder if the obfs4 build is downloading dependencies
 dynamically at build time.
 > < dcf1> Because the goxnet project uses a commit from 2015, which is too
 old to have the x/net/http2 package that obfs4proxy uses.
 > < dcf1> I noticed this because I just tried building a version of meek
 that has the same dependency, and it failed.
 > < dcf1> So I'm not sure where obfs4 is getting its
 golang.org/x/net/http2 from.
 > }}}

 See: #29193. We suddenly need that package (our nightly builds fail hard
 now). That might be due to #29178 and might give some clues about the
 issue dcf had/has.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28614 [Core Tor/Tor]: Can't parse networkstatus consensus time

2019-01-29 Thread Tor Bug Tracker & Wiki
#28614: Can't parse networkstatus consensus time
-+-
 Reporter:  Vort |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  040-rc-must, regression, |  Actual Points:
  postfreeze-ok, tbb-needs   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arma):

 Hint: in maint-0.3.5's src/feature/nodelist/networkstatus.c's
 networkstatus_read_cached_consensus_impl(), we call
 {{{
   char *result = read_file_to_str(filename, RFTS_IGNORE_MISSING, NULL);
 }}}
 Note that we don't pass it the RFTS_BIN flag, which means
 tor_open_cloexec()'s open() ultimately uses O_TEXT rather than O_BINARY
 for its flags.

 But 0.4.0's networkstatus_map_cached_consensus_impl()'s tor_mmap_file()
 doesn't have the same Windows notion of O_TEXT.

 And on Linux, open() doesn't care if it's binary or text because they're
 the same thing, so Linux (and really everything other than Windows)
 continued to work when we shifted from text to binary in 0.4.0.

 Of course, for extra fun notice that we seem to have a Windows-specific
 mmap implementation: see the #elif _WIN32 version of tor_mmap_file().

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29193 [Applications/Tor Browser]: obfs4 needs golang.org/x/net/http2

2019-01-29 Thread Tor Bug Tracker & Wiki
#29193: obfs4 needs golang.org/x/net/http2
--+
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
  |  TorBrowserTeam201901
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 The nightly build from today fails to build obfs4 with the following
 error:
 {{{
 
/var/tmp/dist/gopath/src/gitlab.com/yawning/obfs4.git/transports/meeklite/transport.go:31:2:
 cannot find package "golang.org/x/net/http2" in any of:
 /var/tmp/dist/go/src/golang.org/x/net/http2 (from $GOROOT)
 /var/tmp/dist/gopath/src/golang.org/x/net/http2 (from $GOPATH)
 }}}

 I am not sure why the previous build did not fail. This might be related
 to the changes from #29178.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28716 [Applications/Tor Browser]: Create a mingw-w64-clang project

2019-01-29 Thread Tor Bug Tracker & Wiki
#28716: Create a mingw-w64-clang project
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901,   |  Actual Points:
  GeorgKoppen201901  |
Parent ID:  #28238   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Hm, so for 32bit it seems we are running out of memory during linking
 xul.dll which did not happen before. I verify that with a second machine.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29192 [Applications/Tor Browser]: Make sure our extensions are enabled in Private Browsing Mode in Tor Browser based on ESR 68

2019-01-29 Thread Tor Bug Tracker & Wiki
#29192: Make sure our extensions are enabled in Private Browsing Mode in Tor
Browser based on ESR 68
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  ff68-esr
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 https://bugzilla.mozilla.org/show_bug.cgi?id=1511636 landed and has
 support for disabling extensions by default in Private Browsing Mode. We
 should make sure we are not affected by that for extensions we ship by
 default. I wonder whether we want to have this enabled for all the other
 extensions, though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29191 [- Select a component]: useranonim

2019-01-29 Thread Tor Bug Tracker & Wiki
#29191: useranonim
--+
 Reporter:  useranonim|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  - Select a component  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by useranonim):

 * Attachment "tmp_21280-atkritka_1454677676_9028378992882953209241.jpg"
 added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29191 [- Select a component]: useranonim

2019-01-29 Thread Tor Bug Tracker & Wiki
#29191: useranonim
+--
 Reporter:  useranonim  |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Component:  - Select a component
  Version:  |   Severity:  Normal
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs