Re: [tor-bugs] #29217 [Core Tor/Tor]: Script to add new tor files and modules in rust and/or C

2019-08-01 Thread Tor Bug Tracker & Wiki
#29217: Script to add new tor files and modules in rust and/or C
+--
 Reporter:  nickm   |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  network-team-roadmap-september  |  Actual Points:
Parent ID:  | Points:  2
 Reviewer:  |Sponsor:
|  Sponsor31-can
+--

Comment (by teor):

 Nick, it looks like add_c_file.py was added in commit 2f31c8146f in
 0.4.1.2-alpha.

 But it has a bug: the suggested usage fails with:
 {{{
 $ scripts/maint/add_c_file.py ./src/feature/dirauth/ocelot.c
 Made files successfully but couldn't identify include.am for
 ./src/feature/dirauth/ocelot.c
 Exit 1
 }}}

 The correct usage has no "./":
 {{{
 $ scripts/maint/add_c_file.py src/feature/dirauth/ocelot.c
 }}}

 We should fix the usage, or make topdir_file() use python's canonical path
 functions.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31313 [Applications/GetTor]: Don't rely on RecommendedTBBVersions to create download links

2019-08-01 Thread Tor Bug Tracker & Wiki
#31313: Don't rely on RecommendedTBBVersions to create download links
-+--
 Reporter:  phw  |  Owner:  (none)
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:  0.5
 Reviewer:  hiro |Sponsor:
-+--
Changes (by phw):

 * status:  new => needs_review
 * reviewer:   => hiro


Comment:

 I have a fix in my [https://dip.torproject.org/phw/gettor/tree/fix/31313
 fix/31313] branch. While I was at it, I also fixed a number of minor style
 and formatting issues.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31320 [Core Tor/Tor]: Add an IPv6 ORPort example to the torrcminimal.in-staging and torrc-sample.in files

2019-08-01 Thread Tor Bug Tracker & Wiki
#31320: Add an IPv6 ORPort example to the torrcminimal.in-staging and torrc-
sample.in files
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  tor-relay, ipv6, doc, fast-fix
Actual Points:|  Parent ID:
   Points:  0.2   |   Reviewer:
  Sponsor:|
--+
 We don't currently have any IPv6 ORPorts in the example torrc files, but
 we should.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31319 [Core Tor/Tor]: Document logs that are excluded from the control port log event

2019-08-01 Thread Tor Bug Tracker & Wiki
#31319: Document logs that are excluded from the control port log event
-+-
 Reporter:  teor |  Owner:  teor
 Type:   | Status:  assigned
  enhancement|
 Priority:  Medium   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  tor-spec network-team-roadmap-
 Severity:  Normal   |  august
Actual Points:  0.1  |  Parent ID:  #30901
   Points:  0.1  |   Reviewer:
  Sponsor:   |
  Sponsor31-can  |
-+-
 Control spec changes for #30901.

 See my pull request:
 https://github.com/torproject/torspec/pull/88

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31319 [Core Tor/Tor]: Document logs that are excluded from the control port log event

2019-08-01 Thread Tor Bug Tracker & Wiki
#31319: Document logs that are excluded from the control port log event
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-spec network-team-roadmap-   |  Actual Points:  0.1
  august |
Parent ID:  #30901   | Points:  0.1
 Reviewer:   |Sponsor:
 |  Sponsor31-can
-+-
Changes (by teor):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31311 [Core Tor/Tor]: practracker: do not include unwanted files in distribution

2019-08-01 Thread Tor Bug Tracker & Wiki
#31311: practracker: do not include unwanted files in distribution
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  practracker, tech-debt,  |  Actual Points:
  refactoring, easy, 041-deferred-20190530,  |
  network-team-roadmap-july, dgoulet-merge,  |
  041-must   |
Parent ID:  #29746   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor31-must
-+-
Changes (by nickm):

 * priority:  Medium => High


Comment:

 Calling this high because it is 041-must

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31318 [Applications/Tor Browser]: Navigating back on youtube doesn't work

2019-08-01 Thread Tor Bug Tracker & Wiki
#31318: Navigating back on youtube doesn't work
+--
 Reporter:  cypherpunks |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  Medium  |  Component:  Applications/Tor Browser
  Version:  |   Severity:  Normal
 Keywords:  tbb-usability-  |  Actual Points:
  website   |
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
 Really annoying.

 https://bugzilla.mozilla.org/show_bug.cgi?id=1437266

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31314 [Core Tor/Tor]: Modify git-merge-forward.sh so it can create test merge branches

2019-08-01 Thread Tor Bug Tracker & Wiki
#31314: Modify git-merge-forward.sh so it can create test merge branches
--+---
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  git-scripts   |  Actual Points:
Parent ID:  #31178| Points:  1
 Reviewer:|Sponsor:  Sponsor31-can
--+---
Changes (by teor):

 * parent:   => #31178


Comment:

 Replying to [comment:3 gaba]:
 > Teor: I'm not seeing this ticket in the roadmap that we drafted in July.

 It's part of #31178.

 I'm not sure if we will do the other part of #31178, which is the
 automatic pull requests.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31314 [Core Tor/Tor]: Modify git-merge-forward.sh so it can create test merge branches

2019-08-01 Thread Tor Bug Tracker & Wiki
#31314: Modify git-merge-forward.sh so it can create test merge branches
--+---
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  git-scripts   |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:  Sponsor31-can
--+---

Comment (by gaba):

 Teor: I'm not seeing this ticket in the roadmap that we drafted in July.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30827 [Core Tor/Stem]: Stem CI: remove 0.3.4 builds; add 0.4.1

2019-08-01 Thread Tor Bug Tracker & Wiki
#30827: Stem CI: remove 0.3.4 builds; add 0.4.1
---+---
 Reporter:  nickm  |  Owner:  teor
 Type:  task   | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:  0.1
Parent ID:  #30835 | Points:  0.1
 Reviewer: |Sponsor:  Sponsor31-can
---+---
Changes (by teor):

 * status:  assigned => needs_review
 * points:   => 0.1
 * actualpoints:   => 0.1


Comment:

 See my pull request, which adds jobs for 0.4.0-nightly and 0.4.1-nightly:
 https://github.com/torproject/stem/pull/19

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30827 [Core Tor/Stem]: Stem CI: remove 0.3.4 builds; add 0.4.1

2019-08-01 Thread Tor Bug Tracker & Wiki
#30827: Stem CI: remove 0.3.4 builds; add 0.4.1
---+---
 Reporter:  nickm  |  Owner:  teor
 Type:  task   | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #30835 | Points:
 Reviewer: |Sponsor:  Sponsor31-can
---+---
Changes (by teor):

 * owner:  (none) => teor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30826 [Core Tor/Chutney]: Chutney travis: remove 0.3.4, add 0.4.1

2019-08-01 Thread Tor Bug Tracker & Wiki
#30826: Chutney travis: remove 0.3.4, add 0.4.1
---+--
 Reporter:  nickm  |  Owner:  (none)
 Type:  task   | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: unspecified
Component:  Core Tor/Chutney   |Version:
 Severity:  Normal | Resolution:
 Keywords:  041-deferred-20190719  |  Actual Points:  0.1
Parent ID:  #30835 | Points:  0.1
 Reviewer:  nickm  |Sponsor:  Sponsor31-can
---+--
Changes (by teor):

 * status:  new => needs_review
 * reviewer:   => nickm
 * points:   => 0.1
 * actualpoints:   => 0.1


Comment:

 See my pull request, which adds 0.4.0-nightly and 0.4.1-nightly jobs:
 https://github.com/torproject/chutney/pull/36

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31317 [Core Tor/Stem]: Stop reading ~/.torrc during stem's test_hush_argument

2019-08-01 Thread Tor Bug Tracker & Wiki
#31317: Stop reading ~/.torrc during stem's test_hush_argument
---+
 Reporter:  teor   |  Owner:  atagar
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by teor):

 * owner:  (none) => atagar
 * component:  - Select a component => Core Tor/Stem


Old description:

> In #30102, we put random data in ~/.torrc, which breaks stem's
> test_hush_argument test.
>
> {{{
> ==
> FAIL: test_hush_argument
> --
> Traceback (most recent call last):
>   File "/home/travis/build/torproject/tor/stem/stem/util/test_tools.py",
> line 152, in 
> self.method = lambda test: self.result(test)  # method that can be
> mixed into TestCases
>   File "/home/travis/build/torproject/tor/stem/stem/util/test_tools.py",
> line 225, in result
> test.fail(self._result.msg)
> AssertionError: Expected '[warn] Failed to parse/validate config: Unknown
> option 'invalid_argument'.  Failing.' to be within 'Aug 01 20:10:11.551
> [warn] Failed to parse/validate config: Unknown option '����QT��
> ~��V���vLҶ�
> ���\��ޠ@qw�F��0v��$5�EJ��hܱd�FӺTm��Oo'.  Failing.
> Aug 01 20:10:11.562 [err] Reading config failed--see warnings above.
> '
> --
> }}}
> https://travis-ci.org/torproject/tor/jobs/566642646#L4609

New description:

 In #30102, we put random data in ~/.torrc, which breaks stem's
 test_hush_argument test.

 {{{
 ==
 FAIL: test_hush_argument
 --
 Traceback (most recent call last):
   File "/home/travis/build/torproject/tor/stem/stem/util/test_tools.py",
 line 152, in 
 self.method = lambda test: self.result(test)  # method that can be
 mixed into TestCases
   File "/home/travis/build/torproject/tor/stem/stem/util/test_tools.py",
 line 225, in result
 test.fail(self._result.msg)
 AssertionError: Expected '[warn] Failed to parse/validate config: Unknown
 option 'invalid_argument'.  Failing.' to be within 'Aug 01 20:10:11.551
 [warn] Failed to parse/validate config: Unknown option 'QT��
 ~��V���vLҶ�
 ���\��ޠ@qw�F��0v��$5�EJ��hܱd�FӺTm��Oo'.  Failing.
 Aug 01 20:10:11.562 [err] Reading config failed--see warnings above.
 '
 --
 }}}
 https://travis-ci.org/torproject/tor/jobs/566642646#L4609

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31317 [- Select a component]: Stop reading ~/.torrc during stem's test_hush_argument

2019-08-01 Thread Tor Bug Tracker & Wiki
#31317: Stop reading ~/.torrc during stem's test_hush_argument
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  - Select a component  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 In #30102, we put random data in ~/.torrc, which breaks stem's
 test_hush_argument test.

 {{{
 ==
 FAIL: test_hush_argument
 --
 Traceback (most recent call last):
   File "/home/travis/build/torproject/tor/stem/stem/util/test_tools.py",
 line 152, in 
 self.method = lambda test: self.result(test)  # method that can be
 mixed into TestCases
   File "/home/travis/build/torproject/tor/stem/stem/util/test_tools.py",
 line 225, in result
 test.fail(self._result.msg)
 AssertionError: Expected '[warn] Failed to parse/validate config: Unknown
 option 'invalid_argument'.  Failing.' to be within 'Aug 01 20:10:11.551
 [warn] Failed to parse/validate config: Unknown option '����QT��
 ~��V���vLҶ�
 ���\��ޠ@qw�F��0v��$5�EJ��hܱd�FӺTm��Oo'.  Failing.
 Aug 01 20:10:11.562 [err] Reading config failed--see warnings above.
 '
 --
 }}}
 https://travis-ci.org/torproject/tor/jobs/566642646#L4609

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31316 [Applications/Tor Browser]: macOS 10.15 crash on startup

2019-08-01 Thread Tor Bug Tracker & Wiki
#31316: macOS 10.15 crash on startup
--+--
 Reporter:  mprogers  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  High  |  Component:  Applications/Tor Browser
  Version:  Tor: unspecified  |   Severity:  Normal
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
 Tor crashes on startup.

 Crashed Thread:0  Dispatch queue: com.apple.main-thread

 Exception Type:EXC_BAD_ACCESS (SIGSEGV)
 Exception Codes:   EXC_I386_GPFLT
 Exception Note:EXC_CORPSE_NOTIFY

 Termination Signal:Segmentation fault: 11
 Termination Reason:Namespace SIGNAL, Code 0xb
 Terminating Process:   exc handler [1385]

 This is with Tor version 8.5.4, running on macOS 10.15 beta 5 (19A526h)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31315 [Core Tor/Stem]: Please update the fallback cache in stem

2019-08-01 Thread Tor Bug Tracker & Wiki
#31315: Please update the fallback cache in stem
---+
 Reporter:  teor   |  Owner:  atagar
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Description changed by teor:

Old description:

> > TESTING FAILED (197 seconds)
> 1322
> >  [RUN_OPEN] test_cache_is_up_to_date
> (test.integ.directory.fallback.TestFallback) ... FAIL
>
> https://travis-ci.org/torproject/stem/jobs/565752373#L1321

New description:

 > TESTING FAILED (197 seconds)
 >  [RUN_OPEN] test_cache_is_up_to_date
 (test.integ.directory.fallback.TestFallback) ... FAIL

 https://travis-ci.org/torproject/stem/jobs/565752373#L1321

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31315 [Core Tor/Stem]: Please update the fallback cache in stem

2019-08-01 Thread Tor Bug Tracker & Wiki
#31315: Please update the fallback cache in stem
---+
 Reporter:  teor   |  Owner:  atagar
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor: |
---+
 > TESTING FAILED (197 seconds)
 1322
 >  [RUN_OPEN] test_cache_is_up_to_date
 (test.integ.directory.fallback.TestFallback) ... FAIL

 https://travis-ci.org/torproject/stem/jobs/565752373#L1321

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30591 [Core Tor/Tor]: Make tor's Travis stem job log controller messages from stem and tor

2019-08-01 Thread Tor Bug Tracker & Wiki
#30591: Make tor's Travis stem job log controller messages from stem and tor
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci-fail-sometimes, stem, |  Actual Points:  0.8
  041-should |
Parent ID:  #29437   | Points:  0.1
 Reviewer:  catalyst |Sponsor:
 |  Sponsor31-can
-+-

Comment (by teor):

 Replying to [comment:35 nickm]:
 > This looks okay to me.  We may want further refinements on how we show
 the log, but it won't hurt anybody to merge this to 0.4.1.  Please let me
 know whether you would prefer to merge now or wait until #30901 has
 landed.

 Let's merge now, because the stem job currently fails with:

 > The job exceeded the maximum log length, and has been terminated.
 https://travis-ci.org/torproject/tor/jobs/566642646#L30259

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29024 [Core Tor/Chutney]: Add pluggable-transport support to Chutney

2019-08-01 Thread Tor Bug Tracker & Wiki
#29024: Add pluggable-transport support to Chutney
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Chutney |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-pt, 041-accepted-20190115,   |  Actual Points:  1
  network-team-roadmap-2019-Q1Q2, tor-ci,|
  041-deferred-20190530  |
Parent ID:  #29267   | Points:  2
 Reviewer:  teor, nickm  |Sponsor:
 |  Sponsor19
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged to master as 0a83ecf.

 > I opened #30884, #30885, and #30886 for follow up.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31314 [Core Tor/Tor]: Modify git-merge-forward.sh so it can create test merge branches

2019-08-01 Thread Tor Bug Tracker & Wiki
#31314: Modify git-merge-forward.sh so it can create test merge branches
--+---
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  git-scripts   |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:  Sponsor31-can
--+---
Changes (by teor):

 * cc: gaba (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31089 [Core Tor/Tor]: Consider using data-URI to embed how_tor_works_thumb.png image into tor-exit-notice.html

2019-08-01 Thread Tor Bug Tracker & Wiki
#31089: Consider using data-URI to embed how_tor_works_thumb.png image into tor-
exit-notice.html
-+-
 Reporter:  rl1987   |  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Trivial  | Resolution:
 Keywords:  security-low, 029-backport,  |  Actual Points:
  035-backport, 040-backport, 041-backport   |
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * keywords:   => security-low, 029-backport, 035-backport, 040-backport,
 041-backport


Comment:

 Loading a remote image is a web bug, so this is a low-severity security
 issue that needs to be backported.

 I can do the backport branches as part of the review. I'll also try to
 modify the git scripts to create backport branches at the same time
 (#31314).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31314 [Core Tor/Tor]: Modify git-merge-forward.sh so it can create test merge branches

2019-08-01 Thread Tor Bug Tracker & Wiki
#31314: Modify git-merge-forward.sh so it can create test merge branches
--+---
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  git-scripts   |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:  Sponsor31-can
--+---
Changes (by teor):

 * sponsor:   => Sponsor31-can


Comment:

 Gaba, I think this ticket was on our roadmap for sponsor 31?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31314 [Core Tor/Tor]: Modify git-merge-forward.sh so it can create test merge branches

2019-08-01 Thread Tor Bug Tracker & Wiki
#31314: Modify git-merge-forward.sh so it can create test merge branches
--+-
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  git-scripts
Actual Points:|  Parent ID:
   Points:  1 |   Reviewer:
  Sponsor:|
--+-
 We should modify git-merge-forward.sh so it takes an optional branch base
 name.

 If the branch base name is set to bug1234, the script should:
 1. Create bug1234_029 from the local maint-0.2.9
 2. Create bug1234_035 from the local maint-0.3.5, and merge bug1234_029
 into it
 3. Repeat step 2 with each supported maint branch, and master

 We might also want to modify git-push-all.sh to take a branch base name,
 and push the branches created by git-merge-forward.sh.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30126 [Applications/Tor Browser]: Make Tor Browser on macOS compatible with Apple's notarization

2019-08-01 Thread Tor Bug Tracker & Wiki
#30126: Make Tor Browser on macOS compatible with Apple's notarization
+--
 Reporter:  gk  |  Owner:  tbb-team
 Type:  task| Status:  new
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-security, TorBrowserTeam201907  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by teor):

 Replying to [comment:28 gk]:
 > Replying to [comment:27 mcs]:
 > > We did find one blocker though: when we tested on a macOS 10.9.x
 system we experienced #26876 again. Since Tor Browser 9.0a4 does not have
 this problem, there must besome difference in how `tor.real` is built for
 your test builds.
 >
 > If you look at `bug_30126_v2` in my `tor-browser-build` repo you see the
 changes I am doing. For `tor.real` in particular I set `export
 MACOSX_DEPLOYMENT_TARGET=10.7`. _That_ alone should not cause this issue.
 A couple of possible options come to mind here: 1) We might need to set it
 earlier, that is before the configure step. 2) It's somehow caused by us
 setting the SDK option to 10.11 now.
 >
 > I suspect you get the same problem with the build 2 in comment:17?

 Tor's workaround for Apple's header declaration bug happens in the
 configure step, so you'll need to `export MACOSX_DEPLOYMENT_TARGET=10.7`
 before tor's configure runs,

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31300 [Applications/Tor Launcher]: Modify Tor Launcher so it is compatible with ESR68

2019-08-01 Thread Tor Bug Tracker & Wiki
#31300: Modify Tor Launcher so it is compatible with ESR68
-+-
 Reporter:  mcs  |  Owner:  brade
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Launcher|Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-nightly,  |  Actual Points:
  TorBrowserTeam201908R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by acat):

 I also tested the `Request bridge` option (had to add bridges to the
 prefs, otherwise the section does not appear). It fails with `Tor
 unexpectedly closed` for me, but it might be an issue that will not
 reproduce with a properly built nightly, so I'm not sure (I copied the
 esr68 Firefox built files over a release tor-browser folder).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31306 [Core Tor/Stem]: getinfo circuit-status misses entries

2019-08-01 Thread Tor Bug Tracker & Wiki
#31306: getinfo circuit-status misses entries
---+---
 Reporter:  blister_green  |  Owner:  atagar
 Type:  defect | Status:  needs_information
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:  Tor: 0.4.0.5
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by atagar):

 * status:  new => needs_information


Comment:

 Hi blister_green. Under the covers get_circuits() calls that get_info()
 command so I'm unsure how the counts could differ...

 https://gitweb.torproject.org/stem.git/tree/stem/control.py#n3542

 Do you have repro steps or anything I can do locally to exemplify this
 issue?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31300 [Applications/Tor Launcher]: Modify Tor Launcher so it is compatible with ESR68

2019-08-01 Thread Tor Bug Tracker & Wiki
#31300: Modify Tor Launcher so it is compatible with ESR68
-+-
 Reporter:  mcs  |  Owner:  brade
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Launcher|Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-nightly,  |  Actual Points:
  TorBrowserTeam201908R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by acat):

 Mostly looks good and works fine for me.

 One small question I have regarding the added css:

 {{{
 +groupbox {
 +  margin-left: 16px;
 +  padding: 8px;
 +  background-color: rgba(215, 215, 219, 0.5);
 }}}

 Where does the `background-color` come from? I checked in my machine with
 current tor-launcher, and I don't see any background-color difference with
 the background, but after this patch I do (see screenshots).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29197 [Applications/Tor Launcher]: remove use of overlays from Tor Launcher

2019-08-01 Thread Tor Bug Tracker & Wiki
#29197: remove use of overlays from Tor Launcher
-+-
 Reporter:  mcs  |  Owner:  brade
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Launcher|Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, ux-team, tbb-9.0-must- |  Actual Points:
  nightly, TorBrowserTeam201908R |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by acat):

 Looks good to me, also tested it and it works fine.

 I find the number of lines changed surprisingly low considering it's
 changing a *.xul file to a *.js :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31300 [Applications/Tor Launcher]: Modify Tor Launcher so it is compatible with ESR68

2019-08-01 Thread Tor Bug Tracker & Wiki
#31300: Modify Tor Launcher so it is compatible with ESR68
-+-
 Reporter:  mcs  |  Owner:  brade
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Launcher|Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-nightly,  |  Actual Points:
  TorBrowserTeam201908R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by acat):

 * Attachment "current.png" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31300 [Applications/Tor Launcher]: Modify Tor Launcher so it is compatible with ESR68

2019-08-01 Thread Tor Bug Tracker & Wiki
#31300: Modify Tor Launcher so it is compatible with ESR68
-+-
 Reporter:  mcs  |  Owner:  brade
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Launcher|Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-nightly,  |  Actual Points:
  TorBrowserTeam201908R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by acat):

 * Attachment "patch.png" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31307 [Applications/GetTor]: Gettor doesn't seem to be responding to email requests

2019-08-01 Thread Tor Bug Tracker & Wiki
#31307: Gettor doesn't seem to be responding to email requests
-+
 Reporter:  pili |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by boklm):

 Replying to [comment:2 phw]:
 > Besides, boklm mentions on IRC that RecommendedTBBVersions is not a good
 way to learn about the current Tor Browser version:

 The reason that RecommendedTBBVersions is not a good way for that is that
 it contains both alpha and stable versions, and sometimes both the current
 and previous versions, so it makes it not easy to find which one in the
 list is the current stable version.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26847 [Applications/Tor Browser]: Tor Browser 8.0, noscript pops up a full-browser-size window to warn me about x-site scripting

2019-08-01 Thread Tor Bug Tracker & Wiki
#26847: Tor Browser 8.0, noscript pops up a full-browser-size window to warn me
about x-site scripting
-+-
 Reporter:  arma |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression,  |  Actual Points:
  noscript, tbb-usability|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 I wholeheartedly agree with what Mike said, in addition the XSS protection
 code seems to cause my CPU to peak at 100% (poor Intel Atom), ma1 should
 really consider converting it to WebAssembly and hopefully WebAssembly
 will be enabled by default in the upcoming Tor Browser 9 alpha.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31313 [Applications/GetTor]: Don't rely on RecommendedTBBVersions to create download links

2019-08-01 Thread Tor Bug Tracker & Wiki
#31313: Don't rely on RecommendedTBBVersions to create download links
-+
 Reporter:  phw  |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:  0.5  |   Reviewer:
  Sponsor:   |
-+
 Over at #31307, we were dealing with a broken GetTor because it made
 assumptions on the list length available at
 https://www.torproject.org/projects/torbrowser/RecommendedTBBVersions/.
 See [https://trac.torproject.org/projects/tor/ticket/31307#comment:2 this
 comment] for more details.

 While our emergency fix worked, boklm mentions on IRC that
 RecommendedTBBVersions is not a good way to learn about the current Tor
 Browser version:
 {{{
  20:46  boklm│ RecommendedTBBVersions is not a good way to get the current
 Tor Browser version
  20:47  boklm│
 https://aus1.torproject.org/torbrowser/update_3/release/downloads.json is
 better
  20:48  boklm│ for example with: wget -q -O -
 https://aus1.torproject.org/torbrowser/update_3/release/downloads.json |
 jq -r .version
 }}}

 Let's use this JSON file instead, and make GetTor more robust.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31307 [Applications/GetTor]: Gettor doesn't seem to be responding to email requests

2019-08-01 Thread Tor Bug Tracker & Wiki
#31307: Gettor doesn't seem to be responding to email requests
-+
 Reporter:  pili |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by phw):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 I believe that the problem is now fixed. It looks like the script
 `~/gettor/scripts/add_lins_to_db` was the culprit. In particular
 
[https://gitweb.torproject.org/gettor.git/tree/scripts/add_lins_to_db?id=007da31780d0de514d6b36b435d2d8e900122f48#n56
 lines 56-58]. The script assumes a list of length 12 but the page over at
 https://www.torproject.org/projects/torbrowser/RecommendedTBBVersions/
 currently returns `[ "8.5.4", "8.5.4-MacOS", "8.5.4-Linux",
 "8.5.4-Windows", "9.0a4", "9.0a4-MacOS", "9.0a4-Linux", "9.0a4-Windows"
 ]`, a list that counts only 8 elements. I added an emergency fix that
 changes
 {{{
 version = versions.split(",")[-12]
 }}}
 to
 {{{
 version = versions.split(",")[0]
 }}}
 I was able to re-generate the database and restart GetTor.

 Besides, boklm mentions on IRC that RecommendedTBBVersions is not a good
 way to learn about the current Tor Browser version:
 {{{
  20:46  boklm│ RecommendedTBBVersions is not a good way to get the current
 Tor Browser version
  20:47  boklm│
 https://aus1.torproject.org/torbrowser/update_3/release/downloads.json is
 better
  20:48  boklm│ for example with: wget -q -O -
 https://aus1.torproject.org/torbrowser/update_3/release/downloads.json |
 jq -r .version
 }}}

 I'll file a separate ticket to make GetTor more robust in this regard.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #1517 [Applications/Tor Browser]: Provide JS with reduced time precision

2019-08-01 Thread Tor Bug Tracker & Wiki
#1517: Provide JS with reduced time precision
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:   | Resolution:  fixed
 Keywords:  backport-to-mozilla, tbb-torbutton,  |  Actual Points:
  tbb-fingerprinting-time-highres, ff38-esr, |
  TorBrowserTeam201505R, PearlCrescent201505R|
Parent ID:   | Points:  10
-+-

Comment (by Thorin):

 Replying to [comment:32 mikeperry]:
 > I looked into this more, and noticed one case where ToSeconds() was
 exposed to content. AnimationFrame events have an elapsedTime field. I
 truncated that timestamp to millisecond accuracy (though in reality, the
 timestamps were varying by as much as 20ms for me).

 Hi Mike ... I'm 4 years late to the party... but I'm doing some "work" on
 some current (and open / unpatched) timing attacks - and the reason AFAIK
 is that 60fps = 16ms

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #30429, #26861, #27045, #27265, ...

2019-08-01 Thread Tor Bug Tracker & Wiki
Batch modification to #30429, #26861, #27045, #27265, #28745, #28822, #29187, 
#29197, #29611, #30199, #30334, #30460, #30461, #30548, #31010, #31045, #31173, 
#31264, #31300 by gk:


Comment:
No July any longer.

--
Tickets URL: 

Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31251 [Applications/Tor Browser]: Security Level menu hangs off of the toolbarbutton element when it should hang off of the toolbarbutton's child element with toolbarbutton-icon class

2019-08-01 Thread Tor Bug Tracker & Wiki
#31251: Security Level menu hangs off of the toolbarbutton element when it 
should
hang off of the toolbarbutton's child element with toolbarbutton-icon class
--+---
 Reporter:  pospeselr |  Owner:  pospeselr
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  TorBrowserTeam201908R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks! Looks good and merged to `tor-browser-60.8.0esr-9.0-1` (commit
 0bed1d181d0839f058e311c01dbdb263a96270fd).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26847 [Applications/Tor Browser]: Tor Browser 8.0, noscript pops up a full-browser-size window to warn me about x-site scripting

2019-08-01 Thread Tor Bug Tracker & Wiki
#26847: Tor Browser 8.0, noscript pops up a full-browser-size window to warn me
about x-site scripting
-+-
 Reporter:  arma |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression,  |  Actual Points:
  noscript, tbb-usability|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mikeperry):

 * keywords:  tbb-8.0-issues, tbb-regression, noscript => tbb-8.0-issues,
 tbb-regression, noscript, tbb-usability


Comment:

 Hrmm, this situation does not seem to have improved. Doubleclick is
 encoding URLs in like all of its ad query params (probably because of the
 referer field not being present for https fetches), and this is getting
 triggered multiple times all over the place. It is making many sites
 unusable for me.

 If we can't eliminate these false positives, I think we should disable
 this XSS protection, certainly by default. With as noisy as it currently
 is, I don't think it should be on unless the security level is at High.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31312 [Internal Services/Tor Sysadmin Team]: Grant phw access to GetTor's machine

2019-08-01 Thread Tor Bug Tracker & Wiki
#31312: Grant phw access to GetTor's machine
-+-
 Reporter:  phw  |  Owner:  anarcat
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by anarcat):

 while i'm here, i removed ilv, nima and sukhbir which are inactive
 according to phw. phw wanted to checkin with hiro first, but we can always
 revert this later.

 besides, the people in that group probably don't know how gettor works
 anymore, since hiro rebuilt it.

 final state:

 {{{
 root@getulum:~# getent group gettor
 gettor:x:1536:hiro,phw
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31312 [Internal Services/Tor Sysadmin Team]: Grant phw access to GetTor's machine

2019-08-01 Thread Tor Bug Tracker & Wiki
#31312: Grant phw access to GetTor's machine
-+-
 Reporter:  phw  |  Owner:  anarcat
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by anarcat):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 request seems legit, signature checks out, phw is team lead and this was
 discussed in today's meeting.

 so: done, and propagated on getulum.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31312 [Internal Services/Tor Sysadmin Team]: Grant phw access to GetTor's machine

2019-08-01 Thread Tor Bug Tracker & Wiki
#31312: Grant phw access to GetTor's machine
-+-
 Reporter:  phw  |  Owner:  anarcat
 Type:  task | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by anarcat):

 * owner:  tpa => anarcat
 * status:  new => assigned


Comment:

 checking

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31143 [Internal Services/Tor Sysadmin Team]: Add cohosh to ldap group snowflake

2019-08-01 Thread Tor Bug Tracker & Wiki
#31143: Add cohosh to ldap group snowflake
-+
 Reporter:  arlolra  |  Owner:  weasel
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by anarcat):

 thanks weasel, i can confirm cohosh has access now... i could have sworn i
 checked for this though..

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31304 [Core Tor/Tor]: Run practracker_tests.py as part of make check

2019-08-01 Thread Tor Bug Tracker & Wiki
#31304: Run practracker_tests.py as part of make check
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  practracker, 042-should, tech-debt,  |  Actual Points:  .1
  refactoring, easy, network-team-roadmap-july   |
Parent ID:  #29746   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  assigned => needs_review
 * actualpoints:   => .1


Comment:

 See branch `ticket31304` with PR at
 https://github.com/torproject/tor/pull/1195 .  This is built on #31311,
 which fixes a bug in how make dist handles the practracker subdirectory.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31311 [Core Tor/Tor]: practracker: do not include unwanted files in distribution

2019-08-01 Thread Tor Bug Tracker & Wiki
#31311: practracker: do not include unwanted files in distribution
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  practracker, tech-debt,  |  Actual Points:
  refactoring, easy, 041-deferred-20190530,  |
  network-team-roadmap-july, dgoulet-merge,  |
  041-must   |
Parent ID:  #29746   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor31-must
-+-
Changes (by nickm):

 * status:  assigned => needs_review
 * keywords:
 practracker, tech-debt, refactoring, easy, 041-deferred-20190530,
 network-team-roadmap-july, dgoulet-merge
 =>
 practracker, tech-debt, refactoring, easy, 041-deferred-20190530,
 network-team-roadmap-july, dgoulet-merge, 041-must


Comment:

 See branch `ticket31311_041` with 0.4.1 PR in
 https://github.com/torproject/tor/pull/1194.  Merges cleanly to master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31307 [Applications/GetTor]: Gettor doesn't seem to be responding to email requests

2019-08-01 Thread Tor Bug Tracker & Wiki
#31307: Gettor doesn't seem to be responding to email requests
-+
 Reporter:  pili |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by phw):

 I also didn't get a response over email.

 GetTor needs a "survival guide" that allows people other than the
 maintainer to resurrect the service. Here are the anti-censorship team's
 survival guides:
 
https://trac.torproject.org/projects/tor/wiki/org/teams/AntiCensorshipTeam#Servicesurvivalguides

 I also filed #31312 to get access to GetTor's machine. I may be able to
 restart GetTor.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31312 [Internal Services/Tor Sysadmin Team]: Grant phw access to GetTor's machine

2019-08-01 Thread Tor Bug Tracker & Wiki
#31312: Grant phw access to GetTor's machine
-+-
 Reporter:  phw  |  Owner:  tpa
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 {{{
 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA256

 GetTor is currently offline and it looks like only hiro has the powers to
 access the service.  Please grant phw access, so he can handle emergencies
 like this when hiro is not around.
 -BEGIN PGP SIGNATURE-

 iQGzBAEBCAAdFiEEvWUVvXkFpAp3gtRWD9lfHTpZekgFAl1DJHYACgkQD9lfHTpZ
 ekjSWAv/ajh0z9vRiVaGwzRtG91zQ1oEmOE+qDFYGvLv+SESRbwD3QS1hS7MhwVo
 VaYU/S32vtjR2V5ZWbD0mqDwnOryyj79eJT1UeNJGL/ySPJJzbbaZsTifKC/QMyL
 BVHcQnlO9fXdxwzDbp/hATxAh3OQrfz9dfSLYvdqWmuEbhdJdJIcRbVwsOTNrNzR
 Rq9JukhUZQrshtZo2r6iP2j6xKxRjsg5FQ9BT8jy8GjJxOpN33bvIoP8t96qdI/r
 CwPoH6hD3AWyE2zmDsV1qLZfzqkH6+soDu/zqQsitSXzoSpKpQ1ntfOzte64TX7j
 WniS3DfzDsRttZbC1h+pn0qkAyekqpmmTRCZZXuQhSYrAGkT86dz7AeRSmE2YDTE
 C+TBkTVERSQK/r3/1qyx6jnwcd9Y/AL7PTpWMrSkDc3ymogEdpauw7qVfW8ctRui
 +1hDTvbc9SqbNiIT4LpE63racUntu9mQ7tSHnoIlfFuLjGE5pR2ia6sZvTEu29WM
 P/7zHobb
 =3eoi
 -END PGP SIGNATURE-
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31251 [Applications/Tor Browser]: Security Level menu hangs off of the toolbarbutton element when it should hang off of the toolbarbutton's child element with toolbarbutton-icon class

2019-08-01 Thread Tor Bug Tracker & Wiki
#31251: Security Level menu hangs off of the toolbarbutton element when it 
should
hang off of the toolbarbutton's child element with toolbarbutton-icon class
--+--
 Reporter:  pospeselr |  Owner:  pospeselr
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201908  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by pospeselr):

 * status:  needs_revision => needs_review


Comment:

 squashed into a new branch:

 tor-browser: https://gitweb.torproject.org/user/richard/tor-
 browser.git/commit/?h=bug_31251_v2

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31251 [Applications/Tor Browser]: Security Level menu hangs off of the toolbarbutton element when it should hang off of the toolbarbutton's child element with toolbarbutton-icon class

2019-08-01 Thread Tor Bug Tracker & Wiki
#31251: Security Level menu hangs off of the toolbarbutton element when it 
should
hang off of the toolbarbutton's child element with toolbarbutton-icon class
--+--
 Reporter:  pospeselr |  Owner:  pospeselr
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201908R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by pospeselr):

 * keywords:  TorBrowserTeam201908 => TorBrowserTeam201908R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31311 [Core Tor/Tor]: practracker: do not include unwanted files in distribution

2019-08-01 Thread Tor Bug Tracker & Wiki
#31311: practracker: do not include unwanted files in distribution
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.4.1.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  practracker, tech-debt,
 Severity:  Normal   |  refactoring, easy, 041-deferred-20190530,
 |  network-team-roadmap-july, dgoulet-merge
Actual Points:   |  Parent ID:  #29746
   Points:   |   Reviewer:
  Sponsor:   |
  Sponsor31-must |
-+-
 Right now, "make dist" grabs the entire contents of the practracker
 directory, including temporary files.  That's not a great idea.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31309 [Core Tor/Tor]: Add envvar to pass options to practracker

2019-08-01 Thread Tor Bug Tracker & Wiki
#31309: Add envvar to pass options to practracker
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  practracker, tech-debt,  |  Actual Points:  0
  refactoring, easy, 041-deferred-20190530,  |
  network-team-roadmap-july  |
Parent ID:  #29746   | Points:  .1
 Reviewer:   |Sponsor:
 |  Sponsor31-can
-+-
Changes (by nickm):

 * status:  assigned => needs_review
 * actualpoints:   => 0


Comment:

 Trivial PR at https://github.com/torproject/tor/pull/1193 .

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31100 [Circumvention/Snowflake]: Firefox addon not reporting any users

2019-08-01 Thread Tor Bug Tracker & Wiki
#31100: Firefox addon not reporting any users
-+-
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Very High|  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Major| Resolution:
 Keywords:  snowflake-webextension anti- |  Actual Points:
  censorship-roadmap-august  |
Parent ID:   | Points:  2
 Reviewer:  dcf  |Sponsor:
 |  Sponsor28
-+-

Comment (by cohosh):

 Replying to [comment:23 dcf]:
 > I had a look. I don't see any obvious problems, but I still feel I don't
 fully understand the relation and meaning of `active` vis-à-vis `running`.
 I'm thinking we'll be better off not trying to reuse `ProxyPairs`, but use
 their presence in the list as an indicator of whether they are in use or
 not -- or perhaps separate lists of "pending" and "active" pairs. But
 what's in the bug31100 branch is good to merge now.

 Yeah I agree with this, that it would be better to refactor the proxy-pair
 usage a bit. This was kind of a quick hack to get the timeout working. We
 need at least two states (that the proxypair responded with an answer to
 the broker, and that a datachannel has actually been opened with the
 client), so I'm not sure mere presence in the list is quite enough. I made
 another ticket #31310 for making a more careful change to the proxy pair
 functionality here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31310 [Circumvention/Snowflake]: Refactor/remove proxy-pair state machine in webextension

2019-08-01 Thread Tor Bug Tracker & Wiki
#31310: Refactor/remove proxy-pair state machine in webextension
-+-
 Reporter:  cohosh   |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   |   Keywords:  snowflake-
 |  webextension
Actual Points:   |  Parent ID:
   Points:  2|   Reviewer:
  Sponsor:   |
-+-
 The snowflake badge and webextension code is heavily based off of flash
 proxy, but the proxy pair state machine, which used attributes such as
 "running" and "active" doesn't map as nicely to the webrtc context. It
 would be nice to refactor this to be simpler, more closely match our
 understanding of the webrtc state machine and be easier to maintain. This
 might mean removing these attributes entirely and using the existence of
 proxy pairs to indicate if there are any open or running connections (see
 https://trac.torproject.org/projects/tor/ticket/31100#comment:23).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30126 [Applications/Tor Browser]: Make Tor Browser on macOS compatible with Apple's notarization

2019-08-01 Thread Tor Bug Tracker & Wiki
#30126: Make Tor Browser on macOS compatible with Apple's notarization
+--
 Reporter:  gk  |  Owner:  tbb-team
 Type:  task| Status:  new
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-security, TorBrowserTeam201907  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by gk):

 Replying to [comment:27 mcs]:
 > Replying to [comment:26 gk]:
 > > Alright: mcs/brade: could you give
 > >
 > > https://people.torproject.org/~gk/testbuilds/TorBrowser-tbb-nightly-
 30126_3-osx64_en-US.dmg
 > > https://people.torproject.org/~gk/testbuilds/TorBrowser-tbb-nightly-
 30126_3-osx64_en-US.dmg.asc
 > >
 > > a round of testing? I think I've fixed all the blockers for
 notarization in our build system now. making sure the whole bundle is
 still running (even on a system < 10.11) would be neat as well. :)
 >
 > The good news is that the notarization process works with that build.

 \o/

 > I am not sure it matters, but the following three files have different
 min OS version and SDK values in their mach-o headers:
 >  Tor Browser.app/Contents/MacOS/Tor/PluggableTransports/meek-client
 >  Tor Browser.app/Contents/MacOS/Tor/PluggableTransports/meek-client-
 torbrowser
 >  Tor Browser.app/Contents/MacOS/Tor/PluggableTransports/obfs4proxy
 > While all other binaries have min OS version 10.7 and SDK 10.11, the
 above three files have 10.9 and 10.9.

 That's expected with the switch to Go >= 1.12.6 and  is okay I think

 > We did find one blocker though: when we tested on a macOS 10.9.x system
 we experienced #26876 again. Since Tor Browser 9.0a4 does not have this
 problem, there must besome difference in how `tor.real` is built for your
 test builds.

 If you look at `bug_30126_v2` in my `tor-browser-build` dir you see the
 changes I am doing. For `tor.real` in particular I set `export
 MACOSX_DEPLOYMENT_TARGET=10.7`. _That_ alone should not cause this issue.
 A couple of possible options come to mind here: 1) We might need to set it
 earlier, that is before the configure step. 2) It's somehow caused by us
 setting the SDK option to 10.11 now.

 I suspect you get the same problem with the build 2 in comment:17?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31011 [Core Tor/Tor]: Make the bridge authority reject private PT addresses when DirAllowPrivateAddresses is 0

2019-08-01 Thread Tor Bug Tracker & Wiki
#31011: Make the bridge authority reject private PT addresses when
DirAllowPrivateAddresses is 0
---+---
 Reporter:  teor   |  Owner:  neel
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:  Tor:
   |  unspecified
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  anti-censorship-roadmap-september  |  Actual Points:
Parent ID:  #31009 | Points:  1
 Reviewer: |Sponsor:
   |  Sponsor28-can
---+---
Changes (by neel):

 * cc: neel (added)
 * status:  new => assigned
 * owner:  (none) => neel


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30126 [Applications/Tor Browser]: Make Tor Browser on macOS compatible with Apple's notarization

2019-08-01 Thread Tor Bug Tracker & Wiki
#30126: Make Tor Browser on macOS compatible with Apple's notarization
+--
 Reporter:  gk  |  Owner:  tbb-team
 Type:  task| Status:  new
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-security, TorBrowserTeam201907  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by mcs):

 Replying to [comment:26 gk]:
 > Alright: mcs/brade: could you give
 >
 > https://people.torproject.org/~gk/testbuilds/TorBrowser-tbb-nightly-
 30126_3-osx64_en-US.dmg
 > https://people.torproject.org/~gk/testbuilds/TorBrowser-tbb-nightly-
 30126_3-osx64_en-US.dmg.asc
 >
 > a round of testing? I think I've fixed all the blockers for notarization
 in our build system now. making sure the whole bundle is still running
 (even on a system < 10.11) would be neat as well. :)

 The good news is that the notarization process works with that build.

 I am not sure it matters, but the following three files have different min
 OS version and SDK values in their mach-o headers:
  Tor Browser.app/Contents/MacOS/Tor/PluggableTransports/meek-client
  Tor Browser.app/Contents/MacOS/Tor/PluggableTransports/meek-client-
 torbrowser
  Tor Browser.app/Contents/MacOS/Tor/PluggableTransports/obfs4proxy
 While all other binaries have min OS version 10.7 and SDK 10.11, the above
 three files have 10.9 and 10.9.

 We did find one blocker though: when we tested on a macOS 10.9.x system we
 experienced #26876 again. Since Tor Browser 9.0a4 does not have this
 problem, there must besome difference in how `tor.real` is built for your
 test builds.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31202 [Core Tor/Tor]: Refactor practracker's issue-listing code to return a generator

2019-08-01 Thread Tor Bug Tracker & Wiki
#31202: Refactor practracker's issue-listing code to return a generator
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  practracker, tech-debt,  |  implemented
  refactoring, easy, 041-deferred-20190530   |  Actual Points:  .3
Parent ID:  #29746   | Points:  .2
 Reviewer:   |Sponsor:
 |  Sponsor31-can
-+-
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => implemented


Comment:

 Merged

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31263 [Core Tor/Tor]: More tests for practracker

2019-08-01 Thread Tor Bug Tracker & Wiki
#31263: More tests for practracker
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  practracker, tech-debt,  |  implemented
  refactoring, easy, 041-deferred-20190530,  |  Actual Points:  .1
  network-team-roadmap-july  |
Parent ID:  #29746   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor31-can
-+-
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => implemented


Comment:

 merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30752 [Core Tor/Tor]: Practracker: usability improvements from May retrospective

2019-08-01 Thread Tor Bug Tracker & Wiki
#30752: Practracker: usability improvements from May retrospective
---+---
 Reporter:  nickm  |  Owner:  nickm
 Type:  enhancement| Status:  closed
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  network-team-roadmap-july  |  Actual Points:  .2
Parent ID:  #29746 | Points:  1.5
 Reviewer:  teor   |Sponsor:  Sponsor31-can
---+---
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Merged

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29746 [Core Tor/Tor]: Improve Tor best practices tracker

2019-08-01 Thread Tor Bug Tracker & Wiki
#29746: Improve Tor best practices tracker
-+-
 Reporter:  asn  |  Owner:  nickm
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  practracker, tech-debt,  |  Actual Points:  .1
  refactoring, easy, 041-deferred-20190530,  |
  network-team-roadmap-july, dgoulet-merge   |
Parent ID:   | Points:  3
 Reviewer:  teor, ahf|Sponsor:
 |  Sponsor31-can
-+-
Changes (by nickm):

 * status:  merge_ready => assigned


Comment:

 Okay, marking this as still assigned (as a parent ticket), and closing the
 appropriate child tickets.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29746 [Core Tor/Tor]: Improve Tor best practices tracker

2019-08-01 Thread Tor Bug Tracker & Wiki
#29746: Improve Tor best practices tracker
-+-
 Reporter:  asn  |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  practracker, tech-debt,  |  Actual Points:  .1
  refactoring, easy, 041-deferred-20190530,  |
  network-team-roadmap-july, dgoulet-merge   |
Parent ID:   | Points:  3
 Reviewer:  teor, ahf|Sponsor:
 |  Sponsor31-can
-+-

Comment (by dgoulet):

 Merged! As requested by nickm, not closing just yet.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30680 [Applications/Tor Browser]: NoScript's click-to-play does not work on Twitter videos (on higher security levels)

2019-08-01 Thread Tor Bug Tracker & Wiki
#30680: NoScript's click-to-play does not work on Twitter videos (on higher
security levels)
---+--
 Reporter:  gk |  Owner:  tbb-team
 Type:  defect | Status:  closed
 Priority:  High   |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  noscript, tbb-security-slider  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by gk):

 * keywords:  noscript => noscript, tbb-security-slider


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30680 [Applications/Tor Browser]: NoScript's click-to-play does not work on Twitter videos (on higher security levels)

2019-08-01 Thread Tor Bug Tracker & Wiki
#30680: NoScript's click-to-play does not work on Twitter videos (on higher
security levels)
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  noscript  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 This actually works for me now with NoScript 11.0.2, nice!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29746 [Core Tor/Tor]: Improve Tor best practices tracker

2019-08-01 Thread Tor Bug Tracker & Wiki
#29746: Improve Tor best practices tracker
-+-
 Reporter:  asn  |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  practracker, tech-debt,  |  Actual Points:  .1
  refactoring, easy, 041-deferred-20190530,  |
  network-team-roadmap-july, dgoulet-merge   |
Parent ID:   | Points:  3
 Reviewer:  teor, ahf|Sponsor:
 |  Sponsor31-can
-+-
Changes (by nickm):

 * status:  needs_revision => merge_ready
 * keywords:
 practracker, tech-debt, refactoring, easy, 041-deferred-20190530,
 network-team-roadmap-july
 =>
 practracker, tech-debt, refactoring, easy, 041-deferred-20190530,
 network-team-roadmap-july, dgoulet-merge


Comment:

 Okay, I've addressed the issues you found, and travis has accepted it.
 Time to merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30752 [Core Tor/Tor]: Practracker: usability improvements from May retrospective

2019-08-01 Thread Tor Bug Tracker & Wiki
#30752: Practracker: usability improvements from May retrospective
---+---
 Reporter:  nickm  |  Owner:  nickm
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  network-team-roadmap-july  |  Actual Points:  .2
Parent ID:  #29746 | Points:  1.5
 Reviewer:  teor   |Sponsor:  Sponsor31-can
---+---

Comment (by nickm):

 Replying to [comment:9 catalyst]:
 > The Makefile should provide a way to pass command line options in to
 practracker from the environment, so CI won't have to run practracker by
 bypassing the Makefile. This can be useful if we want to run with less-
 friendly options during cron builds, for example.

 Created #31309 for this issue.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31309 [Core Tor/Tor]: Add envvar to pass options to practracker

2019-08-01 Thread Tor Bug Tracker & Wiki
#31309: Add envvar to pass options to practracker
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  practracker, tech-debt,
 Severity:  Normal   |  refactoring, easy, 041-deferred-20190530,
 |  network-team-roadmap-july
Actual Points:   |  Parent ID:  #29746
   Points:  .1   |   Reviewer:
  Sponsor:   |
  Sponsor31-can  |
-+-
 On #30752, catalyst notes:
 >The Makefile should provide a way to pass command line options in to
 practracker from the environment, so CI won't have to run practracker by
 bypassing the Makefile. This can be useful if we want to run with less-
 friendly options during cron builds, for example.

 I agree.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31308 [Applications/Tor Browser]: Sync mozconfig files used in tor-browser over to tor-browser-build for esr68

2019-08-01 Thread Tor Bug Tracker & Wiki
#31308: Sync mozconfig files used in tor-browser over to tor-browser-build for
esr68
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  ff68-esr, tbb-9.0-must-
 Severity:  Normal   |  alpha, tbb-rbm,
 |  TorBrowserTeam201908
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 If we don't make sufficient progress on #23656 this time we should at
 least make sure all the `mozconfig` files we use for our official builds
 contain all the things they should contain (and only those) (the
 `--enable-proxy-bypass-protection` option is one of them; the
 `MOZILLA_OFFICIAL` changes as well)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30281 [Core Tor/Tor]: Sponsor27 master ticket

2019-08-01 Thread Tor Bug Tracker & Wiki
#30281: Sponsor27 master ticket
--+--
 Reporter:  asn   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:  Sponsor27-must
--+--
Changes (by antonela):

 * Attachment "O2.pdf" added.

 wip-july

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30429 [Applications/Tor Browser]: Rebase Tor Browser patches for Firefox ESR 68

2019-08-01 Thread Tor Bug Tracker & Wiki
#30429: Rebase Tor Browser patches for Firefox ESR 68
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201907R, tbb-9.0   |  Actual Points:
  -must-nightly  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:19 acat]:
 > Not so important, but I was wondering whether it would be ok to do a
 last pass to fix style issues whenever we think we have a branch ready for
 nightly. I can do this, and it cannot take more than 1 day.
 >
 > I think almost all C++ style should be fine according to `./mach clang-
 format`, but I was thinking to also make the JavaScript code we add or
 modify obey mozilla style (ESLint rules). Many of the style issues can be
 fixed automatically. The rules are quite advanced and tuned to Firefox
 codebase, and sometimes they help fixing bugs (deprecated things in XPCOM,
 etc.). I saw this while working on torbutton integration.

 Good idea, let's do it. I am fine not blocking on our nightly releases for
 this but commit a fixup commit which then gets resolved during a later
 rebase (just if we don't get to it in time).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31297 [Applications/Tor Browser]: How to enable sound on translate.google.com on Safer?

2019-08-01 Thread Tor Bug Tracker & Wiki
#31297: How to enable sound on translate.google.com on Safer?
-+-
 Reporter:  cypherpunks  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  noscript, tbb-usability-website, |  Actual Points:
  tbb-security-slider|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  noscript => noscript, tbb-usability-website, tbb-security-
   slider


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31251 [Applications/Tor Browser]: Security Level menu hangs off of the toolbarbutton element when it should hang off of the toolbarbutton's child element with toolbarbutton-icon class

2019-08-01 Thread Tor Bug Tracker & Wiki
#31251: Security Level menu hangs off of the toolbarbutton element when it 
should
hang off of the toolbarbutton's child element with toolbarbutton-icon class
--+
 Reporter:  pospeselr |  Owner:  pospeselr
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201908  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by gk):

 * keywords:  TorBrowserTeam201907R => TorBrowserTeam201908
 * status:  needs_review => needs_revision


Comment:

 posepeslr: Could you squash the commits and and shorten the summary of
 your commit message? It's useful to be able to read that in a terminal on
 one line (for more about that, see: https://tbaggery.com/2008/04/19/a
 -note-about-git-commit-messages.html).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29607 [Core Tor/Tor]: 2019 Q1: Denial of service on v2 and v3 onion service

2019-08-01 Thread Tor Bug Tracker & Wiki
#29607: 2019 Q1: Denial of service on v2 and v3 onion service
-+-
 Reporter:  pidgin   |  Owner:  pidgin
 Type:  defect   | Status:
 |  needs_information
 Priority:  Immediate|  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tor-dos, network-team-   |  Actual Points:
  roadmap-2019-Q1Q2, security, 041-longterm, |
  041-deferred-20190530  |
Parent ID:  #2   | Points:  10
 Reviewer:   |Sponsor:
 |  Sponsor27-must
-+-

Comment (by HelpDOS):

 Replying to [comment:62 asn]:
 > A plausible plan forward: https://lists.torproject.org/pipermail/tor-
 dev/2019-May/013849.html

 Any further developments or recent discussions you could link to? My
 hidden service has been unavailable due to this since February, glad a
 resolution is being worked on and some of the CPU fixes helped a little
 but I'm out of the loop as to where you are with the rate limiting and
 PoW, more interest in the PoW since I don't think the rate limiting will
 assist with availability at all.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25487 [Webpages/Styleguide]: Add an example for cards that are also links

2019-08-01 Thread Tor Bug Tracker & Wiki
#25487: Add an example for cards that are also links
-+--
 Reporter:  cypherpunks  |  Owner:  hiro
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Webpages/Styleguide  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #25404   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by irl):

 Replying to [comment:4 torlove]:
 > It is suspected that Hiro has left the project, given that he never
 responds to tickets anymore.

 hiro does lots of things, not just the styleguide. Right now I'm not
 working on this project as I have higher priorities so this ticket isn't
 that urgent. Still, if you wanted to come up with a patch to the
 styleguide then someone could look at it. I've not abandoned this project,
 we will do it eventually.

 > Not having Font Awesome operable on the higher security setting is a
 problem.In another ticket on this subject I have asked:

 This is off-topic on this ticket. If you're already discussing it
 somewhere else then please keep the discussion there, or if it was also
 off-topic there then we need a new ticket for it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31307 [Applications/GetTor]: Gettor doesn't seem to be responding to email requests

2019-08-01 Thread Tor Bug Tracker & Wiki
#31307: Gettor doesn't seem to be responding to email requests
-+
 Reporter:  pili |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+
 I just emailed  get...@torproject.org with subject: windows and I have not
 received any email back from it.

 Can someone check whether everything is up and running?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31251 [Applications/Tor Browser]: Security Level menu hangs off of the toolbarbutton element when it should hang off of the toolbarbutton's child element with toolbarbutton-icon class

2019-08-01 Thread Tor Bug Tracker & Wiki
#31251: Security Level menu hangs off of the toolbarbutton element when it 
should
hang off of the toolbarbutton's child element with toolbarbutton-icon class
--+--
 Reporter:  pospeselr |  Owner:  pospeselr
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201907R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by acat):

 Looks good and works for me now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31306 [Core Tor/Stem]: getinfo circuit-status misses entries

2019-08-01 Thread Tor Bug Tracker & Wiki
#31306: getinfo circuit-status misses entries
---+---
 Reporter:  blister_green  |  Owner:  atagar
 Type:  defect | Status:  new
 Priority:  Medium |  Component:  Core Tor/Stem
  Version:  Tor: 0.4.0.5   |   Severity:  Normal
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
 When using the getinfo circuit-status call, Stem does not output the same
 number of entries as a direct call on the control port does. This applies
 for the function calls controller.get_circuits() and
 controller.get_circuit() as well as to a direct call using
 controller.get_info("circuit-status").

 Example Output (with relay information removed):
 **Output Control Port:**
 {{{
 getinfo circuit-status
 250+circuit-status=
 1 BUILT $123~bla,$456~bla,$789~bla BUILD_FLAGS=NEED_CAPACITY
 PURPOSE=GENERAL TIME_CREATED=2019-08-01T08:24:46.866459
 2 BUILT ...
 3 BUILT ...
 4 BUILT ...
 5 BUILT ...
 .
 250 OK
 }}}

 **Output Stem (raw getinfo("circuit-status") call):**
 {{{
 1 BUILT $123~bla,$456~bla,$789~bla BUILD_FLAGS=NEED_CAPACITY
 PURPOSE=GENERAL TIME_CREATED=2019-08-01T08:24:46.866459
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31305 [Core Tor/Fallback Scripts]: Add more useful logging to fallback scripts variable config

2019-08-01 Thread Tor Bug Tracker & Wiki
#31305: Add more useful logging to fallback scripts variable config
---+--
 Reporter:  teor   |  Owner:  teor
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Core Tor/Fallback Scripts  |Version:
 Severity:  Normal | Resolution:
 Keywords:  fallback, 043-should   |  Actual Points:  0.3
Parent ID:  #30971 | Points:  0.1
 Reviewer:  nickm  |Sponsor:
---+--
Changes (by teor):

 * status:  assigned => needs_review
 * reviewer:   => nickm
 * points:   => 0.1
 * actualpoints:   => 0.3


Comment:

 See my pull request:
 https://github.com/torproject/fallback-scripts/pull/7

 This fix was a bit more complicated than I expected, because python's
 default bool conversion accepts any string.

 This is the improved error output:

 int
 {{{
 $ TOR_FB_REASONABLY_LIVE_TIME="bad-int" ./updateFallbackDirs.py
 ERROR::Could not cast env var "TOR_FB_REASONABLY_LIVE_TIME" using function
 "" and default "86400". ValueError: "invalid literal for int()
 with base 10: 'bad-int'"
 Exit 1
 }}}

 int, optional=True
 {{{
 $ TOR_FB_MAX_FALLBACK_COUNT=bad-int ./updateFallbackDirs.py
 ERROR::Could not cast optional env var value "bad-int" using function
 "". ValueError: "invalid literal for int() with base 10: 'bad-
 int'"
 ERROR::Could not cast env var "TOR_FB_MAX_FALLBACK_COUNT" using function
 "" and default "200". ValueError:
 "invalid literal for int() with base 10: 'bad-int'"
 Exit 1
 }}}

 bool
 {{{
 $ TOR_FB_PERFORM_IPV4_DIRPORT_CHECKS="bad-bool" ./updateFallbackDirs.py
 ERROR::Could not cast env var "TOR_FB_PERFORM_IPV4_DIRPORT_CHECKS" using
 function "" and default "True".
 ValueError: "invalid literal for custom_bool(): 'bad-bool', default_val:
 'True', var_name: 'TOR_FB_PERFORM_IPV4_DIRPORT_CHECKS'"
 Exit 1
 }}}

 bool, optional
 I temporarily added a TOR_FB_TEST_BOOL_OPT variable for testing
 {{{
 $ TOR_FB_TEST_BOOL_OPT="bad-bool" ./updateFallbackDirs.py
 ERROR::Could not cast optional env var value "bad-bool" using function
 "". ValueError: "invalid literal for
 custom_bool(): 'bad-bool', default_val: 'True', var_name:
 'TOR_FB_TEST_BOOL_OPT'"
 ERROR::Could not cast env var "TOR_FB_TEST_BOOL_OPT" using function
 "" and default "True". ValueError:
 "invalid literal for custom_bool(): 'bad-bool', default_val: 'True',
 var_name: 'TOR_FB_TEST_BOOL_OPT'"
 Exit 1
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29100 [Core Tor/Fallback Scripts]: Update src/app/config/fallback_dirs.inc to ../tor/src/app/config/fallback_dirs.inc post-split

2019-08-01 Thread Tor Bug Tracker & Wiki
#29100: Update src/app/config/fallback_dirs.inc to
../tor/src/app/config/fallback_dirs.inc post-split
---+
 Reporter:  teor   |  Owner:  (none)
 Type:  enhancement| Status:  closed
 Priority:  Medium |  Milestone:
Component:  Core Tor/Fallback Scripts  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  fallback   |  Actual Points:  2
Parent ID:  #28793 | Points:  1
 Reviewer:  nickm  |Sponsor:
---+
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged as 3fce5c6, opened #31305 for follow up.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28793 [Core Tor/Fallback Scripts]: Rebuild the fallback list in 2019

2019-08-01 Thread Tor Bug Tracker & Wiki
#28793: Rebuild the fallback list in 2019
-+-
 Reporter:  teor |  Owner:  teor
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Fallback Scripts|Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  fallback, 041-deferred-20190719  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 All the children are closed, so this task is done.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31305 [Core Tor/Fallback Scripts]: Add more useful logging to fallback scripts variable config

2019-08-01 Thread Tor Bug Tracker & Wiki
#31305: Add more useful logging to fallback scripts variable config
---+--
 Reporter:  teor   |  Owner:  teor
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Core Tor/Fallback Scripts  |Version:
 Severity:  Normal | Resolution:
 Keywords:  fallback, 043-should   |  Actual Points:
Parent ID:  #30971 | Points:
 Reviewer: |Sponsor:
---+--
Changes (by teor):

 * keywords:  fallback => fallback, 043-should
 * parent:  #29100 => #30971


Comment:

 We should fix these logging issues in 0.4.3, or the next time we do a
 fallback scripts update.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31305 [Core Tor/Fallback Scripts]: Add more useful logging to fallback scripts variable config

2019-08-01 Thread Tor Bug Tracker & Wiki
#31305: Add more useful logging to fallback scripts variable config
---+--
 Reporter:  teor   |  Owner:  teor
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Core Tor/Fallback Scripts  |Version:
 Severity:  Normal |   Keywords:  fallback
Actual Points: |  Parent ID:  #29100
   Points: |   Reviewer:
  Sponsor: |
---+--
 In #29100, nickm says:
 > As a followup, I suggest changing the definition of getvar_conf() so
 that on error, it gives a more useful explaining what the problem is, and
 changing the definition of opt() so that it turns the empty string and/or
 a missing option into None, but reports errors otherwise.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29103 [Core Tor/Fallback Scripts]: Add a licence, readme, and code of conduct to fallback-scripts

2019-08-01 Thread Tor Bug Tracker & Wiki
#29103: Add a licence, readme, and code of conduct to fallback-scripts
---+
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:  closed
 Priority:  Medium |  Milestone:
Component:  Core Tor/Fallback Scripts  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  fallback   |  Actual Points:  0.1
Parent ID:  #28793 | Points:  0.1
 Reviewer:  nickm  |Sponsor:
---+
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged as a31d658.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28797 [Core Tor/Fallback Scripts]: Set up CI on the fallback script with a small number of relays

2019-08-01 Thread Tor Bug Tracker & Wiki
#28797: Set up CI on the fallback script with a small number of relays
---+
 Reporter:  teor   |  Owner:  (none)
 Type:  enhancement| Status:  closed
 Priority:  Medium |  Milestone:
Component:  Core Tor/Fallback Scripts  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  fallback, fallback-ci  |  Actual Points:  0.5
Parent ID:  #28793 | Points:  0.5
 Reviewer:  nickm  |Sponsor:
---+
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged as 60c0202, waiting for CI to merge the other changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31021 [Core Tor/Fallback Scripts]: Add fallback CI for the check_existing and OUTPUT_CANDIDATES modes

2019-08-01 Thread Tor Bug Tracker & Wiki
#31021: Add fallback CI for the check_existing and OUTPUT_CANDIDATES modes
-+
 Reporter:  teor |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Fallback Scripts|Version:
 Severity:  Normal   | Resolution:
 Keywords:  fallback, fallback-ci, 043-must  |  Actual Points:
Parent ID:  #28863   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by teor):

 * keywords:  fallback, fallback-ci => fallback, fallback-ci, 043-must
 * parent:  #28797 => #28863


Comment:

 We need to implement these changes in 2019, so that we can make sure that
 our python 3 changes don't break any of these modes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31020 [Core Tor/Fallback Scripts]: Validate the fallback scripts CI output using grep and stem

2019-08-01 Thread Tor Bug Tracker & Wiki
#31020: Validate the fallback scripts CI output using grep and stem
-+
 Reporter:  teor |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Fallback Scripts|Version:
 Severity:  Normal   | Resolution:
 Keywords:  fallback, fallback-ci, 043-must  |  Actual Points:
Parent ID:  #28863   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by teor):

 * keywords:  fallback, fallback-ci => fallback, fallback-ci, 043-must
 * parent:  #28797 => #28863


Comment:

 We need to implement these tests in 2019, so that we can make sure our
 python 3 changes actually work.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28987 [Core Tor/Fallback Scripts]: Add a log level option to the fallback script

2019-08-01 Thread Tor Bug Tracker & Wiki
#28987: Add a log level option to the fallback script
---+
 Reporter:  teor   |  Owner:  (none)
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor/Fallback Scripts  |Version:
 Severity:  Normal | Resolution:
 Keywords:  fallback-ci|  Actual Points:
Parent ID:  #30971 | Points:
 Reviewer: |Sponsor:
---+
Changes (by teor):

 * parent:  #28797 => #30971


Comment:

 We might implement this feature at the end of 2019.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28863 [Core Tor/Fallback Scripts]: updateFallbackDirs.py thinks it is python 3 compatible but it is not

2019-08-01 Thread Tor Bug Tracker & Wiki
#28863: updateFallbackDirs.py thinks it is python 3 compatible but it is not
---+---
 Reporter:  starlight  |  Owner:  (none)
 Type:  defect | Status:  needs_information
 Priority:  Medium |  Milestone:
Component:  Core Tor/Fallback Scripts  |Version:
 Severity:  Normal | Resolution:
 Keywords:  fallback-ci, 043-must  |  Actual Points:
Parent ID:  #30971 | Points:
 Reviewer: |Sponsor:
---+---
Changes (by teor):

 * keywords:  fallback-ci => fallback-ci, 043-must
 * parent:  #28797 => #30971


Comment:

 We need to fix this at the end of 2019, because python 2 is not supported
 in 2020.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30928 [Core Tor/Chutney]: macOS Travis Homebrew cache has expired, failing some builds

2019-08-01 Thread Tor Bug Tracker & Wiki
#30928: macOS Travis Homebrew cache has expired, failing some builds
--+
 Reporter:  teor  |  Owner:  ahf
 Type:  defect| Status:  closed
 Priority:  High  |  Milestone:
Component:  Core Tor/Chutney  |Version:
 Severity:  Major | Resolution:  fixed
 Keywords:  chutney-ci-fail   |  Actual Points:  0.25
Parent ID:| Points:  0.25
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30928 [Core Tor/Chutney]: macOS Travis Homebrew cache has expired, failing some builds

2019-08-01 Thread Tor Bug Tracker & Wiki
#30928: macOS Travis Homebrew cache has expired, failing some builds
--+-
 Reporter:  teor  |  Owner:  ahf
 Type:  defect| Status:  merge_ready
 Priority:  High  |  Milestone:
Component:  Core Tor/Chutney  |Version:
 Severity:  Major | Resolution:
 Keywords:  chutney-ci-fail   |  Actual Points:  0.25
Parent ID:| Points:  0.25
 Reviewer:|Sponsor:
--+-

Comment (by teor):

 Merged as e369c8f, waiting for CI before merging #29024.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs