[tor-bugs] #31383 [- Select a component]: OpenSSL CVE-2019-1552

2019-08-08 Thread Tor Bug Tracker & Wiki
#31383: OpenSSL CVE-2019-1552
-+--
 Reporter:  cypherpunks  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  High |  Component:  - Select a component
  Version:   |   Severity:  Major
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
 https://github.com/openssl/openssl/pull/9400

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31356 [Core Tor/Tor]: 0.4.0 relays should not list Padding=1

2019-08-08 Thread Tor Bug Tracker & Wiki
#31356: 0.4.0 relays should not list Padding=1
--+--
 Reporter:  mikeperry |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.4.0.5
 Severity:  Normal| Resolution:
 Keywords:  wtf-pad   |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:  Sponsor2
--+--

Comment (by teor):

 Replying to [comment:3 mikeperry]:
 > ...
 > Did I mentiin my PR on any ticket before you posted this message? Was
 this a good use of your time?
 >
 > What were you trying to accomplish here? I am honestly curious.
 >
 > Is there a good reason to watch *all* PRs run for the purpose of
 exercising CI?
 >
 > Seriously... This is kind of crazy.. let's discuss.
 >
 > Anyway, since we're here, we might as well treat this PR as final cause
 that's how we do, apparently.
 >
 > Thanks.

 Hi Mike,

 I've been monitoring CI closely over the last few days, because Appveyor
 has been broken for about a week, since they upgraded the compiler in
 their CI image.

 That means logging tickets for each new CI issue as they come up, and
 checking new builds to make sure that the issues are fixed.

 I need CI to work, so I can merge the backport backlog.

 On Travis, I filter out pull requests. On Appveyor, they're all in the
 same list. I guess I made a mistake? Or I was trying to be helpful? I'll
 try to be more careful in future.

 I think what you want me to do is:
 * Don't look at or comment on your draft pull requests, or
 * Don't comment on any of your tickets, unless I'm specifically assigned
 as the reviewer

 Just let me know what you want, and I'll try my best to do it in future.

 I understand you're concerned or annoyed. But please don't call me words
 like "crazy". That's totally unnecessary. And please try to assume that
 I'm doing my best to be helpful. Even if I'm failing at it.

 If you want to continue this conversation, let's do it at the monthly
 retrospective. Or let's talk about it next week. Because I'm just about to
 finish for the day.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31356 [Core Tor/Tor]: 0.4.0 relays should not list Padding=1

2019-08-08 Thread Tor Bug Tracker & Wiki
#31356: 0.4.0 relays should not list Padding=1
--+--
 Reporter:  mikeperry |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.4.0.5
 Severity:  Normal| Resolution:
 Keywords:  wtf-pad   |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:  Sponsor2
--+--

Comment (by cypherpunks):

 SHULD BE MACRO IT SHOULD BE MUAVE I BLOCK BUT I CANT BECAUSE TRAC H8S BOB

 1 punk 1 vote

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31356 [Core Tor/Tor]: 0.4.0 relays should not list Padding=1

2019-08-08 Thread Tor Bug Tracker & Wiki
#31356: 0.4.0 relays should not list Padding=1
--+--
 Reporter:  mikeperry |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.4.0.5
 Severity:  Normal| Resolution:
 Keywords:  wtf-pad   |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:  Sponsor2
--+--

Comment (by mikeperry):

 Replying to [comment:1 teor]:
 > Travis says:
 > {{{
 > clang -DHAVE_CONFIG_H -I.  -I./src -I./src/ext -I./src/ext/trunnel
 -I./src/trunnel -I./src/ext -Isrc/ext
 -DSHARE_DATADIR="\"/usr/local/share\""
 -DLOCALSTATEDIR="\"/usr/local/var\"" -DBINDIR="\"/usr/local/bin\""
 -DTOR_UNIT_TESTS  -DHAVE_MODULE_DIRAUTH=1  -ftrapv -fsanitize=address
 -fno-sanitize=float-divide-by-zero -g -O2 -U_FORTIFY_SOURCE
 -D_FORTIFY_SOURCE=2 -Qunused-arguments -fstack-protector-all -Wstack-
 protector --param ssp-buffer-size=1 -fPIE -fno-omit-frame-pointer
 -fasynchronous-unwind-tables -Wall -fno-strict-aliasing -Werror
 @warning_flags -MT src/core/or/src_core_libtor_app_testing_a-
 circuitpadding.o -MD -MP -MF src/core/or/.deps
 /src_core_libtor_app_testing_a-circuitpadding.Tpo -c -o src/core/or
 /src_core_libtor_app_testing_a-circuitpadding.o `test -f
 'src/core/or/circuitpadding.c' || echo './'`src/core/or/circuitpadding.c
 >
 > src/core/or/circuitpadding.c:218:1: error: version control conflict
 marker in
 >
 >   file
 >
 > <<< HEAD
 >
 > ^
 >
 > src/core/or/circuitpadding.c:236:1: error: version control conflict
 marker in
 >
 >   file
 >
 > <<< HEAD
 >
 > ^
 >
 > src/core/or/circuitpadding.c:244:16: error: format specifies type 'char
 *' but
 >
 >   the argument has type 'int' [-Werror,-Wformat]
 >
 >i, circuit_purpose_to_string(circ->purpose));
 >
 >^
 >
 > ./src/lib/log/log.h:266:53: note: expanded from macro 'log_notice'
 >
 >   log_fn_(LOG_NOTICE, domain, __FUNCTION__, args, ##__VA_ARGS__)
 >
 > ^~~
 >
 > src/core/or/circuitpadding.c:244:19: error: data argument not used by
 format
 >
 >   string [-Werror,-Wformat-extra-args]
 >
 >i, circuit_purpose_to_string(circ->purpose));
 >
 >~~~^
 >
 > ./src/lib/log/log.h:266:53: note: expanded from macro 'log_notice'
 >
 >   log_fn_(LOG_NOTICE, domain, __FUNCTION__, args, ##__VA_ARGS__)
 >
 > ^
 >
 > 4 errors generated.
 > }}}

 Did I mentiin my PR on any ticket before you posted this message? Was this
 a good use of your time?

 What were you trying to accomplish here? I am honestly curious.

 Is there a good reason to watch *all* PRs run for the purpose of
 exercising CI?

 Seriously... This is kind of crazy.. let's discuss.

 Anyway, since we're here, we might as well treat this PR as final cause
 that's how we do, apparently.

 Thanks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29975 [Internal Services/Tor Sysadmin Team]: Please create email alias/forwarding and LDAP for acat

2019-08-08 Thread Tor Bug Tracker & Wiki
#29975: Please create email alias/forwarding and LDAP for acat
-+
 Reporter:  ewyatt   |  Owner:  tpa
 Type:  task | Status:  closed
 Priority:  High |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by ewyatt):

 Replying to [comment:2 arma]:
 > (Erin, if you could actually publish your signature somewhere, that
 would be even better. But there's no reason for that step to block setting
 up the ldap account.)

 The key was verified in person and signed by hellais. Is that enough?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

2019-08-08 Thread Tor Bug Tracker & Wiki
#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 035-backport,   |  Actual Points:  3
  040-backport, postfreeze-ok, network-team- |
  roadmap-july   |
Parent ID:   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by teor):

 * keywords:
 tor-hs-reachability, 029-backport-maybe, 035-backport, 040-backport,
 postfreeze-ok, network-team-roadmap-july, 034-unreached-backport-maybe
 =>
 tor-hs-reachability, 035-backport, 040-backport, postfreeze-ok,
 network-team-roadmap-july
 * actualpoints:   => 3
 * milestone:  Tor: 0.4.0.x-final => Tor: 0.3.5.x-final


Comment:

 This ticket doesn't have any code for 0.2.9.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31356 [Core Tor/Tor]: 0.4.0 relays should not list Padding=1

2019-08-08 Thread Tor Bug Tracker & Wiki
#31356: 0.4.0 relays should not list Padding=1
--+--
 Reporter:  mikeperry |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.4.0.5
 Severity:  Normal| Resolution:
 Keywords:  wtf-pad   |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:  Sponsor2
--+--
Changes (by mikeperry):

 * status:  needs_revision => needs_review


Comment:

 PR that solves this bug: https://github.com/torproject/tor/pull/1227

 Do not close #30992 please. This bug only adds logs for it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #28356, #4363, #22453, #24857, ...

2019-08-08 Thread Tor Bug Tracker & Wiki
Batch modification to #28356, #4363, #22453, #24857, #28113, #28509, #28510, 
#28512, #28514 by teor:


Comment:
Remove outdated 033-backport-maybe

--
Tickets URL: 

Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #28356, #4363, #22453, #24857, ...

2019-08-08 Thread Tor Bug Tracker & Wiki
Batch modification to #28356, #4363, #22453, #24857, #28113, #28509, #28510, 
#28512, #28514 by teor:


--
Tickets URL: 

Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #25372

2019-08-08 Thread Tor Bug Tracker & Wiki
Batch modification to #25372 by teor:


--
Tickets URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #26787, #25372, #25386, #27049, ...

2019-08-08 Thread Tor Bug Tracker & Wiki
Batch modification to #26787, #25372, #25386, #27049, #28183, #28356, #4363, 
#6623, #22453, #22660, #24250, #24853, #24857, #25061, #25208, #25416, #25686, 
#26356, #26469, #27066, #27130, #27190, #27191, #27194, #27201, #27722, #27802, 
#28081, #28113, #28378, #28509, #28510, #28511, #28512, #28514, #28611, #28522 
by teor:


Comment:
Fix 033-unreached-backport spelling.

--
Tickets URL: 

Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #30781

2019-08-08 Thread Tor Bug Tracker & Wiki
Batch modification to #30781 by teor:


Comment:
0.3.4 is unsupported, we won't be backporting anything else to it.

--
Tickets URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #30184

2019-08-08 Thread Tor Bug Tracker & Wiki
Batch modification to #30184 by teor:


Comment:
0.3.4 is unsupported, we won't be backporting anything else to it.

--
Tickets URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #28183, #30561

2019-08-08 Thread Tor Bug Tracker & Wiki
Batch modification to #28183, #30561 by teor:


Comment:
0.3.4 is unsupported, we won't be backporting anything else to it.

--
Tickets URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #29034, #4363, #22453, #28113, ...

2019-08-08 Thread Tor Bug Tracker & Wiki
Batch modification to #29034, #4363, #22453, #28113, #28509, #28510, #28512, 
#28514, #29780 by teor:


Comment:
0.3.4 is unsupported, we won't be backporting anything else to it.

--
Tickets URL: 

Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31381 [Internal Services/Service - trac]: Cannot close the ticket #24351

2019-08-08 Thread Tor Bug Tracker & Wiki
#31381: Cannot close the ticket #24351
--+-
 Reporter:  cypherpunks   |  Owner:  qbi
 Type:  task  | Status:  closed
 Priority:  Medium|  Milestone:
Component:  Internal Services/Service - trac  |Version:
 Severity:  Normal| Resolution:  invalid
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-

Comment (by teor):

 Trac doesn't allow per-ticket permissions. If we could lock tickets, we
 would.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31381 [Internal Services/Service - trac]: Cannot close the ticket #24351

2019-08-08 Thread Tor Bug Tracker & Wiki
#31381: Cannot close the ticket #24351
--+-
 Reporter:  cypherpunks   |  Owner:  qbi
 Type:  task  | Status:  closed
 Priority:  Medium|  Milestone:
Component:  Internal Services/Service - trac  |Version:
 Severity:  Normal| Resolution:  invalid
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-

Comment (by teor):

 I'm sorry, that's just not true.

 We have had cypherpunks mass-closing and mass-modifying tickets several
 times over the past year.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31381 [Internal Services/Service - trac]: Cannot close the ticket #24351

2019-08-08 Thread Tor Bug Tracker & Wiki
#31381: Cannot close the ticket #24351
--+-
 Reporter:  cypherpunks   |  Owner:  qbi
 Type:  task  | Status:  closed
 Priority:  Medium|  Milestone:
Component:  Internal Services/Service - trac  |Version:
 Severity:  Normal| Resolution:  invalid
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-

Comment (by cypherpunks):

 Replying to [comment:1 teor]:
 > We took those permissions away from cypherpunks, because some users were
 misusing them.
 Only a few tickets we're being vandalized, mainly ones related to
 Cloudflare (including the one by ioerror).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31343 [Core Tor/Tor]: appveyor: labs(time_t) is not allowed

2019-08-08 Thread Tor Bug Tracker & Wiki
#31343: appveyor: labs(time_t) is not allowed
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.4-alpha
 Severity:  Major| Resolution:  fixed
 Keywords:  tor-ci-fail 029-backport |  Actual Points:  .1
  035-backport 040-backport 041-backport |
Parent ID:   | Points:  .1
 Reviewer:  mikeperry, teor  |Sponsor:
-+-
Changes (by teor):

 * status:  needs_revision => closed
 * points:   => .1
 * version:   => Tor: 0.2.4.4-alpha
 * resolution:   => fixed
 * milestone:  Tor: 0.4.0.x-final => Tor: 0.2.9.x-final


Comment:

 This issue breaks Appveyor CI: backporting immediately.

 It looks like #31343 and #31374 each fail due to the other's error: I'll
 do a combined test branch to check.

 Merged #31343 and #31374 together.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31374 [Core Tor/Tor]: Appveyor: cast between incompatible function types in compat_time

2019-08-08 Thread Tor Bug Tracker & Wiki
#31374: Appveyor: cast between incompatible function types in compat_time
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.1-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-ci-fail Windows 029-backport |  Actual Points:  0.1
  035-backport 040-backport 041-backport |
Parent ID:  #31343   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor2-must
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed
 * milestone:  Tor: 0.4.0.x-final => Tor: 0.2.9.x-final


Comment:

 This issue breaks Appveyor CI: backporting immediately.

 It looks like #31343 and #31374 each fail due to the other's error: I'll
 do a combined test branch to check.

 Merged #31343 and #31374 together.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31381 [Internal Services/Service - trac]: Cannot close the ticket #24351

2019-08-08 Thread Tor Bug Tracker & Wiki
#31381: Cannot close the ticket #24351
--+-
 Reporter:  cypherpunks   |  Owner:  qbi
 Type:  task  | Status:  closed
 Priority:  Medium|  Milestone:
Component:  Internal Services/Service - trac  |Version:
 Severity:  Normal| Resolution:  invalid
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-
Changes (by teor):

 * status:  new => closed
 * severity:  Blocker => Normal
 * cc: boklm (removed)
 * component:  Applications/Tor Browser => Internal Services/Service - trac
 * priority:  Immediate => Medium
 * version:  Tor: unspecified =>
 * owner:  tbb-team => qbi
 * reviewer:  boklm =>
 * resolution:   => invalid


Comment:

 We took those permissions away from cypherpunks, because some users were
 misusing them.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31382 [Internal Services/Tor Sysadmin Team]: Please create email alias/forwarding and LDAP for federico (OONI)

2019-08-08 Thread Tor Bug Tracker & Wiki
#31382: Please create email alias/forwarding and LDAP for federico (OONI)
-+-
 Reporter:  ewyatt   |  Owner:  tpa
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 {{{
 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA512


 Please create LDAP and email forwarding for OONI dev:

 Name: Federico Ceratto
 Desired UID: federico
 Forwarding email address: feder...@openobservatory.org
 PGP key: 7CA7DDFB333921408C6F2B966F31BC44F5177DAA

 Thank you!

 -BEGIN PGP SIGNATURE-
 Comment: GPGTools - https://gpgtools.org

 iQIzBAEBCgAdFiEENecqn2ZVRfkstmYkugyUAPgPkc4FAl1MtiMACgkQugyUAPgP
 kc4j3w/5AV2Ov8jekmHXN4tG2KvjXrRPSkvIwltYcnmK99tW8nS00ce6euAom3i6
 NTZMybgIN4k5GYrQ5C/BgZOScv5vFIb5QVGLEYoYjdVq0N4VEudrA5+QknAC237/
 wM2WziDv6f75qagYZX1k4PmdMD+6GpLHTXKdXBMWgMihLcrSdiveXerx/B1At+bg
 2xI5spAf65XH53S5Llcg4cfGlKfImspRrjUp3aowKCFx4QI/zOrMx4p70xa8CBqP
 FZVvvUotiMuxNFDKgBqhNif+MVHStkY8D3pBw+zQF8CGRVVM+BuKIi37hp8zCCCd
 BcNS7SYh3oA2b4S0K/UGXLuTB2NJwgcXjWUrDP1wZjDL3rCwtPsM7myYJTWg0mMs
 BxOPcqnqKhA5JSxSGAFFj2XtmOge6wIWQv058+wc+XZUdm++Xq+aCUeH6CaMdbHC
 0AynG4ygxE/S94jm3IEeQoee/uBJ222FMYiTXMHEFqJhdfYRGDb103xuOW3oNp5d
 Oi7E6/1vSNSYVNQxwSxmlW0YceZomNF+kgb4nRtptwyp/+LCSeujqwMhpdd+P9cF
 3dM1yBiWorHr8UwjImulE9J0OAWAHpJ7V08vCv0CvEHptFn9n/y0qHq8Nles5c8t
 u6W1KMw5wtFX0DegMmncoDGy4I+bpQIcQkCPcKRjeiT4fvX8s0s=
 =fNAl
 -END PGP SIGNATURE-
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31381 [Applications/Tor Browser]: Cannot close the ticket #24351

2019-08-08 Thread Tor Bug Tracker & Wiki
#31381: Cannot close the ticket #24351
--+--
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Immediate |  Component:  Applications/Tor Browser
  Version:  Tor: unspecified  |   Severity:  Blocker
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  boklm |Sponsor:
--+--
 https://trac.torproject.org/projects/tor/ticket/24351

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31356 [Core Tor/Tor]: 0.4.0 relays should not list Padding=1

2019-08-08 Thread Tor Bug Tracker & Wiki
#31356: 0.4.0 relays should not list Padding=1
--+
 Reporter:  mikeperry |  Owner:  (none)
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.4.0.5
 Severity:  Normal| Resolution:
 Keywords:  wtf-pad   |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:  Sponsor2
--+
Changes (by teor):

 * status:  new => needs_revision


Comment:

 Travis says:
 {{{
 clang -DHAVE_CONFIG_H -I.  -I./src -I./src/ext -I./src/ext/trunnel
 -I./src/trunnel -I./src/ext -Isrc/ext
 -DSHARE_DATADIR="\"/usr/local/share\""
 -DLOCALSTATEDIR="\"/usr/local/var\"" -DBINDIR="\"/usr/local/bin\""
 -DTOR_UNIT_TESTS  -DHAVE_MODULE_DIRAUTH=1  -ftrapv -fsanitize=address
 -fno-sanitize=float-divide-by-zero -g -O2 -U_FORTIFY_SOURCE
 -D_FORTIFY_SOURCE=2 -Qunused-arguments -fstack-protector-all -Wstack-
 protector --param ssp-buffer-size=1 -fPIE -fno-omit-frame-pointer
 -fasynchronous-unwind-tables -Wall -fno-strict-aliasing -Werror
 @warning_flags -MT src/core/or/src_core_libtor_app_testing_a-
 circuitpadding.o -MD -MP -MF src/core/or/.deps
 /src_core_libtor_app_testing_a-circuitpadding.Tpo -c -o src/core/or
 /src_core_libtor_app_testing_a-circuitpadding.o `test -f
 'src/core/or/circuitpadding.c' || echo './'`src/core/or/circuitpadding.c

 src/core/or/circuitpadding.c:218:1: error: version control conflict marker
 in

   file

 <<< HEAD

 ^

 src/core/or/circuitpadding.c:236:1: error: version control conflict marker
 in

   file

 <<< HEAD

 ^

 src/core/or/circuitpadding.c:244:16: error: format specifies type 'char *'
 but

   the argument has type 'int' [-Werror,-Wformat]

i, circuit_purpose_to_string(circ->purpose));

^

 ./src/lib/log/log.h:266:53: note: expanded from macro 'log_notice'

   log_fn_(LOG_NOTICE, domain, __FUNCTION__, args, ##__VA_ARGS__)

 ^~~

 src/core/or/circuitpadding.c:244:19: error: data argument not used by
 format

   string [-Werror,-Wformat-extra-args]

i, circuit_purpose_to_string(circ->purpose));

~~~^

 ./src/lib/log/log.h:266:53: note: expanded from macro 'log_notice'

   log_fn_(LOG_NOTICE, domain, __FUNCTION__, args, ##__VA_ARGS__)

 ^

 4 errors generated.
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31343 [Core Tor/Tor]: appveyor: labs(time_t) is not allowed

2019-08-08 Thread Tor Bug Tracker & Wiki
#31343: appveyor: labs(time_t) is not allowed
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Very High|  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Major| Resolution:
 Keywords:  tor-ci-fail 029-backport |  Actual Points:  .1
  035-backport 040-backport 041-backport |
Parent ID:   | Points:
 Reviewer:  mikeperry, teor  |Sponsor:
-+-
Changes (by teor):

 * keywords:
 backports? tor-ci-fail 029-backport 035-backport 040-backport
 041-backport
 => tor-ci-fail 029-backport 035-backport 040-backport 041-backport


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31366 [Core Tor/Tor]: Move the connection_edge_process_relay_cell() assignment out of the if statement in circuit_receive_relay_cell()

2019-08-08 Thread Tor Bug Tracker & Wiki
#31366: Move the connection_edge_process_relay_cell() assignment out of the if
statement in circuit_receive_relay_cell()
--+
 Reporter:  neel  |  Owner:  neel
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  technical-debt, fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * milestone:  Tor: unspecified => Tor: 0.4.2.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31232 [Internal Services/Tor Sysadmin Team]: Migrate default snowflake broker (and bridge?) to TPA machines

2019-08-08 Thread Tor Bug Tracker & Wiki
#31232: Migrate default snowflake broker (and bridge?) to TPA machines
-+-
 Reporter:  cohosh   |  Owner:  tpa
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by phw):

 At [http://meetbot.debian.net/tor-meeting/2019/tor-
 meeting.2019-08-08-17.01.log.html today's anti-censorship meeting], we
 talked about snowflake migration. One argument against The Tor Project
 being involved in running snowflake infrastructure is our "we don't run
 the network" principle. Conceptually, the broker is similar to our bridge
 authority (not run by TPO) and BridgeDB (run by TPO). Bridges report
 themselves to the bridge authority, and their descriptors are then copied
 over to BridgeDB, which takes care of bridge distribution. The broker
 combines these two tasks – but it does so for snowflake proxies, and not
 bridges. We're therefore in a bit of a grey area here. (FWIW, I don't want
 to steer this discussion in either direction – just wanted to provide a
 bit of context.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31030 [Core Tor/Tor]: Coverity: Several warnings from test code

2019-08-08 Thread Tor Bug Tracker & Wiki
#31030: Coverity: Several warnings from test code
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  coverity  |  Actual Points:  .1
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 I think that it's actually okay; I've tried to explain why on the patch.
 Let me know if you buy my reasoning :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26294 [Core Tor/Tor]: attacker can force intro point rotation by ddos

2019-08-08 Thread Tor Bug Tracker & Wiki
#26294: attacker can force intro point rotation by ddos
-+-
 Reporter:  arma |  Owner:  asn
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tor-dos, network-team-   |  Actual Points:  6
  roadmap-august |
Parent ID:  #2   | Points:  7
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor27-must
-+-

Comment (by nickm):

 I think this code looks okay but before we merge it, I think we should
 have a patch for tor-spec that explains the new behavior of the replay
 cache.  We should also have a quick proposal that explains why it's safe
 to allow replays, since I've usually thought of them as a way to mount
 active traffic analysis attacks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26542 [Circumvention/BridgeDB]: Distribute IPv6 bridges through bridges.torproject.org

2019-08-08 Thread Tor Bug Tracker & Wiki
#26542: Distribute IPv6 bridges through bridges.torproject.org
-+-
 Reporter:  teor |  Owner:  phw
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Circumvention/BridgeDB   |Version:
 Severity:  Normal   | Resolution:
 Keywords:  anti-censorship-roadmap-october  |  Actual Points:
Parent ID:  #24264   | Points:  3
 Reviewer:  cohosh   |Sponsor:
 |  Sponsor30-must
-+-
Changes (by phw):

 * reviewer:  sysrqb => cohosh


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #9316 [Circumvention/BridgeDB]: BridgeDB should export statistics

2019-08-08 Thread Tor Bug Tracker & Wiki
#9316: BridgeDB should export statistics
-+-
 Reporter:  asn  |  Owner:  phw
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Circumvention/BridgeDB   |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics, bridgedb, prometheus,   |  Actual Points:
  anti-censorship-roadmap-september  |
Parent ID:  #31274   | Points:  3
 Reviewer:  cohosh   |Sponsor:
 |  Sponsor30-must
-+-
Changes (by phw):

 * reviewer:  sysrqb => cohosh


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22755 [Circumvention/BridgeDB]: Use stem to create test descriptors

2019-08-08 Thread Tor Bug Tracker & Wiki
#22755: Use stem to create test descriptors
-+-
 Reporter:  atagar   |  Owner:  phw
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Low  |  Milestone:
Component:  Circumvention/BridgeDB   |Version:
 Severity:  Minor| Resolution:
 Keywords:  python, stem, bridgedb-parsers,  |  Actual Points:
  bridgedb-ci|
Parent ID:   | Points:  1
 Reviewer:  cohosh   |Sponsor:
 |  Sponsor30-can
-+-
Changes (by phw):

 * reviewer:  sysrqb => cohosh


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28942 [Circumvention/Snowflake]: Evaluate pion WebRTC

2019-08-08 Thread Tor Bug Tracker & Wiki
#28942: Evaluate pion WebRTC
+--
 Reporter:  backkem |  Owner:  cohosh
 Type:  enhancement | Status:  accepted
 Priority:  Medium  |  Milestone:
Component:  Circumvention/Snowflake |Version:
 Severity:  Normal  | Resolution:
 Keywords:  anti-censorship-roadmap-august  |  Actual Points:
Parent ID:  | Points:  5
 Reviewer:  |Sponsor:
|  Sponsor28-must
+--
Changes (by sukhbir):

 * cc: sukhbir (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31374 [Core Tor/Tor]: Appveyor: cast between incompatible function types in compat_time

2019-08-08 Thread Tor Bug Tracker & Wiki
#31374: Appveyor: cast between incompatible function types in compat_time
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci-fail Windows 029-backport |  Actual Points:  0.1
  035-backport 040-backport 041-backport |
Parent ID:  #31343   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor2-must
-+-
Changes (by nickm):

 * keywords:
 041-must tor-ci-fail Windows 029-backport 035-backport 040-backport
 041-backport
 =>
 tor-ci-fail Windows 029-backport 035-backport 040-backport
 041-backport
 * milestone:  Tor: 0.4.1.x-final => Tor: 0.4.0.x-final


Comment:

 MErged to 0.4.1 and forward.  Marking for backport.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31380 [Applications/Tor Browser]: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `CXXABI_1.3.11' not found (required by ./TorBrowser/Tor/PluggableTransports/snowflake-client)

2019-08-08 Thread Tor Bug Tracker & Wiki
#31380: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `CXXABI_1.3.11' not 
found
(required by ./TorBrowser/Tor/PluggableTransports/snowflake-client)
--+--
 Reporter:  xhdix |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  snowflake |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by xhdix):

 Debug mode:

 {{{
  ./start-tor-browser --debug
 Aug 08 19:16:01.985 [notice] Tor 0.4.1.3-alpha (git-d2c360c5336b43ba)
 running on Linux with Libevent 2.1.8-stable, OpenSSL 1.1.1c, Zlib 1.2.8,
 Liblzma N/A, and Libzstd N/A.
 Aug 08 19:16:01.985 [notice] Tor can't help you if you use it wrong! Learn
 how to be safe at https://www.torproject.org/download/download#warning
 Aug 08 19:16:01.985 [notice] This version is not a stable Tor release.
 Expect more bugs than usual.
 Aug 08 19:16:01.985 [notice] Read configuration file
 "/home/mk/Desktop/Browser/TorBrowser/Data/Tor/torrc-defaults".
 Aug 08 19:16:01.986 [notice] Read configuration file
 "/home/mk/Desktop/Browser/TorBrowser/Data/Tor/torrc".
 Aug 08 19:16:01.996 [notice] Opening Control listener on 127.0.0.1:9151
 Aug 08 19:16:02.000 [notice] Opened Control listener on 127.0.0.1:9151
 Aug 08 19:16:02.000 [notice] DisableNetwork is set. Tor will not make or
 accept non-control network connections. Shutting down all existing
 connections.
 Aug 08 19:16:02.000 [notice] Parsing GEOIP IPv4 file
 /home/mk/Desktop/Browser/TorBrowser/Data/Tor/geoip.
 Aug 08 19:16:02.000 [notice] Parsing GEOIP IPv6 file
 /home/mk/Desktop/Browser/TorBrowser/Data/Tor/geoip6.
 Aug 08 19:16:02.000 [notice] Bootstrapped 0% (starting): Starting
 Aug 08 19:16:02.000 [notice] Starting with guard context "bridges"
 Aug 08 19:16:02.000 [notice] Delaying directory fetches: DisableNetwork is
 set.
 Aug 08 19:16:02.000 [notice] New control connection opened from 127.0.0.1.
 Aug 08 19:16:02.000 [notice] DisableNetwork is set. Tor will not make or
 accept non-control network connections. Shutting down all existing
 connections.
 Aug 08 19:16:02.000 [notice] New control connection opened from 127.0.0.1.
 Aug 08 19:16:02.000 [notice] DisableNetwork is set. Tor will not make or
 accept non-control network connections. Shutting down all existing
 connections.
 Aug 08 19:16:02.000 [notice] Opening Socks listener on 127.0.0.1:9150
 Aug 08 19:16:02.000 [notice] Opened Socks listener on 127.0.0.1:9150
 Aug 08 19:16:03.000 [warn] Managed proxy at
 './TorBrowser/Tor/PluggableTransports/snowflake-client' reported:
 ./TorBrowser/Tor/PluggableTransports/snowflake-client: /usr/lib/x86_64
 -linux-gnu/libstdc++.so.6: version `CXXABI_1.3.11' not found (required by
 ./TorBrowser/Tor/PluggableTransports/snowflake-client)
 Aug 08 19:16:03.000 [warn] Pluggable Transport process terminated with
 status code 256

 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31380 [Applications/Tor Browser]: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `CXXABI_1.3.11' not found (required by ./TorBrowser/Tor/PluggableTransports/snowflake-client)

2019-08-08 Thread Tor Bug Tracker & Wiki
#31380: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `CXXABI_1.3.11' not 
found
(required by ./TorBrowser/Tor/PluggableTransports/snowflake-client)
---+--
 Reporter:  xhdix  |  Owner:  tbb-team
 Type:  defect | Status:  new
 Priority:  Medium |  Component:  Applications/Tor Browser
  Version: |   Severity:  Normal
 Keywords:  snowflake  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
 Similar to the Ticket #25485 but in the new alpha version when using the
 snowflake bridge.


 {{{
 8/8/19, 18:31:25.542 [NOTICE] DisableNetwork is set. Tor will not make or
 accept non-control network connections. Shutting down all existing
 connections.
 8/8/19, 18:31:31.914 [NOTICE] DisableNetwork is set. Tor will not make or
 accept non-control network connections. Shutting down all existing
 connections.
 8/8/19, 18:31:31.914 [NOTICE] DisableNetwork is set. Tor will not make or
 accept non-control network connections. Shutting down all existing
 connections.
 8/8/19, 18:31:31.914 [NOTICE] DisableNetwork is set. Tor will not make or
 accept non-control network connections. Shutting down all existing
 connections.
 8/8/19, 18:31:31.914 [NOTICE] Opening Socks listener on 127.0.0.1:9150
 8/8/19, 18:31:31.914 [NOTICE] Opened Socks listener on 127.0.0.1:9150
 8/8/19, 18:31:32.212 [WARN] Managed proxy at
 './TorBrowser/Tor/PluggableTransports/snowflake-client' reported:
 ./TorBrowser/Tor/PluggableTransports/snowflake-client: /usr/lib/x86_64
 -linux-gnu/libstdc++.so.6: version `CXXABI_1.3.11' not found (required by
 ./TorBrowser/Tor/PluggableTransports/snowflake-client)
 8/8/19, 18:31:32.216 [WARN] Pluggable Transport process terminated with
 status code 256

 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31379 [Webpages]: Get error message "Error loading tickets." On the 'Create New Ticket' page after writing to the 'summery' input box

2019-08-08 Thread Tor Bug Tracker & Wiki
#31379: Get error message "Error loading tickets." On the 'Create New Ticket' 
page
after writing to the 'summery' input box
--+
 Reporter:  xhdix |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Webpages  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by xhdix):

 * Attachment "photo_2019-08-08_22-05-58.jpg" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31379 [Webpages]: Get error message "Error loading tickets." On the 'Create New Ticket' page after writing to the 'summery' input box

2019-08-08 Thread Tor Bug Tracker & Wiki
#31379: Get error message "Error loading tickets." On the 'Create New Ticket' 
page
after writing to the 'summery' input box
+--
 Reporter:  xhdix   |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Component:  Webpages
  Version:  |   Severity:  Normal
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
 xmlrpc XHR :

 {{{
 
 
 
 
 
 faultCode
 403
 
 
 faultString
 XML_RPC privileges are required to perform this operation.
 You don't have the required permissions.
 
 
 
 

 }}}


 console log:

 Firefox:

 {{{
 jQuery.Deferred exception: $.browser is undefined
 
$.Autocompleter@https://trac.torproject.org/projects/tor/chrome/autocomplete/js/autocomplete.js:96:5
 
autocomplete/<@https://trac.torproject.org/projects/tor/chrome/autocomplete/js/autocomplete.js:39:11
 each@https://trac.torproject.org/projects/tor/chrome/common/js/jquery.js:1:3995
 each@https://trac.torproject.org/projects/tor/chrome/common/js/jquery.js:1:1452
 
autocomplete@https://trac.torproject.org/projects/tor/chrome/autocomplete/js/autocomplete.js:38:16
 
@https://trac.torproject.org/projects/tor/chrome/autocomplete/js/autocomplete_newticket.js:6:3
 
mightThrow@https://trac.torproject.org/projects/tor/chrome/common/js/jquery.js:2:15531
 
resolve/https://trac.torproject.org/projects/tor/chrome/common/js/jquery.js:2:16200
  undefined
 jquery.js:2:18293
 jQuery.Deferred exception: $.browser is undefined
 
$.Autocompleter@https://trac.torproject.org/projects/tor/chrome/autocomplete/js/autocomplete.js:96:5
 
autocomplete/<@https://trac.torproject.org/projects/tor/chrome/autocomplete/js/autocomplete.js:39:11
 each@https://trac.torproject.org/projects/tor/chrome/common/js/jquery.js:1:3995
 each@https://trac.torproject.org/projects/tor/chrome/common/js/jquery.js:1:1452
 
autocomplete@https://trac.torproject.org/projects/tor/chrome/autocomplete/js/autocomplete.js:38:16
 @https://trac.torproject.org/projects/tor/newticket:96:17
 
mightThrow@https://trac.torproject.org/projects/tor/chrome/common/js/jquery.js:2:15531
 
resolve/https://trac.torproject.org/projects/tor/chrome/common/js/jquery.js:2:16200
  undefined
 jquery.js:2:18293
 TypeError: $.browser is undefined[Learn More]
 autocomplete.js:96:5
 $.Autocompleter
 
https://trac.torproject.org/projects/tor/chrome/autocomplete/js/autocomplete.js:96:5
 autocomplete/<
 
https://trac.torproject.org/projects/tor/chrome/autocomplete/js/autocomplete.js:39:11
 each
 https://trac.torproject.org/projects/tor/chrome/common/js/jquery.js:1:3995
 each
 https://trac.torproject.org/projects/tor/chrome/common/js/jquery.js:1:1452
 autocomplete
 
https://trac.torproject.org/projects/tor/chrome/autocomplete/js/autocomplete.js:38:16
 
 
https://trac.torproject.org/projects/tor/chrome/autocomplete/js/autocomplete_newticket.js:6:3
 mightThrow
 https://trac.torproject.org/projects/tor/chrome/common/js/jquery.js:2:15531
 resolve/https://trac.torproject.org/projects/tor/chrome/common/js/jquery.js:2:16200

 }}}

 Chrome:


 {{{
 jquery.js:2 jQuery.Deferred exception: Cannot read property 'opera' of
 undefined TypeError: Cannot read property 'opera' of undefined
 at new $.Autocompleter
 
(https://trac.torproject.org/projects/tor/chrome/autocomplete/js/autocomplete.js:96:15)
 at HTMLInputElement.
 
(https://trac.torproject.org/projects/tor/chrome/autocomplete/js/autocomplete.js:39:11)
 at Function.each
 (https://trac.torproject.org/projects/tor/chrome/common/js/jquery.js:1:4004)
 at jQuery.fn.init.each
 (https://trac.torproject.org/projects/tor/chrome/common/js/jquery.js:1:1459)
 at jQuery.fn.init.autocomplete
 
(https://trac.torproject.org/projects/tor/chrome/autocomplete/js/autocomplete.js:38:21)
 at HTMLDocument.
 
(https://trac.torproject.org/projects/tor/chrome/autocomplete/js/autocomplete_newticket.js:6:18)
 at mightThrow
 (https://trac.torproject.org/projects/tor/chrome/common/js/jquery.js:2:15539)
 at process
 (https://trac.torproject.org/projects/tor/chrome/common/js/jquery.js:2:16200)
 undefined
 jQuery.Deferred.exceptionHook @ jquery.js:2
 process @ jquery.js:2
 setTimeout (async)
 (anonymous) @ jquery.js:2
 fire @ jquery.js:2
 fireWith @ jquery.js:2
 fire @ jquery.js:2
 fire @ jquery.js:2
 fireWith @ jquery.js:2
 ready @ jquery.js:2
 completed @ jquery.js:2
 jquery.js:2 jQuery.Deferred exception: Cannot read property 'opera' of
 undefined TypeError: Cannot read property 'opera' of undefined
 at new $.Autocompleter
 
(https://trac.torproject.org/projects/tor/chrome/autocomplete/js/autocomplete.js:96:15)
 at HTMLInputElement.
 
(https://trac.torproject.org/projects/tor/chrome/autocomplete/js/autocomplete.js:39:11)
 at Function.each
 (https://trac.torproject.org/projects/tor/chrome/common/js/jquery.js:1:4004)
 at jQuery.fn.init.each
 

Re: [tor-bugs] #31010 [Applications/Tor Browser]: Rebase Tor Browser mobile/ patches for Firefox ESR 68

2019-08-08 Thread Tor Bug Tracker & Wiki
#31010: Rebase Tor Browser mobile/ patches for Firefox ESR 68
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-9.0-must-nightly,|  Actual Points:
  TorBrowserTeam201908R  |
Parent ID:  #30429   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * Attachment "0001-Bug-13252-Do-not-store-data-in-the-app-bundle.patch"
 added.

 ESR68 rebased patch for #13252

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31010 [Applications/Tor Browser]: Rebase Tor Browser mobile/ patches for Firefox ESR 68

2019-08-08 Thread Tor Bug Tracker & Wiki
#31010: Rebase Tor Browser mobile/ patches for Firefox ESR 68
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-9.0-must-nightly,|  Actual Points:
  TorBrowserTeam201908R  |
Parent ID:  #30429   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 Replying to [comment:9 sysrqb]:
 > Bisecting leads to [https://github.com/acatarineu/tor-
 browser/commit/d03d360bd773c8d8a97ef1f69e565afcc19796e5 this commit]
 (commit `d03d360bd773c8d8a97ef1f69e565afcc19796e5` on acat's `30429+5`
 branch). This'll require some digging. mcs/brade, if you have any
 suggestions about where I should look, they'll be very much appreciated.
 > ...

 Without knowing a lot about the Android-specific code, my guess is that
 the #9173 patch is just not correct by itself for Android. What is missing
 from acat's 30429+5 branch is a patch for #13252, which Kathy and I have
 been working on along with the updater patches. The #13252 patch adds the
 "side-by-side" TorBrowser-Data magic for macOS and also changes how the
 app data directory is determined on all platforms. As of yesterday, we
 have a "hot off the press" patch for #13252 which we plan to get to acat
 soon. I will attach a copy to this ticket so you can try it now.

 One caveat: the ESR68 #13252 patch is intended to be inserted into the
 commit stream immediately after the #11641 patch
 (69c8b59f9cdc792ee533187723286fdd75dbabd0 on acat's 30429+5 branch). You
 may get conflicts if you tack it on the end.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29399 [Internal Services/Tor Sysadmin Team]: Retire host and services for tordnsel and check

2019-08-08 Thread Tor Bug Tracker & Wiki
#29399: Retire host and services for tordnsel and check
-+-
 Reporter:  ln5  |  Owner:  tpa
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gaba):

 To clarify: we have this in the metrics team roadmap. We will try to
 discuss a more concrete plan and ETA and let you know.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19948 [Applications/Tor Browser]: Some inconsistencies in Torbutton log

2019-08-08 Thread Tor Bug Tracker & Wiki
#19948: Some inconsistencies in Torbutton log
--+--
 Reporter:  bugzilla  |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Minor | Resolution:  user disappeared
 Keywords:  tbb-torbutton |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 Replying to [comment:6 cypherpunks]:
 > Unfortunately, yes, disappeared. But closing tickets this way can lead
 to disappearing of the remaining users...
 I don't know why bugzilla disappeared tho, he seemed to do some very
 sensible job at bug hunting. Maybe he got lost in Mozilla userspace.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31378 [Core Tor/Tor]: Run in ram mode

2019-08-08 Thread Tor Bug Tracker & Wiki
#31378: Run in ram mode
--+
 Reporter:  daealc|  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  readonly ram  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by daealc):

 It seems at least to me that for a piece of software that is primarily
 aimed at people who may be in a 'tight spot' it would be far more sane to
 allow the tor daemon to run anywhere, if information is written to a
 permanent location it can be a sign of tor running.

 However ... if it was to run purely in ram especially the chances of
 discovering evidence of tor usage is minimized, on top of that it would
 also allow for operators who wish to contribute to the network to simply
 'run tor with x settings' and not have to worry about where its writing
 to.

 There really is very little that is bad about adding this option, as for
 entry points if you say tails/memory disks are the answer to my
 enhancement, surely remembering the fingerprint of a trusted entry-point
 is easier. Bearing in mind tails requires rebooting into it and facing
 potential hardware difficulties and using memory disks requires root
 access. Either of which may not be availible.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31378 [Core Tor/Tor]: Run in ram mode

2019-08-08 Thread Tor Bug Tracker & Wiki
#31378: Run in ram mode
--+
 Reporter:  daealc|  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  readonly ram  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by arma):

 This seems like a risky idea. For clients, discarding your entry guards is
 potentially very hazardous. For relays, ...actually ok for relays it might
 not be crazy.

 The current answer is to either make a ramdisk and put your datadirectory
 there, or for more normal users, to use Tails.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31374 [Core Tor/Tor]: Appveyor: cast between incompatible function types in compat_time

2019-08-08 Thread Tor Bug Tracker & Wiki
#31374: Appveyor: cast between incompatible function types in compat_time
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  041-must tor-ci-fail Windows |  Actual Points:  0.1
  029-backport 035-backport 040-backport |
  041-backport   |
Parent ID:  #31343   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor2-must
-+-
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 lgtm;

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31374 [Core Tor/Tor]: Appveyor: cast between incompatible function types in compat_time

2019-08-08 Thread Tor Bug Tracker & Wiki
#31374: Appveyor: cast between incompatible function types in compat_time
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  041-must tor-ci-fail Windows |  Actual Points:  0.1
  029-backport 035-backport 040-backport |
  041-backport   |
Parent ID:  #31343   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor2-must
-+-

Comment (by nickm):

 Appveyor passed with this. I propose that we merge it to 0.4.1 and
 forward, and let teor backport.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31375 [Core Tor/Tor]: hs: Crash in token_bucket_ctr_refill() of the INTRO2 DoS defense

2019-08-08 Thread Tor Bug Tracker & Wiki
#31375: hs: Crash in token_bucket_ctr_refill() of the INTRO2 DoS defense
---+---
 Reporter:  dgoulet|  Owner:  (none)
 Type:  defect | Status:  needs_review
 Priority:  Very High  |  Milestone:  Tor:
   |  0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, crash, regression  |  Actual Points:
Parent ID: | Points:
 Reviewer:  asn|Sponsor:  Sponsor27-must
---+---
Changes (by dgoulet):

 * status:  new => needs_review
 * reviewer:   => asn


Comment:

 Branch: `ticket31375_042_01`
 PR: https://github.com/torproject/tor/pull/1225

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31378 [Core Tor/Tor]: Run in ram mode

2019-08-08 Thread Tor Bug Tracker & Wiki
#31378: Run in ram mode
--+--
 Reporter:  daealc|  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Component:  Core Tor/Tor
  Version:|   Severity:  Normal
 Keywords:  readonly ram  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
 allow --ram-only or --ro-filesystem which disable writing to disk, instead
 keeping all information in ram

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19948 [Applications/Tor Browser]: Some inconsistencies in Torbutton log

2019-08-08 Thread Tor Bug Tracker & Wiki
#19948: Some inconsistencies in Torbutton log
--+--
 Reporter:  bugzilla  |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Minor | Resolution:  user disappeared
 Keywords:  tbb-torbutton |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 Unfortunately, yes, disappeared. But closing tickets this way can lead to
 disappearing of the remaining users...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31375 [Core Tor/Tor]: hs: Crash in token_bucket_ctr_refill() of the INTRO2 DoS defense

2019-08-08 Thread Tor Bug Tracker & Wiki
#31375: hs: Crash in token_bucket_ctr_refill() of the INTRO2 DoS defense
---+---
 Reporter:  dgoulet|  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Very High  |  Milestone:  Tor:
   |  0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, crash, regression  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:  Sponsor27-must
---+---

Comment (by dgoulet):

 Ok... this is embarrassing but the reason we got there is because the
 INTRO2 bucket is _not_ initialized for a legacy intro point (v2)...

 We only init() in `handle_verified_establish_intro_cell()` which is v3
 only.

 Fortunately, we did not release this bug _and_ the HS DoS defense is not
 enabled by default.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31278 [Circumvention/Snowflake]: Chrome proxies hang with open idle connection

2019-08-08 Thread Tor Bug Tracker & Wiki
#31278: Chrome proxies hang with open idle connection
-+
 Reporter:  cypherpunks  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake-webextension   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by dcf):

 There's a new ticket at https://github.com/keroserene/go-webrtc/issues/107
 that has to do with Chrome.
 > According https://bugs.chromium.org/p/webrtc/issues/detail?id=9484 new
 versions of Chrome are sending new offer format and answer cannot be
 generated.
 >
 > For example, for RemoteDescription with info
 > {{{
 > m=application 54111 UDP/DTLS/SCTP webrtc-datachannel a=sctp-port:5000
 > }}}
 > pc.CreateAnswer does not produce any result - no error, no answer
 >
 > Similiar issue for node implementation - [https://github.com/node-webrtc
 /node-webrtc/issues/483 node-webrtc/node-webrtc#483]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31285 [Circumvention/Snowflake]: Browsers accumulate permanently open UDP sockets over time (was: Broswers accumulate permanently open UDP sockets over time)

2019-08-08 Thread Tor Bug Tracker & Wiki
#31285: Browsers accumulate permanently open UDP sockets over time
-+
 Reporter:  cypherpunks  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake-webextension   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31010 [Applications/Tor Browser]: Rebase Tor Browser mobile/ patches for Firefox ESR 68

2019-08-08 Thread Tor Bug Tracker & Wiki
#31010: Rebase Tor Browser mobile/ patches for Firefox ESR 68
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-9.0-must-nightly,|  Actual Points:
  TorBrowserTeam201908R  |
Parent ID:  #30429   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * cc: mcs, brade (added)


Comment:

 Bisecting leads to [https://github.com/acatarineu/tor-
 browser/commit/d03d360bd773c8d8a97ef1f69e565afcc19796e5 this commit]
 (commit `d03d360bd773c8d8a97ef1f69e565afcc19796e5` on acat's `30429+5`
 branch). This'll require some digging. mcs/brade, if you have any
 suggestions about where I should look, they'll be very much appreciated.

 Specifically, I'm hitting [https://searchfox.org/mozilla-
 esr68/source/toolkit/xre/nsAndroidStartup.cpp#49 this result]:
 {{{
 08-06 21:08:45.266 4117-4141/org.torproject.torbrowser I/fennec: XRE_main
 returned 1
 }}}

 I'm having trouble setting breakpoints in the code, so I'm working through
 the code manually right now. I think this failure is triggered after
 [https://searchfox.org/mozilla-
 esr68/source/toolkit/xre/nsAppRunner.cpp#4781 mScopedXPCOM->Initialize()]
 because I'm getting the log message:
 {{{
 08-06 21:08:44.163 4117-4141/org.torproject.torbrowser D/GeckoThread:
 State changed to JNI_READY
 }}}

 and I believe that is set [https://searchfox.org/mozilla-
 esr68/source/widget/android/nsAppShell.cpp#424 at the end] of the
 `Initialize()` call (after a few layers of indirection, assuming I traced
 this correctly).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31366 [Core Tor/Tor]: Move the connection_edge_process_relay_cell() assignment out of the if statement in circuit_receive_relay_cell()

2019-08-08 Thread Tor Bug Tracker & Wiki
#31366: Move the connection_edge_process_relay_cell() assignment out of the if
statement in circuit_receive_relay_cell()
--+--
 Reporter:  neel  |  Owner:  neel
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  technical-debt, fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by neel):

 * status:  assigned => needs_review


Comment:

 PR: https://github.com/torproject/tor/pull/1224

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31377 [Applications/GetTor]: Create a GetTor survival guide

2019-08-08 Thread Tor Bug Tracker & Wiki
#31377: Create a GetTor survival guide
-+
 Reporter:  phw  |  Owner:  (none)
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   |   Keywords:  survival-guide
Actual Points:   |  Parent ID:
   Points:  0.5  |   Reviewer:
  Sponsor:   |
-+
 The anti-censorship team maintains
 
[https://trac.torproject.org/projects/tor/wiki/org/teams/AntiCensorshipTeam#Servicesurvivalguides
 service-specific "survival guides"]. The point of these guides is that
 somebody who's not a maintainer should be able to perform basic
 maintenance tasks if the main developer is not available. Needless to say,
 these guides are only useful if more people than just the maintainer have
 access to a service. In case of GetTor, hiro and phw currently have access
 to GetTor's machine.

 Let's create a survival guide for GetTor. This survival guide should
 explain how one would:
 * Redeploy GetTor (e.g., after fixing a bug in the code)
 * (Re)start GetTor
 * Update the Tor Browser binaries that GetTor serves
 * Analyse log files
 * ...anything else?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31012 [Core Tor/Tor]: tor-print-ed-signing-cert shows local time, without a timezone

2019-08-08 Thread Tor Bug Tracker & Wiki
#31012: tor-print-ed-signing-cert shows local time, without a timezone
---+
 Reporter:  teor   |  Owner:  rl1987
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor   |Version:  Tor: 0.3.5.1-alpha
 Severity:  Normal | Resolution:  fixed
 Keywords:  dgoulet-merge  |  Actual Points:  0.1
Parent ID: | Points:  0.1
 Reviewer:  nickm  |Sponsor:
---+
Changes (by dgoulet):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31207 [Core Tor/Tor]: Space out first connection_edge_process_relay_cell() line in circuit_receive_relay_cell()

2019-08-08 Thread Tor Bug Tracker & Wiki
#31207: Space out first connection_edge_process_relay_cell() line in
circuit_receive_relay_cell()
---+
 Reporter:  neel   |  Owner:  neel
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  dgoulet-merge  |  Actual Points:
Parent ID: | Points:
 Reviewer:  nickm  |Sponsor:
---+
Changes (by dgoulet):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged! No backport.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31023 [Core Tor/Tor]: Add tests for tor-print-ed-signing-cert and other tools, and run them in CI

2019-08-08 Thread Tor Bug Tracker & Wiki
#31023: Add tests for tor-print-ed-signing-cert and other tools, and run them 
in CI
+
 Reporter:  teor|  Owner:  rl1987
 Type:  defect  | Status:  accepted
 Priority:  Medium  |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor|Version:  Tor: 0.3.5.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+
Changes (by dgoulet):

 * parent:  #31012 =>


Comment:

 Unparenting to close parent.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31207 [Core Tor/Tor]: Space out first connection_edge_process_relay_cell() line in circuit_receive_relay_cell()

2019-08-08 Thread Tor Bug Tracker & Wiki
#31207: Space out first connection_edge_process_relay_cell() line in
circuit_receive_relay_cell()
---+
 Reporter:  neel   |  Owner:  neel
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  dgoulet-merge  |  Actual Points:
Parent ID: | Points:
 Reviewer:  nickm  |Sponsor:
---+

Comment (by nickm):

 agreed

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31375 [Core Tor/Tor]: hs: Crash in token_bucket_ctr_refill() of the INTRO2 DoS defense

2019-08-08 Thread Tor Bug Tracker & Wiki
#31375: hs: Crash in token_bucket_ctr_refill() of the INTRO2 DoS defense
---+---
 Reporter:  dgoulet|  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Very High  |  Milestone:  Tor:
   |  0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, crash, regression  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:  Sponsor27-must
---+---
Changes (by nickm):

 * keywords:  tor-hs, crash => tor-hs, crash, regression


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31373 [Core Tor/Tor]: Print summary of features at end of configure

2019-08-08 Thread Tor Bug Tracker & Wiki
#31373: Print summary of features at end of configure
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  configure, build  |  Actual Points:
Parent ID:| Points:  0.1
 Reviewer:  nickm |Sponsor:
--+

Comment (by nickm):

 Neat idea; let's see if we can get a GPL exception for the script, though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17449 [Applications/Quality Assurance and Testing]: Test bridges we ship in Tor Browser regularly

2019-08-08 Thread Tor Bug Tracker & Wiki
#17449: Test bridges we ship in Tor Browser regularly
-+-
 Reporter:  gk   |  Owner:  boklm
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Quality Assurance and   |Version:
  Testing|
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-bridges   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor30-can
-+-
Changes (by phw):

 * keywords:  tbb-usability => tbb-usability, tbb-bridges


Comment:

 Thanks to gman999, we now have a sysmon instance that continuously tests
 our default bridges. Our sysmon config is available
 [https://dip.torproject.org/torproject/anti-censorship/sysmon-
 configuration in this gitlab repository].  Here's how it works:
 > Sysmon runs checks every five minutes, and updates DNS records every ten
 minutes. If a check fails twice (e.g., a service is offline for more than
 five minutes), we get an alert.  Currently, cohosh and phw receive alerts.
 Our sysmon instance currently does not have IPv6 capabilities.

 Whenever one of our default bridges fail, cohosh and I get an email. This
 has happened a few times already. Do we want anything else?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23838 [Applications/Tor Browser]: Use OONI to inform Tor Launcher user workflow

2019-08-08 Thread Tor Bug Tracker & Wiki
#23838: Use OONI to inform Tor Launcher user workflow
--+---
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #31283| Points:
 Reviewer:|Sponsor:  Sponsor30-can
--+---
Changes (by pili):

 * sponsor:   => Sponsor30-can
 * parent:   => #31283


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21848 [Applications/Tor Browser]: Tor Browser always crashes after a few clicks

2019-08-08 Thread Tor Bug Tracker & Wiki
#21848: Tor Browser always crashes after a few clicks
--+--
 Reporter:  fuze83|  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Major | Resolution:  user disappeared
 Keywords:  tbb-crash |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by pili):

 * status:  needs_information => closed
 * resolution:   => user disappeared


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19948 [Applications/Tor Browser]: Some inconsistencies in Torbutton log

2019-08-08 Thread Tor Bug Tracker & Wiki
#19948: Some inconsistencies in Torbutton log
--+--
 Reporter:  bugzilla  |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Minor | Resolution:  user disappeared
 Keywords:  tbb-torbutton |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by pili):

 * status:  new => closed
 * resolution:   => user disappeared


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19921 [Applications/Tor Browser]: Tor Browser: improper handling of 404 Not Found images

2019-08-08 Thread Tor Bug Tracker & Wiki
#19921: Tor Browser: improper handling of 404 Not Found images
--+--
 Reporter:  bugzilla  |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Major | Resolution:  user disappeared
 Keywords:  tbb-linkability   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by pili):

 * status:  needs_information => closed
 * resolution:   => user disappeared


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18994 [Applications/Tor Browser]: Tor crashes after tor browser update running bridge mode in Windows

2019-08-08 Thread Tor Bug Tracker & Wiki
#18994: Tor crashes after tor browser update running bridge mode in Windows
--+--
 Reporter:  eli   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor broser, bridge mode   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by pili):

 Can we close this one?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31374 [Core Tor/Tor]: Appveyor: cast between incompatible function types in compat_time

2019-08-08 Thread Tor Bug Tracker & Wiki
#31374: Appveyor: cast between incompatible function types in compat_time
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  041-must tor-ci-fail Windows |  Actual Points:  0.1
  029-backport 035-backport 040-backport |
  041-backport   |
Parent ID:  #31343   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor2-must
-+-
Changes (by nickm):

 * actualpoints:   => 0.1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31374 [Core Tor/Tor]: Appveyor: cast between incompatible function types in compat_time

2019-08-08 Thread Tor Bug Tracker & Wiki
#31374: Appveyor: cast between incompatible function types in compat_time
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  041-must tor-ci-fail Windows |  Actual Points:
  029-backport 035-backport 040-backport |
  041-backport   |
Parent ID:  #31343   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor2-must
-+-
Changes (by nickm):

 * status:  accepted => needs_review


Comment:

 I have branches:

 `ticket31374_029` with PR at https://github.com/torproject/tor/pull/1221
 `ticket31374_035` (fixes a merge conflict) with PR at
 https://github.com/torproject/tor/pull/1222
 and `ticket31374_042` (for CI only) with PR at
 https://github.com/torproject/tor/pull/1223

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18113 [Applications/Tor Launcher]: Dynamically allocate clients to default Tor Browser bridges of a certain type

2019-08-08 Thread Tor Bug Tracker & Wiki
#18113: Dynamically allocate clients to default Tor Browser bridges of a certain
type
---+---
 Reporter:  isis   |  Owner:  brade
 Type:  enhancement| Status:  needs_information
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Launcher  |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-bridges|  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:  Sponsor30-can
---+---
Changes (by pili):

 * sponsor:   => Sponsor30-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17449 [Applications/Quality Assurance and Testing]: Test bridges we ship in Tor Browser regularly

2019-08-08 Thread Tor Bug Tracker & Wiki
#17449: Test bridges we ship in Tor Browser regularly
-+-
 Reporter:  gk   |  Owner:  boklm
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Quality Assurance and   |Version:
  Testing|
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability|  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor30-can
-+-
Changes (by pili):

 * cc: phw (added)
 * sponsor:   => Sponsor30-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17356 [Applications/Tor Browser]: Tor Browser crash on OS X while receiving Facebook notification in background

2019-08-08 Thread Tor Bug Tracker & Wiki
#17356: Tor Browser crash on OS X while receiving Facebook notification in
background
--+--
 Reporter:  teor  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-crash |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by pili):

 What should we do with these old Tor Browser tickets? Is it ok to close
 them?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17168 [Applications/Tor Browser]: Tor Browser, Linux: Blutmagie Torstatus page rendering horrifyingly slow, corrupt

2019-08-08 Thread Tor Bug Tracker & Wiki
#17168: Tor Browser, Linux: Blutmagie Torstatus page rendering horrifyingly 
slow,
corrupt
--+--
 Reporter:  starlight |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  wontfix
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by pili):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 This is working fine in 9.0a4

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31374 [Core Tor/Tor]: Appveyor: cast between incompatible function types in compat_time

2019-08-08 Thread Tor Bug Tracker & Wiki
#31374: Appveyor: cast between incompatible function types in compat_time
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  041-must tor-ci-fail Windows |  Actual Points:
  029-backport 035-backport 040-backport |
  041-backport   |
Parent ID:  #31343   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor2-must
-+-
Changes (by nickm):

 * status:  new => accepted
 * owner:  (none) => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31376 [Circumvention/Snowflake]: Make a /metrics handle at the snowflake broker for the stats collector

2019-08-08 Thread Tor Bug Tracker & Wiki
#31376: Make a /metrics handle at the snowflake broker for the stats collector
-+-
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  enhancement  | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   |   Keywords:  metrics, stats,
 |  broker
Actual Points:  1|  Parent ID:
   Points:   |   Reviewer:
  Sponsor:  Sponsor28|
-+-
 We have metrics being written to a log file for now as specified in
 #21315, and the metrics team is working on setting up a collector module
 for it in #29461. We should add a handler at the broker at `snowflake-
 bro...@bamsoftware.com/metrics` so the collector can make GET requests for
 the collected metrics.

 The response should be
 {{{Content-Type: text/plain; charset=utf-8}}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31343 [Core Tor/Tor]: appveyor: labs(time_t) is not allowed

2019-08-08 Thread Tor Bug Tracker & Wiki
#31343: appveyor: labs(time_t) is not allowed
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Very High|  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Major| Resolution:
 Keywords:  backports? tor-ci-fail 029-backport  |  Actual Points:  .1
  035-backport 040-backport 041-backport |
Parent ID:   | Points:
 Reviewer:  mikeperry, teor  |Sponsor:
-+-
Changes (by nickm):

 * keywords:  backports? tor-ci 029-backport 035-backport 040-backport
 041-backport =>
 backports? tor-ci-fail 029-backport 035-backport 040-backport
 041-backport


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30979 [Core Tor/Tor]: pre-push hook runs practracker unconditionally

2019-08-08 Thread Tor Bug Tracker & Wiki
#30979: pre-push hook runs practracker unconditionally
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  git-scripts   |  Actual Points:  0
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  accepted => needs_review
 * actualpoints:   => 0


Comment:

 I ran ahead and did this, since I'm getting annoyed about seeing
 practracker failures whenever I push an older branch.

 See my branch `ticket30979` with PR at
 https://github.com/torproject/tor/pull/1220 .

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30979 [Core Tor/Tor]: pre-push hook runs practracker unconditionally

2019-08-08 Thread Tor Bug Tracker & Wiki
#30979: pre-push hook runs practracker unconditionally
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  git-scripts   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  new => accepted
 * owner:  (none) => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31343 [Core Tor/Tor]: appveyor: labs(time_t) is not allowed

2019-08-08 Thread Tor Bug Tracker & Wiki
#31343: appveyor: labs(time_t) is not allowed
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Very High|  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Major| Resolution:
 Keywords:  backports? tor-ci 029-backport   |  Actual Points:  .1
  035-backport 040-backport 041-backport |
Parent ID:   | Points:
 Reviewer:  mikeperry, teor  |Sponsor:
-+-
Changes (by nickm):

 * keywords:
 backports? 041-must tor-ci-fail 029-backport 035-backport 040-backport
 041-backport
 => backports? tor-ci 029-backport 035-backport 040-backport
 041-backport
 * milestone:  Tor: 0.4.1.x-final => Tor: 0.4.0.x-final


Comment:

 Fixed that and ran tests. There is still an appveyor issue wrt function
 casting, but that isn't this.

 These branches are now merged to maint-0.4.1 and forward; marking for
 backport.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31322 [Applications/Tor Browser]: Fix about:tor assertion failure in esr68 linux debug builds

2019-08-08 Thread Tor Bug Tracker & Wiki
#31322: Fix about:tor assertion failure in esr68 linux debug builds
-+-
 Reporter:  acat |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201908R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-

Comment (by mcs):

 r=brade,r=mcs

 We did not test this but it looks good.
 Kathy and I don't know enough about the security implications of using
 `unsafe-inline`; do we need to file a new ticket about removing the need
 for that option?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31232 [Internal Services/Tor Sysadmin Team]: Migrate default snowflake broker (and bridge?) to TPA machines

2019-08-08 Thread Tor Bug Tracker & Wiki
#31232: Migrate default snowflake broker (and bridge?) to TPA machines
-+-
 Reporter:  cohosh   |  Owner:  tpa
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by anarcat):

 1. if you just need a domain, and not a machine, that is fast and quick. i
 *think* the policy is that non-TPA machines get a torproject.net hostname,
 but I can verify that. if you *do* want us to host the machine as well,
 you will definitely need to be most specific on this.

 2. yes, it seems like a good idea to figure out a fix for this in the long
 term

 3. allowing root on TPA machines is a problem. we don't normally allow
 that: we handle the OS-level stuff and grant you access to an account
 (with the sudo access you need, e.g. restart apache or something) on a
 case-by-case basis

 Regarding "monitoring", if the machine is TPA, you get a ton of monitoring
 for free. If it's non-TPA, you get the experimental/external Prometheus
 server that doesn't do alerts.

 So I guess the next step is to actually decide if we absorb this or not,
 and for that we need more precise numbers. I need to know how much memory
 (in GB), disk (size and HDD or SSD or NVMe too), CPU (count and type) and
 bandwidth usage (in TB/mth or gbps 95th percentile) we're talking about.

 Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31207 [Core Tor/Tor]: Space out first connection_edge_process_relay_cell() line in circuit_receive_relay_cell()

2019-08-08 Thread Tor Bug Tracker & Wiki
#31207: Space out first connection_edge_process_relay_cell() line in
circuit_receive_relay_cell()
---+
 Reporter:  neel   |  Owner:  neel
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  dgoulet-merge  |  Actual Points:
Parent ID: | Points:
 Reviewer:  nickm  |Sponsor:
---+
Changes (by teor):

 * keywords:  backport?, dgoulet-merge => dgoulet-merge


Comment:

 This seems to just be formatting/refactoring, so I'm not sure if it's
 worth a backport?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31089 [Core Tor/Tor]: Consider using data-URI to embed how_tor_works_thumb.png image into tor-exit-notice.html

2019-08-08 Thread Tor Bug Tracker & Wiki
#31089: Consider using data-URI to embed how_tor_works_thumb.png image into tor-
exit-notice.html
-+-
 Reporter:  rl1987   |  Owner:  (none)
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Trivial  | Resolution:
 Keywords:  security-low, consider-backport- |  Actual Points:  0.2
  after-0416, 029-backport, 035-backport,|
  040-backport, 041-backport, asn-merge  |
Parent ID:   | Points:  0.2
 Reviewer:  teor |Sponsor:
-+-
Changes (by dgoulet):

 * keywords:
 security-low, consider-backport-after-0416, 029-backport,
 035-backport, 040-backport, 041-backport
 =>
 security-low, consider-backport-after-0416, 029-backport,
 035-backport, 040-backport, 041-backport, asn-merge


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31012 [Core Tor/Tor]: tor-print-ed-signing-cert shows local time, without a timezone

2019-08-08 Thread Tor Bug Tracker & Wiki
#31012: tor-print-ed-signing-cert shows local time, without a timezone
---+
 Reporter:  teor   |  Owner:  rl1987
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor   |Version:  Tor: 0.3.5.1-alpha
 Severity:  Normal | Resolution:
 Keywords:  dgoulet-merge  |  Actual Points:  0.1
Parent ID: | Points:  0.1
 Reviewer:  nickm  |Sponsor:
---+
Changes (by dgoulet):

 * keywords:   => dgoulet-merge


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31207 [Core Tor/Tor]: Space out first connection_edge_process_relay_cell() line in circuit_receive_relay_cell()

2019-08-08 Thread Tor Bug Tracker & Wiki
#31207: Space out first connection_edge_process_relay_cell() line in
circuit_receive_relay_cell()
--+
 Reporter:  neel  |  Owner:  neel
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  backport?, dgoulet-merge  |  Actual Points:
Parent ID:| Points:
 Reviewer:  nickm |Sponsor:
--+
Changes (by dgoulet):

 * keywords:  backport? => backport?, dgoulet-merge


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31372 [Core Tor/Tor]: Appveyor and Travis should use "make -k" (was: Appveyor should use "make -k")

2019-08-08 Thread Tor Bug Tracker & Wiki
#31372: Appveyor and Travis should use "make -k"
--+
 Reporter:  nickm |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-ci|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Description changed by teor:

Old description:

> Right now our .appveyor.yml is not using the "-k" make flag.  That means
> that once it encounters an error, it stops building.  In general, we
> would prefer our CI to keep trying to build for a long as it can, so that
> we can see all of the warnings and errors that are produced.  This will
> help us save round trips between the developer and the CI process.

New description:

 Right now our .appveyor.yml and .travis.yml are not using the "-k" make
 flag.  That means that once it encounters an error, it stops building.  In
 general, we would prefer our CI to keep trying to build for a long as it
 can, so that we can see all of the warnings and errors that are produced.
 This will help us save round trips between the developer and the CI
 process.

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31232 [Internal Services/Tor Sysadmin Team]: Migrate default snowflake broker (and bridge?) to TPA machines

2019-08-08 Thread Tor Bug Tracker & Wiki
#31232: Migrate default snowflake broker (and bridge?) to TPA machines
-+-
 Reporter:  cohosh   |  Owner:  tpa
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cohosh):

 There are a few different scenarios here. Basically what we want in the
 end is for us to be able to handle outages and maintenance to key
 snowflake infrastructure as an organization without relying solely on dcf.
 The key infrastructure here is the snowflake bridge (which is hard-coded
 into the proxies and therefore difficult to update a change of IP address
 quickly), and the snowflake broker (think of this as bridgeDB but for
 Snowflake).

 Right now both the bridge and the broker are on hosts and domains owned by
 dcf. We as the anti-censorship team have access to the hosts, but if
 something goes wrong with the domain (as happened in #31230), our hands
 are still tied. We hacked together a temporary fix by pointing
 `freehaven.net` domains to the bridge and broker machines but that
 shouldn't be our permanent solution.

 So to answer your questions:

 1) We definitely need a tp.org (or tp.net)? domain to point to the broker
 and bridge IP addresses. There is a rumour going around that we only want
 to use these domains for hosts we control. If that is true, then we need a
 domain-fronted snowflake broker host and a snowflake bridge host. I
 suppose it's up to the sysadmin team as to whether these are each their
 own machines or not. The resource usage doesn't seem too bad at the moment
 but the bridge will need a lot of data transfer. I can be more specific
 about resource numbers if needed. I think dcf said he'd be happy to keep
 hosting these services as long as we're happy to point our domains at his
 machines but I'll let him confirm that.

 2) It's not urgent because things are back up and running now but I think
 it's a good idea to keep the ball rolling on this. Now if Roger and dcf
 are unavailable we're in a tough spot again until we hack together another
 quick fix.

 3) The anti-censorship team will need root access to both the bridge and
 broker for monitoring/logs/installation/update abilities.

 As far as #29863 and #31159, we'll still want prometheus monitoring. I'm
 not sure whether this is something the anti-censorship team or the
 sysadmin team will "own" though. I suppose if TPA absorbs the snowflake
 infrastructure, then it is in a similar category as bridgedb or gettor and
 I'm not clear on where we are with who is in charge of monitoring this
 infrastructure at the moment.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31375 [Core Tor/Tor]: hs: Crash in token_bucket_ctr_refill() of the INTRO2 DoS defense (was: hs: Crasg in token_bucket_ctr_refill() of the INTRO2 DoS defense)

2019-08-08 Thread Tor Bug Tracker & Wiki
#31375: hs: Crash in token_bucket_ctr_refill() of the INTRO2 DoS defense
---+
 Reporter:  dgoulet|  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Very High  |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, crash  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:  Sponsor27-must
---+

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31375 [Core Tor/Tor]: hs: Crasg in token_bucket_ctr_refill() of the INTRO2 DoS defense

2019-08-08 Thread Tor Bug Tracker & Wiki
#31375: hs: Crasg in token_bucket_ctr_refill() of the INTRO2 DoS defense
+
 Reporter:  dgoulet |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Very High   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  |   Keywords:  tor-hs, crash
Actual Points:  |  Parent ID:
   Points:  |   Reviewer:
  Sponsor:  Sponsor27-must  |
+
 Ran my relay for some minutes with master (merged #15516) and the HS DoS
 defenses enabled. Relay died with this:

 {{{
 Tor 0.4.2.0-alpha-dev (git-0acfd7dcee2a4473) died: Caught signal 8
 /home/tor/git/tor/src/app/tor(+0x20d359)[0x5594030b1359]
 /home/tor/git/tor/src/app/tor(token_bucket_ctr_refill+0x3b)[0x55940304c33b]
 /home/tor/git/tor/src/app/tor(token_bucket_ctr_refill+0x3b)[0x55940304c33b]
 /home/tor/git/tor/src/app/tor(hs_dos_can_send_intro2+0x45)[0x559402fb6ba5]
 /home/tor/git/tor/src/app/tor(rend_mid_introduce_legacy+0x136)[0x559402ff7096]
 
/home/tor/git/tor/src/app/tor(hs_intro_received_introduce1+0x2ce)[0x5594030457ee]
 /home/tor/git/tor/src/app/tor(rend_process_relay_cell+0x1bf)[0x559402ff643f]
 /home/tor/git/tor/src/app/tor(+0xb9105)[0x559402f5d105]
 /home/tor/git/tor/src/app/tor(+0xb9b60)[0x559402f5db60]
 /home/tor/git/tor/src/app/tor(circuit_receive_relay_cell+0x490)[0x559402f5f590]
 /home/tor/git/tor/src/app/tor(command_process_cell+0x3f8)[0x559402f40ed8]
 /home/tor/git/tor/src/app/tor(channel_tls_handle_cell+0x39b)[0x559402f2078b]
 /home/tor/git/tor/src/app/tor(+0xa5a9c)[0x559402f49a9c]
 /home/tor/git/tor/src/app/tor(connection_handle_read+0xa0d)[0x559402f0dd0d]
 /home/tor/git/tor/src/app/tor(+0x6ef1e)[0x559402f12f1e]
 /usr/lib/x86_64-linux-gnu/libevent-2.1.so.6(+0x1e8f8)[0x7f15b29208f8]
 /usr/lib/x86_64-linux-
 gnu/libevent-2.1.so.6(event_base_loop+0x53f)[0x7f15b292133f]
 /home/tor/git/tor/src/app/tor(do_main_loop+0xd9)[0x559402f14209]
 /home/tor/git/tor/src/app/tor(tor_run_main+0x128d)[0x559402f01d9d]
 /home/tor/git/tor/src/app/tor(tor_main+0x3a)[0x559402eff1da]
 /home/tor/git/tor/src/app/tor(main+0x19)[0x559402efed69]
 /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xe7)[0x7f15b197]
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31343 [Core Tor/Tor]: appveyor: labs(time_t) is not allowed

2019-08-08 Thread Tor Bug Tracker & Wiki
#31343: appveyor: labs(time_t) is not allowed
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Very High|  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Major| Resolution:
 Keywords:  backports? 041-must tor-ci-fail  |  Actual Points:  .1
  029-backport 035-backport 040-backport |
  041-backport   |
Parent ID:   | Points:
 Reviewer:  mikeperry, teor  |Sponsor:
-+-
Changes (by teor):

 * keywords:
 backports? 041-must tor-ci 029-backport 035-backport 040-backport
 041-backport
 =>
 backports? 041-must tor-ci-fail 029-backport 035-backport 040-backport
 041-backport


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31374 [Core Tor/Tor]: Appveyor: cast between incompatible function types in compat_time

2019-08-08 Thread Tor Bug Tracker & Wiki
#31374: Appveyor: cast between incompatible function types in compat_time
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  041-must tor-ci-fail Windows |  Actual Points:
  029-backport 035-backport 040-backport |
  041-backport   |
Parent ID:  #31343   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor2-must
-+-
Changes (by teor):

 * keywords:
 041-must tor-ci Windows 029-backport 035-backport 040-backport
 041-backport
 =>
 041-must tor-ci-fail Windows 029-backport 035-backport 040-backport
 041-backport


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31374 [Core Tor/Tor]: Appveyor: cast between incompatible function types in compat_time

2019-08-08 Thread Tor Bug Tracker & Wiki
#31374: Appveyor: cast between incompatible function types in compat_time
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.4.1.x-final
Component:  Core |Version:  Tor: 0.2.9.1-alpha
  Tor/Tor|   Keywords:  041-must tor-ci Windows
 Severity:  Normal   |  029-backport 035-backport 040-backport
 |  041-backport
Actual Points:   |  Parent ID:  #31343
   Points:  0.5  |   Reviewer:
  Sponsor:   |
  Sponsor2-must  |
-+-
 The latest Appveyor compiler complains:
 {{{
 ../src/lib/time/compat_time.c:522:25: error: cast between incompatible
 function types from 'FARPROC' to 'ULONGLONG (__attribute__((stdcall))
 *)(void)' [-Werror=cast-function-type]
   522 | GetTickCount64_fn = (GetTickCount64_fn_t)
   | ^
 }}}

 This issue is like #27465:

 GetProcAddress() returns FARPROC, which is (long long int(*)()) on
 64-bit Windows:
 https://msdn.microsoft.com/en-
 us/library/windows/desktop/ms683212(v=vs.85).aspx

 But GetTickCount64() is (long long unsigned int(*)()), on both 32-bit
 and 64-bit Windows:
 https://docs.microsoft.com/en-us/windows/win32/api/sysinfoapi/nf-
 sysinfoapi-gettickcount64

 So gcc 8 issues a spurious "incompatible function pointer" warning
 about the cast to GetTickCount64_fn_t.

 Silence this warning by casting to a void function pointer, before
 the cast to GetTickCount64_fn_t.

 Fixes bug N; bugfix on 0.2.9.1-alpha.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31100 [Circumvention/Snowflake]: Firefox addon not reporting any users

2019-08-08 Thread Tor Bug Tracker & Wiki
#31100: Firefox addon not reporting any users
-+-
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  snowflake-webextension anti- |  Actual Points:
  censorship-roadmap-august  |
Parent ID:   | Points:  2
 Reviewer:  dcf  |Sponsor:
 |  Sponsor28
-+-
Changes (by cohosh):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged in `e77baabdcfd742d6dbc4dbf2a74f21ba6d36ad36`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31030 [Core Tor/Tor]: Coverity: Several warnings from test code

2019-08-08 Thread Tor Bug Tracker & Wiki
#31030: Coverity: Several warnings from test code
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  coverity  |  Actual Points:  .1
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 Seems to be an issue with one of the fixes. I'm actually confused how our
 unit tests didn't explode there...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31030 [Core Tor/Tor]: Coverity: Several warnings from test code

2019-08-08 Thread Tor Bug Tracker & Wiki
#31030: Coverity: Several warnings from test code
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  coverity  |  Actual Points:  .1
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by dgoulet):

 * reviewer:  teor => dgoulet


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31359 [Core Tor/Tor]: Split a control_event module out of control, and make it use control safe logging

2019-08-08 Thread Tor Bug Tracker & Wiki
#31359: Split a control_event module out of control, and make it use control 
safe
logging
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  wontfix
 Keywords:  network-team-roadmap-august  |  Actual Points:
Parent ID:  #30901   | Points:  2
 Reviewer:   |Sponsor:  Sponsor31-can
-+-
Changes (by teor):

 * status:  assigned => closed
 * resolution:   => wontfix


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31314 [Core Tor/Tor]: Modify git-merge-forward.sh so it can create test merge branches

2019-08-08 Thread Tor Bug Tracker & Wiki
#31314: Modify git-merge-forward.sh so it can create test merge branches
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  git-scripts, network-team-roadmap-   |  Actual Points:  0.6
  october|
Parent ID:  #31178   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor31-must
-+-
Changes (by teor):

 * keywords:  git-scripts => git-scripts, network-team-roadmap-october


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31178 [Core Tor/Tor]: Scripts to help with backport branches

2019-08-08 Thread Tor Bug Tracker & Wiki
#31178: Scripts to help with backport branches
--+
 Reporter:  nickm |  Owner:  (none)
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:  Tor:
  |  0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  network-team-roadmap-october  |  Actual Points:
Parent ID:| Points:  2
 Reviewer:|Sponsor:  Sponsor31-must
--+
Changes (by teor):

 * owner:  teor => (none)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31178 [Core Tor/Tor]: Scripts to help with backport branches

2019-08-08 Thread Tor Bug Tracker & Wiki
#31178: Scripts to help with backport branches
--+
 Reporter:  nickm |  Owner:  teor
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:  Tor:
  |  0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  network-team-roadmap-october  |  Actual Points:
Parent ID:| Points:  2
 Reviewer:|Sponsor:  Sponsor31-must
--+

Comment (by teor):

 Once #31314 merges, we can downgrade this ticket to sponsor31-can.

 I don't think writing a script to automatically create pull requests is a
 good use of my time (I haven't done any GitHub automation before). If
 someone else wants to do it, we should spend up to 1 day on it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31314 [Core Tor/Tor]: Modify git-merge-forward.sh so it can create test merge branches

2019-08-08 Thread Tor Bug Tracker & Wiki
#31314: Modify git-merge-forward.sh so it can create test merge branches
--+
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  git-scripts   |  Actual Points:  0.6
Parent ID:  #31178| Points:  1
 Reviewer:|Sponsor:  Sponsor31-must
--+
Changes (by teor):

 * sponsor:  Sponsor31-can => Sponsor31-must


Comment:

 Match parent sponsor must.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

  1   2   >