Re: [tor-bugs] #31569 [Applications/Tor Browser]: Revert #4427 to be on par with Fennec ESR68 and avoid regressions

[Tor Bug Tracker & Wiki]

#31569: Revert #4427 to be on par with Fennec ESR68 and avoid regressions
-+-
 Reporter:  cypherpunks  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-security, tbb-parity,  |  Actual Points:
  tbb-mobile |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 `tbb-mobile` is fine. It's about TBB to be on par with TBA.
 See Bugzilla for security "regressions".

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30461 [Applications/Tor Browser]: Update tor-android-service Project to Use Android Toolchain (Firefox 68)

[Tor Bug Tracker & Wiki]

#30461: Update tor-android-service Project to Use Android Toolchain (Firefox 68)
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff68-esr, tbb-9.0-must- |  Actual Points:
  nightly, TorBrowserTeam201908  |
Parent ID:  #30324   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-

Comment (by gk):

 Replying to [comment:12 sisbell]:
 > I need to get review and merge of tor-android-service. Branch 0801a
 contain all the latest changes from orbot to tor-android-service. There
 are a lot of changes here since I've been keeping up with the work going
 into Orbot.
 >
 > https://github.com/sisbell/tor-android-service/commits/0801a
 >
 > Revision 5c9583cf8e2b7002f71c2971aae7ebb44c067b42 on July 17th is the
 minimum I think we can use, so that would cut down a lot of review time.
 The changes after are not so critical for us.

 Okay. I can see how that particular commit is relevant for us but I am not
 so sure about the previous ones. What about we pick just that one for now
 to unblock our nightly and alpha builds and think about the other ones
 later on?

 > How do we want to do this?

 We can discuss this in one of our team meetings but here is how I think we
 should do it: we treat tor-android-service as any of our other project.
 That means proposed changes need a ticket on our bug tracker (right now
 this is Trac but it might become Gitlab or $foo). Then someone needs to
 write a patch, point to a branch (be that one on our own infrastructure,
 or Github, Gitlab or...) and find someone to review and merge the changes.

 The patch should a) be based on our master branch as we own the canonical
 repo now and b) it should be written in a way that we don't have to
 suddenly apply patches to any of our other projects. E.g. it's nice to
 redo the VPN support part but the resulting patch should be written in a
 way that we not have to suddenly apply `tor-browser-build` patches to rip
 things out there. More precisely, it would be written in a way that
 projects can make use of VPN support but others can safely ignore that
 part to reduce attack surface etc. by setting a compile time option to
 just not compile that part in in the first place.

 Does that make sense? If so, please file new tickets for the changes we
 should make in `tor-android-service`, point to the patches (please base
 them on our `master` branch to make merging easier) and set the tickets
 into `needs_review`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13430 [Applications/TorBirdy]: Can't set custom http-proxy on GnuPG-settings, lost after restart

[Tor Bug Tracker & Wiki]

#13430: Can't set custom http-proxy on GnuPG-settings, lost after restart
---+---
 Reporter:  jarrod.ewing   |  Owner:  ioerror
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Applications/TorBirdy  |Version:
 Severity:  Normal | Resolution:  duplicate
 Keywords:  GnuPG, http-proxy  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---

Comment (by Mistywatkins):

 [https://bobhoney.com/ bob honey who just do stuff]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30845 [Applications/Tor Browser]: Make sure default Firefox themes are enabled on ESR68

[Tor Bug Tracker & Wiki]

#30845: Make sure default Firefox themes are enabled on ESR68
-+-
 Reporter:  acat |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff68-esr, TorBrowserTeam201908R, |  Actual Points:
  tbb-9.0-must-alpha |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-

Comment (by cypherpunks):

 `tbb-parity` achieved.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31563 [Applications/Tor Browser]: Urlbar search icons disappear after browser restart

[Tor Bug Tracker & Wiki]

#31563: Urlbar search icons disappear after browser restart
-+-
 Reporter:  acat |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, TorBrowserTeam201908,  |  Actual Points:
  tbb-9.0-must-alpha |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 > 3. Check that search icons have disappeared.
 I.e. some functionality has been removed. Changing prefs can't restore it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31569 [Applications/Tor Browser]: Revert #4427 to be on par with Fennec ESR68 and avoid regressions

[Tor Bug Tracker & Wiki]

#31569: Revert #4427 to be on par with Fennec ESR68 and avoid regressions
-+-
 Reporter:  cypherpunks  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-security, tbb-parity,  |  Actual Points:
  tbb-mobile |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 What you have disabled in #4427: https://developer.mozilla.org/en-
 US/docs/Mozilla/Add-ons/WebExtensions/Distribution_options/Add-
 ons_in_the_enterprise#Firefox_settings

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31570 [Core Tor/Tor]: INTERNAL ERROR: raw assertion failed (core dump) in termux

[Tor Bug Tracker & Wiki]

#31570: INTERNAL ERROR: raw assertion failed (core dump) in termux
-+-
 Reporter:  foremtehan   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  042-should, regression?, mmap,   |  Actual Points:
  android|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:   => 042-should, regression?, mmap, android
 * status:  new => needs_information
 * milestone:   => Tor: 0.4.2.x-final


Comment:

 There's a lot of info in those links, but I can't find the tor version
 you're using?

 I think we fixed a similar mmap bug recently, we'll know if we can find
 you what version you're using.

 There's also a missing newline and tor version bug in the logs here, so
 raw_assert() also has some bugs. I'll open a child ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31571 [Core Tor/Tor]: Add the tor version and a newline to raw_assert()

[Tor Bug Tracker & Wiki]

#31571: Add the tor version and a newline to raw_assert()
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  042-should, regression?, mmap,
 Severity:  Normal   |  android
Actual Points:   |  Parent ID:  #31570
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 We're missing a newline and the tor version in the logs for #31570.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31569 [Applications/Tor Browser]: Revert #4427 to be on par with Fennec ESR68 and avoid regressions

[Tor Bug Tracker & Wiki]

#31569: Revert #4427 to be on par with Fennec ESR68 and avoid regressions
-+-
 Reporter:  cypherpunks  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-security, tbb-parity,  |  Actual Points:
  tbb-mobile |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:2 cypherpunks]:
 > `tbb-mobile` is fine. It's about TBB to be on par with TBA.
 > See Bugzilla for security "regressions".

 It's affecting us on Android, too, as we use the prefs we override for
 desktop there as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31558 [Metrics/CollecTor]: Process bridge pool assignments again

[Tor Bug Tracker & Wiki]

#31558: Process bridge pool assignments again
---+--
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by karsten):

 * status:  new => needs_review


Comment:

 irl, please review
 
[https://gitweb.torproject.org/user/karsten/collector.git/commit/?h=task-31558&id=db2a6bdab1bfc12377c515577589aa67d34fa2ba
 commit db2a6bd in my task-31558 branch]. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31568 [Applications/Tor Browser]: Update How to Create Gradle Dependencies

[Tor Bug Tracker & Wiki]

#31568: Update How to Create Gradle Dependencies
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff68-esr, tbb-9.0-must- |  Actual Points:
  nightly, TorBrowserTeam201908R |
Parent ID:  #30324   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm, ff68-esr, tbb-9.0-must-nightly, TorBrowserTeam201908
 => tbb-rbm, ff68-esr, tbb-9.0-must-nightly, TorBrowserTeam201908R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31558 [Metrics/CollecTor]: Process bridge pool assignments again

[Tor Bug Tracker & Wiki]

#31558: Process bridge pool assignments again
---+--
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer:  irl|Sponsor:
---+--
Changes (by karsten):

 * reviewer:   => irl


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31572 [Applications/Tor Browser]: Extension errors after a while of surfing with Tor Browser based on ESR68

[Tor Bug Tracker & Wiki]

#31572: Extension errors after a while of surfing with Tor Browser based on 
ESR68
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  ff68-esr
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 I see extension errors in my console after a while of surfing:
 {{{
 Extension error: [Exception... "Component returned failure code:
 0x80004005 (NS_ERROR_FAILURE)
 [nsIDOMWindowUtils.removeSheetUsingURIString]"  nsresult: "0x80004005
 (NS_ERROR_FAILURE)"  location: "JS frame ::
 resource://gre/modules/ExtensionCommon.jsm :: runSafeSyncWithoutClone ::
 line 75"  data: no] undefined 75
 [[Exception stack
 runSafeSyncWithoutClone@resource://gre/modules/ExtensionCommon.jsm:75:12
 cleanup@resource://gre/modules/ExtensionContent.jsm:403:11
 close@resource://gre/modules/ExtensionContent.jsm:913:14
 inner-window-destroyed@resource://gre/modules/ExtensionContent.jsm:998:19
 observe@resource://gre/modules/ExtensionContent.jsm:1016:27
 Current stack
 runSafeSyncWithoutClone@resource://gre/modules/ExtensionCommon.jsm:81:9
 cleanup@resource://gre/modules/ExtensionContent.jsm:403:11
 close@resource://gre/modules/ExtensionContent.jsm:913:14
 inner-window-destroyed@resource://gre/modules/ExtensionContent.jsm:998:19
 observe@resource://gre/modules/ExtensionContent.jsm:1016:27
 ]]
 }}}
 Not sure what is trigger those.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30460 [Applications/Tor Browser]: Update TOPL Project to Use Android Toolchain (Firefox 68)

[Tor Bug Tracker & Wiki]

#30460: Update TOPL Project to Use Android Toolchain (Firefox 68)
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff68-esr, tbb-9.0-must- |  Actual Points:
  nightly, TorBrowserTeam201908R |
Parent ID:  #30324   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-
Changes (by gk):

 * keywords:  tbb-rbm, ff68-esr, tbb-9.0-must-nightly, TorBrowserTeam201908
 => tbb-rbm, ff68-esr, tbb-9.0-must-nightly, TorBrowserTeam201908R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31567 [Applications/Tor Browser]: NS_tsnprintf() does not handle %s correctly on Windows

[Tor Bug Tracker & Wiki]

#31567: NS_tsnprintf() does not handle %s correctly on Windows
-+-
 Reporter:  mcs  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201908R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by pospeselr):

 * keywords:  ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201908 =>
 ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201908R
 * status:  needs_information => needs_review


Comment:

 **tldr** there's a patch at the end

 Did some digging on this tonight just for fun. According to this post on
 stack overflow ( https://stackoverflow.com/a/18283757 ) libstdc++ is built
 with the {{{__USE_MINGW_ANSI_STDIO}}} define, so calls to the printf and
 wprintf function families will use the expected format string behaviour
 found on non-windows platforms. Apparently libstdc++ depends on the ANSI
 stdio behavior so it's toggled on.

 The following program will output differently depending on which headers
 you use (C or C++) even if you build with mingw g++
 {{{
 #ifdef USE_STDC
 #include 
 #include 
 #else
 #include 
 #include 
 ##endif

 int main()
 {
 printf("1: %s\n", "ansi format, ansi string");
 printf("2: %S\n", L"ansi format, wide string");
 wprintf(L"3: %s\n", "wide format, ansi string");
 wprintf(L"4: %S\n", L"wide format, wide string");
 fflush(stdout);
 }
 }}}


 


 If you build with the C headers, you get the following output (wine on
 linux):

 {{{
 1: ansi format, ansi string
 2: ansi format, wide string
 3: 4: w
 }}}

 This it the output you would expect if you built with vcs given
 Microsoft's printf format specifiers ( https://docs.microsoft.com/en-
 us/cpp/c-runtime-library/format-specification-syntax-printf-and-wprintf-
 functions?view=vs-2019 )

 The first two prints work as expected, but the next two fail:
  3 is expecting the string to be a wide character string, but it
 encounters an ansi string. I don't know what this ansi string encodes as
 wide string, but it would seem wprintf gives up trying to print it. For
 shits and giggles, if we replace 3's ansi string with
 {{{"w\0i\0d\0e\0\0"}}} it prints out 'wide' to the console.
  4 is expecting an ansi string but gets a wide string, so it prints the
 ansi 'w', finds a NULL byte and treats it as a terminator, only printing
 out 'w'.

 

 If you build with the C++ headers (or if you build with the C headers and
 add {{{#define __USE_MINGW_ANSI_STDIO 1}}} before including {{{stdio.h}}},
 you get the following output:
 {{{
 1: ansi format, ansi string
 2: ansi format, wide string
 3: wide format, ansi string
 4: wide format, wide string
 }}}

 Which is as one would expect I think. Undefining
 {{{__USE_MINGW_ANSI_STDIO}}} or redifining it to 0 does not seem to
 reverse the effect when  using the C++ headers.

 

 However, we probably shouldn't go fucking around with this define because
 who what else depends on this behaviour to work. Instead, we should
 replace the _vsnwprintf call with StringCchVPrintfW. As StringCchVPrintfW
 has no expectation of conforming to ANSI C string format specifiers, it
 can instead ignore the {{{__USE_MINGW_ANSI_STDIO}}} define and always
 conform the Microsoft's specifiers. The following example builds and runs
 using the Microsoft formats:

 {{{
 #include 
 #include 

 #include 
 using namespace std;

 int main()
 {
 char abuffer[1024];
 wchar_t wbuffer[1024];

 StringCchPrintfA(abuffer, 1024, "1: %s\n", "ansi format, ansi
 string"); // small S for ansi
 cout << abuffer;
 StringCchPrintfA(abuffer, 1024, "2: %S\n", L"ansi format, wide
 string"); // big S for wide
 cout << abuffer;

 cout << flush;

 StringCchPrintfW(wbuffer, 1024, L"3 : %S\n", "wide format, ansi
 string"); // big S for ansi
 wcout << wbuffer;
 StringCchPrintfW(wbuffer, 1024, L"4': %s\n", L"wide format, wide
 string"); // small S for wide
 wcout << wbuffer;

 wcout << flush;
 }
 }}}

 

 This patch replaces the _vsnwprintf with StringCchVPrintfExW from
 strsafe.h, a windows specific function and as such implements Microsoft's
 format-string specifiers. The new implementation of mywcsprintf has the
 same outputs and retval as the old for a handful of test-cases.

 **tor-browser patch**:

 https://gitweb.torproject.org/user/richard/tor-
 browser.git/commit/?h=bug_31567

--
Ticket URL: 

Re: [tor-bugs] #31572 [Applications/Tor Browser]: Extension errors after a while of surfing with Tor Browser based on ESR68

[Tor Bug Tracker & Wiki]

#31572: Extension errors after a while of surfing with Tor Browser based on 
ESR68
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ff68-esr  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 After #31396?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31573 [Applications/Tor Browser]: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31573: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  ff68-esr
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 During start-up I can see:
 {{{
 JavaScript error: resource:///modules/sessionstore/SessionStore.jsm, line
 1325: uncaught exception: 2147746065
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31574 [Applications/Tor Browser]: TypeError: addon is null with Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31574: TypeError: addon is null with Tor Browser based on ESR 68
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  ff68-esr
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 During start-up I can see:
 {{{
 JavaScript error: resource:///modules/BrowserGlue.jsm, line 1851:
 TypeError: addon is null
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31575 [Applications/Tor Browser]: Firefox is phoning home during start-up in Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31575: Firefox is phoning home during start-up in Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  ff68-esr, tbb-9.0-must-
 Severity:  Normal   |  alpha, TorBrowserTeam201909
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Starting up one can see a bunch of requests going to Mozilla owned
 domains:
 {{{
 
https://firefox.settings.services.mozilla.com/v1/buckets/monitor/collections/changes/records?collection
 =cfr-fxa&bucket=main
 https://firefox.settings.services.mozilla.com/v1/buckets/main/collections
 /cfr-fxa?_expected=1562598365297
 https://firefox.settings.services.mozilla.com/v1/buckets/main/collections
 /cfr-fxa/records?_expected=1562598365297&_sort=-last_modified
 https://content-signature-2.cdn.mozilla.net/chains/remote-settings
 .content-signature.mozilla.org-2019-10-02-18-15-08.chain

 https://snippets.cdn.mozilla.net/us-
 west/bundles/bundle_8afc759e26e7da7a6283552f250fdf0a5602f4f3.json
 }}}
 We should figure out what we should do with those requests/underlying
 functionality.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30665 [Applications/Tor Browser]: Get Firefox 68 ESR Working with latest android toolchain

[Tor Bug Tracker & Wiki]

#30665: Get Firefox 68 ESR Working with latest android toolchain
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff68-esr, tbb-9.0-must- |  Actual Points:
  nightly, TorBrowserTeam201908  |
Parent ID:  #30324   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-

Comment (by gk):

 While skimming over the patch: please don't enable networking during
 build. What is the error you get?
 Additionally, while you remove the patch for 1527534 in the build script
 you still include it in the config file.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31396 [Applications/Tor Browser]: Communication with noscript for security settings not working in nightlies

[Tor Bug Tracker & Wiki]

#31396: Communication with noscript for security settings not working in 
nightlies
-+-
 Reporter:  acat |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff68-esr, TorBrowserTeam201908R, |  Actual Points:
  tbb-9.0-must-alpha |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-
Changes (by acat):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 bugzilla ticket: https://bugzilla.mozilla.org/show_bug.cgi?id=1577737

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31564 [Applications/Tor Browser]: Android bundles based on ESR 68 are not built reproducibly anymore

[Tor Bug Tracker & Wiki]

#31564: Android bundles based on ESR 68 are not built reproducibly anymore
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-9.0-must-nightly,|  Actual Points:
  TorBrowserTeam201908, GeorgKoppen201908|
Parent ID:  #30324   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 This looks like this issue:
 https://issuetracker.google.com/issues/110237303?pli=1
 (which annoyingly requires a google account just to see it)

 Apparently it has been fixed with:
 > I added sorting the input files in AGP in change list with Change-Id:
 I371304c8a6d244f8bb7833609f464eba000e608f - it should be available in
 android gradle plugin version 3.5 Canary 7
 > We cherry picked it into 3.4 and it should be available in the next 3.4
 canary. We'll see what we can do about 3.3.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30429 [Applications/Tor Browser]: Rebase Tor Browser patches for Firefox ESR 68

[Tor Bug Tracker & Wiki]

#30429: Rebase Tor Browser patches for Firefox ESR 68
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-nightly,  |  Actual Points:
  TorBrowserTeam201908   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-

Comment (by mcs):

 Here is a fixup for the #4234 patch which contains fixes for some Windows
 updater issues that Kathy and I found:

 https://gitweb.torproject.org/user/brade/tor-
 
browser.git/commit/?h=bug30429-fixup-01&id=f607d5bb45e536dc7094999252dc89c6bc84884b

 Mozilla moved the app.update.auto setting to a new JSON file that is
 designed to be shared across all Firefox profiles. Firefox also stores
 some update-related data (on Windows only) in a system location and we do
 not want either of these things.

 Please let me know if we need to create a new ticket for these; for now I
 am using this ticket because it is still open.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31571 [Core Tor/Tor]: Add the tor version and a newline to raw_assert()

[Tor Bug Tracker & Wiki]

#31571: Add the tor version and a newline to raw_assert()
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, 042-should, android,|  Actual Points:  0.1
  macos, 035-backport, 040-backport, |
  041-backport   |
Parent ID:  #31570   | Points:  0.1
 Reviewer:   |Sponsor:
 |  Sponsor31-can
-+-
Changes (by teor):

 * status:  new => needs_review
 * cc: gaba (added)
 * points:   => 0.1
 * sponsor:   => Sponsor31-can
 * actualpoints:   => 0.1
 * keywords:  042-should, regression?, mmap, android =>
 diagnostics, 042-should, android, macos, 035-backport, 040-backport,
 041-backport


Comment:

 See my pull request:
 * 0.3.5: https://github.com/torproject/tor/pull/1277

 The remaining merges are clean, you can see the test branches bug31571_*
 at:
 https://github.com/teor2345/tor/branches

 Gaba, I think this can be sponsor 31 can, because it helps us debug all
 our refactoring.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31570 [Core Tor/Tor]: INTERNAL ERROR: raw assertion failed (core dump) in termux

[Tor Bug Tracker & Wiki]

#31570: INTERNAL ERROR: raw assertion failed (core dump) in termux
-+-
 Reporter:  foremtehan   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  042-should, regression?, mmap,   |  Actual Points:
  android|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:2 teor]:
 > There's a lot of info in those links, but I can't find the tor version
 you're using?

 You'll have to let us know, it's definitely not in these logs.

 > There's also a missing newline and tor version bug in the logs here, so
 raw_assert() also has some bugs. I'll open a child ticket.

 I made sure it will be in future logs, see #31571.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31559 [Core Tor/Tor]: test-timers fail on maint-0.2.9

[Tor Bug Tracker & Wiki]

#31559: test-timers fail on maint-0.2.9
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.2.x-final
Component:  Core Tor/Tor   |Version:  Tor:
   |  0.2.9.17
 Severity:  Normal | Resolution:
   |  worksforme
 Keywords:  042-should, tor-ci-fail-sometimes  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by teor):

 * status:  new => closed
 * resolution:   => worksforme


Comment:

 Looks like it was a once-off travis load issue: the re-run passed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31563 [Applications/Tor Browser]: Urlbar search icons disappear after browser restart

[Tor Bug Tracker & Wiki]

#31563: Urlbar search icons disappear after browser restart
-+-
 Reporter:  acat |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, TorBrowserTeam201908,  |  Actual Points:
  tbb-9.0-must-alpha |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by acat):

 Bugzilla ticket: https://bugzilla.mozilla.org/show_bug.cgi?id=1577750

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30429 [Applications/Tor Browser]: Rebase Tor Browser patches for Firefox ESR 68

[Tor Bug Tracker & Wiki]

#30429: Rebase Tor Browser patches for Firefox ESR 68
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-nightly,  |  Actual Points:
  TorBrowserTeam201908   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-

Comment (by gk):

 Replying to [comment:49 mcs]:
 > Here is a fixup for the #4234 patch which contains fixes for some
 Windows updater issues that Kathy and I found:
 >
 > https://gitweb.torproject.org/user/brade/tor-
 
browser.git/commit/?h=bug30429-fixup-01&id=f607d5bb45e536dc7094999252dc89c6bc84884b
 >
 > Mozilla moved the app.update.auto setting to a new JSON file that is
 designed to be shared across all Firefox profiles. Firefox also stores
 some update-related data (on Windows only) in a system location and we do
 not want either of these things.
 >
 > Please let me know if we need to create a new ticket for these; for now
 I am using this ticket because it is still open.

 Here is fine, thanks. The patch looks good to me. Merged to`tor-
 browser-68.1.0esr-9.0-1` (commit
 f607d5bb45e536dc7094999252dc89c6bc84884b).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31564 [Applications/Tor Browser]: Android bundles based on ESR 68 are not built reproducibly anymore

[Tor Bug Tracker & Wiki]

#31564: Android bundles based on ESR 68 are not built reproducibly anymore
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-9.0-must-nightly,|  Actual Points:
  TorBrowserTeam201908, GeorgKoppen201908|
Parent ID:  #30324   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Hm. Did they say when it got introduced? Is our reproducible builds setup
 broken that we did not detect that problem during the esr60 cycle? Or is
 that really a thing that got introduced with the new toolchain we use.

 That said, sisbell, what are our options here? Can we just use a newer
 gradle plugin which has this fixed? Or do we need to build that one
 ourselves and use it then or...?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #31001, #31089

[Tor Bug Tracker & Wiki]

Batch modification to #31001, #31089 by teor:


Comment:
0.4.1.5 was stable, so these get backported after the next alpha

--
Tickets URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #23818, #31088

[Tor Bug Tracker & Wiki]

Batch modification to #23818, #31088 by teor:


Comment:
Oops, drop the -alpha from backport versions

--
Tickets URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31570 [Core Tor/Tor]: INTERNAL ERROR: raw assertion failed (core dump) in termux

[Tor Bug Tracker & Wiki]

#31570: INTERNAL ERROR: raw assertion failed (core dump) in termux
-+-
 Reporter:  foremtehan   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  042-should, regression?, mmap,   |  Actual Points:
  android|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by foremtehan):

 Replying to [comment:2 teor]:

 >we'll know if we can find you what version you're using.


 I installed tor through termux by "pkg install tor", I find the version
 btw:

 https://i.imgur.com/1IVlFNt.png

 > There's also a missing newline and tor version bug in the logs here, so
 raw_assert() also has some bugs. I'll open a child ticket.

 Is there anything I need to do؟

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31564 [Applications/Tor Browser]: Android bundles based on ESR 68 are not built reproducibly anymore

[Tor Bug Tracker & Wiki]

#31564: Android bundles based on ESR 68 are not built reproducibly anymore
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-9.0-must-nightly,|  Actual Points:
  TorBrowserTeam201908, GeorgKoppen201908|
Parent ID:  #30324   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Someone on the ticket is mentioning that:
 > The latest version that worked was using
 com.android.tools.build:gradle:3.0.1, buildToolsVersion '26.0.2' and
 aaptOptions { cruncherEnabled = false }

 We were using 3.0.1 in esr60, so this is probably why we didn't get the
 issue previously.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31570 [Core Tor/Tor]: INTERNAL ERROR: raw assertion failed (core dump) in termux

[Tor Bug Tracker & Wiki]

#31570: INTERNAL ERROR: raw assertion failed (core dump) in termux
-+-
 Reporter:  foremtehan   |  Owner:  nickm
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  042-should, regression?, mmap,   |  Actual Points:
  android|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  needs_information => assigned
 * owner:  (none) => nickm


Comment:

 Replying to [comment:4 foremtehan]:
 > Replying to [comment:2 teor]:
 >
 > >we'll know if we can find you what version you're using.
 >
 >
 > I installed tor through termux by "pkg install tor", I found the version
 (0.4.1.5):
 >
 > https://i.imgur.com/1IVlFNt.png

 Thanks!

 I've assigned this bug to nickm, because he wrote this code.

 > How to install last version of tor by "pkg"?

 I don't know which tor versions are available via pkg, check its package
 index?

 Let's see if nickm can diagnose the bug, and tell you if it is fixed.
 Then we will know which version to tell you to install.

 > > There's also a missing newline and tor version bug in the logs here,
 so raw_assert() also has some bugs. I'll open a child ticket.
 >
 > Is there anything I need to do؟

 No, we will take care of fixing logging, and make sure it gets into a tor
 release eventually.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31570 [Core Tor/Tor]: INTERNAL ERROR: raw assertion failed (core dump) in termux

[Tor Bug Tracker & Wiki]

#31570: INTERNAL ERROR: raw assertion failed (core dump) in termux
-+-
 Reporter:  foremtehan   |  Owner:  nickm
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  042-should, regression?, mmap,   |  Actual Points:
  android|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * priority:  Medium => High


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31576 [Core Tor/Tor]: Fix shellcheck errors in contrib/dist/rc.subr, and add to test-shellcheck

[Tor Bug Tracker & Wiki]

#31576: Fix shellcheck errors in contrib/dist/rc.subr, and add to 
test-shellcheck
--+--
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Minor |   Keywords:  shellcheck
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 This would be nice to have, but it's not urgent at all.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30665 [Applications/Tor Browser]: Get Firefox 68 ESR Working with latest android toolchain

[Tor Bug Tracker & Wiki]

#30665: Get Firefox 68 ESR Working with latest android toolchain
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff68-esr, tbb-9.0-must- |  Actual Points:
  nightly, TorBrowserTeam201908  |
Parent ID:  #30324   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-

Comment (by gk):

 Replying to [comment:12 gk]:
 > While skimming over the patch: please don't enable networking during
 build. What is the error you get?

 FWIW: I don't get any error when doing a
 {{{
 -  container:
 -# Some issues with gradle daemon running without network access.
 So enable for now.
 -disable_network:
 -  build: 0
 }}}
 on top of your patch. So, compiling still works fine for me without
 network access.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31010 [Applications/Tor Browser]: Rebase Tor Browser mobile/ patches for Firefox ESR 68

[Tor Bug Tracker & Wiki]

#31010: Rebase Tor Browser mobile/ patches for Firefox ESR 68
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-9.0-must-nightly,|  Actual Points:
  TorBrowserTeam201908R  |
Parent ID:  #30429   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by acat):

 acat30429+5_tor-browser_android_68esr_53 looks like it addresses the
 review comments (except the obsolete prefs, which were not reviewed yet
 according to sysrqb).

 Replying to [comment:18 sysrqb]:
 > Replying to [comment:14 sysrqb]:
 > > Replying to [comment:11 acat]:
 > > > Some comments on acat30429+5_tor-browser_android_68esr_39:
 >
 > > > 805a0b25be322d44138bae0d3a862070c9348fea
 > > > {{{
 > > >   +// Avoid throwing an error because Ci.nsIPushService
 isn't implemented
 > > >   +// All other clearing actions should succeed if we arrive
 here.
 > > >   +Promise.resolve();
 > > > }}}
 > > >   Promise.resolve(); is not really doing anything I think.
 > >
 > > I don't actually know. I'll try testing this without that line and see
 if it still works.
 > >
 >
 > It seems like you're correct, we don't need this. However, I don't know
 if we should keep this such that the code is more readable/easier to
 understand? Alternatively, I can delete the `resolve()` line and modify
 the comment.
 I'm not sure it's more readable, but that's subjective I guess :) I read
 is as a noop: it's a statement without side-effects and the value is not
 used nor returned.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30967 [Core Tor/Tor]: Make shellcheck ignore user-created directories, and run it during pre-commit (was: Explicitly select the top-level directories that we want to shellcheck)

[Tor Bug Tracker & Wiki]

#30967: Make shellcheck ignore user-created directories, and run it during pre-
commit
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Major| Resolution:
 Keywords:  fast-fix, teor-backlog-ci,   |  Actual Points:  0.2
  042-should, tor-ci-fail-sometimes  |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
 |  Sponsor31-can
-+-
Changes (by teor):

 * status:  assigned => needs_review
 * keywords:  fast-fix, teor-backlog-ci, 042-should => fast-fix, teor-
 backlog-ci, 042-should, tor-ci-fail-sometimes
 * actualpoints:   => 0.2


Comment:

 See my pull request:
 * master: https://github.com/torproject/tor/pull/1278

 I also added shellcheck to the pre-commit hook, because we've been failing
 CI with shellcheck errors.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28896 [Applications/Tor Browser]: Make sure our bundled WebExtensions are running in Private Browsing Mode

[Tor Bug Tracker & Wiki]

#28896: Make sure our bundled WebExtensions are running in Private Browsing Mode
+--
 Reporter:  gk  |  Owner:  tbb-team
 Type:  task| Status:
|  needs_information
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff68-esr TorBrowserTeam201908R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
|  Sponsor44-can
+--

Comment (by acat):

 Not completely sure about this one.

 What I had thought was: by default in Tor Browser we only have private
 windows, so it makes sense to always enable extensions. Otherwise from the
 user perspective it will be broken behaviour: they might install an
 extension and see no change (icons, etc.), then maybe file bugs.

 It may work as a protection against something that we don't support:
 installing extensions others than the shipped ones. But, at the end of the
 day, we do not forbid installing extensions either, so this change might
 be surprising for users.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31457 [Applications/Tor Browser]: disable per-installation profiles

[Tor Bug Tracker & Wiki]

#31457: disable per-installation profiles
+--
 Reporter:  mcs |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-nightly  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
|  Sponsor44-can
+--

Comment (by mcs):

 Replying to [comment:3 boklm]:
 > It seems the `MOZ_LEGACY_PROFILES` environment variable can be set to
 disable this feature. On Linux we could set it in the start script,
 however I'm not sure we can easily set environment variables on Windows
 and macOS, so maybe patching to disable it will be needed.

 Thanks. We may also be able to disable this by adding the following to our
 .mozconfig files (but I have not tried yet):
  ac_add_options "MOZ_DEDICATED_PROFILES="

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30429 [Applications/Tor Browser]: Rebase Tor Browser patches for Firefox ESR 68

[Tor Bug Tracker & Wiki]

#30429: Rebase Tor Browser patches for Firefox ESR 68
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-nightly,  |  Actual Points:
  TorBrowserTeam201908   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-

Comment (by cypherpunks):

 > Mozilla moved the app.update.auto setting to a new JSON file that is
 designed to be shared across all Firefox profiles. Firefox also stores
 some update-related data (on Windows only) in a system location and we do
 not want either of these things.
 No. We want either of these things. Because it's "the right thing" (part
 of sandboxing). But `CommonAppData` should point to e.g. `C:\Tor
 Browser\Browser\TorBrowser\Data\Browser\Mozilla` instead of
 `C:\ProgramData\Mozilla`.
 > Please let me know if we need to create a new ticket for these
 Yes, please.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31003 [Core Tor/Tor]: heap-use-after-free src/feature/nodelist/routerlist.c:704 in router_get_by_descriptor_digest

[Tor Bug Tracker & Wiki]

#31003: heap-use-after-free src/feature/nodelist/routerlist.c:704 in
router_get_by_descriptor_digest
-+-
 Reporter:  dgoulet  |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0415, tor-   |  Actual Points:  .1
  crash, tor-hs, 041-backport, 040-backport, |
  035-backport, 041-regression?  |
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+-

Comment (by teor):

 Merged to 0.3.5 and later.
 Merged #30894, #30871, and #31003 together.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30871 [Core Tor/Tor]: circuit_mark_for_close_(): Bug: Duplicate call to circuit_mark_for_close at ../src/feature/hs/hs_service.c:3166 (first at ../src/feature/hs/hs_service.c:2385)

[Tor Bug Tracker & Wiki]

#30871: circuit_mark_for_close_(): Bug: Duplicate call to 
circuit_mark_for_close at
../src/feature/hs/hs_service.c:3166 (first at
../src/feature/hs/hs_service.c:2385)
-+-
 Reporter:  s7r  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0415, tor-   |  Actual Points:  0.4
  hs double-mark 035-backport 040-backport   |
  041-backport   |
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
 |  Sponsor27
-+-

Comment (by teor):

 Merged to 0.3.5 and later.
 Merged #30894, #30871, and #31003 together.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0415,|  Actual Points:
  040-backport, tor-relay, circuitpadding, wtf-  |
  pad|
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-
Changes (by teor):

 * status:  merge_ready => needs_revision


Comment:

 I can't backport this branch, because:
 * the changes file has the wrong bugfix version:
   * please update the maint-0.4.0 PR with the changes file with the
 correct bugfix version 0.4.0.1-alpha
   * if you'd like, you can create a release-0.4.1 PR that fixes the wrong
 bug versions in the ChangeLog and ReleaseNotes
 * the PR doesn't merge cleanly into maint-0.4.1
   * please merge the maint-0.4.0 PR to maint-0.4.1, and make that merged
 branch into a separate PR on maint-0.4.1

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30894 [Core Tor/Tor]: Memory leak on invalid CSV_INTERVAL value

[Tor Bug Tracker & Wiki]

#30894: Memory leak on invalid CSV_INTERVAL value
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0415,|  Actual Points:  0.1
  035-backport 040-backport 041-backport |
Parent ID:   | Points:  0.1
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor31-can
-+-

Comment (by teor):

 Merged to 0.3.5 and later.
 Merged #30894, #30871, and #31003 together.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30967 [Core Tor/Tor]: Make shellcheck ignore user-created directories, and run it during pre-commit

[Tor Bug Tracker & Wiki]

#30967: Make shellcheck ignore user-created directories, and run it during pre-
commit
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Major| Resolution:
 Keywords:  fast-fix, teor-backlog-ci,   |  Actual Points:  0.2
  042-should, tor-ci-fail-sometimes  |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
 |  Sponsor31-can
-+-

Comment (by teor):

 This PR failed distcheck, I pushed a fix to the PR.

 Please check that CI passed before merging.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31567 [Applications/Tor Browser]: NS_tsnprintf() does not handle %s correctly on Windows

[Tor Bug Tracker & Wiki]

#31567: NS_tsnprintf() does not handle %s correctly on Windows
-+-
 Reporter:  mcs  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201908R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Here comes a 64bit testbuild and it's accompanied .mar file. mcs/brade: I
 know you don't have much time today but it would be helpful if you could
 give a short feedback whether that worked (assuming any of us has a hard
 time setting up the infrastructure for such a test today-ish):

 https://people.torproject.org/~gk/testbuilds/torbrowser-install-win64-tbb-
 nightly_en-US.exe
 https://people.torproject.org/~gk/testbuilds/torbrowser-install-win64-tbb-
 nightly_en-US.exe.asc

 https://people.torproject.org/~gk/testbuilds/tor-browser-win64-tbb-
 nightly_en-US.mar
 https://people.torproject.org/~gk/testbuilds/tor-browser-win64-tbb-
 nightly_en-US.mar.asc

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31577 [Core Tor/Tor]: make distcheck on macOS ignores --disable-asciidoc in its second configure invocation

[Tor Bug Tracker & Wiki]

#31577: make distcheck on macOS ignores --disable-asciidoc in its second 
configure
invocation
--+--
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal|   Keywords:  tor-dist, macos
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 I build tor on macos using:
 {{{
 git clone https://git.torproject.org/tor.git
 cd tor
 mkdir build-c
 ../configure --disable-asciidoc --with-libevent-dir=/usr/local --with-
 openssl-dir=/usr/local/opt/openssl --enable-lzma --enable-zstd --enable-
 libscrypt CC=clang --enable-gcc-warnings --enable-expensive-hardening
 make distcheck
 }}}

 Which fails with:
 {{{
 checking whether the compiler accepts @warning_flags... yes
 ==

 Building Tor has failed since manpages cannot be built.

 You need asciidoc installed to be able to build the manpages.
 To build without manpages, use the --disable-asciidoc argument
 when calling configure.

 ==
 make: *** [distcheck] Error 1
 Exit 2
 }}}

 What am I doing wrong?
 Does "make distcheck" support a build directory inside tor/ ?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31578 [Core Tor/Tor]: practracker scans build directories inside the tor/ directory

[Tor Bug Tracker & Wiki]

#31578: practracker scans build directories inside the tor/ directory
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core |Version:  Tor: unspecified
  Tor/Tor|   Keywords:  practracker, regression?,
 Severity:  Normal   |  042-should
Actual Points:   |  Parent ID:  #31577
   Points:   |   Reviewer:
  Sponsor:   |
  Sponsor31-can  |
-+-
 When I run practracker after the failed "make distcheck" in #31577, I get
 these errors:

 {{{
 problem function-size /build-c/tor-0.4.2.0-alpha-
 dev/src/trunnel/socks5.c:socks4_client_request_encode() 352
 problem function-size /build-c/tor-0.4.2.0-alpha-
 dev/src/trunnel/socks5.c:socks4_client_request_parse_into() 332
 problem function-size /build-c/tor-0.4.2.0-alpha-
 dev/src/trunnel/socks5.c:socks5_client_request_encode() 113
 problem function-size /build-c/tor-0.4.2.0-alpha-
 dev/src/trunnel/socks5.c:socks5_server_reply_encode() 113
 problem file-size /build-c/tor-0.4.2.0-alpha-dev/src/trunnel/socks5.h 995
 problem function-size /build-c/tor-0.4.2.0-alpha-
 dev/src/trunnel/hs/cell_introduce1.c:trn_cell_introduce_encrypted_encode()
 110
 (warning) problem file-size /src/core/or/circuitpadding.c 3096
 (warning) problem function-size
 /src/core/or/circuitpadding.c:circpad_machine_schedule_padding() 113
 (warning) problem file-size /src/core/or/circuitpadding.h 813
 (warning) problem file-size /src/core/or/relay.c 3264
 (warning) problem file-size /src/feature/hs/hs_service.c 4125
 (warning) problem file-size /src/feature/nodelist/routerlist.c 3241
 (warning) problem function-size
 /src/feature/rend/rendmid.c:rend_mid_establish_intro_legacy() 105
 (warning) problem file-size /src/feature/rend/rendservice.c 4522
 (warning) problem function-size
 /src/feature/rend/rendservice.c:rend_service_receive_introduction() 334
 FAILURE: practracker found 482 new problem(s) in the code: see warnings
 above.

 Please fix the problems if you can, and update the exceptions file
 (../scripts/maint/practracker/./exceptions.txt) if you can't.

 See doc/HACKING/HelpfulTools.md for more information on using practracker.
 You can disable this message by setting the TOR_DISABLE_PRACTRACKER
 environment
 variable.

 make[1]: *** [check-best-practices] Error 226
 make[1]: *** Waiting for unfinished jobs
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28942 [Circumvention/Snowflake]: Evaluate pion WebRTC

[Tor Bug Tracker & Wiki]

#28942: Evaluate pion WebRTC
+--
 Reporter:  backkem |  Owner:  cohosh
 Type:  enhancement | Status:  accepted
 Priority:  Medium  |  Milestone:
Component:  Circumvention/Snowflake |Version:
 Severity:  Normal  | Resolution:
 Keywords:  anti-censorship-roadmap-august  |  Actual Points:
Parent ID:  | Points:  5
 Reviewer:  |Sponsor:
|  Sponsor28-must
+--
Changes (by cohosh):

 * Attachment "vendor.zip" added.

 A working directory of pion/webrtc dependencies

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28942 [Circumvention/Snowflake]: Evaluate pion WebRTC

[Tor Bug Tracker & Wiki]

#28942: Evaluate pion WebRTC
+--
 Reporter:  backkem |  Owner:  cohosh
 Type:  enhancement | Status:  accepted
 Priority:  Medium  |  Milestone:
Component:  Circumvention/Snowflake |Version:
 Severity:  Normal  | Resolution:
 Keywords:  anti-censorship-roadmap-august  |  Actual Points:
Parent ID:  | Points:  5
 Reviewer:  |Sponsor:
|  Sponsor28-must
+--

Comment (by cohosh):

 Replying to [comment:44 cohosh]:
 > Replying to [comment:43 dcf]:
 > > Everything builds, and from the command line I can run `snowflake-
 client -h` and see that it produces output, but unfortunately it doesn't
 bootstrap for me. But then again, neither does
 
[https://github.com/cohosh/snowflake/commit/3cc240625cad22db02eca7af41b139606c13147d
 3cc240625c] from cohosh's pion branch from comment:28. So whatever is
 going wrong for me, is possibly not related to the rbm build.
 > >
 > > This is what I see in the snowflake-client log. After this, there's no
 more output for at least several minutes (that's as long as I waited).
 >
 > Noting that I can reproduce this issue seemingly 100% of the time, I'll
 investigate whether it's due to recent changes to any of the pion
 libraries, since bootstrapping used to work

 Update on this: I tried building with pion/webrtc v2.0.23 (using pion/sctp
 v1.6.4 and otherwise sticking to the versions specified in `go.mod` for
 webrtc v2.0.23) and it bootstraps fully.

 There must have been breaking changes to the pion webrtc library added
 since. I can investigate them but I suggest for now that we use the pion
 dependencies we know work.

 > Replying to [comment:43 dcf]:
 >
 > Overall, my impression so far is that this is not the way we want to
 continue doing things. The problem I foresee is maintenance across
 upgrades: the pion-webrtc module upgrades ones of its dependencies, which
 causes a cascade of updated version requirements down the dependency tree.
 boklm's suggestion from comment:42 would prevent a proliferation of rbm
 projects, but we'll still want something to semi-automatically handle
 upgrades for us. We could of course use go itself--but that's a discussion
 for #28325.
 I think the easiest way to go forward here is to take boklm's suggestion
 in https://trac.torproject.org/projects/tor/ticket/28325#comment:5 and
 just package up the directory supplied by `go mod vendor`. I've attached a
 zip file of working dependencies in `vendor.zip` above.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27284 [Core Tor/Tor]: Check IPv6 exit policies on microdescs

[Tor Bug Tracker & Wiki]

#27284: Check IPv6 exit policies on microdescs
-+-
 Reporter:  teor |  Owner:  neel
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:
  029-backport, 035-backport, 040-backport,  |
  041-backport, 042-backport, ipv6,  |
  040-deferred-20190220, teor-   |
  unreached-2019-03-08   |
Parent ID:  #27248   | Points:
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => merge_ready


Comment:

 That change LGTM.  Before we merge, let's decide if it's a backport
 candidate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28549 [Webpages/Support]: Add missing FAQ questions to support.tpo

[Tor Bug Tracker & Wiki]

#28549: Add missing FAQ questions to support.tpo
-+--
 Reporter:  traumschule  |  Owner:  (none)
 Type:  task | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  Webpages/Support |Version:
 Severity:  Normal   | Resolution:
 Keywords:  faq, dockshackathon  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by emmapeel):

 * keywords:  faq => faq, dockshackathon


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31578 [Core Tor/Tor]: practracker scans build directories inside the tor/ directory

[Tor Bug Tracker & Wiki]

#31578: practracker scans build directories inside the tor/ directory
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  practracker, regression?,|  Actual Points:
  042-should |
Parent ID:  #31577   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor31-can
-+-

Comment (by nickm):

 I can fix this unless somebody else wants to.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28549 [Webpages/Support]: Add missing FAQ questions to support.tpo

[Tor Bug Tracker & Wiki]

#28549: Add missing FAQ questions to support.tpo
+--
 Reporter:  traumschule |  Owner:  (none)
 Type:  task| Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  Webpages/Support|Version:
 Severity:  Normal  | Resolution:
 Keywords:  faq, docshackathon  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by emmapeel):

 * keywords:  faq, dockshackathon => faq, docshackathon


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31577 [Core Tor/Tor]: make distcheck on macOS ignores --disable-asciidoc in its second configure invocation

[Tor Bug Tracker & Wiki]

#31577: make distcheck on macOS ignores --disable-asciidoc in its second 
configure
invocation
-+--
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:  Tor: unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tor-dist, macos  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by nickm):

 By default, make distcheck does not carry any configure flags forward.
 You can override this with `DISTCHECK_CONFIGURE_FLAGS` (see
 https://www.gnu.org/software/automake/manual/html_node/Checking-the-
 Distribution.html for more).

 So for example, instead of `make distcheck`, you would say: `make
 distcheck DISTCHECK_CONFIGURE_FLAGS="--disable-asciidoc ..."`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0415,|  Actual Points:
  040-backport, tor-relay, circuitpadding, wtf-  |
  pad|
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-

Comment (by nickm):

 Mike is pretty hosed; I can pick this up unless somebody else wants to.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31449 [Applications/Tor Browser]: Signing tools for 32bit Linux are 64bit now

[Tor Bug Tracker & Wiki]

#31449: Signing tools for 32bit Linux are 64bit now
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201908,   |  Actual Points:
  tbb-9.0-must-alpha |
Parent ID:  #30321   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:4 gk]:
 >
 > Fair enough. I was under the impression that the current state risks our
 `mar` signing AND that we do something wrong with our 32bit builds given
 that the issue did not happen in the past and we already seem to need some
 hacks to get 32bit builds going. If neither is the case, great! We could
 closed this ticket then as WORKSFORME or something similar.

 I think that we did not have this issue in the past because our
 `.mozconfig-linux-i686` file included the line `ac_add_options --host=i686
 -linux-gnu` which caused host tools to be built in 32bit. Although that
 was not really correct as the host was in reality 64bit, but it still
 worked as we can run 32bit binaries on a 64bit host.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31571 [Core Tor/Tor]: Add the tor version and a newline to raw_assert()

[Tor Bug Tracker & Wiki]

#31571: Add the tor version and a newline to raw_assert()
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, 042-should, android,|  Actual Points:  0.1
  macos, 035-backport, 040-backport, |
  041-backport   |
Parent ID:  #31570   | Points:  0.1
 Reviewer:  nickm|Sponsor:
 |  Sponsor31-can
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision
 * reviewer:   => nickm


Comment:

 Hi!  This looks like a solid set of changes to some tricky code.  I've
 left one suggestion and one question on the PR.

 CI appears to be passing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31567 [Applications/Tor Browser]: NS_tsnprintf() does not handle %s correctly on Windows

[Tor Bug Tracker & Wiki]

#31567: NS_tsnprintf() does not handle %s correctly on Windows
-+-
 Reporter:  mcs  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201908R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 Replying to [comment:7 gk]:
 > Here comes a 64bit testbuild and it's accompanied .mar file. mcs/brade:
 I know you don't have much time today but it would be helpful if you could
 give a short feedback whether that worked (assuming any of us has a hard
 time setting up the infrastructure for such a test today-ish):
 > ...

 Thanks for the builds, and Richard thank you *so* much for hacking on this
 last night. Unfortunately, the problem is not fixed and I think the same
 error is occurring (Unicode strings are being interpreted as C/ANSI
 strings). I do not know why, but maybe our cypherpunks are on the right
 track in that this may be a general problem with how updater.exe gets
 built.

 I will attach a Windows cmd file that can be used to run the updater
 "manually" to reproduce the problem. After you run the updater via the cmd
 file, look under `...\Browser\TorBrowser\UpdateInfo\updates\0` for newly
 created files. When the updater fails due to this bug, you will see status
 and log files there that are named sta and log. The GUID
 suffix is there because the rename (`MoveFileExW()` call) fails as I
 described in the bug description. The contents of the log file will be
 `failed setting status to 'applying'`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31567 [Applications/Tor Browser]: NS_tsnprintf() does not handle %s correctly on Windows

[Tor Bug Tracker & Wiki]

#31567: NS_tsnprintf() does not handle %s correctly on Windows
-+-
 Reporter:  mcs  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201908R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * Attachment "updater-test.cmd" added.

 Windows cmd file for running the updater

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30429 [Applications/Tor Browser]: Rebase Tor Browser patches for Firefox ESR 68

[Tor Bug Tracker & Wiki]

#30429: Rebase Tor Browser patches for Firefox ESR 68
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-nightly,  |  Actual Points:
  TorBrowserTeam201908   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-

Comment (by mcs):

 Replying to [comment:51 cypherpunks]:
 > No. We want either of these things. Because it's "the right thing" (part
 of sandboxing). But `CommonAppData` should point to e.g. `C:\Tor
 Browser\Browser\TorBrowser\Data\Browser\Mozilla` instead of
 `C:\ProgramData\Mozilla`.

 Maybe, but we do not have time to patch or test such a scheme right now. I
 think we are better off without the complexity that this adds for
 developers and users of Tor Browser.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31567 [Applications/Tor Browser]: NS_tsnprintf() does not handle %s correctly on Windows

[Tor Bug Tracker & Wiki]

#31567: NS_tsnprintf() does not handle %s correctly on Windows
-+-
 Reporter:  mcs  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201908R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 FWIW: I did not do `#define STRSAFE_NO_DEPRECATE` before the `strsafe.h`
 as I saw the edit after I started my build. Might be a first thing to
 test.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31538 [Applications/Tor Browser]: Windows bundles based on ESR 68 are not built reproducibly

[Tor Bug Tracker & Wiki]

#31538: Windows bundles based on ESR 68 are not built reproducibly
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-rbm, ff68-esr, tbb-9.0-must- |  Actual Points:
  nightly, TorBrowserTeam201908, |
  GeorgKoppen201908  |
Parent ID:  #30322   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 After building the current nightly for windows x86_64 twice on the same
 machine, I am getting the same bundles. Is it an issue that mostly happen
 when building on different machines?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31538 [Applications/Tor Browser]: Windows bundles based on ESR 68 are not built reproducibly

[Tor Bug Tracker & Wiki]

#31538: Windows bundles based on ESR 68 are not built reproducibly
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-rbm, ff68-esr, tbb-9.0-must- |  Actual Points:
  nightly, TorBrowserTeam201908, |
  GeorgKoppen201908  |
Parent ID:  #30322   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:3 boklm]:
 > After building the current nightly for windows x86_64 twice on the same
 machine, I am getting the same bundles. Is it an issue that mostly happen
 when building on different machines?

 Yeah, that's part of the mystery: it only happens on different machines it
 seems.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31567 [Applications/Tor Browser]: NS_tsnprintf() does not handle %s correctly on Windows

[Tor Bug Tracker & Wiki]

#31567: NS_tsnprintf() does not handle %s correctly on Windows
-+-
 Reporter:  mcs  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201908R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 As for `__USE_MINGW_ANSI_STDIO`, now when ucrt is used, mingw-w64 should
 definitely be patched with
 {{{
 -# define __USE_MINGW_ANSI_STDIO 1
 +# define __USE_MINGW_ANSI_STDIO 0
 }}}
 in its ugly defaults:
 
https://github.com/mingw-w64/mingw-w64/blob/f8e2c9ac594259fd2a46746943f84bd8766d7054/mingw-w64-headers/crt/_mingw.h.in#L428

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31538 [Applications/Tor Browser]: Windows bundles based on ESR 68 are not built reproducibly

[Tor Bug Tracker & Wiki]

#31538: Windows bundles based on ESR 68 are not built reproducibly
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-rbm, ff68-esr, tbb-9.0-must- |  Actual Points:
  nightly, TorBrowserTeam201908, |
  GeorgKoppen201908  |
Parent ID:  #30322   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 "The builds from the same machine were identical, but different on the
 second machine." boklm said last time it happened...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31010 [Applications/Tor Browser]: Rebase Tor Browser mobile/ patches for Firefox ESR 68

[Tor Bug Tracker & Wiki]

#31010: Rebase Tor Browser mobile/ patches for Firefox ESR 68
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-9.0-must-nightly,|  Actual Points:
  TorBrowserTeam201908R  |
Parent ID:  #30429   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sysrqb):

 Okay, great! I rebased the commits (except the last one) on top of `tor-
 browser-68.1.0esr-9.0-1` (`adb1614b652a5be21e7f025d15a8ea48401eeb02`). You
 can reproduce this with: `git cherry-pick acat/30429+5..acat30429+5_tor-
 browser_android_68esr_54~` (where `acat/30429+5` is
 `677a3a505f714a9379735a189a43349c4097231a`).

 In any case, after cherry-picking all of the commits, I made a few
 modifications - including deleting the `Promise.resolve()`, as it was
 previously mentioned :)

 I have branch `bug31010_4`. There is an additional change needed in
 torbutton because `addTrustedTab` is not defined, so we need to revert the
 recent change that introduced this for mobile.

 {{{
 diff --git a/chrome/content/torbutton.js b/chrome/content/torbutton.js
 index 756c2c7c..c97913bc 100644
 --- a/chrome/content/torbutton.js
 +++ b/chrome/content/torbutton.js
 @@ -1861,9 +1861,10 @@ function showSecurityPreferencesPanel(chromeWindow)
 {

if (settingsTab === null) {
// Open up the settings panel in a new tab.
 -  tabBrowser.addTrustedTab(SECURITY_PREFERENCES_URI, {
 +  tabBrowser.addTab(SECURITY_PREFERENCES_URI, {
"selected": true,
"parentId": tabBrowser.selectedTab.id,
 +  triggeringPrincipal:
 Services.scriptSecurityManager.getSystemPrincipal(),
});
} else {
// Activate an existing settings panel tab.
 }}}

 I pushed this to:
 https://github.com/sysrqb/torbutton.git
 branch `bug31010_00`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31564 [Applications/Tor Browser]: Android bundles based on ESR 68 are not built reproducibly anymore

[Tor Bug Tracker & Wiki]

#31564: Android bundles based on ESR 68 are not built reproducibly anymore
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-9.0-must-nightly,|  Actual Points:
  TorBrowserTeam201908, GeorgKoppen201908|
Parent ID:  #30324   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Replying to [comment:3 gk]:
 > Hm. Did they say when it got introduced? Is our reproducible builds
 setup broken that we did not detect that problem during the esr60 cycle?
 Or is that really a thing that got introduced with the new toolchain we
 use.
 >
 > That said, sisbell, what are our options here? Can we just use a newer
 gradle plugin which has this fixed? Or do we need to build that one
 ourselves and use it then or...?

 In the google issuetracker. one person mentioned that they got around the
 issue by using aapt2 directly with the correct order in the linker. I
 think this is worth investigating since it could potentially be scripted
 without requiring a patch. My only concern is that Firefox has a
 customized build so it may not be extendible to this approach. It requires
 looking into.

 https://developer.android.com/studio/command-line/aapt2


 {{{
  aapt2 link -o output.apk
  -I android_sdk/platforms/android_version/android.jar
 compiled/res/values_values.arsc.flat
 compiled/res/drawable_Image.flat --manifest
 /path/to/AndroidManifest.xml -v
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31567 [Applications/Tor Browser]: NS_tsnprintf() does not handle %s correctly on Windows

[Tor Bug Tracker & Wiki]

#31567: NS_tsnprintf() does not handle %s correctly on Windows
-+-
 Reporter:  mcs  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201908R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by pospeselr):

 mcs: we need to update NS_tvsnprintf's usage of _vsnwprintf as well. Will
 post a patch shortly.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31567 [Applications/Tor Browser]: NS_tsnprintf() does not handle %s correctly on Windows

[Tor Bug Tracker & Wiki]

#31567: NS_tsnprintf() does not handle %s correctly on Windows
-+-
 Reporter:  mcs  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201908R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 I think it is also worth noting that ESR60 included this same code, more
 or less. That points to a toolchain change as the root cause.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28896 [Applications/Tor Browser]: Make sure our bundled WebExtensions are running in Private Browsing Mode

[Tor Bug Tracker & Wiki]

#28896: Make sure our bundled WebExtensions are running in Private Browsing Mode
+--
 Reporter:  gk  |  Owner:  tbb-team
 Type:  task| Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  ff68-esr TorBrowserTeam201908R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
|  Sponsor44-can
+--
Changes (by gk):

 * status:  needs_information => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:7 acat]:
 > Not completely sure about this one.
 >
 > What I had thought was: by default in Tor Browser we only have private
 windows, so it makes sense to always enable extensions. Otherwise from the
 user perspective it will be broken behaviour: they might install an
 extension and see no change (icons, etc.), then maybe file bugs.
 >
 > It may work as a protection against something that we don't support:
 installing extensions others than the shipped ones. But, at the end of the
 day, we do not forbid installing extensions either, so this change might
 be surprising for users.

 Okay, that's not unreasonable. After all the users might not know (and
 should not need to know) that they are in a special mode. They just want
 to have a working browser and installing extensions is surely working
 without issues in a vanilla Firefox, right? Let's take your patch then. We
 can revisit that decision later on if needed. Cherry-picked onto `tor-
 browser-68.1.0esr-9.0-1` (commit
 8aabfb8128a8125a00d0a36d41518379258e0b38).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31555 [Applications/Tor Browser]: Don't show the private browsing mode related extensions warning

[Tor Bug Tracker & Wiki]

#31555: Don't show the private browsing mode related extensions warning
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  wontfix
 Keywords:  TorBrowserTeam201908R,   |  Actual Points:
  GeorgKoppen201908, tbb-9.0-must-alpha  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => wontfix


Comment:

 We went with the fix for #28896.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31567 [Applications/Tor Browser]: NS_tsnprintf() does not handle %s correctly on Windows

[Tor Bug Tracker & Wiki]

#31567: NS_tsnprintf() does not handle %s correctly on Windows
-+-
 Reporter:  mcs  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201908   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201908R =>
 ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201908
 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31568 [Applications/Tor Browser]: Update How to Create Gradle Dependencies

[Tor Bug Tracker & Wiki]

#31568: Update How to Create Gradle Dependencies
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff68-esr, tbb-9.0-must- |  Actual Points:
  nightly, TorBrowserTeam201908R |
Parent ID:  #30324   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => needs_revision


Comment:

 Okay. That does not work for me at least not for `tor-android-service` and
 `topl` my lists are a) way longer (attached is the one for topl) and b)
 the patch does not help me creating it. First of all specifying the
 `--offline` flag just breaks for me. Are you sure the things needed get
 downloaded if you specify that flag? Seems a bit counter-intuitive to me.
 What works, though, is replacing `--offline` with `--debug` and removing
 `-Dmaven.repo.local=$gradle_repo`. Still I don't get your lists in #30460
 and #30461.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31568 [Applications/Tor Browser]: Update How to Create Gradle Dependencies

[Tor Bug Tracker & Wiki]

#31568: Update How to Create Gradle Dependencies
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff68-esr, tbb-9.0-must- |  Actual Points:
  nightly, TorBrowserTeam201908R |
Parent ID:  #30324   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * Attachment "list.txt" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31568 [Applications/Tor Browser]: Update How to Create Gradle Dependencies

[Tor Bug Tracker & Wiki]

#31568: Update How to Create Gradle Dependencies
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff68-esr, tbb-9.0-must- |  Actual Points:
  nightly, TorBrowserTeam201908  |
Parent ID:  #30324   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm, ff68-esr, tbb-9.0-must-nightly, TorBrowserTeam201908R
 => tbb-rbm, ff68-esr, tbb-9.0-must-nightly, TorBrowserTeam201908


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30461 [Applications/Tor Browser]: Update tor-android-service Project to Use Android Toolchain (Firefox 68)

[Tor Bug Tracker & Wiki]

#30461: Update tor-android-service Project to Use Android Toolchain (Firefox 68)
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff68-esr, tbb-9.0-must- |  Actual Points:
  nightly, TorBrowserTeam201908  |
Parent ID:  #30324   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-
Changes (by gk):

 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30460 [Applications/Tor Browser]: Update TOPL Project to Use Android Toolchain (Firefox 68)

[Tor Bug Tracker & Wiki]

#30460: Update TOPL Project to Use Android Toolchain (Firefox 68)
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff68-esr, tbb-9.0-must- |  Actual Points:
  nightly, TorBrowserTeam201908R |
Parent ID:  #30324   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-

Comment (by gk):

 Looks mostly good. I still need to verify the dependencies list which is
 blocked by #31568.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30461 [Applications/Tor Browser]: Update tor-android-service Project to Use Android Toolchain (Firefox 68)

[Tor Bug Tracker & Wiki]

#30461: Update tor-android-service Project to Use Android Toolchain (Firefox 68)
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff68-esr, tbb-9.0-must- |  Actual Points:
  nightly, TorBrowserTeam201908  |
Parent ID:  #30324   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-

Comment (by sisbell):

 Replying to [comment:13 gk]:
 > Replying to [comment:12 sisbell]:
 > > I need to get review and merge of tor-android-service. Branch 0801a
 contain all the latest changes from orbot to tor-android-service. There
 are a lot of changes here since I've been keeping up with the work going
 into Orbot.
 > >
 > > https://github.com/sisbell/tor-android-service/commits/0801a
 > >
 > > Revision 5c9583cf8e2b7002f71c2971aae7ebb44c067b42 on July 17th is the
 minimum I think we can use, so that would cut down a lot of review time.
 The changes after are not so critical for us.
 >
 > Okay. I can see how that particular commit is relevant for us but I am
 not so sure about the previous ones. What about we pick just that one for
 now to unblock our nightly and alpha builds and think about the other ones
 later on?
 >
 > > How do we want to do this?
 >
 > We can discuss this in one of our team meetings but here is how I think
 we should do it: we treat tor-android-service as any of our other project.
 That means proposed changes need a ticket on our bug tracker (right now
 this is Trac but it might become Gitlab or $foo). Then someone needs to
 write a patch, point to a branch (be that one on our own infrastructure,
 or Github, Gitlab or...) and find someone to review and merge the changes.
 >
 > The patch should a) be based on our master branch as we own the
 canonical repo now and b) it should be written in a way that we don't have
 to suddenly apply patches to any of our other projects. E.g. it's nice to
 redo the VPN support part but the resulting patch should be written in a
 way that we not have to suddenly apply `tor-browser-build` patches to rip
 things out there. More precisely, it would be written in a way that
 projects can make use of VPN support but others can safely ignore that
 part to reduce attack surface etc. by setting a compile time option to
 just not compile that part in in the first place.
 >
 > Does that make sense? If so, please file new tickets for the changes we
 should make in `tor-android-service`, point to the patches (please base
 them on our `master` branch to make merging easier) and set the tickets
 into `needs_review`.

 I think this makes sense but I don't think we would have time before first
 alpha. What we can do is just use latest tor-android-service from tor repo
 and I'll modify firefox to use it. It will also require regenerating the
 dependencies.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31579 [Core Tor/Tor]: Space out the arguments of cell functions in rend_process_relay_cell()

[Tor Bug Tracker & Wiki]

#31579: Space out the arguments of cell functions in rend_process_relay_cell()
--+--
 Reporter:  neel  |  Owner:  neel
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  easy
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 In the `switch (command) {` statement in `rend_process_relay_cell()`,
 arguments to the functions corresponding to cells aren't spaced, like:

 {{{
 r = hs_intro_received_establish_intro(or_circ,payload,length);
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31579 [Core Tor/Tor]: Space out the arguments to the cell functions in rend_process_relay_cell() (was: Space out the arguments of cell functions in rend_process_relay_cell())

[Tor Bug Tracker & Wiki]

#31579: Space out the arguments to the cell functions in 
rend_process_relay_cell()
--+--
 Reporter:  neel  |  Owner:  neel
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by neel):

 * status:  assigned => needs_review


Comment:

 PR here: https://github.com/torproject/tor/pull/1279

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27284 [Core Tor/Tor]: Check IPv6 exit policies on microdescs

[Tor Bug Tracker & Wiki]

#27284: Check IPv6 exit policies on microdescs
-+-
 Reporter:  teor |  Owner:  neel
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:
  029-backport, 035-backport, 040-backport,  |
  041-backport, 042-backport, ipv6,  |
  040-deferred-20190220, teor-   |
  unreached-2019-03-08   |
Parent ID:  #27248   | Points:
 Reviewer:  nickm|Sponsor:
-+-

Comment (by teor):

 I think this is "no backport".
 Here's why:

 Before this fix, exits that reject IPv4 but accept IPv6 are marked as
 "rejects all".
 After this fix, exits that reject IPv4 but accept IPv6 are marked as
 "accepts some".

 These exits are rare, so the change is not worth backporting.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31577 [Core Tor/Tor]: make distcheck on macOS ignores --disable-asciidoc in its second configure invocation

[Tor Bug Tracker & Wiki]

#31577: make distcheck on macOS ignores --disable-asciidoc in its second 
configure
invocation
-+--
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:  Tor: unspecified
 Severity:  Normal   | Resolution:  not a bug
 Keywords:  tor-dist, macos  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by teor):

 * status:  new => closed
 * resolution:   => not a bug


Comment:

 Oh wow ok. That makes sense.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31578 [Core Tor/Tor]: practracker scans build directories inside the tor/ directory

[Tor Bug Tracker & Wiki]

#31578: practracker scans build directories inside the tor/ directory
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  practracker, regression?,|  Actual Points:
  042-should |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor31-can
-+-
Changes (by teor):

 * parent:  #31577 =>


Comment:

 Go for it :-)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0415,|  Actual Points:
  040-backport, tor-relay, circuitpadding, wtf-  |
  pad|
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-

Comment (by teor):

 I think it might just need an "ours" merge, because the corresponding
 change was already merged to 0.4.1, before being backported.

 But I'm really not sure.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27284 [Core Tor/Tor]: Check IPv6 exit policies on microdescs

[Tor Bug Tracker & Wiki]

#27284: Check IPv6 exit policies on microdescs
-+-
 Reporter:  teor |  Owner:  neel
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:
  029-backport, 035-backport, 040-backport,  |
  041-backport, 042-backport, ipv6,  |
  040-deferred-20190220, teor-   |
  unreached-2019-03-08, asn-merge|
Parent ID:  #27248   | Points:
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * keywords:
 consider-backport-after-042-stable, 029-backport, 035-backport,
 040-backport, 041-backport, 042-backport, ipv6, 040-deferred-20190220,
 teor-unreached-2019-03-08
 =>
 consider-backport-after-042-stable, 029-backport, 035-backport,
 040-backport, 041-backport, 042-backport, ipv6, 040-deferred-20190220,
 teor-unreached-2019-03-08, asn-merge


Comment:

 Thanks for the info! Your reasoning makes sense to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31578 [Core Tor/Tor]: practracker scans build directories inside the tor/ directory

[Tor Bug Tracker & Wiki]

#31578: practracker scans build directories inside the tor/ directory
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  practracker, regression?,|  Actual Points:
  042-should |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor31-can
-+-
Changes (by nickm):

 * owner:  (none) => nickm
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27284 [Core Tor/Tor]: Check IPv6 exit policies on microdescs

[Tor Bug Tracker & Wiki]

#27284: Check IPv6 exit policies on microdescs
-+-
 Reporter:  teor |  Owner:  neel
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  no-backport, ipv6,   |  Actual Points:
  040-deferred-20190220, teor-   |
  unreached-2019-03-08, asn-merge|
Parent ID:  #27248   | Points:
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * keywords:
 consider-backport-after-042-stable, 029-backport, 035-backport,
 040-backport, 041-backport, 042-backport, ipv6, 040-deferred-20190220,
 teor-unreached-2019-03-08, asn-merge
 =>
 no-backport, ipv6, 040-deferred-20190220, teor-unreached-2019-03-08,
 asn-merge


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30466 [Core Tor/Tor]: hs: Do not allow more than one control cell on a circuit

[Tor Bug Tracker & Wiki]

#30466: hs: Do not allow more than one control cell on a circuit
+--
 Reporter:  dgoulet |  Owner:  neel
 Type:  defect  | Status:
|  needs_information
 Priority:  Medium  |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-dos, tor-hs, tor-relay  |  Actual Points:
Parent ID:  | Points:  0.1
 Reviewer:  dgoulet |Sponsor:  Sponsor27-can
+--

Comment (by neel):

 I have a PR with the same code sans the ESTABLISH_INTRO part:
 https://github.com/torproject/tor/pull/1280

 I am not setting this as needs review as I don't know if you need this or
 not (because of #30924). If you do, feel free to set it as needs_review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31555 [Applications/Tor Browser]: Don't show the private browsing mode related extensions warning

[Tor Bug Tracker & Wiki]

#31555: Don't show the private browsing mode related extensions warning
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  wontfix
 Keywords:  TorBrowserTeam201908R,   |  Actual Points:
  GeorgKoppen201908, tbb-9.0-must-alpha  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 It would be better, if you went with the new PBM improvements and didn't
 touch anything without users' feedback.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31580 [Applications/Tor Browser]: Disabling Torbutton resets NoScript to its default state

[Tor Bug Tracker & Wiki]

#31580: Disabling Torbutton resets NoScript to its default state
-+--
 Reporter:  cypherpunks  |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Component:  Applications/Tor Browser
  Version:   |   Severity:  Normal
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
 When the Torbutton extension gets disabled, NoScript gets reset to its
 default state and all default domains are whitelisted and it blocks
 JavaScript on lower security levels.

 Some people need to disable the Torbutton extension to be able to use a
 different proxy with Tor.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31581 [Core Tor/Tor]: KDE Desktop file error

[Tor Bug Tracker & Wiki]

#31581: KDE Desktop file error
--+--
 Reporter:  Psnarf|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Very Low  |  Component:  Core Tor/Tor
  Version:  Tor: unspecified  |   Severity:  Trivial
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
 The freedesktop spec for .desktop files requires the '\' char be escaped.
 In your desktop file, the Exec= command contains a continuation char with
 the rest of the command on the next line. Kwinini flags that as an error,
 no '='.

 To fix, replace the end of the Exec command with "\\" which escapes the
 bash continuation char.

 Tor v8.5.4

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31581 [Core Tor/Tor]: KDE Desktop file error

[Tor Bug Tracker & Wiki]

#31581: KDE Desktop file error
--+--
 Reporter:  Psnarf|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Very Low  |  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Trivial   | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by Psnarf):

 To fix, replace the end of the Exec command with '\\' which escapes the
 bash continuation char.

 [I had no idea using a double-quote followed by two backslash chars and a
 closing double-quote would be interpreted by the wacky wiki to make the
 double backslash vanish.]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31581 [Core Tor/Tor]: KDE Desktop file error

[Tor Bug Tracker & Wiki]

#31581: KDE Desktop file error
--+--
 Reporter:  Psnarf|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Very Low  |  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Trivial   | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by Psnarf):

 Let me try that again.
 {{{
  Replace the single backslash at the end of the Exec= line with a double
 backslash,\\
  thus escaping the backslash to comply with freedesktop specs.  / --> //
 Aha! a double backslash is interpreted herein as a newline. Go figure!
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24351 [Applications/Tor Browser]: Block Global Active Adversary Cloudflare

[Tor Bug Tracker & Wiki]

#24351: Block Global Active Adversary Cloudflare
-+-
 Reporter:  nullius  |  Owner:
 |  cypherpunks
 Type:  enhancement  | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  security, privacy, anonymity, mitm,  |  Actual Points:
  cloudflare |
Parent ID:  #18361   | Points:  1000
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 It's back

 # https://codeberg.org/crimeflare/cloudflare-tor

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18361 [Applications/Tor Browser]: Issues with corporate censorship and mass surveillance

[Tor Bug Tracker & Wiki]

#18361: Issues with corporate censorship and mass surveillance
--+--
 Reporter:  ioerror   |  Owner:  cypherpunks
 Type:  defect| Status:  assigned
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Critical  | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  1000 light years
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 It's back

 https://codeberg.org/crimeflare/cloudflare-tor

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31567 [Applications/Tor Browser]: NS_tsnprintf() does not handle %s correctly on Windows

[Tor Bug Tracker & Wiki]

#31567: NS_tsnprintf() does not handle %s correctly on Windows
-+-
 Reporter:  mcs  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201908   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by pospeselr):

 Ok, so the reason why the above patch does not work with the clang build
 is that {{{StringCchVPrintfExW}}} which was meant to replace
 {{{_vsnwprintf}}} ultimately calls {{{_vsnwprintf}}} itself. This call
 ulimately goes down to {{{ucrtbase!__stdio_common_vswprintf}}} with the
 {{{UCRTBASE_PRINTF_LEGACY_VSPRINTF_NULL_TERMINATION}}} (0x1) flag.
 Switching this flag to {{{UCRTBASE_PRINTF_LEGACY_WIDE_SPECIFIERS}}} (0x4)
 results in the behaviour that we want.

 Patching the binary at runtime in windbg and letting it run results in
 these files:

 update.log:

 {{{
 PATCH DIRECTORY
 C:\Users\user\Desktop\GKTest\Browser\TorBrowser\UpdateInfo\updates\0
 INSTALLATION DIRECTORY C:\Users\user\Desktop\GKTest
 WORKING DIRECTORY C:\Users\user\Desktop\GKTest
 failed: 6
 calling QuitProgressUI
 }}}

 update.status:
 {{{
 failed: 6
 }}}

 Not sure what the correct behaviour is here with regards to the updater
 but at least we get this far.

 I suspect this is a bug in mingw, but it's unclear to me at the moment
 what the right behaviour is here

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31567 [Applications/Tor Browser]: NS_tsnprintf() does not handle %s correctly on Windows

[Tor Bug Tracker & Wiki]

#31567: NS_tsnprintf() does not handle %s correctly on Windows
-+-
 Reporter:  mcs  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201908   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by pospeselr):

 copied from the mozilla bug:

 So I'm tentatively going to claim this is a bug in mingw's implementation
 of _vsnwprintf in ucrt__vsnwprintf.c. I wrote a quick test program and
 built with msvc 19.21 and verified in windbg that a value of '5' (which
 corresponds to UCRTBASE_PRINTF_LEGACY_VSPRINTF_NULL_TERMINATION |
 UCRTBASE_PRINTF_LEGACY_WIDE_SPECIFIERS ) while mingw's implementation only
 passes in '1' ( UCRTBASE_PRINTF_LEGACY_VSPRINTF_NULL_TERMINATION ).
 Swapping the 5 to a 1 in the debugger gives us the same broken behavior.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs