Re: [tor-bugs] #20329 [Applications/Tor Browser]: Prevent add-ons updates from being written to the OS temporary directory

2019-09-09 Thread Tor Bug Tracker & Wiki
#20329: Prevent add-ons updates from being written to the OS temporary directory
--+--
 Reporter:  bugzilla  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-disk-leak |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 https://bugzilla.mozilla.org/show_bug.cgi?id=1473837

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31616 [Applications/Tor Browser]: Tor Browser on Android based on 60.9.0 is crashing on every launch

2019-09-09 Thread Tor Bug Tracker & Wiki
#31616: Tor Browser on Android based on 60.9.0 is crashing on every launch
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  tbb-mobile, tbb-crash,   |  Actual Points:
  TorBrowserTeam201909R  |
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+-

Comment (by Horizon78):

 Perfect!  works fine again after the update!  Thank you very much!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31680 [Applications/Tor Browser]: XSS warning pops up in case of timeout

2019-09-09 Thread Tor Bug Tracker & Wiki
#31680: XSS warning pops up in case of timeout
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 I see increasingly XSS warning popups showing up because of timeouts which
 is highly confusing. Clearly, timeouts are not really an indication of an
 XSS issue. An example for how this looks like is:
 {{{
 NoScript detected a potential Cross-Site Scripting attack

 from https://www.zeit.de to https://dx6ctphzljkf1.cloudfront.net.

 Suspicious data:

 Error: Exceeded 2ms timeout,(URL)
 
https://dx6ctphzljkf1.cloudfront.net/iqdcdnkj/0a3b52795fef0905/index.html?clicktag=http://adclick.g.doubleclick.net/pcs/click%3Fxai
 
%3DAKAOjsuHXc6Zwesb8f8FaSD7QQTqsyHbRHJNWVu3QNltNDaJ94NGlNH6WfODjTA6sloDprbdd1rxSjqWKdGOSolznaWuiKCcayJ4DmNlCF5OkavZ_eGS0Xkfao5UQJ-
 JwqhV_gAR_7tfsnUfu60yvzJ0iU4Z1D6Zkb6sjCl0_HQA22VBLWn-QSPhAgfMV614r-
 
HBeMGma_lSkoiCPSy0kyKnCRL5tUnv1UmFqhpDBN4tMevUa2rZkJz6uo8knPiePTPGjelmuicueasP3g%26sai
 %3DAMfl-
 
YR4Mk3FY_qymLNh3MZw4TEqprFJmYFBo9_kQIEByETK8t21mR91HHtY12pZU52d0EITutWjovVnNx6CvX-
 
biT_ug2TurDhIiyL2djhlow%26sig%3DCg0ArKJSzIDezji-X-DkEAE%26urlfix%3D1%26adurl%3Dhttp://marktplatz.zeit.de/urlaubsziele/themen/lesenswertes/&;
 }}}
 or
 {{{
 NoScript detected a potential Cross-Site Scripting attack

 from https://www.zeit.de to https://s3.eu-central-1.amazonaws.com.

 Suspicious data:

 Error: Exceeded 2ms timeout,(URL) https://s3.eu-
 
central-1.amazonaws.com/iqdcdnea/10e4b7649324fb09/index.html?clicktag=https://adclick.g.doubleclick.net/pcs/click%3Fxai
 %3DAKAOjssAkvqdVAj8OVky5YyBIxfFhdSKOwG3PBSs1sGLVOkrTAbbR2gQhodz_fXydReP-
 sWxzXELTfAuQkQKvcolwGDPsya5J4nL-
 
viX8VzJakyNC5yyVB4zTY8PRSHU_uCuiDOkZfyU6r6ldJAmjPb3o9AJI1JjbB2B6BwWdGEXimu89rpjgP9_7QWQve3pDYoPSYGZtAGvE2nIak17XVJyFo6fpatdx-
 JftpL6BZ3We12XcmWv8xi1WzanqCJH7xQaQImIkf2k5dsgSg%26sai%3DAMfl-
 
YQQpqd7WwCqfy7nh3BpC3v5iOX8vRNIaR7zenwjOphvOa6S79W9pR_h16Vw99tViBvXlyo0AyCzyKJf9xzvxc43C-
 
iGZHR6IQYihbL1eQ%26sig%3DCg0ArKJSzKFyrN2JPsBaEAE%26urlfix%3D1%26adurl%3Dhttps://jobs.zeit.de/campus/berufstest%3Fwt_zmc%3Ddis.int.zonpmr.hausbanner
 .boa-
 
default.bot.wp.quan.x%26utm_medium%3Ddis%26utm_source%3Dhausbanner_zonpmr_int%26utm_campaign
 %3Dboa-
 
default%26utm_content%3Dbot_wp_quan_x&iqdurl=https://www.zeit.de&iqdcid=138255462209&;
 }}}
 That does not involve doing anything special just reading news with an
 9.0a6-ish Tor Browser.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26352 [Applications/Tor Browser]: When using "request desktop site" in Orfox, a mobile phone User-Agent gets sent instead of a desktop browser User-Agent

2019-09-09 Thread Tor Bug Tracker & Wiki
#26352: When using "request desktop site" in Orfox, a mobile phone User-Agent 
gets
sent instead of a desktop browser User-Agent
--+--
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  tbb-mobile|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by worldwa1):

 https://www.contactsupportgroup.com/opera-support/
 https://www.contactsupportgroup.com/match-support/
 https://www.contactsupportgroup.com/snapchat-support/
 https://www.contactsupportgroup.com/tinder-support/
 https://www.contactsupportgroup.com/youtube-support/
 https://www.contactsupportgroup.com/okcupid-support/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26352 [Applications/Tor Browser]: When using "request desktop site" in Orfox, a mobile phone User-Agent gets sent instead of a desktop browser User-Agent

2019-09-09 Thread Tor Bug Tracker & Wiki
#26352: When using "request desktop site" in Orfox, a mobile phone User-Agent 
gets
sent instead of a desktop browser User-Agent
--+--
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  tbb-mobile|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by worldwa1):

 https://www.contactsupportgroup.com/
 https://www.contactsupportgroup.com/skype-support/
 https://www.contactsupportgroup.com/google-home-support/
 https://www.contactsupportgroup.com/idrive-support
 https://www.contactsupportgroup.com/tumblr-support/
 https://www.contactsupportgroup.com/pinterest-support/
 https://www.contactsupportgroup.com/apple-icloud-support/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31679 [Core Tor/Tor]: Make checkShellScripts.sh handle path errors better

2019-09-09 Thread Tor Bug Tracker & Wiki
#31679: Make checkShellScripts.sh handle path errors better
--+
 Reporter:  teor  |  Owner:  teor
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:  testing   |  Actual Points:  0
Parent ID:| Points:  0
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  assigned => needs_review


Comment:

 See my PR:
 * master: https://github.com/torproject/tor/pull/1313

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31679 [Core Tor/Tor]: Make checkShellScripts.sh handle path errors better

2019-09-09 Thread Tor Bug Tracker & Wiki
#31679: Make checkShellScripts.sh handle path errors better
--+
 Reporter:  teor  |  Owner:  teor
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal|   Keywords:  testing
Actual Points:  0 |  Parent ID:
   Points:  0 |   Reviewer:
  Sponsor:|
--+
 checkShellScripts.sh has two minor bugs:
 * it should handle being called from its parent directory on systems
 without realpath
 * it should exit with an error status if it can't find the src directory

 This is a fix on master, so it doesn't need a changes file.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31677 [Core Tor/Tor]: Add usage help option to git scripts

2019-09-09 Thread Tor Bug Tracker & Wiki
#31677: Add usage help option to git scripts
+
 Reporter:  teor|  Owner:  teor
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor|Version:  Tor: unspecified
 Severity:  Normal  | Resolution:
 Keywords:  git-scripts, dev-tools  |  Actual Points:  0.1
Parent ID:  | Points:  0.1
 Reviewer:  |Sponsor:  Sponsor31-can
+
Changes (by teor):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31677 [Core Tor/Tor]: Add usage help option to git scripts

2019-09-09 Thread Tor Bug Tracker & Wiki
#31677: Add usage help option to git scripts
+
 Reporter:  teor|  Owner:  teor
 Type:  defect  | Status:  assigned
 Priority:  Medium  |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor|Version:  Tor: unspecified
 Severity:  Normal  | Resolution:
 Keywords:  git-scripts, dev-tools  |  Actual Points:  0.1
Parent ID:  | Points:  0.1
 Reviewer:  |Sponsor:  Sponsor31-can
+

Comment (by teor):

 See my PR:
 * master: https://github.com/torproject/tor/pull/1312

 It also includes a fix for #31678, because there were conflicts.

 This is a fix on the last help ticket for the git scripts, so I don't
 think it needs a changes file.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31678 [Core Tor/Tor]: Allow git-push-all.sh to be run from any directory

2019-09-09 Thread Tor Bug Tracker & Wiki
#31678: Allow git-push-all.sh to be run from any directory
+
 Reporter:  teor|  Owner:  teor
 Type:  enhancement | Status:  closed
 Priority:  Medium  |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  git-scripts, dev-tools  |  Actual Points:  0
Parent ID:  #31677  | Points:  0
 Reviewer:  |Sponsor:
+
Changes (by teor):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 Let's deal with the review in #31677, because there are conflicts.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31678 [Core Tor/Tor]: Allow git-push-all.sh to be run from any directory

2019-09-09 Thread Tor Bug Tracker & Wiki
#31678: Allow git-push-all.sh to be run from any directory
--+
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  git-scripts, dev-tools
Actual Points:  0 |  Parent ID:  #31677
   Points:  0 |   Reviewer:
  Sponsor:|
--+
 Previously, the script could only be run from one of the worktree
 directories.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31677 [Core Tor/Tor]: Add usage help option to git scripts

2019-09-09 Thread Tor Bug Tracker & Wiki
#31677: Add usage help option to git scripts
---+
 Reporter:  teor   |  Owner:  teor
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor   |Version:  Tor: unspecified
 Severity:  Normal |   Keywords:  git-scripts, dev-tools
Actual Points:  0.1|  Parent ID:
   Points:  0.1|   Reviewer:
  Sponsor:  Sponsor31-can  |
---+
 This is a follow-up to a bunch of sponsor 31 tooling changes.

 While it's nice to have docs at the start of the script, it's even nicer
 to have a usage option "-h" and usage advice on errors.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31673 [Core Tor/Tor]: Deprecated use of

2019-09-09 Thread Tor Bug Tracker & Wiki
#31673: Deprecated use of 
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  035-backport 040-backport|  Actual Points:
  041-backport asn-merge |
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => merge_ready
 * keywords:  035-backport 040-backport 041-backport => 035-backport
 040-backport 041-backport asn-merge


Comment:

 CI has passed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31552 [Core Tor/Tor]: --disable-module-dirauth broken (missing symbols)

2019-09-09 Thread Tor Bug Tracker & Wiki
#31552: --disable-module-dirauth broken (missing symbols)
-+-
 Reporter:  LarryBitcoin |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.5
 Severity:  Normal   | Resolution:
 Keywords:  build, configure, features,  |  Actual Points:  .1
  modules, regression, 041-should|
Parent ID:   | Points:
 Reviewer:  catalyst |Sponsor:
 |  Sponsor31-can
-+-
Changes (by nickm):

 * status:  needs_information => needs_review


Comment:

 For me, the previous changes work with GCC and -O0, but fail with clang
 and -O0.  The configuration that reproduces the failure with the original
 version of the patch but which succeeds with the second is:
 {{{
 ./configure  --disable-module-dirauth --disable-gcc-hardening CC=clang
 CFLAGS='-O0'
 }}}

 (The `--disable-gcc-hardening` part is necessary to turn off
 FORTIFY_SOURCE, which is not compatible with `-O0`.)

 For me, both versions of the patch work with GCC.  My GCC is 9.2.1; my
 clang is 8.0.0.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31354 [Core Tor/Tor]: Compiler "note" in test_addr.c: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’

2019-09-09 Thread Tor Bug Tracker & Wiki
#31354: Compiler "note" in test_addr.c: variable tracking size limit exceeded 
with
‘-fvar-tracking-assignments’
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  regression|  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 wow! Sorry about that-- I honestly don't know what I was working on when I
 left that in.

 I've added a fixup commit to the branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31615 [Core Tor/Tor]: Reorder the early subsystems based on their dependencies

2019-09-09 Thread Tor Bug Tracker & Wiki
#31615: Reorder the early subsystems based on their dependencies
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, consider-backport-  |  Actual Points:  0.3
  after-042-stable, consider-backport-if-|
  needed, 042-should, 040-backport-maybe, 041|
  -backport-maybe, BugSmashFund  |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * status:  needs_revision => merge_ready
 * actualpoints:  0.2 => 0.3


Comment:

 I removed the comments, the merge forward had trivial conflicts:
 * 0.4.0: https://github.com/torproject/tor/pull/1301
 * 0.4.1: https://github.com/torproject/tor/pull/1310
 * master: https://github.com/torproject/tor/pull/1311

 CI is still running on 0.4.1 and master, but I only changed comments, so I
 think it will pass.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31671 [Applications/Tor Browser]: Firefox's integration with Cloudflare for DNS-over-HTTPS

2019-09-09 Thread Tor Bug Tracker & Wiki
#31671: Firefox's integration with Cloudflare for DNS-over-HTTPS
--+--
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Critical  | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 Perhaps it is high time to reconsider ungoogled-chromium being based on
 some other browser rather than being a patch-work of some anti-privacy
 software like Chromium.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31552 [Core Tor/Tor]: --disable-module-dirauth broken (missing symbols)

2019-09-09 Thread Tor Bug Tracker & Wiki
#31552: --disable-module-dirauth broken (missing symbols)
-+-
 Reporter:  LarryBitcoin |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.5
 Severity:  Normal   | Resolution:
 Keywords:  build, configure, features,  |  Actual Points:  .1
  modules, regression, 041-should|
Parent ID:   | Points:
 Reviewer:  catalyst |Sponsor:
 |  Sponsor31-can
-+-
Changes (by catalyst):

 * status:  needs_review => needs_information


Comment:

 Replying to [comment:13 nickm]:
 > I've added another commit to the branch; does it fix the remaining
 problems?
 Did the previous changes work with `-O0`? If so, what readily available
 platform do we have to detect the problems that the second commit
 addresses?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31571 [Core Tor/Tor]: Add the tor version and a newline to raw_assert()

2019-09-09 Thread Tor Bug Tracker & Wiki
#31571: Add the tor version and a newline to raw_assert()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.3
  BugSmashFund, diagnostics, 042-should, |
  android, dgoulet-merge, macos 035-backport |
  040-backport 041-backport  |
Parent ID:  #31570   | Points:  0.1
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * keywords:
 diagnostics, 042-should, android, dgoulet-merge, macos 035-backport
 040-backport 041-backport
 =>
 consider-backport-after-042-stable, BugSmashFund, diagnostics,
 042-should, android, dgoulet-merge, macos 035-backport 040-backport
 041-backport
 * cc: gaba (removed)
 * sponsor:  Sponsor31-can =>
 * actualpoints:  0.1 => 0.3


Comment:

 This is a complex series of changes, across multiple platforms. But it is
 well isolated.
 It does fix a real bug that we have encountered before, and it
 significantly improves error diagnostics,
 So we do want to backport, but not until after 0.4.2-stable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

2019-09-09 Thread Tor Bug Tracker & Wiki
#31594: Close all the log fds before aborting
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, consider-backport-if-   |  Actual Points:  0.9
  needed, consider-backport-after-042-stable,|
  042-should, android, macos, 040-backport-  |
  maybe, 041-backport-maybe, BugSmashFund, asn-  |
  merge  |
Parent ID:   | Points:  0.3
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * parent:  #31571 =>


Comment:

 This ticket is independent of its parent,

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31635 [Core Tor/Tor]: Initialise and reset the sigsafe error fds to -1

2019-09-09 Thread Tor Bug Tracker & Wiki
#31635: Initialise and reset the sigsafe error fds to -1
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, 042-can, technical- |  Actual Points:
  debt   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:  diagnostics, 042-can => diagnostics, 042-can, technical-debt
 * parent:  #31594 =>


Comment:

 Now that the parent is merged to master, we can do this ticket
 independently.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

2019-09-09 Thread Tor Bug Tracker & Wiki
#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.2
  consider-backport-if-needed, diagnostics,  |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression, |
  BugSmashFund   |
Parent ID:   | Points:  0.2
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by teor):

 * parent:  #31594 =>


Comment:

 This ticket is independent of its parent now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31615 [Core Tor/Tor]: Reorder the early subsystems based on their dependencies

2019-09-09 Thread Tor Bug Tracker & Wiki
#31615: Reorder the early subsystems based on their dependencies
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, consider-backport-  |  Actual Points:  0.2
  after-042-stable, consider-backport-if-|
  needed, 042-should, 040-backport-maybe, 041|
  -backport-maybe, BugSmashFund  |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * parent:  #31594 =>


Comment:

 This ticket is independent of its parent.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31673 [Core Tor/Tor]: Deprecated use of

2019-09-09 Thread Tor Bug Tracker & Wiki
#31673: Deprecated use of 
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  035-backport 040-backport|  Actual Points:
  041-backport   |
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
-+-

Comment (by nickm):

 Appears correct; let's see what CI says.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31673 [Core Tor/Tor]: Deprecated use of

2019-09-09 Thread Tor Bug Tracker & Wiki
#31673: Deprecated use of 
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  035-backport 040-backport|  Actual Points:
  041-backport   |
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
-+-
Changes (by dgoulet):

 * status:  needs_revision => needs_review


Comment:

 Fixed in both. Going afk so taking a chance on this one ;).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31615 [Core Tor/Tor]: Reorder the early subsystems based on their dependencies

2019-09-09 Thread Tor Bug Tracker & Wiki
#31615: Reorder the early subsystems based on their dependencies
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, consider-backport-  |  Actual Points:  0.2
  after-042-stable, consider-backport-if-|
  needed, 042-should, 040-backport-maybe, 041|
  -backport-maybe, BugSmashFund  |
Parent ID:  #31594   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 These look good, except that the levels we have here are now out-of-sync
 with the comments in tor_subsystems.c.  Please feel free to either edit
 the ones in tor_subsystems.c, or remove them entirely, and put this back
 into merge_ready once you've done so.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

2019-09-09 Thread Tor Bug Tracker & Wiki
#31594: Close all the log fds before aborting
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, consider-backport-if-   |  Actual Points:  0.9
  needed, consider-backport-after-042-stable,|
  042-should, android, macos, 040-backport-  |
  maybe, 041-backport-maybe, BugSmashFund, asn-  |
  merge  |
Parent ID:  #31571   | Points:  0.3
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * keywords:
 diagnostics, consider-backport-if-needed, consider-backport-
 after-042-stable, 042-should, android, macos, 040-backport-maybe, 041
 -backport-maybe, BugSmashFund
 =>
 diagnostics, consider-backport-if-needed, consider-backport-
 after-042-stable, 042-should, android, macos, 040-backport-maybe, 041
 -backport-maybe, BugSmashFund, asn-merge
 * status:  needs_review => merge_ready


Comment:

 This looks plausible to me.  Let's try it in 0.4.2!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31676 [Internal Services/Tor Sysadmin Team]: decommission resphigi

2019-09-09 Thread Tor Bug Tracker & Wiki
#31676: decommission resphigi
-+-
 Reporter:  weasel   |  Owner:  tpa
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 I chatted with dgoulet, and we can retire resphighi.

 We can always set up a new VM for testnet services if they are useful
 again in the future.  But for now, this setup is not in use.

 This is part of the "retire textile" drive.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31673 [Core Tor/Tor]: Deprecated use of

2019-09-09 Thread Tor Bug Tracker & Wiki
#31673: Deprecated use of 
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  035-backport 040-backport|  Actual Points:
  041-backport   |
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 I've commented on both.

 Also, I've recently started making PRs, but not putting them into needs-
 review until the CI has passed. Maybe consider doing this too?  It's saved
 me from a few problems on this kind of thing in the past week.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31552 [Core Tor/Tor]: --disable-module-dirauth broken (missing symbols)

2019-09-09 Thread Tor Bug Tracker & Wiki
#31552: --disable-module-dirauth broken (missing symbols)
-+-
 Reporter:  LarryBitcoin |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.5
 Severity:  Normal   | Resolution:
 Keywords:  build, configure, features,  |  Actual Points:  .1
  modules, regression, 041-should|
Parent ID:   | Points:
 Reviewer:  catalyst |Sponsor:
 |  Sponsor31-can
-+-
Changes (by nickm):

 * keywords:  build, configure, features, modules, regression => build,
 configure, features, modules, regression, 041-should


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31675 [Core Tor/Tor]: Split microdescs_parse_from_string() into smaller functions

2019-09-09 Thread Tor Bug Tracker & Wiki
#31675: Split microdescs_parse_from_string() into smaller functions
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  assigned
 Priority:  Low   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  0
 Reviewer:|Sponsor:  Sponsor31-can
--+

Comment (by nickm):

 CI passed, but I would like more test coverage.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30777 [Community/Outreach]: Run a "set up new bridges" campaign

2019-09-09 Thread Tor Bug Tracker & Wiki
#30777: Run a "set up new bridges" campaign
---+---
 Reporter:  phw|  Owner:  (none)
 Type:  project| Status:  assigned
 Priority:  High   |  Milestone:
Component:  Community/Outreach |Version:
 Severity:  Normal | Resolution:
 Keywords:  anti-censorship-roadmap-september  |  Actual Points:
Parent ID:  #31281 | Points:  3
 Reviewer: |Sponsor:
   |  Sponsor30-must
---+---

Comment (by phw):

 Brief update: We started our campaign on August 28 in
 [https://blog.torproject.org/run-tor-bridges-defend-open-internet this
 blog post]. So far, 46 new bridges were set up and reported to us.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31538 [Applications/Tor Browser]: Windows bundles based on ESR 68 are not built reproducibly

2019-09-09 Thread Tor Bug Tracker & Wiki
#31538: Windows bundles based on ESR 68 are not built reproducibly
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-rbm, ff68-esr, tbb-9.0-must- |  Actual Points:
  alpha, TorBrowserTeam201909,   |
  GeorgKoppen201909  |
Parent ID:  #30322   | Points:  2
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 The different order in libc++.a is already visible in the respecting link
 command:
 {{{
 /var/tmp/dist/mingw-w64-clang/bin/llvm-ar qc libc++.a
 CMakeFiles/cxx_objects.dir/__/src/shared_mutex.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/exception.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/system_error.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/charconv.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/new.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/variant.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/optional.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/bind.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/locale.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/mutex.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/iostream.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/stdexcept.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/thread.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/random.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/ios.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/typeinfo.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/future.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/functional.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/any.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/utility.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/valarray.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/hash.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/regex.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/condition_variable.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/chrono.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/string.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/debug.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/algorithm.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/memory.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/vector.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/strstream.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/support/win32/thread_win32.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/support/win32/support.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/support/win32/locale_win32.cpp.obj
 }}}
 vs.
 {{{
 /var/tmp/dist/mingw-w64-clang/bin/llvm-ar qc libc++.a
 CMakeFiles/cxx_objects.dir/__/src/typeinfo.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/debug.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/thread.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/hash.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/stdexcept.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/algorithm.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/valarray.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/condition_variable.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/locale.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/functional.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/bind.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/shared_mutex.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/any.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/exception.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/chrono.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/system_error.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/ios.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/string.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/optional.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/new.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/charconv.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/vector.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/regex.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/strstream.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/memory.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/random.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/iostream.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/utility.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/mutex.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/future.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/variant.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/support/win32/support.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/support/win32/locale_win32.cpp.obj
 CMakeFiles/cxx_objects.dir/__/src/support/win32/thread_win32.cpp.obj
 }}}
 Responsible for that is `CMake` which saves the command to use in a
 `link.txt` file
 {{{
 cd /var/tmp/build/libcxx/build/lib && /var/tmp/dist/cmake/bin/cmake -E
 cmake_link_script CMakeFiles/cxx_static.dir/link.txt --verbose=1
 }}}
 I am not sure y

Re: [tor-bugs] #31675 [Core Tor/Tor]: Split microdescs_parse_from_string() into smaller functions

2019-09-09 Thread Tor Bug Tracker & Wiki
#31675: Split microdescs_parse_from_string() into smaller functions
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  assigned
 Priority:  Low   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  0
 Reviewer:|Sponsor:  Sponsor31-can
--+

Comment (by nickm):

 Branch is `ticket31675`; PR at https://github.com/torproject/tor/pull/1309
 .  I'll put this in needs_review when CI passes.

 For review, let's also think about the question: is this a good model for
 handling function-size practracker violations?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30570 [Applications/Tor Browser]: Implement per-site security settings support

2019-09-09 Thread Tor Bug Tracker & Wiki
#30570: Implement per-site security settings support
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ux-team   |  Actual Points:
Parent ID:  #25658| Points:
 Reviewer:|Sponsor:  Sponsor9
--+--
Changes (by intrigeri):

 * cc: intrigeri (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31674 [Applications/Tor Browser]: A highlightable menu item with empty label below "About Tor Browser" item.

2019-09-09 Thread Tor Bug Tracker & Wiki
#31674: A highlightable menu item with empty label below "About Tor Browser" 
item.
--+---
 Reporter:  GoldJello |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  duplicate
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by gk):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Indeed. Closing as a duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31589 [Core Tor/Tor]: hs-v3: Simplify decrypt_desc_layer interface

2019-09-09 Thread Tor Bug Tracker & Wiki
#31589: hs-v3: Simplify decrypt_desc_layer interface
---+---
 Reporter:  asn|  Owner:  (none)
 Type:  defect | Status:
   |  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  unspecified
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs easy refactoring tech-debt  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by dgoulet):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22942 [Applications/Tor Browser]: Empty menuitem below "About Tor Browser"

2019-09-09 Thread Tor Bug Tracker & Wiki
#22942: Empty menuitem below "About Tor Browser"
--+--
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Very Low  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Trivial   | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * cc: GoldJello (added)


Comment:

 Closed #31674 as a duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30020 [Internal Services/Tor Sysadmin Team]: switch from our custom YAML implementation to Hiera

2019-09-09 Thread Tor Bug Tracker & Wiki
#30020: switch from our custom YAML implementation to Hiera
-+-
 Reporter:  anarcat  |  Owner:  anarcat
 Type:  project  | Status:
 |  accepted
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #29387   | Points:
 Reviewer:   |Sponsor:
-+-
Description changed by anarcat:

Old description:

> We currently use a custom-made YAML database for assigning roles to
> servers and other metadata. I started using Hiera for some hosts and it
> seems to be working well.
>
> Hiera is officially supported in Puppet and shipped by default in Puppet
> 5 and later. It's the standard way of specifying metadata and class
> parameters for hosts. I suspect it covers most of our needs in terms of
> metadata and should cover most if not all of what we're currently doing
> with the YAML stuff in Puppet.
>
> We should therefore switch to using Hiera instead of our homegrown
> solution.
>
> This involves converting:
>
>  * `if has_role('foo') { include foo }` into `classes: [ 'foo' ]` in
> hiera
>  * hardcoded macros in the ferm module's `me.conf.erb` into exported
> resources
>  * templates looping over allnodeinfo into exported resources
>  * the `$roles` array into Hiera
>  * the `$localinfo` into Hiera (assuming all the data is there)
>  * the `$nodeinfo` and `$allnodeinfo` arrays into Hiera (assuming we can
> switch from LDAP for host inventory)
>  * basically any other stuff of the kind, including those files:
>{{{
> ./modules/torproject_org/misc/hoster.yaml
> ./modules/torproject_org/misc/local.yaml
> ./modules/ipsec/misc/config.yaml
> ./modules/roles/misc/static-components.yaml
> ./modules/roles/files/spec/spec-redirects.yaml
> }}}
>
> Ideally, all YAML data should end up in the hiera/ directory somehow.
> This is the first step in making our repository public (#29387) but also
> using Hiera as a more elaborate inventory system (#30273).
>
> The idea of switching from LDAP to Hiera for host inventory will
> definitely need to be evaluated more thoroughly before going ahead with
> that part of the conversion, but YAML stuff in Puppet should definitely
> be converted.
>
> The general goal of this is both to allow for a better inventory system
> but also make it easier for people to get onboarded with Puppet. By using
> community standards like Hiera, we make it easier for new people to get
> familiar with the puppet infrastructures and do things meaningfully.

New description:

 We currently use a custom-made YAML database for assigning roles to
 servers and other metadata. I started using Hiera for some hosts and it
 seems to be working well.

 Hiera is officially supported in Puppet and shipped by default in Puppet 5
 and later. It's the standard way of specifying metadata and class
 parameters for hosts. I suspect it covers most of our needs in terms of
 metadata and should cover most if not all of what we're currently doing
 with the YAML stuff in Puppet.

 We should therefore switch to using Hiera instead of our homegrown
 solution.

 This involves converting:

  * `if has_role('foo') { include foo }` into `classes: [ 'foo' ]` in hiera
 (DONE!)
  * hardcoded macros in the ferm module's `me.conf.erb` into exported
 resources (DONE, except for HOST_TPO)
  * templates looping over allnodeinfo into exported resources
  * the `$roles` array into Hiera (DONE!)
  * the `$localinfo` into Hiera (assuming all the data is there) (DONE!)
  * the `$nodeinfo` and `$allnodeinfo` arrays into Hiera (assuming we can
 switch from LDAP for host inventory)
  * basically any other stuff of the kind, including those files:
{{{
 ./modules/torproject_org/misc/hoster.yaml
 ./modules/torproject_org/misc/local.yaml <- DONE!
 ./modules/ipsec/misc/config.yaml
 ./modules/roles/misc/static-components.yaml
 ./modules/roles/files/spec/spec-redirects.yaml
 }}}

 Ideally, all YAML data should end up in the hiera/ directory somehow. This
 is the first step in making our repository public (#29387) but also using
 Hiera as a more elaborate inventory system (#30273).

 The idea of switching from LDAP to Hiera for host inventory will
 definitely need to be evaluated more thoroughly before going ahead with
 that part of the conversion, but YAML stuff in Puppet should definitely be
 converted.

 The general goal of this is both to allow for a better inventory system
 but also make it easier for people to get onboarded with Puppet. By using
 community standards like Hiera, we make it easie

Re: [tor-bugs] #31589 [Core Tor/Tor]: hs-v3: Simplify decrypt_desc_layer interface

2019-09-09 Thread Tor Bug Tracker & Wiki
#31589: hs-v3: Simplify decrypt_desc_layer interface
---+---
 Reporter:  asn|  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  Tor:
   |  unspecified
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs easy refactoring tech-debt  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---

Comment (by ltbringer):

 https://github.com/torproject/tor/pull/1308

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31477 [Core Tor/Tor]: Practracker integration tests for headers and includes

2019-09-09 Thread Tor Bug Tracker & Wiki
#31477: Practracker integration tests for headers and includes
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  practracker, tech-debt,  |  Actual Points:
  refactoring, easy, 041-deferred-20190530,  |
  network-team-roadmap-july, dgoulet-merge   |
Parent ID:  #29746   | Points:
 Reviewer:  catalyst |Sponsor:
 |  Sponsor31-must
-+-
Changes (by dgoulet):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30020 [Internal Services/Tor Sysadmin Team]: switch from our custom YAML implementation to Hiera

2019-09-09 Thread Tor Bug Tracker & Wiki
#30020: switch from our custom YAML implementation to Hiera
-+-
 Reporter:  anarcat  |  Owner:  anarcat
 Type:  project  | Status:
 |  accepted
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #29387   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by anarcat):

 grand milestone today: `local.yaml` was removed from the repository, along
 with `get_role` and `yamlinfo`, which are all now useless.

 WHOOHOO!

 == Next step: hoster.yaml

 the next chunk we need to convert would be, i think,
 `./modules/torproject_org/misc/hoster.yaml`, which specifies those things:

 * `netrange`: used to create the `TPO_NET` macro in ferm (unused?) and
 determine in which `hoster` a given host is (through `whohosts.rb`, which
 does IP range calculations from the host's IP as seen from LDAP)
 * `mirror-debian`: used in `torproject_org` class to define the APT mirror
 for this host
 * `mirror-debian-security`: unused?
 * `nameservers`: used to configured upstream forwarders in unbound on each
 host
 * `nameservers_break_dnssec` : used to disable unbound forwarding in case
 of broken upstream DNS, unused
 * `allow_dns_query`: used to tell unbound to allow other network ranges
 (ie. generally on this site) to use *this* node as recursive DNS server
 (if `misc.resolver-recursive` is true, which is the case when the LDAP ip
 of the host is listed in the hoster's `nameservers` list)

 Debian.org has hooked hosters.yaml into hiera, and the way they did it is
 to have one .yaml file per hoster, for example:

 https://salsa.debian.org/dsa-team/mirror/dsa-
 puppet/blob/master/hieradata/bytemark.yaml

 Unfortunately, the `hoster.yaml` is still present on d.o:

 https://salsa.debian.org/dsa-team/mirror/dsa-
 puppet/blob/master/modules/puppetmaster/lib/puppet/parser/functions/whohosts.rb

 there we have the same code as on tpo:

 {{{
 yamlfile =
 Puppet::Parser::Files.find_file('debian_org/misc/hoster.yaml',
 compiler.environment)
 }}}

 Here the file, which contains more than just ip ranges:

 https://salsa.debian.org/dsa-team/mirror/dsa-
 puppet/blob/master/modules/debian_org/files/misc/hoster.yaml

 So their transition isn't complete, but it matches some of the ideas I had
 (namely to have one YAML file per hoster).

 So what I would suggest we do to get rid of the hoster.yaml file is this:

  1. convert all the aforementioned variables used in `hoster.yaml` into
 class variables, defaulting to the values loaded from `hoster.yaml` (ie.
 `$nodeinfo`)
  2. test the variables by overriding them in (e.g.)
 `hiera/nodes/foo.example.com.yaml`
  3. break up the `hoster.yaml` file into multiple smaller files in
 `hiera/hoster/%{hoster}.yaml`
  4. add that path to `hiera.yaml`
  5. test that host can load its variables from the `hoster` search path by
 hardcoding a value by hand in facter
  6. create a new YAML variable that gives us a IP range -> hoster mapping
  7. create a function that looks through those to guess the hoster for a
 given IP address
  8. use that function to create a fact (through a template, but with a
 variable defined in the base class) that defines the `$hoster` variable
 that hiera will use to load the right YAML
  9. remove `hoster.yaml`

 That's a first step. At that stage, `hoster.yaml` is gone, but `$nodeinfo`
 remains and still might contain host-specific configuration. Those should
 be extract *out* of the `$nodeinfo` construct and into manifest business
 logic. And *then* the `nodeinfo.rb` code can be ripped out.

 There might be a better way to define a hoster per node than guess it with
 its IP address and drop it as a fact, but I can't think of anything right
 now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31616 [Applications/Tor Browser]: Tor Browser on Android based on 60.9.0 is crashing on every launch

2019-09-09 Thread Tor Bug Tracker & Wiki
#31616: Tor Browser on Android based on 60.9.0 is crashing on every launch
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  tbb-mobile, tbb-crash,   |  Actual Points:
  TorBrowserTeam201909R  |
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+-

Comment (by k0b4ya5hilvl4ru):

 Updated, now works

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31607 [Applications/Tor Browser]: App menu items stop working

2019-09-09 Thread Tor Bug Tracker & Wiki
#31607: App menu items stop working
-+-
 Reporter:  mcs  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201909   |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 Replying to [comment:5 gk]:
 > Do we get any errors in the error console? I wonder whether we made a
 mistake when integrating the About dialog from Torbutton directly into
 tor-browser.

 The error console shows:
 {{{
 NS_ERROR_NOT_AVAILABLE: utilityOverlay.js:994
 }}}
 That line in utilityOverlay.js is:
 {{{
  window.openDialog("chrome://browser/content/aboutDialog.xul", "",
 features);
 }}}

 If I enter `chrome://browser/content/aboutDialog.xul` in the URL bar, the
 about box XUL loads in a regular tab. Kathy and I will look deeper.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #6005 [Applications/Tor Browser]: Secure download of videos from YouTube

2019-09-09 Thread Tor Bug Tracker & Wiki
#6005: Secure download of videos from YouTube
--+--
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  needs-triage  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 This is out of the scope of TBB.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30175 [Applications/Tor Browser]: Manually whitelist extensions removed from AMO for purely political reasons in Tor Browser to fight Mozilla's censorship

2019-09-09 Thread Tor Bug Tracker & Wiki
#30175: Manually whitelist extensions removed from AMO for purely political 
reasons
in Tor Browser to fight Mozilla's censorship
--+--
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  enhancement   | Status:  reopened
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Major | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 > If it's a wontfix, then the Tor Project is a wontfix. Resolve the issue
 adequately and answer my questions or I will keep opening the ticket.

 Annoying the devs is literally the worst way to get this "issue" fixed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31616 [Applications/Tor Browser]: Tor Browser on Android based on 60.9.0 is crashing on every launch

2019-09-09 Thread Tor Bug Tracker & Wiki
#31616: Tor Browser on Android based on 60.9.0 is crashing on every launch
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  tbb-mobile, tbb-crash,   |  Actual Points:
  TorBrowserTeam201909R  |
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:45 k0b4ya5hilvl4ru]:
 > It says fixed but play store version is still not working, are you doing
 a new release?

 A release is currently rolling out. Tor Browser 8.5.6 should have the fix.
 Are you still on 8.5.5?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31564 [Applications/Tor Browser]: Android bundles based on ESR 68 are not built reproducibly anymore

2019-09-09 Thread Tor Bug Tracker & Wiki
#31564: Android bundles based on ESR 68 are not built reproducibly anymore
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-9.0-must-alpha,  |  Actual Points:
  TorBrowserTeam201909, GeorgKoppen201909|
Parent ID:  #30324   | Points:  5
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Here's the link to how to download the repo

 https://android.googlesource.com/platform/tools/base/+/studio-master-
 dev/source.md

 I checkout out branch 3.4.0.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31564 [Applications/Tor Browser]: Android bundles based on ESR 68 are not built reproducibly anymore

2019-09-09 Thread Tor Bug Tracker & Wiki
#31564: Android bundles based on ESR 68 are not built reproducibly anymore
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-9.0-must-alpha,  |  Actual Points:
  TorBrowserTeam201909, GeorgKoppen201909|
Parent ID:  #30324   | Points:  5
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Doesn't look better than Briar's approach.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31589 [Core Tor/Tor]: hs-v3: Simplify decrypt_desc_layer interface

2019-09-09 Thread Tor Bug Tracker & Wiki
#31589: hs-v3: Simplify decrypt_desc_layer interface
---+---
 Reporter:  asn|  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  Tor:
   |  unspecified
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs easy refactoring tech-debt  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---

Comment (by ltbringer):

 `desc` is passed down to `build_secret_key_iv_mac` -> `build_kdf_key` ->
 `build_secret_input`.

 That means, either we:

 1. Remove `desc` and provide `desc->plaintext_data.blinded_pubkey`,
 `desc->subcredential` and `desc->plaintext_data.revision_counter`
 2. Ditch encrypted_blob and encrypted_blob_size as arguments and get them
 off desc. (same as you suggest)

 My limited experience says, it would be neater to just pass `desc` but I
 would like to know why that wasn't your preference as either solutions are
 easy.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31616 [Applications/Tor Browser]: Tor Browser on Android based on 60.9.0 is crashing on every launch

2019-09-09 Thread Tor Bug Tracker & Wiki
#31616: Tor Browser on Android based on 60.9.0 is crashing on every launch
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  tbb-mobile, tbb-crash,   |  Actual Points:
  TorBrowserTeam201909R  |
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+-

Comment (by k0b4ya5hilvl4ru):

 It says fixed but play store version is still not working, are you doing a
 new release?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31564 [Applications/Tor Browser]: Android bundles based on ESR 68 are not built reproducibly anymore

2019-09-09 Thread Tor Bug Tracker & Wiki
#31564: Android bundles based on ESR 68 are not built reproducibly anymore
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-9.0-must-alpha,  |  Actual Points:
  TorBrowserTeam201909, GeorgKoppen201909|
Parent ID:  #30324   | Points:  5
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:22 sisbell]:
 > I downloaded the android gradle plugin repo.

 Out of curiosity, do you have a link to the repo?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22029 [Core Tor/Tor]: Allow ed25519 keys to be banned in the approved-routers file

2019-09-09 Thread Tor Bug Tracker & Wiki
#22029: Allow ed25519 keys to be banned in the approved-routers file
-+-
 Reporter:  teor |  Owner:  neel
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-triage-20180328, |  Actual Points:
  034-removed-20180328   |
Parent ID:   | Points:  1
 Reviewer:  nickm|Sponsor:
-+-

Comment (by dgoulet):

 Replying to [comment:68 teor]:
 > Hi nickm, if you could do a review of this branch, that would be great.
 >
 > I've made a few child tickets for tests, I think we should at least test
 on chutney or moria1 before merging.
 > It would also be nice for relay operators to have a file with the
 ed25519 identity in their data directory, but that can be a separate PR.

 As one of the person that commits to the dirauth-conf repository to reject
 relays, I'm interested on starting using this for which moria1 will be
 able to apply! So, that would be some testing at least :).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31570 [Core Tor/Tor]: INTERNAL ERROR: raw assertion failed (core dump) in termux

2019-09-09 Thread Tor Bug Tracker & Wiki
#31570: INTERNAL ERROR: raw assertion failed (core dump) in termux
-+-
 Reporter:  foremtehan   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  042-should, regression?, mmap,   |  Actual Points:  .1
  android, crash BugSmashFund|
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by nickm):

 * keywords:  042-should, regression?, mmap, android, crash => 042-should,
 regression?, mmap, android, crash BugSmashFund


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31457 [Applications/Tor Browser]: disable per-installation profiles

2019-09-09 Thread Tor Bug Tracker & Wiki
#31457: disable per-installation profiles
-+-
 Reporter:  mcs  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:  0.25
  TorBrowserTeam201909R  |
Parent ID:   | Points:  0.25
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-
Changes (by mcs):

 * actualpoints:   => 0.25


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31564 [Applications/Tor Browser]: Android bundles based on ESR 68 are not built reproducibly anymore

2019-09-09 Thread Tor Bug Tracker & Wiki
#31564: Android bundles based on ESR 68 are not built reproducibly anymore
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-9.0-must-alpha,  |  Actual Points:
  TorBrowserTeam201909, GeorgKoppen201909|
Parent ID:  #30324   | Points:  5
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 I downloaded the android gradle plugin repo. Its 8 GB. Most of the
 documentation and README files for the project are incorrect and/or not
 up-to-date. With the exception of the instructions for downloading the
 repo, not a single command worked as given, without some sort of
 modification.

 The blocker for me came with being unable to find or download the google
 vendor code for the build. Its similar to the following reported issue:

 https://stackoverflow.com/questions/50946201/aosp-does-not-have-tools-
 vendor-google3-project

 It does not appear that the full build is open-source.

 After some more research and investigation, I do have an alternative
 solution. We can use apktool. This will decompile the resources and then
 we can recompile with aapt2, which does not have the bug, as we would be
 bypassing the gradle plugin during a re-packaging phase. I've gone through
 apktool code and their is no issue on ordering of resources.

 https://github.com/iBotPeaches/Apktool

 I'll bring this up for discussion but the approach would be to create a
 project apktool project and to build the tool. Then use the tool to
 decompile and recompile resources in consistent order prior to packaging
 everything in the firefox project build (or in tor-browser).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31674 [Applications/Tor Browser]: A highlightable menu item with empty label below "About Tor Browser" item.

2019-09-09 Thread Tor Bug Tracker & Wiki
#31674: A highlightable menu item with empty label below "About Tor Browser" 
item.
--+--
 Reporter:  GoldJello |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by Thorin):

 duplicate of #22942

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31673 [Core Tor/Tor]: Deprecated use of

2019-09-09 Thread Tor Bug Tracker & Wiki
#31673: Deprecated use of 
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  035-backport 040-backport|  Actual Points:
  041-backport   |
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
-+-

Comment (by dgoulet):

 Fixed!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31674 [Applications/Tor Browser]: A highlightable menu item with empty label below "About Tor Browser" item.

2019-09-09 Thread Tor Bug Tracker & Wiki
#31674: A highlightable menu item with empty label below "About Tor Browser" 
item.
--+--
 Reporter:  GoldJello |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by pastly):

 * owner:  (none) => tbb-team
 * component:  - Select a component => Applications/Tor Browser


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31675 [Core Tor/Tor]: Split microdescs_parse_from_string() into smaller functions

2019-09-09 Thread Tor Bug Tracker & Wiki
#31675: Split microdescs_parse_from_string() into smaller functions
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  task   | Status:  assigned
 Priority:  Low|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:
   Points:  0  |   Reviewer:
  Sponsor:  Sponsor31-can  |
---+
 Instead of making an extended practracker exception here, we should make
 this function conform to our best practices.

 I'm taking this on because I need a quick finger exercise between larger
 things.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31674 [- Select a component]: A highlightable menu item with empty label below "About Tor Browser" item.

2019-09-09 Thread Tor Bug Tracker & Wiki
#31674: A highlightable menu item with empty label below "About Tor Browser" 
item.
---+--
 Reporter:  GoldJello  |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Component:  - Select a component
  Version: |   Severity:  Normal
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
 I found a minor bug (cosmetic one) by pressing hamburger menu -> Help.

 You could find a highlightable menu item with empty label below "About Tor
 Browser" item.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31354 [Core Tor/Tor]: Compiler "note" in test_addr.c: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’

2019-09-09 Thread Tor Bug Tracker & Wiki
#31354: Compiler "note" in test_addr.c: variable tracking size limit exceeded 
with
‘-fvar-tracking-assignments’
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  regression|  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:5 nickm]:
 > I think this is ready for a review.  It's not the long-term solution,
 but it may help.
 Thanks! Mostly looks good. I left a comment on the pull request about an
 extraneous addition.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30924 [Core Tor/Tor]: hs-v3: Implement proposal 305 - ESTABLISH_INTRO Cell DoS Defense Extension

2019-09-09 Thread Tor Bug Tracker & Wiki
#30924: hs-v3: Implement proposal 305 -  ESTABLISH_INTRO Cell DoS Defense 
Extension
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tor-spec, prop305, network-  |  implemented
  team-roadmap-august, nickm-merge   |  Actual Points:
Parent ID:  #2   | Points:  7
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 CI passed; Merged to master!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31477 [Core Tor/Tor]: Practracker integration tests for headers and includes

2019-09-09 Thread Tor Bug Tracker & Wiki
#31477: Practracker integration tests for headers and includes
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  practracker, tech-debt,  |  Actual Points:
  refactoring, easy, 041-deferred-20190530,  |
  network-team-roadmap-july, dgoulet-merge   |
Parent ID:  #29746   | Points:
 Reviewer:  catalyst |Sponsor:
 |  Sponsor31-must
-+-
Changes (by catalyst):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:6 nickm]:
 > Replying to [comment:5 catalyst]:
 > > Replying to [comment:4 nickm]:
 > > > The bug is this: I thought that saying that DependencyViolation
 applied to `*` would make it apply to all files -- but practracker doesn't
 support that.  I had to say instead that it applies to `*.h` and `*.c`.
 > > I still didn't understand this description, so I looked into
 `practracker.py` and `problem.py`. I'm guessing that `ProblemFilter` needs
 to have its filename patterns be unambiguously denoting either `.c` or
 `.h` files. It looks like `Item.get_file_type()` determines this based on
 the suffix (`.c` or `.h`) of the file or pattern, defaulting to `*.c`. So
 maybe a pattern of `*` would match `*.c` files but not `*.h` files? Does
 this sound like an accurate description of the bug?
 >
 > That's right -- the Item.get_file_type() function converts `*` to `*.c`,
 so that it will match .c files, but not .h files.
 Thanks. Now that explanation is in the ticket so it's a little easier to
 discover.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31477 [Core Tor/Tor]: Practracker integration tests for headers and includes (was: Practracker integration tsts for headers and includes)

2019-09-09 Thread Tor Bug Tracker & Wiki
#31477: Practracker integration tests for headers and includes
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  practracker, tech-debt,  |  Actual Points:
  refactoring, easy, 041-deferred-20190530,  |
  network-team-roadmap-july, dgoulet-merge   |
Parent ID:  #29746   | Points:
 Reviewer:  catalyst |Sponsor:
 |  Sponsor31-must
-+-

Comment (by catalyst):

 fix typo in summary

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30538 [Applications/Tor Browser]: Unable to comment on The Independent Newspaper

2019-09-09 Thread Tor Bug Tracker & Wiki
#30538: Unable to comment on The Independent Newspaper
--+--
 Reporter:  mwolfe|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-usability-website |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 Replying to [comment:7 mwolfe]:
 > Tor 9.0a6 is able to comment on the Independent website! Fixed at last!
 Thanks to the move to 68 ESR. This seems to have been a Firefox issue.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31673 [Core Tor/Tor]: Deprecated use of

2019-09-09 Thread Tor Bug Tracker & Wiki
#31673: Deprecated use of 
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  035-backport 040-backport|  Actual Points:
  041-backport   |
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
-+-

Comment (by nickm):

 I'm not sure whether removing the HAVE_SYS_SYSCTL_H is correct for all the
 other places we build (ios, etc).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31292 [Core Tor/Tor]: please sign Tor releases with an OpenPGP tool that includes Issuer Fingerprint subpackets

2019-09-09 Thread Tor Bug Tracker & Wiki
#31292: please sign Tor releases with an OpenPGP tool that includes Issuer
Fingerprint subpackets
--+
 Reporter:  dkg   |  Owner:  nickm
 Type:  task  | Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  release   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  accepted => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31673 [Core Tor/Tor]: Deprecated use of

2019-09-09 Thread Tor Bug Tracker & Wiki
#31673: Deprecated use of 
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  035-backport 040-backport|  Actual Points:
  041-backport   |
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
-+-
Changes (by dgoulet):

 * keywords:  035-backport 040-backport 041-backport 042-should easy =>
 035-backport 040-backport 041-backport
 * reviewer:   => nickm
 * status:  new => needs_review


Comment:

 There is two approach to this I believe. Either we keep
 `HAVE_SYS_SYSCTL_H` but add `!defined(__GLIBC__)` or we just remove this
 entirely and only include it _not_ for LInux/Win32 since most BSD flavors
 still uses it afaict.

 I went with the latter.

 029: https://github.com/torproject/tor/pull/1305
 035: https://github.com/torproject/tor/pull/1307

 035 PR merges forward successfully.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31673 [Core Tor/Tor]: Deprecated use of

2019-09-09 Thread Tor Bug Tracker & Wiki
#31673: Deprecated use of 
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  035-backport 040-backport|  Actual Points:
  041-backport 042-should easy   |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  035-backport 040-backport 041-backport => 035-backport
 040-backport 041-backport 042-should easy


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31601 [Applications/Tor Browser]: Don't let Mozilla recommend extensions again

2019-09-09 Thread Tor Bug Tracker & Wiki
#31601: Don't let Mozilla recommend extensions again
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201909R, tbb-9.0   |  Actual Points:
  -must-alpha, ff68-esr  |
Parent ID:   | Points:  0.25
 Reviewer:   |Sponsor:
-+-
Changes (by acat):

 * keywords:  TorBrowserTeam201909, tbb-9.0-must-alpha, ff68-esr =>
 TorBrowserTeam201909R, tbb-9.0-must-alpha, ff68-esr
 * status:  new => needs_review


Comment:

 Thanks. I think `extensions.htmlaboutaddons.recommendations.enabled` is
 enough.

 `extensions.htmlaboutaddons.discover.enabled` is used in
 [https://searchfox.org/mozilla-
 esr68/source/toolkit/mozapps/extensions/content/extensions.js#854], but
 the old `extensions.getAddons.showPane` should cover that.

 Patch for review: https://www.github.com/acatarineu/tor-
 browser/commit/31601.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31565 [Core Tor/Tor]: static Tor building against openssl-1.1.1 fails: configure unable to find linkable OpenSSL

2019-09-09 Thread Tor Bug Tracker & Wiki
#31565: static Tor building against openssl-1.1.1 fails: configure unable to 
find
linkable OpenSSL
+--
 Reporter:  shredder|  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor:
|  unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor,openssl,1.1.1,static,mingw  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by dgoulet):

 * version:  Tor: unspecified =>
 * milestone:   => Tor: unspecified


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31636 [Core Tor/Tor]: Circuit padding: Add meta probability distribution type

2019-09-09 Thread Tor Bug Tracker & Wiki
#31636: Circuit padding: Add meta probability distribution type
--+--
 Reporter:  mikeperry |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  wtf-pad   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by dgoulet):

 * milestone:   => Tor: unspecified


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31597 [Applications/Tor Browser]: Go over all closed bugs/bugs where patches landed between Firefox 61 and 68 (inclusive)

2019-09-09 Thread Tor Bug Tracker & Wiki
#31597: Go over all closed bugs/bugs where patches landed between Firefox 61 
and 68
(inclusive)
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201909, ff68-esr,  |  Actual Points:
  tbb-9.0-must-alpha, GeorgKoppen201909  |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  TorBrowserTeam201909, ff68-esr, tbb-9.0-alpha-must,
 GeorgKoppen201909 => TorBrowserTeam201909, ff68-esr, tbb-9.0-must-
 alpha, GeorgKoppen201909


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30924 [Core Tor/Tor]: hs-v3: Implement proposal 305 - ESTABLISH_INTRO Cell DoS Defense Extension

2019-09-09 Thread Tor Bug Tracker & Wiki
#30924: hs-v3: Implement proposal 305 -  ESTABLISH_INTRO Cell DoS Defense 
Extension
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tor-spec, prop305, network-  |  Actual Points:
  team-roadmap-august, nickm-merge   |
Parent ID:  #2   | Points:  7
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-

Comment (by dgoulet):

 Replying to [comment:16 nickm]:
 > Okey, I've been through the branch and it looks plausible.  I get
 conflicts when I try to squash the fixup commits, though.  I've tried to
 resolve them in a way that looked plausible to me, but next time, it might
 be better to make sure that there is a final branch when we get the ticket
 to merge_ready.

 Sorry about that...

 >
 > I'm going to make sure that CI passes on my squashed-and-merged branch
 before I merge.  I've got it at
 https://github.com/torproject/tor/pull/1304

 This lgtm. CI feeding...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30924 [Core Tor/Tor]: hs-v3: Implement proposal 305 - ESTABLISH_INTRO Cell DoS Defense Extension

2019-09-09 Thread Tor Bug Tracker & Wiki
#30924: hs-v3: Implement proposal 305 -  ESTABLISH_INTRO Cell DoS Defense 
Extension
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tor-spec, prop305, network-  |  Actual Points:
  team-roadmap-august, nickm-merge   |
Parent ID:  #2   | Points:  7
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-

Comment (by nickm):

 Okey, I've been through the branch and it looks plausible.  I get
 conflicts when I try to squash the fixup commits, though.  I've tried to
 resolve them in a way that looked plausible to me, but next time, it might
 be better to make sure that there is a final branch when we get the ticket
 to merge_ready.

 I'm going to make sure that CI passes on my squashed-and-merged branch
 before I merge.  I've got it at
 https://github.com/torproject/tor/pull/1304

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31630 [Core Tor/Tor]: Remove unused assign/encode functions in structvar.

2019-09-09 Thread Tor Bug Tracker & Wiki
#31630: Remove unused assign/encode functions in structvar.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  asn-merge, dgoulet-merge  |  Actual Points:  0
Parent ID:  #29211| Points:  0
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by dgoulet):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31571 [Core Tor/Tor]: Add the tor version and a newline to raw_assert()

2019-09-09 Thread Tor Bug Tracker & Wiki
#31571: Add the tor version and a newline to raw_assert()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, 042-should, android,|  Actual Points:  0.1
  dgoulet-merge, macos 035-backport  |
  040-backport 041-backport  |
Parent ID:  #31570   | Points:  0.1
 Reviewer:  nickm|Sponsor:
 |  Sponsor31-can
-+-
Changes (by dgoulet):

 * milestone:  Tor: 0.4.2.x-final => Tor: 0.4.1.x-final


Comment:

 Merged PR 1287 to master.

 Moving to 041 milestone for backport.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31673 [Core Tor/Tor]: Deprecated use of

2019-09-09 Thread Tor Bug Tracker & Wiki
#31673: Deprecated use of 
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  035-backport 040-backport
 Severity:  Normal   |  041-backport
Actual Points:   |  Parent ID:
   Points:  0.1  |   Reviewer:
  Sponsor:   |
-+-
 I've been getting warnings since couple days ago:

 {{{
 /usr/include/x86_64-linux-gnu/sys/sysctl.h:21:2: warning: #warning "The
  header is deprecated and will be removed." [-Wcpp]
21 | #warning "The  header is deprecated and will be
 removed."
 }}}

 It is annoying with `enable-gcc-warnings` since it errors.

 I've removed that include and tor builds fine so, as nickm suggested on
 IRC, right solution here is to not include on Linux/Win32 instead of
 `#ifdef HAVE_SYS_SYSCTL_H`.

 I would recommend a backport since if this becomes a problem to build tor
 in the future.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31540 [Internal Services/Tor Sysadmin Team]: Do we want to run a NextCloud instance?

2019-09-09 Thread Tor Bug Tracker & Wiki
#31540: Do we want to run a NextCloud instance?
-+
 Reporter:  ln5  |  Owner:  tpa
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by ln5):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 From the TPA meeting today:

 We're good with B or C for now. We can't give Riseup root so B would need
 to be running as UID != 0, but Riseup prefer to handle the machine
 themselves, so we'll go with C for now.

 gaba is moving this forward from now on.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30045 [Core Tor/Tor]: output of "tor --key-expiration sign" should be a time stamp

2019-09-09 Thread Tor Bug Tracker & Wiki
#30045: output of "tor --key-expiration sign" should be a time stamp
--+
 Reporter:  toralf|  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: 0.4.0.3-alpha
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by toralf):

 In the mean while I do have this
 {{{

 @daily   [[ $(/opt/torutils/key-expires.py
 /var/lib/tor/data/keys/ed25519_signing_cert)  -lt 864000 ]] && echo "Tor
 key is expiring soon"
 @daily   [[ $(/opt/torutils/key-expires.py
 /var/lib/tor/data2/keys/ed25519_signing_cert) -lt 864000 ]] && echo "Tor2
 key is expiring soon"

 # cat /opt/torutils/key-expires.py
 #!/usr/bin/env python3

 # put out the time (in seconds) before the key expires

 import codecs
 import sys
 import time

 # eg.: /var/lib/tor/data2/keys/ed25519_signing_cert
 #
 with open(sys.argv[1], 'rb') as f:
 cert = f.read()
 expire = int(codecs.encode(cert[35:38], 'hex'), 16) * 3600
 now = time.time()
 print(int(expire-now))
 }}}
 which does the job for me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #30045, #31257

2019-09-09 Thread Tor Bug Tracker & Wiki
Batch modification to #30045, #31257 by nickm:
component to Core Tor/Tor

--
Tickets URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31552 [Core Tor/Tor]: --disable-module-dirauth broken (missing symbols)

2019-09-09 Thread Tor Bug Tracker & Wiki
#31552: --disable-module-dirauth broken (missing symbols)
-+-
 Reporter:  LarryBitcoin |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.5
 Severity:  Normal   | Resolution:
 Keywords:  build, configure, features,  |  Actual Points:  .1
  modules, regression|
Parent ID:   | Points:
 Reviewer:  catalyst |Sponsor:
 |  Sponsor31-can
-+-
Changes (by dgoulet):

 * reviewer:   => catalyst


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31552 [Core Tor/Tor]: --disable-module-dirauth broken (missing symbols)

2019-09-09 Thread Tor Bug Tracker & Wiki
#31552: --disable-module-dirauth broken (missing symbols)
-+-
 Reporter:  LarryBitcoin |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.5
 Severity:  Normal   | Resolution:
 Keywords:  build, configure, features,  |  Actual Points:  .1
  modules, regression|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor31-can
-+-
Changes (by dgoulet):

 * component:  Core Tor => Core Tor/Tor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31549 [Core Tor/Tor]: Authorities should stop listing relays running pre-0.2.9, or running 0.3.0 through 0.3.4

2019-09-09 Thread Tor Bug Tracker & Wiki
#31549: Authorities should stop listing relays running pre-0.2.9, or running 
0.3.0
through 0.3.4
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  042-can 041-backport consider-   |  Actual Points:
  backport-after-authority-test consider-|
  backport-after-0421 tor-dirauth tor-   |
  bridgeauth |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by dgoulet):

 Replying to [comment:17 teor]:
 > Ok, so I think there are a few tasks remaining for this ticket:
 > 1. Work out how many bridges are on old versions rejected by this patch

 (Weight is based on the observed bandwidth).

 {{{
 == Bridge - Series ==
 <= 0.2.8 series: 367 [w: 0.78%]
 0.3.0x - 0.3.4.x series: 786 [w: 11.21%]
 }}}

 We have a total of 6813 bridges currently publishing descriptors so we are
 talking about removing ~1153 of them (~17%).

 > 2. Decide if we want this change to apply to the bridge authority at the
 same time as the directory authorities

 I believe so yes.

 > And separately:
 > 3. Check that the default bridges are on 0.3.5 or later

 Only one running bridge is <= 0.3.5.7 from this list:

 https://trac.torproject.org/projects/tor/wiki/doc/TorBrowser/DefaultBridges

 I've contacted the operator:

 
https://metrics.torproject.org/rs.html#details/21D96945B790F10D00071BB3336F0AE9200E5C8C

 Orbot is about to get its Bridge list synced up with the ones in Tor
 Browser:
 https://trac.torproject.org/projects/tor/ticket/30870

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29394 [Internal Services/Tor Sysadmin Team]: Find another authoritative DNS provider

2019-09-09 Thread Tor Bug Tracker & Wiki
#29394: Find another authoritative DNS provider
-+-
 Reporter:  ln5  |  Owner:  anarcat
 Type:  task | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by anarcat):

 * owner:  ln5 => anarcat


Comment:

 we're in talks with greenhost about this, will followup

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28490 [Community/Tor Browser Manual]: tb-manual/secure connections: fancy svg is not working, needs to be fixed or replaced

2019-09-09 Thread Tor Bug Tracker & Wiki
#28490: tb-manual/secure connections: fancy svg is not working, needs to be 
fixed
or replaced
--+-
 Reporter:  emmapeel  |  Owner:  wayward
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Community/Tor Browser Manual  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-
Changes (by ggus):

 * status:  assigned => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28490 [Community/Tor Browser Manual]: tb-manual/secure connections: fancy svg is not working, needs to be fixed or replaced

2019-09-09 Thread Tor Bug Tracker & Wiki
#28490: tb-manual/secure connections: fancy svg is not working, needs to be 
fixed
or replaced
--+--
 Reporter:  emmapeel  |  Owner:  wayward
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Community/Tor Browser Manual  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by ggus):

 Hiro fixed with CSS animation -
 
https://gitweb.torproject.org/project/web/manual.git/commit/?id=49b1c031a6c98631bc5e6776a46ed5d3f47adaff

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30538 [Applications/Tor Browser]: Unable to comment on The Independent Newspaper

2019-09-09 Thread Tor Bug Tracker & Wiki
#30538: Unable to comment on The Independent Newspaper
--+--
 Reporter:  mwolfe|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-usability-website |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by mwolfe):

 Tor 9.0a6 is able to comment on the Independent website! Fixed at last!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31477 [Core Tor/Tor]: Practracker integration tsts for headers and includes

2019-09-09 Thread Tor Bug Tracker & Wiki
#31477: Practracker integration tsts for headers and includes
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  practracker, tech-debt,  |  Actual Points:
  refactoring, easy, 041-deferred-20190530,  |
  network-team-roadmap-july, dgoulet-merge   |
Parent ID:  #29746   | Points:
 Reviewer:  catalyst |Sponsor:
 |  Sponsor31-must
-+-

Comment (by nickm):

 Replying to [comment:5 catalyst]:
 > Replying to [comment:4 nickm]:
 > > The bug is this: I thought that saying that DependencyViolation
 applied to `*` would make it apply to all files -- but practracker doesn't
 support that.  I had to say instead that it applies to `*.h` and `*.c`.
 > I still didn't understand this description, so I looked into
 `practracker.py` and `problem.py`. I'm guessing that `ProblemFilter` needs
 to have its filename patterns be unambiguously denoting either `.c` or
 `.h` files. It looks like `Item.get_file_type()` determines this based on
 the suffix (`.c` or `.h`) of the file or pattern, defaulting to `*.c`. So
 maybe a pattern of `*` would match `*.c` files but not `*.h` files? Does
 this sound like an accurate description of the bug?

 That's right -- the Item.get_file_type() function converts `*` to `*.c`,
 so that it will match .c files, but not .h files.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31608 [Core Tor/Tor]: circuit_state_publish() never triggers when a new origin circuit is created

2019-09-09 Thread Tor Bug Tracker & Wiki
#31608: circuit_state_publish() never triggers when a new origin circuit is 
created
+
 Reporter:  dgoulet |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-circuit tor-pubsub  |  Actual Points:
Parent ID:  #31609  | Points:  0.1
 Reviewer:  |Sponsor:
+

Comment (by nickm):

 (I'm afraid I don't remember the original arguments here either. It may be
 that I was wrong before, or that the original reasoning no longer
 applies.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29998 [Core Tor/Tor]: Objective 1, Activity 1.2: Adopt OnionBalance features into onion services v3

2019-09-09 Thread Tor Bug Tracker & Wiki
#29998: Objective 1, Activity 1.2:  Adopt OnionBalance features into onion 
services
v3
+--
 Reporter:  pili|  Owner:  (none)
 Type:  project | Status:  new
 Priority:  Medium  |  Milestone:  Tor:
|  unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  network-team-roadmap-2019-Q1Q2  |  Actual Points:
Parent ID:  #30281  | Points:  23
 Reviewer:  |Sponsor:
|  Sponsor27-must
+--
Changes (by asn):

 * points:  24 => 23


Comment:

 Updating points now that we now more about this (the child ticket has more
 detailed point breakdown).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26768 [Core Tor/Tor]: Support onionbalance in HSv3

2019-09-09 Thread Tor Bug Tracker & Wiki
#26768: Support onionbalance in HSv3
-+-
 Reporter:  asn  |  Owner:  asn
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance  |  Actual Points:
  network-team-roadmap-september tor-spec|
Parent ID:  #29998   | Points:  10
 Reviewer:   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by asn):

 * points:  5 => 10


Comment:

 Pumping this up to 10 points to account for unforeseen overhead (like
 #31648) and other final touches.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29998 [Core Tor/Tor]: Objective 1, Activity 1.2: Adopt OnionBalance features into onion services v3

2019-09-09 Thread Tor Bug Tracker & Wiki
#29998: Objective 1, Activity 1.2:  Adopt OnionBalance features into onion 
services
v3
+--
 Reporter:  pili|  Owner:  (none)
 Type:  project | Status:  new
 Priority:  Medium  |  Milestone:  Tor:
|  unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  network-team-roadmap-2019-Q1Q2  |  Actual Points:
Parent ID:  #30281  | Points:  20
 Reviewer:  |Sponsor:
|  Sponsor27-must
+--
Changes (by asn):

 * points:  24 => 20


Comment:

 Updating points now that we now more about this (the child ticket has more
 detailed point breakdown).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31652 [Core Tor/Tor]: hs-v3: Service circuit retry limit should not close a valid circuit

2019-09-09 Thread Tor Bug Tracker & Wiki
#31652: hs-v3: Service circuit retry limit should not close a valid circuit
+
 Reporter:  dgoulet |  Owner:  neel
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs tor-circuit  |  Actual Points:
Parent ID:  #30200  | Points:  0.1
 Reviewer:  dgoulet |Sponsor:  Sponsor27-must
+
Changes (by dgoulet):

 * reviewer:  asn => dgoulet


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31354 [Core Tor/Tor]: Compiler "note" in test_addr.c: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’

2019-09-09 Thread Tor Bug Tracker & Wiki
#31354: Compiler "note" in test_addr.c: variable tracking size limit exceeded 
with
‘-fvar-tracking-assignments’
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  regression|  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+
Changes (by dgoulet):

 * reviewer:  #31354 => catalyst


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30527 [Core Tor/Tor]: Fix coverity warnings in test_parsecommon.c

2019-09-09 Thread Tor Bug Tracker & Wiki
#30527: Fix coverity warnings in test_parsecommon.c
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  coverity technical-debt  |  Actual Points:  0
Parent ID:   | Points:  .5
 Reviewer:  #30527   |Sponsor:  Sponsor31-can
-+
Changes (by dgoulet):

 * reviewer:   => #30527


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31570 [Core Tor/Tor]: INTERNAL ERROR: raw assertion failed (core dump) in termux

2019-09-09 Thread Tor Bug Tracker & Wiki
#31570: INTERNAL ERROR: raw assertion failed (core dump) in termux
-+-
 Reporter:  foremtehan   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  042-should, regression?, mmap,   |  Actual Points:  .1
  android, crash |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by dgoulet):

 * reviewer:   => ahf


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

2019-09-09 Thread Tor Bug Tracker & Wiki
#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.2
  consider-backport-if-needed, diagnostics,  |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression, |
  BugSmashFund   |
Parent ID:  #31594   | Points:  0.2
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by dgoulet):

 * reviewer:   => dgoulet


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31354 [Core Tor/Tor]: Compiler "note" in test_addr.c: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’

2019-09-09 Thread Tor Bug Tracker & Wiki
#31354: Compiler "note" in test_addr.c: variable tracking size limit exceeded 
with
‘-fvar-tracking-assignments’
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  regression|  Actual Points:
Parent ID:| Points:
 Reviewer:  #31354|Sponsor:
--+
Changes (by dgoulet):

 * reviewer:   => #31354


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

  1   2   >