Re: [tor-bugs] #32165 [Core Tor/Tor]: On first boot, Tor mistakenly tells me "The current consensus has no exit nodes"

[Tor Bug Tracker & Wiki]

#32165: On first boot, Tor mistakenly tells me "The current consensus has no 
exit
nodes"
--+
 Reporter:  arma  |  Owner:  (none)
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  bootstrap |  Actual Points:
Parent ID:| Points:
 Reviewer:  ahf   |Sponsor:
--+

Comment (by arma):

 Replying to [comment:9 teor]:
 > We've switched this check a few times, and it breaks different things
 each time.
 > So we need to be very careful about this change.
 > I'm not sure if it is correct.
 > Please check the history of changes to this line.

 Ok, there have been three changes to this line:

 The original commit, 9b2d106e4, which documented np and nu clearly (yay)
 but got their meanings reversed (oops).

 Nick's fix in #14918, which went in as commit 8eb3d81e6: it clarified the
 function comment in count_usable_descriptors (yay), fixed np to nu as it
 should, but left the (still wrong) comments explaining np and nu in place
 (oops).

 teor's update for #27236, which went in as commit 3ebbc1c84, which
 reintroduced the np vs nu bug.

 I just checked num_present vs num_usable again, and I am confident that
 the fix in 94cb4f8 (which was the same fix as 8eb3d81e6) is right:
 num_usable is how many are in the consensus that we would use, and
 num_present is how many of those we actually have descriptors for right
 now. So on first boot, when we have no descriptors present, we must check
 nu, not np, or we will wrongly conclude that we have a consensus with no
 exits.

 Now, #27236 speaks of internal-only onion service networks and chutney.
 But I don't see how commit 3ebbc1c8 does anything about those -- it
 essentially just reverts Nick's fix. I'm guessing it has something to do
 with the nearby commit 588c7767. It looks like that commit is trying to
 make sure that at least one relay in the consensus can exit to at least
 one port. Makes sense -- but it appears to accidentally also be checking
 that *we have a local descriptor* for such a relay. Can you help me
 understand what exactly we need to check for, in the "internal-only onion
 service networks and chutney" case? We shouldn't merge this new patch
 until we understand the chutney requirements better.

 > We also need to change variable names, log messages, and documentation,
 see:
 > https://trac.torproject.org/projects/tor/ticket/27448#comment:3

 Yes, I agree. I'll give this a go if you like my proposed name changes
 above: "present" -> "ready" and "usable" -> "listed". (I figure going
 through and doing it for the wrong names isn't a good use of anybody's
 time.)

 Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31992 [Applications/Tor Browser]: Remove apktool workaround in #31564

[Tor Bug Tracker & Wiki]

#31992: Remove apktool workaround in #31564
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:  0.25
 Reviewer:|Sponsor:
--+--

Comment (by sisbell):

 I tried installing apktool when building the container. I download it

 https://deb.debian.org/debian/pool/main/a/apktool/apktool_2.4.0-1_all.deb

 and use

 {{{
 dpkg -i ./apktool_2.4.0-1_all.deb
 }}}


 I get a bunch of missing dependencies so I'm not sure this is the simplest
 approach

 {{{
 apt version: 1.8.2
 Selecting previously unselected package apktool.
 (Reading database ... 4868 files and directories currently installed.)
 Preparing to unpack ./apktool_2.4.0-1_all.deb ...
 Unpacking apktool (2.4.0-1) ...
 dpkg: dependency problems prevent configuration of apktool:
  apktool depends on aapt; however:
   Package aapt is not installed.
  apktool depends on android-framework-res; however:
   Package android-framework-res is not installed.
  apktool depends on default-jre-headless | java8-runtime-headless;
 however:
   Package default-jre-headless is not installed.
   Package java8-runtime-headless is not installed.
  apktool depends on libantlr3-runtime-java; however:
   Package libantlr3-runtime-java is not installed.
  apktool depends on libcommons-cli-java; however:
   Package libcommons-cli-java is not installed.
  apktool depends on libcommons-io-java; however:
   Package libcommons-io-java is not installed.
  apktool depends on libcommons-lang3-java; however:
   Package libcommons-lang3-java is not installed.
  apktool depends on libguava-java; however:
   Package libguava-java is not installed.
  apktool depends on libsmali-java (>= 2.2.1); however:
   Package libsmali-java is not installed.
  apktool depends on libstringtemplate-java; however:
   Package libstringtemplate-java is not installed.
  apktool depends on libxmlunit-java; however:
   Package libxmlunit-java is not installed.
  apktool depends on libxpp3-java; however:
   Package libxpp3-java is not installed.
  apktool depends on libyaml-snake-java; however:
   Package libyaml-snake-java is not installed.

 dpkg: error processing package apktool (--install):
  dependency problems - leaving unconfigured
 Errors were encountered while processing:
  apktool

 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27448 [Core Tor/Tor]: router_have_consensus_path() logs an incorrect "no exits in consensus"

[Tor Bug Tracker & Wiki]

#27448: router_have_consensus_path() logs an incorrect "no exits in consensus"
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.4.7-rc
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, teor-backlog-fast-fix  |  Actual Points:
Parent ID:  #32165   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arma):

 Oh, I didn't know about this ticket. Great. Please close one of them as a
 duplicate, and we can proceed on whichever one remains.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32165 [Core Tor/Tor]: On first boot, Tor mistakenly tells me "The current consensus has no exit nodes"

[Tor Bug Tracker & Wiki]

#32165: On first boot, Tor mistakenly tells me "The current consensus has no 
exit
nodes"
--+
 Reporter:  arma  |  Owner:  (none)
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  bootstrap |  Actual Points:
Parent ID:| Points:
 Reviewer:  ahf   |Sponsor:
--+

Comment (by teor):

 We've switched this check a few times, and it breaks different things each
 time.
 So we need to be very careful about this change.
 I'm not sure if it is correct.
 Please check the history of changes to this line.

 We also need to change variable names, log messages, and documentation,
 see:
 https://trac.torproject.org/projects/tor/ticket/27448#comment:3

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27448 [Core Tor/Tor]: router_have_consensus_path() logs an incorrect "no exits in consensus"

[Tor Bug Tracker & Wiki]

#27448: router_have_consensus_path() logs an incorrect "no exits in consensus"
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.4.7-rc
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, teor-backlog-fast-fix  |  Actual Points:
Parent ID:  #32165   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * parent:   => #32165


Comment:

 #32165 is a duplicate, with less information. I'll copy the information
 across.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32165 [Core Tor/Tor]: On first boot, Tor mistakenly tells me "The current consensus has no exit nodes"

[Tor Bug Tracker & Wiki]

#32165: On first boot, Tor mistakenly tells me "The current consensus has no 
exit
nodes"
--+
 Reporter:  arma  |  Owner:  (none)
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  bootstrap |  Actual Points:
Parent ID:| Points:
 Reviewer:  ahf   |Sponsor:
--+

Comment (by arma):

 https://github.com/torproject/tor/pull/1442 is my shiny new github pr.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32178 [Core Tor/Tor]: Tor adds trailing space character to log events

[Tor Bug Tracker & Wiki]

#32178: Tor adds trailing space character to log events
--+--
 Reporter:  arma  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:  easy intro|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by nickm):

 * keywords:   => easy intro
 * severity:  Normal => Minor
 * milestone:   => Tor: unspecified


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32106 [Core Tor/Tor]: tor man page should clarify that KBytes is 1024 bytes

[Tor Bug Tracker & Wiki]

#32106: tor man page should clarify that KBytes is 1024 bytes
--+
 Reporter:  arma  |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  manpage, tor-doc  |  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+
Changes (by nickm):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27903 [Applications/Tor Browser]: Tor Browser 8 does not respect gtk3 settings

[Tor Bug Tracker & Wiki]

#27903: Tor Browser 8 does not respect gtk3 settings
+--
 Reporter:  gk  |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by cypherpunks):

 Can confirm that running {{{GSETTINGS_BACKEND=memory ./start-tor-
 browser}}} fixes it. Using firejail with {{{--nodbus}}} option also works.

 I propose that the {{{GSETTINGS_BACKEND}}} fix above be added to the
 start-tor-browser script which also sets and exports HOME.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32106 [Core Tor/Tor]: tor man page should clarify that KBytes is 1024 bytes

[Tor Bug Tracker & Wiki]

#32106: tor man page should clarify that KBytes is 1024 bytes
--+
 Reporter:  arma  |  Owner:  (none)
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  manpage, tor-doc  |  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+

Comment (by arma):

 shiny new github pull request is at
 https://github.com/torproject/tor/pull/1439

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32164 [Applications/Tor Browser]: "View the Tor logs" puts an extra space at the end of each log line

[Tor Bug Tracker & Wiki]

#32164: "View the Tor logs" puts an extra space at the end of each log line
-+-
 Reporter:  arma |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  needs_review
 Priority:  Low  |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-9.0-issues, tbb-9.0.1-can,   |  Actual Points:
  TorBrowserTeam201910R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arma):

 Replying to [comment:6 arma]:
 > I will open a ticket for Tor to stop doing it.

 Ok this Tor bug is #32178.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32178 [Core Tor/Tor]: Tor adds trailing space character to log events

[Tor Bug Tracker & Wiki]

#32178: Tor adds trailing space character to log events
--+
 Reporter:  arma  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 First noticed in #32164, where Tor Browser's "view of Tor logs" has a
 bonus space at the end of every line.

 I believe it's Tor adding the space. This super simple hack:
 {{{
 diff --git a/src/feature/control/control_events.c
 b/src/feature/control/control_events.c
 index 82ea943999..5ddfffeee8 100644
 --- a/src/feature/control/control_events.c
 +++ b/src/feature/control/control_events.c
 @@ -1328,6 +1328,7 @@ control_event_logmsg(int severity, log_domain_mask_t
 domain, const char *msg)
default: s = "UnknownLogSeverity"; break;
  }
  ++disable_log_messages;
 +printf("Sending \"650 %s %s\"\n", s, b?b:msg);
  send_control_event(event,  "650 %s %s\r\n", s, b?b:msg);
  if (severity == LOG_ERR) {
/* Force a flush, since we may be about to die horribly */
 }}}

 shows it:

 {{{
 Sending "650 INFO circuit_free_(): Circuit 0 (id: 4) has been freed. "
 }}}

 I believe it comes from this snippet in control_event_logmsg():
 {{{
 if (strchr(msg, '\n')) {
   char *cp;
   b = tor_strdup(msg);
   for (cp = b; *cp; ++cp)
 if (*cp == '\r' || *cp == '\n')
   *cp = ' ';
 }
 }}}

 That is, we send in log lines that have \n in them, and the function
 helpfully turns the \n into a ' '.

 Bug went into Tor 0.1.1.1-alpha in commit c2f6fe9b (way back in the days
 of the v0 control protocol).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29603 [Core Tor/Tor]: Make a script that sets up worktrees for the git-* merge scripts

[Tor Bug Tracker & Wiki]

#29603: Make a script that sets up worktrees for the git-* merge scripts
--+
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  git-scripts   |  Actual Points:  0.5
Parent ID:| Points:  1
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32121 [Core Tor/Tor]: Refactor some common configs and functions out of the git scripts.

[Tor Bug Tracker & Wiki]

#32121: Refactor some common configs and functions out of the git scripts.
--+--
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  git-scripts   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by teor):

 * parent:  #29603 =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32122 [Core Tor/Tor]: Add tests for the git scripts

[Tor Bug Tracker & Wiki]

#32122: Add tests for the git scripts
--+--
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  git-scripts   |  Actual Points:
Parent ID:  #32121| Points:
 Reviewer:|Sponsor:
--+--
Changes (by teor):

 * parent:  #29603 => #32121


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32164 [Applications/Tor Browser]: "View the Tor logs" puts an extra space at the end of each log line

[Tor Bug Tracker & Wiki]

#32164: "View the Tor logs" puts an extra space at the end of each log line
-+-
 Reporter:  arma |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  needs_review
 Priority:  Low  |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-9.0-issues, tbb-9.0.1-can,   |  Actual Points:
  TorBrowserTeam201910R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arma):

 Ok, it looks like Tor is adding the trailing whitespace.

 So, yes, please trim it on the Tor Browser side, and I will open a ticket
 for Tor to stop doing it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32172 [Core Tor/Tor]: port test suite to Android to run in emulator

[Tor Bug Tracker & Wiki]

#32172: port test suite to Android to run in emulator
-+
 Reporter:  eighthave|  Owner:  (none)
 Type:  task | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  Android, tbb-mobile  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  nickm|Sponsor:
-+

Comment (by teor):

 iOS also has a similar restriction on /tmp, apps get their own container
 directory with their own tmp.
 
https://developer.apple.com/library/archive/documentation/FileManagement/Conceptual/FileSystemProgrammingGuide/FileSystemOverview/FileSystemOverview.html

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32175 [Core Tor/Tor]: test_options.c uses some very wonky options objects.

[Tor Bug Tracker & Wiki]

#32175: test_options.c uses some very wonky options objects.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .2
Parent ID:  #31241| Points:
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by teor):

 * reviewer:   => teor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32175 [Core Tor/Tor]: test_options.c uses some very wonky options objects.

[Tor Bug Tracker & Wiki]

#32175: test_options.c uses some very wonky options objects.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .2
Parent ID:  #31241| Points:
 Reviewer:|Sponsor:  Sponsor31-can
--+
Changes (by teor):

 * status:  needs_review => merge_ready
 * reviewer:  teor =>


Comment:

 Looks great, I am so happy we are finally cleaning up these tests.

 Some of the mass replaces would have been better as scripts, but they all
 look fine.

 Ready for merge, as soon as CI passes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32175 [Core Tor/Tor]: test_options.c uses some very wonky options objects.

[Tor Bug Tracker & Wiki]

#32175: test_options.c uses some very wonky options objects.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .2
Parent ID:  #31241| Points:
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by nickm):

 * status:  assigned => needs_review
 * reviewer:   => teor


Comment:

 Yeah, it's still waiting.  Are you okay reviewing this one, teor?
 Tentatively putting you on it.  Once this and #31999 are in, I can make
 more progress on options_validate cleanup.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32164 [Applications/Tor Browser]: "View the Tor logs" puts an extra space at the end of each log line

[Tor Bug Tracker & Wiki]

#32164: "View the Tor logs" puts an extra space at the end of each log line
-+-
 Reporter:  arma |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  needs_review
 Priority:  Low  |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-9.0-issues, tbb-9.0.1-can,   |  Actual Points:
  TorBrowserTeam201910R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arma):

 * cc: atagar (added)


Comment:

 Replying to [comment:4 pospeselr]:
 > The log message we receive from tor all seem to have a trailing space.

 Gosh. That shouldn't be happening. We should put a bit of energy into
 learning why it happens, rather than just trimming it and leaving the
 weirdness in place.

 Option one, Tor is somehow including a trailing space in its log events.
 If so, we should stop. Option two, Tor Launcher is somehow adding a
 trailing space when it receives the log events.

 Does Tor Launcher see trailing spaces on events of other kinds?

 I am cc'ing atagar since he either dealt with this in stem, or has no idea
 what we're talking about.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32177 [Core Tor/Tor]: Travis: Consider deleting allow_failure macOS jobs

[Tor Bug Tracker & Wiki]

#32177: Travis: Consider deleting allow_failure macOS jobs
--+
 Reporter:  teor  |  Owner:  teor
 Type:  defect| Status:  assigned
 Priority:  High  |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Major |   Keywords:  tor-ci-slow
Actual Points:|  Parent ID:
   Points:  0.1   |   Reviewer:
  Sponsor:|
--+
 When we backport, our builds are slow, because Travis doesn't have a lot
 of macOS builders.

 If this issue continues, we should delete (or comment out) the
 allow_failure macOS jobs.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32175 [Core Tor/Tor]: test_options.c uses some very wonky options objects.

[Tor Bug Tracker & Wiki]

#32175: test_options.c uses some very wonky options objects.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .2
Parent ID:  #31241| Points:
 Reviewer:|Sponsor:  Sponsor31-can
--+

Comment (by teor):

 CI seems slow, I opened #32177.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31764 [Applications/Tor Browser]: Copying a link and using "Paste & Go" results in error

[Tor Bug Tracker & Wiki]

#31764: Copying a link and using "Paste & Go" results in error
-+-
 Reporter:  gk   |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-issues, tbb-   |  Actual Points:
  regression, tbb-9.0.1-can, |
  TorBrowserTeam201910R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by pospeselr):

 * status:  assigned => needs_review
 * keywords:  ff68-esr, tbb-9.0-issues, tbb-regression, tbb-9.0.1-can =>
 ff68-esr, tbb-9.0-issues, tbb-regression, tbb-9.0.1-can,
 TorBrowserTeam201910R


Comment:

 Very small patch fixes this, but took a bit to understand what's going on
 here.

 Basically we just have to explicitly pass null to _loadURL for the
 'result' parameter. Another adjacent code-path already does this in the
 case where we are providing a 'pseudo-url' like example.com (via paste or
 through a complicated UI flow using the keyboard) where it first must
 prepend !http://www or whatever to it before calling _loadURL (which it
 does with a null 'result' parameter).

 tor-browser: https://gitweb.torproject.org/user/richard/tor-
 browser.git/commit/?h=bug_31764

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31999 [Core Tor/Tor]: Default log file is handled inconsistently

[Tor Bug Tracker & Wiki]

#31999: Default log file is handled inconsistently
--+
 Reporter:  nickm |  Owner:  (none)
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  1.5
Parent ID:  #31241| Points:
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by teor):

 * status:  needs_review => merge_ready


Comment:

 Looks good, I'll merge it later today, if no-one else gets to it first :-)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #10059 [Core Tor/Tor]: capture tor log messages before control connection is opened

[Tor Bug Tracker & Wiki]

#10059: capture tor log messages before control connection is opened
-+-
 Reporter:  mcs  |  Owner:  (none)
 Type:  enhancement  | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, extdev-interview, |  Actual Points:
  tbb-needs, 034-triage-20180328,|
  035-removed-20180711   |
Parent ID:  #9675| Points:  3
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 We may also need a setting that limits the number of stored log messages,
 and the log level that is stored.

 For example:
 {{{
 ControlSaveLogEvents Notice 1000
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31653 [Core Tor/Tor]: Padding cells sent with 0ms delay cause circuit failures

[Tor Bug Tracker & Wiki]

#31653: Padding cells sent with 0ms delay cause circuit failures
-+-
 Reporter:  pulls|  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.5
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad circpad-researchers-want |  Actual Points:
  042-should |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mikeperry):

 Bleh. It is unfortunate that clients need more accurate timers than
 relays.

 1. Do you have any sense as to if client-side timing is more important
 because most test crawls tend to use client-side timings as opposed to
 guard-side timings (and thus inherently get very high client-side timing
 resolution and visibility into Firefox delays), or because of something
 else that is just inherent to the HTTP protocol?

 2. If I were to write a patch that allowed either clients or relays to
 correctly fast-path this 0ms case to insert bursts of back-to-back packets
 without the circuit failure, would that help?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21952 [Applications/Tor Browser]: Onion-location: increasing the use of onion services through automatic redirects and aliasing

[Tor Bug Tracker & Wiki]

#21952: Onion-location: increasing the use of onion services through automatic
redirects and aliasing
-+-
 Reporter:  linda|  Owner:  tbb-
 |  team
 Type:  project  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team, tor-hs, network-team-   |  Actual Points:
  roadmap-november, TorBrowserTeam201911,|
  tbb-9.5|
Parent ID:  #30024   | Points:  6
 Reviewer:   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by sysrqb):

 * keywords:  ux-team, tor-hs, network-team-roadmap-november,
 TorBrowserTeam201911 =>
 ux-team, tor-hs, network-team-roadmap-november, TorBrowserTeam201911,
 tbb-9.5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31918 [Applications/Tor Browser]: Rebase and squash mobile/android patches into desktop

[Tor Bug Tracker & Wiki]

#31918: Rebase and squash mobile/android patches into desktop
---+--
 Reporter:  sysrqb |  Owner:  tbb-team
 Type:  task   | Status:  new
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorBrowserTeam201911, tbb-9.5  |  Actual Points:
Parent ID: | Points:  1
 Reviewer: |Sponsor:
---+--
Changes (by sysrqb):

 * keywords:  TorBrowserTeam201910, tbb-9.0 => TorBrowserTeam201911, tbb-9.5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26844 [Applications/Tor Browser]: TBA: Investigate/Setup Fastlane

[Tor Bug Tracker & Wiki]

#26844: TBA: Investigate/Setup Fastlane
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-9.5, |  Actual Points:
  TorBrowserTeam201911   |
Parent ID:  #26782   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * keywords:  tbb-mobile, tbb-8.5, TorBrowserTeam201908 => tbb-mobile,
 tbb-9.5, TorBrowserTeam201911


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27539 [Applications/Tor Browser]: Create plan for releasing on F-Droid

[Tor Bug Tracker & Wiki]

#27539: Create plan for releasing on F-Droid
-+-
 Reporter:  sysrqb   |  Owner:  sysrqb
 Type:  enhancement  | Status:
 |  accepted
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-9.5, |  Actual Points:
  TorBrowserTeam201911   |
Parent ID:  #26318   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by sysrqb):

 * keywords:  tbb-mobile, tbb-8.5, TorBrowserTeam201908 => tbb-mobile,
 tbb-9.5, TorBrowserTeam201911


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30570 [Applications/Tor Browser]: Implement per-site security settings support

[Tor Bug Tracker & Wiki]

#30570: Implement per-site security settings support
-+-
 Reporter:  gk   |  Owner:
 |  pospeselr
 Type:  enhancement  | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team, TorBrowserTeam201911,   |  Actual Points:
  tbb-9.5|
Parent ID:  #25658   | Points:  10
 Reviewer:   |Sponsor:
 |  Sponsor9
-+-
Changes (by sysrqb):

 * keywords:  ux-team, TorBrowserTeam201910 => ux-team,
 TorBrowserTeam201911, tbb-9.5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29603 [Core Tor/Tor]: Make a script that sets up worktrees for the git-* merge scripts

[Tor Bug Tracker & Wiki]

#29603: Make a script that sets up worktrees for the git-* merge scripts
--+
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  git-scripts   |  Actual Points:  0.5
Parent ID:| Points:  1
 Reviewer:  dgoulet   |Sponsor:
--+

Comment (by nickm):

 Merged to master.  Please close this ticket after closing or unparenting
 the child tickets as appropriate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32086 [Core Tor/Tor]: Try Visual Studio 2019 image in appveyor

[Tor Bug Tracker & Wiki]

#32086: Try Visual Studio 2019 image in appveyor
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci, consider-backport-   |  implemented
  immediately, 035-backport, 040-backport,   |  Actual Points:  0.1
  041-backport, 042-backport |
Parent ID:   | Points:  0.1
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Merged to 0.3.5 and forward.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31660 [Applications/Tor Browser]: Revise onboarding to take new Firefox experience into account

[Tor Bug Tracker & Wiki]

#31660: Revise onboarding to take new Firefox experience into account
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team, TorBrowserTeam201911,   |  Actual Points:
  tbb-9.5|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * keywords:  ux-team => ux-team, TorBrowserTeam201911, tbb-9.5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31882 [Core Tor/Tor]: move Android build config into core tor

[Tor Bug Tracker & Wiki]

#31882: move Android build config into core tor
-+
 Reporter:  eighthave|  Owner:  (none)
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  Android, tbb-mobile  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  nickm|Sponsor:
-+

Comment (by eighthave):

 I included the gitlab-ci changes there to make it easy to see which run
 matches the pull request.  They could be merged separately, if that's
 easier.  That's why I included all those commits on top of the code
 changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32172 [Core Tor/Tor]: port test suite to Android to run in emulator

[Tor Bug Tracker & Wiki]

#32172: port test suite to Android to run in emulator
-+
 Reporter:  eighthave|  Owner:  (none)
 Type:  task | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  Android, tbb-mobile  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  nickm|Sponsor:
-+

Comment (by eighthave):

 I haven't even tried to use `make check` here, that will take a chunk of
 work.  I assume that's where the python detection is.  I'm just directly
 calling the test executables after copying them to the emulator, like
 this:
 {{{
 adb -e shell /data/local/tmp/test
 adb -e shell /data/local/tmp/test-memwipe
 adb -e shell /data/local/tmp/test-slow
 }}}

 From my very vague understanding of the all the bits of the test suite,
 I'm guessing there will be some that won't be worth porting to run in the
 Android emulator.  So I think the question now is: what parts must be
 ported to have decent coverage?  What parts are you worried about?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32164 [Applications/Tor Browser]: "View the Tor logs" puts an extra space at the end of each log line

[Tor Bug Tracker & Wiki]

#32164: "View the Tor logs" puts an extra space at the end of each log line
-+-
 Reporter:  arma |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  needs_review
 Priority:  Low  |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-9.0-issues, tbb-9.0.1-can,   |  Actual Points:
  TorBrowserTeam201910R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by pospeselr):

 * status:  assigned => needs_review
 * keywords:  tbb-9.0-issues, tbb-9.0.1-can => tbb-9.0-issues,
 tbb-9.0.1-can, TorBrowserTeam201910R


Comment:

 The log message we receive from tor all seem to have a trailing space.
 This patch trims() the message before appendnig it to the log.

 tor-launcher: https://gitweb.torproject.org/user/richard/tor-
 launcher.git/commit/?h=bug_32164

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32176 [Core Tor/Tor]: tor manpage: reword FILES and back matter

[Tor Bug Tracker & Wiki]

#32176: tor manpage: reword FILES and back matter
-+-
 Reporter:  catalyst |  Owner:
 |  catalyst
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  gsod, tor-doc, documentation,|  Actual Points:
  manpage|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by catalyst):

 * status:  assigned => needs_review


Comment:

 See my pull request https://github.com/torproject/tor/pull/1437. This
 incorporates most of Swati's content changes in these sections, and makes
 a few minor corrections. Also addresses Nick's issues on
 https://github.com/torproject/tor/pull/1391.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32172 [Core Tor/Tor]: port test suite to Android to run in emulator

[Tor Bug Tracker & Wiki]

#32172: port test suite to Android to run in emulator
-+
 Reporter:  eighthave|  Owner:  (none)
 Type:  task | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  Android, tbb-mobile  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  nickm|Sponsor:
-+
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Good start!  I've left a couple of comments on the PR.  Additionally this
 needs a changes file.

 WRT the other suggestions:
   * We already disable the python tests when python isn't found.  Is there
 a place where we forget to do that?
   * I'm okay porting our shell scripts to a more generic sh, so long as
 shellcheck still passes.
   * I don't know what to do with the third one; maybe there's a way to
 make autoconf and automake override this?  Is there a `/usr/bin/env sh` we
 could use?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31803 [Applications/Tor Browser]: branding for about:debugging needs logo SVG

[Tor Bug Tracker & Wiki]

#31803: branding for about:debugging needs logo SVG
-+-
 Reporter:  mcs  |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, ux-team, tbb-9.0-issues,   |  Actual Points:
  TorBrowserTeam201910R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by pospeselr):

 * keywords:  ff68-esr, ux-team, tbb-9.0-issues => ff68-esr, ux-team,
 tbb-9.0-issues, TorBrowserTeam201910R
 * status:  assigned => needs_review


Comment:

 swapped out the icon with the flat one used in about:preferences

 tor-browser: https://gitweb.torproject.org/user/richard/tor-
 browser.git/commit/?h=bug_31803

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31882 [Core Tor/Tor]: move Android build config into core tor

[Tor Bug Tracker & Wiki]

#31882: move Android build config into core tor
-+
 Reporter:  eighthave|  Owner:  (none)
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  Android, tbb-mobile  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  nickm|Sponsor:
-+
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 I've had a look over the changes, except for the gitlab CI stuff which I'm
 not competent to evaluate.  Since others asked for that, maybe they could
 weigh in whether it seems right to them?  (I was about to suggest doing
 gitlab CI in a separate branch, but I see that somebody else requested it,
 so I probably should defer to them.)

 I've left some comments on the PR.  Additionally, this needs a file in the
 changes/* directory to explain what it is when we generate the changelog.
 The doc/HACKING/CodingStandards.md file explains how those look.

 Please let me know if you have any questions. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32164 [Applications/Tor Browser]: "View the Tor logs" puts an extra space at the end of each log line

[Tor Bug Tracker & Wiki]

#32164: "View the Tor logs" puts an extra space at the end of each log line
---+---
 Reporter:  arma   |  Owner:  pospeselr
 Type:  defect | Status:  assigned
 Priority:  Low|  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-9.0-issues, tbb-9.0.1-can  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by boklm):

 * cc: tbb-team (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31764 [Applications/Tor Browser]: Copying a link and using "Paste & Go" results in error

[Tor Bug Tracker & Wiki]

#31764: Copying a link and using "Paste & Go" results in error
-+-
 Reporter:  gk   |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-issues, tbb-   |  Actual Points:
  regression, tbb-9.0.1-can  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * cc: tbb-team (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32172 [Core Tor/Tor]: port test suite to Android to run in emulator

[Tor Bug Tracker & Wiki]

#32172: port test suite to Android to run in emulator
-+
 Reporter:  eighthave|  Owner:  (none)
 Type:  task | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  Android, tbb-mobile  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  nickm|Sponsor:
-+
Changes (by nickm):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32172 [Core Tor/Tor]: port test suite to Android to run in emulator

[Tor Bug Tracker & Wiki]

#32172: port test suite to Android to run in emulator
-+
 Reporter:  eighthave|  Owner:  (none)
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  Android, tbb-mobile  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  nickm|Sponsor:
-+
Changes (by nickm):

 * reviewer:   => nickm
 * milestone:   => Tor: 0.4.3.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31764 [Applications/Tor Browser]: Copying a link and using "Paste & Go" results in error

[Tor Bug Tracker & Wiki]

#31764: Copying a link and using "Paste & Go" results in error
-+-
 Reporter:  gk   |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-issues, tbb-   |  Actual Points:
  regression, tbb-9.0.1-can  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by pospeselr):

 * owner:  tbb-team => pospeselr
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31803 [Applications/Tor Browser]: branding for about:debugging needs logo SVG

[Tor Bug Tracker & Wiki]

#31803: branding for about:debugging needs logo SVG
---+---
 Reporter:  mcs|  Owner:  pospeselr
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ff68-esr, ux-team, tbb-9.0-issues  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by pospeselr):

 * owner:  antonela => pospeselr


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32164 [Applications/Tor Browser]: "View the Tor logs" puts an extra space at the end of each log line

[Tor Bug Tracker & Wiki]

#32164: "View the Tor logs" puts an extra space at the end of each log line
---+---
 Reporter:  arma   |  Owner:  pospeselr
 Type:  defect | Status:  assigned
 Priority:  Low|  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-9.0-issues, tbb-9.0.1-can  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by pospeselr):

 * owner:  tbb-team => pospeselr
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32176 [Core Tor/Tor]: tor manpage: reword FILES and back matter

[Tor Bug Tracker & Wiki]

#32176: tor manpage: reword FILES and back matter
-+-
 Reporter:   |  Owner:  catalyst
  catalyst   |
 Type:   | Status:  assigned
  enhancement|
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core |Version:
  Tor/Tor|   Keywords:  gsod, tor-doc, documentation,
 Severity:  Normal   |  manpage
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Incorporate most of the rewording changes from #31943 for the FILES, SEE
 ALSO, and BUGS sections of the tor.1.txt manpage.

 Includes some formatting changes to make file names display with fixed-
 width font in the HTML version.

 Also delete a redundant entry for DataDirectory/approved-routers.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27903 [Applications/Tor Browser]: Tor Browser 8 does not respect gtk3 settings

[Tor Bug Tracker & Wiki]

#27903: Tor Browser 8 does not respect gtk3 settings
+--
 Reporter:  gk  |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by cypherpunks):

 dconf has a partial client/server architecture. It uses D-Bus. '''The
 server is only involved in writes''' (and is not activated in the user
 session until the user modifies a preference).

 A "user-db" line specifies a user database. These databases are found in
 $XDG_CONFIG_HOME/dconf/. The name of the file to open in that directory is
 exactly as it is written in the profile. This file is expected to be in
 the binary dconf database format. '''Note that XDG_CONFIG_HOME cannot be
 set/modified per terminal or session, because then the writer and reader
 would be working on different DBs''' (the writer is started by DBus and
 cannot see that variable).


 We can isolate Tor Browser from dconf-service:
 {{{
 export GSETTINGS_BACKEND=memory
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32133 [Internal Services/Service - git]: gitweb.tpo performance problems

[Tor Bug Tracker & Wiki]

#32133: gitweb.tpo performance problems
-+--
 Reporter:  anarcat  |  Owner:  anarcat
 Type:  defect   | Status:  assigned
 Priority:  Immediate|  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Major| Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by anarcat):

 i refactored the puppet stuff to make all those parameters selectable per
 host.

 i think this ticket may be closed in (say) a week if the problem doesn't
 occur again.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32088 [Core Tor/Tor]: Proposal 271 - straightforward improvements

[Tor Bug Tracker & Wiki]

#32088: Proposal 271 - straightforward improvements
--+
 Reporter:  Jaym  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_revision
 Priority:  High  |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-spec prop271  |  Actual Points:
Parent ID:| Points:
 Reviewer:  nickm |Sponsor:
--+
Changes (by nickm):

 * priority:  Medium => High
 * status:  needs_review => needs_revision


Comment:

 Here are some initial comments based on reading the patch and the email,
 based on the assumption that the email is right, and that the patch does
 what the email says it should do.

 Should `next_sampled_idx` persist across runs or be recalculated when we
 load guards?  Right now it seems to start at 0 every time Tor starts.
 Maybe we should also re-calculate the sampled_idx values to be a dense
 array when we save/load the state, so that we aren't leaking more
 information than we intend to.

 The patch will also need:
   * a short proposal.  It can mostly be based on Florentin's email.
   * a patch to guard-spec.txt.
   * tests for the changed behavior.
   * a "changes" file (see doc/HACKING/)
   * editing so that "make check-spaces" passes.
   * Updates to the documentation and names of all the functions whose
 behavior has changed. (For example,
 sample_reachable_filtered_entry_guards` no longer does that the function's
 name implies or the documentation says.)

 How much of that do the original authors want to do, and how much should
 we pick up?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31650 [Applications/Tor Browser]: pre-crunch and pre-strip PNG in tor-service-android to make it reproducible

[Tor Bug Tracker & Wiki]

#31650: pre-crunch and pre-strip PNG in tor-service-android to make it 
reproducible
---+---
 Reporter:  eighthave  |  Owner:  tbb-team
 Type:  enhancement| Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201910R  |  Actual Points:
Parent ID:  #31042 | Points:
 Reviewer: |Sponsor:
---+---

Comment (by sisbell):

 Looks good to me. I can see the pngs updated after running the script. I
 think just adding a small readme to the repo to explain what the script
 does would be helpful.

 Replying to [comment:6 eighthave]:
 > Oh right, but Orbot is included.  It seems in some cases they can be
 reproducibly crunched.  Pre-crunching and disabling the automatic
 crunching ensures that there are no surprises.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32088 [Core Tor/Tor]: Proposal 271 - straightforward improvements

[Tor Bug Tracker & Wiki]

#32088: Proposal 271 - straightforward improvements
--+
 Reporter:  Jaym  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-spec prop271  |  Actual Points:
Parent ID:| Points:
 Reviewer:  nickm |Sponsor:
--+
Changes (by nickm):

 * Attachment "0001-Makes-selection-of-filtered-guards-and-primary-
 guard.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32133 [Internal Services/Service - git]: gitweb.tpo performance problems

[Tor Bug Tracker & Wiki]

#32133: gitweb.tpo performance problems
-+--
 Reporter:  anarcat  |  Owner:  anarcat
 Type:  defect   | Status:  assigned
 Priority:  Immediate|  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Major| Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by anarcat):

 i revert the MaxRequestWorkers down to 75, because during my tests last
 week, 150 would still crash vineale.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31788 [Core Tor/Tor]: Circuit padding trace simulator

[Tor Bug Tracker & Wiki]

#31788: Circuit padding trace simulator
---+
 Reporter:  mikeperry  |  Owner:  (none)
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  circpad-researchers-want, wtf-pad  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by mikeperry):

 Replying to [comment:3 pulls]:
 > The implementation now requires a client and relay trace (got a lazy
 python script to simulate a relay trace from a client trace as well). My
 biggest gripe right now is time. Every time a client/relay machine
 triggers padding, a corresponding event has to be added to the
 relay/client trace with an estimated time. This estimate will always be,
 well, wrong. I'm not sure it's possible to make this estimate in such a
 way that it'll fool time-based classifiers, even if we add in guard traces
 for better estimates and patches as you mention Mike.

 To be clear: I believe this simulator will only be accurate enough to do
 preliminary tuning of defenses against attacks, especially for expensive
 classifiers. I think final attack and defense evaluation, and possibly
 even some final tuning, should be done on the live network. At least until
 we discover that for all of our tested attack+defense combinations, the
 live network and the simulator agree.

 What do you mean by "wrong" though? We should try to make the simulator as
 close as possible. We are aware of the circuitmux problem, as well as
 delay introduced by libevent callbacks. These are both paths we hope we
 can optimize, though. Are there others?

 > Right now I think it might be best as a starting point to just try to
 use the simulator to find optimal machines against attacks like Deep
 Fingerprinting that ignores time. Once we have a better understanding of
 how feasible and costly that is we can look more closely at how time
 changes things.

 Do you mean ignores the time deltas between the client/middles and the
 guard?

 > Any thoughts on this? Have I missed some other reason than time
 estimates for including guard traces?

 Well, I have always assumed that the most realistic adversary for these
 attacks is one that runs them from inside the Tor network, where they have
 much higher resolution over circuit construction and usage, and have full
 circuit multiplexing information.

 We can simulate such an adversary by looking at client traces, or guard
 TLS traces, I suppose.

 > Also, if some other researcher working on this wants to collaborate
 please reach out.

 I now have some time to help with this a bit for the next couple weeks.
 Can you put your work in a branch on github?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32175 [Core Tor/Tor]: test_options.c uses some very wonky options objects.

[Tor Bug Tracker & Wiki]

#32175: test_options.c uses some very wonky options objects.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .2
Parent ID:  #31241| Points:
 Reviewer:|Sponsor:  Sponsor31-can
--+
Changes (by nickm):

 * actualpoints:   => .2


Comment:

 Branch is `bug32175` with PR at
 https://github.com/torproject/tor/pull/1438 .

 It makes test_options.c a few hundred lines shorter.  Will needs_review
 once CI passes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30272 [Applications/Tor Browser]: Gracefully Handle Loss of Connection on Startup

[Tor Bug Tracker & Wiki]

#30272: Gracefully Handle Loss of Connection on Startup
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team, tbb-mobile, tbb-8.5,|  Actual Points:
  TorBrowserTeam201910, Android, iOS |
Parent ID:   | Points:  .5
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  ux-team, tbb-mobile, tbb-8.5, TorBrowserTeam201904, Android,
 iOS => ux-team, tbb-mobile, tbb-8.5, TorBrowserTeam201910, Android,
 iOS


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30570 [Applications/Tor Browser]: Implement per-site security settings support

[Tor Bug Tracker & Wiki]

#30570: Implement per-site security settings support
---+---
 Reporter:  gk |  Owner:  pospeselr
 Type:  enhancement| Status:  assigned
 Priority:  High   |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ux-team, TorBrowserTeam201910  |  Actual Points:
Parent ID:  #25658 | Points:  10
 Reviewer: |Sponsor:  Sponsor9
---+---
Changes (by gk):

 * owner:  tbb-team => pospeselr
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28325 [Applications/Tor Browser]: Use go 1.11 module versioning support

[Tor Bug Tracker & Wiki]

#28325: Use go 1.11 module versioning support
---+--
 Reporter:  boklm  |  Owner:  tbb-team
 Type:  task   | Status:  new
 Priority:  High   |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201911  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by gk):

 * cc: boklm (added)
 * keywords:  tbb-rbm => tbb-rbm, TorBrowserTeam201911


Comment:

 Let's pick this up for November.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21952 [Applications/Tor Browser]: Onion-location: increasing the use of onion services through automatic redirects and aliasing

[Tor Bug Tracker & Wiki]

#21952: Onion-location: increasing the use of onion services through automatic
redirects and aliasing
-+-
 Reporter:  linda|  Owner:  tbb-
 |  team
 Type:  project  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team, tor-hs, network-team-   |  Actual Points:
  roadmap-november, TorBrowserTeam201911 |
Parent ID:  #30024   | Points:  6
 Reviewer:   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by gk):

 * keywords:  ux-team, tor-hs, network-team-roadmap-november => ux-team,
 tor-hs, network-team-roadmap-november, TorBrowserTeam201911
 * cc: acat (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32108 [Core Tor/Tor]: tor can overrun its accountingmax if it enters soft hibernation first

[Tor Bug Tracker & Wiki]

#32108: tor can overrun its accountingmax if it enters soft hibernation first
-+-
 Reporter:  arma |  Owner:  arma
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  network-health 042-backport  |  Actual Points:
  041-backport 040-backport BugSmashFund |
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by gaba):

 * status:  needs_revision => assigned
 * owner:  (none) => arma


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32108 [Core Tor/Tor]: tor can overrun its accountingmax if it enters soft hibernation first

[Tor Bug Tracker & Wiki]

#32108: tor can overrun its accountingmax if it enters soft hibernation first
-+-
 Reporter:  arma |  Owner:  arma
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  network-health 042-backport  |  Actual Points:
  041-backport 040-backport BugSmashFund |
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by gaba):

 * status:  assigned => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32175 [Core Tor/Tor]: test_options.c uses some very wonky options objects.

[Tor Bug Tracker & Wiki]

#32175: test_options.c uses some very wonky options objects.
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:  #31241
   Points: |   Reviewer:
  Sponsor:  Sponsor31-can  |
---+
 In test_options, see this unfortunate comment:

 {{{
   // XXX: Really, all of these options should be set to defaults
   // with options_init(), but about a dozen tests break when I do that.
 }}}

 This is something we need to fix to make the options tests reasonable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32106 [Core Tor/Tor]: tor man page should clarify that KBytes is 1024 bytes

[Tor Bug Tracker & Wiki]

#32106: tor man page should clarify that KBytes is 1024 bytes
--+
 Reporter:  arma  |  Owner:  (none)
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  manpage, tor-doc  |  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 Needs revision for same reason as #32108

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32106 [Core Tor/Tor]: tor man page should clarify that KBytes is 1024 bytes

[Tor Bug Tracker & Wiki]

#32106: tor man page should clarify that KBytes is 1024 bytes
--+
 Reporter:  arma  |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  manpage, tor-doc  |  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+
Changes (by dgoulet):

 * keywords:   => manpage, tor-doc
 * reviewer:   => catalyst


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30272 [Applications/Tor Browser]: Gracefully Handle Loss of Connection on Startup

[Tor Bug Tracker & Wiki]

#30272: Gracefully Handle Loss of Connection on Startup
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team, tbb-mobile, tbb-8.5,|  Actual Points:
  TorBrowserTeam201904, Android, iOS |
Parent ID:   | Points:  .5
 Reviewer:   |Sponsor:
-+-
Changes (by antonela):

 * keywords:  tbb-mobile, tbb-8.5, TorBrowserTeam201904, Android, iOS => ux-
 team, tbb-mobile, tbb-8.5, TorBrowserTeam201904, Android, iOS


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32165 [Core Tor/Tor]: On first boot, Tor mistakenly tells me "The current consensus has no exit nodes"

[Tor Bug Tracker & Wiki]

#32165: On first boot, Tor mistakenly tells me "The current consensus has no 
exit
nodes"
--+
 Reporter:  arma  |  Owner:  (none)
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  bootstrap |  Actual Points:
Parent ID:| Points:
 Reviewer:  ahf   |Sponsor:
--+
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 Needs revision for same reason as #32108

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29603 [Core Tor/Tor]: Make a script that sets up worktrees for the git-* merge scripts

[Tor Bug Tracker & Wiki]

#29603: Make a script that sets up worktrees for the git-* merge scripts
--+
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  git-scripts   |  Actual Points:  0.5
Parent ID:| Points:  1
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by dgoulet):

 * status:  needs_review => merge_ready
 * reviewer:   => dgoulet


Comment:

 I tested it and works super well!

 Good stuff.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32108 [Core Tor/Tor]: tor can overrun its accountingmax if it enters soft hibernation first

[Tor Bug Tracker & Wiki]

#32108: tor can overrun its accountingmax if it enters soft hibernation first
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  network-health 042-backport  |  Actual Points:
  041-backport 040-backport BugSmashFund |
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 I have said this before and I will repeat it here: in the network team we
 use Github to handle "Pull Requests" for internal people in Tor. It is
 okay to not like Github, but that is what we have chosen to use
 nevertheless. For external people we are very flexible. You are in the
 first category.

 We enforce this for the following reasons:

 Firstly, the Github PR system forces the developer (that is you) to watch
 out for the CI (which happens *before* your code lands and *before* you
 ask anybody to review your code. This is unlike our Jenkins CI which
 happens *after* your code have landed. This allows us to catch bugs
 earl(y|ier) and thus makes the quality of Tor a lot better, which is a
 common goal for all of us, hopefully! We even run upfront CI on both
 Windows and Linux, so we catch quite a lot of things by doing this and
 people work hard on making this experience better, more smooth, and faster
 for everyone.

 Secondly, in the network team we all help with the "coding related
 overhead". We do this by distributing the "boring tasks" that is around
 software development between each other, which ensures that everyone is
 having a reasonably "good time". This only works if *everybody* does the
 overhead work for their own stuff themselves. This includes logging into
 Github, opening a PR to torproject/tor, waiting for the PR to have both
 appveyor and travis go "green". If they don't, you have another iteration
 of your code to do. Once your PR is green, you can change status to
 `needs_review` and a nice person from the network team will happily review
 your code.

 So no matter how small or simple a patch it, it still needs to go through
 the Github system for internal people. If you don't do it, someone else
 from the network team will have to do it for you and that is not fair.

 Please resubmit this as a PR and re-request review again! If you need help
 with doing this, we are very open to helping out. Thanks! :-)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31807 [Core Tor/Tor]: Update outdated documentation note for "bridge-distribution"

[Tor Bug Tracker & Wiki]

#31807: Update outdated documentation note for "bridge-distribution"
--+
 Reporter:  phw   |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Low   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:  BugSmashFund 042-can  |  Actual Points:
Parent ID:| Points:  0.2
 Reviewer:  teor  |Sponsor:
--+
Changes (by dgoulet):

 * reviewer:   => teor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31882 [Core Tor/Tor]: move Android build config into core tor

[Tor Bug Tracker & Wiki]

#31882: move Android build config into core tor
-+
 Reporter:  eighthave|  Owner:  (none)
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  Android, tbb-mobile  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  nickm|Sponsor:
-+
Changes (by dgoulet):

 * reviewer:   => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32086 [Core Tor/Tor]: Try Visual Studio 2019 image in appveyor

[Tor Bug Tracker & Wiki]

#32086: Try Visual Studio 2019 image in appveyor
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci, consider-backport-   |  Actual Points:  0.1
  immediately, 035-backport, 040-backport,   |
  041-backport, 042-backport |
Parent ID:   | Points:  0.1
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by dgoulet):

 * status:  needs_review => merge_ready
 * reviewer:   => dgoulet


Comment:

 This makes sense! And simple enough.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32088 [Core Tor/Tor]: Proposal 271 - straightforward improvements

[Tor Bug Tracker & Wiki]

#32088: Proposal 271 - straightforward improvements
--+
 Reporter:  Jaym  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-spec prop271  |  Actual Points:
Parent ID:| Points:
 Reviewer:  nickm |Sponsor:
--+
Changes (by dgoulet):

 * keywords:   => tor-spec prop271
 * reviewer:   => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32103 [Core Tor/Tor]: Subsystem "thread_cleanup" is never called

[Tor Bug Tracker & Wiki]

#32103: Subsystem "thread_cleanup" is never called
--+
 Reporter:  opara |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-should|  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+
Changes (by dgoulet):

 * reviewer:   => catalyst


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32165 [Core Tor/Tor]: On first boot, Tor mistakenly tells me "The current consensus has no exit nodes"

[Tor Bug Tracker & Wiki]

#32165: On first boot, Tor mistakenly tells me "The current consensus has no 
exit
nodes"
--+
 Reporter:  arma  |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  bootstrap |  Actual Points:
Parent ID:| Points:
 Reviewer:  ahf   |Sponsor:
--+
Changes (by dgoulet):

 * keywords:   => bootstrap
 * reviewer:   => ahf
 * milestone:   => Tor: 0.4.2.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32108 [Core Tor/Tor]: tor can overrun its accountingmax if it enters soft hibernation first

[Tor Bug Tracker & Wiki]

#32108: tor can overrun its accountingmax if it enters soft hibernation first
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  network-health 042-backport  |  Actual Points:
  041-backport 040-backport BugSmashFund |
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by dgoulet):

 * keywords:  network-health 042-backport 041-backport 040-backport =>
 network-health 042-backport 041-backport 040-backport BugSmashFund
 * reviewer:   => dgoulet


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30501 [Applications/Tor Browser]: BridgesList Preferences is an overloaded field

[Tor Bug Tracker & Wiki]

#30501: BridgesList Preferences is an overloaded field
---+---
 Reporter:  sisbell|  Owner:  tbb-team
 Type:  defect | Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201910R  |  Actual Points:
Parent ID:  #31280 | Points:  2
 Reviewer: |Sponsor:
   |  Sponsor30-can
---+---
Changes (by sisbell):

 * keywords:  tbb-mobile, TorBrowserTeam201905 => tbb-mobile,
 TorBrowserTeam201910R
 * status:  new => needs_review
 * points:  1 => 2


Comment:

 Involves fixes in both TOPL code and tor-android-service

 https://github.com/sisbell/tor-android-
 service/commit/0835e623f802127898df89cfb13685220dbe24b2

 
https://github.com/sisbell/Tor_Onion_Proxy_Library/commit/ac9ad2295b3dcb312a9aff4f3f7b27343bc4b73d

 This will create an incompatibility with Orbot, so I'll need to open
 another issue for that.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30767 [Applications/Tor Browser]: Custom obfs4 bridge does not work on Tor Browser for Android

[Tor Bug Tracker & Wiki]

#30767: Custom obfs4 bridge does not work on Tor Browser for Android
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-parity, tbb-mobile,  |  Actual Points:
  TorBrowserTeam201910R  |
Parent ID:  #31284   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor30-can
-+-
Changes (by sisbell):

 * keywords:  tbb-parity, tbb-mobile, TorBrowserTeam201910 => tbb-parity,
 tbb-mobile, TorBrowserTeam201910R
 * status:  new => needs_review


Comment:

 I fixed this as part of fixing the bridge list. I took the approach
 suggested by arma, the plugin transport is added regardless of whether
 user specifies a bridge. This is a much cleaner approach.I added some unit
 tests for verify behavior.

 
https://github.com/sisbell/Tor_Onion_Proxy_Library/commit/ac9ad2295b3dcb312a9aff4f3f7b27343bc4b73d

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32123 [Core Tor/Tor]: Implement minimal --disable-relay-mode

[Tor Bug Tracker & Wiki]

#32123: Implement minimal --disable-relay-mode
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-design, network-team-roadmap-|  implemented
  october|  Actual Points:  1.7
Parent ID:  #31851   | Points:  1
 Reviewer:  nickm|Sponsor:
 |  Sponsor31-can
-+-
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => implemented


Comment:

 Looks okay now.  Merged PR 1430 to master!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32133 [Internal Services/Service - git]: gitweb.tpo performance problems

[Tor Bug Tracker & Wiki]

#32133: gitweb.tpo performance problems
-+--
 Reporter:  anarcat  |  Owner:  anarcat
 Type:  defect   | Status:  assigned
 Priority:  Immediate|  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Major| Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by anarcat):

 for future reference, if the MaxRequestWorkers hack doesn't cut it, we
 could simulate fastcgi with uwsgi or fcgiwrap and decouple the apache and
 cgit threads, e.g.:

 https://wiki.archlinux.org/index.php/Cgit#Apache

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31659 [Internal Services/Tor Sysadmin Team]: new onionoo hosts

[Tor Bug Tracker & Wiki]

#31659: new onionoo hosts
-+-
 Reporter:  weasel   |  Owner:  tpa
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by weasel):

 rotated onionoo-frontend-01, which is backed by the two old onionoo
 backends as well as onionoo-backend-01.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26529 [Applications/Tor Browser]: TBA - Notify user about possible proxy-bypass before opening external app

[Tor Bug Tracker & Wiki]

#26529: TBA - Notify user about possible proxy-bypass before opening external 
app
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-torbutton, tbb-  |  Actual Points:
  proxy-bypass, TBA-a3, tbb-8.5, tbb-parity, |
  TorBrowserTeam201910   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by sysrqb):

 * cc: antonela (added)


Comment:

 Replying to [comment:17 gk]:
 > Looks good to me. I've applied the patch to `tor-
 browser-68.2.0esr-9.5-1` (commit
 6dc05e67cdbbb0a74f2c24387a3ea7443e08b57c).
 >
 > Two things I am unsure about:
 > 1)
 > {{{
 >  * launches a file during private browsing. The dialog appears to notify
 the user that a clicked
 >  * link will open in an external application, potentially leaking their
 browsing history.
 >  */
 > }}}
 > That's not the same as explaining possible proxy bypass/anonymity
 losses. We spent quite some time trying to get the message right for
 desktop. Do we want to do that as well in this case?

 On Desktop, our
 [https://gitweb.torproject.org/torbutton.git/tree/chrome/locale/en-
 US/torbutton.properties#n18 English] text is "Some types of files can
 cause applications to connect to the Internet without using Tor." and "To
 be safe, you should only open downloaded files while offline, or use a Tor
 Live CD such as Tails.".

 On Android, it [https://gitweb.torproject.org/tor-
 browser.git/tree/mobile/android/base/locales/en-US/android_strings.dtd?h
 =tor-browser-68.2.0esr-9.5-1#n812 says]: "This link will open in
 . Are you sure you want to exit Private Browsing?" where
 `` is replaced with the target app name.  I think using a message
 like the one on desktop is a better idea.

 I'm adding Anto. We should think about how we should phrase this.

 >
 > 2) Are we confident we have caught all possible issues here? There seems
 to be a variety of potentially problematic code paths.

 I think this deserves another round of auditing. I don't know.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32170 [Core Tor/Tor]: update geoip && geoip6 to October 15 2019 database

[Tor Bug Tracker & Wiki]

#32170: update geoip && geoip6 to October 15 2019 database
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  wontfix
 Keywords:  extra-review, tor-geoip, |  Actual Points:
  029-backport, 035-backport, 040-backport,  |
  041-backport, 042-backport |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  assigned => closed
 * resolution:   => wontfix


Comment:

 Karsten does these updates monthly; I'll take them from him.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31999 [Core Tor/Tor]: Default log file is handled inconsistently

[Tor Bug Tracker & Wiki]

#31999: Default log file is handled inconsistently
--+
 Reporter:  nickm |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  1.5
Parent ID:  #31241| Points:
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by nickm):

 * status:  needs_revision => needs_review
 * actualpoints:   => 1.5


Comment:

 I've added some tests, to make sure that the modified logic gets tests, as
 well as some of the old code that I didn't test.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31785 [Internal Services/Tor Sysadmin Team]: move getulum off moly

[Tor Bug Tracker & Wiki]

#31785: move getulum off moly
-+
 Reporter:  anarcat  |  Owner:  hiro
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:  #29974   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by hiro):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 Getulum has been decommisioned.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32134 [Circumvention/BridgeDB]: Request new translation and update i18n instructions

[Tor Bug Tracker & Wiki]

#32134: Request new translation and update i18n instructions
+---
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:  implemented
 Keywords:  s30-o22a3   |  Actual Points:  0.2
Parent ID:  #31279  | Points:  0.2
 Reviewer:  cohosh  |Sponsor:  Sponsor30-can
+---
Changes (by phw):

 * status:  merge_ready => closed
 * resolution:   => implemented
 * actualpoints:   => 0.2


Comment:

 I merged this patch in commit
 
[https://gitweb.torproject.org/user/phw/bridgedb.git/commit/?h=develop=b3cd9ac6d59a6f8ad1672518436d9e3d0ac2677f
 b3cd9ac].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31164 [Applications/Tor Browser]: Set up default bridge at Karlstad University

[Tor Bug Tracker & Wiki]

#31164: Set up default bridge at Karlstad University
-+-
 Reporter:  phw  |  Owner:  phw
 Type:  project  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-bridges, TorBrowserTeam201909R,  |  Actual Points:
  tbb-backport   |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-

Comment (by pulls):

 We had both of our uplinks die at the same time twice over the weekend,
 taking the entire department's equipment including the bridges offline.
 This isn't suppose to happen, sorry. IT staff investigating and
 monitoring, so far nothing abnormal detected on either side of the
 uplinks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32154 [Applications/Tor Launcher]: Tor Launcher's custom bridge field only allows one line of input

[Tor Bug Tracker & Wiki]

#32154: Tor Launcher's custom bridge field only allows one line of input
-+
 Reporter:  mcs  |  Owner:  brade
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Launcher|Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff68-esr, TorBrowserTeam201910R  |  Actual Points:  0.5
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+
Changes (by mcs):

 * actualpoints:   => 0.5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27604 [Applications/Tor Browser]: Relocating the Tor Browser directory is broken with Tor Browser 8

[Tor Bug Tracker & Wiki]

#27604: Relocating the Tor Browser directory is broken with Tor Browser 8
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression,  |  Actual Points:  0.6
  tbb-8.0.1-can, TorBrowserTeam201910|
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * actualpoints:   => 0.6


Comment:

 Added brade/mcs points so far (0.6).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32055 [Applications/Tor Browser]: Importing bookmarks from Safari doesn't work

[Tor Bug Tracker & Wiki]

#32055: Importing bookmarks from Safari doesn't work
--+--
 Reporter:  rex4539   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  0.1
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by mcs):

 * actualpoints:   => 0.1


Comment:

 Added brade/mcs points so far (0.1).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32039 [Applications/Tor Browser]: Tor Browser 8.5.5 is not working on macOS 10.15 after being freshly installed on macOS 10.15

[Tor Bug Tracker & Wiki]

#32039: Tor Browser 8.5.5 is not working on macOS 10.15 after being freshly
installed on macOS 10.15
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  TorBrowserTeam201910  |  Actual Points:  0.25
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by mcs):

 * actualpoints:   => 0.25


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31607 [Applications/Tor Browser]: App menu items stop working

[Tor Bug Tracker & Wiki]

#31607: App menu items stop working
-+-
 Reporter:  mcs  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:  5
  TorBrowserTeam201910R  |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * actualpoints:   => 5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31768 [Applications/Tor Browser]: Introduce Tor network settings and other updates in TB9 onboarding

[Tor Bug Tracker & Wiki]

#31768: Introduce Tor network settings and other updates in TB9 onboarding
-+-
 Reporter:  antonela |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ux-team, tbb-9.0-must-alpha, |  Actual Points:  2.2
  TorBrowserTeam201910R, tbb-onboarding  |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * actualpoints:   => 2.2


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29206 [Circumvention/Snowflake]: New design for client -- server protocol for Snowflake

[Tor Bug Tracker & Wiki]

#29206: New design for client -- server protocol for Snowflake
---+---
 Reporter:  cohosh |  Owner:  cohosh
 Type:  task   | Status:
   |  needs_revision
 Priority:  Medium |  Milestone:
Component:  Circumvention/Snowflake|Version:
 Severity:  Normal | Resolution:
 Keywords:  anti-censorship-roadmap-september  |  Actual Points:
Parent ID: | Points:  6
 Reviewer:  dcf|Sponsor:
   |  Sponsor28-must
---+---
Changes (by cohosh):

 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32174 [Applications/Tor Launcher]: replace XUL with

[Tor Bug Tracker & Wiki]

#32174: replace XUL  with 
---+--
 Reporter:  mcs|  Owner:  brade
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Launcher  |Version:
 Severity:  Normal |   Keywords:  ff78-esr
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor: |
---+--
 Mozilla has removed XUL , although only partially in the ESR68
 timeframe (see #32154 where we had to replace a multiline usage with
 ). We need to finish the job and replace our remaining uses
 of  with .

 While we are at it, we should double check that we do not use 
 outside of Tor Launcher, either in the Torbutton code or in a Firefox
 patch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31910 [Applications/Tor Browser]: replace meek_lite with meek in circuit display

[Tor Bug Tracker & Wiki]

#31910: replace meek_lite with meek in circuit display
-+-
 Reporter:  mcs  |  Owner:  mcs
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  meek, tbb-9.0-must-alpha,|  Actual Points:  0.2
  TorBrowserTeam201910R, ux-team |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * actualpoints:   => 0.2


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31650 [Applications/Tor Browser]: pre-crunch and pre-strip PNG in tor-service-android to make it reproducible

[Tor Bug Tracker & Wiki]

#31650: pre-crunch and pre-strip PNG in tor-service-android to make it 
reproducible
---+---
 Reporter:  eighthave  |  Owner:  tbb-team
 Type:  enhancement| Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201910R  |  Actual Points:
Parent ID:  #31042 | Points:
 Reviewer: |Sponsor:
---+---

Comment (by eighthave):

 Oh right, but Orbot is included.  It seems in some cases they can be
 reproducibly crunched.  Pre-crunching and disabling the automatic
 crunching ensures that there are no surprises.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #31572, #31573, #31764

[Tor Bug Tracker & Wiki]

Batch modification to #31572, #31573, #31764 by gk:


--
Tickets URL: 

Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs