Re: [tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress

2019-10-22 Thread Tor Bug Tracker & Wiki
#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-should|  Actual Points:  1.5
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by teor):

 * status:  needs_review => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress

2019-10-22 Thread Tor Bug Tracker & Wiki
#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-should|  Actual Points:  1.5
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+

Comment (by teor):

 This is merge_ready.

 But there are actually 22 files that don't pass, see:
 https://github.com/torproject/tor/pull/1454/files#diff-
 8eaf87fc1c11a68a2909b7da648da0a9

 I'm going to wait until #31919 passes before merging, just in case there
 are any more surprises.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32220 [Applications/Tor Browser]: Change letterboxing color when dark theme is enabled

2019-10-22 Thread Tor Bug Tracker & Wiki
#32220: Change letterboxing color when dark theme is enabled
-+--
 Reporter:  cypherpunks  |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  High |  Component:  Applications/Tor Browser
  Version:   |   Severity:  Major
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
 Change letterboxing color when dark theme is enabled

 It is very white and should be changed to a dark color

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31919 [Core Tor/Tor]: Add a check-local target that runs our coccinelle parsing problems script

2019-10-22 Thread Tor Bug Tracker & Wiki
#31919: Add a check-local target that runs our coccinelle parsing problems 
script
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-can   |  Actual Points:  0.3
Parent ID:  #31705| Points:  0.5
 Reviewer:  nickm |Sponsor:
--+
Changes (by teor):

 * status:  new => needs_review
 * reviewer:   => nickm
 * actualpoints:   => 0.3
 * milestone:  Tor: 0.4.2.x-final => Tor: 0.4.3.x-final


Comment:

 See my draft pull request:
 * master: https://github.com/torproject/tor/pull/1454

 TODO:
 * merge #31705 and rebase
 * squash the two Travis commits
 * add a changes file
 * run 'make autostyle-operators' or 'make autostyle', and see if the
 exceptions file gets smaller

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31919 [Core Tor/Tor]: Add a check-local target that runs our coccinelle parsing problems script

2019-10-22 Thread Tor Bug Tracker & Wiki
#31919: Add a check-local target that runs our coccinelle parsing problems 
script
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-can   |  Actual Points:  0.3
Parent ID:  #31705| Points:  0.5
 Reviewer:  nickm |Sponsor:
--+

Comment (by teor):

 Oh, it's based on #31705, you only want the last 5 commits.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32219 [Webpages]: incorrect body size, scrollbars

2019-10-22 Thread Tor Bug Tracker & Wiki
#32219: incorrect body size, scrollbars
-+
 Reporter:  sullivanbug  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Webpages |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by sullivanbug):

 * Attachment "Untitled.jpg" added.

 bug-print

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32219 [Webpages]: incorrect body size, scrollbars

2019-10-22 Thread Tor Bug Tracker & Wiki
#32219: incorrect body size, scrollbars
-+--
 Reporter:  sullivanbug  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Component:  Webpages
  Version:   |   Severity:  Normal
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
 this issue began happening late today, can't find a reason why, already
 tried reinstalling, also tried safe mode.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31667 [Applications/Tor Browser]: NAvigator object leaking OS, again?

2019-10-22 Thread Tor Bug Tracker & Wiki
#31667: NAvigator object leaking OS, again?
--+---
 Reporter:  op_mb |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  duplicate
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by cypherpunks):

 There's an unclosed  tag in the description -- I hope this is not an
 XSS bug?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31571 [Core Tor/Tor]: Add the tor version and a newline to raw_assert()

2019-10-22 Thread Tor Bug Tracker & Wiki
#31571: Add the tor version and a newline to raw_assert()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.3
  BugSmashFund, diagnostics, android, dgoulet-   |
  merge, macos 035-backport 040-backport |
  041-backport   |
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
-+-

Comment (by teor):

 Note: It's marked consider-backport-after-042-stable, so I don't want to
 backport *yet*.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31571 [Core Tor/Tor]: Add the tor version and a newline to raw_assert()

2019-10-22 Thread Tor Bug Tracker & Wiki
#31571: Add the tor version and a newline to raw_assert()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.3
  BugSmashFund, diagnostics, android, dgoulet-   |
  merge, macos 035-backport 040-backport |
  041-backport   |
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
-+-

Comment (by teor):

 PR 1277 merges fine to maint-0.4.1 using my git:
 * 0.4.1: https://github.com/torproject/tor/pull/1452

 We want to backport this change to maint-0.3.5, so we can see a tor
 version every time tor crashes. Even on old tor versions :-)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31509 [Core Tor/Tor]: config refactor: make test-stem should pass

2019-10-22 Thread Tor Bug Tracker & Wiki
#31509: config refactor: make test-stem should pass
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  reopened
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august, |  Actual Points:
  042-deferred-20190918  |
Parent ID:  #29211   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor31-must
-+-
Changes (by teor):

 * status:  closed => reopened
 * resolution:  not a bug =>


Comment:

 We don't know if make test-stem passes, because it is broken on our CI.
 See #30901.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32218 [Core Tor/Tor]: Systemd problem with ExecReload and CAP_KILL

2019-10-22 Thread Tor Bug Tracker & Wiki
#32218: Systemd problem with ExecReload and CAP_KILL
+--
 Reporter:  sunova  |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Component:  Core Tor/Tor
  Version:  Tor: 0.4.2.2-alpha  |   Severity:  Normal
 Keywords:  systemd |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
 Hi
 There is a known issue with CGroup hardening which systemd applies, that
 without CAP_KILL capability, it's not possible to send HUP signal by
 managed slice, even to MAINPID.
 Please add it to CapabilityBoundingSet= section in unit file.
 Running Tor 0.4.2.2-alpha on Gentoo.

 
https://gitweb.torproject.org/tor.git/tree/contrib/dist/tor.service.in?id=d5cbc58094ec740e768d5fa88a51c20c645ed70e

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress

2019-10-22 Thread Tor Bug Tracker & Wiki
#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-should|  Actual Points:  1.5
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by teor):

 * milestone:  Tor: 0.4.2.x-final => Tor: 0.4.3.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32216 [Core Tor/Tor]: Make git-push-all.sh skip branches that match upstream, in all modes

2019-10-22 Thread Tor Bug Tracker & Wiki
#32216: Make git-push-all.sh skip branches that match upstream, in all modes
---+
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  git-scripts, fast-fix  |  Actual Points:  0.1
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:
---+
Changes (by teor):

 * status:  assigned => needs_review


Comment:

 I also fixed some bugs.

 See my PR:
 * master: https://github.com/torproject/tor/pull/1451

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32217 [Core Tor/Tor]: Make git-push-all.sh skip branches that match upstream, in all modes

2019-10-22 Thread Tor Bug Tracker & Wiki
#32217: Make git-push-all.sh skip branches that match upstream, in all modes
---+
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:  closed
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:  duplicate
 Keywords:  git-scripts, fast-fix  |  Actual Points:  0.2
Parent ID:  #32216 | Points:  0.1
 Reviewer: |Sponsor:
---+
Changes (by teor):

 * status:  assigned => closed
 * resolution:   => duplicate
 * parent:   => #32216


Comment:

 Weird, somehow my Tor Browser ended up with a draft copy of this ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32217 [Core Tor/Tor]: Make git-push-all.sh skip branches that match upstream, in all modes

2019-10-22 Thread Tor Bug Tracker & Wiki
#32217: Make git-push-all.sh skip branches that match upstream, in all modes
--+---
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  git-scripts, fast-fix
Actual Points:  0.2   |  Parent ID:
   Points:  0.1   |   Reviewer:
  Sponsor:|
--+---
 This makes my backport pushes slightly faster.

 It also helps make sure I'm only merging to branches I am expecting to
 merge to.

 Also fix some bugs.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32216 [Core Tor/Tor]: Make git-push-all.sh skip branches that match upstream, in all modes

2019-10-22 Thread Tor Bug Tracker & Wiki
#32216: Make git-push-all.sh skip branches that match upstream, in all modes
--+---
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  git-scripts, fast-fix
Actual Points:  0.1   |  Parent ID:
   Points:  0.1   |   Reviewer:
  Sponsor:|
--+---
 This makes my backport pushes slightly faster.

 It also helps make sure I'm only merging to branches I am expecting to
 merge to.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32212 [Applications/Tor Browser]: Tor Browser 9.0 does not restart correctly after updating from 8.5.5, on Debian stretch

2019-10-22 Thread Tor Bug Tracker & Wiki
#32212: Tor Browser 9.0 does not restart correctly after updating from 8.5.5, on
Debian stretch
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-9.0-issues|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by mcs):

 Replying to [ticket:32212 boklm]:
 > I am wondering if the updater is restarting the browser using
 `Browser/firefox`, or if it is instead running `Browser/firefox.real`
 (without using the wrapper script).

 That is likely true. From code inspection:

 To get the value of the exe arg it passes to the updater, `ApplyUpdate()`
 in `toolkit/xre/nsUpdaterDriver.cpp` calls `XRE_GetBinaryPath()`, which in
 turn calls `mozilla::BinaryPath::GetFile()`.

 From reading `xpcom/build/BinaryPath.h`, on Linux the `GetFile()` call is
 basically  `readlink("/proc/self/exe")` which if I understand things
 correctly will bypass our wrapper script.

 One of us should confirm that this is what is happening, maybe by
 temporarily replacing `updater` with a script that logs its args. Then we
 should think about how to fix this problem.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress

2019-10-22 Thread Tor Bug Tracker & Wiki
#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-should|  Actual Points:  1.5
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+

Comment (by teor):

 I would like to check the fixed files using cocci in CI. If we don't, they
 will degrade over time.
 The CI shouldn't take long, I'll see if I can get it done today,

 We can exclude the files that are hard to fix, and open a ticket to deal
 with them later.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32215 [Applications/Tor Browser]: tor browser goes black when starting

2019-10-22 Thread Tor Bug Tracker & Wiki
#32215: tor browser goes black when starting
--+--
 Reporter:  carlosnewmusic|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Immediate |  Milestone:
Component:  Applications/Tor Browser  |Version:  Tor: 0.4.1.6
 Severity:  Major | Resolution:
 Keywords:  tor browser black |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by carlosnewmusic):

 * Attachment "capture.cleaned.png" added.

 open tor browser

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32215 [Applications/Tor Browser]: tor browser goes black when starting

2019-10-22 Thread Tor Bug Tracker & Wiki
#32215: tor browser goes black when starting
---+--
 Reporter:  carlosnewmusic |  Owner:  tbb-team
 Type:  defect | Status:  new
 Priority:  Immediate  |  Component:  Applications/Tor Browser
  Version:  Tor: 0.4.1.6   |   Severity:  Major
 Keywords:  tor browser black  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
 when starting tor in linux both the connection interface will turn black
 from the beginning, without even differentiating between the title bar and
 the program

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32105 [Circumvention/BridgeDB]: brid...@torproject.org don't respond

2019-10-22 Thread Tor Bug Tracker & Wiki
#32105: brid...@torproject.org don't respond
+--
 Reporter:  mh828   |  Owner:  phw
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  cohosh  |Sponsor:  Sponsor30
+--

Comment (by phw):

 Replying to [comment:10 arma]:
 > But, we probably want a bigger change too. It looks like bridgedb relies
 on the .procmailrc contents of the bridgedb user, in order to add the "X
 -DKIM-Authentication-Results: pass" header, without which bridgedb's email
 module won't be pleased with the mail it receives. I think that means the
 mail receiving scripts are part of bridgedb and should be documented, or
 in git, somewhere too.
 [[br]]
 Good point. Here's a patch for bridgedb-admin, which we use for
 administration-related tooling around BridgeDB:
 https://gitweb.torproject.org/user/phw/bridgedb-
 admin.git/commit/?h=fix/32105

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32214 [Applications/Tor Browser]: App dies after some time on Android 9

2019-10-22 Thread Tor Bug Tracker & Wiki
#32214: App dies after some time on Android 9
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201910,|  Actual Points:
  tbb-9.0-issues |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * keywords:  TorBrowserTeam201910, tbb-9.0 => TorBrowserTeam201910,
 tbb-9.0-issues


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32214 [Applications/Tor Browser]: App dies after some time on Android 9

2019-10-22 Thread Tor Bug Tracker & Wiki
#32214: App dies after some time on Android 9
---+---
 Reporter:  sysrqb |  Owner:  tbb-team
 Type:  defect | Status:
   |  needs_information
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorBrowserTeam201910, tbb-9.0  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by sysrqb):

 * status:  new => needs_information


Comment:

 The reporter is using a Galaxy Tab A from 2018.

 Let's try creating an emulator and keep the app open after it bootstraps.
 Maybe we'll hit something.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32214 [Applications/Tor Browser]: App dies after some time on Android 9

2019-10-22 Thread Tor Bug Tracker & Wiki
#32214: App dies after some time on Android 9
-+-
 Reporter:  sysrqb   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  TorBrowserTeam201910,
 Severity:  Normal   |  tbb-9.0
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 We received a report that the Tor Browser app "shuts itself off" on
 Android 9 "after a while". Maybe there's a background process/service that
 is raising an exception.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29856 [Community/Tor Browser Manual]: tb manual: duplicated info around bridges

2019-10-22 Thread Tor Bug Tracker & Wiki
#29856: tb manual: duplicated info around bridges
--+---
 Reporter:  emmapeel  |  Owner:  ggus
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Community/Tor Browser Manual  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  documentation, tbb|  Actual Points:
Parent ID:  #31281| Points:
 Reviewer:|Sponsor:  Sponsor30-can
--+---
Changes (by ggus):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 Merged PT page to Circumvention.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32153 [Community/Tor Browser Manual]: ensure merged content gives correct location for onion icon

2019-10-22 Thread Tor Bug Tracker & Wiki
#32153: ensure merged content gives correct location for onion icon
--+
 Reporter:  bluemoon  |  Owner:  ggus
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Community/Tor Browser Manual  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  documentation, tbb|  Actual Points:
Parent ID:  #29856| Points:
 Reviewer:|Sponsor:
--+
Changes (by ggus):

 * status:  new => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31518 [Core Tor/Tor]: HAProxy implementation in TCPProxy option.

2019-10-22 Thread Tor Bug Tracker & Wiki
#31518: HAProxy implementation in TCPProxy option.
--+
 Reporter:  haxxpop   |  Owner:  haxxpop
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  proxy tcp |  Actual Points:
Parent ID:| Points:
 Reviewer:  nickm |Sponsor:
--+

Comment (by haxxpop):

 The coverage is higher now. The rest of the new lines that is not covered
 are not actually new lines. They are from refactoring and belongs to
 socks4 and socks5.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31549 [Core Tor/Tor]: Authorities should stop listing relays running pre-0.2.9, or running 0.3.0 through 0.3.4

2019-10-22 Thread Tor Bug Tracker & Wiki
#31549: Authorities should stop listing relays running pre-0.2.9, or running 
0.3.0
through 0.3.4
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  042-can 041-backport consider-   |  Actual Points:
  backport-after-authority-test consider-|
  backport-after-0422 tor-dirauth tor-   |
  bridgeauth |
Parent ID:  #25882   | Points:
 Reviewer:  dgoulet, teor|Sponsor:
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged to 0.4.1 and later with a fixup and ours merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31509 [Core Tor/Tor]: config refactor: make test-stem should pass

2019-10-22 Thread Tor Bug Tracker & Wiki
#31509: config refactor: make test-stem should pass
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  not a
 Keywords:  network-team-roadmap-august, |  bug
  042-deferred-20190918  |  Actual Points:
Parent ID:  #29211   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor31-must
-+-
Changes (by nickm):

 * status:  assigned => closed
 * resolution:   => not a bug


Comment:

 I believe this is an ongoing requirement, not a specific task. Please
 reopen if that's wrong?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31508 [Core Tor/Tor]: config refactor: create simple summaries for each refactor step

2019-10-22 Thread Tor Bug Tracker & Wiki
#31508: config refactor: create simple summaries for each refactor step
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  not a
 Keywords:  network-team-roadmap-august, |  bug
  042-deferred-20190918  |  Actual Points:
Parent ID:  #29211   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor31-can
-+-
Changes (by nickm):

 * status:  assigned => closed
 * resolution:   => not a bug


Comment:

 I believe this is an ongoing requirement, not a specific task; please
 reopen if I am wrong there?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31511 [Core Tor/Tor]: config refactor: split mass change commits into automated and manual steps

2019-10-22 Thread Tor Bug Tracker & Wiki
#31511: config refactor: split mass change commits into automated and manual 
steps
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  not a
 Keywords:  network-team-roadmap-august, |  bug
  042-deferred-20190918  |  Actual Points:
Parent ID:  #29211   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor31-must
-+-
Changes (by nickm):

 * status:  assigned => closed
 * resolution:   => not a bug


Comment:

 Closing, as this is a general requirement going forward, not a task.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31516 [Core Tor/Tor]: config refactor: every function table entry should be documented and unit tested

2019-10-22 Thread Tor Bug Tracker & Wiki
#31516: config refactor: every function table entry should be documented and 
unit
tested
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  not a
 Keywords:  network-team-roadmap-august, |  bug
  042-deferred-20190918  |  Actual Points:
Parent ID:  #29211   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor31-must
-+-
Changes (by nickm):

 * status:  assigned => closed
 * resolution:   => not a bug


Comment:

 Closing, as this is a general requirement going forward, not a task.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31851 [Core Tor/Tor]: Allow Tor to be compiled without support for relay mode

2019-10-22 Thread Tor Bug Tracker & Wiki
#31851: Allow Tor to be compiled without support for relay mode
-+-
 Reporter:  teor |  Owner:  teor
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-design, network-team-roadmap-|  Actual Points:  0.2
  october|
Parent ID:   | Points:  5
 Reviewer:  nickm|Sponsor:
 |  Sponsor31-can
-+-

Comment (by teor):

 We want to write a list of code-chunks to disable, in rough order of ease-
 of-implementation.

 For each code chunk, we want to:
 * create stronger code boundaries
 * make those boundaries clear in code naming/layout

 We should do these steps:
 1. Move code into a directory called *_relay, *_dircache, or *_dirauth
 2. Move code between files as needed
 3. Remove upwards dependencies, and other unnecessary dependencies
 4. Refactor code, so code boundaries are clearer:
   * split functions
   * rename functions
 5. Make any other changes that improve modularity

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32213 [Core Tor/Tor]: Disable minimal dirauth and relay options when those modules are disabled

2019-10-22 Thread Tor Bug Tracker & Wiki
#32213: Disable minimal dirauth and relay options when those modules are 
disabled
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  tor-design, network-team-roadmap-
 Severity:  Normal   |  october
Actual Points:   |  Parent ID:  #31851
   Points:  0.5  |   Reviewer:
  Sponsor:   |
  Sponsor31-must |
-+-
 We should disable this minimal set of options:

 * --disable-module-dirauth
   * disable AuthoritativeDirectory

 * --disable-module-relay
   * disable DirPort, DirCache, ORPort
   * set ClientOnly to 1

 This is a serious UX bug, so it must be fixed as part of Sponsor 31.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32139 [Core Tor/Tor]: Disable all dirauth and relay options when those modules are disabled

2019-10-22 Thread Tor Bug Tracker & Wiki
#32139: Disable all dirauth and relay options when those modules are disabled
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-design, network-team-roadmap-|  Actual Points:
  october|
Parent ID:  #31851   | Points:  2
 Reviewer:   |Sponsor:
 |  Sponsor31-can
-+-
Changes (by teor):

 * points:   => 2


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32139 [Core Tor/Tor]: Disable all dirauth and relay options when those modules are disabled

2019-10-22 Thread Tor Bug Tracker & Wiki
#32139: Disable all dirauth and relay options when those modules are disabled
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-design, network-team-roadmap-|  Actual Points:
  october|
Parent ID:  #31851   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor31-can
-+-
Description changed by teor:

Old description:

> Here's what we want to change in this ticket:
>
> * --disable-module-dirauth (and, by implication, --disable-module-relay)
>   * Disables *AuthoritativeDir*, and MinUptimeHidServDirectoryV2 options
> * Maybe these options should move under Directory Authority Server
> Options in the man page
>   * Disables all the options under Directory Authority Server Options
>
> * --disable-module-relay
>   * disable DirPort, DirCache, ORPort
>   * sets ClientOnly to 1 ?
>   * Disables all the other options under Directory Server Options
>   * Disables all the other options under Server Options
>   * Disables the --list-fingerprint, RelayBandwidth*,
> MaxAdvertisedBandwidth, PerConnBW*, and ServerTransportPlugin options
> * Maybe some of these options should move under Server Options in the
> man page
>
> These changes should be much easier after the config refactor.

New description:

 Here's what we want to change in this ticket:

 * --disable-module-dirauth (and, by implication, --disable-module-relay)
   * Disables *AuthoritativeDir*, and MinUptimeHidServDirectoryV2 options
 * Maybe these options should move under Directory Authority Server
 Options in the man page
   * Disables all the options under Directory Authority Server Options

 * --disable-module-relay
   * disable DirPort, DirCache, ORPort
   * set ClientOnly to 1 ?
   * Disables all the other options under Directory Server Options
   * Disables all the other options under Server Options
   * Disables the --list-fingerprint, RelayBandwidth*,
 MaxAdvertisedBandwidth, PerConnBW*, and ServerTransportPlugin options
 * Maybe some of these options should move under Server Options in the
 man page

 These changes should be much easier after the config refactor.

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32139 [Core Tor/Tor]: Disable all dirauth and relay options when those modules are disabled (was: Disable dirauth and relay options when those modules are disabled)

2019-10-22 Thread Tor Bug Tracker & Wiki
#32139: Disable all dirauth and relay options when those modules are disabled
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-design, network-team-roadmap-|  Actual Points:
  october|
Parent ID:  #31851   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor31-can
-+-
Description changed by teor:

Old description:

> Here's what we want to change in this ticket:
>
> * --disable-module-dirauth (and, by implication, --disable-module-relay)
>   * Disables *AuthoritativeDir*, and MinUptimeHidServDirectoryV2 options
> * Maybe these options should move under Directory Authority Server
> Options in the man page
>   * Disables all the options under Directory Authority Server Options
>
> * --disable-module-relay
>   * disable DirPort, DirCache, ORPort, and sets ClientOnly to 1
>   * Disables all the other options under Directory Server Options
>   * Disables all the other options under Server Options
>   * Disables the --list-fingerprint, RelayBandwidth*,
> MaxAdvertisedBandwidth, PerConnBW*, and ServerTransportPlugin options
> * Maybe some of these options should move under Server Options in the
> man page
>
> These changes should be much easier after the config refactor.

New description:

 Here's what we want to change in this ticket:

 * --disable-module-dirauth (and, by implication, --disable-module-relay)
   * Disables *AuthoritativeDir*, and MinUptimeHidServDirectoryV2 options
 * Maybe these options should move under Directory Authority Server
 Options in the man page
   * Disables all the options under Directory Authority Server Options

 * --disable-module-relay
   * disable DirPort, DirCache, ORPort
   * sets ClientOnly to 1 ?
   * Disables all the other options under Directory Server Options
   * Disables all the other options under Server Options
   * Disables the --list-fingerprint, RelayBandwidth*,
 MaxAdvertisedBandwidth, PerConnBW*, and ServerTransportPlugin options
 * Maybe some of these options should move under Server Options in the
 man page

 These changes should be much easier after the config refactor.

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32187 [Core Tor/Tor]: Clean up options_validate() interface

2019-10-22 Thread Tor Bug Tracker & Wiki
#32187: Clean up options_validate() interface
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .1
Parent ID:  #31241| Points:  .3
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+

Comment (by nickm):

 (Now appveyor is done too.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32211 [Core Tor/Tor]: write description of subsystem initialization/shutdown architecture

2019-10-22 Thread Tor Bug Tracker & Wiki
#32211: write description of subsystem initialization/shutdown architecture
-+-
 Reporter:  catalyst |  Owner:  nickm
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-september,  |  Actual Points:
  s31-docs   |
Parent ID:  #29215   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor31-must
-+-
Changes (by catalyst):

 * status:  new => assigned
 * owner:  (none) => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31372 [Core Tor/Tor]: Appveyor and Travis should use "make -k"

2019-10-22 Thread Tor Bug Tracker & Wiki
#31372: Appveyor and Travis should use "make -k"
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-ci, 029-backport, 035-backport,  |  Actual Points:  .1
  040-backport, 041-backport, 042-should |
  dgoulet-merge  |
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged to 0.2.9 and later.
 Merged #32106, #31807, #31001, #23818, #12399, and #31372 together.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #12399 [Core Tor/Tor]: "Hash of session info was not as expected" should be log_protocol_warn

2019-10-22 Thread Tor Bug Tracker & Wiki
#12399: "Hash of session info was not as expected" should be log_protocol_warn
-+-
 Reporter:  ln5  |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-hs easy logging 035-backport |  Actual Points:
  040-backport 041-backport consider-backport-   |
  after-0421 |
Parent ID:   | Points:  .1
 Reviewer:  mikeperry, dgoulet   |Sponsor:
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged to 0.3.5 and later.
 Merged #32106, #31807, #31001, #23818, #12399, and #31372 together.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31001 [Core Tor/Tor]: Undefined behavior in tor_vasprintf()

2019-10-22 Thread Tor Bug Tracker & Wiki
#31001: Undefined behavior in tor_vasprintf()
-+-
 Reporter:  asn  |  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  hackerone, bug-bounty, security- |  Actual Points:  .1
  low, unlikely-crash, 029-backport, |
  035-backport, 040-backport, 041-backport,  |
  dgoulet-merge, consider-backport-after-0421|
Parent ID:   | Points:  0.5
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged to 0.2.9 and later.
 Merged #32106, #31807, #31001, #23818, #12399, and #31372 together.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23818 [Core Tor/Tor]: Make v2 and v3 single onion services retry all failed intro and rend connections with a 3-hop path

2019-10-22 Thread Tor Bug Tracker & Wiki
#23818: Make v2 and v3 single onion services retry all failed intro and rend
connections with a 3-hop path
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.3-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  029-no-backport, 035-backport,   |  Actual Points:  0.2
  040-backport, 041-backport, v3-onion-service-  |
  feature-parity, prop224, tor-hs, single-   |
  onion, ipv6, network-team-roadmap-august,  |
  consider-backport-after-0421   |
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23818 [Core Tor/Tor]: Make v2 and v3 single onion services retry all failed intro and rend connections with a 3-hop path

2019-10-22 Thread Tor Bug Tracker & Wiki
#23818: Make v2 and v3 single onion services retry all failed intro and rend
connections with a 3-hop path
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  029-no-backport, 035-backport,   |  Actual Points:  0.2
  040-backport, 041-backport, v3-onion-service-  |
  feature-parity, prop224, tor-hs, single-   |
  onion, ipv6, network-team-roadmap-august,  |
  consider-backport-after-0421   |
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-

Comment (by teor):

 Merged to 0.3.5 and later.
 Merged #32106, #31807, #31001, #23818, #12399, and #31372 together.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31807 [Core Tor/Tor]: Update outdated documentation note for "bridge-distribution"

2019-10-22 Thread Tor Bug Tracker & Wiki
#31807: Update outdated documentation note for "bridge-distribution"
---+---
 Reporter:  phw|  Owner:  (none)
 Type:  defect | Status:  closed
 Priority:  Low|  Milestone:  Tor:
   |  0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Minor  | Resolution:  fixed
 Keywords:  BugSmashFund 042-can 042-backport  |  Actual Points:  0.2
Parent ID: | Points:  0.2
 Reviewer:  teor   |Sponsor:
---+---
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged the tor branch to 0.4.2 and later.
 Merged #32106, #31807, #31001, #23818, #12399, and #31372 together.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32106 [Core Tor/Tor]: tor man page should clarify that KBytes is 1024 bytes

2019-10-22 Thread Tor Bug Tracker & Wiki
#32106: tor man page should clarify that KBytes is 1024 bytes
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  manpage, tor-doc. 042-can,   |  Actual Points:
  042-backport   |
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged to 0.4.2 and later.
 Merged #32106, #31807, #31001, #23818, #12399, and #31372 together.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31549 [Core Tor/Tor]: Authorities should stop listing relays running pre-0.2.9, or running 0.3.0 through 0.3.4

2019-10-22 Thread Tor Bug Tracker & Wiki
#31549: Authorities should stop listing relays running pre-0.2.9, or running 
0.3.0
through 0.3.4
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  042-can 041-backport consider-   |  Actual Points:
  backport-after-authority-test consider-|
  backport-after-0422 tor-dirauth tor-   |
  bridgeauth |
Parent ID:  #25882   | Points:
 Reviewer:  dgoulet, teor|Sponsor:
-+-
Changes (by teor):

 * keywords:
 042-can 041-backport consider-backport-after-authority-test consider-
 backport-after-0423 tor-dirauth tor-bridgeauth
 =>
 042-can 041-backport consider-backport-after-authority-test consider-
 backport-after-0422 tor-dirauth tor-bridgeauth


Comment:

 We tested this on an authority, and it's working fine. There doesn't seem
 much point in testing it in a release. Time to backport.

 Currently:
 * the bridge authority is on 0.3.5
 * 2 authorities are on 0.4.0
 * 6 authorities are on 0.4.1
 * 1 authority is on 0.4.2-alpha
 So we don't need to go any further back than 0.4.1.

 But I want to make a minor fix. In ticket31549_035, we did not backport
 the unit tests. So the header changes are unnecessary, as is the "STATIC"
 on the function, it should just be "static".

 I made these changes in:
 * 0.3.5: https://github.com/torproject/tor/pull/1450

 Anyone can merge to **0.4.1 and later**, after CI passes.

 When merging, we should:
 * do a fixup, to minimise the diff and future conflicts;
 * use `git merge --strategy ours` to merge forward to maint-0.4.2

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31646 [Applications/Tor Browser]: Update abicheck to require newer libstdc++.so.6

2019-10-22 Thread Tor Bug Tracker & Wiki
#31646: Update abicheck to require newer libstdc++.so.6
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201909R,  |  Actual Points:  3
  tbb-9.0-must-alpha, ff68-esr   |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:15 boklm]:
 > I noticed that on Debian 9, my 8.5.5 browser did not restart at the end
 of the update to 9.0. However it correctly started when starting it again
 manually.
 >
 > On Debian 9, the bundled `libstdc++.so.6` is not required in version
 8.5.5, but is required in version 9.0, so I'm wondering if it could be
 related to this issue.

 I opened a separate ticket for this: #32212

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28290 [Applications/Tor Browser]: Don't allow fingerprinting via navigator.userAgent

2019-10-22 Thread Tor Bug Tracker & Wiki
#28290: Don't allow fingerprinting via navigator.userAgent
-+-
 Reporter:  indigotime   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-fingerprinting-os, user- |  Actual Points:
  feedback, blog |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * cc: op_mb (added)


Comment:

 #31667 is a duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31667 [Applications/Tor Browser]: NAvigator object leaking OS, again?

2019-10-22 Thread Tor Bug Tracker & Wiki
#31667: NAvigator object leaking OS, again?
--+---
 Reporter:  op_mb |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  duplicate
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by boklm):

 * owner:  (none) => tbb-team
 * resolution:   => duplicate
 * status:  new => closed
 * component:  Applications => Applications/Tor Browser
 * version:  Tor: unspecified =>


Comment:

 This is a duplicate of #28290.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32212 [Applications/Tor Browser]: Tor Browser 9.0 does not restart correctly after updating from 8.5.5, on Debian stretch

2019-10-22 Thread Tor Bug Tracker & Wiki
#32212: Tor Browser 9.0 does not restart correctly after updating from 8.5.5, on
Debian stretch
--+
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-9.0-issues
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 When updating Tor Browser 8.5.5 to 9.0 on Debian stretch, the browser does
 not restart after finishing the update. However, it correctly starts when
 manually running the start script again.

 On Debian strech, the bundled `libstdc++.so.6` was not needed with 8.5.5,
 but is needed with 9.0. The wrapper script in `Browser/firefox` is
 supposed to add the directory containing `libstdc++.so.6` to
 `LD_LIBRARY_PATH`.

 I am wondering if the updater is restarting the browser using
 `Browser/firefox`, or if it is instead running `Browser/firefox.real`
 (without using the wrapper script).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32135 [Circumvention/BridgeDB]: Write BridgeDB metrics parser and analyse existing data

2019-10-22 Thread Tor Bug Tracker & Wiki
#32135: Write BridgeDB metrics parser and analyse existing data
+--
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o21a1   |  Actual Points:
Parent ID:  #31274  | Points:  2
 Reviewer:  |Sponsor:
+--

Comment (by phw):

 Below are a bunch of diagrams that I created from our BridgeDB usage
 metrics. The scripts that I used to create these diagrams are available
 here: https://dip.torproject.org/phw/bridgedb-metrics-visualisation

 Note that none of the diagrams below contains vanilla bridges because of a
 bug (#32203). (In fact, I discovered this bug by glancing at these
 visualisations and wondering why there are no vanilla bridges.)

 == Requests per bridge types

 [[Image(bridge-types.png, 600px)]]

 [[Image(bridge-types-nontor.png, 600px)]]

 The first diagram suggests that ScrambleSuit and obfs3 are relatively
 popular but once we remove HTTPS requests coming from Tor (which we
 believe to be almost entirely bots), basically only obfs4 remains. Note
 that this visualisation is an aggregate over all distribution mechanisms.
 An average of ~7,500 obfs4 requests per day is a surprisingly large number
 to me. There may very well be more bots among these requests.

 == Requests per distribution mechanism

 [[Image(distribution-mechanisms.png, 600px)]]

 [[Image(distribution-mechanisms-notor.png, 600px)]]

 Again, we can see a significant difference between all requests and
 requests without bots. With bots removed, moat is our most active
 distribution mechanism. Note that in moat it's difficult to tell apart a
 user from a bot request, so this visualisation is assuming that all
 requests are from users, which is probably false.

 == (Un)successful requests per distribution mechanism

 [[Image((un)successful-email.png, 600px)]]

 Most users (assuming that these requests are in fact from users) succeed
 at getting bridges over email. The drop in mid-October was because of a
 bug in BridgeDB (#32105).

 [[Image((un)successful-moat.png, 600px)]]

 Moat is looking worse. A sizable fraction of requests are unsuccessful,
 presumably because of the difficulty of our CAPTCHA.

 [[Image((un)successful-nontor-https.png, 600px)]]

 The situation is similar for HTTPS requests excluding requests over Tor
 (which we believe are bots).

 [[Image((un)successful-tor-https.png, 600px)]]

 HTTPS requests over Tor only are surprisingly successful. These bots are
 likely using a classifier that solves our CAPTCHAs.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31130 [Applications/Tor Browser]: Use Debian 10 for our Android container images

2019-10-22 Thread Tor Bug Tracker & Wiki
#31130: Use Debian 10 for our Android container images
--+
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:  #31127| Points:  0.5
 Reviewer:|Sponsor:
--+

Comment (by sisbell):

 I try to install ca-certificates but still get the same error regarding
 Certificate failed.  I'll need to investigate more. Its installing from
 the following location

 {{{
 Get:3 http://archive.ubuntu.com/ubuntu eoan/main amd64 ca-certificates all
 20190110 [146 kB]
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31736 [Core Tor/Tor]: Stop using mutex_destroy(), when multiple threads can still access the mutex

2019-10-22 Thread Tor Bug Tracker & Wiki
#31736: Stop using mutex_destroy(), when multiple threads can still access the
mutex
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.5
  consider-backport-if-needed, diagnostics,  |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression, |
  BugSmashFund   |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-

Comment (by teor):

 I'm leaning towards "no backport" on this ticket, unless we discover a
 specific bug.
 Leaving open, so we check again after 042-stable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

2019-10-22 Thread Tor Bug Tracker & Wiki
#31594: Close all the log fds before aborting
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, consider-backport-if-   |  Actual Points:  0.9
  needed, consider-backport-after-042-stable,|
  042-should, android, macos, 040-backport-  |
  maybe, 041-backport-maybe, BugSmashFund|
Parent ID:   | Points:  0.3
 Reviewer:  nickm|Sponsor:
-+-

Comment (by teor):

 I'm leaning towards "no backport" on this ticket, unless we discover a
 specific bug.
 Leaving open, so we check again after 042-stable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

2019-10-22 Thread Tor Bug Tracker & Wiki
#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.4
  consider-backport-if-needed, diagnostics,  |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression, |
  BugSmashFund   |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-

Comment (by teor):

 I'm leaning towards "no backport" on this ticket, unless we discover a
 specific bug.
 Leaving open, so we check again after 042-stable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32211 [Core Tor/Tor]: write description of subsystem initialization/shutdown architecture

2019-10-22 Thread Tor Bug Tracker & Wiki
#32211: write description of subsystem initialization/shutdown architecture
-+-
 Reporter:   |  Owner:  (none)
  catalyst   |
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  network-team-roadmap-september,
 Severity:  Normal   |  s31-docs
Actual Points:   |  Parent ID:  #29215
   Points:   |   Reviewer:
  Sponsor:   |
  Sponsor31-must |
-+-


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32210 [Applications/Tor Browser]: Hide the "Tor" section in preferences when TOR_SKIP_LAUNCH=1 is set

2019-10-22 Thread Tor Bug Tracker & Wiki
#32210: Hide the "Tor" section in preferences when TOR_SKIP_LAUNCH=1 is set
-+--
 Reporter:  cypherpunks  |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Component:  Applications/Tor Browser
  Version:   |   Severity:  Normal
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
 In Tor Browser 9.0, there is now a "Tor" section in the preferences. When
 setting the `TOR_SKIP_LAUNCH=1` variable to disable Tor (e.g. if in a
 transparent proxy environment) then the section is still visible on the
 left but clicking on it does nothing. It should be hidden when this
 variable is set to prevent confusion.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31130 [Applications/Tor Browser]: Use Debian 10 for our Android container images

2019-10-22 Thread Tor Bug Tracker & Wiki
#31130: Use Debian 10 for our Android container images
--+
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:  #31127| Points:  0.5
 Reviewer:|Sponsor:
--+

Comment (by boklm):

 Replying to [comment:7 sisbell]:
 > Replying to [comment:5 boklm]:
 > > Replying to [comment:4 sisbell]:
 > > > I kept in stretch for desktop builds, while adding in buster for
 android.
 > > >
 > > > https://github.com/sisbell/tor-browser-
 build/commit/8a39f6de0ea833f63ae00e5d3a6f2e2503a6572a
 > >
 > > I don't think we need to have two different Ubuntu versions to
 generate the images. We could just use Ubuntu 19.10 to generate all
 images.
 > >
 > > >
 > > > The above commit works fine for openjdk-8. When I attempted to add
 pinning I would get some dependency errors and I didn't see any advantage
 to making this more complicated.
 > >
 > > No pinning means that we are not using Debian buster, but Debian
 testing, which is not what we want (and not a good idea for reproducible
 builds as this distribution is changing a lot all the time). From the
 error it looks like `openjdk-8-jre` and `openjdk-8-jdk-headless` need to
 be added to the pinning configuration too.
 > >
 > I do see that without pinning we still use debian stable buster for a
 bunch of libraries (the first 54). I haven't been able to find a
 specification of how it does its resolving in this case (so I guess
 pinning is designed to force certain rules).
 >
 >
 > {{{
 > Get:50 http://deb.debian.org/debian buster/main amd64 libxdmcp-dev amd64
 1:1.1.2-3 [42.2 kB]
 > Get:51 http://deb.debian.org/debian buster/main amd64 xtrans-dev all
 1.3.5-1 [100 kB]
 > Get:52 http://deb.debian.org/debian buster/main amd64 libxcb1-dev amd64
 1.13.1-2 [174 kB]
 > Get:53 http://deb.debian.org/debian buster/main amd64 libxt-dev amd64
 1:1.1.5-1+b3 [426 kB]
 > Get:54 http://deb.debian.org/debian buster/main amd64 xdg-user-dirs
 amd64 0.17-2 [53.8 kB]
 > Get:55 http://ftp.us.debian.org/debian unstable/main amd64 libglib2.0-0
 amd64 2.62.1-1 [1317 kB]
 > Get:56 http://ftp.us.debian.org/debian unstable/main amd64 libwebp6
 amd64 0.6.1-2+b1 [261 kB]
 > 
 > Get:114 http://ftp.us.debian.org/debian unstable/main amd64 libx11-dev
 amd64 2:1.6.8-1 [822 kB]
 > Get:115 http://ftp.us.debian.org/debian unstable/main amd64 openjdk-8
 -jre-headless amd64 8u232-b09-1 [27.2 MB]
 > Get:116 http://ftp.us.debian.org/debian unstable/main amd64
 openjdk-8-jre amd64 8u232-b09-1 [69.7 kB]
 > Get:117 http://ftp.us.debian.org/debian unstable/main amd64 openjdk-8
 -jdk-headless amd64 8u232-b09-1 [8183 kB]
 > Get:118 http://ftp.us.debian.org/debian unstable/main amd64
 openjdk-8-jdk amd64 8u232-b09-1 [1603 kB]
 >
 > }}}

 Those packages are exactly the same version in buster and in unstable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32188 [Applications/Tor Browser]: Missing string in TorStrings.jsm is showing an error in browser console

2019-10-22 Thread Tor Bug Tracker & Wiki
#32188: Missing string in TorStrings.jsm is showing an error in browser console
-+-
 Reporter:  acat |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-9.0-issues tbb-9.0.1-can,|  Actual Points:
  TorBrowserTeam201910R  |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by pospeselr):

 * status:  assigned => needs_review
 * cc: ux-team (added)
 * keywords:  tbb-9.0-issues tbb-9.0.1-can, TorBrowserTeam201910 =>
 tbb-9.0-issues tbb-9.0.1-can, TorBrowserTeam201910R


Comment:

 Updated tor-browser to point to the existing tor-launcher string for the
 'use a proxy' chekbox in about:preferences#tor

 {{{"torsettings.useProxy.checkpox" : "I use a proxy to connect to the
 Internet"}}}

 Alternatively, we could also add a new "Use a local proxy" to tor
 launcher's network-settings.dtd

 tor-browser: https://gitweb.torproject.org/user/richard/tor-
 browser.git/commit/?h=bug_32188

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31091 [Core Tor/Tor]: Bug stracktrace when pluggable transport cannot bind to port

2019-10-22 Thread Tor Bug Tracker & Wiki
#31091: Bug stracktrace when pluggable transport cannot bind to port
-+-
 Reporter:  s7r  |  Owner:  ahf
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Very High|  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  042-must, consider-backport- |  Actual Points:
  after-0424 |
Parent ID:   | Points:
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * keywords:  042-must => 042-must, consider-backport-after-0424


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31130 [Applications/Tor Browser]: Use Debian 10 for our Android container images

2019-10-22 Thread Tor Bug Tracker & Wiki
#31130: Use Debian 10 for our Android container images
--+
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:  #31127| Points:  0.5
 Reviewer:|Sponsor:
--+

Comment (by boklm):

 Replying to [comment:6 sisbell]:

 > > >
 > > > The above commit works fine for openjdk-8. When I attempted to add
 pinning I would get some dependency errors and I didn't see any advantage
 to making this more complicated.
 > >
 > > No pinning means that we are not using Debian buster, but Debian
 testing, which is not what we want (and not a good idea for reproducible
 builds as this distribution is changing a lot all the time). From the
 error it looks like `openjdk-8-jre` and `openjdk-8-jdk-headless` need to
 be added to the pinning configuration too.
 >
 > I had tried pinning the openjdk-8-jre and openjdk-8-headless but got the
 same result, they were missing.

 Maybe the pinning configuration was wrong. But hard to say without seeing
 the actual configuration that was used, and how the openjdk package was
 installed.

 If pinning is too complicate, an other option is to download and install
 the openjdk packages without using apt. In any case, adding the testing
 repository without pinning is not an option, as that just means we're
 using Debian testing and not buster.


 > >
 > > I also think we should not do this configuration in `projects
 /debootstrap-image/config`, but only in the containers that we use for
 android builds, for example by doing it in `var/pre_pkginst` in
 `rbm.conf`.
 >
 > I can move the apt sources change to rbm.conf. Assuming I don't modify
 the pre script in the debootstrap config for the android specific build,
 how is the # Bug 29158 going to be handled? Is this related to stretch or
 to the ubuntu version? Can it be removed now?

 buster was released after `DSA 4371-1`, so it is not affected by this
 issue.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30344 [Core Tor/Tor]: conn_read_callback is called on connections that are marked for closed

2019-10-22 Thread Tor Bug Tracker & Wiki
#30344: conn_read_callback is called on connections that are marked for closed
-+-
 Reporter:  robgjansen   |  Owner:  asn
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.8
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0424, tor-   |  Actual Points:
  conn, 035-backport, 041-deferred-20190530, |
  042-should, nickm-merge, BugSmashFund  |
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by teor):

 * keywords:
 tor-conn, 035-backport, 041-deferred-20190530, 042-should, nickm-
 merge, BugSmashFund
 =>
 consider-backport-after-0424, tor-conn, 035-backport,
 041-deferred-20190530, 042-should, nickm-merge, BugSmashFund


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32209 [Core Tor/Tor]: write description of config subsystem architecture

2019-10-22 Thread Tor Bug Tracker & Wiki
#32209: write description of config subsystem architecture
-+-
 Reporter:   |  Owner:  (none)
  catalyst   |
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  network-team-roadmap-september,
 Severity:  Normal   |  s31-docs
Actual Points:   |  Parent ID:  #29215
   Points:   |   Reviewer:
  Sponsor:   |
  Sponsor31-must |
-+-


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31466 [Core Tor/Tor]: Consider demoting ".exit is disabled" log message to info

2019-10-22 Thread Tor Bug Tracker & Wiki
#31466: Consider demoting ".exit is disabled" log message to info
-+-
 Reporter:  asn  |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0423, bug-   |  Actual Points:  .1
  bounty, hackerone, tor-security?, 042-should   |
  029-backport? 035-backport 040-backport|
  041-backport BugSmashFund dgoulet-merge|
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by teor):

 * keywords:
 bug-bounty, hackerone, tor-security?, 042-should 029-backport?
 035-backport 040-backport 041-backport BugSmashFund dgoulet-merge
 =>
 consider-backport-after-0423, bug-bounty, hackerone, tor-security?,
 042-should 029-backport? 035-backport 040-backport 041-backport
 BugSmashFund dgoulet-merge


Comment:

 Let's wait until the next alpha to backport further

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32208 [Core Tor/Tor]: write description of control subsystem architecture

2019-10-22 Thread Tor Bug Tracker & Wiki
#32208: write description of control subsystem architecture
-+-
 Reporter:   |  Owner:  (none)
  catalyst   |
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  network-team-roadmap-september,
 Severity:  Normal   |  s31-docs
Actual Points:   |  Parent ID:  #29215
   Points:   |   Reviewer:
  Sponsor:   |
  Sponsor31-must |
-+-


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32135 [Circumvention/BridgeDB]: Write BridgeDB metrics parser and analyse existing data

2019-10-22 Thread Tor Bug Tracker & Wiki
#32135: Write BridgeDB metrics parser and analyse existing data
+--
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o21a1   |  Actual Points:
Parent ID:  #31274  | Points:  2
 Reviewer:  |Sponsor:
+--
Changes (by phw):

 * Attachment "(un)successful-tor-https.png" added.

 (Un)successful requests with Tor over HTTPS.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31884 [Core Tor/Tor]: Define ExecuteBash in the Appveyor error block

2019-10-22 Thread Tor Bug Tracker & Wiki
#31884: Define ExecuteBash in the Appveyor error block
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.4.2-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-ci-fail-rarely, 042-can, |  Actual Points:  0.1
  035-backport, 040-backport, 041-backport,  |
  042-backport, consider-backport-after-ci-  |
  passes, BugSmashFund   |
Parent ID:   | Points:  0.1
 Reviewer:  asn  |Sponsor:
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32135 [Circumvention/BridgeDB]: Write BridgeDB metrics parser and analyse existing data

2019-10-22 Thread Tor Bug Tracker & Wiki
#32135: Write BridgeDB metrics parser and analyse existing data
+--
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o21a1   |  Actual Points:
Parent ID:  #31274  | Points:  2
 Reviewer:  |Sponsor:
+--
Changes (by phw):

 * Attachment "(un)successful-nontor-https.png" added.

 (Un)successful requests without Tor over HTTPS.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32207 [Core Tor/Tor]: write description of pub-sub architecture

2019-10-22 Thread Tor Bug Tracker & Wiki
#32207: write description of pub-sub architecture
-+-
 Reporter:   |  Owner:  (none)
  catalyst   |
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  network-team-roadmap-september,
 Severity:  Normal   |  s31-docs
Actual Points:   |  Parent ID:  #29215
   Points:   |   Reviewer:
  Sponsor:   |
  Sponsor31-can  |
-+-


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32207 [Core Tor/Tor]: write description of pub-sub architecture

2019-10-22 Thread Tor Bug Tracker & Wiki
#32207: write description of pub-sub architecture
-+-
 Reporter:  catalyst |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-september,  |  Actual Points:
  s31-docs   |
Parent ID:  #29215   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor31-must
-+-
Changes (by catalyst):

 * sponsor:  Sponsor31-can => Sponsor31-must


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32135 [Circumvention/BridgeDB]: Write BridgeDB metrics parser and analyse existing data

2019-10-22 Thread Tor Bug Tracker & Wiki
#32135: Write BridgeDB metrics parser and analyse existing data
+--
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o21a1   |  Actual Points:
Parent ID:  #31274  | Points:  2
 Reviewer:  |Sponsor:
+--
Changes (by phw):

 * Attachment "(un)successful-moat.png" added.

 (Un)successful requests over moat.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32135 [Circumvention/BridgeDB]: Write BridgeDB metrics parser and analyse existing data

2019-10-22 Thread Tor Bug Tracker & Wiki
#32135: Write BridgeDB metrics parser and analyse existing data
+--
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o21a1   |  Actual Points:
Parent ID:  #31274  | Points:  2
 Reviewer:  |Sponsor:
+--
Changes (by phw):

 * Attachment "(un)successful-nontor-https.png" added.

 (Un)successful requests over HTTPS.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32135 [Circumvention/BridgeDB]: Write BridgeDB metrics parser and analyse existing data

2019-10-22 Thread Tor Bug Tracker & Wiki
#32135: Write BridgeDB metrics parser and analyse existing data
+--
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o21a1   |  Actual Points:
Parent ID:  #31274  | Points:  2
 Reviewer:  |Sponsor:
+--
Changes (by phw):

 * Attachment "(un)successful-email.png" added.

 (Un)successful requests over email.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32086 [Core Tor/Tor]: Try Visual Studio 2019 image in appveyor

2019-10-22 Thread Tor Bug Tracker & Wiki
#32086: Try Visual Studio 2019 image in appveyor
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci, consider-backport-   |  implemented
  immediately, 035-backport, 040-backport,   |  Actual Points:  0.1
  041-backport, 042-backport |
Parent ID:   | Points:  0.1
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by teor):

 * milestone:  Tor: 0.4.3.x-final => Tor: 0.3.5.x-final


Comment:

 Please move backported tickets to the earliest backport milestone.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32135 [Circumvention/BridgeDB]: Write BridgeDB metrics parser and analyse existing data

2019-10-22 Thread Tor Bug Tracker & Wiki
#32135: Write BridgeDB metrics parser and analyse existing data
+--
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o21a1   |  Actual Points:
Parent ID:  #31274  | Points:  2
 Reviewer:  |Sponsor:
+--
Changes (by phw):

 * Attachment "distribution-mechanisms-notor.png" added.

 Requests per distribution mechanisms (without Tor over HTTPS).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32135 [Circumvention/BridgeDB]: Write BridgeDB metrics parser and analyse existing data

2019-10-22 Thread Tor Bug Tracker & Wiki
#32135: Write BridgeDB metrics parser and analyse existing data
+--
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o21a1   |  Actual Points:
Parent ID:  #31274  | Points:  2
 Reviewer:  |Sponsor:
+--
Changes (by phw):

 * Attachment "distribution-mechanisms.png" added.

 Requests per distribution mechanisms.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31615 [Core Tor/Tor]: Reorder the early subsystems based on their dependencies

2019-10-22 Thread Tor Bug Tracker & Wiki
#31615: Reorder the early subsystems based on their dependencies
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  diagnostics, consider-backport-  |  Actual Points:  0.3
  after-042-stable, consider-backport-if-|
  needed, 042-should, 040-no-backport, 041-no-   |
  backport, BugSmashFund, dgoulet-merge  |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * keywords:
 diagnostics, consider-backport-after-042-stable, consider-backport-if-
 needed, 042-should, 040-backport-maybe, 041-backport-maybe,
 BugSmashFund, dgoulet-merge
 =>
 diagnostics, consider-backport-after-042-stable, consider-backport-if-
 needed, 042-should, 040-no-backport, 041-no-backport, BugSmashFund,
 dgoulet-merge


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32135 [Circumvention/BridgeDB]: Write BridgeDB metrics parser and analyse existing data

2019-10-22 Thread Tor Bug Tracker & Wiki
#32135: Write BridgeDB metrics parser and analyse existing data
+--
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o21a1   |  Actual Points:
Parent ID:  #31274  | Points:  2
 Reviewer:  |Sponsor:
+--
Changes (by phw):

 * Attachment "bridge-types-nontor.png" added.

 Requests per bridge types (without Tor over HTTPS).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32170 [Core Tor/Tor]: update geoip && geoip6 to October 15 2019 database

2019-10-22 Thread Tor Bug Tracker & Wiki
#32170: update geoip && geoip6 to October 15 2019 database
-+
 Reporter:  teor |  Owner:  nickm
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  wontfix
 Keywords:  extra-review, tor-geoip  |  Actual Points:
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+
Changes (by teor):

 * keywords:
 extra-review, tor-geoip, 029-backport, 035-backport, 040-backport,
 041-backport, 042-backport
 => extra-review, tor-geoip


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32135 [Circumvention/BridgeDB]: Write BridgeDB metrics parser and analyse existing data

2019-10-22 Thread Tor Bug Tracker & Wiki
#32135: Write BridgeDB metrics parser and analyse existing data
+--
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o21a1   |  Actual Points:
Parent ID:  #31274  | Points:  2
 Reviewer:  |Sponsor:
+--
Changes (by phw):

 * Attachment "bridge-types.png" added.

 Requests per bridge types.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32206 [Core Tor/Tor]: write high-level outline of target modular tor architecture

2019-10-22 Thread Tor Bug Tracker & Wiki
#32206: write high-level outline of target modular tor architecture
-+-
 Reporter:  catalyst |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-september,  |  Actual Points:
  s31-docs   |
Parent ID:  #29215   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor31-must
-+-
Changes (by catalyst):

 * sponsor:   => Sponsor31-must


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32206 [Core Tor/Tor]: write high-level outline of target modular tor architecture

2019-10-22 Thread Tor Bug Tracker & Wiki
#32206: write high-level outline of target modular tor architecture
-+-
 Reporter:   |  Owner:  (none)
  catalyst   |
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  network-team-roadmap-september,
 Severity:  Normal   |  s31-docs
Actual Points:   |  Parent ID:  #29215
   Points:   |   Reviewer:
  Sponsor:   |
-+-


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32187 [Core Tor/Tor]: Clean up options_validate() interface

2019-10-22 Thread Tor Bug Tracker & Wiki
#32187: Clean up options_validate() interface
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .1
Parent ID:  #31241| Points:  .3
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+

Comment (by teor):

 Replying to [comment:2 nickm]:
 > Travis has passed; appveyor is being incredibly slow.

 Appveyor is the same speed that it always was.
 But Travis is much faster :-)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32195 [Core Tor/Tor]: Rename net_is_disabled, net_is_completely_disabled, and PERIODIC_EVENT_FLAG_NEED_NET

2019-10-22 Thread Tor Bug Tracker & Wiki
#32195: Rename net_is_disabled, net_is_completely_disabled, and
PERIODIC_EVENT_FLAG_NEED_NET
+
 Reporter:  nickm   |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  High|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+

Comment (by teor):

 #17543 is an outdated version of this ticket.

 It also mentions DisableNetwork and we_are_hibernating().

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17543 [Core Tor/Tor]: Bring some clarity to behavior of net_is_disabled() vs DisableNetwork vs we_are_hibernating()

2019-10-22 Thread Tor Bug Tracker & Wiki
#17543: Bring some clarity to behavior of net_is_disabled() vs DisableNetwork vs
we_are_hibernating()
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-client sponsor8-maybe|  duplicate
  technical-debt refactor|  Actual Points:
Parent ID:  #32195   | Points:  medium
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  new => closed
 * resolution:   => duplicate
 * parent:   => #32195


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32188 [Applications/Tor Browser]: Missing string in TorStrings.jsm is showing an error in browser console

2019-10-22 Thread Tor Bug Tracker & Wiki
#32188: Missing string in TorStrings.jsm is showing an error in browser console
-+-
 Reporter:  acat |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-9.0-issues tbb-9.0.1-can,|  Actual Points:
  TorBrowserTeam201910   |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by pospeselr):

 * owner:  tbb-team => pospeselr
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32205 [Applications/Tor Browser]: Implement tor-button changes needed to take advantage of improved bridge info query API in tor

2019-10-22 Thread Tor Bug Tracker & Wiki
#32205: Implement tor-button changes needed to take advantage of improved bridge
info query API in tor
--+--
 Reporter:  pospeselr |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:  #31279
   Points:  2 |   Reviewer:
  Sponsor:  Sponsor30 |
--+--
 Some changes to tor-button will be needed to properly display the
 information of user-provided bridges without a fingerprint in the circuit
 display. Whichever path outlined in #32204 is done, the work needed in Tor
 Browser is a minimal amount of javascript in tor-button.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31130 [Applications/Tor Browser]: Use Debian 10 for our Android container images

2019-10-22 Thread Tor Bug Tracker & Wiki
#31130: Use Debian 10 for our Android container images
--+
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:  #31127| Points:  0.5
 Reviewer:|Sponsor:
--+

Comment (by sisbell):

 Replying to [comment:5 boklm]:
 > Replying to [comment:4 sisbell]:
 > > I kept in stretch for desktop builds, while adding in buster for
 android.
 > >
 > > https://github.com/sisbell/tor-browser-
 build/commit/8a39f6de0ea833f63ae00e5d3a6f2e2503a6572a
 >
 > I don't think we need to have two different Ubuntu versions to generate
 the images. We could just use Ubuntu 19.10 to generate all images.
 >
 > >
 > > The above commit works fine for openjdk-8. When I attempted to add
 pinning I would get some dependency errors and I didn't see any advantage
 to making this more complicated.
 >
 > No pinning means that we are not using Debian buster, but Debian
 testing, which is not what we want (and not a good idea for reproducible
 builds as this distribution is changing a lot all the time). From the
 error it looks like `openjdk-8-jre` and `openjdk-8-jdk-headless` need to
 be added to the pinning configuration too.
 >
 I do see that without pinning we still use debian stable buster for a
 bunch of libraries (the first 54). I haven't been able to find a
 specification of how it does its resolving in this case (so I guess
 pinning is designed to force certain rules).


 {{{
 Get:50 http://deb.debian.org/debian buster/main amd64 libxdmcp-dev amd64
 1:1.1.2-3 [42.2 kB]
 Get:51 http://deb.debian.org/debian buster/main amd64 xtrans-dev all
 1.3.5-1 [100 kB]
 Get:52 http://deb.debian.org/debian buster/main amd64 libxcb1-dev amd64
 1.13.1-2 [174 kB]
 Get:53 http://deb.debian.org/debian buster/main amd64 libxt-dev amd64
 1:1.1.5-1+b3 [426 kB]
 Get:54 http://deb.debian.org/debian buster/main amd64 xdg-user-dirs amd64
 0.17-2 [53.8 kB]
 Get:55 http://ftp.us.debian.org/debian unstable/main amd64 libglib2.0-0
 amd64 2.62.1-1 [1317 kB]
 Get:56 http://ftp.us.debian.org/debian unstable/main amd64 libwebp6 amd64
 0.6.1-2+b1 [261 kB]
 
 Get:114 http://ftp.us.debian.org/debian unstable/main amd64 libx11-dev
 amd64 2:1.6.8-1 [822 kB]
 Get:115 http://ftp.us.debian.org/debian unstable/main amd64 openjdk-8-jre-
 headless amd64 8u232-b09-1 [27.2 MB]
 Get:116 http://ftp.us.debian.org/debian unstable/main amd64 openjdk-8-jre
 amd64 8u232-b09-1 [69.7 kB]
 Get:117 http://ftp.us.debian.org/debian unstable/main amd64 openjdk-8-jdk-
 headless amd64 8u232-b09-1 [8183 kB]
 Get:118 http://ftp.us.debian.org/debian unstable/main amd64 openjdk-8-jdk
 amd64 8u232-b09-1 [1603 kB]

 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32204 [Core Tor/Tor]: Create either a query or event-based API to allow controllers (particularly Tor Browser) to reliably get circuit information

2019-10-22 Thread Tor Bug Tracker & Wiki
#32204: Create either a query or event-based API to allow controllers 
(particularly
Tor Browser) to reliably get circuit information
--+
 Reporter:  pospeselr |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:  #31279
   Points:|   Reviewer:
  Sponsor:  Sponsor30 |
--+
 Currently we can not get the address or type of a bridge by id/fingerprint
 if the bridge entry in torrc does not have the fingerprint string
 provided. This info is needed for the circuit display in Tor Browser,
 which currently just displays 'Bridge' without the address or type
 information.

 Tor Browser currently gets the circuit display information by first
 requesting the circuit for a given first-party domain/nonce pair. This
 returns an array of fingerprints. We then get the list of bridges stored
 in the torrc file via  {{{GETCONF bridge}}}. We compare each bridge's id
 to each node in the circuit. If a match if sound we know the node is a
 bridge and we display its information. Otherwise, we assume it is a relay
 and we query the information from tor via {{{GETINFO
 ns/id/$fingerprint}}}.

 With the change in #32125 we now infer that if the GETINFO call fails,
 it's because the id we've received is actually a Bridge whose info we do
 not know.

 Some possible options:

  - Tor updates the torrc with the Bridge's fingerprint once it is known.
 Tor Browser's logic doesn't change but there will be a window when a user
 looking at the circuit display will just see 'Bridge' rather than the full
 set of information.
  - Tor adds a new query API that allows us to get Bridge information in a
 similar fashion to how we currently get relay information. The repeated
 GETCONF for bridges goes away and we now for each id in the circuit, we
 just try querying bridge info and if that fails we then query relay info.
  - Tor Browser listens for the 'figured out the fingerprint for this
 bridge event' (which I believe currently just logs?) and maintains some
 in-memory map/cache of fingerprint to { type, ip, geolocation }. I'd
 really rather not do this.
  - Add a 'verbose' circuit query API, where we just provide the
 domain/nonce pair and you give us the required data all at once. This
 would simplify Tor Browser code and would require less back-and-forth
 between tor and Tor Browser.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32203 [Circumvention/BridgeDB]: BridgeDB doesn't create metrics for vanilla bridges

2019-10-22 Thread Tor Bug Tracker & Wiki
#32203: BridgeDB doesn't create metrics for vanilla bridges
+
 Reporter:  phw |  Owner:  phw
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o21a1   |  Actual Points:
Parent ID:  #31274  | Points:  0.25
 Reviewer:  cohosh  |Sponsor:  Sponsor30-must
+
Changes (by phw):

 * status:  assigned => needs_review
 * reviewer:   => cohosh


Comment:

 I have a patch in my
 [https://github.com/NullHypothesis/bridgedb/compare/develop...fix/32203
 fix/32203 branch].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32187 [Core Tor/Tor]: Clean up options_validate() interface

2019-10-22 Thread Tor Bug Tracker & Wiki
#32187: Clean up options_validate() interface
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .1
Parent ID:  #31241| Points:  .3
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by nickm):

 * status:  assigned => needs_review


Comment:

 Travis has passed; appveyor is being incredibly slow.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32203 [Circumvention/BridgeDB]: BridgeDB doesn't create metrics for vanilla bridges

2019-10-22 Thread Tor Bug Tracker & Wiki
#32203: BridgeDB doesn't create metrics for vanilla bridges
+---
 Reporter:  phw |  Owner:  phw
 Type:  defect  | Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  |   Keywords:  s30-o21a1
Actual Points:  |  Parent ID:  #31274
   Points:  0.25|   Reviewer:
  Sponsor:  Sponsor30-must  |
+---
 The metrics.py module uses code like the following to weed out invalid
 transport protocols. Unfortunately, this is also weeding out "vanilla",
 which results in BridgeDB not counting vanilla bridges:

 {{{
 if not isTransportSupported(bridgeType):
 logging.warning("User requested unsupported transport type %s "
 "over HTTPS." % bridgeType)
 return
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30881 [Internal Services/Tor Sysadmin Team]: answer the opsreportcard questionnaire, AKA the "limoncelli test"

2019-10-22 Thread Tor Bug Tracker & Wiki
#30881: answer the opsreportcard questionnaire, AKA the "limoncelli test"
-+-
 Reporter:  anarcat  |  Owner:  anarcat
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by anarcat):

 i designed a service docs template in here:

 https://help.torproject.org/tsa/howto/template/

 it's quite exhaustive and most documentation don't have all fields, but it
 gives us a good thing to copy-paste from.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31764 [Applications/Tor Browser]: Copying a link and using "Paste & Go" results in error

2019-10-22 Thread Tor Bug Tracker & Wiki
#31764: Copying a link and using "Paste & Go" results in error
-+-
 Reporter:  gk   |  Owner:
 |  pospeselr
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff68-esr, tbb-9.0-issues, tbb-   |  Actual Points:  0.25
  regression, tbb-9.0.1-can, |
  TorBrowserTeam201910R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by pospeselr):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Mozilla bug:

 https://bugzilla.mozilla.org/show_bug.cgi?id=1590538

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31130 [Applications/Tor Browser]: Use Debian 10 for our Android container images

2019-10-22 Thread Tor Bug Tracker & Wiki
#31130: Use Debian 10 for our Android container images
--+
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:  #31127| Points:  0.5
 Reviewer:|Sponsor:
--+

Comment (by sisbell):

 Replying to [comment:5 boklm]:
 > Replying to [comment:4 sisbell]:
 > > I kept in stretch for desktop builds, while adding in buster for
 android.
 > >
 > > https://github.com/sisbell/tor-browser-
 build/commit/8a39f6de0ea833f63ae00e5d3a6f2e2503a6572a
 >
 > I don't think we need to have two different Ubuntu versions to generate
 the images. We could just use Ubuntu 19.10 to generate all images.
 Ok I can change this.

 >
 > >
 > > The above commit works fine for openjdk-8. When I attempted to add
 pinning I would get some dependency errors and I didn't see any advantage
 to making this more complicated.
 >
 > No pinning means that we are not using Debian buster, but Debian
 testing, which is not what we want (and not a good idea for reproducible
 builds as this distribution is changing a lot all the time). From the
 error it looks like `openjdk-8-jre` and `openjdk-8-jdk-headless` need to
 be added to the pinning configuration too.

 I had tried pinning the openjdk-8-jre and openjdk-8-headless but got the
 same result, they were missing.
 >
 > I also think we should not do this configuration in `projects
 /debootstrap-image/config`, but only in the containers that we use for
 android builds, for example by doing it in `var/pre_pkginst` in
 `rbm.conf`.

 I can move the apt sources change to rbm.conf. Assuming I don't modify the
 pre script in the debootstrap config for the android specific build, how
 is the # Bug 29158 going to be handled? Is this related to stretch or to
 the ubuntu version? Can it be removed now?

 >
 > > Also trying to use snapshot with pinning resulted in
 > >
 > >
 > > {{{
 > > Starting build: Mon Oct 21 23:03:49 2019
 > > Hit:1 http://deb.debian.org/debian buster InRelease
 > > Get:2 http://deb.debian.org/debian buster/main Translation-en [5967
 kB]
 > > Ign:3 https://snapshot.debian.org sid InRelease
 > > Err:4 https://snapshot.debian.org sid Release
 > >   Certificate verification failed: The certificate is NOT trusted. The
 certificate issuer is unknown.  Could not handshake: Error in the
 certificate verification. [IP: 185.17.185.185 443]
 > > Reading package lists...
 > > W: https://snapshot.debian.org/dists/sid/InRelease: No system
 certificates available. Try installing ca-certificates.
 > > W: https://snapshot.debian.org/dists/sid/Release: No system
 certificates available. Try installing ca-certificates.
 > > E: The repository 'https://snapshot.debian.org sid Release' does not
 have a Release file.
 > > }}}
 > >
 >
 > Did you try installing `ca-certificates` as suggested in the error
 message?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31653 [Core Tor/Tor]: Padding cells sent with 0ms delay cause circuit failures

2019-10-22 Thread Tor Bug Tracker & Wiki
#31653: Padding cells sent with 0ms delay cause circuit failures
-+-
 Reporter:  pulls|  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.5
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad circpad-researchers-want |  Actual Points:
  042-should |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by pulls):

 For 1, I would guess it's mostly due to how people collect traces and do
 evaluation, but as is the case for 2, I don't really know. As discussed
 for the simulator, I think the first order of business is to get
 reasonably efficient machines that can defend against deep learning
 attacks without time and then take it from there.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32202 [Applications/Tor Browser]: white header and footer

2019-10-22 Thread Tor Bug Tracker & Wiki
#32202: white header and footer
+--
 Reporter:  rsstnce17   |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  Medium  |  Component:  Applications/Tor Browser
  Version:  Tor: 0.4.1.6|   Severity:  Normal
 Keywords:  white, header,  |  Actual Points:
  footer|
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
 seems to be a white header and footer on every page after i updated...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32202 [Applications/Tor Browser]: white header and footer

2019-10-22 Thread Tor Bug Tracker & Wiki
#32202: white header and footer
--+--
 Reporter:  rsstnce17 |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:  Tor: 0.4.1.6
 Severity:  Normal| Resolution:
 Keywords:  white, header, footer |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by rsstnce17):

 * Attachment "torimg.png" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

  1   2   3   >