Re: [tor-bugs] #32606 [Applications/Tor Browser]: Set up default bridge at Georgetown University

2019-11-27 Thread Tor Bug Tracker & Wiki
#32606: Set up default bridge at Georgetown University
+
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  tbb-bridges, TorBrowserTeam201911R  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+
Changes (by gk):

 * keywords:  tbb-bridges => tbb-bridges, TorBrowserTeam201911R
 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks, looks good to me. Merged to `tor-browser-build`'s `master` (commit
 b7c78701ed87062a5daa6a8d634da98873ad10dd) and cherry-picked to its
 `maint-9.0` (commit d8033881110e0717ef5c9d4e2265b0b8c79d9b7d).

 The `tor-android-service` change got merged to `master` (commit
 3d3de669452f563f3f7b58f57f757f7a7cdae621), too.

 I bumped the `tor-android-service` commits used in our builds (commit
 8d61174e8400449388260b18876d9f189d3a2152 (`master`) and
 9b96257a1720851159372ab03cdbd2726b21e55b (`maint-9.0`))

 The bridge will be available in 9.5a3 and likely in 9.0.3.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31130 [Applications/Tor Browser]: Use Debian 10 for our Android container images

2019-11-27 Thread Tor Bug Tracker & Wiki
#31130: Use Debian 10 for our Android container images
---+---
 Reporter:  gk |  Owner:  sisbell
 Type:  defect | Status:
   |  needs_revision
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201911  |  Actual Points:
Parent ID:  #31127 | Points:  0.5
 Reviewer: |Sponsor:
---+---

Comment (by gk):

 Replying to [comment:51 boklm]:
 > Replying to [comment:50 gk]:
 > > Replying to [comment:48 sisbell]:
 > > > Looks like we just need one additional dependency installed for the
 JDK headless installation. I verified a full build.
 > > >
 > > > https://github.com/sisbell/tor-browser-
 build/commit/005b6651ba42737c7e1bd177f01286294355c02f
 > >
 > > Okay, we are close. Looking over the patch again I see you are
 pointing to `https://deb.debian.org/debian/pool/main/o/openjdk-8` for the
 openjdk packages. However, that seems to be brittle to me as it's easily
 conceivable that our version is getting superseded by newer updates in the
 couple of weeks, essentially getting unavailable. Better is using
 `snapshot.debian.org` (e.g.
 
https://snapshot.debian.org/archive/debian/20191031T212011Z/pool/main/o/openjdk-8/).
 >
 > As it's an update for a stable distribution, I think previous versions
 of the packages are not removed from mirrors (until the whole suite is
 removed, which I think will not be before 2022 for stretch). So I think
 using `https://deb.debian.org/` is fine (but using snapshot.debian.org is
 fine too).

 I think you are wrong here. Have a look at

 
https://snapshot.debian.org/archive/debian/20191001T024204Z/pool/main/o/openjdk-8/
 and
 
https://snapshot.debian.org/archive/debian/20191031T212011Z/pool/main/o/openjdk-8/

 in the former you still find `8u232-b04` binaries but not the latter right
 now there are `8u232-b09-1~deb9u1` ones *instead* of the former which the
 stable archive mirrors but it seems that's not guaranteed to hold. That is
 there seems to be no reason to assume that `8u232-b09-1~deb9u1` could not
 get replaced in the future by a successor, which is why I think we should
 go the snapshot route to be on the safe side.

 > > boklm: anything else that should get fixed?
 >
 > I did not try to do a build yet, but the patch looks good to me.
 >
 > I think we should also check that the creation of `wheezy-amd64` and
 `stretch-amd64` images in `debootstrap-image` is still working correctly
 with the updated Ubuntu version.

 Yes, please.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32633 [Community]: Installed Office Setup

2019-11-27 Thread Tor Bug Tracker & Wiki
#32633: Installed Office Setup
---+--
 Reporter:  Office05   |  Owner:  ggus
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Community  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by Office05):

 * Attachment "ms office.png" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32633 [Community]: Installed Office Setup

2019-11-27 Thread Tor Bug Tracker & Wiki
#32633: Installed Office Setup
--+---
 Reporter:  Office05  |  Owner:  ggus
 Type:  defect| Status:  new
 Priority:  Medium|  Component:  Community
  Version:|   Severity:  Normal
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
 Microsoft word used to write Letters, blogs, Stories, And documents
 related to Work. Microsoft Excel Use to Work an Excel sheet Accounts-
 related Work and other Microsoft office use. visit:-https://office-
 product-key-setup.com/  ]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32346 [Internal Services/Service - deb.tpo]: What is proper release name at Tor Debian Repository for Ubuntu Bionic 18.04?

2019-11-27 Thread Tor Bug Tracker & Wiki
#32346: What is proper release name at Tor Debian Repository for Ubuntu Bionic
18.04?
-+-
 Reporter:  sectua1  |  Owner:  weasel
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - deb.tpo  |Version:
 Severity:  Normal   | Resolution:
 |  worksforme
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arma):

 I've also seen some folks recommend "lsb_release -c" for learning what
 your distro's codename is called.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31531 [Core Tor/Tor]: Make control_event_conf_changed() take a smartlist of config_line_t

2019-11-27 Thread Tor Bug Tracker & Wiki
#31531: Make control_event_conf_changed() take a smartlist of config_line_t
--+
 Reporter:  teor  |  Owner:  neel
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor:
  |  0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  technical-debt, extra-review  |  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:  catalyst  |Sponsor:  Sponsor31-can
--+
Changes (by teor):

 * keywords:  technical-debt => technical-debt, extra-review


Comment:

 Hi, I'm marking this pull request as needing extra review, because it's
 from an external contributor.

 The merger should do another review before they merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32627 [Core Tor/Tor]: deploy torspec as HTML to GitLab Pages

2019-11-27 Thread Tor Bug Tracker & Wiki
#32627: deploy torspec as HTML to GitLab Pages
--+
 Reporter:  eighthave |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  torspec, doc  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * keywords:  torspec => torspec, doc
 * type:  defect => enhancement
 * component:  Core Tor => Core Tor/Tor
 * milestone:   => Tor: 0.4.3.x-final


Comment:

 Thanks for this code!

 I think we'd prefer python to sed, but I'll leave that to the reviewer to
 decide.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32398 [Core Tor/Stem]: Stem str/bytes confusion on error

2019-11-27 Thread Tor Bug Tracker & Wiki
#32398: Stem str/bytes confusion on error
---+
 Reporter:  teor   |  Owner:  atagar
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by teor):

 You need to make test_take_ownership_via_controller fail, and be running
 python 3.

 One way to make test_take_ownership_via_controller fail is to run the stem
 tests with tor that has #32339 and #32344, but not #32399.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32405 [Applications/Tor Browser]: Crash immediately after bootstrap on Android

2019-11-27 Thread Tor Bug Tracker & Wiki
#32405: Crash immediately after bootstrap on Android
-+-
 Reporter:  sysrqb   |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-crash, tbb-9.0-issues,   |  Actual Points:
  TorBrowserTeam201911R  |
Parent ID:   | Points:  .25
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 As a note, when I imported to github it flagged 4 security vulnerabilities
 in the tor-browser libraries. Github automatically created pull requests
 for them.

 https://github.com/sisbell/tor-browser/pulls

 Security Issues
 https://github.com/advisories/GHSA-rprw-h62v-c2w7
 https://github.com/advisories/GHSA-3gx7-xhv7-5mx3
 https://github.com/advisories/GHSA-x84v-xcm2-53pg
 https://github.com/advisories/GHSA-mh33-7rrq-662w

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32626 [Core Tor/Tor]: Remove extra space in #define in ed25519-donna-portable-identify.h

2019-11-27 Thread Tor Bug Tracker & Wiki
#32626: Remove extra space in #define in ed25519-donna-portable-identify.h
--+---
 Reporter:  neel  |  Owner:  neel
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:  ahf   |Sponsor:
--+---
Changes (by teor):

 * cc: nickm (added)
 * status:  merge_ready => needs_information


Comment:

 Sorry, I don't think we change anything in `src/ext` ?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32405 [Applications/Tor Browser]: Crash immediately after bootstrap on Android

2019-11-27 Thread Tor Bug Tracker & Wiki
#32405: Crash immediately after bootstrap on Android
-+-
 Reporter:  sysrqb   |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-crash, tbb-9.0-issues,   |  Actual Points:
  TorBrowserTeam201911R  |
Parent ID:   | Points:  .25
 Reviewer:   |Sponsor:
-+-
Changes (by sisbell):

 * status:  assigned => needs_review
 * keywords:  tbb-crash, tbb-9.0-issues, TorBrowserTeam201911 => tbb-crash,
 tbb-9.0-issues, TorBrowserTeam201911R
 * points:   => .25


Comment:

 I wasn't able to do a full clone of the tor-browser repo on github due to
 2GB repo size limitation on github. I took the branch tor-
 browser-68.2.0esr-9.5-1 (without history) and made the following commit.

 https://github.com/sisbell/tor-
 browser/commit/170876b6516539fef0580eeec9ae7ac252863eaf

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30590 [Internal Services/Service - deb.tpo]: Ubuntu packages for 0.4.0.5 unavailable

2019-11-27 Thread Tor Bug Tracker & Wiki
#30590: Ubuntu packages for 0.4.0.5 unavailable
-+
 Reporter:  highflux7|  Owner:  weasel
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - deb.tpo  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by teor):

 * status:  new => closed
 * type:  defect => task
 * component:  Core Tor/Tor => Internal Services/Service - deb.tpo
 * version:  Tor: 0.4.0.5 =>
 * milestone:  Tor: 0.4.0.x-final =>
 * owner:  (none) => weasel
 * resolution:   => fixed


Comment:

 This is fixed now.

 You're probably best to email the tor-relays or tor-talk lists about
 issues like this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32346 [Internal Services/Service - deb.tpo]: What is proper release name at Tor Debian Repository for Ubuntu Bionic 18.04?

2019-11-27 Thread Tor Bug Tracker & Wiki
#32346: What is proper release name at Tor Debian Repository for Ubuntu Bionic
18.04?
-+-
 Reporter:  sectua1  |  Owner:  weasel
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - deb.tpo  |Version:
 Severity:  Normal   | Resolution:
 |  worksforme
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  new => closed
 * resolution:   => worksforme
 * component:  Applications => Internal Services/Service - deb.tpo
 * type:  enhancement => task
 * owner:  (none) => weasel


Comment:

 It should be "bionic":
 https://deb.torproject.org/torproject.org/dists/bionic/

 If you're having trouble, you will probably get better help on the mailing
 lists:
 * tor-relays if you're trying to configure a relay
 * tor-talk otherwise
 https://lists.torproject.org/cgi-bin/mailman/listinfo

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32631 [Core Tor/Chutney]: Chutney Travis: Use the latest dependencies

2019-11-27 Thread Tor Bug Tracker & Wiki
#32631: Chutney Travis: Use the latest dependencies
--+--
 Reporter:  teor  |  Owner:  teor
 Type:  task  | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Core Tor/Chutney  |Version:
 Severity:  Normal|   Keywords:
Actual Points:  0.1   |  Parent ID:
   Points:  0.5   |   Reviewer:
  Sponsor:|
--+--
 Use the latest dependencies in Chutney Travis:
 * Linux and macOS images
 * tor versions
 * python versions

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32632 [Core Tor/Fallback Scripts]: Fallback Scripts Travis: Use the latest dependencies

2019-11-27 Thread Tor Bug Tracker & Wiki
#32632: Fallback Scripts Travis: Use the latest dependencies
---+--
 Reporter:  teor   |  Owner:  teor
 Type:  task   | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Core Tor/Fallback Scripts  |Version:
 Severity:  Normal |   Keywords:
Actual Points:  0.1|  Parent ID:
   Points:  0.5|   Reviewer:
  Sponsor: |
---+--
 Use the latest dependencies in Chutney Travis:
 * Linux and macOS images
 * python versions

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31639 [Core Tor/Chutney]: When Travis updates the homebrew cache in their images, stop updating it in .travis.yml

2019-11-27 Thread Tor Bug Tracker & Wiki
#31639: When Travis updates the homebrew cache in their images, stop updating 
it in
.travis.yml
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Chutney |Version:
 Severity:  Normal   | Resolution:
 Keywords:  merge-after-travis-image-update, |  Actual Points:  0
  tor-hs, ipv6, single-onion, fast-fix,  |
  chutney-ci |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Still failing. Updating to the latest macOS image in #32241 didn't fix
 this issue, either.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32630 [Core Tor/Tor]: Chutney Travis: Make chutney work on Xenial and Bionic images

2019-11-27 Thread Tor Bug Tracker & Wiki
#32630: Chutney Travis: Make chutney work on Xenial and Bionic images
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  chutney-ci
Actual Points:|  Parent ID:  #32240
   Points:  0.1   |   Reviewer:
  Sponsor:|
--+
 If we fix #32240 in Tor, we should do the same thing for Chutney's Travis
 config.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32240 [Core Tor/Tor]: Tor Travis: Make chutney work on Xenial and Bionic images (was: Travis: Make chutney work on Xenial and Bionic images)

2019-11-27 Thread Tor Bug Tracker & Wiki
#32240: Tor Travis: Make chutney work on Xenial and Bionic images
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci, chutney, 043-should, |  Actual Points:
  029-backport, 035-backport, 040-backport,  |
  041-backport, 042-backport |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32629 [Core Tor/Tor]: Re-enable 1 or 2 more macOS jobs in Travis

2019-11-27 Thread Tor Bug Tracker & Wiki
#32629: Re-enable 1 or 2 more macOS jobs in Travis
--+
 Reporter:  teor  |  Owner:  teor
 Type:  task  | Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  tor-ci
Actual Points:|  Parent ID:
   Points:  0.2   |   Reviewer:
  Sponsor:|
--+
 Reverts #32177.

 We might need to merge or disable some jobs, to get builds to finish fast
 enough.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32500 [Core Tor/Tor]: consider clang -std=gnu99 in Travis for better C99 portability

2019-11-27 Thread Tor Bug Tracker & Wiki
#32500: consider clang -std=gnu99 in Travis for better C99 portability
-+-
 Reporter:  catalyst |  Owner:  teor
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  portability, tor-ci, 029-backport,   |  Actual Points:  0.5
  035-backport, 040-backport, 041-backport,  |
  042-backport   |
Parent ID:   | Points:  0.1
 Reviewer:  catalyst |Sponsor:
 |  Sponsor31-can
-+-
Changes (by teor):

 * actualpoints:  0.3 => 0.5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32500 [Core Tor/Tor]: consider clang -std=gnu99 in Travis for better C99 portability

2019-11-27 Thread Tor Bug Tracker & Wiki
#32500: consider clang -std=gnu99 in Travis for better C99 portability
-+-
 Reporter:  catalyst |  Owner:  teor
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  portability, tor-ci, 029-backport,   |  Actual Points:  0.3
  035-backport, 040-backport, 041-backport,  |
  042-backport   |
Parent ID:   | Points:  0.1
 Reviewer:  catalyst |Sponsor:
 |  Sponsor31-can
-+-
Changes (by teor):

 * status:  merge_ready => needs_review


Comment:

 We were using the trusty gcc for all our builds until about a month ago
 :-)

 I'm going to experiment with using the NSS gcc in later Tor versions.
 There are two advantages:
 * we'll test the NSS-specific code with `-std=gnu99`
 * we'll get a later gcc version

 Same PRs and tests as before, but it only affects 0.3.5 and later.

 (Thanks for your patience with this ticket!)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31859 [Core Tor/Tor]: Delete similar CI jobs

2019-11-27 Thread Tor Bug Tracker & Wiki
#31859: Delete similar CI jobs
--+
 Reporter:  teor  |  Owner:  teor
 Type:  task  | Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  tor-design|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:  Sponsor27-can
--+
Changes (by teor):

 * sponsor:   => Sponsor27-can
 * parent:  #30860 =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31756 [Core Tor/Tor]: Cover all configuration options with test_parseconf.sh

2019-11-27 Thread Tor Bug Tracker & Wiki
#31756: Cover all configuration options with test_parseconf.sh
--+--
 Reporter:  nickm |  Owner:  (none)
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by teor):

 We made significant progress on this task as part of Sponsor 31, adding
 support for alternate results for:
 * relay and dirauth modules
 * lzma, zstd, and nss libraries

 We could add support for additional platforms in a similar way.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32606 [Applications/Tor Browser]: Set up default bridge at Georgetown University

2019-11-27 Thread Tor Bug Tracker & Wiki
#32606: Set up default bridge at Georgetown University
--+--
 Reporter:  phw   |  Owner:  phw
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-bridges   |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:
--+--
Changes (by phw):

 * status:  assigned => needs_review


Comment:

 * My task/32606 branch [https://github.com/NullHypothesis/tor-browser-
 build/commit/b7c78701ed87062a5daa6a8d634da98873ad10dd has a patch] for
 tor-browser-build.
 * My task/32606 branch [https://github.com/NullHypothesis/tor-android-
 service/commit/3d3de669452f563f3f7b58f57f757f7a7cdae621 has a patch] for
 tor-android-service.

 I also added another row to
 [https://trac.torproject.org/projects/tor/wiki/doc/TorBrowser/DefaultBridges
 our list of default bridges] and updated our
 [https://dip.torproject.org/torproject/anti-censorship/sysmon-
 configuration/commit/7a5dd4188f467d0eb07d1fdea631eb721f1d2ff8
 sysmon.conf].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32522 [Core Tor/Tor]: Create better tooling for canonical tor header includes

2019-11-27 Thread Tor Bug Tracker & Wiki
#32522: Create better tooling for canonical tor header includes
---+---
 Reporter:  teor   |  Owner:  teor
 Type:  task   | Status:  assigned
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  network-team-roadmap-november  |  Actual Points:  4
Parent ID:  #31851 | Points:  1
 Reviewer: |Sponsor:  Sponsor31-can
---+---
Changes (by teor):

 * actualpoints:  0.8 => 4


Comment:

 There's still some work to do here, but I should have a PR ready for
 review soon. I found a lot of interesting bugs and inconsistencies along
 the way, see the child tickets.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31157 [Circumvention/Snowflake]: Collect metrics about what type of proxies are running

2019-11-27 Thread Tor Bug Tracker & Wiki
#31157: Collect metrics about what type of proxies are running
-+-
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  enhancement  | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  anti-censorship-roadmap-october  |  Actual Points:  1
Parent ID:   | Points:  3
 Reviewer:  phw  |Sponsor:  Sponsor28
-+-
Changes (by phw):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:8 cohosh]:
 > Thanks! Pushed some changes.
 [[br]]
 The changes are all well done!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32480 [Applications/GetTor]: Use Github/Gitlab releases to distribute gettor binaries

2019-11-27 Thread Tor Bug Tracker & Wiki
#32480: Use Github/Gitlab releases to distribute gettor binaries
-+-
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  github, releases |  Actual Points:  .5
Parent ID:   | Points:  1
 Reviewer:  phw  |Sponsor:
-+-
Changes (by phw):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:10 cohosh]:
 > Right now this script is run manually, but this is something we should
 definitely do if/when it is automated in the future. I'm not quite sure
 how to handle this since I don't want an error to stop the update script
 and start over when it is run again. This wastes a lot of bandwidth and
 time. My current thought is that we can print out the missing releases in
 a log file and manually upload them later, but that's not a very elegant
 solution.
 [[br]]
 How about we make the script more robust by making it re-attempt failed
 downloads and uploads two or three times? We may still have to fix issues
 manually on occasion but I would expect this to eliminate the majority of
 transient issues.

 Also, commit
 
[https://dip.torproject.org/cohosh/gettor/commit/ee8d5a85ff6388a27c6aecadcaec3d7c6c920ec6
 ee8d5a85] looks good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31130 [Applications/Tor Browser]: Use Debian 10 for our Android container images

2019-11-27 Thread Tor Bug Tracker & Wiki
#31130: Use Debian 10 for our Android container images
---+---
 Reporter:  gk |  Owner:  sisbell
 Type:  defect | Status:
   |  needs_revision
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201911  |  Actual Points:
Parent ID:  #31127 | Points:  0.5
 Reviewer: |Sponsor:
---+---

Comment (by boklm):

 Replying to [comment:50 gk]:
 > Replying to [comment:48 sisbell]:
 > > Looks like we just need one additional dependency installed for the
 JDK headless installation. I verified a full build.
 > >
 > > https://github.com/sisbell/tor-browser-
 build/commit/005b6651ba42737c7e1bd177f01286294355c02f
 >
 > Okay, we are close. Looking over the patch again I see you are pointing
 to `https://deb.debian.org/debian/pool/main/o/openjdk-8` for the openjdk
 packages. However, that seems to be brittle to me as it's easily
 conceivable that our version is getting superseded by newer updates in the
 couple of weeks, essentially getting unavailable. Better is using
 `snapshot.debian.org` (e.g.
 
https://snapshot.debian.org/archive/debian/20191031T212011Z/pool/main/o/openjdk-8/).

 As it's an update for a stable distribution, I think previous versions of
 the packages are not removed from mirrors (until the whole suite is
 removed, which I think will not be before 2022 for stretch). So I think
 using `https://deb.debian.org/` is fine (but using snapshot.debian.org is
 fine too).

 > boklm: anything else that should get fixed?

 I did not try to do a build yet, but the patch looks good to me.

 I think we should also check that the creation of `wheezy-amd64` and
 `stretch-amd64` images in `debootstrap-image` is still working correctly
 with the updated Ubuntu version.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32365 [Applications/Tor Browser]: Localization is broken in Tor Browser 9 on Android

2019-11-27 Thread Tor Bug Tracker & Wiki
#32365: Localization is broken in Tor Browser 9 on Android
-+-
 Reporter:  gk   |  Owner:  sysrqb
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  tbb-9.0-issues, tbb-9.0-regression,  |  Actual Points:
  TorBrowserTeam201911R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 sysrqb: please add your points.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31531 [Core Tor/Tor]: Make control_event_conf_changed() take a smartlist of config_line_t

2019-11-27 Thread Tor Bug Tracker & Wiki
#31531: Make control_event_conf_changed() take a smartlist of config_line_t
+
 Reporter:  teor|  Owner:  neel
 Type:  defect  | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  catalyst|Sponsor:  Sponsor31-can
+
Changes (by catalyst):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:9 neel]:
 > Fixed it.
 Thanks! Looks good now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32365 [Applications/Tor Browser]: Localization is broken in Tor Browser 9 on Android

2019-11-27 Thread Tor Bug Tracker & Wiki
#32365: Localization is broken in Tor Browser 9 on Android
-+-
 Reporter:  gk   |  Owner:  sysrqb
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  tbb-9.0-issues, tbb-9.0-regression,  |  Actual Points:
  TorBrowserTeam201911R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks. I fixed a typo in the comment (to avoid another round-trip) and
 picked the fix onto `master` (commit
 4f97d497ea11a8325cafeaec6ac51fb10ef56de1) and `maint-9.0` (commit
 54091ab8d4a431458105d2be5346ac5232fea265). It should be available in 9.5a3
 and 9.0.2

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32505 [Applications/Tor Browser]: Tighten our rules in our entitlements file for macOS

2019-11-27 Thread Tor Bug Tracker & Wiki
#32505: Tighten our rules in our entitlements file for macOS
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-security, tbb-sign,  |  Actual Points:  0.1
  GeorgKoppen201911, TorBrowserTeam201911R,  |
  tbb-backport   |
Parent ID:  #32504   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-security, tbb-sign, GeorgKoppen201911,
 TorBrowserTeam201911R =>
 tbb-security, tbb-sign, GeorgKoppen201911, TorBrowserTeam201911R, tbb-
 backport


Comment:

 Oh, and this is a candidate for backporting.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32505 [Applications/Tor Browser]: Tighten our rules in our entitlements file for macOS

2019-11-27 Thread Tor Bug Tracker & Wiki
#32505: Tighten our rules in our entitlements file for macOS
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-security, tbb-sign,  |  Actual Points:  0.1
  GeorgKoppen201911, TorBrowserTeam201911R   |
Parent ID:  #32504   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:5 mcs]:
 > r=mcs
 > This looks good to me (I assume you did not intend to change the ticket
 status away from `needs_review` and that was just Trac "being helpful")

 Yeah, Trac cheated on me. Thanks for the review. This is applied to
 `master` (commit e01d78d95fa019b9418e17ac03b3b26e655d6cd9) now and will be
 used for notarizing 9.5a3.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31718 [Internal Services/Tor Sysadmin Team]: Update DNS records for .ooni.torproject.org domains

2019-11-27 Thread Tor Bug Tracker & Wiki
#31718: Update DNS records for .ooni.torproject.org domains
-+-
 Reporter:  hellais  |  Owner:  anarcat
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by anarcat):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 i removed the ooni user and group now as well, and the files are gone.
 we're all clear now, closing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30788 [Applications/Tor Browser]: Ship Malay (ms) Tor Browser in alpha series

2019-11-27 Thread Tor Bug Tracker & Wiki
#30788: Ship Malay (ms) Tor Browser in alpha series
--+--
 Reporter:  emmapeel  |  Owner:  gk
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201911R |  Actual Points:  0.25
Parent ID:  #29935| Points:  0.25
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * keywords:  TorBrowserTeam201911 => TorBrowserTeam201911R
 * status:  assigned => needs_review
 * actualpoints:   => 0.25


Comment:

 Okay, the problem was that `ms-MY` was used by the translator for the
 strings but there was `ms`, too, which had some missing. Now things look
 good. Here are the patched for review:
 `torbutton`: `bug_30788`
 
(https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_30788=23384413a31148a41856557b1632e8eb1e4d2f3d)
 `tor-launcher`: `` (https://gitweb.torproject.org/user/gk/tor-
 launcher.git/commit/?h=bug_30788=ec26d714fab1b6431646fce93fb94160e210d96d)
 `tor-browser-build`: `bug_30788_v2` (https://gitweb.torproject.org/user/gk
 /tor-browser-
 build.git/commit/?h=bug_30788_v2=e1b07e3ee6b7c47fe72b1e187909598081b5efdd)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32576 [Circumvention/Snowflake]: Fix race condition in snowflake broker

2019-11-27 Thread Tor Bug Tracker & Wiki
#32576: Fix race condition in snowflake broker
-+--
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  defect   | Status:  needs_review
 Priority:  Very High|  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics  |  Actual Points:  1
Parent ID:   | Points:
 Reviewer:  phw  |Sponsor:  Sponsor28
-+--

Comment (by phw):

 This looks good. I left a review on your GitHub pull request. I had a
 minor suggestion and a question regarding the scope of what needs to be
 protected by a lock.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32473 [Metrics/Exit Scanner]: Evaluate the results from the exitmap based scanner compared to the current exit lists system

2019-11-27 Thread Tor Bug Tracker & Wiki
#32473: Evaluate the results from the exitmap based scanner compared to the 
current
exit lists system
--+--
 Reporter:  irl   |  Owner:  metrics-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Metrics/Exit Scanner  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by irl):

 Replying to [comment:3 karsten]:
 > I compared those exit lists from the new exit scanner (only 2019-11-26
 or later) to the ones published by the old exit scanner from the same time
 frame. I attached my output file that organizes scan results by
 fingerprint. Some observations:
 >
 >  - The new scanner omits a handful relays that the old scanner scanned.
 I assume this is related to exit policies? The absolute number of these
 cases is rather low, but please take a look, too (at the beginning of the
 output file).

 These are all exit policy related. The current implementation requires
 port 443 to be allowed. A future version, with the help of TSA and
 iptables, could work around this limitation. It looks like the current
 scanner starts a listener on port 80 but I don't know Haskell enough to
 understand what it is doing.

 >  - The vast majority of scans (over 1,000) result in the same exit
 address. There are just 6 relays with 2 or more exit addresses by either
 old or new scanner. It's hard to say which scanner is right here. Maybe
 it's just relays on dynamic IPs or with multiple IP addresses. Please take
 a look at these (grep for "exit addresses total").

 These look like dynamic IPs, I can't see anything that would suggest
 otherwise.

 >  - Looks like the new scanner doesn't properly clear old scan results.
 I'm only looking at results from 2019-11-26 and later, and yet there are
 scan results from 2019-11-19 and 2019-11-20. This seems like a (small)
 bug.

 Yes, I'd disabled that to test merging with an older file, I'll uncomment
 that code again. (:

 > That's all. Overall, I think that these results are as close to the
 current scanner as they can get. If we can resolve that one bug and get
 your confirmation that the other two things are normal, I think we're good
 to go.

 Awesome!

 I will hopefully wrap up #32264 tonight and then #32265 tomorrow, and then
 deploy to AWS over the weekend to evaluate again before asking TPA for a
 machine.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32618 [Applications/Tor Browser]: Backport 1467970 and 1590526

2019-11-27 Thread Tor Bug Tracker & Wiki
#32618: Backport 1467970 and 1590526
--+--
 Reporter:  sysrqb|  Owner:  gk
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201911R |  Actual Points:  0.2
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by sysrqb):

 * cc: tbb-team (added)
 * status:  needs_review => assigned
 * owner:  tbb-team => gk


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32618 [Applications/Tor Browser]: Backport 1467970 and 1590526

2019-11-27 Thread Tor Bug Tracker & Wiki
#32618: Backport 1467970 and 1590526
--+--
 Reporter:  sysrqb|  Owner:  gk
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201911R |  Actual Points:  0.2
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by sysrqb):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32365 [Applications/Tor Browser]: Localization is broken in Tor Browser 9 on Android

2019-11-27 Thread Tor Bug Tracker & Wiki
#32365: Localization is broken in Tor Browser 9 on Android
-+-
 Reporter:  gk   |  Owner:  sysrqb
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-9.0-issues, tbb-9.0-regression,  |  Actual Points:
  TorBrowserTeam201911R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * keywords:  tbb-9.0-issues, tbb-9.0-regression, TorBrowserTeam201911 =>
 tbb-9.0-issues, tbb-9.0-regression, TorBrowserTeam201911R
 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32547 [Applications/Tor Browser]: Set up default bridge at the University of Minnesota

2019-11-27 Thread Tor Bug Tracker & Wiki
#32547: Set up default bridge at the University of Minnesota
--+--
 Reporter:  phw   |  Owner:  phw
 Type:  task  | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-bridges   |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:
--+--
Changes (by phw):

 * cc: singh882@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31960 [Circumvention/Snowflake]: Hello, currently, in China, Tor Browser 9.0a7 version can't establish a Tor network connection through snowflake bridge

2019-11-27 Thread Tor Bug Tracker & Wiki
#31960: Hello, currently, in China, Tor Browser 9.0a7 version can't establish a 
Tor
network connection through snowflake bridge
-+--
 Reporter:  amiableclarity2011   |  Owner:  cohosh
 Type:  defect   | Status:  assigned
 Priority:  Immediate|  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by phw):

 Thanks for your feedback, amiableclarity2011! We can provide you with a
 private obfs4 bridge which should work in China. Just send an email to phw
 at torproject dot org.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32626 [Core Tor/Tor]: Remove extra space in #define in ed25519-donna-portable-identify.h

2019-11-27 Thread Tor Bug Tracker & Wiki
#32626: Remove extra space in #define in ed25519-donna-portable-identify.h
--+-
 Reporter:  neel  |  Owner:  neel
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:  ahf   |Sponsor:
--+-
Changes (by ahf):

 * status:  needs_review => merge_ready
 * reviewer:   => ahf


Comment:

 LGTM. I also don't think this needs a changes file. Thanks for the patch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27265 [Applications/rbm]: In some cases, rbm will download files in the wrong project directory

2019-11-27 Thread Tor Bug Tracker & Wiki
#27265: In some cases, rbm will download files in the wrong project directory
+--
 Reporter:  boklm   |  Owner:  boklm
 Type:  defect  | Status:
|  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/rbm|Version:
 Severity:  Normal  | Resolution:
 Keywords:  boklm201811, TorBrowserTeam201911R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by boklm):

 In branch `bug_27265_v4` I rebased the two patches on master:
 
https://gitweb.torproject.org/user/boklm/rbm.git/commit/?h=bug_27265_v4=03d53fcb0444fe9d752719bfbb62e3658d15d26d

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32473 [Metrics/Exit Scanner]: Evaluate the results from the exitmap based scanner compared to the current exit lists system

2019-11-27 Thread Tor Bug Tracker & Wiki
#32473: Evaluate the results from the exitmap based scanner compared to the 
current
exit lists system
--+--
 Reporter:  irl   |  Owner:  metrics-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Metrics/Exit Scanner  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by karsten):

 I compared those exit lists from the new exit scanner (only 2019-11-26 or
 later) to the ones published by the old exit scanner from the same time
 frame. I attached my output file that organizes scan results by
 fingerprint. Some observations:

  - The new scanner omits a handful relays that the old scanner scanned. I
 assume this is related to exit policies? The absolute number of these
 cases is rather low, but please take a look, too (at the beginning of the
 output file).

  - The vast majority of scans (over 1,000) result in the same exit
 address. There are just 6 relays with 2 or more exit addresses by either
 old or new scanner. It's hard to say which scanner is right here. Maybe
 it's just relays on dynamic IPs or with multiple IP addresses. Please take
 a look at these (grep for "exit addresses total").

  - Looks like the new scanner doesn't properly clear old scan results. I'm
 only looking at results from 2019-11-26 and later, and yet there are scan
 results from 2019-11-19 and 2019-11-20. This seems like a (small) bug.

 That's all. Overall, I think that these results are as close to the
 current scanner as they can get. If we can resolve that one bug and get
 your confirmation that the other two things are normal, I think we're good
 to go.

 And glad to hear that you have found a way for including published/last
 status times!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32198 [Internal Services/Services Admin Team]: upgrade CRM* machines to buster

2019-11-27 Thread Tor Bug Tracker & Wiki
#32198: upgrade CRM* machines to buster
-+-
 Reporter:  anarcat  |  Owner:  hiro
 Type:  task | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Services Admin |Version:
  Team   |
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by hiro):

 [ ] Createa node to the FSN cluster and replicate functionality of the crm
 VM
 [ ] Have all the configuration in puppet
 [ ] Copy current setup to the new node and test that everything is working
 [ ] Start decommissioning old crm VM

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32473 [Metrics/Exit Scanner]: Evaluate the results from the exitmap based scanner compared to the current exit lists system

2019-11-27 Thread Tor Bug Tracker & Wiki
#32473: Evaluate the results from the exitmap based scanner compared to the 
current
exit lists system
--+--
 Reporter:  irl   |  Owner:  metrics-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Metrics/Exit Scanner  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by karsten):

 * Attachment "task-32473-analysis.txt" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32597 [Circumvention/Snowflake]: Hello, currently, in China, Tor Browser 9.5a2 still can't connect to Tor network through snowflake bridge

2019-11-27 Thread Tor Bug Tracker & Wiki
#32597: Hello, currently, in China, Tor Browser 9.5a2 still can't connect to Tor
network through snowflake bridge
-+
 Reporter:  amiableclarity2011   |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Immediate|  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by cohosh):

 Thanks, can you try connecting multiple times (say, like 10 times) and let
 me know if you ever bootstrap past 10%?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29259 [Circumvention/Snowflake]: Ensure high test coverage for Snowflake

2019-11-27 Thread Tor Bug Tracker & Wiki
#29259: Ensure high test coverage for Snowflake
---+---
 Reporter:  ahf|  Owner:  cohosh
 Type:  task   | Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Circumvention/Snowflake|Version:
 Severity:  Normal | Resolution:
 Keywords:  anti-censorship-roadmap-september  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
   |  Sponsor28-must
---+---

Comment (by cohosh):

 Okay I added a few code coverage visualizations. Obviously that's not the
 full story here, but I'm going to recommend calling this ticket done and
 then making another ticket that focuses on integration-style tests. This
 will be a bit tricker to do but I have some ideas of how to do it with
 snowbox. I do manual testing with snowbox before PRs and I have an idea on
 how to automate that. Since it's already in a docker container we can
 probably loop that into our CI.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29259 [Circumvention/Snowflake]: Ensure high test coverage for Snowflake

2019-11-27 Thread Tor Bug Tracker & Wiki
#29259: Ensure high test coverage for Snowflake
---+---
 Reporter:  ahf|  Owner:  cohosh
 Type:  task   | Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Circumvention/Snowflake|Version:
 Severity:  Normal | Resolution:
 Keywords:  anti-censorship-roadmap-september  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
   |  Sponsor28-must
---+---
Changes (by cohosh):

 * Attachment "common-safelog-coverage.html" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29259 [Circumvention/Snowflake]: Ensure high test coverage for Snowflake

2019-11-27 Thread Tor Bug Tracker & Wiki
#29259: Ensure high test coverage for Snowflake
---+---
 Reporter:  ahf|  Owner:  cohosh
 Type:  task   | Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Circumvention/Snowflake|Version:
 Severity:  Normal | Resolution:
 Keywords:  anti-censorship-roadmap-september  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
   |  Sponsor28-must
---+---
Changes (by cohosh):

 * Attachment "client-lib-coverage.html" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29259 [Circumvention/Snowflake]: Ensure high test coverage for Snowflake

2019-11-27 Thread Tor Bug Tracker & Wiki
#29259: Ensure high test coverage for Snowflake
---+---
 Reporter:  ahf|  Owner:  cohosh
 Type:  task   | Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Circumvention/Snowflake|Version:
 Severity:  Normal | Resolution:
 Keywords:  anti-censorship-roadmap-september  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
   |  Sponsor28-must
---+---
Changes (by cohosh):

 * Attachment "common-messages-coverage.html" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29259 [Circumvention/Snowflake]: Ensure high test coverage for Snowflake

2019-11-27 Thread Tor Bug Tracker & Wiki
#29259: Ensure high test coverage for Snowflake
---+---
 Reporter:  ahf|  Owner:  cohosh
 Type:  task   | Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Circumvention/Snowflake|Version:
 Severity:  Normal | Resolution:
 Keywords:  anti-censorship-roadmap-september  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
   |  Sponsor28-must
---+---
Changes (by cohosh):

 * Attachment "broker-coverage.html" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29259 [Circumvention/Snowflake]: Ensure high test coverage for Snowflake

2019-11-27 Thread Tor Bug Tracker & Wiki
#29259: Ensure high test coverage for Snowflake
---+---
 Reporter:  ahf|  Owner:  cohosh
 Type:  task   | Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Circumvention/Snowflake|Version:
 Severity:  Normal | Resolution:
 Keywords:  anti-censorship-roadmap-september  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
   |  Sponsor28-must
---+---
Changes (by cohosh):

 * Attachment "client-coverage.html" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29259 [Circumvention/Snowflake]: Ensure high test coverage for Snowflake

2019-11-27 Thread Tor Bug Tracker & Wiki
#29259: Ensure high test coverage for Snowflake
---+---
 Reporter:  ahf|  Owner:  cohosh
 Type:  task   | Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Circumvention/Snowflake|Version:
 Severity:  Normal | Resolution:
 Keywords:  anti-censorship-roadmap-september  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
   |  Sponsor28-must
---+---
Changes (by cohosh):

 * status:  assigned => needs_review


Comment:

 Here are some test additions and touch-ups to existing go unit testing
 code: https://github.com/cohosh/snowflake/pull/16

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32365 [Applications/Tor Browser]: Localization is broken in Tor Browser 9 on Android

2019-11-27 Thread Tor Bug Tracker & Wiki
#32365: Localization is broken in Tor Browser 9 on Android
-+-
 Reporter:  gk   |  Owner:  sysrqb
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-9.0-issues, tbb-9.0-regression,  |  Actual Points:
  TorBrowserTeam201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sysrqb):

 Replying to [comment:8 gk]:
 > Replying to [comment:6 sysrqb]:
 > > Okay, i think option (3) is the more simple. We only need `./mach
 android assemble-app`. I also filtered `mk` from the locale list. Branch
 `bug32365_02`.
 >
 > Thanks! I assume the change got introduced in
 https://bugzilla.mozilla.org/show_bug.cgi?id=1443208 and looking at that
 bug your patch looks good. However, I don't think we should filter `mk` as
 you do. *If* we do the filtering no `mk` content is shown. But if we don't
 do it then at least the Torbutton parts (like the `about:tor` page) *are*
 localized if you have an `mk` device. I'd argue that is a win. We probably
 should put a comment above the part where you filtered `mk` as this
 behavior is not obvious.

 That makes sense. I created a new branch reflecting these changes.
 `bug32365_03`

 >
 > What bothers me is that the locale is still not properly propagated to
 our `about:tor` page and fundraising parts. It's just the default link
 that's visible unless you switch the locale. But then after restart you
 see the same again. We should file a ticket for that and get this fixed
 for the next release.

 I debugged this. It is cause by two problems.

 1. In `aboutTor-content.js`:`onPageLoad` we only track changes of
 `intl.locale.os`, however, in Fennec the locale may be set by either
 `intl.locale.os` or `intl.locale.requested`.

 1. When `about:tor` is loaded, `onLocaleChange` is called before
 `onChromeDataUpdate`, therefore the
 `content.document.body.getAttribute("mobile")` conditional in
 `onLocaleChange` is always `undefined` at the first page load.

 I opened #32628 for this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32628 [Applications/Tor Browser]: about:tor is not always localized on Android

2019-11-27 Thread Tor Bug Tracker & Wiki
#32628: about:tor is not always localized on Android
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 See ticket:32365#comment:8 for background. The locale is not correctly
 propagated within about:tor.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32500 [Core Tor/Tor]: consider clang -std=gnu99 in Travis for better C99 portability

2019-11-27 Thread Tor Bug Tracker & Wiki
#32500: consider clang -std=gnu99 in Travis for better C99 portability
-+-
 Reporter:  catalyst |  Owner:  teor
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  portability, tor-ci, 029-backport,   |  Actual Points:  0.3
  035-backport, 040-backport, 041-backport,  |
  042-backport   |
Parent ID:   | Points:  0.1
 Reviewer:  catalyst |Sponsor:
 |  Sponsor31-can
-+-
Changes (by catalyst):

 * status:  needs_revision => merge_ready


Comment:

 Replying to [comment:12 teor]:
 > Thanks for helping diagnose that. I merged the two env lists, and re-
 merged all the branches.
 >
 > (I couldn't find another matrix entry, most of the rest of them disable
 large amounts of code.)
 >
 > Here are the PRs for review:
 > * 0.2.9: ​​https://github.com/torproject/tor/pull/1539
 > * 0.3.5: ​​https://github.com/torproject/tor/pull/1540
 >
 > Test branches are here:
 > * ​https://travis-ci.org/teor2345/tor/branches
 Thanks! This looks good now. The main drawback I can think of using for
 the chutney matrix entry is that we'll be using the gcc in Trusty, rather
 than something newer. Maybe it'll be OK.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31823 [Core Tor/Stem]: HSv3 descriptor support in stem [encoding]

2019-11-27 Thread Tor Bug Tracker & Wiki
#31823: HSv3 descriptor support in stem [encoding]
-+-
 Reporter:  asn  |  Owner:  atagar
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Stem|Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-hs scaling onionbalance  |  Actual Points:  2
  network-team-roadmap-september tor-spec|
Parent ID:  #26768   | Points:  5
 Reviewer:   |Sponsor:
-+-
Changes (by asn):

 * status:  needs_revision => closed
 * resolution:   => fixed


Comment:

 Damian, this looks really good now!

 I think we can safely close this ticket and I will open new tickets if I
 find any new bugs, or need any changes.

 Thanks a lot for all your work

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32616 [Applications/Tor Browser]: disable GetSecureOutputDirectoryPath() functionality

2019-11-27 Thread Tor Bug Tracker & Wiki
#32616: disable GetSecureOutputDirectoryPath() functionality
--+
 Reporter:  mcs   |  Owner:  mcs
 Type:  defect| Status:
  |  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-update,TorBrowserTeam201911R  |  Actual Points:  0.1
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by mcs):

 * actualpoints:   => 0.1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32505 [Applications/Tor Browser]: Tighten our rules in our entitlements file for macOS (was: Tighten our rules in our entitelements file for macOS)

2019-11-27 Thread Tor Bug Tracker & Wiki
#32505: Tighten our rules in our entitlements file for macOS
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-security, tbb-sign,  |  Actual Points:  0.1
  GeorgKoppen201911, TorBrowserTeam201911R   |
Parent ID:  #32504   | Points:
 Reviewer:   |Sponsor:
-+-

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32505 [Applications/Tor Browser]: Tighten our rules in our entitelements file for macOS

2019-11-27 Thread Tor Bug Tracker & Wiki
#32505: Tighten our rules in our entitelements file for macOS
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-security, tbb-sign,  |  Actual Points:  0.1
  GeorgKoppen201911, TorBrowserTeam201911R   |
Parent ID:  #32504   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 r=mcs
 This looks good to me (I assume you did not intend to change the ticket
 status away from `needs_review` and that was just Trac "being helpful")

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23545 [Applications/Tor Browser]: UX improvement: Tor Browser should handle bogus HSv3 addresses

2019-11-27 Thread Tor Bug Tracker & Wiki
#23545: UX improvement: Tor Browser should handle bogus HSv3 addresses
-+-
 Reporter:  asn  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224, ux-team,|  Actual Points:
  034-triage-20180328, 034-removed-20180328  | Points:
Parent ID:  #30022   |  network-team: 5-10
 Reviewer:   |Sponsor:
 |  Sponsor27-must
-+-

Comment (by asn):

 Ticket #32546 has been merged to little-t-tor so the TB team is now ready
 to work on this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32020 [Core Tor/Tor]: hsv3: Client do not report failing circuit back into HS subsystem

2019-11-27 Thread Tor Bug Tracker & Wiki
#32020: hsv3: Client do not report failing circuit back into HS subsystem
+
 Reporter:  dgoulet |  Owner:  dgoulet
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  tor-hs, tor-client  |  Actual Points:  1
Parent ID:  #30200  | Points:  1
 Reviewer:  asn |Sponsor:  Sponsor27-must
+
Changes (by asn):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Merged! Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27265 [Applications/rbm]: In some cases, rbm will download files in the wrong project directory

2019-11-27 Thread Tor Bug Tracker & Wiki
#27265: In some cases, rbm will download files in the wrong project directory
+--
 Reporter:  boklm   |  Owner:  boklm
 Type:  defect  | Status:
|  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/rbm|Version:
 Severity:  Normal  | Resolution:
 Keywords:  boklm201811, TorBrowserTeam201911R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by boklm):

 In branch `test-for-bug_27265` I added a test to reproduce the issue:
 https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h
 =test-for-bug_27265=8366b8e550dde2ef0ccd85defc70c51368560e80

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32020 [Core Tor/Tor]: hsv3: Client do not report failing circuit back into HS subsystem

2019-11-27 Thread Tor Bug Tracker & Wiki
#32020: hsv3: Client do not report failing circuit back into HS subsystem
+
 Reporter:  dgoulet |  Owner:  dgoulet
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, tor-client  |  Actual Points:  1
Parent ID:  #30200  | Points:  1
 Reviewer:  asn |Sponsor:  Sponsor27-must
+

Comment (by asn):

 OK. Please find latest PR here:
 https://github.com/torproject/tor/pull/1573

 It squashed the latest branch, removed the reverted commits, fixed a typo
 (wrods -> words), and improved a bit the changes file (to clarify that the
 reachability delta is positive).

 I made a PR just to make sure that CI passes. I will merge when it
 finishes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32485 [Applications/Tor Browser]: Dead obfs4 Bridges on Tor Browser Android

2019-11-27 Thread Tor Bug Tracker & Wiki
#32485: Dead obfs4 Bridges on Tor Browser Android
--+--
 Reporter:  torify|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201911  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * status:  needs_information => new


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32485 [Applications/Tor Browser]: Dead obfs4 Bridges on Tor Browser Android

2019-11-27 Thread Tor Bug Tracker & Wiki
#32485: Dead obfs4 Bridges on Tor Browser Android
--+---
 Reporter:  torify|  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201911  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by torify):

 My attachment is from 2019/11 and those screenshots are from older
 versions. I tried now again but TBA stuck at 30% (loading_status) step and
 i received ''"NOTICE: No circuits are opened. Relaxed timeout for circuit
 4 (a General-purpose client 1-hop circuit in state doing handshakes with
 channel state open) to 6ms. However, it appears the circuit has timed
 out anyway."'' notification message again like in log file.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32505 [Applications/Tor Browser]: Tighten our rules in our entitelements file for macOS

2019-11-27 Thread Tor Bug Tracker & Wiki
#32505: Tighten our rules in our entitelements file for macOS
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-security, tbb-sign,  |  Actual Points:  0.1
  GeorgKoppen201911, TorBrowserTeam201911R   |
Parent ID:  #32504   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * owner:  tbb-team => gk
 * cc: tbb-team (added)
 * status:  needs_review => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32505 [Applications/Tor Browser]: Tighten our rules in our entitelements file for macOS

2019-11-27 Thread Tor Bug Tracker & Wiki
#32505: Tighten our rules in our entitelements file for macOS
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-security, tbb-sign,  |  Actual Points:  0.1
  GeorgKoppen201911, TorBrowserTeam201911R   |
Parent ID:  #32504   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-security, tbb-sign, GeorgKoppen201911R => tbb-security,
 tbb-sign, GeorgKoppen201911, TorBrowserTeam201911R


Comment:

 Writing the patch and reviewing it is not smart.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32485 [Applications/Tor Browser]: Dead obfs4 Bridges on Tor Browser Android

2019-11-27 Thread Tor Bug Tracker & Wiki
#32485: Dead obfs4 Bridges on Tor Browser Android
--+---
 Reporter:  torify|  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201911  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by torify):

 * Attachment "TBA-log" added.

 Tor Browser Android Connection Log File

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32485 [Applications/Tor Browser]: Dead obfs4 Bridges on Tor Browser Android

2019-11-27 Thread Tor Bug Tracker & Wiki
#32485: Dead obfs4 Bridges on Tor Browser Android
--+---
 Reporter:  torify|  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201911  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by torify):

 Replying to [comment:6 sysrqb]:
 > Apparently some networks (country? countries?) are blocking this bridge.

 Yes, i am living in a restricted country and my country blocked Tor
 network, torproject.org domains and more.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32505 [Applications/Tor Browser]: Tighten our rules in our entitelements file for macOS

2019-11-27 Thread Tor Bug Tracker & Wiki
#32505: Tighten our rules in our entitelements file for macOS
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-security, tbb-sign,  |  Actual Points:  0.1
  GeorgKoppen201911R |
Parent ID:  #32504   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * actualpoints:   => 0.1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32505 [Applications/Tor Browser]: Tighten our rules in our entitelements file for macOS

2019-11-27 Thread Tor Bug Tracker & Wiki
#32505: Tighten our rules in our entitelements file for macOS
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-security, tbb-sign,  |  Actual Points:
  GeorgKoppen201911R |
Parent ID:  #32504   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  new => needs_review
 * keywords:  tbb-security, tbb-sign, GeorgKoppen201911 => tbb-security,
 tbb-sign, GeorgKoppen201911R


Comment:

 `bug_32505` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_32505=8e0320bd568f1c5697418498aa1e18b7e34a9207)
 has a proposed fix fir the alpha entitlements file.

 I think we should keep the apple-events entitlement as Mozilla ships it
 for now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30787 [Applications/Tor Browser]: Ship Lithuanian Tor Browser in alpha series

2019-11-27 Thread Tor Bug Tracker & Wiki
#30787: Ship Lithuanian Tor Browser in alpha series
--+--
 Reporter:  emmapeel  |  Owner:  gk
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201911R |  Actual Points:  0.25
Parent ID:  #29935| Points:  0.25
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32422 [Internal Services/Service - git]: Add boklm as a gitolite admin

2019-11-27 Thread Tor Bug Tracker & Wiki
#32422: Add boklm as a gitolite admin
-+
 Reporter:  sysrqb   |  Owner:  tor-gitadm
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by irl):

 I would like to suggest waiting for ahf to be up to speed first, and then
 see if we still need more.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32607 [Internal Services/Service - git]: adjust push access for the Tor Browser git repos

2019-11-27 Thread Tor Bug Tracker & Wiki
#32607: adjust push access for the Tor Browser git repos
-+
 Reporter:  mcs  |  Owner:  tor-gitadm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by irl):

 * status:  needs_information => closed
 * resolution:   => fixed


Comment:

 {{{
 @tor-browser = boklm brade gk mcs sysrqb
 --
 repo builders/tor-browser-build
 RW   = @tor-browser
 --
 repo builders/rbm
 RW   = @tor-browser
 --
 repo tor-browser
 RW   = @tor-browser
 --
 repo tor-browser-bundle-testsuite
 RW   = @tor-browser
 --
 repo tor-browser-spec
 RW   = @tor-browser
 --
 repo tor-launcher
 RW   = @tor-browser
 --
 repo torbutton
 RW   = @tor-browser
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32422 [Internal Services/Service - git]: Add boklm as a gitolite admin

2019-11-27 Thread Tor Bug Tracker & Wiki
#32422: Add boklm as a gitolite admin
-+
 Reporter:  sysrqb   |  Owner:  tor-gitadm
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by gk):

 * status:  needs_information => new


Comment:

 The ask was one from (larger) teams, hence boklm volunteered for the
 browser folks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32607 [Internal Services/Service - git]: adjust push access for the Tor Browser git repos

2019-11-27 Thread Tor Bug Tracker & Wiki
#32607: adjust push access for the Tor Browser git repos
-+-
 Reporter:  mcs  |  Owner:  tor-gitadm
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 {{{
 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA512

 We would like to update the list of people who have push (write)
 access to the Tor Browser git repositories:

   builders/tor-browser-build
   tor-browser
   tor-browser-bundle-testsuite
   tor-browser-spec
   tor-launcher
   torbutton

 If we are lucky, access for all is controlled by the same `tor-browser`
 group.

 Changes requested:

 1. Remove push access for mikeperry and arthuredelstein.

 2. Add push access for sysrqb. As team lead, Matt needs this in
 order to access to perform rebasing and release work, for merging
 patches from other team members, and in general to do all the other
 things that Georg has done as team lead in the past.

 Thanks!
 -BEGIN PGP SIGNATURE-

 iQIzBAEBCgAdFiEE1LbTp/1VD4Q+DIDnfkOLWrkXMD4FAl3eV7QACgkQfkOLWrkX
 MD42UxAAgIiWa57BesJQELyTbWT9rDrNf9LqIKwH1bd07ggwKvyzS0EPVFG2aJhW
 RqHwITuOctfL0Q/vmttau3SkG8hPRaxg41nBGYDTeEN0IwJ/U8lFHgDB4cVGWWoj
 cVg/MH+pX2p3wB+U98VNVCuS44Ndg46aUlwP3Fr77/92F2SlVCHrD4n1vZvjc00b
 1Lex96gx7f0hWIWfzpJBa61DHhPyrC0RmfX8TE7PuXOJWKN6NyjhDvYQ2sQvwPvg
 tRXQX/TMUFiQdeq1fTSO4OT2w95PMIomRWI0lykGi/lXqvHNtFJ1Q+rbHXsAfg3h
 4GGvVpCNbiX3ulfvBx65+KEpWsoND8liYoJW+XBKPAs8xRolClZmnWC2STyUcNUi
 Yzh3iUyIAU78PcaVqcFEGPq6OJ8qhXvq6cE+hyo38dOBz63ZSDp3e4NQDvdrqBQl
 1RjyfBRYkIGbDEiFOzhoLxAdyqHPwyG4gv83/FW6oZvHHS6J5Yw0uoiBBt/D3Xo4
 6WGzjCLSSI91/nmTcxm9NhZPL96M22KyMGxcos3kloyYpCS2I3Xp+hpezyjSa/Vu
 9FpVhXJ3fnChM2dotrgHkZALmZu86OYgMfPmAFxH92o+hAThUKhL1++mtUcmedtB
 56R2Jjmsxs0DzlkKqKZL9zhEO29jDINck9gkEIg4jOfgedvBheQ=
 =a4oy
 -END PGP SIGNATURE-
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30910 [Internal Services/Service - git]: Warning when pushing to tor.git: "disabling bitmap writing, as some objects are not being packed."

2019-11-27 Thread Tor Bug Tracker & Wiki
#30910: Warning when pushing to tor.git: "disabling bitmap writing, as some 
objects
are not being packed."
-+
 Reporter:  nickm|  Owner:  tor-gitadm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by irl):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 Ok, trying out a reduced expiry time for pruning to see if that helps.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32607 [Internal Services/Service - git]: adjust push access for the Tor Browser git repos

2019-11-27 Thread Tor Bug Tracker & Wiki
#32607: adjust push access for the Tor Browser git repos
-+-
 Reporter:  mcs  |  Owner:  tor-gitadm
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Adding push access to `tor-browser-bundle-testsuite ` for more people in
 the Tor Browser team sounds good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31350 [Internal Services/Service - git]: test the locales for Android with a githook after updating from transifex

2019-11-27 Thread Tor Bug Tracker & Wiki
#31350: test the locales for Android with a githook after updating from 
transifex
-+-
 Reporter:  emmapeel |  Owner:  tor-
 |  gitadm
 Type:  enhancement  | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201904,|  Actual Points:
  GeorgKoppen201904  |
Parent ID:  #30054   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by eighthave):

 This kind of thing could easily run in GitLab CI.  Someone just needs to
 write the required checker scripts.  I can throw that up on
 https://gitlab.com/torproject in a mirror repo, which would automatically
 run GitLab CI on new commits.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32618 [Applications/Tor Browser]: Backport 1467970 and 1590526

2019-11-27 Thread Tor Bug Tracker & Wiki
#32618: Backport 1467970 and 1590526
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201911R |  Actual Points:  0.2
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * status:  new => needs_review
 * keywords:  TorBrowserTeam201911 => TorBrowserTeam201911R
 * actualpoints:   => 0.2


Comment:

 `bug_32618` (https://gitweb.torproject.org/user/gk/tor-
 browser.git/log/?h=bug_32618) has the backports. I did not build the
 changes yet but I looked at possible `parseFromString()` calls that might
 still be problematic AND on esr68 while not being present anymore when the
 patches landed on Mozilla's branches. We are good here, though.

 I also double-checked that the patches for those two bugs are the only
 ones we need to backport:

 Bug 1585769 is relevant here but the picture-in-picture video feature is
 only enabled in Windows nightlies if the code is esr68, so I think we can
 avoid backporting that fix.
 Bug 1585588 is not affecting us as we don't ship that extension and it
 should be fixed by bug 1590526 anyway (which fixed bug 1576508 as well).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32422 [Internal Services/Service - git]: Add boklm as a gitolite admin

2019-11-27 Thread Tor Bug Tracker & Wiki
#32422: Add boklm as a gitolite admin
-+-
 Reporter:  sysrqb   |  Owner:  tor-gitadm
 Type:  enhancement  | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by irl):

 * status:  new => needs_information


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31433 [Internal Services/Service - git]: Non-blocking Jenkins hooks

2019-11-27 Thread Tor Bug Tracker & Wiki
#31433: Non-blocking Jenkins hooks
-+
 Reporter:  atagar   |  Owner:  tor-gitadm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   | Resolution:  wontfix
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by irl):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 It would make it more complicated and less reliable to make it a
 background process. This only occured because Jenkins had issues. If
 Jenkins has issues a lot we might reconsider this, but I've not
 experienced this problem.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31350 [Internal Services/Service - git]: test the locales for Android with a githook after updating from transifex

2019-11-27 Thread Tor Bug Tracker & Wiki
#31350: test the locales for Android with a githook after updating from 
transifex
-+-
 Reporter:  emmapeel |  Owner:  tor-
 |  gitadm
 Type:  enhancement  | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201904,|  Actual Points:
  GeorgKoppen201904  |
Parent ID:  #30054   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by irl):

 * status:  new => needs_information


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31350 [Internal Services/Service - git]: test the locales for Android with a githook after updating from transifex

2019-11-27 Thread Tor Bug Tracker & Wiki
#31350: test the locales for Android with a githook after updating from 
transifex
-+-
 Reporter:  emmapeel |  Owner:  tor-
 |  gitadm
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201904,|  Actual Points:
  GeorgKoppen201904  |
Parent ID:  #30054   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by irl):

 This isn't really a task for the git team, unless I've misunderstood it.
 Can you use GitLab CI/Travis for this? If you want a tpo hosted solution
 then this would be a Jenkins task.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32422 [Internal Services/Service - git]: Add boklm as a gitolite admin

2019-11-27 Thread Tor Bug Tracker & Wiki
#32422: Add boklm as a gitolite admin
-+
 Reporter:  sysrqb   |  Owner:  tor-gitadm
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by irl):

 I'm not sure we need this many git admins.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31583 [Internal Services/Service - git]: Policy repo push access

2019-11-27 Thread Tor Bug Tracker & Wiki
#31583: Policy repo push access
-+
 Reporter:  atagar   |  Owner:  tor-gitadm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by irl):

 * status:  new => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31486 [Internal Services/Service - git]: Create a new repository for User Research

2019-11-27 Thread Tor Bug Tracker & Wiki
#31486: Create a new repository for User Research
-+
 Reporter:  pili |  Owner:  tor-gitadm
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:  Sponsor9
-+
Changes (by irl):

 * status:  new => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32607 [Internal Services/Service - git]: adjust push access for the Tor Browser git repos

2019-11-27 Thread Tor Bug Tracker & Wiki
#32607: adjust push access for the Tor Browser git repos
-+-
 Reporter:  mcs  |  Owner:  tor-gitadm
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by irl):

 * cc: boklm (added)
 * status:  new => needs_information


Comment:

 I need a GPG signed message I can verify and trust. This touches a ton of
 things, in this case I think that message should come from the Tor Browser
 team lead.

 Here is the current state, perhaps you can just tell me what it should
 look like once the changes are made. We can create/remove/merge groups to
 simplify, but we don't have to:

 {{{
 @tor-browser = arthuredelstein boklm brade
 gk mcs mikeperry

 @tor-browser-bundle  = boklm brade gk mcs
 mikeperry

 @tor-launcher= arthuredelstein brade gk
 mcs mikeperry

 @torbutton   = arthuredelstein brade gk
 mcs mikeperry

 repo builders/tor-browser-build
 RW   = @tor-browser-bundle

 repo tor-browser
 RW   = @tor-browser

 repo tor-browser-bundle-testsuite
 RW   = boklm

 repo tor-browser-spec
 RW   = @tor-browser

 repo tor-launcher
 RW   = @tor-launcher

 repo torbutton
 RW   = @torbutton
 }}}

 Adding boklm to CC because this will affect one repository that they are
 the only authorised person on (but I'll accept the signed message from
 just the team lead).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32476 [Applications/Tor Browser]: Support Launching TorService Using JNI

2019-11-27 Thread Tor Bug Tracker & Wiki
#32476: Support Launching TorService Using JNI
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  Android, tbb-mobile, |  Actual Points:
  TorBrowserTeam201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by eighthave):

 I agree that having Java support is good, plus I don't think it'll be much
 work.  I've been working on TorService and jtorctl always with supporting
 both Java and Android in mind.  The JNI code should already support Java,
 its just not tested there for a while.

 The clear border of sharing is
 ''src/feature/api/org_torproject_jni_TorService.c'' instead of
 ''TorService.java''.  The biggest block of logic in ''TorService.java'' is
 the startup procedure, and it seems very unlikely that the startup
 procedure should be shared between Java and Android.  They will have
 similarities, but not close enough that code sharing makes sense.  So if
 that core stuff isn't shared, then separating the Android-specific stuff
 like broadcasts from the Android-specific startup logic would only make
 the code more unreadable and unmaintainable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32473 [Metrics/Exit Scanner]: Evaluate the results from the exitmap based scanner compared to the current exit lists system

2019-11-27 Thread Tor Bug Tracker & Wiki
#32473: Evaluate the results from the exitmap based scanner compared to the 
current
exit lists system
--+--
 Reporter:  irl   |  Owner:  metrics-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Metrics/Exit Scanner  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by irl):

 This tar file contains a series of runs one after another:
 https://people.torproject.org/~irl/volatile/more-than-a-single-run.tar

 The published and last status date times are still just fake based on
 measurement times, but I have figured out now where to get both of those
 times.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32132 [Applications/Tor Browser]: Re-enable jemalloc for Windows users

2019-11-27 Thread Tor Bug Tracker & Wiki
#32132: Re-enable jemalloc for Windows users
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  TorBrowserTeam201910R,   |  Actual Points:  0.1
  GeorgKoppen201910, tbb-rbm, tbb-backport   |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Works without crashes, let's backport :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32627 [Core Tor]: deploy torspec as HTML to GitLab Pages

2019-11-27 Thread Tor Bug Tracker & Wiki
#32627: deploy torspec as HTML to GitLab Pages
---+--
 Reporter:  eighthave  |  Owner:  (none)
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Core Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  torspec|  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by eighthave):

 Here's a Python version of the same script, for anyone who wants it.
 {{{
 #!/usr/bin/env python3

 import glob
 import os
 import re

 if not os.path.exists('public'):
 os.mkdir('public')

 titles = dict()
 for f in glob.glob('*.txt'):
 with open(f) as fp:
 contents = fp.read()
 contents = re.sub(r'^\n +', r'# ', contents)
 contents = re.sub(r'\n {1,3}([^ ])', r'\n\1', contents)
 contents = re.sub(r'\n([0-9]+\. (?!http))', r'\n## \1', contents)
 contents = re.sub(r'\n([0-9]+\.[0-9]+\. )', r'\n### \1', contents)
 contents = re.sub(r'\n([0-9]+\.[0-9]+\.[0-9]+\. )', r'\n \1',
 contents)
 contents = re.sub(r'\n([0-9]+\.[0-9]+\.[0-9]+\.[0-9]+\. )', r'\n#
 \1', contents)
 with open(f, 'w') as fp:
 fp.write(contents)
 m = re.match(r'\s*# (.*)\n', contents)
 titles[re.sub(r'\.txt$', r'', f)] = m.group(1)

 with open('public/index.html', 'w') as fp:
 fp.write('\n\n%s' %
 os.getenv('CI_PROJECT_PATH'))
 for k, v in sorted(titles.items()):
 fp.write('%s: %s' % (k, k,
 v))
 fp.write('')
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32627 [Core Tor]: deploy torspec as HTML to GitLab Pages (was: deploy torspec as HTML to)

2019-11-27 Thread Tor Bug Tracker & Wiki
#32627: deploy torspec as HTML to GitLab Pages
---+--
 Reporter:  eighthave  |  Owner:  (none)
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Core Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  torspec|  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32627 [Core Tor]: deploy torspec as HTML to

2019-11-27 Thread Tor Bug Tracker & Wiki
#32627: deploy torspec as HTML to
---+--
 Reporter:  eighthave  |  Owner:  (none)
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Core Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  torspec|  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by eighthave):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32627 [Core Tor]: deploy torspec as HTML to

2019-11-27 Thread Tor Bug Tracker & Wiki
#32627: deploy torspec as HTML to
---+--
 Reporter:  eighthave  |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Component:  Core Tor
  Version: |   Severity:  Normal
 Keywords:  torspec|  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
 https://github.com/torproject/torspec/pull/96 will deploy torspec in HTML
 to any GitLab fork setup with CI and Pages (default on gitlab.com). it
 only adds one file: ''.gitlab-ci.yml''

 Once merged, the site will show up automatically on
 https://torproject.gitlab.io/torspec, and it'll sync every commit from the
 canonical repo and automatically rebuild the HTML.

 The sed regexps in ''.gitlab-ci.yml'' could be used as the beginnings of a
 conversion to Markdown format, as needed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31130 [Applications/Tor Browser]: Use Debian 10 for our Android container images

2019-11-27 Thread Tor Bug Tracker & Wiki
#31130: Use Debian 10 for our Android container images
---+---
 Reporter:  gk |  Owner:  sisbell
 Type:  defect | Status:
   |  needs_revision
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201911  |  Actual Points:
Parent ID:  #31127 | Points:  0.5
 Reviewer: |Sponsor:
---+---
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-rbm, TorBrowserTeam201911R => tbb-rbm,
   TorBrowserTeam201911


Comment:

 Replying to [comment:48 sisbell]:
 > Looks like we just need one additional dependency installed for the JDK
 headless installation. I verified a full build.
 >
 > https://github.com/sisbell/tor-browser-
 build/commit/005b6651ba42737c7e1bd177f01286294355c02f

 Okay, we are close. Looking over the patch again I see you are pointing to
 `https://deb.debian.org/debian/pool/main/o/openjdk-8` for the openjdk
 packages. However, that seems to be brittle to me as it's easily
 conceivable that this version is getting superseded by newer updates in
 the couple of weeks. Better is using `snapshot.debian.org` (e.g.
 
https://snapshot.debian.org/archive/debian/20191031T212011Z/pool/main/o/openjdk-8/).
 boklm: anything else that should get fixed?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32616 [Applications/Tor Browser]: disable GetSecureOutputDirectoryPath() functionality

2019-11-27 Thread Tor Bug Tracker & Wiki
#32616: disable GetSecureOutputDirectoryPath() functionality
--+
 Reporter:  mcs   |  Owner:  mcs
 Type:  defect| Status:
  |  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-update,TorBrowserTeam201911R  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by gk):

 * cc: sysrqb (added)


Comment:

 This looks good to me and I tested a Windows build which is still working
 fine. I merged your patch to `tor-browser-68.3.0esr-9.0-1` (commit
 acaf32506a39f94751853ff55869855ac3563a54). Leaving the ticket open for
 sysrqb to pick up the fix for 9.5a3.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

  1   2   >