Re: [tor-bugs] #33186 [Applications/Tor Browser]: Tab crashes with an error " Gah. Your tab just crashed."

2020-02-07 Thread Tor Bug Tracker & Wiki
#33186: Tab crashes with an error " Gah. Your tab just crashed."
--+--
 Reporter:  oracle|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Blocker   | Resolution:
 Keywords:  crash |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by oracle):

 Replying to [comment:2 cypherpunks]:
 >
 > You can't turn off e10s (Multi-Process) in Firefox 68
 >
 > If developers want to disable e10s on official builds for testing they
 can use MOZ_FORCE_DISABLE_E10S environment variable.

 This fixed it. Thanks a lot. :D

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19026 [Circumvention/Snowflake]: Remove local LAN address ICE candidates

2020-02-07 Thread Tor Bug Tracker & Wiki
#19026: Remove local LAN address ICE candidates
-+--
 Reporter:  dcf  |  Owner:  arlolra
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  cohosh   |Sponsor:
-+--

Comment (by dcf):

 Replying to [comment:17 arlolra]:
 > It could, but since `offer *webrtc.SessionDescription` comes from a call
 to `pc.LocalDescription()`, I didn't want to invalidate the cached parsed
 description in that structure,
 > https://github.com/pion/webrtc/blob/master/sessiondescription.go#L10-L13
 >
 > You could skip it, yes, but I felt the cheap string check was preferable
 attempting a parse,
 >
 
https://github.com/pion/sdp/blob/03441e3c706c7c3b719ee75194049a31cbb2eb7e/common_description.go#L112-L122

 Okay, works for me.

 > Yeah, that was ugly.  I pushed commit for this suggestion,
 >
 
https://github.com/keroserene/snowflake/commit/edd53af92ac868cf3ba57988e14de887f088a47b

 Everything looks good from my point of view.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33191 [Applications/GetTor]: Move from twisted adbapi to sqlite3 for GetTor

2020-02-07 Thread Tor Bug Tracker & Wiki
#33191: Move from twisted adbapi to sqlite3 for GetTor
-+--
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  task | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:  .5
 Reviewer:   |Sponsor:
-+--
Changes (by cohosh):

 * status:  assigned => needs_review


Comment:

 I based these changes off of the commits in #33123 because they
 restructure the database queries.

 The first commit removes a bunch of unused imports that I found through
 running a linter. The second makes the actual switch from twisted.adbapi
 to sqlite3.

 https://dip.torproject.org/cohosh/gettor/compare/ticket%2F33123...database

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19026 [Circumvention/Snowflake]: Remove local LAN address ICE candidates

2020-02-07 Thread Tor Bug Tracker & Wiki
#19026: Remove local LAN address ICE candidates
-+--
 Reporter:  dcf  |  Owner:  arlolra
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  cohosh   |Sponsor:
-+--

Comment (by arlolra):

 Replying to [comment:16 dcf]:
 > Could
 > {{{
 >   if !bc.keepLocalAddresses {
 >   offer = {
 >   Type: offer.Type,
 >   SDP:  stripLocalAddresses(offer.SDP),
 >   }
 >   }
 > }}}
 > be instead
 > {{{
 >   if !bc.keepLocalAddresses {
 >   offer.SDP = stripLocalAddresses(offer.SDP)
 >   }
 > }}}
 > ?

 It could, but since `offer *webrtc.SessionDescription` comes from a call
 to `pc.LocalDescription()`, I didn't want to invalidate the cached parsed
 description in that structure,
 https://github.com/pion/webrtc/blob/master/sessiondescription.go#L10-L13


 > https://github.com/keroserene/snowflake/compare/trac19026#diff-
 0f3a063993ea3b440ad2ce0abb6ac195R105
 >
 > {{{
 >   if a.IsICECandidate() {
 > }}}
 >
 > Is it necessary to test `IsICECandidate`, or could you skip it and just
 check the `err` result of `ToICECandidate`?

 You could skip it, yes, but I felt the cheap string check was preferable
 attempting a parse,
 
https://github.com/pion/sdp/blob/03441e3c706c7c3b719ee75194049a31cbb2eb7e/common_description.go#L112-L122

 > 
 >
 > The attributes loop is structured like this, with `attrs = append(attrs,
 a)` in three places:
 > {{{
 > for a in attributes {
 >   if a.IsICECandidate() {
 >   ice, err = a.ToICECandidate()
 >   if err != nil {
 >   attrs = append(attrs, a)
 >   continue
 >   }
 >   if ice.Typ == "host" {
 >   ip = net.ParseIP(ice.Address)
 >   if ip == nil {
 >   attrs = append(attrs, a)
 >   continue
 >   }
 >   if IsLocal(ip) {
 >   /* no append in this case */
 >   continue
 >   }
 >   }
 >   }
 >   attrs = append(attrs, a)
 > }
 > }}}
 >
 > Consider restructuring so that you only `continue` in the "skip" case,
 and all other cases fall through to `attrs = append(attrs, a)`. Expressing
 the logic: if a candidate, and type=="host", and an IP address, and IP
 address is local, skip; otherwise keep.
 > {{{
 > for a in attributes {
 >   if a.IsICECandidate() {
 >   ice, err = a.ToICECandidate()
 >   if err == nil && ice.Typ == "host" {
 >   ip = net.ParseIP(ice.Address)
 >   if ip != nil && IsLocal(ip) {
 >   /* no append in this case */
 >   continue
 >   }
 >   }
 >   }
 >   attrs = append(attrs, a)
 > }
 > }}}
 >
 > But also possibly with my note about `ToICECandidate` above:
 > {{{
 > for a in attributes {
 >   if ice, err = a.ToICECandidate(); err == nil {
 >   if ice.Typ == "host" {
 >   ip = net.ParseIP(ice.Address)
 >   if ip != nil && IsLocal(ip) {
 >   /* no append in this case */
 >   continue
 >   }
 >   }
 >   }
 >   attrs = append(attrs, a)
 > }
 > }}}

 Yeah, that was ugly.  I pushed commit for this suggestion,
 
https://github.com/keroserene/snowflake/commit/edd53af92ac868cf3ba57988e14de887f088a47b

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33192 [Core Tor/Tor]: Stop assuming that /usr/bin/python exists

2020-02-07 Thread Tor Bug Tracker & Wiki
#33192: Stop assuming that /usr/bin/python exists
--+--
 Reporter:  alwayslivid   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.4.2.5
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by alwayslivid):

 Please check my proposed change here:
 https://github.com/torproject/tor/pull/1712

 This change will be particularly useful for people that are using FreeBSD,
 have compiled Python on a Linux machine, or use non-traditional setups of
 Python.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19026 [Circumvention/Snowflake]: Remove local LAN address ICE candidates

2020-02-07 Thread Tor Bug Tracker & Wiki
#19026: Remove local LAN address ICE candidates
-+--
 Reporter:  dcf  |  Owner:  arlolra
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  cohosh   |Sponsor:
-+--

Comment (by dcf):

 Replying to [comment:14 arlolra]:
 > Here's a branch for this now,
 > https://github.com/keroserene/snowflake/compare/trac19026

 https://github.com/keroserene/snowflake/compare/trac19026#diff-
 0f3a063993ea3b440ad2ce0abb6ac195R144

 Could
 {{{
 if !bc.keepLocalAddresses {
 offer = {
 Type: offer.Type,
 SDP:  stripLocalAddresses(offer.SDP),
 }
 }
 }}}
 be instead
 {{{
 if !bc.keepLocalAddresses {
 offer.SDP = stripLocalAddresses(offer.SDP)
 }
 }}}
 ?

 https://github.com/keroserene/snowflake/compare/trac19026#diff-
 0f3a063993ea3b440ad2ce0abb6ac195R105

 {{{
 if a.IsICECandidate() {
 }}}

 Is it necessary to test `IsICECandidate`, or could you skip it and just
 check the `err` result of `ToICECandidate`?

 

 The attributes loop is structured like this, with `attrs = append(attrs,
 a)` in three places:
 {{{
 for a in attributes {
 if a.IsICECandidate() {
 ice, err = a.ToICECandidate()
 if err != nil {
 attrs = append(attrs, a)
 continue
 }
 if ice.Typ == "host" {
 ip = net.ParseIP(ice.Address)
 if ip == nil {
 attrs = append(attrs, a)
 continue
 }
 if IsLocal(ip) {
 /* no append in this case */
 continue
 }
 }
 }
 attrs = append(attrs, a)
 }
 }}}

 Consider restructuring so that you only `continue` in the "skip" case, and
 all other cases fall through to `attrs = append(attrs, a)`. Expressing the
 logic: if a candidate, and type=="host", and an IP address, and IP address
 is local, skip; otherwise keep.
 {{{
 for a in attributes {
 if a.IsICECandidate() {
 ice, err = a.ToICECandidate()
 if err == nil && ice.Typ == "host" {
 ip = net.ParseIP(ice.Address)
 if ip != nil && IsLocal(ip) {
 /* no append in this case */
 continue
 }
 }
 }
 attrs = append(attrs, a)
 }
 }}}

 But also possibly with my note about `ToICECandidate` above:
 {{{
 for a in attributes {
 if ice, err = a.ToICECandidate(); err == nil {
 if ice.Typ == "host" {
 ip = net.ParseIP(ice.Address)
 if ip != nil && IsLocal(ip) {
 /* no append in this case */
 continue
 }
 }
 }
 attrs = append(attrs, a)
 }
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33192 [Core Tor/Tor]: Stop assuming that /usr/bin/python exists

2020-02-07 Thread Tor Bug Tracker & Wiki
#33192: Stop assuming that /usr/bin/python exists
--+--
 Reporter:  alwayslivid   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Component:  Core Tor/Tor
  Version:  Tor: 0.4.2.5  |   Severity:  Normal
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
 This issue is relevant to the following ticket: #29913

 In short, the problem in #29913 was that Python 3 scripts cannot depend on
 a hardcoded path in order to find the Python 3 executable, because the
 path itself is not immutable. (For instance, as seen in that ticket
 itself.

 Unfortunately, the same exact issue also applies to Python 2 scripts and
 their relevant executables.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19026 [Circumvention/Snowflake]: Remove local LAN address ICE candidates

2020-02-07 Thread Tor Bug Tracker & Wiki
#19026: Remove local LAN address ICE candidates
-+--
 Reporter:  dcf  |  Owner:  arlolra
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  cohosh   |Sponsor:
-+--
Changes (by arlolra):

 * status:  merge_ready => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33108 [Internal Services/Services Admin Team]: How and when should the sysadmin team adopt a service

2020-02-07 Thread Tor Bug Tracker & Wiki
#33108: How and when should the sysadmin team adopt a service
-+-
 Reporter:  hiro |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Services Admin |Version:
  Team   |
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #31243   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by anarcat):

 hiro, do you want to drive this process? i think the next step is to draft
 up a text that would describe a proposed policy and make an RFC out if it.

 thanks1

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31243 [Internal Services/Tor Sysadmin Team]: TPA-RFC-2: define how users get support, what's an emergency and what is supported

2020-02-07 Thread Tor Bug Tracker & Wiki
#31243: TPA-RFC-2: define how users get support, what's an emergency and what is
supported
-+-
 Reporter:  anarcat  |  Owner:  anarcat
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tparfc   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by anarcat):

 next steps here are:

  1. move the policy proposal into https://help.torproject.org/tsa/policy/
  2. draft improvements to factor in #33108
  3. send the draft officially to tpa at the end of the TPA-RFC-1 delay, if
 approved (next friday, 2020-02-14)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33081 [Internal Services/Tor Sysadmin Team]: new gnt-fsn node (fsn-node-04)

2020-02-07 Thread Tor Bug Tracker & Wiki
#33081: new gnt-fsn node (fsn-node-04)
-+-
 Reporter:  anarcat  |  Owner:  anarcat
 Type:  task | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tpa-roadmap-february |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+-
Changes (by anarcat):

 * status:  new => assigned


Comment:

 will order a new PX62 box on monday, which should land about the same time
 textile is decomissioned (tuesday, #31686). thinking of improving the
 puppet bootstrap in this install (#32914).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33123 [Applications/GetTor]: Update GetTor's rate limiting

2020-02-07 Thread Tor Bug Tracker & Wiki
#33123: Update GetTor's rate limiting
-+--
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+--
Changes (by cohosh):

 * status:  assigned => needs_review


Comment:

 I'd like to review this quick fix as is and then work on #33191 before
 writing unit tests.

 Basically, the deferred objects returned by adbapi calls to the database
 are difficult to deal with pytest.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33191 [Applications/GetTor]: Move from twisted adbapi to sqlite3 for GetTor

2020-02-07 Thread Tor Bug Tracker & Wiki
#33191: Move from twisted adbapi to sqlite3 for GetTor
-+--
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  task | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:  .5   |   Reviewer:
  Sponsor:   |
-+--
 Right now we're using the twisted database api for connecting to our
 sqlite3 database. This is difficult to use and test. BridgeDB uses the
 sqlite3 python package and that works just fine, perhaps we can move to
 that.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31781 [Internal Services/Tor Sysadmin Team]: ping fails as a regular user on new VMs

2020-02-07 Thread Tor Bug Tracker & Wiki
#31781: ping fails as a regular user on new VMs
-+-
 Reporter:  weasel   |  Owner:  anarcat
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by anarcat):

 ping'd bts again, will upload the hotfix on our debian repo monday because
 we are missing the fix on new ganeti machines in the cluster.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33134 [Internal Services/Tor Sysadmin Team]: Improve documentation for interacting with db.torproject.org

2020-02-07 Thread Tor Bug Tracker & Wiki
#33134: Improve documentation for interacting with db.torproject.org
-+-
 Reporter:  gk   |  Owner:  anarcat
 Type:  enhancement  | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by anarcat):

 update: we have the latest changes online now, so our repo is here:

 https://git.torproject.org/admin/userdir-ldap-cgi.git

 and the files you'd like to edit are rather:

 https://gitweb.torproject.org/admin/userdir-ldap-cgi.git/tree/html/doc-
 mail.wml
 https://gitweb.torproject.org/admin/userdir-ldap-
 cgi.git/tree/html/password.wml

 thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33134 [Internal Services/Tor Sysadmin Team]: Improve documentation for interacting with db.torproject.org

2020-02-07 Thread Tor Bug Tracker & Wiki
#33134: Improve documentation for interacting with db.torproject.org
-+-
 Reporter:  gk   |  Owner:  anarcat
 Type:  enhancement  | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by anarcat):

 * status:  accepted => needs_information


Comment:

 i can't find the source for our deployment of the package here, but the
 upstream source is here:

 https://salsa.debian.org/dsa-team/mirror/userdir-ldap-cgi/

 do you think you could provide a patch that would represent the changes
 you're thinking of? I think the two files you might want to modify are:

 https://salsa.debian.org/dsa-team/mirror/userdir-ldap-cgi/blob/master/html
 /doc-mail.wml
 https://salsa.debian.org/dsa-team/mirror/userdir-ldap-
 cgi/blob/master/html/password.wml

 feel free to send patches upstream or here, i can take care of shepherding
 them up there. otherwise i'm also happy to try and interpret what you
 meant there, but i'm not sure i would do as good of a job as you. :)

 thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33134 [Internal Services/Tor Sysadmin Team]: Improve documentation for interacting with db.torproject.org

2020-02-07 Thread Tor Bug Tracker & Wiki
#33134: Improve documentation for interacting with db.torproject.org
-+-
 Reporter:  gk   |  Owner:  anarcat
 Type:  enhancement  | Status:
 |  accepted
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by anarcat):

 >  ISTR that our documentation here is derived from Debian; if that's
 correct, we should first check whether there are any updates in the
 documentation in Debian that we can upstream. After we're done with this,
 we should see whether the upstream maintainers would like to take our
 improved documentation.

 I misunderstood gk's comments: i thought they were about the wiki
 documentation. But they are, as you said, about the db.tpo HTML docs,
 which *are* indeed from upstream Debian.

 They are provided by the userdir-ldap-cgi package, which we get from
 Debian as well, so any changes we do there *must* be provided back
 upstream anyways otherwise they will be lost on the next import.

 I'll see if I can sort this out. Good thing that weasel just upgraded this
 host to the latest upstream, it will make my job easier. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19026 [Circumvention/Snowflake]: Remove local LAN address ICE candidates

2020-02-07 Thread Tor Bug Tracker & Wiki
#19026: Remove local LAN address ICE candidates
-+-
 Reporter:  dcf  |  Owner:  arlolra
 Type:  enhancement  | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  cohosh   |Sponsor:
-+-

Comment (by arlolra):

 > However, I missed that Attributes are public on the SessionDescription,
 and can be manipulated directly.

 I think I must have confused `sdp.SessionDescription` with
 `webrtc.SessionDescription`

 Thanks for catching that, dcf

 > Will fix, thanks.

 Here's a branch for this now,
 https://github.com/keroserene/snowflake/compare/trac19026

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33190 [Applications/Orbot]: Orbot doesn't start in VPN mode on Android 10

2020-02-07 Thread Tor Bug Tracker & Wiki
#33190: Orbot doesn't start in VPN mode on Android 10
--+
 Reporter:  Gbug  |  Owner:  n8fr8
 Type:  defect| Status:  new
 Priority:  Medium|  Component:  Applications/Orbot
  Version:  Tor: 0.4.2.5  |   Severity:  Normal
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
 VPN mode off, orbot can autostart*
 VPN mode on, orbot cannot autostart

 Toggling android VPN settings makes no difference and changing the list of
 VPN mode apps makes no difference.

 Reproduced on Graphene QQ1A.200205.002.2020.02.04.01
 with both Orbot
 16.1.4-RC-1-tor-0.4.2.5-rc and 16.1.2-RC-1-tor-0.4.1.5-rc
 problem also reported on Calyx

 May be related to https://trac.torproject.org/projects/tor/ticket/30607

 *in this case it is the last application started

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33138 [Internal Services/Services Admin Team]: New RT queue and alias iff@tpo

2020-02-07 Thread Tor Bug Tracker & Wiki
#33138: New RT queue and alias iff@tpo
---+--
 Reporter:  ggus   |  Owner:  ggus
 Type:  defect | Status:  new
 Priority:  High   |  Milestone:
Component:  Internal Services/Services Admin Team  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by anarcat):

 >  The instructions for 'Creating a queue' looks easy. :)

 Great. Follow those and let me know if you hit a snag. Then I'll create
 the actual forwards for the queue.

 By the way, my objective is to automate the creation of queues insofar as
 you could:

  1. create the Queue in the RT web GUI
  2. and it automatically works when you write to qu...@rt.torproject.org

 writing to qu...@torproject.org is a *different* forward, and maybe we
 want to encourage people to use the former so we have full automation and
 better autonomy... but i'd understand if we don't want people to be
 confused that way...

 anyways, just a thought, let me know when you're done and i can look at
 creating the forwards, probably next week.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33189 [Internal Services/Tor Sysadmin Team]: Plan for increase in CiviCRM email send rate

2020-02-07 Thread Tor Bug Tracker & Wiki
#33189: Plan for increase in CiviCRM email send rate
-+-
 Reporter:  richarde |  Owner:  tpa
 Type:  task | Status:  new
 Priority:  Medium   |  Component:  Internal Services/Tor Sysadmin
 |  Team
  Version:   |   Severity:  Normal
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
 Fundraising has requested an email speedup, and we (at Giant Rabbit) would
 like to test increasing CiviCRM's send from 500 per 5 minutes to 5,000 per
 5 minutes. CiviCRM has been sending the mails via postfix on crm-int-01,
 so that's where the rate would be increasing. We'd like to pilot the new
 settings on the February newsletter.

 Does this sound reasonable? Is there other planning that ought to take
 place?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32928 [Core Tor/Tor]: Tor Manual: Split Circuit Timeout options into their own subsection

2020-02-07 Thread Tor Bug Tracker & Wiki
#32928: Tor Manual: Split Circuit Timeout options into their own subsection
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can extra-review  |
Parent ID:  #4310| Points:  0.5
 Reviewer:  catalyst, nickm  |Sponsor:
-+-
Changes (by catalyst):

 * status:  needs_review => merge_ready


Comment:

 Note to merger: please merge https://github.com/torproject/tor/pull/1711
 instead; it adds a changes file.  Thanks!

 Swati, I think that should auto-close your pull request if it's merged
 without additional changes or rebasing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19026 [Circumvention/Snowflake]: Remove local LAN address ICE candidates

2020-02-07 Thread Tor Bug Tracker & Wiki
#19026: Remove local LAN address ICE candidates
-+-
 Reporter:  dcf  |  Owner:  arlolra
 Type:  enhancement  | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  cohosh   |Sponsor:
-+-

Comment (by arlolra):

 > Sorry to bring it up at this late stage, but the pion/sdp package is an
 alternative to string operations.

 The patch already uses that parse candidate lines,
 
https://github.com/keroserene/snowflake/commit/dbd133b6e1196e4ec7550f0ebb52854cb00d1007
 #diff-0f3a063993ea3b440ad2ce0abb6ac195R101

 However, I missed that Attributes are public on the SessionDescription,
 and can be manipulated directly.

 Will fix, thanks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32929 [Core Tor/Tor]: Tor Manual: Split Node options into their own subsection

2020-02-07 Thread Tor Bug Tracker & Wiki
#32929: Tor Manual: Split Node options into their own subsection
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can extra-review  |
Parent ID:  #4310| Points:  0.5
 Reviewer:  catalyst, nickm  |Sponsor:
-+-
Changes (by catalyst):

 * status:  needs_review => merge_ready


Comment:

 Note to merger: see #32928 for special merge instructions.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32928 [Core Tor/Tor]: Tor Manual: Split Circuit Timeout options into their own subsection

2020-02-07 Thread Tor Bug Tracker & Wiki
#32928: Tor Manual: Split Circuit Timeout options into their own subsection
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can extra-review  |
Parent ID:  #4310| Points:  0.5
 Reviewer:  catalyst, nickm  |Sponsor:
-+-

Comment (by catalyst):

 Replying to [comment:16 swati]:
 > Reworded your suggestion a bit and updated the introductory text in both
 the sections.
 Thanks!  It looks good.  There needs to be a changes file, but I can write
 one and push it to your branch if that's ok.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33188 [Core Tor/Tor]: Tor Manual: Alphabetize Server and Directory Server Options

2020-02-07 Thread Tor Bug Tracker & Wiki
#33188: Tor Manual: Alphabetize Server and Directory Server Options
-+-
 Reporter:  swati|  Owner:  (none)
 Type:  task | Status:  new
 Priority:  Medium   |  Component:  Core
 |  Tor/Tor
  Version:   |   Severity:  Normal
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can   |
Parent ID:  #4310| Points:
 Reviewer:   |Sponsor:
-+-
 Alphabetize options in the Server Options and Directory Server Options

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33187 [Webpages/Website]: Please add job description to website

2020-02-07 Thread Tor Bug Tracker & Wiki
#33187: Please add job description to website
--+--
 Reporter:  ewyatt|  Owner:  hiro
 Type:  task  | Status:  new
 Priority:  Very High |  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 {{{
 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA512

 February 5, 2020
 The Tor Project is looking for an Executive Assistant!
 The Executive Assistant is responsible for providing high-level
 administrative support to the Executive Director. This position will
 actively manage the ED’s schedule, handle internal and external executive-
 level communications, and coordinate special projects and events.
 This position is full-time and remote; someone in the Eastern time zone
 strongly preferred. This position will be performed remotely, preferably
 by someone in the Eastern time zone.
 You:
 •   Technology-competent and/or willing and able to learn new
 tools. Our team coordinates via IRC (the grandparent of Slack), email,
 Signal messaging app, and bug trackers, etc.
 •   Have an exceptional ability to see ten steps ahead,
 anticipating and heading off issues before they become problems.
 •   Highly skilled at prioritizing ED’s tasks and effectively
 communicating changing priorities on a daily basis.
 •   Problem solver! Plans, strategies, and schedules change:
 You react quickly, are resilient, and take the initiative to find the best
 alternatives when these changes arise.
 •   Independent: self-directed and able to get the job done;
 ensure the ED is on track.
 •   Proactive: you take initiative in improving processes;
 you’re always thinking ahead.
 Job Duties:
 •   Manage ED’s schedule: schedule meetings, screen for
 conflicts, and ensure the ED is prepared for important meetings.
 •   Arrange travel, prepare expense reports, and handle other
 administrative tasks.
 •   Head up the planning and logistics of twice-yearly
 organization-wide meetings.
 •   Serve as proxy for ED at certain weekly meetings, take
 notes, and keep track of ED’s action items.
 •   Develop and sustain a high level of professionalism among
 staff and community members.
 •   Assist the ED with administering the organization’s travel
 policy: follow up on travel approvals and expenses and help manage the
 budget.
 •   Assist the ED with reports, presentations, and follow ups
 with/for major donors and sponsors.
 Required Skills & Qualifications:
 •   Be personable with strong interpersonal and oral/written
 communication skills; ability or willingness to learn to use various
 communication tools and function in an asynchronous work environment.
 •   Uphold a strict level of confidentiality.
 •   Maintain a high level of attention to detail and accuracy.
 •   Ability to manage multiple tasks, re-prioritize on a daily
 basis, and meet deadlines.
 •   Be highly organized with exceptional planning skills.
 •   Able to work both independently and in a collaborative
 environment.
 •   Ability to track and monitor travel budget spending at the
 org level.
 •   Willingness to try new methods, apps, and/or technology.
 •   Take initiative in completing assignments, solving
 problems, and seeking solutions.
 •   3 to 5 years experience as Executive Assistant or similar
 roles.
 •   An interest in free and open source software and/or
 internet freedom is a bonus but not required.
 To apply:
 Please email a *PDF* of your resume/CV, and a cover letter explaining how
 your qualifications and experience meet the requirements of this job
 description. Please include the reasons why you want to work at Tor
 Project.
 Email should be sent to hr at torproject dot org with "Executive Assistant
 " in the subject line. No phone calls, please.
 Other notes:
 We offer a competitive benefits package, including a generous PTO policy;
 14 paid holidays per year (including the week between Christmas and New
 Year's, when the office is closed); health, vision, dental, disability,
 and life insurance; flexible work schedule; and occasional travel
 opportunities.
 The Tor Project, Inc., is a 501(c)(3) organization headquartered in
 Seattle with paid staff and contractors of around 40 engineers and
 operational support people, plus many volunteers all over the world. Tor
 develops free and open source software for privacy and freedom online,
 protecting people from tracking, surveillance, and censorship.
 The Tor Project's mission is to advance 

Re: [tor-bugs] #33157 [Circumvention/Snowflake]: Client generates SDP with "IN IP4 0.0.0.0", causing proxy to send "client_ip=0.0.0.0" and bridge to send "USERADDR 0.0.0.0:1"

2020-02-07 Thread Tor Bug Tracker & Wiki
#33157: Client generates SDP with "IN IP4 0.0.0.0", causing proxy to send
"client_ip=0.0.0.0" and bridge to send "USERADDR 0.0.0.0:1"
-+
 Reporter:  dcf  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by dcf):

 I'll say that the bug here is not necessarily that the SDP contains
 0.0.0.0; it's that the proxy uses 0.0.0.0 as the client address despite
 more meaningful information being available in the SDP. `remoteIPFromSDP`
 could choose one of the candidates from an `a=candidate` line rather than
 only looking at the `c=` line, for example. (Which one? It probably
 doesn't matter, as they are all likely to have the same geolocation, as
 long as you pick an external address candidate and not a LAN address
 candidate.) One way to fix the problem would be to ensure that clients
 generate SDP with a meaningful address in the `c=` line; another way would
 be to use a different method of extracting the address in the proxy.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19026 [Circumvention/Snowflake]: Remove local LAN address ICE candidates

2020-02-07 Thread Tor Bug Tracker & Wiki
#19026: Remove local LAN address ICE candidates
-+-
 Reporter:  dcf  |  Owner:  arlolra
 Type:  enhancement  | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  cohosh   |Sponsor:
-+-

Comment (by dcf):

 Sorry to bring it up at this late stage, but the
 [https://github.com/pion/sdp pion/sdp] package is an alternative to string
 operations. There's a
 [https://godoc.org/github.com/pion/sdp#SessionDescription
 SessionDescription] type with
 [https://godoc.org/github.com/pion/sdp#SessionDescription.Marshal Marshal]
 and [https://godoc.org/github.com/pion/sdp#SessionDescription.Unmarshal
 Unmarshal] methods, containing an array of
 [https://godoc.org/github.com/pion/sdp#Attribute Attribute]s that each
 have a [https://godoc.org/github.com/pion/sdp#Attribute.ToICECandidate
 ToICECandidate] method.

 Replying to [comment:6 cohosh]:
 > - {{{FIXME: Should this check ip.IsLoopback() and others?}}} I'd like to
 include `0.0.0.0` and `127.0.0.1` addresses in this, especially after dcf
 found #33157.

 I feel that the 0.0.0.0 is unrelated to anything involving candidate
 addresses. 0.0.0.0 is appearing in the `o=` origin field and the `c=`
 connection information field (the latter is what `remoteIPFromSDP` looks
 at), not in an `a=candidate` attribute.

 However, I imagine that if a LAN address appears as a `a=candidate`, that
 may also cause it to appear in `o=` or `c=`, and we may have to
 additionally deal with that when #33157 is figured out.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26923 [Circumvention/Pluggable transport]: Intent to create Pluggable Transport: HTTPS proxy

2020-02-07 Thread Tor Bug Tracker & Wiki
#26923: Intent to create Pluggable Transport: HTTPS proxy
-+-
 Reporter:  sf   |  Owner:  (none)
 Type:  project  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Pluggable transport|Version:
 Severity:  Normal   | Resolution:
 Keywords:  httpsproxy, anti-censorship- |  Actual Points:
  roadmap-september  |
Parent ID:   | Points:  30
 Reviewer:   |Sponsor:
 |  Sponsor28-can
-+-
Changes (by phw):

 * cc: cohosh (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33186 [Applications/Tor Browser]: Tab crashes with an error " Gah. Your tab just crashed."

2020-02-07 Thread Tor Bug Tracker & Wiki
#33186: Tab crashes with an error " Gah. Your tab just crashed."
--+--
 Reporter:  oracle|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Blocker   | Resolution:
 Keywords:  crash |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by Thorin):

 this is my area of expertise, but the default is to install to desktop

 If you were installing to desktop, what happens if you install it to e.g
 `c:/torbrowser/`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33186 [Applications/Tor Browser]: Tab crashes with an error " Gah. Your tab just crashed."

2020-02-07 Thread Tor Bug Tracker & Wiki
#33186: Tab crashes with an error " Gah. Your tab just crashed."
--+--
 Reporter:  oracle|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Blocker   | Resolution:
 Keywords:  crash |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 >I have tried setting browser.tabs.remote.autostart to false.

 You can't turn off e10s (Multi-Process) in Firefox 68

 If developers want to disable e10s on official builds for testing they can
 use MOZ_FORCE_DISABLE_E10S environment variable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19026 [Circumvention/Snowflake]: Remove local LAN address ICE candidates

2020-02-07 Thread Tor Bug Tracker & Wiki
#19026: Remove local LAN address ICE candidates
-+-
 Reporter:  dcf  |  Owner:  arlolra
 Type:  enhancement  | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  cohosh   |Sponsor:
-+-

Comment (by cohosh):

 Replying to [comment:9 arlolra]:
 > > especially after dcf found #33157.
 >
 > Hmm, after reading that, I noticed we have,
 > https://github.com/keroserene/snowflake/blob/master/proxy-
 go/snowflake.go#L60-L70
 >
 > I should probably consolidate that with some of the nastiness added here
 to grep the sdp.

 That's a good idea. We can discuss this on #33157.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19026 [Circumvention/Snowflake]: Remove local LAN address ICE candidates

2020-02-07 Thread Tor Bug Tracker & Wiki
#19026: Remove local LAN address ICE candidates
-+-
 Reporter:  dcf  |  Owner:  arlolra
 Type:  enhancement  | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  cohosh   |Sponsor:
-+-
Changes (by cohosh):

 * status:  needs_review => merge_ready


Comment:

 These changes looks good to me. Let's merge this and follow up with a port
 to proxies as you mentioned. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31085 [Circumvention/Snowflake]: Make an Android extension or app for people to be a snowflake (AMO or proxy-go)

2020-02-07 Thread Tor Bug Tracker & Wiki
#31085: Make an Android extension or app for people to be a snowflake (AMO or
proxy-go)
+
 Reporter:  cypherpunks |  Owner:  (none)
 Type:  task| Status:  new
 Priority:  Medium  |  Milestone:
Component:  Circumvention/Snowflake |Version:
 Severity:  Normal  | Resolution:
 Keywords:  snowflake-webextension android  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+

Comment (by cohosh):

 We proposed this as a GSoC project, but if someone wants to work out it
 outside of that, that's also great: https://community.torproject.org/gsoc
 /snowflake-android-proxy/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32921 [Core Tor/Tor]: Code and script changes to run clang-format without breaking checkSpaces or coccinelle

2020-02-07 Thread Tor Bug Tracker & Wiki
#32921: Code and script changes to run clang-format without breaking 
checkSpaces or
coccinelle
+
 Reporter:  nickm   |  Owner:  nickm
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  style, 043-can  |  Actual Points:  1.5
Parent ID:  #29226  | Points:
 Reviewer:  catalyst|Sponsor:
+

Comment (by catalyst):

 Doing a little digging through documentation, it seems like
 `StatementMacros` is new in clang-format-8.0, and `SpaceAfterLogicalNot`
 is new in clang-format-9.0.  The latest branch removes
 `SpaceAfterLogicalNot`, which helps with the latter.  (If we want to go as
 far back as clang-format-3.8 for Debian stretch, we might have to do a lot
 more digging.)

 Once I comment out those directives, clang-format-6.0 on Ubuntu Xenial
 seems to accept the .clang-format file.  (We'll have to parameterize the
 clang-format executable name in the helper script if we want this to run
 easily on Xenial, though, because 3.8 is the default there.)

 We can remove `StatementMacros` by changing the ht.h macros to use the
 "redeclare incomplete struct" trick for eating semicolons, and adjusting
 uses of those macros.  (The examples in the comments in ht.h use
 semicolons after those macros anyway, even though it might cause compiler
 errors/warnings.)  We might want to do that as a child ticket of this
 ticket.

 (Note that we seem to have two readily findable instances of this
 technique with different struct tags: `struct dummy_semicolon_eater__` in
 src/lib/cc/compat_compiler.h and `struct tor_semicolon_eater` in
 src/lib/conf/conftesting.h.  We might want to consolidate them.  I prefer
 the `tor_` prefix for future library-friendliness.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32921 [Core Tor/Tor]: Code and script changes to run clang-format without breaking checkSpaces or coccinelle

2020-02-07 Thread Tor Bug Tracker & Wiki
#32921: Code and script changes to run clang-format without breaking 
checkSpaces or
coccinelle
+
 Reporter:  nickm   |  Owner:  nickm
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  style, 043-can  |  Actual Points:  1.5
Parent ID:  #29226  | Points:
 Reviewer:  catalyst|Sponsor:
+

Comment (by nickm):

 I've pushed a new rebased `clang_format_prep_3`, which is the branch I am
 hoping for review on here.  This branch forces no formatting per se, and
 only prepares for formatting.  https://github.com/torproject/tor/pull/1709
 is the pull request.  There's a CI failure, but it looks like a download
 failure rather than a real bug.

 https://github.com/torproject/tor/pull/1710 is the result of running
 clang-format.sh on that branch. The CI failures are real there due to some
 functions getting longer and making practracker upset.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33138 [Internal Services/Services Admin Team]: New RT queue and alias iff@tpo

2020-02-07 Thread Tor Bug Tracker & Wiki
#33138: New RT queue and alias iff@tpo
---+--
 Reporter:  ggus   |  Owner:  ggus
 Type:  defect | Status:  new
 Priority:  High   |  Milestone:
Component:  Internal Services/Services Admin Team  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by ggus):

 Replying to [comment:2 anarcat]:
 > when's the iff? what's the deadline for this? thanks!

 Ops, forgoto to add that. The Call for Proposals opens February 13th.

 The instructions for 'Creating a queue' looks easy. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33138 [Internal Services/Services Admin Team]: New RT queue and alias iff@tpo

2020-02-07 Thread Tor Bug Tracker & Wiki
#33138: New RT queue and alias iff@tpo
---+--
 Reporter:  ggus   |  Owner:  ggus
 Type:  defect | Status:  new
 Priority:  High   |  Milestone:
Component:  Internal Services/Services Admin Team  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by anarcat):

 oh and can you see if you can create the queue yourself in RT to see if we
 could offload that part of the work, so that us sysadmins only have to
 deal with the underlying email bits (which I'm thinking of automating
 anyways)...

 see if you can pick stuff off this checklist:
 https://help.torproject.org/tsa/howto/rt/ :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33138 [Internal Services/Services Admin Team]: New RT queue and alias iff@tpo

2020-02-07 Thread Tor Bug Tracker & Wiki
#33138: New RT queue and alias iff@tpo
---+--
 Reporter:  ggus   |  Owner:  ggus
 Type:  defect | Status:  new
 Priority:  High   |  Milestone:
Component:  Internal Services/Services Admin Team  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by anarcat):

 when's the iff? what's the deadline for this? thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31239 [Internal Services/Tor Sysadmin Team]: automate installs

2020-02-07 Thread Tor Bug Tracker & Wiki
#31239: automate installs
-+-
 Reporter:  anarcat  |  Owner:  anarcat
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tpa-roadmap-february |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by anarcat):

 one part that was missing in our documentation is the firewall setup. we
 had network allow blocks covering all hosts configured by hand in `tor-
 puppet/modules/ferm/templates/defs.conf.erb`. instead of updating the
 install docs, I just fixed this and shoved it in puppet, in #33143.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33186 [Applications/Tor Browser]: Tab crashes with an error " Gah. Your tab just crashed."

2020-02-07 Thread Tor Bug Tracker & Wiki
#33186: Tab crashes with an error " Gah. Your tab just crashed."
--+--
 Reporter:  oracle|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Blocker   | Resolution:
 Keywords:  crash |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by oracle):

 I've also tried using bridges. But still nothing works

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33186 [Applications/Tor Browser]: Tab crashes with an error " Gah. Your tab just crashed."

2020-02-07 Thread Tor Bug Tracker & Wiki
#33186: Tab crashes with an error " Gah. Your tab just crashed."
+--
 Reporter:  oracle  |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  Medium  |  Component:  Applications/Tor Browser
  Version:  |   Severity:  Blocker
 Keywords:  crash   |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
 I just installed Tor browser on a windows 10 pro laptop.
 Every time I open the browser, I face the error "Gah. Your tab just
 crashed." The same happens when I try to open new tabs.
 I have tried setting browser.tabs.remote.autostart to false. I have also
 tried  to launch the program in safe mode but still the issue persists. I
 have also tried to run Tor without firewall. Then I've also tried
 reinstalling it
 Please guide me on how to solve this, as this doesn't  allow me to use the
 browser at all.

 Regards

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32928 [Core Tor/Tor]: Tor Manual: Split Circuit Timeout options into their own subsection

2020-02-07 Thread Tor Bug Tracker & Wiki
#32928: Tor Manual: Split Circuit Timeout options into their own subsection
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can extra-review  |
Parent ID:  #4310| Points:  0.5
 Reviewer:  catalyst, nickm  |Sponsor:
-+-

Comment (by swati):

 Replying to [comment:15 catalyst]:
 >
 > Thanks for the changes!
 >
 > >  - I added a new section called **Dormant Mode Options** and moved the
 four options under this section. Does anyone want to suggest a better
 introductory sentence for this section?
 >
 > Dormant mode is a state that tor can enter and leave, and the options in
 this section modify that behavior.  Maybe this?
 >
 > "Tor can enter a dormant mode to conserve power and network bandwidth.
 The following options control when tor enters and leaves dormant mode."
 >
 > >  - Also, I renamed the Timeout Options section to **Circuit Timeout
 Options**, as suggested by catalyst. I haven't moved the other options
 that aren't directly related to timeout under this section. Leaving them
 where they are for now. Is that okay?
 >
 > I think that's fine.  I couldn't come up with a concise heading for an
 expanded section that would contain the other options you were
 considering.  I would suggest rewording the introductory paragraph to
 something like this?
 >
 > "The following options are useful for configuring timeouts related to
 building Tor circuits and using them."
 >
 > >  - Can we consider this ticket resolved? If yes, can we merge the PR
 so that I can continue working on the rest of the manual?
 >
 > I think we're mostly there.  There are a couple of minor wording changes
 I suggested above for the introductory text of the new sections.  If you
 agree, please go ahead and make those changes.

 Reworded your suggestion a bit and updated the introductory text in both
 the sections.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33077 [Metrics/Analysis]: Graph results from the torflow to sbws transition

2020-02-07 Thread Tor Bug Tracker & Wiki
#33077: Graph results from the  torflow to sbws transition
-+-
 Reporter:  mikeperry|  Owner:
 |  metrics-team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Analysis |Version:
 Severity:  Normal   | Resolution:
 Keywords:  sbws-roadmap metrics-team-roadmap-   |  Actual Points:
  2020Q1 |
Parent ID:  #33121   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by karsten):

 I made another graph first that shows when directory authorities switched
 from torflow to sbws:

 [[Image(torflow-sbws-transition-2020-02-07.png, 700px)]]

 It looks like longclaw switched back and forth between sbws and torflow on
 2019-02-23 and once more around 2019-03-20, and bastet briefly switched
 from torflow to sbws on 2019-03-09 before switching back. Oh, and maatuska
 temporarily switched to sbws between 2019-12-15 and 2019-12-24 before
 switching permanently on 2020-01-08.

 I'll graph the time around the last switches from torflow to sbws. That
 means the days around 2019-05-28 for the bastet switch and the days around
 2020-01-08 for the maatuska switch. I don't have the data to say when
 exactly longclaw switched, but I can make another graph for that if
 somebody tells me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33077 [Metrics/Analysis]: Graph results from the torflow to sbws transition

2020-02-07 Thread Tor Bug Tracker & Wiki
#33077: Graph results from the  torflow to sbws transition
-+-
 Reporter:  mikeperry|  Owner:
 |  metrics-team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Analysis |Version:
 Severity:  Normal   | Resolution:
 Keywords:  sbws-roadmap metrics-team-roadmap-   |  Actual Points:
  2020Q1 |
Parent ID:  #33121   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by karsten):

 * Attachment "torflow-sbws-transition-2020-02-07.png" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33115 [Webpages/Blog]: Migrating the blog to a static web site with Lektor

2020-02-07 Thread Tor Bug Tracker & Wiki
#33115: Migrating the blog to a static web site with Lektor
---+--
 Reporter:  hiro   |  Owner:  hiro
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Webpages/Blog  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:  10
 Reviewer: |Sponsor:
---+--

Comment (by pili):

 I would like to highlight the need for an events/calendar plugin or
 similar.

 Also, we might want to keep the following notes on this from the last dev
 meeting:
 
https://trac.torproject.org/projects/tor/wiki/org/meetings/2019Stockholm/Notes/Blog

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33138 [Internal Services/Services Admin Team]: New RT queue and alias iff@tpo

2020-02-07 Thread Tor Bug Tracker & Wiki
#33138: New RT queue and alias iff@tpo
---+--
 Reporter:  ggus   |  Owner:  ggus
 Type:  defect | Status:  new
 Priority:  High   |  Milestone:
Component:  Internal Services/Services Admin Team  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by pili):

 * cc: anarcat (added)
 * component:  Community/Outreach => Internal Services/Services Admin Team


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30317 [Circumvention/BridgeDB]: Update howto on https://bridges.torproject.org/ to take mobile Tor Browser into account

2020-02-07 Thread Tor Bug Tracker & Wiki
#30317: Update howto on https://bridges.torproject.org/ to take mobile Tor 
Browser
into account
-+-
 Reporter:  gk   |  Owner:  sysrqb
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Circumvention/BridgeDB   |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-parity, s30-o22a2, anti- |  Actual Points:
  censorship-roadmap-2020Q1  |
Parent ID:  #31279   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor30-must
-+-
Changes (by pili):

 * cc: ggus, PROTechThor (added)
 * status:  needs_information => new


Comment:

 We recently published the Tor Browser for Android manual: https://tb-
 manual.torproject.org/mobile-tor/ and there are some details there

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33113 [Applications/Tor Browser]: Bump NSIS version to 3.05

2020-02-07 Thread Tor Bug Tracker & Wiki
#33113: Bump NSIS version to 3.05
---+--
 Reporter:  cypherpunks|  Owner:  tbb-team
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam202002  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by cypherpunks):

 Enjoy:
 
https://github.com/spesmilo/electrum/commit/570c0aeca39e56c742b77380ec274d178d660c29

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29865 [Webpages/Styleguide]: lektor: anchors bring the links to the top, but it stays under the navigation bar (so you don't see them)

2020-02-07 Thread Tor Bug Tracker & Wiki
#29865: lektor: anchors bring the links to the top, but it stays under the
navigation bar (so you don't see them)
-+
 Reporter:  emmapeel |  Owner:  hiro
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Webpages/Styleguide  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by emmapeel):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 I cannot reproduce this issue anymore, yay!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28827 [Webpages/Styleguide]: Add wordlist to the styleguide

2020-02-07 Thread Tor Bug Tracker & Wiki
#28827: Add wordlist to the styleguide
-+-
 Reporter:  emmapeel |  Owner:  hiro
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Webpages/Styleguide  |Version:
 Severity:  Normal   | Resolution:  wontfix
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by emmapeel):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 We have decided to have only one list of words, and have different
 sections for

 - actual meaning
 - spelling notes
 - translation notes

 it is to be located at support.tpo/glossary and the ticket to follow is
 now

 https://dip.torproject.org/torproject/web/support/issues/82

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33113 [Applications/Tor Browser]: Bump NSIS version to 3.05

2020-02-07 Thread Tor Bug Tracker & Wiki
#33113: Bump NSIS version to 3.05
---+--
 Reporter:  cypherpunks|  Owner:  tbb-team
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam202002  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by gk):

 Replying to [comment:1 cypherpunks]:
 > Should fix #29185.

 What makes you think so?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs