Re: [tor-bugs] #33675 [Core Tor/Chutney]: Search microdescriptor files for relay ed25519 keys

[Tor Bug Tracker & Wiki]

#33675: Search microdescriptor files for relay ed25519 keys
---+---
 Reporter:  teor   |  Owner:  anuradha1904
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Core Tor/Chutney   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ipv6, prop311, outreachy-ipv6  |  Actual Points:  0.1
Parent ID:  #33428 | Points:  0.5
 Reviewer:  teor   |Sponsor:  Sponsor55-can
---+---

Comment (by teor):

 Replying to [comment:8 anuradha1904]:
 > Great, so for "md", all the code that I have to add is:-
 >
 > {{{
 > elif md:
 >  return r'^id ed25519 ' + " "
 > }}}

 Can you explain why you wrote this code?
 Why do you think you need to use the nickname?

 The code in the ticket description is:
 {{{
 elif md:
 # Not yet implemented, see #33428
 # r'^id ed25519 " + ed25519_identity (end of line)
 # needs ed25519-identity from #30642
 # or the existing keys/ed25519_master_id_public_key
 }}}

 At
 https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L1325

 > Am I following the right way, because I checked in the cached-
 microdescs.new file, and the ed25519 key was just after the string "id
 ed25519" and there was no nickname like for ''desc'' and ''cons'' in the
 file ''cached-microdesc-consensus'' and ''cached-microdescs.new''. teor,
 nickm , can you confirm ? If not, where am I wrong? Kindly guide me and
 Thank you.

 Regular expressions are patterns that are matched against each line. You
 can read a short introduction here:
 https://docs.python.org/3/howto/regex.html

 Remember how we just loaded ed25519-id in #33428 ?
 https://github.com/torproject/chutney/pull/61/files#diff-
 5fe4ecd0da6560d24d20e8ce90281abfR792

 Maybe it could be useful here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30317 [Circumvention/BridgeDB]: Update howto on https://bridges.torproject.org/ to take mobile Tor Browser into account

[Tor Bug Tracker & Wiki]

#30317: Update howto on https://bridges.torproject.org/ to take mobile Tor 
Browser
into account
-+-
 Reporter:  gk   |  Owner:  phw
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Circumvention/BridgeDB   |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-parity, s30-o22a2, anti- |  Actual Points:
  censorship-roadmap-2020Q1  |
Parent ID:  #31279   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor30-must
-+-
Changes (by phw):

 * status:  assigned => needs_review


Comment:

 Thanks for the link, pili. It's best to link to tb-manual instead of
 replicating setup instructions on BridgeDB. How about we change the text
 in the box on [https://bridges.torproject.org/howto this page] to the
 following:

 
 == How to start using your bridges

 First, you need to [https://www.torproject.org/download/ download Tor
 Browser]. Our Tor Browser User Manual explains how you can add your
 bridges to Tor Browser. If you are using Windows, Linux, or OS X, [https
 ://tb-manual.torproject.org/bridges/#entering-bridge-addresses click here]
 to learn more. If you are using Android, [https://tb-manual.torproject.org
 /mobile-tor/#circumvention click here].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33683 [Applications/Tor Browser]: Fenix fingerprinting

[Tor Bug Tracker & Wiki]

#33683: Fenix fingerprinting
-+-
 Reporter:  Thorin   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  tbb-fingerprinting-
 Severity:  Normal   |  fenix, tbb-mobile
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 As I come across Fenix-only items I will add them here for consideration:
 sysrqb & gk know how to get hold of me if you need a PoC

 - toolbar location can be detected
- Settings > Customize > Toolbar > Top/Bottom
 - font inflation can be detected
- Settings > Accessibility > Automatic Font Sizing

 Feel free to add more items

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30317 [Circumvention/BridgeDB]: Update howto on https://bridges.torproject.org/ to take mobile Tor Browser into account

[Tor Bug Tracker & Wiki]

#30317: Update howto on https://bridges.torproject.org/ to take mobile Tor 
Browser
into account
-+-
 Reporter:  gk   |  Owner:  phw
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Circumvention/BridgeDB   |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-parity, s30-o22a2, anti- |  Actual Points:
  censorship-roadmap-2020Q1  |
Parent ID:  #31279   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor30-must
-+-
Changes (by phw):

 * owner:  sysrqb => phw
 * status:  new => assigned
 * points:   => 0.5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29286 [Circumvention/Obfs4]: Maintain obfs4 proxy

[Tor Bug Tracker & Wiki]

#29286: Maintain obfs4 proxy
+--
 Reporter:  cohosh  |  Owner:  (none)
 Type:  task| Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Circumvention/Obfs4 |Version:
 Severity:  Normal  | Resolution:  not a
|  bug
 Keywords:  obfs4, maintainance, ex-sponsor-19  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
|  Sponsor30-can
+--
Changes (by phw):

 * status:  new => closed
 * resolution:   => not a bug


Comment:

 I'm closing this ticket because it's not actionable.

 The process for "maintaining" obfs4 is: write a patch and ask Yawning to
 merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33675 [Core Tor/Chutney]: Search microdescriptor files for relay ed25519 keys

[Tor Bug Tracker & Wiki]

#33675: Search microdescriptor files for relay ed25519 keys
---+---
 Reporter:  teor   |  Owner:  anuradha1904
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Core Tor/Chutney   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ipv6, prop311, outreachy-ipv6  |  Actual Points:  0.1
Parent ID:  #33428 | Points:  0.5
 Reviewer:  teor   |Sponsor:  Sponsor55-can
---+---

Comment (by anuradha1904):

 Great, so for "md", all the code that I have to add is:-


 {{{
 elif md:
  return r'^id ed25519 ' + " "
 }}}

 Am I following the right way, because I checked in the cached-
 microdescs.new file, and the ed25519 key was just after the string "id
 ed25519" and there was no nickname like for ''desc'' and ''cons'' in the
 file ''cached-microdesc-consensus'' and ''cached-microdescs.new''. teor,
 nickm , can you confirm ? If not, where am I wrong? Kindly guide me and
 Thank you.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33675 [Core Tor/Chutney]: Search microdescriptor files for relay ed25519 keys

[Tor Bug Tracker & Wiki]

#33675: Search microdescriptor files for relay ed25519 keys
---+---
 Reporter:  teor   |  Owner:  anuradha1904
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Core Tor/Chutney   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ipv6, prop311, outreachy-ipv6  |  Actual Points:  0.1
Parent ID:  #33428 | Points:  0.5
 Reviewer:  teor   |Sponsor:  Sponsor55-can
---+---

Comment (by nickm):

 Err, sorry. That should have said 'something like "test000a" or
 "test006c"'.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33675 [Core Tor/Chutney]: Search microdescriptor files for relay ed25519 keys

[Tor Bug Tracker & Wiki]

#33675: Search microdescriptor files for relay ed25519 keys
---+---
 Reporter:  teor   |  Owner:  anuradha1904
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Core Tor/Chutney   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ipv6, prop311, outreachy-ipv6  |  Actual Points:  0.1
Parent ID:  #33428 | Points:  0.5
 Reviewer:  teor   |Sponsor:  Sponsor55-can
---+---

Comment (by nickm):

 It's a short string that identifies the node, typically something like
 "000a" or "006c"

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33675 [Core Tor/Chutney]: Search microdescriptor files for relay ed25519 keys

[Tor Bug Tracker & Wiki]

#33675: Search microdescriptor files for relay ed25519 keys
---+---
 Reporter:  teor   |  Owner:  anuradha1904
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Core Tor/Chutney   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ipv6, prop311, outreachy-ipv6  |  Actual Points:  0.1
Parent ID:  #33428 | Points:  0.5
 Reviewer:  teor   |Sponsor:  Sponsor55-can
---+---

Comment (by anuradha1904):

 Thank you nickm. Also, Can you explain me what does "nickname" mean in
 function getNodeDirInfoStatusPattern? Thank you.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33258 [Metrics]: Add CSV file export of graphed data

[Tor Bug Tracker & Wiki]

#33258: Add CSV file export of graphed data
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020Q1  |  Actual Points:
Parent ID:  #33327   | Points:  1
 Reviewer:   |Sponsor:  Sponsor59
-+--
Changes (by karsten):

 * status:  new => needs_review


Comment:

 I started working on #33256 and #33258 in parallel and now have a patch
 for review that implements #33258. This patch contains a rewrite of tgen
 plots to use the pandas and seaborn libraries.

 On the plus side of using pandas, it's really easy to export graphed data
 to a .csv file. And it's in general good practice to separate all data
 tidying from visualization.

 On the minus side, I didn't want to update all the old PyLab code to use
 pandas. Instead I switched that code to using seaborn, which is much newer
 and much higher-level. The code is much shorter and easier to read. But it
 comes with a few changes to produced plots that we need to discuss.

 I attached
 
[https://trac.torproject.org/projects/tor/attachment/ticket/33258/tgen.onionperf.viz.2020-03-20_10%3A06%3A21.pdf
 old] and
 
[https://trac.torproject.org/projects/tor/attachment/ticket/33258/tgen.onionperf.viz.2020-03-20_23%3A27%3A42.pdf
 new] tgen plots as .pdf files. Changes are:

  - ECDFs "Time to download first byte" and "Time to download last of {
 51200, 1048576, 5242880 } bytes" remain mostly unchanged. One very minor
 change is that lines now extend to (-Inf, 0) and (Inf, 1). As before,
 these plots are set to focus on values up to the 99th percentile.

  - Time plots "Time to download { first, last } of { 51200, 1048576,
 5242880 } bytes over time" are roughly the same as the "mean time to
 download [...]" plots. Noticeable differences are that the x axis uses
 datetime values rather than "ticks" and that the plot has changed from
 line to scatter plot. The rationale behind switching from lines to dots is
 that measurements are mostly independent from each other. This fact is
 better expressed by using a single dot per measurement rather than shorter
 or longer lines depending on how different subsequent measurements were
 and how much time has passed between those measurements.

  - Box plots "Time to download last of { 51200, 1048576, 5242880 } bytes"
 replace the "median time to download [...]" plots by giving more detail
 than just the median. They do not, however, show maxima or even any
 outliers at all, because extreme outliers can make it difficult to read
 the median value.

  - Bar plots "Mean time to download last of { 51200, 1048576, 5242880 }
 bytes" replace the "mean time to download [...]" plots. It's questionable
 whether these plots are still required with the box plots being present.

  - There are no equivalents for "max time to download [...]" plots,
 because the maximum download time can also be obtained from time plots. If
 having plots with download time maxima is for some reason important, they
 could be re-added as bar plots.

  - Count plots "Number of downloads of { 51200, 1048576, 5242880 } bytes
 completed" replace their similarly named equivalents but are much more
 readable.

  - There are no equivalents for "number of { 51200, 1048576, 5242880 }
 bytes completed, all clients over time". These time plots are basically
 the same as the time plots showing download time, except that those have
 useful y values which these don't have.

  - Count plots "Number of downloads failed" and time plot "Download
 runtime until error" replace the various error graphs which didn't seem to
 be as useful.

 Regarding tor plots I'm a bit unclear why we would need them at all. I
 attached the
 
[https://trac.torproject.org/projects/tor/attachment/ticket/33258/tor.onionperf.viz.2020-03-20_10%3A06%3A36.pdf
 old] tor plots as .pdf file for discussion here. I did not yet rewrite
 this code, because maybe we can kill it right away. Some notes:

  - The "60 second moving average [...]" graphs are currently broken. The x
 axis is supposed to be the time in seconds, but it starts at unix time 0
 or 1970-01-01. If you look very closely at the space right to the
 legend you'll find the data points. However, I don't know how this
 visualization can be useful for anything besides debugging a handful of
 measurements.

  - The "1 second throughput [...]" graphs would be more useful with a
 higher data resolution than 1 KiB/s, which is the reason for those huge
 steps. But even if the ECDFs would be smoother, is this really something
 we care about?

 I attached my Git

Re: [tor-bugs] #33258 [Metrics]: Add CSV file export of graphed data

[Tor Bug Tracker & Wiki]

#33258: Add CSV file export of graphed data
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020Q1  |  Actual Points:
Parent ID:  #33327   | Points:  1
 Reviewer:   |Sponsor:  Sponsor59
-+--
Changes (by karsten):

 * Attachment "0001-Rewrite-tgen-plots-to-use-pandas-and-seaborn.patch"
 added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33675 [Core Tor/Chutney]: Search microdescriptor files for relay ed25519 keys

[Tor Bug Tracker & Wiki]

#33675: Search microdescriptor files for relay ed25519 keys
---+---
 Reporter:  teor   |  Owner:  anuradha1904
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Core Tor/Chutney   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ipv6, prop311, outreachy-ipv6  |  Actual Points:  0.1
Parent ID:  #33428 | Points:  0.5
 Reviewer:  teor   |Sponsor:  Sponsor55-can
---+---

Comment (by nickm):

 Generally it's best to have one issue per PR; that way they can get
 reviewed and merged independently. (Reviewing two little PRs is usally
 easier than reviewing one big one.)

 That said, if branches have to edit the same part of the file, then there
 might be merge conflicts. If that's the case, it's probably better to have
 one branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33258 [Metrics]: Add CSV file export of graphed data

[Tor Bug Tracker & Wiki]

#33258: Add CSV file export of graphed data
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020Q1  |  Actual Points:
Parent ID:  #33327   | Points:  1
 Reviewer:   |Sponsor:  Sponsor59
-+--
Changes (by karsten):

 * Attachment "tgen.onionperf.viz.2020-03-20_23:27:42.pdf" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33258 [Metrics]: Add CSV file export of graphed data

[Tor Bug Tracker & Wiki]

#33258: Add CSV file export of graphed data
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020Q1  |  Actual Points:
Parent ID:  #33327   | Points:  1
 Reviewer:   |Sponsor:  Sponsor59
-+--
Changes (by karsten):

 * Attachment "tgen.onionperf.viz.2020-03-20_10:06:21.pdf" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33258 [Metrics]: Add CSV file export of graphed data

[Tor Bug Tracker & Wiki]

#33258: Add CSV file export of graphed data
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020Q1  |  Actual Points:
Parent ID:  #33327   | Points:  1
 Reviewer:   |Sponsor:  Sponsor59
-+--
Changes (by karsten):

 * Attachment "tor.onionperf.viz.2020-03-20_10:06:36.pdf" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33675 [Core Tor/Chutney]: Search microdescriptor files for relay ed25519 keys

[Tor Bug Tracker & Wiki]

#33675: Search microdescriptor files for relay ed25519 keys
---+---
 Reporter:  teor   |  Owner:  anuradha1904
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Core Tor/Chutney   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ipv6, prop311, outreachy-ipv6  |  Actual Points:  0.1
Parent ID:  #33428 | Points:  0.5
 Reviewer:  teor   |Sponsor:  Sponsor55-can
---+---

Comment (by anuradha1904):

 Hey teor, can you break down this problem for me a little bit, I am unable
 to understand the function  getNodeDirInfoStatusPattern(). Thank you.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33675 [Core Tor/Chutney]: Search microdescriptor files for relay ed25519 keys

[Tor Bug Tracker & Wiki]

#33675: Search microdescriptor files for relay ed25519 keys
---+---
 Reporter:  teor   |  Owner:  anuradha1904
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Core Tor/Chutney   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ipv6, prop311, outreachy-ipv6  |  Actual Points:  0.1
Parent ID:  #33428 | Points:  0.5
 Reviewer:  teor   |Sponsor:  Sponsor55-can
---+---

Comment (by anuradha1904):

 hey teor, should I do all the changes on the same branch by making commits
 for each issue solved or rather make different PRs, since all the issue
 assigned to me are in the same file.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19251 [Applications/Tor Browser]: TorBrowser might want to have an error page specific to when .onion links fail

[Tor Bug Tracker & Wiki]

#19251: TorBrowser might want to have an error page specific to when .onion 
links
fail
+--
 Reporter:  cypherpunks |  Owner:  brade
 Type:  enhancement | Status:  needs_review
 Priority:  Low |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ux-team, TorBrowserTeam202003R  |  Actual Points:  6.7
Parent ID:  #30025  | Points:  6
 Reviewer:  acat,pospeselr  |Sponsor:
|  Sponsor27-must
+--

Comment (by mcs):

 Replying to [comment:47 pospeselr]:
 > Looks good, assuming you meant tor-browser patch:
 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug19251-04

 Wow, how did I post that and not notice? Yes, the commit on the
 `bug19251-04` branch is the one I meant.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19251 [Applications/Tor Browser]: TorBrowser might want to have an error page specific to when .onion links fail

[Tor Bug Tracker & Wiki]

#19251: TorBrowser might want to have an error page specific to when .onion 
links
fail
+--
 Reporter:  cypherpunks |  Owner:  brade
 Type:  enhancement | Status:  needs_review
 Priority:  Low |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ux-team, TorBrowserTeam202003R  |  Actual Points:  6.7
Parent ID:  #30025  | Points:  6
 Reviewer:  acat,pospeselr  |Sponsor:
|  Sponsor27-must
+--

Comment (by pospeselr):

 Looks good, assuming you meant tor-browser patch:
 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug19251-04

 :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33679 [Core Tor/Tor]: Make sure every address function that takes for_listening supports IPv6

[Tor Bug Tracker & Wiki]

#33679: Make sure every address function that takes for_listening supports IPv6
---+---
 Reporter:  teor   |  Owner:  MrSquanchee
 Type:  task   | Status:
   |  needs_revision
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop312, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33049 | Points:  0.5
 Reviewer: |Sponsor:
   |  Sponsor55-must
---+---
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:2 MrSquanchee]:
 > > Make sure every address function that takes for_listening supports
 IPv6
 >
 > I see only one such function.

 There are at least 5 such functions.
 Of the ones I checked, 3 only support IPv4, and 1 already supports IPv6
 for_listening.
 Please double-check by searching address.c for for_listening.

 > You can see my PR here https://github.com/torproject/tor/pull/1831

 Thanks!

 Please update the function comment so it describes what the function does
 now.

 And please add tests for the new code you just added.

 It would also be great to simplify the IPv4 case the same way you
 simplified the IPv6 case.
 (If for_listening is true, any IPv4 address is acceptable.)

 And merge the IPv4 and IPv6 cases, if you can find a simple way to do it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28005 [Applications/Tor Browser]: Officially support onions in HTTPS-Everywhere

[Tor Bug Tracker & Wiki]

#28005: Officially support onions in HTTPS-Everywhere
-+-
 Reporter:  asn  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, https-everywhere, network-   |  Actual Points:  18
  team-roadmap-november, network-team-roadmap-   |
  2020Q1, TorBrowserTeam202003R, ux-team |
Parent ID:  #30029   | Points:  20
 Reviewer:  mcs, sysrqb, antonela|Sponsor:
 |  Sponsor27-must
-+-

Comment (by mcs):

 One thing I forgot to mention: the SecureDrop ruleset maps
 `www.nytimes.com.securedrop.tor.onion` to the NYT SecureDrop service. It
 is inconvenient to require the `www.` prefix as well as `.com`.  But I am
 not sure what process was used to create the ruleset and how it will be
 maintained by SecureDrop people going forward.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33682 [Metrics/Exit Scanner]: TorBulkExitList.py has wrong mimetype

[Tor Bug Tracker & Wiki]

#33682: TorBulkExitList.py has wrong mimetype
--+--
 Reporter:  arma  |  Owner:  metrics-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Metrics/Exit Scanner  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 In the various exitlist changes, it looks like
 https://check.torproject.org/cgi-bin/TorBulkExitList.py
 has turned into a "download this python script" rather than the cgi that
 it used to be.

 It's linked from various external sites, and also from internal sites like
 https://2019.www.torproject.org/docs/faq-abuse.html.en#Bans

 We should probably do something smarter than trying to download a python
 script to the person's hard drive.

 Maybe we make it a redirect to
 https://check.torproject.org/torbulkexitlist
 or maybe we make it a little html note that the old script doesn't work
 anymore and here are pointers to the blog post and tor-project@ mail.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33679 [Core Tor/Tor]: Make sure every address function that takes for_listening supports IPv6

[Tor Bug Tracker & Wiki]

#33679: Make sure every address function that takes for_listening supports IPv6
---+---
 Reporter:  teor   |  Owner:  MrSquanchee
 Type:  task   | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop312, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33049 | Points:  0.5
 Reviewer: |Sponsor:
   |  Sponsor55-must
---+---
Changes (by MrSquanchee):

 * status:  assigned => needs_review


Comment:

 > Make sure every address function that takes for_listening supports IPv6

 I see only one such function.

 You can see my PR here https://github.com/torproject/tor/pull/1831

 Thanks,

 MrSquanchee.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33676 [Core Tor/Chutney]: Stop waiting a set time for microdescriptors

[Tor Bug Tracker & Wiki]

#33676: Stop waiting a set time for microdescriptors
---+---
 Reporter:  teor   |  Owner:  anuradha1904
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Core Tor/Chutney   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ipv6, prop311, outreachy-ipv6  |  Actual Points:
Parent ID:  #33428 | Points:  0.5
 Reviewer:  teor   |Sponsor:  Sponsor55-can
---+---
Description changed by teor:

Old description:

> When we make chutney check for microdescriptors, we can stop waiting a
> set time for microdescriptors to download.
>
> Please read these instructions carefully. Don't leave out any steps!
>
> First, set MIN_START_TIME_LEGACY and NODE_WAIT_FOR_UNCHECKED_DIR_INFO to
> 0:
> https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L926
> https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L952
>
> Then check that `make test-network-all` still passes on:
> * Tor master, and
> * Tor maint-0.3.5
>
> You can build a different tor branch using the following commands:
> {{{
> git checkout 
> make
> }}}
>
> Check the new code on your own machine, and then submit a pull request to
> run Chutney's CI.
>
> If all those tests pass, you can remove all the code that uses
> MIN_START_TIME_LEGACY and NODE_WAIT_FOR_UNCHECKED_DIR_INFO:
> * remove NODE_WAIT_FOR_UNCHECKED_DIR_INFO
> * replace NODE_WAIT_FOR_UNCHECKED_DIR_INFO with 0 in
> getUncheckedDirInfoWaitTime()
> * remove getMinStartTime()
> * remove all the constants getMinStartTime() uses
> * remove all calls to getMinStartTime()
> * remove all the variables, code, and comments that depend on
> getMinStartTime()
>   *
> https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L2224
>   *
> https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L2273
>
> Then add a commit to your pull request with these changes, and check that
> they pass CI.

New description:

 Your code in #33675 needs to pass your local "make test-network-all", on
 master and maint-0.3.5, before you start this ticket.

 When we make chutney check for microdescriptors, we can stop waiting a set
 time for microdescriptors to download.

 Please read these instructions carefully. Don't leave out any steps!

 First, set MIN_START_TIME_LEGACY and NODE_WAIT_FOR_UNCHECKED_DIR_INFO to
 0:
 https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L926
 https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L952

 Then check that `make test-network-all` still passes on:
 * Tor master, and
 * Tor maint-0.3.5

 You can build a different tor branch using the following commands:
 {{{
 git checkout 
 make
 }}}

 Check the new code on your own machine, and then submit a pull request to
 run Chutney's CI.

 If all those tests pass, you can remove all the code that uses
 MIN_START_TIME_LEGACY and NODE_WAIT_FOR_UNCHECKED_DIR_INFO:
 * remove NODE_WAIT_FOR_UNCHECKED_DIR_INFO
 * replace NODE_WAIT_FOR_UNCHECKED_DIR_INFO with 0 in
 getUncheckedDirInfoWaitTime()
 * remove getMinStartTime()
 * remove all the constants getMinStartTime() uses
 * remove all calls to getMinStartTime()
 * remove all the variables, code, and comments that depend on
 getMinStartTime()
   *
 https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L2224
   *
 https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L2273

 Then add a commit to your pull request with these changes, and check that
 they pass CI.

 You can ignore macOS hangs ("red ! symbol") on Travis CI. It is a bit
 unstable right now.

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28005 [Applications/Tor Browser]: Officially support onions in HTTPS-Everywhere

[Tor Bug Tracker & Wiki]

#28005: Officially support onions in HTTPS-Everywhere
-+-
 Reporter:  asn  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, https-everywhere, network-   |  Actual Points:  18
  team-roadmap-november, network-team-roadmap-   |
  2020Q1, TorBrowserTeam202003R, ux-team |
Parent ID:  #30029   | Points:  20
 Reviewer:  mcs, sysrqb, antonela|Sponsor:
 |  Sponsor27-must
-+-

Comment (by mcs):

 Replying to [comment:34 acat]:
 > The issue with
 https://trac.torproject.org/projects/tor/ticket/21952#comment:117 would
 also affect this one, so I made a small revision to not use
 `onStateChange` and use `onLocationChange` instead:
 https://github.com/acatarineu/tor-browser/commit/28005+3.

 Good catch. Just a few more comments from Kathy and me:

 Is there a version of HTTPS-E available that supports the new
 `get_simple_rules_ending_with` API? When we tested with HTTPS-E 2020.3.16
 we saw some strange behavior, but if that is supposed to work we can try
 again.

 Related to `browser/components/onionservices/HttpsEverywhereControl.jsm`:
 * Should we open a new ticket for the "lock the channel to prevent user
 changes" issue? Is it a foot gun? I guess the idea is that we do not want
 users to substitute their own URL, etc. with the SecureDrop ruleset. On
 the other hand, I think users can add their own .tor.onion rules.
 * In `getRulesetTimestamp()` please add a comment to explain the structure
 of the rulesets returned by HTTPS-E via `get_ruleset_timestamps` (or maybe
 the comment can point to some HTTPS-E doc or code). For example, why do we
 have `return securedrop[1];`?

 Related to `browser/components/onionservices/OnionAliasStore.jsm`:
 * Within the `_periodicRulesetCheck()` comment s/preferrable/preferable/
 * Within the `init()` comment: s/a http observer/an http observer/
 * In the "Found ruleset" debugging output, there is a space after the
 first timestamp, e.g., `OnionAlias: Found ruleset timestamp 1582940785 ,
 current is 1582940785`. I wonder if you can use string substitutions to
 construct the log messages instead of a list of JS values
 (https://developer.mozilla.org/en-
 US/docs/Web/API/Console#Using_string_substitutions).

 Related to Torbutton's `chrome/content/tor-circuit-display.js`:
 * Within `xmlTree() the `let element =` block is indented too much.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33675 [Core Tor/Chutney]: Search microdescriptor files for relay ed25519 keys

[Tor Bug Tracker & Wiki]

#33675: Search microdescriptor files for relay ed25519 keys
---+---
 Reporter:  teor   |  Owner:  anuradha1904
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Core Tor/Chutney   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ipv6, prop311, outreachy-ipv6  |  Actual Points:  0.1
Parent ID:  #33428 | Points:  0.5
 Reviewer:  teor   |Sponsor:  Sponsor55-can
---+---
Description changed by teor:

Old description:

> We need to enable searching for ed25519 keys in relay microdescriptor
> files.
>
> There are instructions and a draft search pattern here:
> https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L1325
>
> Please open a new pull request for this ticket. Your branch should be
> based on the final version of #33428.

New description:

 Your code in #33428 needs to pass your local "make test-network-all",
 before you start this ticket.

 We need to enable searching for ed25519 keys in relay microdescriptor
 files.

 There are instructions and a draft search pattern here:
 https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L1325

 Please open a new pull request for this ticket. Your branch should be
 based on the final version of #33428.

 Before you push new changes to your pull request, your chutney code should
 pass:
 * "make test-network-all" on tor master
 * "make test-network-all" on tor maint-0.3.5

 You can build a tor branch using these commands:
 {{{
 cd tor
 git checkout -b 
 make
 }}}
 Where  is master or maint-0.3.5

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33428 [Core Tor/Chutney]: Make chutney check for relay microdescriptors before verifying

[Tor Bug Tracker & Wiki]

#33428: Make chutney check for relay microdescriptors before verifying
---+---
 Reporter:  teor   |  Owner:  anuradha1904
 Type:  enhancement| Status:
   |  needs_revision
 Priority:  Medium |  Milestone:
Component:  Core Tor/Chutney   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ipv6, prop311, outreachy-ipv6  |  Actual Points:  0.3
Parent ID:  #33050 | Points:  1
 Reviewer:  teor   |Sponsor:  Sponsor55-can
---+---

Comment (by teor):

 Before you push new changes to your pull request, your chutney code should
 pass:
 * "make test-network-all" on tor master

 If you get stuck, the getting started instructions have more details:
 *
 
https://trac.torproject.org/projects/tor/wiki/Outreachy#Gettingstartedwithtordevelopment

 But be careful, some of the commands are different.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0435,|  Actual Points:  1.1
  043-should, ipv6, 035-backport, 041-backport,  |
  042-backport, 043-backport |
Parent ID:  #33048   | Points:  1
 Reviewer:  nickm, teor  |Sponsor:
 |  Sponsor55-must
-+-
Changes (by teor):

 * status:  needs_revision => merge_ready


Comment:

 I squashed my changes, nick's changes, my extra tests, and some minor test
 fixes.

 See my PRs:
 * 0.3.5: https://github.com/torproject/tor/pull/1827
 * 0.4.1: https://github.com/torproject/tor/pull/1828
 * 0.4.3: https://github.com/torproject/tor/pull/1829
 * master: https://github.com/torproject/tor/pull/1830

 Test branches are here:
 * https://github.com/teor2345/tor/branches/all?query=32588

 Anyone can merge after CI passes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33680 [Internal Services/Tor Sysadmin Team]: Please deactivate email forwarding for wayward@

[Tor Bug Tracker & Wiki]

#33680: Please deactivate email forwarding for wayward@
-+-
 Reporter:  ewyatt   |  Owner:  anarcat
 Type:  task | Status:  closed
 Priority:  Low  |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by anarcat):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 done!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33680 [Internal Services/Tor Sysadmin Team]: Please deactivate email forwarding for wayward@

[Tor Bug Tracker & Wiki]

#33680: Please deactivate email forwarding for wayward@
-+-
 Reporter:  ewyatt   |  Owner:  anarcat
 Type:  task | Status:
 |  accepted
 Priority:  Low  |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by anarcat):

 * status:  new => accepted
 * owner:  tpa => anarcat


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33681 [Core Tor/Tor]: Refactor using_default_dir_authorities() local address checks

[Tor Bug Tracker & Wiki]

#33681: Refactor using_default_dir_authorities() local address checks
+
 Reporter:  teor|  Owner:  teor
 Type:  task| Status:  assigned
 Priority:  Medium  |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  |   Keywords:  prop312, ipv6
Actual Points:  |  Parent ID:  #33236
   Points:  0.5 |   Reviewer:
  Sponsor:  Sponsor55-must  |
+
 Currently, we check for IPv4 and IPv6 local addresses and
 using_default_dir_authorities() in two different places:
 * IPv4: resolve_my_address()
 * IPv6: router_get_advertised_ipv6_or_ap()

 Once we've combined the code that checks IPv4 and IPv6 advertised ORPorts,
 we can do a single using_default_dir_authorities() check.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33674 [Core Tor/Tor]: Check return value handling in the relay and dirauth stubs

[Tor Bug Tracker & Wiki]

#33674: Check return value handling in the relay and dirauth stubs
+
 Reporter:  teor|  Owner:  teor
 Type:  task| Status:  closed
 Priority:  Medium  |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  technical-debt  |  Actual Points:  0.4
Parent ID:  | Points:  0.5
 Reviewer:  nickm   |Sponsor:
+

Comment (by teor):

 (Actually, I cherry-picked the new commits from master, because the 0.4.3
 PR was squashed.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #4826 [Core Tor/Tor]: Write proposal for improved consensus voting schedules

[Tor Bug Tracker & Wiki]

#4826: Write proposal for improved consensus voting schedules
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  needs-proposal, tor-dirauth voting   |  duplicate
  robustness |  Actual Points:
Parent ID:   | Points:  5
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Fixed in #4631.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33674 [Core Tor/Tor]: Check return value handling in the relay and dirauth stubs

[Tor Bug Tracker & Wiki]

#33674: Check return value handling in the relay and dirauth stubs
+
 Reporter:  teor|  Owner:  teor
 Type:  task| Status:  closed
 Priority:  Medium  |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  technical-debt  |  Actual Points:  0.4
Parent ID:  | Points:  0.5
 Reviewer:  nickm   |Sponsor:
+
Changes (by teor):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 CI passed, merged to master. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32994 [Core Tor/Tor]: Get all flag defaults from port_cfg_new()

[Tor Bug Tracker & Wiki]

#32994: Get all flag defaults from port_cfg_new()
-+-
 Reporter:  teor |  Owner:
 |  MrSquanchee
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  extra-review, technical-debt, tor-   |  Actual Points:  0.3
  client, easy, intro, outreachy-ipv6|
Parent ID:   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 This looks good.

 A nice follow up patch to this would be to change some of the integer
 values that we use with only zero and ones to be C99 `bool`'s instead of
 integers :-)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33672 [Applications/Tor Browser]: Force include https-everywhere in incremental mar update

[Tor Bug Tracker & Wiki]

#33672: Force include https-everywhere in incremental mar update
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202003R |  Actual Points:  .2
Parent ID:| Points:
 Reviewer:  brade, mcs|Sponsor:
--+--

Comment (by sysrqb):

 That's disappointing. I looked at staged extensions, instead of
 distribution addons, but I believe you are correct.

 [https://gitweb.torproject.org/tor-
 browser.git/tree/toolkit/mozapps/extensions/internal/XPIInstall.jsm?h=tor-
 browser-68.6.0esr-9.5-1#n3768 XPIInstall.jsm::installDistributionAddon]

 {{{
 let state = location.get(id);

 if (state) {
   try {
 let existingAddon = await loadManifestFromFile(state.file,
 location);

 if (Services.vc.compare(addon.version, existingAddon.version) <=
 0) {
   return null;
 }
 }}}

 Which is called from `XPIProvider::installDistributionAddons`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33618 [Core Tor/Tor]: Add IPv6 Support to is_local_addr()

[Tor Bug Tracker & Wiki]

#33618: Add IPv6 Support to is_local_addr()
--+
 Reporter:  kimimaro  |  Owner:  kimimaro
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:  Tor:
  |  0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  outreachy-ipv6 ipv6  prop312  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:  Sponsor55-can
--+

Comment (by teor):

 Oops, the pull request is: https://github.com/torproject/tor/pull/1825

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33618 [Core Tor/Tor]: Add IPv6 Support to is_local_addr()

[Tor Bug Tracker & Wiki]

#33618: Add IPv6 Support to is_local_addr()
--+
 Reporter:  kimimaro  |  Owner:  kimimaro
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:  Tor:
  |  0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  outreachy-ipv6 ipv6  prop312  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:  Sponsor55-can
--+

Comment (by teor):

 Thanks for the pull request, I made some comments asking for changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33680 [Internal Services/Tor Sysadmin Team]: Please deactivate email forwarding for wayward@

[Tor Bug Tracker & Wiki]

#33680: Please deactivate email forwarding for wayward@
-+-
 Reporter:  ewyatt   |  Owner:  tpa
 Type:  task | Status:  new
 Priority:  Low  |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 {{{
 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA512


 Please deactivate email forwarding for wayward@. She has been notified and
 acknowledged the notice. Thanks.

 -BEGIN PGP SIGNATURE-
 Comment: GPGTools - https://gpgtools.org

 iQIzBAEBCgAdFiEENecqn2ZVRfkstmYkugyUAPgPkc4FAl504/QACgkQugyUAPgP
 kc4ahBAAg/EPt3m1uOl+6VUVap4nUenGzmqHVirU0GWo2ieCwrV/x4OzVnrEPyqL
 hjlnb+VBTtasNss81muT6f53ACztIJHTfcLP0oUGIji2QXJB3kON8NUkdvE6zI5c
 eq6IdhDkZ53EHlOiVwGz6G8uTzubvsjK+rY1PPjHZaPQwqdvIk8jR/Whx6YEoNTS
 oLpbRxkuQiIY66J9sPKhdQR3peZUqjFZl3UG0d4AFT3CfXOkwQXcJlFSqrmWVsJc
 0J97yb42ePSQGsBjKeOJNC7/v7BowBPKS9/1c91Lp82fuvpP6zaIwHFWH+Ub2DQU
 A7z7MQhl4wwGZLeQrhp3Qdqgz571PO1jM3pToI4NzBPMKZIXtnZziR2vmkH3d2gM
 +sQ/ctXels1WljZUsS8qOtCb0nN1WW6M322q/FDpxoCCcc89amH3+YqYpl+OE9Hp
 ALP48uOOoAf8A1EahWnb/Rwzgk2O3opiiTvvD23r76x1IyoFRtaOUGIHHJfAFICu
 13dkavarU3dYguBcNNU3/PWNYVxNK+QwjSqK3O6Z36L/eXXqIMtWWudVou5SSq4d
 lyid1qBHZnWX1wUPDhr8aVoHrYjvweWSqnfxwfWCx6ZEVuH37biybJd9xSwKLk+Y
 buFTut1bjbRgM6ER1PSAeM4bWPJRcsw4KxhOly1hiy41HgLVgLo=
 =uOUY
 -END PGP SIGNATURE-

 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33672 [Applications/Tor Browser]: Force include https-everywhere in incremental mar update

[Tor Bug Tracker & Wiki]

#33672: Force include https-everywhere in incremental mar update
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202003R |  Actual Points:  .2
Parent ID:| Points:
 Reviewer:  brade, mcs|Sponsor:
--+--

Comment (by mcs):

 On macOS, I do not think it will help to include an older version of
 HTTPS-E under `Contents/Resources/distribution/extensions/`. The .xpi will
 not be copied into the user's profile unless it is a newer version than
 what is already in the profile. I think the following is the relevant
 code:
 https://gitweb.torproject.org/tor-
 browser.git/tree/toolkit/mozapps/extensions/internal/XPIProvider.jsm?h
 =tor-browser-68.6.0esr-9.5-1#n2788

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0435,|  Actual Points:  1.1
  043-should, ipv6, 035-backport, 041-backport,  |
  042-backport, 043-backport |
Parent ID:  #33048   | Points:  1
 Reviewer:  nickm, teor  |Sponsor:
 |  Sponsor55-must
-+-
Changes (by teor):

 * keywords:
 043-should, ipv6, memory-safety, security-low, 035-backport,
 040-backport, 041-backport, 042-backport
 =>
 consider-backport-after-0435, 043-should, ipv6, 035-backport,
 041-backport, 042-backport, 043-backport
 * actualpoints:  1 => 1.1
 * milestone:  Tor: 0.4.3.x-final => Tor: 0.4.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  043-should, ipv6, memory-safety, |  Actual Points:  1
  security-low, 035-backport, 040-backport,  |
  041-backport, 042-backport |
Parent ID:  #33048   | Points:  1
 Reviewer:  nickm, teor  |Sponsor:
 |  Sponsor55-must
-+-

Comment (by teor):

 I tweaked a few of the tests, and fixed the changes file.

 See my PR:
 * 0.3.5: https://github.com/torproject/tor/pull/1826

 I'll squash and create merge forward branches after the tests pass.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33672 [Applications/Tor Browser]: Force include https-everywhere in incremental mar update

[Tor Bug Tracker & Wiki]

#33672: Force include https-everywhere in incremental mar update
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202003R |  Actual Points:  .2
Parent ID:| Points:
 Reviewer:  brade, mcs|Sponsor:
--+--
Changes (by boklm):

 * status:  new => needs_review
 * keywords:   => TorBrowserTeam202003R
 * actualpoints:   => .2


Comment:

 After generating incremental mars with this patch, in the
 `updatev3.manifest` from linux, windows, macos incremental mars, I can see
 an `add` line for `https-everywhere-...@eff.org.xpi`, so this seems to be
 working.

 I rebased the two patches on `maint-9.0` in branch `bug_33672-maint-9.0`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 
build.git/commit/?h=bug_33672-maint-9.0&id=03858651f89915f2e266f66ff0b07343c1196bfd

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
---+---
 Reporter:  teor   |  Owner:  MrSquanchee
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33052 | Points:  1
 Reviewer: |Sponsor:  Sponsor55-can
---+---

Comment (by teor):

 I found these examples by searching the tor github for "consensus
 parameter".

 If you tell us what you've already looked at (with links), then we won't
 suggest the same things. And we have a better idea of what you're missing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33674 [Core Tor/Tor]: Check return value handling in the relay and dirauth stubs

[Tor Bug Tracker & Wiki]

#33674: Check return value handling in the relay and dirauth stubs
+
 Reporter:  teor|  Owner:  teor
 Type:  task| Status:  needs_revision
 Priority:  Medium  |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  technical-debt  |  Actual Points:  0.4
Parent ID:  | Points:  0.5
 Reviewer:  nickm   |Sponsor:
+
Changes (by teor):

 * keywords:  043-must, technical-debt => technical-debt
 * milestone:  Tor: 0.4.3.x-final => Tor: 0.4.4.x-final
 * actualpoints:  0.3 => 0.4


Comment:

 Replying to [comment:4 nickm]:
 > Actually, it looks like there is a non-spurious CI warning on the master
 version:
 > {{{
 > ./src/feature/relay/routerkeys.h:92:36: error: parameter ‘sign_out’ set
 but not used [-Werror=unused-but-set-parameter]
 >int *sign_out)
 > ^~~~
 > ./src/feature/relay/routerkeys.h: In function
 ‘make_tap_onion_key_crosscert’:
 > ./src/feature/relay/routerkeys.h:106:35: error: parameter ‘len_out’ set
 but not used [-Werror=unused-but-set-parameter]
 >   int *len_out)
 >^~~
 > }}}
 >
 > (The 0.4.3 branch is already merged)

 The master CI is running because I pushed a fix for that issue :-)

 Unfortunately, it doesn't show up on my local compiler, so it's been hard
 to make sure I caught all the bugs.

 Once CI passes, anyone can merge:
 * master: https://github.com/torproject/tor/pull/1822

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33674 [Core Tor/Tor]: Check return value handling in the relay and dirauth stubs

[Tor Bug Tracker & Wiki]

#33674: Check return value handling in the relay and dirauth stubs
+
 Reporter:  teor|  Owner:  teor
 Type:  task| Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  technical-debt  |  Actual Points:  0.4
Parent ID:  | Points:  0.5
 Reviewer:  nickm   |Sponsor:
+
Changes (by teor):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32804 [Core Tor/Tor]: Travis CI hangs during compile or test

[Tor Bug Tracker & Wiki]

#32804: Travis CI hangs during compile or test
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci-rarely-fail, tor-test, hang,  |  Actual Points:
  tor-ci, 043-should |
Parent ID:  #29645   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 MacStadium and Travis CI have both reported macOS outages from March 19
 1930-1950 UTC:
 * https://status.macstadium.com/incidents/l464rrkdg4yn
 * https://www.traviscistatus.com/incidents/9861dc7dtsb0

 They believe it's fixed, but we're still seeing issues.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
---+---
 Reporter:  teor   |  Owner:  MrSquanchee
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33052 | Points:  1
 Reviewer: |Sponsor:  Sponsor55-can
---+---
Changes (by MrSquanchee):

 * status:  needs_review => assigned


Comment:

 Hii teor,
 Thanks for your suggestion,
 I was really stuck with this consensus parameter :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33672 [Applications/Tor Browser]: Force include https-everywhere in incremental mar update

[Tor Bug Tracker & Wiki]

#33672: Force include https-everywhere in incremental mar update
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  brade, mcs|Sponsor:
--+--

Comment (by boklm):

 I made two patches for option 2. in branch `bug_33672`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_33672&id=9fd30760d4fa95a497f94f235f0df804f8d39579

 I am currently generating incremental mars with this patch to check if it
 correctly includes https-everywhere.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19001 [Circumvention/Snowflake]: Tor Browser with Snowflake

[Tor Bug Tracker & Wiki]

#19001: Tor Browser with Snowflake
-+-
 Reporter:  dcf  |  Owner:  (none)
 Type:  project  | Status:  new
 Priority:  Very High|  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Critical | Resolution:
 Keywords:  anti-censorship-roadmap-2020Q1, ux-  |  Actual Points:
  team   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor28-must
-+-
Changes (by antonela):

 * keywords:  anti-censorship-roadmap-2020Q1 => anti-censorship-roadmap-
 2020Q1, ux-team


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
---+---
 Reporter:  teor   |  Owner:  MrSquanchee
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33052 | Points:  1
 Reviewer: |Sponsor:  Sponsor55-can
---+---

Comment (by teor):

 Here's a good example of a function that checks an option and a consensus
 parameter:
 
https://github.com/torproject/tor/blob/44f92e8e4278403b9e633668f8be70f197b6e8db/src/core/or/dos.c#L154

 You shouldn't need to worry about when the consensus arrives.
 networkstatus_get_param() handles that for you.

 The tricky part will be turning statistics on and off based on the
 parameter. I suggest you collect the statistics if:
 * the BandwidthStatistics option is on (1), or
 * the BandwidthStatistics option is auto (-1).

 And then you only put the statistics in the extra-info if:
 * the BandwidthStatistics option is on (1), or
 * the BandwidthStatistics option is auto (-1), and the consensus parameter
 is on (1).

 So it looks like you'll need two new functions, one for collecting the
 statistics, and another for submitting them.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  043-should, ipv6, memory-safety, |  Actual Points:  1
  security-low, 035-backport, 040-backport,  |
  041-backport, 042-backport |
Parent ID:  #33048   | Points:  1
 Reviewer:  ahf  |Sponsor:
 |  Sponsor55-must
-+-
Changes (by teor):

 * status:  accepted => assigned
 * owner:  nickm => teor


Comment:

 Thanks, this is exactly what I wanted to test. Honestly, I was a bit stuck
 trying to work out how.

 I'll do a few tweaks, and then merge.

 Thanks so much!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  043-should, ipv6, memory-safety, |  Actual Points:  1
  security-low, 035-backport, 040-backport,  |
  041-backport, 042-backport |
Parent ID:  #33048   | Points:  1
 Reviewer:  nickm, teor  |Sponsor:
 |  Sponsor55-must
-+-
Changes (by teor):

 * status:  assigned => needs_revision
 * reviewer:  ahf => nickm, teor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33679 [Core Tor/Tor]: Make sure every address function that takes for_listening supports IPv6

[Tor Bug Tracker & Wiki]

#33679: Make sure every address function that takes for_listening supports IPv6
---+---
 Reporter:  teor   |  Owner:  MrSquanchee
 Type:  task   | Status:  assigned
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop312, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33049 | Points:  0.5
 Reviewer: |Sponsor:
   |  Sponsor55-must
---+---
Changes (by MrSquanchee):

 * status:  new => assigned
 * owner:  (none) => MrSquanchee


Comment:

 Thanks for making this ticket in reference to
 https://trac.torproject.org/projects/tor/ticket/33618#comment:8
 I think I may be helpful here.
 Thanks,
 MrSquanchee.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  nickm
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  043-should, ipv6, memory-safety, |  Actual Points:  1
  security-low, 035-backport, 040-backport,  |
  041-backport, 042-backport |
Parent ID:  #33048   | Points:  1
 Reviewer:  ahf  |Sponsor:
 |  Sponsor55-must
-+-

Comment (by teor):

 Replying to [comment:35 nickm]:
 > FWIW, this isn't an "uninitialized RAM" bug: The reason it says 94 is
 that the "ipv6_port" field in the cfg_port_t is set to CFG_AUTO_PORT,
 which is 0xc4005e in hex.  Once that's cast to a uint16_t, we get 0x5e,
 which is 94.

 That makes sense! I misread the hex constant as 0x405e, so I couldn't work
 out how the cast was doing that, without some memory misalignment.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33678 [Core Tor/Tor]: Disable practracker in git hooks in maint-0.4.3

[Tor Bug Tracker & Wiki]

#33678: Disable practracker in git hooks in maint-0.4.3
--+
 Reporter:  teor  |  Owner:  teor
 Type:  task  | Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  043-should|  Actual Points:  0.1
Parent ID:| Points:  0.1
 Reviewer:  nickm |Sponsor:
--+
Changes (by nickm):

 * status:  needs_review => closed
 * reviewer:   => nickm
 * resolution:   => fixed


Comment:

 Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33618 [Core Tor/Tor]: Add IPv6 Support to is_local_addr()

[Tor Bug Tracker & Wiki]

#33618: Add IPv6 Support to is_local_addr()
--+
 Reporter:  kimimaro  |  Owner:  kimimaro
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:  Tor:
  |  0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  outreachy-ipv6 ipv6  prop312  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:  Sponsor55-can
--+

Comment (by teor):

 Replying to [comment:7 kimimaro]:
 > current code changes in config.c
 > …
 > The error is quite interesting now:
 > {{{
 > tor ) make test-network
 > $CHUTNEY_PATH was not set.
 > Assuming test-network.sh will find ./../chutney
 > Running IPv4 flavors: bridges+hs-v23.
 > ping6 ::1 or ping ::1 succeeded, running IPv6 flavors: single-
 onion-v23-ipv6-md.
 > FAIL: bridges+hs-v23
 > cat:
 '/home/seneca/Documents/outreachy/tor/../chutney/net/nodes/*/info.log': No
 such file or directory
 > FAIL: single-onion-v23-ipv6-md
 > cat:
 '/home/seneca/Documents/outreachy/tor/../chutney/net/nodes/*/info.log': No
 such file or directory
 > Log and result files are available in ./test_network_log.
 > Makefile:21723: recipe for target 'test-network-results' failed
 > make[1]: *** [test-network-results] Error 1
 > Makefile:21570: recipe for target 'test-network' failed
 > make: *** [test-network] Error 2
 >
 > tor ) wc -l test_network_log/*
 >670 test_network_log/bridges+hs-v23.log
 >  4 test_network_log/bridges+hs-v23.trs
 >599 test_network_log/single-onion-v23-ipv6-md.log
 >  4 test_network_log/single-onion-v23-ipv6-md.trs
 >   1277 total
 > }}}
 >
 > Please tell me if you want me to attach the logs.

 Yes, we need to see the detailed logs to help you.

 It looks like tor is crashing, but I can't see why that's happening.

 Can you submit your code as a git pull request to:
 https://github.com/torproject/tor

 Then we can be sure we are all seeing the same code. And we also have
 continuous integration (CI) set up to test the code. So we will all see
 the same logs. And the same code reviews :-)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33618 [Core Tor/Tor]: Add IPv6 Support to is_local_addr()

[Tor Bug Tracker & Wiki]

#33618: Add IPv6 Support to is_local_addr()
--+
 Reporter:  kimimaro  |  Owner:  kimimaro
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:  Tor:
  |  0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  outreachy-ipv6 ipv6  prop312  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:  Sponsor55-can
--+

Comment (by teor):

 I opened #33679 for that bug in tor_addr_is_valid(). Good catch!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33679 [Core Tor/Tor]: Make sure every address function that takes for_listening supports IPv6

[Tor Bug Tracker & Wiki]

#33679: Make sure every address function that takes for_listening supports IPv6
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  task   | Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal |   Keywords:  prop312, ipv6, outreachy-ipv6
Actual Points: |  Parent ID:  #33049
   Points:  0.5|   Reviewer:
  Sponsor: |
  Sponsor55-must   |
---+---
 We need to make sure all of our basic address functions support IPv6.

 For example, tor_addr_is_valid() only supports IPv4 for_listening.

 We need to make this change before we create generic IPv6 listeners for
 proposal 312.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33668 [Core Tor/Tor]: --disable-module-relay yields to a Bug:

[Tor Bug Tracker & Wiki]

#33668: --disable-module-relay yields to a Bug:
+
 Reporter:  toralf  |  Owner:  nickm
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.4.3.3-alpha
 Severity:  Normal  | Resolution:  fixed
 Keywords:  crash 043-must  |  Actual Points:  .1
Parent ID:  #33674  | Points:
 Reviewer:  teor|Sponsor:
+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged with parent.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33674 [Core Tor/Tor]: Check return value handling in the relay and dirauth stubs

[Tor Bug Tracker & Wiki]

#33674: Check return value handling in the relay and dirauth stubs
--+
 Reporter:  teor  |  Owner:  teor
 Type:  task  | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  043-must, technical-debt  |  Actual Points:  0.3
Parent ID:| Points:  0.5
 Reviewer:  nickm |Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => needs_revision


Comment:

 Actually, it looks like there is a non-spurious CI warning on the master
 version:
 {{{
 ./src/feature/relay/routerkeys.h:92:36: error: parameter ‘sign_out’ set
 but not used [-Werror=unused-but-set-parameter]
int *sign_out)
 ^~~~
 ./src/feature/relay/routerkeys.h: In function
 ‘make_tap_onion_key_crosscert’:
 ./src/feature/relay/routerkeys.h:106:35: error: parameter ‘len_out’ set
 but not used [-Werror=unused-but-set-parameter]
   int *len_out)
^~~
 }}}

 (The 0.4.3 branch is already merged)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33674 [Core Tor/Tor]: Check return value handling in the relay and dirauth stubs

[Tor Bug Tracker & Wiki]

#33674: Check return value handling in the relay and dirauth stubs
--+
 Reporter:  teor  |  Owner:  teor
 Type:  task  | Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  043-must, technical-debt  |  Actual Points:  0.3
Parent ID:| Points:  0.5
 Reviewer:  nickm |Sponsor:
--+
Changes (by nickm):

 * status:  needs_review => merge_ready


Comment:

 I've squashed and merged the 0.4.3 version;  I'll wait for more CI to
 finish on the master version, then I'll cherry-pick its changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33674 [Core Tor/Tor]: Check return value handling in the relay and dirauth stubs

[Tor Bug Tracker & Wiki]

#33674: Check return value handling in the relay and dirauth stubs
--+
 Reporter:  teor  |  Owner:  teor
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  043-must, technical-debt  |  Actual Points:  0.3
Parent ID:| Points:  0.5
 Reviewer:  nickm |Sponsor:
--+

Comment (by nickm):

 LGTM, squashing and merging.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33618 [Core Tor/Tor]: Add IPv6 Support to is_local_addr()

[Tor Bug Tracker & Wiki]

#33618: Add IPv6 Support to is_local_addr()
--+
 Reporter:  kimimaro  |  Owner:  kimimaro
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:  Tor:
  |  0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  outreachy-ipv6 ipv6  prop312  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:  Sponsor55-can
--+

Comment (by teor):

 Replying to [comment:8 MrSquanchee]:
 > If I may help, I can see that `tor_addr_is_valid(const tor_addr_t *addr,
 int for_listening)` does not check for ipv6 addresses here:
 
[https://github.com/torproject/tor/blob/686494f0f71b9235399b8241aba3e0c2fcb03ea1/src/lib/net/address.c#L831].

 That's true, but we should open another ticket to fix the issue with
 tor_addr_is_valid(). Because that issue is not relevant to this ticket.

 Here's why:

 It doesn't make any sense to compare an all-zeroes IPv6 address to see if
 it's on the same network as another address. So we should pass "false" for
 "for_listening".

 And all-zeroes addresses never reach this code, because they are excluded
 by tor_addr_is_internal() at the start of the function.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33618 [Core Tor/Tor]: Add IPv6 Support to is_local_addr()

[Tor Bug Tracker & Wiki]

#33618: Add IPv6 Support to is_local_addr()
--+
 Reporter:  kimimaro  |  Owner:  kimimaro
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:  Tor:
  |  0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  outreachy-ipv6 ipv6  prop312  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:  Sponsor55-can
--+
Changes (by teor):

 * owner:  neel => kimimaro


Comment:

 Hi Neel, please check if other people are working on tickets before you
 assign them to yourself. (And please only assign yourself tickets if
 you're actively working on them.)

 kimimaro is working on this ticket right now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33375 [Core Tor/Tor]: Stop advertising an IPv6 exit policy when DNS is broken for IPv6

[Tor Bug Tracker & Wiki]

#33375: Stop advertising an IPv6 exit policy when DNS is broken for IPv6
-+-
 Reporter:  teor |  Owner:  neel
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.14
 Severity:  Normal   | Resolution:
 Keywords:  security-review-dos-risk, extra- |  Actual Points:
  review, no-backport, ipv6, tor-exit, tor-dns   |
Parent ID:  #24833   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * reviewer:  teor =>


Comment:

 I don't have time to keep on reviewing this patch right now. I'm really
 busy with google summer of code and outreachy. So I'm going to pass it to
 another reviewer.

 Here are some things for the reviewer to check:

 Replying to [comment:5 teor]:
 > This IPv6 DNS code is currently unused, so it has never been tested. So
 I want to make sure we have the design right.
 >
 > Here are some issues I noticed when reading the code:
 > * the code only counts DNS errors on timeout, but there are actually 11
 different DNS errors. We should consider which errors we want to track,
 and which ones we want to ignore. See
 http://www.wangafu.net/~nickm/libevent-2.1/doxygen/html/dns_8h.html

 Which errors should we turn off IPv6 DNS for? All of them? Only the ones
 that clients can't trigger?

 > * the minimum number of queries before failure is 10. But that could
 happen by chance, on server startup. Let's make the minimum something more
 reasonable. We can make it at least 1000. But maybe we should set it to 1
 when TestingTorNetwork is set. That way, broken IPv6 exits will fail
 quickly in chutney.

 The last version of the PR I reviewed changed the wrong "10". Please check
 that the new PR changes this code:
 https://github.com/torproject/tor/pull/1771/files#diff-
 ed2a85a7ec36e73dc681fe94a7dcf524L1556

 > We should find out which DNS errors can be triggered by tor clients, and
 ignore them. Otherwise, a client that floods an exit with bad DNS queries
 could disable IPv6 exiting on that relay. I think Nick might be able to
 help here.

 We also need to think about the risk of DNS-based attacks.

 > I think it's ok to fail thousands of client circuits, before an IPv6
 exit disables IPv6. Because getting the new descriptor to clients can take
 an hour or two. There's also a tradeoff here: we want quiet exits to
 disable IPv6 eventually. But we want busy exits to survive a momentary
 glitch.

 Overall, I wonder if this patch is the best way to solve this issue.
 Perhaps we should manually apply the BadExit flag through the network
 health team. Perhaps we should set the limits much, much higher.

 Do we know how many queries a busy exit processes? And how many timeouts
 they have?
 It's really hard to make a good design without good data.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33651 [Core Tor/Tor]: Suspicious "fetched this many bytes" counts from #32720

[Tor Bug Tracker & Wiki]

#33651: Suspicious "fetched this many bytes" counts from #32720
--+
 Reporter:  arma  |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  0
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by arma):

 Looking promising!
 {{{
 Mar 20 05:59:37.013 [notice] Heartbeat: Tor's uptime is 3:31 hours, with
 14 circuits open. I've sent 366 kB and received 1.20 MB.
 Mar 20 05:59:37.014 [notice] While bootstrapping, fetched this many bytes:
 Mar 20 05:59:37.014 [notice] 394532 (microdescriptor fetch)
 Mar 20 05:59:37.014 [notice] While not bootstrapping, fetched this many
 bytes:
 Mar 20 05:59:37.014 [notice] 212736 (consensus network-status fetch)
 Mar 20 05:59:37.014 [notice] 5935 (hidden-service v2 descriptor fetch)
 Mar 20 05:59:37.014 [notice] 55871 (microdescriptor fetch)
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32804 [Core Tor/Tor]: Travis CI hangs during compile or test

[Tor Bug Tracker & Wiki]

#32804: Travis CI hangs during compile or test
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci-rarely-fail, tor-test, hang,  |  Actual Points:
  tor-ci, 043-should |
Parent ID:  #29645   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Same with #33678:

 Hang during chutney test:
 https://travis-ci.org/github/torproject/tor/jobs/664738525

 An error occurred while generating the build script:
 https://travis-ci.org/github/torproject/tor/jobs/664738526

 And the #33428 PR:

 Hang at brew update:
 https://travis-ci.org/github/torproject/chutney/jobs/664745474
 https://travis-ci.org/github/torproject/chutney/jobs/664745476

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33173 [Applications/Tor Browser]: Test new MAR signing key (nssdb8)

[Tor Bug Tracker & Wiki]

#33173: Test new MAR signing key (nssdb8)
-+
 Reporter:  gk   |  Owner:  gk
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-sign, GeorgKoppen202003  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by gk):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 Looks good. I was able to sign a new .mar file with the backup key and
 successfully applied an incremental update from 9.5a7 to 9.5a8.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33428 [Core Tor/Chutney]: Make chutney check for relay microdescriptors before verifying

[Tor Bug Tracker & Wiki]

#33428: Make chutney check for relay microdescriptors before verifying
---+---
 Reporter:  teor   |  Owner:  anuradha1904
 Type:  enhancement| Status:
   |  needs_revision
 Priority:  Medium |  Milestone:
Component:  Core Tor/Chutney   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ipv6, prop311, outreachy-ipv6  |  Actual Points:  0.3
Parent ID:  #33050 | Points:  1
 Reviewer:  teor   |Sponsor:  Sponsor55-can
---+---

Comment (by teor):

 Oh, that's not a Tor pull request, it's on your repository. So I can't
 restart it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32804 [Core Tor/Tor]: Travis CI hangs during compile or test

[Tor Bug Tracker & Wiki]

#32804: Travis CI hangs during compile or test
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci-rarely-fail, tor-test, hang,  |  Actual Points:
  tor-ci, 043-should |
Parent ID:  #29645   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Same with #33428 in chutney:

 "An error occurred while generating the build script."

 https://travis-ci.com/github/ANURADHAJHA99/chutney/jobs/300248520

 I restarted this job only.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33428 [Core Tor/Chutney]: Make chutney check for relay microdescriptors before verifying

[Tor Bug Tracker & Wiki]

#33428: Make chutney check for relay microdescriptors before verifying
---+---
 Reporter:  teor   |  Owner:  anuradha1904
 Type:  enhancement| Status:
   |  needs_revision
 Priority:  Medium |  Milestone:
Component:  Core Tor/Chutney   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ipv6, prop311, outreachy-ipv6  |  Actual Points:  0.3
Parent ID:  #33050 | Points:  1
 Reviewer:  teor   |Sponsor:  Sponsor55-can
---+---

Comment (by teor):

 Looks like Travis CI is having some issues. A job failed, I restarted it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33678 [Core Tor/Tor]: Disable practracker in git hooks in maint-0.4.3

[Tor Bug Tracker & Wiki]

#33678: Disable practracker in git hooks in maint-0.4.3
--+
 Reporter:  teor  |  Owner:  teor
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  043-should|  Actual Points:  0.1
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+

Comment (by teor):

 One macOS CI failed due to Travis infrastructure issues, see #32804.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32804 [Core Tor/Tor]: Travis CI hangs during compile or test

[Tor Bug Tracker & Wiki]

#32804: Travis CI hangs during compile or test
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci-rarely-fail, tor-test, hang,  |  Actual Points:
  tor-ci, 043-should |
Parent ID:  #29645   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 New issues:

 "An error occurred while generating the build script."

 https://travis-ci.org/github/teor2345/tor/jobs/664737699

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33650 [Core Tor/Tor]: Verify that intro2 cell extensions actually work

[Tor Bug Tracker & Wiki]

#33650: Verify that intro2 cell extensions actually work
-+-
 Reporter:  arma |  Owner:
 |  mikeperry
 Type:  task | Status:
 |  accepted
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dos tor-dos-2020 anonymous-  |  Actual Points:
  credentials research   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arma):

 Another piece of this ticket: let's discover how much extra space we
 actually have, in the cells, for these blobs.

 In particular, if we want to include a blob for the intro point and also a
 blob for the service, then these two will compete with each other for the
 limited space.

 And that realization opens up two directions for future research:

 * Space-compact tokens. For example, are there proof-of-work schemes where
 the proof can be communicated in very few bytes, yet it is still efficient
 for the checker to check it? As one example, I can imagine a scheme where
 you send only (x, y) where x is a short seed and y is a number of bytes
 you generate from that seed such that, when you hash the y bytes, you get
 the property you want. Thus the checker can just expand the y bytes and
 check the property, but the prover has to find an x and y that achieves
 the property. I just made that scheme up, and I bet other people have done
 it way better (i.e. more compact and/or more efficient for the verifier).

 * "Wide" intro cells. In the general case, we'll want to be able to send
 more than 100-200 bytes of tokens in these cells. So we'll want some way
 to send big cells, or to send multiple cells that are conceptually tied
 together. See proposal 249 ("Allow CREATE cells with >505 bytes of
 handshake data") for ideas that can hopefully be reused here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
-+-
 Reporter:  cohosh   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  ReleaseTrainMigration, TorBrowserTeam202003|
Parent ID:  #31688   | Points:  2
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 I guess this ticket is relevant as well as there will be no security fixes
 for 1.12 anymore now that 1.14 is out.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33678 [Core Tor/Tor]: Disable practracker in git hooks in maint-0.4.3 (was: Disable practracker in maint-0.4.3)

[Tor Bug Tracker & Wiki]

#33678: Disable practracker in git hooks in maint-0.4.3
--+
 Reporter:  teor  |  Owner:  teor
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  043-should|  Actual Points:  0.1
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  assigned => needs_review


Comment:

 See my PRs:
 * 0.4.3: https://github.com/torproject/tor/pull/1823
 * master: https://github.com/torproject/tor/pull/1824

 The master branch is a "git merge -s ours", to keep practracker in git
 hooks in master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33678 [Core Tor/Tor]: Disable practracker in maint-0.4.3

[Tor Bug Tracker & Wiki]

#33678: Disable practracker in maint-0.4.3
--+
 Reporter:  teor  |  Owner:  teor
 Type:  task  | Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  043-should
Actual Points:  0.1   |  Parent ID:
   Points:  0.1   |   Reviewer:
  Sponsor:|
--+
 Let's remove .enable_practracker_in_hooks to disable practracker in hooks
 in maint-0.4.3.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33674 [Core Tor/Tor]: Check return value handling in the relay and dirauth stubs

[Tor Bug Tracker & Wiki]

#33674: Check return value handling in the relay and dirauth stubs
--+
 Reporter:  teor  |  Owner:  teor
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  043-must, technical-debt  |  Actual Points:  0.3
Parent ID:| Points:  0.5
 Reviewer:  nickm |Sponsor:
--+
Changes (by teor):

 * status:  assigned => needs_review
 * reviewer:   => nickm
 * keywords:  043-must => 043-must, technical-debt
 * actualpoints:   => 0.3


Comment:

 There are a few places where our out argument handling could be risky.

 See my PRs:
 * 0.4.3: https://github.com/torproject/tor/pull/1821
 * master: https://github.com/torproject/tor/pull/1822

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33668 [Core Tor/Tor]: --disable-module-relay yields to a Bug:

[Tor Bug Tracker & Wiki]

#33668: --disable-module-relay yields to a Bug:
+
 Reporter:  toralf  |  Owner:  nickm
 Type:  defect  | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.4.3.3-alpha
 Severity:  Normal  | Resolution:
 Keywords:  crash 043-must  |  Actual Points:  .1
Parent ID:  #33674  | Points:
 Reviewer:  teor|Sponsor:
+
Changes (by teor):

 * parent:   => #33674


Comment:

 Hmm, actually, I found a duplicated (void)msg in the patch.

 I fixed it, and did some more fixes in #33674. So let's squash my fix, and
 merge this ticket along with #33674?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33671 [Applications/Tor Browser]: Update "Get Involved" url in about:tor

[Tor Bug Tracker & Wiki]

#33671: Update "Get Involved" url in about:tor
--+--
 Reporter:  ggus  |  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202004  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by pili):

 * keywords:   => TorBrowserTeam202004


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs