Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

2020-04-17 Thread Tor Bug Tracker & Wiki
#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:
  TorBrowserTeam202004R  |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by cypherpunks):

 https://bugzilla.mozilla.org/show_bug.cgi?id=1627354

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33618 [Core Tor/Tor]: Add IPv6 Support to is_local_addr()

2020-04-17 Thread Tor Bug Tracker & Wiki
#33618: Add IPv6 Support to is_local_addr()
--+
 Reporter:  kimimaro  |  Owner:  kimimaro
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor:
  |  0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  outreachy-ipv6 ipv6  prop312  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:  teor  |Sponsor:  Sponsor55-can
--+

Comment (by kimimaro):

 Here's the main guidelines I am using with regards to writing the unit
 tests: https://github.com/torproject/tor/pull/1825#issuecomment-604905534

 I have a question. Is this what I'm supposed to write in test_config.c?
 This is just a prototype of course.


 {{{
 static void
 test_config_is_local_addr_impl(void *arg)
 {
   (void)arg;
   const routerinfo_t *my_routerinfo = router_get_my_routerinfo();
   const tor_addr_t *my_ipv6_addr = NULL;

   if (my_routerinfo) {
 my_ipv6_addr = _routerinfo->ipv6_addr;
   }

   // add test cases here like
 
https://github.com/torproject/tor/blob/384a771fccb0b0ab8b95122815b33ef26bf042e8/src/test/test_addr.c#L345

   done:
 // free memory
 }

 // add this function into config_tests_t[]

 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33554 [Core Tor/Tor]: Excessive CPU usage in windows tor_cond_t code?

2020-04-17 Thread Tor Bug Tracker & Wiki
#33554: Excessive CPU usage in windows tor_cond_t code?
--+
 Reporter:  nickm |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  backport? |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by scullcactus):

 Just wanted to link my report about this at tor-relays mailing list. Seems
 like it's confirmed by others as well.
 https://lists.torproject.org/pipermail/tor-relays/2020-April/018408.html
 Although this isn't a show stopper we hope to get a fix in future releases
 so relays running on Windows can be put to work for a longer time without
 interventions.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33924 [Core Tor/Tor]: Tor beginning with 0.4.1 seems to ignore SIGNAL SHUTDOWN on iOS

2020-04-17 Thread Tor Bug Tracker & Wiki
#33924: Tor beginning with 0.4.1 seems to ignore SIGNAL SHUTDOWN on iOS
--+
 Reporter:  tla   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.4.1.5
 Severity:  Major | Resolution:
 Keywords:  backport? |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by tla):

 Could be a timing issue? Maybe iOS removes us from process scheduling
 before Tor could stop?
 Has the time used for the shutdown increased?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33411 [Core Tor/Tor]: Make DirCache default to 0 on Windows relays

2020-04-17 Thread Tor Bug Tracker & Wiki
#33411: Make DirCache default to 0 on Windows relays
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.1.9
 Severity:  Normal   | Resolution:
 Keywords:  044-should, cpu, windows, linux, |  Actual Points:
  performance, regression, 033-triage-20180326,  |
  033-removed-20180326, 034-deferred-20180602,   |
  035-removed-20180711, 032-unreached-backport,  |
  040-roadmap-proposed, 033-unreached-backport-  |
  maybe, network-health  |
Parent ID:  #24857   | Points:  0.2
 Reviewer:   |Sponsor:
-+-

Comment (by gvanem):

 If this bug-tracker had been on Github, I would have seen your reply
 sooner.
 But you insist on using this German Trac crack?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33850 [Core Tor/Tor]: log rotation for /var/log/tor/debug.log did not close handle to old file after compression

2020-04-17 Thread Tor Bug Tracker & Wiki
#33850: log rotation for /var/log/tor/debug.log did not close handle to old file
after compression
---+
 Reporter:  MaKoTor|  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  backport logs  |  Actual Points:
Parent ID:  #33087 | Points:
 Reviewer: |Sponsor:
---+
Changes (by nickm):

 * keywords:   => backport logs
 * milestone:   => Tor: 0.4.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33925 [Core Tor/Tor]: Can't compile Tor master as of 2020-04-16

2020-04-17 Thread Tor Bug Tracker & Wiki
#33925: Can't compile Tor master as of 2020-04-16
--+
 Reporter:  tla   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  backport? |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * keywords:   => backport?
 * cc: tla (added)
 * milestone:   => Tor: 0.4.4.x-final


Comment:

 Are you sure that's up-to-date?  There should be a libtor-llharden.a
 there.

 When I run "make show-libs" on master, src/lib/libtor-llharden.a is
 listed.  How are you generating the command line above?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33924 [Core Tor/Tor]: Tor beginning with 0.4.1 seems to ignore SIGNAL SHUTDOWN on iOS

2020-04-17 Thread Tor Bug Tracker & Wiki
#33924: Tor beginning with 0.4.1 seems to ignore SIGNAL SHUTDOWN on iOS
--+
 Reporter:  tla   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.4.1.5
 Severity:  Major | Resolution:
 Keywords:  backport? |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 Tla, did you check whether the android people have run into the same
 problem?  If not, then this is maybe a problem in the ios framework, not
 in Tor itself.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33924 [Core Tor/Tor]: Tor beginning with 0.4.1 seems to ignore SIGNAL SHUTDOWN on iOS

2020-04-17 Thread Tor Bug Tracker & Wiki
#33924: Tor beginning with 0.4.1 seems to ignore SIGNAL SHUTDOWN on iOS
--+
 Reporter:  tla   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.4.1.5
 Severity:  Major | Resolution:
 Keywords:  backport? |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * cc: backport? (removed)
 * keywords:   => backport?


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33924 [Core Tor/Tor]: Tor beginning with 0.4.1 seems to ignore SIGNAL SHUTDOWN on iOS

2020-04-17 Thread Tor Bug Tracker & Wiki
#33924: Tor beginning with 0.4.1 seems to ignore SIGNAL SHUTDOWN on iOS
--+
 Reporter:  tla   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.4.1.5
 Severity:  Major | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * cc: backport?, tla (added)
 * milestone:   => Tor: 0.4.4.x-final


Comment:

 Hm. It works for me when I try it manually by running tor and connecting
 to a controlport with telnet.  (I tried on 0.4.1.9, 0.4.1.5, and master.)
 Maybe something trickier is going on.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33928 [Internal Services/Service - lists]: Create tor-alums mailing list please

2020-04-17 Thread Tor Bug Tracker & Wiki
#33928: Create tor-alums mailing list please
---+---
 Reporter:  arma   |  Owner:  qbi
 Type:  task   | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Internal Services/Service - lists  |Version:
 Severity:  Normal | Resolution:
   |  implemented
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by arma):

 * status:  new => closed
 * resolution:   => implemented


Comment:

 I've made the list.

 If somebody who is better at lists wants to look over what I did and make
 sure I didn't knock anything over while running newlist... please do. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33928 [Internal Services/Service - lists]: Create tor-alums mailing list please

2020-04-17 Thread Tor Bug Tracker & Wiki
#33928: Create tor-alums mailing list please
---+-
 Reporter:  arma   |  Owner:  qbi
 Type:  task   | Status:  new
 Priority:  Medium |  Milestone:
Component:  Internal Services/Service - lists  |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor: |
---+-
 Please create a new list, tor-alums, admined by Isabela and Roger and
 Erin.

 Description: "a list to support former employees, contractors, and interns
 in sharing job opportunities".

 No need for archives; it will be a closed list.

 Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33927 [Applications/Tor Browser]: Add tor-browser-build project for fenix

2020-04-17 Thread Tor Bug Tracker & Wiki
#33927: Add tor-browser-build project for fenix
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:
  GeorgKoppen202004  |
Parent ID:  #33184   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * cc: sisbell, sysrqb (added)


Comment:

 Okay, I spent some time on this and learned a ton. :) `bug_33927_v2`
 (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_33927_v2=a9eca52f63d049f0cb1a03c14971c8743d79a2b1)
 builds Fenix successfully. It's not ready for review and I need to file
 other tickets for issues I encountered on my way, but it compiles.
 However, only if you allow network access during the build which is due to
 #33594.

 Another gotcha is that we can't use Android SDK 29 out of the box, see
 comment:13:ticket:33557. We should think about what to do in this case.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33927 [Applications/Tor Browser]: Add tor-browser-build project for fenix

2020-04-17 Thread Tor Bug Tracker & Wiki
#33927: Add tor-browser-build project for fenix
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  tbb-mobile, Android,
 Severity:  Normal   |  GeorgKoppen202004
Actual Points:   |  Parent ID:  #33184
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 We need an own project for Fenix

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33365 [Circumvention/Snowflake]: Probe Snowflake bridge from proxy 1x a day

2020-04-17 Thread Tor Bug Tracker & Wiki
#33365: Probe Snowflake bridge from proxy 1x a day
-+---
 Reporter:  cohosh   |  Owner:  arlolra
 Type:  defect   | Status:  needs_information
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake-webextension   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  cohosh   |Sponsor:  Sponsor28
-+---
Changes (by cohosh):

 * status:  needs_review => needs_information


Comment:

 It generally looks good to me, but I had a question about the structure of
 the last commit.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

2020-04-17 Thread Tor Bug Tracker & Wiki
#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:
  TorBrowserTeam202004R  |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by gk):

 Or maybe we can just ship both SDKs in our `android-toolchain` project and
 the respective code picks the one it needs somehow...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

2020-04-17 Thread Tor Bug Tracker & Wiki
#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:
  TorBrowserTeam202004R  |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by gk):

 Replying to [comment:9 sisbell]:
 > Another issue I encountered is that android-components and fenix use
 different version of the Android SDK, Fenix is on 28 and android-
 components is on 29. I'll need to bring these into alignment (up to 29 for
 fenix)

 That does not seem so easy. Right now Fenix is broken with our toolchain.
 It breaks during compilation like:
 {{{
 > Task :app:compileGeckoBetaDebugKotlin
 e: /var/tmp/build/fenix-
 
943d3837b243/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkController.kt:
 (81, 9): Val cannot be reassigned
 e: /var/tmp/build/fenix-
 
943d3837b243/app/src/main/java/org/mozilla/fenix/library/history/HistoryController.kt:
 (76, 9): Val cannot be reassigned
 e: /var/tmp/build/fenix-
 943d3837b243/app/src/main/java/org/mozilla/fenix/utils/ClipboardHandler.kt:
 (32, 13): Val cannot be reassigned
 }}}
 That does not happen if I use our current toolchain. I can compile Fenix
 successfully with it.

 I wonder if we should try harder to match what Mozilla is currently using
 toolchain-wise. That is whether we should bite the bullet and use
 different ones for Fenix and android-components...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33926 [Applications/Tor Browser]: tor-browser-bundle-testsuite.git is missing is LICENSE file

2020-04-17 Thread Tor Bug Tracker & Wiki
#33926: tor-browser-bundle-testsuite.git is missing is LICENSE file
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  TorBrowserTeam202004R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good to me. Merged to `master` (commit
 2357de09b5e66dddf749a4fec042940abcafabca).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32038 [Applications/Tor Browser]: tor-browser-build license is unclear

2020-04-17 Thread Tor Bug Tracker & Wiki
#32038: tor-browser-build license is unclear
--+--
 Reporter:  JeremyRand|  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  TorBrowserTeam202004R |  Actual Points:
Parent ID:| Points:
 Reviewer:  sysrqb|Sponsor:
--+--
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good. Merged to `master` (commit
 49319fa1afea0f0f0e2ce16b7d61da95f39c79b2).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33926 [Applications/Tor Browser]: tor-browser-bundle-testsuite.git is missing is LICENSE file

2020-04-17 Thread Tor Bug Tracker & Wiki
#33926: tor-browser-bundle-testsuite.git is missing is LICENSE file
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202004R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by boklm):

 * status:  new => needs_review
 * keywords:  TorBrowserTeam202004 => TorBrowserTeam202004R


Comment:

 There is a patch for review in branch `bug_33926`:
 https://gitweb.torproject.org/user/boklm/tor-browser-bundle-
 testsuite.git/commit/?h=bug_33926=2357de09b5e66dddf749a4fec042940abcafabca

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33926 [Applications/Tor Browser]: tor-browser-bundle-testsuite.git is missing is LICENSE file

2020-04-17 Thread Tor Bug Tracker & Wiki
#33926: tor-browser-bundle-testsuite.git is missing is LICENSE file
--+
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
  |  TorBrowserTeam202004
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 Similarly to #32038, we should add a LICENSE file to `tor-browser-bundle-
 testsuite.git`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32038 [Applications/Tor Browser]: tor-browser-build license is unclear

2020-04-17 Thread Tor Bug Tracker & Wiki
#32038: tor-browser-build license is unclear
--+--
 Reporter:  JeremyRand|  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202004R |  Actual Points:
Parent ID:| Points:
 Reviewer:  sysrqb|Sponsor:
--+--
Changes (by boklm):

 * keywords:  TorBrowserTeam202004 => TorBrowserTeam202004R
 * status:  needs_revision => needs_review


Comment:

 I added a new revision of the commit in branch `bug_32038_v2`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_32038_v2=49319fa1afea0f0f0e2ce16b7d61da95f39c79b2

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32788 [Applications/Tor Browser]: Add specific version number for test builds

2020-04-17 Thread Tor Bug Tracker & Wiki
#32788: Add specific version number for test builds
+--
 Reporter:  gk  |  Owner:  tbb-team
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam202004R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Alright, thanks. (I don't use the alpha flavor, thus I missed that).
 Squashed and merged into `master` (commit
 3310abeac20111775407177fb95f4ede3d50251c).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32788 [Applications/Tor Browser]: Add specific version number for test builds

2020-04-17 Thread Tor Bug Tracker & Wiki
#32788: Add specific version number for test builds
+--
 Reporter:  gk  |  Owner:  tbb-team
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam202004R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by boklm):

 I think this issue affect only testbuild-nightly builds but not testbuild-
 alpha builds. For testbuild-alpha build I think it's better to keep the
 alpha version, to reuse a previous alpha build if it exists (or being able
 to check that the build is matching an alpha build).

 So I suggest the following change (to be squashed in your commit before
 merging):
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_32788=7fa17dbc0c57f12ece10abda64d912c15f430001

 Otherwise the rest of the patch looks good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33010 [Metrics/Ideas]: Monitor cloudflare captcha rate: do a periodic onionperf-like query to a cloudflare-hosted static site

2020-04-17 Thread Tor Bug Tracker & Wiki
#33010: Monitor cloudflare captcha rate: do a periodic onionperf-like query to a
cloudflare-hosted static site
---+--
 Reporter:  arma   |  Owner:  metrics-team
 Type:  task   | Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/Ideas  |Version:
 Severity:  Normal | Resolution:
 Keywords:  network-health gsoc-ideas  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by cypherpunks):

 * Attachment "captchawtf.png" added.

 https://captcha.wtf/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32788 [Applications/Tor Browser]: Add specific version number for test builds

2020-04-17 Thread Tor Bug Tracker & Wiki
#32788: Add specific version number for test builds
+--
 Reporter:  gk  |  Owner:  tbb-team
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam202004R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * keywords:  tbb-rbm => tbb-rbm, TorBrowserTeam202004R
 * status:  new => needs_review


Comment:

 `bug_32788_v2` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_32788_v2=3f76a3f9c2e545aafa540f16b5042d4bb6c8e4b4)
 has a fix up for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33481 [Applications/Tor Browser]: Update lucetc for RLBox on macOS

2020-04-17 Thread Tor Bug Tracker & Wiki
#33481: Update lucetc for RLBox on macOS
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-security, tbb-rbm,   |  Actual Points:
  GeorgKoppen202002, TorBrowserTeam202004R   |
Parent ID:  #33410   | Points:
 Reviewer:  pospeselr|Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-security, GeorgKoppen202002, TorBrowserTeam202004R => tbb-
 security, tbb-rbm, GeorgKoppen202002, TorBrowserTeam202004R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33924 [Core Tor/Tor]: Tor beginning with 0.4.1 seems to ignore SIGNAL SHUTDOWN on iOS

2020-04-17 Thread Tor Bug Tracker & Wiki
#33924: Tor beginning with 0.4.1 seems to ignore SIGNAL SHUTDOWN on iOS
--+--
 Reporter:  tla   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.4.1.5
 Severity:  Major | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by tla):

 See #33837 for more context.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33837 [Core Tor/Tor]: Tor.framework Unknown type name 'dispatch_queue_t'

2020-04-17 Thread Tor Bug Tracker & Wiki
#33837: Tor.framework Unknown type name 'dispatch_queue_t'
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  043-should, 043-backport,|  Actual Points:
  042-backport, 041-backport |
Parent ID:   | Points:  .5
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by tla):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 True.

 I opened #33924 and #33925 instead! Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33925 [Core Tor/Tor]: Can't compile Tor master as of 2020-04-16

2020-04-17 Thread Tor Bug Tracker & Wiki
#33925: Can't compile Tor master as of 2020-04-16
--+
 Reporter:  tla   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 I can compile 0.4.3.4-rc without problem now.

 Master not so great, though:

 {{{
 Ld
 /Users/berhart/Library/Developer/Xcode/DerivedData/Tor-
 atzjucxhwnhfrqcmzwlymuguursh/Build/Products/Debug/Tor.framework/Versions
 /A/Tor normal x86_64 (in target 'Tor-Mac' from project 'Tor') cd
 /Users/berhart/workspace/gp/Tor.framework
 /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.
 /xctoolchain/usr/bin/clang -target x86_64-apple-macos10.9
 /-dynamiclib -isysroot
 //Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.
 /platform/Developer/SDKs/MacOSX10.15.sdk
 /-L/Users/berhart/Library/Developer/Xcode/DerivedData/Tor-
 /atzjucxhwnhfrqcmzwlymuguursh/Build/Products/Debug
 /-F/Users/berhart/Library/Developer/Xcode/DerivedData/Tor-
 /atzjucxhwnhfrqcmzwlymuguursh/Build/Products/Debug -filelist
 //Users/berhart/Library/Developer/Xcode/DerivedData/Tor-
 /atzjucxhwnhfrqcmzwlymuguursh/Build/Intermediates.noindex/Tor.build/
 /Debug/Tor-Mac.build/Objects-normal/x86_64/Tor.LinkFileList
 /-install_name @rpath/Tor.framework/Tor -Xlinker -rpath -Xlinker
 /@executable_path/../Frameworks -Xlinker -rpath -Xlinker
 /@loader_path/../Frameworks -Xlinker -object_path_lto -Xlinker
 //Users/berhart/Library/Developer/Xcode/DerivedData/Tor-
 /atzjucxhwnhfrqcmzwlymuguursh/Build/Intermediates.noindex/Tor.build/
 /Debug/Tor-Mac.build/Objects-normal/x86_64/Tor_lto.o -Xlinker
 /-export_dynamic -Xlinker -no_deduplicate -fobjc-arc
 /-fobjc-link-runtime -fapplication-extension -framework CFNetwork
 /-ltor-app -ltor-compress -ltor-evloop -ltor-tls -ltor-crypt-ops
 /-lkeccak-tiny -ltor-pubsub -ltor-confmgt -led25519_ref10
 /-led25519_donna -lcurve25519_donna -ltor-geoip -ltor-process
 /-ltor-buf -ltor-time -ltor-fs -ltor-encoding -ltor-sandbox
 /-ltor-container -ltor-net -ltor-thread -ltor-memarea -ltor-math
 /-ltor-meminfo -ltor-osinfo -ltor-dispatch -ltor-log -ltor-lock
 /-ltor-fdio -ltor-string -ltor-term -ltor-smartlist-core
 /-ltor-malloc -ltor-wallclock -ltor-err -ltor-version -ltor-intmath
 /-ltor-ctime -lor-trunnel -ltor-trace -lssl -lcrypto -levent
 /-levent_core -levent_extra -levent_pthreads -llzma -lz -Xlinker
 /-dependency_info -Xlinker
 //Users/berhart/Library/Developer/Xcode/DerivedData/Tor-
 /atzjucxhwnhfrqcmzwlymuguursh/Build/Intermediates.noindex/Tor.build/
 /Debug/Tor-Mac.build/Objects-normal/x86_64/Tor_dependency_info.dat
 /-o
 //Users/berhart/Library/Developer/Xcode/DerivedData/Tor-
 /atzjucxhwnhfrqcmzwlymuguursh/Build/Products/Debug/Tor.framework/
 /Versions/A/Tor
 /
 Undefined symbols for architecture x86_64: "_sys_winprocess", referenced
 from: _tor_subsystems in libtor-app.a(subsystem_list.o) ld: symbol(s)
 not found for architecture x86_64 clang: error: linker command failed
 with exit code 1 (use -v to see invocation)
 }}}

 See #33837 for more context.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33924 [Core Tor/Tor]: Tor beginning with 0.4.1 seems to ignore SIGNAL SHUTDOWN on iOS

2020-04-17 Thread Tor Bug Tracker & Wiki
#33924: Tor beginning with 0.4.1 seems to ignore SIGNAL SHUTDOWN on iOS
--+--
 Reporter:  tla   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.4.1.5
 Severity:  Major |   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 Ok, so it seems Tor doesn't honor SIGNAL SHUTDOWN anymore. The first Tor
 version I tested was 0.4.1.5 (first stable of 0.4.1).

 Sending it with 0.4.0.6, I see this in the logs:
 {{{
 Apr 16 16:31:58.000 [notice] Interrupt: exiting cleanly.
 }}}

 With later Tor versions, this message disappears and the TorThread still
 hangs around after app wake up.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32536 [Applications/Tor Browser]: Security level set to "Safest" but JavaScript still Enabled.

2020-04-17 Thread Tor Bug Tracker & Wiki
#32536: Security level set to "Safest" but JavaScript still Enabled.
--+--
 Reporter:  tor70001  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  noscript  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 Thanks to some changes in NoScript, it no longer crashes WebExtensions
 Remote process.
 Thanks to #33613, it disables JavaScript execution, as a safe guard, when
 Firefox doesn't restart dead WebExtensions Remote process. Only #32549
 remains in that situation.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32038 [Applications/Tor Browser]: tor-browser-build license is unclear

2020-04-17 Thread Tor Bug Tracker & Wiki
#32038: tor-browser-build license is unclear
--+
 Reporter:  JeremyRand|  Owner:  tbb-team
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202004  |  Actual Points:
Parent ID:| Points:
 Reviewer:  sysrqb|Sponsor:
--+
Changes (by gk):

 * keywords:  TorBrowserTeam202004R => TorBrowserTeam202004


Comment:

 Replying to [comment:10 sysrqb]:

 [snip]

 > My believe Jeremy was only referring to `tor-browser-build`, so directly
 placing the 3-clause BSD license in `LICENSE` would be good enough.

 Yep.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32501 [Applications/Tor Browser]: Add hasDormantCanceledByStartup to TOPL TorSettings Interface

2020-04-17 Thread Tor Bug Tracker & Wiki
#32501: Add hasDormantCanceledByStartup to TOPL TorSettings Interface
---+--
 Reporter:  sisbell|  Owner:  tbb-team
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  tbb-mobile, TorBrowserTeam202004R  |  Actual Points:  .25
Parent ID: | Points:  .25
 Reviewer:  sysrqb |Sponsor:
---+--
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Fixed by #33359.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33359 [Applications/Tor Browser]: Use latest Version of TOPL and Remove Patches

2020-04-17 Thread Tor Bug Tracker & Wiki
#33359: Use latest Version of TOPL and Remove Patches
---+--
 Reporter:  sisbell|  Owner:  tbb-team
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  tbb-mobile, TorBrowserTeam202004R  |  Actual Points:
Parent ID: | Points:  .5
 Reviewer:  sysrqb |Sponsor:
---+--
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good to me, thanks! Cherry-picked onto `master` (commit
 d567f0f9fc3cebd4f57ee928b6b2c185137403d5).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32418 [Applications/Tor Browser]: Torbrowser tells on every start, that it can't update although it is newest

2020-04-17 Thread Tor Bug Tracker & Wiki
#32418: Torbrowser tells on every start, that it can't update although it is 
newest
--+
 Reporter:  Yeti  |  Owner:  mcs
 Type:  defect| Status:
  |  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-update,TorBrowserTeam202004R  |  Actual Points:  0.7
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by cypherpunks):

 Wow! What if we do customization of Firefox by `policies.json` instead of
 patching?
 (`71c414d5edc5562a176e98fe3d037f0da6e51afc` needs some love to become
 upstreamable)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs