Re: [tor-bugs] #33428 [Core Tor/Chutney]: Make chutney check for relay microdescriptors before verifying

2020-05-17 Thread Tor Bug Tracker & Wiki
#33428: Make chutney check for relay microdescriptors before verifying
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Chutney |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, prop311, outreachy-ipv6,   |  Actual Points:  0.5
  network-team-roadmap-2020Q1|
Parent ID:  #33050   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor55-can
-+-
Changes (by teor):

 * cc: nickm, dgoulet (added)


Comment:

 You might also want to check the CI on the underlying branch in:
 * https://github.com/teor2345/chutney/branches/all?query=33676

 (This code can be unstable due to timing issues. So if it passes both CI
 runs, then it's pretty good.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33428 [Core Tor/Chutney]: Make chutney check for relay microdescriptors before verifying

2020-05-17 Thread Tor Bug Tracker & Wiki
#33428: Make chutney check for relay microdescriptors before verifying
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Chutney |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, prop311, outreachy-ipv6,   |  Actual Points:  0.5
  network-team-roadmap-2020Q1|
Parent ID:  #33050   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor55-can
-+-
Changes (by teor):

 * status:  assigned => needs_review
 * reviewer:  teor =>


Comment:

 See my PR, which is based on anuradha1904's PR:
 * chutney: https://github.com/torproject/chutney/pull/72

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33675 [Core Tor/Chutney]: Search microdescriptor files for relay ed25519 keys

2020-05-17 Thread Tor Bug Tracker & Wiki
#33675: Search microdescriptor files for relay ed25519 keys
---+---
 Reporter:  teor   |  Owner:  anuradha1904
 Type:  enhancement| Status:
   |  needs_revision
 Priority:  Medium |  Milestone:
Component:  Core Tor/Chutney   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ipv6, prop311, outreachy-ipv6  |  Actual Points:  0.2
Parent ID:  #33428 | Points:  0.5
 Reviewer:  teor   |Sponsor:  Sponsor55-can
---+---

Comment (by teor):

 Replying to [comment:34 anuradha1904]:
 > Sorry with the editing, I am using VS code, the git conflict issue was
 something, that got ignored by me mistakenly. I am very sorry for that. I
 am comfortable with python, but I think i need to polish it more, and I am
 working hard on that by practising data structures and algorithms in
 python.Answering your further questions:-
 > 1. This means that the file is not found.
 > 2. Add conditions in a try catch block to tackle situation like this.
 > 3. We use try catch block.

 Hi, I'm sorry I didn't see your response. Trac doesn't send out emails for
 comment edits.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33675 [Core Tor/Chutney]: Search microdescriptor files for relay ed25519 keys

2020-05-17 Thread Tor Bug Tracker & Wiki
#33675: Search microdescriptor files for relay ed25519 keys
---+---
 Reporter:  teor   |  Owner:  anuradha1904
 Type:  enhancement| Status:  closed
 Priority:  Medium |  Milestone:
Component:  Core Tor/Chutney   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  ipv6, prop311, outreachy-ipv6  |  Actual Points:  0.2
Parent ID:  #33428 | Points:  0.5
 Reviewer:  teor   |Sponsor:  Sponsor55-can
---+---
Changes (by teor):

 * status:  needs_revision => closed
 * resolution:   => fixed


Comment:

 Fixed in #33428.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33428 [Core Tor/Chutney]: Make chutney check for relay microdescriptors before verifying

2020-05-17 Thread Tor Bug Tracker & Wiki
#33428: Make chutney check for relay microdescriptors before verifying
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Chutney |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, prop311, outreachy-ipv6,   |  Actual Points:  0.5
  network-team-roadmap-2020Q1|
Parent ID:  #33050   | Points:  1
 Reviewer:  teor |Sponsor:
 |  Sponsor55-can
-+-
Changes (by teor):

 * owner:  anuradha1904 => teor
 * status:  needs_revision => assigned
 * actualpoints:  0.3 => 0.5


Comment:

 I'm going to finish off this ticket, because we'd like to have this
 feature, and I might not be around to do mentoring in future.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33676 [Core Tor/Chutney]: Stop waiting a set time for microdescriptors

2020-05-17 Thread Tor Bug Tracker & Wiki
#33676: Stop waiting a set time for microdescriptors
---+---
 Reporter:  teor   |  Owner:  anuradha1904
 Type:  enhancement| Status:  closed
 Priority:  Medium |  Milestone:
Component:  Core Tor/Chutney   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  ipv6, prop311, outreachy-ipv6  |  Actual Points:
Parent ID:  #33428 | Points:  0.5
 Reviewer:  teor   |Sponsor:  Sponsor55-can
---+---
Changes (by teor):

 * status:  needs_revision => closed
 * resolution:   => fixed


Comment:

 Fixed in #33428.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33581 [Core Tor/Chutney]: Restore bridge networkstatus checks in chutney

2020-05-17 Thread Tor Bug Tracker & Wiki
#33581: Restore bridge networkstatus checks in chutney
--+---
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Chutney  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ipv6, prop311 |  Actual Points:
Parent ID:  #33582| Points:  0.1
 Reviewer:|Sponsor:  Sponsor55-can
--+---
Description changed by teor:

Old description:

> This issue depends on the tor bridge descriptor upload fix in #33582, or
> robust reachability self-tests in #33222.
>
> In chutney networks, there's a race condition when bridges try to publish
> their descriptor to the bridge authority:
> * bridges try to publish their descriptors before bootstrapping
> * but bridges can't publish their descriptors, because they don't have
> enough directory info to build a circuit to the bridge authority
>
> Also, bridges do not retry publishing their descriptor immediately after
> they bootstrap.
>
> We can only do the networkstatus-bridges check on tor versions with the
> #33222 or #33582 fixes. So we'll need to check for:
> * the next tor 0.4.4-alpha version, or
> * an environmental variable that enables these tests.
>
> We don't have to do these fixes, because it should be enough to test
> relay reachability. But we would risk breaking bridge reachability tests,
> and not knowing about it until after a release.
>
> Also, the chutney workarounds seem to cause weird race conditions, which
> are time-consuming to diagnose and fix.

New description:

 This issue depends on the tor bridge descriptor upload fix in #33582,
 robust reachability self-tests in #33222, or bridge log checks in #34037.

 In chutney networks, there's a race condition when bridges try to publish
 their descriptor to the bridge authority:
 * bridges try to publish their descriptors before bootstrapping
 * but bridges can't publish their descriptors, because they don't have
 enough directory info to build a circuit to the bridge authority

 Also, bridges do not retry publishing their descriptor immediately after
 they bootstrap.

 We can only do the networkstatus-bridges check on tor versions with the
 #33222 or #33582 fixes. So we'll need to check for:
 * the next tor 0.4.4-alpha version, or
 * an environmental variable that enables these tests.

 We don't have to do these fixes, because it should be enough to test relay
 reachability. But we would risk breaking bridge reachability tests, and
 not knowing about it until after a release.

 Also, the chutney workarounds seem to cause weird race conditions, which
 are time-consuming to diagnose and fix.

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33582 [Core Tor/Tor]: Make bridges wait until they have bootstrapped, before publishing their descriptor

2020-05-17 Thread Tor Bug Tracker & Wiki
#33582: Make bridges wait until they have bootstrapped, before publishing their
descriptor
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-bridge, tor-relay, prop311,  |  Actual Points:
  outreachy-ipv6, easy   |
Parent ID:  #33050   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor55-can
-+-
Description changed by teor:

Old description:

> Instead of this fix, we can make chutney check tor's logs for
> reachability self-test successes. See #34037.
>
> On bridges, there's a race condition when bridges try to publish their
> descriptor to the bridge authority:
> * bridges try to publish their descriptors before bootstrapping
> * but bridges can't publish their descriptors, because they don't have
> enough directory info to build a circuit to the bridge authority
>
> Bridges will eventually try to publish their descriptors again, when they
> become dirty.
>
> We should make bridges wait until they have bootstrapped, before they try
> to publish their descriptors. (This might be a good change for relays as
> well: there isn't much point in publishing a relay that can't bootstrap.)
>
> This issue happens regardless of `AssumeReachable`. It is most obvious in
> chutney networks.
>
> This ticket isn't essential. But the workarounds seem to cause weird race
> conditions, which are time-consuming to diagnose and fix.

New description:

 Instead of this fix, we can make chutney check tor's logs for reachability
 self-test successes (#34037), or implement strict self-tests (#33222).

 On bridges, there's a race condition when bridges try to publish their
 descriptor to the bridge authority:
 * bridges try to publish their descriptors before bootstrapping
 * but bridges can't publish their descriptors, because they don't have
 enough directory info to build a circuit to the bridge authority

 Bridges will eventually try to publish their descriptors again, when they
 become dirty.

 We should make bridges wait until they have bootstrapped, before they try
 to publish their descriptors. (This might be a good change for relays as
 well: there isn't much point in publishing a relay that can't bootstrap.)

 This issue happens regardless of `AssumeReachable`. It is most obvious in
 chutney networks.

 This ticket isn't essential. But the workarounds seem to cause weird race
 conditions, which are time-consuming to diagnose and fix.

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34037 [Core Tor/Chutney]: Make chutney check tor's logs for reachability self-test success

2020-05-17 Thread Tor Bug Tracker & Wiki
#34037: Make chutney check tor's logs for reachability self-test success
--+---
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Chutney  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ipv6, prop311 |  Actual Points:
Parent ID:  #33050| Points:  2
 Reviewer:|Sponsor:  Sponsor55-can
--+---
Description changed by teor:

Old description:

> This ticket is an alternative to #33407.
>
> Instead of fixing bridge descriptor uploads, we can check bridge logs to
> make sure that reachability self-tests have succeeded.
>
> For consistency, we should also do the same checks for relays.
>
> We can only do these tests on authorities, relays, and bridges that are
> configured with `AssumeReachable 0`. Chutney's current defaults are:
> * directory authorities: 1
> * bridge authorities: 1
> * relays: 0
> * bridges: 0
> * clients: clients never perform reachability self-tests
>
> Some custom chutney networks may set `AssumeReachable 1` for relays and
> bridges. So we should make it easy for them to disable these checks.

New description:

 This ticket is an alternative to #33582 or #33222.

 Instead of fixing bridge descriptor uploads, we can check bridge logs to
 make sure that reachability self-tests have succeeded.

 For consistency, we should also do the same checks for relays.

 We can only do these tests on authorities, relays, and bridges that are
 configured with `AssumeReachable 0`. Chutney's current defaults are:
 * directory authorities: 1
 * bridge authorities: 1
 * relays: 0
 * bridges: 0
 * clients: clients never perform reachability self-tests

 Some custom chutney networks may set `AssumeReachable 1` for relays and
 bridges. So we should make it easy for them to disable these checks.

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33226 [Core Tor/Tor]: Prop 311: 5. Declare Support for Subprotocol Version "Relay=3"

2020-05-17 Thread Tor Bug Tracker & Wiki
#33226: Prop 311: 5. Declare Support for Subprotocol Version "Relay=3"
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  prop311, ipv6, network-team- |  Actual Points:  1
  roadmap-2020Q2 |
Parent ID:  #33222   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor55-must
-+-
Changes (by teor):

 * status:  assigned => closed
 * resolution:   => fixed
 * actualpoints:   => 1


Comment:

 Done as part of #33222.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34246 [Core Tor/Tor]: Add a link to the formatted architecture docs in src/mainpage.md

2020-05-17 Thread Tor Bug Tracker & Wiki
#34246: Add a link to the formatted architecture docs in src/mainpage.md
--+---
 Reporter:  teor  |  Owner:  (none)
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  044-should, easy, doc
Actual Points:|  Parent ID:
   Points:  0.1   |   Reviewer:
  Sponsor:|
--+---
 When I open up src/mainpage.md. it's obviously meant to be formatted by a
 markdown parser. (And GitHub's markdown doesn't seem to handle "@"
 directives.)

 Can you add a link to the formatted output at the top of mainpage.md ?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24844 [Core Tor/Tor]: Add HS v3 status to the SIGUSR1 dumpstats()

2020-05-17 Thread Tor Bug Tracker & Wiki
#24844: Add HS v3 status to the SIGUSR1 dumpstats()
-+-
 Reporter:  dgoulet  |  Owner:  neel
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, 034-triage-20180328, |  Actual Points:
  034-removed-20180328   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * milestone:  Tor: unspecified => Tor: 0.4.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33227 [Core Tor/Tor]: Prop 311: 5.1. Update Tor Spec Relay Subprotocols

2020-05-17 Thread Tor Bug Tracker & Wiki
#33227: Prop 311: 5.1. Update Tor Spec Relay Subprotocols
+
 Reporter:  teor|  Owner:  teor
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  prop311, ipv6, torspec  |  Actual Points:  0.1
Parent ID:  #33222  | Points:  0.1
 Reviewer:  |Sponsor:  Sponsor55-must
+
Changes (by teor):

 * status:  assigned => needs_review
 * actualpoints:   => 0.1


Comment:

 See my PR:
 * torspec: https://github.com/torproject/torspec/pull/116

 It's the same as the draft in proposal 311, with a few minor edits at the
 end of the Relay=2 section.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34244 [Core Tor/Fallback Scripts]: Fallback details changed for 1938EBACBB1A7BFA888D9623C90061130E63BB3F

2020-05-17 Thread Tor Bug Tracker & Wiki
#34244: Fallback details changed for 1938EBACBB1A7BFA888D9623C90061130E63BB3F
---+
 Reporter:  ahf|  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor/Fallback Scripts  |Version:
 Severity:  Normal | Resolution:
 Keywords:  fallback-change|  Actual Points:
Parent ID:  #30972 | Points:
 Reviewer: |Sponsor:
---+
Changes (by teor):

 * parent:   => #30972


Comment:

 You might find these changes easier to track if you make them child
 tickets of the next rebuild.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33812 [Core Tor/Tor]: Add unit tests for bandwidth statistics functions

2020-05-17 Thread Tor Bug Tracker & Wiki
#33812: Add unit tests for bandwidth statistics functions
---+---
 Reporter:  MrSquanchee|  Owner:  MrSquanchee
 Type:  task   | Status:
   |  needs_revision
 Priority:  Medium |  Milestone:  Tor:
   |  unspecified
Component:  Core Tor/Tor   |Version:
 Severity:  Minor  | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33617 | Points:  2
 Reviewer:  ahf|Sponsor:  Sponsor55-can
---+---

Comment (by teor):

 I also added some issues with the changes file, forward declarations, and
 duplicate or redundant code.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34220 [Core Tor/Tor]: Return to stem master once stem issue 63 is resolved.

2020-05-17 Thread Tor Bug Tracker & Wiki
#34220: Return to stem master once stem issue 63 is resolved.
--+
 Reporter:  nickm |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  044-should|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * keywords:   => 044-should


Comment:

 The stem bug has been closed as fixed, so this may be okay to do now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24844 [Core Tor/Tor]: Add HS v3 status to the SIGUSR1 dumpstats()

2020-05-17 Thread Tor Bug Tracker & Wiki
#24844: Add HS v3 status to the SIGUSR1 dumpstats()
-+-
 Reporter:  dgoulet  |  Owner:  neel
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, 034-triage-20180328, |  Actual Points:
  034-removed-20180328   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by neel):

 * status:  assigned => needs_review


Comment:

 PR: https://github.com/torproject/tor/pull/1898

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34245 [Core Tor/Tor]: Declare variables in for loops in rend_service_dump_stats()

2020-05-17 Thread Tor Bug Tracker & Wiki
#34245: Declare variables in for loops in rend_service_dump_stats()
--+-
 Reporter:  neel  |  Owner:  neel
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:  ahf   |Sponsor:
--+-
Changes (by ahf):

 * status:  needs_review => merge_ready
 * reviewer:   => ahf


Comment:

 I think this change is fine.

 Neel, there is a significant amount of overhead for us to do these
 whitespace fixes with one ticket per N patches (for a pretty small N),
 where one of us have to review it, someone else needs to come in and do
 the merge.

 I think we should stop doing these as individual changes. If you want to
 solve the whitespace problems in Tor, please have a look at the work that
 happened in the beginning of this year where folks in the network team
 evaluated using clang-format to handle code-style in Tor automatically.

 We have a pretty costly code-review process for tor.git since (a) we are
 written in C and every line is a potential catastrophe waiting to happen,
 and (b) because we are a project where security is key.

 For me to review these small changes, I need to pull your branch on my
 local machine (in case Github's web interface isn't showing me the truth),
 then make a decision on the changes, comment on the ticket, then finally
 saying yay or nay. Then somebody else from the team goes in, have to go it
 over as well, and do the merge Doing this is just too much work for these
 small changes.

 If you want to help with the clang-format work that has been going on,
 please have a look at #29226.

 Thank you :-)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24844 [Core Tor/Tor]: Add HS v3 status to the SIGUSR1 dumpstats()

2020-05-17 Thread Tor Bug Tracker & Wiki
#24844: Add HS v3 status to the SIGUSR1 dumpstats()
-+-
 Reporter:  dgoulet  |  Owner:  neel
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Low  |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, 034-triage-20180328, |  Actual Points:
  034-removed-20180328   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by neel):

 * status:  new => assigned
 * cc: neel (added)
 * owner:  (none) => neel


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34245 [Core Tor/Tor]: Declare variables in for loops in rend_service_dump_stats()

2020-05-17 Thread Tor Bug Tracker & Wiki
#34245: Declare variables in for loops in rend_service_dump_stats()
--+--
 Reporter:  neel  |  Owner:  neel
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by neel):

 * status:  assigned => needs_review


Comment:

 PR: https://github.com/torproject/tor/pull/1897

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34245 [Core Tor/Tor]: Declare variables in for loops in rend_service_dump_stats() (was: Space out for loops and int declaration in rend_service_dump_stats())

2020-05-17 Thread Tor Bug Tracker & Wiki
#34245: Declare variables in for loops in rend_service_dump_stats()
--+--
 Reporter:  neel  |  Owner:  neel
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34245 [Core Tor/Tor]: Space out for loops and int declaration in rend_service_dump_stats()

2020-05-17 Thread Tor Bug Tracker & Wiki
#34245: Space out for loops and int declaration in rend_service_dump_stats()
--+--
 Reporter:  neel  |  Owner:  neel
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  easy
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34237 [Core Tor/Tor]: Fix spacing in if statement in tor_version_parse()

2020-05-17 Thread Tor Bug Tracker & Wiki
#34237: Fix spacing in if statement in tor_version_parse()
--+
 Reporter:  neel  |  Owner:  neel
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:  ahf   |Sponsor:
--+
Changes (by nickm):

 * milestone:   => Tor: 0.4.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34237 [Core Tor/Tor]: Fix spacing in if statement in tor_version_parse()

2020-05-17 Thread Tor Bug Tracker & Wiki
#34237: Fix spacing in if statement in tor_version_parse()
--+
 Reporter:  neel  |  Owner:  neel
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:  ahf   |Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 merged

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34244 [Core Tor/Fallback Scripts]: Fallback details changed for 1938EBACBB1A7BFA888D9623C90061130E63BB3F

2020-05-17 Thread Tor Bug Tracker & Wiki
#34244: Fallback details changed for 1938EBACBB1A7BFA888D9623C90061130E63BB3F
---+-
 Reporter:  ahf|  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor/Fallback Scripts  |Version:
 Severity:  Normal |   Keywords:  fallback-change
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor: |
---+-
 From tor-rel...@lists.torproject.org:

 {{{
 Date: Sun, 17 May 2020 07:53:52 +
 From: Anders Burmeister <...>
 To: "tor-rel...@lists.torproject.org" 
 Subject: [tor-relays] EOL 1938EBACBB1A7BFA888D9623C90061130E63BB3F
 FallbackDir

 FallbackDir

 1938EBACBB1A7BFA888D9623C90061130E63BB3F

 Expired
 rest of the family happily up and running.
 /anders
 }}}

 The relay is still running though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

2020-05-17 Thread Tor Bug Tracker & Wiki
#33626: Add TBB project for GeckoView
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by boklm):

 In projects/firefox/build:
 {{{
 +# We need to have the get-moz-build-date script available in the
 container
 +# but we can't include it via input_files as it is a script shared
 between
 +# projects.
 +cat > get-moz-build-date << EOF
 + [% INCLUDE get-moz-build-date %]
 +EOF
 +
 }}}
 I think the `INCLUDE` line should not be indented, as it's adding a space
 at the beginning of the file. Although it still works as we run the script
 with `perl $rootdir/get-moz-build-date` and don't use the shebang line.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34243 [Applications/Tor Browser]: debootstrap-image project for Linux fails with sefault

2020-05-17 Thread Tor Bug Tracker & Wiki
#34243: debootstrap-image project for Linux fails with sefault
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by boklm):

 Is the kernel on this machine configured with `vsyscall=emulate`?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34243 [Applications/Tor Browser]: debootstrap-image project for Linux fails with sefault

2020-05-17 Thread Tor Bug Tracker & Wiki
#34243: debootstrap-image project for Linux fails with sefault
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 `./rbm/rbm build container-image --target nightly --target torbrowser-
 linux-x86_64` is what I used.

 I built Linux bundles on that machine previously, too, I think. And
 building `stretch` and `buster` containers is working fine on it as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34243 [Applications/Tor Browser]: debootstrap-image project for Linux fails with sefault

2020-05-17 Thread Tor Bug Tracker & Wiki
#34243: debootstrap-image project for Linux fails with sefault
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-rbm
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 On one of my machines creating a Linux container fails:
 {{{
 W: Failure trying to run: chroot "/var/tmp/tmp.HiqNC7Q599/base-image" dpkg
 --force-depends --install /var/cache/apt/archives/base-
 passwd_3.5.26_amd64.deb
 W: See /var/tmp/tmp.HiqNC7Q599/base-image/debootstrap/debootstrap.log for
 details
 }}}
 And that log says:
 {{{
 2020-05-17 19:15:26
 URL:http://archive.debian.org/debian/pool/main/z/zlib/zlib1g_1.2.7.dfsg-
 13_amd64.deb [87392/87392] -> "/var/tmp/tmp.uv7kNeRkLc/base-
 image//var/cache/apt/archives/partial/zlib1g_1%3a1.2.7.dfsg-13_amd64.deb"
 [1]
 dpkg: warning: parsing file '/var/lib/dpkg/status' near line 5 package
 'dpkg':
  missing description
 dpkg: warning: parsing file '/var/lib/dpkg/status' near line 5 package
 'dpkg':
  missing architecture
 Segmentation fault
 }}}
 I originally hit this when trying to solve #34242. To have a chance to
 repro one needs the fix for #34242, too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34242 [Applications/Tor Browser]: Creating containers for Linux targets is busted due to outdated apt

2020-05-17 Thread Tor Bug Tracker & Wiki
#34242: Creating containers for Linux targets is busted due to outdated apt
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam202005R,  |  Actual Points:
  GeorgKoppen202005  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:2 gk]:
 > Replying to [comment:1 gk]:
 >
 > [snip]
 >
 > > However, it seems I still can't build containers successfully again.
 The `debootstrap-image` part is still failing, although differently now:
 > > {{{
 > > W: Failure trying to run: chroot "/var/tmp/tmp.HiqNC7Q599/base-image"
 dpkg --force-depends --install /var/cache/apt/archives/base-
 passwd_3.5.26_amd64.deb
 > > W: See /var/tmp/tmp.HiqNC7Q599/base-image/debootstrap/debootstrap.log
 for details
 > > }}}
 > >
 > > And the end of that log says:
 > > {{{
 > > 2020-05-17 19:15:26
 URL:http://archive.debian.org/debian/pool/main/z/zlib/zlib1g_1.2.7.dfsg-
 13_amd64.deb [87392/87392] -> "/var/tmp/tmp.uv7kNeRkLc/base-
 image//var/cache/apt/archives/partial/zlib1g_1%3a1.2.7.dfsg-13_amd64.deb"
 [1]
 > > dpkg: warning: parsing file '/var/lib/dpkg/status' near line 5 package
 'dpkg':
 > >  missing description
 > > dpkg: warning: parsing file '/var/lib/dpkg/status' near line 5 package
 'dpkg':
 > >  missing architecture
 > > Segmentation fault
 > > }}}
 > > Hrm.
 >
 > *That* in turn does only happen on one of the machines I have available.
 So, this ticket seems to be unrelated to that problem at least.

 I filed #34243 for that one.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34242 [Applications/Tor Browser]: Creating containers for Linux targets is busted due to outdated apt

2020-05-17 Thread Tor Bug Tracker & Wiki
#34242: Creating containers for Linux targets is busted due to outdated apt
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam202005R,  |  Actual Points:
  GeorgKoppen202005  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  assigned => needs_review
 * keywords:  tbb-rbm, TorBrowserTeam202005, GeorgKoppen202005 => tbb-rbm,
 TorBrowserTeam202005R, GeorgKoppen202005


Comment:

 Replying to [comment:1 gk]:

 [snip]

 > However, it seems I still can't build containers successfully again. The
 `debootstrap-image` part is still failing, although differently now:
 > {{{
 > W: Failure trying to run: chroot "/var/tmp/tmp.HiqNC7Q599/base-image"
 dpkg --force-depends --install /var/cache/apt/archives/base-
 passwd_3.5.26_amd64.deb
 > W: See /var/tmp/tmp.HiqNC7Q599/base-image/debootstrap/debootstrap.log
 for details
 > }}}
 >
 > And the end of that log says:
 > {{{
 > 2020-05-17 19:15:26
 URL:http://archive.debian.org/debian/pool/main/z/zlib/zlib1g_1.2.7.dfsg-
 13_amd64.deb [87392/87392] -> "/var/tmp/tmp.uv7kNeRkLc/base-
 image//var/cache/apt/archives/partial/zlib1g_1%3a1.2.7.dfsg-13_amd64.deb"
 [1]
 > dpkg: warning: parsing file '/var/lib/dpkg/status' near line 5 package
 'dpkg':
 >  missing description
 > dpkg: warning: parsing file '/var/lib/dpkg/status' near line 5 package
 'dpkg':
 >  missing architecture
 > Segmentation fault
 > }}}
 > Hrm.

 *That* in turn does only happen on one of the machines I have available.
 So, this ticket seems to be unrelated to that problem at least.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34242 [Applications/Tor Browser]: Creating containers for Linux targets is busted due to outdated apt

2020-05-17 Thread Tor Bug Tracker & Wiki
#34242: Creating containers for Linux targets is busted due to outdated apt
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam202005,   |  Actual Points:
  GeorgKoppen202005  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 `bug_34242` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_34242=e9fa09b87bd633f10cfeca2797839662138d5d39)
 has the changes up for review.

 However, it seems I still can't build containers successfully again. The
 `debootstrap-image` part is still failing, although differently now:
 {{{
 W: Failure trying to run: chroot "/var/tmp/tmp.HiqNC7Q599/base-image" dpkg
 --force-depends --install /var/cache/apt/archives/base-
 passwd_3.5.26_amd64.deb
 W: See /var/tmp/tmp.HiqNC7Q599/base-image/debootstrap/debootstrap.log for
 details
 }}}

 And the end of that log says:
 {{{
 2020-05-17 19:15:26
 URL:http://archive.debian.org/debian/pool/main/z/zlib/zlib1g_1.2.7.dfsg-
 13_amd64.deb [87392/87392] -> "/var/tmp/tmp.uv7kNeRkLc/base-
 image//var/cache/apt/archives/partial/zlib1g_1%3a1.2.7.dfsg-13_amd64.deb"
 [1]
 dpkg: warning: parsing file '/var/lib/dpkg/status' near line 5 package
 'dpkg':
  missing description
 dpkg: warning: parsing file '/var/lib/dpkg/status' near line 5 package
 'dpkg':
  missing architecture
 Segmentation fault
 }}}
 Hrm.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34242 [Applications/Tor Browser]: Creating containers for Linux targets is busted due to outdated apt

2020-05-17 Thread Tor Bug Tracker & Wiki
#34242: Creating containers for Linux targets is busted due to outdated apt
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  tbb-rbm,
 Severity:  Normal   |  TorBrowserTeam202005,
 |  GeorgKoppen202005
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 For Linux containers we hardcode `0.9.7.9+deb7u8` as the minimal `apt`
 version but that's not available anymore on `deb.freexian.com`. Rather
 it's `0.9.7.9+deb7u9` now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34004 [Core Tor/Tor]: Support for full DNS and DNSSEC resolution

2020-05-17 Thread Tor Bug Tracker & Wiki
#34004: Support for full DNS and DNSSEC resolution
--+
 Reporter:  chrisss404|  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Major | Resolution:
 Keywords:  DNS, DNSSEC   |  Actual Points:
Parent ID:| Points:
 Reviewer:  ahf   |Sponsor:
--+

Comment (by ahf):

 This seems to need some more discussion that is happening in parallel on
 tor-...@lists.torproject.org.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34238 [Core Tor/Tor]: Space out some function calls in parse_short_policy()

2020-05-17 Thread Tor Bug Tracker & Wiki
#34238: Space out some function calls in parse_short_policy()
--+
 Reporter:  neel  |  Owner:  neel
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 I think some of these are not right, but other people could have different
 opinions.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

2020-05-17 Thread Tor Bug Tracker & Wiki
#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
  control,termination,signals,windows,winapi |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by ahf):

 * status:  needs_review => needs_revision
 * reviewer:   => ahf


Comment:

 I think the patch looks fine, but could I get you to create a pull-request
 against our master branch on https://github.com/torproject/tor ? This
 would allow us to verify that the code passes our test-suites and is
 mergeable.

 We are generally not very good at dealing with Microsoft Windows, so if
 you know its APIs well, and are working on something related to this,
 please feel free to poke us about anything that you might discover. We
 could definitely need some help in this area :-)

 Thank you for working on this!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34236 [Core Tor/Tor]: Fix spacing in if statement in port_parse_config()

2020-05-17 Thread Tor Bug Tracker & Wiki
#34236: Fix spacing in if statement in port_parse_config()
--+-
 Reporter:  neel  |  Owner:  neel
 Type:  enhancement   | Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:  ahf   |Sponsor:
--+-
Changes (by ahf):

 * status:  needs_review => merge_ready
 * reviewer:   => ahf


Comment:

 Looks fine. I don't think needs a changes file.

 I'm actually unsure if we ever made a decision on space after '!' in
 boolean expressions, but I will let the merger have a say as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34237 [Core Tor/Tor]: Fix spacing in if statement in tor_version_parse()

2020-05-17 Thread Tor Bug Tracker & Wiki
#34237: Fix spacing in if statement in tor_version_parse()
--+-
 Reporter:  neel  |  Owner:  neel
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:  ahf   |Sponsor:
--+-
Changes (by ahf):

 * status:  needs_review => merge_ready
 * reviewer:   => ahf


Comment:

 Thanks, looks fine. I don't think this needs a changes file.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33812 [Core Tor/Tor]: Add unit tests for bandwidth statistics functions

2020-05-17 Thread Tor Bug Tracker & Wiki
#33812: Add unit tests for bandwidth statistics functions
---+---
 Reporter:  MrSquanchee|  Owner:  MrSquanchee
 Type:  task   | Status:
   |  needs_revision
 Priority:  Medium |  Milestone:  Tor:
   |  unspecified
Component:  Core Tor/Tor   |Version:
 Severity:  Minor  | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33617 | Points:  2
 Reviewer:  ahf|Sponsor:  Sponsor55-can
---+---
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 The code is starting to look very good. I have added two smaller issues
 with the `STATIC` handling and a nitpick about a filename typo.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34238 [Core Tor/Tor]: Space out some function calls in parse_short_policy() (was: Space out tor_assert() call in parse_short_policy())

2020-05-17 Thread Tor Bug Tracker & Wiki
#34238: Space out some function calls in parse_short_policy()
--+--
 Reporter:  neel  |  Owner:  neel
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by neel):

 * status:  assigned => needs_review


Comment:

 PR: https://github.com/torproject/tor/pull/1896

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34024 [Metrics/Onionperf]: Reduce timeout and stallout values

2020-05-17 Thread Tor Bug Tracker & Wiki
#34024: Reduce timeout and stallout values
---+
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID: | Points:  1
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * status:  new => needs_review


Comment:

 I looked at measurements made by op-hk2, op-nl2, and op-us2 in the first
 half of May 2020. I wanted to get an idea how many of the 5 MiB
 measurements would have timed out with a timeout of 270 rather than 3600
 seconds. The result was: ''zero''. For comparison, there have been 1,027
 successful 5 MiB measurements in that time, and the slowest four have
 finished in 201 seconds, 186 seconds, 142 seconds, and 128 seconds. And
 while it's conceivable that we would find a non-zero number in other half
 months of measurements, their number will very likely be really small.

 Similar to #34023, let's discuss how to proceed here. My recommendation is
 that we:

  1. use a timeout of 270 seconds for all measurements to avoid overlapping
 measurements and

  2. set the stallout value to 0 to disable the stallout function in TGen.

 More on Thursday at the weekly meeting.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30602 [Metrics/Library]: Extend TorperfResult to return parsed new PARTIAL* and ERRORCODE fields

2020-05-17 Thread Tor Bug Tracker & Wiki
#30602: Extend TorperfResult to return parsed new PARTIAL* and ERRORCODE fields
-+-
 Reporter:  karsten  |  Owner:  karsten
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Metrics/Library  |Version:
 Severity:  Normal   | Resolution:  implemented
 Keywords:   |  Actual Points:  0.1
Parent ID:  #29507   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by karsten):

 * status:  accepted => closed
 * resolution:   => implemented
 * actualpoints:   => 0.1


Comment:

 Implemented in [https://gitweb.torproject.org/metrics-
 lib.git/commit/?id=a422aff99f964c04b1c2c9d65f487717eccd882d commit
 a422aff] and merged to master. Closing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31572 [Applications/Tor Browser]: Extension errors after a while of surfing with Tor Browser based on ESR68

2020-05-17 Thread Tor Bug Tracker & Wiki
#31572: Extension errors after a while of surfing with Tor Browser based on 
ESR68
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-issues, tbb-   |  Actual Points:
  regression, tbb-9.0.1-can  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by traumschule):

 Related: #33966 #34241

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34241 [Applications/Tor Browser]: tba crash saving image

2020-05-17 Thread Tor Bug Tracker & Wiki
#34241: tba crash saving image
-+-
 Reporter:  traumschule  |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  tbb-mobile noscript
 Severity:  Normal   |  okhttp
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 - tba version: 68.8.0 (9.5a12)
 - includes several Gecko traces for error code [https://helpful.knobs-
 dials.com/index.php/0x80004005_(NS_ERROR_FAILURE)_and_other_firefox_errors
 0x80004005] (catch-all ff error) equal to #31572 and #33966

 STR:
 1) start and connect TBA (without this step the page won't be loaded after
 connecting)
 2) in another application share a link with TBA
 3) "Open in Tor Browser"
 4) "Save Image As"
 Result:

 {{{
 05-17 15:19:16.044  5623  5641 E AndroidRuntime: FATAL EXCEPTION:
 GeckoBackgroundThread
 05-17 15:19:16.044  5623  5641 E AndroidRuntime: Process:
 org.torproject.torbrowser_alpha, PID: 5623
 05-17 15:19:16.044  5623  5641 E AndroidRuntime:
 java.lang.NullPointerException: Attempt to invoke virtual method
 'java.lang.String java.net.InetAddress.toString()' on a null object
 reference
 05-17 15:19:16.044  5623  5641 E AndroidRuntime:at
 com.android.okhttp.internal.Util.closeQuietly(Util.java:96)
 05-17 15:19:16.044  5623  5641 E AndroidRuntime:at
 
com.android.okhttp.internal.http.StreamAllocation.deallocate(StreamAllocation.java:293)
 05-17 15:19:16.044  5623  5641 E AndroidRuntime:at
 
com.android.okhttp.internal.http.StreamAllocation.streamFinished(StreamAllocation.java:234)
 05-17 15:19:16.044  5623  5641 E AndroidRuntime:at
 
com.android.okhttp.internal.http.Http1xStream$AbstractSource.endOfInput(Http1xStream.java:571)
 05-17 15:19:16.044  5623  5641 E AndroidRuntime:at
 
com.android.okhttp.internal.http.Http1xStream$FixedLengthSource.read(Http1xStream.java:610)
 05-17 15:19:16.044  5623  5641 E AndroidRuntime:at
 com.android.okhttp.okio.RealBufferedSource$1.read(RealBufferedSource.java:396)
 05-17 15:19:16.044  5623  5641 E AndroidRuntime:at
 java.io.InputStream.read(InputStream.java:101)
 05-17 15:19:16.044  5623  5641 E AndroidRuntime:at
 
org.mozilla.gecko.GeckoApplication.downloadImageForSetImage(GeckoApplication.java:887)
 05-17 15:19:16.044  5623  5641 E AndroidRuntime:at
 org.mozilla.gecko.GeckoApplication.access$300(GeckoApplication.java:82)
 05-17 15:19:16.044  5623  5641 E AndroidRuntime:at
 org.mozilla.gecko.GeckoApplication$6.run(GeckoApplication.java:847)
 05-17 15:19:16.044  5623  5641 E AndroidRuntime:at
 
org.mozilla.gecko.permissions.PermissionBlock.executeRunnable(PermissionBlock.java:139)
 05-17 15:19:16.044  5623  5641 E AndroidRuntime:at
 
org.mozilla.gecko.permissions.PermissionBlock.onPermissionsGranted(PermissionBlock.java:118)
 05-17 15:19:16.044  5623  5641 E AndroidRuntime:at
 org.mozilla.gecko.permissions.PermissionBlock.run(PermissionBlock.java:98)
 05-17 15:19:16.044  5623  5641 E AndroidRuntime:at
 org.mozilla.gecko.GeckoApplication.setImageAs(GeckoApplication.java:844)
 05-17 15:19:16.044  5623  5641 E AndroidRuntime:at
 org.mozilla.gecko.GeckoApplication.access$100(GeckoApplication.java:82)
 05-17 15:19:16.044  5623  5641 E AndroidRuntime:at
 
org.mozilla.gecko.GeckoApplication$EventListener.handleMessage(GeckoApplication.java:649)
 05-17 15:19:16.044  5623  5641 E AndroidRuntime:at
 org.mozilla.gecko.EventDispatcher$3.run(EventDispatcher.java:368)
 05-17 15:19:16.044  5623  5641 E AndroidRuntime:at
 android.os.Handler.handleCallback(Handler.java:873)
 05-17 15:19:16.044  5623  5641 E AndroidRuntime:at
 android.os.Handler.dispatchMessage(Handler.java:99)
 05-17 15:19:16.044  5623  5641 E AndroidRuntime:at
 android.os.Looper.loop(Looper.java:216)
 05-17 15:19:16.044  5623  5641 E AndroidRuntime:at
 org.mozilla.gecko.util.GeckoBackgroundThread.run(GeckoBackgroundThread.java:41)
 }}}

 Alternative way:
 1) Open and connect TBA
 2) Click "Donate Now"
 3) Long tap the logo
 4) Switch to the Image tab
 5) "Set As"
 6) See the `Unable to set image` message
 7) "Set As" again
 Result:

 {{{
 05-17 15:57:13.538 24022 24041 E AndroidRuntime: FATAL EXCEPTION:
 GeckoBackgroundThread
 05-17 15:57:13.538 24022 24041 E AndroidRuntime: Process:
 org.torproject.torbrowser_alpha, PID: 24022
 05-17 15:57:13.538 24022 24041 E AndroidRuntime:
 java.lang.NullPointerException: Attempt to invoke virtual method
 'java.lang.String java.net.InetAddress.toString()' on a null object
 reference
 05-17 15:57:13.538 24022 24041 E AndroidRuntime: 

Re: [tor-bugs] #30602 [Metrics/Library]: Extend TorperfResult to return parsed new PARTIAL* and ERRORCODE fields

2020-05-17 Thread Tor Bug Tracker & Wiki
#30602: Extend TorperfResult to return parsed new PARTIAL* and ERRORCODE fields
-+--
 Reporter:  karsten  |  Owner:  karsten
 Type:  enhancement  | Status:  accepted
 Priority:  Medium   |  Milestone:
Component:  Metrics/Library  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #29507   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * owner:  metrics-team => karsten
 * status:  assigned => accepted


Comment:

 Picking this up again.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33831 [Core Tor/sbws]: Relays without descriptors are not scaled, but still added to the bwlines without vote=0

2020-05-17 Thread Tor Bug Tracker & Wiki
#33831: Relays without descriptors are not scaled, but still added to the 
bwlines
without vote=0
-+-
 Reporter:  juga |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  sbws:
 |  1.1.x-final
Component:  Core Tor/sbws|Version:  sbws:
 |  1.1.0
 Severity:  Normal   | Resolution:
 Keywords:  sbws-roadmap, intro, |  Actual Points:
  GeorgKoppen202005  |
Parent ID:  #33121   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by juga):

 I think i'm going to need to change the logic on what to do when there is
 not descriptor observed bandwidth nor consensus bandwidth for #33871, so i
 think i'll implement this as part of that ticket.
 No need then to work on this ticket for now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33973 [Applications/Tor Browser]: Create fat .aar for geckoview

2020-05-17 Thread Tor Bug Tracker & Wiki
#33973: Create fat .aar for geckoview
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
-+-

Comment (by ahf):

 I have managed to build this branch now on two different machines.

 The only changes I have had to make so far are:

 {{{
 diff --git a/README b/README
 index 8e97e2f..2457f15 100644
 --- a/README
 +++ b/README
 @@ -198,7 +198,7 @@ builds, and will require that you run Debian Stretch
 and install build
  dependencies for all the components that are built. This can be done
  with the following command:

 -  # apt-get install build-essential python automake libtool zip unzip
 +  # apt-get install build-essential python automake libtool zip unzip \
  autoconf2.13 openjdk-8-jdk gettext-base autotools-dev \
  automake autoconf libtool autopoint libssl-dev \
  pkg-config zlib1g-dev libparallel-forkmanager-perl \
 diff --git a/projects/geckoview/config b/projects/geckoview/config
 index 63da289..ddab204 100644
 --- a/projects/geckoview/config
 +++ b/projects/geckoview/config
 @@ -93,6 +93,7 @@ steps:

  input_files:
- project: container-image
 +pkg_type: build
- name: '[% c("var/compiler") %]'
  project: '[% c("var/compiler") %]'
  pkg_type: build
 }}}

 Where the last part was from boklm and GeKo on IRC.

 From what I can tell with the code is that it seems reasonable. I am not
 sure what the common strategy is for when you review build-system
 components in the browser. In Tor we have all kinds of sanitizers from
 shellcheck that we run on shell-like scripts. The code looks fine to me,
 is easy to understand once the gist of rbm kicks in.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34240 [Internal Services/Tor Sysadmin Team]: Update Metrics CollecTor check to remove Torperf files

2020-05-17 Thread Tor Bug Tracker & Wiki
#34240: Update Metrics CollecTor check to remove Torperf files
-+-
 Reporter:  karsten  |  Owner:  tpa
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 We stopped archiving Torperf files in #34141, and now the check starts
 complaining about them not being recent anymore: `CRITICAL: Got a valid
 response from https://collector.torproject.org/index/index.json with at
 least one timestamp being critically outdated: /recent/torperf/ =
 2020-05-16 00:10 (33 = 30 + 3 hours ago)`

 I'm attaching a patch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34240 [Internal Services/Tor Sysadmin Team]: Update Metrics CollecTor check to remove Torperf files

2020-05-17 Thread Tor Bug Tracker & Wiki
#34240: Update Metrics CollecTor check to remove Torperf files
-+-
 Reporter:  karsten  |  Owner:  tpa
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by karsten):

 * status:  new => needs_review


Comment:

 Thanks in advance!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34240 [Internal Services/Tor Sysadmin Team]: Update Metrics CollecTor check to remove Torperf files

2020-05-17 Thread Tor Bug Tracker & Wiki
#34240: Update Metrics CollecTor check to remove Torperf files
-+-
 Reporter:  karsten  |  Owner:  tpa
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by karsten):

 * Attachment "0001-Update-Metrics-CollecTor-check-to-remove-Torperf-
 fil.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33434 [Metrics/Onionperf]: Allow users to select Onion Service version to measure

2020-05-17 Thread Tor Bug Tracker & Wiki
#33434: Allow users to select Onion Service version to measure
---+
 Reporter:  acute  |  Owner:  karsten
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID: | Points:  0.5
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * status:  accepted => needs_review
 * cc: dgoulet, asn (added)


Comment:

 While working on #34023 (for deciding whether we can use partial
 completion times instead of full completion times) I realized that I could
 use the same analysis data and code to compare version 2 to version 3
 measurement results for this ticket.

 And while doing that analysis I realized that we're currently doing 1/3 of
 all OnionPerf measurements to version 3 onion servers---which we're not
 even graphing on Tor Metrics. But even if we did graph them, we'd be
 making 2/3 of measurements to onion services and only 1/3 via exits.

 Can we take out v2 onion service support and only do v3 onion service
 measurements in the future? Please take a look at the following graph. It
 shows time to download 50 KiB, 1 MiB, and 5 MiB over Tor to its own web
 server (public server) or to its own v2 or v3 onion server.

 [[Image(onionperf-v2vsv3-2020-05-17.png, 700px)]]

 I didn't follow all the v3 onion server changes in detail. Is there any
 conceptual difference that might show up in these performance graphs? If
 it's mainly different crypto, shared randomness, and a differently
 distributed directory, we could expect the same performance results for
 downloading files using either version.

 What do you think? Should we just kill the version 2 measurements? And
 should we include all onion server measurements on Tor Metrics, regardless
 of version?

 Copying onion service people to also get their input here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33434 [Metrics/Onionperf]: Allow users to select Onion Service version to measure

2020-05-17 Thread Tor Bug Tracker & Wiki
#33434: Allow users to select Onion Service version to measure
---+
 Reporter:  acute  |  Owner:  karsten
 Type:  enhancement| Status:  accepted
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID: | Points:  0.5
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * Attachment "onionperf-v2vsv3-2020-05-17.png" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34239 [Metrics/CollecTor]: Release CollecTor 1.15.2

2020-05-17 Thread Tor Bug Tracker & Wiki
#34239: Release CollecTor 1.15.2
---+-
 Reporter:  karsten|  Owner:  karsten
 Type:  task   | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by karsten):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 Release: https://dist.torproject.org/collector/1.15.2/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34239 [Metrics/CollecTor]: Release CollecTor 1.15.2

2020-05-17 Thread Tor Bug Tracker & Wiki
#34239: Release CollecTor 1.15.2
---+--
 Reporter:  karsten|  Owner:  karsten
 Type:  task   | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor: |
---+--
 I need to put out CollecTor 1.15.2 today with an update to metrics-lib
 2.13.0 in order to archive OnionPerf's analysis results file format
 version 2.0.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs