Re: [tor-bugs] #15056 [Core Tor/Tor]: Support ed25519 identities for circuit extension

2016-11-11 Thread Tor Bug Tracker & Wiki 
#15056: Support ed25519 identities for circuit extension
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, ed25519, prop-220,|  Actual Points:
  027-triaged-1-in, 028-triaged, |
  201511-deferred, tor-crypto-identity, tor- |
  ed25519-proto, TorCoreTeam201609, nickm-   |
  deferred-20161005  |
Parent ID:  #15054   | Points:  parent
 Reviewer:   |Sponsor:
 |  SponsorU-must
-+-
Changes (by nickm):

 * status:  assigned => needs_review


Comment:

 This is now implemented, and I believe ready for review.  I'm going to be
 adding more unit tests on and off over the next week, but I think it's
 worth looking at.

 The branch is 'feature15056_v1' in my public repository.

 There is a gitlab merge request at
 https://gitlab.com/nickm_tor/tor/merge_requests/10

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15056 [Core Tor/Tor]: Support ed25519 identities for circuit extension

2016-11-28 Thread Tor Bug Tracker & Wiki 
#15056: Support ed25519 identities for circuit extension
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, ed25519, prop-220,|  Actual Points:
  027-triaged-1-in, 028-triaged, |
  201511-deferred, tor-crypto-identity, tor- |
  ed25519-proto, TorCoreTeam201609, nickm-   |
  deferred-20161005, review-group-12 |
Parent ID:  #15054   | Points:  parent
 Reviewer:  dgoulet  |Sponsor:
 |  SponsorU-must
-+-
Changes (by dgoulet):

 * reviewer:   => dgoulet


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15056 [Core Tor/Tor]: Support ed25519 identities for circuit extension

2016-12-05 Thread Tor Bug Tracker & Wiki 
#15056: Support ed25519 identities for circuit extension
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, ed25519, prop-220,|  Actual Points:
  027-triaged-1-in, 028-triaged, |
  201511-deferred, tor-crypto-identity, tor- |
  ed25519-proto, TorCoreTeam201609, nickm-   |
  deferred-20161005, review-group-13 |
Parent ID:  #15054   | Points:  parent
 Reviewer:  dgoulet  |Sponsor:
 |  SponsorU-must
-+-
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 Did a pass at it! Good work!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15056 [Core Tor/Tor]: Support ed25519 identities for circuit extension

2016-12-06 Thread Tor Bug Tracker & Wiki 
#15056: Support ed25519 identities for circuit extension
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, ed25519, prop-220,|  Actual Points:
  027-triaged-1-in, 028-triaged, |
  201511-deferred, tor-crypto-identity, tor- |
  ed25519-proto, TorCoreTeam201609, nickm-   |
  deferred-20161005, review-group-13 |
Parent ID:  #15054   | Points:  parent
 Reviewer:  dgoulet  |Sponsor:
 |  SponsorU-must
-+-

Comment (by dgoulet):

 Ok, did a second pass. I missed two files during initial review as Gitlab
 joyfully didn't expand them to me ... so not to myself and everyone, make
 sure to click the "Expand All" button before review!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15056 [Core Tor/Tor]: Support ed25519 identities for circuit extension

2016-12-07 Thread Tor Bug Tracker & Wiki 
#15056: Support ed25519 identities for circuit extension
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, ed25519, prop-220,|  Actual Points:
  027-triaged-1-in, 028-triaged, |
  201511-deferred, tor-crypto-identity, tor- |
  ed25519-proto, TorCoreTeam201609, nickm-   |
  deferred-20161005, review-group-13 |
Parent ID:  #15054   | Points:  parent
 Reviewer:  dgoulet  |Sponsor:
 |  SponsorU-must
-+-

Comment (by nickm):

 Okay, I think I've been over it all again, and added a little more fixing.
 How do you feel about it now?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15056 [Core Tor/Tor]: Support ed25519 identities for circuit extension

2016-12-08 Thread Tor Bug Tracker & Wiki 
#15056: Support ed25519 identities for circuit extension
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, ed25519, prop-220,|  Actual Points:
  027-triaged-1-in, 028-triaged, |
  201511-deferred, tor-crypto-identity, tor- |
  ed25519-proto, TorCoreTeam201609, nickm-   |
  deferred-20161005, review-group-13 |
Parent ID:  #15054   | Points:  parent
 Reviewer:  dgoulet  |Sponsor:
 |  SponsorU-must
-+-
Changes (by dgoulet):

 * status:  needs_revision => merge_ready


Comment:

 Fixup all lgtm! #20918 and #20895 have been opened to address some more
 engineering intensive improvement.

 My public relay has been running this for almost 3 days now with
 `ExtendByEd25519ID 1` on and so far it's happy. I've also tested this in
 chutney confirming that authentication is working with rsa and ed25519
 together.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15056 [Core Tor/Tor]: Support ed25519 identities for circuit extension

2016-12-08 Thread Tor Bug Tracker & Wiki 
#15056: Support ed25519 identities for circuit extension
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, ed25519, prop-220,|  Actual Points:
  027-triaged-1-in, 028-triaged, |
  201511-deferred, tor-crypto-identity, tor- |
  ed25519-proto, TorCoreTeam201609, nickm-   |
  deferred-20161005, review-group-13 |
Parent ID:  #15054   | Points:  parent
 Reviewer:  dgoulet  |Sponsor:
 |  SponsorU-must
-+-

Comment (by nickm):

 Okay. I've squashed the branch down to feature15056_v1_squashed. You can
 verify that it has the same contents as feature15056_v1, except with fewer
 commits in it.

 Merging that to master.

 Let's see what happens now!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15056 [Core Tor/Tor]: Support ed25519 identities for circuit extension

2016-12-08 Thread Tor Bug Tracker & Wiki 
#15056: Support ed25519 identities for circuit extension
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:  closed
 Priority:  High |  Milestone:  Tor:
 |  0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, ed25519, prop-220,|  implemented
  027-triaged-1-in, 028-triaged, |  Actual Points:
  201511-deferred, tor-crypto-identity, tor- |
  ed25519-proto, TorCoreTeam201609, nickm-   |
  deferred-20161005, review-group-13 |
Parent ID:  #15054   | Points:  parent
 Reviewer:  dgoulet  |Sponsor:
 |  SponsorU-must
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15056 [Core Tor/Tor]: Support ed25519 identities for circuit extension

2016-06-06 Thread Tor Bug Tracker & Wiki 
#15056: Support ed25519 identities for circuit extension
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 Priority:  High |  assigned
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.9.x-final
 Keywords:  tor-relay, ed25519, prop-220,|Version:  Tor:
  027-triaged-1-in, 028-triaged, |  0.2.7
  201511-deferred, tor-crypto-identity, tor- | Resolution:
  ed25519-proto  |  Actual Points:
Parent ID:  #15054   | Points:  parent
 Reviewer:   |Sponsor:
 |  SponsorU-must
-+-
Changes (by nickm):

 * points:  6 => parent
 * severity:   => Normal


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15056 [Core Tor/Tor]: Support ed25519 identities for circuit extension

2016-08-30 Thread Tor Bug Tracker & Wiki 
#15056: Support ed25519 identities for circuit extension
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, ed25519, prop-220,|  Actual Points:
  027-triaged-1-in, 028-triaged, |
  201511-deferred, tor-crypto-identity, tor- |
  ed25519-proto TorCoreTeam201609|
Parent ID:  #15054   | Points:  parent
 Reviewer:   |Sponsor:
 |  SponsorU-must
-+-
Changes (by nickm):

 * keywords:
 tor-relay, ed25519, prop-220, 027-triaged-1-in, 028-triaged,
 201511-deferred, tor-crypto-identity, tor-ed25519-proto
 =>
 tor-relay, ed25519, prop-220, 027-triaged-1-in, 028-triaged,
 201511-deferred, tor-crypto-identity, tor-ed25519-proto
 TorCoreTeam201609


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15056 [Core Tor/Tor]: Support ed25519 identities for circuit extension

2016-09-14 Thread Tor Bug Tracker & Wiki 
#15056: Support ed25519 identities for circuit extension
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, ed25519, prop-220,|  Actual Points:
  027-triaged-1-in, 028-triaged, |
  201511-deferred, tor-crypto-identity, tor- |
  ed25519-proto TorCoreTeam201609|
Parent ID:  #15054   | Points:  parent
 Reviewer:   |Sponsor:
 |  SponsorU-must
-+-

Comment (by nickm):

 I've started a branch here, as `15056_wip`, based on my #15055 branch.  So
 far, it should (mostly) send ed25519 identities in extend2 cells as
 appropriate.

 The accepting part will be a little harder.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15056 [Core Tor/Tor]: Support ed25519 identities for circuit extension

2016-09-14 Thread Tor Bug Tracker & Wiki 
#15056: Support ed25519 identities for circuit extension
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, ed25519, prop-220,|  Actual Points:
  027-triaged-1-in, 028-triaged, |
  201511-deferred, tor-crypto-identity, tor- |
  ed25519-proto TorCoreTeam201609|
Parent ID:  #15054   | Points:  parent
 Reviewer:   |Sponsor:
 |  SponsorU-must
-+-

Comment (by nickm):

 (I will rebase this branch a lot)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs