Re: [tor-bugs] #16426 [Metrics/Onionoo]: Add parse history for tarballs in archive directory

[Tor Bug Tracker & Wiki]

#16426: Add parse history for tarballs in archive directory
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  assigned
 Priority:  Low  |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * owner:   => metrics-team
 * status:  needs_review => assigned
 * severity:   => Normal


Comment:

 Please find
 [https://gitweb.torproject.org/user/karsten/onionoo.git/log/?h=task-16426
 my task-16426 branch] with an amended patch and another commit that fixes
 a bug that I found while testing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16426 [Metrics/Onionoo]: Add parse history for tarballs in archive directory

[Tor Bug Tracker & Wiki]

#16426: Add parse history for tarballs in archive directory
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  Low  |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16426 [Metrics/Onionoo]: Add parse history for tarballs in archive directory

[Tor Bug Tracker & Wiki]

#16426: Add parse history for tarballs in archive directory
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  Low  |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by iwakeh):

 Looks fine passes tests and checks.  Merge ready.

 I added some quick tweaks to things I noticed in the reviewed classes.
 Please review three more commits in
 [https://gitweb.torproject.org/user/iwakeh/onionoo.git?h=task-16426 my
 branch].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16426 [Metrics/Onionoo]: Add parse history for tarballs in archive directory

[Tor Bug Tracker & Wiki]

#16426: Add parse history for tarballs in archive directory
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  Low  |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by iwakeh):

 PS:  I assume we decided at some point to not add tests for the history
 tracking functionality?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16426 [Metrics/Onionoo]: Add parse history for tarballs in archive directory

[Tor Bug Tracker & Wiki]

#16426: Add parse history for tarballs in archive directory
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  closed
 Priority:  Low  |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Great, thanks for checking!  Merged together with your three commits.

 Regarding testing, I'd say we should rather replace the duplicate code for
 history tracking with functionality from metrics-lib than write tests for
 Onionoo.  But that's for another ticket/time.

 Closing.  Thanks again!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs