Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  iwakeh
 Type:  enhancement  | Status:  closed
 Priority:  Very High|  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---
Changes (by karsten):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Great! Renamed in a separate commit, squashed all fixup/squash commits in
 that branch, and pushed to master. I'd say this one is safe to be closed
 now. Closing. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  iwakeh
 Type:  enhancement  | Status:  merge_ready
 Priority:  Very High|  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---

Comment (by iwakeh):

 Replying to [comment:46 karsten]:
 > How about `mostRecentStatusMillis`?

 Perfect!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  iwakeh
 Type:  enhancement  | Status:  merge_ready
 Priority:  Very High|  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---

Comment (by karsten):

 How about `mostRecentStatusMillis`?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  iwakeh
 Type:  enhancement  | Status:  merge_ready
 Priority:  Very High|  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---

Comment (by iwakeh):

 The two commits are fine.  Could we use a more telling name for
 'retrieveLastSeenMillis', maybe 'retrieveLatestNetworkUpdateMillis' or
 else?  Also throughout replace 'lastSeenMillis' with something that
 indicates the usage better.  I don't really have a good naming idea
 though.

 Leaving this on 'merge ready'.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  iwakeh
 Type:  enhancement  | Status:  merge_ready
 Priority:  Very High|  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---

Comment (by karsten):

 I pushed two commits related to this branch to a branch that is under
 review for #24729. Those commits and comments there also ask the question
 above. Feel free to move that part of the discussion here, but I'm also
 happy to keep it there.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  iwakeh
 Type:  enhancement  | Status:  merge_ready
 Priority:  Very High|  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---

Comment (by iwakeh):

 Replying to [comment:42 karsten]:
 > Here's a possible improvement: how about we use the last consensus
 valid-after time or bridge network status publication timestamp

 > as timestamp

 Which timestamp in particular are you referring to?

 >rather than the last time we saw a specific relay or bridge? I think we
 called that "Tor time" on #25002. This would lead to a smaller `out/`
 directory, because we wouldn't write as detailed history files anymore for
 relays or bridges that are long gone. Does this make sense?

 Regardless, 'Tor time' makes sense, b/c it is a value from the network and
 not 'added' to the data.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  iwakeh
 Type:  enhancement  | Status:  merge_ready
 Priority:  Very High|  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---

Comment (by karsten):

 Here's a possible improvement: how about we use the last consensus valid-
 after time or bridge network status publication timestamp as timestamp
 rather than the last time we saw a specific relay or bridge? I think we
 called that "Tor time" on #25002. This would lead to a smaller `out/`
 directory, because we wouldn't write as detailed history files anymore for
 relays or bridges that are long gone. Does this make sense?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  iwakeh
 Type:  enhancement  | Status:  merge_ready
 Priority:  Very High|  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---

Comment (by karsten):

 Thanks for checking!

 Those three commits (87177e9, 638d895, and 6308c89) look good.

 Let's discuss deployment at today's meeting.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  iwakeh
 Type:  enhancement  | Status:  merge_ready
 Priority:  Very High|  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---
Changes (by iwakeh):

 * status:  accepted => merge_ready


Comment:

 The made changes look ok, although the new graph history compiler code is
 still not making much use the java.time classes.  But, changing it raises
 some questions about the calculations and would take too long for this
 ticket.  Thus, making a note later on the java8 ticket for Onionoo.

 The changes here and the upcoming changes in 25002 will make Onionooo
 distances independent of their local state as far as possible.

 The change here leads to identical 'out' directories when run with the
 same 'status' directory contents.  I have a few
 [https://gitweb.torproject.org/user/iwakeh/onionoo.git/log/?h=task-16513-2
 minor unrelated commits].

 Comparing the 'out' dir resulting from Onionoo-4.4-1.8.0 with the
 resulting 'out' from the new 5.0-1.9.0  can only be done manually.  So
 far, I think those differences are due to the changes here and thus
 intended, but that's hard to verify.  Maybe, make a copy of 'out' and
 'status' before deployment to have a rollback option in the unlikely case
 there are unwanted differences?

 In total: merge ready.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  iwakeh
 Type:  enhancement  | Status:  accepted
 Priority:  Very High|  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---
Changes (by karsten):

 * priority:  High => Very High


Comment:

 Raising priority of this ticket even more, because it's currently blocking
 #24729 which confuses a lot of relay operators and leads to repeated
 questions.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  iwakeh
 Type:  enhancement  | Status:  accepted
 Priority:  High |  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---

Comment (by iwakeh):

 Replying to [comment:37 karsten]:
 > Replying to [comment:36 iwakeh]:
 > > The list of exit_addresses is one more data item in onionoo's details
 documents that is depending on the current system time.  Depending on the
 current time the addresses are added or omitted to the stored collection
 (cf.
 
[https://gitweb.torproject.org/user/karsten/onionoo.git/tree/src/main/java/org/torproject/onionoo/updater/NodeDetailsStatusUpdater.java?h=task-16513-2#n805
 NodeDetailsStatusUpdater]).  Could the validAfter time of the latest
 consensus processed be a replacement for the system time?
 >
 > Yes. We should probably do that. I haven't tried it out yet, nor have I
 looked around for similar places where we're depending on system time
 there.
 >
 > However! That's a different issue. It's about making the '''update'''
 step less dependent on things like system time, though we won't be able to
 make it fully deterministic. Still a good thing to do. But it's different
 from making the '''write''' step deterministic where we're taking a
 `status/` directory as input and writing files to the `out/` directory.
 Should we collect this idea on a new ticket, like, "Make updating status
 files independent of system time"?

 Oh, I took this ticket as meaning 'Make results from Onionoo
 deterministic', but writing and updating are different concerns.  Will
 open a new ticket (rather with the meaning I perceived) and check for more
 issues in the update process while continuing the review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  iwakeh
 Type:  enhancement  | Status:  accepted
 Priority:  High |  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---

Comment (by karsten):

 Replying to [comment:36 iwakeh]:
 > The list of exit_addresses is one more data item in onionoo's details
 documents that is depending on the current system time.  Depending on the
 current time the addresses are added or omitted to the stored collection
 (cf.
 
[https://gitweb.torproject.org/user/karsten/onionoo.git/tree/src/main/java/org/torproject/onionoo/updater/NodeDetailsStatusUpdater.java?h=task-16513-2#n805
 NodeDetailsStatusUpdater]).  Could the validAfter time of the latest
 consensus processed be a replacement for the system time?

 Yes. We should probably do that. I haven't tried it out yet, nor have I
 looked around for similar places where we're depending on system time
 there.

 However! That's a different issue. It's about making the '''update''' step
 less dependent on things like system time, though we won't be able to make
 it fully deterministic. Still a good thing to do. But it's different from
 making the '''write''' step deterministic where we're taking a `status/`
 directory as input and writing files to the `out/` directory. Should we
 collect this idea on a new ticket, like, "Make updating status files
 independent of system time"?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  iwakeh
 Type:  enhancement  | Status:  accepted
 Priority:  High |  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---

Comment (by iwakeh):

 The list of exit_addresses is one more data item in onionoo's details
 documents that is depending on the current system time.  Depending on the
 current time the addresses are added or omitted to the stored collection
 (cf.
 
[https://gitweb.torproject.org/user/karsten/onionoo.git/tree/src/main/java/org/torproject/onionoo/updater/NodeDetailsStatusUpdater.java?h=task-16513-2#n805
 NodeDetailsStatusUpdater]).  Could the validAfter time of the currently
 processed consensus be a replacement for the system time?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  iwakeh
 Type:  enhancement  | Status:  accepted
 Priority:  High |  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---

Comment (by karsten):

 Thank you!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  iwakeh
 Type:  enhancement  | Status:  accepted
 Priority:  High |  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---
Changes (by iwakeh):

 * owner:  metrics-team => iwakeh
 * status:  needs_review => accepted


Comment:

 Sure, will run system tests and provide fixes, if necessary, as part of
 the review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  High |  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---
Changes (by karsten):

 * status:  merge_ready => needs_review


Comment:

 Thanks for checking. I just added one small (but important) fixup commit
 
([https://gitweb.torproject.org/user/karsten/onionoo.git/commit/?h=task-16513-2&id=c9157949039c6793c2bc36a10a3e561575b40530
 c915794]) and another big (and also important) refactoring commit
 
([https://gitweb.torproject.org/user/karsten/onionoo.git/commit/?h=task-16513-2&id=699d82613fcd20c5e7b29a6a1082a2d5058c1ab8
 699d826]) to my branch. That second commit reduces code duplication by a
 lot, which I think is an important step towards making this code more
 maintainable by other people than me in the future.

 However, I'm running out of time here. The new code is way better
 documented than usual, it compiles, checkstyle doesn't have complaints,
 and all tests pass, including new ones. But I can't spend another day on
 running system tests, and I do expect the output to be somewhat different
 from current output. But each difference needs investigation, and maybe
 the old output was wrong and the new output is right.

 iwakeh or maybe irl, can I ask either of you to take over here? Reviewing
 and testing this code is not a trivial task, and it will almost certainly
 take longer than a few hours. But I could imagine it's a good way to dive
 deeper into this part of Onionoo, and at the same time ensure that this
 code will be more readable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  merge_ready
 Priority:  High |  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---
Changes (by iwakeh):

 * status:  needs_review => merge_ready


Comment:

 All checks and tests pass; good to start using more java.time classes.
 Would it be possible to rename the one-letter variables in
 
[https://gitweb.torproject.org/user/karsten/onionoo.git/tree/src/main/java/org/torproject/onionoo/writer/BandwidthDocumentWriter.java?h=task-16513-2&id=1638b1b998f012077549dca5dfa97e527ba0#n100
 BandwidthDocumentWriter]; there are other places, too, but let's start
 slowly.
 Merge ready, when all system tests ran/are running fine.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  High |  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---

Comment (by iwakeh):

 Replying to [comment:30 karsten]:
 > Pushed one test.

 Cool, thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  High |  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---

Comment (by karsten):

 Pushed one test.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  High |  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---

Comment (by karsten):

 Replying to [comment:28 iwakeh]:
 > Replying to [comment:27 karsten]:
 > > Would you be able to review the last four commits in
 [https://gitweb.torproject.org/user/karsten/onionoo.git/log/?h=task-16513-2
 my updated task-16513-2 branch]? It contains several fixes from local
 tests with omeiense's `status/` directory.
 >
 > From skimming the commits:
 > Could you easily add simple tests for the comparison fix and the one-
 off-bug?  These will document clearly what is intended with the current
 code.

 Not easily, but I'll give it a try.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  High |  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---

Comment (by iwakeh):

 Replying to [comment:27 karsten]:
 > Would you be able to review the last four commits in
 [https://gitweb.torproject.org/user/karsten/onionoo.git/log/?h=task-16513-2
 my updated task-16513-2 branch]? It contains several fixes from local
 tests with omeiense's `status/` directory.

 From skimming the commits:
 Could you easily add simple tests for the comparison fix and the one-off-
 bug?  These will document clearly what is intended with the current code.

 >
 > I'm currently running another test for the last commit in that branch,
 and I'm considering a rewrite of the code that produces a graph history,
 so that we can reduce code duplication at least a bit. I'll see if that
 last part can be done within reasonable time, and if not, put it on hold
 again.

 Will take a closer look at all commits soon.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  High |  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---
Changes (by karsten):

 * status:  merge_ready => needs_review


Comment:

 Would you be able to review the last four commits in
 [https://gitweb.torproject.org/user/karsten/onionoo.git/log/?h=task-16513-2
 my updated task-16513-2 branch]? It contains several fixes from local
 tests with omeiense's `status/` directory.

 I'm currently running another test for the last commit in that branch, and
 I'm considering a rewrite of the code that produces a graph history, so
 that we can reduce code duplication at least a bit. I'll see if that last
 part can be done within reasonable time, and if not, put it on hold again.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  merge_ready
 Priority:  High |  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---

Comment (by iwakeh):

 There is #24870 for Onionoo's date-time changes.  Just leave the code here
 as is and do all changes together.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  merge_ready
 Priority:  High |  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---

Comment (by karsten):

 Hmm, or should we replace all those milliseconds in the code with Java 8
 date/time constructs all in a single step? I have to admit, I can't
 believe that that's the most elegant way of converting seven numbers into
 one number, yet you may be right. But I'd want to read up on Java 8 things
 first before changing things. (We do have a ticket for that, right?) Happy
 to add a ISO string what the long number means as a comment next to that
 line.

 System tests have not even begun. I'm still working on downloading the
 `status/` directory from omeiense...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  merge_ready
 Priority:  High |  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---
Changes (by iwakeh):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:23 karsten]:
 > I renamed `now` to `lastSeenMillis` in
 
[https://gitweb.torproject.org/user/karsten/onionoo.git/commit/?h=task-16513-2&id=27794f7a7500783cd4b8f47f857b5e59c3c3fe61
 commit 27794f7], and I realized that we'll have to make similar changes to
 updating status which I did in
 
[https://gitweb.torproject.org/user/karsten/onionoo.git/commit/?h=task-16513-2&id=7e99b95485529c6a1d22ef7ee0eff841a890a598
 commit 7e99b95]. Please take another look at least at that second commit.

 Good that you thought of this!
 When taking another look at the tests, I'd say it's time to start using
 new DateTime classes.  For example:
 {{{
 diff --git
 a/src/test/java/org/torproject/onionoo/docs/WeightsStatusTest.java
 b/src/test/java/org/torproject/onionoo/docs/WeightsStatusTest.java
 index e28f989..7169aaa 100644
 --- a/src/test/java/org/torproject/onionoo/docs/WeightsStatusTest.java
 +++ b/src/test/java/org/torproject/onionoo/docs/WeightsStatusTest.java
 @@ -9,6 +9,8 @@ import static org.junit.Assert.assertTrue;

  import org.junit.Test;

 +import java.time.ZoneOffset;
 +import java.time.LocalDateTime;
  import java.util.Arrays;
  import java.util.Map;
  import java.util.SortedMap;
 @@ -101,7 +103,8 @@ public class WeightsStatusTest {
  }
  assertEquals("history: ", correctHistory,
 mapToString(ws.getHistory()));
  assertEquals(correctLines.length, ws.getHistory().size());
 -ws.compressHistory(1515670935476L);
 +ws.compressHistory(LocalDateTime.of(2017, 01, 01, 7, 15, 0, 0)
 +.toInstant(ZoneOffset.UTC).toEpochMilli());
  assertEquals("found: " + mapToString(ws.getHistory()), 1,
  ws.getHistory().size());
  assertEquals("[143103240, 143104320] : [-1.0, 1.78279826E-4,
 "
 }}}

 This is a bit longer, but will make the tests more readable and it will be
 immediately obvious what timestamp is used in a test.  Maybe, start at
 least with the newly introduced tests here?


 >
 > Right now I'm downloading omeiense's `status/` and `out/` directories
 and will run a local Onionoo server for a few hours, just to be really
 sure that it's doing the right thing.

 Tests and checks pass.  Ready for merge when the system test succeeds.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  High |  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---
Changes (by karsten):

 * status:  merge_ready => needs_review


Comment:

 I renamed `now` to `lastSeenMillis` in
 
[https://gitweb.torproject.org/user/karsten/onionoo.git/commit/?h=task-16513-2&id=27794f7a7500783cd4b8f47f857b5e59c3c3fe61
 commit 27794f7], and I realized that we'll have to make similar changes to
 updating status which I did in
 
[https://gitweb.torproject.org/user/karsten/onionoo.git/commit/?h=task-16513-2&id=7e99b95485529c6a1d22ef7ee0eff841a890a598
 commit 7e99b95]. Please take another look at least at that second commit.

 Right now I'm downloading omeiense's `status/` and `out/` directories and
 will run a local Onionoo server for a few hours, just to be really sure
 that it's doing the right thing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  merge_ready
 Priority:  High |  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---

Comment (by karsten):

 Replying to [comment:21 iwakeh]:
 > All tests and checks pass and code looks ok.

 Awesome!

 > Shouldn't the new method parameter 'long now' (in various methods) be
 named differently to reflect the meaning of the milliseconds timestamp?
 Maybe 'long lastMeasurementMillis' or similar?

 Good point. Let's go with `lastSeenMillis` which is what we use in
 `NodeStatus`, too. I'll change that before merging.

 > How will the data be affected when deploying the fix?  The stored data
 timestamps might be more recent than the last seen value used in the new
 code.  Did you run system tests on a local instance?
 > This should be clarified before deployment, but the code is merge ready.

 I'll run another local test before merging. Once that's done, let's
 coordinate deployment as usual.

 Thanks for the review!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  merge_ready
 Priority:  High |  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---
Changes (by iwakeh):

 * status:  needs_review => merge_ready


Comment:

 All tests and checks pass and code looks ok.

 Shouldn't the new method parameter 'long now' (in various methods) be
 named differently to reflect the meaning of the milliseconds timestamp?
 Maybe 'long lastMeasurementMillis' or similar?

 How will the data be affected when deploying the fix?  The stored data
 timestamps might be more recent than the last seen value used in the new
 code.  Did you run system tests on a local instance?
 This should be clarified before deployment, but the code is merge ready.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  High |  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---

Comment (by iwakeh):

 Ah, tests work now; continuing review, thanks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  High |  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---
Changes (by karsten):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:18 iwakeh]:
 > Test failure:

 Uhm, yes. Please find the fixup commit that I just pushed to the same
 branch. (I changed that test a couple of times, and it looks like it ended
 up being in a mixed state at the end.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_revision
 Priority:  High |  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+
Changes (by iwakeh):

 * status:  needs_review => needs_revision


Comment:

 Test failure:
 {{{
 [junit] Testcase: testIgnoreFuture took 0.392 sec
 [junit] FAILED
 [junit] expected:<1> but was:<0>
 [junit] junit.framework.AssertionFailedError: expected:<1> but was:<0>
 [junit] at
 
org.torproject.onionoo.writer.BandwidthDocumentWriterTest.testIgnoreFuture(BandwidthDocumentWriterTest.java:74)
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  High |  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+---
Changes (by karsten):

 * status:  needs_revision => needs_review
 * priority:  Medium => High


Comment:

 Please review
 
[https://gitweb.torproject.org/user/karsten/onionoo.git/commit/?h=task-16513-2&id=0de5770187c292bfbb451fbfe796e00a9445c6f5
 commit 0de5770 in my task-16513-2 branch]. Setting priority to high,
 because I'd like to base my #24831 work on this branch (or a revised
 version of it), and it would be cool to move forward with that while
 having a possible plan in mind. (Thanks!)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+
Changes (by iwakeh):

 * severity:  Blocker => Normal


Comment:

 'blocker' seems not appropriate here. -> setting to 'normal'

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Blocker  | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 I'm going to revise my branch based on an idea I had yesterday related to
 #24831: let's use the time when we last saw a relay in a consensus (and a
 bridge in a status) to determine which graphs to produce. This has
 advantages over other approaches:
  - It does not depend on system time, which is what we're trying to
 resolve here.
  - It does not rely on statistics reported by the relay or bridge, which
 breaks if a relay or bridge has a broken clock, and which may lead to
 different documents (bandwidth, weights, etc.) showing somewhat different
 time periods.
 Branch follows, but I'll have to implement and test the idea first.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:  Onionoo-1.8.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Blocker  | Resolution:
 Keywords:  metrics-2017 |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---
Changes (by karsten):

 * status:  assigned => needs_review


Comment:

 I already gave this a try a few months ago, and yesterday I went through
 that code again and improved it quite a bit. I think it's ready for review
 now. Please take a careful look at
 [https://gitweb.torproject.org/user/karsten/onionoo.git/log/?h=task-16513
 my task-16513 branch].

 Note that I did ''not'' consider the
 [https://trac.torproject.org/projects/tor/ticket/16513#comment:1 two
 related thoughts stated above]. Those are not directly related to writing
 the files in `out/`. Still worth considering, but as part of another (new)
 ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  assigned
 Priority:  Medium   |  Milestone:  Onionoo-1.8.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Blocker  | Resolution:
 Keywords:  metrics-2017 |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---
Changes (by iwakeh):

 * milestone:  Onionoo-1.7.0 => Onionoo-1.8.0


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+---
 Reporter:  karsten  |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Onionoo-1.4.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Blocker  | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---
Changes (by iwakeh):

 * milestone:   => Onionoo-1.4.0


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory 
deterministic
-+
 Reporter:  karsten  |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Blocker  | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by iwakeh):

 * severity:   => Blocker


Comment:

 This includes comparing the various documents from different instances
 after deployment in order to find out if all is as 'deterministic' as
 expected.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs